[00:06:16] greg-g: I updated https://wikitech.wikimedia.org/wiki/Deployments#Week_of_February_10th with Flow's adjusted deploy and my guess at MaxSem's rescheduled Mobile deploy [00:07:54] (03PS6) 10TTO: Add $wgLocalInterwikis to handle multiple local prefixes [core] - 10https://gerrit.wikimedia.org/r/110162 [00:08:49] (03PS6) 10Aaron Schulz: Simplified Swift backend to use maxConns flag in MultiHttpClient [core] - 10https://gerrit.wikimedia.org/r/108152 [00:09:07] gwicke: just a rebase [00:09:19] (03CR) 10BryanDavis: "I think this should be reworded to be more descriptive of the problem and less Intel centric. See http://www.virtualbox.org/manual/ch10.ht" [vagrant] - 10https://gerrit.wikimedia.org/r/112800 (owner: 10Milimetric) [00:09:39] (03PS1) 10Prtksxna: Design Update * Hard shadows * Light border * Fast fadeOut animation * Typeface/Leading * Margin from images * Load popup sooner [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112827 [00:11:36] (03CR) 10GWicke: [C: 032] Simplified Swift backend to use maxConns flag in MultiHttpClient [core] - 10https://gerrit.wikimedia.org/r/108152 (owner: 10Aaron Schulz) [00:13:05] on my dev wiki, every time i touch a messages file, it rebuilds the whole localization cache next time i try to load a page, and it takes annoyingly long. is there any way to make it either not use the localization cache at all, or speed up rebuilding? [00:14:46] (03Merged) 10jenkins-bot: Simplified Swift backend to use maxConns flag in MultiHttpClient [core] - 10https://gerrit.wikimedia.org/r/108152 (owner: 10Aaron Schulz) [00:17:26] <^d> jackmcbarn: $wgLocalisationCacheConf is where you'll want to look. [00:17:35] <^d> There's a "Null" type that basically is no cache. [00:17:54] hmm, that should really be documented [00:18:38] <^d> Like https://www.mediawiki.org/wiki/Manual:$wgLocalisationCacheConf? [00:18:51] null isn't documented i mean [00:25:52] ^d: that gives me"[94306ad9] /core/index.php/Test Exception from line 468 of C:\xampp\htdocs\core\includes\cache\LocalisationCache.php: No localisation cache found for English. Please run maintenance/rebuildLocalisationCache.php." [00:26:21] spagewmf3: thanks man [00:27:24] (03CR) 10CSteipp: "It seems like from https://www.mail-archive.com/wikitech-l@lists.wikimedia.org/msg73695.html that pbkdf2 might be the best option as the d" [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [00:28:04] <^d> jackmcbarn: Bleh. You'll have to play with it. We do it in a couple of places in the installer & maintenance scripts--try using that as an example. [00:28:10] (03Abandoned) 10CSteipp: Add Whirlpool using the password api [core] - 10https://gerrit.wikimedia.org/r/110646 (owner: 10CSteipp) [00:28:15] gwicke: https://gerrit.wikimedia.org/r/#/c/110250/ is fairly small [00:29:17] (03CR) 10CSteipp: [V: 032] Get title from EditPage rather than $wgTitle [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/111478 (owner: 10Chad) [00:33:23] AaronSchulz, looking.. [00:34:58] bd808: Just need one help. Did the other part. Please see. http://fpaste.org/76317/13921652/ [00:37:14] (03CR) 10GWicke: [C: 032] MultiHttpClient tweaks [core] - 10https://gerrit.wikimedia.org/r/110250 (owner: 10Aaron Schulz) [00:37:51] (03CR) 10jenkins-bot: [V: 04-1] MultiHttpClient tweaks [core] - 10https://gerrit.wikimedia.org/r/110250 (owner: 10Aaron Schulz) [00:44:24] "$this->numRows" gives the total number of results for the query ? [00:44:47] bd808: Are you there? [00:47:09] zeek: I'm in and out. End of my work day :) [00:47:31] (03PS4) 10Aaron Schulz: Added concurrent HEAD request support for Swift [core] - 10https://gerrit.wikimedia.org/r/107759 [00:47:32] bd808: :( please see that last thing [00:48:11] its already hard to find you due to out 10 hour clock difference :| [00:50:34] zeek: This is the part where I admit to not knowing much about the code you are wandering around in. I have no idea what NumRows is in this context. My advice is to trace it back to where it comes from and figure out what it is. [00:51:18] ohh no... I wanted to show you this: http://fpaste.org/76317/13921652/ regarding the bug [00:51:23] bd808: ^ [00:52:22] zeek: Ah. You want a sanity check on the pagination logic. Looking... [00:52:47] Yeah and I added some comment add the end. Please look that too. :) [00:54:11] (03PS2) 10Aaron Schulz: MultiHttpClient tweaks [core] - 10https://gerrit.wikimedia.org/r/110250 [00:54:19] gwicke: rebased [00:55:05] AaronSchulz, was just reminded about the runMulti vs. just run thing.. [00:55:21] (03CR) 10GWicke: [C: 032] MultiHttpClient tweaks [core] - 10https://gerrit.wikimedia.org/r/110250 (owner: 10Aaron Schulz) [00:55:39] AaronSchulz, do you see a reason to keep them separate? [00:56:14] run() is more convenient for getting the response fields [00:56:31] zeek: I think your on the right track. Usually when you're showing a pagination gadget you want to show pages on both sides of the current page though. Like if you decide to display 9 links you'd show N-4 … N … N+4 where N is the current page. [00:56:47] yes fixed that too... one min [00:57:05] And of course adjust all of that when you are closer to one end of the range or the other [00:58:07] AaronSchulz: yeah, good point about the response [00:58:07] (03CR) 10CSteipp: [C: 032] "Working in my testing, seems reasonable." [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 (owner: 10Jackmcbarn) [00:58:10] (03Merged) 10jenkins-bot: Add an API action to test blacklisted URLs [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 (owner: 10Jackmcbarn) [00:58:17] one array less [00:58:31] although run could return the matching format depending on what was passed in [00:58:34] the single request case is fairly common [00:58:46] (03Merged) 10jenkins-bot: MultiHttpClient tweaks [core] - 10https://gerrit.wikimedia.org/r/110250 (owner: 10Aaron Schulz) [00:58:47] single request -> single response object [00:58:55] array of requests -> array of responses [00:59:34] might be too magical though [00:59:44] am a bit undecided.. [00:59:48] bd808: http://fpaste.org/76415/92166756/ [01:00:44] bd808: Just one thing remaining. To verify that page numbers do not exceed the total result. That is what I am not sure how to do. So i asked, did $this -> numRows fetched the total number of result rows? [01:02:01] zeek: I don't know the answer to that. :( And from what bawolff wrote on the bug that's likely the part that the current api doesn't report. [01:02:56] zeek: When you do find that magic number however you just need to clamp $endPage with it using min() in the same way you used max() on the start page [01:03:28] bd808: Well, while generating the next link it does somehow figure out when to show the next link and when not, in the current implementation. so there must be something.... : | [01:04:13] Or if you could tell me how to do a new query to the DB.. then I could get that magic num in minutes... :P [01:06:03] zeek: I think you need to trace the existing logic back to the sql layer and see what it gives. There is a magic trick in mysql `SQL_CALC_FOUND_ROWS` that will return the total result count for a limit+offset query but it's probably not portable. [01:07:34] bd808: Can to direct to me the exact file from where to begin looking for SQLs? [01:11:16] zeek: Start from includes/QueryPage.php and work your way back. I'm not trying to be obtuse; I actually don't know myself. You might need to find a concrete subclass of QueryPage too. [01:11:51] bd808: Ok cool. No issues. I'll try to figure it out. :) [01:11:57] zeek: QueryPage::reallyDoQuery() is probably where you need to concentrate [01:12:16] That seems to be where $res comes from [01:12:17] bd808: Thanks :) [01:14:46] (03PS1) 10EBernhardson: Basic test to demonstrate history bundling issue [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112830 [01:14:58] (03CR) 10jenkins-bot: [V: 04-1] Basic test to demonstrate history bundling issue [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112830 (owner: 10EBernhardson) [01:16:09] (03PS1) 10EBernhardson: Basic test to demonstrate history bundling issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112831 [01:16:20] (03CR) 10jenkins-bot: [V: 04-1] Basic test to demonstrate history bundling issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112831 (owner: 10EBernhardson) [01:16:23] (03Abandoned) 10EBernhardson: Basic test to demonstrate history bundling issue [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112830 (owner: 10EBernhardson) [01:16:37] (03CR) 10TTO: "recheck" [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO) [01:20:31] (03PS1) 10BryanDavis: Rearrange modules to make more sense [tools/scap] - 10https://gerrit.wikimedia.org/r/112832 [01:22:44] (03PS6) 10Physikerwelt: Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 [01:22:58] (03CR) 10jenkins-bot: [V: 04-1] Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [01:23:59] greg-g: greg-g: BTW, was the "Wed @ 14:00" slot for VE tomorrow or next week? [01:26:43] (03CR) 10BryanDavis: Convert scap-1 to python (032 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/112487 (owner: 10BryanDavis) [01:26:56] (03PS2) 10Matthias Mullie: Basic test to demonstrate history bundling issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112831 (owner: 10EBernhardson) [01:26:59] (03PS1) 10Matthias Mullie: Fix history timespans logic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112833 [01:28:43] (03CR) 10Physikerwelt: [C: 04-2] "OK. It's probably a bad idea to have the test generation tool in a seperate extension. Maybe it would be better to ad a maitenance script " [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [01:29:47] (03CR) 10Physikerwelt: "The main problem is... All this is pointless if the tests are not supported by Jenkins." [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [01:31:24] James_F: sorry, tomorrow if you want/can. [01:38:38] (03PS6) 10Physikerwelt: Differentiate missing texvccheck from missing texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/112589 [01:43:31] Krinkle, how long is ResourceLoaderGetConfigVars data cached? [01:44:02] (03PS2) 10Matthias Mullie: Fix history timespans logic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112833 [01:44:03] And do you know who it can be force-invalidated? [01:44:05] (03CR) 10jenkins-bot: [V: 04-1] Fix history timespans logic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112833 (owner: 10Matthias Mullie) [01:44:05] superm401: Part of the startup module, so whenever it is rebuild (5 minutes) [01:44:08] It has no invalidation logic [01:44:18] Krinkle, okay, thanks. [01:44:25] bd808: As far as i figured out, all the queries are being performed using reallyDoQuery and DoQuery functions. This is the way i found to get rows using SQL_CALC, but i dont think its possible using reallyDoQuery. http://stackoverflow.com/questions/186588/which-is-fastest-select-sql-calc-found-rows-from-table-or-select-count [01:44:28] superm401: If it doesn't rebuild, let me know, there is a known isuse. [01:44:52] Krinkle, no, it's just because I wanted to use it for something new in GettingStarted, but I want to think ahead about config changes. [01:44:56] 5 minute wait is fine, though. [01:47:04] (03CR) 10Physikerwelt: "It was a module before. now it's a role. In the I don't care about that. It would be optimal if the the install script would be a puppet m" [vagrant] - 10https://gerrit.wikimedia.org/r/112355 (owner: 10Physikerwelt) [01:48:44] zeek: This might be the sort of question where writing an email to wikitech-l would get you an answer or some good ideas to try. There are a lot of smart folks on that mailing list. Describe what you want to accomplish, the ideas you have and ask for feedback. [01:49:06] All right. [01:51:57] (03PS3) 10Matthias Mullie: Fix history timespans logic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112833 [01:52:00] (03CR) 10jenkins-bot: [V: 04-1] Fix history timespans logic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112833 (owner: 10Matthias Mullie) [01:58:42] (03PS4) 10Matthias Mullie: Fix history timespans logic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112833 [02:02:15] (03PS3) 10Matthias Mullie: Basic test to demonstrate history bundling issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112831 (owner: 10EBernhardson) [02:02:22] (03PS1) 10Krinkle: [WIP] resourceloader: Fix broken 'skinStyles' loop in file module getModifiedTime [core] - 10https://gerrit.wikimedia.org/r/112837 [02:11:37] (03PS4) 10BryanDavis: Convert scap-1 to python [tools/scap] - 10https://gerrit.wikimedia.org/r/112487 [02:11:46] side effects when parsing text (like Extension:Variables would cause) are bad, right? why is Extension:Cite okay then? [02:13:19] (03PS1) 10Mattflaschen: Avoid unnecessary network call if there are no categories [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/112838 [02:17:16] (03PS1) 10Luis Felipe Schenone: Bug fix and minor improvements [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/112839 [02:17:52] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] Bug fix and minor improvements [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/112839 (owner: 10Luis Felipe Schenone) [02:18:06] (03PS1) 10Matthias Mullie: restore should look at previour revision for correct value [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112840 [02:18:38] (03PS15) 10Parent5446: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 [02:18:50] (03CR) 10Parent5446: "PS15: Made PBKDF2 the default." [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [02:19:27] (03CR) 10jenkins-bot: [V: 04-1] Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [02:20:09] (03PS5) 10Aaron Schulz: Added concurrent HEAD request support for Swift [core] - 10https://gerrit.wikimedia.org/r/107759 [02:25:28] (03PS1) 10Luis Felipe Schenone: Removing wrong author [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/112841 [02:25:42] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] Removing wrong author [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/112841 (owner: 10Luis Felipe Schenone) [02:29:13] (03CR) 10DarTar: "This is a good starting point to get cross-wiki edit data." [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/94516 (owner: 10Adamw) [02:30:24] (03PS5) 10Spage: Fix history timespans logic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112833 (owner: 10Matthias Mullie) [02:35:23] greg-g: Thanks, we can! [02:39:54] spagewmf_, you've got some uncommitted Flow changes in the git repo. [02:40:00] The config one. [02:44:38] (03PS3) 10Matthias Mullie: Tests for PostRevisionable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112797 [02:44:48] (03CR) 10jenkins-bot: [V: 04-1] Tests for PostRevisionable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112797 (owner: 10Matthias Mullie) [02:48:10] (03PS1) 10Matthias Mullie: Test permissions on multiple revisions in 1 object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112844 [02:48:21] (03CR) 10jenkins-bot: [V: 04-1] Test permissions on multiple revisions in 1 object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112844 (owner: 10Matthias Mullie) [02:51:44] (03PS2) 10Matthias Mullie: Fix typo that leads to fatal in unused code-path [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112713 [03:07:29] gwicke: ok, https://gerrit.wikimedia.org/r/#/c/107759/ is the last of those change in that area [03:08:30] (03PS6) 10Aaron Schulz: Added concurrent HEAD request support for Swift [core] - 10https://gerrit.wikimedia.org/r/107759 [03:10:50] (03PS4) 10EBernhardson: Basic test to demonstrate history bundling issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112831 [03:11:03] (03CR) 10jenkins-bot: [V: 04-1] Basic test to demonstrate history bundling issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112831 (owner: 10EBernhardson) [03:14:16] (03PS5) 10EBernhardson: Basic test to demonstrate history bundling issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112831 [03:14:26] (03CR) 10jenkins-bot: [V: 04-1] Basic test to demonstrate history bundling issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112831 (owner: 10EBernhardson) [03:29:19] (03PS6) 10Matthias Mullie: Basic test to demonstrate history bundling issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112831 (owner: 10EBernhardson) [03:29:28] (03CR) 10jenkins-bot: [V: 04-1] Basic test to demonstrate history bundling issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112831 (owner: 10EBernhardson) [03:35:40] (03PS7) 10EBernhardson: Basic test to demonstrate history bundling issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112831 [03:51:36] (03CR) 10EBernhardson: "To do these tests properly we need to be able to tell it when 'now' is, so we can test things like today being entirely within the last 4 " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112831 (owner: 10EBernhardson) [04:06:42] (03CR) 10EBernhardson: [C: 032] Fix history timespans logic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112833 (owner: 10Matthias Mullie) [04:06:52] (03CR) 10EBernhardson: [C: 032] Basic test to demonstrate history bundling issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112831 (owner: 10EBernhardson) [04:06:56] (03Merged) 10jenkins-bot: Fix history timespans logic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112833 (owner: 10Matthias Mullie) [04:07:04] (03CR) 10jenkins-bot: [V: 04-1] Basic test to demonstrate history bundling issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112831 (owner: 10EBernhardson) [04:20:13] (03PS4) 10Prtksxna: [WIP] Add EventLogging [WIP] [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112661 [04:21:29] (03CR) 10Isarra: "'Actions' is probably fine for the label, just reads a bit strange and looks a bit odd because it's longer than any of the default content" [core] - 10https://gerrit.wikimedia.org/r/112236 (owner: 10Bartosz Dziewoński) [04:34:22] (03PS1) 10EBernhardson: No need to load workflow in RC Formatter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112846 [05:37:32] (03PS8) 10EBernhardson: Basic test to demonstrate history bundling issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112831 [05:40:32] (03CR) 10MZMcBride: "Likely related: bug 61252" [core] - 10https://gerrit.wikimedia.org/r/110869 (owner: 10Alex Monk) [05:45:06] (03PS1) 10Legoktm: Only call ->clearInstanceCache() if $targetUser instanceof User [core] - 10https://gerrit.wikimedia.org/r/112847 [05:57:07] (03CR) 10Aaron Schulz: Add a PSR-3 based logging interface. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [05:59:30] (03CR) 10Tim Starling: [C: 032] Only call ->clearInstanceCache() if $targetUser instanceof User [core] - 10https://gerrit.wikimedia.org/r/112847 (owner: 10Legoktm) [06:00:28] (03PS1) 10Tim Starling: Only call ->clearInstanceCache() if $targetUser instanceof User [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112848 [06:00:46] (03CR) 10Tim Starling: [C: 032] Only call ->clearInstanceCache() if $targetUser instanceof User [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112848 (owner: 10Tim Starling) [06:03:48] (03Merged) 10jenkins-bot: Only call ->clearInstanceCache() if $targetUser instanceof User [core] - 10https://gerrit.wikimedia.org/r/112847 (owner: 10Legoktm) [06:04:43] (03Merged) 10jenkins-bot: Only call ->clearInstanceCache() if $targetUser instanceof User [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112848 (owner: 10Tim Starling) [06:14:23] (03PS1) 10Aaron Schulz: Fixed broken auth caching for Swift [core] - 10https://gerrit.wikimedia.org/r/112849 [06:15:07] (03PS1) 10Aaron Schulz: Fixed broken auth caching for Swift [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112851 [06:16:00] TimStarling: ^ one line fix [06:18:32] time to review is not exactly linear in the number of lines, you know [06:20:36] yeah, but the odds are usually better if it's one line [06:21:59] there's only 1 or 2 cache keys for all wikis, right? [06:22:16] I would hate to merge this and have the whole site instantly go down [06:23:17] oh right, wfMemcKey() [06:23:44] so at least 880 keys [06:24:07] 3 per wiki [06:25:04] you know apc.user_entries_hint is 4096 [06:25:31] just thinking about that deadlock on mw1184 [06:25:50] the processes were stuck in APCBagOStuff you know [06:25:53] really it could use the FileBackend wikiId...which would cut it down to a third [06:27:15] technically we only need one per server...one would just need a way to convey that properly [06:27:19] apc.shm_size is probably too small [06:27:52] in any case this was in production for a long time, it was broken in the last few weeks [06:27:52] apc.user_entries_hint probably is too, but that doesn't cause deadlocks when it is exceeded [06:29:24] I'll make a follow-up patch to switch the wiki ID part of the key to the swiftAuthUrl...that would be 1 key/box [06:29:36] well, still 3 with backend name...but that's OK [06:29:46] (03PS2) 10Aaron Schulz: Fixed broken auth caching for Swift [core] - 10https://gerrit.wikimedia.org/r/112849 [06:29:51] (03CR) 10Tim Starling: [C: 032] Fixed broken auth caching for Swift [core] - 10https://gerrit.wikimedia.org/r/112849 (owner: 10Aaron Schulz) [06:30:01] (03PS5) 10Prtksxna: [WIP] Add EventLogging [WIP] [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112661 [06:30:42] I don't really have time to deploy it now, I'm about to go for dinner [06:33:58] (03Merged) 10jenkins-bot: Fixed broken auth caching for Swift [core] - 10https://gerrit.wikimedia.org/r/112849 (owner: 10Aaron Schulz) [06:37:34] (03PS1) 10TTO: Fix some omitted colons in Spanish magic word l10n [core] - 10https://gerrit.wikimedia.org/r/112852 [06:39:10] (03CR) 10Tpt: [C: 04-1] "Hi! Thanks a lot for this change." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/112806 (owner: 10Xelgen) [06:39:27] (03PS1) 10Aaron Schulz: Reduce the amount of Swift auth cache keys used on wiki farms [core] - 10https://gerrit.wikimedia.org/r/112853 [06:39:36] TimStarling: at dinner yet? [06:39:49] no [06:40:17] (03PS1) 10Aaron Schulz: Reduce the amount of Swift auth cache keys used on wiki farms [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112854 [06:40:47] (03CR) 10Nikerabbit: "Please make sure that translatewiki.net does not have the old values which would override these on next export." [core] - 10https://gerrit.wikimedia.org/r/112852 (owner: 10TTO) [06:48:25] * AaronSchulz wonders if ori is up [06:49:27] what's up? [06:49:34] you are :-P [06:50:29] ori: https://gerrit.wikimedia.org/r/112853 [06:53:41] hi apergos [06:53:47] morning [06:59:10] AaronSchulz: why not md5( $this->swiftAuthUrl . $username ) ? [06:59:31] then you don't have to worry about sanitizing the key [06:59:47] is there debug value to have the username present as plaintext? [06:59:58] * in having [07:00:24] doesn't really matter either way [07:02:15] do you mind if I change it to: return 'swiftcredentials:' . md5( $username . $this->swiftAuthUrl ); [07:03:34] ^ AaronSchulz [07:03:37] if there a colon between username and auth URL that works [07:07:13] (03PS2) 10Ori.livneh: Reduce the amount of Swift auth cache keys used on wiki farms [core] - 10https://gerrit.wikimedia.org/r/112853 (owner: 10Aaron Schulz) [07:07:22] (03PS3) 10Aaron Schulz: Reduce the amount of Swift auth cache keys used on wiki farms [core] - 10https://gerrit.wikimedia.org/r/112853 [07:07:39] cool? [07:07:58] (03CR) 10TTO: "Done, thanks." [core] - 10https://gerrit.wikimedia.org/r/112852 (owner: 10TTO) [07:10:09] AaronSchulz: ^ [07:10:20] * ori wonders why Jenkins is not on it. [07:10:59] (03CR) 10TTO: "By the way, is it possible to view diffs of AdvancedTranslate data on TWN?" [core] - 10https://gerrit.wikimedia.org/r/112852 (owner: 10TTO) [07:11:15] looks fine [07:11:23] (03CR) 10Aaron Schulz: [C: 031] Reduce the amount of Swift auth cache keys used on wiki farms [core] - 10https://gerrit.wikimedia.org/r/112853 (owner: 10Aaron Schulz) [07:11:31] (03CR) 10Ori.livneh: [C: 032] Reduce the amount of Swift auth cache keys used on wiki farms [core] - 10https://gerrit.wikimedia.org/r/112853 (owner: 10Aaron Schulz) [07:12:01] (03CR) 10Aaron Schulz: [C: 032] Fixed broken auth caching for Swift [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112851 (owner: 10Aaron Schulz) [07:12:15] (03Abandoned) 10Aaron Schulz: Reduce the amount of Swift auth cache keys used on wiki farms [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112854 (owner: 10Aaron Schulz) [07:13:20] (03PS1) 10Aaron Schulz: Reduce the amount of Swift auth cache keys used on wiki farms [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112856 [07:13:39] (03CR) 10Aaron Schulz: [C: 032] Reduce the amount of Swift auth cache keys used on wiki farms [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112856 (owner: 10Aaron Schulz) [07:14:32] ori: btw I rebased https://gerrit.wikimedia.org/r/#/c/102361/ [07:14:52] (03Merged) 10jenkins-bot: Reduce the amount of Swift auth cache keys used on wiki farms [core] - 10https://gerrit.wikimedia.org/r/112853 (owner: 10Aaron Schulz) [07:15:34] AaronSchulz: are you deploying the swift patches? would you like me to hang around? [07:16:06] (03Merged) 10jenkins-bot: Fixed broken auth caching for Swift [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112851 (owner: 10Aaron Schulz) [07:16:26] if you want [07:17:21] i was hoping to get some late thai food but i can wait [07:17:46] (03Merged) 10jenkins-bot: Reduce the amount of Swift auth cache keys used on wiki farms [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112856 (owner: 10Aaron Schulz) [07:18:11] I'm testing the handleError() patch [07:18:14] (03CR) 10TTO: "recheck" [core] - 10https://gerrit.wikimedia.org/r/112852 (owner: 10TTO) [07:24:51] (03PS1) 10Ori.livneh: Add .gitreview [skins/Splash] - 10https://gerrit.wikimedia.org/r/112857 [07:25:49] Isarra: https://asciinema.org/a/7586 [07:28:28] hi i am gsoc aspirant. please someone guide me ? [07:29:34] (03PS4) 10Aaron Schulz: Added simpler handleError() method in RedisConnectionPool [core] - 10https://gerrit.wikimedia.org/r/102361 [07:29:38] (03CR) 10Ori.livneh: [C: 032] Added simpler handleError() method in RedisConnectionPool [core] - 10https://gerrit.wikimedia.org/r/102361 (owner: 10Aaron Schulz) [07:30:26] (03CR) 10Ori.livneh: [C: 032 V: 032] Add .gitreview [skins/Splash] - 10https://gerrit.wikimedia.org/r/112857 (owner: 10Ori.livneh) [07:30:51] ori: Neat. [07:31:45] Thanks. [07:33:13] :) yw [07:33:37] Now how do I.. do stuff... [07:33:45] (03Merged) 10jenkins-bot: Added simpler handleError() method in RedisConnectionPool [core] - 10https://gerrit.wikimedia.org/r/102361 (owner: 10Aaron Schulz) [07:34:01] you can clone it now [07:34:06] since it actually has contents [07:34:14] namely, the commit that added the .gitreview file [07:36:07] And now I can dump in the pile of stuff and this time it'll actually work? [07:36:40] karan1: welcome! https://www.mediawiki.org/wiki/Summer_of_Code_2014 and https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker are good places to start. and in general, specific questions get answered quicker! [07:37:21] Isarra: probably [07:37:28] * ori leaves for real [07:37:43] Excellent answer. [07:39:36] (03PS1) 10Spage: Specify which Actions menu, Topic or Post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112858 [07:42:03] (03CR) 10Yuvipanda: [C: 032 V: 032] "Looks like design tweaks to me :)" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112827 (owner: 10Prtksxna) [07:54:01] (03PS1) 10Isarra: Initial pile of skin [skins/Splash] - 10https://gerrit.wikimedia.org/r/112859 [08:00:52] (03PS2) 10Isarra: Initial pile of skin [skins/Splash] - 10https://gerrit.wikimedia.org/r/112859 [08:02:10] (03CR) 10Isarra: [C: 032 V: 032] Initial pile of skin [skins/Splash] - 10https://gerrit.wikimedia.org/r/112859 (owner: 10Isarra) [08:19:25] (03CR) 10Nemo bis: "https://translatewiki.net/wiki/Special:PrefixIndex/MediaWiki:Sp-translate" [core] - 10https://gerrit.wikimedia.org/r/112852 (owner: 10TTO) [08:24:59] (03PS1) 10Isarra: Add external link icons from Vector [skins/Splash] - 10https://gerrit.wikimedia.org/r/112860 [09:02:16] (03PS1) 10Amire80: Fix message grammar [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/112864 [09:21:28] (03PS1) 10Amire80: Improve the clarity of the no-xml-element-found message [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/112865 [09:27:22] (03PS1) 10AndyRussG: Prevent deletion of institutions with courses [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/112866 [09:27:32] (03CR) 10jenkins-bot: [V: 04-1] Prevent deletion of institutions with courses [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/112866 (owner: 10AndyRussG) [09:38:19] (03PS2) 10AndyRussG: Prevent deletion of institutions with courses [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/112866 [09:38:26] (03CR) 10jenkins-bot: [V: 04-1] Prevent deletion of institutions with courses [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/112866 (owner: 10AndyRussG) [09:41:22] (03CR) 10AndyRussG: "Something's fishy with JSLint..." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/112866 (owner: 10AndyRussG) [09:42:01] (03PS1) 10Amire80: Add gender support for gwtoolset-step-1-instructions-2 [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/112867 [10:11:55] (03CR) 10Siebrand: [C: 032] Add gender support for gwtoolset-step-1-instructions-2 [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/112867 (owner: 10Amire80) [10:11:59] (03Merged) 10jenkins-bot: Add gender support for gwtoolset-step-1-instructions-2 [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/112867 (owner: 10Amire80) [10:13:26] (03CR) 10Siebrand: Prevent deletion of institutions with courses (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/112866 (owner: 10AndyRussG) [10:20:44] (03PS1) 10Hashar: browsertests: replace -p ciwmf with --tags @clean [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112869 [10:21:14] (03CR) 10Hashar: [C: 032] browsertests: replace -p ciwmf with --tags @clean [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112869 (owner: 10Hashar) [10:21:31] (03Merged) 10jenkins-bot: browsertests: replace -p ciwmf with --tags @clean [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112869 (owner: 10Hashar) [10:24:09] (03PS24) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 [10:24:26] (03CR) 10Amire80: [C: 032] "Thank you, Xelgen!" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/112817 (owner: 10Xelgen) [10:24:28] (03CR) 10Hashar: "rebased" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 (owner: 10Hashar) [10:24:33] (03Merged) 10jenkins-bot: Adding Armenian icons for formatting buttons [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/112817 (owner: 10Xelgen) [10:43:22] (03CR) 10Phuedx: "Mattflaschen: this is now unblocked, right?" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111262 (owner: 10Mattflaschen) [11:06:24] (03PS1) 10Hashar: Firefox based browser tests jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112873 [11:08:26] (03CR) 10Hashar: [C: 032] Firefox based browser tests jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112873 (owner: 10Hashar) [11:08:42] (03Merged) 10jenkins-bot: Firefox based browser tests jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112873 (owner: 10Hashar) [11:12:57] (03PS1) 10Hashar: Tag anon rowser tests with @clean [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112874 [11:13:01] (03PS1) 10Physikerwelt: add gitreview file [services/mathoid] - 10https://gerrit.wikimedia.org/r/112875 [11:13:21] (03PS2) 10Physikerwelt: add gitreview file [services/mathoid] - 10https://gerrit.wikimedia.org/r/112875 [11:13:40] (03CR) 10Physikerwelt: [C: 031] add gitreview file [services/mathoid] - 10https://gerrit.wikimedia.org/r/112875 (owner: 10Physikerwelt) [11:15:59] (03PS3) 10Pastakhov: add maximum number of allowed loops [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/112680 [11:18:47] (03PS2) 10Hashar: Tag browser tests with @clean [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112874 [11:18:51] (03PS3) 10Physikerwelt: add gitreview file [services/mathoid] - 10https://gerrit.wikimedia.org/r/112875 [11:20:25] (03CR) 10Hashar: "phantomjs test: http://integration.wikimedia.org/ci/job/mwext-browsertests-Flow-phantomjs/4/console" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112874 (owner: 10Hashar) [11:23:35] (03PS4) 10Pastakhov: add maximum number of allowed loops [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/112680 [11:24:42] (03PS3) 10Hashar: Tag browser tests with @clean [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112874 [11:34:51] (03PS1) 10Physikerwelt: Change default mathoid port to 10042 [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/112878 [11:36:06] (03CR) 10Physikerwelt: [C: 032] "Tests: 57, Assertions: 54, Skipped: 26. arg" [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/112878 (owner: 10Physikerwelt) [11:36:13] (03Merged) 10jenkins-bot: Change default mathoid port to 10042 [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/112878 (owner: 10Physikerwelt) [11:50:43] (03PS1) 10Phuedx: Delay showing the task toolbar after Visual Editor edit [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/112880 [12:01:46] (03CR) 10Phuedx: [C: 032] Remove foreachwiki_populate_categories.php [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/112746 (owner: 10Mattflaschen) [12:01:48] (03Merged) 10jenkins-bot: Remove foreachwiki_populate_categories.php [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/112746 (owner: 10Mattflaschen) [12:09:57] (03CR) 10Phuedx: [C: 032] Remove English Wikipedia-specific categories. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/112748 (owner: 10Mattflaschen) [12:10:00] (03Merged) 10jenkins-bot: Remove English Wikipedia-specific categories. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/112748 (owner: 10Mattflaschen) [12:11:43] (03CR) 10Phuedx: [C: 032] Add extension authors [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/112749 (owner: 10Mattflaschen) [12:11:45] (03Merged) 10jenkins-bot: Add extension authors [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/112749 (owner: 10Mattflaschen) [12:36:35] (03PS1) 10Physikerwelt: fix: wrong port numer in last commit [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/112882 [12:37:04] (03CR) 10Physikerwelt: [V: 032] fix: wrong port numer in last commit [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/112882 (owner: 10Physikerwelt) [12:37:14] (03CR) 10Physikerwelt: [C: 032] fix: wrong port numer in last commit [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/112882 (owner: 10Physikerwelt) [12:37:21] (03Merged) 10jenkins-bot: fix: wrong port numer in last commit [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/112882 (owner: 10Physikerwelt) [12:46:17] prtksxna: have you seen https://en.wikipedia.org/wiki/Wikipedia:Unsolicited_redesigns [13:16:39] YuviPanda: I was looking at this http://weare1910.com/sites/default/files/project/wikipedia_new_desktop_full.jpg a moment ago. :D [13:17:25] Niharika: :D yeah, I was having a discussion about that in ##design, and pointed those people to the 'Unsolicited design's page :) [13:17:50] #design is the design channel? [13:18:06] Or ##design? [13:18:08] Niharika: it's not wikimedia specific. just 'general' [13:18:09] ##design [13:18:18] Niharika: there's also #wikimedia-design but only prtksxna is active there :D [13:18:37] YuviPanda: Okay. [13:20:31] I was asking around this morning if hiding the sidebar would be a good design idea for wikimedia. [13:20:40] eeek [13:21:21] Niharika: mobile already does it. [13:21:31] Niharika: have you seen http://unicorn.wmflabs.org/winter/ [13:21:46] * YuviPanda hotpatches code to hide *just* Nemo_bis's sidebar [13:23:08] YuviPanda: Looks good. Fixed header looks nice. [13:23:26] Nemo_bis: What do you have to say about http://weare1910.com/sites/default/files/project/wikipedia_new_desktop_full.jpg ? [13:23:30] Niharika: :) There's a 'give feedback' link on the sidebar. You should perhaps go have some [13:23:35] I'm not clicking that link [13:23:41] Okay. [13:25:09] Niharika: 'tis ok, lots of people are overly attached to what they are used to :) [13:25:23] Niharika: making even smallish changes in the UI draws plenty of 'criticism'. [13:25:27] Niharika: don't worry about it too much [13:25:30] Niharika: how's OPW going? [13:26:36] YuviPanda: Just one final hurdle remains. The BetaFeatures extension is somehow broken on my wiki. [13:26:49] I´m planning to reinstall it. [13:27:56] Niharika: ah! good luck :) [13:28:05] Thanks. :) [13:32:57] isn't it the worst when your code works but only on other peoples' computers? :D [13:33:31] brion: heh, yeah, happened to me with those tests :P [13:33:41] hehe [13:44:15] (03PS25) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 [13:44:22] (03CR) 10Hashar: "rebased" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 (owner: 10Hashar) [13:47:30] (03PS1) 10Hashar: browsertest: make log dir writable by all [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112890 [13:47:33] (03PS1) 10Hashar: browsertest: fix up whitespace in LocalSettings.php [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112891 [13:47:39] (03CR) 10Hashar: [C: 032] browsertest: make log dir writable by all [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112890 (owner: 10Hashar) [13:47:44] (03CR) 10Hashar: [C: 032] browsertest: fix up whitespace in LocalSettings.php [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112891 (owner: 10Hashar) [13:48:20] (03Merged) 10jenkins-bot: browsertest: make log dir writable by all [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112890 (owner: 10Hashar) [13:48:35] (03Merged) 10jenkins-bot: browsertest: fix up whitespace in LocalSettings.php [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112891 (owner: 10Hashar) [13:50:32] (03PS26) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 [14:14:08] (03PS10) 10Prtksxna: Add time ago in words at the bottom of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 [14:14:48] prtksxna: https://chicken.wmflabs.org [14:32:58] (03PS2) 10Milimetric: Add a note about hardware virtualization [vagrant] - 10https://gerrit.wikimedia.org/r/112800 [14:44:55] hi zeljkof are you around? We had some more builds with errors overnight [14:45:42] chrismcmahon: I am here [14:46:24] (03PS21) 10Prtksxna: Add Triangle/Pokey to the NavigationPopups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111773 [14:47:54] zeljkof: join the #wikimedia-qa channel? [14:48:14] chrismcmahon: I am already there [14:52:07] prtksxna: https://wikitech.wikimedia.org/wiki/Help:Access [14:55:28] (03CR) 10Aklapper: "We will get the patch for https://bugzilla.wikimedia.org/show_bug.cgi?id=59889 in first later today (to enable the "Saved Reports" feature" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106757 (owner: 1001tonythomas) [14:56:31] (03PS1) 10Zfilipin: WIP Moved tests from browsertests repository [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112895 [15:04:47] is this bug already solved https://bugzilla.wikimedia.org/show_bug.cgi?id=57821 ? [15:05:28] what does status unconfirmed mean? [15:06:40] jme: that nobody has looked at it yet. [15:07:00] ...or at least nobody has decided what to do about it. [15:07:30] "unconfirmed" is not really different from "new", don'tr worry about it. We don't really use that distinction [15:08:14] prtksxna: export SUDO_DEBUG=0 [15:10:20] prtksxna: export SUDOERS_DEBUG=1 [15:10:21] prtksxna: export SUDOERS_DEBUG=0 [15:10:39] DanielK_WMDE_: did you give a look to the bug? [15:11:33] (03CR) 10Anomie: Add $wgLocalInterwikis to handle multiple local prefixes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO) [15:11:41] DanielK_WMDE_: to me it doesn't seem to be a bug at all . see this http://tinyurl.com/kkwt62v . [15:11:42] (03CR) 10Anomie: Add $wgLocalInterwikis to handle multiple local prefixes (033 comments) [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO) [15:14:11] YuviPanda: https://gerrit.wikimedia.org/r/#/c/112661/ [15:15:53] YuviPanda: https://meta.wikimedia.org/wiki/Schema:Popups [15:18:52] (03PS8) 10Umherirrender: Add llprop=langname and llprop=autonym for action=query&prop=langlinks [core] - 10https://gerrit.wikimedia.org/r/112245 [15:18:58] (03CR) 10Anomie: [C: 032] Add llprop=langname and llprop=autonym for action=query&prop=langlinks [core] - 10https://gerrit.wikimedia.org/r/112245 (owner: 10Umherirrender) [15:19:45] (03CR) 10Anomie: [C: 032] New hook MessageCache::get [core] - 10https://gerrit.wikimedia.org/r/98078 (owner: 10Nikerabbit) [15:20:09] YuviPanda: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/javascripts/loggingSchemas/MobileWebClickTracking.js [15:21:45] YuviPanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=52287 [15:23:14] (03Merged) 10jenkins-bot: Add llprop=langname and llprop=autonym for action=query&prop=langlinks [core] - 10https://gerrit.wikimedia.org/r/112245 (owner: 10Umherirrender) [15:24:01] (03Merged) 10jenkins-bot: New hook MessageCache::get [core] - 10https://gerrit.wikimedia.org/r/98078 (owner: 10Nikerabbit) [15:34:42] DanielK_WMDE_: did you say something? I lost the connection.. [15:36:55] jme: nope. can't say anything to that, talk to jared :) [15:37:07] i don't even see a captcha on the page you linked to [15:38:32] DanielK_WMDE_: ok thnaks. [15:42:44] (03CR) 10Chad: [C: 032] Make MVEL way faster [extensions/CirrusSearch] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112732 (owner: 10Manybubbles) [15:42:48] (03CR) 10Chad: [C: 032] Make MVEL way faster [extensions/CirrusSearch] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112707 (owner: 10Manybubbles) [15:42:52] (03Merged) 10jenkins-bot: Make MVEL way faster [extensions/CirrusSearch] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112732 (owner: 10Manybubbles) [15:42:55] (03Merged) 10jenkins-bot: Make MVEL way faster [extensions/CirrusSearch] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112707 (owner: 10Manybubbles) [15:50:45] (03CR) 10Mattflaschen: "No, it's only in wmf13 (check https://gerrit.wikimedia.org/r/#/c/110696/ , same link as in the commit), the click 'Included in' on the le" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111262 (owner: 10Mattflaschen) [15:57:54] (03CR) 10Addshore: [C: 031] Avoid failing if calling the exposed function but no watch/unwatch link was found for whatever reason. [core] - 10https://gerrit.wikimedia.org/r/111796 (owner: 10Thiemo Mättig (WMDE)) [16:01:46] (03CR) 10BryanDavis: Add a PSR-3 based logging interface. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [16:04:58] (03PS1) 10Prtksxna: Update type size and leading [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112903 [16:05:00] (03PS1) 10Prtksxna: Reduce space between extract and timestamp [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112904 [16:05:02] (03PS1) 10Prtksxna: Reduce padding on text [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112905 [16:08:12] thehelpfulone: any idea why AffCom's listserv request has been delayed? anyway I can bribe someone to fill the request? :) [16:19:31] (03PS2) 10Zfilipin: WIP Moved tests from browsertests repository [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112895 [16:24:37] Niharika: Hey, can you check that your ULS repository is currently the same as what's in gerrit? Try running "git status" and see if there are any changes that aren't committed. [16:26:01] rdwrer: I made it work, by a hack. BetaFeaturesHooks is looking for the function ´onGetPreferences()´ only, somehow. So I changed the onGetBetaFeaturePreferences to that and onGetPreferences to something else. [16:26:19] ...what [16:26:35] Niharika: That doesn't make any sense [16:27:03] rdwrer: I made sure BetaFeatures is updated. [16:27:09] I have no other explanation. [16:27:17] But doing that makes it work. [16:27:19] Niharika: Upload a new patchset to gerrit? [16:27:36] With these changes? [16:27:40] Okay. [16:29:18] (03CR) 10Addshore: Support langlinks from hooks in ApiQueryLangLinks. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/60034 (owner: 10Daniel Kinzler) [16:34:09] (03PS3) 10Zfilipin: WIP Moved tests from browsertests repository [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112895 [16:34:46] How does one fix an SUL entry with no accounts attached? [16:35:47] rdwrer: Uploaded. [16:36:11] I see that [16:36:15] Niharika: Wow, that's weird. [16:36:23] <^d> brion: You were...interested...in interwiki search results in API. Were you planning on writing a patch? Or were you just adding input for when I hopefully write a patch? [16:36:33] Niharika: Can you try changing it back, now? I'm not entirely sure why this could possibly ever matter. [16:36:35] <^d> (I'm ok with either way, I just want to know whether I should be working on something :)) [16:36:38] rdwrer: Could you see if that works for you too? [16:36:47] I'm sure it does, the previous one did [16:37:00] ^d: i might poke at it but if you poke it first that's fine :) [16:37:03] no cookie-licking [16:37:04] Hi csteipp [16:37:10] I tried changing it. Naming that function anything other that ´onGetPreferences´ breaks it. [16:37:23] <^d> brion: So whoever gets around to it and gets a patch up first, okie dokie :) [16:37:37] that's our enginerring priority system now ;) [16:38:09] That's so weeeeird [16:38:23] Niharika: Your version works for me just fine [16:38:33] Niharika: Wait. What version of PHP are you using? [16:38:59] Erm, I am editing existing files only so same version, no? [16:39:08] How do I check? [16:39:16] Niharika: No, your computer could be running a different version than mine - run php --version [16:39:57] PHP 5.3.10-1ubuntu3.8+wmf2 with Suhosin-Patch [16:40:04] Bollocks, that's working then. [16:40:11] In fact...wmf2? [16:40:30] Oh, maybe it's a vagrant box or something [16:40:46] Anyway, cool, that should be fine [16:41:23] Yeah, vagrant. [16:41:39] Niharika: Anyway, changing the pref names works for me [16:41:49] I have no idea what's borked on your system, but something ain't right [16:42:02] Maybe I'll have another Vagrant user try to reproduce [16:42:11] rdwrer: Okay, so I´ll work with this and revert it to the old names in the last patch. [16:42:14] If they can, I can bother someone else about a vagrant bug [16:42:18] Sure sure [16:42:47] Niharika: As long as your reviewer can get it working, it should be OK [16:43:20] * brion hmms [16:43:24] Niharika: just to check something [16:43:35] what's the order of BetaFeatures and the other ext in LocalSettings? [16:43:39] * rdwrer bows at the feet of the mighty architect [16:44:02] Hm, I thought we decided that wouldn't matter, but OK [16:44:09] it *shouldn't* [16:44:18] (03PS1) 10Manybubbles: Cherry pick performance improvement for cirrus [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112907 [16:44:26] (03CR) 10Yuvipanda: [C: 032 V: 032] Update type size and leading [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112903 (owner: 10Prtksxna) [16:44:55] (03CR) 10Yuvipanda: [C: 032 V: 032] Reduce space between extract and timestamp [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112904 (owner: 10Prtksxna) [16:45:07] (03CR) 10Yuvipanda: [C: 032 V: 032] Reduce padding on text [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112905 (owner: 10Prtksxna) [16:45:09] brion: BetaFeatures comes before all others, in require_once. [16:45:10] prtksxna: merged [16:45:35] ok that should be ok then [16:45:41] i'm just suspicious of commit 9d7376afe778a1416eb0889d2fb1b58dfff27e58 [16:46:09] if you had an older version that might override things funny [16:46:29] brion: But there's no reason setting the hook function to a different name would fix it... [16:46:31] (03PS1) 10Manybubbles: Cherry pick performance improvement for cirrus [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112908 [16:46:47] rdwrer: hmm, changing the actual function name yeah [16:46:50] *weirddddd* [16:55:08] Hey, I have a question regarding PHPUnit tests execution: Are they runned via cli, so that PHP_SAPI == 'cli' ? [16:56:29] Sure [16:56:58] hashar: You seen https://gerrit.wikimedia.org/r/#/q/owner:jenkins-bot%2540wikimedia.org+status:open,n,z ? I can't work out why it's broken… [16:59:34] (03PS1) 10Jforrester: Try to manually update VisualEditor to 831141e [extensions] - 10https://gerrit.wikimedia.org/r/112911 [16:59:54] <^d> brion: Is there something like getPrefixedText() that doesn't include the IW prefix? [17:00:11] <^d> I want namespace + title string, but don't want the IW prefix. [17:00:21] hoo: sure to 'cli'? [17:00:26] ^d: getText() ? [17:01:17] <^d> getText doesn't include the namespace though? [17:01:31] se4598: Pretty much, yes [17:01:44] (03CR) 10Chad: [C: 032] Cherry pick performance improvement for cirrus [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112908 (owner: 10Manybubbles) [17:01:49] (03CR) 10Chad: [C: 032] Cherry pick performance improvement for cirrus [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112907 (owner: 10Manybubbles) [17:02:00] ^d: interwiki doesn't have any known namespace by definition [17:02:07] unless.... something very weird is happening? [17:02:45] <^d> http://p.defau.lt/?T3yva_k1LoLCArDIOPXurg - that's what I get with getPrefixedText() and getNamespace() [17:03:07] <^d> Using the ApiQueryBase::addTitleInfo() convenience function [17:03:27] ^d: look about what i'd expect there. and with getText() and getNamespace()? [17:04:46] <^d> getText() gives just Anonymous, no IW prefix. [17:04:46] *looks [17:04:56] ^d: that sounds like what we'd want [17:05:09] ...isn't it? [17:05:43] (03Merged) 10jenkins-bot: Cherry pick performance improvement for cirrus [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112908 (owner: 10Manybubbles) [17:05:45] (03Merged) 10jenkins-bot: Cherry pick performance improvement for cirrus [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112907 (owner: 10Manybubbles) [17:05:48] (03PS6) 10Kunalgrover05: Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 [17:07:27] <^d> brion: It's inconsistent. [17:07:30] <^d> Here's a wider search [17:07:40] <^d> http://p.defau.lt/?M0hwo2raPobTJ61Rhp6VUw [17:08:18] hmmmmmm [17:08:19] odd [17:08:24] interwikis should never process namespaces [17:08:32] maybe that changed somewhere along the line [17:08:38] or maybe we never checked to make sure it was true [17:08:44] but in theory they are totally opaque [17:08:52] we don't know the foreign namesapces [17:08:55] and have no way to parse them [17:09:02] <^d> For core namespaces you can assume. [17:09:12] don't assume :) [17:09:18] <^d> In Cirrus, we only allow IW searches via core namespaces for obvious reasons. [17:09:40] is the namespace number coming from Cirrus, or from MediaWiki's Title parser? [17:10:03] i.e. does Cirrus send us 'wikipedia:User:Foo/Foobar.js' and we decompose it? [17:10:14] or does it send ('wikipedia', 2, 'Foo/Foobar.js') [17:10:22] <^d> The latter, more or less. [17:10:25] ick [17:10:46] in that case getPrefixedText will definitely be wrong in any non-english language, won't it? [17:11:12] <^d> Quite probably. [17:11:27] * brion gets out the time-traveling-cluebat [17:12:07] <^d> Ooh, ohh. [17:12:13] <^d> I can think of any easier way to fix this. [17:12:25] <^d> Still store the integer namespace for searching [17:12:34] <^d> But also store the localized text form, for returning. [17:12:38] \o/ [17:12:40] that'd do it [17:12:42] <^d> Allows us to do saner things on IW results. [17:13:10] (03PS7) 10Kunalgrover05: Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 [17:13:15] why on earth are these nodes

anyway? silly xml :D [17:15:08] (03CR) 10Kunalgrover05: "Sorry for making multiple commits. Had another change to make" [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [17:16:39] <^d> brion: I have no idea. I'm just using xml right now because defaults. [17:16:56] aww i don't blame you [17:17:08] it's probably yurik historical code :D ;) [17:17:24] * yurik wasn't here [17:17:27] hehe [17:17:31] * brion blames roan then [17:18:41] (03CR) 10Phuedx: [C: 04-1] "This works well and looks good apart from two minor points." (032 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/112838 (owner: 10Mattflaschen) [17:19:10] ^d, what are you using? where did you find default xml? The only default in API is HTMLed XML :) [17:19:23] <^d> Yeah, that's what I mean. [17:19:36] that's for beauty printing on api page :) [17:19:39] <^d> Which is convenient for copy+pasting to show brion :) [17:19:41] don' tuse that :) [17:19:44] :D [17:19:54] add format=jsonfm ;) [17:20:00] i gotta run buy cat food before my cats go all Thunderdome over the last morsels [17:20:02] brb [17:20:11] <^d> yurik: Extra keystrokes :p [17:20:27] lazy bum! in wiki we like extra keystrokes! esp spaces! [17:20:49] * yurik blames brion for extra spaces [17:24:53] YuviPanda: Thanks! Should I put changes for review on chicken to make it easier for reviewers, or were you asking for some other reason? [17:25:11] prtksxna: to show the designers, mainly [17:25:33] YuviPanda: Oh, yeah! That I'll do on the call or something [17:25:36] (03Abandoned) 10Ragesoss: Switch long comments to PHPDoc format [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95158 (owner: 10Ragesoss) [17:25:41] prtksxna: Ok :) [17:28:37] (03CR) 10Dan-nl: [C: 032 V: 032] Fix message grammar [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/112864 (owner: 10Amire80) [17:29:43] James_F: looking at the VE changes not being merged automatically for mw/extensions.git [17:31:10] (03PS1) 10Chad: WIP: Support interwiki searches in API [core] - 10https://gerrit.wikimedia.org/r/112913 [17:31:27] hashar: Thanks. [17:31:44] (03PS2) 10Chad: WIP: Support interwiki searches in API [core] - 10https://gerrit.wikimedia.org/r/112913 [17:31:55] James_F: ahh https://gerrit.wikimedia.org/r/#/c/112816/ [17:32:00] hashar: I created https://gerrit.wikimedia.org/r/#/c/112911/ manually, but didn't want to merge it as it would confuse matters. [17:32:03] James_F: some path conflict :( [17:32:17] (03Abandoned) 10Hashar: Syncronize VisualEditor: 052b039..2962ca5 [extensions] - 10https://gerrit.wikimedia.org/r/112816 (owner: 10Jenkins-mwext-sync) [17:32:31] hashar: But… how? Also note that it didn't depend on it. [17:32:33] (03CR) 10Chad: "Definitely a WIP. Here's the current output: http://p.defau.lt/?AmeW99XEomOZDQDg3H23jQ" [core] - 10https://gerrit.wikimedia.org/r/112913 (owner: 10Chad) [17:32:48] (03CR) 10Hashar: [C: 032 V: 032] Syncronize VisualEditor: b0d2509..831141e [extensions] - 10https://gerrit.wikimedia.org/r/112845 (owner: 10Jenkins-mwext-sync) [17:32:52] hashar: https://gerrit.wikimedia.org/r/#/c/112845/ is "Merge pending", but there's nothing blocking it. [17:33:00] James_F: so I have abandoned the first change which had some conflict [17:33:05] Aha. [17:33:09] (03CR) 10Dan-nl: [C: 032 V: 032] "thanks!" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/112865 (owner: 10Amire80) [17:33:13] James_F: then the stalled change, I rebased it and force merged it [17:33:17] (03Abandoned) 10Jforrester: Try to manually update VisualEditor to 831141e [extensions] - 10https://gerrit.wikimedia.org/r/112911 (owner: 10Jforrester) [17:33:20] * James_F nods. [17:33:22] James_F: no clue what happened, sorry :-( [17:33:32] hashar: OK, well, I'll try that if it happens again. Thanks! [17:33:35] YuviPanda: Oh, chicken won't auto update like the other, I'll have to pull changes? [17:34:36] James_F: on another topic, we managed to get 2 browser tests to run from Gerrit/Zuul and against a fresh wiki/ve/parsoid. [17:34:48] hashar: Yeah, I saw. Awesome work. :-) [17:34:49] James_F: it is not yet activated, I would like to get more tests to pass [17:35:29] * James_F nods. [17:38:25] (03CR) 10Jeroen De Dauw: "Not really nice to just copy the monolog sources into MW..." [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [17:38:29] cx [17:38:52] cat on keyboard [17:45:33] (03CR) 10Brion VIBBER: "Looks good functionally (except for the namespacing issue we discussed on IRC), but I would argue that the 'interwiki' parameter belongs i" [core] - 10https://gerrit.wikimedia.org/r/112913 (owner: 10Chad) [17:45:52] (03CR) 10EBernhardson: [C: 031] Basic test to demonstrate history bundling issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112831 (owner: 10EBernhardson) [17:48:44] hashar, cool [17:49:22] (03PS1) 10Chad: Begin indexing namespace text forms in the database [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112914 [17:51:45] <^d> Database? [17:51:53] <^d> I need caffeine. [17:52:02] (03PS2) 10Chad: Begin indexing namespace text forms [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112914 [17:55:35] (03PS13) 10Gergő Tisza: Embedding Static Map to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 (owner: 10Inchikutty) [17:56:04] (03PS9) 10Gergő Tisza: Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 (owner: 10Inchikutty) [17:56:51] (03PS17) 10Gergő Tisza: Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 (owner: 10Inchikutty) [17:58:38] (03CR) 10BryanDavis: "Jeroen wrote:" [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [18:02:20] (03CR) 10Manybubbles: Begin indexing namespace text forms (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112914 (owner: 10Chad) [18:04:57] (03CR) 10Chad: Begin indexing namespace text forms (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112914 (owner: 10Chad) [18:05:36] (03PS3) 10Chad: Begin indexing namespace text forms in the database [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112914 [18:07:49] (03PS2) 10MaxSem: Take ratio into account when considering images [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/112787 [18:09:33] (03PS4) 10Kunalgrover05: Go to top button for pages [core] - 10https://gerrit.wikimedia.org/r/108323 (owner: 10Gerrit Patch Uploader) [18:12:59] Is this bug already solved https://bugzilla.wikimedia.org/show_bug.cgi?id=56128 ? because I do not find captcha going out of the container . See this http://tinyurl.com/kkwt62v . [18:14:18] (03PS1) 10Physikerwelt: Remove duplicated code from the LaTeXML class [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/112916 [18:14:27] (03CR) 10jenkins-bot: [V: 04-1] Remove duplicated code from the LaTeXML class [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/112916 (owner: 10Physikerwelt) [18:14:38] sorry wrong bug provided. Its https://bugzilla.wikimedia.org/show_bug.cgi?id=57821 [18:16:02] (03CR) 10Jeroen De Dauw: [C: 04-1] "Oh, did not see you added a composer.json. That effectively breaks being able to install any of the extensions via Composer." [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [18:17:11] (03PS13) 10Jeroen De Dauw: Make it possible for extensions to specify which version of MediaWiki they support via Composer. [core] - 10https://gerrit.wikimedia.org/r/105092 [18:17:42] (03PS2) 10Physikerwelt: Remove duplicated code from the LaTeXML class [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/112916 [18:18:01] (03CR) 10Cmcmahon: [C: 032] "We can re-write the xpath as css when watir-webdriver 0.6.8 gets released and we upgrade. Until then, there is a bug that prevents using " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112858 (owner: 10Spage) [18:18:08] (03CR) 10jenkins-bot: [V: 04-1] Remove duplicated code from the LaTeXML class [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/112916 (owner: 10Physikerwelt) [18:18:43] (03CR) 10Kaldari: [C: 032] Take ratio into account when considering images [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/112787 (owner: 10MaxSem) [18:18:45] (03Merged) 10jenkins-bot: Take ratio into account when considering images [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/112787 (owner: 10MaxSem) [18:19:48] (03CR) 10BryanDavis: "Jeroen wrote:" [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [18:21:54] (03PS1) 10Matthias Mullie: Move cutting of index data into index code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112917 [18:22:02] (03PS4) 10Chad: Begin indexing namespace text forms in the database [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112914 [18:22:26] (03PS3) 10Chad: WIP: Support interwiki searches in API [core] - 10https://gerrit.wikimedia.org/r/112913 [18:22:57] (03PS5) 10Chad: Begin indexing namespace text forms [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112914 [18:25:06] (03CR) 10Matthias Mullie: [C: 04-1] "This should be good for now - it will fix the immediate problem." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112750 (owner: 10Bsitu) [18:25:21] hi there. trying to init a git clone with ‘git review -s’ leads to ‘Exception: Could not connect to gerrit at ssh://ireas@gerrit.wikimedia.org:29418/translatewiki‘. Login on labs is working for me. [18:26:59] Umm I am new to wikimedia development [18:27:15] hi xylophone [18:27:26] I am having problems getting vagrind up [18:27:53] and now I am not able to understand the whole wikitech lab business [18:28:09] you mean like having a lab account? [18:28:15] yes [18:28:21] what does it mean? [18:28:29] they have a cluster of servers [18:28:34] that you can run things on [18:28:36] using ssh [18:28:41] e.g. i want to write a bot [18:28:47] so i have a lab account that will host it for me [18:28:59] ok [18:29:15] I have registered for shell access and have uploaded the ssh keys [18:29:36] i am getting the following output [18:29:36] most people use the tools lab [18:29:37] If you are having access problems, please see: https://wikitech.wikimedia.org/wiki/Access#Accessing_public_and_private_instances Welcome to Ubuntu 12.04.2 LTS (GNU/Linux 3.2.0-58-virtual x86_64) bastion1 is a Wikimedia Labs bastion host (with mosh enabled) (role::labs::bastion). System information as of Wed Feb 12 18:22:52 UTC 2014 System load: 0.16 Processes: 110 Usage of /: 33.3% of 9.83G [18:29:47] wait [18:29:52] what are you using labs for? [18:29:57] there are different parts of it [18:30:59] I want to work on projects in mediawiki, basically I want to be a developer for mediawiki under GSOC [18:31:26] i was directed to this page from the GSOC project ideas page [18:32:22] (03PS4) 10Chad: WIP: Support interwiki searches in API [core] - 10https://gerrit.wikimedia.org/r/112913 [18:32:31] i am fluent in web development [18:32:37] (03CR) 10Mwjames: [C: 04-1] "I think there is an obvious reason as to why libraries like monolog, symfony allow to integrate their sources by managing dependencies thr" [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [18:33:22] but am not able to get hold of a working platform on which to create patches for bugs, or to work on extensions [18:34:38] (03PS1) 10Gerrit Patch Uploader: Add c: as Commons interwiki prefix [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/112920 [18:34:40] xylophone: Using our Vagrant virtual machine may be more in line with what you are looking to do than Labs: https://www.mediawiki.org/wiki/MediaWiki-Vagrant [18:34:48] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/112920 (owner: 10Gerrit Patch Uploader) [18:34:53] (03CR) 10Jeroen De Dauw: "I'm really blind :)" [core] - 10https://gerrit.wikimedia.org/r/112699 (owner: 10BryanDavis) [18:34:58] xylophone: ummm [18:35:05] i think https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools might be the best choice [18:35:23] xylophone: "MediaWiki-Vagrant is a portable MediaWiki development environment" [18:35:37] (03CR) 10Chad: "Current output's looking like: http://p.defau.lt/?5VAxueoAUh_qtKQcJ64oPg" [core] - 10https://gerrit.wikimedia.org/r/112913 (owner: 10Chad) [18:35:41] ^ what he said [18:35:53] (03CR) 10PiRSquared17: [C: 04-1] "Do not merge yet, this is still under discussion." [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/112920 (owner: 10Gerrit Patch Uploader) [18:37:41] (03CR) 10Anomie: "If 'interwiki' is in srinfo, then it should probably show up under query.searchinfo like the other srinfo items." [core] - 10https://gerrit.wikimedia.org/r/112913 (owner: 10Chad) [18:37:49] hmmm, git review -s now fails trying to scp :hook/commit-msg [0] any ideas? [18:37:50] [0] https://tools.wmflabs.org/paste/view/0005c8e3 [18:42:09] ireas: does .git/..../commit-msh exist? [18:42:28] GEOFBOT, I now found out it was being caused by my German locale (!) [18:42:37] oh [18:42:47] that makes sense [18:42:54] GEOFBOT, running `LANG=C git review -s` worked [18:45:10] I am having some trouble getting vagrant wikimedia up [18:45:27] it is saying that I must specify the filesystem type [18:45:29] The following SSH command responded with a non-zero exit status. Vagrant assumes that this means the command failed! mount /tmp/VBoxGuestAdditions.iso -o loop /mnt Stdout from the command: Stderr from the command: mount: you must specify the filesystem type [18:45:55] can someone check the error.... [18:46:46] also , the prompt also says --- GuestAdditions versions on your host (4.1.18) and guest (4.1.12) do not match. [18:46:47] (03CR) 10Krinkle: Add jsduck documentation to mediawiki.feedback.js (033 comments) [core] - 10https://gerrit.wikimedia.org/r/111624 (owner: 10MarkTraceur) [18:47:10] Krinkle|detached: Oh, good plan, I can follow up on reviews after lunch [18:47:47] (03PS2) 10Matthias Mullie: (bug 112917) Move cutting of index data into index code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112917 [18:50:23] (03PS1) 10Yurik: Zero ext update [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112924 [18:50:27] (03CR) 10Matthias Mullie: [C: 031] "LGTM; +2 whenever suitable" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112831 (owner: 10EBernhardson) [18:50:56] (03PS1) 10Yurik: Zero ext update [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112925 [18:51:55] Hi. [18:52:06] (03CR) 10Yurik: [C: 032 V: 032] Zero ext update [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112925 (owner: 10Yurik) [18:52:23] (03CR) 10Yurik: [C: 032 V: 032] Zero ext update [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112924 (owner: 10Yurik) [18:52:27] I was wondering if it is okay to submit a patch for something still under discussion (I already did ) [18:52:31] it's okay, right? [18:52:50] xylophone: What platform (linux, mac, windows) in your host computer and what versions of vagrant and virtualbox are you using? [18:53:34] Darn they left [18:55:06] huh: Sure it's ok. Your commit message should keep it from being randomly +2'd (not that that happens very often) [18:55:34] bd808: thanks [19:03:06] (03PS3) 10Physikerwelt: Remove duplicated code from the LaTeXML class [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/112916 [19:03:20] (03CR) 10jenkins-bot: [V: 04-1] Remove duplicated code from the LaTeXML class [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/112916 (owner: 10Physikerwelt) [19:07:29] (03PS4) 10Physikerwelt: Remove duplicated code from the LaTeXML class [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/112916 [19:07:35] (03CR) 10jenkins-bot: [V: 04-1] Remove duplicated code from the LaTeXML class [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/112916 (owner: 10Physikerwelt) [19:11:49] (03PS5) 10Physikerwelt: Remove duplicated code from the LaTeXML class [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/112916 [19:12:07] (03CR) 10Isarra: [C: 032 V: 032] Add external link icons from Vector [skins/Splash] - 10https://gerrit.wikimedia.org/r/112860 (owner: 10Isarra) [19:13:25] (03PS1) 10Matthias Mullie: (bug 60983) Apply redlinker to flow-parsoid API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112931 [19:15:08] (03CR) 10Physikerwelt: [C: 032] "haha jenkins-bot... I konw your real name" [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/112916 (owner: 10Physikerwelt) [19:25:38] (03PS5) 10Matthias Mullie: Move flow( 'loadReplyForm' ) to base/action.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108634 [19:25:41] (03PS4) 10Matthias Mullie: Alternative way of dealing with edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108635 [19:25:44] (03PS4) 10Matthias Mullie: Move flow( 'setupEditForm' ) to base/action.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108535 [19:30:16] (03CR) 10Krinkle: [C: 04-2] "Placeholder blocker pending wider discussion with other ResourceLoader maintainers. This is major addition that we're going to have to mai" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/111250 (owner: 10MaxSem) [19:33:38] YuviPanda: You set up some magic on multimedia-alpha and now it's broken and everything is terrible, haaalp [19:33:51] mmmmagiic! [19:34:02] No wait [19:34:06] Ignore me! I'm an idiot. [19:34:13] rdwrer: heh ok! [19:34:23] (03PS1) 10Physikerwelt: Add MediaWiki extension MathSearch [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112935 [19:34:40] git was totally happy to replace all of MediaWiki with MultimediaViewer [19:38:29] Ugh, and now update.php is being sloooooow [19:38:56] Maybe enough of it ran that I can access the wiki [19:47:05] (03PS1) 10Raimond Spekking: Fix syntax error Ibc6ed951a9883bb85b8fc10be3e46500b34939e7 [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/112936 [19:47:47] (03CR) 10Raimond Spekking: [C: 032] Fix syntax error Ibc6ed951a9883bb85b8fc10be3e46500b34939e7 [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/112936 (owner: 10Raimond Spekking) [19:47:55] (03Merged) 10jenkins-bot: Fix syntax error Ibc6ed951a9883bb85b8fc10be3e46500b34939e7 [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/112936 (owner: 10Raimond Spekking) [19:48:30] (03CR) 10Raimond Spekking: Improve the clarity of the no-xml-element-found message (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/112865 (owner: 10Amire80) [19:56:45] (03PS1) 10Dan-nl: GWToolset broken on Commons Beta [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/112938 [19:57:59] (03CR) 10Dan-nl: [C: 032 V: 032] GWToolset broken on Commons Beta [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/112938 (owner: 10Dan-nl) [19:59:44] (03CR) 10Dan-nl: "* this commit created a bug 61271" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/112867 (owner: 10Amire80) [20:00:42] (03PS15) 10Catrope: Add OOjs UI v0.1.0-pre (3b61a8d77c) to MW core [core] - 10https://gerrit.wikimedia.org/r/98887 [20:01:08] rdwrer: Please merge ---^^ :) [20:01:24] (03CR) 10jenkins-bot: [V: 04-1] Add OOjs UI v0.1.0-pre (3b61a8d77c) to MW core [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [20:02:05] (03PS16) 10Catrope: Add OOjs UI v0.1.0-pre (3b61a8d77c) to MW core [core] - 10https://gerrit.wikimedia.org/r/98887 [20:02:34] (03CR) 10Catrope: [C: 031] Add OOjs UI v0.1.0-pre (3b61a8d77c) to MW core [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [20:08:47] (03PS1) 10Chad: Minor updates for settings with Elasticsearch 1.0 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112940 [20:11:43] (03PS2) 10Umherirrender: Exclude prop=uploadwarning from allimages and stashimageinfo [core] - 10https://gerrit.wikimedia.org/r/112341 [20:21:16] (03CR) 10Nikerabbit: Add jsduck documentation to mediawiki.feedback.js (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111624 (owner: 10MarkTraceur) [20:34:16] (03CR) 10Krinkle: Add jsduck documentation to mediawiki.feedback.js (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111624 (owner: 10MarkTraceur) [20:37:10] (03Abandoned) 10Chad: Move blame for $wgTitle up one level to getUserSig() [core] - 10https://gerrit.wikimedia.org/r/111567 (owner: 10Chad) [20:39:07] (03PS2) 10Chad: Moved $wgQueryPages stuff out of the global scope and into a function [core] - 10https://gerrit.wikimedia.org/r/111248 [20:39:55] (03CR) 10jenkins-bot: [V: 04-1] Moved $wgQueryPages stuff out of the global scope and into a function [core] - 10https://gerrit.wikimedia.org/r/111248 (owner: 10Chad) [20:40:32] <^d> Silly jenkins/. [20:40:48] (03PS3) 10Chad: Moved $wgQueryPages stuff out of the global scope and into a function [core] - 10https://gerrit.wikimedia.org/r/111248 [20:41:06] (03Abandoned) 10Chad: Don't dump globals to stdout during a unit test [core] - 10https://gerrit.wikimedia.org/r/112147 (owner: 10Chad) [20:43:01] * ^d looks around for a CR victim [20:44:00] (03CR) 10Chad: "Probably. Feel free to submit patches for them :)" [core] - 10https://gerrit.wikimedia.org/r/112641 (owner: 10Chad) [20:44:15] (03PS2) 10Isarra: (bug 61010) Add IE support to vertical-gradient mixin. [core] - 10https://gerrit.wikimedia.org/r/112066 [20:44:29] (03CR) 10Krinkle: Avoid failing if calling the exposed function but no watch/unwatch link was found for whatever reason. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111796 (owner: 10Thiemo Mättig (WMDE)) [20:44:31] (03CR) 10Krinkle: [C: 04-1] Avoid failing if calling the exposed function but no watch/unwatch link was found for whatever reason. [core] - 10https://gerrit.wikimedia.org/r/111796 (owner: 10Thiemo Mättig (WMDE)) [20:45:26] (03PS3) 10BryanDavis: Add a note about hardware virtualization [vagrant] - 10https://gerrit.wikimedia.org/r/112800 (owner: 10Milimetric) [20:46:16] (03CR) 10Krinkle: "These parameters are required per the function documentation. If these are missing or (in case of the jQuery object) invalid (empty set), " [core] - 10https://gerrit.wikimedia.org/r/111796 (owner: 10Thiemo Mättig (WMDE)) [20:46:54] (03CR) 10BryanDavis: [C: 032] Add a note about hardware virtualization [vagrant] - 10https://gerrit.wikimedia.org/r/112800 (owner: 10Milimetric) [20:46:57] (03Merged) 10jenkins-bot: Add a note about hardware virtualization [vagrant] - 10https://gerrit.wikimedia.org/r/112800 (owner: 10Milimetric) [20:47:06] (03CR) 10Ori.livneh: "Thanks :)" [vagrant] - 10https://gerrit.wikimedia.org/r/112800 (owner: 10Milimetric) [20:47:59] Is this bug already solved https://bugzilla.wikimedia.org/show_bug.cgi?id=57821 because I do not see the captcha flowing out of the container ? See this http://tinyurl.com/kkwt62v [20:51:03] (03CR) 10Anomie: "docs/hooks.txt still mentions $wgQueryPages" [core] - 10https://gerrit.wikimedia.org/r/111248 (owner: 10Chad) [20:51:10] (03PS3) 10Krinkle: Vector: Use the new ::-moz-placeholder pseudo-element for Firefox 19+ [core] - 10https://gerrit.wikimedia.org/r/110964 (owner: 10Bartosz Dziewoński) [20:52:25] (03CR) 10MarkTraceur: [C: 032] "Thanks, Roan!" [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [20:55:46] (03Merged) 10jenkins-bot: Add OOjs UI v0.1.0-pre (3b61a8d77c) to MW core [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [20:56:31] Hoorayyyyy [20:58:37] (03PS2) 10MarkTraceur: Added jsduck docs to mediawiki.debug.js [core] - 10https://gerrit.wikimedia.org/r/111620 [20:59:03] (03CR) 10MarkTraceur: "Addressed comments in PS2" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/111620 (owner: 10MarkTraceur) [20:59:26] (03CR) 10jenkins-bot: [V: 04-1] Added jsduck docs to mediawiki.debug.js [core] - 10https://gerrit.wikimedia.org/r/111620 (owner: 10MarkTraceur) [20:59:50] (03PS3) 10MarkTraceur: Added jsduck docs to mediawiki.debug.js [core] - 10https://gerrit.wikimedia.org/r/111620 [21:00:18] (03CR) 10Aaron Schulz: [C: 04-1] Password Expiration (0310 comments) [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [21:00:27] (03CR) 10MarkTraceur: "Rebased" [core] - 10https://gerrit.wikimedia.org/r/111620 (owner: 10MarkTraceur) [21:06:23] spagewmf1, do you know what css_preso is on toro? [21:06:58] superm401: presumably a directory I used for a presentation either about or using CSS [21:07:11] spagewmf2, can I delete it? [21:07:25] superm401: I'll do it [21:07:32] Okay, thanks. [21:07:39] is toro going to the big bullring in the sky ? :) [21:07:56] spagewmf2, nope, just cleaning it up. [21:08:10] I also standardized between piramido and toro to a growth_shared/LocalSettings.php file. [21:08:45] spagewmf2, I made that since I wasn't sure how you guys were using those machines. [21:08:54] (03PS2) 10MarkTraceur: Add jsduck documentation to mediawiki.feedback.js [core] - 10https://gerrit.wikimedia.org/r/111624 [21:08:56] But if you want us to put that stuff in shared/ we could probably do that. [21:09:18] It would mean we would need to coordinate a little bit. [21:09:31] (03CR) 10MarkTraceur: "Addressed comments in PS2" (035 comments) [core] - 10https://gerrit.wikimedia.org/r/111624 (owner: 10MarkTraceur) [21:09:42] (03CR) 10jenkins-bot: [V: 04-1] Add jsduck documentation to mediawiki.feedback.js [core] - 10https://gerrit.wikimedia.org/r/111624 (owner: 10MarkTraceur) [21:11:05] (03PS3) 10MarkTraceur: Add jsduck documentation to mediawiki.feedback.js [core] - 10https://gerrit.wikimedia.org/r/111624 [21:11:10] (03CR) 10MarkTraceur: "Rebased" [core] - 10https://gerrit.wikimedia.org/r/111624 (owner: 10MarkTraceur) [21:11:27] (03CR) 10MarkTraceur: "Rebased" [core] - 10https://gerrit.wikimedia.org/r/111624 (owner: 10MarkTraceur) [21:11:42] (03CR) 10MarkTraceur: "REBASED" [core] - 10https://gerrit.wikimedia.org/r/111624 (owner: 10MarkTraceur) [21:11:47] qOh FFS [21:12:00] Jenkins you ass. [21:12:04] Er. Gerrit you ass. [21:18:00] (03PS1) 10FreedomFighterSparrow: Allow anonymous users to dismiss the sitenotice [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/112951 [21:18:23] superm401: Flow (core features, E2, whatev) isn't using toro and piramido. I've been putting files in /data/project/git_files/{LABS_NAMES} with symlinks [21:18:50] spagewmf2, yeah, us too. However, I made a directory to share between toro and piramido. [21:18:58] Anyway, you can keep doing what you're doing. [21:19:22] (03PS1) 10Chad: Use ProfilerSection where possible [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112952 [21:19:30] (03CR) 10Physikerwelt: "sorry but don't have +2 here" [services/mathoid] - 10https://gerrit.wikimedia.org/r/112875 (owner: 10Physikerwelt) [21:19:54] <^d> AaronSchulz: https://gerrit.wikimedia.org/r/112952 should fix all the profiler errors :p [21:21:32] (03PS1) 10MarkTraceur: Add external things to the JSDuck config [core] - 10https://gerrit.wikimedia.org/r/112953 [21:24:06] (03CR) 10Aaron Schulz: [C: 032] Use ProfilerSection where possible [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112952 (owner: 10Chad) [21:24:11] (03Merged) 10jenkins-bot: Use ProfilerSection where possible [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112952 (owner: 10Chad) [21:25:36] (03CR) 10MarkTraceur: "Fixes issues with jsduck jobs, but not the underlying cause." [core] - 10https://gerrit.wikimedia.org/r/112953 (owner: 10MarkTraceur) [21:25:52] RoanKattouw: If you could merge ^^, doc.wm.org will have oojs docs too [21:26:04] (in the core docs) [21:26:32] (03CR) 10Catrope: [C: 032] Add external things to the JSDuck config [core] - 10https://gerrit.wikimedia.org/r/112953 (owner: 10MarkTraceur) [21:26:38] Huzzah [21:26:47] Now to figure out why the eff Jenkins merged a broken patch. [21:26:57] I guess because it's not really broken, but sigh. [21:28:45] (03PS1) 10Gergő Tisza: Add jquery-throttle-debounce to core [core] - 10https://gerrit.wikimedia.org/r/112956 [21:29:42] (03Merged) 10jenkins-bot: Add external things to the JSDuck config [core] - 10https://gerrit.wikimedia.org/r/112953 (owner: 10MarkTraceur) [21:30:51] (03PS1) 10Matthias Mullie: Address i18n issue [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/112958 [21:32:37] (03CR) 10jenkins-bot: [V: 04-1] Add jquery-throttle-debounce to core [core] - 10https://gerrit.wikimedia.org/r/112956 (owner: 10Gergő Tisza) [21:35:15] (03PS2) 10Matthias Mullie: Address i18n issue [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/112958 [21:35:53] (03CR) 10Milimetric: "Thanks Bryan, I made the same change and had a gerrit-fail on patchset2." [vagrant] - 10https://gerrit.wikimedia.org/r/112800 (owner: 10Milimetric) [21:43:55] (03CR) 10Matthias Mullie: "I've added tests for this type of revision checks in https://gerrit.wikimedia.org/r/#/c/112844/ (note that that patch fails miserably, rig" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112161 (owner: 10Matthias Mullie) [21:44:51] (03CR) 10BryanDavis: "Milimetric: yw. I figured something like that happened. Thanks for pointing out the problem and getting the patch started." [vagrant] - 10https://gerrit.wikimedia.org/r/112800 (owner: 10Milimetric) [21:46:36] (03PS2) 10Nemo bis: Allow anonymous users to dismiss the sitenotice [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/112951 (owner: 10FreedomFighterSparrow) [21:47:11] (03CR) 10Matthias Mullie: [C: 031] "LGTM, but have not yet tested it recently" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 (owner: 10Bsitu) [21:48:22] (03CR) 10Nemo bis: "Thanks for the patch! Brion, this restores what you declared a requirement for the extension a few years ago." [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/112951 (owner: 10FreedomFighterSparrow) [21:50:09] (03PS2) 10Gergő Tisza: Add jquery-throttle-debounce to core [core] - 10https://gerrit.wikimedia.org/r/112956 [21:55:11] (03PS1) 10Jforrester: Update OOjs UI to c0f5658 [core] - 10https://gerrit.wikimedia.org/r/113012 [21:55:33] Did someone merged something with CirrusSearch into master?? [21:55:55] On de.wikipedia.beta.wmflabs.org: PHP fatal error in /data/project/apache/common-local/php-master/extensions/CirrusSearch/includes/Searcher.php line 200: [21:55:55] Class 'CirrusSearch\ProfileSection' not found [21:56:06] manybubbles: ^ [21:56:19] se4598: They deployed some performance things today AFAIR [21:56:35] hoo: we didn't deploy that that I know of [21:56:43] mh [21:57:12] it about master, not deployed on production etc. [21:57:17] ah [21:57:22] beta [21:57:33] (03CR) 10Catrope: [C: 032] Update OOjs UI to c0f5658 [core] - 10https://gerrit.wikimedia.org/r/113012 (owner: 10Jforrester) [21:58:04] (03CR) 10FreedomFighterSparrow: "Nemo, why the second patchset? Isn't it identical?" [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/112951 (owner: 10FreedomFighterSparrow) [21:59:44] se4598 manybubbles that is the same error that showed up on beta labs just now [22:00:04] se4598 manybubbles https://bugzilla.wikimedia.org/show_bug.cgi?id=61286 [22:00:11] (03CR) 10Nemo bis: "I only fixed a small error in the commit message, yes. https://gerrit.wikimedia.org/r/#/c/112951/1..2//COMMIT_MSG" [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/112951 (owner: 10FreedomFighterSparrow) [22:00:13] manybubbles: https://gerrit.wikimedia.org/r/112952 <- this change? [22:00:18] I'll fix it [22:00:58] (03Merged) 10jenkins-bot: Update OOjs UI to c0f5658 [core] - 10https://gerrit.wikimedia.org/r/113012 (owner: 10Jforrester) [22:01:55] (03PS1) 10Manybubbles: Properly use ProfileSection [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113015 [22:02:19] (03CR) 10Manybubbles: [C: 032] "This is less broken then before. Merging." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113015 (owner: 10Manybubbles) [22:02:26] (03Merged) 10jenkins-bot: Properly use ProfileSection [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/113015 (owner: 10Manybubbles) [22:02:47] lets see if that fixes it in beta [22:05:04] seems bugzilla has gone into maintenance right now as announced [22:05:14] !bug [22:05:15] https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=$url_encoded_* [22:07:45] <^d> manybubbles: Bleh, sorry about that. [22:08:05] yes, I've shut down Bugzilla for about 2 or 3 hours now [22:08:09] manybubbles: seems working for me [22:08:17] cool [22:08:22] no big deal [22:08:24] at least no fatal ;) [22:08:25] caught and fixed [22:09:41] (03CR) 10Chad: [C: 032] If the job queue supports it, delay link counting [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112803 (owner: 10Manybubbles) [22:09:47] (03Merged) 10jenkins-bot: If the job queue supports it, delay link counting [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112803 (owner: 10Manybubbles) [22:10:19] MatmaRex, superm401: question: should projects name their CSS-only module "foo.css" or "foo.nojs Ditto for the no-js CSS files. [22:11:06] spagewmf2, there are different conventions. [22:11:23] Core is using skins.vector.styles now, which is nice since it doesn't prejudge whether it's CSS or LESS. [22:11:39] I prefer that to nojs for the general CSS-only module. [22:12:58] spagewmf2, for a file with only nojs rules it could be .nojs.styles.less or .nojs.styles.css . [22:13:11] This presumably doesn't need to be its own module. [22:14:04] superm401: wfm, I like it. I'll look for a place to note this on mw.org [22:22:11] (03PS1) 10Physikerwelt: Add makefile [services/mathoid] - 10https://gerrit.wikimedia.org/r/113024 [22:22:13] (03PS1) 10Physikerwelt: npm version of debian package [services/mathoid] - 10https://gerrit.wikimedia.org/r/113025 [22:22:15] (03PS1) 10Physikerwelt: Prepere for next build [services/mathoid] - 10https://gerrit.wikimedia.org/r/113026 [22:22:17] (03PS1) 10Physikerwelt: Remove version from the npm dependency for now [services/mathoid] - 10https://gerrit.wikimedia.org/r/113027 [22:27:10] (03CR) 10Matthias Mullie: [C: 031] "LGTM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112126 (owner: 10Bencmq) [22:27:47] (03PS1) 10Catrope: Update VisualEditor to wmf13 branch for cherry-picks [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113032 [22:28:53] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to wmf13 branch for cherry-picks [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113032 (owner: 10Catrope) [22:36:33] (03PS1) 10MarkTraceur: Break JSDuck (DO NOT MERGE) [core] - 10https://gerrit.wikimedia.org/r/113034 [22:40:27] (03CR) 10jenkins-bot: [V: 04-1] Break JSDuck (DO NOT MERGE) [core] - 10https://gerrit.wikimedia.org/r/113034 (owner: 10MarkTraceur) [22:42:20] (03PS2) 10MarkTraceur: Break JSDuck (DO NOT MERGE) [core] - 10https://gerrit.wikimedia.org/r/113034 [22:44:28] (03CR) 10MarkTraceur: [C: 032] "Deployed." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/113033 (owner: 10MarkTraceur) [22:45:12] (03Abandoned) 10MarkTraceur: Break JSDuck (DO NOT MERGE) [core] - 10https://gerrit.wikimedia.org/r/113034 (owner: 10MarkTraceur) [22:54:40] (03PS1) 10Matthias Mullie: Fix missing i18n msgs for edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113037 [23:04:17] (03CR) 10Chad: "That seemed like the wrong place to put it" [core] - 10https://gerrit.wikimedia.org/r/112913 (owner: 10Chad) [23:08:51] (03PS2) 10Mattflaschen: Avoid unnecessary network call if there are no categories [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/112838 [23:11:37] (03CR) 10Mattflaschen: "See inline regarding optimization." (032 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/112838 (owner: 10Mattflaschen) [23:23:21] (03CR) 10EBernhardson: [C: 032] Update cache version to match wmf12 and wmf13 deploy with new uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112752 (owner: 10EBernhardson) [23:23:30] (03Merged) 10jenkins-bot: Update cache version to match wmf12 and wmf13 deploy with new uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112752 (owner: 10EBernhardson) [23:27:08] (03PS1) 10Bsitu: Flow watchlist data tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113042 [23:30:41] (03CR) 10EBernhardson: "couple nit picks" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113042 (owner: 10Bsitu) [23:48:10] (03PS3) 10Aaron Schulz: Limit attempts to render the same thumbnail after failures [core] - 10https://gerrit.wikimedia.org/r/107419 [23:53:07] (03PS1) 10Bsitu: Fix topic preview [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113046 [23:53:17] (03PS4) 10Aaron Schulz: Limit attempts to render the same thumbnail after failures [core] - 10https://gerrit.wikimedia.org/r/107419 [23:53:40] (03CR) 10EBernhardson: Add *Revisionable classes (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111366 (owner: 10Matthias Mullie) [23:54:03] (03CR) 10EBernhardson: Add *Revisionable classes (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111366 (owner: 10Matthias Mullie) [23:54:15] (03CR) 10Matthias Mullie: [C: 031] "LGTM - merge after code freeze" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113046 (owner: 10Bsitu) [23:55:23] (03CR) 10jenkins-bot: [V: 04-1] Limit attempts to render the same thumbnail after failures [core] - 10https://gerrit.wikimedia.org/r/107419 (owner: 10Aaron Schulz) [23:56:30] (03CR) 10EBernhardson: "I've also been thinking, perhaps RevisionCollection would be more appropriate than Revisionable?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111366 (owner: 10Matthias Mullie) [23:56:37] (03PS5) 10BryanDavis: Limit attempts to render the same thumbnail after failures [core] - 10https://gerrit.wikimedia.org/r/107419 (owner: 10Aaron Schulz) [23:57:19] (03CR) 10BryanDavis: [C: 032] "This seems like a great idea!" [core] - 10https://gerrit.wikimedia.org/r/107419 (owner: 10Aaron Schulz) [23:57:49] (03CR) 10Matthias Mullie: "RevisionCollection sounds reasonable. Also: any suggestion on where to put it, that is not Model?" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111366 (owner: 10Matthias Mullie) [23:58:19] (03PS2) 10Bsitu: Flow watchlist data tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113042 [23:59:37] (03CR) 10Bsitu: Flow watchlist data tweaks (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/113042 (owner: 10Bsitu)