[00:01:40] (03CR) 10jenkins-bot: [V: 04-1] Add OOjs UI v0.1.0-pre (ddff003909) to core [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [00:05:09] (03PS4) 10EBernhardson: Create maintenance mode [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112570 [00:08:09] (03PS2) 10Chad: Use near_match to also search pages [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112566 (owner: 10Manybubbles) [00:08:14] (03PS5) 10EBernhardson: Create maintenance mode [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112570 [00:08:20] (03CR) 10Chad: [C: 032] Use near_match to also search pages [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112566 (owner: 10Manybubbles) [00:08:25] (03Merged) 10jenkins-bot: Use near_match to also search pages [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112566 (owner: 10Manybubbles) [00:09:14] (03Abandoned) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112571 (owner: 10EBernhardson) [00:09:40] (03Abandoned) 10EBernhardson: Create maintenance mode [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112570 (owner: 10EBernhardson) [00:09:43] (03CR) 10Chad: "lgtm if the i18n checks out." [extensions/Math] - 10https://gerrit.wikimedia.org/r/112589 (owner: 10Physikerwelt) [00:10:11] (03Abandoned) 10EBernhardson: base36 uuids [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112569 (owner: 10EBernhardson) [00:10:35] (03Abandoned) 10EBernhardson: base36 uuids [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112572 (owner: 10EBernhardson) [00:10:50] (03Abandoned) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112568 (owner: 10EBernhardson) [00:11:08] (03Abandoned) 10EBernhardson: Create maintenance mode [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112567 (owner: 10EBernhardson) [00:12:19] (03PS2) 10Prtksxna: Update icon on Beta Preferences [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112607 [00:13:12] (03PS26) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [00:13:22] superm401, hi, ori told me to ask you about click tracking for links on desktop [00:17:16] (03PS27) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [00:17:17] (03CR) 10jenkins-bot: [V: 04-1] [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [00:17:30] (03PS28) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [00:17:31] jgonera, right, so the trick we've been using is to block the link navigation for X milliseconds, use that interval to log, then after the logging complete the navigation. [00:17:31] We actually removed the helper, but let me dig into git and find examples for you. [00:17:31] superm401, oh, so it's removed? we're doing something similar on mobile [00:17:31] jgonera, because it was in GettingStarted, not EventLogging, we weren't using it, and I didn't like the way it was factored. [00:17:31] One sec [00:17:40] (03PS13) 10EBernhardson: base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 [00:17:55] what I was wondering about mainly is if you used some sampling strategy? I want to track clicks in links such as preferences, beta, talk from the personal toolbar and I'm wondering if this won't be too much for all logged in users on desktop [00:18:20] It's probably fine, but that's a question for ori. [00:18:28] hah [00:18:30] Bug for doing it right: https://bugzilla.wikimedia.org/show_bug.cgi?id=52287 [00:18:43] I'm digging up examples of the old helper code and code calling it. [00:18:44] (03PS29) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [00:18:47] greg-g: you just created https://bugzilla.wikimedia.org/show_bug.cgi?id=61161 under the CiviCRM component [00:18:53] (03CR) 10jenkins-bot: [V: 04-1] [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [00:18:58] I'm not sure that's what you intended [00:19:29] gah [00:19:45] bugzilla [00:19:48] off by one [00:19:56] superm401, mw.eventLog.logEvent returns a Deferred so it should be enough to reidrect when mw.eventLog.logEvent is done [00:20:00] thanks mwalker [00:20:06] jgonera, helper function. Not specific to links (as bug indicates, I think there should be one that is specific for links): https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGettingStarted.git/b66689ef823c759067d4f16c8a894758b727db60/resources%2Fext.gettingstarted.logging.js#L6 [00:20:32] jgonera, yeah, but you have to delay the navigation since otherwise it can happen before logging finishes. [00:20:57] But logging might *never* finish, but you don't want the link click to fail just because logging is broken. [00:21:03] superm401, even if I redirect after mw.eventLog.logEvent is resolved? [00:21:04] oh [00:21:05] I see [00:21:07] right [00:21:30] Though I guess that would only be an issue if event.gif took forever to respond (though I don't see how that could happen). [00:21:30] (03CR) 10GWicke: [C: 032] "Looks good to me." [core] - 10https://gerrit.wikimedia.org/r/108152 (owner: 10Aaron Schulz) [00:21:35] If the network is down entirely, it's a moot point. [00:22:06] Sorry, right link is https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGettingStarted.git/b66689ef823c759067d4f16c8a894758b727db60/resources%2Fext.gettingstarted.logging.js#L64 [00:22:18] superm401, who knows, there might be some packet loss just for the event.gif request, I guess a timeout of 500ms is a good idea [00:22:20] (03PS30) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [00:22:44] jgonera, right, I guess if the request is lost, that would be equivalent to never responding. [00:22:58] jgonera, right, so a call site example is https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGettingStarted.git/b66689ef823c759067d4f16c8a894758b727db60/resources%2Fext.gettingstarted.return.js#L225 . [00:23:24] You can probably see why I want a link-specific helper, so callers don't need that boilerplate. [00:23:50] Just to confirm: There's no easy way to get a fully human-readable blockedtext message all filled out from the API is there? [00:23:56] jgonera, actually, that's a bad example. [00:24:29] superm401, that's fine, I get it [00:24:39] (03PS14) 10EBernhardson: base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 [00:24:55] Okay, my main point is that we should make a helper specifically for doing it with actual links. [00:25:20] You'd have to action=query&meta=userinfo&uiprop=blockinfo, action=query&list=blocks&bkids=n, action=parse&text={{MediaWiki:Blockedtext}}, then mess around with date formatting right? [00:25:20] https://www.mediawiki.org/wiki/MediaWiki:Template:Blockedtext [00:25:52] (03PS15) 10EBernhardson: base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 [00:26:13] superm401, function logThenNavigate( $link, eventInstance, timeout ) - what's eventInstance? [00:27:04] jgonera, just whatever you're logging. Same as first parameter of logUnlessTimeout or second of logEvent. [00:27:12] The actual data [00:27:27] superm401, then we need an argument for the schema name too, right? [00:27:43] as in mw.eventLog.logEvent( schemaName, data ) [00:27:44] jgonera, yep, my mistake. [00:27:47] ok [00:28:15] (03PS31) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [00:28:17] (03PS16) 10EBernhardson: base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 [00:28:19] GettingStarted made a wrapper so we could skip putting the schema name since we keep changing the schema. We ended up dropping that wrapper too. [00:28:38] right [00:31:33] (03PS17) 10EBernhardson: base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 [00:31:40] (03PS18) 10EBernhardson: base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 [00:36:39] (03PS19) 10EBernhardson: base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 [00:38:42] (03CR) 10GWicke: Added pipelining and max connection support to MultiHttpClient (032 comments) [core] - 10https://gerrit.wikimedia.org/r/108151 (owner: 10Aaron Schulz) [00:42:33] (03PS1) 10Ori.livneh: quote space-separated proxy list arg for scap-1 [tools/scap] - 10https://gerrit.wikimedia.org/r/112612 [00:42:41] bd808: ^ [00:43:21] (03CR) 10BryanDavis: [C: 032] "Ori types faster than I do so his patch wins." [tools/scap] - 10https://gerrit.wikimedia.org/r/112612 (owner: 10Ori.livneh) [00:43:23] (03Merged) 10jenkins-bot: quote space-separated proxy list arg for scap-1 [tools/scap] - 10https://gerrit.wikimedia.org/r/112612 (owner: 10Ori.livneh) [00:43:37] That's the spirit! [00:44:28] rdwrer: I have the exact same diff in my local repo :) [00:44:45] because you ran git pull [00:49:32] <^demon> Gerrit reboot in ~10 minutes. [00:50:49] (03PS5) 10Aaron Schulz: Added pipelining and max connection support to MultiHttpClient [core] - 10https://gerrit.wikimedia.org/r/108151 [00:50:51] gwicke: done [00:56:13] AaronSchulz, oh sorry: I meant the for single / all hosts thing for maxConns [00:56:14] (03PS2) 10Ori.livneh: Break up roles.pp into individual role files [vagrant] - 10https://gerrit.wikimedia.org/r/112413 [00:56:14] connections per host vs. total connections [00:56:14] in most libraries I worked with so far (and browsers) the connection limit is per host [00:56:14] (03CR) 10Ori.livneh: [C: 032] "Updated README per Matt's suggestion." [vagrant] - 10https://gerrit.wikimedia.org/r/112413 (owner: 10Ori.livneh) [00:56:14] (03Merged) 10jenkins-bot: Break up roles.pp into individual role files [vagrant] - 10https://gerrit.wikimedia.org/r/112413 (owner: 10Ori.livneh) [00:56:15] (03Abandoned) 10EBernhardson: [WIP] Mysql slave with permenant slave-lag [vagrant] - 10https://gerrit.wikimedia.org/r/107497 (owner: 10EBernhardson) [00:56:17] <^demon> Gerrit upgrade done. [00:56:18] (03CR) 10EBernhardson: [C: 032] [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [00:56:18] (03CR) 10EBernhardson: [C: 032] base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 (owner: 10EBernhardson) [00:56:18] (03Merged) 10jenkins-bot: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [00:56:25] (03Merged) 10jenkins-bot: base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 (owner: 10EBernhardson) [00:57:12] (03CR) 10GWicke: Added pipelining and max connection support to MultiHttpClient (031 comment) [core] - 10https://gerrit.wikimedia.org/r/108151 (owner: 10Aaron Schulz) [00:57:58] I got my GCI shirt and certificate today! *squee* [00:59:35] gwicke: actually that php 5.5 case should just be deleted [00:59:49] for maxConns [01:00:12] (03PS1) 10Ori.livneh: Add Max Semenik and Moritz Schubotz to AUTHORS.txt [vagrant] - 10https://gerrit.wikimedia.org/r/112614 [01:01:02] <^demon> Gloria: Gerrit should behave on status queries again. [01:03:46] (03PS1) 10Chad: Revert "Limit searches at 500 per page" [core] - 10https://gerrit.wikimedia.org/r/112615 [01:04:36] (03CR) 10Ori.livneh: [C: 04-1] ""support" and "utils" are two ways of saying "i don't know how to organize this stuff". even one is too much, IMO. but it's OK to figure t" (032 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/112487 (owner: 10BryanDavis) [01:04:38] (03PS6) 10Aaron Schulz: Added pipelining and max connection support to MultiHttpClient [core] - 10https://gerrit.wikimedia.org/r/108151 [01:10:57] (03CR) 10GWicke: Added pipelining and max connection support to MultiHttpClient (031 comment) [core] - 10https://gerrit.wikimedia.org/r/108151 (owner: 10Aaron Schulz) [01:13:56] gwicke: no, since that doesn't actually do what I thought it did [01:14:07] that's just the pool cache size [01:15:38] AaronSchulz, maybe we actually want CURLMOPT_MAX_HOST_CONNECTIONS ? [01:15:43] http://curl.haxx.se/libcurl/c/curl_multi_setopt.html [01:15:54] Pass a long. The set number will be used as the maximum amount of simultaneously open connections to a single host. [01:16:34] generally our main concern is not overloading servers on the other end, which this should do [01:20:16] gwicke: I could add a maxConnsPerHost option in another patch [01:21:17] AaronSchulz, is there a use case for a limit on the number of total connections? [01:21:49] from my perspective maxConns can just be the per-host setting [01:21:55] it's just swift now...it could be perhost [01:22:16] in which case it should have the same effect as the manual batching (only more efficient) [01:22:48] I could just change the docs to be per-host and change the implementation in other patch [01:22:51] it basically gives you a rolling window [01:23:40] though maxConns sounds like an odd name if it is per-host [01:24:00] in node etc it is called maxSockets [01:24:28] http://nodejs.org/api/http.html#http_agent_maxsockets [01:25:42] maybe maxConnectionsPerHost would be clearer [01:26:46] I'm fine with changing the implementation later, would just be good to clarify the interface in this patch [01:27:39] per host is fine [01:27:44] when cherry picking to a branch from within the gerrit interface it seems to maintain the Change-Id. I have a cherry-pick that has a merge conflict so had to cherry-pick manually, but gerrit is rejecting the review because 'change 112568 closed' [01:27:53] any ideas? should i just let it chose a new Change-Id ? [01:27:59] s/chose/choose/ [01:28:18] ebernhardson, you can delete it with amend [01:28:28] git review will then add a new one [01:28:34] ok, i'll just clear out the Change-Id [01:28:46] (03PS1) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112620 [01:29:41] (03CR) 10EBernhardson: "manual cherry pick to wmf/1.23wmf12 in I8b05d79bd35de809f22f55f37e6bf2b13d8e22c2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 (owner: 10EBernhardson) [01:30:47] (03CR) 10EBernhardson: [C: 032] [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112620 (owner: 10EBernhardson) [01:30:48] (03Merged) 10jenkins-bot: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112620 (owner: 10EBernhardson) [01:35:54] (03PS1) 10EBernhardson: base36 uuids [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112621 [01:36:04] (03CR) 10jenkins-bot: [V: 04-1] base36 uuids [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112621 (owner: 10EBernhardson) [01:37:40] (03PS2) 10EBernhardson: base36 uuids [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112621 [01:38:10] (03CR) 10EBernhardson: [C: 032] base36 uuids [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112621 (owner: 10EBernhardson) [01:38:20] (03Merged) 10jenkins-bot: base36 uuids [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112621 (owner: 10EBernhardson) [01:41:25] gwicke: does php5.5 support CURLMOPT_MAX_HOST_CONNECTIONS ? It's not documented. [01:41:31] (03CR) 10Brian Wolff: "In practise though nobody is doing anything other than namespace (and even that is pretty rare, mostly just enwiki). Perfect is the eneyme" [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [01:49:16] (03PS1) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112622 [01:50:20] (03CR) 10EBernhardson: "Manual cherry pick to 1.23wmf12 in I8b05d79bd35de809f22f55f37e6bf2b13d8e22c2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [01:50:45] (03CR) 10EBernhardson: [C: 032] [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112622 (owner: 10EBernhardson) [01:50:54] (03Merged) 10jenkins-bot: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112622 (owner: 10EBernhardson) [01:53:12] (03PS1) 10EBernhardson: base36 uuids [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112623 [01:53:38] (03CR) 10EBernhardson: "manual cherry pick to 1.23wmf13 in Ie70b0ffbc439ea83c0922d5113ccc4cab00f8424" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 (owner: 10EBernhardson) [01:53:51] (03CR) 10EBernhardson: [C: 032] base36 uuids [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112623 (owner: 10EBernhardson) [01:54:01] (03Merged) 10jenkins-bot: base36 uuids [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112623 (owner: 10EBernhardson) [01:54:46] <^d> Who wants code to review? [01:54:47] <^d> :) [01:55:26] (03PS1) 10EBernhardson: Create maintenance mode [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112624 [01:55:41] (03CR) 10EBernhardson: [C: 032] Create maintenance mode [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112624 (owner: 10EBernhardson) [01:55:53] (03Merged) 10jenkins-bot: Create maintenance mode [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112624 (owner: 10EBernhardson) [01:56:48] (03PS7) 10Aaron Schulz: Added pipelining and max connection support to MultiHttpClient [core] - 10https://gerrit.wikimedia.org/r/108151 [01:57:13] (03PS1) 10EBernhardson: Create maintenance mode [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112625 [01:57:27] (03CR) 10EBernhardson: [C: 032] Create maintenance mode [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112625 (owner: 10EBernhardson) [01:58:36] (03Merged) 10jenkins-bot: Create maintenance mode [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112625 (owner: 10EBernhardson) [02:00:06] AaronSchulz: that string isn't anywhere in the php-5.5.0 release, so probably(but not guaranteed) not [02:01:09] (03PS1) 10Chad: Remove $wgMaintenanceScripts and friends [core] - 10https://gerrit.wikimedia.org/r/112627 [02:01:36] on beta labs, ULS is giving me "JSON.parse: unexpected end of data" errors while logged in. [02:02:23] <^d> ebernhardson, AaronSchulz: I can't find it in php master. [02:04:25] yeah I could find it either (doesn't work in php -r) [02:07:37] (03PS5) 10Aaron Schulz: Simplified Swift backend to use maxConns flag in MultiHttpClient [core] - 10https://gerrit.wikimedia.org/r/108152 [02:19:12] (03PS1) 10Manybubbles: Boost pages based on their namespace [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112629 [02:19:14] (03CR) 10jenkins-bot: [V: 04-1] Boost pages based on their namespace [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112629 (owner: 10Manybubbles) [02:19:54] (03PS1) 10Chad: Remove undocumented and unused searchx parameter [core] - 10https://gerrit.wikimedia.org/r/112630 [02:21:31] (03PS2) 10Manybubbles: Boost pages based on their namespace [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112629 [02:22:10] (03CR) 10TTO: "See comments." (036 comments) [core] - 10https://gerrit.wikimedia.org/r/108323 (owner: 10Gerrit Patch Uploader) [02:23:12] (03CR) 10Mattflaschen: "Ready for review (no longer blocked)." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111345 (owner: 10Mattflaschen) [02:26:21] (03PS3) 10Chad: Boost pages based on their namespace [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112629 (owner: 10Manybubbles) [02:27:21] (03PS1) 10Manybubbles: Fix warning when searching in all namespaces [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112631 [02:31:19] (03CR) 10Chad: [C: 04-1] "Do we have to have this? I'd just WONTFIX the bug. I hate "go to top" links, especially one that's wastefully injected to the DOM via Java" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/108323 (owner: 10Gerrit Patch Uploader) [02:32:25] (03CR) 10Chad: [C: 032] "Whoops. Forgot that is now optional." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112631 (owner: 10Manybubbles) [02:32:32] (03Merged) 10jenkins-bot: Fix warning when searching in all namespaces [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112631 (owner: 10Manybubbles) [02:34:41] (03CR) 10GWicke: Added pipelining and max connection support to MultiHttpClient (031 comment) [core] - 10https://gerrit.wikimedia.org/r/108151 (owner: 10Aaron Schulz) [02:35:38] (03CR) 10Aaron Schulz: Added pipelining and max connection support to MultiHttpClient (031 comment) [core] - 10https://gerrit.wikimedia.org/r/108151 (owner: 10Aaron Schulz) [02:38:41] ^d: You should discuss why you hate "go to top" links on the bug report. [02:39:03] I constantly wish there were one on mobile. [02:39:13] <^d> Well, the implementation is worth discussing on the change. [02:39:32] <^d> Also, if I just leave comments on the bug someone will get merge-happy and merge without reading the bug I'm sure. [02:39:45] :-) [02:39:48] <^d> :) [02:40:45] (03PS1) 10Manybubbles: Handle _s as spaces in prefix: [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112633 [02:41:26] (03CR) 10Mattflaschen: [C: 04-1] "Unused namespace import, and NS_MAIN looks funny (even though it seems not to affect the result in this case)." (032 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/112496 (owner: 10Phuedx) [02:41:33] (03CR) 10Chad: [C: 032] Handle _s as spaces in prefix: [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112633 (owner: 10Manybubbles) [02:41:38] (03Merged) 10jenkins-bot: Handle _s as spaces in prefix: [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112633 (owner: 10Manybubbles) [02:42:03] (03CR) 10Parent5446: [C: 031] Remove $wgMaintenanceScripts and friends [core] - 10https://gerrit.wikimedia.org/r/112627 (owner: 10Chad) [02:43:46] (03CR) 10Aaron Schulz: [C: 032] Remove $wgMaintenanceScripts and friends [core] - 10https://gerrit.wikimedia.org/r/112627 (owner: 10Chad) [02:46:57] (03Merged) 10jenkins-bot: Remove $wgMaintenanceScripts and friends [core] - 10https://gerrit.wikimedia.org/r/112627 (owner: 10Chad) [02:47:17] (03PS1) 10Chad: Remove $wgMaintenanceScripts [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/112634 [02:50:10] (03CR) 10Chad: [C: 032] Boost pages based on their namespace [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112629 (owner: 10Manybubbles) [02:50:17] (03Merged) 10jenkins-bot: Boost pages based on their namespace [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112629 (owner: 10Manybubbles) [02:58:34] (03CR) 10Jorm: [C: 04-1] "I don't want to block this, but there's no way we'd want to deploy it to Foundation wikis. 3rd party wikis may want to have this function" [core] - 10https://gerrit.wikimedia.org/r/108323 (owner: 10Gerrit Patch Uploader) [03:03:34] (03PS1) 10Aaron Schulz: Cleanup to LoadMonitor [core] - 10https://gerrit.wikimedia.org/r/112635 [03:04:09] (03CR) 10Mattflaschen: "Also, RedisCategorySync doesn't work." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/112496 (owner: 10Phuedx) [03:20:28] rdwrer: Around? [03:21:39] Sorta! :) [03:21:43] Niharika: What's up? [03:22:16] VectorBeta appears as a Beta feature just fine, rdwrer. The other one, mine, doesn´t. [03:22:23] Hm. [03:22:24] Weird. [03:22:31] Well at least you aren't breaking other features anymore [03:22:34] Let me look again. [03:22:37] Yeah. [03:22:39] Okay. [03:23:20] Oh, right, it works for me. [03:24:29] Niharika: Can you tell me what versions of MediaWiki and BetaFeatures you are running? If they aren't the latest, update them. [03:24:29] Any idea about what could possibly cause this problem? [03:24:45] Okay. [03:25:46] Mediawiki - 1.23 alpha and BetaFeatures- version 0.1. rdwrer. [03:26:03] Hm [03:26:47] Niharika: Can you run "git fetch --all && git checkout master && git reset --hard origin/master" on both of them? [03:27:32] rdwrer: Okay. [03:27:44] Sounds scary. [03:28:17] Heh, it's not that scary [03:39:53] rdwrer: When you ask me to run git fetch -- all, you mean to fetch it from the mediawiki repo on GitHub right? [03:40:39] Uh [03:40:40] No [03:40:44] I mean run those commands [03:40:45] Exactly [03:40:54] Copy and paste them [03:48:15] rdwrer: I get this: Fetching gerrit [03:48:15] fatal: Project not found: mediawiki/core/git [03:48:15] fatal: Could not read from remote repository. [03:48:15] Please make sure you have the correct access rights [03:48:15] and the repository exists. [03:48:16] error: Could not fetch gerrit [03:50:19] (03CR) 10Chad: [C: 032] Do not use OutputPage to output exceptions in Installer [core] - 10https://gerrit.wikimedia.org/r/112243 (owner: 10Brian Wolff) [03:54:21] (03Merged) 10jenkins-bot: Do not use OutputPage to output exceptions in Installer [core] - 10https://gerrit.wikimedia.org/r/112243 (owner: 10Brian Wolff) [03:58:33] ...what [03:58:54] Niharika: Can you run "git remote -v" and pastebin the result? [03:59:07] In general don't paste more than 1 or 2 lines in IRC, plesae [03:59:16] Okay. [04:00:25] https://dpaste.de/TPaJ [04:00:34] rdwrer: ^ [04:01:33] Niharika: git remote set-url gerrit ssh://Niharika29@gerrit.wikimedia.org:29418/mediawiki/core.git [04:01:36] Then try again [04:08:34] rdwrer: To do the same for BetaFeatures, I need to add the remote for it, right? [04:08:44] No [04:08:49] It should be fine [04:09:31] Okay. Done that. But still the same thing. [04:10:29] Niharika: That's really strange [04:10:43] Niharika: Put another die() call in the beta features hook, make sure it's getting called [04:10:55] Can anyone help me with Lua? [04:11:29] I'm trying to return mw.site.stats(users), but it seems to return a table and not a number [04:11:30] Techman224: Hello! When you're on IRC it's usually good practice to jump right in and ask a question, as it saves time for everyone involved :) how can we help you? [04:11:58] rdwrer: Okay, the die doesnt do anything. So the onGetBetaFeaturePreferences function isn´t being called... [04:12:16] OK [04:12:33] Niharika: Put a die() in the BetaFeatures.php file, anyplace [04:12:44] rdwrer: Okay! [04:12:59] If that doesn't cause trouble, you don't have BetaFeatures enabled [04:13:09] rdwrer: That breaks it. [04:13:11] Seems unlikely [04:13:13] OK, good [04:13:18] Delete that [04:13:31] Done. [04:13:46] Techman224: AFAICT, you should be doing mw.site.stats.users, not mw.site.stats(users) [04:14:08] rdwrer, oh so stats isn't a function [04:15:06] (03PS1) 10Mattflaschen: Disable UndefinedFunctionCheck [vagrant] - 10https://gerrit.wikimedia.org/r/112638 [04:15:22] Putting a die before the hook for the Beta feature breaks it as well. [04:15:30] It's a table according to the docs [04:16:29] Huh. [04:18:40] (03PS15) 10Prtksxna: [WIP] Add Triangle/Pokey to the NavigationPopups [WIP] [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111773 [04:18:42] (03PS7) 10Prtksxna: Add `redirects to` message at the top of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111983 [04:18:43] And the initial onGetPreferences function is being called too. Only this function isn´t, somehow. [04:18:44] (03PS8) 10Prtksxna: Add time ago in words at the bottom of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 [04:20:17] rdwrer, now how do I insert commas into a number [04:20:39] I have 20709568, and I want 20,709,568 [04:21:25] Techman224: Turn it into a string and do a regex replacement on it, I guess [04:21:41] Techman224: What language? [04:21:51] There are usually pre-made functions to do that kind of thing. [04:21:55] Gloria, Lua [04:21:59] Oh, eep. [04:22:08] {{formatnum: }}? :-) [04:22:08] https://www.mediawiki.org/wiki/formatnum:Template:_ [04:22:13] Hah [04:22:22] Stupid bot. [04:22:24] https://www.mediawiki.org/wiki/Extension:Scribunto/Lua_reference_manual#mw.language:formatNum [04:22:27] so yeah [04:22:45] I see it [04:23:00] https://www.mediawiki.org/wiki/Help:Magic_words#Formatting [04:23:06] You can do it in wikitext. [04:23:09] True story. [04:23:16] Or you could not do it in wikitext please god why [04:23:19] :P [04:23:34] Lua is faster right? [04:23:45] What's the rush? [04:23:47] "yes" or something [04:29:55] I need to create a new language object to use the formatNum method [04:31:26] Or wrap your output in the parser function. [04:33:16] I'll just get the lang code from the wiki itself [04:33:26] <^d> Or hack Parser.php to look for the string you want, and have it append the output. [04:43:14] I don't understand how this test is failing, https://en.wikipedia.org/wiki/Module_talk:NumberUsers/testcases [04:48:07] (03CR) 10Skizzerz: [C: 032 V: 032] Remove $wgMaintenanceScripts [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/112634 (owner: 10Chad) [04:50:45] (03CR) 10EBernhardson: [C: 032] terms-of-use text should wrap [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111670 (owner: 10Matthias Mullie) [04:51:02] (03Merged) 10jenkins-bot: terms-of-use text should wrap [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111670 (owner: 10Matthias Mullie) [04:53:10] rdwrer, could you help fix it? [04:54:19] Huh, that seems to be a passing test in disguise [04:56:45] (03CR) 10EBernhardson: [C: 031] Move flow( 'loadReplyForm' ) to base/action.js (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108634 (owner: 10Matthias Mullie) [05:00:58] (03PS16) 10Prtksxna: [WIP] Add Triangle/Pokey to the NavigationPopups [WIP] [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111773 [05:19:56] (03CR) 10EBernhardson: [C: 04-1] "also, after todays merges, the getHex calls need to turn into getAlphadecimal." (038 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111366 (owner: 10Matthias Mullie) [05:21:56] (03PS17) 10Prtksxna: Add Triangle/Pokey to the NavigationPopups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111773 [05:28:06] (03PS18) 10Prtksxna: Add Triangle/Pokey to the NavigationPopups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111773 [05:33:18] (03CR) 10Prtksxna: Add JS/CSS for the new NavigationPopups (031 comment) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [05:53:14] (03PS1) 10Chad: Return early when page id is less than 1 [core] - 10https://gerrit.wikimedia.org/r/112641 [06:10:18] (03CR) 10TTO: ""Back to top" links are important for accessibility. However a JavaScript implementation is not really so accessible." [core] - 10https://gerrit.wikimedia.org/r/108323 (owner: 10Gerrit Patch Uploader) [06:15:09] zz_yuvipanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=61167 [06:23:43] yurik around? did u see the mail i have sent you about codecademy's response? [06:24:07] diwanship, hi, not yet, looking.... [06:24:36] ok [06:27:10] diwanship, you could ask him about the status of export/import, so that you can easily export everything and re-import part of it into a separate guide [06:27:37] (03PS2) 10Aaron Schulz: Cleanups to LoadMonitor [core] - 10https://gerrit.wikimedia.org/r/112635 [06:27:51] diwanship, also, while they are thinking about it, would you like to get our regular documentation better with some of the stuff you learnt? [06:28:08] diwanship, i mean - https://www.mediawiki.org/wiki/API:Main_page [06:28:24] it certainly could use lots of help :) [06:30:55] you mean to edit API:Main page with my new learnt stuff [06:31:03] exactly [06:31:11] and make it much shorter / easier to read [06:31:13] :) [06:31:38] i mean - we can always move extra details into subpages/further down, but make the intro shorter and easier to get started [06:32:38] (03CR) 10Chad: "Accessibility for whom?" [core] - 10https://gerrit.wikimedia.org/r/108323 (owner: 10Gerrit Patch Uploader) [06:32:55] ya sure i'll surely do that. :) wat i was thinking dnt knw when they will have import/export functionality till then i was thinking to make a personal folder where i'll take all the backup of the exercises [06:34:14] that could also work, but might be much longer - but in any case, lets follow their guideline and make it shorter / break it into two [06:34:19] yurik wat about the count of exercises they have comented on [06:34:29] ? [06:34:38] if that's their guideline, sure, lets follow it [06:34:46] one guide - for the query [06:34:49] one - for everything else [06:35:09] and one - if they allow it later (or if i can make a workaround or if we switch to python and it works) - for editing [06:36:55] so we'd have to create another course for each of them. [06:38:23] (03PS5) 10TTO: Add $wgLocalInterwikis to handle multiple local prefixes [core] - 10https://gerrit.wikimedia.org/r/110162 [06:38:23] yurik for the current course you r the admin , so will you create the other or i should? [06:42:31] diwanship, go ahead and create a new one(s) as you need [06:42:39] yurik also when u say one guide for query and other for evrything else, then the evrything else part only conatin parsing and query includes lists,prop and meta (which again totals 35 exercises) [06:42:55] only for query [06:43:04] hmm... [06:43:10] query is 35 total? [06:43:17] yes [06:43:31] m thinking to merge some concepts which are almost same [06:43:46] bummer... how do you think we can split it up? [06:44:39] i would like to bring the core things - concepts - like continuation, supplying titles/pageids/generators, as the first tutorial, and the second could be less used functions... not sure which though [06:45:19] pick the ones that you think will be more in-depth and put them into the 2nd query tutorial? [06:45:34] or if you think some of them can be removed as too obscure? [06:46:20] yes we can do something like basic concepts and core concepts [06:48:02] yurik by first and 2nd tutorial you mean two different courses? [06:48:56] diwanship, yes - more like "basic - which includes intro to parse & query), and advanced - which should include the rest of query [06:51:54] yurik , ok i'll start working on this. what about editing? to be very frank i have very basic knowledge of python though dats y having difficulty in implementing the script you gave me [06:52:29] diwanship, its ok, we could postpone editing until we figure out a better way to demo it [06:53:29] ok but still i'll think about it implementing by php [06:56:35] yurik can u explain me the comment by Nikhil "we generally don't support authenticated api(s)" does this mean that we can't do the editing part anyway untill and unless they don't support it [06:56:47] ? [06:57:24] diwanship, well, they do support some sort of an authenticated api (there is a dropdown to select it during course creation), but i guess it takes them considerable effort to add it [06:59:40] ohhh okk. thanks [07:03:33] yurik i'll create a course as a collaborator course and add you in that. is it ok? [07:03:45] diwanship, sure [07:04:09] can u give me your usrname for codecademy [07:04:24] diwanship, it should be in the other course [07:04:35] okkk yes i got it [07:23:23] RoanKattouw: hey, do you have some time to help me debug using WikiEditor on a custom textarea in an extension? [07:23:37] Not really [07:23:42] I have to be on Caltrain in 10 hours [07:23:44] :/ [07:23:46] ah [07:24:00] can I send you an email? [07:24:26] Sure [07:32:19] legoktm: CodeEditor? [07:32:26] no, WikiEditor. [07:32:35] I mean, that sounds like what CodeEditor does. [07:32:40] What's the question? [07:33:00] I'm trying to load WikiEditor on a custom textarea created by an extension [07:33:09] and it's not really working [07:33:26] the dom looks like its getting modified correctly, but the whole interface doesn't show up [07:38:27] legoktm: Pastebin your code? [07:38:32] one sec [07:38:34] (03PS1) 10Legoktm: Load WikiEditor in textarea input [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/112642 [07:38:37] Gloria: ^ [07:38:46] (03CR) 10jenkins-bot: [V: 04-1] Load WikiEditor in textarea input [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/112642 (owner: 10Legoktm) [07:39:55] The ext.MassMessage.editor.js is basically what ext.wikiEditor.js is, with a different #id [07:41:05] Probably just need to skim the WikiEditor code. It probably wants a particular HTML structure. [07:41:08] Or something. [07:41:10] It's late. [07:41:55] https://github.com/wikimedia/mediawiki-extensions-WikiEditor/blob/master/modules/jquery.wikiEditor.js [07:42:04] * @example To intialize without any modules: [07:42:04] * $( 'div#edittoolbar' ).wikiEditor(); [07:42:27] oh wait [07:42:35] is that for a div? [07:42:49] * legoktm tries [07:43:08] Yeah, that was my thought. It might bind to a wrapper rather than the textarea itself. [07:43:17] Or something. [07:45:53] rappers [07:46:41] wait but [07:46:50] https://github.com/wikimedia/mediawiki-extensions-WikiEditor/blob/master/modules/ext.wikiEditor.js [07:46:53] $( '#wpTextbox1' ).wikiEditor(); [07:46:59] which is the