[00:26:44] (03PS1) 10Varnent: Update to 1.0.20140209 - changelog on MediaWiki.org [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/112408 [00:28:22] (03Abandoned) 10Varnent: Improve UTF-8 and links support [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/108331 (owner: 10Dereckson) [00:29:44] (03CR) 10Varnent: [C: 032 V: 032] Update to 1.0.20140209 - changelog on MediaWiki.org [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/112408 (owner: 10Varnent) [00:36:55] (03CR) 10Anomie: "> I suspect this is because the values are added in a" [core] - 10https://gerrit.wikimedia.org/r/107389 (owner: 10Anomie) [00:41:05] (03PS2) 10Anomie: Add newlines around scribunto-doc-page-show wikitext [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/110575 [00:41:12] (03CR) 10Tim Starling: [C: 032] Add newlines around scribunto-doc-page-show wikitext [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/110575 (owner: 10Anomie) [00:44:05] (03Merged) 10jenkins-bot: Add newlines around scribunto-doc-page-show wikitext [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/110575 (owner: 10Anomie) [00:45:48] (03PS2) 10Anomie: Fix PHP implementation of mw.ustring %W [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/111467 [00:45:55] (03CR) 10Tim Starling: [C: 032] Fix PHP implementation of mw.ustring %W [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/111467 (owner: 10Anomie) [00:48:22] (03Merged) 10jenkins-bot: Fix PHP implementation of mw.ustring %W [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/111467 (owner: 10Anomie) [00:52:44] i've been seeing a lot of edits that look like https://en.wikipedia.org/w/?diff=594748481 recently. is there some tool that formats templates like that automatically and adds all the extra fields? [02:12:03] (03CR) 10Dereckson: "Follow-up: see change I0372c272d9bdada1978f9d92be763253ee93200c." [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/108331 (owner: 10Dereckson) [02:32:44] any gci winner here? [02:38:54] (03PS1) 10Ori.livneh: Break up roles.pp into individual role files [vagrant] - 10https://gerrit.wikimedia.org/r/112413 [02:41:40] (03CR) 10Ori.livneh: "Feedback appreciated. I'm not 100% sure about this." [vagrant] - 10https://gerrit.wikimedia.org/r/112413 (owner: 10Ori.livneh) [02:51:06] (03CR) 10Isarra: [C: 031] "I'm going to +1 this because even though I have no way of testing it, the same goes for most people here - and if it gets merged, it's the" [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz) [02:56:33] (03PS8) 10Legoktm: Add preliminary MS SQL support [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz) [03:00:56] (03CR) 10jenkins-bot: [V: 04-1] Add preliminary MS SQL support [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz) [03:49:35] (03PS4) 10Isarra: New class for parsing MediaWiki:Sidebar-like messages into modern, nested navigation menus. [core] - 10https://gerrit.wikimedia.org/r/108045 (owner: 10Jack Phoenix) [03:50:47] (03CR) 10jenkins-bot: [V: 04-1] New class for parsing MediaWiki:Sidebar-like messages into modern, nested navigation menus. [core] - 10https://gerrit.wikimedia.org/r/108045 (owner: 10Jack Phoenix) [04:00:39] (03PS5) 10Prtksxna: Add hook for BetaFeatures [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112006 [04:02:36] (03PS6) 10Ori.livneh: mediawiki.user: Remove #name and #anonymous; deprecate #bucket [core] - 10https://gerrit.wikimedia.org/r/111422 [04:11:37] (03PS11) 10Anomie: Use the new limit report hooks [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/53804 [04:11:48] (03CR) 10Tim Starling: [C: 032] Use the new limit report hooks [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/53804 (owner: 10Anomie) [04:11:54] (03PS1) 10Gnosygnu: v1.2.2.1 [xowa] - 10https://gerrit.wikimedia.org/r/112419 [04:15:09] (03Merged) 10jenkins-bot: Use the new limit report hooks [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/53804 (owner: 10Anomie) [04:25:17] (03PS9) 10Skizzerz: Add preliminary MS SQL support [core] - 10https://gerrit.wikimedia.org/r/105138 [04:26:49] (03PS10) 10Legoktm: Add preliminary MS SQL support [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz) [04:29:10] (03CR) 10jenkins-bot: [V: 04-1] Add preliminary MS SQL support [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz) [04:34:16] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/112419 (owner: 10Gnosygnu) [04:35:04] (03PS12) 10Prtksxna: [WIP] Add Triangle/Pokey to the NavigationPopups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111773 [04:35:05] (03PS4) 10Prtksxna: Add `redirects to` message at the top of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111983 [04:35:07] (03PS5) 10Prtksxna: Add time ago in words at the bottom of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 [04:35:11] (03CR) 10Prtksxna: Add time ago in words at the bottom of the popup (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 (owner: 10Prtksxna) [04:38:59] (03PS11) 10Skizzerz: Add preliminary MS SQL support [core] - 10https://gerrit.wikimedia.org/r/105138 [04:39:38] (03PS12) 10Legoktm: Add preliminary MS SQL support [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz) [04:46:13] (03CR) 10Legoktm: [C: 031] "Tests are passing and code looks good. I'll +2 this in a few days if no one has any objections. And what Isarra said." [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz) [04:47:53] (03CR) 10Legoktm: "Schema change is now complete on WMF wikis, so this should probably be abandoned." [core] - 10https://gerrit.wikimedia.org/r/107415 (owner: 10Reedy) [05:44:06] (03CR) 10Adamw: "Cool! My only regret is that so much machinery is declared in roles in the first place. I'd rather see anything longer than "include ::o" [vagrant] - 10https://gerrit.wikimedia.org/r/112413 (owner: 10Ori.livneh) [05:45:29] (03CR) 10Adamw: Break up roles.pp into individual role files (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/112413 (owner: 10Ori.livneh) [05:54:10] (03CR) 10Adamw: "On second thought, the global configuration belongs in a separate file such as site.pp. That would go a long way towards unjunking-up rol" [vagrant] - 10https://gerrit.wikimedia.org/r/112413 (owner: 10Ori.livneh) [06:54:24] (03PS2) 10Pastakhov: add Variable handling Functions [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/112000 [06:55:35] (03CR) 10Pastakhov: [C: 032] add Variable handling Functions [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/112000 (owner: 10Pastakhov) [06:55:40] (03Merged) 10jenkins-bot: add Variable handling Functions [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/112000 (owner: 10Pastakhov) [07:01:29] (03CR) 10Adamw: "lol, good judgement call!" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/112311 (owner: 10Adamw) [08:28:13] helllo [08:29:11] hi hashar [08:29:14] good morning! [08:38:37] (03PS4) 10AndyRussG: No undeletion of courses of deleted institutions [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110143 [08:40:54] morning! [08:44:23] (03PS5) 10AndyRussG: No undeletion of courses of deleted institutions [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110143 [08:51:40] (03CR) 10AndyRussG: No undeletion of courses of deleted institutions (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110143 (owner: 10AndyRussG) [09:20:43] (03PS1) 10MaxSem: Kill $wgEnablePopups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112430 [09:23:05] (03CR) 10Yuvipanda: [C: 032 V: 032] "Hmm, does make sense." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112430 (owner: 10MaxSem) [09:50:41] (03CR) 10Hashar: [C: 032] Standardize file headers [tools/scap] - 10https://gerrit.wikimedia.org/r/112320 (owner: 10Ori.livneh) [09:50:43] (03Merged) 10jenkins-bot: Standardize file headers [tools/scap] - 10https://gerrit.wikimedia.org/r/112320 (owner: 10Ori.livneh) [09:52:24] (03CR) 10Hashar: "If we want to run unit tests in a tox maintained virtual env, I am pretty sure we need a setup.py entry point to have our code installed i" [tools/scap] - 10https://gerrit.wikimedia.org/r/112036 (owner: 10Hashar) [09:53:20] (03CR) 10Ori.livneh: [C: 04-1] qunit: Add SinonJS utility (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111634 (owner: 10Krinkle) [09:56:48] (03CR) 10Physikerwelt: "ok. I'll try to find out how to run "rake"... Probably it would be a good idea to configure Jenkins to check for all those coding style as" [vagrant] - 10https://gerrit.wikimedia.org/r/112355 (owner: 10Physikerwelt) [10:21:48] Can somebody tell me how and where in the code is "Login" button (which is on the top-right corner) generated ?? [10:42:48] (03CR) 10Hashar: "Should we just abandon that and handle the generation of a dedup id in logstash?" [core] - 10https://gerrit.wikimedia.org/r/108890 (owner: 10Hashar) [10:43:52] (03PS3) 10Netbrain: Fixed bug where variables referenced where not reachable (out of scope) [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/97902 [10:44:09] jme: the login page is generated by includes/specials/SpecialUserlogin.php [10:45:02] jme: and we also have includes/templates/Userlogin.php [10:48:47] hashar: Actually, I am working on bug https://bugzilla.wikimedia.org/show_bug.cgi?id=57523 . And I am not able to locate How "Login with Persona" button generated. [10:49:24] no idea what persona is [10:49:49] hashar: no problem .. Thanks [10:49:51] jme: seems to comes from http://www.mediawiki.org/wiki/Extension:Persona [10:50:01] hashar: yeah .. [10:50:19] the text itself is in Persona.i18n.php [10:50:29] 'persona-login' => 'Login with Persona', [10:50:37] so you want to look for "persona-login" in the actual code [10:50:57] ie https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FPersona/e6d69c2e0194117ea7f1e064849195371b4e6259/Persona.php#L153 [10:52:14] hashar: yeah .. but I also found out that Persona extension is not installedon mediawiki https://en.wikipedia.org/wiki/Special:Version . So, Is it usefull to work on this bug or not? [10:52:28] probably not :-] [10:53:16] jme: we have some bugs at https://www.mediawiki.org/wiki/Annoying_little_bugs [10:53:31] jme: they should be easy to fix and have some worthwhile impact [10:54:01] and even if someone already has sent a patch for them, you can still test the patches and comment about it in Gerrit :-] [10:54:33] an example is https://gerrit.wikimedia.org/r/#/c/106625/ [10:54:59] which is to make Special:Whatlinkshere.php transcludable (i.e. have the ability to include it in an article to show other articles pointing to it) [11:05:14] (03PS5) 10Kunalgrover05: Implement listing for tracking categories [core] - 10https://gerrit.wikimedia.org/r/112323 [11:14:43] (03CR) 10Hashar: "I need to reproduce the issue :/" [core] - 10https://gerrit.wikimedia.org/r/112033 (owner: 10Anomie) [11:19:16] (03CR) 10Helder.wiki: [C: 031] Allow posting in all talk namespaces by default [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94698 (owner: 10Legoktm) [11:22:32] hashar: did you say something? My connection was lost :/ [11:23:27] (03CR) 10Prtksxna: Add hook for BetaFeatures (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112006 (owner: 10Prtksxna) [11:29:11] (03CR) 10Helder.wiki: [C: 031] Fix undefined variable [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/112152 (owner: 10Legoktm) [11:29:13] (03PS13) 10Prtksxna: [WIP] Add Triangle/Pokey to the NavigationPopups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111773 [11:29:16] (03PS5) 10Prtksxna: Add `redirects to` message at the top of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111983 [11:29:17] (03PS6) 10Prtksxna: Add time ago in words at the bottom of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 [11:40:23] (03PS6) 10Prtksxna: Add hook for BetaFeatures [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112006 [11:42:22] Hey andre__, how can I register a new component on bugzilla for https://www.mediawiki.org/wiki/Extension:Popups [11:42:43] prtksxna, https://www.mediawiki.org/wiki/Bug_management/Project_Maintainers#To_add_a_project_or_component [11:44:21] andre__: Thanks! Will add. [11:46:08] prtksxna, thanks! https://bugzilla.wikimedia.org/enter_bug.cgi?product=Wikimedia&component=Bugzilla [11:46:37] andre__: The link you sent had a link to that :) [11:47:23] (03CR) 10Yuvipanda: [C: 04-1] "The feature description also is rather terrible." (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112006 (owner: 10Prtksxna) [11:48:54] (03PS7) 10Prtksxna: Add hook for BetaFeatures [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112006 [11:49:08] (03CR) 10Prtksxna: Add hook for BetaFeatures (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112006 (owner: 10Prtksxna) [11:50:20] (03CR) 10Yuvipanda: Add hook for BetaFeatures (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112006 (owner: 10Prtksxna) [11:56:49] (03PS8) 10Prtksxna: Add hook for BetaFeatures [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112006 [11:58:04] (03CR) 10Yuvipanda: [C: 032 V: 032] Add hook for BetaFeatures [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112006 (owner: 10Prtksxna) [12:00:04] andre__: Added :) https://bugzilla.wikimedia.org/show_bug.cgi?id=61136 Thank you! [12:01:45] prtksxna, I'll do that later today :) [12:01:51] andre__: Thanks :) [12:12:56] (03CR) 10Hashar: [C: 031] "So I managed to reproduce the issue which happens when running:" [core] - 10https://gerrit.wikimedia.org/r/112033 (owner: 10Anomie) [12:22:55] (03CR) 10Prtksxna: Add `redirects to` message at the top of the popup (033 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111983 (owner: 10Prtksxna) [12:25:47] (03CR) 10Daniel Kinzler: [C: 031] "Looks fine, needs manual testing. Or, better, actual test cases - if we had phpunit tests for this, i could have given +2." [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 (owner: 10Jackmcbarn) [12:28:09] Thank you andre__ \o/ [12:28:17] (03CR) 10Daniel Kinzler: [C: 031] "not tested. i can haz unit test?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111159 (owner: 10Bene) [12:29:00] (03CR) 10Prtksxna: Add `redirects to` message at the top of the popup (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111983 (owner: 10Prtksxna) [12:33:02] (03CR) 10Daniel Kinzler: "Note that this logic may be factored out of the Title class soon. Watch out for regressions." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender) [12:33:27] (03PS5) 10Hashar: Adding DonationInterface test runner [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/71727 (owner: 10MarkTraceur) [12:39:51] (03CR) 10QChris: "Upstream merged this change into stable-2.8." [gerrit] (wmf) - 10https://gerrit.wikimedia.org/r/112201 (owner: 10QChris) [12:54:27] (03PS6) 10Hashar: Adding DonationInterface test runner [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/71727 (owner: 10MarkTraceur) [12:55:16] (03CR) 10Hashar: "fixed up path to PHPUNIT" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/71727 (owner: 10MarkTraceur) [13:00:27] (03PS1) 10Hashar: trigger mwext-DonationInterface-testextensions-master [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112440 [13:00:51] Dereckson: are you around? [13:01:38] (03CR) 10Hashar: [C: 032] "Will try to get the DonationInterface tests to be runnable using:" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112440 (owner: 10Hashar) [13:01:42] (03Merged) 10jenkins-bot: trigger mwext-DonationInterface-testextensions-master [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112440 (owner: 10Hashar) [13:02:42] (03CR) 10Hashar: "Trying with the generic job Zuul triggers are https://gerrit.wikimedia.org/r/#/c/112440/" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/71727 (owner: 10MarkTraceur) [13:05:15] matanya: aye [13:05:20] Hello. [13:05:45] hi, i have a question about right names [13:06:11] some wikis have the right interface_editor as a user right [13:06:35] but the hebrew wiki calls it editinterface [13:06:50] would renaming the right need database changes? [13:07:22] Indeed for the name of groups. [13:07:33] It's a custom group with some rights to edit templates? [13:07:41] the interface [13:07:44] not templated [13:07:46] see wmf-config/InitialiseSettings.php [13:08:40] i think the group name should be consistnt, and have a ptch for that [13:08:56] but not sure what would be the inpact of the change, or the rights included [13:09:07] for ckb. for example, interface_editor is the name of the group, editinterface the right [13:09:22] to have a group name different than the right name avoids some confusion. [13:09:37] yes, that is my point [13:09:49] especially as I see for ckb. they have extra rights [13:09:52] he. wants also 'editusercss' => true, │./src/metasploit/lib/msf/core/exploit/.svn/prop-base/pdf.rb.svn-base [13:10:14] no exploits please :) [13:10:17] he. wants also editusercss and edituserjs, or just editinterface? [13:10:31] (It's the result of find . | grep noms | grep pdf on a tmux window) [13:10:34] are the former included in the latter? [13:10:53] (in a folder I've a checkout of A LOT of open source projects) [13:11:15] for ckb. interface_editor group include 3 rights, editinterface, editusercss, edituserjs, they are independant rights [13:12:33] since hewiki editinterface has much more rights than ckb it can't be the same, correct? [13:13:17] and the abuse filter settings should be moved to the abuse filter settings [13:14:07] so not sure what would be the best way to handle this Dereckson [13:15:02] rdwrer: Around? [13:38:28] (03CR) 10KartikMistry: [C: 031] "LGTM" [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/110174 (owner: 10Reza) [13:44:53] Anyone who can help me a bit with the BetaFeatures extension? I am trying to make a feature appear in the list of available Beta Features but I´m getting some errors. I have followed everything given here: https://www.mediawiki.org/wiki/Extension:BetaFeatures exactly. [13:45:03] (03Abandoned) 10Zfilipin: WIP Moved Selenium tests from browsertests repository [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/92879 (owner: 10Zfilipin) [13:47:31] This is the backtrace: https://dpaste.de/NwJE [13:51:13] SVG is making me do dirty things :( [13:57:34] Hello everyone [13:57:50] i have a particular question concerning the WebChat extension, and i've tried searching for the answer online, to no avail [13:58:03] i'm trying to build a intranet mediawiki site, with a IRC server, also running only in the local network. the purpose is to provide a working team a documentation and local chat service through Mediawiki [13:58:14] so, my mediawiki is, up, WebChat extension is also up, but i cant seem to configure it so it points to the local irc server...any thoughtS? [14:01:21] (03PS18) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 [14:02:33] changed it irc client... [14:03:28] Anyone online bya ccident? [14:07:32] oops, wrong channel, apologies. goodday everyone! [14:27:27] (03PS1) 10Raimond Spekking: Consistency tweaks [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112451 [14:28:39] (03PS19) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 [14:29:05] (03PS20) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 [14:31:23] (03PS21) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 [14:37:55] (03PS14) 10Prtksxna: [WIP] Add Triangle/Pokey to the NavigationPopups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111773 [14:37:57] (03PS6) 10Prtksxna: Add `redirects to` message at the top of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111983 [14:37:59] (03PS7) 10Prtksxna: Add time ago in words at the bottom of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 [14:38:09] (03CR) 10Yuvipanda: [C: 032 V: 032] "Thanks for the patch!" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112451 (owner: 10Raimond Spekking) [14:41:40] (03PS7) 10Aude: Add QuickTemplateAfterPortlet hook to add html after portlets [core] - 10https://gerrit.wikimedia.org/r/101895 [14:42:07] (03PS8) 10Aude: Add BaseTemplateAfterPortlet hook to add html after portlets [core] - 10https://gerrit.wikimedia.org/r/101895 [14:44:02] (03CR) 10Anomie: [C: 04-1] "This wikitext:" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98078 (owner: 10Nikerabbit) [14:51:37] (03CR) 10Nikerabbit: "Anomie: Any suggestions how to do that without having hooks to deal with both lckey and uckey?" [core] - 10https://gerrit.wikimedia.org/r/98078 (owner: 10Nikerabbit) [14:52:51] hashar: I have a question concerning jenkins... is texvc installed at all at jenkins I would have expected that this test throws an error at least [14:52:52] https://gerrit.wikimedia.org/r/#/c/112353/ [14:53:35] https://integration.wikimedia.org/ci/job/mwext-Math-testextensions-master/596/console [14:53:47] the tests can't find texvc so the tests ends up being skipped [14:54:03] physikerwelt: ^^ [14:54:29] (03CR) 10Anomie: "Calculate $lckey before the hook and pass it to the hook. Require the hook to return any result in lckey format (should be easy for them)." [core] - 10https://gerrit.wikimedia.org/r/98078 (owner: 10Nikerabbit) [14:59:43] hashar: Jenkins did not run the new test [15:00:02] https://gerrit.wikimedia.org/r/#/c/112353/1/tests/MathParserTests.php [15:00:17] the test is called testAdd [15:00:29] it's not listed in the output [15:00:51] the other tests are manually marked with skip-test annotations [15:01:12] locally the test works fine [15:01:49] well [15:01:50] http://integration.wikimedia.org/ci/job/mwext-Math-testextensions-master/596/testReport/(root)/MathParserTests/ [15:01:56] apparently the file has been found [15:02:51] probably I should change the file name [15:02:59] or class name [15:03:01] worth a try :-) [15:03:10] (03PS6) 10Anomie: Expose mw.log data on preview [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/55602 [15:04:04] Hi hashar. Do you know what went wrong here? https://integration.wikimedia.org/ci/job/mwext-VisualEditor-npm/777/console [15:04:23] Krenair: what does it say? [15:04:34] 22:07:22 npm ERR! Error: EROFS, open '/home/jenkins-deploy/.npm/ee270f24-grunt-contrib-jshint-0-7-2.lock' [15:04:47] EROFS [15:04:48] bah [15:04:55] sounds like filesystem is dead :D [15:05:04] :D... [15:05:34] homeDirectory: /home/jenkins-deploy [15:05:46] which is the stupid GlusterFS [15:06:27] rm: cannot remove `11c3833f-npm-grunt-cli-0-1-11-package-tgz.lock': Read-only file system [15:06:27] :( [15:06:42] any clue how to instruct NPM to write to a different directory than ~/.npm ? :] [15:06:42] (03PS1) 10Physikerwelt: Separate Mathoid from the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112454 [15:06:54] nope, sorry [15:11:08] (03PS2) 10Physikerwelt: DO NOT SUBMIT: (Jeninks test) MathParser tests [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 [15:12:01] Krenair: so there are two issues: The first is that GlusterFS is dead on integration project [15:12:14] the second is that the user jenkins-deploy uses /home/ (GlusterFS) as a home dir [15:12:20] should be /mnt, the local instance disk [15:17:00] hashar, so fixing either of these should get the test working again then [15:17:48] yup [15:17:59] I have filled https://bugzilla.wikimedia.org/show_bug.cgi?id=61141 for the GlusterFS issue [15:19:38] (03PS2) 10MathiasLidal: Added support for html comments within sidebarmenu syntax, this allows for adding comments within the syntax. [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/102083 (owner: 10Netbrain) [15:20:13] (03CR) 10MathiasLidal: [C: 032 V: 032] Added support for html comments within sidebarmenu syntax, this allows for adding comments within the syntax. [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/102083 (owner: 10Netbrain) [15:25:50] (03PS4) 10Nikerabbit: New hook MessageCache::get [core] - 10https://gerrit.wikimedia.org/r/98078 [15:26:41] (03CR) 10jenkins-bot: [V: 04-1] New hook MessageCache::get [core] - 10https://gerrit.wikimedia.org/r/98078 (owner: 10Nikerabbit) [15:29:41] and https://bugzilla.wikimedia.org/show_bug.cgi?id=61144 to migrate jenkins-deploy homedir under /mnt [15:31:37] Niharika: Followed it *exactly*? [15:32:18] rdwrer: There was some obvious change in syntax, so besides changing that, I did all the steps listed. [15:33:05] Niharika: And you have the extension working otherwise, and it's loaded? [15:33:25] rdwrer: It is loaded and shows up on the Special:Version page too. [15:34:02] Hm. [15:34:16] Niharika: Can you put a die() call in your BetaFeatures hook? [15:34:22] Make sure it's getting called. [15:34:46] rdwrer: Okay. [15:35:08] (03PS3) 10Physikerwelt: DO NOT SUBMIT: (Jeninks test) MathParser tests [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 [15:36:19] rdwrer: I see a message showing some Uncommitted DB transactions. What could cause that? [15:36:33] hashar: for some reason my new class MathCoverageTest is not found by jenkins [15:36:39] Heh, probably the die() did that [15:37:01] physikerwelt: no idea [15:37:13] Niharika: When you load Special:Preferences, do you see the full page? [15:37:17] physikerwelt: jenkins uses: cd tests/phpunit && php phpunit.php --testsuite extensions [15:37:32] so the test files have to be registered using the UnitTestFile hook [15:37:55] oh stupid me [15:38:02] rdwrer: No, after the die(), I get a blank page. I get the Uncommitted DB trans. message before the die(). [15:38:10] 'kay [15:38:14] hashar, I think that bug is quite important, I know at least on the VE repo any new patchset will get Verified-1 due to this [15:38:24] Krenair: yeah [15:38:30] Niharika: I don't really mind the uncommitted thing, but we know the hook is running at least. Can I see the content of the hook? [15:38:35] Krenair: all nom tests are being run on labs instance :( [15:38:45] rdwrer: I´ll dpaste it. [15:38:47] Krenair: mind you, I dont have merge access on puppet repo :D [15:38:57] (03PS5) 10Nikerabbit: New hook MessageCache::get [core] - 10https://gerrit.wikimedia.org/r/98078 [15:40:38] rdwrer: https://dpaste.de/ppTT#L22,23,24,25,26,27,28,29 [15:41:29] Niharika: And that function is registered as a hook...can I see that code too? [15:42:30] rdwrer: https://dpaste.de/Qfcw#L28 [15:42:55] (03PS1) 10Raimond Spekking: Message has no translatable content -> ignore it [core] - 10https://gerrit.wikimedia.org/r/112462 [15:43:00] 'kay... [15:43:06] (03PS4) 10Physikerwelt: DO NOT SUBMIT: (Jeninks test) MathParser tests [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 [15:43:11] (03CR) 10Raimond Spekking: [C: 032 V: 032] Message has no translatable content -> ignore it [core] - 10https://gerrit.wikimedia.org/r/112462 (owner: 10Raimond Spekking) [15:43:28] Niharika: Now, let's try this: It looks like the onGetPreferences function has a bunch of non-beta-status things in it [15:43:44] (03CR) 10Anomie: [C: 04-1] Add lllangname= and llautonym= for action=query&prop=langlinks (033 comments) [core] - 10https://gerrit.wikimedia.org/r/112245 (owner: 10Umherirrender) [15:43:55] rdwrer: Okay... [15:44:13] Niharika: Let's put that function back as a GetPreferences hook, and pull the BetaFeature definition into a new function onGetBetaFeaturesPreferences [15:44:15] (03PS2) 10Umherirrender: Provide language names on action=parse&prop=langlinks [core] - 10https://gerrit.wikimedia.org/r/112332 [15:44:20] Then register that as the BF hook [15:44:23] (03CR) 10Anomie: [C: 032] "May as well." [core] - 10https://gerrit.wikimedia.org/r/112332 (owner: 10Umherirrender) [15:44:30] (03CR) 10jenkins-bot: [V: 04-1] DO NOT SUBMIT: (Jeninks test) MathParser tests [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [15:44:45] rdwrer: Okay. I´ll be back in ten minutes. [15:44:48] And do that. [15:44:49] 'kay! [15:44:57] I'll be around, though I need to get ready for work [15:45:10] rdwrer: No problem. Thanks. [15:45:56] hashar: thank you. Now everything works as expected... only texvc is missing... but that was expected [15:46:12] physikerwelt: what was the error ? [15:46:39] physikerwelt: ahhhh goooood find [15:46:52] the classname was xxxTests.php rather than xxxTest.php [15:47:21] physikerwelt: one day we will have to get mediawiki/core to detect extension test files for us and registerer them automatically instead of relying on the UnitTestList hook [15:48:41] yes... that's a good idea... however I would be happy if texvc could be installed at jenkins [15:49:50] the dataProvider annotation works perfect [15:51:35] (03Merged) 10jenkins-bot: Provide language names on action=parse&prop=langlinks [core] - 10https://gerrit.wikimedia.org/r/112332 (owner: 10Umherirrender) [15:51:54] (03PS6) 10Anomie: New hook MessageCache::get [core] - 10https://gerrit.wikimedia.org/r/98078 (owner: 10Nikerabbit) [15:52:37] the project test overview looks really bad now 387 broken test cases https://integration.wikimedia.org/ci/job/mwext-Math-testextensions-master/ [15:55:55] (03CR) 10Anomie: [C: 031] "Looks good to me. Not +2ing yet in case Parent5446 or Legoktm want to re-review; remind me on Wednesday if someone else doens't merge soon" [core] - 10https://gerrit.wikimedia.org/r/98078 (owner: 10Nikerabbit) [16:09:53] Niharika: Much luck? [16:10:09] rdwrer: Not yet. Gimme a minute. [16:11:15] 'kay, no rush :) [16:11:29] rdwrer: Yay! Errors are gone. :D [16:11:37] Woohoo! [16:11:59] But my feature doesn´t appear in the list. [16:12:18] rdwrer: No feature appears in the list. It´s empty. [16:12:30] OK. [16:12:49] Niharika: Can you paste the hooks file and the main file one more time, so I can debug a bit? :) [16:13:04] rdwrer: Sure! Moment. [16:13:10] Actually, Niharika, is this a patch you'll soon submit to Gerrit? Can you submit it as a WIP? [16:13:36] i.e. commit, put "WIP" at the start of the commit message, and push it to gerrit so I can see it [16:14:10] rdwrer: I was gonna push it to gerrit. Okay, I´ll add WIP to the commit msg. What does it stand for? [16:14:25] Work In Progress - makes sure nobody will merge it :) [16:15:09] Okay. [16:15:31] I was planning to push it as a new PS in 104793, actually. [16:15:45] With the rest of my work. [16:16:41] That's fine, as long as I can look at the diff to sort out what's wrong [16:16:58] rdwrer: https://dpaste.de/7wLh and https://dpaste.de/A2Zx#L17 [16:17:17] Niharika: MyExtensionHooks should be UniversalLanguageSelectorHooks [16:17:29] Oh, sorry. [16:17:51] Not a problem :) [16:18:32] rdwrer: Corrected. Still doesnt appear as a Beta Feature. [16:18:57] rdwrer: I can dpaste the complete files if thatĺl be more useful. [16:18:59] Niharika: Next, the label-message and desc-message should be i18n keys [16:19:09] Which is super ironic for a ULS change :) [16:19:24] rdwrer: Oops. Yes. I´ll fix that too. [16:19:25] Niharika: See https://www.mediawiki.org/wiki/Messages_API [16:20:25] rdwrer: But that doesn´t have anything to do with the feature not appearing in the list or does it? [16:20:53] It might, I'm not sure yet :) [16:21:04] Okay. [16:21:27] The rest of it looks fine, so I'm *hoping* that's the issue [16:21:44] Because otherwise we need to try debugging more intensively [16:22:01] Niharika: After you fix the message thing, pushing it to Gerrit would be helpful so I can debug locally [16:22:01] rdwrer: Okay. I´ll get back to you once I fix that. [16:22:13] And I can do that from the office [16:22:16] rdwrer: Okay. Thanks for all the help. :) [16:22:23] Meaning I'll be gone for about 20 minutes or so [16:22:32] No problem. [16:30:10] (03CR) 10Hashar: "Well done! Sorry for the delay :D" [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [16:33:20] hashar: do you think it's a good idea to replace the parserTests by PHPUnit tests [16:34:12] i.e. generated files like that one https://gerrit.wikimedia.org/r/#/c/112353/4/tests/ParserTest.data might be unwanted [16:34:24] physikerwelt: Brion wrote the parser tests as a set of integration tests because we kept breaking the parser [16:34:32] I guess you want a mix of them [16:34:40] a lot of unit tests to finely cover your functions [16:34:46] and all tricky corner cases that might happens [16:35:00] then a few high level integration tests to make sure the usual business cases are working [16:35:22] of course, if you dont like the existing .txt parser tests, you can well write your own system [16:35:39] and if you have LOT of bandwidth / time, you could even start a new system in mw/core :] [16:37:41] hashar: My goal is that people can design a page that is used for testing. What I'm doing at the moment could be covered with the parserTests as well. It's not a big difference to write the tests to a text file or use the serialze php function [16:38:25] the serialized data is also a bit hard to read/understand [16:40:28] yes I agree... It's not made for reading but the test output gives readable errors and you have to look at a page that contains the pictures to dceide what's wrong [16:42:08] in general I like the parser tests... but I think the phpunit tests are easier to maintain and to understand [16:42:21] there are some people that know phpunit [16:44:13] will you try to re-enable texvc at jenkins or should I try to do it myself? [16:48:55] (03CR) 10Legoktm: "Needs I60b61d635eb3ab033dc9cc8d8bbf751e2221acc8 in Echo to be merged first." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/98257 (owner: 10Legoktm) [16:49:23] (03PS10) 10Aude: Add RCCacheEntryBuilder, split from EnhancedChangesList and cleaned up [core] - 10https://gerrit.wikimedia.org/r/97742 [16:49:25] (03CR) 10Bene: "Apparently there don't exist any tests for SkinTemplate or did I miss something?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111159 (owner: 10Bene) [16:57:44] hashar: Do you have a few minutes to chat about the tox+pbr patch for scap? [17:11:41] bd808: ah sorry forgot to ping ya :( [17:11:54] bd808: I am heading out, need some fresh air, but should be around later in my evening [17:12:02] bd808: or we can talk about it tomorrow ? There is no urgency :-] [17:12:07] (03PS1) 10Manybubbles: Don't do the phrase boost for queries with syntax [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112480 [17:12:15] bd808: unless you want to bit ori in the merge race hehe [17:12:18] hashar: Later or tomorrow are both ok with me. [17:12:33] bd808: so tomorrow, I guess a bunch of conf calls tonight [17:12:52] hashar: Sounds good. I just didn't want to forget about it. :) [17:13:00] bd808: feel free to reply on the gerrit change if you want, so I can proceed your remarks tomorrow morning while you sleep. Might save some time [17:13:08] * bd808 nods [17:13:43] bah 6pm15 and there instill some sun outside [17:13:50] spring is coming!! \O/ [17:15:40] off see you later [17:16:15] (03PS11) 10Aude: Add RCCacheEntryBuilder, split from EnhancedChangesList and cleaned up [core] - 10https://gerrit.wikimedia.org/r/97742 [17:22:18] No sun here, isn't hashar supposed to be at higher latitude than me [17:24:41] (03CR) 10Bartosz Dziewoński: [C: 031] "Note that this currently breaks at least two widely used scripts across WMF wikis: https://en.wikipedia.org/wiki/MediaWiki:FileUploadWizar" [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh) [17:25:06] (03PS1) 10Physikerwelt: Change format of the gnerated phpunit coverage tests [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/112481 [17:29:15] greg-g: Do you know if there's a plan to re-enable ULS in a single deploy, or just to let it trickle out with the train? https://gerrit.wikimedia.org/r/#/c/108988/ got merged 5 hours ago… [17:30:26] (03PS5) 10Physikerwelt: Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 [17:30:30] (03CR) 10Nikerabbit: New hook MessageCache::get (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98078 (owner: 10Nikerabbit) [17:30:37] (03CR) 10jenkins-bot: [V: 04-1] Coverage tests for the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [17:31:10] James_F: I believe it is all at once [17:31:30] Nikerabbit: ^^ [17:31:37] greg-g: Do you know when? Want to update the timing for asking people to use it… [17:32:01] yeah, I forgot to give them back their window, Tuesday at 2am Pacific [17:32:11] they're old window time [17:32:13] Aha, so "tonight"? [17:32:16] their [17:32:17] * Their [17:32:19] shush [17:32:22] yes [17:32:22] Kk. [17:33:11] (03CR) 10Matthias Mullie: "Jakobj: well, $revision not really an "optional" parameter. Not like how optional parameters are mostly config-directives with a default v" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112158 (owner: 10Matthias Mullie) [17:33:47] greg-g: I think tomorrow is too early [17:34:48] (03CR) 10Chad: [C: 032] Don't do the phrase boost for queries with syntax [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112480 (owner: 10Manybubbles) [17:34:53] (03Merged) 10jenkins-bot: Don't do the phrase boost for queries with syntax [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112480 (owner: 10Manybubbles) [17:35:25] (03PS1) 10Manybubbles: Remove two attributes we no longer need [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112483 [17:35:31] greg-g: the train would be next opportunity [17:35:33] (03PS2) 10Manybubbles: Remove two attributes we no longer need [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112483 [17:36:10] (03CR) 10Manybubbles: "We're performing the required links after the release train this week." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112483 (owner: 10Manybubbles) [17:36:12] (03CR) 10Physikerwelt: [V: 04-1] "Please do not submit until jenkis is happy." [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [17:37:49] physikerwelt: there is a 'n' before the 's' [17:38:54] Niharika: Oh, wow, not only does your patch remove the ULS preference and not register a beta feature, it removes any beta features that exist on the wiki [17:38:57] Fuuuuun [17:39:08] :O [17:39:19] * rdwrer continues looking [17:39:20] (03PS3) 10Chad: Wrap texvccheck call in PoolCounter [extensions/Math] - 10https://gerrit.wikimedia.org/r/111916 [17:39:34] (03CR) 10Physikerwelt: "I mean Jenkins thank you Nemo_bis" [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [17:39:35] The ULS remains intact though, right? [17:40:04] Nikerabbit: k, one sec, in meeting [17:40:12] Niharika: You did the i18n wrong, so let me see if fixing that fixes everything [17:40:37] rdwrer: Okay. Sorry about that. [17:41:38] <^d> physikerwelt: I amended gerrit 111916 to only wrap texvccheck for now. [17:41:50] <^d> It'd be nice to wrap texvc as well, but we can do that as its own change :) [17:42:00] I tested it locally and it works for me [17:42:17] It's OK, Niharika [17:42:29] but how to verify it on a test cluster [17:43:22] Niharika: Heh, no luck, the message wasn't the issue [17:43:23] <^d> Long as it works with the default core implementation we should be fine [17:44:12] Oh, that´s bad. [17:44:22] Yeah, but it's OK, I'm still debugging [17:44:28] ^d so you think it's save to merge? [17:45:37] <^d> physikerwelt: Yeah. Long as you've tested locally I'm fine with you merging. [17:45:43] <^d> I wouldn't mind getting it live ;-) [17:46:24] OH [17:46:46] Niharika: You did $wgHooks['GetBetaFeaturePreferences'] = '...'; [17:46:46] (03CR) 10Physikerwelt: [C: 032] "Tested locally. Works as before." [extensions/Math] - 10https://gerrit.wikimedia.org/r/111916 (owner: 10Chad) [17:46:56] Niharika: You should have done $wgHooks['GetBetaFeaturePreferences'][] = '...'; [17:47:02] * yuvipanda ellipsises rdwrer [17:47:06] Oh. [17:47:07] It works after changing that [17:47:30] I owe you one more sorry for that, rdwrer. And thanks a lot. [17:47:34] Niharika: I'm still not sure why the ULS preference doesn't appear after your patch, though [17:47:45] Let me push the fixed version :) [17:48:01] ^d Thank you. I hope it will improve the performance problems [17:48:21] By the way I think it's save to merge this one as well https://gerrit.wikimedia.org/r/#/c/112454/ [17:48:25] yuvipanda: Read this: http://www.nytimes.com/2014/02/10/technology/wikipedia-vs-the-small-screen.html?partner=rss&emc=rss&_r=0 ? [17:48:31] Niharika: ooh, nice! [17:48:34] (03CR) 10GWicke: "We should maybe leave a note where this is moved to (the new mediawiki/services/mathoid repository or github?)." [extensions/Math] - 10https://gerrit.wikimedia.org/r/112454 (owner: 10Physikerwelt) [17:48:40] Niharika: thanks! :) I will! [17:48:47] :) [17:48:59] Ugh, Gerrit doesn't want me to push it. [17:49:11] <^d> physikerwelt: What it'll help do is keep the Apache servers stable from too many texvccheck processes causing them to fall over. [17:49:18] I´ll do it, just tell me how to fix the i18n? rdwrer [17:49:26] <^d> We'll set some max number of processes and max number to queue. [17:49:38] Niharika: So, you need to add two messages to UniversalLanguageSelector.i18n.php [17:49:52] I went with 'uls-betafeature-label' and 'uls-betafeature-desc' [17:49:56] Okay. [17:50:09] Those should hold the title of the feature and a longer description of it (but only 255 characters or so) [17:50:18] Got it. [17:50:43] Niharika: Then put those exact strings in the hook call, instead of a literal English string [17:51:00] rdwrer: Alright. [17:52:23] (03CR) 10Physikerwelt: "I'd vote for mediawiki/services/mathoid." [extensions/Math] - 10https://gerrit.wikimedia.org/r/112454 (owner: 10Physikerwelt) [17:53:03] (03CR) 10BryanDavis: "Hashar wrote:" [tools/scap] - 10https://gerrit.wikimedia.org/r/112036 (owner: 10Hashar) [17:53:11] (03PS24) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [17:53:27] (03CR) 10GWicke: "ok, will pull that into mediawiki/services/mathoid then" [extensions/Math] - 10https://gerrit.wikimedia.org/r/112454 (owner: 10Physikerwelt) [17:53:31] (03CR) 10jenkins-bot: [V: 04-1] [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [17:53:57] rdwrer: But it still doesn´t add the feature in the Beta Feature list, does it? [17:54:24] (03CR) 10GWicke: "Can you add a note like a MOVED file in the mathoid dir for a while so that people know where to look?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/112454 (owner: 10Physikerwelt) [17:54:26] It will after you fix i18n and the hook registry [17:54:27] (03PS12) 10Aude: Add RCCacheEntryBuilder, split from EnhancedChangesList and cleaned up [core] - 10https://gerrit.wikimedia.org/r/97742 [17:54:34] hoo: review ^ :) [17:54:57] or anyone else review ^ [17:55:02] heh [17:55:16] (03PS25) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [17:56:36] (03PS13) 10Aude: Add RCCacheEntryBuilder, split from EnhancedChangesList and cleaned up [core] - 10https://gerrit.wikimedia.org/r/97742 [17:56:41] kill the whitespace [17:56:42] (03CR) 10Physikerwelt: "ok probably it's better to wait until the repository is created. Some people don't like github." [extensions/Math] - 10https://gerrit.wikimedia.org/r/112454 (owner: 10Physikerwelt) [17:57:48] https://gerrit.wikimedia.org/r/#/c/101895/ also up for review [17:59:08] aude: Talking about review... there's still https://gerrit.wikimedia.org/r/106226 which is a smallish thing in gerrit for a month now... [17:59:28] (03Abandoned) 10Aude: Add tests for EnhancedChangesList class [core] - 10https://gerrit.wikimedia.org/r/93611 (owner: 10Aude) [17:59:35] (03CR) 10Physikerwelt: "I created a request at https://www.mediawiki.org/wiki/Git/New_repositories/Requests" [extensions/Math] - 10https://gerrit.wikimedia.org/r/112454 (owner: 10Physikerwelt) [17:59:37] rdwrer: You´re sure you fixed only the i18n and the hook registry? It still doesn´t show up as a Beta Feature for me. :( [17:59:48] oh, yeah [18:00:07] Niharika: Can you push a new patchset so I can make sure you fixed it? [18:00:15] rdwrer: Yep. [18:00:23] (03CR) 10Jakobj: "Ok, sorry. Shouldn't we keep this in the doc block?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112158 (owner: 10Matthias Mullie) [18:02:13] (03CR) 10GWicke: "See my already processed request on that page. The mathoid repo was already created." [extensions/Math] - 10https://gerrit.wikimedia.org/r/112454 (owner: 10Physikerwelt) [18:03:01] rdwrer: Uploaded. [18:05:29] Niharika: It works fine for me [18:05:40] Hi any mentors here? [18:06:13] rdwrer: Okay. Doesn´t work for me. Where should I start debugging from? [18:06:28] Niharika: Start by clearing your cache and seeing if that fixes it [18:06:31] Your browser cache [18:06:36] Okay. [18:06:42] (03PS1) 10BryanDavis: Convert scap-1 to python [tools/scap] - 10https://gerrit.wikimedia.org/r/112487 [18:06:43] ishan1604: Hello! When you're on IRC it's usually good practice to jump right in and ask a question, as it saves time for everyone involved :) how can we help you? [18:07:34] Are there any android projects that I can contribute to? [18:08:26] I believe so! yuvipanda knows something about that, I'll defer to him. [18:09:00] Nikerabbit: so, you all don't want to have a separate window to do the enablement? [18:09:09] hi ishan1604! [18:09:22] Hi @yuvipanda [18:09:48] ishan1604: have you done much android work before? [18:09:51] rdwrer: That did not help. Where else could the problem be? [18:10:00] Niharika: Honestly I have no idea [18:10:05] Yes Sir I have about 1.5 Years of experience on Android platform [18:10:24] rdwrer: Okay. Thanks for the help. :) [18:10:30] ishan1604: :) No need to call any of us 'Sir' :) [18:10:31] (03PS2) 10Physikerwelt: Separate Mathoid from the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112454 [18:10:38] (03CR) 10BryanDavis: Convert scap-1 to python (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/112487 (owner: 10BryanDavis) [18:10:43] Niharika: I know you have BetaFeatures installed and working properly, so that's not it...wait, does the beta tab in preferences still show up totally empty? Can you try installing e.g. VectorBeta and seeing if that adds a preference? [18:10:47] Ok Yuvipanda :) [18:11:06] rdwrer: Okay, I will. [18:11:11] ishan1604: so we are rewriting the wikipedia android app with native code now. it is a mix of Java and JS. Have you done much work with IntelliJ before? [18:11:14] (03CR) 10Physikerwelt: "oups... I did not see that." [extensions/Math] - 10https://gerrit.wikimedia.org/r/112454 (owner: 10Physikerwelt) [18:11:33] !e VectorBeta | Niharika [18:11:33] Niharika: https://www.mediawiki.org/wiki/Extension:VectorBeta [18:12:01] I have been using Eclipse for all this time. But have recently switched to android studio and a gradle build. [18:12:03] greg-g: perhaps later, but I'll try to get a definite answer [18:12:20] but deployment train looks viable option too [18:12:47] Nikerabbit: comfortable with that (I assume yes, just making sure :) ) [18:12:54] ishan1604: ah, hmm. IntelliJ is almost exactly the same as Android Studio, but a bit more stable [18:13:33] What's the build system that you use? Ant , Gradle or Maven ? [18:16:19] greg-g: yeah... actually I could use the window tomorrow to deploy https://gerrit.wikimedia.org/r/#/c/112435/ which prepares the config but does not change anything [18:16:52] Nikerabbit: the 8 UTC time? [18:18:40] rdwrer: I´ll catch you tomorrow? It´s kinda late in my timezone. Thanks for all the help. I´ll try and see if VectorBeta works tomorrow. [18:18:54] KK, cheers [18:19:19] (03CR) 10Springle: [C: 031] "+1 for the schema change bits. Greg mentioned you're ok with doing these yourself during the deployment window, which is fine by me :-)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [18:20:20] greg-g: yeah that's the usual time, right? [18:20:54] yep [18:21:02] just confirming, sorry, I'm a confirmer :) [18:21:56] (03CR) 10Chad: "Serialized PHP isn't the best format for storing data--it's absolutely impossible to read. Is there a reason this can't be provided by an " [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [18:22:16] @yuvipanda are you still here ? [18:22:29] ishan1604: sorry, in a meeting, give me about 5 minutes [18:22:31] ishan1604: and we use maven :) [18:22:37] ishan1604: github.com/wikimedia/apps-android-wikipedia [18:22:45] ishan1604: ignore the README file and give it a shot [18:23:03] sure [18:23:33] (03PS11) 10Bsitu: Add corresponding *_user_wiki field to all *_user_id fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 [18:24:41] (03PS1) 10Manybubbles: Remove thumbnail captions from search text [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112488 [18:24:55] (03PS10) 10EBernhardson: base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 [18:25:00] ishan1604: back! try that out? [18:25:07] (03CR) 10jenkins-bot: [V: 04-1] base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 (owner: 10EBernhardson) [18:25:14] ishan1604: import that into IntelliJ or Android Studio? I've not really used Android studio much though [18:25:20] I have never used Maven [18:25:35] But I feel the wikipedia folder can be imported into eclipse [18:25:39] and I can easily compile it [18:25:53] give me 2 minutes to have the app running on my nexus [18:28:09] (03PS3) 10Physikerwelt: Separate Mathoid from the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112454 [18:28:33] (03CR) 10Physikerwelt: "@GWicke anything else to do before we can merge?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/112454 (owner: 10Physikerwelt) [18:31:57] (03CR) 10GWicke: [C: 032] "Can you remove the request for the repo? I'll pull the code & add you to the admin group for the repo." [extensions/Math] - 10https://gerrit.wikimedia.org/r/112454 (owner: 10Physikerwelt) [18:32:04] (03Merged) 10jenkins-bot: Separate Mathoid from the Math extension [extensions/Math] - 10https://gerrit.wikimedia.org/r/112454 (owner: 10Physikerwelt) [18:38:47] This code looks quite clumsy and looks like there's a lot of work that needs to be done [18:45:40] ishan1604: :D yeah, it's a heavy work in progress. [18:45:58] I suspect a lot of refactors will be done over time. [18:46:08] the onCreate's are too large for my liking, for example [18:46:25] ishan1604: pick something you consider clumsy and try to fix it? [18:46:50] Network Calls :D [18:47:42] Looks like my Eclipse messed up with the Code Hierarchy [18:47:48] that you created using maven [18:48:04] I have a huge load of Errors :p [18:48:22] (03CR) 10Chad: "I'm on the fence on this. I can see it as being usually the right thing to do...with edge cases where you wouldn't want to." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112488 (owner: 10Manybubbles) [18:49:00] ishan1604: interesting. what do you consider wrong with the network calls? [18:49:29] Nothing's Wrong Till an app is working [18:49:59] But I feel we can use some syntactical sugar and Libraries that could ease the App Flow [18:50:19] I would like to know Are we using a RESTful service ? [18:51:33] James_F: update/clarification: just prep for ULS going out tonight, full thing rides the train starting Thurs [18:52:15] Also I just saw You are Parsing JSON manually. Wow! [18:52:27] greg-g: Aha. Thanks. [18:52:40] @yuvipanda There seriously is Ample of work :D [18:53:00] ori: do you have time to look at https://gerrit.wikimedia.org/r/#/c/107759/3 ? [18:53:15] (03PS1) 10Bsitu: Flow mention should respect Echo mention preference [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112493 [18:53:34] ishan1604: Reflection on Android is really slow, and the Mediawiki API doesn't really have set 'return' values that can be serialized into set classes [18:53:47] ishan1604: the mediawiki API is not remotely close to RESTful :) [18:53:52] let me find you some documentation links [18:53:57] (03PS2) 10Bsitu: Flow mention should respect Echo mention preference [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112493 [18:54:18] ishan1604: http://mediawiki.org/wiki/API:Main_page is starting point for the mediawiki API docs [18:54:28] James_F: Nikerabbit what I have: https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=98833&oldid=98832 (note both additions) [18:54:43] (03PS11) 10EBernhardson: base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 [18:55:28] On it Now. But I need to figure a way out to compile the Code. Because I seriously think its gonna be foolish on my part to Download a Third IDE just for Android :p [18:56:14] Don't you think Apache Ant builds faster than Gradle or Maven. Though Gradle has an edge over the other two. [18:56:27] ishan1604: well, Ant and Maven are different tools, no? [18:56:32] ishan1604: Maven does dependency management, which Ant does not [18:56:45] Ant is an Automation Tool yeah. [18:56:53] It ships with the Eclipse IDE [18:56:56] I am using Maven primarily for the dependency management [18:57:13] hmm, I've not used eclipse at all in about a year and a half. [18:57:40] I love Java because there is Eclipse on this Earth Haha ! [18:57:42] greg-g: Thanks. [18:57:56] (03CR) 10Chad: "This test sucks :\" [core] - 10https://gerrit.wikimedia.org/r/112147 (owner: 10Chad) [18:58:17] ishan1604: heh, you probably shouldn't ask me about my opinions on eclipse then :) [18:58:56] True. Also tell me what is the wikipedia-it folder for ? [18:59:07] ishan1604: it has tests! [18:59:14] Ohk [18:59:21] 'it' is 'integration tests' [18:59:28] Alright :) [18:59:35] What do you use for Testing ? [19:00:03] ishan1604: just the default instrumentation runners. [19:00:03] Need to spend some time looking at other ones. [19:00:03] and maybe setup Roboelectric [19:00:06] espresso from google looked promising, but it seems to have gone the same way as Volley [19:00:11] (unsupported code dumps) [19:00:37] Espresso is real good. [19:00:51] Also do you guys have a Remote Error Logging Mechanism setup yet ? [19:01:40] nope, we have ACRA that emails to me :) [19:02:53] Dude ! ACRA is what i was Talking about. [19:02:56] :) [19:03:01] They have something called Acralyzer. [19:03:08] we don't ship logcat output, however. privacy concerns, etc [19:03:10] an open source backend reports analysis webapp built on a full open stack. [19:03:18] yeah, I haven't setup that yet. [19:03:39] hey guys [19:03:40] ishan1604: what would be more useful is some form of out-of-band auto-update thing for nightly builds [19:03:53] ishan1604: so you can install an apk once, and then it notifies you every time I push a new test build [19:04:48] this is for the development phase ? [19:04:54] ishan1604: yeah [19:05:20] How do you think can you perform an Auto-Update of the app ? [19:05:34] Lest the app is installed from Play Store [19:05:47] @sarthakmeh Hi [19:06:39] ishan1604: you can't do an auto-update [19:06:46] i see some android talks going on [19:06:48] ishan1604: but you can do a notification saying 'new update available, download apk again!' [19:06:56] Yup that;s possible [19:07:00] And Very Easy [19:07:03] We can use GCM [19:07:08] Google Cloud Messaging Service [19:07:12] pfft. where will you push to GCM from? [19:07:39] Any Server or even a localhost [19:07:53] isn't it easier to just have the APK file sit on a server at a constant URL, do a 'HEAD' HTTP request, compare last modified date, and see if it is newer than current one, and if so pop up message to user saying 'click to download new apk'? [19:08:36] Sounds Nice! I have never used a HEAD Request. [19:08:53] ishan1604: it is just like a regular request, but returns only the HTTP headers [19:09:20] Ahh Ok. [19:10:09] (03PS1) 10EBernhardson: Only pass strings to mysqli::real_escape_string [core] - 10https://gerrit.wikimedia.org/r/112494 [19:10:16] ishan1604: this could easily be another separate, much simpler app [19:10:16] that we can distribute through regular channels [19:10:16] makes the actual app code less complicated [19:10:16] You mentioned JS being used in the Android App. Where ? [19:10:35] ishan1604: look at the folder called www/ [19:10:43] ishan1604: the rendering of the article content is managed by JS [19:11:27] So we have a Webview in the app to which we inflate a Webpage with HTML, CSS and JS. ? [19:12:05] ishan1604: yup [19:12:15] (03CR) 10BryanDavis: Convert scap-1 to python (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/112487 (owner: 10BryanDavis) [19:12:16] and then we communicate with the JS running inside it [19:12:48] Anyone know how long it takes for the page cache to expire? [19:12:51] (on wmf sites) [19:13:12] Krenair: the HTML cache? 30 days for anons, I remember reading somewhere. [19:13:21] I think MatmaRex was involved in that 'somewhere' as well [19:13:22] Don't you think its slow? [19:13:22] damn. ok. [19:14:00] ishan1604: what is the alternative? [19:14:16] (03CR) 10Aaron Schulz: [C: 032] Only pass strings to mysqli::real_escape_string [core] - 10https://gerrit.wikimedia.org/r/112494 (owner: 10EBernhardson) [19:14:17] ishan1604: we are just using it as a dumb way to display HTML. The entire app isa bout 6000 lines of Java but about 200 lines of JS [19:14:34] Regular Fragments [19:14:39] (03Abandoned) 10Aaron Schulz: Avoid setting $wgTitle in runJobs.php [core] - 10https://gerrit.wikimedia.org/r/103399 (owner: 10Aaron Schulz) [19:14:54] They are much more faster in rendering and processing for sure. [19:14:57] ishan1604: Wikipedia uses HTML. How will you display HTML with regular fragments? [19:15:16] this does use fragments as well - each WebView is encapsulated in a PageViewFragment that also does a bunch of other stuff [19:15:22] :p [19:15:33] The main purpose is to remove the WebView [19:15:45] Can't we do something like this [19:15:47] :) Noble purpose! [19:15:55] our old app was Phonegap. was slow and sucked [19:15:59] I am happy we got rid of that [19:16:11] Phonegap is the worst thing that could ever happen to any OS [19:16:47] we agree :) [19:17:00] ishan1604: but I'll be interested to see how you can display HTML proper without using a webview [19:17:15] Wikipedia URL -> JSON -> Some Parsing -> XML Layout Inflation [19:17:36] Why do you want to display HTML. When the Sole purpose is to just show the Data. [19:17:48] (03Merged) 10jenkins-bot: Only pass strings to mysqli::real_escape_string [core] - 10https://gerrit.wikimedia.org/r/112494 (owner: 10EBernhardson) [19:19:03] ishan1604: :) Have you looked at the JSON data returned? [19:19:06] let me give you a URL, wait [19:19:20] I saw the URL didn't make a request Yet. [19:19:50] (03PS1) 10Phuedx: Canonicalize excluded category names [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/112496 [19:20:00] ishan1604: look at https://en.wikipedia.org/wiki/Special:ApiSandbox#action=mobileview&format=json&page=India§ions=all&prop=text%7Csections§ionprop=level%7Cline&noheadings= [19:20:04] hit 'make request' [19:20:06] look at the JSON [19:20:18] and tell me how you can convert that into proper XML Layouts :) [19:20:29] that's just the JSON for the India article [19:21:14] Holy Shit That's JSON :O [19:21:30] :) [19:21:58] Anyone know anything about math equations going missing from Extension:Book PDF export thing? [19:22:00] ishan1604: it is! [19:22:25] Krenair: mwalker might, but he isn't around now :( [19:22:45] I only see the HTML [19:22:45] ishan1604: but to be more exact, it is just HTML chopped up and put in different pieces of JSON :) [19:23:14] I need to make a GET Request right ? [19:24:29] Where do i Put the Search Param in this request? [19:24:29] http://en.wikipedia.org/w/api.php?format=json&action=query&titles=Main%20Page&prop=revisions&rvprop=content [19:25:17] hey guys i am android developer and interested in contributing to wikimedia [19:25:21] Ahh got it! [19:25:29] can someone tell me from where i can start [19:26:37] (03PS3) 10Aaron Schulz: Simplified Swift backend to use maxConns flag in MultiHttpClient [core] - 10https://gerrit.wikimedia.org/r/108152 [19:26:50] gwicke: any time to look at https://gerrit.wikimedia.org/r/#/c/108152/ [19:27:03] ishan1604: :) [19:27:17] Who's fault is it :D [19:27:18] ? [19:27:26] (03CR) 10jenkins-bot: [V: 04-1] Simplified Swift backend to use maxConns flag in MultiHttpClient [core] - 10https://gerrit.wikimedia.org/r/108152 (owner: 10Aaron Schulz) [19:27:27] ishan1604: en.wikipedia.org/w/api.php?action=mobileview&format=json&page=India§ions=all&prop=text%7Csections§ionprop=level%7Cline&noheadings= will get you that directly [19:27:28] AaronSchulz: not yet, sorry [19:27:31] ishan1604: which one? the HTML? [19:27:41] AaronSchulz, on my list for this afternoon [19:27:42] Yup [19:27:51] ishan1604: heh. Mediawiki is ver, *very* flexible, and that results in things like that. [19:27:51] such a bad way of sending a response [19:28:01] gah, merge conflict [19:28:15] ishan1604: it is just a simple document management system, so it sends back documents. You can't have flexibility *and* structure at the same time [19:28:24] it is a tradeoff, and MW's picks flexibility [19:29:18] Ok [19:29:27] I have an Idea tell me how viable it is [19:29:53] As we see the major Content in the JSON is HTML right? [19:30:03] it would be having a DOM [19:30:11] ishan1604: in *this* particular response, yes :) [19:30:16] it does, yes [19:30:32] The DOM remains same throughout the requests ? [19:31:05] If we code a Parse in Java that Can Parse DOM and then convert it into a Pretty JSON response? [19:31:10] Parser* [19:31:28] Then use Gson for ORM [19:31:29] ishan1604: it has to support *all* valid HTML, and also inline CSS. [19:32:16] How about using this ? [19:32:17] http://jsoup.org/ [19:32:19] :) [19:32:25] oh, just stupid whitespace changes [19:32:42] ishan1604: what will you do with all the inline CSS? :) [19:33:56] it is possible with Jsoup [19:34:12] If the style is embedded in your Element you just have to use .attr("style") [19:34:29] there is a css style called 'transition' that does animation [19:34:29] you will have to support that [19:34:39] how would you? [19:35:28] (03CR) 10Chad: Remove two attributes we no longer need (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112483 (owner: 10Manybubbles) [19:35:44] 1. Jsoup is open source [19:35:55] 2. We can always code [19:36:03] (03CR) 10Manybubbles: Remove two attributes we no longer need (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112483 (owner: 10Manybubbles) [19:36:07] ishan1604: I am not saying it can't be done :) I am saying what advantage will it give you, at all? [19:36:15] Ok [19:36:16] ishan1604: you are essentially now writing a mediawiki specific renderer [19:36:25] that re-implements half of HTML and css [19:36:45] (03PS3) 10Manybubbles: Remove two attributes we no longer need [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112483 [19:36:51] So when the Json comes in with HTML we convert it into Pretty JSON and then use it in the app. [19:36:58] (03CR) 10Chad: [C: 032 V: 032] Keep status:closed's limit below MySQL Connector/J's hard limit [gerrit] (wmf) - 10https://gerrit.wikimedia.org/r/112201 (owner: 10QChris) [19:37:01] Serves the app in a better manner, doesn't it? [19:37:24] ishan1604: how so more than just using a webview to render it? [19:38:17] I don't know. I don't really vouch for Webviews. [19:38:33] ishan1604: heh :) They are okay as generic HTML renderers, methinks. [19:38:50] HTML is, IMO, rather perfect for this - it is a markup language meant for documents, and wiki pages *are* documents [19:39:37] I second your opinion. But then the quality of app isn't to that mark. I'd prefer browsing Wikipedia on Chrome on Android than using the App. [19:39:43] what do you think about it? [19:39:50] ishan1604: you haven't even built or tried out the app yet :P [19:40:08] (03PS1) 10EBernhardson: Create maintenance mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112498 [19:40:11] I have tried the one I downloaded from the play store. [19:40:21] And wasn't quite satisfied. [19:40:24] ishan1604: that is github.com/wikimedia/WikipediaMobile [19:40:28] Haven't yet tried the one you sent me [19:40:33] ishan1604: it sucks, but is distinctly different from what this one is [19:40:34] Ahh [19:40:44] Is it the phonegap one ? [19:40:46] ishan1604: that one used Phonegap, and this one does not. at all. [19:40:52] the old one is PhoneGap [19:41:16] Woah. Okay, I'll take your word. And will build this one and try it out. [19:41:52] ishan1604: :D You shouldn't take my word! Do try it out and build it and we can work towards fixing it if it isn't good enough :) [19:42:00] I really still think that HTML can be converted into pretty Json. [19:42:20] And I'd surely Submit this as one of my projects in GSOC [19:42:28] this summer. [19:42:35] ishan1604: :) [19:42:46] ishan1604: I don't disagree that it can be, just that it's a *lot* of work [19:43:07] ishan1604: plus, the mobile app is only about 5% of wikipedia's traffic. there's the desktop site, and then there's the mobile website. [19:43:13] what can they do with pretty JSON? [19:43:51] Well it can be run on top of the Main API, and other users (If any) consume your web api, can be helped. [19:44:03] Agree ? [19:44:14] Who doesn't love Pretty Json :p [19:44:45] ishan1604: it's the wrong tool for the job, I think :) [19:44:54] but I guess we'll just have differing opinions. 'tis ok [19:46:13] Hmm..You surely have the experience. And I don't disagree that it is a lot of work. [19:47:29] ishan1604: :) it's a re-implementation of webkit on top of Android's Layout libraries. [19:48:04] (03PS2) 10EBernhardson: Create maintenance mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112498 [19:48:09] ishan1604: either way, try to build it? I'll be around for another hour, and can help with any issues [19:48:55] Ok I'll try to build it. Will ping here in case I come across any issues [19:49:12] (03CR) 10Chad: "This seems like an hhvm-specific workaround, why was it not guarded with wfIsHHVM()?" [core] - 10https://gerrit.wikimedia.org/r/112494 (owner: 10EBernhardson) [19:49:45] ishan1604: :) [19:49:47] (03PS1) 10Manybubbles: Don't search text wrapped in nosearch class [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112500 [19:50:30] Also is there anything on the Android Front, MW is planning to go forward with this summer in GSOC ? [19:50:48] (03PS4) 10Aaron Schulz: Added pipelining and max connection support to MultiHttpClient [core] - 10https://gerrit.wikimedia.org/r/108151 [19:50:50] (03PS4) 10Aaron Schulz: Simplified Swift backend to use maxConns flag in MultiHttpClient [core] - 10https://gerrit.wikimedia.org/r/108152 [19:51:16] ishan1604: not sure yet. Usually students just hunt around for projects to work on and convince mentors to take them on :) we will probably also put on a list of projects, but that's not exlusive [19:51:28] ^d: does https://gerrit.wikimedia.org/r/#/c/110210/ look ok? [19:51:49] (03PS2) 10Manybubbles: Don't search text wrapped in nosearch class [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112500 [19:52:03] Ohh Okay ;) [19:52:33] LOL see this is what is the Example Jsoup.org has used on their Main Page [19:52:37] Document doc = Jsoup.connect("http://en.wikipedia.org/").get(); [19:52:37] Elements newsHeadlines = doc.select("#mp-itn b a"); [19:52:43] <^d> AaronSchulz: I guess? Postgres is a mystery to me [19:53:23] ishan1604: yeah, screen scraping. TERRIBLE thing. should just use the API [19:53:35] :p [19:53:38] true [19:54:14] But its fun. I like scrapped some data about 65000 Medicines/Drugs from a website I couldn't get an API Access of :p [19:54:41] ishan1604: I have spent years doing similar things too :) But when there *is* an API, using it is the best [19:54:52] For Sure ! [19:55:05] :) [19:55:21] ishan1604: get to building it! It will be interesting to see people's experience with eclipse and the maven file [19:55:36] Alright. BRB [19:56:24] (03CR) 10EBernhardson: "I was perhaps too quick to submit this, i wasn't expecting hhvm to already have a patch in the works. I'm fine with a revert." [core] - 10https://gerrit.wikimedia.org/r/112494 (owner: 10EBernhardson) [19:58:23] (03PS1) 10Chad: Revert "Only pass strings to mysqli::real_escape_string" [core] - 10https://gerrit.wikimedia.org/r/112501 [19:58:39] (03CR) 10Chad: "Want to confirm the upstream patch indeed works, then we can merge this." [core] - 10https://gerrit.wikimedia.org/r/112501 (owner: 10Chad) [20:05:37] (03CR) 10Aaron Schulz: [C: 032] Revert "Only pass strings to mysqli::real_escape_string" [core] - 10https://gerrit.wikimedia.org/r/112501 (owner: 10Chad) [20:07:14] (03CR) 10Chad: "Hmm, wonder why we're stuck pending :\" [gerrit] (wmf) - 10https://gerrit.wikimedia.org/r/112201 (owner: 10QChris) [20:08:27] (03PS1) 10Yuvipanda: Minor RL registration cleanup [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/112502 [20:09:05] (03PS1) 10Yuvipanda: Minor style cleanup for accessing globals [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/112504 [20:09:09] (03Merged) 10jenkins-bot: Revert "Only pass strings to mysqli::real_escape_string" [core] - 10https://gerrit.wikimedia.org/r/112501 (owner: 10Chad) [20:09:11] ugh: ^ two minor cleanup type changes? [20:09:19] MatmaRex: ^ very, very minor [20:10:19] <^d> AaronSchulz: Did you check the upstream patch before merging that? [20:10:52] (03CR) 10Umherirrender: Make a single # an invalid title in php and js (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender) [20:13:17] (03CR) 10Legoktm: "https://gerrit.wikimedia.org/r/#/c/112179/" [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/112504 (owner: 10Yuvipanda) [20:14:01] yuvipanda: ^ [20:14:13] (03PS2) 10Legoktm: Minor cleanup, add COPYING [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/112179 [20:14:57] ugh: lol [20:14:57] ugh: looking. try the other one tho? [20:15:03] (03CR) 10Yuvipanda: [C: 032 V: 032] Minor cleanup, add COPYING [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/112179 (owner: 10Legoktm) [20:15:12] sure [20:15:14] ugh: merged :) [20:15:26] (03Abandoned) 10Yuvipanda: Minor style cleanup for accessing globals [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/112504 (owner: 10Yuvipanda) [20:15:41] (03PS2) 10Yuvipanda: Minor RL registration cleanup [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/112502 [20:17:24] (03CR) 10Legoktm: Minor RL registration cleanup (031 comment) [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/112502 (owner: 10Yuvipanda) [20:18:01] (03CR) 10Yuvipanda: Minor RL registration cleanup (031 comment) [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/112502 (owner: 10Yuvipanda) [20:18:22] ugh: I modified the code later on to match [20:18:56] ^d, Cirrus uses LinksUpdate, right? is it run via job queue these days? [20:20:06] (03CR) 10Legoktm: [C: 032 V: 032] Minor RL registration cleanup (031 comment) [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/112502 (owner: 10Yuvipanda) [20:20:24] <^d> MaxSem: Yep yep [20:20:57] ergh, feeling myself a bit outdated:P [20:21:33] (03CR) 10Chad: [C: 032] Remove thumbnail captions from search text [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112488 (owner: 10Manybubbles) [20:21:38] (03Merged) 10jenkins-bot: Remove thumbnail captions from search text [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112488 (owner: 10Manybubbles) [20:21:47] ugh: whoo thanks :) [20:22:35] (03CR) 10Chad: "I'm fine with someone else taking the reigns here and finishing this off. I haven't had the time to think about it." [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [20:35:14] (03PS3) 10Umherirrender: Add llprop=langname and llprop=autonym for action=query&prop=langlinks [core] - 10https://gerrit.wikimedia.org/r/112245 [20:36:02] (03CR) 10jenkins-bot: [V: 04-1] Add llprop=langname and llprop=autonym for action=query&prop=langlinks [core] - 10https://gerrit.wikimedia.org/r/112245 (owner: 10Umherirrender) [20:36:05] (03CR) 10Umherirrender: "Patch Set 3: Addressed comments" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/112245 (owner: 10Umherirrender) [20:37:38] (03PS4) 10Umherirrender: Add llprop=langname and llprop=autonym for action=query&prop=langlinks [core] - 10https://gerrit.wikimedia.org/r/112245 [20:37:58] (03CR) 10Umherirrender: "Patch Set 4: Rebased" [core] - 10https://gerrit.wikimedia.org/r/112245 (owner: 10Umherirrender) [20:49:34] (03CR) 10Aaron Schulz: [C: 04-1] Fire Echo event when revision is approved (032 comments) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/79775 (owner: 10Bartosz Dziewoński) [20:54:30] (03PS1) 10Manybubbles: Use near_match to also search pages [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112566 [20:55:11] (03PS1) 10EBernhardson: Create maintenance mode [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112567 [20:55:12] (03PS1) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112568 [20:55:12] (03PS1) 10EBernhardson: base36 uuids [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112569 [20:59:09] RoanKattouw_away, "Conventionally, this parameter is called "config"" - are those conventions documented somewhere? [20:59:34] No :( [20:59:40] They should be, I agree [20:59:54] ok, I'll fix that today [21:00:04] To be fair, "config" is mainly used for subclasses of OO.ui.Element [21:00:10] So almost always my excuse would be "inheritance" [21:00:28] But here I'm proposing to use the same pattern for something that isn't an OO.ui.Element subclass [21:00:32] Which is kind of new AFAIK [21:00:34] Sure, I'll change it, I missed your comments from patchset 2 [21:00:59] No worries [21:01:20] I was just clarifying that I was more proposing to extend an existing pattern as opposed to actually pointing to an established convention [21:01:40] It's really only a "convention" for one class, it just so happens that that one class is a base class for like 1/3rd of the entire codebase :) [21:02:03] (03PS1) 10EBernhardson: Create maintenance mode [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112570 [21:02:06] (03PS1) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112571 [21:02:09] (03PS1) 10EBernhardson: base36 uuids [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112572 [21:02:14] I see, I'm all for that too ;) I thought I saw "options" somewhere in the code too though when grepping [21:02:22] Hmmm... [21:02:24] Where? [21:02:27] let me see [21:02:41] I think it may have been called that in prehistoric times [21:02:57] RoanKattouw_away: I took a look at OO-ui docs cursorily a few days ago. Reminded me intensely of the Java I'm writing... [21:02:59] RoanKattouw_away, modules/ve-mw/init/ve.init.mw.Target.js:936 and modules/ve-mw/init/ve.init.mw.Target.js:999 [21:03:14] yuvipanda: Yeah it's very OO-y :) hence the name [21:03:29] RoanKattouw_away, that's a mandatory one though [21:03:31] yeah, I was like 'so many objects!' and then after a few seconds 'well, what were you expecting?!' [21:03:31] however [21:03:34] grep -nr "{Object} \[options\]" [21:03:34] modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js:175: * @param {Object} [options] [21:03:34] modules/ve-mw/init/targets/ve.init.mw.MobileViewTarget.js:17: * @param {Object} [options] Additional options for the target [21:03:34] lib/ve/modules/ve/ui/ve.ui.TargetToolbar.js:17: * @param {Object} [options] Configuration options [21:03:34] lib/ve/modules/ve/ui/ve.ui.Toolbar.js:16: * @param {Object} [options] Configuration options [21:03:35] lib/ve/lib/oojs-ui/oojs-ui.js:2620: * @param {Object} [options] Configuration options [21:03:42] hah! [21:03:53] And none of that stuff uses @cfg ? [21:04:23] Also, could you check whether those doc comments are lies and the param is really called config? Or feeds into a subclass constructor's config param? [21:04:32] (03PS1) 10MaxSem: Add MobileApp [tools/release] - 10https://gerrit.wikimedia.org/r/112573 [21:04:40] If we actually have options parameters in all of those classes, I need to send some nasty looks Trevor's way :) [21:05:04] (03PS1) 10Umherirrender: Deprecate llurl= in favour of llprop=url for action=query&prop=langlinks [core] - 10https://gerrit.wikimedia.org/r/112574 [21:05:36] RoanKattouw_away, they are called options indeed, modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js uses options in one place and config in another [21:05:46] Ha [21:05:51] Well TrevorP|Away just got back to his desk [21:05:58] RoanKattouw_away, there are many more results for grep -nr "{Object} \[config\]" though [21:06:09] So I'm sure he's looking forward to being harassed about this ;) [21:06:14] Yes, config is much much more common [21:06:24] OK, I'll make it config then [21:07:38] jgonera: see https://gerrit.wikimedia.org/r/#/c/111672/ [21:07:44] I clean a lot of this up in that patch [21:08:40] oh, wait, so @cfg is an official thing in JSDuck? [21:08:41] er... I think https://gerrit.wikimedia.org/r/#/c/108955/ [21:08:48] it's official [21:09:52] @cfg may also be a think Krinkle|detached hacked up [21:09:54] it's to do with ExtJs, which has a class builder that takes a config object, but we use it to describe the kinds of things that can be passed to the constructor [21:10:01] We don't know how that works, we just do what he tells us to [21:10:04] https://github.com/senchalabs/jsduck/wiki/@cfg [21:10:08] Ah nice [21:10:26] so does @cfg always assume there's an object called "config"? [21:10:37] Yes [21:11:06] well, @cfg doesn't have an opinion about the constructor argument, it's disconnected [21:11:09] we just use the same language to make it somewhat intuitive when reading the docs [21:11:15] have you see the generated docs? [21:11:41] I think I have, but do you have a link to something using @cfg handy? [21:11:48] (03PS5) 10Umherirrender: Add llprop=langname and llprop=autonym for action=query&prop=langlinks [core] - 10https://gerrit.wikimedia.org/r/112245 [21:11:50] example: https://doc.wikimedia.org/VisualEditor/master/#!/api/ve.ui.MWCategoryItemWidget [21:12:07] (03PS11) 10CSteipp: Password Expiration [core] - 10https://gerrit.wikimedia.org/r/92037 [21:12:19] the reason @cfg is so useful is because it works with inheritance and mixins [21:12:33] (03CR) 10Umherirrender: "Patch Set 5: Rebased on the top of I1340b18b51bccdfaaddec6a16df320d5f6e5acfa" [core] - 10https://gerrit.wikimedia.org/r/112245 (owner: 10Umherirrender) [21:12:44] so, we can write the docs at the place they are really used, and the docs inherit [21:12:52] I see, so I should use that instead of @param {number} [options.section] [21:12:58] it's really quite nice, but admittedly different [21:12:59] (03CR) 10Anomie: [C: 04-1] Deprecate llurl= in favour of llprop=url for action=query&prop=langlinks (032 comments) [core] - 10https://gerrit.wikimedia.org/r/112574 (owner: 10Umherirrender) [21:13:08] jgonera: yes [21:13:10] exactly [21:13:44] and, they should always be optional, so "@cfg {number} [selection] Selection index" or something [21:14:54] anything non-optional should be an argument preceding config [21:15:02] config itself is also always optional [21:15:19] got it [21:15:25] so, if you are going to pluck things out of it, you need to do something like config = config || {}; at the top of the constructor [21:15:30] You will see this done a lot [21:15:45] mooeypoo: howdy [21:15:59] heya [21:16:09] sorry I am a bit late :( [21:16:20] So, image data model... [21:16:23] np, I'm also completely available tomorrow (no class) if you prefer [21:16:41] I will get started today [21:16:44] * mooeypoo nods [21:16:46] awesome [21:17:11] doing it here, in #mediawiki-visualeditor or on hangouts? [21:17:27] (03CR) 10Legoktm: [C: 031] "+1 assuming this is just for the wmf branch and isn't going into master." (031 comment) [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112567 (owner: 10EBernhardson) [21:17:41] I'm going to hack together a start for ve.dm.MWMediaModel.js [21:17:53] we can move to ve, sorry [21:19:55] (03PS2) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112568 [21:19:58] (03PS2) 10EBernhardson: base36 uuids [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112569 [21:20:01] (03PS2) 10EBernhardson: Create maintenance mode [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112567 [21:20:04] (03CR) 10Legoktm: "How often is this actually going to be necessary? I don't think it's worth merging into master." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112498 (owner: 10EBernhardson) [21:20:22] (03CR) 10EBernhardson: Create maintenance mode (031 comment) [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112567 (owner: 10EBernhardson) [21:20:52] (03CR) 10Anomie: Add llprop=langname and llprop=autonym for action=query&prop=langlinks (032 comments) [core] - 10https://gerrit.wikimedia.org/r/112245 (owner: 10Umherirrender) [21:20:57] (03CR) 10EBernhardson: "Yea we could probably just put it in the deploy branches, i hope we won't need a full disable any time in the future." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112498 (owner: 10EBernhardson) [21:21:47] (03CR) 10CSteipp: "PS11 was supposed to be a rebase, but since SpecialChangePassword was refactored to use HTMLForm, the way it integrated needed to be refac" [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [21:22:07] (03PS2) 10EBernhardson: base36 uuids [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112572 [21:22:10] (03PS2) 10EBernhardson: Create maintenance mode [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112570 [21:22:13] (03PS2) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112571 [21:22:48] (03CR) 10JGonera: "To avoid putting the XML prolog back manually, you can create an .svgo.yml with the following:" [core] - 10https://gerrit.wikimedia.org/r/106506 (owner: 10Bartosz Dziewoński) [21:24:31] TrevorParscal, is there a dedicated VE IRC channel? [21:25:15] jgonera: #mediawiki-visualeditor [21:25:44] yuvipanda: You joined and immediately left us? :-( [21:25:46] yuvipanda, thanks, I must have made a typo before because I tried that ;) [21:26:02] James_F: just wanted to check if it was mw or wm and if it was ve or visualeditor :P [21:26:28] * James_F grins. [21:27:57] (03PS1) 10Yaron Koren: New version: 1.6.4 [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/112578 [21:29:55] (03CR) 10Yaron Koren: [C: 032 V: 032] New version: 1.6.4 [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/112578 (owner: 10Yaron Koren) [21:32:03] (03PS1) 10MaxSem: Add MobileApp [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112580 [21:32:56] (03PS1) 10Matthias Mullie: Check permissions in RecentChanges & Contributions feeds [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112583 [21:34:51] (03PS1) 10MaxSem: Add MobileApp [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112585 [21:34:55] (03PS12) 10CSteipp: Password Expiration [core] - 10https://gerrit.wikimedia.org/r/92037 [21:38:20] MaxSem: wooo! [21:39:19] (03PS1) 10MaxSem: Fix timestamp validation [extensions/FeaturedFeeds] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112586 [21:40:55] Hm, is doc.wm.o down? [21:46:13] (03PS3) 10Manybubbles: Don't search text wrapped in nosearch class [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112500 [21:46:29] (03CR) 10Manybubbles: "rebased" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112500 (owner: 10Manybubbles) [21:50:56] (03CR) 10Chad: [C: 04-1] "Spelling nit, otherwise fine." (033 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112566 (owner: 10Manybubbles) [21:54:02] (03PS1) 10Physikerwelt: Differntiate missing texvccheck from missing texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/112589 [21:55:26] (03PS2) 10Physikerwelt: Differntiate missing texvccheck from missing texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/112589 [21:56:47] (03CR) 10Mattflaschen: "I'm fine with splitting it." (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/112413 (owner: 10Ori.livneh) [21:56:48] (03CR) 10Physikerwelt: [C: 04-1] "it might be better to add a parameter to the help text... otherwise everything has to be retranslated" [extensions/Math] - 10https://gerrit.wikimedia.org/r/112589 (owner: 10Physikerwelt) [21:59:25] greg-g: did you mind if i expand our deploy tomorrow to start at 2? would just be more confortable with a 2 hour deploy window and nothing else is there [22:00:12] still gives an hour after reedy's deploy before we start [22:00:49] ebernhardson: yeah, actually, in generally, I should give ya'll 2 hours be default on that day [22:01:03] (03CR) 10MaxSem: [C: 032] Fix timestamp validation [extensions/FeaturedFeeds] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112586 (owner: 10MaxSem) [22:01:05] (03Merged) 10jenkins-bot: Fix timestamp validation [extensions/FeaturedFeeds] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112586 (owner: 10MaxSem) [22:01:49] (03PS1) 10MaxSem: Update FeaturedFeeds to wmf/1.23wmf13 tip [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112592 [22:03:09] (03CR) 10MaxSem: [C: 032 V: 032] Update FeaturedFeeds to wmf/1.23wmf13 tip [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112592 (owner: 10MaxSem) [22:03:14] (03CR) 10MaxSem: [C: 032 V: 032] Add MobileApp [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112585 (owner: 10MaxSem) [22:03:30] (03CR) 10MaxSem: [C: 032 V: 032] Add MobileApp [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112580 (owner: 10MaxSem) [22:03:52] (03CR) 10MaxSem: [C: 032 V: 032] Add MobileApp [tools/release] - 10https://gerrit.wikimedia.org/r/112573 (owner: 10MaxSem) [22:10:43] (03PS3) 10Physikerwelt: Differntiate missing texvccheck from missing texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/112589 [22:12:43] (03PS4) 10Physikerwelt: Differentiate missing texvccheck from missing texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/112589 [22:14:10] (03PS3) 10Kunalgrover05: Go to top button for pages [core] - 10https://gerrit.wikimedia.org/r/108323 (owner: 10Gerrit Patch Uploader) [22:15:51] (03CR) 10jenkins-bot: [V: 04-1] Go to top button for pages [core] - 10https://gerrit.wikimedia.org/r/108323 (owner: 10Gerrit Patch Uploader) [22:28:12] (03PS1) 10Matthias Mullie: Use more permissive isRevisionAllowed on helper tools. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112596 [22:36:29] (03CR) 10Physikerwelt: "Chad: I started to create a PHP file, with an array. But I was not sure what the right way is. Include it in the main method? And suddenly" [extensions/Math] - 10https://gerrit.wikimedia.org/r/112353 (owner: 10Physikerwelt) [22:38:01] (03PS1) 10Aaron Schulz: Avoid fatal error in LoadBalancer when all servers are busy [core] - 10https://gerrit.wikimedia.org/r/112598 [22:38:34] AaronSchulz: nice [22:38:46] (03PS1) 10Aaron Schulz: Avoid fatal error in LoadBalancer when all servers are busy [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112599 [22:40:23] (03CR) 10Matthias Mullie: Create maintenance mode (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112498 (owner: 10EBernhardson) [22:40:31] (03CR) 10Hoo man: [C: 032] Avoid fatal error in LoadBalancer when all servers are busy [core] - 10https://gerrit.wikimedia.org/r/112598 (owner: 10Aaron Schulz) [22:41:45] (03PS5) 10EBernhardson: Use provided language for link messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112038 [22:41:55] (03CR) 10jenkins-bot: [V: 04-1] Use provided language for link messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112038 (owner: 10EBernhardson) [22:44:12] (03Merged) 10jenkins-bot: Avoid fatal error in LoadBalancer when all servers are busy [core] - 10https://gerrit.wikimedia.org/r/112598 (owner: 10Aaron Schulz) [22:44:18] (03PS6) 10EBernhardson: Use provided language for link messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112038 [22:44:53] (03CR) 10Aaron Schulz: [C: 032] Avoid fatal error in LoadBalancer when all servers are busy [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112599 (owner: 10Aaron Schulz) [22:45:31] (03CR) 10Matthias Mullie: [C: 031] [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [22:46:19] (03CR) 10Physikerwelt: Avoid fatal error in LoadBalancer when all servers are busy (031 comment) [core] - 10https://gerrit.wikimedia.org/r/112598 (owner: 10Aaron Schulz) [22:48:28] (03Merged) 10jenkins-bot: Avoid fatal error in LoadBalancer when all servers are busy [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112599 (owner: 10Aaron Schulz) [22:49:24] (03CR) 10Chad: [C: 032] Show the pool counter key and use English for the debug logging [core] - 10https://gerrit.wikimedia.org/r/112125 (owner: 10Aaron Schulz) [22:50:23] gah [22:51:39] (03PS1) 10Aaron Schulz: Move clearing of $i down a bit from 56b22fbea8cdd6fcd31c94e6b4bb01be49fa9683 [core] - 10https://gerrit.wikimedia.org/r/112601 [22:52:03] (03PS2) 10Aaron Schulz: Move clearing of $i down a bit in LoadBalancer [core] - 10https://gerrit.wikimedia.org/r/112601 [22:52:12] (03PS1) 10Aaron Schulz: Move clearing of $i down a bit in LoadBalancer [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112602 [22:52:20] (03CR) 10Aaron Schulz: [C: 032] Move clearing of $i down a bit in LoadBalancer [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112602 (owner: 10Aaron Schulz) [22:52:33] (03CR) 10Hoo man: [C: 032] "Damn... thanks" [core] - 10https://gerrit.wikimedia.org/r/112601 (owner: 10Aaron Schulz) [22:53:17] (03Merged) 10jenkins-bot: Show the pool counter key and use English for the debug logging [core] - 10https://gerrit.wikimedia.org/r/112125 (owner: 10Aaron Schulz) [22:53:28] heh, I never synced that out yet [22:56:39] (03PS2) 10Physikerwelt: Change format of the generated phpunit coverage tests [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/112481 [22:56:49] (03CR) 10Physikerwelt: [C: 032 V: 032] Change format of the generated phpunit coverage tests [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/112481 (owner: 10Physikerwelt) [22:58:23] (03Merged) 10jenkins-bot: Move clearing of $i down a bit in LoadBalancer [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112602 (owner: 10Aaron Schulz) [22:59:09] (03Merged) 10jenkins-bot: Move clearing of $i down a bit in LoadBalancer [core] - 10https://gerrit.wikimedia.org/r/112601 (owner: 10Aaron Schulz) [22:59:56] (03CR) 10Matthias Mullie: [C: 031] base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 (owner: 10EBernhardson) [23:00:08] (03CR) 10Matthias Mullie: [C: 031] base36 uuids [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112569 (owner: 10EBernhardson) [23:00:34] (03CR) 10Matthias Mullie: [C: 031] [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112568 (owner: 10EBernhardson) [23:00:50] (03CR) 10Matthias Mullie: [C: 031] [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112571 (owner: 10EBernhardson) [23:08:50] (03PS5) 10Physikerwelt: Differentiate missing texvccheck from missing texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/112589 [23:09:44] (03CR) 10BryanDavis: "I like this. I had a couple roles patches that became a pain to keep rebased due to merge conflicts. The only downside I see is that this " [vagrant] - 10https://gerrit.wikimedia.org/r/112413 (owner: 10Ori.livneh) [23:14:34] (03CR) 10Physikerwelt: [C: 031] "I did not review the code... But I like the idea very much... rebasing is very annoying especially if it takes a few review iterations unt" [vagrant] - 10https://gerrit.wikimedia.org/r/112413 (owner: 10Ori.livneh) [23:20:33] (03PS3) 10Physikerwelt: Install MathWeb Search service [vagrant] - 10https://gerrit.wikimedia.org/r/112355 [23:20:57] (03PS3) 10EBernhardson: Create maintenance mode [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112567 [23:21:56] (03CR) 10Matthias Mullie: [C: 04-1] "Discovered some bug after all" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [23:22:38] (03CR) 10Matthias Mullie: [C: 031] base36 uuids [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112572 (owner: 10EBernhardson) [23:22:58] (03CR) 10Parent5446: [C: 031] New hook MessageCache::get [core] - 10https://gerrit.wikimedia.org/r/98078 (owner: 10Nikerabbit) [23:23:01] (03PS2) 10Cmcmahon: QA Test for Action menu Permalink [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112048 [23:23:41] (03PS3) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112568 [23:23:44] (03PS3) 10EBernhardson: base36 uuids [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112569 [23:23:47] (03PS4) 10EBernhardson: Create maintenance mode [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112567 [23:24:29] (03PS3) 10Cmcmahon: QA Test for Action menu Permalink [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112048 [23:26:12] (03PS4) 10Cmcmahon: QA Test for Action menu Permalink [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112048 [23:28:58] (03PS5) 10Cmcmahon: QA Test for Action menu Permalink [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112048 [23:30:37] (03CR) 10Pginer: [C: 031] Remove gradients, minor cleanup [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111144 (owner: 10Mattflaschen) [23:33:27] (03CR) 10Parent5446: [C: 04-1] Add blobs support to ResourceLoader (033 comments) [core] - 10https://gerrit.wikimedia.org/r/111250 (owner: 10MaxSem) [23:33:51] (03PS3) 10EBernhardson: base36 uuids [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112572 [23:33:54] (03PS3) 10EBernhardson: Create maintenance mode [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112570 [23:37:02] (03Abandoned) 10EBernhardson: Create maintenance mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112498 (owner: 10EBernhardson) [23:37:45] (03CR) 10EBernhardson: "Ok i'll look back into this, for one reason or another update-rc.d is not being run locally." [vagrant] - 10https://gerrit.wikimedia.org/r/112064 (owner: 10EBernhardson) [23:42:38] (03CR) 10MaxSem: Add blobs support to ResourceLoader (032 comments) [core] - 10https://gerrit.wikimedia.org/r/111250 (owner: 10MaxSem) [23:48:00] (03PS4) 10EBernhardson: base36 uuids [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112572 [23:49:02] (03PS4) 10EBernhardson: base36 uuids [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112569 [23:49:44] (03PS12) 10EBernhardson: base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 [23:50:41] (03CR) 10Parent5446: [C: 04-1] "Overall I don't think this works properly. The tracking category message can contain basically *any* magic word, not just the namespace. W" (0313 comments) [core] - 10https://gerrit.wikimedia.org/r/112323 (owner: 10Kunalgrover05) [23:53:28] (03CR) 10Maryana: [V: 031] QA Test for Action menu Permalink [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112048 (owner: 10Cmcmahon) [23:58:26] (03CR) 10Matthias Mullie: [C: 031] QA Test for Action menu Permalink [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112048 (owner: 10Cmcmahon) [23:59:23] (03CR) 10Cmcmahon: [C: 032] "Merging after +1 from Matthias and IRC review from Maryana" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112048 (owner: 10Cmcmahon) [23:59:42] (03PS13) 10Catrope: Add OOjs UI v0.1.0-pre (ddff003909) to core [core] - 10https://gerrit.wikimedia.org/r/98887 [23:59:52] (03PS1) 10Prtksxna: Update icon on Beta Preferences [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112607