[00:01:54] (03PS1) 10Parent5446: Revert "Removed "Justify paragraphs" from MW user Preference." [core] - 10https://gerrit.wikimedia.org/r/112151 [00:02:15] (03PS2) 10Parent5446: Revert "Removed "Justify paragraphs" from MW user Preference." [core] - 10https://gerrit.wikimedia.org/r/112151 [00:02:43] (03CR) 10jenkins-bot: [V: 04-1] Revert "Removed "Justify paragraphs" from MW user Preference." [core] - 10https://gerrit.wikimedia.org/r/112151 (owner: 10Parent5446) [00:03:33] (03CR) 10jenkins-bot: [V: 04-1] Revert "Removed "Justify paragraphs" from MW user Preference." [core] - 10https://gerrit.wikimedia.org/r/112151 (owner: 10Parent5446) [00:03:39] (03CR) 10MZMcBride: "What consensus are you referring to?" [core] - 10https://gerrit.wikimedia.org/r/112151 (owner: 10Parent5446) [00:06:09] (03PS1) 10Legoktm: Fix undefined variable [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/112152 [00:12:50] (03PS10) 10CSteipp: Password Expiration [core] - 10https://gerrit.wikimedia.org/r/92037 [00:12:57] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Does not merge." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/111620 (owner: 10MarkTraceur) [00:13:43] (03CR) 10jenkins-bot: [V: 04-1] Password Expiration [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [00:15:26] (03CR) 10Parent5446: "I'm not referring to any consensus. Commit messages in Git are history, so assuming this patch is ever merged, it's safe to assume it was " [core] - 10https://gerrit.wikimedia.org/r/112151 (owner: 10Parent5446) [00:15:39] (03CR) 10Parent5446: [C: 04-2] Revert "Removed "Justify paragraphs" from MW user Preference." [core] - 10https://gerrit.wikimedia.org/r/112151 (owner: 10Parent5446) [00:15:58] (03PS2) 10Wctaiwan: Add support for Flow's terms of use [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/111693 [00:17:34] (03CR) 10Hoo man: [C: 04-1] "Just some thoughts" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [00:21:14] (03CR) 10Technical 13: "+1" [core] - 10https://gerrit.wikimedia.org/r/112151 (owner: 10Parent5446) [00:26:05] (03CR) 10CSteipp: [C: 04-2] "PS10 addressed Tyler and Max'es comments. I'm working through merging this with master, which is ugly, and this version of password reset " (031 comment) [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [00:28:55] (03PS3) 10Krinkle: resourceloader: Always send headers with a 304 response [core] - 10https://gerrit.wikimedia.org/r/74400 (owner: 10Catrope) [00:29:28] (03PS6) 10Matthias Mullie: Add *Revisionable classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111366 [00:29:47] (03CR) 10jenkins-bot: [V: 04-1] resourceloader: Always send headers with a 304 response [core] - 10https://gerrit.wikimedia.org/r/74400 (owner: 10Catrope) [00:30:43] (03PS4) 10Matthias Mullie: Don't propagate permissions to older revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112042 [00:30:46] (03PS1) 10Matthias Mullie: Split permission-logic into separate method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112158 [00:30:49] (03PS1) 10Matthias Mullie: Add path from Revision object to Revisionable object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112159 [00:30:52] (03PS1) 10Matthias Mullie: Make sure permission checks also check against current revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112160 [00:30:55] (03PS1) 10Matthias Mullie: Some permission fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112161 [00:30:58] (03PS1) 10Matthias Mullie: Make a method to check permissions against only the specific revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112162 [00:31:01] (03PS1) 10Matthias Mullie: Make history entries also check previous revisions if restored [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112163 [00:31:15] (03CR) 10jenkins-bot: [V: 04-1] Make sure permission checks also check against current revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112160 (owner: 10Matthias Mullie) [00:31:21] (03CR) 10jenkins-bot: [V: 04-1] Some permission fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112161 (owner: 10Matthias Mullie) [00:31:29] (03CR) 10jenkins-bot: [V: 04-1] Make a method to check permissions against only the specific revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112162 (owner: 10Matthias Mullie) [00:31:37] (03CR) 10jenkins-bot: [V: 04-1] Make history entries also check previous revisions if restored [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112163 (owner: 10Matthias Mullie) [00:39:40] (03Restored) 10TTO: Bring PageNotice extension into the modern era [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105141 (owner: 10TTO) [00:39:43] (03Restored) 10TTO: Allow per-page notice functionality to be disabled [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105143 (owner: 10TTO) [00:39:46] (03Restored) 10TTO: Add CSS file to provide a margin below/above each notice [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105142 (owner: 10TTO) [00:40:59] <^demon|away> ebernhardson: On search again...I guess we can all think on it over the weekend and set something up next week to sit down and talk? [00:41:11] pls to include me in that meeting. [00:43:16] <^demon|away> jorm: mmk. [00:43:43] (03CR) 10TTO: "I can understand that. In that case, I'll resume work on cleaning up the PageNotice extension. See I4b0bfbf02f997971927452114ec5d4ed5a629f" [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO) [00:43:55] (03PS5) 10Krinkle: CSSJanus: Account for attribute selectors in brace lookahead [core] - 10https://gerrit.wikimedia.org/r/105639 (owner: 10Catrope) [00:44:13] (03CR) 10Legoktm: [C: 04-1] Use provided language for link messages (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112038 (owner: 10EBernhardson) [00:47:56] (03CR) 10TTO: [C: 04-1] "Needs some work. In particular, I think the wrong hook is being used." [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105141 (owner: 10TTO) [00:52:32] (03PS2) 10Matthias Mullie: Make sure permission checks also check against current revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112160 [00:54:32] (03PS2) 10Matthias Mullie: Some permission fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112161 [00:56:46] (03PS2) 10Matthias Mullie: Make a method to check permissions against only the specific revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112162 [00:57:45] (03PS2) 10Matthias Mullie: Make history entries also check previous revisions if restored [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112163 [01:03:48] ^demon|away: yea that sounds good [01:04:27] Hmm. Should I remove apc from my dev vm... it has Zend OPcache v7.0.3-dev [01:09:10] Profiling error: in(CirrusSearch\Updater::sendDocuments), out(CirrusSearch\Updater::updatePages) [01:09:17] ^demon|away: still errors in ES profiling [01:10:06] (03PS4) 10Bsitu: Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 [01:14:09] (03PS1) 10Matthias Mullie: Add some more details to RC tables [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112169 [01:16:28] (03CR) 10MZMcBride: "Aha, I see now. Thanks for the clarification." [core] - 10https://gerrit.wikimedia.org/r/112151 (owner: 10Parent5446) [01:17:08] (03PS5) 10Bsitu: Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 [01:17:16] moizsyed: If you join us in -staff, we are plotting to play Coup [01:18:01] (03CR) 10Krinkle: [C: 031] CSSJanus: Account for attribute selectors in brace lookahead [core] - 10https://gerrit.wikimedia.org/r/105639 (owner: 10Catrope) [01:24:16] (03PS3) 10TTO: Add CSS file to provide a margin below/above each notice [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105142 [01:24:18] (03PS3) 10TTO: Allow per-page notice functionality to be disabled [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105143 [01:24:20] (03PS3) 10TTO: Bring PageNotice extension into the modern era [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105141 [01:29:24] (03CR) 10Manybubbles: [C: 032] Updated mediawiki_selenium to 0.2.1 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112140 (owner: 10Zfilipin) [01:29:30] (03Merged) 10jenkins-bot: Updated mediawiki_selenium to 0.2.1 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112140 (owner: 10Zfilipin) [01:31:03] (03CR) 10Technical 13: [C: 031] "This patch needs to be merged, it is apparently a very popular option (I'm surprised there was no data in the patches on Gerrit or on the " [core] - 10https://gerrit.wikimedia.org/r/112151 (owner: 10Parent5446) [01:50:49] (03PS1) 10Reedy: Add COPYING [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/112172 [01:51:21] (03PS1) 10Reedy: Add COPYING [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/112173 [01:51:44] (03PS1) 10Reedy: Add COPYING [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/112174 [01:52:32] (03PS1) 10Reedy: Add COPYING [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/112175 [01:53:03] (03PS1) 10Reedy: Add COPYING [extensions/AccountAudit] - 10https://gerrit.wikimedia.org/r/112176 [01:54:35] (03PS1) 10Reedy: Add COPYING [extensions/OpenSearchXml] - 10https://gerrit.wikimedia.org/r/112177 [01:54:50] (03PS1) 10Reedy: Add COPYING [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/112178 [01:54:52] (03CR) 10jenkins-bot: [V: 04-1] Add COPYING [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/112178 (owner: 10Reedy) [01:55:38] Stupid bot [01:57:51] (03PS1) 10Legoktm: Minor cleanup, add COPYING [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/112179 [02:00:13] (03PS1) 10Reedy: Add COPYING [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/112180 [02:04:50] (03PS3) 10IAlex: Only put returnto parameter if needed on the from-http redirect in Special:Userlogin [core] - 10https://gerrit.wikimedia.org/r/97078 [02:05:31] (03CR) 10Jack Phoenix: [C: 031] ""normalize.css is not MediaWiki, it's a 3rd party library, it does not belong under `mediawiki.*`."" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [02:06:16] (03PS15) 10TTO: Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 [02:09:31] (03CR) 10Maryana: "I'd just change the very last part to:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112049 (owner: 10Cmcmahon) [02:11:36] (03PS4) 10EBernhardson: Use provided language for link messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112038 [02:11:42] (03CR) 10jenkins-bot: [V: 04-1] Use provided language for link messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112038 (owner: 10EBernhardson) [02:15:05] (03PS1) 10Reedy: Add COPYING [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/112182 [02:17:01] (03CR) 10Maryana: "LGTM!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112048 (owner: 10Cmcmahon) [02:18:31] (03PS1) 10Reedy: Add COPYING [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/112183 [02:19:11] Wonder how many others under WMF usage are still missing COPYING... [02:19:27] Or COPING [02:19:53] COPING is pretty helpful too [02:20:29] reedy@ubuntu64-web-esxi:~$ cat COPING [02:20:30] Leave. Leave now. [02:20:32] Sorted [02:21:05] Heh [02:21:41] Why haven't we got Extension:Sarcasm on the cluster? [02:26:17] Or Extension:Awesomeness???! [02:27:13] (03CR) 10Mattflaschen: "Is this still needed/wanted?" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/94516 (owner: 10Adamw) [02:37:49] (03CR) 10Cscott: "Hey, TTO, don't take the -2 personally, I was just trying to prevent another almost-merge before the Parsoid team has gotten a chance to w" [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [02:38:23] (03PS1) 10Mattflaschen: Document SkinVectorStyleModules hooks [core] - 10https://gerrit.wikimedia.org/r/112184 [02:39:11] (03CR) 10jenkins-bot: [V: 04-1] Document SkinVectorStyleModules hooks [core] - 10https://gerrit.wikimedia.org/r/112184 (owner: 10Mattflaschen) [02:39:56] (03PS2) 10Mattflaschen: Document SkinVectorStyleModules hook [core] - 10https://gerrit.wikimedia.org/r/112184 [02:40:32] yay :D [02:40:44] (03CR) 10jenkins-bot: [V: 04-1] Document SkinVectorStyleModules hook [core] - 10https://gerrit.wikimedia.org/r/112184 (owner: 10Mattflaschen) [02:43:48] (03Abandoned) 10Mattflaschen: Document SkinVectorStyleModules hook [core] - 10https://gerrit.wikimedia.org/r/112184 (owner: 10Mattflaschen) [03:03:03] (03CR) 10Mattflaschen: "I also documented it on MW.org: https://www.mediawiki.org/wiki/Manual:Hooks/SkinVectorStyleModules" [core] - 10https://gerrit.wikimedia.org/r/101663 (owner: 10IAlex) [03:13:23] (03PS4) 10Liangent: Remove user preference "noconvertlink" [core] - 10https://gerrit.wikimedia.org/r/111968 [03:21:46] (03CR) 10Mattflaschen: [C: 032] "Confirmed locally." [core] - 10https://gerrit.wikimedia.org/r/96704 (owner: 10IAlex) [03:22:57] (03CR) 10MZMcBride: "Trash?" [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [03:24:49] Gloria: [03:24:49] Noun[edit] [03:24:50] trash (uncountable) [03:24:50] (chiefly US) Useless things to be discarded; rubbish; refuse.  [quotations ▼] [03:25:11] (03Merged) 10jenkins-bot: Fix HTML output arround HTMLForm's submit buttons when in vform [core] - 10https://gerrit.wikimedia.org/r/96704 (owner: 10IAlex) [03:27:35] p858snake: Oh, thanks. [03:28:30] (03CR) 10MZMcBride: "Nice. Thanks for working on this." [core] - 10https://gerrit.wikimedia.org/r/111968 (owner: 10Liangent) [03:50:52] (03PS1) 10Chad: Fix profiling error [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112185 [03:58:53] (03CR) 10Legoktm: [C: 032] Fix profiling error [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112185 (owner: 10Chad) [03:58:58] (03Merged) 10jenkins-bot: Fix profiling error [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112185 (owner: 10Chad) [04:32:27] (03CR) 10Ori.livneh: [C: 032] "Good thing that it's private -- wouldn't want subclasses parsing timestamps! :P" [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/112139 (owner: 10MaxSem) [04:32:29] (03Merged) 10jenkins-bot: Fix timestamp validation [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/112139 (owner: 10MaxSem) [04:34:53] (03PS2) 10Prtksxna: Add hook for BetaFeatures [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112006 [04:35:40] (03CR) 10Prtksxna: Add hook for BetaFeatures (035 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112006 (owner: 10Prtksxna) [04:42:44] (03PS3) 10Prtksxna: Add hook for BetaFeatures [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112006 [04:43:34] (03CR) 10Prtksxna: Add hook for BetaFeatures (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112006 (owner: 10Prtksxna) [04:45:08] (03PS4) 10Prtksxna: Add hook for BetaFeatures [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112006 [04:46:22] (03CR) 10TTO: "Thanks, Scott. I'm about to post a very long comment at the bug, so duck for cover! :)" [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [05:32:21] (03CR) 10Mattflaschen: "I'm concerned this will break normal editing for certain users, who have software that strips/doesn't send the Referer (probably more comm" [core] - 10https://gerrit.wikimedia.org/r/65418 (owner: 10Parent5446) [05:48:53] (03CR) 10Mattflaschen: [C: 04-1] "-1 for now, since I don't want to revive Extension:Agora." [extensions/Agora] - 10https://gerrit.wikimedia.org/r/93525 (owner: 10Spage) [06:16:06] (03PS3) 10Wctaiwan: Add support for Flow's terms of use [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/111693 [06:16:50] (03CR) 10Legoktm: [C: 031] Add support for Flow's terms of use [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/111693 (owner: 10Wctaiwan) [06:19:17] (03CR) 10Legoktm: [C: 031] "Haven't tested yet." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111710 (owner: 10Wctaiwan) [06:27:32] (03CR) 10Mattflaschen: [C: 04-1] "Looks good. Preference is visually correct, and I confirmed the JavaScript value ends up at 5 * 1024 * 1024 ." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 (owner: 10Gilles) [06:30:09] (03PS5) 10Mattflaschen: Fix the i18n source string for the chunked preference [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 (owner: 10Gilles) [06:30:34] (03CR) 10Mattflaschen: [C: 032] "Looks good, see previous." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 (owner: 10Gilles) [06:30:44] (03Merged) 10jenkins-bot: Fix the i18n source string for the chunked preference [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 (owner: 10Gilles) [06:34:08] (03CR) 10Parent5446: "@Mattflaschen - This patch actually uses loose referer checking, meaning if the referer header was stripped, it gives it the OK and let's " [core] - 10https://gerrit.wikimedia.org/r/65418 (owner: 10Parent5446) [06:41:36] (03CR) 10Mattflaschen: "My mistake. I should have read it more closely before." [core] - 10https://gerrit.wikimedia.org/r/65418 (owner: 10Parent5446) [07:13:11] (03CR) 10Cscott: "Sorry, I was posting from my phone with its silly autocorrect. In my last comment it should have been "weigh in" and "tag" (not trash!)." [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [07:19:27] (03CR) 10Mattflaschen: "I know this has already been merged into Popups, but I wanted to make one suggestion:" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [07:20:33] (03CR) 10Prtksxna: "@Mattflaschen Will do!" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [07:23:05] hi prtksxna [07:23:08] i just woke up [07:23:13] YuviPanda: o/ [07:23:22] YuviPanda: Morning [07:23:47] hi prtksxna [07:24:24] prtksxna: you should create a labs account [07:24:28] prtksxna: wikitech.wikimedia.org [07:26:16] YuviPanda: will do [07:27:14] (03CR) 10Mattflaschen: "Certain Math WMF branches are created through a script at the same time WMF production core branches are. E.g. https://git.wikimedia.org/" [extensions/Math] - 10https://gerrit.wikimedia.org/r/109488 (owner: 10Physikerwelt) [07:38:29] (03CR) 10Mattflaschen: "It seems like the "copy built file" approach is consistent with how we're handling jQuery." [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [07:46:31] (03CR) 10Mattflaschen: "Haven't double-checked, but probably superseded by https://gerrit.wikimedia.org/r/#/c/111636/" [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [08:11:06] (03PS6) 10Physikerwelt: remove armourMath and wgContLang (bug 60799) [extensions/Math] - 10https://gerrit.wikimedia.org/r/111119 [08:24:37] (03PS2) 10Aaron Schulz: fix: texvccheck is not idempotent [extensions/Math] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112057 (owner: 10Physikerwelt) [08:42:13] (03CR) 10Hashar: [C: 04-1] "TestFileIterator is used to read a file having parser tests." [core] - 10https://gerrit.wikimedia.org/r/112033 (owner: 10Anomie) [09:28:23] What is the "keep going" message in VisualEditor? [09:29:08] (03CR) 10TTO: "This is a good start! Please take a look at the comments. Someone else will need to comment on the ResourceLoader stuff though." (037 comments) [core] - 10https://gerrit.wikimedia.org/r/108323 (owner: 10Gerrit Patch Uploader) [09:32:26] Hello. I am interested in GSoC'14. My keen interest is in web development. Can anyone guide me about any such project in wikimedia? [09:47:13] Ritika: did you check https://www.mediawiki.org/wiki/Summer_of_Code_2014#Featured_project_ideas ? [09:48:04] Thanks. [09:52:23] I just went through the list. I liked the project idea Flow. Can anyone give me more details about the same? [10:04:56] Click the link? [10:08:33] (03CR) 10Fomafix: mediawiki.api: Refactor getToken and postWithToken methods (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111636 (owner: 10Krinkle) [10:09:07] (03CR) 10TTO: "The other ILL message not requiring translation, interlanguage-link-nonlang, does not have qqq documentation. It seems inconsistent to be " [core] - 10https://gerrit.wikimedia.org/r/111390 (owner: 10TTO) [10:10:34] (03CR) 10TTO: [C: 04-1] "This needs a clearer commit message. Or if you no longer want this patch, please abandon it." [core] - 10https://gerrit.wikimedia.org/r/111289 (owner: 10Adi.iiita) [10:15:30] (03CR) 10Peachey88: "Please have a look at Commit message guidelines " [core] - 10https://gerrit.wikimedia.org/r/111289 (owner: 10Adi.iiita) [11:09:35] (03PS1) 10Shirayuki: Fix syntax error in YetAnotherKeywords.i18n.php [extensions/YetAnotherKeywords] - 10https://gerrit.wikimedia.org/r/112200 [11:22:04] (03PS3) 10QChris: Bring draft status to PatchSetAttribute [gerrit] (wmf) - 10https://gerrit.wikimedia.org/r/69428 [11:40:05] (03PS1) 10QChris: Keep status:closed's limit below MySQL Connector/J's hard limit [gerrit] (wmf) - 10https://gerrit.wikimedia.org/r/112201 [11:41:12] (03CR) 10QChris: "Corresponding upstream fix is at" [gerrit] (wmf) - 10https://gerrit.wikimedia.org/r/112201 (owner: 10QChris) [12:57:16] (03PS2) 10Bartosz Dziewoński: Drop dead code from all SVG source files [core] - 10https://gerrit.wikimedia.org/r/111982 (owner: 10Thiemo Mättig (WMDE)) [13:00:54] (03CR) 10Bartosz Dziewoński: [C: 032] "Thank you!" [core] - 10https://gerrit.wikimedia.org/r/111982 (owner: 10Thiemo Mättig (WMDE)) [13:04:16] (03Merged) 10jenkins-bot: Drop dead code from all SVG source files [core] - 10https://gerrit.wikimedia.org/r/111982 (owner: 10Thiemo Mättig (WMDE)) [13:23:56] (03CR) 10Bartosz Dziewoński: "Ping?" [core] - 10https://gerrit.wikimedia.org/r/109124 (owner: 10Bartosz Dziewoński) [13:41:16] (03PS1) 10Bartosz Dziewoński: Vector: Simplify text paths in tiny icons [core] - 10https://gerrit.wikimedia.org/r/112234 [13:43:16] (03PS2) 10Bartosz Dziewoński: Vector: Simplify text paths in tiny icons [core] - 10https://gerrit.wikimedia.org/r/112234 [13:48:58] (03PS3) 10Bartosz Dziewoński: Optimize all SVGs (attempt 2) [core] - 10https://gerrit.wikimedia.org/r/106506 [13:50:59] I realized that jenkins stopped to run https://www.mediawiki.org/wiki/Parser_tests are they deprecated? [13:52:27] if they are deprecated it's fine for me... since I prefere to kind of abuse phpunit tests for the same purpose [13:53:51] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Something truly fascinating happened to document-icon.svg." [core] - 10https://gerrit.wikimedia.org/r/106506 (owner: 10Bartosz Dziewoński) [13:56:55] (03PS2) 10Umherirrender: Use TablePager on Special:ProtectedPages (using log_search) [core] - 10https://gerrit.wikimedia.org/r/105443 [13:57:45] (03CR) 10jenkins-bot: [V: 04-1] Use TablePager on Special:ProtectedPages (using log_search) [core] - 10https://gerrit.wikimedia.org/r/105443 (owner: 10Umherirrender) [13:57:52] (03CR) 10Umherirrender: "Patch Set 2: Addressed inline comments" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/105443 (owner: 10Umherirrender) [14:02:03] (03CR) 10Bartosz Dziewoński: "Filed an issue: https://github.com/svg/svgo/issues/182" [core] - 10https://gerrit.wikimedia.org/r/106506 (owner: 10Bartosz Dziewoński) [14:04:50] (03PS3) 10Umherirrender: Use TablePager on Special:ProtectedPages (using log_search) [core] - 10https://gerrit.wikimedia.org/r/105443 [14:05:43] (03PS2) 10Werdna: Anonymous editor warning [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109445 [14:05:46] (03CR) 10Umherirrender: "Patch Set 3: Rebased" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105443 (owner: 10Umherirrender) [14:53:02] (03PS1) 10Bartosz Dziewoński: Show a label next to Vector's dropdown actions menu [core] - 10https://gerrit.wikimedia.org/r/112236 [14:58:43] Hello. I am interested in GSoC'14. I came across the project idea's list of Wikimedia. I am interested in the project flow. Can anyone give more details about the same? [15:03:23] Kajol_: most of WMF's employees are not here during weekends, and they're the ones who could help [15:04:06] Okay. Thanks for the information. :) [15:05:50] Kajol_: in their absense, you might want to read https://www.mediawiki.org/wiki/Flow/Architecture [15:06:03] or other pages around https://www.mediawiki.org/wiki/Flow_Portal [15:06:32] (03PS2) 10Bartosz Dziewoński: Show a label next to Vector's dropdown actions menu [core] - 10https://gerrit.wikimedia.org/r/112236 [15:07:12] Thanks again. :) [15:19:03] How can I determine the MySQL server host for Wikipedias in the following languages: fiu-vro, zh-yue, bat-smg, nds-nl, roa-tara, cbk-zam, zh-min-nan, zh-classical, map-bms, be-x-old, roa-rup ? [15:19:29] e.g. fiu-vrowiki.labsdb is not a valid host [15:21:46] cff: s/-/_/ [15:26:05] how to add a svg version of an image in wikimedia...? [15:26:59] hoo: thx [16:11:14] (03PS2) 10Physikerwelt: Fix: Allow
as valid Math output [extensions/Math] - 10https://gerrit.wikimedia.org/r/111171 [17:00:24] I'm having a problem with the 1.23alpha (master) installation, not sure if it's something I might be missing or an actual reportable bug.. anyone knows if this is known already? Installation gets stuck on last step "Setting up database..." with php errors in the logs. [17:02:49] I haven't heard of that before. What are the errors in the logs? [17:07:47] let me see [17:08:02] [error] [client 127.0.0.1] PHP Warning: Cannot modify header information - headers already sent in /home/moriel/wikimedia/mediawiki/includes/WebResponse.php on line 38, referer: http://localhost/mediawiki/mw-config/index.php?page=Install [17:08:16] I have a whole bunch of those. [17:08:57] This is from my second attempt yesterday. I read that there was a similar problem in an earlier version that worked with Extensions, so I added in VisualEditor and tried again -- with the same error [17:09:07] I can try this again now so I have the full list of errors, I'll report it if it's unknown [17:13:51] bawolff, https://dpaste.de/BMfA [17:16:18] hmm, the last error is the most concerning one [17:17:14] This doesn't look like a local error, but I did manage to install the same version yesterday (I'm trying to get ubuntu to work on my old [oooooooooooooooold] pc) and it succeeded, *but* then showed an empty page at the end [17:17:21] which is usually an indication of bad permissions [17:17:31] ... could this be the case here again? seems weird [17:17:40] The PHP Fatal error: Call to a member function isSpecialPage() on a non-object in /home/moriel/wikimedia/mediawiki/includes/Skin.php on line 271, referer: http://localhost/mediawiki/mw-config/index.php?page=Install [17:17:43] is causing the blank page [17:18:11] Now there's no blank pages, the installation just stalls [17:18:37] It's stuck on "Setting up database..." -- and the mysql database seems to be finished, from brief look at it [17:19:13] oh, scratch that, database is empty. [17:19:43] bawolff, ok, so it sounds like it might not be just my local (old and cranky) environment... [17:20:20] * bawolff 's looking through the log to see if anyone has touched the installer recently, nothing stands out [17:23:04] bawolff, https://bugzilla.wikimedia.org/show_bug.cgi?id=61092 [17:24:21] bawolff, full disclosure: I am a linux noob, so it might be something I did wrong here, perhaps permissions. [17:24:37] I'm pretty sure its not a permission error [17:24:40] I'm trying to figure that out too, but it seems weird if that's the case, no? [17:24:52] yeah I thought so. Hm. [17:25:31] It looks like the installer is setting up OutputPage with a null object of some kind, possibly something to do with exception handling [17:26:01] Hi, I'm wondering why https://bugzilla.wikimedia.org/show_bug.cgi?id=61012 is not deployed? [17:26:35] It affects all pages that use align or alignat [17:27:51] the link to the code review: https://gerrit.wikimedia.org/r/#/c/112057/ [17:28:49] physikerwelt: Its not [17:29:05] physikerwelt: Nobody has +2'd the backport change [17:29:27] it does not look so [17:29:27] physikerwelt, greg said he wants Aaron or Sam to review and deploy [17:29:48] (see comment #10 on the bug report, from this morning) [17:30:00] physikerwelt: When its backported, somebody would have +2'd the change (whomever is backporting it would), and there would be a line about it at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:31:39] yes. what's the problem with the change [17:32:02] mooeypoo: Do you want to try installing using sqlite (if its available on your platform), just to narrow down the issue (Is it only mysql or is it all dbs) [17:32:20] I can try (you might have to help me out here) [17:32:23] physikerwelt: Probably nothings wrong, just nobody looked at it yet. It is the weekend [17:33:49] physikerwelt: If after a while, still nobody has looked at it, you could try pinging Aaron or Reedy [17:35:18] the point is that people are trying to change the pages to work around the bug [17:35:55] (03CR) 10Umherirrender: "I am still prefer the schema change (Ie40057398a7829c698df3d68813006798a72dccb), because than it looks possible to allow filtering the pro" [core] - 10https://gerrit.wikimedia.org/r/105443 (owner: 10Umherirrender) [17:36:49] bawolff, it only gives me the option of MySQL [17:37:01] Reedy: ping [17:37:35] bawolff, trying to figure out how to add sqlite [17:37:37] mooeypoo: Ok, that means php isn't compiled with sqlite support. Don't worry about it, I was just curious but it probably won't yield much info anyway [17:39:00] bawolff, ok [17:40:19] oh, I think I managed to reproduce the error sort of [17:40:42] physikerwelt: Hi. [17:40:55] Gloria: hi [17:40:58] physikerwelt: Given Wikimedia's recent math troubles, I was looking at some of your recent changesets. [17:41:09] physikerwelt: I _really_ wish you'd have someone other than you review and merge your code. [17:41:21] Gloria: me to [17:41:26] :-) [17:41:45] Yes, I suppose that's the catch. We need another person who can review Math. [17:42:00] bawolff, oh? [17:42:05] Wait, he's been self-merging to a WMF-deployed extension? [17:42:34] Krenair: That was basically my reaction. :-/ [17:43:10] I can probably review math, but not sure about Math. [17:43:19] Heh. [17:43:24] mooeypoo: I tried switching the if statement on line 245 of DatabaseInstaller.php and it triggered similar errors [17:45:31] Gloria: Just to understand my fault... what exactly is the main problem you see? [17:45:48] Gloria: Can you specify it in terms of commits? [17:46:34] bawolff, you mean line #243? I have } else { on #245 [17:46:58] yep, that one [17:47:03] * mooeypoo nods [17:47:16] I think it boils down to Exception.php trying to use $wgOut that isn't set up properly [17:47:20] was worried my repo might not be updated, but I just pulled again before trying, so it's updated [17:48:49] physikerwelt: The caching issue was obviously unfortunate. But there also seems to have been changes to what syntax is supported? [17:49:00] physikerwelt: I saw a comment yesterday that certain math inputs were now failing. [17:49:36] physikerwelt: And I was looking at https://bugzilla.wikimedia.org/showdependencytree.cgi?id=60997&hide_resolved=1 which had me somewhat worried. [17:50:15] physikerwelt: Math support getting love is great and everyone really appreciates it, don't get me wrong. [17:50:25] Gloria: I'm very unhappy about that. [17:50:50] mooeypoo: The easiest fix would be http://pastebin.com/nZsgGPPJ but it might be better to make $wgOut actually work [17:51:01] I'm thinking perhaps more code review, more testing coverage, and perhaps moving a bit slower might help. [17:51:08] Gloria: I don't get you wrong and I'm not happy with the things that get merged. [17:51:08] But I haven't been following along very closely. [17:51:31] Okay. Perhaps it's just a communications issue, then. :-) [17:52:57] bawolff, I'm not familiar enough with that part of the codebase, but this should probably have some sort of fix. how does it work in terms of standalone mw btw? This should block the version from being declared as 'stable' until fixed? [17:53:24] Gloria: The bad thing is that in the end the final result is worth copared to the things I had merged if there would be no code review at all... that's somehow contraintuitive and does not go along that I like the idea of code review so much that I tried to establish it at my university as well [17:53:50] mooeypoo: Well this fixes the problem that error reporting is broken, it doesn't fix the actual error you are recieving [17:53:55] Gloria: The idea to attract new developers for doing the code review for the math extension was somehow stupid [17:54:04] physikerwelt: How is the math test coverage? [17:54:20] and probably this should be fixed before next release, but that's a long way off [17:54:21] My (uninformed) sense is that that's the weak point. [17:54:36] Gloria: Very bad [17:54:48] Math should have parser tests, basically, but more complicated to support PNG, MathJax, etc. output. [17:54:58] physikerwelt: Is there a bug report about improving test coverage? [17:55:11] They are no longer run by Jenkins [17:55:11] bawolff, yeah. Hm. Are you going to have a patch, or should I just fix it up here and test per your pastebin? [17:55:16] physikerwelt: Ouch. [17:55:42] * Gloria --> lunch. [17:55:42] mooeypoo: I'll have a patch, I'm trying to see if there's a better solution [17:55:55] I'll see if I can poke at this later, though I'm kind of taking the day off. :P [17:56:01] bawolff, oh, ok, I thought you wanted me to test. I shall remain patient, then :D [17:56:09] mooeypoo: But yeah, try applying the pastebin thing locally, it will probably give you a better error message at least [17:56:19] * mooeypoo nods [17:58:17] what's Gloria's name at bugzilla [17:59:35] ^^probably Gloira [17:59:51] bawolff, got new errors for you [18:00:26] physikerwelt: MZMcBride [18:00:50] mooeypoo: Woo [18:01:08] physikerwelt: MZMcBride --> b@mzmcbride.com [18:01:12] B, for Bugzilla. [18:01:37] bawolff, seems to be my mysql permissions [18:01:44] Error: 1044 Access denied for user 'mwuser'@'localhost' to database 'devwiki' (localhost) [18:01:51] Gloria: thanks [18:02:38] Gloria: What is the z for in your other email address [18:02:52] mooeypoo: Well that should definitely be handled more gracefully by the installer [18:02:57] bawolff: Arbitrary. :-) I have aliases for A-Z. [18:03:06] I try to spread them out and there's usually a correlation. [18:03:10] bawolff, aye, I thought it should stop me in the database config stage [18:03:10] But sometimes it's arbitrary. [18:03:24] G for Git/Gerrit, B for Bugzilla, W for the wikis, etc. [18:03:56] But still. I would really like if https://gerrit.wikimedia.org/r/#/c/112057/ would be merged soon [18:05:00] (03PS1) 10Brian Wolff: Do not use OutputPage to output exceptions in Installer [core] - 10https://gerrit.wikimedia.org/r/112243 [18:08:30] bawolff, \o/ success [18:09:16] ... bawolff and now after saving LocalSettings.php, my wiki has a blank page [18:09:17] again. [18:09:28] :) [18:09:34] You should enable php error reporting [18:09:44] I tried. hang on, I think this is permissions [18:10:25] Gloria: You were absolutly right. The problematic change that was +2 by me had only 2 +1 [18:11:15] bawolff, \o/ works!! it was permission fluke, had to chmod LocalSettings.php [18:11:16] wooo [18:11:28] Hmm, we should give a better error for that [18:11:48] I imagine its really common to upload LocalSettings.php with the user's permission instead of apaches [18:12:07] yeah, since you have to download it and copy it over [18:12:19] it shows an empty page -- which in the docs says it's permissions, so that's something [18:12:42] (03CR) 10Physikerwelt: "Just to simplify the review... It's a fixup for Ida24b6bf339508753bed40d2e218c4a5b7fe7d0c" [extensions/Math] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112057 (owner: 10Physikerwelt) [18:12:48] bawolff, and error reporting doesn't work, because it doesn't read LocalSettings.php :p [18:13:21] Ah, that's why php.ini is good. It goes right at the source [18:13:54] (03PS3) 10Werdna: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 [18:14:05] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [18:14:26] bawolff: want to look at a small php patch? :) https://gerrit.wikimedia.org/r/#/c/112006/ [18:14:27] bawolff, ... good point, I didn't think about that [18:15:55] YuviPanda: Are we allowed to directly embed an svg file like that? Does everyone support svg now a days? (I haven't been keeping up with browser support wars) [18:16:19] bawolff: most things other than IE do, and I think that is what the other betafeatures stuff does as well anyway [18:16:45] IE is still kind of important :P [18:16:47] bawolff: VE definitely does it [18:16:54] And I think later IEs support it [18:17:17] bawolff: yeah, but betafeatures. [18:17:18] 'tis ok [18:17:25] Well provided that everyone else is doing it [18:17:47] It doesn't work correctly on lynx ;) [18:18:23] :P [18:18:24] Hmm, we should have a new section of Special:Version just for beta features perhaps [18:18:30] but that's not an issue with this commit [18:22:37] physikerwelt, there's been probably about 4 OTRS tickets about the Math extension throwing parse errors all over wikipedia articles [18:24:32] Krenair: what 4 OTRS? [18:25:32] bugzilla? [18:25:49] (03CR) 10MarkTraceur: [C: 04-1] "Just the one thing - better to support BetaFeatures as a soft dependency. Then we should be good to go." (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112006 (owner: 10Prtksxna) [18:26:32] (03CR) 10Brian Wolff: Add hook for BetaFeatures (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112006 (owner: 10Prtksxna) [18:26:36] physikerwelt, do you have access to OTRS? [18:27:16] Krenair: I don't think so [18:27:55] physikerwelt, well then there's no point in me telling you which ones [18:28:16] The relevant BZ report is https://bugzilla.wikimedia.org/show_bug.cgi?id=61026 I think [18:28:23] rdwrer: thanks for that :) there's also a couple of js ones https://gerrit.wikimedia.org/r/#/q/owner:%22SuchetaG+%253Csucheta.ghoshal%2540gmail.com%253E%22+status:,n,z [18:28:40] rdwrer: err, I mean https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/Popups+status:open,n,z [18:28:42] forget that link [18:28:58] or rather, the one it's a dupe of [18:29:51] Krenair: Yes I know the bug. [18:30:04] and I see that's my fault [18:30:21] and I created a fix [18:31:45] it should be fixed in the master branch [18:32:38] but (as I found out due to this bug) in production the wmf/1.23wmf13 branch is used and not master [18:35:40] (03CR) 10Brian Wolff: [C: 04-1] Fix z-index on popup (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/112044 (owner: 1001tonythomas) [18:37:19] how to add svg version of images in wikimedia..? [18:37:39] (03PS1) 10MarkAHershberger: Requires the UserDailyContribs extension but doesn't seem to document that anywhere. [extensions/ClickTracking] - 10https://gerrit.wikimedia.org/r/112244 [18:38:45] (03PS2) 1001tonythomas: Fixed z-index on popup [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/112044 [18:40:20] jme: Try finding previous commits that did that, and see what they do [18:41:24] bawolf: how do i find those commits? [18:42:10] !gerrit db6764e56c5fd542a [18:42:11] https://gerrit.wikimedia.org/r/#q,db6764e56c5fd542a,n,z [18:42:30] Is an example of such a commit [18:43:03] (If you have downloaded mediawiki via git, the command git log will give you a list of recent commits and what they did) [18:46:49] (03CR) 10Alex Monk: "Assuming this commit fixes the issue, please deploy it ASAP. It is very visible to readers - there have been numerous emails to info-en it" [extensions/Math] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112057 (owner: 10Physikerwelt) [18:47:12] (03CR) 10Alex Monk: "about it*" [extensions/Math] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112057 (owner: 10Physikerwelt) [18:47:52] bawolff: corrected the z-index patch. [18:49:14] bawolff: I found one commit of ori. [18:49:21] tonythomas01: Thanks. I need to test it in a few other situations. I'm worried it might mess up when its showing a video in a pop up [18:50:09] bawolff: ok. ! np [18:51:24] Hmm, not helped by the fact that TimedMediaHandler spontanously decided to stop working locally... [18:52:06] bawolff: happens. Last day, I too couldnt test it myself [18:52:36] TimedMediaHandler isn't exactly the most robust piece of code [18:53:03] bawolff: yeah. [18:59:11] tonythomas01: Hmm, still doesn't work [18:59:21] looks like we don't use the class .mv-player [18:59:26] bawolff: thats sad :( [18:59:47] rdwrer: review for the rest of the stuff? [19:00:06] Oh, I got sidetracked again [19:00:09] * rdwrer looks [19:00:23] tonythomas01: I think mv-player is a class for a skin we don't use or something [19:00:43] rdwrer: :) [19:03:50] bawolff: when I applied it directly in my browser inspector it worked fine [19:06:28] (03CR) 10Brian Wolff: [C: 04-1] "We don't seem to use the mv-player theme. I think this css should be in MwEmbedModules/EmbedPlayer/resources/skins/kskin/PlayerSkinKskin.c" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/112044 (owner: 1001tonythomas) [19:06:54] tonythomas01: Did you apply it directly to the element, or the entire rule (with the .mv-player part) [19:06:56] bawolff: when I applied z-index: 3 in the properties of
(as per chrome inspector ) it worked [19:07:25] Yes, but the rule in the css file you changed was .mv-player .overlay-win [19:07:35] (Which is my fault, since I told you to change that one) [19:11:56] (03CR) 10Brian Wolff: "Additional problem, when you apply z-index: 3 to the overlay for a popup video (i.e. Videos < $wgMinimumVideoPlayerSize), everything becom" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/112044 (owner: 1001tonythomas) [19:14:04] (03PS3) 1001tonythomas: Fix z-index on popup [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/112044 [19:14:26] bawolff: applied to ui-widget-content [19:18:58] tonythomas01: Ok, that works better, but the z-index needs to be higher for videos that use the jquery pop-up [19:19:08] * bawolff reccomends z-index: 1503 [19:19:26] * tonythomas01 preparing the PS  [19:19:29] Otherwise the part of the dialog that says select code to embed can't be selected [19:20:55] (03PS4) 1001tonythomas: Fixed z-index on popup [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/112044 [19:21:51] * YuviPanda tries to gather rdwrer's attention again for the popup patches [19:23:53] Agh [19:25:19] (03CR) 10MarkTraceur: [C: 04-1] Add time ago in words at the bottom of the popup (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 (owner: 10Prtksxna) [19:27:47] (03PS1) 10Umherirrender: Add lllangname= and llautonym= for action=query&prop=langlinks [core] - 10https://gerrit.wikimedia.org/r/112245 [19:30:25] (03PS2) 10Umherirrender: Add lllangname= and llautonym= for action=query&prop=langlinks [core] - 10https://gerrit.wikimedia.org/r/112245 [19:30:27] (03CR) 10MarkTraceur: [C: 04-1] Add `redirects to` message at the top of the popup (034 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111983 (owner: 10Prtksxna) [19:30:35] YuviPanda: {{done}} can I get a cookie [19:30:35] https://www.mediawiki.org/wiki/Template:done [19:30:39] I am new to wikimedia . Can somebody guide me with this bug https://bugzilla.wikimedia.org/show_bug.cgi?id=60948 ? [19:30:42] * YuviPanda gives rdwrer a cookie [19:30:42] stfu wm-bot [19:30:55] Hi, jme! I'll take a look with you. [19:30:57] (03CR) 10Umherirrender: "Patch Set 2: Removed trailing whitespace" [core] - 10https://gerrit.wikimedia.org/r/112245 (owner: 10Umherirrender) [19:30:59] * YuviPanda gives rdwrer some new wikilove with the new redesigned wikilove! [19:31:13] rdwrer: I miss the day when the bot talked back to people [19:31:28] *days [19:31:35] jme: So first step is to find the files in the Translate repository. Can you open them up? [19:31:42] In a text editor, mind you. [19:32:13] rdwrer: ok let me have a look on them. [19:32:29] (03CR) 10Aaron Schulz: "Actually, nevermind you don't need any GROUP BY clause since this is enforced on the application level (if there were multiple logs relate" [core] - 10https://gerrit.wikimedia.org/r/105443 (owner: 10Umherirrender) [19:34:54] (03CR) 10Brian Wolff: [C: 032] "lgtm" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/112044 (owner: 1001tonythomas) [19:34:58] (03Merged) 10jenkins-bot: Fixed z-index on popup [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/112044 (owner: 1001tonythomas) [19:36:10] (03CR) 10Adamw: [C: 032] Style the titles of courses in the Special:MyCourses feed [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/111502 (owner: 10Ragesoss) [19:36:19] (03Merged) 10jenkins-bot: Style the titles of courses in the Special:MyCourses feed [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/111502 (owner: 10Ragesoss) [19:36:21] rdwrer: I could not find Translate repository .. [19:36:48] jme: Its full name is mediawiki/extensions/Translate.git [19:36:57] jme: http://git.wikimedia.org/tree/mediawiki%2fextensions%2fTranslate.git [19:37:09] bawolff: Thanks :) [19:37:20] tonythomas01: thanks for the patch [19:37:36] bawolff: :) np [19:37:38] (03CR) 10Aaron Schulz: [C: 032] Document parser cache key control. [core] - 10https://gerrit.wikimedia.org/r/98512 (owner: 10Daniel Kinzler) [19:37:58] jme: If you have gerrit account set up (Which you should do first) you can download with git clone ssh://@gerrit.wikimedia.org:29418/mediawiki/extensions/Translate.git [19:38:43] bawolff: ok let me set up a gerrit account. [19:38:54] (03CR) 10Umherirrender: "But the other patch allows to add a index on the table, having a index over three tables sounds not possible (maybe creating a view first," [core] - 10https://gerrit.wikimedia.org/r/105443 (owner: 10Umherirrender) [19:40:35] jme: you should try this :) www.mediawiki.org/wiki/Gerrit/Tutorial [19:41:00] (03Merged) 10jenkins-bot: Document parser cache key control. [core] - 10https://gerrit.wikimedia.org/r/98512 (owner: 10Daniel Kinzler) [19:41:25] tonythimas01: thanks.. yeah i was looking into that . [19:42:00] jme: Yo! [19:42:22] (03CR) 10Aaron Schulz: "Right, but I didn't actually see an index there. Also, the list of protected pages tends to be modest (especially per user), unless you ha" [core] - 10https://gerrit.wikimedia.org/r/105443 (owner: 10Umherirrender) [20:00:55] Can anyone gives some hints where to look if I want to know how the geohack URL is generated for a wiki page that has a geo coordinate in it? [20:02:01] Is it using ghel ? [20:04:11] bawolff: i have set up gerrit account .. but git clone ssh://@gerrit.wikimedia.org:29418/mediawiki/extensions/Translate.git is not cloning the repo.. its coz in my network i cannot make ssh connection outside my network. [20:04:48] You can do an http clone, but it will make submitting patches harder [20:05:59] jme try git clone http://gerrit.wikimedia.org/r/p/mediawiki/extensions/Translate.git [20:10:11] bawolff: its cloning.. [20:15:33] jme: Later on when you make your change - since you couldn't use ssh, in order to send in your fix, you will probably have to use http://tools.wmflabs.org/gerrit-patch-uploader/ [20:15:41] * bawolff has to go, good luck [20:27:17] rdwrer: yeah now i can see the translate repo and also the resources/images/ which contains both .png and .svg images .. [20:28:23] OK [20:28:38] jme: Now open the SVGs and add the version numbers to the elements :) [20:28:47] I think it's going to be 1.1 for all of them [20:30:06] don't forget to add a 'generated with adobe illustrator' tag to them all [20:32:50] (03CR) 10Jakobj: "method "getPermission": optional parameter should be the last" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112158 (owner: 10Matthias Mullie) [20:32:56] rdwrer: its already there in all the svgs [20:33:16] rdwrer: did you see the bug https://bugzilla.wikimedia.org/show_bug.cgi?id=60948 ? [20:33:48] i need to add the missing svg versions of png images.. [20:34:41] (03CR) 10Aaron Schulz: [C: 032] fix: texvccheck is not idempotent [extensions/Math] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112057 (owner: 10Physikerwelt) [20:34:49] (03Merged) 10jenkins-bot: fix: texvccheck is not idempotent [extensions/Math] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112057 (owner: 10Physikerwelt) [20:35:14] YuviPanda: in any of the already existing svg versions of the images 'generated with adobe illustrator' is not mentioned .. [20:35:32] jme: sorry, I was just joking :) don't worry about it [20:36:22] Oh, hm [20:36:41] jme: I'm not sure what the bug means, then [20:36:49] SVG version shouldn't make any difference in a PNG [20:37:10] ...right? [20:37:13] Am I insane? [20:38:15] rdwrer: I think you are right.. [20:38:18] YuviPanda: do you have any idea about this bug https://bugzilla.wikimedia.org/show_bug.cgi?id=60948 ? [20:38:39] rdwrer: no you are not. [20:39:01] jme: sorry, no. rdwrer might [20:40:04] I just finished saying I didn't, YuviPanda :P [20:40:05] YuviPanda: do you know anyone who can help me with this? [20:40:16] jme: Reply on the bug, ask for more information [20:40:27] Say it's silly to provide SVG versions in a PNG or something similar [20:40:35] oh [20:40:37] Maybe Nikerabbit can help? [20:42:12] rdwrer: I think I have chosen a selected a wrong bug gto solve .. .:P [20:42:30] No no, it's OK, we'll sort it out [20:42:40] I think I have selected a wrong bug to solve.. :P [20:43:39] rdwrer: I am a php developer and this seems to be a graphics problem .. [20:43:53] what do you say ? [20:44:10] jme: Well, you can switch if you want, it's not like you have to stick it out [20:46:16] (03Abandoned) 10UltrasonicNXT: Add convenience function User::isInGroup( $group ) [core] - 10https://gerrit.wikimedia.org/r/100590 (owner: 10UltrasonicNXT) [20:46:59] rdwrer: yeah i think I should do that.. [20:48:43] physikerwelt, hey [20:49:06] physikerwelt, I was expecting that to fix https://en.wikipedia.org/wiki/Euler%E2%80%93Maclaurin_formula#Proofs but it doesn't appear to have done so [20:51:14] Oh that's because it's wmf12. [20:51:56] AaronSchulz, doesn't https://gerrit.wikimedia.org/r/#/c/105187/ need to be in 1.23wmf12 as well? [20:53:17] rdwrer: ohh man, i think we misunderstood the bug ... it means that for several .png images there .svg files are missing... [20:54:18] but still I think i have chosen a wrong bug .. its graphics problem ... [20:55:32] (03PS1) 10Aaron Schulz: fix: texvccheck is not idempotent [extensions/Math] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112246 [20:57:15] (03CR) 10Physikerwelt: [C: 031] fix: texvccheck is not idempotent [extensions/Math] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112246 (owner: 10Aaron Schulz) [20:58:30] (03CR) 10Aaron Schulz: [C: 032] fix: texvccheck is not idempotent [extensions/Math] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112246 (owner: 10Aaron Schulz) [20:58:37] (03Merged) 10jenkins-bot: fix: texvccheck is not idempotent [extensions/Math] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112246 (owner: 10Aaron Schulz) [21:04:44] physikerwelt: https://en.wikipedia.org/w/index.php?title=Real_projective_line&oldid=543928239&forceprofile=true [21:04:56] for a full cache hit (all pngs rendered) that is really slow [21:05:21] graphite shows a huge performance regression for MediaWiki.MathHooks.mathTagHook.tavg in the last few days as well [21:05:32] 96.73% 21.217089 85 - MathHooks::mathTagHook [21:06:04] https://graphite.wikimedia.org/render/?width=849&height=455&_salt=1391893417.452&target=MediaWiki.MathHooks.mathTagHook.tavg&from=-7days [21:07:12] AaronSchulz: do you think it's because of the shell out of texvccheck? [21:08:24] we can disable that to test if that's the reason [21:09:04] so previously it just did a HEAD to swift (usually averted by memcached 92% of the time) and now it shells out each time to check syntax? [21:09:18] (for the case were the png is there already) [21:10:05] yes it does the shell out in every case... [21:10:43] but it does call latex only if the image is not already there? [21:12:47] (03PS3) 10Isarra: Show a label next to Vector's dropdown actions menu [core] - 10https://gerrit.wikimedia.org/r/112236 (owner: 10Bartosz Dziewoński) [21:14:22] (03CR) 10Isarra: "Also we should change the (actions) message. 'Actions' is a very strange label to give the user. Something like 'Tools' would be a lot mor" [core] - 10https://gerrit.wikimedia.org/r/112236 (owner: 10Bartosz Dziewoński) [21:15:47] AaronSchulz: Maybe we should disable texvccheck if uses too manny resouces [21:19:11] AaronSchulz: How long does it take until the patch is deployed? [21:19:36] what patch? [21:19:56] that https://gerrit.wikimedia.org/r/#/c/112246/ [21:20:06] I already merged that a while ago [21:20:13] (03PS4) 10Isarra: Show a label next to Vector's dropdown actions menu [core] - 10https://gerrit.wikimedia.org/r/112236 (owner: 10Bartosz Dziewoński) [21:20:21] you weren't in #wikimedia-operations [21:21:57] does action=purge clear all caches? [21:23:50] there are lots of caches...not sure which ones you mean :) [21:24:24] the thing is if I enter new equations everything works fine [21:24:51] but for the "cached" ones there is still an error [21:26:10] an error on preview and purge (with no text changes)? [21:26:22] are you saying you have to change some text first? [21:26:51] * AaronSchulz was running into that problem with his test wiki...didn't have time to figure out the full reason [21:27:21] no I just added action=purge to the url [21:27:54] ok now it seems to work [21:27:54] https://en.wikipedia.org/wiki/Help:Displaying_a_formula [21:49:40] (03CR) 10Bartosz Dziewoński: "These files are somewhat modified at this point and could reasonably enough be namespaces under 'mediawiki.'. But I think that's not what " [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [21:55:34] (03PS1) 10IAlex: Use wfShellWikiCmd() for the shell command in cleanupSpam.php [core] - 10https://gerrit.wikimedia.org/r/112297 [21:57:41] (03CR) 10Bartosz Dziewoński: "The problem with the image is that people were trying to make it possible to change Vector's colours via CSS only, with relation to bug 51" [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [21:59:39] (03PS1) 10UltrasonicNXT: Add {{NUMBEROFVOTESPAGE}} [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/112298 [21:59:39] https://www.mediawiki.org/wiki/Template:NUMBEROFVOTESPAGE [22:00:32] (03CR) 10Bartosz Dziewoński: [C: 032] "I think I'll merge this for now and file some bugs about how silly this solution is instead. :)" [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [22:03:55] (03Merged) 10jenkins-bot: Vector: Restore page-fade.png as fallback background-image for IE 6-9 [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [22:05:56] (03CR) 10Bartosz Dziewoński: "(If you believe this is worth backporting to currently deployed WMF versions, please bug someone who can do this about it.)" [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [22:07:36] (03CR) 10Jack Phoenix: "Yay! Functionality-wise this looks good to go." (035 comments) [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/112298 (owner: 10UltrasonicNXT) [22:13:57] (03PS2) 10UltrasonicNXT: Add {{NUMBEROFVOTESPAGE}} [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/112298 [22:13:58] https://www.mediawiki.org/wiki/Template:NUMBEROFVOTESPAGE [22:16:30] (03PS1) 10Bartosz Dziewoński: Vector: Delete edit-icon.png [core] - 10https://gerrit.wikimedia.org/r/112301 [22:20:47] (03CR) 10Jack Phoenix: [C: 032 V: 032] Add {{NUMBEROFVOTESPAGE}} [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/112298 (owner: 10UltrasonicNXT) [22:20:47] https://www.mediawiki.org/wiki/Template:NUMBEROFVOTESPAGE [22:26:03] (03CR) 10Daniel Friesen: """"The problem is, the point where we did it wrong was when we created the skins.common.* modules. These are not complete skins, so they d" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [22:30:02] (03CR) 10Daniel Friesen: "Hmmm... maybe "even though it has been modified" would've been a politer way to phrase that." [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [23:05:37] (03PS2) 10Parent5446: Added more filter options to $wgRCFeeds [core] - 10https://gerrit.wikimedia.org/r/111736 [23:11:05] Question about PHPStorm debugging: if I'm using the xdebug.remote_connect_back=0 setting, how does the IDE know to make a debug connection at the same time I browse to a page? Wouldn't I have to point the browser to make a request through the IDE? [23:36:43] awight: xdebug.remote_connect_back is not what you think. xdebug *always* initiates the connection to the IDE [23:37:13] awight: xdebug.remote_connect_back just determines what IP xdebug will try and connect to [23:43:55] parent5446: well, we just had a situation where apache would hang and not serve (no access.log, even) if the remote_connect_back setting=1 [23:44:16] parent5446: documentation says that setting determines whether php will "always call home" [23:50:13] (03CR) 10Technical 13: [C: 031] Add an API module for querying AntiSpoof results. [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/87546 (owner: 10Stwalkerster) [23:52:55] (03PS1) 10Legoktm: Add custom extension type for Beta features [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/112302 [23:54:22] (03PS1) 10Legoktm: Set extension type to 'betafeatures' [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/112303 [23:56:37] (03CR) 10Legoktm: [C: 04-1] Add hook for BetaFeatures (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112006 (owner: 10Prtksxna)