[00:04:23] Reedy, any idea? [00:05:50] Krenair: gem1.9.1? [00:05:54] or something like that? [00:06:39] (03CR) 10Spage: [C: 032] "two patches for Echo and Flow updating to 08a5049 and 0c70332 respectively." [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111940 (owner: 10EBernhardson) [00:06:43] ah, probably not [00:06:59] Same as just 'gem' [00:07:07] (03CR) 10Physikerwelt: "I'd vote for testing it with texvccheck first." [extensions/Math] - 10https://gerrit.wikimedia.org/r/111916 (owner: 10Chad) [00:07:17] `which -a gem` [00:07:33] or i guess just scan the filesystem for executables named 'gem', heh [00:07:48] rdwrer: Can you +1 https://gerrit.wikimedia.org/r/#/c/111676/ ? [00:08:52] MatmaRex, "ls /usr/bin | grep gem" reveals only gem and gem1.9.1 (which are identical). "which -a gem" only lists /usr/bin/gem [00:09:47] (03PS2) 10Krinkle: Update VisualEditor to 1.23wmf12 branch for cherry-pick [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111697 (owner: 10Catrope) [00:09:56] at this point i would `find / -name gem` :P [00:10:09] (03CR) 10Krinkle: [C: 031] Update VisualEditor to 1.23wmf12 branch for cherry-pick [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111697 (owner: 10Catrope) [00:10:25] also, i think you can get `gem` to install to / uninstall from several locations [00:10:37] (03Merged) 10jenkins-bot: Update Echo and Flow [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111940 (owner: 10EBernhardson) [00:11:10] --[no-]user-install Install in user's home directory instead [00:11:10] of GEM_HOME. [00:11:18] that too, check your GEM_HOME [00:11:31] Krinkle: On it [00:11:47] I don't appear to have a GEM_HOME...? Maybe I'm doing it wrong [00:12:01] (03CR) 10MarkTraceur: [C: 031] mediawiki.jqueryMsg: Add jsduck docs [core] - 10https://gerrit.wikimedia.org/r/111676 (owner: 10MarkTraceur) [00:14:21] Krinkle: {{done}} [00:14:21] https://www.mediawiki.org/wiki/Template:done [00:14:33] (03CR) 10Krinkle: [C: 032] mediawiki.jqueryMsg: Add jsduck docs [core] - 10https://gerrit.wikimedia.org/r/111676 (owner: 10MarkTraceur) [00:14:38] Thx [00:14:48] Krenair: maybe you should just set it to wherever that gem is installed, then uninstall [00:15:08] (03PS1) 10Krinkle: Update VisualEditor to 1.23wmf13 branch for cherry-pick [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111942 [00:15:22] (03CR) 10Krinkle: [C: 031] Update VisualEditor to 1.23wmf13 branch for cherry-pick [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111942 (owner: 10Krinkle) [00:15:42] MatmaRex, uninstall gem hoping to find another gem somewhere else? [00:16:02] wait, i'm not sure what you're trying to do [00:16:06] wm-bot: That was super unhelpful [00:16:06] Hi rdwrer, there is some error, I am a stupid bot and I am not intelligent enough to hold a conversation with you :-) [00:16:12] CLEARLY. [00:16:41] rdwrer: it's useful when you want to link to [[developer access]] or something [00:16:41] https://www.mediawiki.org/wiki/developer_access [00:16:44] (03CR) 10EBernhardson: [C: 032] Update Echo and Flow [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111939 (owner: 10EBernhardson) [00:16:49] But a template? Guh. [00:16:58] [[Template:Done]] [00:16:58] https://www.mediawiki.org/wiki/Template:Done [00:17:01] Helpful. [00:17:07] {{done}} unhelpful [00:17:07] https://www.mediawiki.org/wiki/Template:done [00:17:20] submit a patch ~ [00:17:22] @info [00:17:23] http://bots.wmflabs.org/~wm-bot/dump/%23wikimedia-dev.htm [00:17:27] @help [00:17:27] I am running http://meta.wikimedia.org/wiki/WM-Bot version wikimedia bot v. 1.20.2.1 my source code is licensed under GPL and located at https://github.com/benapetr/wikimedia-bot I will be very happy if you fix my bugs or implement new features [00:18:08] you can sorta kinda get the bot to ignore some stuff [00:18:12] like it ignores !logs [00:18:40] but this apparently only applies to !commands [00:19:31] (03Merged) 10jenkins-bot: mediawiki.jqueryMsg: Add jsduck docs [core] - 10https://gerrit.wikimedia.org/r/111676 (owner: 10MarkTraceur) [00:19:45] (03CR) 10jenkins-bot: [V: 04-1] Update VisualEditor to 1.23wmf13 branch for cherry-pick [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111942 (owner: 10Krinkle) [00:20:20] ffs [00:20:20] https://integration.wikimedia.org/ci/job/mediawiki-core-phpunit-misc/19549/console [00:20:23] (03Merged) 10jenkins-bot: Update Echo and Flow [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111939 (owner: 10EBernhardson) [00:20:32] The tests take too long that a unit test fails that compares timestamps in core [00:20:44] silly test of course [00:20:46] MatmaRex, I would like to upgrade Vagrant so I can mess with the cirrussearch role [00:20:54] (03PS2) 10Krinkle: Update VisualEditor to 1.23wmf13 branch for cherry-pick [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111942 [00:21:01] To do this I need to uninstall it from being a gem apparently [00:21:09] However, gem does not agree with me that vagrant is installed [00:21:19] And therefore won't uninstall it [00:21:52] did you install it via apt [00:21:53] ? [00:21:58] dpkg -l | grep vagrant [00:22:31] (03CR) 10Krinkle: Support attribute selectors in CSSJanus (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105639 (owner: 10Catrope) [00:22:42] (03CR) 10Krinkle: [C: 032] Update VisualEditor to 1.23wmf13 branch for cherry-pick [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111942 (owner: 10Krinkle) [00:22:52] (03CR) 10Krinkle: [C: 032] Update VisualEditor to 1.23wmf12 branch for cherry-pick [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111697 (owner: 10Catrope) [00:23:00] (03CR) 10Bsitu: [C: 032] Auto-wrapping explicit escaper for templates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103317 (owner: 10EBernhardson) [00:23:24] Krenair: i suggest rm -rf [00:23:28] Reedy, I'm confused because it shows up in both apt and the error I'm getting includes a lot of references to /opt/vagrant/embedded/gems/gems/vagrant-1.0.5 [00:23:43] (03CR) 10TTO: "What? The fact that this stemmed from the Draft space stuff is irrelevant. This is a valid MediaWiki core change that should stand on its " [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO) [00:24:12] (03Merged) 10jenkins-bot: Auto-wrapping explicit escaper for templates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103317 (owner: 10EBernhardson) [00:26:11] /opt is old school [00:27:00] (03Merged) 10jenkins-bot: Update VisualEditor to 1.23wmf13 branch for cherry-pick [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111942 (owner: 10Krinkle) [00:27:12] (03PS7) 10Physikerwelt: Add VisualEditor support [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 (owner: 10Catrope) [00:27:14] (03Merged) 10jenkins-bot: Update VisualEditor to 1.23wmf12 branch for cherry-pick [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111697 (owner: 10Catrope) [00:32:21] (03PS2) 10IAlex: Used DIRECTORY_SEPARATOR instead of '/' in GitInfo.php [core] - 10https://gerrit.wikimedia.org/r/111777 (owner: 1001tonythomas) [00:33:04] (03CR) 10Physikerwelt: [C: 031] "Just rebased... but still depends on Iab0c56246626de1e0f which does not work." [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 (owner: 10Catrope) [00:33:48] (03CR) 10IAlex: "Corrected code format." [core] - 10https://gerrit.wikimedia.org/r/111777 (owner: 1001tonythomas) [00:33:57] (03CR) 10IAlex: [C: 032] Used DIRECTORY_SEPARATOR instead of '/' in GitInfo.php [core] - 10https://gerrit.wikimedia.org/r/111777 (owner: 1001tonythomas) [00:34:30] (03PS3) 10Mattflaschen: Have mtime as calculated by startup module increase on schema change [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/111731 [00:34:49] (03CR) 10Mattflaschen: "Done in next patch set" (032 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/111731 (owner: 10Mattflaschen) [00:35:17] (03CR) 10jenkins-bot: [V: 04-1] Have mtime as calculated by startup module increase on schema change [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/111731 (owner: 10Mattflaschen) [00:36:36] (03CR) 10Mattflaschen: "recheck" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/111731 (owner: 10Mattflaschen) [00:37:11] (03Merged) 10jenkins-bot: Used DIRECTORY_SEPARATOR instead of '/' in GitInfo.php [core] - 10https://gerrit.wikimedia.org/r/111777 (owner: 1001tonythomas) [00:51:37] (03PS1) 10Matthias Mullie: Fix work-breaking in FireFox [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111944 [00:52:03] (03CR) 10EBernhardson: [C: 032] Fix work-breaking in FireFox [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111944 (owner: 10Matthias Mullie) [00:52:13] (03Merged) 10jenkins-bot: Fix work-breaking in FireFox [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111944 (owner: 10Matthias Mullie) [00:58:45] (03CR) 10Swalling: "If what you're saying is that this should be evaluated solely on its own merits..." [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO) [01:06:51] (03CR) 10Legoktm: [C: 04-1] "Err, the right-throttleoverride message is still missing." [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/109443 (owner: 10Parent5446) [01:09:09] (03PS4) 10Ori.livneh: Have mtime as calculated by startup module increase on schema change [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/111731 (owner: 10Mattflaschen) [01:09:13] (03PS5) 10Legoktm: Cleanup to ThrottleOverrideHooks::onPingLimiter [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/109444 (owner: 10Parent5446) [01:09:29] (03CR) 10Legoktm: [C: 032] Cleanup to ThrottleOverrideHooks::onPingLimiter [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/109444 (owner: 10Parent5446) [01:09:45] superm401: I changed the wording of the comment in https://gerrit.wikimedia.org/r/#/c/111731/3..4/includes/ResourceLoaderSchemaModule.php ; is that OK by you? [01:11:53] (03CR) 10Ori.livneh: "PS4: Tweaked the wording of the comment; otherwise unchanged. Whew -- I'm really glad you caught and fixed this bug." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/111731 (owner: 10Mattflaschen) [01:17:48] Reedy, ori: Got rid of it with apt-get remove - I still don't understand why it appeared to have been installed as a gem earlier [01:19:17] hacks [01:19:18] magic [01:19:20] linux [01:19:21] it's ruby! [01:19:38] Most package managers get confused with multiple versions from multiple sources [01:20:28] Like PHPUnit [01:21:56] Channel "doc.php.net" is not responding over http://, failed with message: Connection to `doc.php.net:80' failed: Connection timed out [01:21:56] Trying channel "doc.php.net" over https:// instead [01:22:00] gj Pickle [01:22:24] (03PS1) 10IAlex: Add two new debug log groups [core] - 10https://gerrit.wikimedia.org/r/111946 [01:22:26] heh [01:25:17] (03CR) 10Legoktm: [C: 032 V: 032] Fixed filtering for target field on Special:ThrottleOverride (031 comment) [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/109442 (owner: 10Parent5446) [01:30:31] (03CR) 10Alex Monk: "Did that get done?" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/76460 (owner: 10TTO) [01:31:30] (03PS6) 10Bsitu: Add correspond *_user_wiki field to all *_user_id fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 [01:31:52] (03PS7) 10Bsitu: Add corresponding *_user_wiki field to all *_user_id fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 [01:33:36] (03PS1) 10Isarra: Turned css into less, something about a shovel. [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/111949 [01:36:10] (03CR) 10Isarra: [C: 032 V: 032] "Hi." [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/111949 (owner: 10Isarra) [01:37:23] (03CR) 10TTO: "No, not yet. I'll have to summon the strength to do it at some stage." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/76460 (owner: 10TTO) [01:37:31] (03CR) 10Ori.livneh: [C: 032] Have mtime as calculated by startup module increase on schema change [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/111731 (owner: 10Mattflaschen) [01:38:01] (03Merged) 10jenkins-bot: Have mtime as calculated by startup module increase on schema change [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/111731 (owner: 10Mattflaschen) [01:39:07] (03PS3) 10TTO: Allow interlanguage link prefixes that are not language codes [core] - 10https://gerrit.wikimedia.org/r/111390 [01:40:25] (03Abandoned) 10Physikerwelt: Install node and phantomjs for serverside MathJax execution [vagrant] - 10https://gerrit.wikimedia.org/r/90702 (owner: 10Physikerwelt) [01:48:30] (03PS12) 10Jforrester: Add OOjs UI v0.1.0-pre (ddff003909) to core [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [01:49:48] (03CR) 10Jforrester: "@Hashar: Can you please remove your -2 or respond to my, Chad's and Bartosz's concerns?" [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [01:50:25] (03CR) 10jenkins-bot: [V: 04-1] Add OOjs UI v0.1.0-pre (ddff003909) to core [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [01:54:55] (03PS8) 10Bsitu: Add corresponding *_user_wiki field to all *_user_id fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 [01:54:58] (03PS1) 10Bsitu: Pull flow revision data based on user_wiki and user_id/user_ip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111952 [01:58:08] (03PS1) 10Anomie: API: Refactor continuation code and add to purge, watch, etc. [core] - 10https://gerrit.wikimedia.org/r/111954 [02:00:11] ori, to install the vagrant package I have to remove virtualbox? what [02:00:16] (03PS3) 10Ori.livneh: mediawiki.user: Remove #name and #anonymous; deprecate #bucket [core] - 10https://gerrit.wikimedia.org/r/111422 [02:00:32] Krenair: is your virtualbox ancient too? [02:00:41] (03PS4) 10Ori.livneh: mediawiki.user: Remove #name and #anonymous; deprecate #bucket [core] - 10https://gerrit.wikimedia.org/r/111422 [02:01:01] ori, 4.2.4-81684~Ubuntu~natty [02:01:51] (03CR) 10jenkins-bot: [V: 04-1] API: Refactor continuation code and add to purge, watch, etc. [core] - 10https://gerrit.wikimedia.org/r/111954 (owner: 10Anomie) [02:04:29] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.user: Remove #name and #anonymous; deprecate #bucket [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh) [02:05:52] (03PS1) 10Matthias Mullie: Fix clearfix, which triggered scrollbars [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111955 [02:06:40] (03PS5) 10Ori.livneh: mediawiki.user: Remove #name and #anonymous; deprecate #bucket [core] - 10https://gerrit.wikimedia.org/r/111422 [02:07:52] (03PS2) 10Anomie: API: Refactor continuation code and add to purge, watch, etc. [core] - 10https://gerrit.wikimedia.org/r/111954 [02:17:03] (03CR) 10EBernhardson: Formatter for CheckUser rows (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111354 (owner: 10EBernhardson) [02:20:25] (03CR) 10Legoktm: Formatter for CheckUser rows (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111354 (owner: 10EBernhardson) [02:22:16] (03CR) 10Matthias Mullie: Formatter for CheckUser rows (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111354 (owner: 10EBernhardson) [02:23:45] (03PS3) 10Ori.livneh: ResourceLoader: pass jQuery twice to 'implements' module wrapper [core] - 10https://gerrit.wikimedia.org/r/85637 [02:28:07] (03CR) 10Alex Monk: "minor thing" (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/103119 (owner: 10MegaAlex) [02:32:54] (03Abandoned) 10Ori.livneh: Restore module storage logging for I7183778cb [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/100722 (owner: 10Ori.livneh) [02:37:00] (03PS1) 10Krinkle: mediawiki.log: Move #warn and #deprecate to mediawiki.js and add tracking [core] - 10https://gerrit.wikimedia.org/r/111957 [02:37:29] (03PS1) 10Matthias Mullie: Get rid of hyphenation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111958 [02:37:49] (03CR) 10jenkins-bot: [V: 04-1] Get rid of hyphenation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111958 (owner: 10Matthias Mullie) [02:37:51] ori, that's fine. It occurred to me that we could just use the actual schema mtime, instead of workarounds. [02:38:00] But that would require an API change, so this is simpler. [02:38:25] (03PS2) 10Matthias Mullie: Get rid of hyphenation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111958 [02:40:22] (03PS1) 10Legoktm: GitInfo: Suppress some wrong warnings [core] - 10https://gerrit.wikimedia.org/r/111959 [02:41:13] superm401: also vulnerable to time synchronization issues cross-wiki [02:41:23] using the actual schema mtime, i mean [02:41:25] (03CR) 10Legoktm: "My .git/config has:" [core] - 10https://gerrit.wikimedia.org/r/111959 (owner: 10Legoktm) [02:47:23] (03PS2) 10Ori.livneh: mediawiki.inspect: add method for grepping loaded modules [core] - 10https://gerrit.wikimedia.org/r/97856 [02:56:06] (03PS2) 10Krinkle: mediawiki.log: Move #warn and #deprecate to mediawiki.js and add tracking [core] - 10https://gerrit.wikimedia.org/r/111957 [03:19:44] (03PS5) 10EBernhardson: Add hook SpecialCheckUserGetLinksFromRow [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/111249 [03:20:11] (03CR) 10Krinkle: mediawiki.inspect: add method for grepping loaded modules (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97856 (owner: 10Ori.livneh) [03:21:35] (03CR) 10Krinkle: [C: 031] GitInfo: Suppress some wrong warnings [core] - 10https://gerrit.wikimedia.org/r/111959 (owner: 10Legoktm) [03:24:02] (03CR) 10Krinkle: "So those long sequences without detectable break points from the dictionary, will they still be broken up? The hyphen doesn't matter much " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111958 (owner: 10Matthias Mullie) [03:30:12] (03CR) 10EBernhardson: "Moved hook to after the default links are generated. Also changed $links from string to an associative array. If we are moving the hook " [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/111249 (owner: 10EBernhardson) [03:38:40] (03PS4) 10Krinkle: [WIP] mediawiki.api: Refactor getToken and postWithToken methods [core] - 10https://gerrit.wikimedia.org/r/111636 [03:45:43] (03PS3) 10EBernhardson: Formatter for CheckUser rows [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111354 [03:45:46] (03CR) 10jenkins-bot: [V: 04-1] Formatter for CheckUser rows [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111354 (owner: 10EBernhardson) [03:46:51] (03PS5) 10Krinkle: mediawiki.api: Refactor getToken and postWithToken methods [core] - 10https://gerrit.wikimedia.org/r/111636 [03:49:08] (03CR) 10EBernhardson: "PS3: Addressed comments on PS1 and PS2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111354 (owner: 10EBernhardson) [03:51:38] (03PS4) 10EBernhardson: Formatter for CheckUser rows [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111354 [03:59:09] (03PS3) 10Krinkle: qunit: Add SinonJS utility [core] - 10https://gerrit.wikimedia.org/r/111634 [03:59:14] (03PS7) 10Isarra: Add normalize.css as an available resource in skins/common/ [core] - 10https://gerrit.wikimedia.org/r/110908 [03:59:15] (03PS3) 10Krinkle: mediawiki.api.test: Use sinon sandbox for unit tests [core] - 10https://gerrit.wikimedia.org/r/111635 [03:59:27] (03PS6) 10Krinkle: mediawiki.api: Refactor getToken and postWithToken methods [core] - 10https://gerrit.wikimedia.org/r/111636 [04:00:47] (03CR) 10jenkins-bot: [V: 04-1] Add normalize.css as an available resource in skins/common/ [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [04:16:45] (03PS1) 10Krinkle: jquery.tablesorter.test: Re-organise variables [core] - 10https://gerrit.wikimedia.org/r/111962 [04:16:47] (03PS1) 10Krinkle: [WIP] Set up node-jscs via Grunt (and pass it) [core] - 10https://gerrit.wikimedia.org/r/111963 [04:17:06] (03PS2) 10Krinkle: [WIP] Set up node-jscs via Grunt (and pass it) [core] - 10https://gerrit.wikimedia.org/r/111963 [04:17:45] (03CR) 10Krinkle: "Using Array#reduce instead of a closure with a variable, Array#filter, and Array#map." [core] - 10https://gerrit.wikimedia.org/r/111963 (owner: 10Krinkle) [04:20:15] (03PS3) 10Krinkle: [WIP] Set up node-jscs via Grunt (and pass it) [core] - 10https://gerrit.wikimedia.org/r/111963 [04:45:58] (03PS8) 10Skizzerz: Add normalize.css as an available resource in skins/common/ [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [04:50:43] (03PS9) 10Isarra: Add normalize.css as an available resource in skins/common/ [core] - 10https://gerrit.wikimedia.org/r/110908 [04:52:06] (03PS6) 10Skizzerz: Add in preliminary MS SQL support [core] - 10https://gerrit.wikimedia.org/r/105138 [04:52:57] (03CR) 10jenkins-bot: [V: 04-1] Add in preliminary MS SQL support [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz) [04:55:53] (03PS7) 10Skizzerz: Add in preliminary MS SQL support [core] - 10https://gerrit.wikimedia.org/r/105138 [05:04:10] (03PS1) 10Liangent: Remove user preference "noconvertlink" [core] - 10https://gerrit.wikimedia.org/r/111968 [05:05:50] (03Abandoned) 10Liangent: Write a better explaination for tog-noconvertlink. [core] - 10https://gerrit.wikimedia.org/r/19769 (owner: 10Liangent) [05:06:46] (03PS2) 10Liangent: Remove user preference "noconvertlink" [core] - 10https://gerrit.wikimedia.org/r/111968 [05:13:08] (03PS3) 10Liangent: Remove user preference "noconvertlink" [core] - 10https://gerrit.wikimedia.org/r/111968 [05:32:11] YuviPanda: What all do we need to do for security on the Popups extension? [05:32:20] prtksxna: let's get it merged first [05:32:24] * YuviPanda pokes legoktm [05:32:28] hiya [05:32:39] YuviPanda: I received some CR, need to push changes [05:32:44] ah [05:32:48] prtksxna: from whom? [05:33:00] YuviPanda: legoktm :) [05:33:21] prtksxna: :) [05:33:29] (03CR) 10Krinkle: "Since this a generic upstream lib, it shouldn't registered under "skins". Skins can depend on this or load it, but it shouldn't be in skin" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [05:40:40] (03CR) 10Prtksxna: Add JS/CSS resources (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111763 (owner: 10Prtksxna) [05:40:43] (03PS3) 10Prtksxna: Add animation to Popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111768 [05:40:45] (03PS2) 10Prtksxna: Remove `title` attribute from links that have the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111772 [05:40:47] (03PS2) 10Prtksxna: Add Triangle/Pokey to the NavigationPopups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111773 [05:40:49] (03PS4) 10Prtksxna: Add JS/CSS resources [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111763 [05:41:31] YuviPanda: We'll start with the localisation stuff? [05:41:58] (03PS1) 10Pastakhov: define float type for Hooks [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/111971 [05:42:36] (03CR) 10Pastakhov: [C: 032] define float type for Hooks [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/111971 (owner: 10Pastakhov) [05:42:41] (03Merged) 10jenkins-bot: define float type for Hooks [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/111971 (owner: 10Pastakhov) [05:43:28] prtksxna: hmm, sure [05:43:49] (03PS1) 10Pastakhov: add Math Functions [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/111972 [05:44:34] YuviPanda: Any ideas on what library to use for 'timeAgo'? [05:44:59] YuviPanda: We also need to make changes according to the feedback on the mailing list on WL! [05:45:04] prtksxna: looks like we should just do it ourselves [05:45:26] prtksxna: but with mw.msg instead of hardcoded strings [05:45:32] prtksxna: make that a separate js file? [05:45:33] YuviPanda: Hm, so in Yair's new script, he is taking care of localisation too [05:45:40] prtksxna: yeah, I saw that. we could steal it [05:45:54] umm [05:45:58] YuviPanda: New file to give time ago strings? [05:45:58] localization should be via RL [05:46:24] YuviPanda: The only other localisation thing is the 'redirects here' string [05:47:05] legoktm: err, yeah? this is just putting that timeago logic in a separate js file [05:47:09] prtksxna: no, just add on to this one [05:47:16] prtksxna: on the i18n.php file [05:47:18] ah, ok [05:47:21] ignore me then [05:47:32] YuviPanda: I lost you. What are you saying? [05:47:53] YuviPanda: Also, hang to make this quicker/lulz? [05:48:13] prtksxna: 1. put message contents in Popups.i18n.php, 2. Register them for use from JS with RL 3. Use them! [05:48:15] prtksxna: sure [05:48:29] (03PS6) 10Krinkle: jquery.client: Recognise Amazon Silk browser [core] - 10https://gerrit.wikimedia.org/r/110989 (owner: 10Alex Monk) [05:48:35] legoktm: think you can merge some of that code? it's been up for like a couple of weeks now :| [05:48:39] sure [05:48:40] link? [05:48:46] legoktm: also link to the NPP patch you asked me to merge? [05:49:05] YuviPanda: https://gerrit.wikimedia.org/r/#/c/94403/ [05:49:05] legoktm: https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/Popups+status:open,n,z [05:49:21] (03CR) 10jenkins-bot: [V: 04-1] jquery.client: Recognise Amazon Silk browser [core] - 10https://gerrit.wikimedia.org/r/110989 (owner: 10Alex Monk) [05:49:24] ah, PageTriage. I was looking for 'NewPage' something [05:50:59] (03PS7) 10Krinkle: jquery.client: Recognise Amazon Silk browser [core] - 10https://gerrit.wikimedia.org/r/110989 (owner: 10Alex Monk) [05:51:11] (03CR) 10Krinkle: "Rebased to resolve merge conflict." [core] - 10https://gerrit.wikimedia.org/r/110989 (owner: 10Alex Monk) [05:51:53] (03CR) 10Legoktm: [C: 032 V: 032] "A good start." (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111763 (owner: 10Prtksxna) [05:54:02] (03CR) 10Legoktm: [C: 04-1] Add animation to Popups (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111768 (owner: 10Prtksxna) [05:54:48] legoktm: I thought I took care of those line endings :( [05:55:00] apparently not [05:55:53] (03CR) 10Krinkle: mediawiki.notification: Return the Notification object from .notify calls (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110667 (owner: 10Bartosz Dziewoński) [05:55:56] (03PS2) 10Bartosz Dziewoński: mediawiki.notification: Return the Notification object from .notify calls [core] - 10https://gerrit.wikimedia.org/r/110667 [05:57:29] :| [06:00:01] (03CR) 10Legoktm: "I did a bit of searching, found https://stackoverflow.com/questions/287407/how-to-stop-title-attribute-from-displaying-tooltip-temporarily" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111772 (owner: 10Prtksxna) [06:01:40] YuviPanda: what? no 'popups' vagrant role? ;) [06:01:47] oh heh [06:01:52] you did it already [06:01:57] legoktm: :P [06:02:05] I hadn't git pull'd [06:02:08] :P [06:02:32] (03CR) 10Krinkle: "Pushed 'mediawiki-core-jslint'." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/111964 (owner: 10Krinkle) [06:02:36] (03CR) 10Krinkle: [C: 032] Separate job for mediawiki-core-jslint to use git-mwcore scm [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/111964 (owner: 10Krinkle) [06:02:37] legoktm: I tried that with mouseenter and it didn't work, I wonder what gets triggered first, hover or mouseenter [06:02:52] legoktm: Will try this too, its better to keep them on if we can [06:02:56] (03Merged) 10jenkins-bot: Separate job for mediawiki-core-jslint to use git-mwcore scm [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/111964 (owner: 10Krinkle) [06:03:26] (03PS4) 10Prtksxna: Add animation to Popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111768 [06:03:28] (03PS3) 10Prtksxna: Remove `title` attribute from links that have the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111772 [06:03:30] (03PS3) 10Prtksxna: Add Triangle/Pokey to the NavigationPopups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111773 [06:03:34] hm [06:03:35] ok [06:03:43] also, we should get jenkins jobs set up [06:03:46] (03CR) 10Prtksxna: Add animation to Popups (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111768 (owner: 10Prtksxna) [06:03:58] legoktm: no pagetriage role! [06:04:32] YuviPanda: IIRC, you just need to load the extension and run update.php [06:04:38] yeah [06:04:41] let me write one [06:05:04] I forget if it has a hard dependency on echo or if its soft [06:05:39] let's find out! [06:05:40] :P [06:08:27] (03CR) 10Isarra: "I'm not sure what being an upstream library has to do with anything. skins/common is for resources common to multiple skins, resources tha" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [06:10:38] legoktm: hover *is* before mouseenter \o/ [06:10:48] wonderful! [06:13:04] prtksxna: legoktm on all browsers? :P [06:13:09] (03PS4) 10Prtksxna: Remove the `title` attribute on `hover` (for links that have popups) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111772 [06:13:11] (03PS4) 10Prtksxna: Add Triangle/Pokey to the NavigationPopups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111773 [06:13:50] (03PS1) 10Legoktm: Enable extension by default [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111973 [06:13:52] * prtksxna checks [06:19:11] legoktm: hmm, can we assume mw.api is always available? or should it be an explicit dep? [06:19:25] I think best practice is to explicitly state it [06:19:32] right [06:21:50] YuviPanda: merge https://gerrit.wikimedia.org/r/111973 ? [06:21:52] legoktm: apparently you *do* need it, otherwise race conditions [06:22:02] makes sense [06:22:16] (03CR) 10Yuvipanda: [C: 032 V: 032] Enable extension by default [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111973 (owner: 10Legoktm) [06:22:18] legoktm: done [06:22:21] ty [06:22:51] (03PS5) 10Prtksxna: Add animation to Popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111768 [06:23:41] (03CR) 10Legoktm: [C: 032 V: 032] Add animation to Popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111768 (owner: 10Prtksxna) [06:26:51] (03PS5) 10Prtksxna: Remove the `title` attribute on `hover` (for links that have popups) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111772 [06:29:46] (03CR) 10Legoktm: [C: 032 V: 032] Remove the `title` attribute on `hover` (for links that have popups) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111772 (owner: 10Prtksxna) [06:30:11] legoktm: I am working on fix on the triangle/pokey commit [06:30:13] (03PS5) 10Prtksxna: Add Triangle/Pokey to the NavigationPopups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111773 [06:30:15] oh [06:30:18] oops [06:30:20] I just rebased it [06:30:26] prtksxna: let me know when its ready to review :) [06:30:35] legoktm: yup :) [06:33:44] legoktm: trololol. You can't enable both the mobilefrontend and the popups roles because they depend on two same extensions [06:33:59] wut [06:34:01] really? [06:34:59] legoktm: yeah. knownish thing. duplicate definitions [06:36:57] (03PS2) 10Legoktm: Use timestamp of page move instead of creation date [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/94403 [06:37:10] legoktm: lol, ^ was from fucking november yet rebased cleanly :D [06:37:21] no one has touched the extension in months [06:39:23] heh [06:39:24] yeah [06:42:46] legoktm: how do I test this patch? [06:42:56] ummm [06:43:10] create a page at User:Foo [06:43:16] wait a few seconds [06:43:20] then move it into mainspace [06:43:25] now go to special:newpagesfeed [06:43:43] check that the timestamp that is listed as "creation" is the move timestamp and not the creation in userspace timestamp [06:43:46] (03PS6) 10Prtksxna: Add Triangle/Pokey to the NavigationPopups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111773 [06:43:48] (03PS1) 10Prtksxna: Add dependency to mediawiki.api in ResourceLoader [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111974 [06:44:02] legoktm: Could you take a look at the other commit. The triangle once is going to take some time. :\ [06:44:03] legoktm: ah, ok [06:44:16] sure [06:44:28] legoktm: Thanks :) [06:44:44] (03CR) 10Legoktm: [C: 032 V: 032] Add dependency to mediawiki.api in ResourceLoader [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111974 (owner: 10Prtksxna) [06:47:20] legoktm: hmm, still shows me create time [06:47:29] legoktm: https://www.dropbox.com/s/wdl9ftm88ydb40e/Screenshot%202014-02-07%2012.17.25.png [06:47:41] legoktm: https://www.dropbox.com/s/3iwdbuc5szadchp/Screenshot%202014-02-07%2012.17.37.png [06:47:46] legoktm: should show me 46, shows me 45 [06:47:56] hrm [06:48:04] I wonder if [06:48:40] (03CR) 10Daniel Friesen: [C: 04-1] "Firstly skins.common.* is not for arbitrary things inside skins/common/, it's for the three-leveled profiles of common skin elements {elem" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [06:49:01] legoktm: hmm? [06:49:05] YuviPanda: what is the value of the created column in the pagetriage_page table? [06:49:27] legoktm: looking [06:49:52] legoktm: 20140207064546 [06:50:24] :((((( [06:50:29] i'll mess with it later [06:50:31] I don't know why [06:50:53] YuviPanda: thanks for testing it though [06:51:02] legoktm: ok! :( [06:51:06] legoktm: let me leave comments there [06:52:41] (03CR) 10Yuvipanda: [C: 04-1] "Doesn't work :(" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/94403 (owner: 10Legoktm) [06:54:35] There has to be a way to detect LESS errors /o\ [06:59:17] Is there a bug about the abomination that is interwiki import prefixes? [06:59:42] Transwiki, I guess. [07:00:21] prtksxna: you can run maintenance/checkLess.php, legoktm says [07:01:50] YuviPanda: Where? How? [07:02:47] prtksxna: vagrant ssh, then php /vagrant/mediawiki/maintenance/checkLess.php /vagrant/mediawiki/extensions/Popups/resources/ [07:03:09] YuviPanda: Ok, thanks o/ [07:03:29] Import sources. [07:04:07] YuviPanda: brb, this css masking problem might be larger than I expected :\ [07:04:13] prtksxna: kk [07:05:23] prtksxna: there's a bug for the less issue: https://bugzilla.wikimedia.org/show_bug.cgi?id=59858 you should add a comment maybe [07:12:43] YuviPanda: hmm [07:13:37] YuviPanda: I'll have to make an SVG element in the JS make clipPath definition in it and then use it through CSS for it to *hopefully* work on FF [07:14:01] prtksxna: how will it degrade on browsers that don't support it [07:14:17] YuviPanda: As I had shown you, just won't show the triangel [07:14:37] prtksxna: ok [07:14:41] s/triangel/triangle [07:16:14] quadrangel [07:18:55] prtksxna: I've a power cut :( dunno how long I'll be up [07:19:13] o [07:19:21] (03PS1) 10Yuvipanda: Add role for PageTriage extension [vagrant] - 10https://gerrit.wikimedia.org/r/111975 [07:19:25] legoktm: ^ [07:19:39] I'll fix the triangle thing [07:19:51] YuviPanda: Should I move the localisation then? [07:20:31] s/the/to [07:20:32] prtksxna: you know how to do the localization thing now, right? [07:20:39] prtksxna: ok, do it now. sure [07:21:32] YuviPanda: hang? [07:21:43] prtksxna: no power, on 3G :P can't hang [07:22:12] YuviPanda: o! ok, I was wondering how you were connected :P [07:22:16] prtksxna: :P [07:22:29] YuviPanda: You were porting something from VB, did you do that? [07:22:48] prtksxna: so like how we added a 'dependencies' key to the module [07:22:52] prtksxna: you need to add a 'messages' key [07:23:07] prtksxna: and as its value, have an array of all the keys of the messages you will be using in JS [07:23:07] YuviPanda: ah right [07:23:10] prtksxna: does that make sense? [07:23:29] (03CR) 10Legoktm: [C: 032] Add role for PageTriage extension [vagrant] - 10https://gerrit.wikimedia.org/r/111975 (owner: 10Yuvipanda) [07:23:30] YuviPanda: I think I saw that in the Multimedia Viewer extension too [07:23:32] (03Merged) 10jenkins-bot: Add role for PageTriage extension [vagrant] - 10https://gerrit.wikimedia.org/r/111975 (owner: 10Yuvipanda) [07:23:39] prtksxna: yeah, it's there in every extension [07:24:27] (03PS1) 10Olenz: Allow setting configuration variables before loading the extension. [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/111976 [07:27:01] YuviPanda: Just a second, let me share a diff [07:27:06] prtksxna: k [07:27:46] YuviPanda: http://pastie.org/8707574 [07:28:26] prtksxna: yup, about right :) except you have spaces there :P [07:28:37] YuviPanda: Yes, and wrong quotes [07:28:43] :P [07:28:47] but other than that [07:28:47] yeah [07:28:55] Cool [07:29:41] YuviPanda: And then I can just use `mw.message( "NP2-edited-seconds", timestamp );` and `mw.message( "NP2-redirects" )`, right? [07:29:48] prtksxna: yup [07:29:52] prtksxna: let me get you docs for it [07:30:09] prtksxna: https://www.mediawiki.org/wiki/Manual:Messages_API#Using_messages_in_JavaScript [07:30:24] prtksxna: hah, you need mw.message( 'thing' ).text() apparently [07:30:30] YuviPanda: Right [07:31:54] YuviPanda: So, I'll break the commits into the PHP stuff and then 2 others, one for redirects and the other for time [07:32:13] YuviPanda: Do we write our own small function for the time thing? That is what we decided, right? [07:32:18] prtksxna: yeah. [07:32:34] prtksxna: well, one commit for redirects, one for time. don't make the php stuff a separate commit [07:33:12] YuviPanda: so put the php stuff with the redirects only? [07:33:44] prtksxna: well, the commit that introduces the php stuff should be the same commit that uses them [07:34:03] prtksxna: so put the time related php messages and js in one commit, and also for redirect [07:34:13] YuviPanda: Hm, so I'll do time first [07:34:14] YuviPanda: got it [07:34:29] prtksxna: ok, makes sense [07:37:11] (03PS7) 10Prtksxna: [WIP] Add Triangle/Pokey to the NavigationPopups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111773 [07:37:13] (03PS1) 10Prtksxna: [WIP] Add time ago in words at the bottom of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 [07:40:22] prtksxna: brb [07:41:34] YuviPanda: k [07:47:40] (03CR) 10Isarra: "I appreciate that skins/common is not an ideal implementation, and indeed we'll be wanting to get rid of/move the entire thing at some poi" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [07:52:32] YuviPanda: lol its returning 44years ago :P [07:53:24] YuviPanda: lol debugged! [08:30:41] paravoid: :D [08:30:43] paravoid: you know what's 44 years ago, right? [08:31:38] err [08:31:40] sorry paravoid [08:31:44] i meant, prt [08:31:45] zz_prtksxna: [08:35:40] (03PS1) 10Physikerwelt: Fix: texvccheck is not indempotent [extensions/Math] - 10https://gerrit.wikimedia.org/r/111980 [08:37:55] (03PS2) 10Physikerwelt: Fix: texvccheck is not indempotent [extensions/Math] - 10https://gerrit.wikimedia.org/r/111980 [08:38:31] (03CR) 10Daniel Friesen: "resources/ *is* the correct place for new css/js modules, this included. This fact does not change simply because the module is css-only a" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [08:39:28] YuviPanda: unix epoch time? [08:39:36] YuviPanda: Did the power come back? [08:39:48] prtksxna: yeah, unix epoch [08:39:51] prtksxna: and no it's not back [08:40:01] YuviPanda: :\ [08:42:05] YuviPanda: sux [08:42:24] prtksxna: inorite :( [08:43:22] Should set up some redirecting pages to test this [08:43:41] prtksxna: D: [08:43:42] err [08:43:43] :D [08:43:53] lol [08:44:32] someone around for a quick code review for https://gerrit.wikimedia.org/r/#/c/111980/ [08:46:03] (03PS3) 10Physikerwelt: Fix: texvccheck is not indempotent [extensions/Math] - 10https://gerrit.wikimedia.org/r/111980 [08:50:59] (03CR) 10Prtksxna: Fix: texvccheck is not indempotent (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/111980 (owner: 10Physikerwelt) [08:51:27] physikerwelt: Thats all the PHP I know :P [08:51:33] (03CR) 10Aklapper: [C: 04-1] "-1 for the time being due to https://bugzilla.wikimedia.org/show_bug.cgi?id=55536#c5" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106864 (owner: 1001tonythomas) [08:56:18] so, I +2ed this 15 minutes ago https://gerrit.wikimedia.org/r/#/c/111950/ and jenkins-bot still hasn't acted on it. is there a way to manually run the bot or figure out why it didn't pick this up? [08:57:45] try recheck as a comment [08:59:24] recheck will only do the +1 tests [08:59:37] I recommend causing a new ps, but editing the commit message [08:59:41] that did something... triggered a test tun without qunit. but at this point the diff needs to attempt to be merged [09:00:09] (03PS4) 10Physikerwelt: fix: texvccheck is not idempotent [extensions/Math] - 10https://gerrit.wikimedia.org/r/111980 [09:01:24] oh... it has a dependency, I bet that's why [09:01:37] ;D [09:04:56] (03PS1) 10Thiemo Mättig (WMDE): Drop dead code from all SVG source files. This matters because these files are actually used as data URI encoded background images in the CSS. I know there are a million ways to do much more agressive compression. Take this as a first step that - for sure [core] - 10https://gerrit.wikimedia.org/r/111982 [09:06:07] (03PS2) 10Pastakhov: add Math Functions [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/111972 [09:09:01] (03CR) 10Pastakhov: [C: 032] add Math Functions [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/111972 (owner: 10Pastakhov) [09:09:06] (03Merged) 10jenkins-bot: add Math Functions [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/111972 (owner: 10Pastakhov) [09:16:14] (03PS8) 10Prtksxna: [WIP] Add Triangle/Pokey to the NavigationPopups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111773 [09:16:16] (03PS2) 10Prtksxna: Add time ago in words at the bottom of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 [09:16:18] (03PS1) 10Prtksxna: Add `redirects to` message at the top of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111983 [09:16:26] YuviPanda: Will you please check the localisation commits once? [09:16:34] prtksxna: doing [09:18:16] (03CR) 10Yuvipanda: Add time ago in words at the bottom of the popup (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 (owner: 10Prtksxna) [09:18:44] prtksxna: what's the point of the redirects to message? [09:18:45] do users care? [09:18:58] why not just show the content + title of what it redirects to, rather than the redirects-to? [09:19:04] YuviPanda: maybe they do [09:19:11] prtksxna: I don't think so :P [09:19:23] prtksxna: we don't show it prominently much else [09:19:24] places [09:19:25] *in [09:19:36] YuviPanda: Leave a comment here? https://www.mediawiki.org/wiki/Talk:Navigation_Popups_(Restyling_and_Enhancements) [09:19:41] prtksxna: also, if that triangle thingy is still WIP, you should drop it from the dependent commits [09:19:44] YuviPanda: I don't think its being shown prominently [09:19:51] hmm, ok [09:19:52] fine [09:19:58] prtksxna: code looks ok tho [09:20:17] prtksxna: you can drop it from the dependent commits by doing a git rebase -i and then deleting that line [09:20:24] YuviPanda: Nothing it dependent on it, I changed the order [09:20:28] ah [09:20:28] ok [09:20:33] legoktm: merge? ^ :) [09:20:39] which one? [09:20:56] YuviPanda: But do remember to leave a comment there [09:21:05] legoktm: mabe [09:21:17] err [09:21:18] prtksxna: mabe [09:21:25] stupid 3G [09:21:37] legoktm: https://gerrit.wikimedia.org/r/111977 [09:21:50] * prtksxna is making changes to 111977 [09:22:16] (the one that YuviPanda pointed out) [09:22:23] ok [09:22:41] (03CR) 10Legoktm: Add time ago in words at the bottom of the popup (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 (owner: 10Prtksxna) [09:23:03] I'd rather have someone from the i18n team look at that [09:23:52] legoktm: Did that line get added automatically? :O [09:24:04] I...don't know? :P [09:25:38] (03PS9) 10Prtksxna: [WIP] Add Triangle/Pokey to the NavigationPopups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111773 [09:25:40] (03PS2) 10Prtksxna: Add `redirects to` message at the top of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111983 [09:25:40] * prtksxna doesn't remember adding it [09:25:42] (03PS3) 10Prtksxna: Add time ago in words at the bottom of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 [09:26:22] (03CR) 10Prtksxna: Add time ago in words at the bottom of the popup (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 (owner: 10Prtksxna) [09:27:16] YuviPanda: legoktm: Whom should I add from the i18n team? [09:27:46] Nikerabbit and siebrand are usually the people I ask [09:29:22] legoktm: ok [09:30:59] YuviPanda: Is there any other PHP code that is required to get this extension in to the world? [09:31:10] prtksxna: betafeatures registration! [09:31:20] (03CR) 10Nemo bis: "What's this, yet another reimplementation of MediaWiki:Ago and friends? Have you looked for any semi-standard solution?" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 (owner: 10Prtksxna) [09:33:04] Nemo_bis: I tried to find one, couldn't. can you point me to one? [09:33:22] multimediaviewer uses moment.js I think [09:33:32] YuviPanda: Yes [09:35:38] (03CR) 10Yuvipanda: "@Nemo: Can you point me to some? I looked around but couldn't find any." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 (owner: 10Prtksxna) [09:36:52] prtksxna: make the betafeatures one non-dependent on any of the merged patches? [09:37:11] YuviPanda: Why is that? [09:37:17] prtksxna: easiesr to merge? [09:37:21] YuviPanda: You mean unmerged? [09:37:26] ah [09:37:27] yes [09:37:28] grr [09:38:57] YuviPanda: I think I'll take care of the triangles first [09:39:04] prtksxna: ok! [09:39:26] YuviPanda: You can't imagine how much they are bothering me :P [09:39:43] prtksxna: :P [09:39:43] fine [09:45:44] (03CR) 10Nemo bis: "You could look at what Echo is doing. It's not really documented and it fails in unexpected ways, but that's just one more reason to avoid" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 (owner: 10Prtksxna) [09:48:50] (03CR) 10Isarra: "There is currently structure set up for skin things in resources. Sorting out how best to organise and add such is well beyond the scope o" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [09:49:10] (03CR) 10Yuvipanda: "MultimediaViewer is using moment.js, which comes with its own i18n files and such. I asked around, and consensus seems to be 'do your own " [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 (owner: 10Prtksxna) [09:49:22] (03CR) 10Isarra: "no structure*" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [10:28:31] (03PS5) 10Physikerwelt: fix: texvccheck is not idempotent [extensions/Math] - 10https://gerrit.wikimedia.org/r/111980 [10:29:40] (03CR) 10Physikerwelt: "Please test if the values are stored in the database correctly as well." [extensions/Math] - 10https://gerrit.wikimedia.org/r/111980 (owner: 10Physikerwelt) [10:30:24] ^^anybody want's to do a code-review for that? [10:38:26] (03CR) 10Helder.wiki: "FWIW, the request for a proper navigation system for books is from 2008, and is NOT specific from Portuguese Wikibooks. All Wikibooks proj" [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO) [10:43:15] YuviPanda: I think I am going to have to use an SVG image : [10:43:30] hmm, so that kills support for w hat? [10:43:32] * YuviPanda checks [10:43:46] IE until 8 [10:43:54] but if it degrades gracefully enough, 'tis k :) [10:45:14] YuviPanda: I don't think it'll be 'graceful', there will be no thumbnail [10:45:20] ow [10:45:25] that's not graceful :| [10:46:04] YuviPanda: I could detect and switch it out with a normal [10:47:15] YuviPanda: Is that fine? [10:51:15] prtksxna: you could, yeah [10:51:20] prtksxna: make sure to note that in comments, etc [10:51:26] YuviPanda: Right [10:51:36] YuviPanda: This seems like a lot of work for something trivial :\ [10:51:51] prtksxna: to me all of HTML/CSS based web dev feels like that :P [10:52:06] YuviPanda: :P [10:52:15] :D [10:52:17] * prtksxna floats YuviPanda left [10:52:21] * YuviPanda clears prtksxna [10:52:40] * prtksxna clips YuviPanda  [10:53:10] * YuviPanda rounds prtksxna's borders [10:53:14] hmm [10:53:15] corners? [10:53:22] :P [10:53:34] brb smoke [11:00:16] YuviPanda: I am wondering if this is possible with the border technique [11:00:23] prtksxna: how so? [11:00:50] YuviPanda: Put 2 thick borders, one #fff and the other transparent [11:01:00] YuviPanda: hmm, but we can't assume #fff to be the bg, can we? [11:01:01] ok? [11:01:14] no, but you can call use 'transparent' [11:01:19] you can also just use an image border? [11:02:45] YuviPanda: In the sense [11:02:48] YuviPanda: In the sense? [11:02:57] YuviPanda: I think this would get too hacky too :\ [11:03:09] YuviPanda: The other method might be longer, but its clean [11:03:11] prtksxna: like, just have a triangular image, position that as a div above the div, and adjust its' position accordingly? [11:03:46] YuviPanda: I can't clip it into any shape (in FF), if I could I would clip the triangle anyway, right? [11:03:49] YuviPanda: Like in webkit [11:04:03] why clip it? just have an image in the shape of a triangle? [11:04:13] YuviPanda: from where? [11:04:26] YuviPanda: It masks the image! [11:04:32] prtksxna: oh. nevermind me. [11:04:35] right [11:04:49] prtksxna: hmm, right. then I have not much ideas on how to do it [11:05:31] YuviPanda: You see - http://thumbs.bayimg.com/19bd03a2848441ca7d670180609daf440712510c.jpg [11:06:34] prtksxna: yeah, I see what you mean. I just don't know how to do it :P [11:06:42] :( [11:07:03] I deman pre rendered images with that triangle cut out :D [11:07:16] prtksxna: take a break from it, do the betafeatures thingy, then it can go on betalabs and we can plan a deployment, and then we can fix this in the meantime? [11:07:22] deployment will take two weeks anyway, at the leats [11:07:43] hmm [11:07:47] ok [11:11:03] Error: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold install php5-redis' returned 100: Reading package lists... [11:11:04] E: Package 'php5-redis' has no installation candidate [11:11:05] what [11:12:33] (03PS10) 10Prtksxna: [WIP] Add Triangle/Pokey to the NavigationPopups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111773 [11:13:41] hi Nikerabbit [11:17:37] (03PS1) 10Pastakhov: add Variable handling Functions [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/112000 [11:19:42] (03PS2) 10Aaron Schulz: Added --wiki parameter to runJobs.php call [core] - 10https://gerrit.wikimedia.org/r/110644 [11:19:49] (03CR) 10IAlex: [C: 032] Added --wiki parameter to runJobs.php call [core] - 10https://gerrit.wikimedia.org/r/110644 (owner: 10Aaron Schulz) [11:23:59] (03Merged) 10jenkins-bot: Added --wiki parameter to runJobs.php call [core] - 10https://gerrit.wikimedia.org/r/110644 (owner: 10Aaron Schulz) [11:33:02] YuviPanda: Once I add the betafeatures hook, can I remove the feature flag bool? [11:33:11] prtksxna: no, keep that also. [11:33:16] prtksxna: that will let the entire thing disappear [11:33:31] YuviPanda: But isn't it as simple as hitting a checkbox now? [11:35:28] prtksxna: yeah, but it is to disable the entire thing [11:35:35] prtksxna: we can remove that after a few weeks [11:35:44] YuviPanda: Cool [11:35:46] prtksxna: it's hitting a checkbox for every user who had that checkbox ticked [11:36:11] :| [11:36:43] prtksxna: still, it's just general good practice to have a feature flag [11:37:32] YuviPanda: Understood :) [11:40:26] prtksxna: i also just found https://www.mediawiki.org/wiki/File:Guide_Color.png :) [11:41:07] YuviPanda: Didn't I send you this yesterday when we were working on WL? [11:41:14] prtksxna: not the link [11:41:34] prtksxna: do poke me when the betafeature is done, I'll try to get it deployed today [11:41:50] prtksxna: if we can't get it deployed on betalabs, we will make our on labs instance and put it :) [11:42:10] YuviPanda: Yes, I will [11:42:15] YuviPanda: Oh, cool! [11:42:15] prtksxna: ok :) [11:42:21] prtksxna: we should probably do that anyway [11:42:26] let me poke the right people [11:42:35] YuviPanda: I am creating FatalErros right now, please don't disturb me :D [11:42:42] prtksxna: :P kk [11:45:31] YuviPanda: I'll be using 'BetaFeatures::isFeatureEnabled' in the 'onBeforePageDisplay' hook, right? [11:46:06] prtksxna: there's a link from gerrit patchset somewhere, no? [11:46:16] YuviPanda: onBeforePageDisplay [11:46:21] YuviPanda: https://www.mediawiki.org/wiki/Extension:BetaFeatures#Using_the_new_hooks_in_your_extension [11:46:22] oops [11:46:23] right [11:46:29] just follow that :) [11:47:07] YuviPanda: What does it mean '//implement' that a check, right? cant I use it in onBeforePageDisplay [11:48:37] prtksxna: yeah, you first register it in getPreferences() and then do the check in onbeforedisplay [11:49:21] YuviPanda: Had to change $this to $skin :) [11:49:38] YuviPanda: I am not adding the screenshot for now, vbamba is working on it [11:50:16] prtksxna: ok [11:51:33] YuviPanda: ? [11:52:09] Nikerabbit: wanted to ask for i18n review of https://gerrit.wikimedia.org/r/#/c/111977/ to see if we're doing things right [11:52:12] well [11:52:16] not 'right', but at least tolerable [11:53:01] (03PS1) 10Prtksxna: Add hook for BetaFeatures [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112006 [11:53:35] (03CR) 10Siebrand: [C: 04-1] "Looks good. Needs release notes." [core] - 10https://gerrit.wikimedia.org/r/111968 (owner: 10Liangent) [11:54:17] YuviPanda: Added the hook [11:54:27] prtksxna: ya testing [11:57:10] prtksxna: I don't see it in http://127.0.0.1:8080/wiki/Special:Preferences#mw-prefsection-betafeatures [11:58:11] YuviPanda: That is strange I see it http://localhost:8080/wiki/Special:Preferences#mw-prefsection-betafeatures with a missing image [11:58:30] prtksxna: hmm. [11:58:38] the code looks fine to me [11:59:10] YuviPanda: Are you sure you are on the right branch and stuff? [11:59:12] prtksxna: no, still doesn't work for me :| [11:59:13] yeah [11:59:20] ' Add hook for BetaFeatures' [11:59:32] :\ [12:00:04] YuviPanda: I'll brb in ½hour [12:27:47] * YuviPanda waves at hashar and hashar_ [12:29:22] (03PS1) 10Zfilipin: Renamed mediawiki-selenium Ruby gem to mediawiki_selenium [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112010 [12:29:38] YuviPanda: lo [12:30:20] (03CR) 10Helder.wiki: "The preference was removed on" [core] - 10https://gerrit.wikimedia.org/r/27206 (owner: 10Siebrand) [12:31:47] YuviPanda: bak [12:32:01] YuviPanda: Did it start showing? :) [12:32:17] (03PS1) 10Zfilipin: Renamed mediawiki-selenium Ruby gem to mediawiki_selenium [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112012 [12:33:33] prtksxna: nope :( [12:33:45] YuviPanda: Oh, what to do? Something wrong in the code? [12:34:01] (03CR) 10Bartosz Dziewoński: "Hmmm actually, this probably should have release notes… Sorry for piecewise review." [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh) [12:34:34] prtksxna: I don't know :| [12:35:31] YuviPanda: :( Ok, I'll switch back to the masking stuff? That's one last major block! [12:35:37] prtksxna: yeah, ok! [12:35:43] prtksxna: I'll check this out later tonight [12:35:46] (03CR) 10Bartosz Dziewoński: [C: 032] GitInfo: Suppress some wrong warnings [core] - 10https://gerrit.wikimedia.org/r/111959 (owner: 10Legoktm) [12:36:10] YuviPanda: Hmm. Ok, I'll be working later too. [12:36:41] YuviPanda: o/ [12:37:10] prtksxna: ok! [12:38:15] (03CR) 10Bartosz Dziewoński: mediawiki.notification: Return the Notification object from .notify calls (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110667 (owner: 10Bartosz Dziewoński) [12:39:41] (03Merged) 10jenkins-bot: GitInfo: Suppress some wrong warnings [core] - 10https://gerrit.wikimedia.org/r/111959 (owner: 10Legoktm) [12:43:33] (03CR) 10Liangent: "...and I can't find a suitable section in RELEASE-NOTES?" [core] - 10https://gerrit.wikimedia.org/r/111968 (owner: 10Liangent) [12:44:19] (03PS3) 10Bartosz Dziewoński: mediawiki.notification: Return the Notification object from .notify calls [core] - 10https://gerrit.wikimedia.org/r/110667 [12:45:29] (03CR) 10Jpond: "Olaf," [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/111976 (owner: 10Olenz) [13:02:35] (03CR) 10Hashar: "I would prefer submodule instead of copy pasting code. But then if people hate submodules I am not going to fight for it :D" [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [13:02:37] (03PS1) 10Ebe123: Show warning when moving a page to a different test wiki [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/112022 [13:02:39] (03CR) 10jenkins-bot: [V: 04-1] Show warning when moving a page to a different test wiki [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/112022 (owner: 10Ebe123) [13:08:11] (03PS2) 10Ebe123: Show warning when moving a page to a different test wiki [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/112022 [13:30:35] (03CR) 10Manybubbles: [C: 032] Renamed mediawiki-selenium Ruby gem to mediawiki_selenium [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112010 (owner: 10Zfilipin) [13:30:39] (03Merged) 10jenkins-bot: Renamed mediawiki-selenium Ruby gem to mediawiki_selenium [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112010 (owner: 10Zfilipin) [13:31:49] (03PS2) 10Werdna: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 [13:31:59] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [13:38:09] YuviPanda: ping [13:38:13] pongi [13:38:41] YuviPanda: pongal :D [13:39:12] prtksxna: bongal [13:39:22] YuviPanda: Do you think the extension should be "design experiments" or something and we can keep adding stuff like 'popups' and 'fixedheader' to it [13:39:44] YuviPanda: Otherwise we'll keep trying to make it part of some extension, where it (maybe) doesn't belong [13:39:55] prtksxna: should just be Popups, I think. we'll make a new extension for those. But I think FixedHeader *will* go into VectorBeta, since it doesn't work with the other skins [13:40:02] this works with all skins, so makes sense to keep it separate [13:40:41] YuviPanda: Oh, ok! Got it. [13:48:56] YuviPanda: uga [13:51:26] YuviPanda: timeAgo() looks very weird or wrong [13:51:59] Nikerabbit: How so? [13:55:26] Nikerabbit: how so? [13:55:28] did i miss scrollback? [13:55:41] (03CR) 10Nikerabbit: Add time ago in words at the bottom of the popup (035 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 (owner: 10Prtksxna) [13:56:58] YuviPanda: You didnt :) [13:57:02] ok [13:57:04] Nikerabbit: I'll look into it in a bit :) [13:57:43] Nikerabbit: Thanks for the review [13:59:25] prtksxna: the main problem is that I was confused at first and had to reverse engineer what is really going on, as the documentation didn't help [13:59:49] Nikerabbit: Right, the documentation is sort of place holder right now [14:00:04] Nikerabbit: Are you fine with the approach if the code was easier to read and better documented? [14:00:55] Nikerabbit: I know exactly what you mean, I felt the same way when I first read Yair's script, but it was pretty nice once I understood it :) [14:05:49] prtksxna: yeah it is simple enough for your purpose [14:12:24] prtksxna: let me setup our labs thing anyway. you will want it for other things [14:13:31] YuviPanda: Yeah [14:13:39] prtksxna: yeah. let me do things [14:16:59] (03PS11) 10Prtksxna: [WIP] Add Triangle/Pokey to the NavigationPopups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111773 [14:17:01] (03PS3) 10Prtksxna: Add `redirects to` message at the top of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111983 [14:17:03] (03PS4) 10Prtksxna: Add time ago in words at the bottom of the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 [14:17:17] (03CR) 10Prtksxna: Add time ago in words at the bottom of the popup (035 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111977 (owner: 10Prtksxna) [14:18:30] (03PS1) 10Gerrit Patch Uploader: Vector: Restore page-fade.png as fallback background-image for IE 6-9 [core] - 10https://gerrit.wikimedia.org/r/112025 [14:18:32] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [14:19:47] (03CR) 10Edokter: "Applies to bug 60991 and bug 60943." [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [14:21:39] (03CR) 10Bartosz Dziewoński: "Lemme attach the image. Also see inline." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [14:22:39] (03CR) 10Bartosz Dziewoński: Vector: Restore page-fade.png as fallback background-image for IE 6-9 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [14:25:26] (03CR) 10Bartosz Dziewoński: "I think I agree with Krinkle and Daniel on the module name – if we ever deprecate the current way skins work in the future, we'll be stuck" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [14:25:39] (03CR) 10Edokter: Vector: Restore page-fade.png as fallback background-image for IE 6-9 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [14:31:51] (03PS2) 10Bartosz Dziewoński: Vector: Restore page-fade.png as fallback background-image for IE 6-9 [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [14:33:22] (03CR) 10Bartosz Dziewoński: [C: 031] "Added the image and addressed my own inline comments. Also fixed the background-color rule (.vertical-gradient mixin sets it to the end co" [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [14:33:51] (03PS3) 10Edokter: Vector: Restore page-fade.png as fallback background-image for IE 6-9 [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [14:37:57] (03CR) 10Bartosz Dziewoński: "…I think something went wrong with the last patchset. When editing the commit message, gerrit will use the patchset you were looking at as" [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [14:38:41] (03PS4) 10Bartosz Dziewoński: Vector: Restore page-fade.png as fallback background-image for IE 6-9 [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [14:39:19] (03CR) 10Edokter: "I believe my updating the commit message (on-page) seems to have reverted the entire patch. Sorry..." [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [14:39:22] (03CR) 10Bartosz Dziewoński: "PS4 is the same as PS2. This behavior is bug 52292, by the way." [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [14:39:52] Nikerabbit: I CAN HAZ +1? [14:40:15] Sorry about the all caps :\ [14:40:52] * YuviPanda gives Nikerabbit a fluffy bunny hat [14:41:01] (03CR) 10Bartosz Dziewoński: [C: 031] Vector: Restore page-fade.png as fallback background-image for IE 6-9 [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [14:43:35] (03CR) 10Bartosz Dziewoński: "I have a similar patch at https://gerrit.wikimedia.org/r/#/c/106506/ , which needs more work because it does in fact currently break some " [core] - 10https://gerrit.wikimedia.org/r/111982 (owner: 10Thiemo Mättig (WMDE)) [14:44:04] (03CR) 10Edokter: [C: 031] "Looks good, though I would have put the background-color on top." [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [14:45:12] aww [14:45:22] (03CR) 10Bartosz Dziewoński: "I assume you used some automated tools/scripts to do this – it would be great to mention them in the commit message." [core] - 10https://gerrit.wikimedia.org/r/111982 (owner: 10Thiemo Mättig (WMDE)) [14:46:20] (03CR) 10Bartosz Dziewoński: "So would I, but then it won't work :D" [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [14:49:48] (03CR) 10Edokter: "You got me... why would that not work?" [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [14:53:14] (03CR) 10Bartosz Dziewoński: "Apparently an issue for NaN stroke-width has already been filed by Juliusz: https://github.com/svg/svgo/issues/181" [core] - 10https://gerrit.wikimedia.org/r/106506 (owner: 10Bartosz Dziewoński) [14:54:19] (03CR) 10Bartosz Dziewoński: "The .vertical-gradient mixins also sets a background-color, we need to put ours later to override that one." [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [14:55:57] Hi can someone have a look at the fix for https://bugzilla.wikimedia.org/show_bug.cgi?id=61012 i.e. it creates a lot of new bug reports [14:59:19] Reedy: Can you lookup https://bugzilla.wikimedia.org/show_bug.cgi?id=60986 maybe? Can't reproduce that one locally or on beta [15:03:34] helpful [15:04:09] Reedy: I can try to reproduce on hewiki, not sure local users will like that, though [15:05:12] I see some "Maximum execution time of 180 seconds exceeded" on zhwiki [15:05:40] (03CR) 10Anomie: [C: 031] "Code looks ok. Haven't tested. One missing message, but that's easily fixed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111390 (owner: 10TTO) [15:06:08] reedy@fluorine:/a/mw-log$ grep AbuseFilter fatal.log -B 15 | grep hewiki [15:06:08] reedy@fluorine:/a/mw-log$ [15:06:18] to zgrep! [15:07:08] hoo: Can't see anything [15:07:12] (03PS1) 10Hoo man: Check whether AbuseFilter::$editboxName is set before using it [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/112026 [15:07:15] Reedy: weird [15:07:16] legoktm: ^ [15:07:28] Reedy: Will force it on hewiki, then [15:07:46] WFM [15:07:47] ;) [15:09:24] Reedy: Couldn't reproduce this even on hewiki... ok :P [15:10:20] TODO: kick matanya [15:11:26] (03CR) 10Edokter: "I see now. Though are you realy sure it is needed? The current background-color is set at #f6f6f6 (page background). Your rule would turn " [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [15:11:33] Hello. Does anyone know where marktraceur is? [15:12:11] San Francisco [15:12:21] Possibly in bed [15:12:49] Niharika: undercover as rdwrer [15:12:50] try dwrer [15:13:14] Oh, okay. Thanks, guys. [15:13:42] (03CR) 10Daniel Kinzler: Refactor SpecialCategories (031 comment) [core] - 10https://gerrit.wikimedia.org/r/107842 (owner: 10Daniel Kinzler) [15:16:00] (03CR) 10Anomie: [WIP] Revamp API (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm) [15:16:17] (03CR) 10Daniel Kinzler: [C: 04-2] "Relying on globals without explicitly initializing them is still a very bad idea. PHP's register_globals still exists and is active per de" [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/111976 (owner: 10Olenz) [15:19:34] (03PS1) 10Manybubbles: Rely on mediawiki_selenium's screenshot on failure [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112028 [15:24:03] (03CR) 10Anomie: [C: 04-1] API: update documentation and suppress warning when parsing summary (031 comment) [core] - 10https://gerrit.wikimedia.org/r/108307 (owner: 10Nullzero) [15:24:09] (03PS5) 10Anomie: API: update documentation and suppress warning when parsing summary [core] - 10https://gerrit.wikimedia.org/r/108307 (owner: 10Nullzero) [15:24:59] (03PS6) 10Nullzero: API: update documentation and suppress warning when parsing summary [core] - 10https://gerrit.wikimedia.org/r/108307 [15:25:19] (03CR) 10Anomie: [C: 032] "PS5: Fix a typo." [core] - 10https://gerrit.wikimedia.org/r/108307 (owner: 10Nullzero) [15:29:06] (03Merged) 10jenkins-bot: API: update documentation and suppress warning when parsing summary [core] - 10https://gerrit.wikimedia.org/r/108307 (owner: 10Nullzero) [15:33:10] (03CR) 10Anomie: [C: 032] mb_substr() expects parameter 2 to be long, string given [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/110582 (owner: 10Umherirrender) [15:33:19] (03CR) 10jenkins-bot: [V: 04-1] mb_substr() expects parameter 2 to be long, string given [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/110582 (owner: 10Umherirrender) [15:35:36] (03PS1) 10Anomie: Update doc comment [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/112029 [15:35:41] (03CR) 10jenkins-bot: [V: 04-1] Update doc comment [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/112029 (owner: 10Anomie) [15:37:04] (03CR) 10Anomie: "recheck" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/112029 (owner: 10Anomie) [15:56:11] (03CR) 10Bartosz Dziewoński: [C: 032] Update doc comment [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/112029 (owner: 10Anomie) [15:56:16] (03CR) 10jenkins-bot: [V: 04-1] Update doc comment [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/112029 (owner: 10Anomie) [15:56:39] D: [16:00:06] (03CR) 10Bartosz Dziewoński: "I would say that this decreases the readability of the tests. :(" [core] - 10https://gerrit.wikimedia.org/r/111962 (owner: 10Krinkle) [16:05:38] (03CR) 10Cmcmahon: [C: 032] Renamed mediawiki-selenium Ruby gem to mediawiki_selenium [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112012 (owner: 10Zfilipin) [16:08:46] (03CR) 10Thiemo Mättig (WMDE): "I did two pretty simple steps:" [core] - 10https://gerrit.wikimedia.org/r/111982 (owner: 10Thiemo Mättig (WMDE)) [16:13:36] (03PS1) 10Anomie: Fix TestFileIterator to never return 0 tests [core] - 10https://gerrit.wikimedia.org/r/112033 [16:14:29] (03CR) 10Anomie: "I7f18fc95 and I0bc8d612 are failing Jenkins due to this problem." [core] - 10https://gerrit.wikimedia.org/r/112033 (owner: 10Anomie) [16:15:38] MatmaRex: Sigh. ^ [16:16:47] anomie: huh. why would there be 0 tests? [16:17:21] anyway, i should probably let hashar or whoever handle that one :) [16:17:35] MatmaRex: The tests in ParserFunctions's stringFunctionTests.txt are all skipped if $wgPFEnableStringFunctions is false. [16:18:05] While I could have worked around it by adding a dummy test to the top of that file, I thought it better to fix it at the source. [16:19:44] MatmaRex: I didn't really expect you to want to merge it. I just showed it to you to explain what made Jenkins weirdly -1 there. [16:20:18] Hi can someone have a look at the fix for https://bugzilla.wikimedia.org/show_bug.cgi?id=61012 i.e. the bug creates a lot of new bug reports [16:21:29] a self-replicating bug report? :o [16:22:20] (03CR) 10Cmcmahon: [C: 032] Rely on mediawiki_selenium's screenshot on failure [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112028 (owner: 10Manybubbles) [16:22:59] I mean the bug makes people creating new bug reports [16:24:12] physikerwelt: I'll have a look, after I figure out reproducing it locally [16:24:15] and it adds red color to wikipages which very ugly see http://en.wikipedia.org/wiki/Equations_of_motion#Uniform_acceleration [16:25:45] It's quite easy to understand texvccheck converts \begin{align} -> \begin{aligned} and \begin{aligned} is not known by texvc [16:36:34] (03CR) 10Matthias Mullie: "Yes, word-wrap: break-word; will break up whatever is too long for the container." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111958 (owner: 10Matthias Mullie) [16:40:26] (03CR) 10Matthias Mullie: [C: 032] Add hook SpecialCheckUserGetLinksFromRow [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/111249 (owner: 10EBernhardson) [16:40:28] (03Merged) 10jenkins-bot: Add hook SpecialCheckUserGetLinksFromRow [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/111249 (owner: 10EBernhardson) [16:41:29] (03CR) 10Chad: [C: 032] Changed the password $valid check condition [core] - 10https://gerrit.wikimedia.org/r/109888 (owner: 1001tonythomas) [16:44:18] (03PS3) 10Chad: Use redirects in prefix and go searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111835 (owner: 10Manybubbles) [16:44:57] (03Merged) 10jenkins-bot: Changed the password $valid check condition [core] - 10https://gerrit.wikimedia.org/r/109888 (owner: 1001tonythomas) [16:50:32] (03PS3) 10BryanDavis: Convert scappy to a python package [tools/scap] - 10https://gerrit.wikimedia.org/r/111716 [16:50:34] (03CR) 10Matthias Mullie: [C: 031] "LGTM - just not sure if you're looking to fix both @todo's first or want it merged already and deal with that some later time ;)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111354 (owner: 10EBernhardson) [16:56:37] (03CR) 10Daniel Friesen: ""There is currently no structure set up for skin things in resources. Sorting out how best to organise and add such is well beyond the sco" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [17:00:18] (03PS4) 10BryanDavis: Convert scappy to a python package [tools/scap] - 10https://gerrit.wikimedia.org/r/111716 [17:04:23] (03CR) 10Anomie: [C: 032] "Appears to work in local testing." [extensions/Math] - 10https://gerrit.wikimedia.org/r/111980 (owner: 10Physikerwelt) [17:04:34] (03Merged) 10jenkins-bot: fix: texvccheck is not idempotent [extensions/Math] - 10https://gerrit.wikimedia.org/r/111980 (owner: 10Physikerwelt) [17:05:53] anomie thank you very much [17:07:38] (03CR) 10Matthias Mullie: [C: 031] Pull flow revision data based on user_wiki and user_id/user_ip [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111952 (owner: 10Bsitu) [17:08:55] (03PS17) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 [17:20:23] hashar_: Meetbot is now in -office if you didn't know [17:22:12] rdwrer: using tool labs infrastructure ? [17:22:34] ah yeah [17:22:35] awesome [17:25:26] hashar_: I'm telling scfc_de to add you to the project [17:25:33] But yeah, meetbot. The future is now. [17:25:48] well I have no idea how tool labs works, so I am probably not going to be any helpful :/ [17:25:50] awesome [17:25:56] Heh [17:26:28] the old logs are at http://integration-meetbot.instance-proxy.wmflabs.org/wikimedia-meetbot/ [17:26:36] I can't connect on the instance to generate a tarball of them though [17:26:39] maybe wget would help [17:29:31] Not sure it would be useful [17:29:48] Anyway we should maybe add -dev to the channel list, and use it for RFC reviews [17:30:53] (03CR) 10Anomie: [C: 04-1] "Needs rebase. Otherwise, looks good." [core] - 10https://gerrit.wikimedia.org/r/110819 (owner: 10Umherirrender) [17:31:39] rdwrer: or rfc reviews can be held in -office :D [17:31:55] rdwrer: -dev has a lot of grrit-wm spam, it is not idea for discussion [17:31:57] s [17:34:20] Ah maybe. [17:34:42] (03PS6) 10EBernhardson: Simplify edit-title template [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103069 [17:35:52] (03PS7) 10EBernhardson: Simplify edit-title template [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103069 [17:40:43] I am off, have a good weekend! [17:40:56] hashar_: have a good weekend! [17:42:28] <^d> YuviPanda: brion responded to our search API bug :) [17:42:36] ^d: with a patch? :D [17:42:42] (03CR) 10Anomie: [C: 031] Add an API action to test blacklisted URLs [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 (owner: 10Jackmcbarn) [17:42:51] Commited-from: Oakland [17:43:12] <^d> YuviPanda: Wondering what the structure would be :) [17:43:14] does Oakland have oaks? [17:43:20] <^d> You should add yourself to CC. [17:43:24] ^d: link? I don't think I'm on cc [17:43:37] <^d> Richmond doesn't have rich people. [17:43:43] <^d> https://bugzilla.wikimedia.org/show_bug.cgi?id=60975 [17:44:05] (03PS8) 10Catrope: Add VisualEditor support [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 [17:44:09] but does it have rich Monds? [17:44:32] (03CR) 10Matthias Mullie: [C: 04-1] "Looks generally ok; some remarks (mostly nitpicks - some of importance)" (0314 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 (owner: 10Bsitu) [17:55:52] (03PS1) 10Hashar: Python modularization with pbr [tools/scap] - 10https://gerrit.wikimedia.org/r/112036 [17:56:08] bd808: more python love for scap : https://gerrit.wikimedia.org/r/112036 :D [17:56:50] (03PS1) 10Chad: Make InterwikiResultsType implement instead of inherit [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112037 [17:57:14] * hashar_ and I am off for real *wave* [17:57:31] (03Abandoned) 10Chad: Make InterwikiResultsType implement instead of inherit [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112037 (owner: 10Chad) [17:58:04] (03PS4) 10Chad: Use redirects in prefix and go searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111835 (owner: 10Manybubbles) [17:59:33] (03PS5) 10EBernhardson: Formatter for CheckUser rows [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111354 [17:59:36] (03PS1) 10EBernhardson: Use provided language for link messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112038 [18:03:52] (03PS2) 10EBernhardson: Use provided language for link messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112038 [18:05:52] (03CR) 10Matthias Mullie: Use provided language for link messages (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112038 (owner: 10EBernhardson) [18:05:57] (03CR) 10Chad: "Maybe I'm doing something wrong, but I can't seem to get the desired behavior." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111835 (owner: 10Manybubbles) [18:06:00] (03CR) 10Matthias Mullie: [C: 032] Formatter for CheckUser rows [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111354 (owner: 10EBernhardson) [18:06:09] (03Merged) 10jenkins-bot: Formatter for CheckUser rows [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111354 (owner: 10EBernhardson) [18:07:22] (03PS3) 10EBernhardson: Use provided language for link messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112038 [18:08:54] (03CR) 10Physikerwelt: [C: 04-1] "The hook works fine and displays a section in the betafeatures menue." [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 (owner: 10Catrope) [18:12:40] (03CR) 10Umherirrender: "jenkins failure "No tests found in suite "StringFunctionTests::testParserTest"." is/looks unrelated to this change." [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/110582 (owner: 10Umherirrender) [18:14:58] (03CR) 10Matthias Mullie: Add *Revisionable classes (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111366 (owner: 10Matthias Mullie) [18:15:03] (03PS3) 10Matthias Mullie: Add *Revisionable classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111366 [18:17:05] (03PS3) 10Umherirrender: Add prop 'limitreportdata' and 'limitreporthtml' to action=parse [core] - 10https://gerrit.wikimedia.org/r/110819 [18:17:48] (03CR) 10Umherirrender: "Patch Set 3: Rebased" [core] - 10https://gerrit.wikimedia.org/r/110819 (owner: 10Umherirrender) [18:22:46] (03CR) 10CSteipp: [C: 032] Check whether AbuseFilter::$editboxName is set before using it [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/112026 (owner: 10Hoo man) [18:22:53] (03Merged) 10jenkins-bot: Check whether AbuseFilter::$editboxName is set before using it [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/112026 (owner: 10Hoo man) [18:24:09] (03CR) 10Anomie: [C: 032] Add prop 'limitreportdata' and 'limitreporthtml' to action=parse [core] - 10https://gerrit.wikimedia.org/r/110819 (owner: 10Umherirrender) [18:25:00] (03CR) 10Anomie: "See I855887f8" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/110582 (owner: 10Umherirrender) [18:27:23] (03Merged) 10jenkins-bot: Add prop 'limitreportdata' and 'limitreporthtml' to action=parse [core] - 10https://gerrit.wikimedia.org/r/110819 (owner: 10Umherirrender) [18:34:53] (03CR) 10Mattflaschen: "I agree there could potentially be a reason to put it in core, even if we don't use it for Drafts. However, the books use case doesn't se" [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO) [18:36:35] (03CR) 10Bsitu: Add corresponding *_user_wiki field to all *_user_id fields (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 (owner: 10Bsitu) [18:37:56] (03CR) 10EBernhardson: [C: 04-1] Introduce found & foundMulti, to test if index queries are in local storage (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111364 (owner: 10Matthias Mullie) [18:40:04] (03PS1) 10Matthias Mullie: Don't propagate permissions to older revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112042 [18:40:16] (03CR) 10EBernhardson: [C: 031] Similar to found, introduce got/gotMulti to test if data is in local cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111365 (owner: 10Matthias Mullie) [18:43:28] (03PS3) 10Matthias Mullie: Introduce found & foundMulti, to test if index queries are in local storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111364 [18:44:52] (03CR) 10Matthias Mullie: [C: 04-2] "Do not yet merge - will need follow-up patches to alternatively check for permissions on older revisions (well - we don't really have that" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112042 (owner: 10Matthias Mullie) [18:46:52] (03CR) 10Krinkle: [C: 04-1] "The vertical-gradient mixin should not require a png or svg to be present as well. Either we need to accept the fallback vertical-gradient" [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [18:51:47] (03CR) 10Umherirrender: "File stringFunctionsTests.txt contains tests and that file works locally without the error from here. So the Iterator has a problem to acc" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/110582 (owner: 10Umherirrender) [18:57:43] Nemo_bis: for bug 4073, comment 11, it would be nice if you could by a conversation with both to assert if the best solution is to use Translate extension or subpages by lang code [18:59:18] (03CR) 10EBernhardson: [C: 032] Introduce found & foundMulti, to test if index queries are in local storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111364 (owner: 10Matthias Mullie) [18:59:25] (03PS3) 10Matthias Mullie: Similar to found, introduce got/gotMulti to test if data is in local cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111365 [18:59:28] (03Merged) 10jenkins-bot: Introduce found & foundMulti, to test if index queries are in local storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111364 (owner: 10Matthias Mullie) [18:59:41] (03CR) 10EBernhardson: [C: 032] "PS3: rebased" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111365 (owner: 10Matthias Mullie) [18:59:49] (03Merged) 10jenkins-bot: Similar to found, introduce got/gotMulti to test if data is in local cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111365 (owner: 10Matthias Mullie) [19:03:19] (03CR) 10Isarra: "Krinkle - the mixin shouldn't require fallback images, but IE6-9 gradients also don't support stop positioning, which Vector's top gradien" [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [19:04:35] (03PS1) 1001tonythomas: Fix z-index on popup [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/112044 [19:05:43] (03CR) 1001tonythomas: "Couldnt test in my localhost. But as per https://bugzilla.wikimedia.org/show_bug.cgi?id=61023#c1" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/112044 (owner: 1001tonythomas) [19:07:50] (03PS2) 10Matthias Mullie: Don't propagate permissions to older revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112042 [19:07:53] (03PS4) 10Matthias Mullie: Add *Revisionable classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111366 [19:08:29] (03CR) 10Isarra: "Or resize it... point is, for IE the div needs to be the same height as the gradient for it to work properly." [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [19:09:41] (03CR) 10CSteipp: [C: 031] "Security looks ok, and the functionality is working as I expected." [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [19:10:11] (03PS1) 10Cmcmahon: QA WIP Test for Action menu Permalink [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112048 [19:11:24] (03CR) 10Manybubbles: [C: 032] "Verified again locally and chad approves so +2." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111835 (owner: 10Manybubbles) [19:11:29] (03Merged) 10jenkins-bot: Use redirects in prefix and go searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111835 (owner: 10Manybubbles) [19:11:55] greg-g: wanted to check in about our "early feb" deploy converting flow uuids from 128->88bit, would prefer to get it on the calendar next week if possible. It requires a read only mode(only for flow) and pk changes to db so 2 hours is probably required [19:12:25] (03PS1) 10Cmcmahon: QA WIP Test for Action menu History [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112049 [19:12:52] (03CR) 10EBernhardson: [C: 04-2] "need security review for the templating refactor before +2 any templates using it." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103069 (owner: 10EBernhardson) [19:13:19] ebernhardson: was goign to ask you about that :) [19:13:28] ebernhardson: so, what coordination do you need from eg ops? [19:14:22] greg-g: i checked with sean, he was ok with us doing the db changes ourselves since its a single shared flow db. [19:14:35] * greg-g nods [19:14:42] cool, so, ... lemme look [19:15:09] Tuesday during Flow's held window (3pm pacific)? [19:15:18] (03CR) 10Edokter: "Krinkle, this is a serious breaking change with major visual impact for a substantial part of the readers using IE. This cannot be simply " [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [19:16:05] ebernhardson: ^ [19:17:06] (03CR) 10Krinkle: "If it isn't feasible to develop a generic generator for the syntax, how about doing it once? I reckon using that one inline here is still " [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [19:18:00] (03CR) 10Krinkle: "Also, see https://bugzilla.wikimedia.org/show_bug.cgi?id=60943#c8. I'd recommend we don't use gradients in tabs either. That looks much be" [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [19:20:31] greg-g: that should work, yea [19:20:40] kk [19:21:02] ebernhardson: is there more info on this I could link to when I do the weekly deploy updates email? [19:21:07] (03CR) 10Edokter: "There is also a very good reason to leave the IE filters alone. Its gradient filter has a nasty habit of re-rendering any text on top of i" [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [19:21:38] (03CR) 10Isarra: "Why are you trying to change the visual design of the entire skin for a single browser? The tabs look fine with gradients, and you're over" [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [19:22:46] greg-g: hmm, best I have at the moment is the gerrit patch https://gerrit.wikimedia.org/r/#/c/98995/ [19:22:59] greg-g: i'll update the commit message there to make it more descriptive [19:23:21] * greg-g nods [19:23:25] thanks ebernhardson [19:28:30] ^d, so I believe https://gerrit.wikimedia.org/r/#/c/105220/4 puts information about LQT pages in the Cirrus search index right? [19:29:12] (03CR) 10CSteipp: [C: 031] "Thanks for fixing this Alex. This implementation seems reasonable for our use. Although I haven't tested it." [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/111514 (owner: 10Alex Monk) [19:29:49] (03PS22) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [19:29:52] (03CR) 10jenkins-bot: [V: 04-1] [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [19:31:49] (03PS23) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [19:31:52] (03CR) 10jenkins-bot: [V: 04-1] [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [19:34:27] (03CR) 10Chad: [C: 04-2] "I don't think editnotices are something we should emulate here. I'm afraid of someone using some parser magic to turn this into *per page*" [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO) [19:34:52] <^d> Krenair: Yes, that's the plan :) [19:35:23] ^d, does it allow any different kind of querying using that data? [19:35:35] <^d> Not yet. I haven't written hooks for extending query syntax yet. [19:35:48] <^d> This was just step 1 so we can start cramming it in. [19:39:44] (03CR) 10Catrope: [C: 031] Don't try to insert the pending changes in the middle of VE's 'Edit' and 'Edit source' [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/110862 (owner: 10Alex Monk) [19:39:58] (03CR) 10Edokter: "The PNG does not need to be 'maintained'; it has been stable for the past seven years. But if you imply that it be made dynamic in some wa" [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [19:40:16] (03CR) 10CSteipp: [C: 031] "Code correctly prevents xss, and the modification of the input parameters doesn't look like it would open up any additional security issue" [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/97559 (owner: 10Jackmcbarn) [19:43:59] (03CR) 10Aaron Schulz: [C: 031] Add dry-run mode to migrateToRevDel.php (031 comment) [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/109777 (owner: 10Alex Monk) [19:45:54] (03PS1) 10CSteipp: Change spaces to tabs [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/112055 [19:52:32] (03PS1) 10Krinkle: Create mediawiki-core-npm [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112056 [19:53:06] (03CR) 10Anomie: "The tests in that file are only used if $wgPFEnableStringFunctions is true, while it's false by default." [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/110582 (owner: 10Umherirrender) [19:54:01] (03PS1) 10Physikerwelt: fix: texvccheck is not idempotent [extensions/Math] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112057 [19:54:43] (03CR) 10Krinkle: [C: 032] "Pushed 'mediawiki-core-npm' to Jenkins (not enabled anywhere, just for testing)." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112056 (owner: 10Krinkle) [19:55:00] (03Merged) 10jenkins-bot: Create mediawiki-core-npm [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112056 (owner: 10Krinkle) [19:55:28] (03CR) 10Krinkle: "Neutral, fine either way." [core] - 10https://gerrit.wikimedia.org/r/112025 (owner: 10Gerrit Patch Uploader) [19:55:59] (03CR) 10Catrope: [C: 04-1] "Doesn't work with $wgVisualEditorTabPosition = 'after';" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/110862 (owner: 10Alex Monk) [19:58:42] (03CR) 10Krinkle: [C: 04-1] Don't try to insert the pending changes in the middle of VE's 'Edit' and 'Edit source' (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/110862 (owner: 10Alex Monk) [19:58:52] (03CR) 10Anomie: [C: 04-1] "I'm not convinced about the use case claimed here. MediaWiki's groups are just a way to give necessary rights to users; if you're checking" [core] - 10https://gerrit.wikimedia.org/r/100590 (owner: 10UltrasonicNXT) [19:59:22] RoanKattouw, okay - so now there are 2 flags for the same feature:P [19:59:37] MaxSem: Well, you know why? [19:59:47] If you enabled the beta feature, all you got was the ability to enable the skin [20:00:45] (03PS2) 10Alex Monk: Don't try to insert the pending changes in the middle of VE's 'Edit' and 'Edit source' [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/110862 [20:01:29] (03CR) 10Isarra: "Unfortunately it doesn't matter what the module is named/where it is - without a proper organisation structure in place, these will all st" [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [20:04:50] (03PS3) 10Alex Monk: Add dry-run mode to migrateToRevDel.php [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/109777 [20:05:06] hash mismatch [20:05:06] key_verify failed for server_host_key [20:05:06] fatal: Could not read from remote repository. [20:05:18] Trying to push to gerrit... Worked when I tried again. what? [20:11:39] (03CR) 10Jdlrobson: [C: 032] "Since no one else has commented.." [core] - 10https://gerrit.wikimedia.org/r/101663 (owner: 10IAlex) [20:11:43] (03PS1) 10Hashar: python jobs for mediawiki/tools/scap [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112058 [20:11:57] (03CR) 10Hashar: [C: 032] python jobs for mediawiki/tools/scap [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112058 (owner: 10Hashar) [20:13:23] (03PS1) 10Hashar: python jobs for mediawiki/tools/scap [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112059 [20:13:34] (03CR) 10jenkins-bot: [V: 04-1] python jobs for mediawiki/tools/scap [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112059 (owner: 10Hashar) [20:13:37] (03Merged) 10jenkins-bot: python jobs for mediawiki/tools/scap [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/112058 (owner: 10Hashar) [20:14:42] (03CR) 10Jdlrobson: [C: 031] "Allowing others to chip in but great stuff!" [core] - 10https://gerrit.wikimedia.org/r/111634 (owner: 10Krinkle) [20:15:15] (03PS2) 10Hashar: python jobs for mediawiki/tools/scap [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112059 [20:15:39] (03CR) 10Hashar: [C: 032] python jobs for mediawiki/tools/scap [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112059 (owner: 10Hashar) [20:15:45] (03Merged) 10jenkins-bot: python jobs for mediawiki/tools/scap [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/112059 (owner: 10Hashar) [20:16:38] (03CR) 10Hashar: "recheck" [tools/scap] - 10https://gerrit.wikimedia.org/r/112036 (owner: 10Hashar) [20:19:08] (03CR) 10Hashar: "recheck" [tools/scap] - 10https://gerrit.wikimedia.org/r/112036 (owner: 10Hashar) [20:20:22] (03PS2) 10Hashar: Python modularization with pbr [tools/scap] - 10https://gerrit.wikimedia.org/r/112036 [20:27:04] (03CR) 10Nullzero: "Does it have to remove from MessagesQqq.php as well?" [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [20:30:56] ^d, I'm just wondering what needs to be done to confirm that this patch works fully [20:31:11] <^d> I want to make sure the data's getting injected. [20:31:16] <^d> I don't think it was last time I tested. [20:31:22] <^d> Lemme update my clones and try again. [20:38:15] (03Merged) 10jenkins-bot: Visual design tweaks. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110946 (owner: 10Phuedx) [20:39:14] (03CR) 10PleaseStand: "> Does it have to remove from MessagesQqq.php as well?" [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [20:40:51] ori, tried hhvm on vagrant: [Fri Feb 07 20:35:28 2014] [error] [client 10.0.2.2] (111)Connection refused: FastCGI: failed to connect to server "/usr/lib/cgi-bin/php5-hhvm": connect() failed [20:41:09] and /usr/lib/cgi-bin is empty [20:44:23] <^d> Krenair: You know what would be even better? Keeping it hardcoded to lsearchd. It's never worked in anything else. [20:44:31] <^d> And tbh I'd rather not bother here. [20:44:34] <^d> The feature *sucks* [20:45:32] MaxSem: thats a 'fake' thing thats handled inside of apache, my best guess is hhvm didn't start itself? [20:45:46] MaxSem: check `pgrep hhvm` if that doesn't have anything try `sudo service hhvm start` [20:46:30] MaxSem: we probably either need an update-rc.d in the hhvm module, or push an update to hhvm's packaging to update-rc.d on its own [20:49:53] (03Abandoned) 10Chad: Begin extending CirrusSearch schema with necessary data [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/105220 (owner: 10Chad) [20:59:23] (03PS1) 10Chad: WIP: Remove LQT search [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/112062 [20:59:44] <^d> Krenair: ^ :p [21:00:16] heh. [21:00:21] have fun finding someone to approve that. [21:00:35] <^d> Selfmergedeploy [21:00:37] <^d> gogogogo [21:04:51] (03PS1) 10EBernhardson: Start HHVM on boot [vagrant] - 10https://gerrit.wikimedia.org/r/112064 [21:05:08] MaxSem: added a patch, but not certain its for your issue [21:07:11] <^d> ebernhardson: I got your e-mail re: search :) [21:07:17] <^d> Two things immediately come to mind. [21:07:53] * ebernhardson leans in [21:07:54] <^d> (1) Do we also want Flow posts to be searchable in the normal site search too? I imagine so. [21:08:01] probably, yes [21:08:18] <^d> (2) Right now Cirrus pretty much focuses on a 1 page -> 1 document model. If I understand Flow properly this might be a little problematic? [21:08:24] <^d> And we might have to think a little harder on this. [21:08:41] ^d: it is problematic, because a page is really just a list of topics. Those topics can belong to multiple pages [21:08:46] <^d> (cc manybubbles on all this :)) [21:09:08] but, we do have the concept of the page a topic was created on, so we can use that initialy [21:09:15] <^d> Hmm, these are also historical too, whereas we only care about the latest version. [21:09:39] <^d> So, my initial assumption is right: we'll probably end up doing this mostly in the Flow side with the Elastica library. [21:09:50] <^d> And then we'll expose that via Special:Search in Cirrus probably. [21:09:53] ^d: we could index them all as little pages, I guess [21:09:54] ok [21:10:07] so long as they resolve to sections in pages [21:10:08] <^d> manybubbles: I think we'll need a distinct index for this. [21:10:09] I think [21:10:27] Probably [21:10:40] but It might be good to search the with site search like they are pages [21:10:48] hmm, they kinda-sorta a resolvable to section pages. We can also change things in the Flow end as necessary [21:10:54] if you want to do that, then they have to be indexes (kinda) like little pages [21:11:12] <^d> Well expanding site search to include results is doable. [21:11:15] or you could have the whole thread in site search [21:11:25] yeah [21:11:33] sorting everything together is always a pain [21:11:45] i suppose one concern about the whole thread, is the associated metadata. But i dont know much about elastic. The important metadata would mostly be the involved usernames [21:11:45] <^d> Bleh yeah [21:12:00] unless you just declare bankruptcy on sorting, then you can do what you want [21:12:09] hrm [21:12:24] sorting together, that is [21:12:42] (03PS1) 10Isarra: (bug 61010) Add IE support to vertical-gradient mixin. [core] - 10https://gerrit.wikimedia.org/r/112066 [21:12:45] ebernhardson: imagine it as a document store that lets you index into the fields (full text) really well [21:13:06] it is really good at traditional document store stuff like filtering by lots of fields in the document [21:13:11] ebernhardson, doesn't seem to help [21:13:32] but also good at sorting a bunch of different results when you search across a whole bunch of different fields [21:13:35] MaxSem: hmm, `pgrep hhvm` shows a running process? [21:13:52] ebernhardson, nope [21:14:11] 1 sec [21:14:14] MaxSem: hmm, my patch should have fixed that...ok i'll look into it some more [21:14:40] MaxSem: also, momentarily(bug in hhvm) /wiki/Foo doesn't work it needs to be /w/index.php?title=Foo . That bug is being fixed upstream and will make the hhvm-nightly any day [21:15:33] manybubbles: hmm, ok well i guess will just have to try it out and see what happens :) [21:16:25] (03PS1) 10Manybubbles: Update to Elastica v0.90.10.0 [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/112067 [21:21:43] (03CR) 10Aaron Schulz: [C: 032] Add dry-run mode to migrateToRevDel.php [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/109777 (owner: 10Alex Monk) [21:21:54] <^d> ebernhardson: Hmm, as long as Flow boards end up resolving to a single page I think we could work with that. [21:22:25] AaronSchulz, I think that needs Verified and Submit [21:22:31] <^d> No reason Flow couldn't add a multi-part mapping to it to store the full discussion. [21:23:16] ^d: hmm, it would probably need to have some sort of cut-off though? With classic talk pages they would get archived into alternate pages containing ~50 sections each, but flow will go on forever [21:23:45] or, i guess per-topic pages with multi-part for the individual posts [21:23:49] hmm [21:23:50] <^d> Hmmmmmm [21:24:17] we could actualy futz the location of the topics as well, to Special:Flow/topic/ [21:24:37] <^d> manybubbles: Could this possibly be wrangled into what we want? http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/mapping-nested-type.html [21:24:47] <^d> We could "nest" flow-types into our page types. [21:25:36] I've been trying to stay away from nested types [21:25:39] (03PS1) 10Umherirrender: Remove outdated todo from Title::userCanRead [core] - 10https://gerrit.wikimedia.org/r/112069 [21:25:46] something about the implementation just makes me unhappy [21:25:50] <^d> Aw :\ [21:25:53] I know [21:26:02] for instance, all children must live on the same shard as the parent [21:26:09] <^d> Anyway, I think it'd solve our problem here. [21:26:17] <^d> page would allow for a nested type of flow. [21:26:25] all the parent<->child mappings live in memory all the time [21:26:30] <^d> Ewww. [21:26:36] it could get bloatybad [21:26:46] I'd have to ask about others using it to see [21:26:55] you'd be surprised how little memory things can take [21:27:02] but still [21:27:15] <^d> I think it's the solution we're needing here. That or something like it. [21:27:32] (03CR) 10Legoktm: [V: 032] Add dry-run mode to migrateToRevDel.php [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/109777 (owner: 10Alex Monk) [21:28:12] ^d: in other news, I poked our manager folk about going to berlin buzzwords to hang out with Elasticsearch people [21:28:33] (03CR) 10Catrope: [C: 032] Don't try to insert the pending changes in the middle of VE's 'Edit' and 'Edit source' [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/110862 (owner: 10Alex Monk) [21:28:51] <^d> ooh. [21:28:56] <^d> i miss berlin [21:29:09] you want to make a good excuse to go? [21:29:19] (03PS1) 10Mwalker: Updating DI for AzRecurring and MinFraud Alarm [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/112086 [21:29:23] (03CR) 10Krinkle: "In the short term this will speed up our existing unit tests a lot by not having to wait for actions to happen that we aren't testing. Suc" [core] - 10https://gerrit.wikimedia.org/r/111634 (owner: 10Krinkle) [21:29:29] <^d> manybubbles: Around Zurich? [21:29:41] http://www.berlinbuzzwords.de/ [21:29:45] May 25-28 [21:29:52] (03CR) 10Mwalker: [C: 032 V: 032] Updating DI for AzRecurring and MinFraud Alarm [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/112086 (owner: 10Mwalker) [21:30:02] <^d> No can do, family in town. [21:30:08] awe no! [21:30:09] (03CR) 10IAlex: [C: 032] Remove outdated todo from Title::userCanRead [core] - 10https://gerrit.wikimedia.org/r/112069 (owner: 10Umherirrender) [21:30:45] bd808: you're using Elasticsearch [21:30:57] Aye [21:31:16] hey legoktm [21:31:20] o/ [21:31:27] <^d> manybubbles: I hear wikipedia is using elasticsearch too [21:31:30] <^d> ;-) [21:31:34] ORLY [21:31:48] you can totally do it [21:32:30] <^d> Anyway, was there a question for bd808? [21:32:42] <^d> Or were you just stating that he uses elasticsearch. [21:33:13] legoktm: can you check out https://gerrit.wikimedia.org/r/#/c/112006/? the beta hook displays for zz_prtksxna but not for me :| want to know if it is something in my setup or something else [21:33:45] (03CR) 10Catrope: [V: 032] Don't try to insert the pending changes in the middle of VE's 'Edit' and 'Edit source' [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/110862 (owner: 10Alex Monk) [21:34:03] I suppose if you made a list of people wmf might want to send, it'd go me, ^d, then bd808. [21:34:18] I'd love to got to buzz words but this year I'd rather go to Zurich [21:34:33] 2 trips to the EU in 2 weeks seems excessive [21:34:42] * legoktm tests [21:34:56] Unless I could just hang out at hashar's house in the middle :) [21:35:57] manybubbles: YOu know what might be a good idea is to get an opsen to go with you [21:36:23] bd808: hashar would love that, I'm sure [21:36:30] I asked in the email. [21:36:41] There are lots of them in the EU already and it would be good to get some deeper ops coverage on elasticsearch [21:36:43] (03PS9) 10Bsitu: Add corresponding *_user_wiki field to all *_user_id fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 [21:36:43] which only went to managers but I probably should have sent it to more people [21:36:48] right [21:36:57] I'm not really sure how much the conference would do that. [21:37:06] but if you put your mind to it you probably could [21:37:37] All conferences are about the hallway track [21:37:45] +1 [21:38:49] * bd808 wonders how pissed his wife would be if he ended up staying in the EU from Mother's day until memorial day [21:38:58] (03Merged) 10jenkins-bot: Remove outdated todo from Title::userCanRead [core] - 10https://gerrit.wikimedia.org/r/112069 (owner: 10Umherirrender) [21:39:47] (03PS2) 10Alex Monk: Check current name of user instead of blindly using user_text (could've been renamed since) [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/111514 [21:39:56] (03PS10) 10Bsitu: Add corresponding *_user_wiki field to all *_user_id fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 [21:41:30] (03PS1) 10Umherirrender: Use Language::commaList on Special:ProtectedTitles [core] - 10https://gerrit.wikimedia.org/r/112121 [21:42:56] (03PS1) 10Catrope: Update MobileFrontend for d62f43bc61df3 [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112122 [21:43:36] (03CR) 10Krinkle: mediawiki.notification: Return the Notification object from .notify calls (033 comments) [core] - 10https://gerrit.wikimedia.org/r/110667 (owner: 10Bartosz Dziewoński) [21:43:46] (03CR) 10Catrope: [C: 032 V: 032] Update MobileFrontend for d62f43bc61df3 [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112122 (owner: 10Catrope) [21:43:52] legoktm: ok, heading to sleep. do leave comments if you find time to test it out :) [21:43:57] night [21:43:59] night yhager [21:44:01] errr [21:44:06] night zz_yuvipanda [21:44:10] legoktm: :P [21:44:10] sorry yhager! [21:44:13] GOT YOU! [21:44:15] :P [21:44:18] you changed nicks too fast >.> [21:44:31] legoktm: I should just enable the autonick plugin on ZNC, been doing it manually [21:44:39] <^d> bd808: At least it's planned. [21:44:50] * ^d mumbles eyjafjallajökull [21:44:55] (03CR) 10Reza: "May reading comments here https://gerrit.wikimedia.org/r/#/c/76349/ and generally difference of popular Arabic and Persian typefaces will " [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/110174 (owner: 10Reza) [21:46:02] (03PS2) 10Mattflaschen: Fix fm and gm and duplicate selectors [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111144 [21:47:53] legoktm: heh :) [21:48:57] (03CR) 10Krinkle: jquery.client: Recognise Amazon Silk browser (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110989 (owner: 10Alex Monk) [21:52:35] (03CR) 10Alex Monk: jquery.client: Recognise Amazon Silk browser (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110989 (owner: 10Alex Monk) [21:54:55] (03PS10) 10Isarra: Add Normalize.css as an available resource. [core] - 10https://gerrit.wikimedia.org/r/110908 [21:56:29] (03PS4) 10Bartosz Dziewoński: mediawiki.notification: Return the Notification object from .notify calls [core] - 10https://gerrit.wikimedia.org/r/110667 [21:56:32] (03CR) 10Bartosz Dziewoński: mediawiki.notification: Return the Notification object from .notify calls (033 comments) [core] - 10https://gerrit.wikimedia.org/r/110667 (owner: 10Bartosz Dziewoński) [22:01:56] (03PS3) 10Mattflaschen: Remove gradients, minor cleanup [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111144 [22:02:47] (03CR) 10Mattflaschen: "Gradients removed. Pau, I'd appreciate it if you take a look." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111144 (owner: 10Mattflaschen) [22:03:16] (03CR) 10Krinkle: [C: 032] jquery.client: Recognise Amazon Silk browser (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110989 (owner: 10Alex Monk) [22:04:09] (03PS1) 10Aaron Schulz: Show the pool counter key and use English for the debug logging [core] - 10https://gerrit.wikimedia.org/r/112125 [22:04:17] (03PS1) 10Bencmq: fire wikipage.content hook on new posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112126 [22:05:04] (03PS2) 10Legoktm: fire wikipage.content hook on new posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112126 (owner: 10Bencmq) [22:05:16] (03CR) 10Bartosz Dziewoński: [C: 031] "Looks like a very fun thing." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111634 (owner: 10Krinkle) [22:06:19] (03PS4) 10Krinkle: qunit: Add SinonJS utility [core] - 10https://gerrit.wikimedia.org/r/111634 [22:06:21] (03CR) 10Krinkle: qunit: Add SinonJS utility (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111634 (owner: 10Krinkle) [22:06:26] (03PS4) 10Krinkle: mediawiki.api.test: Use sinon sandbox for unit tests [core] - 10https://gerrit.wikimedia.org/r/111635 [22:06:30] (03PS7) 10Krinkle: mediawiki.api: Refactor getToken and postWithToken methods [core] - 10https://gerrit.wikimedia.org/r/111636 [22:07:10] (03Merged) 10jenkins-bot: jquery.client: Recognise Amazon Silk browser [core] - 10https://gerrit.wikimedia.org/r/110989 (owner: 10Alex Monk) [22:09:43] gwicke: are you working from home today? [22:14:41] (03CR) 10Bencmq: "This fixes the bug, but my question is whether this is the correct place to fire the hook (i.e. does it matter of it is fired multiple tim" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112126 (owner: 10Bencmq) [22:16:52] (03PS1) 10QChris: Fix documented salt lifespan [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/112129 [22:18:06] (03CR) 10EBernhardson: [C: 04-1] "Only real concern is :not selectors, if we want to support IE8 we cant suse them" (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108535 (owner: 10Matthias Mullie) [22:19:23] (03CR) 10Daniel Friesen: [C: 04-1] "normalize.css is not MediaWiki, it's a 3rd party library, it does not belong under `mediawiki.*`." [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [22:19:52] (03CR) 10Chad: [C: 032 V: 032] Update to Elastica v0.90.10.0 [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/112067 (owner: 10Manybubbles) [22:20:59] (03PS1) 10Mwalker: Updating for MinFraud again... [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/112130 [22:21:01] ori, why did you WONTFIX https://bugzilla.wikimedia.org/show_bug.cgi?id=47181 ? [22:21:11] (03CR) 10Mwalker: [C: 032 V: 032] Updating for MinFraud again... [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/112130 (owner: 10Mwalker) [22:21:32] As you know we're now looking into similar work as part of https://bugzilla.wikimedia.org/show_bug.cgi?id=49057 [22:23:07] superm401: i waffled about it. if you think it's the right way to go, you can re-open (or whatever you think is appropriate). [22:23:48] ori, I'll open a new one since I think we're going to do it with USB drives. However, we can reopen that if we want CDs too. [22:24:32] superm401: cool, having someone actually think this through beats my early intuitions about the problem by a long shot, so godspeed [22:24:53] ori, I haven't thought it through all that much. But I do know we want to script two things: [22:25:16] 1. Assembling the various files, in as easy to use a form as possible (e.g. Yuvi wants to make a DMG) [22:26:33] 2. Making a USB image [22:26:50] superm401: i presume you've read http://docs.vagrantup.com/v2/plugins/packaging.html ? [22:27:00] oh no, wrong link [22:28:00] https://github.com/jedi4ever/veewee i guess? i can't find it now [22:30:26] (03CR) 10Swalling: [C: 031] "Seems like a good idea, since the buttons in core have a hover state (the bevel) already." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111144 (owner: 10Mattflaschen) [22:31:13] (03PS5) 10Matthias Mullie: Add *Revisionable classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111366 [22:31:54] (03PS3) 10Matthias Mullie: Don't propagate permissions to older revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/112042 [22:32:56] Krinkle, regarding https://gerrit.wikimedia.org/r/#/c/111929/ isn [22:33:11] isn't setting a var to undefined a bit ugly? [22:33:40] ori, the Ubuntu base box will probably just be one of the files on the USB drive. [22:33:58] We could investigate packaging the pre-provisioned box, but I'm concerned it would get stale. [22:34:02] Krinkle, actually, we could even do if ( this.section ) because you never want to scroll to section 0 (lead) anyway [22:34:06] jgonera: setting, yes, that would be redundant. resetting to undefined is fine, that's no different than doing = null, except that it's not null. [22:34:20] if ( section !== undefined ) [22:34:24] section = undefined; [22:35:05] constructor: this.section = config.section; @param {number} [config.section] e.g. undefined (not existent, implied undefined, not explicitly undefined), or a number. [22:35:10] Krinkle, if you prefer that, then sure. the fact that both undefined and null exist in JS has always confused me [22:35:39] ori, also, are you alright with the scripts being in the main MWV repo? [22:35:41] null should generally only be used as placeholder for objects, though even then I tend to avoid it. It doesn't matter, as long as its consistent. [22:35:50] I won't commit binaries there, just the builder scripts. [22:36:11] Krinkle, but wait, then I have to do section || undefined in https://gerrit.wikimedia.org/r/#/c/111934/1/javascripts/modules/editor/VisualEditorOverlay.js which looks confusing to avoid weird behavior when 0 is provided (for some reason VE scrolls to the bottom of the page then) [22:36:23] (line 26) [22:36:29] There is two minor advantages to using undefined instead of null. 1) typeof null is broken (object), 2) undeclared properties default to undefined, so it's easier to work with (e.g. you wouldnt do isset( config.section ) ? config.section : undefined;, just plain config.section [22:36:36] can't we just go with if ( this.section )? [22:36:57] and then it won't run for undefined, null and 0 [22:37:07] jgonera: If you never want 0 in there, document it as invalid and make sure this.section (your private property) is not set to something you don't want to handle. [22:37:31] e.g. from the constructor, or merely in a comment (e.g. "don't pass 0 here, it will fail") [22:37:46] (03PS5) 10Ori.livneh: Convert scap to a Python package [tools/scap] - 10https://gerrit.wikimedia.org/r/111716 (owner: 10BryanDavis) [22:37:58] or if you don't want to put the responsibility on the caller, move the logic to the constructor like this.section = config.section || undefined; [22:38:01] (03CR) 10Ori.livneh: [C: 032 V: 032] Convert scap to a Python package [tools/scap] - 10https://gerrit.wikimedia.org/r/111716 (owner: 10BryanDavis) [22:38:07] looks odd, but as long as it is intentional, a comment will clear that up [22:38:18] Krinkle, yes, I can do that too, but what's the benefit in writing more code, more docs and making it less intuitive? [22:38:33] what happens with false, null, '', NaN, etc. doesnt' matter as those are invalid values. [22:38:43] jgonera: It's actually a lot less code [22:39:24] @param {number} [config.section], // Filter out 0, we only want 1 or higher this.section = config.section || undefined; if (this.section) this.section = undefined; [22:39:40] pretty minimal compared to the eixsting one in desktop and the one currently in gerrit. [22:40:20] if ( this.section ) vs. if ( this.section !== undefined), then section: options && options.section vs. section: ( options && options.section ) || undefined [22:40:35] hm, ok, it's not that important for me, I'll just do it the way you like it ;) [22:41:16] k [22:47:26] (03PS1) 10Manybubbles: Stop using script for boost-templates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112134 [22:48:07] (03PS2) 10Manybubbles: Stop using script for boost-templates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112134 [22:51:00] (03CR) 10Legoktm: [C: 04-1] "BetaFeatures registration works for me, not sure why it wasn't for Yuvi." (035 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/112006 (owner: 10Prtksxna) [22:52:25] greg-g: https://en.wikipedia.org/wiki/Wikipedia:VP/T#Math_aligned_environments_failing_to_parse [22:52:38] aware of that? [22:55:12] (03CR) 10Aaron Schulz: "Any examples?" [core] - 10https://gerrit.wikimedia.org/r/103399 (owner: 10Aaron Schulz) [22:55:13] AaronSchulz: no :/ [22:56:04] what's odd is that Math was reverted to the previous version yesterday, as in, ENWIKI has the version of Math they had a week ago [23:05:46] (03PS1) 10Gergő Tisza: Add license to test images [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112137 [23:09:21] (03CR) 10EBernhardson: [C: 032] Get rid of hyphenation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111958 (owner: 10Matthias Mullie) [23:09:31] (03Merged) 10jenkins-bot: Get rid of hyphenation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111958 (owner: 10Matthias Mullie) [23:10:13] (03CR) 10EBernhardson: [C: 032] Fix clearfix, which triggered scrollbars [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111955 (owner: 10Matthias Mullie) [23:10:23] (03Merged) 10jenkins-bot: Fix clearfix, which triggered scrollbars [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111955 (owner: 10Matthias Mullie) [23:11:26] (03CR) 10EBernhardson: [C: 032] Implement pre-commit hook running less, jshint, and phplint checks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110235 (owner: 10EBernhardson) [23:11:37] (03Merged) 10jenkins-bot: Implement pre-commit hook running less, jshint, and phplint checks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110235 (owner: 10EBernhardson) [23:13:43] (03PS1) 10MaxSem: Fix timestamp validation [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/112139 [23:19:22] (03CR) 10Bartosz Dziewoński: [C: 031] qunit: Add SinonJS utility [core] - 10https://gerrit.wikimedia.org/r/111634 (owner: 10Krinkle) [23:20:06] (03CR) 10Ori.livneh: [C: 032] "Thanks!" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/112129 (owner: 10QChris) [23:20:37] (03Merged) 10jenkins-bot: Fix documented salt lifespan [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/112129 (owner: 10QChris) [23:20:46] (03PS1) 10Zfilipin: Updated mediawiki_selenium to 0.2.1 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/112140 [23:21:19] (03PS3) 10Hashar: Python modularization with pbr [tools/scap] - 10https://gerrit.wikimedia.org/r/112036 [23:21:48] (03CR) 10Ori.livneh: [C: 04-1] "Looks good, but needs a require => so that it doesn't get executed before the package is fetched and configured" (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/112064 (owner: 10EBernhardson) [23:31:30] (03PS2) 10Wctaiwan: Make terms of use non-WMF specific [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111710 [23:31:33] (03CR) 10jenkins-bot: [V: 04-1] Make terms of use non-WMF specific [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111710 (owner: 10Wctaiwan) [23:33:20] (03CR) 10Wctaiwan: Make terms of use non-WMF specific (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111710 (owner: 10Wctaiwan) [23:33:50] (03CR) 10Cmcmahon: [C: 032] "updated by request of Commons admins" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112137 (owner: 10Gergő Tisza) [23:33:58] (03Merged) 10jenkins-bot: Add license to test images [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/112137 (owner: 10Gergő Tisza) [23:34:29] (03PS1) 10Chad: Don't dump globals to stdout during a unit test [core] - 10https://gerrit.wikimedia.org/r/112147 [23:37:19] (03CR) 10Bartosz Dziewoński: "This supersedes https://gerrit.wikimedia.org/r/#/c/110662/ , noting for posterity. Some comments inline, mostly pointing out typos ;)" (037 comments) [core] - 10https://gerrit.wikimedia.org/r/111636 (owner: 10Krinkle) [23:38:19] (03CR) 10jenkins-bot: [V: 04-1] Don't dump globals to stdout during a unit test [core] - 10https://gerrit.wikimedia.org/r/112147 (owner: 10Chad) [23:39:35] (03CR) 10Aaron Schulz: [C: 04-1] "Needs rebase" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/105443 (owner: 10Umherirrender) [23:41:00] (03CR) 10BryanDavis: [C: 04-1] "+1 for tox; -1 for pbr." [tools/scap] - 10https://gerrit.wikimedia.org/r/112036 (owner: 10Hashar) [23:54:45] (03PS3) 10Wctaiwan: Make terms of use non-WMF specific [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111710