[00:00:08] (03PS1) 10EBernhardson: Prevent events with large blob extra data [extensions/Echo] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111652 [00:00:19] (03PS1) 10EBernhardson: Prevent events with large blob extra data [extensions/Echo] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111653 [00:00:22] (03Abandoned) 10TTO: Give a meaningful message when Special:ActiveUsers is disabled [core] - 10https://gerrit.wikimedia.org/r/109496 (owner: 10TTO) [00:00:30] (03CR) 10EBernhardson: [C: 032] Prevent events with large blob extra data [extensions/Echo] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111653 (owner: 10EBernhardson) [00:00:36] (03Merged) 10jenkins-bot: Prevent events with large blob extra data [extensions/Echo] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111653 (owner: 10EBernhardson) [00:00:42] (03CR) 10EBernhardson: [C: 032] Prevent events with large blob extra data [extensions/Echo] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111652 (owner: 10EBernhardson) [00:00:49] (03Merged) 10jenkins-bot: Prevent events with large blob extra data [extensions/Echo] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111652 (owner: 10EBernhardson) [00:01:04] (03PS1) 10EBernhardson: Catch exceptions formatting notifications [extensions/Echo] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111654 [00:01:13] (03CR) 10EBernhardson: [C: 032] Catch exceptions formatting notifications [extensions/Echo] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111654 (owner: 10EBernhardson) [00:01:25] (03PS1) 10EBernhardson: Catch exceptions formatting notifications [extensions/Echo] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111656 [00:01:28] (03Merged) 10jenkins-bot: Catch exceptions formatting notifications [extensions/Echo] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111654 (owner: 10EBernhardson) [00:01:39] (03CR) 10EBernhardson: [C: 032] Catch exceptions formatting notifications [extensions/Echo] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111656 (owner: 10EBernhardson) [00:01:46] (03Merged) 10jenkins-bot: Catch exceptions formatting notifications [extensions/Echo] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111656 (owner: 10EBernhardson) [00:01:59] (03PS1) 10Matthias Mullie: AbstractRevision was not being used, assuming incorrect namespace Flow\AbstractRevision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111657 [00:03:00] (03CR) 10EBernhardson: [C: 032] AbstractRevision was not being used, assuming incorrect namespace Flow\AbstractRevision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111657 (owner: 10Matthias Mullie) [00:03:10] (03Merged) 10jenkins-bot: AbstractRevision was not being used, assuming incorrect namespace Flow\AbstractRevision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111657 (owner: 10Matthias Mullie) [00:03:59] (03PS4) 10Krinkle: mediawiki.htmlform: Add jsduck docs [core] - 10https://gerrit.wikimedia.org/r/111627 (owner: 10MarkTraceur) [00:04:10] (03CR) 10Krinkle: [C: 032] mediawiki.htmlform: Add jsduck docs [core] - 10https://gerrit.wikimedia.org/r/111627 (owner: 10MarkTraceur) [00:04:13] (03CR) 10Matthias Mullie: "Fix already merged" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111625 (owner: 10EBernhardson) [00:07:28] (03PS1) 10EBernhardson: Prevent fatal errors in urlgenerator [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111658 [00:08:03] (03CR) 10EBernhardson: "cherry-picked to wmf/1.23wmf11 in https://gerrit.wikimedia.org/r/111658" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111625 (owner: 10EBernhardson) [00:08:08] (03PS6) 10Matthias Mullie: Switch to underscores, because php mangles everything else [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110501 (owner: 10EBernhardson) [00:08:16] (03CR) 10EBernhardson: [C: 032] Prevent fatal errors in urlgenerator [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111658 (owner: 10EBernhardson) [00:08:21] (03Merged) 10jenkins-bot: Prevent fatal errors in urlgenerator [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111658 (owner: 10EBernhardson) [00:08:31] (03Merged) 10jenkins-bot: mediawiki.htmlform: Add jsduck docs [core] - 10https://gerrit.wikimedia.org/r/111627 (owner: 10MarkTraceur) [00:09:20] (03PS1) 10EBernhardson: Prevent fatal errors in urlgenerator [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111659 [00:09:32] (03CR) 10EBernhardson: [C: 032] Prevent fatal errors in urlgenerator [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111659 (owner: 10EBernhardson) [00:09:41] (03Merged) 10jenkins-bot: Prevent fatal errors in urlgenerator [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111659 (owner: 10EBernhardson) [00:10:04] (03PS1) 10EBernhardson: AbstractRevision was not being used, assuming incorrect namespace Flow\AbstractRevision [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111660 [00:10:09] (03CR) 10EBernhardson: [C: 032] AbstractRevision was not being used, assuming incorrect namespace Flow\AbstractRevision [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111660 (owner: 10EBernhardson) [00:10:14] (03Merged) 10jenkins-bot: AbstractRevision was not being used, assuming incorrect namespace Flow\AbstractRevision [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111660 (owner: 10EBernhardson) [00:10:21] (03PS1) 10EBernhardson: AbstractRevision was not being used, assuming incorrect namespace Flow\AbstractRevision [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111661 [00:11:06] (03CR) 10EBernhardson: [C: 032] AbstractRevision was not being used, assuming incorrect namespace Flow\AbstractRevision [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111661 (owner: 10EBernhardson) [00:11:15] (03Merged) 10jenkins-bot: AbstractRevision was not being used, assuming incorrect namespace Flow\AbstractRevision [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111661 (owner: 10EBernhardson) [00:12:03] (03CR) 10TTO: Allow interlanguage link prefixes that are not language codes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111390 (owner: 10TTO) [00:12:26] (03CR) 10BryanDavis: [C: 032] Add jsduck support for MediaViewer [vagrant] - 10https://gerrit.wikimedia.org/r/108858 (owner: 10Gergő Tisza) [00:12:30] (03Merged) 10jenkins-bot: Add jsduck support for MediaViewer [vagrant] - 10https://gerrit.wikimedia.org/r/108858 (owner: 10Gergő Tisza) [00:14:12] (03PS7) 10Matthias Mullie: Switch to underscores, because php mangles everything else [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110501 (owner: 10EBernhardson) [00:14:43] (03CR) 10Mattflaschen: [C: 04-1] "Should be indented with tabs." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110946 (owner: 10Phuedx) [00:14:54] (03PS1) 10EBernhardson: Update Echo and Flow [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111662 [00:14:57] (03CR) 10Matthias Mullie: [C: 032] "I found 1 more missing [replyTo] - fixed it" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110501 (owner: 10EBernhardson) [00:15:16] superm401, have you worked on jqueryMsg recently? [00:15:21] (you're in the contribs) [00:15:33] rdwrer, no, not recently. [00:15:43] (03CR) 10jenkins-bot: [V: 04-1] Update Echo and Flow [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111662 (owner: 10EBernhardson) [00:15:44] Hm. [00:15:52] superm401: Do you remember the astCache variable? [00:15:53] (03Merged) 10jenkins-bot: Switch to underscores, because php mangles everything else [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110501 (owner: 10EBernhardson) [00:16:09] rdwrer, somewhat, let me look to refresh my memory. [00:16:26] I'm confused about the @static tag on it [00:16:30] It seems to be...not static at all [00:16:37] (03PS1) 10IAlex: Send the full title to the 'nogomatch' debug log group [core] - 10https://gerrit.wikimedia.org/r/111663 [00:17:45] rdwrer, no, it is. [00:17:55] rdwrer, I'll do a pastebin [00:18:02] 'kay [00:18:13] (03PS1) 10Matthias Mullie: Immediately render submitted header changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111665 [00:18:48] (03PS2) 10EBernhardson: Update Echo and Flow [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111662 [00:19:10] rdwrer, http://pastebin.com/pWhA4Sam [00:19:21] Huh. [00:19:32] There's gotta be something magical between, then, because otherwise this makes no sense. [00:19:50] OH [00:19:51] Duh. [00:19:56] Excuse me while I hurt myself [00:20:11] If you create it in the prototype, the new objects all get the prototype's copy referenced. [00:20:16] Damn it JavaScript [00:20:25] rdwrer, hey, it's commented. :) [00:20:27] Thanks, superm401 [00:21:00] rdwrer, it's intentional AFAICT, for better caching. In theory it should work, unless there's a variable not taken into account in the cache. [00:21:02] No problem [00:21:36] (03PS1) 10EBernhardson: Update Echo and Flow [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111668 [00:26:00] (03PS1) 10Matthias Mullie: Don't use .flow-container scoping - tipsy break out of it [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111669 [00:27:23] (03CR) 10EBernhardson: [C: 032] Update Echo and Flow [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111662 (owner: 10EBernhardson) [00:27:51] (03CR) 10EBernhardson: [C: 032] Update Echo and Flow [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111668 (owner: 10EBernhardson) [00:27:54] (03CR) 10Spage: [C: 032] "These are the commits you are looking for." [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111668 (owner: 10EBernhardson) [00:29:19] (03PS1) 10Matthias Mullie: terms-of-use text should wrap [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111670 [00:29:31] (03PS1) 10Bsitu: Add *_user_wiki to all the *_user_id columns [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 [00:29:39] (03CR) 10jenkins-bot: [V: 04-1] Add *_user_wiki to all the *_user_id columns [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 (owner: 10Bsitu) [00:31:17] (03Merged) 10jenkins-bot: Update Echo and Flow [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111662 (owner: 10EBernhardson) [00:31:30] (03Merged) 10jenkins-bot: Update Echo and Flow [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111668 (owner: 10EBernhardson) [00:38:12] TrevorParscal https://gerrit.wikimedia.org/r/#/c/109940/ [00:39:28] (03PS1) 10Ori.livneh: scappy: full compatibility with scap's '--versions' arg [tools/scap] - 10https://gerrit.wikimedia.org/r/111673 [00:40:09] (03CR) 10Ori.livneh: [C: 032 V: 032] scappy: full compatibility with scap's '--versions' arg [tools/scap] - 10https://gerrit.wikimedia.org/r/111673 (owner: 10Ori.livneh) [00:45:18] (03PS1) 10Krinkle: jquery.client: Include platform in the profile cache key [core] - 10https://gerrit.wikimedia.org/r/111674 [00:45:31] RoanKattouw: ^ [00:45:39] Sweet [00:45:41] Reviewing [00:46:29] (03CR) 10Catrope: [C: 04-1] jquery.client: Include platform in the profile cache key (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111674 (owner: 10Krinkle) [00:47:29] Krinkle: --^^ [00:48:26] (03PS1) 10MarkTraceur: Add jsduck docs to jqueryMsg [core] - 10https://gerrit.wikimedia.org/r/111676 [00:49:00] RoanKattouw: I'm going to have to hoist all those friggin vars [00:49:14] (03CR) 10jenkins-bot: [V: 04-1] jquery.client: Include platform in the profile cache key [core] - 10https://gerrit.wikimedia.org/r/111674 (owner: 10Krinkle) [00:49:18] (03PS2) 10Krinkle: jquery.client: Include platform in the profile cache key [core] - 10https://gerrit.wikimedia.org/r/111674 [00:49:34] (03CR) 10EBernhardson: [C: 032] Add *Revisionable classes (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111366 (owner: 10Matthias Mullie) [00:50:18] (03CR) 10Catrope: [C: 032] jquery.client: Include platform in the profile cache key [core] - 10https://gerrit.wikimedia.org/r/111674 (owner: 10Krinkle) [00:50:21] (03PS3) 10Krinkle: jquery.client: Include platform in the profile cache key [core] - 10https://gerrit.wikimedia.org/r/111674 [00:50:26] lol [00:50:30] jshint error [00:52:12] (03PS1) 10Ori.livneh: fold 'sync-wikiversions' into scappy [tools/scap] - 10https://gerrit.wikimedia.org/r/111678 [00:52:26] (03CR) 10Ori.livneh: [C: 032 V: 032] fold 'sync-wikiversions' into scappy [tools/scap] - 10https://gerrit.wikimedia.org/r/111678 (owner: 10Ori.livneh) [00:52:32] (03CR) 10Catrope: [C: 032] jquery.client: Include platform in the profile cache key [core] - 10https://gerrit.wikimedia.org/r/111674 (owner: 10Krinkle) [00:52:40] (03PS1) 10Krinkle: jquery.client: Clean up cache key repetition and early return [core] - 10https://gerrit.wikimedia.org/r/111680 [00:52:45] RoanKattouw: are you guys going to deploy additional changes? [00:52:50] ori: ? [00:53:05] I know nothing of any changes being deployed [00:53:13] RoanKattouw: TrevorParscal Krinkle - let me know if https://gerrit.wikimedia.org/r/#/c/109940/ needs any tweaks [00:53:20] Other than that Krinkle was supposed to have deployed some config changes an hour ago that I didn't check on [00:53:32] (03PS1) 10Bsitu: Automatically mark invalid notifications as read upon request [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111681 [00:53:35] RoanKattouw: Couldn't get a window, and no reply from James either. [00:53:47] cool [00:53:48] whoops wrong one - i meant https://gerrit.wikimedia.org/r/#/c/109806/9 (just fixed qunit / npm issues as we speak) [00:53:53] (03CR) 10Catrope: [C: 032] jquery.client: Clean up cache key repetition and early return [core] - 10https://gerrit.wikimedia.org/r/111680 (owner: 10Krinkle) [00:53:57] RoanKattouw: It's low prio as it was just something semi-random that we remembed we should've done in January [00:54:02] OK [00:54:03] it can wait [00:56:33] (03CR) 10Matthias Mullie: [C: 032] Automatically mark invalid notifications as read upon request [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111681 (owner: 10Bsitu) [00:56:41] (03Merged) 10jenkins-bot: Automatically mark invalid notifications as read upon request [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111681 (owner: 10Bsitu) [00:57:00] (03Merged) 10jenkins-bot: jquery.client: Include platform in the profile cache key [core] - 10https://gerrit.wikimedia.org/r/111674 (owner: 10Krinkle) [00:57:12] (03PS1) 10Ori.livneh: Fix typo ('version' => 'versions') introduced in I2195835cc [tools/scap] - 10https://gerrit.wikimedia.org/r/111683 [00:57:28] (03CR) 10Ori.livneh: [C: 032 V: 032] Fix typo ('version' => 'versions') introduced in I2195835cc [tools/scap] - 10https://gerrit.wikimedia.org/r/111683 (owner: 10Ori.livneh) [00:57:55] (03Merged) 10jenkins-bot: jquery.client: Clean up cache key repetition and early return [core] - 10https://gerrit.wikimedia.org/r/111680 (owner: 10Krinkle) [01:05:34] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 20d6df9..5aafc12 [extensions] - 10https://gerrit.wikimedia.org/r/111685 [01:05:36] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 20d6df9..5aafc12 [extensions] - 10https://gerrit.wikimedia.org/r/111685 (owner: 10Jenkins-mwext-sync) [01:06:40] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 5aafc12..6c42b76 [extensions] - 10https://gerrit.wikimedia.org/r/111686 [01:06:42] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 5aafc12..6c42b76 [extensions] - 10https://gerrit.wikimedia.org/r/111686 (owner: 10Jenkins-mwext-sync) [01:07:02] (03CR) 10Parent5446: Make abstract Config class truly implementation-agnostic (032 comments) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [01:07:43] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 6c42b76..5c8627d [extensions] - 10https://gerrit.wikimedia.org/r/111687 [01:07:45] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 6c42b76..5c8627d [extensions] - 10https://gerrit.wikimedia.org/r/111687 (owner: 10Jenkins-mwext-sync) [01:33:29] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 5c8627d..d8c9c30 [extensions] - 10https://gerrit.wikimedia.org/r/111692 [01:33:31] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 5c8627d..d8c9c30 [extensions] - 10https://gerrit.wikimedia.org/r/111692 (owner: 10Jenkins-mwext-sync) [01:38:51] (03PS1) 10Wctaiwan: Add support for Flow's terms of use [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/111693 [01:43:07] (03CR) 10Parent5446: [C: 031] Check current name of user instead of blindly using user_text (could've been renamed since) (031 comment) [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/111514 (owner: 10Alex Monk) [01:45:09] (03PS1) 10Catrope: Update VisualEditor to 1.23wmf12 branch for cherry-pick [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111697 [01:49:16] (03CR) 10TTO: "I'm inclined to agree with all of those points, although I still don't understand your point about i18n messages." [core] - 10https://gerrit.wikimedia.org/r/110832 (owner: 10TTO) [01:49:47] (03Abandoned) 10TTO: Add SkinTemplateLanguageLinks hook [core] - 10https://gerrit.wikimedia.org/r/110832 (owner: 10TTO) [02:01:40] (03PS1) 10Legoktm: Turn mediawiki/skins into a meta repo of skins [skins] - 10https://gerrit.wikimedia.org/r/111700 [02:01:46] (03PS1) 10Legoktm: Add .gitreview [skins] - 10https://gerrit.wikimedia.org/r/111701 [02:01:53] Isarra: ^ [02:03:15] (03PS1) 10TTO: Remove from autoblocker message [core] - 10https://gerrit.wikimedia.org/r/111702 [02:04:51] (03PS2) 10TTO: Remove from autoblocker message [core] - 10https://gerrit.wikimedia.org/r/111702 [02:05:15] (03CR) 10TTO: "See followup I505a486624f1891fb8b708862692637d4ec42db8" [core] - 10https://gerrit.wikimedia.org/r/99195 (owner: 10Siebrand) [02:05:44] legoktm: Does that do it? If so neat. [02:05:46] And yay. [02:05:49] And thank you. [02:05:55] I think so! [02:06:35] some of the existing mediawiki/skins/* repos are empty [02:06:43] >.< [02:06:48] namely apex and Truglass [02:06:52] https://gerrit.wikimedia.org/r/#/admin/projects/?filter=mediawiki%252Fskins%252F [02:07:09] I guess someone should go through the rest and see if they even work and crap, too. [02:07:49] BlueSpice was recently updated [02:08:01] and I think Ryan L keeps webplatform updated [02:09:20] https://wikimediafoundation.org/w/index.php?title=Home&useskin=tomas [02:09:41] Weird. [02:15:35] (03PS3) 10Gerrit Patch Uploader: Clean Timestamp Fields in mysql [core] - 10https://gerrit.wikimedia.org/r/110949 [02:15:37] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [02:18:33] (03PS1) 10Gergő Tisza: Return jqXHR from mw.Api calls [core] - 10https://gerrit.wikimedia.org/r/111704 [02:18:49] (03PS2) 10Bsitu: Add *_user_wiki to all the *_user_id columns [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 [02:21:32] (03PS3) 10Bsitu: Add *_user_wiki to all the *_user_id columns [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 [02:22:57] (03PS2) 10Gergő Tisza: Return jqXHR from mw.Api calls [core] - 10https://gerrit.wikimedia.org/r/111704 [02:30:10] (03PS1) 10Legoktm: Don't throw exceptions in the Echo formatter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111706 [02:30:16] (03PS1) 10Legoktm: Whitelist action=info on Flow pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111707 [02:31:07] (03Abandoned) 10Legoktm: Don't throw exceptions in the Echo formatter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111706 (owner: 10Legoktm) [02:31:57] (03PS2) 10Legoktm: Whitelist action=info on Flow pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111707 [02:32:00] (03PS4) 10Gerrit Patch Uploader: Clean Timestamp Fields in mysql [core] - 10https://gerrit.wikimedia.org/r/110949 [02:32:02] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [02:35:51] (03PS1) 10Legoktm: Default Echo email notifications for Flow to disabled [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111708 [02:43:25] (03CR) 10Legoktm: "That patch has been self -1'd since January and doesn't have a very clear path forward. Personally I think it makes sense to just merge th" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111402 (owner: 10Legoktm) [02:44:20] (03CR) 10EBernhardson: "We checked whitelisting info before, the problem is it doesn't provide relevant information. For example here is the info for Talk:Flow on" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111707 (owner: 10Legoktm) [02:49:42] (03PS1) 10Wctaiwan: Make terms of use non-WMF specific [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111710 [02:49:53] (03CR) 10Mattflaschen: "See inline." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [02:54:06] (03CR) 10Parent5446: "Can somebody explain to me why we are converting all the BINARY to VARBINARY and not the other way around? Timestamps will always be 14 by" [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [02:59:40] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: d8c9c30..78680bb [extensions] - 10https://gerrit.wikimedia.org/r/111711 [02:59:42] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: d8c9c30..78680bb [extensions] - 10https://gerrit.wikimedia.org/r/111711 (owner: 10Jenkins-mwext-sync) [03:02:54] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 78680bb..a1d4acc [extensions] - 10https://gerrit.wikimedia.org/r/111712 [03:02:56] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 78680bb..a1d4acc [extensions] - 10https://gerrit.wikimedia.org/r/111712 (owner: 10Jenkins-mwext-sync) [03:11:22] (03PS3) 10Legoktm: Enable action=info for Flow pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111707 [03:16:38] (03PS6) 10Prtksxna: Add animation to NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/110675 [03:16:40] (03PS1) 10Prtksxna: Remove `title` attribute from links that have the popup [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/111715 [03:35:48] (03CR) 10EBernhardson: [C: 032] Enable action=info for Flow pages (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111707 (owner: 10Legoktm) [03:35:58] (03Merged) 10jenkins-bot: Enable action=info for Flow pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111707 (owner: 10Legoktm) [03:38:03] (03CR) 10Legoktm: Enable action=info for Flow pages (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111707 (owner: 10Legoktm) [03:39:57] (03CR) 10Mattflaschen: [C: 04-1] "With IConfig removed, Config is kind of serving a dual purpose:" (036 comments) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [03:42:18] (03PS1) 10BryanDavis: Convert scappy to a python package [tools/scap] - 10https://gerrit.wikimedia.org/r/111716 [03:49:02] (03CR) 10Mattflaschen: "It works. However, see the note inline about addModuleStyles." (031 comment) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111511 (owner: 10Yuvipanda) [03:49:18] (03CR) 10BryanDavis: Convert scappy to a python package (033 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/111716 (owner: 10BryanDavis) [03:53:26] (03PS2) 10BryanDavis: Convert scappy to a python package [tools/scap] - 10https://gerrit.wikimedia.org/r/111716 [03:58:44] (03PS1) 10Legoktm: Turn \Flow\View into a ContextSource [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111717 [04:19:22] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: a1d4acc..406e540 [extensions] - 10https://gerrit.wikimedia.org/r/111718 [04:19:24] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: a1d4acc..406e540 [extensions] - 10https://gerrit.wikimedia.org/r/111718 (owner: 10Jenkins-mwext-sync) [04:20:36] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 406e540..0d0b7b2 [extensions] - 10https://gerrit.wikimedia.org/r/111719 [04:20:38] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 406e540..0d0b7b2 [extensions] - 10https://gerrit.wikimedia.org/r/111719 (owner: 10Jenkins-mwext-sync) [04:20:43] (03PS1) 10Ori.livneh: Fix crash when --version is not specified [tools/scap] - 10https://gerrit.wikimedia.org/r/111720 [04:21:18] (03PS2) 10Ori.livneh: Fix crash when --version is not specified [tools/scap] - 10https://gerrit.wikimedia.org/r/111720 [04:22:18] (03CR) 10Ori.livneh: [C: 032 V: 032] Fix crash when --version is not specified [tools/scap] - 10https://gerrit.wikimedia.org/r/111720 (owner: 10Ori.livneh) [04:22:24] (03PS1) 10Legoktm: Implement former SimpleAntiSpam extension in \Flow\View\ [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111721 [04:23:14] (03PS2) 10Legoktm: Implement former SimpleAntiSpam extension in \Flow\View [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111721 [04:24:50] (03PS1) 10Legoktm: Use the context we have instead of RequestContext::getMain() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111722 [04:25:53] (03PS2) 10Legoktm: Use the context we have instead of RequestContext::getMain() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111722 [04:30:16] (03Abandoned) 10Legoktm: Implement former SimpleAntiSpam extension in \Flow\View [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111721 (owner: 10Legoktm) [04:38:28] (03CR) 10BryanDavis: Convert scappy to a python package (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/111716 (owner: 10BryanDavis) [04:38:51] (03PS1) 10Legoktm: Whitelist action=watch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111723 [04:42:26] (03PS1) 10Legoktm: Use context instead of global [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111724 [04:57:11] Cool, geben (PHP debugging UI for emacs) has conditional breakpoints. [05:34:22] (03PS1) 10Ori.livneh: Fix regexp for reading dsh host files [tools/scap] - 10https://gerrit.wikimedia.org/r/111726 [05:34:45] (03CR) 10Ori.livneh: [C: 032 V: 032] Fix regexp for reading dsh host files [tools/scap] - 10https://gerrit.wikimedia.org/r/111726 (owner: 10Ori.livneh) [05:37:58] (03PS1) 10Ori.livneh: Invoke IRCSocketHandler with addr as starargs [tools/scap] - 10https://gerrit.wikimedia.org/r/111727 [05:39:48] (03CR) 10Ori.livneh: [C: 032 V: 032] Invoke IRCSocketHandler with addr as starargs [tools/scap] - 10https://gerrit.wikimedia.org/r/111727 (owner: 10Ori.livneh) [05:54:41] (03PS1) 10Ori.livneh: rename scappy -> scap, scap -> scap-old [tools/scap] - 10https://gerrit.wikimedia.org/r/111729 [05:55:12] (03CR) 10Ori.livneh: [C: 032 V: 032] rename scappy -> scap, scap -> scap-old [tools/scap] - 10https://gerrit.wikimedia.org/r/111729 (owner: 10Ori.livneh) [05:55:29] (03CR) 10MZMcBride: "Heh." [tools/scap] - 10https://gerrit.wikimedia.org/r/111729 (owner: 10Ori.livneh) [06:11:12] (03CR) 10PleaseStand: "> Can somebody explain to me why we are converting all the BINARY to VARBINARY and not the other way around? Timestamps will always be 14 " [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [06:36:00] (03PS1) 10Mattflaschen: Have mtime as calculated by startup module increase on schema change [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/111731 [06:37:48] ^ ori, another bug found thanks to module storage. [06:38:07] I got tired of using debug mode when even hard refresh mysteriously didn't work. [06:40:38] (03PS1) 10Cscott: Switch from `when` to `bluebird` for Promise implementation. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/111732 [06:40:52] (03CR) 10jenkins-bot: [V: 04-1] Switch from `when` to `bluebird` for Promise implementation. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/111732 (owner: 10Cscott) [06:43:22] (03PS2) 10Mattflaschen: Have mtime as calculated by startup module increase on schema change [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/111731 [06:44:36] (03PS2) 10Cscott: Switch from `when` to `bluebird` for Promise implementation. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/111732 [06:44:48] (03CR) 10jenkins-bot: [V: 04-1] Switch from `when` to `bluebird` for Promise implementation. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/111732 (owner: 10Cscott) [06:48:37] superm401: hmm! nice find! [06:48:49] i am still reproducing & grokking [06:48:52] ori, thanks. :) [06:52:27] (03PS1) 10Nullzero: Make list=allfileusages functional [core] - 10https://gerrit.wikimedia.org/r/111734 [07:13:56] (03CR) 10Mattflaschen: "> Rotating the key/salt every 24 hours will 'break' Aarons latest research snippet about anonymous editors behavior as he analyzes IPS on " [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/110700 (owner: 10Ori.livneh) [07:16:27] (03CR) 10Mattflaschen: [C: 032] "Looks good, confirmed locally." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110580 (owner: 10Phuedx) [07:16:31] (03Merged) 10jenkins-bot: Update onboarding CTA impression logging. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110580 (owner: 10Phuedx) [07:17:07] (03PS1) 10Freakolowsky: Fix Oracle 1.23 missing patches [core] - 10https://gerrit.wikimedia.org/r/111735 [07:18:27] every single time ... spend ~hour to find out all the schema changes pplz forgot to put into oracle/table.sql [07:19:18] (03CR) 10Nemo bis: [C: 031] "Fine for this case." [core] - 10https://gerrit.wikimedia.org/r/111702 (owner: 10TTO) [07:19:33] (03PS2) 10Legoktm: Whitelist action=(un)watch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111723 [07:20:35] (03CR) 10Nikerabbit: [C: 032] Remove from autoblocker message [core] - 10https://gerrit.wikimedia.org/r/111702 (owner: 10TTO) [07:21:02] (03CR) 10Nemo bis: "Thanks TTO, but how do we audit the other hundreds of cases here and in core though?" [core] - 10https://gerrit.wikimedia.org/r/99195 (owner: 10Siebrand) [07:23:53] (03CR) 10Legoktm: Add special page alias file (031 comment) [extensions/GlobalContributions] - 10https://gerrit.wikimedia.org/r/111425 (owner: 10Raimond Spekking) [07:23:58] (03PS2) 10Legoktm: Add special page alias file [extensions/GlobalContributions] - 10https://gerrit.wikimedia.org/r/111425 (owner: 10Raimond Spekking) [07:24:24] (03CR) 10Legoktm: [C: 032 V: 032] "Thanks!" [extensions/GlobalContributions] - 10https://gerrit.wikimedia.org/r/111425 (owner: 10Raimond Spekking) [07:24:32] (03Merged) 10jenkins-bot: Remove from autoblocker message [core] - 10https://gerrit.wikimedia.org/r/111702 (owner: 10TTO) [07:28:58] (03CR) 10Parent5446: [C: 031] Fix Oracle 1.23 missing patches [core] - 10https://gerrit.wikimedia.org/r/111735 (owner: 10Freakolowsky) [07:29:11] (03CR) 10Nikerabbit: "Does MySQL not support years past 9999?" [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [07:49:20] (03CR) 10Robert Vogel: [C: 032 V: 032] "Thanks a lot" [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/111480 (owner: 10Chad) [07:49:57] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111710 (owner: 10Wctaiwan) [07:51:17] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/111693 (owner: 10Wctaiwan) [07:56:25] (03CR) 10Siebrand: "Waiting for Niklas to comment, Andy. I just asked him to review in a PM." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110143 (owner: 10AndyRussG) [08:06:43] Oh my https://gerrit.googlecode.com/issues/attachment?aid=23510000000&name=capture.png&token=k3M15_IqGFjZpqUBCCM6cO8jnjI%3A1391673878129&inline=1 [08:13:50] (03CR) 10Nikerabbit: No undeletion of courses of deleted institutions (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110143 (owner: 10AndyRussG) [08:22:44] (03CR) 10Siebrand: "Because it's in https://gerrit.wikimedia.org/r/#/c/105177/ ?" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/105150 (owner: 10Siebrand) [08:24:30] (03PS1) 10Parent5446: Added more filter options to $wgRCFeeds [core] - 10https://gerrit.wikimedia.org/r/111736 [08:27:15] (03PS2) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/111431 [08:27:41] (03CR) 10Siebrand: Update formatting (034 comments) [core] - 10https://gerrit.wikimedia.org/r/111431 (owner: 10Siebrand) [08:28:10] Aaron Schulz is on west-coast time, right? [08:28:40] (03CR) 10Gilles: [C: 031] Return jqXHR from mw.Api calls [core] - 10https://gerrit.wikimedia.org/r/111704 (owner: 10Gergő Tisza) [08:28:59] freakolowsky: yes, but he was sick today :( [08:29:12] oh ... bummer ... [08:29:51] he's usually good about following up if you add him as a reviewer though [08:30:21] (03CR) 10Parent5446: [C: 032] Update formatting [core] - 10https://gerrit.wikimedia.org/r/111431 (owner: 10Siebrand) [08:30:23] nah ... just need to ask him sth about the upsert function in Database.php [08:30:39] email then? [08:30:47] I think Siebrand would like this https://code.google.com/p/gerrit/issues/detail?id=1487 [08:32:09] (03CR) 10Siebrand: [C: 032 V: 032] Remove unused $wgTitles [extensions/News] - 10https://gerrit.wikimedia.org/r/111492 (owner: 10Chad) [08:33:52] (03Merged) 10jenkins-bot: Update formatting [core] - 10https://gerrit.wikimedia.org/r/111431 (owner: 10Siebrand) [08:34:08] (03CR) 10Mattflaschen: "It works, but I haven't yet tried alternate category names due to the issues inline." (036 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111459 (owner: 10Phuedx) [08:34:16] (03CR) 10Mattflaschen: [C: 04-1] Refactor task configuration. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111459 (owner: 10Phuedx) [08:35:15] (03CR) 10Siebrand: [C: 032 V: 032] Once again, no need for $wgTitle [extensions/BreadCrumbs2] - 10https://gerrit.wikimedia.org/r/111483 (owner: 10Chad) [08:37:55] morning [08:44:16] yo Nikerabbit ... how's the weather up there ... [08:45:12] ^d: https://code.google.com/p/gerrit/issues/detail?id=93 is fixed?! :O When are we going to have it? [08:47:59] (03PS4) 10Freakolowsky: Add sequence support for upsert in DatabaseOracle [core] - 10https://gerrit.wikimedia.org/r/110991 (owner: 10Umherirrender) [08:50:03] Noted on https://bugzilla.wikimedia.org/show_bug.cgi?id=46792 [08:51:19] legoktm: enhanced rc doesn't show tags by default? [08:51:27] I don't remember? [08:51:32] apparently not [08:51:45] hmm, now how do I turn it off [08:52:35] prefs [08:52:42] ?usenewrc = 0 maybe? [08:54:04] i thought it did [08:54:21] [12:45:11 AM] ^d: https://code.google.com/p/gerrit/issues/detail?id=93 is fixed?! :O When are we going to have it? <-- switch to the new change screen in your prefs [08:54:24] I see it when I set tagfilter [08:54:50] Nemo_bis: http://cl.ly/image/0C3e1v0m1u2O [08:55:03] okay, I see tags if I turn it off [08:55:13] (03CR) 10Freakolowsky: "I tried making a merge statement, but there are just too many differences:" [core] - 10https://gerrit.wikimedia.org/r/110991 (owner: 10Umherirrender) [08:57:09] freakolowsky: nice [08:58:06] 10x ... just wish i had more time these days to poke aroud MW ... i kind of miss doing it [09:01:08] (03PS1) 10Yuvipanda: Tag wikilove edits with a revision tag [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111738 [09:01:38] legoktm: ^ :) [09:01:42] :D [09:01:46] will review momentarily [09:01:49] legoktm: thanks! :) [09:03:05] (03CR) 10Hashar: "This patch causes php maintenance/getConfiguration.php to die with a fatal error:" [core] - 10https://gerrit.wikimedia.org/r/103330 (owner: 10Aaron Schulz) [09:04:40] legoktm: aren't tags purged with the recentchanges table? [09:04:47] (03PS1) 10Hashar: Revert "Added some constants to speed up Setup.php" [core] - 10https://gerrit.wikimedia.org/r/111739 [09:04:58] yuvipanda: nope [09:05:05] they have their own table which goes with revision table [09:05:06] hmm, right. because they match to revid also [09:05:13] which is why you can filter in Special:Contribs [09:05:16] right [09:05:27] fair enough. [09:06:20] (03CR) 10jenkins-bot: [V: 04-1] Revert "Added some constants to speed up Setup.php" [core] - 10https://gerrit.wikimedia.org/r/111739 (owner: 10Hashar) [09:06:26] (03CR) 10Nuria: ">I thought Aaron was using the CheckUser table for that research, not this hashed EL data. Can you confirm?" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/110700 (owner: 10Ori.livneh) [09:07:05] (03CR) 10Hashar: [C: 032] "Failure is due to me canceling the tests jobs. Self merging since that is a revert." [core] - 10https://gerrit.wikimedia.org/r/111739 (owner: 10Hashar) [09:07:29] just got a notification from HR that i still haven't used up vacation days from 2012 ... i need a vacation ... how's Bali this time of year? [09:08:57] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111738 (owner: 10Yuvipanda) [09:08:59] Wow, in the new change view autocompletion for users even works. :) [09:10:25] (03CR) 10Siebrand: [C: 04-1] use imagemap class for HTML rendering (032 comments) [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [09:10:41] (03Merged) 10jenkins-bot: Revert "Added some constants to speed up Setup.php" [core] - 10https://gerrit.wikimedia.org/r/111739 (owner: 10Hashar) [09:12:33] Nemo_bis: new change view ? [09:12:46] I must say that the new change view has some rough edges (like ugly buttons and yellow background for inline comment, hmm) but looks much better [09:12:59] hashar: what Lego linked, http://cl.ly/image/0C3e1v0m1u2O [09:13:10] ah in Gerrit [09:13:22] I tried it a bit, but disliked some UI inconsistencies [09:13:23] hashar: second last preference in https://gerrit.wikimedia.org/r/#/settings/preferences [09:13:29] Ah I see. [09:13:45] i.e. the buttons at the top (cherry-pick, rebase...) could use some CSS tweak [09:13:46] I didn't even try it because people talked so bad about it. :P [09:13:53] I like it overall [09:13:58] I think it is fine [09:14:21] just a bit too disruptive for me to switch to it right now. Plus I would have to spend a couple hours tweaking the CSS [09:14:41] It also has some bugs with scrollbars and such, I note [09:15:02] Will probably get better in 2.9 [09:17:47] (03PS1) 10Yuvipanda: Move CSS, JS & images into a resources/ folder [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111741 [09:17:49] (03CR) 10jenkins-bot: [V: 04-1] Move CSS, JS & images into a resources/ folder [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111741 (owner: 10Yuvipanda) [09:18:29] (03PS2) 10Yuvipanda: Move CSS, JS & images into a resources/ folder [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111741 [09:19:37] legoktm: ^ trivial change [09:22:05] (03CR) 10Legoktm: Tag wikilove edits with a revision tag (031 comment) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111738 (owner: 10Yuvipanda) [09:22:31] (03CR) 10Yuvipanda: Tag wikilove edits with a revision tag (031 comment) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111738 (owner: 10Yuvipanda) [09:22:56] yuvipanda: did you check nothing broke in the resources moving? [09:23:16] legoktm: it works for me locally. [09:23:26] (03PS2) 10TTO: Allow interlanguage link prefixes that are not language codes [core] - 10https://gerrit.wikimedia.org/r/111390 [09:23:46] ok [09:24:00] (03CR) 10Legoktm: [C: 032] Move CSS, JS & images into a resources/ folder [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111741 (owner: 10Yuvipanda) [09:24:03] (03Merged) 10jenkins-bot: Move CSS, JS & images into a resources/ folder [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111741 (owner: 10Yuvipanda) [09:25:26] (03PS2) 10Yuvipanda: Tag wikilove edits with a revision tag [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111738 [09:25:29] legoktm: updated ^ [09:26:40] (03CR) 10Legoktm: Tag wikilove edits with a revision tag (031 comment) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111738 (owner: 10Yuvipanda) [09:26:43] hashar: hi, I have problem with testing extensions. https://gerrit.wikimedia.org/r/#/c/111199/ The extension PhpTags must be installed for the extension PhpTags Functions. [09:29:39] (03PS2) 10Legoktm: Turn mediawiki/skins into a meta repo of skins [skins] - 10https://gerrit.wikimedia.org/r/111700 [09:30:18] (03PS3) 10Yuvipanda: Tag wikilove edits with a revision tag [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111738 [09:30:19] legoktm: updated. [09:31:05] (03CR) 10Legoktm: [C: 032] Tag wikilove edits with a revision tag [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111738 (owner: 10Yuvipanda) [09:31:07] (03Merged) 10jenkins-bot: Tag wikilove edits with a revision tag [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111738 (owner: 10Yuvipanda) [09:31:14] legoktm: thanks! :) [09:31:18] :D [09:32:30] legoktm: should be picked up on the train, I guess :D nice [09:34:15] yuvipanda: https://meta.wikimedia.org/w/index.php?title=Tech%2FNews%2F2014%2F07&diff=7373220&oldid=7372537 [09:34:34] pastakhov: ahh dependencies :( [09:34:40] pastakhov: should have tested the jobs [09:35:04] pastakhov: the dependencies have to be defined in jenkins-job-builder-config.git repository. There is a few examples at the bottom of mediawiki-extensions.yaml [09:35:13] legoktm: woo thanks! [09:35:16] !gitweb integration/jenkins-job-builder-config.git [09:35:16] https://git.wikimedia.org/summary/?r=integration/jenkins-job-builder-config.git [09:35:55] pastakhov: for example line 535 https://git.wikimedia.org/blob/integration%2Fjenkins-job-builder-config.git/3e37a8a5594f751b2c94e9f62c6399a90367be1e/mediawiki-extensions.yaml#L535 [09:36:11] hmm, legoktm maybe have one repo for designer related features? [09:36:19] yuvipanda: I don't think that's really feasible [09:36:27] pastakhov: that defines for Capiunto the dependency Scribunto [09:36:29] popups should become a real extension [09:36:31] it's like VectorBeta, but for all skins! :P [09:36:35] hmm, fine [09:36:55] legoktm: should it be Extension:Popups? [09:36:56] pastakhov: if you need to define several dependencies, you can separate them using comma: Ext1,Ext2,Ext3 [09:36:59] yeah [09:37:00] legoktm: or Extension:NavPopups? [09:37:08] I like Popups [09:37:11] Extension:Popups [09:37:15] prtksxna: ^ ? [09:37:59] prtksxna: is the name ok with you? [09:38:10] I like popups [09:38:26] prtksxna: ok, let me get it created [09:38:41] yuvipanda: Should we call it something non-useful? Like PolarKite or something? [09:38:46] noooooooo [09:38:53] you want people to use your extension! [09:38:56] I always want to do that but people keep shooting me down [09:38:56] hehe :P [09:38:59] what, no! [09:39:02] who wants users! [09:39:11] Users will only create problems imho [09:39:30] There are no bugs without users, I say we get rid of them, I am sure I have yuvipanda's support :D [09:39:32] if you have no users, no one files bug reports, hence no bugs! [09:39:41] ...wrong button. [09:39:44] hehe :P [09:40:06] yuvipanda: Where is the patch where you are fixing the WikiLove thing? I'll fix the CSS stuff? [09:40:45] I was just going to push one more commit to NavPopups (I am still going to do it) :d [09:40:55] prtksxna: yeah, you can do it. [09:41:16] prtksxna: update your vagrant repo, do 'vagrant enable-role wikilove', 'vagrant provision' and you shall have wikilove [09:41:43] legoktm: also how will new repo make review faster? [09:42:00] yuvipanda: cuz you can self-merge in a non-deployed repo [09:42:03] xD [09:42:08] legoktm: pfft, that's cheating :P [09:42:39] plus you can merge a good chunk of it [09:42:44] then do lots of incremental fixes [09:43:19] hmm [09:43:19] true [09:43:24] repo about to be done [09:43:29] yuvipanda: wikilove is not a valid role [09:43:39] prtksxna: did you get latest vagrant master [09:44:05] * prtksxna gets the latest vagrant master [09:46:07] legoktm: prtksxna moving the popup thing to its own extension now [09:46:21] yuvipanda: Oh, do I need to do anything? [09:46:22] wait [09:46:23] one sec [09:46:38] prtksxna: hmm, you could do it all yourself :D it's not much [09:46:42] prtksxna: git clone https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups [09:46:47] prtksxna: then move appropriate files to it? [09:46:49] just regular move [09:46:52] and make a new commit [09:47:06] prtksxna: I can do it if you want. [09:47:12] Should I still keep it separated into 4 commits like it is right now? [09:47:20] yuvipanda: Also, I haven't pushed some of the recent stuff [09:47:26] prtksxna: ah, ok. [09:47:27] (03PS1) 10Legoktm: Add .gitreview [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111748 [09:47:30] prtksxna: yeah, probably [09:47:40] eh [09:47:43] the permissions are wrong [09:47:46] I can't +2 [09:47:48] legoktm: yeah, fixing [09:47:58] ok [09:48:32] yuvipanda: Just a second, I'll push some stuff out so that I don't end up stepping on my own feet! [09:48:37] prtksxna: ok! [09:51:23] hashar: so... I defined dependencies for PhpTagsFunctions. https://git.wikimedia.org/blob/integration%2Fjenkins-job-builder-config.git/3e37a8a5594f751b2c94e9f62c6399a90367be1e/mediawiki-extensions.yaml#L569 [09:52:24] hashar_: ^ but for some reason this does not work for me [09:53:15] hashar_: https://git.wikimedia.org/blob/integration%2Fjenkins-job-builder-config.git/3e37a8a5594f751b2c94e9f62c6399a90367be1e/mediawiki-extensions.yaml#L557 [09:54:02] hashar_: sorry, first link is wrong [09:54:12] yuvipanda: Is it possible that I am facing a weird caching issue? A class that exists nowhere in the code (I grep'd) is being applied to a div. I have debug=true! [09:54:25] prtksxna: what class? [09:55:07] yuvipanda: Some CSS class that I was using earlier [09:55:14] prtksxna: probably caching. [09:55:18] prtksxna: try in incognito? [09:55:46] (03CR) 10Legoktm: [C: 032 V: 032] Add .gitreview [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111748 (owner: 10Legoktm) [09:55:56] alright [09:57:08] yuvipanda: Yup! Works properly there. Any fix for non-incognito? [09:57:26] prtksxna: clear your cache? [10:00:06] hashar: are you still here? I defined dependencies for PhpTagsFunctions, but for some reason this does not work for me https://git.wikimedia.org/blob/integration%2Fjenkins-job-builder-config.git/3e37a8a5594f751b2c94e9f62c6399a90367be1e/mediawiki-extensions.yaml#L555 [10:00:13] (03Abandoned) 10Legoktm: Add .gitreview [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111748 (owner: 10Legoktm) [10:01:53] (03PS24) 10Prtksxna: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 [10:01:55] (03PS2) 10Prtksxna: Remove `title` attribute from links that have the popup [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/111715 [10:01:57] (03PS7) 10Prtksxna: Add animation to NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/110675 [10:01:59] (03PS1) 10Prtksxna: Add Triangle/Pokey to the NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/111750 [10:02:01] (03CR) 10jenkins-bot: [V: 04-1] Add animation to NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/110675 (owner: 10Prtksxna) [10:02:03] (03CR) 10jenkins-bot: [V: 04-1] Add Triangle/Pokey to the NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/111750 (owner: 10Prtksxna) [10:02:12] /o\ [10:03:30] pastakhov: internet is flapping here sorry [10:03:58] pastakhov: once the change has been made to the yaml configuration, we have to update the jobs in jenkins [10:04:03] (03CR) 10Prtksxna: "recheck" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/111750 (owner: 10Prtksxna) [10:04:21] (03CR) 10Prtksxna: "recheck" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/110675 (owner: 10Prtksxna) [10:04:27] (03PS3) 10Gilles: Add the ability to know if fullscreen is available [core] - 10https://gerrit.wikimedia.org/r/110523 [10:05:22] (03CR) 10Gilles: "Updated to match the contents of the merged pull request" [core] - 10https://gerrit.wikimedia.org/r/110523 (owner: 10Gilles) [10:07:53] hashar_: should I just wait? [10:08:16] pastakhov: what is your gerrit change # ? [10:08:34] hashar_: https://gerrit.wikimedia.org/r/#q,I4781d4f0267365f12880bf121082e9cd3b984181,n,z [10:08:54] (03PS1) 10Yuvipanda: Add COPYING file [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111751 [10:09:15] prtksxna: ^ [10:09:17] prtksxna: try merging it? [10:09:24] prtksxna: let's check permissions [10:09:52] (03CR) 10Prtksxna: [C: 032 V: 032] "Testing permissions" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111751 (owner: 10Yuvipanda) [10:10:15] prtksxna: \o/ [10:10:16] sweet [10:10:26] \o/ indeed [10:11:40] pastakhov: will try to get the job updated. Internet is very slow here :/ [10:12:34] hashar_: Thanks! [10:13:06] pastakhov: what are the dependencies already? PhpTags requiring PhpTagsFunctions ? [10:13:14] pastakhov: does PhpTagsFunctions requires PhpTags as well? [10:14:58] hashar_: PhpTags is needed for PhpTagsFunctions [10:15:46] ah it is already there [10:17:06] trying my best [10:17:16] and blaming the slow wifi network here :/ [10:18:21] (03CR) 10Nikerabbit: "Thanks for doing this. As more code starts using JSDuck, we have more example for other people to learn from." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/111624 (owner: 10MarkTraceur) [10:21:57] (03PS1) 10Yuvipanda: Base PHP Extension description files [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111753 [10:25:13] (03PS2) 10Yuvipanda: Base PHP Extension description files [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111753 [10:25:30] (03CR) 10Prtksxna: [C: 032 V: 032] "\o/" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111753 (owner: 10Yuvipanda) [10:25:54] pastakhov: the job for PhpTagsFunctions has been created without the PhpTags dependencies, sorry. It installs the dependency now but the job fails [10:26:00] pastakhov: http://integration.wikimedia.org/ci/job/mwext-PhpTagsFunctions-testextensions-master/2/consoleFull :( [10:26:18] pastakhov: there is lot of Notice: Use of undefined constant ... [10:26:43] pastakhov: we use $wgDevelopmentWarnings = true; [10:27:17] pastakhov: and there is a bunch of: PHP Warning: Wrong parameter count for print_r() in Command line code on line 0
[10:27:29] pastakhov: from /extensions/PhpTagsFunctions/tests/phpunit/PhpTagsFunctions_Array_Test.php:375 [10:27:33] hashar_: great. i will fix it [10:27:59] hashar_: thanks a lot :-) [10:28:31] I will also make it so you get tests to run for you [10:28:59] (03PS1) 10Tim Landscheidt: Fix sudo chown rule for service groups [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/111755 [10:30:26] (03PS1) 10Hashar: whitelist pastakhov [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/111757 [10:30:59] (03CR) 10Hashar: [C: 032] whitelist pastakhov [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/111757 (owner: 10Hashar) [10:31:04] (03Merged) 10jenkins-bot: whitelist pastakhov [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/111757 (owner: 10Hashar) [10:32:02] pastakhov: should be good now. Happy hacking! [10:32:28] hashar_: You're very generous :-) [10:36:46] (03CR) 10Andrew Bogott: [C: 032] Fix sudo chown rule for service groups [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/111755 (owner: 10Tim Landscheidt) [10:36:48] (03Merged) 10jenkins-bot: Fix sudo chown rule for service groups [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/111755 (owner: 10Tim Landscheidt) [10:42:35] (03PS3) 10Phuedx: Visual design tweaks. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110946 [10:42:54] (03PS1) 10Yuvipanda: Add role for Popups extension [vagrant] - 10https://gerrit.wikimedia.org/r/111760 [10:42:59] (03CR) 10jenkins-bot: [V: 04-1] Add role for Popups extension [vagrant] - 10https://gerrit.wikimedia.org/r/111760 (owner: 10Yuvipanda) [10:44:11] (03PS2) 10Yuvipanda: Add role for Popups extension [vagrant] - 10https://gerrit.wikimedia.org/r/111760 [10:44:14] (03CR) 10jenkins-bot: [V: 04-1] Add role for Popups extension [vagrant] - 10https://gerrit.wikimedia.org/r/111760 (owner: 10Yuvipanda) [10:45:08] (03PS3) 10Yuvipanda: Add role for Popups extension [vagrant] - 10https://gerrit.wikimedia.org/r/111760 [10:48:38] (03CR) 10Phuedx: "Damn!" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110946 (owner: 10Phuedx) [10:50:03] (03PS1) 10Prtksxna: Add JS/CSS resources [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111763 [10:50:10] yuvipanda: ^ [10:58:03] (03PS2) 10Prtksxna: Add JS/CSS resources [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111763 [10:58:18] (03PS4) 10KartikMistry: Update README [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/109630 [10:58:25] (03CR) 10Nikerabbit: [C: 032] Update README [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/109630 (owner: 10KartikMistry) [10:58:27] (03Merged) 10jenkins-bot: Update README [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/109630 (owner: 10KartikMistry) [10:59:50] (03CR) 10Aklapper: "Quick update: Bugzilla 4.4 upgrade planned for next Wednesday. Afterwards I am going to look at this patch. (I'm really sorry this takes s" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106757 (owner: 1001tonythomas) [11:01:16] (03CR) 10TTO: "As for MZMcBride's comment about naming schemes, I think I already answered that: consistency is the order of the day here. No need to int" [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO) [11:01:38] (03CR) 10Ori.livneh: "Needs to be carefully rebased on top of the last set of changes I made, but I'm stopping there, so it's all yours, and I think the approac" [tools/scap] - 10https://gerrit.wikimedia.org/r/111716 (owner: 10BryanDavis) [11:05:03] (03PS3) 10Prtksxna: Add JS/CSS resources [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111763 [11:11:23] (03PS1) 10Yuvipanda: Register Extension:Popups with mediawiki/extensions.git [extensions] - 10https://gerrit.wikimedia.org/r/111767 [11:11:54] (03PS1) 10Prtksxna: Add animation to Popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111768 [11:12:01] (03PS1) 10Pastakhov: fix PhpExceptionPhpTags (1.0.4) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/111769 [11:13:13] (03PS2) 10Pastakhov: fix ExceptionPhpTags (1.0.4) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/111769 [11:13:27] (03CR) 10Pastakhov: [C: 032] fix ExceptionPhpTags (1.0.4) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/111769 (owner: 10Pastakhov) [11:13:32] (03Merged) 10jenkins-bot: fix ExceptionPhpTags (1.0.4) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/111769 (owner: 10Pastakhov) [11:14:17] (03PS4) 10Pastakhov: add array and pcre functions [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/111199 [11:14:23] (03CR) 10jenkins-bot: [V: 04-1] add array and pcre functions [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/111199 (owner: 10Pastakhov) [11:17:13] (03CR) 10Hashar: [C: 04-1] "List should be sorted and each submodules MUST have "branch = .". See inline comment." (031 comment) [extensions] - 10https://gerrit.wikimedia.org/r/111767 (owner: 10Yuvipanda) [11:17:26] yuvipanda: https://gerrit.wikimedia.org/r/#/c/111767/1/.gitmodules,unified :D [11:17:34] Hello. I'd like to contribute to MediaWiki, can anybody give me any suggestions as to how I should start? [11:17:35] yuvipanda: modules need to be sorted and require branch = . [11:18:10] hashar: alright! [11:18:11] polybuildr: there is some material at https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker [11:18:48] polybuildr: some people are maintaining a virtual machine that should make it easy to start up. You will need Vagrant (virtualiaztion software) and then look at https://www.mediawiki.org/wiki/Mediawiki-vagrant :-] [11:19:11] polybuildr: make sure to hang out in #mediawiki as well :-] [11:21:07] (03CR) 10Bartosz Dziewoński: [C: 032] Add the ability to know if fullscreen is available [core] - 10https://gerrit.wikimedia.org/r/110523 (owner: 10Gilles) [11:21:08] hashar: updated [11:21:09] (03PS2) 10Yuvipanda: Register Extension:Popups with mediawiki/extensions.git [extensions] - 10https://gerrit.wikimedia.org/r/111767 [11:21:47] hashar: I tried that script first, but it also added other repos, and I just chickened out :P [11:22:43] yuvipanda: well update all extensions in a single change :] [11:22:51] hashar: one of them errored out as well [11:22:53] I run it from time to time [11:22:56] DataCommonValues or somesuch [11:22:57] :( [11:23:00] that's why I chickened out :P [11:23:09] DataCommonValues .......... [11:23:15] yet another meaningless name [11:23:36] hashar: okay, I don't see it at all this time. [11:24:52] (03Merged) 10jenkins-bot: Add the ability to know if fullscreen is available [core] - 10https://gerrit.wikimedia.org/r/110523 (owner: 10Gilles) [11:28:20] yuvipanda: my net is slow sorry [11:28:46] hashar: 'tis ok :) [11:31:51] (03PS1) 10Yuvipanda: [WIP] Make the buttons list use mw.ui buttons [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111771 [11:31:55] prtksxna: ^ [11:32:41] yuvipanda: i am trying to review the chnage [11:32:50] hashar: ok [11:33:05] (03CR) 10Hashar: [C: 032 V: 032] Register Extension:Popups with mediawiki/extensions.git [extensions] - 10https://gerrit.wikimedia.org/r/111767 (owner: 10Yuvipanda) [11:33:07] here we go [11:33:10] woo! [11:33:18] then we have to wait for the beta updating job to catch up [11:33:23] ok [11:33:41] hashar: should we wait for that to catch up before merging the medaiwiki-config change? [11:34:00] yes [11:34:05] hashar: ok! :) [11:34:07] I think :-] [11:34:18] the job status is at https://integration.wikimedia.org/dashboard/ [11:34:46] there is one to update the code / regenerate l10n, listed on the dashboard as "MW code" : https://integration.wikimedia.org/ci/job/beta-code-update/ [11:35:30] it is run every 6 minutes or so [11:35:31] another job is to update the operations/mediawiki-config.git and touch InitializeSettings.php. Listed on dashboard as "MW conf" : https://integration.wikimedia.org/ci/job/beta-mediawiki-config-update/ [11:35:39] it runs just after a change has been merged [11:35:56] so config change can land before the extension code has been pulled [11:39:52] (03PS2) 10Prtksxna: Add animation to Popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111768 [11:39:54] (03PS1) 10Prtksxna: Remove `title` attribute from links that have the popup [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111772 [11:39:56] (03PS1) 10Prtksxna: Add Triangle/Pokey to the NavigationPopups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111773 [11:43:35] (03PS1) 10KartikMistry: Do not use jargon in comment. [core] - 10https://gerrit.wikimedia.org/r/111774 [11:46:52] (03CR) 10Bartosz Dziewoński: [C: 032] Do not use jargon in comment. [core] - 10https://gerrit.wikimedia.org/r/111774 (owner: 10KartikMistry) [11:50:12] ori: around? trivial patch https://gerrit.wikimedia.org/r/#/c/111760/ [11:50:14] (03Merged) 10jenkins-bot: Do not use jargon in comment. [core] - 10https://gerrit.wikimedia.org/r/111774 (owner: 10KartikMistry) [11:51:52] (03CR) 10Yuvipanda: "Moved to the Popups extension: https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/Popups+status:open,n,z" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [11:52:05] (03Abandoned) 10Yuvipanda: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [11:52:14] (03CR) 10Yuvipanda: "Moved to the Popups extension https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/Popups+status:open,n,z" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/110675 (owner: 10Prtksxna) [11:52:22] (03Abandoned) 10Yuvipanda: Add animation to NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/110675 (owner: 10Prtksxna) [11:52:34] (03CR) 10Yuvipanda: "Moved to the popups extension https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/Popups+status:open,n,z" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/111715 (owner: 10Prtksxna) [11:52:42] (03Abandoned) 10Yuvipanda: Remove `title` attribute from links that have the popup [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/111715 (owner: 10Prtksxna) [11:52:52] (03Abandoned) 10Yuvipanda: Add Triangle/Pokey to the NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/111750 (owner: 10Prtksxna) [12:03:24] Hey, I am working on the bug https://bugzilla.wikimedia.org/show_bug.cgi?id=60574 , so can someone please help me in finding where the changes are to be made? [12:11:52] lunch time bbl [12:19:14] I need some JavaScript that redirects me to a kitten image whenever some flow-related HTML appears in my browser, suggestions? [12:20:11] (03CR) 10Siebrand: Base PHP Extension description files (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111753 (owner: 10Yuvipanda) [12:29:06] Nemo_bis: heh [12:31:12] Nemo_bis: if ( $( '.flow-newtopic-title' ).length ) location.href = 'http://www.reddit.com/r/aww'; [12:31:35] (03PS2) 10Yuvipanda: [WIP] Make the buttons list use mw.ui buttons [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111771 [12:31:35] actually, $( function () { if ( $( '.flow-newtopic-title' ).length ) location.href = 'http://www.reddit.com/r/aww'; } ); [12:42:40] (03PS3) 10Yuvipanda: [WIP] Make the list of wikilove types look like a list [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111771 [12:44:50] (03PS4) 10Yuvipanda: [WIP] Make the list of wikilove types look like a list [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111771 [12:50:55] prtksxna: also it needs a '.selected' class modifier [12:52:24] yuvipanda: Right. Please fix this gerrit thing :) [12:52:54] prtksxna: heh. [12:59:25] yuvipanda: You added the changes, should I pull? Would I be able to see the .selected class then? [12:59:36] prtksxna: there's no .selected class, we need to add one [12:59:40] prtksxna: you should pull, yeah [13:01:32] yuvipanda: Pulled, clicking on it still does nothing [13:01:40] prtksxna: refresh [13:01:48] yuvipanda: I did :O [13:01:51] (03PS5) 10Yuvipanda: [WIP] Make the list of wikilove types look like a list [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111771 [13:01:51] prtksxna: oh, wait. push didn't go through [13:01:52] doing now [13:01:54] prtksxna: try [13:01:54] now [13:03:14] (03PS1) 10Pastakhov: fix abstract static function BaseHooks::getClassName() [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/111786 [13:04:02] (03CR) 10Pastakhov: [C: 032] fix abstract static function BaseHooks::getClassName() [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/111786 (owner: 10Pastakhov) [13:04:06] yuvipanda: This would start to make a lot of sense if the selected image was colored [13:04:07] (03Merged) 10jenkins-bot: fix abstract static function BaseHooks::getClassName() [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/111786 (owner: 10Pastakhov) [13:04:15] yuvipanda: But we don't have those assets anywhere, do we? [13:04:27] prtksxna: probalby not, no [13:04:38] prtksxna: but we should probably highlight it in blue or something, no? [13:04:40] yuvipanda: So should I just make icons? [13:05:11] prtksxna: we should probably have that be a separate commit, maybe? [13:05:23] prtksxna: remember that users can swap these icons out to be whatever they want [13:05:32] prtksxna: so the design should work with whatever icons [13:05:40] (03PS5) 10Pastakhov: add array and pcre functions [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/111199 [13:05:45] MatmaRex: what if I'm in Special:Contributions, as in my case? [13:06:53] ah. well, that could prove troublesome [13:11:21] yuvipanda: Right, but we still need states for them no? [13:11:39] yuvipanda: Them being b/w isn't cool, it always looks *disabled* [13:11:41] prtksxna: ya. but we can't make everyone give us two images. [13:11:49] prtksxna: true. [13:11:57] prtksxna: but that's a separate issue from styling 'selected' state [13:11:59] yuvipanda: who is everyone? we'll just make, no? [13:12:11] prtksxna: on different wikis the things are customized to be different things [13:13:17] prtksxna: try the icon on https://he.wikipedia.org/wiki/%D7%9E%D7%A9%D7%AA%D7%9E%D7%A9:Jorm?uselang=en [13:15:36] prtksxna: they are customized per-wiki [13:20:34] prtksxna: brb [13:20:36] yuvipanda: hang? [13:20:36] yuvipanda: I won't be working till very late today, been working continuously since 0500hr [13:21:50] kk [13:24:32] (03PS1) 10Raimond Spekking: Consistency tweaks in preparation for adding extension to translatewiki.net [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111790 [13:25:48] (03CR) 10Raimond Spekking: Base PHP Extension description files (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111753 (owner: 10Yuvipanda) [13:28:45] (03CR) 10Yuvipanda: [C: 032 V: 032] Consistency tweaks in preparation for adding extension to translatewiki.net [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111790 (owner: 10Raimond Spekking) [13:29:07] prtksxna: hmm, ok [13:29:09] prtksxna: sure [13:30:24] yuvipanda: Any new builds for me to test? [13:30:55] Niharika: not yet, no :( we did make the build instructions much easier [13:31:33] yuvipanda: Okay. [13:31:43] Niharika: should have something tomorrow though :) [13:32:10] yuvipanda: :) Yay. Email it to me, I´ll reply as soon as I can. [13:33:09] Niharika: I will! [13:35:52] (03PS6) 10Yuvipanda: Make the list of wikilove types look like a list [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111771 [13:36:17] yuvipanda: For the numbers - http://pastie.org/8704875 [13:40:35] (03CR) 10Nikerabbit: [C: 032] mediawiki.util: Don't hardcode selectors in updateTooltipAccessKeys if possible [core] - 10https://gerrit.wikimedia.org/r/110377 (owner: 10Bartosz Dziewoński) [13:41:13] (03CR) 10MarkAHershberger: "ok, thought so, but when I was going through the abandoned patches, I wanted to make sure and you didn't leave any reason when abandoning " [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/105150 (owner: 10Siebrand) [13:41:49] (03CR) 10Kghbln: [C: 04-1] "I have tested the authored change and it works well. -1 since it is otherwise not possible to document this for the end-user." (032 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/109488 (owner: 10Physikerwelt) [13:44:14] (03Merged) 10jenkins-bot: mediawiki.util: Don't hardcode selectors in updateTooltipAccessKeys if possible [core] - 10https://gerrit.wikimedia.org/r/110377 (owner: 10Bartosz Dziewoński) [13:48:18] yuvipanda: Chuck icons? http://jsfiddle.net/AZz6s/ [13:51:32] yuvipanda: U+2714 ✔ heavy check mark :D [13:53:13] prtksxna: http://caniuse.com/#search=inline-block [14:01:56] (03CR) 10Physikerwelt: Introduce $wgMathValidModes to adjust the selectable math rendering modes in user preferences (032 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/109488 (owner: 10Physikerwelt) [14:05:33] (03PS2) 10Phuedx: Refactor task configuration. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111459 [14:07:22] (03PS1) 10Pastakhov: fix function with void param [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/111793 [14:07:48] (03CR) 10Pastakhov: [C: 032] fix function with void param [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/111793 (owner: 10Pastakhov) [14:07:52] (03Merged) 10jenkins-bot: fix function with void param [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/111793 (owner: 10Pastakhov) [14:09:42] (03PS6) 10Pastakhov: add array and pcre functions [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/111199 [14:10:03] (03CR) 10Hashar: "Chad, would Gerrit automatically update the submodules in mediawiki/skins.git just like it does for mediawiki/extensions.git ?" [skins] - 10https://gerrit.wikimedia.org/r/111700 (owner: 10Legoktm) [14:10:15] (03CR) 10Pastakhov: [C: 032] add array and pcre functions [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/111199 (owner: 10Pastakhov) [14:10:20] (03Merged) 10jenkins-bot: add array and pcre functions [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/111199 (owner: 10Pastakhov) [14:12:03] hashar: ^^^ gerrit works great, thanks again :-) [14:12:06] hi i am new here i want to contribute to wikipedia and mediawiki i know php and javascript so please help and guide me [14:12:18] (03PS2) 10Nullzero: API: Fix a bug to make list=allfileusages functional again [core] - 10https://gerrit.wikimedia.org/r/111734 [14:16:18] (03PS4) 10Nullzero: API: update documentation and suppress warning when parsing summary [core] - 10https://gerrit.wikimedia.org/r/108307 [14:16:20] (03CR) 10Phuedx: Refactor task configuration. (033 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111459 (owner: 10Phuedx) [14:16:41] (03PS1) 10IAlex: Put line breaks after each element in OutputPage::headElement() [core] - 10https://gerrit.wikimedia.org/r/111794 [14:17:43] arko__: there is some material at https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker [14:22:23] (03CR) 10Hashar: "So that is supposed to update VisualEditor in mediawiki/extensions.git up to commit sha1 85fa839. That is https://gerrit.wikimedia.org/r/" [extensions] - 10https://gerrit.wikimedia.org/r/111608 (owner: 10Jenkins-mwext-sync) [14:22:39] (03Abandoned) 10Hashar: Syncronize VisualEditor: 90d46cb..85fa839 [extensions] - 10https://gerrit.wikimedia.org/r/111608 (owner: 10Jenkins-mwext-sync) [14:36:14] (03CR) 10Kghbln: "Well, see my comment. I am unsure now too. I will be great if somebody of WMF points the way here. I change to 0 though I think a -1 may b" (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/109488 (owner: 10Physikerwelt) [14:36:43] (03PS1) 10Thiemo Mättig (WMDE): Avoid failing if calling the exposed function but no watch/unwatch link was found for whatever reason. [core] - 10https://gerrit.wikimedia.org/r/111796 [14:37:31] (03CR) 10jenkins-bot: [V: 04-1] Avoid failing if calling the exposed function but no watch/unwatch link was found for whatever reason. [core] - 10https://gerrit.wikimedia.org/r/111796 (owner: 10Thiemo Mättig (WMDE)) [14:38:42] (03CR) 10Bartosz Dziewoński: "I think I have already seen one patch like this, and it was finally abandoned after neither the submitter nor any of the reviewers were ab" [core] - 10https://gerrit.wikimedia.org/r/111796 (owner: 10Thiemo Mättig (WMDE)) [14:41:08] (03CR) 10Bartosz Dziewoński: "Ah, no, that patch was slightly different: https://gerrit.wikimedia.org/r/#/c/92596/" [core] - 10https://gerrit.wikimedia.org/r/111796 (owner: 10Thiemo Mättig (WMDE)) [15:01:16] (03PS2) 10Thiemo Mättig (WMDE): Avoid failing if calling the exposed function but no watch/unwatch link was found for whatever reason. [core] - 10https://gerrit.wikimedia.org/r/111796 [15:06:49] (03CR) 10Thiemo Mättig (WMDE): "Since the function is exposed and can be called from every user script it should not fail with a fatal error if we can avoid this. An exam" [core] - 10https://gerrit.wikimedia.org/r/111796 (owner: 10Thiemo Mättig (WMDE)) [15:12:13] (03PS1) 10Hashar: debian-glue: archive lintian.xml [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/111798 [15:13:55] (03CR) 10Hashar: [C: 032] debian-glue: archive lintian.xml [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/111798 (owner: 10Hashar) [15:14:12] (03Merged) 10jenkins-bot: debian-glue: archive lintian.xml [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/111798 (owner: 10Hashar) [15:18:01] (03Draft1) 1001tonythomas: Used DIRECTORY_SEPARATOR instead of '/' in GitInfo.php [core] - 10https://gerrit.wikimedia.org/r/111777 [15:23:25] (03CR) 10Anomie: [C: 032] "Looks good, works, and the dispute is resolved." [core] - 10https://gerrit.wikimedia.org/r/111001 (owner: 10Bene) [15:26:58] (03Merged) 10jenkins-bot: Add SkinTemplateGetLanguageLink hook [core] - 10https://gerrit.wikimedia.org/r/111001 (owner: 10Bene) [15:34:34] (03PS1) 10Bartosz Dziewoński: ApiQuerySiteinfo: Add prop=restrictions for protection information [core] - 10https://gerrit.wikimedia.org/r/111799 [15:41:55] (03PS3) 10Anomie: API: Fix a bug to make list=allfileusages functional again [core] - 10https://gerrit.wikimedia.org/r/111734 (owner: 10Nullzero) [15:42:05] (03CR) 10Anomie: [C: 032] API: Fix a bug to make list=allfileusages functional again [core] - 10https://gerrit.wikimedia.org/r/111734 (owner: 10Nullzero) [15:46:16] (03Merged) 10jenkins-bot: API: Fix a bug to make list=allfileusages functional again [core] - 10https://gerrit.wikimedia.org/r/111734 (owner: 10Nullzero) [15:47:50] (03CR) 10Anomie: "RELEASE-NOTES entry? Otherwise, +2." [core] - 10https://gerrit.wikimedia.org/r/111799 (owner: 10Bartosz Dziewoński) [15:48:10] MatmaRex: ^ [15:48:22] (03CR) 10Reza: "I just want to clarify that Ladsgroup wanted to say NOT using Amiri for all Arabic scripts derivative (and perhaps he agrees with this pat" [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/110174 (owner: 10Reza) [15:49:20] oh, duh [15:49:25] i forgot, was meaning to add one [15:49:26] thanks [15:50:23] anomie: "* Added prop=restrictions to API action=query&meta=siteinfo."? [15:50:33] siprop [15:51:26] ah [15:51:35] and let's expand this a bit, actually [15:51:49] (03PS2) 10Bartosz Dziewoński: ApiQuerySiteinfo: Add prop=restrictions for protection information [core] - 10https://gerrit.wikimedia.org/r/111799 [15:53:59] anomie: ^ [15:56:54] (03PS2) 10Zfilipin: cucumber.yml is no longer needed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110350 [15:57:00] (03CR) 10Cmcmahon: [C: 032] cucumber.yml is no longer needed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110350 (owner: 10Zfilipin) [15:59:27] (03PS1) 10Hashar: debian-glue: lintian for both binaries and source [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/111805 [16:07:07] (03CR) 10Legoktm: Add JS/CSS resources (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/111763 (owner: 10Prtksxna) [16:10:57] (03CR) 10Anomie: [C: 04-1] Allow interlanguage link prefixes that are not language codes (032 comments) [core] - 10https://gerrit.wikimedia.org/r/111390 (owner: 10TTO) [16:12:36] (03PS1) 10Matthias Mullie: (bug 56811) reply field for replying to tangents has wrong name in it [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111807 [16:13:43] (03CR) 10Anomie: [C: 032] Remove unused $entryPoint from Preferences::tryFormSubmit [core] - 10https://gerrit.wikimedia.org/r/110900 (owner: 10Hoo man) [16:16:08] (03CR) 10Anomie: Update formatting (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111431 (owner: 10Siebrand) [16:19:17] (03PS2) 10Zfilipin: Moved Sauce Labs browser configuration to mediawiki-selenium Ruby gem [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109913 [16:19:36] (03CR) 10Cmcmahon: [C: 032] Moved Sauce Labs browser configuration to mediawiki-selenium Ruby gem [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109913 (owner: 10Zfilipin) [16:22:20] (03Merged) 10jenkins-bot: cucumber.yml is no longer needed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110350 (owner: 10Zfilipin) [16:22:58] (03Merged) 10jenkins-bot: Moved Sauce Labs browser configuration to mediawiki-selenium Ruby gem [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109913 (owner: 10Zfilipin) [16:26:53] (03Merged) 10jenkins-bot: ApiQuerySiteinfo: Add prop=restrictions for protection information [core] - 10https://gerrit.wikimedia.org/r/111799 (owner: 10Bartosz Dziewoński) [16:28:04] (03CR) 10jenkins-bot: [V: 04-1] Remove unused $entryPoint from Preferences::tryFormSubmit [core] - 10https://gerrit.wikimedia.org/r/110900 (owner: 10Hoo man) [16:28:09] (03CR) 10Bartosz Dziewoński: [C: 031] "Requiring the user to check if the element exist also sounds reasonable to me, but I guess we can do this the jQuery way." [core] - 10https://gerrit.wikimedia.org/r/111796 (owner: 10Thiemo Mättig (WMDE)) [16:28:51] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 0d0b7b2..5ae8976 [extensions] - 10https://gerrit.wikimedia.org/r/111814 [16:28:53] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 0d0b7b2..5ae8976 [extensions] - 10https://gerrit.wikimedia.org/r/111814 (owner: 10Jenkins-mwext-sync) [16:31:00] (03CR) 10Bartosz Dziewoński: "Please check the links in the commit message before code-reviewing. The rule we currently have in our styles uses a deprecated pseudoclass" [core] - 10https://gerrit.wikimedia.org/r/110964 (owner: 10Bartosz Dziewoński) [16:32:28] (03CR) 10Bartosz Dziewoński: Cleanup search placeholder black/gray text mess (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111516 (owner: 10Jdlrobson) [16:33:05] (03CR) 10Hashar: [C: 032] debian-glue: lintian for both binaries and source [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/111805 (owner: 10Hashar) [16:33:23] (03Merged) 10jenkins-bot: debian-glue: lintian for both binaries and source [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/111805 (owner: 10Hashar) [16:33:57] (03CR) 10Bartosz Dziewoński: Fix userrights-interwiki when the 'user' table is shared (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111532 (owner: 10UltrasonicNXT) [16:42:51] * hashar waves [16:45:09] (03CR) 10Anomie: [C: 04-2] "Wanting to use Scribunto_LuaEngineTestBase without providing any Lua tests seems like a very odd use case. And this would make the more-li" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/111108 (owner: 10Hoo man) [16:46:33] (03CR) 10Anomie: "recheck" [core] - 10https://gerrit.wikimedia.org/r/110900 (owner: 10Hoo man) [16:48:12] (03CR) 10Anomie: Remove unused $entryPoint from Preferences::tryFormSubmit [core] - 10https://gerrit.wikimedia.org/r/110900 (owner: 10Hoo man) [16:48:19] (03CR) 10Anomie: [C: 032] Remove unused $entryPoint from Preferences::tryFormSubmit [core] - 10https://gerrit.wikimedia.org/r/110900 (owner: 10Hoo man) [16:51:51] (03Merged) 10jenkins-bot: Remove unused $entryPoint from Preferences::tryFormSubmit [core] - 10https://gerrit.wikimedia.org/r/110900 (owner: 10Hoo man) [16:56:41] (03PS8) 10Chad: WIP: Implement interwiki searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105986 [16:57:47] (03PS9) 10Chad: Implement interwiki searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105986 [16:59:45] (03CR) 10Anomie: [C: 032] "I hate to break BC, but this is probably for the best." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/110983 (owner: 10Jackmcbarn) [17:01:03] (03Merged) 10jenkins-bot: Remove message formats other than plain [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/110983 (owner: 10Jackmcbarn) [17:07:24] (03CR) 10Jdlrobson: Cleanup search placeholder black/gray text mess (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111516 (owner: 10Jdlrobson) [17:11:20] (03CR) 10Jdlrobson: "I'm aware exactly of what you are doing Bartosz but this CSS rule does nothing for any Firefox version I tested in browser stack. I don't " [core] - 10https://gerrit.wikimedia.org/r/110964 (owner: 10Bartosz Dziewoński) [17:18:20] (03CR) 10Bartosz Dziewoński: "Let's go back to using document.all in JS then, it still works in all browsers these days!" [core] - 10https://gerrit.wikimedia.org/r/110964 (owner: 10Bartosz Dziewoński) [17:20:54] Hey, I am a newbie. Please someone tell me how can i get a bug assigned? [17:21:15] you don't. just start working on it :) [17:21:39] jme: If you want to make it official, we can set you as the assignee, just poke one of us [17:21:43] (most people on this channel can assign bugs if it will make you happy, thought) [17:21:46] though* [17:22:53] please assign me this bug https://bugzilla.wikimedia.org/show_bug.cgi?id=60948 .I would try to resolve it. [17:23:02] 'kay [17:23:17] jme: What's your name on Bugzilla? [17:23:56] rdwrer: mehtajatin05@gmail.com is all i got.. [17:24:18] jme: Done [17:24:36] rdwrer: Thanks .. :) [17:27:24] rdwrer: I would ask you if I need some help .. [17:28:02] You could certainly try, jme_ :) I'm not very well-versed in the Translate extension. [17:29:41] rdwrer: okay will see.. thanks :) [17:29:47] (03PS1) 10EBernhardson: Properly parse out underscored parameters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111823 [17:31:35] (03PS2) 10EBernhardson: Properly parse out underscored parameters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111823 [17:31:59] (03CR) 10Matthias Mullie: [C: 032] Properly parse out underscored parameters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111823 (owner: 10EBernhardson) [17:32:07] (03Merged) 10jenkins-bot: Properly parse out underscored parameters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111823 (owner: 10EBernhardson) [17:38:00] (03PS2) 10Matthias Mullie: Move flow( 'setupEditForm' ) to base/action.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108535 [17:40:48] (03PS2) 10Matthias Mullie: Don't use .flow-container scoping - tipsy breaks out of it [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111669 [17:41:38] (03PS1) 10EBernhardson: The buttons dont need greater specificity [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111824 [17:42:15] (03Abandoned) 10EBernhardson: The buttons dont need greater specificity [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111824 (owner: 10EBernhardson) [17:42:30] (03CR) 10EBernhardson: [C: 032] Don't use .flow-container scoping - tipsy breaks out of it [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111669 (owner: 10Matthias Mullie) [17:42:38] (03Merged) 10jenkins-bot: Don't use .flow-container scoping - tipsy breaks out of it [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111669 (owner: 10Matthias Mullie) [17:45:02] MatmaRex: https://gerrit.wikimedia.org/r/#/c/111771/6? :) [17:45:04] legoktm: ^ [17:45:11] and a smaller https://gerrit.wikimedia.org/r/#/c/111825/ [17:45:22] all more - than plus :) [17:45:38] trailing whitespace -2 [17:45:47] I'l test it in a bit [17:46:21] legoktm: gah, I need to fix my setup [17:46:23] (03CR) 10EBernhardson: [C: 032] (bug 56811) reply field for replying to tangents has wrong name in it [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111807 (owner: 10Matthias Mullie) [17:46:32] (03Merged) 10jenkins-bot: (bug 56811) reply field for replying to tangents has wrong name in it [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111807 (owner: 10Matthias Mullie) [17:46:51] I need to figure out why my Flow API requests are getting screwed up [17:46:53] (03CR) 10EBernhardson: [C: 032] Whitelist action=(un)watch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111723 (owner: 10Legoktm) [17:47:02] (03CR) 10jenkins-bot: [V: 04-1] Whitelist action=(un)watch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111723 (owner: 10Legoktm) [17:48:21] (03CR) 10Chad: [C: 032 V: 032] Add .gitreview [skins] - 10https://gerrit.wikimedia.org/r/111701 (owner: 10Legoktm) [17:49:06] (03CR) 10Chad: [C: 04-1] "Yes, once the minor nitpick is fixed I mentioned." (031 comment) [skins] - 10https://gerrit.wikimedia.org/r/111700 (owner: 10Legoktm) [17:49:25] ah [17:50:07] (03PS3) 10Legoktm: Turn mediawiki/skins into a meta repo of skins [skins] - 10https://gerrit.wikimedia.org/r/111700 [17:50:21] (03PS3) 10Legoktm: Whitelist action=(un)watch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111723 [17:50:34] (03CR) 10Legoktm: [C: 032] "Per Erik's +2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111723 (owner: 10Legoktm) [17:50:42] (03Merged) 10jenkins-bot: Whitelist action=(un)watch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111723 (owner: 10Legoktm) [17:50:53] (03CR) 10Chad: [C: 032 V: 032] Turn mediawiki/skins into a meta repo of skins [skins] - 10https://gerrit.wikimedia.org/r/111700 (owner: 10Legoktm) [17:51:00] ^d: yay! [17:51:11] (03PS2) 10Legoktm: Add .gitreview [skins] - 10https://gerrit.wikimedia.org/r/111701 [17:51:17] (03CR) 10Chad: [C: 032 V: 032] Add .gitreview [skins] - 10https://gerrit.wikimedia.org/r/111701 (owner: 10Legoktm) [17:51:50] (03CR) 10BryanDavis: [C: 032] Add role for Popups extension [vagrant] - 10https://gerrit.wikimedia.org/r/111760 (owner: 10Yuvipanda) [17:51:55] (03Merged) 10jenkins-bot: Add role for Popups extension [vagrant] - 10https://gerrit.wikimedia.org/r/111760 (owner: 10Yuvipanda) [17:51:56] thanks bd808 [17:53:14] (03PS10) 10Chad: Implement interwiki searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105986 [17:53:32] (03PS7) 10Yuvipanda: Make the list of wikilove types look like a list [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111771 [17:53:34] legoktm: killed the whitespave errors [17:53:34] (03PS2) 10Yuvipanda: Make numbers use 'flat' CSS backgrounds [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111825 [17:54:04] ok, I'll take a look once I finish this flow thing [17:54:42] legoktm: woo [17:54:59] legoktm: I've another patch fixing the arrow to use css. [17:56:39] <^d> brion: I think bug 3615 is invalid now that you removed the EO conversion :) [17:56:41] (03CR) 10Jdlrobson: [C: 04-2] "I'm really not sure what document.all has to do with this." [core] - 10https://gerrit.wikimedia.org/r/110964 (owner: 10Bartosz Dziewoński) [17:57:10] ^d: well it will be once it merges :D [17:57:25] <^d> Ah ok, thought it had merged. [17:58:35] (03CR) 10Bartosz Dziewoński: "It's another deprecated technology." [core] - 10https://gerrit.wikimedia.org/r/110964 (owner: 10Bartosz Dziewoński) [18:02:06] (03PS3) 10EBernhardson: Some header content breaks out of its box [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111102 [18:02:36] (03CR) 10EBernhardson: "PS2: move ui-helper-clearfix class" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111102 (owner: 10EBernhardson) [18:02:45] (03PS4) 10EBernhardson: Some header content breaks out of its box [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111102 [18:03:06] (03PS2) 10Jdlrobson: Cleanup search placeholder black/gray text mess [core] - 10https://gerrit.wikimedia.org/r/111516 [18:03:09] (03CR) 10EBernhardson: "err, PS3 updated the clearfix location, and PS4 is the rebase" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111102 (owner: 10EBernhardson) [18:04:01] (03PS2) 10UltrasonicNXT: Fix userrights-interwiki when the 'user' table is shared [core] - 10https://gerrit.wikimedia.org/r/111532 [18:05:38] (03CR) 10jenkins-bot: [V: 04-1] Cleanup search placeholder black/gray text mess [core] - 10https://gerrit.wikimedia.org/r/111516 (owner: 10Jdlrobson) [18:05:58] (03CR) 10Jdlrobson: "recheck" [core] - 10https://gerrit.wikimedia.org/r/111516 (owner: 10Jdlrobson) [18:12:09] (03CR) 10Swalling: "@Helder If Portuguese Wikibooks is in need to better site navigation between chapters/books, using a namespace wide MediaWiki message plus" [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO) [18:12:11] (03CR) 10Manybubbles: [C: 032] "Have a merge." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105986 (owner: 10Chad) [18:12:16] (03Merged) 10jenkins-bot: Implement interwiki searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105986 (owner: 10Chad) [18:13:19] (03PS2) 10Matthias Mullie: Move flow( 'loadReplyForm' ) to base/action.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108634 [18:13:22] (03CR) 10jenkins-bot: [V: 04-1] Move flow( 'loadReplyForm' ) to base/action.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108634 (owner: 10Matthias Mullie) [18:15:54] (03CR) 10EBernhardson: [C: 032] Implement better scrolling via conditionalScroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 (owner: 10SG) [18:16:03] (03Merged) 10jenkins-bot: Implement better scrolling via conditionalScroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 (owner: 10SG) [18:16:12] (03PS3) 10Matthias Mullie: Move flow( 'loadReplyForm' ) to base/action.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108634 [18:16:15] (03PS10) 10Legoktm: [WIP] Revamp API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 [18:16:18] (03CR) 10jenkins-bot: [V: 04-1] Move flow( 'loadReplyForm' ) to base/action.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108634 (owner: 10Matthias Mullie) [18:16:21] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Revamp API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm) [18:17:36] <^d> (Merged) jenkins-bot: Implement interwiki searches [extensions/CirrusSearch] - https://gerrit.wikimedia.org/r/105986 (owner: Chad) [18:17:40] <^d> Happy days are here! [18:17:41] <^d> \o/ [18:18:50] :OOOO [18:19:23] I'm going to mark this day on at least a handful calendars [18:19:25] (03Abandoned) 10Chad: Begin indexing unexpanded text forms [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110604 (owner: 10Chad) [18:19:35] ^d: \o/. is there an API? [18:19:43] (03CR) 10Legoktm: "@Anomie: I'm going to do list=flow in a separate commit, this one is already getting too large for my liking." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm) [18:19:50] <^d> yuvipanda: I guess so? [18:19:56] oh, hmm? [18:19:59] <^d> I dunno, never seen if the search API includes the results. [18:20:03] <^d> Let's find out :) [18:21:12] <^d> yuvipanda: I don't see it in list=search right now. [18:21:19] <^d> Should be pretty easy to expose though. [18:21:20] yeah, me neuither. [18:21:23] yay! [18:21:27] yes! expose! :) [18:22:30] (03PS11) 10Legoktm: [WIP] Revamp API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 [18:22:40] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Revamp API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm) [18:22:42] <^d> yuvipanda: Bug 60975 filed so we don't forget. [18:22:47] wooo! [18:23:32] (03PS12) 10Legoktm: [WIP] Revamp API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 [18:27:30] (03CR) 10Chad: "Needs rebase. Should be safe to merge now that 1.23wmf13 has been cut." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110974 (owner: 10Manybubbles) [18:28:13] (03CR) 10EBernhardson: [C: 032] Instead of passing string, pass title revision object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111648 (owner: 10Matthias Mullie) [18:28:23] (03CR) 10EBernhardson: [C: 032] (bug 60906) Truncate content before storing event into DB [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111649 (owner: 10Matthias Mullie) [18:28:26] (03Merged) 10jenkins-bot: Instead of passing string, pass title revision object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111648 (owner: 10Matthias Mullie) [18:28:33] (03Merged) 10jenkins-bot: (bug 60906) Truncate content before storing event into DB [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111649 (owner: 10Matthias Mullie) [18:28:41] (03CR) 10EBernhardson: [C: 032] Limit mentioned users as to no fill event_extra [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111650 (owner: 10Matthias Mullie) [18:28:50] (03Merged) 10jenkins-bot: Limit mentioned users as to no fill event_extra [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111650 (owner: 10Matthias Mullie) [18:29:13] <^d> Interwiki search results in action: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Search&search=Test&fulltext=Search&profile=all&redirs=0 [18:29:23] <^d> Ping Nemo_bis, yuvipanda, etc. [18:29:32] wooo! [18:29:34] \o/ [18:29:45] omgomgomg [18:29:57] ^d: can you get rid of the interwiki prefix in front of the title? [18:30:11] <^d> We probably should. [18:30:19] <^d> The core stuff didn't change at all. [18:30:22] ^d: fuckfuckfuck that's so awesome! :D [18:30:22] <^d> It's really ugly code :p [18:30:44] will it also be able to search wikidata? [18:30:57] <^d> Eventually yeah [18:31:17] :D [18:31:22] I want pretty logos riding ponies :< [18:31:57] <^d> Nemo_bis: I'll get you ponies another day. Today you'll just have to live with interwiki searches in beta :p [18:32:21] bwaaaa [18:33:02] I'm quite confused, why 3 boxes for en.voy and 2 for en.wikt [18:33:07] <^d> I'm not sure :p [18:33:18] And for deleted pages even [18:33:39] <^d> Those links are going to prod! [18:33:42] The index on Beta probably isn't the fittest one right now [18:34:01] Ah, because of the interwiki prefixes? [18:34:08] <^d> Yeah, prefixes seem to go to prod. [18:34:21] Right, it couldn't know about servername [18:34:41] <^d> This is why we have betas :) [18:34:47] Is http://en.wikipedia.beta.wmflabs.org updated as soon as a new change is merged into MW? [18:34:54] <^d> Yeah [18:38:17] (03CR) 10Chad: "Removing -2. I don't think it's working perfectly yet, but the hooks stabled out." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/105220 (owner: 10Chad) [18:38:24] (03CR) 10Chad: Begin extending CirrusSearch schema with necessary data [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/105220 (owner: 10Chad) [18:41:28] helderwiki: mostly yes, sometimes no, the automatic deployment to beta breaks sometimes. check your version to be sure. [18:41:57] ok, thanks chrismcmahon :-) [18:42:55] helderwiki: but mostly beta has new code about 3 minutes after it is merged to the master branch, and the databases on beta are updated about every hour. [18:49:43] (03PS5) 10Isarra: Add normalize.css as an available resource in skins/common/ [core] - 10https://gerrit.wikimedia.org/r/110908 [18:49:54] do you know if there is some RTL classes put out on body for me to vary my things on? [18:50:30] (03CR) 10jenkins-bot: [V: 04-1] Add normalize.css as an available resource in skins/common/ [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [18:51:23] yuvipanda: rtl / ltr, and sitedir-rtl / sitedir-ltr [18:51:38] MatmaRex: on body? [18:51:46] yep [18:51:49] [18:51:56] MatmaRex: sweet! thanks! [19:03:49] (03PS6) 10Isarra: Add normalize.css as an available resource in skins/common/ [core] - 10https://gerrit.wikimedia.org/r/110908 [19:03:59] (03CR) 10Phuedx: [C: 032] Use mediawiki.ui.button instead of mediawiki.ui [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/111356 (owner: 10Mattflaschen) [19:04:36] (03CR) 10jenkins-bot: [V: 04-1] Add normalize.css as an available resource in skins/common/ [core] - 10https://gerrit.wikimedia.org/r/110908 (owner: 10Isarra) [19:08:18] Nemo_bis: i think you have once asked me if it's possible to make a gerrit search for changes +2d by a cetain person? [19:08:55] it apparently is [19:09:33] hm, or maybe not. [19:09:53] someone linked me to searches in the form of label:Code-Review+1,user=, but i can't get this to work now :/ [19:10:11] never heard of those [19:10:16] are they documented? [19:11:14] https://gerrit.wikimedia.org/r/Documentation/user-search.html#labels [19:11:51] (it was PleaseStand in fact) [19:11:52] magic [19:19:14] when was that added? [19:19:17] does it work in API [19:23:13] (03PS1) 10IAlex: Correct the destionation of checkLastModified debug messages [core] - 10https://gerrit.wikimedia.org/r/111833 [19:23:15] (03PS1) 10Yuvipanda: Replace arrow with CSS arrow [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111834 [19:23:34] (03PS1) 10Manybubbles: Use redirects in prefix and go searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111835 [19:34:59] (03CR) 10Umherirrender: "Another solution is to call Database::nextSequenceValue for each row, but that maybe increment the sequence very often and there is no way" [core] - 10https://gerrit.wikimedia.org/r/110991 (owner: 10Umherirrender) [19:35:52] (03PS1) 10MaxSem: Create config directory for browser tests [vagrant] - 10https://gerrit.wikimedia.org/r/111838 [19:38:50] legoktm: think you can get to wikilove in the next hour? I should go to sleep after that [19:38:56] sure [19:38:58] let me do it now [19:39:04] this flow thing isn't really making any progress [19:39:10] legoktm: heh! wheee! :) [19:39:33] legoktm: give me a couple of minutes, I'll grab some water and be back. there are 3 patches now though [19:39:37] sure [19:39:40] legoktm: there's also a vagrant wikilove role (got merged yesterday) [19:39:45] using it :D [19:44:41] (03CR) 10Umherirrender: "Bad handling, when nothing/a empty string is given to Special:Diff" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/63395 (owner: 10Jérémie Roquet) [19:45:33] legoktm: :D [19:46:29] yuvipanda: http://cl.ly/image/1D000i1c260m <-- there's a weird border around the first item [19:46:41] FF27 OSX [19:46:44] let me try another browser [19:47:31] yuvipanda: chromium is worse: http://cl.ly/image/3f3X2U3T3h0z [19:47:48] legoktm: hmm, seems to be the 'active' style [19:47:57] legoktm: click something else? see if this goes away? [19:48:28] it does [19:48:34] legoktm: let me fix [19:48:39] :D [19:48:56] legoktm: do the others :P [19:50:04] aren't they dependent? [19:50:20] legoktm: yeah, but this shouldn't affect those [19:50:23] independent fix [19:50:25] ok [19:56:45] (03PS2) 10Manybubbles: Introduce a rescore window for script scores [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110974 [19:56:54] (03CR) 10Manybubbles: "Rebased." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110974 (owner: 10Manybubbles) [19:57:59] (03CR) 10Legoktm: [C: 032] Make numbers use 'flat' CSS backgrounds [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111825 (owner: 10Yuvipanda) [20:00:04] (03CR) 10Legoktm: [C: 032] Replace arrow with CSS arrow [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111834 (owner: 10Yuvipanda) [20:00:59] (03CR) 10Freakolowsky: "The last thing you should worry about on this topic is sequence being queried too often because, that's what it's there for :D Even if you" [core] - 10https://gerrit.wikimedia.org/r/110991 (owner: 10Umherirrender) [20:02:43] legoktm: that's super annoying. setting outline: none on :active and :focus doesn't seem to work at all :| [20:02:57] :/ [20:04:35] What are you using? A button? [20:05:12] sjoerddebruin: [20:05:18] a block level a: [20:05:21] Hm… [20:06:09] (03PS3) 10Matthias Mullie: Move flow( 'setupEditForm' ) to base/action.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108535 [20:06:12] And outline none on the normal version? Not the active of focus one? [20:08:57] yuvipanda: I found something like “::-moz-focus-inner”, maybe that will work? [20:09:23] sjoerddebruin: I set it for :hover as well, that seems to work [20:09:24] weird [20:09:33] CSS is always weird. :P [20:09:59] (03PS8) 10Yuvipanda: Make the list of wikilove types look like a list [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111771 [20:10:00] legoktm: try it now? [20:10:01] (03PS2) 10Yuvipanda: Replace arrow with CSS arrow [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111834 [20:10:03] (03PS3) 10Yuvipanda: Make numbers use 'flat' CSS backgrounds [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111825 [20:10:25] Wikilove really needs a styling update. :P [20:11:08] sjoerddebruin: it looks like https://www.dropbox.com/s/ez3x8lliew37f2a/Screenshot%202014-02-06%2023.12.29.png with the styling fixes :) [20:11:20] :D [20:11:22] (looks like https://www.dropbox.com/s/mdx7frtablxebiy/Screenshot%202014-02-06%2023.12.45.png now) [20:11:37] Yeah, ugly imo. [20:11:41] (The last one) [20:11:45] sjoerddebruin: yeah. [20:11:50] sjoerddebruin: the new one looks a bit better, I'd say [20:11:55] at the least :) [20:11:58] But not perfect yet. [20:11:59] woo! [20:12:20] sjoerddebruin: heh, yeah. I need to redo the form to also be an 'agora' form, but that is probably a bit more work [20:12:32] Oh, yeah. [20:12:44] sjoerddebruin: and swap out jquery.ui dialog for something else [20:12:44] (03CR) 10Legoktm: [C: 032] "Yay!" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111771 (owner: 10Yuvipanda) [20:12:46] (03Merged) 10jenkins-bot: Make the list of wikilove types look like a list [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111771 (owner: 10Yuvipanda) [20:12:48] :) [20:12:51] legoktm: worked for you? [20:12:52] wheee! [20:12:56] yup [20:13:02] legoktm: although having to set it up on :hover was a bit absurd [20:13:23] legoktm: you need to hit +2 on the other two again :P [20:13:30] yuvipanda: Do you also test it on a iOS-device? [20:13:31] (03CR) 10Legoktm: [C: 032] Make numbers use 'flat' CSS backgrounds [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111825 (owner: 10Yuvipanda) [20:13:33] (03Merged) 10jenkins-bot: Make numbers use 'flat' CSS backgrounds [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111825 (owner: 10Yuvipanda) [20:13:38] (03CR) 10Legoktm: [C: 032] Replace arrow with CSS arrow [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111834 (owner: 10Yuvipanda) [20:13:39] Weird behavior sometimes. [20:13:40] (03Merged) 10jenkins-bot: Replace arrow with CSS arrow [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111834 (owner: 10Yuvipanda) [20:13:46] sjoerddebruin: what, wikilove? [20:13:51] Yeah. [20:13:58] sjoerddebruin: I don't think most parts of mediawiki Vector are tested on mobile :) [20:14:13] It’s so easy on OS X. -_- [20:14:46] Brrrr [20:14:52] https://www.dropbox.com/s/kb7nl5sd16pg2o3/Screenshot%202014-02-06%2021.14.49.png [20:15:09] Needs a “-webkit-appearance:none;” [20:15:11] sjoerddebruin: heh, sounds fancy :P [20:15:17] err [20:15:18] looks [20:15:23] sjoerddebruin: are you talking about the 'login' [20:15:30] ? [20:15:37] button [20:15:40] in the screencap? [20:15:41] Yes. [20:15:46] hmm, right [20:16:04] “-webkit-appearance:none;” and resetting the border-radius works. [20:16:21] sjoerddebruin: looks okay to me... [20:16:31] sjoerddebruin: https://www.dropbox.com/s/3hblkl3hjdz1wka/Screenshot%202014-02-07%2001.46.31.png [20:16:42] What are you using? [20:16:48] chrome os x [20:16:54] This is Safari on iOS [20:17:01] aaaah [20:17:10] sjoerddebruin: as I said, nobody tests things on iOS for the desktop site ;) [20:17:15] sjoerddebruin: you should probably file a bug [20:17:16] Ugh... [20:17:40] “Log in looks horrible on iOS”? [20:18:18] Skin and page rendering, yuvipanda? [20:18:36] sjoerddebruin: hmm, probably. [20:18:40] attach the screenshot too [20:18:45] Yup. [20:19:18] yuvipanda: https://meta.wikimedia.org/w/index.php?title=Tech%2FNews%2F2014%2F07&diff=7380906&oldid=7379414 [20:19:36] legoktm: woo! [20:19:43] James_F: ^ (before/after screenshots :) ) [20:19:52] legoktm: although I guess they shouldn't be on dropbox... :) [20:19:56] ideally [20:20:00] hehe [20:20:06] I was hoping odder would take care of that for us [20:20:11] heh, probably woudl [20:20:14] because he's awesome [20:20:16] *would [20:20:17] yeah [20:21:03] legoktm: hmm, I could replace jQuery.ui dialog with an experimental oojs one next, or maybe split the code out some more to have a smaller first-load load [20:21:22] I think the latter would be best [20:21:31] I would have to do both anyway [20:21:32] yuvipanda: Lovely. :-) [20:21:42] yuvipanda: Both. [20:21:47] yuvipanda: Smaller load == good. [20:22:00] yeah, and getting rid of jQuery.UI would also give us a smaller load [20:22:12] no point getting rid of jquery.localize, I think [20:22:12] ++ [20:22:25] it also has its own custom logging thing that should be replaced with EventLogging [20:22:50] yuvipanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=60980 [20:22:58] sweet. thanks, sjoerddebruin :) [20:23:15] I’ve set it on minor, because it’s not a big issue. [20:23:22] sjoerddebruin: although, usually it 'just works', since os x safari and iOS safari share a fair bit of code/quirks [20:23:38] Yeah, but iOS adds some basic styling to buttons. [20:23:41] right [20:24:42] James_F: I read through the oojs-ui docs. It has a softish dependency on VE :( [20:24:48] James_F: has any other non-VE extension used it yet? [20:24:49] yuvipanda: It does? [20:24:58] yuvipanda: Yes, ish. [20:25:06] yuvipanda: Ask TrevorParscal (timing). [20:25:07] James_F: yeah, the docs say so at least. you have to have VE installed for the modules to be available [20:25:16] heh :D [20:25:29] James_F: I thought you were talking about NavigationTiming there and was confused as that has almost no UI [20:26:53] James_F: specifically, 'require_once("$IP/extensions/VisualEditor/VisualEditor.php"); in LocalSettings.php (until the module is in core).' [20:28:10] yuvipanda: “-webkit-appearance:none;” is enough, I think. [20:28:17] https://www.dropbox.com/s/4wzx5inyj3dudg3/Screenshot%202014-02-06%2021.28.15.png [20:28:47] sjoerddebruin: make a patch? :) [20:28:52] Me? :P [20:29:13] I love the iOS Simulator. :) [20:29:14] sjoerddebruin: yes, you! :) [20:30:06] yuvipanda: I think flow is using some oojs thingy [20:30:16] legoktm: oh? OOJS or OOJS-UI? [20:30:34] or not [20:30:38] km-mpb:Flow km$ ack "oojs" [20:30:39] nothing :( [20:30:44] Ah, you use border-box. :D [20:30:46] I heard something about it [20:30:55] didnt fully read the email :P [20:31:02] legoktm: :P [20:32:26] yuvipanda: Oh, that's outdated. [20:32:54] James_F: ah! [20:33:34] But yuvipanda, I don’t think I can help you. :O [20:33:46] I’m not a MediaWiki-dev, you see. [20:35:24] sjoerddebruin: everyone can become one, y'know :) [20:36:04] I’ve never worked in teams. :( [20:36:28] yuvipanda: Actually, https://gerrit.wikimedia.org/r/#/c/98887/ isn't merged yet. Ignore me. [20:37:27] James_F: looks a bit... stale as well :( [20:43:32] <^d> AaronSchulz: https://gerrit.wikimedia.org/r/#/c/111535/ [20:45:31] why not 'protected'? [20:45:45] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 5ae8976..b267161 [extensions] - 10https://gerrit.wikimedia.org/r/111887 [20:45:47] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 5ae8976..b267161 [extensions] - 10https://gerrit.wikimedia.org/r/111887 (owner: 10Jenkins-mwext-sync) [20:46:05] James_F: didn't you make a patch to ignore ^ [20:46:06] ? [20:46:42] <^d> AaronSchulz: I prefer least exposure. Unless it's needed to be protected for some reason. [20:47:26] so a subclass will never want to call that? [20:48:40] <^d> Well, they shouldn't be. [20:48:42] <^d> It was @private [20:49:00] (03PS1) 10Yuvipanda: Ignore messages from the VE sync bot [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/111889 [20:49:04] (03PS2) 10Manybubbles: Use redirects in prefix and go searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111835 [20:49:06] yeah but nobody follows those comments [20:49:14] I'd be fine making it protected [20:49:17] which is probably good enough [20:49:50] (03PS2) 10Jforrester: Suppress updates to mediawiki/extensions [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/110830 [20:50:11] (03Abandoned) 10Yuvipanda: Suppress updates to mediawiki/extensions [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/110830 (owner: 10Jforrester) [20:56:13] (03CR) 10Aaron Schulz: [C: 032] Remove stubiness from AuthPlugin [core] - 10https://gerrit.wikimedia.org/r/110587 (owner: 10Chad) [20:56:16] (03PS2) 10Welterkj: use UNIX EOL for i18n file [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 [20:56:52] (03CR) 10jenkins-bot: [V: 04-1] Remove stubiness from AuthPlugin [core] - 10https://gerrit.wikimedia.org/r/110587 (owner: 10Chad) [21:00:47] (03PS1) 10EBernhardson: Invalid passed arguments should be catchable, not fatal [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111891 [21:01:01] (03PS2) 10EBernhardson: Invalid passed arguments should be catchable, not fatal [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111891 [21:02:02] yuvipanda: Hope you haven't broken grrrrrrrrrrrrrrit with that change. :-) [21:02:19] James_F: heh, I want someone who isn't sleepy to merge it :) That is not me :P [21:02:24] James_F: you should poke legoktm [21:02:25] * James_F grins. [21:02:32] legoktm: *poke* [21:02:42] hold on, echo is fataling [21:04:04] (03CR) 10Legoktm: [C: 032] Invalid passed arguments should be catchable, not fatal [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111891 (owner: 10EBernhardson) [21:04:11] (03Merged) 10jenkins-bot: Invalid passed arguments should be catchable, not fatal [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111891 (owner: 10EBernhardson) [21:04:39] (03PS1) 10Legoktm: Invalid passed arguments should be catchable, not fatal [extensions/Echo] (wmf/1.22wmf11) - 10https://gerrit.wikimedia.org/r/111892 [21:04:43] * ebernhardson wishes php would follow hhvm's lead and make null->foo() and 'blergh'->foo() catchable errors [21:05:16] (03PS1) 10Legoktm: Invalid passed arguments should be catchable, not fatal [extensions/Echo] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111893 [21:05:20] (03PS4) 10Matthias Mullie: Move flow( 'loadReplyForm' ) to base/action.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108634 [21:05:36] (03PS1) 10Legoktm: Invalid passed arguments should be catchable, not fatal [extensions/Echo] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111894 [21:05:48] hmm [21:06:16] hmm, it should just be 12 and 13 i think? [21:06:39] legoktm: ^ [21:06:45] no [21:06:49] 11 is live on wikipedias [21:06:57] the 12 deploy got rollbacked [21:07:00] oh, ok [21:22:16] (03PS1) 10EBernhardson: Be more defensive with data from echo events [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111896 [21:22:44] (03PS3) 10Welterkj: use imagemap class for HTML rendering [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 [21:22:51] (03CR) 10Mattflaschen: "Pau said that since it will use the new Agora style (e.g. bevel), we should remove the gradients. Correct me if I misunderstood." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111144 (owner: 10Mattflaschen) [21:23:06] ^d: zat work? how can I check? [21:23:21] <^d> Amgine: Hm? [21:23:36] search sister projects [21:23:54] (03CR) 10Legoktm: Be more defensive with data from echo events (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111896 (owner: 10EBernhardson) [21:23:57] <^d> Ah, yeah it's enabled on beta labs. [21:24:03] <^d> http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special%3ASearch&profile=default&search=Test&fulltext=Search - for example. [21:24:13] <^d> There's some obvious kinks we need to work out. [21:24:41] [21:25:26] <^d> Even if it's wonky and wrong right now, I'm glad to actually see it live somewhere other than my localhost :) [21:25:56] [21:27:50] heh, only wikivoyage is found when searching for 'flatulence'. So I'm assuming this is using wikidata's interwiki, which doesn't find anything on the wiktionaries. [21:28:29] (03CR) 10Welterkj: "I implemented Siebrand's suggestions in patch 2:" [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [21:29:08] (03PS1) 10Chad: Obvious oversight: make interwiki cache time configurable [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111897 [21:29:20] (03CR) 10Chad: [C: 032] Obvious oversight: make interwiki cache time configurable [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111897 (owner: 10Chad) [21:29:25] (03Merged) 10jenkins-bot: Obvious oversight: make interwiki cache time configurable [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111897 (owner: 10Chad) [21:30:04] (03PS1) 10Chad: Followup. Pressed save + merge too fast [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111898 [21:30:25] (03PS2) 10Chad: Followup. Pressed save + merge too fast [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111898 [21:30:52] (03CR) 10Chad: [C: 032] Followup. Pressed save + merge too fast [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111898 (owner: 10Chad) [21:30:55] (03Abandoned) 10Welterkj: use imagemap class for HTML rendering [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [21:30:57] (03Merged) 10jenkins-bot: Followup. Pressed save + merge too fast [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111898 (owner: 10Chad) [21:31:06] <^d> Amgine: Ah, that might explain some things! [21:31:18] <^d> I was wondering why we were seeing multiple results for some wikis and none for others. [21:31:22] <^d> I hadn't debugged yet. [21:32:07] We should ask the wikidata folk which projects aren't yet covered by their interwiki system. [21:32:54] (03Restored) 10Welterkj: use imagemap class for HTML rendering [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 (owner: 10Welterkj) [21:41:11] (03PS1) 10Chad: Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79ff36fdeb1 [core] - 10https://gerrit.wikimedia.org/r/111900 [21:41:47] ^d: ^ is on the wrong branch [21:42:08] (03Abandoned) 10Chad: Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79ff36fdeb1 [core] - 10https://gerrit.wikimedia.org/r/111900 (owner: 10Chad) [21:42:44] (03PS1) 10Chad: Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79ff36fdeb1 [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111901 [21:43:14] <^d> legoktm: Thanks. [21:43:18] :) [21:43:39] (03PS2) 10EBernhardson: Be more defensive with data from echo events [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111896 [21:44:29] (03PS3) 10Matthias Mullie: Alternative way of dealing with edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108635 [21:48:06] (03CR) 10Mattflaschen: [C: 04-1] "It doesn't work." (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111459 (owner: 10Phuedx) [21:48:29] (03CR) 10Matthias Mullie: [C: 032] Some header content breaks out of its box [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111102 (owner: 10EBernhardson) [21:49:46] Reedy: ping [21:49:57] Hi [21:50:14] I saw a lot of bug messages [21:50:21] We saw a lot of errors [21:50:49] Including cluster outages due to number of texvccheck processes running on apaches [21:51:05] (03PS1) 10Chad: Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79ff36fdeb1 [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111903 [21:51:07] do you think it's because of the change in the chache keys [21:51:20] Seems likely [21:52:03] (03PS1) 10Matthias Mullie: Fix spelling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111904 [21:53:12] (03CR) 10Mattflaschen: "Fixed the inline one, not tested yet." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111459 (owner: 10Phuedx) [21:53:50] yes I think the problem is that all pages need to be regenerated at the same time [21:54:02] (03CR) 10Chad: [C: 032 V: 032] Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79ff36fdeb1 [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111901 (owner: 10Chad) [21:54:11] (03CR) 10Chad: [C: 032 V: 032] Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79ff36fdeb1 [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111903 (owner: 10Chad) [21:54:23] (03CR) 10Matthias Mullie: Be more defensive with data from echo events (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111896 (owner: 10EBernhardson) [21:55:26] (03CR) 10EBernhardson: Be more defensive with data from echo events (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111896 (owner: 10EBernhardson) [21:55:36] <^d> physikerwelt: I think there were some problems with https://gerrit.wikimedia.org/r/#/c/104991/ in terms of deployment. [21:55:53] <^d> We had some downtime today, and it's looking like this change might have been at fault. [21:56:24] I would strongly perfer to move to the new math version of the math extension in one step [21:57:10] <^d> Well I don't think that would've made a difference here. [21:57:14] (03Merged) 10jenkins-bot: Some header content breaks out of its box [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111102 (owner: 10EBernhardson) [21:57:33] <^d> Since we changed the page hash, it caused mass cache invalidations. [21:58:05] but than the it has to be deployed only once [21:58:22] (03CR) 10Matthias Mullie: [C: 032] "Indeed ^^" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111896 (owner: 10EBernhardson) [21:58:34] <^d> physikerwelt: Yes, but I don't think anyone was aware the change was coming. [21:58:38] <^d> It looks self-merged :\ [21:59:11] now we need to deploy each change seperately and each change will cause the same not really unexpected [21:59:16] trouble [22:01:02] (03CR) 10BryanDavis: [C: 032] Create config directory for browser tests [vagrant] - 10https://gerrit.wikimedia.org/r/111838 (owner: 10MaxSem) [22:01:16] (03PS1) 10IAlex: Allow to disable specific groups in $wgDebugLogGroups [core] - 10https://gerrit.wikimedia.org/r/111906 [22:01:33] <^d> physikerwelt: Well for now we had to revert Math to the version in 1.23wmf11 for the time being. [22:01:47] <^d> (The deployed version, that is) [22:03:13] ^d: I have send a mail to wikitech that this will happen [22:03:30] (03Merged) 10jenkins-bot: Be more defensive with data from echo events [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111896 (owner: 10EBernhardson) [22:03:37] (03Merged) 10jenkins-bot: Create config directory for browser tests [vagrant] - 10https://gerrit.wikimedia.org/r/111838 (owner: 10MaxSem) [22:06:20] <^d> physikerwelt: I see the copy you forwarded to me. [22:06:54] physikerwelt: are you subscribed to wikitech too? if you're not, it will silently reject mail [22:07:00] i've complained about this before. [22:07:02] � [22:07:15] <^d> I see no such message in the wikitech-l archives. [22:07:41] ok probably I used the wrong sender [22:07:42] I see other messages from you physikerwelt [22:08:09] <^d> I'm forwarding it to wikitech-l now. [22:09:21] <^d> http://lists.wikimedia.org/pipermail/wikitech-l/2014-February/074321.html - here's the message everyone [22:09:44] (03CR) 10Matthias Mullie: [C: 032] Use context instead of global [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111724 (owner: 10Legoktm) [22:09:54] (03Merged) 10jenkins-bot: Use context instead of global [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111724 (owner: 10Legoktm) [22:10:38] <^d> "I expect that this will influence the performance of the the wmf system in a negative way, but I cannot decide how negative that will be." [22:10:52] <^d> Heh, a pretty negative way. This needs to be scheduled and rolled out slowly, probably. [22:10:56] <^d> :) [22:11:22] Did you revert https://gerrit.wikimedia.org/r/#/c/108490/ as well [22:11:37] because the old version tries to call getMath [22:11:38] Math related [22:11:39] [22:10:57] Error on https://meta.wikimedia.org/wiki/User_talk:PiRSquared17 [22:11:39] [22:11:04] https://www.irccloud.com/pastebin/gq7JA31J [22:11:45] lol [22:11:58] so I think you reverted the wrong patch [22:12:19] 960 PHP Fatal error: Call to undefined method ParserOptions::getMath() in /usr/local/apache/common-local/php-1.23wmf12/extensions/Math/Math.hooks.php on line 50 [22:12:20] Ouch [22:12:22] because the change is designed to wok with the old and the new cache keys [22:12:34] <^d> Well fuck. [22:13:19] (03CR) 10Matthias Mullie: [C: 032] Use the context we have instead of RequestContext::getMain() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111722 (owner: 10Legoktm) [22:13:33] (03Merged) 10jenkins-bot: Use the context we have instead of RequestContext::getMain() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111722 (owner: 10Legoktm) [22:15:08] (03CR) 10Matthias Mullie: "Even if not yet going through with the proper fix, I'd still prefer to change the current header overrides to vector-specific (skinStyles)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111402 (owner: 10Legoktm) [22:16:14] <^d> physikerwelt: You're right, I had to revert the revert. [22:17:27] I feel sorry I did not find an adequate way to modell inter repository dependencies in gerrit [22:21:06] but again...I think there are more changes that require a continuous roll out and I think it would be easier to those changes only once [22:28:24] ^d: did you revert https://gerrit.wikimedia.org/r/#/c/108490/ [22:28:43] <^d> I put it back in place. [22:29:56] (03PS1) 10Chad: Revert "Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79ff36fdeb1" [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111910 [22:30:12] (03PS1) 10Chad: Revert "Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79ff36fdeb1" [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111911 [22:30:21] (03CR) 10Chad: [C: 032 V: 032] Revert "Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79ff36fdeb1" [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111910 (owner: 10Chad) [22:30:31] (03CR) 10Chad: [C: 032 V: 032] Revert "Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79ff36fdeb1" [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111911 (owner: 10Chad) [22:31:24] You might consider to revert https://gerrit.wikimedia.org/r/#/c/108490/ [22:33:20] look at the Math.hooks.php ... it checks if ( ! is_callable( 'ParserOptions::getMath' ) ... [22:33:57] in that case it would not generate new cache keys [22:33:59] Hey. Are thanks-messages new to the IRC rc-feed? [22:37:01] <^d> physikerwelt: I think we'll be fine now. [22:37:08] <^d> I think we evicted most everything already ;-) [22:40:03] sjoerddebruin: yes :) [22:40:12] Nice. [22:40:22] https://gerrit.wikimedia.org/r/#/c/99619/ specifically [22:41:00] Was it added today? [22:41:48] legoktm: ^ [22:41:57] it got deployed today I think [22:42:05] :) [22:42:53] It needs a link to the thanked edit IMO. [22:44:17] ^d: if the load due to texvccheck is too high you can disable it [22:44:49] <^d> What I think we should do is wrap it in PoolCounter :) [22:45:13] <^d> Like we do with search & page rendering. [22:46:37] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: b267161..2598fe8 [extensions] - 10https://gerrit.wikimedia.org/r/111915 [22:46:39] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: b267161..2598fe8 [extensions] - 10https://gerrit.wikimedia.org/r/111915 (owner: 10Jenkins-mwext-sync) [22:48:08] legoktm: Can you do a grrrit re-deploy? [22:48:13] ah [22:48:13] right [22:48:14] sure [22:48:26] Oh, and merge. [22:48:32] https://gerrit.wikimedia.org/r/#/c/111889/ [22:48:53] (03CR) 10Legoktm: [C: 032] Ignore messages from the VE sync bot [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/111889 (owner: 10Yuvipanda) [22:48:56] (03CR) 10Jforrester: [C: 032] Ignore messages from the VE sync bot [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/111889 (owner: 10Yuvipanda) [22:48:58] * James_F thought Yuvi had merged. [22:49:00] Ha. :-) [22:49:34] should I just add you to the account on labs? [22:49:52] deploying right now though [22:50:07] legoktm: That might be worth doing, yeah. [22:50:34] greg-g: Can I grab an LD slot for Krinkle for a couple of VE back-ports? [22:50:45] James_F: yeah, what are they? [22:51:20] greg-g: https://gerrit.wikimedia.org/r/#/c/111912 to wmf13 to un-break Mobile VE. [22:51:52] James_F: are you in the tools project? [22:51:55] greg-g: And https://gerrit.wikimedia.org/r/#/c/111697/ from Roan from last night for which we didn't get an LD slot for wmf12. [22:52:39] legoktm: No. [22:52:48] James_F: ok, we need someone to add you to that first [22:53:00] legoktm: Great. :-( [22:53:54] James_F: yep yep [22:54:25] (03PS1) 10Chad: WIP: Wrap texvc call in PoolCounter [extensions/Math] - 10https://gerrit.wikimedia.org/r/111916 [22:55:08] (03PS3) 10Mattflaschen: Refactor task configuration. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111459 (owner: 10Phuedx) [22:55:26] greg-g: Want me to add to the calendar? [22:55:46] (03PS13) 10Legoktm: [WIP] Revamp API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 [22:55:52] James_F: if you would be so kind [22:57:16] greg-g: {{done}} [22:57:16] https://www.mediawiki.org/wiki/Template:done [22:58:02] ty [22:58:04] haha [22:58:11] thanks wm-bot [22:58:12] Hey greg-g, you are welcome! [22:58:49] * James_F grins. [23:00:08] 43 PHP Fatal error: Class 'MathInputCheckTexvc' not found in /usr/local/apache/common-local/php-1.23wmf12/extensions/Math/MathRenderer.php on line 435 [23:00:18] (03PS2) 10Legoktm: Only style header in Vector skin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111402 [23:00:27] (03CR) 10Physikerwelt: "maybe we can to that for texvccheck... and it creates a dependency to https://wikitech.wikimedia.org/wiki/PoolCounter which is bad for non" [extensions/Math] - 10https://gerrit.wikimedia.org/r/111916 (owner: 10Chad) [23:02:10] Reedy: where does that come from? [23:02:21] it's in the apache syslogs [23:02:40] hmm [23:02:41] (03CR) 10Mattflaschen: [C: 032] "Looks good. I tested it pretty extensively locally, with both standard and customized categories." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111459 (owner: 10Phuedx) [23:02:43] (03Merged) 10jenkins-bot: Refactor task configuration. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111459 (owner: 10Phuedx) [23:02:43] seems it may just be one apache [23:03:45] maybe the change in Math.php is missing there [23:04:32] (03PS1) 10Krinkle: Clean up HTML and lint errors [integration/docroot] - 10https://gerrit.wikimedia.org/r/111921 [23:05:50] (03PS2) 10Krinkle: Clean up HTML and lint errors [integration/docroot] - 10https://gerrit.wikimedia.org/r/111921 [23:06:04] (03CR) 10Krinkle: [C: 032] Clean up HTML and lint errors [integration/docroot] - 10https://gerrit.wikimedia.org/r/111921 (owner: 10Krinkle) [23:06:07] (03Merged) 10jenkins-bot: Clean up HTML and lint errors [integration/docroot] - 10https://gerrit.wikimedia.org/r/111921 (owner: 10Krinkle) [23:06:16] Looks to be up to date [23:06:59] (03PS1) 10EBernhardson: Catch catchable fatal errors when formatting echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111922 [23:09:38] But if MathInputCheckTexvc is in the autoload classes and is deployed on the server why was it not found? [23:10:32] (03CR) 10EBernhardson: [C: 032] Default Echo email notifications for Flow to disabled [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111708 (owner: 10Legoktm) [23:10:41] (03Merged) 10jenkins-bot: Default Echo email notifications for Flow to disabled [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111708 (owner: 10Legoktm) [23:11:29] Looks like the first one was Feb 6 22:15:54 [23:12:31] (03CR) 10Krinkle: Have mtime as calculated by startup module increase on schema change (032 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/111731 (owner: 10Mattflaschen) [23:13:53] (03PS1) 10Legoktm: Make action=history work on Flow pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111924 [23:14:18] (03CR) 10Matthias Mullie: [C: 032] Only style header in Vector skin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111402 (owner: 10Legoktm) [23:14:28] (03Merged) 10jenkins-bot: Only style header in Vector skin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111402 (owner: 10Legoktm) [23:16:50] Reedy: I don't understand how to ensure that all files are changed at once. Is that guaranteed by the deployment process? [23:21:00] (03PS2) 10IAlex: Remove stubiness from AuthPlugin [core] - 10https://gerrit.wikimedia.org/r/110587 (owner: 10Chad) [23:21:37] (03CR) 10IAlex: [C: 032] Remove stubiness from AuthPlugin [core] - 10https://gerrit.wikimedia.org/r/110587 (owner: 10Chad) [23:21:50] (03CR) 10Chad: [C: 032] Introduce a rescore window for script scores [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110974 (owner: 10Manybubbles) [23:22:56] (03Merged) 10jenkins-bot: Introduce a rescore window for script scores [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110974 (owner: 10Manybubbles) [23:24:43] (03PS2) 10MarkTraceur: Add jsduck docs to jqueryMsg [core] - 10https://gerrit.wikimedia.org/r/111676 [23:25:25] (03PS5) 10Physikerwelt: Introduce orthogonal option to enable MathJax [extensions/Math] - 10https://gerrit.wikimedia.org/r/110226 [23:26:01] (03PS8) 10Physikerwelt: Change database layout [extensions/Math] - 10https://gerrit.wikimedia.org/r/110329 [23:26:10] (03Merged) 10jenkins-bot: Remove stubiness from AuthPlugin [core] - 10https://gerrit.wikimedia.org/r/110587 (owner: 10Chad) [23:26:26] (03CR) 10Physikerwelt: "Please merge with caution." [extensions/Math] - 10https://gerrit.wikimedia.org/r/110329 (owner: 10Physikerwelt) [23:27:08] (03PS5) 10Physikerwelt: remove armourMath and wgContLang (bug 60799) [extensions/Math] - 10https://gerrit.wikimedia.org/r/111119 [23:27:59] (03PS4) 10Bsitu: Add correspond *_user_wiki field to all *_user_id fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 [23:28:14] (03PS5) 10Bsitu: Add corresponding *_user_wiki field to all *_user_id fields [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111671 [23:28:48] (03Abandoned) 10EBernhardson: Invalid passed arguments should be catchable, not fatal [extensions/Echo] (wmf/1.22wmf11) - 10https://gerrit.wikimedia.org/r/111892 (owner: 10Legoktm) [23:29:29] (03PS1) 10EBernhardson: Be more defensive with data from echo events [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111930 [23:29:41] (03PS1) 10EBernhardson: Be more defensive with data from echo events [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111931 [23:30:12] (03CR) 10EBernhardson: [C: 032] Be more defensive with data from echo events [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111931 (owner: 10EBernhardson) [23:30:23] (03Merged) 10jenkins-bot: Be more defensive with data from echo events [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111931 (owner: 10EBernhardson) [23:30:39] (03CR) 10EBernhardson: [C: 032] Be more defensive with data from echo events [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111930 (owner: 10EBernhardson) [23:30:52] (03Merged) 10jenkins-bot: Be more defensive with data from echo events [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111930 (owner: 10EBernhardson) [23:35:46] ori, hey. you around? [23:36:10] Krenair: sorta. what's up? [23:36:21] alex@alex:~/Git/wmf-vagrant (master)$ vagrant list-roles [23:36:21] /home/alex/Git/wmf-vagrant/lib/mediawiki-vagrant.rb:4:in `': undefined method `plugin' for Vagrant:Module (NoMethodError) [23:37:17] (03CR) 10Pawanseerwani: "@Nikerabbit : The supported range for datetime is '1000-01-01 00:00:00' to '9999-12-31 23:59:59'. And the range of timestamp is '1970-01-" [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [23:37:22] Krenair: what does vagrant -v say? [23:37:42] the same thing [23:37:50] in fact vagrant -anything- returns that error [23:38:42] (03PS3) 10Krinkle: Add jsduck docs to jqueryMsg [core] - 10https://gerrit.wikimedia.org/r/111676 (owner: 10MarkTraceur) [23:39:15] (03CR) 10Bsitu: [C: 032] Immediately render submitted header changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111665 (owner: 10Matthias Mullie) [23:39:18] (03CR) 10EBernhardson: [C: 032] Invalid passed arguments should be catchable, not fatal [extensions/Echo] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111893 (owner: 10Legoktm) [23:39:32] (03CR) 10EBernhardson: [C: 032] Invalid passed arguments should be catchable, not fatal [extensions/Echo] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111894 (owner: 10Legoktm) [23:39:44] (03Merged) 10jenkins-bot: Immediately render submitted header changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111665 (owner: 10Matthias Mullie) [23:39:50] (03Merged) 10jenkins-bot: Invalid passed arguments should be catchable, not fatal [extensions/Echo] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111893 (owner: 10Legoktm) [23:39:53] Krenair: chdir outside the mediawiki-vagrant directory hierarchy [23:39:54] (03Merged) 10jenkins-bot: Invalid passed arguments should be catchable, not fatal [extensions/Echo] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111894 (owner: 10Legoktm) [23:39:56] and run vagrant -v [23:40:09] Vagrant version 1.0.5 [23:40:40] (03CR) 10TTO: Allow interlanguage link prefixes that are not language codes (032 comments) [core] - 10https://gerrit.wikimedia.org/r/111390 (owner: 10TTO) [23:41:45] Krenair: that's way too old [23:42:04] Krenair: but read: http://docs.vagrantup.com/v2/installation/upgrading-from-1-0.html [23:44:03] (03PS1) 10EBernhardson: Immediately render submitted header changes [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111935 [23:44:03] Hm... Am trying to gem uninstall but apparently vagrant is not installed according to that... [23:44:11] (03CR) 10EBernhardson: [C: 032] Immediately render submitted header changes [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111935 (owner: 10EBernhardson) [23:44:21] (03Merged) 10jenkins-bot: Immediately render submitted header changes [extensions/Flow] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111935 (owner: 10EBernhardson) [23:44:41] (03CR) 10Matthias Mullie: [C: 032] Catch catchable fatal errors when formatting echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111922 (owner: 10EBernhardson) [23:44:48] (03Merged) 10jenkins-bot: Catch catchable fatal errors when formatting echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111922 (owner: 10EBernhardson) [23:46:05] (03CR) 10Bsitu: [C: 032] Fix spelling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111904 (owner: 10Matthias Mullie) [23:46:28] (03Merged) 10jenkins-bot: Fix spelling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111904 (owner: 10Matthias Mullie) [23:46:32] (03CR) 10BryanDavis: "@Physikerwelt: Default behavior of PoolCounter::factory() if $wgPoolCounterConf doesn't say otherwise is to use the PoolCounter_Stub which" [extensions/Math] - 10https://gerrit.wikimedia.org/r/111916 (owner: 10Chad) [23:46:44] (03PS1) 10EBernhardson: Catch catchable fatal errors when formatting echo notifications [extensions/Echo] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111936 [23:46:48] (03CR) 10EBernhardson: [C: 032] Catch catchable fatal errors when formatting echo notifications [extensions/Echo] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111936 (owner: 10EBernhardson) [23:47:00] (03Merged) 10jenkins-bot: Catch catchable fatal errors when formatting echo notifications [extensions/Echo] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111936 (owner: 10EBernhardson) [23:47:03] (03PS1) 10EBernhardson: Catch catchable fatal errors when formatting echo notifications [extensions/Echo] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111937 [23:47:06] (03CR) 10EBernhardson: [C: 032] Catch catchable fatal errors when formatting echo notifications [extensions/Echo] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111937 (owner: 10EBernhardson) [23:47:23] (03Merged) 10jenkins-bot: Catch catchable fatal errors when formatting echo notifications [extensions/Echo] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111937 (owner: 10EBernhardson) [23:47:30] (03PS4) 10Krinkle: Add jsduck docs to jqueryMsg [core] - 10https://gerrit.wikimedia.org/r/111676 (owner: 10MarkTraceur) [23:47:39] (03CR) 10Krinkle: Add jsduck docs to jqueryMsg (032 comments) [core] - 10https://gerrit.wikimedia.org/r/111676 (owner: 10MarkTraceur) [23:47:41] ori, so paths like /opt/vagrant/embedded/gems/gems/vagrant-1.0.5/bin/vagrant:40:in were included in the error [23:47:51] however, alex@alex:~/Git$ sudo gem uninstall vagrant-1.0.5 [23:47:51] INFO: gem "vagrant-1.0.5" is not installed [23:47:53] (03PS5) 10Krinkle: mediawiki.jqueryMsg: Add jsduck docs [core] - 10https://gerrit.wikimedia.org/r/111676 (owner: 10MarkTraceur) [23:48:05] same for just 'vagrant' (without -1.0.5) [23:48:05] Krenair: you probably have multiple versions of 'gem' [23:50:25] (03PS1) 10EBernhardson: Update Echo and Flow [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111939 [23:51:08] (03CR) 10Bsitu: Make action=history work on Flow pages (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111924 (owner: 10Legoktm) [23:53:02] ori, how can I find the right one and use it? [23:53:49] which gem [23:53:57] (03PS2) 10Chad: WIP: Wrap texvc call in PoolCounter [extensions/Math] - 10https://gerrit.wikimedia.org/r/111916 [23:56:21] Reedy, that shows the gem I am calling is in /user/bin/gem [23:56:40] same one when root? [23:56:42] (03PS1) 10EBernhardson: Update Echo and Flow [core] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/111940 [23:56:45] /sudo [23:57:56] yup.