[00:02:42] (03PS1) 10Kaldari: Follow up to Iee3765e940cfd9784c55b6a87a678e41550032a7 [extensions/VectorBeta] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111378 [00:02:55] (03CR) 10EBernhardson: [C: 032] Split up ShallowCompactor's expand; move building of queries into own method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111363 (owner: 10Matthias Mullie) [00:03:05] (03CR) 10Kaldari: [C: 032] Follow up to Iee3765e940cfd9784c55b6a87a678e41550032a7 [extensions/VectorBeta] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111378 (owner: 10Kaldari) [00:03:07] (03Merged) 10jenkins-bot: Split up ShallowCompactor's expand; move building of queries into own method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111363 (owner: 10Matthias Mullie) [00:03:10] (03Merged) 10jenkins-bot: Follow up to Iee3765e940cfd9784c55b6a87a678e41550032a7 [extensions/VectorBeta] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111378 (owner: 10Kaldari) [00:03:51] (03CR) 10BryanDavis: [C: 032 V: 032] ensure tmpfile is accessible to dsh subprocess [tools/scap] - 10https://gerrit.wikimedia.org/r/111377 (owner: 10Ori.livneh) [00:06:23] (03CR) 10Jforrester: "Sure, except that it's posting as jenkins-bot – I'm pretty sure we want to hear jenkins's V-1s." [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/110830 (owner: 10Jforrester) [00:08:26] (03PS1) 10Kaldari: Update VectorBeta [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111382 [00:08:41] (03CR) 10Kaldari: [C: 032 V: 032] Update VectorBeta [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111382 (owner: 10Kaldari) [00:10:20] (03PS1) 10Krinkle: Update VisualEditor to latest 1.23wmf11 for cherry-picks [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111383 [00:11:28] (03PS1) 10Krinkle: Update VisualEditor to latest 1.23wmf12 for cherry-picks [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111384 [00:11:57] (03CR) 10Krinkle: [C: 032] Update VisualEditor to latest 1.23wmf11 for cherry-picks [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111383 (owner: 10Krinkle) [00:12:02] (03CR) 10Krinkle: [C: 032] Update VisualEditor to latest 1.23wmf12 for cherry-picks [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111384 (owner: 10Krinkle) [00:18:27] (03Merged) 10jenkins-bot: Update VisualEditor to latest 1.23wmf11 for cherry-picks [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111383 (owner: 10Krinkle) [00:19:15] (03Merged) 10jenkins-bot: Update VisualEditor to latest 1.23wmf12 for cherry-picks [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111384 (owner: 10Krinkle) [00:23:24] (03CR) 10Kaldari: [C: 032] Copy over yet more assets [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/111376 (owner: 10Jdlrobson) [00:23:29] (03Merged) 10jenkins-bot: Copy over yet more assets [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/111376 (owner: 10Jdlrobson) [00:27:54] (03PS4) 10Alex Monk: jquery.client: Recognise Amazon Silk [core] - 10https://gerrit.wikimedia.org/r/110989 [00:29:47] (03PS3) 10Tim Starling: Maintenance script for benchmarking parse operations [core] - 10https://gerrit.wikimedia.org/r/102596 [00:36:10] (03CR) 10TTO: "> Bug 16962 also doesn't need a hook adding or altering existing language links, it just needs a (default blank) i18n message in the right" [core] - 10https://gerrit.wikimedia.org/r/110832 (owner: 10TTO) [00:38:13] TimStarling: I verified https://gerrit.wikimedia.org/r/#/c/102596/3/maintenance/benchmarks/benchmarkParse.php ; any reason not to merge? [00:38:19] (03CR) 10TTO: Add SkinTemplateGetLanguageLink hook (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111001 (owner: 10Bene) [00:39:07] you can merge it if you like [00:40:07] (03CR) 10Tim Starling: Maintenance script for benchmarking parse operations (035 comments) [core] - 10https://gerrit.wikimedia.org/r/102596 (owner: 10Tim Starling) [00:40:22] (03PS4) 10Tim Starling: Maintenance script for benchmarking parse operations [core] - 10https://gerrit.wikimedia.org/r/102596 [00:41:27] (03CR) 10Ori.livneh: [C: 032] Maintenance script for benchmarking parse operations [core] - 10https://gerrit.wikimedia.org/r/102596 (owner: 10Tim Starling) [00:41:27] 54 comments on 119 lines of basically trivial code [00:42:10] that's only 45% coverage! [00:42:28] maybe we should have held off a bit longer, to try to get up to a 1:2 ratio [00:43:07] Trailing spaces should really be considered a blocker :D [00:44:50] Heh, merged without a license. [00:45:01] (03Merged) 10jenkins-bot: Maintenance script for benchmarking parse operations [core] - 10https://gerrit.wikimedia.org/r/102596 (owner: 10Tim Starling) [00:45:21] "When type casting, do not use a space within or after the cast operator:" also a very important one... [00:54:03] (03CR) 10Hoo man: Add SkinTemplateGetLanguageLink hook (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111001 (owner: 10Bene) [00:56:14] trailing spaces annoyingly show up as red [00:56:27] we should just slap some CSS on top of gerrit to hide these [00:56:35] ^d: ^ [00:56:47] <^d> meh [00:57:20] then we can have people go through core agian and submit white space-only chagnes... [00:58:04] <^d> Or the third option is not caring about whitespace so much. [00:58:33] <^d> I guess pointing out whitespace problems is easier than actually reviewing code though. [00:58:57] they're displayed in eye-poking red [00:59:09] obviously it annoys people [00:59:30] (which is by design, i understand) [01:00:49] <^d> You can ignore that. [01:00:59] ignore what? [01:01:14] <^d> gerrit. [01:01:17] <^d> ;-) [01:03:36] (03CR) 10Matthias Mullie: [C: 04-1] Some header content breaks out of its box (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111102 (owner: 10EBernhardson) [01:05:11] (03CR) 10Matthias Mullie: [C: 032] Provide a default rc_log_type of null [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111123 (owner: 10EBernhardson) [01:05:22] (03Merged) 10jenkins-bot: Provide a default rc_log_type of null [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111123 (owner: 10EBernhardson) [01:05:27] (03CR) 10Matthias Mullie: [C: 032] Apply overflow:auto to preview [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111133 (owner: 10EBernhardson) [01:05:37] (03Merged) 10jenkins-bot: Apply overflow:auto to preview [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111133 (owner: 10EBernhardson) [01:07:16] (03CR) 10Matthias Mullie: [C: 032] Re-add historical link's to timespans [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111135 (owner: 10EBernhardson) [01:07:25] (03Merged) 10jenkins-bot: Re-add historical link's to timespans [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111135 (owner: 10EBernhardson) [01:08:27] MatmaRex: I think there's a user pref in Gerrit for showing trailing whitespace. [01:08:32] We could just tweak the default, maybe. [01:14:53] trying out benchmarkParse.php, i see that it spending almost the entirety of its time waiting( CPU time = 0.084 s, wall clock time = 3.070 s ) i'm assuming intially this is a misconfiguration in my vagrant instance, any suggestions where to start looking? [01:18:50] strace seems to suggest its pulling thumbs from commons? [01:20:37] (03CR) 10Matthias Mullie: Don't send suppression log entries to recentchanges (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111158 (owner: 10Legoktm) [01:20:42] (03PS2) 10Matthias Mullie: Don't send suppression log entries to recentchanges [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111158 (owner: 10Legoktm) [01:20:55] (03CR) 10Matthias Mullie: [C: 032] Don't send suppression log entries to recentchanges [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111158 (owner: 10Legoktm) [01:21:05] (03Merged) 10jenkins-bot: Don't send suppression log entries to recentchanges [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111158 (owner: 10Legoktm) [01:26:28] (03CR) 10Matthias Mullie: [C: 032] Use mediawiki.ui.button when mw-ui-button is used [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111334 (owner: 10Mattflaschen) [01:26:38] (03Merged) 10jenkins-bot: Use mediawiki.ui.button when mw-ui-button is used [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111334 (owner: 10Mattflaschen) [01:29:05] (03CR) 10Matthias Mullie: [C: 031] "Looks good at first sight, will do some testing tomorrow" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111354 (owner: 10EBernhardson) [01:30:18] (03CR) 10Legoktm: Add hook SpecialCheckUserGetLinksFromRow (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/111249 (owner: 10EBernhardson) [01:32:36] (03CR) 10Matthias Mullie: Add hook SpecialCheckUserGetLinksFromRow (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/111249 (owner: 10EBernhardson) [01:32:57] (03CR) 10Legoktm: Add hook SpecialCheckUserGetLinksFromRow (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/111249 (owner: 10EBernhardson) [01:34:26] (03CR) 10Matthias Mullie: [C: 032] Replace usage of deprecated Title::escapeLocalURL() [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/111344 (owner: 10EBernhardson) [01:34:29] (03Merged) 10jenkins-bot: Replace usage of deprecated Title::escapeLocalURL() [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/111344 (owner: 10EBernhardson) [01:35:04] (03CR) 10Matthias Mullie: [C: 032] Buffered cache is already hooked up to transactions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111368 (owner: 10EBernhardson) [01:35:14] (03Merged) 10jenkins-bot: Buffered cache is already hooked up to transactions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111368 (owner: 10EBernhardson) [01:36:24] (03PS4) 10EBernhardson: Add hook SpecialCheckUserGetLinksFromRow [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/111249 [01:36:35] (03CR) 10EBernhardson: Add hook SpecialCheckUserGetLinksFromRow (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/111249 (owner: 10EBernhardson) [01:37:23] (03CR) 10Matthias Mullie: Don't error out on duplicate id's (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111224 (owner: 10EBernhardson) [01:38:10] (03PS1) 10TTO: Allow interlanguage link prefixes that are not language codes [core] - 10https://gerrit.wikimedia.org/r/111390 [01:39:26] (03CR) 10TTO: "On that last point, please see https://gerrit.wikimedia.org/r/#/c/111390/" [core] - 10https://gerrit.wikimedia.org/r/110832 (owner: 10TTO) [01:42:04] (03CR) 10Matthias Mullie: Add hook SpecialCheckUserGetLinksFromRow (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/111249 (owner: 10EBernhardson) [01:47:31] Does anyone know if there's a trick to enabling UploadWizard campaigns? [01:47:40] It doesn't seem to be recognized as a namespace. [01:47:45] YuviPanda: ^ [01:47:47] I'm just trying to view the campaign page for a quick test. [01:51:50] (03PS2) 10Legoktm: Formatter for CheckUser rows [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111354 (owner: 10EBernhardson) [01:52:31] (03PS1) 10Mattflaschen: Use mediawiki.ui.button instead of mediawiki.ui [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/111393 [02:07:13] (03CR) 10Parent5446: "There were quite a number of problems in this patch that I mentioned but were not addressed. It'd be nice if existing reviewers got more t" [core] - 10https://gerrit.wikimedia.org/r/102596 (owner: 10Tim Starling) [02:08:35] (03PS1) 10Mattflaschen: Use mediawiki.ui.button instead of mediaiki.ui [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111395 [02:09:37] (03PS1) 10Kaldari: Hygiene: Whitespace fixes [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/111396 [02:11:51] (03CR) 10Bartosz Dziewoński: [C: 032] Hygiene: Whitespace fixes [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/111396 (owner: 10Kaldari) [02:11:55] (03Merged) 10jenkins-bot: Hygiene: Whitespace fixes [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/111396 (owner: 10Kaldari) [02:11:57] (03CR) 10Legoktm: Formatter for CheckUser rows (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111354 (owner: 10EBernhardson) [02:12:37] (03CR) 10MZMcBride: "Patches welcome. :-)" [core] - 10https://gerrit.wikimedia.org/r/102596 (owner: 10Tim Starling) [02:16:27] (03CR) 10Legoktm: [C: 04-1] "Gerrit managed to confuse me, so most of the comments I care about (and what the -1 is for) are on PS1, and the one I just wanted to menti" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111354 (owner: 10EBernhardson) [02:17:21] https://bugzilla.wikimedia.org/43652 [02:21:22] (03CR) 10Mattflaschen: "Based on my grepping (ack-grep --files-with-match mw-ui-button|grep extensions|cut -d/ -f 2|uniq), this covers the remaining ones on the W" [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari) [02:21:50] (03CR) 10PleaseStand: [C: 04-1] jquery.client: Recognise Amazon Silk (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110989 (owner: 10Alex Monk) [02:22:24] (03CR) 10Legoktm: [C: 032] Use mediawiki.ui.button instead of mediaiki.ui [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111395 (owner: 10Mattflaschen) [02:22:31] (03Merged) 10jenkins-bot: Use mediawiki.ui.button instead of mediaiki.ui [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111395 (owner: 10Mattflaschen) [02:23:25] (03CR) 10Legoktm: [C: 032] Use mediawiki.ui.button when mw-ui-button is used [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111341 (owner: 10Mattflaschen) [02:23:28] (03Merged) 10jenkins-bot: Use mediawiki.ui.button when mw-ui-button is used [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111341 (owner: 10Mattflaschen) [02:33:16] (03CR) 10Parent5446: "Working on a patch now, but it shouldn't be my job to fix the mistakes of others." [core] - 10https://gerrit.wikimedia.org/r/102596 (owner: 10Tim Starling) [02:33:49] smackdown! [02:37:02] (03PS1) 10Parent5446: Code, style, and doc fixes for benchmarkParse.php [core] - 10https://gerrit.wikimedia.org/r/111400 [02:37:16] double smackdown! [02:37:26] (03CR) 10Parent5446: "Follow-up: https://gerrit.wikimedia.org/r/111400" [core] - 10https://gerrit.wikimedia.org/r/102596 (owner: 10Tim Starling) [02:37:39] folks, this is how it's done. [02:37:59] O.o [02:38:48] (03PS1) 10Legoktm: Revert "mwext-GlobalPreferences-testextensions-master non voting" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/111401 [02:39:03] :| [02:39:08] (03PS2) 10Legoktm: Revert "mwext-GlobalPreferences-testextensions-master non voting" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/111401 [02:39:45] gerrit no longer leaves "reverted in foo" comments? [02:47:36] (03CR) 10TTO: "recheck" [core] - 10https://gerrit.wikimedia.org/r/111390 (owner: 10TTO) [02:49:14] (03CR) 10Ori.livneh: Code, style, and doc fixes for benchmarkParse.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111400 (owner: 10Parent5446) [02:50:02] (03CR) 10TTO: [C: 04-1] "Please use a more appropriate commit message. It should look something like this:" [core] - 10https://gerrit.wikimedia.org/r/111330 (owner: 10Adi.iiita) [02:58:48] (03PS1) 10Legoktm: Make page title readable in Modern skin [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111402 [03:00:43] (03PS2) 10Parent5446: Code, style, and doc fixes for benchmarkParse.php [core] - 10https://gerrit.wikimedia.org/r/111400 [03:04:24] (03PS1) 10Legoktm: Save 'flow-talk-taken-over' message in content language [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111403 [03:15:44] (03PS4) 10Phuedx: Stop logging with the GettingStartedOnRedirect schema. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110375 [03:22:30] (03PS1) 10Legoktm: Fix phpdoc [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111404 [03:23:10] (03CR) 10Legoktm: [C: 032] Fix phpdoc [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111404 (owner: 10Legoktm) [03:23:18] (03Merged) 10jenkins-bot: Fix phpdoc [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111404 (owner: 10Legoktm) [03:24:30] (03Abandoned) 10Legoktm: Formatter: Require any IContextSource instead of specific implementations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109487 (owner: 10Legoktm) [03:26:34] (03PS1) 10Legoktm: Use ContextSource::msg instead of wfMessage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111405 [03:35:52] (03CR) 10Swalling: [C: 031] "JS seems correct based on updated schema." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110580 (owner: 10Phuedx) [03:38:30] (03CR) 10Swalling: [C: 031] "Once the blocking deployments have happened, this seems correct class to use." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111345 (owner: 10Mattflaschen) [03:39:14] (03PS1) 10PleaseStand: Correct proportions in SVG search icon [core] - 10https://gerrit.wikimedia.org/r/111406 [03:46:34] (03CR) 10Mattflaschen: [C: 032] "Looks good, tested locally. Nice to clear out some old code." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110375 (owner: 10Phuedx) [03:46:39] (03Merged) 10jenkins-bot: Stop logging with the GettingStartedOnRedirect schema. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110375 (owner: 10Phuedx) [03:57:05] (03CR) 10Legoktm: "This is causing some weird issues for me when I $ git submodule update --init:" [extensions] - 10https://gerrit.wikimedia.org/r/111202 (owner: 10Hashar) [03:59:08] (03CR) 10MZMcBride: "Self-merge?" [extensions] - 10https://gerrit.wikimedia.org/r/111202 (owner: 10Hashar) [04:00:00] legoktm: Did that break LocalisationUpdate? [04:00:05] dunno [04:00:12] it just broke my extension repo [04:00:41] by Raimond's comment I'm guessing it broke some TWN script [04:01:06] bbl food [04:16:06] (03CR) 10Ori.livneh: [C: 032] "Nice!" [core] - 10https://gerrit.wikimedia.org/r/111400 (owner: 10Parent5446) [04:19:55] (03Merged) 10jenkins-bot: Code, style, and doc fixes for benchmarkParse.php [core] - 10https://gerrit.wikimedia.org/r/111400 (owner: 10Parent5446) [04:36:34] (03PS1) 10Chad: Remove duplicate submodule definitions [extensions] - 10https://gerrit.wikimedia.org/r/111410 [04:37:25] (03CR) 10Chad: [C: 032 V: 032] Remove duplicate submodule definitions [extensions] - 10https://gerrit.wikimedia.org/r/111410 (owner: 10Chad) [04:47:58] (03CR) 10Mattflaschen: [C: 04-1] "Looks good, tested successfully." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110580 (owner: 10Phuedx) [05:16:55] (03PS2) 10Mattflaschen: Remove images from task config [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111105 [05:17:14] (03CR) 10Mattflaschen: "Done" (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111105 (owner: 10Mattflaschen) [05:18:54] (03PS1) 10Ori.livneh: scap: post runtime stats to statsd / graphite [tools/scap] - 10https://gerrit.wikimedia.org/r/111411 [05:31:32] (03PS3) 10Pastakhov: fix array definition and array index [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/111198 [05:32:02] (03PS2) 10Pastakhov: add some array functions [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/111199 [05:53:47] (03PS3) 10Aaron Schulz: Made UpdateSpecialPages support --list/--only with the callback updates [core] - 10https://gerrit.wikimedia.org/r/110398 [05:53:54] (03CR) 10Ori.livneh: [C: 032] Made UpdateSpecialPages support --list/--only with the callback updates [core] - 10https://gerrit.wikimedia.org/r/110398 (owner: 10Aaron Schulz) [05:58:15] (03Merged) 10jenkins-bot: Made UpdateSpecialPages support --list/--only with the callback updates [core] - 10https://gerrit.wikimedia.org/r/110398 (owner: 10Aaron Schulz) [05:58:21] (03PS1) 10Ori.livneh: scap: invoke dsh via subprocess.call rather than .check_call [tools/scap] - 10https://gerrit.wikimedia.org/r/111418 [05:59:11] (03PS14) 10Mattflaschen: mediawiki.api: Fix token with postWithToken, add test [core] - 10https://gerrit.wikimedia.org/r/83217 [06:01:10] (03PS2) 10Ori.livneh: scap: invoke dsh via subprocess.call rather than .check_call [tools/scap] - 10https://gerrit.wikimedia.org/r/111418 [06:01:32] (03CR) 10Ori.livneh: [C: 032 V: 032] scap: invoke dsh via subprocess.call rather than .check_call [tools/scap] - 10https://gerrit.wikimedia.org/r/111418 (owner: 10Ori.livneh) [06:01:41] (03CR) 10Ori.livneh: [C: 032 V: 032] scap: post runtime stats to statsd / graphite [tools/scap] - 10https://gerrit.wikimedia.org/r/111411 (owner: 10Ori.livneh) [06:05:57] (03CR) 10Mattflaschen: "Simplified the async test at Bartosz's suggestion." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [06:43:32] (03PS1) 10Amire80: Reword gwtoolset-title-bad with clearer punctuation [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/111420 [07:14:58] (03CR) 10Krinkle: [C: 04-1] Add deleteToken and moveToken (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111357 (owner: 10Ladsgroup) [07:33:28] (03CR) 10Siebrand: [C: 032] Reword gwtoolset-title-bad with clearer punctuation [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/111420 (owner: 10Amire80) [07:33:32] (03Merged) 10jenkins-bot: Reword gwtoolset-title-bad with clearer punctuation [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/111420 (owner: 10Amire80) [07:36:58] (03PS1) 10Ori.livneh: mw.user: remove #name & #anonymous; deprecate #bucket [core] - 10https://gerrit.wikimedia.org/r/111422 [07:37:31] (03PS2) 10Ori.livneh: ResourceLoader: pass jQuery twice to 'implements' module wrapper [core] - 10https://gerrit.wikimedia.org/r/85637 [07:39:48] (03CR) 10Siebrand: [C: 032] Use ContextSource::msg instead of wfMessage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111405 (owner: 10Legoktm) [07:40:01] (03Merged) 10jenkins-bot: Use ContextSource::msg instead of wfMessage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111405 (owner: 10Legoktm) [07:41:57] (03CR) 10jenkins-bot: [V: 04-1] mw.user: remove #name & #anonymous; deprecate #bucket [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh) [07:54:36] (03PS2) 10Krinkle: mediawiki.user: Remove #name and #anonymous; deprecate #bucket [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh) [07:55:47] ori: https://gerrit.wikimedia.org/r/#/c/74293/ [07:57:58] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.user: Remove #name and #anonymous; deprecate #bucket [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh) [08:01:56] ori: https://gerrit.wikimedia.org/r/#/c/108658/1/TimedMediaHandler.hooks.php [08:10:47] Krinkle: https://github.com/facebook/pfff/ [08:18:17] ori: /\bsilk\/([0-9.-_]*)/ to match "AppleWebKit/500.x silk/1.2.3_4556.7" [08:18:20] Spot the error [08:20:02] (03CR) 10Siebrand: Bug11269p1 Change-Id: Ibf9191f3a694014ad02eba9a58c600833e8361ec (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111330 (owner: 10Adi.iiita) [08:23:06] (03CR) 10Siebrand: [C: 031] Prevent use of bad titles in thread names [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/111239 (owner: 10UltrasonicNXT) [08:29:16] (03CR) 10Nikerabbit: "There seems to be a high chance for name conflicts in for blobs in different modules." [core] - 10https://gerrit.wikimedia.org/r/111250 (owner: 10MaxSem) [08:42:00] (03PS1) 10Ori.livneh: scap: ensure tmpfile is flushed; pass env to dsh [tools/scap] - 10https://gerrit.wikimedia.org/r/111424 [08:43:15] (03CR) 10Ori.livneh: [C: 032 V: 032] scap: ensure tmpfile is flushed; pass env to dsh [tools/scap] - 10https://gerrit.wikimedia.org/r/111424 (owner: 10Ori.livneh) [08:53:57] (03CR) 10Nemo bis: "> The reason given for Bookwormcentral's block is "Spamming"" [core] - 10https://gerrit.wikimedia.org/r/99195 (owner: 10Siebrand) [08:54:18] (03PS1) 10Raimond Spekking: Add special page alias file [extensions/GlobalContributions] - 10https://gerrit.wikimedia.org/r/111425 [09:03:07] (03CR) 10TTO: "That text (message "autoblocker") should not be in italics at all. It is never correct to have quoted text in both italics and quotation m" [core] - 10https://gerrit.wikimedia.org/r/99195 (owner: 10Siebrand) [09:05:59] (03PS2) 10Raimond Spekking: Add i18n file [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/110146 [09:17:18] (03CR) 10Siebrand: [C: 031] Add i18n file [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/110146 (owner: 10Raimond Spekking) [09:17:22] (03PS3) 10Hashar: mwext-GlobalPreferences-testextensions-master is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/111401 (owner: 10Legoktm) [09:17:59] !jenkins mwext-GlobalPreferences-testextensions-master [09:18:00] https://integration.wikimedia.org/ci/job/mwext-GlobalPreferences-testextensions-master [09:18:19] (03CR) 10Hashar: [C: 032] "Thank you! Deploying :-)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/111401 (owner: 10Legoktm) [09:18:23] (03Merged) 10jenkins-bot: mwext-GlobalPreferences-testextensions-master is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/111401 (owner: 10Legoktm) [09:58:37] (03CR) 10Yuvipanda: [C: 032 V: 032] "Thank you!" [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/110146 (owner: 10Raimond Spekking) [10:19:50] (03PS21) 10Prtksxna: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 [10:19:50] (03PS3) 10Prtksxna: Add animation to NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/110675 [10:20:20] (03PS2) 10Ladsgroup: Add deleteToken and moveToken [core] - 10https://gerrit.wikimedia.org/r/111357 [10:20:29] (03PS1) 10Siebrand: Fix CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/111430 [10:20:53] (03CR) 10Ladsgroup: "Done" [core] - 10https://gerrit.wikimedia.org/r/111357 (owner: 10Ladsgroup) [10:23:10] (03PS22) 10Prtksxna: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 [10:23:12] (03PS4) 10Prtksxna: Add animation to NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/110675 [10:30:29] (03CR) 10Prtksxna: "I'll add the BetaFeatures preference and name the module better once we know that this code will stay here :)" (0317 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [10:45:33] (03CR) 10Phuedx: [C: 032] Remove images from task config [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111105 (owner: 10Mattflaschen) [10:45:36] (03Merged) 10jenkins-bot: Remove images from task config [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111105 (owner: 10Mattflaschen) [11:02:42] (03PS1) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/111431 [11:07:18] (03CR) 10Pastakhov: [C: 032] fix array definition and array index [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/111198 (owner: 10Pastakhov) [11:07:23] (03Merged) 10jenkins-bot: fix array definition and array index [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/111198 (owner: 10Pastakhov) [11:08:19] (03PS3) 10Pastakhov: add array functions [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/111199 [11:08:57] (03CR) 10Pastakhov: [C: 032] add array functions [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/111199 (owner: 10Pastakhov) [11:09:00] (03CR) 10jenkins-bot: [V: 04-1] add array functions [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/111199 (owner: 10Pastakhov) [11:10:43] (03CR) 10Pastakhov: [V: 032] add array functions [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/111199 (owner: 10Pastakhov) [11:18:54] (03CR) 10Pastakhov: "Dependence does not work here, please help me." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/110164 (owner: 10Pastakhov) [11:19:16] (03PS1) 10Physikerwelt: Fix: Correct select field for MathEngine [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/111432 [11:21:07] (03PS2) 10Physikerwelt: Fix: Correct select field for MathEngine [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/111432 [11:22:41] (03CR) 10Physikerwelt: [C: 032 V: 032] Fix: Correct select field for MathEngine [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/111432 (owner: 10Physikerwelt) [11:25:16] (03PS1) 10Hashar: multigit: refresh submodules after checkout [integration/jenkins] - 10https://gerrit.wikimedia.org/r/111433 [11:25:29] (03CR) 10Hashar: [C: 032] multigit: refresh submodules after checkout [integration/jenkins] - 10https://gerrit.wikimedia.org/r/111433 (owner: 10Hashar) [11:25:32] (03Merged) 10jenkins-bot: multigit: refresh submodules after checkout [integration/jenkins] - 10https://gerrit.wikimedia.org/r/111433 (owner: 10Hashar) [11:44:17] (03PS14) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 [11:45:31] (03PS3) 10Phuedx: Update onboarding CTA impression logging. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110580 [13:09:39] (03CR) 10Hashar: [C: 032] multigit: set -e [integration/jenkins] - 10https://gerrit.wikimedia.org/r/111217 (owner: 10Hashar) [13:10:15] (03PS3) 10Hashar: multigit: set -e [integration/jenkins] - 10https://gerrit.wikimedia.org/r/111217 [13:10:21] (03CR) 10Hashar: [C: 032] multigit: set -e [integration/jenkins] - 10https://gerrit.wikimedia.org/r/111217 (owner: 10Hashar) [13:10:24] (03Merged) 10jenkins-bot: multigit: set -e [integration/jenkins] - 10https://gerrit.wikimedia.org/r/111217 (owner: 10Hashar) [13:45:52] (03CR) 10Hashar: "deployed, all jobs are passing." [integration/jenkins] - 10https://gerrit.wikimedia.org/r/111217 (owner: 10Hashar) [14:17:35] (03PS1) 10Manybubbles: Reindex is ok seeing same id twice [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111450 [14:50:08] (03PS2) 10Adi.iiita: Changed pagination format on Special:MostLinkedCategories From results starting from ABC to results in range ABC to DEF [core] - 10https://gerrit.wikimedia.org/r/111330 [14:54:33] !gitweb integration/jenkins-job-builder-config [14:54:34] https://git.wikimedia.org/summary/?r=integration/jenkins-job-builder-config [15:04:57] What is the syntax to grep a function name using git? [15:09:08] (03CR) 10Fomafix: "This change generates bug 60900." [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński) [15:14:23] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Tests need updating. Looks like a good idea." [core] - 10https://gerrit.wikimedia.org/r/111422 (owner: 10Ori.livneh) [15:20:26] Hie, please tell me the difference in working of " $this->msg( 'XYZ' )->numParams(...)" and "$this->getLanguage()->XYZ(...) ". [15:20:50] bd808|BUFFER: Hi Bryan. [15:23:50] (03PS1) 10Liangent: (bug 57401) Fix padding values of div#content [core] - 10https://gerrit.wikimedia.org/r/111454 [15:24:41] (03PS2) 10Liangent: (bug 57401) Fix padding values of div#content [core] - 10https://gerrit.wikimedia.org/r/111454 [15:29:54] bd808|BUFFER, ori: I am working on this bug and i need some guidance. Please tell me the difference in working of " $this->msg( 'XYZ' )->numParams(...)" and "$this->getLanguage()->XYZ(...) ". Both are using a message defined in messagesEn.php butI believe both work differently as the number of parametes is same as defined in 1st case but different for the other. So there must be an intermediate pre processing before they are ac [16:02:59] uh... Error: 1054 Unknown column 'page_links_updated' in 'field list' (localhost) [16:03:14] that column is now, right? but update.php doesn't seem to create it... [16:03:20] am i missing something? [16:13:40] (03PS1) 10Phuedx: Refactor task configuration. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111459 [16:15:12] I am working on this bug and i need some guidance. Please tell me the difference in working of " $this->msg( 'XYZ' )->numParams(...)" and "$this->getLanguage()->XYZ(...) ". Both are using a message defined in messagesEn.php butI believe both work differently as the number of parametes is same as defined in 1st case but different for the other. So there must be an intermediate pre processing before they are actually rendered. I [16:15:19] (got DC.... ) [16:16:01] (03CR) 10Matthias Mullie: [C: 04-1] "We should probably do away with globally styling h1 altogether (also see https://gerrit.wikimedia.org/r/#/c/105426/)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111402 (owner: 10Legoktm) [16:16:28] <^d> zeek: I've not seen the latter usage before. [16:16:56] <^d> But $this->msg() should return a Message object. That's where you should look for docs on how it's processed (you can get it plain, parsed, etc) [16:18:26] ^d: http://fpaste.org/74687/91617085/ [16:19:12] I am not sure how viewPrevNext is working. In messageEn.php it has the defination with 3 parametres. [16:19:30] <^d> viewPrevNext() is a method on Language. [16:19:38] <^d> That'd be the place to look. [16:19:58] I was about to say that, but failed to load the PHP docs on doc.wm.o [16:20:02] Redirect loop I guess [16:20:32] Yes I though there must be an intermediate. Let me see. :) [16:22:41] Not sure who I should bother about the redirect problem [16:23:18] <^d> hashar: I thought you guys fixed that? [16:23:51] <^d> The redirectings on doc.wm.o [16:24:47] ^d: what do you mean ? [16:25:25] <^d> docs.wm.o doesn't work for me either. [16:25:32] <^d> It redirects to ssl version, then dies. [16:25:52] hashar: https://doc.wikimedia.org/mediawiki-core/master/php/html/ I get infinite redirect [16:26:07] <^d> Well ^ loads for me [16:26:20] Oh, maybe it's a Firefox thing. [16:26:31] <^d> Ah, ignore me. [16:26:34] <^d> docs v. doc [16:26:45] <^d> But yeah, that link wfm. [16:26:45] Hm, heisenbug, it worked when I opened the web console [16:26:58] <^d> hashar: Sorry for needless pings. [16:27:03] <^d> It seems to be user error [16:28:35] (03PS15) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 [16:30:09] ^d: I have migrated the {doc,integration}.{wikimedia,mediawiki}.org website behind a varnish instance [16:30:12] (the misc varnish) [16:30:16] so that might be a side effect [16:31:19] rdwrer: there might be a wrong entry in Varnish cache which we are using in front of the website :-( [16:31:36] Ah. [16:31:39] rdwrer: someone filled a bug about it yesterday I think [16:31:47] can't remember the bug #wikimedia-dev though [16:31:50] grr [16:33:16] rdwrer: https://bugzilla.wikimedia.org/show_bug.cgi?id=60822 [16:33:57] rdwrer: if you can still reproduce, it would be nice to get the full response headers [16:34:14] I can't, and opening the web console fixed it instantly [16:34:22] great :D [16:37:24] rdwrer: will look at it [16:38:51] (03PS3) 10Cmcmahon: Fix browser tests for new topic UI [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110597 (owner: 10Spage) [16:41:39] (03PS2) 10Phuedx: Visual design tweaks. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110946 [16:42:04] (03PS2) 10Aaron Schulz: Merged redis queue periodic tasks into recyclePruneAndUndelayJobs() [core] - 10https://gerrit.wikimedia.org/r/104475 [16:43:04] (03PS16) 10Jforrester: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 (owner: 10Hashar) [16:43:43] James_F: that is highly experimental :-) [16:43:55] hashar: I was fixing the ASCII art. :-) [16:44:03] James_F: thx! [16:44:05] hashar: (I'd got that impression. ;-)) [16:45:13] (03CR) 10MaxSem: "Blob name conflicts are avoidable the same way as message key conflicts are: unique per extension prefixes. I even added aliases specifica" [core] - 10https://gerrit.wikimedia.org/r/111250 (owner: 10MaxSem) [16:45:22] (03PS2) 10Bene: Add title to list item of language link [core] - 10https://gerrit.wikimedia.org/r/111159 [16:46:38] (03PS4) 10Spage: Fix browser tests for new topic UI [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110597 [16:46:55] (03CR) 10Cmcmahon: [C: 032] "Turning tests back to green" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110597 (owner: 10Spage) [16:53:14] (03CR) 10Bene: Add SkinTemplateGetLanguageLink hook (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111001 (owner: 10Bene) [17:14:37] (03PS3) 10Bartosz Dziewoński: Vector: Fix padding values of div#content [core] - 10https://gerrit.wikimedia.org/r/111454 (owner: 10Liangent) [17:14:44] (03CR) 10Bartosz Dziewoński: [C: 032] Vector: Fix padding values of div#content [core] - 10https://gerrit.wikimedia.org/r/111454 (owner: 10Liangent) [17:15:06] (03PS1) 10Anomie: Fix PHP implementation of mw.ustring %W [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/111467 [17:16:20] (03CR) 10Bartosz Dziewoński: [C: 031] "Not tested." [core] - 10https://gerrit.wikimedia.org/r/111159 (owner: 10Bene) [17:16:53] Hie, I am trying to setup wikimedia environment using vagrant. When i run vagrant provision, it is unable ro download packages. I have installed vagrant proxyconf plugin and set up my proxy. Please help I want to start contributing http://www.fpaste.org/74717/39162048/ [17:19:28] (03Merged) 10jenkins-bot: Vector: Fix padding values of div#content [core] - 10https://gerrit.wikimedia.org/r/111454 (owner: 10Liangent) [17:25:03] (03PS1) 10Etienne: WIP: phpunit test for XQuery generation [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/111468 [17:26:19] (03CR) 10MarkAHershberger: "For future reference, there is enough information in the commit message to put a line or two in the release notes." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110923 (owner: 10Nemo bis) [17:26:43] (03Restored) 10MarkAHershberger: Various fixes to job running code in Wiki.php [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110923 (owner: 10Nemo bis) [17:27:25] (03CR) 10MarkAHershberger: [C: 032] Various fixes to job running code in Wiki.php [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110923 (owner: 10Nemo bis) [17:27:40] (03CR) 10Anomie: Update formatting (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111431 (owner: 10Siebrand) [17:30:38] (03Merged) 10jenkins-bot: Various fixes to job running code in Wiki.php [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110923 (owner: 10Nemo bis) [17:30:51] (03Restored) 10MarkAHershberger: Correct sequence name for fresh Postgres installation [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110922 (owner: 10Nemo bis) [17:31:23] (03CR) 10MarkAHershberger: [C: 032] Correct sequence name for fresh Postgres installation [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110922 (owner: 10Nemo bis) [17:33:08] (03CR) 10Chad: "Yeah, let's remove the WIP and get this in. We don't have to turn it on in prod until we've worked out the kinks." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105986 (owner: 10Chad) [17:33:39] (03PS1) 10Physikerwelt: Fix: Correct diff tool [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/111472 [17:34:10] (03CR) 10Physikerwelt: [C: 032 V: 032] Fix: Correct diff tool [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/111472 (owner: 10Physikerwelt) [17:34:21] (03CR) 10MarkAHershberger: [C: 032] Add error handling if descriptionmsg isn't defined for extension. [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110475 (owner: 10Brian Wolff) [17:35:04] (03PS2) 10Etienne: WIP: phpunit test for XQuery generation [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/111468 [17:35:06] (03Merged) 10jenkins-bot: Correct sequence name for fresh Postgres installation [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110922 (owner: 10Nemo bis) [17:36:19] (03CR) 10MarkAHershberger: [C: 032] update RELEASE-NOTES-1.22 for bug 60543 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110408 (owner: 10Se4598) [17:37:07] (03CR) 10Anomie: [C: 04-1] Allow interlanguage link prefixes that are not language codes (034 comments) [core] - 10https://gerrit.wikimedia.org/r/111390 (owner: 10TTO) [17:37:59] (03Merged) 10jenkins-bot: Add error handling if descriptionmsg isn't defined for extension. [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110475 (owner: 10Brian Wolff) [17:38:02] (03CR) 10jenkins-bot: [V: 04-1] update RELEASE-NOTES-1.22 for bug 60543 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110408 (owner: 10Se4598) [17:38:04] (03CR) 10MarkAHershberger: "Could you explain why this is abaondoned?" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/105150 (owner: 10Siebrand) [17:40:15] (03CR) 10Chad: [C: 032] Fix CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/111430 (owner: 10Siebrand) [17:40:28] (03CR) 10Bartosz Dziewoński: [C: 032] "Not much of a difference, IMO, but if you think this looks better, then sure :)" [core] - 10https://gerrit.wikimedia.org/r/111406 (owner: 10PleaseStand) [17:40:30] (03CR) 10Anomie: [C: 031] "Code itself looks good, haven't tested. Also, anyone looking at merging should first check if there's a resolution to the issue raised by " [core] - 10https://gerrit.wikimedia.org/r/111001 (owner: 10Bene) [17:43:50] (03Merged) 10jenkins-bot: Fix CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/111430 (owner: 10Siebrand) [17:44:38] (03Merged) 10jenkins-bot: Correct proportions in SVG search icon [core] - 10https://gerrit.wikimedia.org/r/111406 (owner: 10PleaseStand) [17:45:54] (03CR) 10UltrasonicNXT: [V: 032] "Ok, I've got a +1, so I'll go for this." [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/111239 (owner: 10UltrasonicNXT) [17:46:41] (03CR) 10UltrasonicNXT: [C: 032] "Oh hello, it's not letting me submit a CR +2..." [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/111239 (owner: 10UltrasonicNXT) [17:50:16] (03CR) 10Anomie: [C: 04-2] "-2 from me in favor of I223bf7a7." [core] - 10https://gerrit.wikimedia.org/r/110832 (owner: 10TTO) [17:51:38] (03PS3) 10UltrasonicNXT: Prevent use of bad titles in thread names [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/111239 [17:52:02] (03CR) 10UltrasonicNXT: [C: 032 V: 032] "Cool, it just needed a rebase" [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/111239 (owner: 10UltrasonicNXT) [17:54:26] (03PS1) 10Welterkj: use imagemap class for HTML rendering [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111475 [17:54:31] (03CR) 10Chad: [C: 032] Reindex is ok seeing same id twice [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111450 (owner: 10Manybubbles) [17:54:38] (03Merged) 10jenkins-bot: Reindex is ok seeing same id twice [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111450 (owner: 10Manybubbles) [17:55:39] (03CR) 10Chad: [C: 032] Don't offer create link for searches with syntax [core] - 10https://gerrit.wikimedia.org/r/111233 (owner: 10Manybubbles) [17:59:16] (03Merged) 10jenkins-bot: Don't offer create link for searches with syntax [core] - 10https://gerrit.wikimedia.org/r/111233 (owner: 10Manybubbles) [18:01:13] (03CR) 10Chad: [C: 032] Turn on create and suggestions query has syntax [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111261 (owner: 10Manybubbles) [18:01:19] (03Merged) 10jenkins-bot: Turn on create and suggestions query has syntax [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111261 (owner: 10Manybubbles) [18:01:31] (03CR) 10Anomie: Moved $wgQueryPages stuff out of the global scope and into a function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111248 (owner: 10Chad) [18:01:42] (03PS1) 10Bartosz Dziewoński: Vector: text-indent workaround for Firefox 27 bug [core] - 10https://gerrit.wikimedia.org/r/111476 [18:01:48] Hie, I am trying to setup wikimedia environment using vagrant. When i run vagrant provision, it is unable ro download packages. I have installed vagrant proxyconf plugin and set up my proxy. Please help I want to start contributing http://www.fpaste.org/74717/39162048/ [18:03:14] (03CR) 10Chad: [C: 032] http://www.mediawiki.org --> https://www.mediawiki.org [core] - 10https://gerrit.wikimedia.org/r/108681 (owner: 10Ladsgroup) [18:04:16] (03CR) 10Chad: "Uses are worst, yes. But until all the uses are gone, removing sets like these in core can lead to unpredictable effects." [core] - 10https://gerrit.wikimedia.org/r/103399 (owner: 10Aaron Schulz) [18:06:44] (03Merged) 10jenkins-bot: http://www.mediawiki.org --> https://www.mediawiki.org [core] - 10https://gerrit.wikimedia.org/r/108681 (owner: 10Ladsgroup) [18:07:11] (03CR) 10Bartosz Dziewoński: "Yet another followup: https://gerrit.wikimedia.org/r/111476 . I think I've beaten some kind of a record." [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński) [18:08:50] (03PS14) 10Krinkle: Remove 'Remember my login' preference [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [18:09:18] (03CR) 10Krinkle: "Clarified commit message to reflect removal of the preference in general, not just from the "Preferences page"." [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [18:09:41] (03PS1) 10Chad: Get title from EditPage rather than $wgTitle [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/111478 [18:11:03] (03PS2) 10Chad: Get title from EditPage rather than $wgTitle [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/111478 [18:12:07] (03CR) 10Krinkle: [C: 04-1] Remove 'Remember my login' preference (031 comment) [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [18:13:13] (03CR) 10Brion VIBBER: [C: 031] "Works for me on Firefox 30.0a1 nightly / Mac OS X. Any objections?" [core] - 10https://gerrit.wikimedia.org/r/111476 (owner: 10Bartosz Dziewoński) [18:13:17] (03PS1) 10Chad: $wgTitle is not needed here [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/111480 [18:13:35] we should just throw an exception any time $wgTitle is accessed [18:13:41] heh [18:18:44] (03PS1) 10Chad: The parser is never null [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/111481 [18:19:20] (03CR) 10Chad: "This gets rid of $wgParser, $wgTitle and $wgOut in one commit. How much karma do I get for that? ;-)" [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/111481 (owner: 10Chad) [18:19:22] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 8e4fe35..ef111af [extensions] - 10https://gerrit.wikimedia.org/r/111482 [18:19:24] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 8e4fe35..ef111af [extensions] - 10https://gerrit.wikimedia.org/r/111482 (owner: 10Jenkins-mwext-sync) [18:19:50] <^d> brion: I want to start wrapping it in DeprecatedGlobal. [18:19:57] <^d> But we need to stop using it in core first. [18:20:01] <^d> Dogfood and such [18:20:06] (03CR) 10Anomie: "Code looks good at a glance. Some suggestions though." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111255 (owner: 10Legoktm) [18:25:32] (03PS1) 10Chad: Once again, no need for $wgTitle [extensions/BreadCrumbs2] - 10https://gerrit.wikimedia.org/r/111483 [18:26:08] <^d> That's all extensions starting with "B" other than BlueSpice. [18:26:47] (03PS1) 10EBernhardson: Catch exceptions formatting notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111484 [18:27:00] (03CR) 10Bartosz Dziewoński: "Let's please merge this before the branch cut tomorrow so that people don't murder us, or me in particular." [core] - 10https://gerrit.wikimedia.org/r/111476 (owner: 10Bartosz Dziewoński) [18:28:30] (03PS2) 10EBernhardson: Catch exceptions formatting notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111484 [18:31:14] (03CR) 10Legoktm: Catch exceptions formatting notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111484 (owner: 10EBernhardson) [18:31:33] (03PS1) 10Chad: $wgTitle and $wgOut weren't needed here [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/111486 [18:31:51] (03PS11) 10Dr0ptp4kt: Add support to get just the startup module URL with version. [core] - 10https://gerrit.wikimedia.org/r/102344 [18:34:55] (03CR) 10Hoo man: [C: 04-1] $wgTitle and $wgOut weren't needed here (031 comment) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/111486 (owner: 10Chad) [18:36:32] (03PS5) 10Alex Monk: jquery.client: Recognise Amazon Silk [core] - 10https://gerrit.wikimedia.org/r/110989 [18:36:44] (03CR) 10Aaron Schulz: "A change to redo the query was already done (the page is back now), this isn't needed anymore now." [core] - 10https://gerrit.wikimedia.org/r/109496 (owner: 10TTO) [18:38:07] (03PS1) 10Chad: Don't need $wgTitle or $wgParser here [extensions/ExtTab] - 10https://gerrit.wikimedia.org/r/111488 [18:38:09] (03CR) 10Legoktm: Catch exceptions formatting notifications (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111484 (owner: 10EBernhardson) [18:39:12] (03CR) 10Alex Monk: Catch exceptions formatting notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111484 (owner: 10EBernhardson) [18:42:12] (03PS1) 10Yurik: Updated to the latest Zero ext [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111489 [18:43:41] (03PS1) 10Yurik: Updated to the latest Zero ext [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111490 [18:44:01] (03PS1) 10Chad: Use parser's title rather than $wgTitle [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/111491 [18:44:24] (03CR) 10Yurik: [C: 032 V: 032] Updated to the latest Zero ext [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111490 (owner: 10Yurik) [18:45:53] (03PS1) 10Chad: Remove unused $wgTitles [extensions/News] - 10https://gerrit.wikimedia.org/r/111492 [18:46:25] (03PS3) 10EBernhardson: Catch exceptions formatting notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111484 [18:47:19] (03CR) 10EBernhardson: "PS3: added event id to logged message" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111484 (owner: 10EBernhardson) [18:49:32] (03CR) 10Legoktm: [C: 031] "Haven't tested" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111484 (owner: 10EBernhardson) [18:49:57] (03CR) 10Kaldari: [C: 04-1] Add JS/CSS for the new NavigationPopups (034 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [18:53:11] (03CR) 10Yurik: [C: 032 V: 032] Updated to the latest Zero ext [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111489 (owner: 10Yurik) [18:55:14] (03PS15) 1001tonythomas: Removed 'Remember my login' preference [core] - 10https://gerrit.wikimedia.org/r/94614 [18:57:18] (03PS1) 10Bsitu: Prevent events with large blob extra data [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111495 [18:57:26] (03CR) 10jenkins-bot: [V: 04-1] Prevent events with large blob extra data [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111495 (owner: 10Bsitu) [18:57:26] any objections to 'text-indent: 200%' hack in https://gerrit.wikimedia.org/r/#/c/111476/ ? [18:57:30] otherwise i'm merging' it [18:59:04] (03CR) 10Brion VIBBER: [C: 032] "+2 \o/ c'mon jenkins test this bad boy" [core] - 10https://gerrit.wikimedia.org/r/111476 (owner: 10Bartosz Dziewoński) [18:59:19] (03PS2) 10Bsitu: Prevent events with large blob extra data [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111495 [18:59:24] (03PS1) 10Chad: Remove some easily removed $wgTitles [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/111496 [19:00:42] (03CR) 10Umherirrender: "Due to the missing raw sql support I can now do:" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110991 (owner: 10Umherirrender) [19:02:05] (03CR) 10EBernhardson: Prevent events with large blob extra data (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111495 (owner: 10Bsitu) [19:02:29] (03Merged) 10jenkins-bot: Vector: text-indent workaround for Firefox 27 bug [core] - 10https://gerrit.wikimedia.org/r/111476 (owner: 10Bartosz Dziewoński) [19:03:21] (03CR) 10Matthias Mullie: Prevent events with large blob extra data (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111495 (owner: 10Bsitu) [19:08:29] (03CR) 10Nikerabbit: [C: 032] Remove some easily removed $wgTitles [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/111496 (owner: 10Chad) [19:08:32] (03PS1) 10Chad: Removed $wgTitle usages that were marked as todo [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/111497 [19:08:34] (03Merged) 10jenkins-bot: Remove some easily removed $wgTitles [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/111496 (owner: 10Chad) [19:09:55] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: ef111af..db2661d [extensions] - 10https://gerrit.wikimedia.org/r/111498 [19:09:57] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: ef111af..db2661d [extensions] - 10https://gerrit.wikimedia.org/r/111498 (owner: 10Jenkins-mwext-sync) [19:12:17] (03PS1) 10Chad: The parser is never null :) [extensions/GraphViz] - 10https://gerrit.wikimedia.org/r/111499 [19:12:44] (03PS3) 10Bene: Add SkinTemplateGetLanguageLink hook [core] - 10https://gerrit.wikimedia.org/r/111001 [19:20:35] (03PS1) 10Chad: Use titles already easily on hand [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/111500 [19:21:31] (03PS2) 10Chad: $wgTitle and $wgOut weren't needed here [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/111486 [19:23:11] (03PS1) 10Ragesoss: Style the titles of courses in the Special:MyCourses feed [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/111502 [19:23:15] (03CR) 10Ori.livneh: [C: 032] Merged redis queue periodic tasks into recyclePruneAndUndelayJobs() [core] - 10https://gerrit.wikimedia.org/r/104475 (owner: 10Aaron Schulz) [19:24:06] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: db2661d..1e6daf1 [extensions] - 10https://gerrit.wikimedia.org/r/111503 [19:24:08] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: db2661d..1e6daf1 [extensions] - 10https://gerrit.wikimedia.org/r/111503 (owner: 10Jenkins-mwext-sync) [19:26:55] (03Merged) 10jenkins-bot: Merged redis queue periodic tasks into recyclePruneAndUndelayJobs() [core] - 10https://gerrit.wikimedia.org/r/104475 (owner: 10Aaron Schulz) [19:28:05] (03PS1) 10Chad: Remove easily removed $wgTitles, SpecialPages and Articles have titles on hand [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/111504 [19:28:41] (03PS4) 10Bene: Add SkinTemplateGetLanguageLink hook [core] - 10https://gerrit.wikimedia.org/r/111001 [19:30:44] (03PS3) 10Physikerwelt: WIP: phpunit test for XQuery generation [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/111468 (owner: 10Etienne) [19:37:58] (03PS1) 10Chad: Remove some easily removed $wgTitles from BlueSpiceExtensions [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/111506 [19:40:13] (03PS2) 10AalekhN: Includes toggle handler in jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/110883 [19:41:44] (03CR) 10jenkins-bot: [V: 04-1] Includes toggle handler in jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/110883 (owner: 10AalekhN) [19:43:23] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 1e6daf1..d7e9564 [extensions] - 10https://gerrit.wikimedia.org/r/111508 [19:43:25] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 1e6daf1..d7e9564 [extensions] - 10https://gerrit.wikimedia.org/r/111508 (owner: 10Jenkins-mwext-sync) [19:47:53] (03CR) 10Mglaser: [C: 032 V: 032] "Thanks!" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/111506 (owner: 10Chad) [19:49:36] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: d7e9564..425d6fe [extensions] - 10https://gerrit.wikimedia.org/r/111510 [19:49:38] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: d7e9564..425d6fe [extensions] - 10https://gerrit.wikimedia.org/r/111510 (owner: 10Jenkins-mwext-sync) [19:50:11] (03PS1) 10Yuvipanda: Make buttons use mw.ui buttons [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111511 [19:56:45] (03CR) 10Adamw: [C: 04-1] "tiny thing to fix" (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/111502 (owner: 10Ragesoss) [20:01:18] <^d> Ok, that's enough of that for now. Time for lunch. [20:01:35] * ^d drops a pile of review on the floor https://gerrit.wikimedia.org/r/#/q/status:open+topic:wgTitle-ugh,n,z [20:01:55] (03PS2) 10Ragesoss: Style the titles of courses in the Special:MyCourses feed [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/111502 [20:06:09] (03PS1) 10Alex Monk: Check current name of user instead of blindly using user_text (could've been renamed since) [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/111514 [20:06:56] (03CR) 10Alex Monk: Maintenance script to migrate legacy Oversight data (031 comment) [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 (owner: 10Alex Monk) [20:07:51] (03CR) 10Alex Monk: "Also I should note that dry-run mode is Ib2960014" [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 (owner: 10Alex Monk) [20:08:27] (03PS1) 10Yuvipanda: Add role for WikiLove [vagrant] - 10https://gerrit.wikimedia.org/r/111515 [20:08:29] bd808: trivial merge? ^ [20:09:04] (03CR) 10BryanDavis: [C: 032] Add role for WikiLove [vagrant] - 10https://gerrit.wikimedia.org/r/111515 (owner: 10Yuvipanda) [20:09:07] (03Merged) 10jenkins-bot: Add role for WikiLove [vagrant] - 10https://gerrit.wikimedia.org/r/111515 (owner: 10Yuvipanda) [20:09:09] bd808: thanks! [20:09:46] YuviPanda: yw. [20:09:52] :) [20:10:02] YuviPanda: If you have a bit to think about a more complicated patch: https://gerrit.wikimedia.org/r/#/c/108067/ [20:10:33] bd808: hmm, not today but I'll take a look at it tomorrow [20:10:56] bd808: jobvite and 'being outside' has started stealing some of my time :( [20:10:57] (03PS1) 10Jdlrobson: Cleanup search placeholder black/gray text mess [core] - 10https://gerrit.wikimedia.org/r/111516 [20:11:08] These things happen :) [20:12:47] bd808: I suppose. I've been playing Ingress, and that's had interesting side effects. [20:20:11] (03PS3) 10Bsitu: Prevent events with large blob extra data [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111495 [20:23:19] (03CR) 10MaxSem: "Hmm, or should I just prefix every blob with module name?" [core] - 10https://gerrit.wikimedia.org/r/111250 (owner: 10MaxSem) [20:25:59] (03CR) 10EBernhardson: [C: 032] Prevent events with large blob extra data [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111495 (owner: 10Bsitu) [20:26:07] (03Merged) 10jenkins-bot: Prevent events with large blob extra data [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111495 (owner: 10Bsitu) [20:32:04] bd808: I have submitted my first patch. Its been long and I am curious to know if its worth merging. Will you please see :) https://gerrit.wikimedia.org/r/#/c/111330/ [20:33:24] <^demon|away> zeek: Yay on getting it in :) [20:33:29] <^demon|away> Sorry you had problems the other evening [20:33:55] ^demon|away: Haha, ya had written a bad commit message.. :) [20:34:31] (03CR) 10CSteipp: Added password hashing API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [20:34:32] zeek: Looking now [20:35:52] cool :) [20:37:19] (03PS3) 10Catrope: Changed pagination format on Special:MostLinkedCategories [core] - 10https://gerrit.wikimedia.org/r/111330 (owner: 10Adi.iiita) [20:37:52] * RoanKattouw reformatted the commit summary [20:38:08] (03CR) 10Jack Phoenix: [C: 032 V: 032] Use titles already easily on hand [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/111500 (owner: 10Chad) [20:38:11] (03CR) 10Jack Phoenix: [C: 032 V: 032] Removed $wgTitle usages that were marked as todo [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/111497 (owner: 10Chad) [20:38:47] (03CR) 10Hashar: [C: 031] Document $wgResourceLoaderMaxage in DefaultSettings.php [core] - 10https://gerrit.wikimedia.org/r/110637 (owner: 10Umherirrender) [20:40:54] (03CR) 10Bartosz Dziewoński: "I have a related patch at https://gerrit.wikimedia.org/r/#/c/110964/ …" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111516 (owner: 10Jdlrobson) [20:45:47] * bd808 waits patiently for his vagrant image to boot [20:47:12] (03CR) 10Hashar: "I just ran the sync-with-gerrit.py script available in the repo, added to gerrit and self approved. We have done that for ages." [extensions] - 10https://gerrit.wikimedia.org/r/111202 (owner: 10Hashar) [20:52:10] zeek: Can you give me an example of a special page this would change? [20:52:56] bd808: I have mentioned in the commit message. "Changed pagination format on Special:MostLinkedCategories". I took this from the bug itself. [20:53:16] (03PS1) 10Ori.livneh: scappy: light refactoring [tools/scap] - 10https://gerrit.wikimedia.org/r/111522 [20:53:18] zeek: Thanks. Apparently I'm reading challenged today :) [20:53:34] bd808: No problem :) [20:54:04] (03CR) 10Ori.livneh: [C: 032 V: 032] scappy: light refactoring [tools/scap] - 10https://gerrit.wikimedia.org/r/111522 (owner: 10Ori.livneh) [20:58:26] (03CR) 10Legoktm: [C: 04-1] Make buttons use mw.ui buttons (031 comment) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111511 (owner: 10Yuvipanda) [20:59:52] (03PS1) 10Chad: Get title from article rather than $wgTitle [extensions/Video] - 10https://gerrit.wikimedia.org/r/111529 [20:59:55] (03CR) 10BryanDavis: "Two trivial comments on the messages file. Awesome first patch!" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111330 (owner: 10Adi.iiita) [21:00:43] zeek: two tiny little comments on the messages file. But it works! That's the hard part. :) [21:01:13] (03PS2) 10Yuvipanda: Make buttons use mw.ui buttons [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111511 [21:01:16] (03CR) 10Yuvipanda: Make buttons use mw.ui buttons (031 comment) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111511 (owner: 10Yuvipanda) [21:01:25] legoktm: updated [21:01:41] legoktm: I thought I'll be using the form class later on, then realized mw.ui won't include buttons forever [21:01:44] (03CR) 10Parent5446: Check current name of user instead of blindly using user_text (could've been renamed since) (031 comment) [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/111514 (owner: 10Alex Monk) [21:02:04] bd808: yay thanks. :) Let me know i will fix the comments too. Want to make it perfect. :) [21:03:18] zeek: The comments are in gerrit. Look at the diff for languages/messages/MessagesEn.php in Patch Set 3 to see them. [21:04:25] ok [21:05:11] (03CR) 10Ori.livneh: [C: 032] "yeah, probably best to do it this way as a stopgap." [vagrant] - 10https://gerrit.wikimedia.org/r/111143 (owner: 10Gergő Tisza) [21:05:15] (03PS2) 10Gergő Tisza: Make sure gems are always installed for the vagrant user [vagrant] - 10https://gerrit.wikimedia.org/r/111143 [21:05:19] (03CR) 10Ori.livneh: [C: 032] Make sure gems are always installed for the vagrant user [vagrant] - 10https://gerrit.wikimedia.org/r/111143 (owner: 10Gergő Tisza) [21:05:22] (03Merged) 10jenkins-bot: Make sure gems are always installed for the vagrant user [vagrant] - 10https://gerrit.wikimedia.org/r/111143 (owner: 10Gergő Tisza) [21:05:48] (03PS6) 10Gergő Tisza: Add jsduck support for MediaViewer [vagrant] - 10https://gerrit.wikimedia.org/r/108858 [21:06:20] (03CR) 10Ori.livneh: [C: 04-1] "tiny nit, sorry" (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/108858 (owner: 10Gergő Tisza) [21:06:35] (03PS1) 10UltrasonicNXT: Fix userrights-interwiki when the 'user' table is shared [core] - 10https://gerrit.wikimedia.org/r/111532 [21:08:24] (03CR) 10Parent5446: [C: 04-1] Update formatting (033 comments) [core] - 10https://gerrit.wikimedia.org/r/111431 (owner: 10Siebrand) [21:11:19] (03PS6) 10Ori.livneh: Add role::wikimania_scholarships [vagrant] - 10https://gerrit.wikimedia.org/r/108067 (owner: 10BryanDavis) [21:11:21] (03CR) 10jenkins-bot: [V: 04-1] Add role::wikimania_scholarships [vagrant] - 10https://gerrit.wikimedia.org/r/108067 (owner: 10BryanDavis) [21:11:49] ori: I'll rebase ^ [21:12:08] bd808: can you remove the modline from roles.pp too? [21:12:15] Sure [21:12:22] thanks [21:13:11] (03PS2) 10Ottomata: Including apache::mods::wsgi for wikimetrics so package is available [vagrant] - 10https://gerrit.wikimedia.org/r/110211 [21:13:25] (03CR) 10Ori.livneh: [C: 032] "Yep." [vagrant] - 10https://gerrit.wikimedia.org/r/110211 (owner: 10Ottomata) [21:13:27] (03Merged) 10jenkins-bot: Including apache::mods::wsgi for wikimetrics so package is available [vagrant] - 10https://gerrit.wikimedia.org/r/110211 (owner: 10Ottomata) [21:14:55] (03CR) 10Ori.livneh: "Looks OK. Have you tested it?" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/106693 (owner: 10TheDJ) [21:15:09] (03PS7) 10BryanDavis: Add role::wikimania_scholarships [vagrant] - 10https://gerrit.wikimedia.org/r/108067 [21:15:12] (03CR) 10jenkins-bot: [V: 04-1] Add role::wikimania_scholarships [vagrant] - 10https://gerrit.wikimedia.org/r/108067 (owner: 10BryanDavis) [21:15:14] (03CR) 10Jdlrobson: [C: 04-1] "Please test this locally rather than submitting blind patches. This is not needed on newer versions of Firefox. The placeholder does not i" [core] - 10https://gerrit.wikimedia.org/r/110964 (owner: 10Bartosz Dziewoński) [21:15:32] gah! [21:16:01] * bd808 kicks jenkins for point out his mistakes [21:16:12] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 425d6fe..90d46cb [extensions] - 10https://gerrit.wikimedia.org/r/111533 [21:16:14] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 425d6fe..90d46cb [extensions] - 10https://gerrit.wikimedia.org/r/111533 (owner: 10Jenkins-mwext-sync) [21:16:40] (03CR) 10Ori.livneh: [C: 04-1] "Needs rebase. LGTM otherwise." [core] - 10https://gerrit.wikimedia.org/r/102361 (owner: 10Aaron Schulz) [21:16:42] (03PS8) 10BryanDavis: Add role::wikimania_scholarships [vagrant] - 10https://gerrit.wikimedia.org/r/108067 [21:16:45] (03CR) 10Jdlrobson: Cleanup search placeholder black/gray text mess (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111516 (owner: 10Jdlrobson) [21:17:06] (03PS9) 10BryanDavis: Add role::wikimania_scholarships [vagrant] - 10https://gerrit.wikimedia.org/r/108067 [21:17:53] ori: I think I've rebased it to death now [21:18:45] zeek: Did you find the comments I made? Did they make sense? [21:19:25] bd808: Yes working on it. Apparently, the javascript was getting crashed again and again when i tried to open it. On it now. Fixing asap [21:20:10] zeek: No problem. I just didn't want to leave you hanging where you were so close to done. [21:20:25] :) [21:20:26] Coren: what about using a more standard hash lib (one of the whirlpool alternatives from the list) as the *input* to the whirlpool use? [21:20:39] (03PS1) 10Yuvipanda: Remove jquery.elastic [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111534 [21:20:41] (03CR) 10Jdlrobson: Cleanup search placeholder black/gray text mess (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111516 (owner: 10Jdlrobson) [21:21:15] MatmaRex: wanna do a -162, +1 patch? :D [21:21:29] (https://gerrit.wikimedia.org/r/#/c/111534/) [21:21:36] * jeremyb reruns away [21:21:42] jeremyb: Evaluating the impact of chaining algorithms is even harder than just the one. :-) I understand the reasoning behind the idea (make GPU-assisted brute force require, at least, custom code) but those things rarely end well. :-) [21:22:24] To wit the disaster when people chained DES twice without realizing that this made differential cryptanalysis even /easier/ than a single round. :-) [21:22:34] bd808: See if I guessed it correctly what you suggested me to do. :) http://fpaste.org/74785/35324139/ [21:23:40] YuviPanda: i should probably at least check out and install the extension and see if this parses [21:23:44] zeek: Yes but do the PLURAL block too [21:23:59] MatmaRex: yeah, I just merged a vagrant role for it (if you use vagrant) [21:24:41] zeek: ie {{PLURAL:$1|1 result|$1 results}} [21:24:41] https://www.mediawiki.org/wiki/PLURAL:Template:%241 [21:24:52] Yes got it. :) [21:25:04] YuviPanda: i don't :( [21:25:09] MatmaRex: :( [21:25:29] MatmaRex: even then, wikilove is trivial. checkout, set one thing to true in localsettings, done [21:25:36] bah, it looks good [21:25:49] (03CR) 10Bartosz Dziewoński: [C: 032] Remove jquery.elastic [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111534 (owner: 10Yuvipanda) [21:25:54] woo, thanks :) [21:25:57] and i hate this autoresizing crap [21:26:01] MatmaRex: it depends on https://gerrit.wikimedia.org/r/#/c/111511/2 [21:26:04] but that has a dependency, no? [21:26:05] MatmaRex: which is trivial as well... [21:26:15] it removes jquery ui butotns [21:26:16] *buttons [21:26:40] i feel like someone should actually look at that one before merging [21:26:49] can't you bribe some growth guys or something? [21:26:55] MatmaRex: I can localtunnel me to you if you want [21:26:55] bd808: 'showingresultsinrange' => "Showing below up to {{PLURAL:$1|1 result|$1 results}} in range #$2 to #$3.", [21:26:55] https://www.mediawiki.org/wiki/PLURAL:Template:%241 [21:27:04] heh [21:27:11] MatmaRex: let me do that [21:27:25] zeek: That looks right to me [21:27:34] gahhh, no [21:27:40] i'm off to sleep in a few minutes [21:27:48] no merging when i'm sleepy :( [21:28:07] MatmaRex: ah, that's a better excuse, yes :) [21:28:10] MatmaRex: thanks for this merge, though [21:29:16] (03CR) 10PleaseStand: [C: 04-1] Clean Timestamp Fields in mysql (034 comments) [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [21:29:16] (03PS4) 10Adi.iiita: Changed pagination format on Special:MostLinkedCategories From results starting from ABC to results in range ABC to DEF Solved the comments made on revision 3. [core] - 10https://gerrit.wikimedia.org/r/111330 [21:29:25] (03PS1) 10Chad: Actually make Parser::pstPass2() private [core] - 10https://gerrit.wikimedia.org/r/111535 [21:29:25] bd808: ^ [21:29:32] MatmaRex: it's up at https://yuvipanda.localtunnel.me/wiki/Main_Page if you want to take a look :) [21:30:55] MatmaRex: Goodnight :) [21:31:42] zeek: I don't think that your change did what you wanted it to do. :( The only difference between patch set 4 and patch set 3 is that the commit message changed back to the version from patch set 2 [21:32:05] O.o let me see [21:33:38] bd808: I have been told that the commit should not change... this time i modified one file.. so i used git commit --amend. But my git status shows one file unmodified. [21:33:59] modified.. not unmodified [21:34:35] zeek: Ah. Easy to fix. Do `git commit --amend --all` to add changes to the existing commit [21:34:44] ohh ok [21:34:59] Or do `git add ; git commit --amend` [21:35:40] The `--all` flag makes git commit pick up all changed files in the working directory which is often what you'll want to do when amending but not always [21:35:52] (03PS5) 10Adi.iiita: Changed pagination format on Special:MostLinkedCategories From results starting from ABC to results in range ABC to DEF Solved the comments made on revision 3. [core] - 10https://gerrit.wikimedia.org/r/111330 [21:35:52] bd808: --all is very bad practice. use -p instead? also git add -i [21:36:10] did --all :P [21:36:17] it's not a bad practive if you do `git status` first to see what you're committing :D [21:36:44] It can cause interesting things to happen if you habitually keep a dirty tree for sure [21:37:03] yeah, like I do :| :D [21:37:15] I've 376 untracked files now [21:37:16] what does -p does? :) [21:37:58] zeek: it shows you each 'chunk' of change, and asks you if you want to include it in the commit or not :) [21:38:12] understood :) [21:38:21] zeek: do try it out the next time :) [21:38:47] for sure.... its been the first time chatting has made me learn so much :D [21:38:49] zeek: and when you finally conclude it's a royal pita, use some gui to do that instead [21:38:59] MatmaRex: pfft :P [21:39:01] Basically it runs `git add --patch .` before commiting [21:39:03] `git gui` should come by default with your git installation [21:39:23] git lets you do the same thing in a thousand different ways :) try out a few and then figure out what works for you [21:39:26] Ohh no i wanna be the black screen man... with green fonts... :D :D [21:39:30] and remember to not be overwhelmed :) [21:39:35] zeek: \o/ :) [21:39:42] YuviPanda: making people learn git without guis for piecewise committing and viewing history should be prohibited by the geneva convention [21:39:46] All the cool kids use the CLI [21:39:59] MatmaRex: what bd808 said :P [21:40:07] although I like black on white rather than green on black [21:40:24] black on white.. thats stressful to eyes.. avoid it bro [21:40:27] * bd808 runs solarized dark [21:40:56] bd808 is out of the world! ! [21:41:00] :D [21:41:03] zeek: not pure black on white, a combination of darkish colors on a lightish color [21:41:14] but yeah, this is an experiment. I'm usually on monaco theme, which is dark [21:41:37] zeek: YuviPanda does most of his codling in the dark due to power outages so he probably needs the bright screen to see his tea cup [21:41:39] (03PS1) 10Chad: Move blame for $wgTitle up one level to getUserSig() [core] - 10https://gerrit.wikimedia.org/r/111567 [21:41:48] hehe :P [21:41:52] lol :P [21:41:57] bd808: believe it or not, that is actually a consideration when I'm in Chennai... [21:42:07] bd808: although I dont' look at my screen when I crank it up to max brightness [21:42:10] YuviPanda indian.. great me too :) [21:42:17] zeek: hehe :D [21:43:07] Lucknowite... :D bd808, look I found a teammy :P [21:43:09] <^demon|away> 111567 was hairy :) [21:43:13] <^demon|away> Parser titles, ugh. [21:43:17] (03CR) 10jenkins-bot: [V: 04-1] Move blame for $wgTitle up one level to getUserSig() [core] - 10https://gerrit.wikimedia.org/r/111567 (owner: 10Chad) [21:43:35] zeek: YuviPanda is a medawiki-vagrant wizard too so he can help if he's around and you have problems with that again [21:43:58] yeah, very probably. although I wouldn't consider myself a 'wizard', unless it is a wizard in the discworld sense... :) [21:44:37] <^demon|away> Crap, how did I miss that one? [21:45:13] zeek: Don't forget to `git review` that latest update when you're ready [21:45:39] YuviPanda: please help me with this problem http://www.fpaste.org/74792/36679139/ related to vagrant provision. [21:45:44] bd808: I pushed my update PS5... and cant git review it... ssh blocked. :( [21:46:00] YuviPanda: Wizard on work instantly :D [21:46:02] (03CR) 10Yuvipanda: [C: 032] "Thanks for the patch!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/111393 (owner: 10Mattflaschen) [21:46:17] (03Merged) 10jenkins-bot: Use mediawiki.ui.button instead of mediawiki.ui [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/111393 (owner: 10Mattflaschen) [21:46:20] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 90d46cb..85fa839 [extensions] - 10https://gerrit.wikimedia.org/r/111608 [21:46:56] jme: what version of virtualbox and vagrant are you running? [21:46:58] jme: and what OS? [21:47:27] (03CR) 10EBernhardson: [C: 032] Save 'flow-talk-taken-over' message in content language [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111403 (owner: 10Legoktm) [21:47:33] OS: fedora 17 , vagrant- 1.4.3, virtualbox-4.2 [21:47:46] (03Merged) 10jenkins-bot: Save 'flow-talk-taken-over' message in content language [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111403 (owner: 10Legoktm) [21:47:54] It looks to me like virtualbox didn't mount the mediawiki export before jme's puppet run [21:48:24] bd808: so how to fix that..? [21:48:33] yeah, seems that way [21:48:36] Key bit is "Could not open input file: /vagrant/mediawiki/maintenance/insta" [21:48:52] Well… have you tried turning it off and on again :) [21:49:06] jme: you need to install a newer version of virtualbox and vagrant, I think. [21:49:17] jme: yeah, do try turning it off and on, as bd808 suggests :) [21:49:19] vagrant reload, that is [21:49:23] bd808: Please see revision 5. Is it fine? [21:49:29] bd808: yes i did that .. [21:49:43] but no luck [21:49:48] jme: I think you need a newer version of virtualbox [21:49:51] https://gerrit.wikimedia.org/r/#/c/111330/ [21:49:53] current version is 4.3.6, I think [21:55:39] (03PS4) 10Bsitu: Catch exceptions formatting notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111484 (owner: 10EBernhardson) [21:56:09] RFC review meeting in 5 min in #wikimedia-meetbot - propose RFCs to review on https://www.mediawiki.org/wiki/Architecture_meetings/RFC_review_2014-02-05 [21:56:13] YuviPanda: I earlier installed VBox 4.3 but that has some problem with fedora 17 ... so i switced to virtualbox 4.2 [21:56:36] jme: hmm, then you might want to try to try older versions of Vagrant until you find one that works? [21:56:49] jme: you are using the latest version of Vagrant, and that usually expects latest version of Virtualbox [21:58:20] bd808: Everything fine with PS5? https://gerrit.wikimedia.org/r/#/c/111330/ [21:58:23] YuviPanda: ok [21:58:33] (03PS6) 10BryanDavis: Show range start and end in special page pagination [core] - 10https://gerrit.wikimedia.org/r/111330 (owner: 10Adi.iiita) [21:58:51] (03PS7) 10Adi.iiita: Show range start and end in special page pagination [core] - 10https://gerrit.wikimedia.org/r/111330 [21:58:58] jme: i use vb 4.2 on fed 17. works fine for me. [21:59:28] (03CR) 10BryanDavis: [C: 032] Show range start and end in special page pagination [core] - 10https://gerrit.wikimedia.org/r/111330 (owner: 10Adi.iiita) [21:59:46] zeek: You are +2 and headed for master! [22:00:04] I fiddled with your commit message a bit before approving [22:00:16] bd808: ohh thanks. :) [22:01:02] I am trying to learn all the conventions of wikimedia slowly. [22:01:08] :) [22:01:18] Using that "Action headline\n\nDescription" format makes the git history more informative [22:01:23] qgil: meetbot isn't in the meetbot channel :) [22:02:04] Ok would do that next time along with git commit -p :) [22:02:55] zeek: congrats on your first patch :) [22:03:05] brion, mmm wait [22:03:13] okay, now sleepy time for me [22:03:18] qgil: we're continuing "manually" for now, it's ok :) [22:03:25] (03Merged) 10jenkins-bot: Show range start and end in special page pagination [core] - 10https://gerrit.wikimedia.org/r/111330 (owner: 10Adi.iiita) [22:03:51] YuviPanda: Thank you. I will try best to make more. :) Have a good night. [22:03:56] :) [22:04:11] brion, no idea, and hashar has a reason to keep reminding us that such setup if experimental and unsupported... [22:04:28] yeah. next time we'll check it beforehand :D [22:06:45] (03PS1) 10Matthias Mullie: Inject Language into notification controller [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111610 [22:06:48] (03PS1) 10Matthias Mullie: Correct docs [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111611 [22:06:51] (03PS1) 10Matthias Mullie: Remove redundant params [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111612 [22:06:54] (03PS1) 10Matthias Mullie: Instead of passing string, pass title revision object [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111613 [22:06:57] (03PS1) 10Matthias Mullie: Truncate content before storing event into DB [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111614 [22:07:00] (03PS1) 10Matthias Mullie: Limit mentioned users as to no fill event_extra [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111615 [22:07:16] Does anyone besides hashar have access to integration-meetbot.pmtpa.wmflabs to restart meetbot? [22:07:34] Instructions at https://bugzilla.wikimedia.org/show_bug.cgi?id=46377#c6 [22:08:06] (03CR) 10Kaldari: [C: 04-1] Remove jquery.elastic (031 comment) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111534 (owner: 10Yuvipanda) [22:11:12] (03PS2) 10Yuvipanda: Remove jquery.elastic [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111534 [22:11:23] (03CR) 10Kaldari: [C: 032 V: 032] Remove jquery.elastic [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111534 (owner: 10Yuvipanda) [22:18:11] (03CR) 10Kaldari: [C: 04-1] "Couple issues:" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111511 (owner: 10Yuvipanda) [22:19:16] spage: Mark and I are jsducking now, feel free to join us near the 3rd Fl hammock [22:22:02] (03PS1) 10Matthias Mullie: Add some more clarification on why event_extra can't be too large [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111616 [22:28:50] (03PS2) 10Se4598: update RELEASE-NOTES-1.22 for bug 60543 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110408 [22:29:12] (03PS3) 10Yuvipanda: Make buttons use mw.ui buttons [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111511 [22:29:14] (03PS3) 10Yuvipanda: Remove jquery.elastic [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111534 [22:29:33] (03CR) 10Se4598: "PS rebased" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110408 (owner: 10Se4598) [22:29:57] (03CR) 10Freakolowsky: "I'll have a look at it in the morning." [core] - 10https://gerrit.wikimedia.org/r/110991 (owner: 10Umherirrender) [22:30:19] (03CR) 10Kaldari: [C: 032 V: 032] Remove jquery.elastic [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111534 (owner: 10Yuvipanda) [22:33:01] (03CR) 10Kaldari: [C: 032 V: 032] Make buttons use mw.ui buttons [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111511 (owner: 10Yuvipanda) [22:34:36] (03PS3) 10EBernhardson: Don't error out on duplicate id's [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111224 [22:35:41] Krinkle: another day, another lightning deploy :-/ [22:36:52] (03PS1) 10MarkTraceur: Added jsduck docs to mediawiki.debug.js [core] - 10https://gerrit.wikimedia.org/r/111620 [22:44:14] (03PS1) 10Kaldari: Replacing mw-ui-primary with mw-ui-progressive [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111622 [22:45:12] (03CR) 10Kaldari: [C: 032 V: 032] Replacing mw-ui-primary with mw-ui-progressive [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/111622 (owner: 10Kaldari) [22:46:18] (03CR) 10Matthias Mullie: [C: 032] Don't error out on duplicate id's [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111224 (owner: 10EBernhardson) [22:46:28] (03Merged) 10jenkins-bot: Don't error out on duplicate id's [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111224 (owner: 10EBernhardson) [22:47:12] (03CR) 10Trevor Parscal: [C: 032] "Works fine" [core] - 10https://gerrit.wikimedia.org/r/95822 (owner: 10Matanya) [22:51:49] (03PS1) 10MarkTraceur: Add jsduck documentation to mediawiki.feedback.js [core] - 10https://gerrit.wikimedia.org/r/111624 [22:51:59] Krinkle: 2-0 me, better start catching up [22:55:20] (03PS1) 10EBernhardson: Prevent fatal errors in urlgenerator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111625 [22:56:58] is there a git configuration that will cause git fetch to fail if the remote repository shares no common commits with the local one? [22:58:52] (03CR) 10Gergő Tisza: [C: 04-2] "As pointed out earlier, please submit upstream first." [core] - 10https://gerrit.wikimedia.org/r/110883 (owner: 10AalekhN) [22:59:41] (03PS10) 10Ori.livneh: Add role::wikimania_scholarships [vagrant] - 10https://gerrit.wikimedia.org/r/108067 (owner: 10BryanDavis) [23:01:21] (03PS2) 10EBernhardson: Prevent fatal errors in urlgenerator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111625 [23:01:24] (03PS1) 10MarkTraceur: Add jsduck docs to htmlform [core] - 10https://gerrit.wikimedia.org/r/111627 [23:01:26] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 90d46cb..10fec23 [extensions] - 10https://gerrit.wikimedia.org/r/111628 [23:01:28] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 90d46cb..10fec23 [extensions] - 10https://gerrit.wikimedia.org/r/111628 (owner: 10Jenkins-mwext-sync) [23:01:38] (03CR) 10Matthias Mullie: [C: 04-1] "There's 2 issues (1 of which quite important: submissions with params don't work)" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110501 (owner: 10EBernhardson) [23:01:53] (03CR) 10Jforrester: "Why didn't this update get committed?" [extensions] - 10https://gerrit.wikimedia.org/r/111608 (owner: 10Jenkins-mwext-sync) [23:01:59] (03CR) 10Ori.livneh: [C: 032] "I think the need for a mysql role is probably a code smell -- an indication that we got something wrong. Whatever it is, it's nothing to d" [vagrant] - 10https://gerrit.wikimedia.org/r/108067 (owner: 10BryanDavis) [23:02:20] ^ bd808 fyi [23:02:26] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 10fec23..64fad76 [extensions] - 10https://gerrit.wikimedia.org/r/111629 [23:02:29] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 10fec23..64fad76 [extensions] - 10https://gerrit.wikimedia.org/r/111629 (owner: 10Jenkins-mwext-sync) [23:02:36] ori: Neat! [23:02:43] see comment tho [23:02:50] (03Merged) 10jenkins-bot: Add role::wikimania_scholarships [vagrant] - 10https://gerrit.wikimedia.org/r/108067 (owner: 10BryanDavis) [23:03:29] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 64fad76..8f43596 [extensions] - 10https://gerrit.wikimedia.org/r/111630 [23:03:31] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 64fad76..8f43596 [extensions] - 10https://gerrit.wikimedia.org/r/111630 (owner: 10Jenkins-mwext-sync) [23:03:37] mysql being something that vagrant should handle differently… probably. I think about it at some point in the not too distant future. [23:04:28] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 8f43596..20d6df9 [extensions] - 10https://gerrit.wikimedia.org/r/111631 [23:04:30] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 8f43596..20d6df9 [extensions] - 10https://gerrit.wikimedia.org/r/111631 (owner: 10Jenkins-mwext-sync) [23:04:34] (03CR) 10Matthias Mullie: [C: 032] Prevent fatal errors in urlgenerator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111625 (owner: 10EBernhardson) [23:04:40] (03PS1) 10Krinkle: qunit: Move modules exclusively for $wgEnableJavaScriptTest to test registry [core] - 10https://gerrit.wikimedia.org/r/111632 [23:04:42] (03PS1) 10Krinkle: qunit: Preserve context in QUnit module environment override [core] - 10https://gerrit.wikimedia.org/r/111633 [23:04:44] (03PS1) 10Krinkle: qunit: Add SinonJS utility [core] - 10https://gerrit.wikimedia.org/r/111634 [23:04:46] (03PS1) 10Krinkle: mediawiki.api.test: Use sinon sandbox for unit tests [core] - 10https://gerrit.wikimedia.org/r/111635 [23:04:48] (03PS1) 10Krinkle: [WIP] mediawiki.api: Refactor getToken [core] - 10https://gerrit.wikimedia.org/r/111636 [23:05:30] (03Merged) 10jenkins-bot: Prevent fatal errors in urlgenerator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111625 (owner: 10EBernhardson) [23:05:46] (03PS2) 10Matthias Mullie: (bug 60906) Truncate content before storing event into DB [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111614 [23:09:33] (03CR) 10Alex Monk: Check current name of user instead of blindly using user_text (could've been renamed since) (031 comment) [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/111514 (owner: 10Alex Monk) [23:11:59] (03CR) 10jenkins-bot: [V: 04-1] qunit: Add SinonJS utility [core] - 10https://gerrit.wikimedia.org/r/111634 (owner: 10Krinkle) [23:12:41] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.api.test: Use sinon sandbox for unit tests [core] - 10https://gerrit.wikimedia.org/r/111635 (owner: 10Krinkle) [23:13:06] (03CR) 10jenkins-bot: [V: 04-1] [WIP] mediawiki.api: Refactor getToken [core] - 10https://gerrit.wikimedia.org/r/111636 (owner: 10Krinkle) [23:13:22] (03PS3) 10EBernhardson: Switch to underscores, because php mangles everything else [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110501 [23:13:25] (03CR) 10jenkins-bot: [V: 04-1] Switch to underscores, because php mangles everything else [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110501 (owner: 10EBernhardson) [23:14:19] (03CR) 10EBernhardson: [C: 032] Inject Language into notification controller [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111610 (owner: 10Matthias Mullie) [23:14:30] (03Merged) 10jenkins-bot: Inject Language into notification controller [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111610 (owner: 10Matthias Mullie) [23:14:37] (03CR) 10EBernhardson: [C: 032] Correct docs [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111611 (owner: 10Matthias Mullie) [23:14:47] (03Merged) 10jenkins-bot: Correct docs [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111611 (owner: 10Matthias Mullie) [23:15:33] (03PS7) 10Gergő Tisza: Add jsduck support for MediaViewer [vagrant] - 10https://gerrit.wikimedia.org/r/108858 [23:17:55] (03CR) 10MarkTraceur: [C: 032] "Thanks, Krinkle!" [core] - 10https://gerrit.wikimedia.org/r/111632 (owner: 10Krinkle) [23:18:31] (03PS4) 10Phuedx: Update onboarding CTA impression logging. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110580 [23:18:43] (03CR) 10Mattflaschen: "Rebased so it would be on top of the populate script." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110580 (owner: 10Phuedx) [23:20:17] (03CR) 10EBernhardson: [C: 032] Remove redundant params [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111612 (owner: 10Matthias Mullie) [23:20:24] (03CR) 10MarkTraceur: [C: 032] qunit: Preserve context in QUnit module environment override [core] - 10https://gerrit.wikimedia.org/r/111633 (owner: 10Krinkle) [23:20:32] (03Merged) 10jenkins-bot: Remove redundant params [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111612 (owner: 10Matthias Mullie) [23:20:59] (03CR) 10Legoktm: "Is there a reason this is just to a wmf/ branch and not master?" (031 comment) [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111614 (owner: 10Matthias Mullie) [23:21:32] (03PS1) 10Krinkle: mediawiki.page.watch.ajax: Add jsduck documentation [core] - 10https://gerrit.wikimedia.org/r/111638 [23:22:20] (03Merged) 10jenkins-bot: qunit: Move modules exclusively for $wgEnableJavaScriptTest to test registry [core] - 10https://gerrit.wikimedia.org/r/111632 (owner: 10Krinkle) [23:23:11] (03CR) 10Matthias Mullie: "mmh - there isn't; mistake on my part, I'll fix that" [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111614 (owner: 10Matthias Mullie) [23:24:15] (03Merged) 10jenkins-bot: qunit: Preserve context in QUnit module environment override [core] - 10https://gerrit.wikimedia.org/r/111633 (owner: 10Krinkle) [23:24:16] (03CR) 10Matthias Mullie: No-js tweaks (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110421 (owner: 10EBernhardson) [23:24:33] (03PS2) 10Matthias Mullie: No-js tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110421 (owner: 10EBernhardson) [23:24:56] (03CR) 10Matthias Mullie: [C: 031] "I'm happy with it; if my addition was ok, +2 the patch" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110421 (owner: 10EBernhardson) [23:25:44] (03CR) 10Matthias Mullie: [C: 032] Catch exceptions formatting notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111484 (owner: 10EBernhardson) [23:26:30] (03Merged) 10jenkins-bot: Catch exceptions formatting notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111484 (owner: 10EBernhardson) [23:26:33] (03CR) 10jenkins-bot: [V: 04-1] No-js tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110421 (owner: 10EBernhardson) [23:26:38] rdwrer: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/CONTRIBUTING.md [23:26:47] Krinkle: You're alive! [23:26:53] Krinkle: You have a deployment window in 34 minutes [23:27:32] What am I deploying? [23:28:04] (03CR) 10MarkTraceur: [C: 032] mediawiki.page.watch.ajax: Add jsduck documentation [core] - 10https://gerrit.wikimedia.org/r/111638 (owner: 10Krinkle) [23:28:49] (03CR) 10Matthias Mullie: (bug 60906) Truncate content before storing event into DB (031 comment) [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111614 (owner: 10Matthias Mullie) [23:29:03] (03PS1) 10Matthias Mullie: Revert "Inject Language into notification controller" [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111639 [23:29:06] (03PS1) 10EBernhardson: Revert "Remove redundant params" [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111640 [23:29:09] (03PS1) 10Matthias Mullie: Revert "Correct docs" [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111641 [23:29:13] (03CR) 10EBernhardson: [C: 032] Revert "Remove redundant params" [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111640 (owner: 10EBernhardson) [23:29:26] (03PS1) 10EBernhardson: Revert "Correct docs" [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111642 [23:29:32] (03Merged) 10jenkins-bot: Revert "Remove redundant params" [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111640 (owner: 10EBernhardson) [23:29:35] (03CR) 10EBernhardson: [C: 032] Revert "Correct docs" [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111642 (owner: 10EBernhardson) [23:29:43] (03Abandoned) 10Matthias Mullie: Revert "Inject Language into notification controller" [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111639 (owner: 10Matthias Mullie) [23:29:46] (03Merged) 10jenkins-bot: Revert "Correct docs" [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111642 (owner: 10EBernhardson) [23:29:52] (03Abandoned) 10Matthias Mullie: Revert "Correct docs" [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111641 (owner: 10Matthias Mullie) [23:30:24] (03PS1) 10EBernhardson: Revert "Inject Language into notification controller" [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111643 [23:30:30] (03CR) 10EBernhardson: [C: 032] Revert "Inject Language into notification controller" [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111643 (owner: 10EBernhardson) [23:30:40] (03Merged) 10jenkins-bot: Revert "Inject Language into notification controller" [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111643 (owner: 10EBernhardson) [23:31:35] (03Merged) 10jenkins-bot: mediawiki.page.watch.ajax: Add jsduck documentation [core] - 10https://gerrit.wikimedia.org/r/111638 (owner: 10Krinkle) [23:33:22] (03PS4) 10Chad: Make abstract Config class truly implementation-agnostic [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [23:33:27] (03CR) 10Chad: Make abstract Config class truly implementation-agnostic (039 comments) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [23:33:37] (03PS2) 10Krinkle: mediawiki.htmlform: Add jsduck docs [core] - 10https://gerrit.wikimedia.org/r/111627 (owner: 10MarkTraceur) [23:33:40] (03CR) 10Krinkle: [C: 04-1] mediawiki.htmlform: Add jsduck docs (032 comments) [core] - 10https://gerrit.wikimedia.org/r/111627 (owner: 10MarkTraceur) [23:33:42] (03PS1) 10Matthias Mullie: Inject Language into notification controller [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111645 [23:33:45] (03PS1) 10Matthias Mullie: Correct docs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111646 [23:33:48] (03PS1) 10Matthias Mullie: Remove redundant params [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111647 [23:33:51] (03PS1) 10Matthias Mullie: Instead of passing string, pass title revision object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111648 [23:33:54] (03PS1) 10Matthias Mullie: (bug 60906) Truncate content before storing event into DB [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111649 [23:33:57] (03PS1) 10Matthias Mullie: Limit mentioned users as to no fill event_extra [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111650 [23:34:25] (03Abandoned) 10Matthias Mullie: Instead of passing string, pass title revision object [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111613 (owner: 10Matthias Mullie) [23:34:34] (03Abandoned) 10Matthias Mullie: (bug 60906) Truncate content before storing event into DB [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111614 (owner: 10Matthias Mullie) [23:34:42] (03Abandoned) 10Matthias Mullie: Limit mentioned users as to no fill event_extra [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111615 (owner: 10Matthias Mullie) [23:35:21] (03PS3) 10AndyRussG: No undeletion of courses of deleted institutions [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110143 [23:35:33] (03CR) 10jenkins-bot: [V: 04-1] Make abstract Config class truly implementation-agnostic [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [23:36:12] (03PS2) 10Krinkle: qunit: Add SinonJS utility [core] - 10https://gerrit.wikimedia.org/r/111634 [23:36:36] (03CR) 10EBernhardson: [C: 032] Inject Language into notification controller [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111645 (owner: 10Matthias Mullie) [23:36:50] (03PS2) 10Krinkle: mediawiki.api.test: Use sinon sandbox for unit tests [core] - 10https://gerrit.wikimedia.org/r/111635 [23:37:02] (03PS2) 10Krinkle: [WIP] mediawiki.api: Refactor getToken [core] - 10https://gerrit.wikimedia.org/r/111636 [23:37:09] (03PS5) 10Chad: Make abstract Config class truly implementation-agnostic [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [23:37:11] (03CR) 10EBernhardson: [C: 032] Correct docs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111646 (owner: 10Matthias Mullie) [23:37:23] (03CR) 10EBernhardson: [C: 032] Remove redundant params [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111647 (owner: 10Matthias Mullie) [23:37:26] (03CR) 10Krinkle: "Added upstream lib to jshintignore" [core] - 10https://gerrit.wikimedia.org/r/111634 (owner: 10Krinkle) [23:38:33] (03PS3) 10MarkTraceur: mediawiki.htmlform: Add jsduck docs [core] - 10https://gerrit.wikimedia.org/r/111627 [23:38:42] (03PS3) 10Matthias Mullie: No-js tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110421 (owner: 10EBernhardson) [23:38:56] (03Merged) 10jenkins-bot: Inject Language into notification controller [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111645 (owner: 10Matthias Mullie) [23:38:59] (03Merged) 10jenkins-bot: Correct docs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111646 (owner: 10Matthias Mullie) [23:39:11] Krinkle: did you mean to put "Work on core jsduck patches" in the engineering calendar [23:39:57] let me guess... he missed the "d" by one key :D [23:40:22] (03CR) 10Halfak: "No event appears when the user loads on a special page and not CTA was shown. I see how this was unclear in the old description. I've up" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110580 (owner: 10Phuedx) [23:40:47] rdwrer: https://github.com/Krinkle/dotfiles/blob/8f3fa0357ed17246d0d762d2ee809b4dc455f403/hosts/KrinkleMac/modules/setup.sh#L25-L26 [23:41:04] (03Merged) 10jenkins-bot: Remove redundant params [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111647 (owner: 10Matthias Mullie) [23:41:48] (03CR) 10jenkins-bot: [V: 04-1] Make abstract Config class truly implementation-agnostic [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [23:41:51] TimStarling: Yes, I moved it from various personal calendars there since more people wanted in on it. Mark and Spage both expressed interest and others are welcome to join the sprint/duckathon as well (on third floor collab space or virtually) [23:42:07] Maybe it should be on an office-specific calendar or a less wide one [23:42:11] ok [23:42:37] (03CR) 10Swalling: ""No event appears when the user loads on a special page and not CTA was shown. I see how this was unclear in the old description. I've u" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110580 (owner: 10Phuedx) [23:43:07] (03CR) 10jenkins-bot: [V: 04-1] [WIP] mediawiki.api: Refactor getToken [core] - 10https://gerrit.wikimedia.org/r/111636 (owner: 10Krinkle) [23:43:30] TimStarling: I've renamed it to be less adhoc [23:44:44] I don't mind, it just looked like an error [23:44:48] (03PS23) 10Prtksxna: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 [23:44:50] (03PS5) 10Prtksxna: Add animation to NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/110675 [23:45:59] (03CR) 10Prtksxna: "Made the thumbnail size 300!" (034 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [23:46:59] (03CR) 10Halfak: "Nevermind that last comment. It was due to user error." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110580 (owner: 10Phuedx) [23:49:00] (03CR) 10Matthias Mullie: [C: 031] "I'm happy with it; if my addition was ok, +2 the patch" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110421 (owner: 10EBernhardson) [23:50:29] (03CR) 10Halfak: [C: 031] Update onboarding CTA impression logging. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110580 (owner: 10Phuedx) [23:50:45] (03PS4) 10EBernhardson: Switch to underscores, because php mangles everything else [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110501 [23:51:16] (03CR) 10Matthias Mullie: Switch to underscores, because php mangles everything else (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110501 (owner: 10EBernhardson) [23:51:47] (03PS5) 10EBernhardson: Switch to underscores, because php mangles everything else [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110501 [23:53:09] (03CR) 10AndyRussG: "Added in this patch set: prevent users from restoring courses with deleted institutions by manually entering the URL to restore them." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110143 (owner: 10AndyRussG) [23:54:34] (03CR) 10EBernhardson: [C: 032] No-js tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110421 (owner: 10EBernhardson) [23:54:44] (03Merged) 10jenkins-bot: No-js tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110421 (owner: 10EBernhardson) [23:57:16] (03PS3) 10Krinkle: [WIP] mediawiki.api: Refactor getToken [core] - 10https://gerrit.wikimedia.org/r/111636 [23:57:39] (03CR) 10EBernhardson: [C: 032] Add some more clarification on why event_extra can't be too large [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111616 (owner: 10Matthias Mullie) [23:57:47] (03CR) 10TTO: "Certainly, FA/GA formatting is link-specific not page-specific, but other types of formatting may depend on which page is being viewed." [core] - 10https://gerrit.wikimedia.org/r/111001 (owner: 10Bene) [23:58:21] (03Merged) 10jenkins-bot: Add some more clarification on why event_extra can't be too large [extensions/Echo] - 10https://gerrit.wikimedia.org/r/111616 (owner: 10Matthias Mullie) [23:59:54] (03CR) 10TTO: [C: 031] "Whoops, I see $this->getTitle() was added, +1 then." [core] - 10https://gerrit.wikimedia.org/r/111001 (owner: 10Bene)