[08:05:38] (03PS3) 10Physikerwelt: remove armourMath [extensions/Math] - 10https://gerrit.wikimedia.org/r/111119 [08:08:55] (03CR) 10Frédéric Wang: "I believe the point was exactly to break the Math 2.0 patch into small independent chunk to make review easier..." [extensions/Math] - 10https://gerrit.wikimedia.org/r/87519 (owner: 10Liangent) [08:09:55] (03Abandoned) 10Liangent: Remove one $wgContLang usage. [extensions/Math] - 10https://gerrit.wikimedia.org/r/87519 (owner: 10Liangent) [08:12:15] (03PS4) 10Frédéric Wang: remove armourMath and wgContLang (bug 60799) [extensions/Math] - 10https://gerrit.wikimedia.org/r/111119 (owner: 10Physikerwelt) [08:13:43] (03CR) 10Frédéric Wang: "Sorry, I just made the same change as you at the same time..." [extensions/Math] - 10https://gerrit.wikimedia.org/r/111119 (owner: 10Physikerwelt) [08:15:43] (03CR) 10Physikerwelt: [C: 031] "the history says that you imporved the commit message;-)" [extensions/Math] - 10https://gerrit.wikimedia.org/r/111119 (owner: 10Physikerwelt) [08:19:04] (03CR) 10Siebrand: [C: 04-1] Allow moving category pages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111096 (owner: 10Jackmcbarn) [08:21:34] (03CR) 10Frédéric Wang: Introduce $wgMathValidModes to adjust the selectable math rendering modes in user preferences (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/109488 (owner: 10Physikerwelt) [08:29:13] (03CR) 10Physikerwelt: [C: 04-1] Introduce $wgMathValidModes to adjust the selectable math rendering modes in user preferences (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/109488 (owner: 10Physikerwelt) [08:37:10] (03PS10) 10Physikerwelt: Introduce $wgMathValidModes to adjust the selectable math rendering modes in user preferences [extensions/Math] - 10https://gerrit.wikimedia.org/r/109488 [08:39:30] (03CR) 10TTO: "Which for loop are you referring to? I don't follow." [core] - 10https://gerrit.wikimedia.org/r/110832 (owner: 10TTO) [08:41:38] (03CR) 10Frédéric Wang: [C: 031] "Thanks." [extensions/Math] - 10https://gerrit.wikimedia.org/r/109488 (owner: 10Physikerwelt) [08:42:41] (03CR) 10Jforrester: [C: 032] Localisation updates from https://translatewiki.net. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/110851 (owner: 10L10n-bot) [08:42:43] (03CR) 10TTO: "If you mean that the Title object created in each iteration of the `foreach` loop is lost, I don't see that as a problem. Consumers of thi" [core] - 10https://gerrit.wikimedia.org/r/110832 (owner: 10TTO) [08:42:45] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/110851 (owner: 10L10n-bot) [09:04:19] (03PS1) 10Nemo bis: Tweak documentation for Title::getLocalUrl [core] - 10https://gerrit.wikimedia.org/r/111164 [09:13:25] (03CR) 10Nikerabbit: [C: 04-1] Tweak documentation for Title::getLocalUrl (032 comments) [core] - 10https://gerrit.wikimedia.org/r/111164 (owner: 10Nemo bis) [09:16:39] (03PS2) 10Nemo bis: Tweak documentation for Title::getLocalUrl [core] - 10https://gerrit.wikimedia.org/r/111164 [09:17:16] (03CR) 10Nemo bis: Tweak documentation for Title::getLocalUrl (032 comments) [core] - 10https://gerrit.wikimedia.org/r/111164 (owner: 10Nemo bis) [09:25:03] (03CR) 10Nikerabbit: Typography updates from typography refresh meeting (033 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/108155 (owner: 10Kaldari) [09:27:49] (03CR) 10Nikerabbit: "Legos are never a solution." [core] - 10https://gerrit.wikimedia.org/r/110279 (owner: 10Bartosz Dziewoński) [09:33:16] (03CR) 10Nikerabbit: Tweak documentation for Title::getLocalUrl (032 comments) [core] - 10https://gerrit.wikimedia.org/r/111164 (owner: 10Nemo bis) [09:34:30] (03PS3) 10Bartosz Dziewoński: mediawiki.searchSuggest: Only handle Vector's fulltext hack on Vector [core] - 10https://gerrit.wikimedia.org/r/110965 [09:34:36] (03CR) 10Ori.livneh: [C: 032] mediawiki.searchSuggest: Only handle Vector's fulltext hack on Vector [core] - 10https://gerrit.wikimedia.org/r/110965 (owner: 10Bartosz Dziewoński) [09:38:46] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.searchSuggest: Only handle Vector's fulltext hack on Vector [core] - 10https://gerrit.wikimedia.org/r/110965 (owner: 10Bartosz Dziewoński) [09:42:28] (03CR) 10Nikerabbit: "If you mean WMF ops, I don't think they even log deprecation warnings." [core] - 10https://gerrit.wikimedia.org/r/106279 (owner: 10Bartosz Dziewoński) [09:42:56] (03CR) 10Ori.livneh: "recheck" [core] - 10https://gerrit.wikimedia.org/r/110965 (owner: 10Bartosz Dziewoński) [09:50:48] (03CR) 10Ori.livneh: mediawiki.searchSuggest: Only handle Vector's fulltext hack on Vector [core] - 10https://gerrit.wikimedia.org/r/110965 (owner: 10Bartosz Dziewoński) [09:50:53] (03CR) 10Ori.livneh: [C: 032] mediawiki.searchSuggest: Only handle Vector's fulltext hack on Vector [core] - 10https://gerrit.wikimedia.org/r/110965 (owner: 10Bartosz Dziewoński) [09:54:15] (03Merged) 10jenkins-bot: mediawiki.searchSuggest: Only handle Vector's fulltext hack on Vector [core] - 10https://gerrit.wikimedia.org/r/110965 (owner: 10Bartosz Dziewoński) [09:55:14] (03CR) 10Nemo bis: Tweak documentation for Title::getLocalUrl (032 comments) [core] - 10https://gerrit.wikimedia.org/r/111164 (owner: 10Nemo bis) [10:23:55] (03CR) 10Ori.livneh: Rewrite rendering of Vector simple search (031 comment) [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński) [10:24:05] (03PS2) 10PleaseStand: Use nesting in search.less again [core] - 10https://gerrit.wikimedia.org/r/110986 [10:24:41] (03CR) 10Ori.livneh: [C: 032] Use nesting in search.less again [core] - 10https://gerrit.wikimedia.org/r/110986 (owner: 10PleaseStand) [10:28:18] (03Merged) 10jenkins-bot: Use nesting in search.less again [core] - 10https://gerrit.wikimedia.org/r/110986 (owner: 10PleaseStand) [10:36:16] (03PS3) 10Hashar: Adding lint jobs to more fundraising repos [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/111097 (owner: 10Mwalker) [10:40:49] (03CR) 10PleaseStand: "That change was merged, so this one can be abandoned." [core] - 10https://gerrit.wikimedia.org/r/110963 (owner: 10Bartosz Dziewoński) [10:44:10] (03CR) 10Hashar: [C: 032] "Listed jobs being created in the commit message." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/111097 (owner: 10Mwalker) [10:44:29] (03Merged) 10jenkins-bot: Adding lint jobs to more fundraising repos [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/111097 (owner: 10Mwalker) [10:45:42] (03PS2) 10Hashar: Run additional, non-voting lint jobs for mediawiki-vagrant [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/109430 (owner: 10Adamw) [10:45:55] (03PS2) 10Hashar: Add jobs for mediawiki-vagrant erblint and "rake lint" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/109428 (owner: 10Adamw) [10:47:03] (03CR) 10Ori.livneh: "But see the comment in parse.py: nuria: ^ [10:47:18] holaaa [10:50:11] (03PS3) 10Pastakhov: Add jobs for mw/ext/PhpTags and mw/ext/PhpTagsFunctions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/110164 [10:50:58] (03PS1) 10Physikerwelt: Fix: Allow
as valid Math output [extensions/Math] - 10https://gerrit.wikimedia.org/r/111171 [10:51:03] (03Abandoned) 10Bartosz Dziewoński: Vector: Remove spurious CSS rule [core] - 10https://gerrit.wikimedia.org/r/110963 (owner: 10Bartosz Dziewoński) [10:56:14] (03CR) 10Bartosz Dziewoński: mediawiki.util: Don't hardcode selectors in updateTooltipAccessKeys if possible (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110377 (owner: 10Bartosz Dziewoński) [10:58:10] (03CR) 10Bartosz Dziewoński: Add title to list item of language link (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111159 (owner: 10Bene) [10:59:38] (03PS7) 10Bartosz Dziewoński: Remove HTML back-compat styles from I5fe0543e [core] - 10https://gerrit.wikimedia.org/r/82102 [11:01:22] (03CR) 10Bartosz Dziewoński: "To be merged on 13 March." [core] - 10https://gerrit.wikimedia.org/r/82102 (owner: 10Bartosz Dziewoński) [11:02:25] (03PS1) 10Ori.livneh: Remove obsoleted files and config variables [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/111172 [11:02:49] (03CR) 10Bartosz Dziewoński: "Thanks for the followups and quick reviews." [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński) [11:03:52] (03PS2) 10Bartosz Dziewoński: Vector: ::-moz-placeholder is a pseudoelement since Firefox 19 [core] - 10https://gerrit.wikimedia.org/r/110964 [11:05:09] (03CR) 10Bartosz Dziewoński: "https://gerrit.wikimedia.org/r/#/c/110986/ seems to do the same thing and has been merged already." [core] - 10https://gerrit.wikimedia.org/r/110973 (owner: 10Jdlrobson) [11:06:35] (03Abandoned) 10Bartosz Dziewoński: Rewrite search.less again with nesting [core] - 10https://gerrit.wikimedia.org/r/110973 (owner: 10Jdlrobson) [11:09:30] (03CR) 10Nuria: [C: 032] Remove obsoleted files and config variables [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/111172 (owner: 10Ori.livneh) [11:09:59] (03Merged) 10jenkins-bot: Remove obsoleted files and config variables [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/111172 (owner: 10Ori.livneh) [11:18:05] (03CR) 10Siebrand: Add diff view of changes to board header (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 (owner: 10Bsitu) [11:18:15] (03CR) 10Phuedx: [C: 04-1] "This looks good, but I don't think that L32 is required any more as well." (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111105 (owner: 10Mattflaschen) [11:19:17] (03CR) 10Bartosz Dziewoński: "Can I ask this to be held until https://gerrit.wikimedia.org/r/#/c/82100/ is deployed, so in case it breaks something horribly users have " [core] - 10https://gerrit.wikimedia.org/r/99422 (owner: 1001tonythomas) [11:19:37] !technext [11:19:38] https://meta.wikimedia.org/wiki/Tech/News/Next [11:22:03] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/99422 (owner: 1001tonythomas) [11:23:11] (03CR) 10Siebrand: "@Tony: Yes. And while you're at it, "valid TIFF" should probably be changed to "valid TIFF file."." [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/107039 (owner: 1001tonythomas) [11:26:50] (03PS2) 10Ori.livneh: Use HMAC SHA1 with rotating key to hash IP addresses [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/110700 [11:28:53] (03CR) 10Bartosz Dziewoński: "Posted to tech news: https://meta.wikimedia.org/wiki/Tech/News/2014/07" [core] - 10https://gerrit.wikimedia.org/r/99422 (owner: 1001tonythomas) [11:28:55] (03CR) 10Bartosz Dziewoński: "Posted to tech news: https://meta.wikimedia.org/wiki/Tech/News/2014/07" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński) [11:29:27] (03CR) 10Physikerwelt: "@Amire80: Could you please check if there are language specific effects on removing the armourMath function. I found the function in langu" [extensions/Math] - 10https://gerrit.wikimedia.org/r/111119 (owner: 10Physikerwelt) [11:40:20] (03CR) 10Nikerabbit: Tweak documentation for Title::getLocalUrl (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111164 (owner: 10Nemo bis) [11:50:44] (03CR) 10Ori.livneh: "Nuria reminds me that the 90-day argument has another side to it altogether, which is consistency with other systems. I think that's fine," [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/110700 (owner: 10Ori.livneh) [11:51:25] (03CR) 10Nuria: [C: 032] Use HMAC SHA1 with rotating key to hash IP addresses [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/110700 (owner: 10Ori.livneh) [11:51:54] (03Merged) 10jenkins-bot: Use HMAC SHA1 with rotating key to hash IP addresses [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/110700 (owner: 10Ori.livneh) [11:54:46] (03PS3) 10Nemo bis: Tweak documentation for Title::getLocalUrl [core] - 10https://gerrit.wikimedia.org/r/111164 [11:55:42] (03CR) 10Aklapper: [C: 032 V: 031] "I see. I like this a lot, thanks!" [wikimedia/bugzilla/triagescripts] - 10https://gerrit.wikimedia.org/r/110702 (owner: 10Merlijn van Deen) [11:56:06] (03CR) 10Aklapper: [V: 032] "I see. I like this a lot, thanks!" [wikimedia/bugzilla/triagescripts] - 10https://gerrit.wikimedia.org/r/110702 (owner: 10Merlijn van Deen) [11:56:13] (03CR) 10Nemo bis: Tweak documentation for Title::getLocalUrl (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111164 (owner: 10Nemo bis) [11:57:05] (03CR) 10Aklapper: "I have no idea about Jenkins/Gerrit stuff, so feel free to commit directly to the Git repository." [wikimedia/bugzilla/triagescripts] - 10https://gerrit.wikimedia.org/r/110702 (owner: 10Merlijn van Deen) [12:03:07] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. See inline comments. Bartosz has also spotted this already." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/107360 (owner: 1001tonythomas) [12:04:22] (03CR) 10Phuedx: [C: 032] Import populate script from Gist [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/106479 (owner: 10Mattflaschen) [12:04:25] (03Merged) 10jenkins-bot: Import populate script from Gist [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/106479 (owner: 10Mattflaschen) [12:09:44] (03CR) 10Siebrand: Add editmyoptions right to a new grant (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/107205 (owner: 10CSteipp) [12:26:03] (03CR) 1001tonythomas: "I will modify" [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [12:34:22] (03PS10) 10Lekshmi: Changed deprecated $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/109903 [12:48:36] (03CR) 10Siebrand: [C: 04-1] ChangesListSpecialPage: Remove all functionality for generating feeds [core] - 10https://gerrit.wikimedia.org/r/110864 (owner: 10Bartosz Dziewoński) [12:50:05] (03PS1) 10Bartosz Dziewoński: jquery.suggestions, mediawiki.searchSuggest: Don't use jquery.autoEllipsis [core] - 10https://gerrit.wikimedia.org/r/111180 [12:50:17] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/109443 (owner: 10Parent5446) [12:50:34] hey ori, wanna review something performaceish today? ^^ [12:50:45] (03CR) 10jenkins-bot: [V: 04-1] jquery.suggestions, mediawiki.searchSuggest: Don't use jquery.autoEllipsis [core] - 10https://gerrit.wikimedia.org/r/111180 (owner: 10Bartosz Dziewoński) [12:51:16] re [12:51:18] stupid bot [12:51:23] hashar: fix this please :( [12:51:38] )what? [12:51:54] (03CR) 10Bartosz Dziewoński: "Tests failed because of https://bugzilla.wikimedia.org/show_bug.cgi?id=53895" [core] - 10https://gerrit.wikimedia.org/r/111180 (owner: 10Bartosz Dziewoński) [12:52:00] https://bugzilla.wikimedia.org/show_bug.cgi?id=53895 [12:52:31] does https://doc.wikimedia.org/mediawiki-core/master/php/html/ load for you? how about https://doc.wikimedia.org/mediawiki-core/master/php ? [12:53:36] Nikerabbit: both load for me [12:54:43] (03CR) 10Siebrand: [C: 04-1] "L10n reviewed. See inline comment." (031 comment) [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/107307 (owner: 10Adamw) [12:55:14] (03PS2) 10Bartosz Dziewoński: jquery.suggestions, mediawiki.searchSuggest: Don't use jquery.autoEllipsis [core] - 10https://gerrit.wikimedia.org/r/111180 [12:56:54] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/38487 (owner: 10thibaultmarin) [12:58:20] (03CR) 10Siebrand: [C: 032] Parameter type hints on SiteNoticeAfter hook subscriber [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/98154 (owner: 10Reedy) [12:58:22] (03Merged) 10jenkins-bot: Parameter type hints on SiteNoticeAfter hook subscriber [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/98154 (owner: 10Reedy) [13:03:30] (03PS2) 1001tonythomas: Changed the password $valid check condition [core] - 10https://gerrit.wikimedia.org/r/109888 [13:05:00] Nikerabbit: Have you checked what version of HTTPS Everywhere you have? Some older versions have superseded whitelists/blacklists. [13:05:43] (03PS4) 10AalekhN: Remove nested paragraph element in HTMLTextBlockField [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/110823 [13:07:34] Ah, saw the comments [13:07:45] I wonder why anyone on earth is using Chrome. :) [13:08:20] (03CR) 1001tonythomas: "@Hoo, @Chad :removed the messge. Looks ok now ?" [core] - 10https://gerrit.wikimedia.org/r/109888 (owner: 1001tonythomas) [13:14:07] * YuviPanda puts flame suit on [13:14:11] Nemo_bis: the dev tools are better [13:14:16] (03CR) 10Bartosz Dziewoński: [C: 032] Now cache has cleared remove superfluous modules [core] - 10https://gerrit.wikimedia.org/r/102492 (owner: 10Jdlrobson) [13:16:07] (03CR) 10Hoo man: [C: 04-1] Changed the password $valid check condition (032 comments) [core] - 10https://gerrit.wikimedia.org/r/109888 (owner: 1001tonythomas) [13:17:43] (03Merged) 10jenkins-bot: Now cache has cleared remove superfluous modules [core] - 10https://gerrit.wikimedia.org/r/102492 (owner: 10Jdlrobson) [13:18:31] (03CR) 10Hoo man: "This should probably be abandoned in favour of https://gerrit.wikimedia.org/r/109888 (which also fixes https://bugzilla.wikimedia.org/4139" [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [13:19:13] (03CR) 10Hoo man: "Please note that this will fix https://bugzilla.wikimedia.org/41392 in the commit message while you're on it ;)" [core] - 10https://gerrit.wikimedia.org/r/109888 (owner: 1001tonythomas) [13:20:31] YuviPanda: better than in Chromium? O_o [13:21:06] Nemo_bis: ah, Chromium also does not provide binary builds for my current platform [13:21:54] Nemo_bis: I'm not using it [13:22:57] ok [13:23:06] YuviPanda: what platform is that? [13:24:06] (03CR) 10Jackmcbarn: Allow moving category pages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111096 (owner: 10Jackmcbarn) [13:25:22] hoo: Should the message config-admin-name-invalid be used ? [13:25:33] Nemo_bis: OS X :) [13:25:40] hoo: or a new one config-admin-bogus-username as Chad suggests ? [13:26:22] tonythomas01: mh, both is probably ok [13:26:54] hoo: ok. the message should be that the username is invalid right ? [13:27:08] YuviPanda: ugh. Well, you're damned in any case, the browser is the least of your worries. [13:27:14] heh [13:27:51] On the other hand I didn't expect anyone in this channel not to use HTTPS Everywhere. [13:27:54] tonythomas01: Yep [13:28:06] hoo: thanks [13:29:51] (03PS1) 1001tonythomas: Punctuated the error message tiff_invalid_file [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/111186 [13:30:40] (03CR) 1001tonythomas: "Done: https://gerrit.wikimedia.org/r/#/c/111186/" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/107039 (owner: 1001tonythomas) [13:44:19] (03PS3) 1001tonythomas: Changed the password $valid check condition [core] - 10https://gerrit.wikimedia.org/r/109888 [14:00:37] (03CR) 10Phuedx: [C: 032] Tag all GettingStarted-related edits, including 'redirect' [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110315 (owner: 10Mattflaschen) [14:00:39] (03Merged) 10jenkins-bot: Tag all GettingStarted-related edits, including 'redirect' [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110315 (owner: 10Mattflaschen) [14:04:36] (03PS1) 10Manybubbles: Turn token range queries into bare tokens [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111191 [14:08:03] (03PS11) 1001tonythomas: Ticking search in all namespaces should tick all the remaining ones. [core] - 10https://gerrit.wikimedia.org/r/110610 [14:08:23] (03CR) 10Reedy: [C: 04-1] "Seemingly need radio button support too for intended usage" [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110276 (owner: 10Reedy) [14:10:29] (03CR) 1001tonythomas: "@marktraucer: I changed everything expect this line" [core] - 10https://gerrit.wikimedia.org/r/110610 (owner: 1001tonythomas) [14:12:08] (03Abandoned) 1001tonythomas: Error shown if Administrator username and password match in the installer [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [14:14:30] (03CR) 1001tonythomas: "I will restore that portion from includes/User.php" [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [14:20:52] (03PS11) 1001tonythomas: Removed 'Remember my login' option from the Preferences page [core] - 10https://gerrit.wikimedia.org/r/94614 [14:27:04] (03CR) 10CSteipp: [C: 031] "I'm happy with this. Adding Ori to make sure he's ok with the way the registration happens in Setup.php." [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [14:31:12] (03CR) 10Siebrand: [C: 032] "Thanks." [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/111186 (owner: 1001tonythomas) [14:31:17] (03Merged) 10jenkins-bot: Punctuated the error message tiff_invalid_file [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/111186 (owner: 1001tonythomas) [14:38:41] (03CR) 10Prtksxna: "I am sorry I haven't responded to the question of why the code is here. I am new to the community and am trying to figure out my way aroun" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [14:53:56] (03PS7) 10Umherirrender: Add title tests about interwiki prefix [core] - 10https://gerrit.wikimedia.org/r/104016 [14:55:02] (03PS2) 10Gerrit Patch Uploader: Clean Timestamp Fields in mysql [core] - 10https://gerrit.wikimedia.org/r/110949 [14:55:04] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/110949 (owner: 10Gerrit Patch Uploader) [15:00:29] (03PS1) 10Pastakhov: fix array definition and array index [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/111198 [15:04:14] (03CR) 10Bartosz Dziewoński: "Deploying new extensions isn't hard, but it requires them to be reviewed first, which historically caused WMF teams to try not to do it." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [15:05:18] (03CR) 10Prtksxna: "Bartosz, noted. Will share with the design team!" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [15:06:24] prtksxna: greg-g is the deployment manager, he knows the details [15:06:39] MatmaRex: Got it! [15:08:15] (03CR) 10Bene: "Hey, this might be a problem for the bug linked in the commit message." [core] - 10https://gerrit.wikimedia.org/r/110832 (owner: 10TTO) [15:13:26] (03PS1) 10Pastakhov: add some array functions [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/111199 [15:30:44] (03CR) 10Hashar: "Jobs deployed, will add zuul triggers" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/110164 (owner: 10Pastakhov) [15:30:49] (03CR) 10Hashar: [C: 032] Add jobs for mw/ext/PhpTags and mw/ext/PhpTagsFunctions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/110164 (owner: 10Pastakhov) [15:31:09] (03Merged) 10jenkins-bot: Add jobs for mw/ext/PhpTags and mw/ext/PhpTagsFunctions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/110164 (owner: 10Pastakhov) [15:32:32] (03PS1) 10Hashar: Triggers for for mw/ext/PhpTags and mw/ext/PhpTagsFunctions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/111200 [15:32:53] (03CR) 10Hashar: "Zuul triggers added by https://gerrit.wikimedia.org/r/111200 (same change-id)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/110164 (owner: 10Pastakhov) [15:33:37] (03CR) 10Hashar: [C: 032] Triggers for for mw/ext/PhpTags and mw/ext/PhpTagsFunctions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/111200 (owner: 10Hashar) [15:33:41] (03Merged) 10jenkins-bot: Triggers for for mw/ext/PhpTags and mw/ext/PhpTagsFunctions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/111200 (owner: 10Hashar) [15:34:01] (03PS2) 10Pastakhov: fix array definition and array index [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/111198 [15:38:25] (03PS2) 1001tonythomas: Splitted date and time in message 'rclistfrom' [core] - 10https://gerrit.wikimedia.org/r/107360 [15:38:36] (03PS1) 10Bartosz Dziewoński: Don't override the 'limit' parameter when building feed query [core] - 10https://gerrit.wikimedia.org/r/111201 [15:38:50] (03PS1) 10Hashar: sync extensions [extensions] - 10https://gerrit.wikimedia.org/r/111202 [15:39:13] (03CR) 10Hashar: [C: 032] sync extensions [extensions] - 10https://gerrit.wikimedia.org/r/111202 (owner: 10Hashar) [15:39:19] (03CR) 10Hashar: [V: 032] sync extensions [extensions] - 10https://gerrit.wikimedia.org/r/111202 (owner: 10Hashar) [15:39:34] (03CR) 10Bartosz Dziewoński: "Caused bug 60795. Fix: https://gerrit.wikimedia.org/r/111201" [core] - 10https://gerrit.wikimedia.org/r/105195 (owner: 10Bartosz Dziewoński) [15:56:01] (03CR) 10PleaseStand: (bug 28401) Make RC en RCL honour options for rss/atom (031 comment) [core] - 10https://gerrit.wikimedia.org/r/38634 (owner: 10MrBlueSky) [15:57:44] (03PS9) 10Daniel Kinzler: Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 [15:57:48] (03PS1) 10Manybubbles: Handle space in namespace prefixed searches [core] - 10https://gerrit.wikimedia.org/r/111204 [16:06:42] (03PS2) 10Bartosz Dziewoński: ChangesListSpecialPage: Remove all functionality for generating feeds [core] - 10https://gerrit.wikimedia.org/r/110864 [16:07:08] (03CR) 10Bartosz Dziewoński: ChangesListSpecialPage: Remove all functionality for generating feeds (0315 comments) [core] - 10https://gerrit.wikimedia.org/r/110864 (owner: 10Bartosz Dziewoński) [16:07:12] (03PS10) 10Daniel Kinzler: Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 [16:08:27] (03CR) 10Daniel Kinzler: Introducing TitleValue (0317 comments) [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [16:08:34] (03CR) 10Hashar: [C: 04-1] "shell snippets are run by Jenkins with -e already. I do not think this is needed, see inline comment." (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/111136 (owner: 10MarkTraceur) [16:08:44] (03CR) 10Daniel Kinzler: [C: 04-1] "I have addressed most of the previous comments in the latest patch sets. I want to try and re-think the service interfaces for the next it" [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [16:12:38] (03PS3) 10Bartosz Dziewoński: ChangesListSpecialPage: Remove all functionality for generating feeds [core] - 10https://gerrit.wikimedia.org/r/110864 [16:13:56] (03CR) 10Bartosz Dziewoński: [C: 04-1] ChangesListSpecialPage: Remove all functionality for generating feeds (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110864 (owner: 10Bartosz Dziewoński) [16:26:10] (03PS10) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 [16:36:09] (03Abandoned) 10Chad: Revert "Support SearchEngine's new sort parameter" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110996 (owner: 10Chad) [16:39:06] (03PS11) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 [16:40:18] (03CR) 10Liangent: ""I have in mind that there was a special function for Chinese... but I could not find it again... maybe I mix up something here."" [extensions/Math] - 10https://gerrit.wikimedia.org/r/111119 (owner: 10Physikerwelt) [16:42:47] (03PS16) 10Inchikutty: Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [16:43:06] (03PS12) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 [16:43:50] (03PS1) 10Manybubbles: Trim quotes from prefix: search [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111210 [16:58:52] (03CR) 10MarkTraceur: [C: 032] Remove nested paragraph element in HTMLTextBlockField [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/110823 (owner: 10AalekhN) [16:58:59] (03Merged) 10jenkins-bot: Remove nested paragraph element in HTMLTextBlockField [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/110823 (owner: 10AalekhN) [17:00:55] (03PS1) 10Hashar: multigit: point ZUUL_URL to zuul.eqiad.wmnet [integration/jenkins] - 10https://gerrit.wikimedia.org/r/111213 [17:01:14] (03CR) 10Hashar: [C: 032] multigit: point ZUUL_URL to zuul.eqiad.wmnet [integration/jenkins] - 10https://gerrit.wikimedia.org/r/111213 (owner: 10Hashar) [17:01:18] (03Merged) 10jenkins-bot: multigit: point ZUUL_URL to zuul.eqiad.wmnet [integration/jenkins] - 10https://gerrit.wikimedia.org/r/111213 (owner: 10Hashar) [17:02:47] (03PS1) 10Addshore: Make ApiHelp more Helpful! [core] - 10https://gerrit.wikimedia.org/r/111214 [17:08:46] (03CR) 10PleaseStand: "How is this different from the paraminfo module?" [core] - 10https://gerrit.wikimedia.org/r/111214 (owner: 10Addshore) [17:09:47] (03Abandoned) 10Addshore: Make ApiHelp more Helpful! [core] - 10https://gerrit.wikimedia.org/r/111214 (owner: 10Addshore) [17:11:39] (03CR) 10Chad: [C: 032] Turn token range queries into bare tokens [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111191 (owner: 10Manybubbles) [17:11:44] (03Merged) 10jenkins-bot: Turn token range queries into bare tokens [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111191 (owner: 10Manybubbles) [17:16:28] (03CR) 10Chad: [C: 032] Fix Undefined wgSearchType [extensions/LiquidThreads] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/110860 (owner: 10Alex Monk) [17:16:31] (03Merged) 10jenkins-bot: Fix Undefined wgSearchType [extensions/LiquidThreads] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/110860 (owner: 10Alex Monk) [17:16:33] (03CR) 10Chad: [C: 032] Fix Undefined wgSearchType [extensions/LiquidThreads] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110861 (owner: 10Alex Monk) [17:16:35] (03Merged) 10jenkins-bot: Fix Undefined wgSearchType [extensions/LiquidThreads] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110861 (owner: 10Alex Monk) [17:23:05] (03PS1) 10Chad: Updating LiquidThreads submodule [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111215 [17:23:17] (03PS1) 10Chad: Updating LQT submodule [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111216 [17:24:47] (03PS1) 10Hashar: multigit: set -e [integration/jenkins] - 10https://gerrit.wikimedia.org/r/111217 [17:25:42] (03PS2) 10Hashar: multigit: set -e [integration/jenkins] - 10https://gerrit.wikimedia.org/r/111217 [17:26:13] (03CR) 10Hashar: [C: 04-2] "Impacts a few critical jobs such as:" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/111217 (owner: 10Hashar) [17:29:01] qgil: you dropped out [17:29:56] !seen mlitn [17:29:57] Did you mean @seen mlitn? [17:30:00] @seen mlitn [17:30:00] ebernhardson: Last time I saw mlitn they were quitting the network with reason: Quit: mlitn N/A at 1/31/2014 2:53:08 PM (4d2h36m52s ago) [17:30:33] (03CR) 10PleaseStand: Don't override the 'limit' parameter when building feed query (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111201 (owner: 10Bartosz Dziewoński) [17:34:01] (03CR) 10Chad: [C: 032] Updating LiquidThreads submodule [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111215 (owner: 10Chad) [17:34:03] (03CR) 10Chad: [C: 032] Updating LQT submodule [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111216 (owner: 10Chad) [17:37:38] (03Merged) 10jenkins-bot: Updating LiquidThreads submodule [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111215 (owner: 10Chad) [17:38:26] (03Merged) 10jenkins-bot: Updating LQT submodule [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111216 (owner: 10Chad) [17:39:30] (03CR) 10Chad: [C: 032] Handle space in namespace prefixed searches [core] - 10https://gerrit.wikimedia.org/r/111204 (owner: 10Manybubbles) [17:42:56] (03Merged) 10jenkins-bot: Handle space in namespace prefixed searches [core] - 10https://gerrit.wikimedia.org/r/111204 (owner: 10Manybubbles) [17:45:48] (03CR) 10Chad: [C: 032] Trim quotes from prefix: search [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111210 (owner: 10Manybubbles) [17:45:52] (03Merged) 10jenkins-bot: Trim quotes from prefix: search [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111210 (owner: 10Manybubbles) [18:01:27] off for today, see you tomorrow [18:04:46] (03PS1) 10EBernhardson: Don't error out on duplicate id's [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111224 [18:11:54] (03PS2) 10EBernhardson: Don't error out on duplicate id's [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111224 [18:17:56] (03CR) 10Anomie: [C: 04-1] "Ah, now we have bug links." [core] - 10https://gerrit.wikimedia.org/r/110832 (owner: 10TTO) [18:25:10] (03CR) 10Mattflaschen: "Looks good. One small issue." (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110375 (owner: 10Phuedx) [18:27:29] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 4cd9ab2..c528a0f [extensions] - 10https://gerrit.wikimedia.org/r/111228 [18:27:31] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 4cd9ab2..c528a0f [extensions] - 10https://gerrit.wikimedia.org/r/111228 (owner: 10Jenkins-mwext-sync) [18:28:51] (03CR) 10Aaron Schulz: [C: 04-1] "Needs rebase" [core] - 10https://gerrit.wikimedia.org/r/100211 (owner: 10Anomie) [18:29:11] (03PS1) 10Manybubbles: Don't offer create link for searches with syntax [core] - 10https://gerrit.wikimedia.org/r/111233 [18:30:55] (03CR) 10Raimond Spekking: "PhpMaps: I wonder if this should has be added. I have had issues with it with translatewiki.net script and in a chat with Reedy he told me" [extensions] - 10https://gerrit.wikimedia.org/r/111202 (owner: 10Hashar) [18:32:06] (03CR) 10Aaron Schulz: [C: 032] Don't escape the mail's subject in Special:PasswordReset [core] - 10https://gerrit.wikimedia.org/r/94816 (owner: 10IAlex) [18:33:56] greg-g: can we get a deploy window later today for 111161 and 111160? cherry-picks from wmf12 to populate CheckUser [18:34:59] (03CR) 10EBernhardson: [C: 031] Use RecentChanges::save to add RC rows [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111160 (owner: 10Jalexander) [18:35:08] ebernhardson: yes, afternoon is free after 1pm [18:35:29] (03CR) 10EBernhardson: [C: 031] Abort email notifications coming out of RecentChange [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111161 (owner: 10Jalexander) [18:35:37] greg-g: excellent, thanks [18:35:49] (03Merged) 10jenkins-bot: Don't escape the mail's subject in Special:PasswordReset [core] - 10https://gerrit.wikimedia.org/r/94816 (owner: 10IAlex) [18:36:20] ebernhardson: what time you want? (let me know when you have an idea) [18:36:31] (03PS3) 10Umherirrender: Add sequence support for upsert in DatabaseOracle [core] - 10https://gerrit.wikimedia.org/r/110991 [18:37:10] greg-g: 1pm works [18:37:47] (03CR) 10Umherirrender: "Patch Set 3: Add foreach to add column to each list of columns." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110991 (owner: 10Umherirrender) [18:39:32] cool [18:40:09] (03CR) 10Aaron Schulz: [C: 032] API: Handle "special" options in action=options [core] - 10https://gerrit.wikimedia.org/r/88995 (owner: 10Anomie) [18:41:44] (03CR) 10Aaron Schulz: [C: 032] Clean up global state when job finishes [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94685 (owner: 10Legoktm) [18:41:54] (03Merged) 10jenkins-bot: Clean up global state when job finishes [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94685 (owner: 10Legoktm) [18:43:42] (03Merged) 10jenkins-bot: API: Handle "special" options in action=options [core] - 10https://gerrit.wikimedia.org/r/88995 (owner: 10Anomie) [18:47:13] (03CR) 10Hoo man: [C: 032] "Per +2 on PS6" [core] - 10https://gerrit.wikimedia.org/r/104016 (owner: 10Umherirrender) [18:48:09] (03PS1) 10Yaron Koren: Fix for editsection HTML/CSS change in MW 1.22 [extensions/HeaderTabs] - 10https://gerrit.wikimedia.org/r/111236 [18:49:34] (03PS1) 10Ori.livneh: Initial commit. Add .gitreview. [tools/scap] - 10https://gerrit.wikimedia.org/r/111237 [18:50:05] (03CR) 10Bartosz Dziewoński: Don't override the 'limit' parameter when building feed query (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111201 (owner: 10Bartosz Dziewoński) [18:50:16] (03CR) 10Ori.livneh: [C: 032 V: 032] Initial commit. Add .gitreview. [tools/scap] - 10https://gerrit.wikimedia.org/r/111237 (owner: 10Ori.livneh) [18:50:38] (03PS7) 10UltrasonicNXT: Allow the removal of various features [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97383 [18:50:43] (03Merged) 10jenkins-bot: Add title tests about interwiki prefix [core] - 10https://gerrit.wikimedia.org/r/104016 (owner: 10Umherirrender) [18:50:47] scap rewrite? have you not had enough site-breaking, ori? :D [18:51:15] speaking of which, i need someone to merge https://gerrit.wikimedia.org/r/111201 before thursday ~ [18:54:07] (03PS6) 10Umherirrender: Make a single # an invalid title in php and js [core] - 10https://gerrit.wikimedia.org/r/106561 [18:54:34] (03PS3) 10Phuedx: Stop logging with the GettingStartedOnRedirect schema. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110375 [18:54:58] MatmaRex: i don't have an opinion of my own re: pleasestand's suggestion, but i'm inclined to trust his intuitions [18:55:03] so maybe implement what he's suggesting? [18:55:11] (03CR) 10Yaron Koren: [C: 032 V: 032] Fix for editsection HTML/CSS change in MW 1.22 [extensions/HeaderTabs] - 10https://gerrit.wikimedia.org/r/111236 (owner: 10Yaron Koren) [18:56:13] alrighty [18:56:23] plop [18:56:27] why does he not have +2? :D [18:57:05] (03PS8) 10Umherirrender: API: Return set values for action=options [core] - 10https://gerrit.wikimedia.org/r/92928 [18:57:36] (03CR) 10Phuedx: Stop logging with the GettingStartedOnRedirect schema. (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110375 (owner: 10Phuedx) [19:00:18] (03CR) 10jenkins-bot: [V: 04-1] API: Return set values for action=options [core] - 10https://gerrit.wikimedia.org/r/92928 (owner: 10Umherirrender) [19:01:47] (03PS2) 10Bartosz Dziewoński: Don't override the 'limit' parameter when building feed query [core] - 10https://gerrit.wikimedia.org/r/111201 [19:01:55] (03PS1) 10UltrasonicNXT: Prevent use of bad titles in thread names [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/111239 [19:02:09] ori: ^^ [19:02:18] (03CR) 10Phuedx: [C: 032] Auto-launch full tour, not just intro [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/107726 (owner: 10Mattflaschen) [19:02:36] (03Merged) 10jenkins-bot: Auto-launch full tour, not just intro [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/107726 (owner: 10Mattflaschen) [19:03:05] (03CR) 10Bartosz Dziewoński: "Done per PleaseStand." [core] - 10https://gerrit.wikimedia.org/r/111201 (owner: 10Bartosz Dziewoński) [19:04:02] (03PS1) 10Mwalker: Adding Zuul Triggers for Fundraising Jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/111240 [19:05:28] MatmaRex: Any idea what might be causing this? http://i.imgur.com/NITLEyC.png I'll file a bug and look into it soon but figured maybe you know (I'm over a week behind on core review, not sure what was merged in this recently) [19:05:41] Did a fresh pull, hard refresh client side [19:06:05] looks like an incompatibility between html version and css [19:06:39] Krinkle: could be me, but i was sure i was handling this [19:06:46] !g 82100 [19:06:46] https://gerrit.wikimedia.org/r/#q,82100,n,z [19:06:51] (and followups) [19:08:23] * MatmaRex tries to reproduce [19:09:23] (03CR) 10MarkTraceur: [C: 032] "Will deploy shortly" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/111240 (owner: 10Mwalker) [19:09:28] (03Merged) 10jenkins-bot: Adding Zuul Triggers for Fundraising Jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/111240 (owner: 10Mwalker) [19:10:36] (03CR) 10Aaron Schulz: [C: 04-1] Add API action=revisiondelete (032 comments) [core] - 10https://gerrit.wikimedia.org/r/70749 (owner: 10Anomie) [19:10:37] These things are hard to reproduce once server-side caches are purged. You'd have to check out master from before this, log out, edit a page, open a few different pages with the new html, check out newer master, wait 5-10 minutes, then open another page. 304 on the /wiki/Main_Page will instruct browser to re-use html cache, but load.php will have been invalidated by then and will be the new one. [19:10:57] At least that's how I get it, and never intentionally by following those steps, just naturally. [19:11:16] legoktm: around? [19:11:20] yup [19:11:31] legoktm: can I ask you about centralauth cookies? :D [19:12:05] sure, but I can't guarantee I know the answer :P [19:12:06] (03CR) 10Krinkle: "Seems to be incompatible with old html or old css or something that happens after updating, http://i.imgur.com/NITLEyC.png" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński) [19:12:44] legoktm: so, I logged in to one wiki (test). Can I somehow automatically construct or save cookies so that I am logged into all wikis now? [19:12:49] legoktm: this is with the API [19:12:51] (03PS7) 10Chad: WIP: Implement interwiki searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105986 [19:13:32] (03PS14) 10Jackmcbarn: Add an API action to test blacklisted URLs [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 [19:14:24] Is it just me or http://mediawiki.org pages are missing the watch star icon? [19:14:41] qgil: if you're using the typography refresh, its a known bug [19:14:59] YuviPanda: I think you probably can if you adjust the domain part...not sure if its explicitly supported [19:15:14] MatmaRex: I just reproduced it again. Checking out e6cf2f1 ('master@{2 weeks ago}'), opening /wiki/Sandbox?2rnd, then checkout fb1b6ea885b4 ('master') and open the same url in another tab (still logged out) [19:15:22] legoktm, ah, indeed. Phew! [19:16:20] Krinkle: that's exactly what i'm trying to do right now, except my dev server is playing up [19:17:23] (03PS1) 10Legoktm: Make the old $wgSearchType available as an alternative if the BetaFeature is enabled [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111242 [19:17:40] (03PS15) 10Jackmcbarn: Add an API action to test blacklisted URLs [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 [19:17:45] MatmaRex: Looks like 'background-color: transparent;' is the missing rule, that was there before and is gone afterwards (no longe applies to button) [19:18:00] (03PS2) 10Umherirrender: Add prop 'limitreportdata' and 'limitreporthtml' to action=parse [core] - 10https://gerrit.wikimedia.org/r/110819 [19:18:23] causing it to default to grey (native button style gets removed bit by bit through padding/margin/width/position resets, but background color remains, maybe background: none, instead of background-image: none?) [19:18:30] Krinkle: ah poop, yeah, i can reproduce it too [19:18:41] (03CR) 10Umherirrender: "Patch Set 2: Changed how params gets added to result" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110819 (owner: 10Umherirrender) [19:18:45] and i know the cause, actually [19:18:50] OK [19:18:50] okay, easily fixed [19:18:55] on it [19:18:56] cool :) [19:18:56] thanks! [19:20:04] (03CR) 10Chad: [C: 032] Make the old $wgSearchType available as an alternative if the BetaFeature is enabled [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111242 (owner: 10Legoktm) [19:20:08] (03Merged) 10jenkins-bot: Make the old $wgSearchType available as an alternative if the BetaFeature is enabled [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111242 (owner: 10Legoktm) [19:21:59] (03PS3) 10Bartosz Dziewoński: Don't override the 'limit' parameter when building feed query [core] - 10https://gerrit.wikimedia.org/r/111201 [19:22:04] (03CR) 10Ori.livneh: [C: 032] Don't override the 'limit' parameter when building feed query [core] - 10https://gerrit.wikimedia.org/r/111201 (owner: 10Bartosz Dziewoński) [19:24:57] (03PS1) 10Bartosz Dziewoński: Vector: Add missing rule in HTML compatibility styles [core] - 10https://gerrit.wikimedia.org/r/111243 [19:25:24] Krinkle: ^ [19:25:47] i actually don't know how it disappeared [19:26:08] i thought i knew, but that change removed it elsewhere (SVG icon for the magnifying glass) [19:26:14] (03Merged) 10jenkins-bot: Don't override the 'limit' parameter when building feed query [core] - 10https://gerrit.wikimedia.org/r/111201 (owner: 10Bartosz Dziewoński) [19:26:29] (03CR) 10Spage: [C: 032] "Deploying at 1pm PDT" [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111161 (owner: 10Jalexander) [19:26:36] (03CR) 10Anomie: Add API action=revisiondelete (032 comments) [core] - 10https://gerrit.wikimedia.org/r/70749 (owner: 10Anomie) [19:26:58] (03PS11) 10Anomie: Add API action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/70749 [19:27:14] (03CR) 10Spage: [C: 032] "Deploying at 1pm PDT" [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111160 (owner: 10Jalexander) [19:27:39] it would appear i did quite a lot of almost-site-breaking recently, sorry guys :) [19:28:01] (03Merged) 10jenkins-bot: Abort email notifications coming out of RecentChange [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111161 (owner: 10Jalexander) [19:28:04] (03Merged) 10jenkins-bot: Use RecentChanges::save to add RC rows [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111160 (owner: 10Jalexander) [19:30:35] Reedy, could you do a settings check on ptwikibooks for me? [19:32:30] I don't know [19:32:31] Do I? [19:32:32] :| [19:33:02] I've been awake for 30 hours or so [19:33:03] heh... mitigate all the jet lag :P [19:33:03] Please could you tell me the values of wgSearchType and wgSearchTypeAlternatives ? [19:33:03] ouch [19:33:04] get some sleep :p [19:33:28] Sleeping at 7.30pm isn't the best idea [19:33:51] sleep is for the weak [19:34:08] and/or the drugged [19:34:08] > var_dump( $wgSearchType ); [19:34:08] string(12) "LuceneSearch" [19:34:22] > var_dump( $wgSearchTypeAlternatives ); [19:34:22] array(1) { [19:34:22] [0]=> [19:34:22] string(12) "CirrusSearch" [19:34:22] } [19:34:27] ffs... I'm trying to talk to people but IRC reconnects every few minutes, making me miss stuff [19:36:20] Krenair: You could have seen that in the mediawiki-config repo also... [19:36:40] mediawiki-config/wmf-config/CirrusSearch-common.php [19:36:42] it's all ther [19:36:43] e [19:36:50] I was trying to confirm that I hadn't messed up my idea of what was going on in mediawiki-config [19:37:10] (03CR) 10Bartosz Dziewoński: "Another followup: https://gerrit.wikimedia.org/r/#/c/111243/ . Thanks." [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński) [19:37:50] This block of code: https://gerrit.wikimedia.org/r/#/c/110846/1/pages/TalkpageView.php isn't working as expected there [19:38:03] (03PS9) 10Umherirrender: API: Return set values for action=options [core] - 10https://gerrit.wikimedia.org/r/92928 [19:38:36] (03CR) 10Umherirrender: "Patch Set 9: Fixes after rebase" [core] - 10https://gerrit.wikimedia.org/r/92928 (owner: 10Umherirrender) [19:40:30] jgonera, are you at/coming to the mw.ui hack day? [19:40:40] (03PS2) 10Bartosz Dziewoński: Vector: Add missing rule in HTML compatibility styles [core] - 10https://gerrit.wikimedia.org/r/111243 [19:40:44] (03CR) 10Ori.livneh: [C: 032] Vector: Add missing rule in HTML compatibility styles [core] - 10https://gerrit.wikimedia.org/r/111243 (owner: 10Bartosz Dziewoński) [19:43:20] (03CR) 10MaxSem: Password Expiration (031 comment) [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [19:44:45] (03Merged) 10jenkins-bot: Vector: Add missing rule in HTML compatibility styles [core] - 10https://gerrit.wikimedia.org/r/111243 (owner: 10Bartosz Dziewoński) [19:44:54] (03CR) 10Anomie: Support ApiPageSet in ApiWatch (031 comment) [core] - 10https://gerrit.wikimedia.org/r/53964 (owner: 10Eranroz) [19:44:59] (03PS20) 10Anomie: Support ApiPageSet in ApiWatch [core] - 10https://gerrit.wikimedia.org/r/53964 (owner: 10Eranroz) [19:45:11] (03PS8) 10Bartosz Dziewoński: Remove HTML back-compat styles from I5fe0543e [core] - 10https://gerrit.wikimedia.org/r/82102 [19:45:36] (03CR) 10Anomie: [C: 032] "PS20: Trivial doc cleanup" [core] - 10https://gerrit.wikimedia.org/r/53964 (owner: 10Eranroz) [19:46:19] superm401, we're on the hangout [19:47:07] (03CR) 10jenkins-bot: [V: 04-1] Remove HTML back-compat styles from I5fe0543e [core] - 10https://gerrit.wikimedia.org/r/82102 (owner: 10Bartosz Dziewoński) [19:48:18] (03PS9) 10Bartosz Dziewoński: Remove HTML back-compat styles from I5fe0543e [core] - 10https://gerrit.wikimedia.org/r/82102 [19:48:47] (03CR) 10Siebrand: Password Expiration (031 comment) [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [19:48:49] (03PS2) 10Anomie: Detect already-undone edits for undo [core] - 10https://gerrit.wikimedia.org/r/100211 [19:49:06] (03CR) 10Aaron Schulz: [C: 032] Add API action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/70749 (owner: 10Anomie) [19:50:18] \o/ [19:51:20] (03PS1) 10Chad: Moved $wgQueryPages stuff out of the global scope and into a function [core] - 10https://gerrit.wikimedia.org/r/111248 [19:51:20] (03CR) 10Aaron Schulz: [C: 032] Detect already-undone edits for undo [core] - 10https://gerrit.wikimedia.org/r/100211 (owner: 10Anomie) [19:52:08] (03Merged) 10jenkins-bot: Support ApiPageSet in ApiWatch [core] - 10https://gerrit.wikimedia.org/r/53964 (owner: 10Eranroz) [19:52:10] (03CR) 10jenkins-bot: [V: 04-1] Add API action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/70749 (owner: 10Anomie) [19:52:22] jgonera, http://etherpad.wikimedia.org/p/MediaWiki_UI_Standardization_hack4 [19:52:34] (03PS13) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 [19:53:35] (03PS7) 10Physikerwelt: install MathWebSearch [vagrant] - 10https://gerrit.wikimedia.org/r/108869 [19:53:47] (03CR) 10Siebrand: [C: 04-1] "L10n reviewed." (031 comment) [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/111239 (owner: 10UltrasonicNXT) [19:55:56] (03Merged) 10jenkins-bot: Detect already-undone edits for undo [core] - 10https://gerrit.wikimedia.org/r/100211 (owner: 10Anomie) [19:56:26] (03PS5) 10IAlex: Enhance the destination control parameter of wfDebug() and wfDebugLog() [core] - 10https://gerrit.wikimedia.org/r/95356 [19:56:28] (03CR) 10Legoktm: [C: 032] Limit Flow API to only respond on enabled pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110458 (owner: 10EBernhardson) [19:57:45] (03Merged) 10jenkins-bot: Limit Flow API to only respond on enabled pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110458 (owner: 10EBernhardson) [20:00:05] (03PS1) 10EBernhardson: Add hook SpecialCheckUserGetLinksFromRow [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/111249 [20:00:13] (03CR) 10Aaron Schulz: [C: 032] Enhance the destination control parameter of wfDebug() and wfDebugLog() [core] - 10https://gerrit.wikimedia.org/r/95356 (owner: 10IAlex) [20:00:28] (03CR) 10Anomie: [C: 04-1] ChangesListSpecialPage: Remove all functionality for generating feeds (032 comments) [core] - 10https://gerrit.wikimedia.org/r/110864 (owner: 10Bartosz Dziewoński) [20:02:41] (03PS1) 10MaxSem: Add blobs support to ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/111250 [20:04:03] (03Merged) 10jenkins-bot: Enhance the destination control parameter of wfDebug() and wfDebugLog() [core] - 10https://gerrit.wikimedia.org/r/95356 (owner: 10IAlex) [20:04:23] (03PS12) 10Anomie: Add API action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/70749 [20:04:58] (03CR) 10Maryana: "Not reviewing the code, just putting the PM stamp of approval on the concept :)" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107402 (owner: 10Jackmcbarn) [20:04:59] (03CR) 10Anomie: [C: 032] "Stupid RELEASE-NOTES. Trivial rebase, Aaron +2ed PS11." [core] - 10https://gerrit.wikimedia.org/r/70749 (owner: 10Anomie) [20:05:26] Please help me with how to handle change id. I faced this error on submitting my patch. http://fpaste.org/74423/91544290/ [20:05:26] anomie: may i interest you in http://github.com/matmarex/mediawikireleasenotes-driver ? [20:05:38] anomie: heh, I was a bit surprised for second that that conflicted [20:05:52] (03CR) 10EBernhardson: "Documentation added at https://www.mediawiki.org/wiki/Manual:Hooks/SpecialCheckUserGetLinksFromRow" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/111249 (owner: 10EBernhardson) [20:05:55] MatmaRex: Not unless you get it installed in Gerrit/Jenkins/wherever [20:05:57] anomie: also, ori is offering a statue in honor of whoever managed to make jenkins/gerrit use that [20:06:09] AaronSchulz: I *just* merged a patch that made it conflict, after rebasing. [20:06:10] (i believe the offer is still valid) [20:06:21] manages* [20:06:24] MatmaRex: jgit vs. cgit... now have fun :P [20:06:42] hoo: i'm not touching that with a ten-yars stick [20:06:46] but someone just might [20:06:59] zeek_: have you tried doing what the error message instructs you to do? [20:07:44] MatmaRex: It instucts me to use scp which I cant. :( shh blocked. And the manual part is unclear. [20:08:32] (03Merged) 10jenkins-bot: Add API action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/70749 (owner: 10Anomie) [20:09:45] zeek_: hmph. let me put the code for the commit-msg hook somewhere [20:10:19] zeek_: also, how is ssh blocked if you were able to get that error message? it's via ssh. [20:10:55] MatmaRex: No i used https... git push https://gerrit.wikimedia.org/r/p/mediawiki/core HEAD:refs/for/master [20:11:02] * anomie wonders what sort of place zeek_ is at that ssh is blocked [20:11:28] zeek_: does that actually work? i was under the impression that it doesn't [20:11:30] anyway [20:11:32] http://pastebin.com/vW6ECe6X [20:11:46] put this code into .git/hooks/commit-msg on your repository [20:11:59] Yeah it does. :) [20:12:14] ok and then I push? [20:12:20] then run `git commit --amend` to fix your latest commit, you'll see a Change-Id line appear at the very bottom of commit message [20:12:24] and then push :) [20:13:02] thanx let me try :) [20:13:29] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: c528a0f..047d6bf [extensions] - 10https://gerrit.wikimedia.org/r/111251 [20:13:31] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: c528a0f..047d6bf [extensions] - 10https://gerrit.wikimedia.org/r/111251 (owner: 10Jenkins-mwext-sync) [20:13:49] Suggestion... you might wanna incorporate the https features in the "using gerrit" page for people like me :D [20:13:52] (03CR) 10JGonera: [C: 04-1] Update login and HTMLForm to new design (032 comments) [core] - 10https://gerrit.wikimedia.org/r/104011 (owner: 10Spage) [20:14:08] (03CR) 10Jorm: [C: 031] Make the diff the primary link in thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107402 (owner: 10Jackmcbarn) [20:14:21] (03CR) 10Anomie: [C: 031] "Haven't tested, yet." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111248 (owner: 10Chad) [20:14:43] (03PS6) 10Aaron Schulz: Made ActiveUsers use querycache and do staggered updates on view [core] - 10https://gerrit.wikimedia.org/r/110299 [20:16:14] (03CR) 10Bartosz Dziewoński: [C: 032] Make the diff the primary link in thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107402 (owner: 10Jackmcbarn) [20:16:22] (03Merged) 10jenkins-bot: Make the diff the primary link in thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107402 (owner: 10Jackmcbarn) [20:17:02] zeek_: most people just use the gerrit patch uploader if they're in a situation like that [20:17:07] * legoktm huggles MatmaRex  [20:17:08] http://tools.wmflabs.org/gerrit-patch-uploade [20:17:14] thanks for merging that :D [20:18:05] (03CR) 10Bartosz Dziewoński: [C: 032] Parse wikilinks in skip log entries [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/102072 (owner: 10Legoktm) [20:18:11] legoktm: my pleasure [20:18:13] (03Merged) 10jenkins-bot: Parse wikilinks in skip log entries [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/102072 (owner: 10Legoktm) [20:19:12] (03CR) 10Ori.livneh: [C: 032] Made ActiveUsers use querycache and do staggered updates on view [core] - 10https://gerrit.wikimedia.org/r/110299 (owner: 10Aaron Schulz) [20:22:24] MatmaRex: When i use the git commit --amend, it opens up nano editor with this content... should i just exit it? http://fpaste.org/74428/91545310/ [20:22:46] (03Merged) 10jenkins-bot: Made ActiveUsers use querycache and do staggered updates on view [core] - 10https://gerrit.wikimedia.org/r/110299 (owner: 10Aaron Schulz) [20:23:02] zeek_: well, you might want to type some commit message for your changes [20:23:06] then save and exit [20:23:43] I had done that when i commited earlier, should i change the message it shows? [20:24:30] probably [20:24:52] but commit mesasges normally don't just disappear, if you typed one in, it should be there [20:25:46] anomie: you can't have a prop= and a list= module named the same thing? [20:25:46] It shows that earlier one. Please see the link i gave. I saved the file as it is and tried to push again. Same error.. change id missing.. :/ [20:26:36] (03CR) 10Bene: "Please look at https://gerrit.wikimedia.org/r/#/c/111001/ for such a hook." [core] - 10https://gerrit.wikimedia.org/r/110832 (owner: 10TTO) [20:26:39] legoktm: Probably not, since yurik's ApiModuleManager. But feel free to fix that. [20:26:53] MatmaRex: ^ [20:27:26] legoktm, anomie why would we ever want that ? :) [20:27:44] zeek_: where did you save the commit-msg file? [20:28:05] zeek_: you can always add a CHange-Id line yourself, e.g. by copying the one the error message is suggesting [20:28:07] yurik: For list=flow and prop=flow, I suspect, since it's legoktm asking. [20:28:12] Right now flow has a list=flow module, and I want to replace it with prop=flow, but I don't want to kill the old one until the new one is fully ready [20:28:27] sigh [20:28:33] its not a big deal [20:29:06] in my repo... vi .git/hooks/commit-msg. Ok i can see the change id which is generated in the error message, but where should i put that?? [20:29:13] MatmaRex: ^ [20:29:36] zeek_: at the bottom of the commit message [20:30:34] (03PS1) 10Legoktm: API: Add prop=flow to detect if Flow is enabled on a page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111255 [20:31:51] (03CR) 10Legoktm: [C: 04-2] "Until we kill list=flow properly." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111255 (owner: 10Legoktm) [20:32:00] (03CR) 10Spage: [C: 04-1] "From hack day: rename actionbuttons mw-ui-button-bar and adjust its line spacing in it so that if buttons wrap onto multiple lines it look" [core] - 10https://gerrit.wikimedia.org/r/104011 (owner: 10Spage) [20:35:24] (03PS2) 10UltrasonicNXT: Prevent use of bad titles in thread names [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/111239 [20:36:22] (03PS1) 10Legoktm: Send mediawiki/extension/Thanks to -corefeatures [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/111257 [20:36:38] MatmaRex: I have not done this earlier, m sorry can you please elaborate. How do i edit the git commit file. I googled and can find the same git commit --amend command. :( [20:36:40] (03CR) 10Legoktm: [V: 032] Send mediawiki/extension/Thanks to -corefeatures [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/111257 (owner: 10Legoktm) [20:36:53] (03CR) 10Legoktm: [C: 032] Send mediawiki/extension/Thanks to -corefeatures [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/111257 (owner: 10Legoktm) [20:39:27] zeek_: that is the command to use [20:39:43] you edit it in the editor that opens, save and quit [20:39:57] you can change the editor by changing the value of the $EDITOR variable [20:42:56] ok thankx :) [20:43:04] (03PS1) 10Aaron Schulz: Made ActiveUsers use querycache and do staggered updates on view [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111258 [20:43:18] (03CR) 10Aaron Schulz: [C: 032] Made ActiveUsers use querycache and do staggered updates on view [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111258 (owner: 10Aaron Schulz) [20:44:05] (03PS1) 10Adi.iiita: Bug11269p1c [core] - 10https://gerrit.wikimedia.org/r/111259 [20:45:54] (03CR) 10jenkins-bot: [V: 04-1] Bug11269p1c [core] - 10https://gerrit.wikimedia.org/r/111259 (owner: 10Adi.iiita) [20:46:15] MatmaRex: Its done... Adi.iiita. thanks a lot :) [20:46:27] :) [20:47:57] MatmaRex: Please tell me what errors i faced in my patch. https://gerrit.wikimedia.org/r/111259 [20:48:10] (03Merged) 10jenkins-bot: Made ActiveUsers use querycache and do staggered updates on view [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111258 (owner: 10Aaron Schulz) [20:51:10] (03CR) 10Freakolowsky: [C: 031] Add sequence support for upsert in DatabaseOracle (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110991 (owner: 10Umherirrender) [20:51:11] zeek_: you can click on the links jenkins-bot posted to see [20:51:19] https://integration.wikimedia.org/ci/job/mediawiki-core-lint/34455/console [20:51:25] PHP Parse error: syntax error, unexpected ',' in languages/messages/MessagesQqq.php on line 2996 [20:52:57] hi MatmaRex [20:53:45] spage, jgonera, I forgot, MatmaRex has a patch already, so I'll review that. [20:56:50] hi Nikerabbit [20:57:41] (03CR) 10Mattflaschen: [C: 032] "Confirmed locally (e.g. fixes GettingStarted, no regressions on login and signup)." [core] - 10https://gerrit.wikimedia.org/r/110696 (owner: 10Bartosz Dziewoński) [20:58:38] MatmaRex: Its shows me some indentation errors and m more which i didnt modify in the first place. Should I ignore them? [20:59:06] Yes seen that error [20:59:39] (03PS1) 10Manybubbles: Turn on create and suggestions query has syntax [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/111261 [20:59:50] zeek_: yeah, you can mostly ignore the non-voting jobs [21:00:05] ok [21:00:06] (03PS1) 10Mattflaschen: Remove white-space: normal override. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111262 [21:01:17] (03Merged) 10jenkins-bot: mediawiki.ui: Remove white-space: nowrap; for buttons [core] - 10https://gerrit.wikimedia.org/r/110696 (owner: 10Bartosz Dziewoński) [21:03:12] (03CR) 10Mattflaschen: [C: 04-2] "Should be merged when https://gerrit.wikimedia.org/r/#/c/110696/ is deployed everywhere in production (and it's verified not be reverted)." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111262 (owner: 10Mattflaschen) [21:05:10] (03PS1) 10Adi.iiita: Bug11269p1d [core] - 10https://gerrit.wikimedia.org/r/111289 [21:07:13] zeek_: you should not change or remove the change-id line, btw [21:07:14] zeek_: that's what gerrit uses to track new versions of your patches [21:07:51] (03Abandoned) 10Bartosz Dziewoński: Bug11269p1c [core] - 10https://gerrit.wikimedia.org/r/111259 (owner: 10Adi.iiita) [21:07:52] You mean i should i keep same change id?? [21:08:06] MatmaRex:^ [21:08:07] zeek_: yes [21:09:38] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 047d6bf..8e4fe35 [extensions] - 10https://gerrit.wikimedia.org/r/111316 [21:09:40] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 047d6bf..8e4fe35 [extensions] - 10https://gerrit.wikimedia.org/r/111316 (owner: 10Jenkins-mwext-sync) [21:09:45] ok [21:09:47] (03PS1) 10Aaron Schulz: Hide bots by default on Special:ActiveUsers [core] - 10https://gerrit.wikimedia.org/r/111317 [21:10:02] legoktm: someone put up a patch to hide Jenkins-mwext-sync [21:10:49] er [21:10:51] someone uploaded one? [21:11:12] or I should? [21:11:48] channel hopping [21:11:48] https://gerrit.wikimedia.org/r/#/c/110830/ [21:12:09] (03PS1) 10Spage: Add flow-post-UUID hash to URL [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111320 [21:12:46] (03PS1) 10Spage: Mark API as a shim which will be replaced [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111321 [21:12:51] MatmaRex, YuviPanda: Changed my change id to the same as previous and tried to push. Got this error... http://fpaste.org/74448/91548321/ [21:13:07] (03PS1) 10Spage: Re-add historical link's to timespans [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111322 [21:13:47] zeek_: oh, heh [21:13:53] (03CR) 10Legoktm: [C: 04-1] "I think we should just ignore the Jenkins-mwext-sync bot like we do L10n-bot rather than the entire repo entirely." [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/110830 (owner: 10Jforrester) [21:14:09] :| [21:14:17] zeek_: i closed your previous change, i assumed you'll be working on the new one :) i can reopen it and close the new one instead [21:14:26] (the gerrit term for closing is also "abandoning") [21:15:03] (03PS1) 10Bsitu: Update Flow [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111323 [21:15:29] MatmaRex: well... if the new one works fine... then m ok.. but i guess it wouldn't because it is showing modification in just 2 files rather than 4... (I am so confused) :D [21:16:10] (03CR) 10Legoktm: [C: 04-1] Add hook SpecialCheckUserGetLinksFromRow (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/111249 (owner: 10EBernhardson) [21:16:14] oh. hmm [21:16:36] (03Restored) 10Bartosz Dziewoński: Bug11269p1c [core] - 10https://gerrit.wikimedia.org/r/111259 (owner: 10Adi.iiita) [21:16:43] zeek_: you created a new commit instead of amending the previous one [21:16:49] yes. [21:17:10] well, gerrit, unlike all other git workflows, doesn't like that [21:17:31] you need to amend commits if you iwsh to fix an existing patch [21:17:38] Ok now I am starting to realise.. that I patch should have one commit... and if i need to change then just amend.. [21:17:49] *one patch [21:17:59] (03CR) 10Manybubbles: "I finally got around to testing it. Dropped this into LocalSettings:" (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105986 (owner: 10Chad) [21:18:24] ohh yeah just as i thought.... so should I place the patch again in a new branch and submit? [21:18:31] MatmaRex: ^ [21:18:57] or there is some hack? :) [21:19:06] (03CR) 10EBernhardson: [C: 032] Add flow-post-UUID hash to URL [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111320 (owner: 10Spage) [21:19:13] (03Merged) 10jenkins-bot: Add flow-post-UUID hash to URL [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111320 (owner: 10Spage) [21:19:18] (03CR) 10EBernhardson: [C: 032] Mark API as a shim which will be replaced [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111321 (owner: 10Spage) [21:19:28] (03Merged) 10jenkins-bot: Mark API as a shim which will be replaced [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111321 (owner: 10Spage) [21:19:34] (03CR) 10EBernhardson: [C: 032] Re-add historical link's to timespans [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111322 (owner: 10Spage) [21:19:37] zeek_: you can use an interactive rebase to merge the two commits [21:19:44] (03Merged) 10jenkins-bot: Re-add historical link's to timespans [extensions/Flow] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111322 (owner: 10Spage) [21:20:04] zeek_: if you don't know what that is, it might be easier for you to just copy the files somewhere, delete your branch, start anew and copy them back [21:20:45] (03CR) 10Bsitu: [C: 032] Update Flow [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111323 (owner: 10Bsitu) [21:20:50] MatmaRex: I really want to learn how to do the 1st one... but I am totally on the 2nd one now.. :D [21:21:04] :D [21:22:11] (03PS1) 10IAlex: Remove trailing line breaks from wfDebugLog() messages [core] - 10https://gerrit.wikimedia.org/r/111324 [21:22:13] (03PS2) 10Aaron Schulz: Made UpdateSpecialPages support --list/--only with the callback updates [core] - 10https://gerrit.wikimedia.org/r/110398 [21:23:38] (03PS1) 10Mattflaschen: Use mediawiki.ui.button when mw-ui-button is used [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/111326 [21:23:57] (03Merged) 10jenkins-bot: Update Flow [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/111323 (owner: 10Bsitu) [21:24:47] (03PS1) 10Hashar: parsoidsvc-debian-glue [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/111328 [21:24:50] (03PS2) 10Mattflaschen: Use mediawiki.ui.button when mw-ui-button is used [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/111326 [21:27:21] (03CR) 10Hashar: [C: 032] "I use integration/jenkins-debian-glue.git to push new versions of upstream package. That trigger a jenkins job which build it for me using" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/111328 (owner: 10Hashar) [21:27:40] (03Merged) 10jenkins-bot: parsoidsvc-debian-glue [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/111328 (owner: 10Hashar) [21:27:45] (03CR) 10Parent5446: [C: 04-1] Add sequence support for upsert in DatabaseOracle (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110991 (owner: 10Umherirrender) [21:27:50] (03CR) 10Mattflaschen: "#2 for OAuth: https://gerrit.wikimedia.org/r/#/c/111326/" [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari) [21:28:15] (03CR) 10Hashar: "Sorry commented on wrong Gerrit change :-D" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/111328 (owner: 10Hashar) [21:28:41] (03PS1) 10Adi.iiita: Bug11269p1 Change-Id: Ibf9191f3a694014ad02eba9a58c600833e8361ec [core] - 10https://gerrit.wikimedia.org/r/111330 [21:29:34] (03CR) 10Chad: Moved $wgQueryPages stuff out of the global scope and into a function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/111248 (owner: 10Chad) [21:29:55] (03CR) 10Parent5446: [C: 032] Remove trailing line breaks from wfDebugLog() messages [core] - 10https://gerrit.wikimedia.org/r/111324 (owner: 10IAlex) [21:30:45] (03CR) 10Chad: WIP: Implement interwiki searches (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105986 (owner: 10Chad) [21:33:06] (03Merged) 10jenkins-bot: Remove trailing line breaks from wfDebugLog() messages [core] - 10https://gerrit.wikimedia.org/r/111324 (owner: 10IAlex) [21:33:21] (03PS2) 10EBernhardson: Add hook SpecialCheckUserGetLinksFromRow [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/111249 [21:33:45] MatmaRex: please see the patch now... https://gerrit.wikimedia.org/r/111330 .. hope its looks fine... :| Also if you could give me a link on what codes suppose to mean... PS1, PS2 CR etc? [21:33:51] (03CR) 10EBernhardson: Add hook SpecialCheckUserGetLinksFromRow (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/111249 (owner: 10EBernhardson) [21:34:24] <^d> zeek_: PS1, PS2, etc mean "patch set 1" [21:34:27] <^d> "Patch set 2" [21:34:28] <^d> etc. [21:34:34] <^d> "CR" means Code Review. [21:34:57] (03PS1) 10Hashar: trigger parsoidsvc-debian-glue (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/111331 [21:34:58] ^d thankx :) [21:35:16] (03CR) 10Hashar: [C: 032] trigger parsoidsvc-debian-glue (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/111331 (owner: 10Hashar) [21:35:22] (03Merged) 10jenkins-bot: trigger parsoidsvc-debian-glue (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/111331 (owner: 10Hashar) [21:37:24] (03PS1) 10Mattflaschen: Use mediawiki.ui.button when mw-ui-button is used [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111334 [21:45:03] (03PS1) 10Foxtrott: Switch from MW provided less compiler object to self-created one [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/111335 [21:45:54] (03CR) 10Foxtrott: [C: 032 V: 032] Switch from MW provided less compiler object to self-created one [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/111335 (owner: 10Foxtrott) [21:47:25] (03PS1) 10Bsitu: Update Flow [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111336 [21:48:18] (03CR) 10Bsitu: [C: 032] Update Flow [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111336 (owner: 10Bsitu) [21:49:13] (03CR) 10Adi.iiita: "Abandon this. I submitted fresh." [core] - 10https://gerrit.wikimedia.org/r/111259 (owner: 10Adi.iiita) [21:51:25] (03PS1) 10Aaron Schulz: Fixed use of qcc_value by Special:ActiveUsers [core] - 10https://gerrit.wikimedia.org/r/111337 [21:52:14] (03Merged) 10jenkins-bot: Update Flow [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111336 (owner: 10Bsitu) [21:52:22] (03PS2) 10Phuedx: Update onboarding CTA impression logging. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110580 [21:52:47] ori: ^ [21:53:43] (03PS12) 10Parent5446: Removed 'Remember my login' option from the Preferences page [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [21:54:11] (03PS13) 10Parent5446: Removed 'Remember my login' option from the Preferences page [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [21:54:45] (03PS1) 10Aaron Schulz: Fixed use of qcc_value by Special:ActiveUsers [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111338 [21:55:02] (03CR) 10Parent5446: "PS13: This is what I meant." [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [21:55:48] (03CR) 10Parent5446: [C: 031] Make a single # an invalid title in php and js [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender) [21:57:29] (03CR) 10Aaron Schulz: [C: 032] Fixed use of qcc_value by Special:ActiveUsers [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111338 (owner: 10Aaron Schulz) [22:00:20] (03PS1) 10Mattflaschen: Use mediawiki.ui.button when mw-ui-button is used [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111341 [22:00:54] (03Merged) 10jenkins-bot: Fixed use of qcc_value by Special:ActiveUsers [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/111338 (owner: 10Aaron Schulz) [22:06:51] (03PS3) 10EBernhardson: Add hook SpecialCheckUserGetLinksFromRow [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/111249 [22:13:59] (03PS2) 10Spage: Fix browser tests for new topic UI [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110597 [22:15:06] (03CR) 10Ori.livneh: [C: 032] Fixed use of qcc_value by Special:ActiveUsers [core] - 10https://gerrit.wikimedia.org/r/111337 (owner: 10Aaron Schulz) [22:18:04] (03PS1) 10EBernhardson: Replace usage of deprecated Title::escapeLocalURL() [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/111344 [22:18:24] (03Merged) 10jenkins-bot: Fixed use of qcc_value by Special:ActiveUsers [core] - 10https://gerrit.wikimedia.org/r/111337 (owner: 10Aaron Schulz) [22:18:41] (03PS1) 10Mattflaschen: Change toolbar button to mw-ui-progressive. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111345 [22:18:43] (03PS1) 10Mwalker: Remove Sphinx from SmashPig Jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/111346 [22:22:43] (03PS1) 10Mwalker: Make SmashPig Sphinx task non voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/111347 [22:23:01] (03Abandoned) 10Mwalker: Remove Sphinx from SmashPig Jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/111346 (owner: 10Mwalker) [22:32:45] (03CR) 10MarkTraceur: [C: 032] "Deploying now" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/111347 (owner: 10Mwalker) [22:32:51] (03Merged) 10jenkins-bot: Make SmashPig Sphinx task non voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/111347 (owner: 10Mwalker) [22:34:27] git show --pretty=fuller is pretty nice when you want to see when a commit got merged (as opposed to started). [22:37:35] (03CR) 10Mattflaschen: [C: 04-2] "I thought the change adding progressive was older than it is. This needs to wait until 1.23wmf11 is off the cluster (after the rotation T" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/111345 (owner: 10Mattflaschen) [22:37:55] (03PS1) 10Ori.livneh: Copy scap scripts from operations/puppet repository [tools/scap] - 10https://gerrit.wikimedia.org/r/111351 [22:38:29] (03CR) 10Ori.livneh: [C: 032 V: 032] Copy scap scripts from operations/puppet repository [tools/scap] - 10https://gerrit.wikimedia.org/r/111351 (owner: 10Ori.livneh) [22:45:56] (03PS1) 10BryanDavis: Place scripts in bin directory [tools/scap] - 10https://gerrit.wikimedia.org/r/111353 [22:47:06] (03CR) 10BryanDavis: [C: 032 V: 032] Place scripts in bin directory [tools/scap] - 10https://gerrit.wikimedia.org/r/111353 (owner: 10BryanDavis) [22:57:21] (03PS1) 10EBernhardson: Formatter for CheckUser rows [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111354 [23:02:19] (03PS1) 10Mattflaschen: Use mediawiki.ui.button instead of mediawiki.ui [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/111356 [23:02:30] (03PS18) 10Adamw: Provision the fundraising-crm project [vagrant] - 10https://gerrit.wikimedia.org/r/94950 [23:08:34] (03PS1) 10Ladsgroup: Add deleteToken and moveToken [core] - 10https://gerrit.wikimedia.org/r/111357 [23:09:23] (03PS1) 10Matthias Mullie: Fix typos [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111358 [23:09:24] (03PS1) 10Matthias Mullie: Remove 'latest' indexes on posts & headers. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111359 [23:09:24] (03PS1) 10Matthias Mullie: Move query-to-index-key code out of findMulti [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111360 [23:09:26] (03PS1) 10Matthias Mullie: Return correct internal value in LocalBufferedCache::get [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111361 [23:09:28] (03PS1) 10Matthias Mullie: Add method to test if LocalBufferedStorage has data in own cache already [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111362 [23:09:31] (03PS1) 10Matthias Mullie: Split up ShallowCompactor's expand; move building of queries into own method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111363 [23:09:34] (03PS1) 10Matthias Mullie: Introduce found & foundMulti, to test if index queries are in local storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111364 [23:09:37] (03PS1) 10Matthias Mullie: Similar to found, introduce got/gotMulti to test if data is in local cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111365 [23:09:40] (03PS1) 10Matthias Mullie: Add *Revisionable classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111366 [23:10:08] (03CR) 10jenkins-bot: [V: 04-1] Split up ShallowCompactor's expand; move building of queries into own method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111363 (owner: 10Matthias Mullie) [23:10:14] (03CR) 10jenkins-bot: [V: 04-1] Introduce found & foundMulti, to test if index queries are in local storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111364 (owner: 10Matthias Mullie) [23:10:21] (03CR) 10jenkins-bot: [V: 04-1] Similar to found, introduce got/gotMulti to test if data is in local cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111365 (owner: 10Matthias Mullie) [23:10:33] (03CR) 10jenkins-bot: [V: 04-1] Add *Revisionable classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111366 (owner: 10Matthias Mullie) [23:15:08] (03PS19) 10Adamw: Provision the fundraising-crm project [vagrant] - 10https://gerrit.wikimedia.org/r/94950 [23:16:05] (03CR) 10CSteipp: [C: 032] Use mediawiki.ui.button when mw-ui-button is used [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/111326 (owner: 10Mattflaschen) [23:16:10] (03Merged) 10jenkins-bot: Use mediawiki.ui.button when mw-ui-button is used [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/111326 (owner: 10Mattflaschen) [23:18:34] (03CR) 10EBernhardson: [C: 032] Fix typos [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111358 (owner: 10Matthias Mullie) [23:18:46] (03Merged) 10jenkins-bot: Fix typos [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111358 (owner: 10Matthias Mullie) [23:20:39] (03PS1) 10EBernhardson: Buffered cache is already hooked up to transactions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111368 [23:33:25] (03CR) 10Spage: "Excellent, just comment comments." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111224 (owner: 10EBernhardson) [23:34:26] (03PS2) 10Matthias Mullie: Split up ShallowCompactor's expand; move building of queries into own method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111363 [23:35:45] (03PS2) 10Matthias Mullie: Introduce found & foundMulti, to test if index queries are in local storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111364 [23:35:48] (03PS2) 10Matthias Mullie: Similar to found, introduce got/gotMulti to test if data is in local cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111365 [23:35:51] (03PS2) 10Matthias Mullie: Add *Revisionable classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111366 [23:47:57] (03CR) 10Matthias Mullie: Force word breaks in the various user content areas (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108972 (owner: 10Werdna) [23:48:00] (03PS4) 10Matthias Mullie: Force word breaks in the various user content areas [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108972 (owner: 10Werdna) [23:48:12] (03CR) 10Matthias Mullie: [C: 032] Force word breaks in the various user content areas [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108972 (owner: 10Werdna) [23:48:20] (03Merged) 10jenkins-bot: Force word breaks in the various user content areas [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108972 (owner: 10Werdna) [23:53:27] (03CR) 10EBernhardson: [C: 032] "Initially we were not passing options to the index to keep them simple, essentially pushing the logic of understanding query options to a" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111359 (owner: 10Matthias Mullie) [23:53:38] (03Merged) 10jenkins-bot: Remove 'latest' indexes on posts & headers. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111359 (owner: 10Matthias Mullie) [23:57:23] (03PS1) 10Jdlrobson: Copy over yet more assets [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/111376 [23:58:12] (03CR) 10EBernhardson: [C: 032] Move query-to-index-key code out of findMulti [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111360 (owner: 10Matthias Mullie) [23:58:23] (03Merged) 10jenkins-bot: Move query-to-index-key code out of findMulti [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111360 (owner: 10Matthias Mullie) [23:58:31] (03PS1) 10Ori.livneh: ensure tmpfile is accessible to dsh subprocess [tools/scap] - 10https://gerrit.wikimedia.org/r/111377 [23:58:50] ^ bd808 [23:58:57] (03CR) 10EBernhardson: [C: 032] "how did we never catch this previously? I'm quite surprised this codepath wasn't being run." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111361 (owner: 10Matthias Mullie) [23:59:08] (03Merged) 10jenkins-bot: Return correct internal value in LocalBufferedCache::get [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111361 (owner: 10Matthias Mullie) [23:59:44] (03CR) 10EBernhardson: [C: 032] Add method to test if LocalBufferedStorage has data in own cache already [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111362 (owner: 10Matthias Mullie) [23:59:58] (03Merged) 10jenkins-bot: Add method to test if LocalBufferedStorage has data in own cache already [extensions/Flow] - 10https://gerrit.wikimedia.org/r/111362 (owner: 10Matthias Mullie)