[00:06:16] (03PS1) 10Alex Monk: Fix API QUnit tests that are not aware of wgDebugToolbar [core] - 10https://gerrit.wikimedia.org/r/110894 [00:07:29] (03CR) 10Alex Monk: "(I don't like this solution much and it's probably wrong in all sorts of ways)" [core] - 10https://gerrit.wikimedia.org/r/110894 (owner: 10Alex Monk) [00:11:49] Krenair: http://i.imgur.com/t0XHtgJ.gif [00:12:46] :D [00:15:07] Krenair: hm, maybe mw.api should be just delete'ing the debuginfo key? (and the test would check if === [] || === {}) [00:15:28] Krenair: i actually find it hard to believe no other tests break because of this [00:16:32] Well other stuff definitely broke because of it: https://gerrit.wikimedia.org/r/#/c/110478/ (IIRC there was something else I found ages ago with this issue, can't remember the details). Don't know about other tests [00:17:37] meh, the root cause is that in PHP, {} and [] are the same thing [00:17:41] fact: PHP sucks [00:18:08] MatmaRex: May I introduce you to Gnu bash? :P [00:18:54] php > var_dump( json_decode( '{}' ) == json_decode( '[]' ) ); [00:18:54] bool(false) [00:20:04] But it's bool(true) if you give $assoc = true to the first json_decode. So... sometimes [00:20:50] why do people take everything literally? D: [00:21:01] MatmaRex: :P [00:21:09] <{{Technical_13}}> That's how we roll...