[00:30:39] (03Abandoned) 10Bartosz Dziewoński: AJAXify watchlist editor [core] - 10https://gerrit.wikimedia.org/r/63274 (owner: 10Bartosz Dziewoński) [00:46:33] (03CR) 10Alex Monk: "We'll want to add other, similar auto-completion functions soon so hoo suggested that these go under $( ... ).mediawiki... Not sure how yo" [core] - 10https://gerrit.wikimedia.org/r/110820 (owner: 10Alex Monk) [00:56:13] MatmaRex, did you mean to abandon that? [00:56:37] yep [00:56:54] it's not a very good idea the way it's done [00:57:11] and no one touched it in months (including me) [01:01:52] (03CR) 10Legoktm: "I wonder if it would be possible to have the autocomplete-er automatically run on $('.mw-autocomplete-user') or something so you don't hav" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110820 (owner: 10Alex Monk) [01:02:10] (03PS3) 10Isarra: (Bug 55424) Add a link to nuke a user from Special:Contributions [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/110669 [01:16:17] who wants to mark three and a half bugs fixed with one merge? https://gerrit.wikimedia.org/r/#/c/82100/ [01:25:24] legoktm, I guess we want to run the code to pick up all .mw-autocomplete-user on each special page? [01:26:36] err, well I think the special page should still have a $this->getOutput()->addModules( 'jquery.ui.autocomplete.user') (or whatever), but that would pick up the .mw-autocomplete-user [01:36:04] (03PS3) 10Alex Monk: Autocomplete performer field on Special:Log [core] - 10https://gerrit.wikimedia.org/r/110820 [01:37:56] legoktm, how's that? [01:38:45] :D [01:39:56] (03CR) 10jenkins-bot: [V: 04-1] Autocomplete performer field on Special:Log [core] - 10https://gerrit.wikimedia.org/r/110820 (owner: 10Alex Monk) [01:40:02] doh. [01:40:39] jenkins-bot... what... [01:40:53] legoktm, what's the command to rerun tests again? [01:41:05] 'retest' right? [01:41:09] just edit the commit message or hit rebase [01:41:13] (03CR) 10Alex Monk: "retest" [core] - 10https://gerrit.wikimedia.org/r/110820 (owner: 10Alex Monk) [01:41:15] 'recheck' but that only runs the +1 tests [01:41:35] ugh. [01:41:57] jsduck is a +1 [01:42:04] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/110820 (owner: 10Alex Monk) [01:42:36] "queued" [01:43:40] Weren't we able to retrigger tests through the jenkins web ui at some point? [03:06:33] (03CR) 10Krinkle: [C: 031] "It will still be caught relatively early on. Namely in the loop of ResourceLoader::makeModuleResponse, which makes sure the exception gets" [core] - 10https://gerrit.wikimedia.org/r/109956 (owner: 10Umherirrender) [03:14:20] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 84433d6..74242c7 [extensions] - 10https://gerrit.wikimedia.org/r/110829 [03:14:22] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 84433d6..74242c7 [extensions] - 10https://gerrit.wikimedia.org/r/110829 (owner: 10Jenkins-mwext-sync) [03:30:17] (03PS1) 10Jforrester: Suppress updates to mediawiki/extensions [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/110830 [03:38:41] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 74242c7..7b54c6d [extensions] - 10https://gerrit.wikimedia.org/r/110831 [03:38:43] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 74242c7..7b54c6d [extensions] - 10https://gerrit.wikimedia.org/r/110831 (owner: 10Jenkins-mwext-sync) [03:41:04] (03PS2) 10TTO: Add $wgLocalInterwikis to handle multiple local prefixes [core] - 10https://gerrit.wikimedia.org/r/110162 [03:41:55] (03CR) 10jenkins-bot: [V: 04-1] Add $wgLocalInterwikis to handle multiple local prefixes [core] - 10https://gerrit.wikimedia.org/r/110162 (owner: 10TTO) [03:45:58] (03PS3) 10TTO: Add $wgLocalInterwikis to handle multiple local prefixes [core] - 10https://gerrit.wikimedia.org/r/110162 [03:47:54] (03CR) 10TTO: "Was this backported? The idea was for this patch to be merged quickly..." [core] - 10https://gerrit.wikimedia.org/r/109496 (owner: 10TTO) [03:53:53] (03CR) 10Krinkle: Autocomplete performer field on Special:Log (035 comments) [core] - 10https://gerrit.wikimedia.org/r/110820 (owner: 10Alex Monk) [04:01:58] (03PS4) 10Alex Monk: Autocomplete performer field on Special:Log [core] - 10https://gerrit.wikimedia.org/r/110820 [04:03:01] (03PS5) 10Alex Monk: Autocomplete performer field on Special:Log [core] - 10https://gerrit.wikimedia.org/r/110820 [04:03:39] legoktm, ^ seems the select function is unnecessary. might want to remove it from the example page [04:06:40] (03CR) 10jenkins-bot: [V: 04-1] Autocomplete performer field on Special:Log [core] - 10https://gerrit.wikimedia.org/r/110820 (owner: 10Alex Monk) [04:07:02] (03CR) 10Alex Monk: "recheck" [core] - 10https://gerrit.wikimedia.org/r/110820 (owner: 10Alex Monk) [04:08:50] (03CR) 10Alex Monk: [C: 032] Override SpecialPage::execute instead of setting a callback function [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/105427 (owner: 10Legoktm) [04:08:54] (03Merged) 10jenkins-bot: Override SpecialPage::execute instead of setting a callback function [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/105427 (owner: 10Legoktm) [04:19:06] (03CR) 10Alex Monk: [C: 032] Pass context to HTMLForm, don't use HTMLForm::setTitle [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/100330 (owner: 10Legoktm) [04:19:08] (03Merged) 10jenkins-bot: Pass context to HTMLForm, don't use HTMLForm::setTitle [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/100330 (owner: 10Legoktm) [04:22:15] (03PS1) 10TTO: Add SkinTemplateLanguageLinks hook [core] - 10https://gerrit.wikimedia.org/r/110832 [05:13:13] (03PS8) 1001tonythomas: Ticking search in all namespaces should disable and tick all the remaining checkboxes. [core] - 10https://gerrit.wikimedia.org/r/110610 [05:14:35] (03CR) 10jenkins-bot: [V: 04-1] Ticking search in all namespaces should disable and tick all the remaining checkboxes. [core] - 10https://gerrit.wikimedia.org/r/110610 (owner: 1001tonythomas) [05:16:26] (03PS9) 1001tonythomas: Ticking search in all namespaces should disable and tick all the remaining checkboxes. [core] - 10https://gerrit.wikimedia.org/r/110610 [05:17:46] (03CR) 10jenkins-bot: [V: 04-1] Ticking search in all namespaces should disable and tick all the remaining checkboxes. [core] - 10https://gerrit.wikimedia.org/r/110610 (owner: 1001tonythomas) [05:26:19] (03PS10) 1001tonythomas: Ticking search in all namespaces should disable and tick all the remaining checkboxes. [core] - 10https://gerrit.wikimedia.org/r/110610 [05:29:24] (03CR) 1001tonythomas: "Now, ticking the 'search in all namespace' will disable all other checkboxes, plus select them all." [core] - 10https://gerrit.wikimedia.org/r/110610 (owner: 1001tonythomas) [05:38:45] (03CR) 10Parent5446: [C: 04-1] Add SkinTemplateLanguageLinks hook (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110832 (owner: 10TTO) [06:05:27] (03CR) 10TTO: "Would you change your opinion if I told you that all other hooks (bar one) in SkinTemplate.php pass $this by reference?" [core] - 10https://gerrit.wikimedia.org/r/110832 (owner: 10TTO) [08:34:26] (03CR) 10Siebrand: (Bug 55424) Add a link to nuke a user from Special:Contributions (032 comments) [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/110669 (owner: 10Isarra) [08:34:51] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/110669 (owner: 10Isarra) [08:36:36] (03PS1) 10Siebrand: Fix rebuildall.php fatal error with PostgreSQL [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110835 [08:58:10] (03PS2) 10Siebrand: Fix rebuildall.php fatal error with PostgreSQL [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110835 [09:02:57] (03PS1) 10Siebrand: Avoid variable naming conflicts in DatabasePostgres::selectSQLText [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110836 [09:32:02] Morning. [09:35:13] (03CR) 10Siebrand: [C: 032] Module namespace translations for Serbian Latin and Croatian [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/108469 (owner: 10Raimond Spekking) [09:37:07] (03Merged) 10jenkins-bot: Module namespace translations for Serbian Latin and Croatian [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/108469 (owner: 10Raimond Spekking) [09:37:29] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/99422 (owner: 1001tonythomas) [09:38:43] (03CR) 10Siebrand: [C: 032 V: 032] Initial commit [extensions/GlobalContributions] - 10https://gerrit.wikimedia.org/r/105911 (owner: 10Legoktm) [09:40:14] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/97559 (owner: 10Jackmcbarn) [09:45:26] (03CR) 10Siebrand: [C: 032] Transclude translation for preference edit section to ensure consistency of translation [core] - 10https://gerrit.wikimedia.org/r/58668 (owner: 10Raimond Spekking) [09:45:53] (03PS1) 10UltrasonicNXT: Ensure PMs are dismissed properly [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/110837 [09:47:09] (03PS2) 10UltrasonicNXT: Ensure PMs are dismissed properly [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/110837 [09:47:46] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Ensure PMs are dismissed properly [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/110837 (owner: 10UltrasonicNXT) [09:49:24] (03Merged) 10jenkins-bot: Transclude translation for preference edit section to ensure consistency of translation [core] - 10https://gerrit.wikimedia.org/r/58668 (owner: 10Raimond Spekking) [09:52:31] (03CR) 10Siebrand: Parser functions now format numbers according to page language (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110342 (owner: 10Nikerabbit) [10:11:18] (03CR) 10UltrasonicNXT: "Is there anything else I can do for this?" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97383 (owner: 10UltrasonicNXT) [10:28:10] (03PS3) 1001tonythomas: Removed 'Enable simplified search bar (Vector skin only)' from MW user Preference [core] - 10https://gerrit.wikimedia.org/r/99422 [10:31:08] (03PS4) 1001tonythomas: Removed 'Enable simplified search bar (Vector skin only)' from MW user Preference [core] - 10https://gerrit.wikimedia.org/r/99422 [10:33:21] (03CR) 1001tonythomas: "Rebased change." [core] - 10https://gerrit.wikimedia.org/r/99422 (owner: 1001tonythomas) [10:43:16] marktraceur: you around ? [10:44:12] tonythomas01: Sort of [10:44:17] What can I do for you? [10:44:38] marktraceur: remember that exit backdrop patch for multimediaviewer ? [10:45:00] Yup [10:45:02] marktraceur: I have one implemented succesffully. Can you go through it [10:45:08] Uh, maybe! [10:45:14] marktraceur: https://gerrit.wikimedia.org/r/#/c/108317/ [10:45:48] Looking. [10:45:58] marktraceur: :) [10:47:35] It does indeed work [10:48:39] marktraceur: thanks. the approach is enough ? [10:48:55] marktraceur: I couldn't find another way to get that black div [10:49:38] It's good, yeah. [10:49:46] That's the way I told you to do it, so it makes sense [10:50:04] marktraceur: yeah. ! [10:50:05] A few style things and it'll be ready to go [10:50:12] style things ? [10:50:23] See the patch - I've commented [10:50:26] ok [10:50:40] And now it's nearly 03:00 and I should probably go to bed [10:50:57] I'll review your updated patchset tomorrow, I hope [10:51:30] ok ! thanks [10:51:39] will upload it soon [10:54:22] marktraceur: I have uploaded the new one. Review on your ease [10:54:39] Hm, you caught me halfway through my bedtime snack, I'll just review now [10:54:51] marktraceur: ha [10:55:57] Done! [10:56:17] marktraceur: thanks :) [10:56:30] That will go out to beta-labs in the next ten minutes or so [10:56:36] And out to mediawiki.org on Thursdya [10:56:37] had been a long wait. ! anyway happy [10:56:41] ok :) [10:57:13] Thursday our time, though - I guess that's early Friday your time [10:57:52] marktraceur: yes. I will wait [10:58:03] :) [10:58:21] Let me know if you need thoughts about next steps, or more review [10:58:43] I dunno about other folks on that repo, but I'm way more responsive to IRC than I am to in-Gerrit review requests, or emails [11:01:51] marktraceur: of course. Can you help me with getting further [11:02:03] not today. you should go sleep. I will ping you, say tommorow [11:02:16] Yeah, good plan [11:02:24] marktraceur: :) [11:08:02] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Minor overescaping issue." (032 comments) [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/110669 (owner: 10Isarra) [12:26:40] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/99422 (owner: 1001tonythomas) [12:30:13] (03CR) 10Nikerabbit: "PHP Notice: Undefined variable: wgSearchType in /www/translatewiki.net/w/extensions/LiquidThreads/pages/TalkpageView.php on line 311" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/110616 (owner: 10Alex Monk) [12:31:23] (03CR) 10Siebrand: [C: 04-1] "L10n reviewed. See inline comments." (032 comments) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/110243 (owner: 10Reedy) [12:32:24] (03PS1) 10Nikerabbit: Fix Undefined wgSearchType [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/110846 [12:32:39] (03CR) 10Siebrand: WIP: Add messages for Trademark Licensing form for foundationwiki (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/110243 (owner: 10Reedy) [12:33:01] (03CR) 10Siebrand: [C: 032] Fix Undefined wgSearchType [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/110846 (owner: 10Nikerabbit) [12:33:03] (03Merged) 10jenkins-bot: Fix Undefined wgSearchType [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/110846 (owner: 10Nikerabbit) [12:36:01] (03CR) 10Nemo bis: "Needs cherry-pick I suppose?" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/110846 (owner: 10Nikerabbit) [13:28:25] (03CR) 10Siebrand: [C: 032 V: 032] Add i18n file [extensions/YetAnotherKeywords] - 10https://gerrit.wikimedia.org/r/108026 (owner: 10Raimond Spekking) [13:33:58] (03CR) 10Siebrand: [C: 04-2] "Removed merge block, as dependency was merged." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105235 (owner: 10Chad) [13:34:20] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105235 (owner: 10Chad) [14:14:05] (03CR) 10Siebrand: [C: 04-2] "I closed the bug with the following reasoning. It's also why I'm adding "Do not submit" to this patch set." [core] - 10https://gerrit.wikimedia.org/r/109658 (owner: 10Arav93) [14:38:41] Question, the toolserver doesn't work [14:38:47] Why's that? [14:46:24] why would we know? [14:47:50] toolserver folks hang out at #wikimedia-toolserver [15:03:45] (03PS1) 10Ori.livneh: Touch INSTALL to test merge proccess [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110857 [15:04:17] (03CR) 10Ori.livneh: [C: 032] Touch INSTALL to test merge proccess [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110857 (owner: 10Ori.livneh) [15:07:15] (03CR) 10Siebrand: "If I look at this solution, I still see text parts being glued together.Is there anything against creating strings for the full messages, " [core] - 10https://gerrit.wikimedia.org/r/109296 (owner: 10Microchip08) [15:07:54] (03Merged) 10jenkins-bot: Touch INSTALL to test merge proccess [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110857 (owner: 10Ori.livneh) [15:12:57] (03CR) 10Siebrand: [C: 04-1] Make show/hide link in RC individually localizable [core] - 10https://gerrit.wikimedia.org/r/109296 (owner: 10Microchip08) [15:14:00] (03CR) 10Siebrand: Gave a new error message for !isValidTiff() (031 comment) [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/107039 (owner: 1001tonythomas) [15:14:41] (03CR) 10Siebrand: [C: 04-1] Renamed"{{SITENAME}}" to "wikipedia" in ArticleFeedbackv5.i18n.php [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/109473 (owner: 10Arav93) [15:14:41] https://www.mediawiki.org/wiki/Template:SITENAME [15:21:28] (03CR) 10Siebrand: "I like the feature, I'm less impressed with the look of it :). I've voiced concerns about our default solution to glue new strings, someth" [core] - 10https://gerrit.wikimedia.org/r/94064 (owner: 10Nemo bis) [15:25:16] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/108487 (owner: 10Hydriz) [15:27:24] (03CR) 10Nemo bis: "Personally I don't like icons and tooltips so I doubt I'll spend time on that, but someone else may implement it if you file a bug." [core] - 10https://gerrit.wikimedia.org/r/94064 (owner: 10Nemo bis) [15:27:44] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109445 (owner: 10Werdna) [15:29:34] (03CR) 10Siebrand: Changed permission needed for throttle override (031 comment) [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/109443 (owner: 10Parent5446) [15:38:03] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Collection] - 10https://gerrit.wikimedia.org/r/107620 (owner: 10Anomie) [15:43:20] Reedy, around? [15:48:34] (03PS7) 10Hydriz: Add the ability to export pages within a prefix. [core] - 10https://gerrit.wikimedia.org/r/108487 [15:52:21] Nikerabbit: Well now I feel pretty stupid. [15:54:27] don't [15:54:45] but cherry-pick if needed pls [15:57:08] (03PS1) 10Alex Monk: Fix Undefined wgSearchType [extensions/LiquidThreads] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/110860 [15:57:22] (03PS1) 10Alex Monk: Fix Undefined wgSearchType [extensions/LiquidThreads] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110861 [16:27:33] (03PS1) 10Alex Monk: Don't try to insert the pending changes in the middle of VE's 'Edit' and 'Edit source' [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/110862 [17:11:48] (03PS1) 10Bartosz Dziewoński: ChangesListSpecialPage: Remove all functionality for generating feeds [core] - 10https://gerrit.wikimedia.org/r/110864 [17:15:36] (03CR) 10Bartosz Dziewoński: "This all will become moot if we ever solve bug 48615, and I definitely intend to solve it sometime soonish. I still think we should merge " [core] - 10https://gerrit.wikimedia.org/r/109296 (owner: 10Microchip08) [17:18:56] (03CR) 10MZMcBride: "Ugh." [core] - 10https://gerrit.wikimedia.org/r/109710 (owner: 10Aaron Schulz) [17:19:19] (03PS5) 10UltrasonicNXT: Allow the removal of various features [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97383 [17:26:46] (03CR) 10MZMcBride: "Miser mode sucks. It's an ugly, horrible hack that should only ever be viewed as temporary. I hope everyone writing and reviewing code tha" [core] - 10https://gerrit.wikimedia.org/r/109710 (owner: 10Aaron Schulz) [17:30:40] (03CR) 10Bartosz Dziewoński: "MZMcBride, Aaron is already working on a proper solution to this, miser-mode-free: https://gerrit.wikimedia.org/r/110299" [core] - 10https://gerrit.wikimedia.org/r/109710 (owner: 10Aaron Schulz) [17:31:20] * Gloria blinks at MatmaRex. [17:31:29] (03CR) 10Nemo bis: "MZ, I think the "miser" part of the name already implies "sucks". :P" [core] - 10https://gerrit.wikimedia.org/r/109710 (owner: 10Aaron Schulz) [17:31:45] (03CR) 10Bartosz Dziewoński: "Bah, not this. I should read more than just commit message topics." [core] - 10https://gerrit.wikimedia.org/r/109710 (owner: 10Aaron Schulz) [17:32:04] i assume it's about active users [17:32:13] It's not. :-) [17:32:14] since that's what everyone but you is complaining about right now :P [17:32:39] (03CR) 10MZMcBride: "Related: bug 60740" [core] - 10https://gerrit.wikimedia.org/r/109710 (owner: 10Aaron Schulz) [17:32:48] clearly we need more tables to count things in other tables [17:32:54] Obviously Gloria is complaining about info action rather. [17:33:14] MatmaRex: Well, most templates have few transclusions. And miser mode applies to all Wikimedia wikis. [17:33:28] So this is a pretty heavy-handed change. [17:33:39] I can't reproduce https://bugzilla.wikimedia.org/show_bug.cgi?id=60738, even on deployment-prep... Any ideas? [17:33:47] Have you tried restarting? [17:34:06] Race conditions are always annoying to reproduce. [17:34:24] Does Special:UserRights submit a timestamp like ?action=edit ? [17:34:55] It uses a comma-separated list of current groups to do conflict detection [17:35:01] I think this type of conflict resolution has been handled throughout the code base. [17:35:08] (03PS5) 10Nemo bis: Made ActiveUsers use querycache and do staggered updates on view [core] - 10https://gerrit.wikimedia.org/r/110299 (owner: 10Aaron Schulz) [17:35:16] This works on my local wiki and deployment-prep, but apparently not commons? [17:35:50] The approach sounds funky. [17:36:04] I'm not sure relying on a comma-separated list is sane. [17:36:29] Why not use a timestamp? [17:36:40] Aaron approved it... [17:41:09] I think we (me and hoo?) decided to do it this way on the 23rd of April last year after some IRC discussion. I don't remember why. Might be to do with not needing memcached: https://gerrit.wikimedia.org/r/#/c/60229/5..6/includes/specials/SpecialUserrights.php [17:44:46] Ah yes, here it is: Apr 23 23:18:50 https://gerrit.wikimedia.org/r/#/c/60229/5/includes/specials/SpecialUserrights.php Why so complicated? It would be much easier to just pass a list of set groups as hidden field to the form and check that in the submit function against the then set groups, no? [17:46:58] oh that [17:47:05] where's the problem with it [17:47:18] Odder managed to break it on commons. [17:47:37] yikes... how? Sorting? [17:47:45] https://bugzilla.wikimedia.org/show_bug.cgi?id=60738 [17:48:57] Krenair: I see... can be solved by clearing cache and loading stuff from master [17:49:09] not sure that's totally worth it [17:49:50] Well I thought it was loading from master :/ [17:52:08] (03PS6) 10UltrasonicNXT: Allow the removal of various features [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97383 [17:52:53] hoo, woops, apparently not. [17:52:54] Krenair: Probably running User::clearInstanceCache just before checking will solve that [17:53:00] (03Abandoned) 10Physikerwelt: WIP: Add mathsearch test data [vagrant] - 10https://gerrit.wikimedia.org/r/108856 (owner: 10Physikerwelt) [17:55:09] hoo, hmm, before generating the conflictcheck group list as well? [17:55:34] Krenair: Can be, but before actually changing things is more important [18:00:04] hoo, I would prefer to reproduce the issue before making a change like this :/ [18:01:01] Have fun then... timing problems are hard to reproduce [18:08:45] (03PS1) 10Alex Monk: Clear user cache before checking userrights conflict [core] - 10https://gerrit.wikimedia.org/r/110869 [18:12:05] Krenair: Did you test it? So that it doesn't break :P [18:12:21] hoo, I tested that I could still make userrights changes and that conflicts were still detected [18:12:32] k [18:12:58] (as much as I could before.) [18:14:55] (03CR) 10Hoo man: [C: 032] "As this will reload the user groups from master, it should solve the issues." [core] - 10https://gerrit.wikimedia.org/r/110869 (owner: 10Alex Monk) [18:15:02] there you go ;) [18:15:29] (03PS1) 10UltrasonicNXT: Fix users being 'kicked' on unban [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/110870 [18:15:55] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix users being 'kicked' on unban [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/110870 (owner: 10UltrasonicNXT) [18:17:56] (03Merged) 10jenkins-bot: Clear user cache before checking userrights conflict [core] - 10https://gerrit.wikimedia.org/r/110869 (owner: 10Alex Monk) [18:31:28] (03PS1) 10Physikerwelt: Fix: Rename variables in TextSearch section [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/110871 [18:31:43] (03PS4) 10Isarra: (Bug 55424) Add a link to nuke a user from Special:Contributions [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/110669 [18:38:32] (03PS2) 10Physikerwelt: Fix: Rename variables in TextSearch section [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/110871 [18:39:59] (03CR) 10Physikerwelt: [C: 032 V: 032] Fix: Rename variables in TextSearch section [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/110871 (owner: 10Physikerwelt) [18:44:11] (03PS1) 10UltrasonicNXT: Use POST requests on write actions [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/110872 [18:45:48] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Use POST requests on write actions [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/110872 (owner: 10UltrasonicNXT) [18:55:14] (03CR) 10Parent5446: [C: 031] "Haven't tested" [core] - 10https://gerrit.wikimedia.org/r/99422 (owner: 1001tonythomas) [18:56:58] (03CR) 10Parent5446: [C: 032] Fix rebuildall.php fatal error with PostgreSQL [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110835 (owner: 10Siebrand) [18:57:22] (03CR) 10Parent5446: [C: 032] Avoid variable naming conflicts in DatabasePostgres::selectSQLText [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110836 (owner: 10Siebrand) [19:00:31] (03Merged) 10jenkins-bot: Fix rebuildall.php fatal error with PostgreSQL [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110835 (owner: 10Siebrand) [19:00:35] (03Merged) 10jenkins-bot: Avoid variable naming conflicts in DatabasePostgres::selectSQLText [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110836 (owner: 10Siebrand) [19:22:23] Hi, could I ask the following patch is reviewed? https://gerrit.wikimedia.org/r/#/c/110693/ [19:23:26] (03PS7) 10Bartosz Dziewoński: Added wfSuppressWarnings and wfRestoreWarnings [core] - 10https://gerrit.wikimedia.org/r/110693 (owner: 10Imjacobclark) [19:23:38] (03CR) 10Bartosz Dziewoński: "Hard-wrapped the commit message." [core] - 10https://gerrit.wikimedia.org/r/110693 (owner: 10Imjacobclark) [19:24:45] huh, we don't always wrap ini_set with warnings suppression [19:24:48] but sometimes we do [19:28:07] (03CR) 10Bartosz Dziewoński: [C: 032] Added wfSuppressWarnings and wfRestoreWarnings [core] - 10https://gerrit.wikimedia.org/r/110693 (owner: 10Imjacobclark) [19:28:16] imjacobclark: :) [19:28:58] Awesome :) [19:29:00] Thanks haha [19:30:00] Yes it was flagged as a bug as it's not required and thus the messages can be surpressed [19:30:43] (03PS1) 10Jack Phoenix: Fix PHP Fatal error: Call to undefined method Title::getPrefixedTitle(). [core] - 10https://gerrit.wikimedia.org/r/110875 [19:31:08] ^that had been there almost for five years; what do I win? [19:31:34] (03Merged) 10jenkins-bot: Added wfSuppressWarnings and wfRestoreWarnings [core] - 10https://gerrit.wikimedia.org/r/110693 (owner: 10Imjacobclark) [19:33:23] (03CR) 10Bartosz Dziewoński: [C: 032] "Lol." [core] - 10https://gerrit.wikimedia.org/r/110875 (owner: 10Jack Phoenix) [19:36:49] (03Merged) 10jenkins-bot: Fix PHP Fatal error: Call to undefined method Title::getPrefixedTitle(). [core] - 10https://gerrit.wikimedia.org/r/110875 (owner: 10Jack Phoenix) [19:37:02] ashley: there's a very funny idiom in polish that basically means "a handshake from the chairman" that doesn't really translate well to english. so, that. :D [19:40:48] (03CR) 10Bartosz Dziewoński: [C: 032] (Bug 55424) Add a link to nuke a user from Special:Contributions [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/110669 (owner: 10Isarra) [19:40:50] (03Merged) 10jenkins-bot: (Bug 55424) Add a link to nuke a user from Special:Contributions [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/110669 (owner: 10Isarra) [19:41:02] MatmaRex: my Polish is pl-0.1 or so -- I know the most important profanities or so :p you should teach me more one of these days! [19:44:16] ashley: just like my finnish, heh [19:44:40] it's always good to start with the most important things (-; [19:45:37] perkele, kurwa mac!:P [19:47:31] hey I understood perkele! [19:47:53] does that make me fi-0.01? :P [19:56:57] (03Abandoned) 10Hashar: API: let user fetch categories sorted by keyprefix [core] - 10https://gerrit.wikimedia.org/r/9960 (owner: 10Catrope) [19:57:22] Krenair: oh neat [19:57:23] (03CR) 10Bartosz Dziewoński: "The module has since been rewritten. Wanna try and see if this is still necessary, and if so, reapply?" [core] - 10https://gerrit.wikimedia.org/r/65871 (owner: 10Mattflaschen) [19:58:01] legoktm, ? [19:58:08] [08:03:39 PM] legoktm, ^ seems the select function is unnecessary. might want to remove it from the example page [19:58:10] (03PS4) 10Liangent: Write a better explaination for tog-noconvertlink. [core] - 10https://gerrit.wikimedia.org/r/19769 [19:58:15] ah [20:00:01] (03Abandoned) 10Hashar: (bug 27849) Add normalized info for Unicode normalization of titles [core] - 10https://gerrit.wikimedia.org/r/22831 (owner: 10Catrope) [20:00:48] (03Abandoned) 10Hashar: (bug 28162) Installer ignores initial DBport [core] - 10https://gerrit.wikimedia.org/r/8906 (owner: 10saper) [20:02:05] (03Abandoned) 10Hashar: Add a "User auth" extension group to Special:Version. [core] - 10https://gerrit.wikimedia.org/r/29719 (owner: 10Daniel Friesen) [20:04:03] (03Abandoned) 10Hashar: [DO NOT MERGE] Rough and ready proof of concept for search suggestions [core] - 10https://gerrit.wikimedia.org/r/41365 (owner: 10Jarry1250) [20:04:54] (03Abandoned) 10Hashar: allowing negative timestamps, BC [core] - 10https://gerrit.wikimedia.org/r/55854 (owner: 10Toniher) [20:06:59] (03Abandoned) 10Hashar: Add a Html::escape method. [core] - 10https://gerrit.wikimedia.org/r/67605 (owner: 10Daniel Friesen) [20:12:33] (03PS1) 10UltrasonicNXT: Replace chat-specific message with MW equivalent [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/110877 [20:13:53] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Replace chat-specific message with MW equivalent [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/110877 (owner: 10UltrasonicNXT) [20:14:31] (03CR) 10UltrasonicNXT: "(Raimond - just added you to check that I can delete messages like this and it won't screw up TMN?)" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/110877 (owner: 10UltrasonicNXT) [20:14:40] (03PS1) 10Legoktm: autocomplete: Remove unnecessary select function [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/110878 [20:14:57] Krenair: ^ [20:16:47] (03Abandoned) 10UltrasonicNXT: Code style [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/95853 (owner: 10UltrasonicNXT) [20:24:28] (03CR) 10Raimond Spekking: "Adam: It's fine to delete messages. TWN will handle it correctly." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/110877 (owner: 10UltrasonicNXT) [20:34:19] (03PS1) 10Hashar: test: remove creation UTPage [core] - 10https://gerrit.wikimedia.org/r/110879 [20:39:01] (03CR) 10Hashar: "Now I am wondering why we create a UTPage article :-D" [core] - 10https://gerrit.wikimedia.org/r/110879 (owner: 10Hashar) [20:49:12] (03PS1) 10Se4598: abuse_filter_log table only uses tinyint not int for namespace ID [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/110881 [20:49:59] (03PS1) 10Hashar: test: remove creation of UTSysop [core] - 10https://gerrit.wikimedia.org/r/110882 [20:51:14] (03PS2) 10Se4598: abuse_filter_log table only uses tinyint not int for namespace ID [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/110881 [20:53:18] (03CR) 10jenkins-bot: [V: 04-1] test: remove creation of UTSysop [core] - 10https://gerrit.wikimedia.org/r/110882 (owner: 10Hashar) [21:11:45] (03CR) 10Alex Monk: [C: 032] autocomplete: Remove unnecessary select function [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/110878 (owner: 10Legoktm) [21:11:53] (03Merged) 10jenkins-bot: autocomplete: Remove unnecessary select function [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/110878 (owner: 10Legoktm) [21:28:34] Hey, who wants to vote for or against an easter egg? :D https://gerrit.wikimedia.org/r/110874 [21:28:56] currently 3 to 2 for easter egg^^ [21:29:18] help me with this ... http://tinyurl.com/otsf6w6 [21:29:25] (03PS1) 10AalekhN: jquery.fullscreen.js: Includes toggle handler in jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/110883 [21:30:46] (03CR) 10jenkins-bot: [V: 04-1] jquery.fullscreen.js: Includes toggle handler in jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/110883 (owner: 10AalekhN) [21:36:15] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Please submit any changes upstream first: https://github.com/theopolisme/jquery-fullscreen/" [core] - 10https://gerrit.wikimedia.org/r/110883 (owner: 10AalekhN) [21:38:45] (03PS1) 10Physikerwelt: Add setup for IBM DB2 driver [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/110885 [21:40:43] (03CR) 10Physikerwelt: "Probably a nice feature would be to check out the latest n version from mediawiki core only. checking out everything takes a large portion" [vagrant] - 10https://gerrit.wikimedia.org/r/107802 (owner: 10Physikerwelt) [21:42:05] (03CR) 10Physikerwelt: [C: 032 V: 032] Add setup for IBM DB2 driver [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/110885 (owner: 10Physikerwelt) [22:21:54] (03CR) 10Theopolisme: "Commented on the pull request, thanks!" [core] - 10https://gerrit.wikimedia.org/r/110523 (owner: 10Gilles) [23:13:15] (03CR) 10Se4598: "reminder to myself: If I have a lot of time and better knowledge, I should probably look at https://gerrit.wikimedia.org/r/64594 as an exa" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/110881 (owner: 10Se4598) [23:17:42] (03PS3) 10Se4598: abuse_filter_log table only uses tinyint not int for namespace ID [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/110881 [23:17:58] (03CR) 10Bartosz Dziewoński: "Rebased to run tests." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/110881 (owner: 10Se4598) [23:18:30] MatmaRex: mh... didn't work [23:18:38] heh [23:18:46] I thought AF only has the parser tests anyways? [23:18:57] legoktm: Yes, but it still runs the DB install ;) [23:19:03] :D [23:19:07] (03CR) 10Bartosz Dziewoński: "Duh, AF apparently has no unit tests." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/110881 (owner: 10Se4598) [23:19:31] (03CR) 10Hoo man: "It has, not sure why they don't run atm" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/110881 (owner: 10Se4598) [23:19:43] legoktm: It was broken unless we fixed the SQLite stuff initially :P [23:19:58] heh [23:22:53] MatmaRex: maybe remove and readd jenkins-bot to run full tests? I dunno [23:23:28] hoo^ [23:23:58] Not sure, the last zuul updgrade maybe broke that [23:25:40] afaik I'm not "trusted" to run all tests, but if someone else add it, it could be ok [23:26:16] yeah, it should run them after i rebased, unless something is broken [23:26:32] also, we should probably add you to the "trusted" list [23:26:38] MatmaRex: Might be... after the last Jenkins update, zuul also got upgraded [23:26:53] or, even better, we could finally make it possible to run the tests for everyone� [23:27:13] MatmaRex: :P Not as long as we don't run them in VMs [23:30:35] Jenkins is in production. Not sure it's wise to let anyone run any code they want on it. [23:31:40] Krenair: afaik the actual test runners are separate machines or environments or something [23:32:15] Krenair: so the worst that can happen is that someone has to wipe them and restore from puppet or something [23:32:34] or at least i hope that's the case, heh [23:38:33] MatmaRex, hey, any idea how to run the VE QUnit tests? [23:39:00] Krenair: huh, nope. it doesn't do them the standard way? [23:39:53] MatmaRex, honestly I know nothing about how our QUnit stuff works beyond that you can trigger the core stuff from Special:JavaScriptTest if you have $wgEnableJavaScriptTest = true; [23:41:47] that's about as much as i ever needed to know [23:42:04] MatmaRex, hm, I refreshed the page and it suddenly runs a lot more than it did first time. oh well [23:44:13] what [23:44:21] I just found another thing broken by $wgDebugToolbar = true