[00:00:46] <^d> I thought it meant "don't inherit from the parent" [00:00:53] <^d> Not "don't also apply to children" [00:00:55] <^d> But maybe [00:00:56] <^d> Who knows. [00:01:22] Should I toggle it and see what happens? [00:01:36] <^d> Yeah! [00:02:20] Kk. :-) [00:08:01] (03CR) 10Bartosz Dziewoński: mediawiki.api: Fix token with postWithToken, add test (031 comment) [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [00:08:02] ^d: every gerrit user is also a wikitech user, right? [00:08:23] or am i confused? [00:08:43] <^d> Yes. [00:08:54] <^d> But not all wikitech users are gerrit users (you're created in gerrit on first login) [00:10:55] (03Abandoned) 10Jdlrobson: Make italics within blockquotes normal to make them distinguisable [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106736 (owner: 10Jdlrobson) [00:13:58] (03CR) 10Jack Phoenix: "Yep! If I might bug you with a few very minor documentation tweaks:" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/110615 (owner: 10UltrasonicNXT) [00:17:19] (03PS1) 10Bartosz Dziewoński: mediawiki.api: Remove misleading comment about JSONP [core] - 10https://gerrit.wikimedia.org/r/110662 [00:17:31] ^ trivial [00:18:43] would like to gig up the commit which got rid of the parameter [00:18:46] dig* [00:19:29] !g Ic2af66b91a996bc9b46dc3e999b4099541573b08 [00:19:29] https://gerrit.wikimedia.org/r/#q,Ic2af66b91a996bc9b46dc3e999b4099541573b08,n,z [00:19:33] Krenair: ^ [00:19:40] it was apparently commented-out there [00:20:04] roan commented on it on some earlier patchset, i think [00:20:11] and disappeared sometime later [00:20:30] i didn't investigate, blaming removals is harder than blaming additions :) [00:22:41] yeah in https://gerrit.wikimedia.org/r/#/c/64582/15/resources/mediawiki.api/mediawiki.api.js MatmaRex [00:24:16] (03CR) 10Alex Monk: "This comment was added in Ic2af66b9, but the parameter it references was removed (as part of PS16). Roan's comment on PS15:" [core] - 10https://gerrit.wikimedia.org/r/110662 (owner: 10Bartosz Dziewoński) [00:38:54] (03CR) 10Gergő Tisza: [C: 04-1] "Some general problems:" (035 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 (owner: 10Inchikutty) [00:40:00] (03PS2) 10Brion VIBBER: Remove old Esperanto character conversion support [core] - 10https://gerrit.wikimedia.org/r/110589 [00:48:39] gwicke: I updated a non-vagrant labs server and extensions/Parsoid broke. Is that obsolete and I should switch to https://www.mediawiki.org/wiki/Parsoid/Setup ? [00:51:08] (03Abandoned) 10Jdlrobson: Build living style guide as Special:StyleGuide [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [00:53:14] jdlrobson: I'll add Special:KiSSMyGuide to my list of things to do :) [00:54:15] spage, afaik ori updated Vagrant already [00:54:36] that repository is indeed obsolete: it only contains the actual extension now [00:54:46] which you probably don't need [00:55:30] gwicke: thanks. we have old-skool labs instances as well as labs-vagrant [00:56:08] spage: https://gerrit.wikimedia.org/r/#/c/108079/ [00:56:39] there was a vagrant bug about it too that I don't find right now [00:57:20] I'm currently working on a Debian package [00:58:32] gwicke: I see your systemd unit file! Vote early and often in Debian init wars, the never-ending soap opera :) [00:59:17] spage: hehe, yes.. I hope they end up picking systemd real soon now� [01:00:26] no news from the front though [01:18:11] (03CR) 10Alex Monk: jquery audit of mw.DestinationChecker.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86804 (owner: 10MarkTraceur) [01:21:50] Krenair: Ugh, don't remind me [01:22:02] marktraceur, heh, sorry [01:22:03] * marktraceur has been so bad about those patches [01:22:09] I had forgotten I had left the -1 there [01:22:36] Heh [01:22:47] There are -1s from you on all of my little UW cleanup patches, I think [01:26:50] (03CR) 10PleaseStand: [C: 04-1] Remove old Esperanto character conversion support (036 comments) [core] - 10https://gerrit.wikimedia.org/r/110589 (owner: 10Brion VIBBER) [01:29:54] (03CR) 10Bartosz Dziewoński: mediawiki.notification: Hide #mw-notification-area when it's empty (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109124 (owner: 10Bartosz Dziewoński) [01:35:46] (03PS2) 10Bartosz Dziewoński: mediawiki.notification: Hide #mw-notification-area when it's empty [core] - 10https://gerrit.wikimedia.org/r/109124 [01:39:07] hie, i am working to solve this bug. https://bugzilla.wikimedia.org/show_bug.cgi?id=11269. I went through the code, but I am confused regarding the exact file to make changes in. Please help. [01:40:52] ori: Can you please help me? [01:41:14] zeek: Try includes/QueryPage.php [01:42:19] ok [01:43:32] zeek: QueryPage doesn't control all special pages, but it controls many of the get a list of things page [01:44:24] bawolff: Its difficult to understand where the actual HTML is rendered [01:44:47] try around line 544 [01:45:05] that's where the paging links are [01:45:35] zeek: Lines like $this->msg( 'showingresults' ) means its getting some sort of string from the i18n file [01:46:11] iln8 is? [01:46:19] il8n [01:49:26] zeek: i18n stands for internationalization. It just means it loads a different string for 'showingresults' depending on user language [01:49:40] zeek: It loads the string from languages/messages/MessagesEn.php for english [01:49:44] !i18n [01:49:45] See http://www.mediawiki.org/wiki/Internationalisation for developer help on MediaWiki internationalisation. To translate MediaWiki in another language, please visit http://translatewiki.net [01:49:57] Yeah got that. Googled it. :) [01:55:50] is there any way for me to get this: https://en.wikipedia.org/w/api.php?action=opensearch&search=api&limit=2&namespace=0&format=xmlfm in JSON? [01:56:42] (03CR) 10Isarra: "Huh, that's kind of neat. I don't know if it really adds anything, but I also don't know that it necessarily makes things any worse." [core] - 10https://gerrit.wikimedia.org/r/110584 (owner: 10Gerrit Patch Uploader) [01:57:10] bawolff: I do not have any data visible on http://127.0.0.1:8080/wiki/Special:MostLinkedCategories and I think there is no edit option on specials pages. How to add data? [01:57:18] jorm: nope, it's inherently xml :( [01:57:26] i think it's the single api module that does that [01:57:30] grrr. [01:57:33] but we have some saner apis for text extracts [01:57:49] !e TextExtracts [01:57:49] https://www.mediawiki.org/wiki/Extension:TextExtracts [01:57:52] there's also the search api module that doesn't have that problem [01:58:10] zeek: Do you have any categories on your wiki? [01:58:13] even documented ones! :D https://www.mediawiki.org/wiki/Extension:TextExtracts#API [01:58:37] bawolff: I dont think so, how to add those? [01:58:44] !categories [01:58:44] http://www.mediawiki.org/wiki/Help:Categories [02:00:03] jorm: MatmaRex: how about https://en.wikipedia.org/w/api.php?action=query&list=search&srsearch=api&format=jsonfm&srlimit=2 [02:01:20] i have no idea what jorm is trying to do :) [02:02:28] SHIT that's exactly what i want, bawolff! [02:02:37] yay! [02:02:41] thanks! [02:03:05] sadly, i think i have to roll my own typeahead library, since all of them assume only json and none do jsonp. [02:11:27] bawolff: I guess I have to modify the code in the function "viewPrevNext", but I cannot find its defination. Whixh file to look into? [02:11:49] *Which [02:12:45] zeek: Its in language/Language.php [02:13:24] zeek: for reference, if you have a git checkout, an easy way to figure out where definitions are like that is to do [02:13:34] git grep n\ viewPrevNext [02:14:06] ohh ok didn't knew. [02:14:17] I would use that next time [02:15:01] zeek: That's ok. For certain things, like $this->getLanguage() and friends that appear quite a few times in the code base, you'll just start to know where they are as you get more experianced [02:15:26] ok :) [02:16:35] (03CR) 10Bartosz Dziewoński: [C: 032] Move toctoggle from mediawiki.util.js to separate file mediawiki.toc.js [core] - 10https://gerrit.wikimedia.org/r/106132 (owner: 10Gerrit Patch Uploader) [02:20:16] (03Merged) 10jenkins-bot: Move toctoggle from mediawiki.util.js to separate file mediawiki.toc.js [core] - 10https://gerrit.wikimedia.org/r/106132 (owner: 10Gerrit Patch Uploader) [02:33:27] bawolff: I moved to the defination of function wfMessage and now reached the class of Message. Now I am not sure where to look. Please guide. [02:34:27] Basically all you need to know about wfMessage is it takes things out of the language/messages/MessageEn.php file, and replaces $1, $2, etc with parameters specified [02:34:51] so wfMessage( 'hist' )->text() returns the content of the hist array element in language/messages/MessageEn.php [02:35:16] wfMessage( 'hist' )->params( 'foo' )->text() would do the same thing, but replace $1 with 'foo' [02:35:47] https://www.mediawiki.org/wiki/WfMessage has docs on the function [02:36:19] You probably don't want to try to follow the code execution path of wfMessage, since it goes to some complicated places with localization cache [02:37:04] Ok :) [02:42:01] (03PS1) 10Bartosz Dziewoński: mediawiki.notification: Return the Notification object from .notify calls [core] - 10https://gerrit.wikimedia.org/r/110667 [02:49:24] bawolff: I have understood well now, ($plink, $nlink, $this->pipeList( $numLinks ) ), these are the 3 param that will be substituted for the defination of 'viewprevnext', but I just looked at the bug again and the first part required me to change the message display "Showing below up to 50 results starting with #1" to "Showing below up to 50 results in range #1 to #50... So I am working on that first. :) [02:51:23] zeek: Yes, that parts a much better part to work on. The other part of the bug would be really difficult to solve efficiently [02:51:31] bawolff: Should I change the defination of "'showingresults'" or create a new variable? [02:51:58] bawolff: WIth your help I'll surely do them both. :) [02:52:13] umm you can probably change the message (I think), however you have to make sure its changed everywhere its used [02:52:57] That will not be possible I guess :O I need to add another parametre, so whereever it is used I will have to pass another paramentre [02:53:33] Its also totally fine just to create a new message [02:53:42] Any naming convention? [02:54:07] If you need to separate words, use dashes (-), not spaces or underscores [02:54:11] all lowercase [02:54:34] otherwise not really [02:54:38] 'showingresultsinrange' <- how about that? [02:54:47] that sounds fine [02:55:18] zeek: also, some boring technical notes: https://www.mediawiki.org/wiki/Localisation#Adding_new_messages [02:55:26] You have to add it to languages/messages/MessagesEn.php, languages/messages/MessagesQqq.php and maintinance/language/messages.inc [02:55:48] (ha, bawolff already summed up the parts that matter) [02:55:53] you don't have to worry about any other languages though, the translators will deal with other languages [02:56:13] MatmaRex: Sometimes its faster than finding the page ;) [02:56:26] All right, it fun to read boring messages after a sleepless night :P [02:56:43] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Does not merge." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/102072 (owner: 10Legoktm) [03:07:28] bawolff: I made these changes: http://fpaste.org/73568/39122401/ [03:08:32] But I didnt understand how to add data to my http://127.0.0.1:8080/wiki/Special:MostLinkedCategories, I edited the http://127.0.0.1:8080/wiki/Categories page though. [03:09:00] (03PS2) 10Bartosz Dziewoński: jquery.suggestions: Do not duplicate keypress logic [core] - 10https://gerrit.wikimedia.org/r/82814 [03:09:19] (03CR) 10Bartosz Dziewoński: "Rebased." [core] - 10https://gerrit.wikimedia.org/r/82814 (owner: 10Bartosz Dziewoński) [03:09:24] zeek: The changes look correct to me (Just reading the code that is, the true test is one the code is tested) [03:09:31] (03PS7) 10Bartosz Dziewoński: jquery.suggestions, mediawiki.searchSuggest: Fix form submission [core] - 10https://gerrit.wikimedia.org/r/48252 [03:09:55] bawolff: yes thats why i need to add data so I can test :) [03:10:18] Just add the text [[Category:Foo]] to a bunch of pages [03:10:18] https://www.mediawiki.org/wiki/Category:Foo [03:10:35] That will tell mediawiki that whatever page you add that code to is in the "Foo" category [03:11:08] (I'm assuming you have $wgMiserMode = false; (aka the default). If its not false, you need to do some extra stuff) [03:11:19] ohh allright. let me try [03:11:35] or be right back in 15 minutes. [03:41:15] (03CR) 10Parent5446: "Agreed on the second two points, but there's no way we are going to hold up core development just because the WMF is using years-deprecate" [core] - 10https://gerrit.wikimedia.org/r/109903 (owner: 10Lekshmi) [03:43:42] bawolff: I feel the correct thing would be "in range 1 to 1", but have a look: https://mediacru.sh/ff5kC4kTODwm [03:46:04] zeek: Hmm, I think the ($this->limit + $this->offset) part needs to be something else [03:46:28] something like min( $this->numRows, $this->limit ) + $this->offset [03:46:37] (03CR) 10Parent5446: [C: 04-1] Make abstract Config class truly implementation-agnostic (032 comments) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [03:47:04] (03PS10) 10EBernhardson: Auto-wrapping explicit escaper for templates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103317 [03:47:14] (03CR) 1001tonythomas: "@Bartozs: Earlier, before the patch too, the uesr had the right to check 'Search in all namespaces' and chose some 2 or three namespace ch" [core] - 10https://gerrit.wikimedia.org/r/110610 (owner: 1001tonythomas) [03:48:03] (03CR) 10EBernhardson: "PS10: updated to address comments, and wrote docblock for Flow\Template" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103317 (owner: 10EBernhardson) [03:48:59] bawolff: Yeah right, that fixes it. :) [03:49:45] (03CR) 10Brian Wolff: "If wmf is using years deprecated features, third party re-users probably are too..." [core] - 10https://gerrit.wikimedia.org/r/109903 (owner: 10Lekshmi) [03:52:14] zeek: I have to go. Good luck with the bug. (If you have more questions, there's lots of other friendly people on the channel who can probably answer) [03:54:07] bawolff: Thank you have a good day [04:05:48] bd808|BUFFER: Can someone please tell me how to update the messagesQqq.php? I have added the message the messagesEn.php and messages.inc [04:08:29] Can someone please tell me how to update the messagesQqq.php? I have added the message the messagesEn.php and messages.inc [04:40:18] Can someone please tell me how to update the messagesQqq.php? I have added the message the messagesEn.php and messages.inc [04:42:29] (03PS1) 10Isarra: (Bug 55424) Add a link to nuke a user from Special:Contributions [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/110669 [04:46:48] (03CR) 10Legoktm: (Bug 55424) Add a link to nuke a user from Special:Contributions (032 comments) [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/110669 (owner: 10Isarra) [04:51:45] (03PS2) 10Isarra: (Bug 55424) Add a link to nuke a user from Special:Contributions [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/110669 [06:22:06] (03PS5) 10TTO: Make the link in import log entry always use canonical namespace [core] - 10https://gerrit.wikimedia.org/r/84197 [06:32:50] * apergos looks around for a Reedy (on a Friday night, I know) [06:43:19] hey prtksxna [06:43:25] prtksxna: managed to get someone to review it? [06:44:06] YuviPanda: Quit sleep talking :P [06:44:17] prtksxna: kk quit :P [06:44:25] YuviPanda: vbamba says it should get done by Monday :) [06:45:11] prtksxna: hmm ok :) [06:45:20] prtksxna: you can work on next patch before this gets merged, y'kknow [06:45:24] 'dependent' patches [06:45:45] prtksxna: we could also work on the category editor if you want :P [06:47:06] YuviPanda: Hehe! Don't remind me of that thing again :P [06:47:13] prtksxna: :P [06:47:20] prtksxna: I didn't say its actual name, did I [06:47:26] YuviPanda: I have some design stuff that I could take care of first (or in parallel) [06:47:31] YuviPanda: That is actually cooler :D [06:47:36] prtksxna: :P [06:47:43] prtksxna: we could call ours coolcat :P [06:47:45] YuviPanda: Its a gadget right now? [06:47:54] prtksxna: although I prefer lukewarmcat [06:47:55] YuviPanda: Or HotDog :) [06:48:06] prtksxna: or warmcat [06:48:19] YuviPanda: Or NyanCat? [06:48:32] prtksxna: heh, definitely! Don't think that'll make it tho [06:48:44] BUT WE MUST TRY [06:49:01] prtksxna: WE WILL [06:50:24] prtksxna: DO DESIGN NA [06:51:12] YuviPanda: Shyoar [06:51:38] YuviPanda: You need to explain a couple of things to me though [06:51:50] YuviPanda: Here or PM? [06:52:42] prtksxna: sure, let's do it here [06:53:17] YuviPanda: I am not sure how I'll manage some stuff in git [06:53:25] what stuff [06:53:37] YuviPanda: This (HotCat) would be a different repo altogether, right? [06:53:54] prtksxna: perhaps. [06:54:33] YuviPanda: But we'll be working on it together, so I'll keep dong 'g review -d ' to get your changes and 'g review' to push mine, that's all right? Nothing else to it? [06:55:00] prtksxna: yeah, pretty much [06:57:01] YuviPanda: And on VectorBeta, I am currently on 'review/prtksxna/109878', should I make a branch from that to do the design work and push from there. And in case there are any changes to the first patch I could just switch branches, make change, push come back to design branch and pull the changes from 'review/prtksxna/109878' again? [06:57:28] prtksxna: no, it's fine, you can just be on the same branch and push things [06:57:36] prtksxna: branch name is flexible and in the end does not really matter [06:57:42] prtksxna: what matters is what commit you are on [06:58:01] prtksxna: the github workflow makes branches important. Gerrit doesn't give a shit about branches for the most part [06:58:32] YuviPanda: What I am suggesting seems simpler, as I'd never have to rebase [06:58:35] YuviPanda: I see [06:58:47] YuviPanda: I am not that flexible with that idea yet :P [06:59:02] prtksxna: you have to rebase in the end anyway, because otherwise it means you will be working on only one commit [06:59:15] * prtksxna scratches head [06:59:20] prtksxna: start thinking of commits as nothing more than diffs that can be reordered, and moved around [06:59:46] YuviPanda: Alright [07:04:08] prtksxna: gaah, stupid internetr [07:04:34] prtksxna: turns out there is an extension that does categorization [07:04:39] prtksxna: https://www.mediawiki.org/wiki/Extension:InlineCategorizer [07:05:05] ...that extension never worked [07:05:11] YuviPanda: Oh! [07:05:13] legoktm: Oh? [07:05:16] legoktm: ah! [07:05:24] Krinkle moved it out of core because it was broken [07:05:28] aaah [07:05:28] HA! [07:05:30] that makes sense [07:05:32] and no one ever fixed it [07:05:54] https://git.wikimedia.org/commit/mediawiki%2Fextensions%2FInlineCategorizer/9e40832f59671a05d8ace285d946d68eb2a952e7 [07:06:01] YuviPanda: Just grab the HotCat gadget [07:06:23] p858snake|l: have you looked at that thing's code?! [07:06:38] https://www.mediawiki.org/wiki/User:Krinkle/Extension_review/InlineCategorizer [07:06:46] Have you looked at the code for half the extensions out there? [07:07:01] p858snake|l: half the deployed-on-wmf extensions seem fairly decentish [07:07:05] relative to hotcat at least [07:09:51] oh well [07:09:58] legoktm: tried the iOS app? [07:10:39] hmm, are my messages going through? [07:10:43] YuviPanda: yes! [07:10:44] or is it shitty internet time again? [07:10:46] ah [07:10:47] ok :) [07:10:49] legoktm: how's it/ [07:10:50] I made an edit to my userpage logged out [07:10:53] and then I got reverted. [07:11:07] not terrible :P [07:11:12] :P [07:11:20] Special:Random "doesn't exist" [07:11:22] legoktm: logged in coming sometime soon [07:11:33] legoktm: heh, at least on android I kinda pretend that other namespaces don't exist yet [07:11:45] legoktm: and yeah, Special:Random won't exist. this is using action=mobileview [07:12:27] :/ [07:12:32] YuviPanda: What internet are you on? TTN? [07:12:41] legoktm: I'll fix it soon enough. [07:12:43] prtksxna: ya [07:12:48] what's TTN? [07:12:54] Jasper_Deng: local ISP [07:14:31] legoktm: did you test out captcha support? :P [07:14:36] no [07:14:37] legoktm: iOS's AF isn't done yet I think [07:14:37] let me do that [07:14:41] legoktm: ok [07:15:07] YuviPanda: So, I start doing some work on the design stuff, make a commit. Now I get a CR asking me to change something. I'll do a 'g rebase -i 942e4264', 'edit' both commits and then add stuff from files hunk by hunk to both commit? What if there is overlapping stuff? Or stuff that completely changed? I think I should just try doing this once and it'll be fine :D [07:15:25] YuviPanda: So HotCat or the Extension? [07:15:43] prtksxna: yeah, git rebase -i and then 'edit' is what you should do [07:15:51] prtksxna: overlapping doesn't happen too much [07:16:21] prtksxna: we should start from scratch [07:16:22] I think [07:16:32] YuviPanda: success! [07:16:39] though, iOS kept trying to autocorrect it [07:16:45] legoktm: haha! file a bug :P [07:16:54] I've disabled autocorrect for it [07:16:55] on Android [07:16:58] okay [07:17:24] uhh Wikipedia App -> Generic? [07:17:39] legoktm: probably [07:17:44] legoktm: that part of BZ needs reform [07:18:07] > Component description: "If you're not sure where the bug should go" [07:18:10] :P [07:19:10] YuviPanda: I see, I'll quickly eat lunch and then we shall start [07:19:13] prtksxna: ok! [07:19:21] prtksxna: I'll brb [07:19:46] https://bugzilla.wikimedia.org/show_bug.cgi?id=60707 [07:21:35] legoktm: thanks! [07:21:41] legoktm: oh, can you test a titleblacklist? [07:22:04] I could but lazy [07:22:10] legoktm: :P dO IT [07:22:12] / working on something else right now [07:22:14] ah [07:22:20] legoktm: better excuse that :P [07:22:27] legoktm: do you know who I could bug for android testing? [07:22:31] I'm curious how long until someone reverts my edit [07:22:32] umm [07:22:33] YuviPanda: I could help with app testing. [07:22:41] YuviPanda: Niharika can help with android testing! [07:22:52] Niharika: woo! what phone do you have? [07:23:01] Android tab and iPhone 4. [07:23:18] Niharika: ah. Android what version? [07:23:23] Works? [07:23:24] Niharika: Nexus 7 or some other tab? [07:23:37] Kitkat. [07:23:37] N& only. [07:23:37] N7 [07:23:37] * [07:23:37] Niharika: it currently only works on Android 4.0+ [07:23:40] Niharika: ah, great [07:23:43] Niharika: let me send you a build [07:23:59] YuviPanda: I have a few non-wikimedian friends who have androids if you want [07:24:16] Alright. I´ll be back in a minute. [07:24:31] legoktm: hmm, nah, it's probably not good enough for those guys [07:24:32] yet [07:24:39] legoktm: we haven't gotten to visual styling yet [07:25:09] ok [07:25:38] Niharika: emailed you a build [07:26:13] brb for real [07:30:46] YuviPanda: Installed. [07:31:34] Looks good to me. Though you might want to scale it to adapt to tablets a bit. [07:33:32] ok really I need a Reedy or a deployer [07:33:34] grrr [07:39:06] Niharika: yeah, probably. [07:39:08] Niharika: try it around a bit. make edits even :) [07:39:11] Niharika: and file bugs? [07:39:50] YuviPanda: Trying it, file bugs where? [07:40:07] Niharika: bugzilla.wikimedia.org? [07:40:10] Niharika: or just email me :) [07:40:16] Niharika: screenshots of bugs appreciated too :) [07:40:41] Okay. I´ll go the bugzilla way. Will learn the way that works too. [07:41:19] If I go to Saved Pages and there are no saved pages, it gives me a blank screen. [07:41:32] Should give a message like ¨No Saved Pages¨, right? [07:41:44] Is that buggy enough for a bug? [07:42:01] YuviPanda: ^ [07:42:32] Niharika: yup! [07:42:34] Niharika: file it! [07:43:08] YuviPanda: Login isn´t working. [07:43:20] Niharika: yeah, haven't implemented it yet :P [07:43:30] YuviPanda: Okay. :P [07:44:09] YuviPanda: Will you also be implementing support for Talk pages? And filing bugs? [07:45:21] YuviPanda: Any plans of a Windows app too? [07:46:35] Niharika: yeah talk pages [07:46:39] Niharika: not so much filing bugs [07:46:52] Niharika: although if it crashes, it will pop up a dialog box saying 'send Yuvi a crash report' [07:47:04] Okay. Nice. [07:47:53] Niharika: eventually, push notifications :) [07:48:27] Cool. Could I possibly help with anything? :P [07:48:32] hey dev folks, who else deploys regularly besides Reedy? [07:48:54] I need to add them as reviewers on a fix, we had a recent deploy break all dumps [07:49:13] sometime yesterday... [07:49:18] apergos: ori is the only one I could think of who might possibly be awake [07:49:52] * apergos grits teeth sure don't want to just do this myself. blergh [07:49:55] Niharika: probably a fair bit - we are still on the way :D But I'll wait for OPW to finish before adding more code to your burden [07:50:30] who that's asleep? (No I don't plan to wake them, we'll live with it for somehours) [07:50:36] YuviPanda: I am dying of lack of burden, believe me. I could try fixing this bug for starters. :D [07:50:47] Niharika: oh! Then go ahead! :D [07:50:52] Niharika: you've done android stuff before, right? [07:51:08] apergos: hmm, Reedy, Tim-away, maxsem, RoanKattouw_away [07:51:18] ok [07:51:23] (03PS8) 10Inchikutty: [WIP] Embedding Static Map to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 [07:51:26] thanks [07:51:29] YuviPanda: Yep. Gotta brush up stuff though. This should be a nice place to start. What´s the name of the repo? [07:51:38] Niharika: apps/android/wikipedia [07:51:46] Niharika: you will also need apps/android/java-mwapi [07:51:59] YuviPanda: Okay. Copy that. [07:52:47] Niharika: when you tried android dev [07:52:49] did you use Eclipse? [07:52:56] YuviPanda: Yeah. [07:53:04] YuviPanda: What are you using? [07:53:20] Niharika: use IntelliJ! [07:53:44] YuviPanda: Okay. Great. [07:53:58] Github got revamped. :o [07:56:45] ok I submitted a bz report and a gerrit change and marked the priority up so hopefully someone will see it soon enough [07:57:32] I can codge together a script to rerun all the abstract dump phases for the failed dumps later, a bit tedious is all [07:59:17] YuviPanda: I have an N7 too, yunogivebuild? [07:59:41] prtksxna: sent [08:00:09] YuviPanda: Also, can you setup some boilerplate code that generates some markup at the bottom of the page and I'll use that as a starting point for lut4cat [08:00:15] GOT! [08:00:27] prtksxna: haha lut4cat [08:00:39] prtksxna: hmm, so I was thinking we should do a mockup first, and then move it from there [08:00:50] prtksxna: that, or start as a gadget (remember the interview task you did?) [08:01:39] YuviPanda: Thats a gadget? I thought it was user JS/CSS [08:02:06] prtksxna: well, they are the same mechanism [08:02:14] prtksxna: eventually that can be made into a gadget [08:02:21] YuviPanda: We'll make the mockup on HTML/CSS only, might as well make a patch so that its easy to share? [08:02:45] prtksxna: yeah, but patches aren't easy for people to try out [08:02:47] prtksxna: userscripts are [08:03:19] YuviPanda: Oh, ok. Got it! [08:03:45] prtksxna: I am thinking of doing a LightTable plugin that will make developing UserScripts much easier [08:03:59] YuviPanda: But who uses LightTable? [08:04:07] prtksxna: me? :P [08:04:21] YuviPanda: Make an emacs script instead :P [08:04:21] (03CR) 10Calak: [C: 031] Make the link in import log entry always use canonical namespace [core] - 10https://gerrit.wikimedia.org/r/84197 (owner: 10TTO) [08:05:39] prtksxna: :P lolmacs :P [08:05:51] :| [08:05:57] prtksxna: :P [08:06:42] YuviPanda: btw - I might not be in BOM for a couple of days this month, make sure you don't come here during that time [08:06:53] prtksxna: will make sure! [08:06:58] YuviPanda: No other way to send you the crash report other than email? :o I thought it´d be done in the backend. [08:08:47] Niharika: yeah, just email [08:08:51] Niharika: no backend integration yet [08:09:04] YuviPanda: Okay. Sent you one. [08:09:12] Niharika: yeah, saw it [08:09:18] Niharika: did you rotate the phone or some such when it was loading? [08:09:25] YuviPanda: Nope. [08:10:06] Niharika: hmm, weird [08:10:09] Niharika: I'll investigate! [08:10:18] YuviPanda: Filed another bug too. [08:10:49] Niharika: hmm, try hitting 'back'? does it go away then? [08:11:02] YuviPanda: Is the article supposed to rotate when I rotate the tab? [08:11:11] Niharika: yeah? [08:11:17] Niharika: it's supposed to [08:11:53] YuviPanda: It doesn´t go away. If I press the Back button, the app closes. [08:12:00] YuviPanda: Doesn´t rotate either. [08:12:10] Niharika: hmm, ok. [08:12:13] Niharika: the page doesn't rotate? [08:12:16] Niharika: what does it do instead? [08:12:33] YuviPanda: Nothing. It stays in the vertical pose only. [08:13:46] Niharika: oh [08:13:51] Niharika: can you send me a screenshot? [08:14:10] For the Suggestion list thing? [08:14:14] Right away. [08:15:28] Niharika: for both [08:15:36] Niharika: actually just for the rotate. [08:15:41] Niharika: I can already repro the suggest list thing [08:16:26] YuviPanda: How should I send a screenshot for that? :P The phone rotates, but article doesnt. It´s the same as in the vertical orientation. [08:16:36] Tab* [08:17:55] Niharika: the UI doesn't rotate? [08:18:03] (03PS2) 10Umherirrender: Document $wgResourceLoaderMaxage in DefaultSettings.php [core] - 10https://gerrit.wikimedia.org/r/110637 [08:18:17] YuviPanda: Sending you a picture. [08:19:45] (03CR) 10Umherirrender: "Patch Set 2: Fixed typo" [core] - 10https://gerrit.wikimedia.org/r/110637 (owner: 10Umherirrender) [08:20:31] YuviPanda: Got it? [08:21:17] Niharika: yeah [08:21:31] Niharika: do you have 'rotate' settings turned on in your tablet? [08:21:34] Niharika: it looks rotation locked? [08:22:04] YuviPanda: Oops. Yeah. It´s rotation locked. My bad. [08:22:09] Niharika: :D [08:22:23] YuviPanda: Okay, bad news too. [08:22:27] haha! :D [08:22:42] YuviPanda: Crashed on rotating. [08:22:52] Niharika: that's slightly better :D [08:22:59] Niharika: crash report? [08:23:03] YuviPanda: :P [08:23:11] Wait, trying to reproduce it. [08:23:53] Doesnt give me the popup now. Here´s how it crashes: I rotate it, and when I try to scroll, it crashes. [08:24:05] No popup. [08:25:12] Niharika: hmm [08:25:20] Niharika: does it give you a popup when you start it the next time? [08:25:26] Niharika: and does it crash only when you try to scroll? [08:26:43] YuviPanda: No popup next time either. yes, crashes only when I scroll. If I open the app in horizontal orientation, it works fine. [08:26:50] Niharika: hmm, ok [08:26:52] Niharika: file bug? [08:27:16] YuviPanda: Okay. [08:28:23] YuviPanda: The Version section in Bugzilla doesn´t have Android 4.0+ listed. [08:28:47] Niharika: yeah, it's fine, ignore it [08:29:00] Niharika: this doesn't work at all on 2.3 anyway :D [08:29:22] Oh. Then how are you testing? Emulator only? [08:30:22] YuviPanda: And why doesn´t it work on 2.3? Seems simple enough. [08:30:33] YuviPanda: Search is kinda slow though. [08:30:35] Niharika: no, I have a nexus 4 [08:30:53] Niharika: 2.3 -> 4.0 is a major API change. lots of features available in 4.0 are not in 2.3 [08:30:59] Niharika: the entire animation framework is different, for example [08:31:10] YuviPanda: Ah. And you couldn´t reproduce the rotation bug on it? [08:31:12] Niharika: can you go to en.m.wikipedia.org (the mobile site), and see if search is any faster there? [08:31:31] Niharika: yeah, seems to work for me. but i have a nexus 7 as well (I've like, 4 android devices of various descriptions :P) so I'll test on it later [08:31:37] YuviPanda: Okay, sure. [08:32:19] Niharika: you know hindi right? test it out on the hindi wikipedia? :) [08:32:22] you can change language in settings [08:32:39] YuviPanda: Alright. [08:36:32] YuviPanda: Search is faster by about 3-4 seconds on en.m.wikipedia.org. [08:36:42] Niharika: hmm, ok! file a bug for that as well? [08:36:53] YuviPanda: Right. [08:38:33] YuviPanda: If I type say, Delhi in the search box, and pick Delhi metro from the suggestion list, the text in the search box should change into Delhi metro, right? [08:38:46] Niharika: contentious thing, that :) [08:39:05] YuviPanda: haz krome? [08:39:14] Niharika: I just leave it as it is now, because you might've accidentally tapped the wrong one and want to redo it [08:39:22] Niharika: but yeah, I agree with you that it is confusing. [08:39:32] Niharika: we should maybe consider clearing the search term [08:39:35] Niharika: file a bug? :D [08:39:37] prtksxna: hmm? [08:39:53] YuviPanda: Like, if I type D, and pick the first suggestion, then the Search box still says D. [08:40:07] Kinda confusing, yeah. [08:40:18] Niharika: yeah, I am wondering if we should just clear the search term out once you tap it [08:41:07] YuviPanda: Hmm...retaining current article title is the usual thing, I suppose. [08:41:22] Niharika: I could do that too. [08:45:37] YuviPanda: When I open the app, it gives me just a blank screen first thing. Along with the search bar, of course. What do you intend to put on the opening page? [08:46:12] Niharika: yeah, there are plans to put your last few articles, some 'recent edits on this wiki' stuff, and the 'featured article' and stuff [08:46:19] Niharika: will be done a couple of weeks from now [08:46:46] YuviPanda: Need an opinion, can you please open http://neexxnukqf.localtunnel.me//wiki/Test_NavPopUps on a webkit browser? [08:46:49] YuviPanda: Okay, cool. [08:47:21] prtksxna: opening [08:47:57] prtksxna: sup [08:48:13] YuviPanda: N7 has the worst battery [08:48:15] YuviPanda: Hang? [08:48:19] prtksxna: sure [08:48:38] prtksxna: call [08:48:46] YuviPanda: A suggestion, in the Other Languages window, just show the other language names. Because all the other pages will have the same title. [08:48:54] I guess. [08:49:17] Niharika: yeah but they will be in different languages, no? [08:49:46] YuviPanda: Um, they all appear in English? The titles, I mean. [08:50:15] Niharika: oh?! screenshot? [08:50:20] Niharika: should be in the native language [08:53:12] YuviPanda: No, okay, it´s fine. But makes it sorta hard to search. [08:53:33] Niharika: is it showing in native language or english? [08:53:40] Niharika: you can type language name also [08:53:45] Niharika: but yeah, point taken. It could be confusing [08:54:00] YuviPanda: You could consider showing only the language names, I meant. [08:54:04] Niharika: yeah. file a bug? [08:54:27] YuviPanda: Right. [08:54:47] YuviPanda: Be back after a quick lunch. [08:57:41] Niharika: ok! [09:23:17] YuviPanda: Filed a bug for that too. [09:23:24] Niharika: woo! :D [09:23:49] But it didn´t come up in the #mediawiki feed... [09:24:29] Niharika: I saw it though [09:24:35] Niharika: #mediawiki's feed is weird [09:24:39] I have it hidden anyway [09:24:59] YuviPanda: Okay. [09:25:12] Who´s designing the icon? :D [09:26:15] YuviPanda: Some text appears weird, but that´s probably because the app isn´t optimized for tablets. [09:26:23] Niharika: screenshot? [09:26:34] Niharika: icon is probably smeone from the design team. we haven't done much icons yet :) [09:27:11] YuviPanda: Sent you a screenshot. [09:27:30] Niharika: oh, yeah. the infoboxes [09:27:37] Niharika: they aren't optimized for *anything* now :D [09:27:44] Niharika: the page styling is going to be fixed at some point in the near future [09:28:18] YuviPanda: Okay, cool. [09:33:55] (03PS10) 10Inchikutty: [WIP]Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [09:46:04] (03PS19) 10Eranroz: Support ApiPageSet in ApiWatch [core] - 10https://gerrit.wikimedia.org/r/53964 [09:49:59] (03CR) 10Siebrand: "Add a rephrase suggestion." (031 comment) [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/110669 (owner: 10Isarra) [09:55:57] YuviPanda: Aren't the icons going to stay Holo? [09:56:13] prtksxna: let's not talk about it [09:57:21] prtksxna: I hope so, however. [09:57:24] prtksxna: but let's see [09:57:35] YuviPanda: I see :) [09:57:45] YuviPanda: When do you think I'll get to work on the infoboxes? :D [09:58:17] prtksxna: well, clearly the app isn't important enough for you to work on infoboxes for it, so I honestly do not know :( [09:58:41] YuviPanda: Isn't that a fix on the web? [09:58:47] prtksxna: not really [09:59:03] YuviPanda: Then how will *I* do it anyway [09:59:09] prtksxna: well, it's JS and CSS [09:59:13] prtksxna: and fixing inline styling [09:59:19] prtksxna: but it's not going to show up anywhere else [09:59:21] for now at least [09:59:34] YuviPanda: Not even on mobile browsers? [09:59:47] not in the beginning, no [10:00:47] icy [10:18:32] YuviPanda: Can you please test this on whatever browser you are on http://neexxnukqf.localtunnel.me//wiki/Test_NavPopUps [10:18:44] doing, prtksxna [10:19:25] YuviPanda: thanks [10:19:31] prtksxna: I almost don't see any animation [10:19:45] prtksxna: also all popups are portrait only [10:19:51] prtksxna: oh, nevermind. [10:19:57] prtksxna: i had confused landscape and portrait. plz2ignore [10:19:58] YuviPanda: even newton? [10:20:01] prtksxna: but yeah, almost no animation [10:20:07] YuviPanda: refresh? [10:22:19] YuviPanda: Can you see the animation now? [10:22:27] prtksxna: refreshing [10:23:17] prtksxna: still see the 'down to up' animation [10:24:19] YuviPanda: Yes, I haven't changed the animation [10:24:31] prtksxna: ah ok. but yeah, can see it now [10:24:32] YuviPanda: But everything is *working* on your browser too, right? [10:24:35] prtksxna: ya [10:24:37] this is chrome [10:25:08] YuviPanda: Oh! I thought you were using FF [10:25:15] prtksxna: I use both [10:25:37] (◕︵◕) [10:26:32] prtksxna: i can test in ff [10:27:07] YuviPanda: Works for me, submitting another patch [10:27:13] prtksxna: ok! [10:27:37] YuviPanda: Much Less. So Mixins. Very Animation! :P [10:28:03] prtksxna: wow [10:30:42] (03PS1) 10Prtksxna: Add animation to NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/110675 [10:30:46] (03CR) 10jenkins-bot: [V: 04-1] Add animation to NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/110675 (owner: 10Prtksxna) [10:31:07] prtksxna: so much jenkins-bot love :P [10:31:59] YuviPanda: arghh! this again! [10:32:11] prtksxna: recheck [10:32:22] (03CR) 10Prtksxna: "recheck" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/110675 (owner: 10Prtksxna) [10:32:51] YuviPanda: Who should I add for review? Who takes care of CSS/LESS? [10:33:14] prtksxna: same as previous patch, I guess [10:33:24] prtksxna: add jdlrobson, Krinkle at the least [10:35:36] YuviPanda: done (y) [10:35:50] prtksxna: :) [10:45:43] (03PS1) 10Umherirrender: Remove outdated todo from RecentChange.php [core] - 10https://gerrit.wikimedia.org/r/110678 [10:46:52] (03CR) 10Yuvipanda: [C: 032] Remove outdated todo from RecentChange.php [core] - 10https://gerrit.wikimedia.org/r/110678 (owner: 10Umherirrender) [10:50:57] (03PS7) 10Physikerwelt: Rename some global variables that violate the naming convention [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 [10:51:38] (03CR) 10jenkins-bot: [V: 04-1] Rename some global variables that violate the naming convention [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 (owner: 10Physikerwelt) [10:52:36] (03CR) 10Umherirrender: "It is bad to see, that a patch set with some "@todo document" was merged. Would be nice, when this documentation can be added in the near " [core] - 10https://gerrit.wikimedia.org/r/92588 (owner: 10MaxSem) [10:52:39] (03PS8) 10Physikerwelt: Rename some global variables that violate the naming convention [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 [10:53:07] (03Merged) 10jenkins-bot: Remove outdated todo from RecentChange.php [core] - 10https://gerrit.wikimedia.org/r/110678 (owner: 10Umherirrender) [10:53:09] (03CR) 10jenkins-bot: [V: 04-1] Rename some global variables that violate the naming convention [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 (owner: 10Physikerwelt) [10:53:42] (03PS9) 10Physikerwelt: Rename some global variables that violate the naming convention [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 [10:54:00] (03PS1) 10Gerrit Patch Uploader: Remove deprecated function mw.util.tocToggle [core] - 10https://gerrit.wikimedia.org/r/110679 [10:54:02] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/110679 (owner: 10Gerrit Patch Uploader) [10:54:45] (03CR) 10Jeroen De Dauw: (Bug 55424) Add a link to nuke a user from Special:Contributions (032 comments) [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/110669 (owner: 10Isarra) [10:54:54] (03CR) 10jenkins-bot: [V: 04-1] Rename some global variables that violate the naming convention [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 (owner: 10Physikerwelt) [10:55:48] (03PS10) 10Physikerwelt: Rename some global variables that violate the naming convention [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 [10:57:22] (03CR) 10jenkins-bot: [V: 04-1] Rename some global variables that violate the naming convention [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 (owner: 10Physikerwelt) [10:58:36] (03CR) 10MaxSem: "Probably, if you've actually read the whole diff you would've noticed that the comments in question were already present and this patch ha" [core] - 10https://gerrit.wikimedia.org/r/92588 (owner: 10MaxSem) [11:03:02] (03PS1) 10Gerrit Patch Uploader: Remove deprecated function mw.util.tocToggle [core] - 10https://gerrit.wikimedia.org/r/110680 [11:03:04] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/110680 (owner: 10Gerrit Patch Uploader) [11:05:35] Why jenkins-bot, why? [11:20:05] (03CR) 10Umherirrender: (bug 33186) image rotate api (031 comment) [core] - 10https://gerrit.wikimedia.org/r/44005 (owner: 10J) [11:21:16] (03CR) 10Umherirrender: "Sorry, I have only looked at the added class files, not the removed part of DairikiDiff.php." [core] - 10https://gerrit.wikimedia.org/r/92588 (owner: 10MaxSem) [11:46:49] hey prtksxna [11:46:55] prtksxna: am online, but going to take shower now [11:47:27] * prtksxna YuviPanda: oh ok, sent you another email [11:47:34] prtksxna: i responded :P [11:47:40] YuviPanda: (which you've replied to) [11:47:45] :P [11:49:03] (03CR) 10Umherirrender: "When 'searcheverything' gets checked, the list of checkbox can be collapsed or disabled and checked, so the user cannot choose something t" [core] - 10https://gerrit.wikimedia.org/r/110610 (owner: 1001tonythomas) [11:49:33] prtksxna: brb then [11:54:02] (03CR) 10Umherirrender: "Needs testing, if 'searcheverything' not gets deleted, because it is not part of $wgDefaultUserOptions." [core] - 10https://gerrit.wikimedia.org/r/101233 (owner: 10Umherirrender) [11:56:09] (03PS11) 10Physikerwelt: Rename some global variables that violate the naming convention [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 [11:57:17] (03PS20) 10Prtksxna: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 [11:57:19] (03PS2) 10Prtksxna: Add animation to NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/110675 [12:01:52] (03CR) 10Bartosz Dziewoński: (Bug 55424) Add a link to nuke a user from Special:Contributions (031 comment) [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/110669 (owner: 10Isarra) [12:02:32] (03CR) 10Prtksxna: Add JS/CSS for the new NavigationPopups (032 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [12:02:42] (03CR) 10Prtksxna: Add JS/CSS for the new NavigationPopups (032 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [12:06:20] (03CR) 10Bartosz Dziewoński: "This got duplicated at https://gerrit.wikimedia.org/r/#/c/110680/ , which one do we abandon?" [core] - 10https://gerrit.wikimedia.org/r/110679 (owner: 10Gerrit Patch Uploader) [12:13:18] (03PS7) 10Umherirrender: API: Return set values for action=options [core] - 10https://gerrit.wikimedia.org/r/92928 [12:19:11] (03CR) 10Fomafix: "Please abandon this change. It is superseded by https://gerrit.wikimedia.org/r/110680 . Sorry I missed the Change-Id." [core] - 10https://gerrit.wikimedia.org/r/110679 (owner: 10Gerrit Patch Uploader) [12:20:18] (03PS1) 10Bartosz Dziewoński: vector: Split placeholder rules in search.less (again) [core] - 10https://gerrit.wikimedia.org/r/110683 [12:22:09] (03CR) 10Bartosz Dziewoński: "Yeah, I think that would be better." [core] - 10https://gerrit.wikimedia.org/r/110610 (owner: 1001tonythomas) [12:27:00] (03PS1) 10Prtksxna: Add horizontal scroll to pre elements (where required) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/110685 [12:30:21] Hello! [12:32:05] (03CR) 10Bartosz Dziewoński: "This has been discussed at length at bug 260 for years and scrollbars are not the best solution here." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/110685 (owner: 10Prtksxna) [12:32:58] (03Abandoned) 10Bartosz Dziewoński: Remove deprecated function mw.util.tocToggle [core] - 10https://gerrit.wikimedia.org/r/110679 (owner: 10Gerrit Patch Uploader) [12:35:32] (03CR) 10Yuvipanda: "@MatmaRex: True, but it is made worse in VectorBeta by the narrower page width, and so I think it is worth fixing it just for vectorbeta" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/110685 (owner: 10Prtksxna) [12:37:42] (03PS11) 10Inchikutty: [WIP]Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [12:39:45] (03CR) 10Bartosz Dziewoński: "I am very much hoping the narrow page width is going away. Time would be better spent solving the blockers to fixing bug 260 properly :)" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/110685 (owner: 10Prtksxna) [12:42:39] prtksxna: I'm going to test it and merge it now [12:42:57] YuviPanda|brb: what? the popups? [12:43:50] prtksxna: the overflow [12:44:16] YuviPanda: Hmm, I am reading the comments on the bug [12:44:31] YuviPanda: Do you thinking breaking the word would make more sense? MatmaRex? [12:44:56] well, I don't think there is 'one' solution [12:45:03] plus bug 260 is about fixing it for everything [12:45:07] while this is just for VectorBeta [12:45:10] separate things, I think [12:45:28] prtksxna: yeah, word-wrapping sounds like the solution here to me [12:45:37] i'm not opposed to adding the scrollbars, i just pointed out the bug [12:45:47] since it wasn't referneced, i assumed you didn;t know about it :) [12:45:59] YuviPanda: Yes, I noticed that [12:46:00] and there's lots of insight on it [12:46:11] MatmaRex: Yes, thanksI didn't. I should've searched bugzilla first [12:46:25] s/thanksI/thanks I [12:46:49] YuviPanda: Makes sense, but let me just finish reading it? :D [12:46:59] prtksxna: sure. I'll test it and +1 for now [12:48:39] YuviPanda: Does VB need to support IE7? [12:48:49] prtksxna: I don't know, tbh [12:49:02] YuviPanda: We *are* using animation :P [12:49:13] prtksxna: yeah, but that will eventually fall back gracefully to just popping up :P [12:49:46] YuviPanda: https://gerrit.wikimedia.org/r/#/c/12564/ [12:51:02] prtksxna: was reverted https://gerrit.wikimedia.org/r/#/c/12720/ [12:51:08] o [12:51:48] prtksxna: https://gerrit.wikimedia.org/r/#/c/16189/ [12:52:45] YuviPanda: hrm [12:52:58] YuviPanda: You are right, I guess its ok to be in VB [12:53:15] prtksxna: yeah, I think so too [12:53:54] MatmaRex: What is the problem with narrow page width? [12:55:47] MatmaRex: so, I think I'll go ahead and merge this. Bug 260 is already controversial, but this fixes issues with a perhaps-even-more-controversial beta feature only, so meh. [12:56:20] MatmaRex: The correct column width is known to improve readability since before the web and screens. [13:05:31] prtksxna: in theory, sure; in practice, especially when it's this poorly executed, not necessarily [13:05:40] (03CR) 10Yuvipanda: [C: 031] "@MatmaRex: Not disagreeing :) Just that I have VectorBeta enabled, and this is annoying as hell. Considering how old the bug is and how ma" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/110685 (owner: 10Prtksxna) [13:05:52] as you can clearly see from the number of complains everyone received about this� [13:06:03] MatmaRex: Why would you say its poorly executed? [13:06:26] (03CR) 10Bartosz Dziewoński: "Okay." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/110685 (owner: 10Prtksxna) [13:06:43] (03CR) 10Yuvipanda: [C: 032] Add horizontal scroll to pre elements (where required) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/110685 (owner: 10Prtksxna) [13:06:49] (03Merged) 10jenkins-bot: Add horizontal scroll to pre elements (where required) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/110685 (owner: 10Prtksxna) [13:06:50] prtksxna: because the full-width page layout of vector was not changed, someone just slapped a max-width on it [13:06:51] MatmaRex: thanks! :) [13:07:07] prtksxna: have you seen how this looks on a large screen? everything is in the leftmost 30% of the display [13:07:15] MatmaRex: Also, where can I read more of these complaints? (I want to get a better understanding of this problem) [13:07:16] while the rightmost 70% is a huge white space [13:07:27] MatmaRex: Yes, I do see that [13:07:43] and of course, the content of Wikipedia pages was never created with such constraint in mind [13:07:54] so things like tables, images floated on left and right, don't fit [13:08:00] MatmaRex: But it still affects readability positively. Sure, I'd like it better if it were in the center :) [13:08:05] prtksxna: https://www.mediawiki.org/wiki/Talk:Typography_refresh [13:08:45] half of that page is about the max-width now, apparnetly, i haven't looked at it for a while [13:09:08] http://i.imgur.com/WngZRLj.png [13:09:16] this can;t possibly be considered an improvement [13:09:27] the entire page, footer and header, still use full-width layout [13:09:39] MatmaRex: An improvement in readability it still is, in aesthetic maybe not [13:09:42] with only the content being squished [13:09:57] readability has very strong ties with the looks [13:10:11] ugly fonts are unpleasant to read, for example [13:10:31] MatmaRex: True, but that isn't the case here. [13:10:35] (03PS12) 10Inchikutty: [WIP]Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [13:11:14] my opinion is that this looks like shit and you're not going to change it. :) [13:11:28] MatmaRex: Hmm. I think I should read the talk page before we continue this conversation, I am sure I am missing a lot of points that you are trying to put forth. [13:11:53] on an unrelated note, last time i tried to make some changes to the typography refresh i was shouted at because "this is the current interation" or something [13:11:58] i hope you won't get shouted at [13:12:10] MatmaRex: I respect your opinion and would like to understand it better, that's all [13:12:13] (i removed the italicising of
s) [13:12:26] MatmaRex: I don't have the decision making power to change anything anyway :) [13:12:41] MatmaRex: technically, prtksxna is part of the design team :P [13:12:52] MatmaRex: would be interesting if he does get shouted at :P [13:13:30] yeah, i know [13:15:53] (03PS13) 10Inchikutty: [WIP]Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [13:16:47] MatmaRex: I'll read the conversation and ping you again (if that's ok?). "looks like shit", is very subjective and I am sure there is something objective you are trying to say, so you just need to give me some time to understand better. [13:18:14] prtksxna: I think the problem that people are pointing out (that I can see as well) is that the content width was changed, but the chrome around it was left intact [13:18:37] prtksxna: if the search bar, links on top, etc - everything was changed to fit the narrow column width, then it would've been fine [13:19:12] prtksxna: so I think that is the primary point. putting a max-width on an element doesn't transform a design into 'work with small columns' [13:23:34] (03CR) 10Siebrand: [C: 032] "I wish we'd just get rid of external link icons :(." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110608 (owner: 10EBernhardson) [13:23:46] (03Merged) 10jenkins-bot: Links in Echo notifications should be internal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110608 (owner: 10EBernhardson) [13:41:19] (03CR) 10Siebrand: "L10n reviewed. I think this needs some fixes." (038 comments) [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110567 (owner: 10MarkAHershberger) [13:48:11] (03CR) 10Siebrand: [C: 04-1] "L10n reviewed." (035 comments) [extensions/AzharAuth] - 10https://gerrit.wikimedia.org/r/110518 (owner: 10Dereckson) [13:58:21] (03Abandoned) 10Physikerwelt: Add cirrus search [vagrant] - 10https://gerrit.wikimedia.org/r/108845 (owner: 10Physikerwelt) [14:23:41] (03CR) 10Physikerwelt: "how can we fix this" [vagrant] - 10https://gerrit.wikimedia.org/r/106008 (owner: 10Physikerwelt) [14:24:35] YuviPanda: I see that point completely, are you able to see mine too? [14:26:29] prtksxna: that it improves readability? yeah [14:26:44] prtksxna: as MatmaRex said, the principle seems sound. The implementation not so much [14:27:01] YuviPanda: Also, I am not sure what "level of completion" this is at. If its "complete" then there is definitely something wrong, if its a work in progress then it deserves some space, maybe the issues that you are pointing out are being worked on [14:27:16] prtksxna: definitely work in progress, and that is why it still has it :P [14:27:35] prtksxna: I know they are being worked on. in fact I think you will be the person working on most of them :P [14:27:48] YuviPanda: Oh :P [14:27:57] (03PS4) 10Physikerwelt: install MathWebSearch [vagrant] - 10https://gerrit.wikimedia.org/r/108869 [14:28:03] prtksxna: the fixed header stuff you are supposed to be doing next should take this into account I guess [14:28:08] YuviPanda: Yes [14:28:47] YuviPanda: If the implementation is a WIP no point in spending so much energy criticizing it [14:29:01] prtksxna: well, it is out there becasue it wants criticism :P [14:29:25] prtksxna: 'the implementation sucks' is just an opinion, and it is a beta feature explicitly because it wants feedback, no? [14:29:35] YuviPanda: Are you had told me about Gerrit, its for review not for criticism :) [14:29:41] prtksxna: hehe :P [14:29:46] prtksxna: yeah, agreed. [14:30:19] :D [14:35:29] YuviPanda: So, about NyanCat, what are we doing? [14:35:37] prtksxna: today? nothing :P [14:35:42] prtksxna: but let's start with mocks, as a gadget [14:35:49] prtksxna: I'm off to eat food now [14:35:54] YuviPanda: erm ok [14:36:01] YuviPanda: We'll talk tomorrow then. o/ [14:36:03] prtksxna: do mockup? [14:36:10] YuviPanda: in js only? [14:36:23] YuviPanda: I don't want to do it on PS [14:36:26] YuviPanda: Photoshop [14:36:32] prtksxna: ok! [14:36:35] prtksxna: yeah, js/css [14:36:49] YuviPanda: So, just write stuff in my common.js? [14:37:09] YuviPanda: Create some DOM elements at the bottom using JS and style them with common.css, is that the right way? [14:37:47] prtksxna: put the style in your user css as well [14:37:59] prtksxna: yeah, common.css for now [14:38:15] YuviPanda: Got it (y) [14:38:32] s/Are/As [14:46:23] (03PS1) 10UltrasonicNXT: Add cache time for avatars [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/110691 [14:47:10] (03CR) 10UltrasonicNXT: "No prob!" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/110615 (owner: 10UltrasonicNXT) [14:50:04] (03PS3) 10UltrasonicNXT: Add working RenameUser hook [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/110615 [14:55:11] (03CR) 10Siebrand: Add links to forum logs (031 comment) [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/110212 (owner: 10UltrasonicNXT) [15:03:39] (03CR) 10Siebrand: "Niklas, do you have any suggestions?" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110143 (owner: 10AndyRussG) [15:07:29] (03CR) 10Siebrand: [C: 04-1] "Unanswered question on templates/compare-revisions.html.php in PS1." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 (owner: 10Bsitu) [15:08:11] (03CR) 10Siebrand: [C: 031] "i18n reviewed." [core] - 10https://gerrit.wikimedia.org/r/109853 (owner: 10Yurik) [15:09:19] (03CR) 10Siebrand: "Erik: Should we consider forking and maintaining it ourselves on GitHub?" [core] - 10https://gerrit.wikimedia.org/r/104650 (owner: 10EBernhardson) [15:11:58] (03CR) 10Siebrand: "I've created https://github.com/jaz303/tipsy/issues/176 : "Pull requests are not merged or closed #176" with content: It's been 7 months s" [core] - 10https://gerrit.wikimedia.org/r/104650 (owner: 10EBernhardson) [15:17:18] (03CR) 10Siebrand: [C: 04-1] "Per Alex's inline comments. Also left a reply." (031 comment) [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/47311 (owner: 10Reedy) [15:21:20] (03CR) 10Siebrand: "Tim, where do you want to go with this?" [core] - 10https://gerrit.wikimedia.org/r/102596 (owner: 10Tim Starling) [15:21:42] (03Abandoned) 10Siebrand: BookManagerv2: Clear cache when JSON file changes [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/104336 (owner: 10Geek400) [15:22:33] (03Abandoned) 10Siebrand: BookManagerv2: Clear cache when JSON file changes [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/104335 (owner: 10Geek400) [15:26:07] (03PS1) 10Imjacobclark: Added wfSuppressWarnings and wfRestoreWarnings before and after the ini_set call to apc cache by default to suppress errors if ini_set is disabled [core] - 10https://gerrit.wikimedia.org/r/110693 [15:27:38] (03CR) 10jenkins-bot: [V: 04-1] Added wfSuppressWarnings and wfRestoreWarnings before and after the ini_set call to apc cache by default to suppress errors if ini_set is disabled [core] - 10https://gerrit.wikimedia.org/r/110693 (owner: 10Imjacobclark) [15:29:28] (03PS2) 10Imjacobclark: Added wfSuppressWarnings and wfRestoreWarnings before and after the ini_set call to apc cache by default to suppress errors if ini_set is disabled [core] - 10https://gerrit.wikimedia.org/r/110693 [15:51:57] (03PS1) 10Bartosz Dziewoński: mediawiki.ui: Remove white-space: nowrap; for buttons [core] - 10https://gerrit.wikimedia.org/r/110696 [15:54:25] Hi, could I request code review of this bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=60658 (Bug 60658 - LocalisationCache::readPHPFile should suppress warnings around ini_set) [16:14:01] (03PS1) 10Hoo man: Minor documentation fix for ContentHandler::makeParserOptions [core] - 10https://gerrit.wikimedia.org/r/110697 [16:14:23] legoktm: ^ [16:14:39] Or anyone who wants to boost their review count [16:18:27] * Gloria bites hoo. [16:19:15] Gloria: :P I could also self-merge it, due to it's simplicity, I guess ... [16:20:15] Gloria for +2! [16:20:35] (03CR) 10Bartosz Dziewoński: [C: 032] Minor documentation fix for ContentHandler::makeParserOptions [core] - 10https://gerrit.wikimedia.org/r/110697 (owner: 10Hoo man) [16:24:16] (03Merged) 10jenkins-bot: Minor documentation fix for ContentHandler::makeParserOptions [core] - 10https://gerrit.wikimedia.org/r/110697 (owner: 10Hoo man) [16:25:42] Such abuse. [16:26:12] > By clicking the "Save page" button, you are agreeing to Wikimedia's terms of use and privacy policy, and you irrevocably agree to release your contribution under the CC-BY-SA 3.0 License and the GFDL. You agree that a hyperlink or URL is sufficient attribution under the Creative Commons license. [16:26:19] [ Send ] [ Preview ] [16:26:24] Does anyone see the bug? [16:26:46] Gloria: where's this? [16:26:54] [[Special:MassMessage]] [16:26:54] https://www.mediawiki.org/wiki/Special:MassMessage [16:27:14] The bug is that the button isn't labeled "Save page" so the disclaimer text is wrong. [16:27:19] yeah [16:27:26] * Gloria files a bug. [16:27:30] flow guys solved this by slapping messages with that text modified into their extension [16:27:45] i think they are going to solve this properly later [16:27:50] so cc them [16:28:06] Mehhhhhhhhh. [16:28:11] Lego will get cc'd. [16:28:20] (that message should just take a parameter, i think) [16:28:36] (or maybe it could be reworded, but people would probably want to ping legal about that) [16:28:56] e.g. Polish translation just vaguely talks about "saving your changes" [16:29:35] https://bugzilla.wikimedia.org/show_bug.cgi?id=60724 [16:30:39] (03PS14) 10Bartosz Dziewoński: Rewrite rendering of Vector simple search [core] - 10https://gerrit.wikimedia.org/r/82100 [16:31:15] https://bugzilla.wikimedia.org/show_bug.cgi?id=60725 [16:32:39] regarding bug https://bugzilla.wikimedia.org/show_bug.cgi?id=60459 the reviewer asks me to add an entry to the "Configuration changes" section of RELEASE-NOTES (for other users of MediaWiki) what do i have to enter? [16:32:47] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Reapplied on master, needs work per comments here." [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński) [16:33:05] (03PS1) 10UltrasonicNXT: Redo PM header interface [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/110698 [16:33:48] Lekshmi: Copy and paste the bug summary? [16:33:52] That's usually sufficient. [16:34:44] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Redo PM header interface [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/110698 (owner: 10UltrasonicNXT) [16:37:19] shall i add the deprecate function in removed methods in relase notes [16:39:56] the configuration changes in relaese notes talks only about version 1.23 while the deprecation of $wgCopyrighticon is in1.17.0 [16:40:19] so where shall i add the smmary [16:41:18] Lekshmi: Which change are you discussing? [16:41:43] https://gerrit.wikimedia.org/r/#/c/109903/ ? [16:42:21] yes [16:43:32] (03PS1) 10Ori.livneh: Bugfix for UDP reader [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/110699 [16:43:34] (03PS1) 10Ori.livneh: Use HMAC SHA1 with rotating key to hash IP addresses [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/110700 [16:45:04] shall i add the bug summary under configuration changes of 1.23 [16:45:12] Yes. [16:45:19] Lekshmi: If it's wrong, someone will complain. :-) [16:45:21] Don't worry about it. [16:45:24] Just amend the change. [16:45:26] (03CR) 10Isarra: "If I click on this, will it publish my replies?" (032 comments) [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/110669 (owner: 10Isarra) [16:45:35] (03CR) 10Ori.livneh: [C: 032] Bugfix for UDP reader [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/110699 (owner: 10Ori.livneh) [16:46:04] (03Merged) 10jenkins-bot: Bugfix for UDP reader [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/110699 (owner: 10Ori.livneh) [16:50:19] the reviewer has also asked me to make changes in two other files.how can i amend the commit if there are more files to be modified. [16:50:27] (03PS1) 10UltrasonicNXT: Fix problem with columnn widths [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/110701 [16:50:45] Lekshmi: https://www.mediawiki.org/wiki/Gerrit/Getting_started [16:50:51] Lekshmi: Just follow the instructions there. [16:51:17] (03PS2) 10UltrasonicNXT: Fix problem with columnn widths [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/110701 [16:51:49] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix problem with columnn widths [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/110701 (owner: 10UltrasonicNXT) [16:56:29] (03PS15) 10Bartosz Dziewoński: Rewrite rendering of Vector simple search [core] - 10https://gerrit.wikimedia.org/r/82100 [16:57:44] (03CR) 10Bartosz Dziewoński: "PS15: Finally, ultimately and for the last damned time adjusted the go vs fulltext vs search-suggestions behavior. It is proper now, and d" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński) [17:04:11] MatmaRex: regarding yesterdays select all checkboxes. Should I make a Check All / None button as in Special:Search ? [17:04:27] MatmaRex: or the collapsing select box, as per Umherrinder ? [17:04:40] https://gerrit.wikimedia.org/r/#/c/110610/ [17:05:02] shall i replace $wgcopyrighticon with $wgFooterIcons['copyright']['copyright'] or just $wgFootericons [17:08:58] tonythomas01: i honestly have no idea. :) [17:09:25] MatmaRex: But, I liked your idea of Check All/None button [17:09:43] Lekshmi: mh... you should do it like this: https://gerrit.wikimedia.org/r/110668 [17:09:57] nopt sure what you're talking about exactly, though [17:11:27] (03CR) 10Brian Wolff: [C: 04-1] "See inline" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110693 (owner: 10Imjacobclark) [17:12:12] (03PS16) 10Bartosz Dziewoński: Rewrite rendering of Vector simple search [core] - 10https://gerrit.wikimedia.org/r/82100 [17:12:45] (03CR) 10Bartosz Dziewoński: "I incorporated this in https://gerrit.wikimedia.org/r/#/c/82100/ . Thanks." [core] - 10https://gerrit.wikimedia.org/r/103066 (owner: 10TheDJ) [17:13:23] (03CR) 10Bartosz Dziewoński: "Fixed up the CSS and added Derk-Jan as coauthor, since I ended up using his solution. This should be good to merge now (but do test it a b" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński) [17:14:04] (03PS6) 10Bartosz Dziewoński: Remove HTML back-compat styles from I5fe0543e [core] - 10https://gerrit.wikimedia.org/r/82102 [17:14:27] (03PS3) 10Imjacobclark: Added wfSuppressWarnings and wfRestoreWarnings before and after the ini_set call to apc cache by default to suppress errors if ini_set is disabled [core] - 10https://gerrit.wikimedia.org/r/110693 [17:17:23] (03PS4) 10Imjacobclark: Added wfSuppressWarnings and wfRestoreWarnings before and after the ini_set call to apc cache by default to suppress errors if ini_set is disabled [core] - 10https://gerrit.wikimedia.org/r/110693 [17:21:43] (03PS1) 10Merlijn van Deen: Add Upload to Gerrit button to attachments [wikimedia/bugzilla/triagescripts] - 10https://gerrit.wikimedia.org/r/110702 [17:22:23] (03PS5) 10Bartosz Dziewoński: Add SVG version of search button icon [core] - 10https://gerrit.wikimedia.org/r/97307 (owner: 10M4tx) [17:24:13] (03CR) 10Bartosz Dziewoński: "Rebased on the latest version of the dependency." [core] - 10https://gerrit.wikimedia.org/r/97307 (owner: 10M4tx) [18:03:28] (03PS1) 10Ori.livneh: Reject FeedItem timestamps set too far in the future [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/110703 [18:03:52] (03Abandoned) 10Ebe123: Create Special:Purge [core] - 10https://gerrit.wikimedia.org/r/109523 (owner: 10Ebe123) [18:11:06] (03PS2) 10MaxSem: Reject FeedItem timestamps set too far in the future [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/110703 (owner: 10Ori.livneh) [18:11:56] (03CR) 10MaxSem: [C: 032] Reject FeedItem timestamps set too far in the future [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/110703 (owner: 10Ori.livneh) [18:11:58] (03Merged) 10jenkins-bot: Reject FeedItem timestamps set too far in the future [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/110703 (owner: 10Ori.livneh) [18:46:52] (03CR) 10Ori.livneh: [C: 032] vector: Split placeholder rules in search.less (again) [core] - 10https://gerrit.wikimedia.org/r/110683 (owner: 10Bartosz Dziewoński) [18:50:36] (03Merged) 10jenkins-bot: vector: Split placeholder rules in search.less (again) [core] - 10https://gerrit.wikimedia.org/r/110683 (owner: 10Bartosz Dziewoński) [18:54:41] (03PS7) 10Lekshmi: Changed deprecated $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/109903 [18:55:24] (03CR) 10jenkins-bot: [V: 04-1] Changed deprecated $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/109903 (owner: 10Lekshmi) [18:58:33] (03PS1) 10Physikerwelt: Prepare for DB2 integration [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/110704 [19:00:08] (03CR) 10Physikerwelt: [C: 032 V: 032] Prepare for DB2 integration [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/110704 (owner: 10Physikerwelt) [19:01:50] (03PS4) 10Physikerwelt: WIP: Add mathsearch test data [vagrant] - 10https://gerrit.wikimedia.org/r/108856 [19:01:53] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add mathsearch test data [vagrant] - 10https://gerrit.wikimedia.org/r/108856 (owner: 10Physikerwelt) [19:08:55] (03PS5) 10Physikerwelt: WIP: Add mathsearch test data [vagrant] - 10https://gerrit.wikimedia.org/r/108856 [19:11:56] (03PS6) 10Physikerwelt: WIP: Add mathsearch test data [vagrant] - 10https://gerrit.wikimedia.org/r/108856 [19:15:55] (03PS14) 10Inchikutty: [WIP]Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [19:18:35] (03PS8) 10Lekshmi: Changed deprecated $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/109903 [19:20:38] (03CR) 10jenkins-bot: [V: 04-1] Changed deprecated $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/109903 (owner: 10Lekshmi) [19:21:57] (03CR) 10Parent5446: [C: 04-1] "You can't just do a text Find + Replace and expect it to work." [core] - 10https://gerrit.wikimedia.org/r/109903 (owner: 10Lekshmi) [19:28:43] (03PS1) 10Umherirrender: Add CURRENTDAY1/LOCALDAY1 aliases for CURRENTDAY/LOCALDAY [core] - 10https://gerrit.wikimedia.org/r/110705 [19:32:25] where did I go wrong [19:38:00] (03CR) 10Umherirrender: "See r50811 for adding of aliases {{CURRENTMONTH2}} and {{LOCALMONTH2}}" [core] - 10https://gerrit.wikimedia.org/r/110705 (owner: 10Umherirrender) [19:38:00] https://www.mediawiki.org/wiki/Template:CURRENTMONTH2 [20:02:36] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 4ec4053..84433d6 [extensions] - 10https://gerrit.wikimedia.org/r/110816 [20:02:38] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 4ec4053..84433d6 [extensions] - 10https://gerrit.wikimedia.org/r/110816 (owner: 10Jenkins-mwext-sync) [20:05:15] (03PS9) 10Inchikutty: Embedding Static Map to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 [20:12:18] (03PS1) 10Ori.livneh: Update FeaturedFeeds to master [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110817 [20:14:16] We don't have a way to search for existing users via the API (while not requiring them to have an existing user page) right? [20:14:41] I mean, we can tell if a given user exists, but not search for all users beginning with a certain string [20:14:50] (03PS1) 10Ori.livneh: Update FeaturedFeeds to master [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/110818 [20:15:13] (03CR) 10Ori.livneh: [C: 032 V: 032] Update FeaturedFeeds to master [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110817 (owner: 10Ori.livneh) [20:15:23] (03CR) 10Ori.livneh: [C: 032 V: 032] Update FeaturedFeeds to master [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/110818 (owner: 10Ori.livneh) [20:16:07] Krenair: we have an allusers api [20:16:25] Krenair: which you can pass a prefix to search from [20:16:53] ahh allusers of course, thanks MatmaRex [20:17:03] (I probably should have read more of the docs page...) [20:19:37] (03PS1) 10Umherirrender: Add prop 'limitreportdata' and 'limitreporthtml' to action=parse [core] - 10https://gerrit.wikimedia.org/r/110819 [20:27:14] (03PS3) 10Technical 13: Use textarea instead of input for wpReason on Special:Userlogin/signup [core] - 10https://gerrit.wikimedia.org/r/107042 (owner: 10Yuvipanda) [20:34:13] (03PS8) 10Inchikutty: Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 [20:37:02] (03CR) 10Technical 13: "I believe that it is set up so that if "all" is checked, it doesn't even bother with the rest when updating the database. That way, if so" [core] - 10https://gerrit.wikimedia.org/r/110610 (owner: 1001tonythomas) [20:52:30] (03PS1) 10Alex Monk: Autocomplete performer field on Special:Log [core] - 10https://gerrit.wikimedia.org/r/110820 [20:59:42] (03CR) 10Hoo man: [C: 04-1] "don't think the JS should be specific to special log... why not have this generic, there are a lot more places where user names could be a" [core] - 10https://gerrit.wikimedia.org/r/110820 (owner: 10Alex Monk) [21:02:03] ori: hey can you help me out with this error during vagrant provision .. https://dpaste.de/577h#L2 [21:03:26] hoo, you thinking of something like $( '#mw-log-user' ).autocompleteMediaWikiUser() ? [21:04:00] please help ... https://dpaste.de/577h#L2 [21:04:55] Krenair: Something like that... could also stay in the mw. object... but please keep that generic, we don't want that logic ten times for every Special page using user names, right? [21:06:27] hoo, mediawiki.autocompleteUser( $( '#mw-log-user' ) ) ? [21:08:29] Krenair: Rather have it as a jQuery module. I'd say [21:18:54] hoo, okay then, $( '#mw-log-user' ).autocompleteMediaWikiUser() [21:19:31] (03CR) 10Nikerabbit: Added wfSuppressWarnings and wfRestoreWarnings before and after the ini_set call to apc cache by default to suppress errors if ini_set is di (032 comments) [core] - 10https://gerrit.wikimedia.org/r/110693 (owner: 10Imjacobclark) [21:19:37] I don't like the MediaWiki in tehre, but I also don't have a better idea at hand [21:21:18] hoo, storing the library in resources/jquery.ui/jquery.ui.autocomplete.mediawikiuser.js sound about right? [21:22:14] Krenair: What about $( ... ).mediaWiki.autocompleteUser() ? That would need a little more work, but might be worthwhile long term [21:23:36] this being my first jquery plugin I have no idea how you'd do that. [21:25:18] http://api.jqueryui.com/jQuery.widget/ [21:26:34] Well I found I could just use "$.fn.autocompleteMediaWikiUser = function () {" to implement $( '#mw-log-user' ).autocompleteMediaWikiUser() [21:26:58] Not so sure about the .mediawiki bit... [21:27:17] Krenair: fn is just an alias for jQuery's prototype [21:27:32] you can use that, but that's a jQuery module then, not a jQuery ui one [21:29:28] this one sums up jQuery ui widgets quite good it seems https://learn.jquery.com/jquery-ui/widget-factory/how-to-use-the-widget-factory/ [21:33:19] hoo, so I set it up to do $.widget( 'mediawiki.autocompleteMediaWikiUser', { _create: function () { /* code here */ } } ); but $('#mw-log-user').mediawiki appears undefined [21:34:02] Krenair: Not sure what you're askin for [21:34:17] the namespace wont appear if you call the ui widget from global jQuery() [21:35:39] I'm trying to get $('#mw-log-user').mediawiki.autocompleteMediaWikiUser to be defined [21:36:27] ok... when you will need to do $.fn.mediaWiki = {}; $.fn.mediawiki.autocomplete... = ... ; [21:36:40] not sure Krinkle will like that [21:36:47] or whether we already do it [21:37:04] I thought you said I needed to use $.widget... [21:37:43] Krenair: Yes, but you wont be able to use $( ... ).mediawiki.whatever using jQuery ui [21:37:52] I think there's a bug for that [21:37:59] in jQuery ui :/ [21:38:05] ah. [21:39:11] hoo, so then in $.fn.mediawiki.autocompleteUser how do I access the jquery object? [21:39:40] Krenair: Of the element it was called on? [21:39:44] yes [21:39:50] this should be set [21:39:53] so $( this ) [21:39:56] brb [21:40:28] no, this gives $.fn.mediawiki [21:41:34] (03PS5) 10Imjacobclark: Added wfSuppressWarnings and wfRestoreWarnings [core] - 10https://gerrit.wikimedia.org/r/110693 [21:43:40] (03PS6) 10Imjacobclark: Added wfSuppressWarnings and wfRestoreWarnings [core] - 10https://gerrit.wikimedia.org/r/110693 [21:47:56] doh, right [21:56:48] (03PS1) 10UltrasonicNXT: Fix DB errors [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/110821 [21:59:39] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix DB errors [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/110821 (owner: 10UltrasonicNXT) [22:06:03] any ideas hoo? [22:06:40] Krenair: In wikibase we just use jQuery ui anyway and ignore the potential problem [22:06:52] like $.widget( 'wikibase.foobar' ) [22:07:27] So how do you access $('#mw-log-user') when calling $( '#mw-log-user' ).wikibase.foobar() ? [22:08:59] oh that's with $.widget [22:09:13] hoo, right, so how do you get $( '#mw-log-user' ).wikibase.foobar() at all then? [22:09:28] Krenair: We don't [22:09:40] We just use $( '...' ).foobar( .. ) [22:09:41] :| [22:09:48] (03PS1) 10AalekhN: HTMLTextBlockField.php : Removes Nested P elements in HTMLTextBlockField [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/110823 [22:10:12] I'm going to have to use a $( '#mw-log-user' ).autocompleteMediaWikiUser() then hoo [22:12:47] (03PS2) 10Alex Monk: Autocomplete performer field on Special:Log [core] - 10https://gerrit.wikimedia.org/r/110820 [22:17:06] Krenair: Not a fan of that name, we should talk to Krinkle maybe he has an idea [22:17:41] yep. I might as well pre-emptively -1 it for him :P [22:31:47] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I'll look into this when a few other pending SVG changes are merged." [core] - 10https://gerrit.wikimedia.org/r/106506 (owner: 10Bartosz Dziewoński) [23:00:05] (03CR) 10Jack Phoenix: [C: 032 V: 032] Add working RenameUser hook [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/110615 (owner: 10UltrasonicNXT) [23:01:42] (03CR) 10Jack Phoenix: [C: 032 V: 032] Add cache time for avatars [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/110691 (owner: 10UltrasonicNXT)