[00:00:30] kaldari: But the main issues is something different [00:01:14] OK, lemme change it back to HtmlBuilder real quick.... [00:01:17] oh, found it [00:01:30] what'd you find? [00:01:33] You are using the dot syntax to call functions, we no longer support that [00:01:36] use colons [00:01:42] root:tag( 'table' ) [00:01:44] and so... [00:02:03] The old syntax was an insane workaround to make it look more like JS, but that's Lua -.- [00:02:40] so also mw.html:create('')? [00:03:14] hoo: I don't actually know Lua, but trying to learn. Sorry :P [00:04:21] ;) [00:04:31] kaldari: No, that one stays with dots [00:04:38] dots -> static calls [00:04:45] colons: Calls on instances [00:04:49] ah [00:05:48] (03PS3) 10Bsitu: Add cacheKey function and tests to TreeRepository + typo fix [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110472 [00:05:59] kaldari: Will fix the bug later on... that one should really give a nicer error message ;) [00:07:52] hoo: OK, no script error now, but it's not outputting anything :P [00:08:07] kaldari: Let me see [00:08:09] (03PS4) 10Bsitu: Add cacheKey function and tests to TreeRepository + typo fix [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110472 [00:09:13] kaldari: You got the hierarchy wrong... do you know jQuery? [00:09:18] yes [00:09:25] do "local table = root :tag('table')" or so [00:09:39] than you can do table:tag( 'tr' ):tag( 'td' ): ... [00:09:58] but if you just keep working on root you'll add stuff to the main element, but not to the table [00:10:27] or just directly call the :tag( 'tr' )... after the tag( 'table' ) [00:10:32] hoo: ah that's what I was afraid of [00:12:01] hoo: problem is that I want to make the table tags optional, so I guess that's going to make the code more complicated. I'll just have to create root elements for each tr instead I guess, and then append them to the table tag if it is supposed to exist. Does that sound correct? [00:12:57] (03PS5) 10Bsitu: Add cacheKey function and tests to TreeRepository + typo fix [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110472 [00:13:32] or I guess I could do root = mw.html.create(''), then root = root:tag('table') if the table tag is needed [00:14:01] that should work I think [00:15:02] maybe :) [00:16:15] kaldari: Probably does [00:16:33] Sorry, doing Wikidata deploy after-fixes now, so I'm a ltittle not-fully here :P [00:16:51] hoo: yay, that works! [00:16:59] hoo: Thanks!!! [00:21:21] (03PS3) 10AndyRussG: Check revision object for course talk notification [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110446 [00:22:21] (03PS2) 10AndyRussG: Additional checks for course talk notifications [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110461 [00:31:33] (03PS1) 10Brian Wolff: Add error handling if descriptionmsg isn't defined for extension. [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110475 [00:32:33] (03PS6) 10Bsitu: Add cacheKey function and tests to TreeRepository + typo fix [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110472 [00:34:40] Can someone review a revert to fix a core regression (currently deployed to MW.org)? [00:34:51] https://gerrit.wikimedia.org/r/#/c/110473/ [00:34:54] The bug is trivial to reproduce: [00:35:02] Go to https://www.mediawiki.org/w/index.php?title=Special:Preferences#mw-prefsection-watchlist [00:35:15] Uncheck "Add pages I create and files I upload to my watchlist". [00:35:20] Click save [00:35:27] It stays checked. [00:35:33] This is also causing problems for the GettingStarted extension. [00:35:59] (03CR) 10Legoktm: Add error handling if descriptionmsg isn't defined for extension. (031 comment) [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110475 (owner: 10Brian Wolff) [00:37:10] legoktm: yeah, that'd be better. /me not too interested in the issue, just rather not have fatals [00:37:26] (03PS2) 10Legoktm: Revert "User::saveOptions() optimization" [core] - 10https://gerrit.wikimedia.org/r/110473 (owner: 10Mattflaschen) [00:37:37] legoktm: in any case, that code goes away in newer mediawiki, so it doesn't have to perfect really [00:37:37] (03CR) 10Legoktm: [C: 032] Revert "User::saveOptions() optimization" [core] - 10https://gerrit.wikimedia.org/r/110473 (owner: 10Mattflaschen) [00:38:01] bawolff: o.O why does it go away? [00:38:15] I'm not sure, but the code isn't in master [00:38:26] Thanks, legoktm [00:38:33] I hope it got replaced with something less scary [00:38:39] I'll cherry-pick to the deployment branch. [00:38:52] superm401: np [00:38:56] glad you spotted it :) [00:39:16] legoktm, it broke GettingStarted. We have a hidden preference for whether to auto-show a tour. [00:39:44] bawolff: it hasn't been merged into master... https://gerrit.wikimedia.org/r/#/c/107110/ [00:40:01] https://gerrit.wikimedia.org/r/#/c/107211/ cherry-pick was self merged [00:40:14] (03PS1) 10Mattflaschen: Revert "User::saveOptions() optimization" [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110477 [00:40:16] * bawolff wonders why it was in a release... [00:41:02] There was also a code comment saying it would be gone after 1.22... [00:41:28] (03CR) 10Legoktm: [C: 04-1] "See https://gerrit.wikimedia.org/r/#/c/110475/1/includes/installer/WebInstallerPage.php,cm" [core] - 10https://gerrit.wikimedia.org/r/107110 (owner: 10MarkAHershberger) [00:41:34] :| [00:41:57] (03Merged) 10jenkins-bot: Revert "User::saveOptions() optimization" [core] - 10https://gerrit.wikimedia.org/r/110473 (owner: 10Mattflaschen) [00:43:16] legoktm, cherry-pick is https://gerrit.wikimedia.org/r/#/c/110477/ [00:43:33] superm401: I can't merge there :/ [00:43:59] "Very hacky for now, but I expect it only be used for 1.22.0 at the most" [00:44:04] Oh, yeah. [00:44:15] in Installer::getExtensionInfo [00:44:21] * legoktm sighs [00:45:30] (03CR) 10Brian Wolff: [C: 04-1] "Causes fatals if you have an extension without descriptionmsg" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/107110 (owner: 10MarkAHershberger) [00:47:47] (03PS1) 10Awjrichards: Integrate pretty MobileFrontend deployment note posting [tools/release] - 10https://gerrit.wikimedia.org/r/110479 [00:48:02] greg-g, can I deploy a hotfix for a preference bug? https://bugzilla.wikimedia.org/60653 [00:48:51] * greg-g is on call, one sec [00:48:54] (03CR) 10Awjrichards: [C: 04-2] "Probably best to merge https://gerrit.wikimedia.org/r/110282, https://gerrit.wikimedia.org/r/110283, https://gerrit.wikimedia.org/r/110284" [tools/release] - 10https://gerrit.wikimedia.org/r/110479 (owner: 10Awjrichards) [00:54:28] (03PS4) 10TTO: Add language override options for rebuildInterwiki [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/94593 [00:57:54] hoo: Found another bug(?). If you try to call addClass with a non-existant parameter, it causes a script error. I beleive this worked OK with the old HtmlBuilder though. Example: https://en.wikipedia.org/wiki/Module:Sidebar/sandbox https://en.wikipedia.org/wiki/Template:Sidebar/testcases [00:58:52] kaldari: This is now expected behaviour... [00:59:06] its a "feature" [00:59:06] OK, so I just need to add explicit tests now? [00:59:12] ebernhardson: It really is :P [00:59:28] hoo: i can actually see it helping in some cases :) [00:59:30] kaldari: Yep, we do that in teh function also, the old one just silently filtered that away [00:59:39] and we thought that would be wrong... tell the user that somethings awry [01:00:04] Be bold also applies to input handling :P [01:00:09] well, it did make for a nice shortcut :P [01:02:38] (03PS5) 10MrBlueSky: Special:Contributions: add all params to feed URL [core] - 10https://gerrit.wikimedia.org/r/108287 [01:02:47] (03CR) 10Brian Wolff: [C: 032] "Thanks, looks good." [core] - 10https://gerrit.wikimedia.org/r/108287 (owner: 10MrBlueSky) [01:03:22] hoo: I guess it would help if there was an up to date Lua template I could look at somewhere to get an idea of the new conventions. Do you know of any? [01:04:08] kaldari: I use the new mw.html in https://gerrit.wikimedia.org/r/#/c/105157/7/includes/lua/InfoboxRender.lua,unified quite a lot [01:04:28] it's very complex though (implementation of the infobox template) [01:04:48] Reedy: here the patches for the first of those EP errors you found: https://gerrit.wikimedia.org/r/#/c/110446/ and https://gerrit.wikimedia.org/r/#/c/110461/ [01:04:49] We also have https://www.mediawiki.org/wiki/Extension:Scribunto/Lua_reference_manual#Html_library [01:06:37] Reedy and ragesoss remember there's a patch coming in a bit for the last error [01:06:48] (03Merged) 10jenkins-bot: Special:Contributions: add all params to feed URL [core] - 10https://gerrit.wikimedia.org/r/108287 (owner: 10MrBlueSky) [01:08:17] hoo: hmm, I think I like HtmlBuilder better :P What's the advantage of mw.html? speed? [01:08:42] (03CR) 10Swalling: "Remove -1 because the button not showing etc. was because of https://gerrit.wikimedia.org/r/#/c/110473/, which is dealt with" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/107726 (owner: 10Mattflaschen) [01:09:02] kaldari: It has more features, a couple less bugs and is more verbose on errors [01:09:23] (03CR) 10Swalling: Auto-launch full tour, not just intro [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/107726 (owner: 10Mattflaschen) [01:09:24] eg. HtmlBuilder will at times just silently blackhole elements without giving oyu a warning or anything [01:09:31] (03PS1) 10Hoo man: Validate the type of the tagName given to mw.html.create [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/110484 [01:10:23] and mw.html has unit tests :P [01:10:28] * hoo loves unit tests [01:12:33] spage: sooo i added you to style-guide [01:12:42] for some reason when i ssh in though i cannot use the become command :( [01:14:47] (03PS2) 10Awjrichards: Integrate pretty MobileFrontend deployment note posting [tools/release] - 10https://gerrit.wikimedia.org/r/110479 [01:17:57] (03CR) 10Awjrichards: "Also, I would like to double check the existence of MF before running the MF-specific script. I'm not sure how this gets run so I'm not su" [tools/release] - 10https://gerrit.wikimedia.org/r/110479 (owner: 10Awjrichards) [01:18:02] superm401: local-styleguide@tools-login:~/core/resources$ make kss [01:18:03] make: *** [kss] Error 7 [01:18:47] jdlrobson, hmm, is that because there's no wiki? [01:18:58] superm401: yeh we can use beta labs though [01:19:05] Yeah, that's what I was going to say; should be fine. [01:19:58] superm401: ok so hopefully it will start autoupdating again soon [01:20:03] just running it now to try it out [01:20:09] jdlrobson, cool, thanks. [01:24:10] (03PS1) 10Hoo man: Update Wikidata to master [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110488 [01:24:51] (03PS1) 10Aude: Update Wikidata, fix js issue [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110489 [01:24:55] superm401: so.. i don't think this box can access beta labs [01:25:07] (03Abandoned) 10Aude: Update Wikidata, fix js issue [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110489 (owner: 10Aude) [01:25:37] jdlrobson, hmm, I think I heard of such an issue before. Let me ask in Labs. [01:25:43] (03CR) 10Aude: [C: 031] Update Wikidata to master [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110488 (owner: 10Hoo man) [01:26:48] it can ping wikipedia/mediawiki though [01:27:06] http://tools.wmflabs.org/styleguide/desktop/section-2.html < superm401 [01:32:13] * bawolff wonders why you're not doing that in the wiki? [01:34:06] (03PS12) 10Krinkle: Make Special:Whatlinkshere.php transcludable [core] - 10https://gerrit.wikimedia.org/r/106625 (owner: 10AalekhN) [01:34:15] (03CR) 10Krinkle: "Grammar in commit message." [core] - 10https://gerrit.wikimedia.org/r/106625 (owner: 10AalekhN) [01:36:43] (03CR) 10Krinkle: Add JS/CSS for the new NavigationPopups (031 comment) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [01:37:23] jdlrobson, mediawiki.org works for now, but Beta is better since it's more up to date. [01:37:28] I asked if there's a way to do that. [01:37:32] ok [01:39:10] (03CR) 10Krinkle: [C: 04-1] Add JS/CSS for the new NavigationPopups (031 comment) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [01:48:21] (03CR) 10Krinkle: [C: 031] mediawiki.util: Don't hardcode selectors in updateTooltipAccessKeys if possible [core] - 10https://gerrit.wikimedia.org/r/110377 (owner: 10Bartosz Dziewoński) [01:49:38] (03CR) 10Krinkle: [C: 04-1] "This was intentionally not added. If anything, it should be named according to mw.hook conventions and be given a documentation block." [core] - 10https://gerrit.wikimedia.org/r/110347 (owner: 10Helder.wiki) [01:50:32] (03CR) 10Krinkle: "It wasn't added because it will be asynchronous and can't be used this way. If you need hooks like this you should use a strict bind/fire " [core] - 10https://gerrit.wikimedia.org/r/110347 (owner: 10Helder.wiki) [01:51:28] (03PS4) 10Krinkle: Fire hook "LivePreviewPrepare" [core] - 10https://gerrit.wikimedia.org/r/110347 (owner: 10Helder.wiki) [01:51:48] (03CR) 10Swalling: [C: 031] "This is working piramido for the redirect funnel, including reverts. http://piramido.wmflabs.org/w/index.php?title=Hipster_ipsum&action=hi" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110315 (owner: 10Mattflaschen) [01:52:17] (03PS3) 10Bsitu: Limit Flow API to only respond on enabled pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110458 (owner: 10EBernhardson) [01:53:04] (03CR) 10Bsitu: [C: 031] Limit Flow API to only respond on enabled pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110458 (owner: 10EBernhardson) [01:55:26] (03CR) 10Krinkle: [C: 04-1] Fire hook "LivePreviewPrepare" [core] - 10https://gerrit.wikimedia.org/r/110347 (owner: 10Helder.wiki) [01:57:49] (03PS1) 10AndyRussG: Remove $this from closure in UserRoleMessage [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110491 [02:05:55] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 92f62d3..8960cc2 [extensions] - 10https://gerrit.wikimedia.org/r/110495 [02:05:57] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 92f62d3..8960cc2 [extensions] - 10https://gerrit.wikimedia.org/r/110495 (owner: 10Jenkins-mwext-sync) [02:22:46] (03PS2) 10Hoo man: Update Wikidata to master [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110488 [02:26:06] (03CR) 10Aude: [C: 031] Update Wikidata to master [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110488 (owner: 10Hoo man) [02:31:41] (03CR) 10Krinkle: Make message keys unique, were the same as extension/ContactPage (031 comment) [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/110142 (owner: 10Reedy) [02:36:52] (03PS1) 10Gerrit Patch Uploader: textMigration.php : Migration of text from archive table to text table [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/110499 [02:36:54] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/110499 (owner: 10Gerrit Patch Uploader) [02:37:30] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 8960cc2..4ec4053 [extensions] - 10https://gerrit.wikimedia.org/r/110500 [02:37:32] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 8960cc2..4ec4053 [extensions] - 10https://gerrit.wikimedia.org/r/110500 (owner: 10Jenkins-mwext-sync) [02:39:42] (03PS1) 10EBernhardson: Switch to underscores, because php mangles everything else [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110501 [02:40:07] (03PS2) 10Pawanseerwani: textMigration.php : Migration of text from archive table to text table [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/110499 (owner: 10Gerrit Patch Uploader) [02:44:46] (03CR) 10MZMcBride: "Does this change have an associated bug report? Quiddity just reminded me of bug 57154, which may be related." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [02:45:53] (03CR) 10MZMcBride: "I believe this change is related to bug 56196. It may make sense to note this in the commit message, if so." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110501 (owner: 10EBernhardson) [03:01:39] (03PS1) 10Gerrit Patch Uploader: textMigration.php : Migration of text from archive table to text table [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/110503 [03:01:45] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/110503 (owner: 10Gerrit Patch Uploader) [03:02:30] (03CR) 10PleaseStand: [C: 04-1] "Duplicate of I868a7a92." [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/110499 (owner: 10Gerrit Patch Uploader) [03:02:32] (03CR) 10Ragesoss: [C: 032] "tested locally" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110446 (owner: 10AndyRussG) [03:02:39] (03Merged) 10jenkins-bot: Check revision object for course talk notification [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110446 (owner: 10AndyRussG) [03:03:09] (03CR) 10Ragesoss: [C: 032] "tested locally" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110461 (owner: 10AndyRussG) [03:03:16] (03Merged) 10jenkins-bot: Additional checks for course talk notifications [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110461 (owner: 10AndyRussG) [03:04:35] (03CR) 10Tim Starling: [C: 032] Update Wikidata to master [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110488 (owner: 10Hoo man) [03:07:45] (03Merged) 10jenkins-bot: Update Wikidata to master [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110488 (owner: 10Hoo man) [03:13:50] (03CR) 10PleaseStand: [C: 04-1] "Haven't taken a close look yet, though I did notice some obvious problems:" [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/110503 (owner: 10Gerrit Patch Uploader) [03:39:59] (03PS14) 10Mattflaschen: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [03:41:21] (03CR) 10Mattflaschen: "Yair rand approved GPLv2+, so removing -2. Please keep that link (showing the license diff) in the commit message." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [03:48:50] (03CR) 10PleaseStand: "Found another issue, which I noted in an inline comment." (031 comment) [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/110503 (owner: 10Gerrit Patch Uploader) [03:51:03] (03PS1) 10Tim Starling: Revert "Update Wikidata to master" [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110507 [03:51:24] (03CR) 10Tim Starling: [C: 032] Revert "Update Wikidata to master" [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110507 (owner: 10Tim Starling) [03:55:23] (03Merged) 10jenkins-bot: Revert "Update Wikidata to master" [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110507 (owner: 10Tim Starling) [04:42:10] (03CR) 10AndyRussG: "Thanks, see inline comment." (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110143 (owner: 10AndyRussG) [04:59:44] (03CR) 10MZMcBride: "<3" [core] - 10https://gerrit.wikimedia.org/r/107017 (owner: 1001tonythomas) [05:00:18] Do I win for shortest comment? [05:04:01] are you sure that no-one's submitted a "." before you? ;) [05:06:38] https://en.wikipedia.org/wiki/Centerville_Community_College [05:06:41] Quality article. [05:08:54] I think it's real, at least. [05:08:58] It contains "the the". [05:09:02] That's why I'm looking at it. [05:16:47] I'm going to file a bug about killing ".m" from URLs. [05:16:51] I think Varnish can do that. [05:17:06] (03CR) 10Mattflaschen: [C: 032] "Confirmed locally." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/110157 (owner: 10Chiborg) [05:17:10] (03Merged) 10jenkins-bot: Use Revision ID instead of current Rev ID [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/110157 (owner: 10Chiborg) [05:17:20] (03CR) 10Parent5446: "The same way you deprecate anything else, by putting @deprecated in the documentation." [core] - 10https://gerrit.wikimedia.org/r/110246 (owner: 10Chad) [05:31:36] (03CR) 10Brian Wolff: "For future reference, if you ever need to update a version of a patch you submitted, just make sure that the Change-ID line in the commit " [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/110503 (owner: 10Gerrit Patch Uploader) [05:32:21] (03PS13) 10Mattflaschen: mediawiki.api: Fix token with postWithToken, add test [core] - 10https://gerrit.wikimedia.org/r/83217 [05:39:20] (03CR) 10Mattflaschen: "Both done in patch set 13." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [06:07:59] (03CR) 10Adamw: Refactor logic for course-related redundant data (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110334 (owner: 10AndyRussG) [06:14:53] (03CR) 10Adamw: [C: 032] Maintenance script for repairing redundant data [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110344 (owner: 10AndyRussG) [06:15:03] (03CR) 10Adamw: [C: 032] Refactor logic for course-related redundant data [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110334 (owner: 10AndyRussG) [06:15:13] (03Merged) 10jenkins-bot: Refactor logic for course-related redundant data [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110334 (owner: 10AndyRussG) [06:15:17] (03Merged) 10jenkins-bot: Maintenance script for repairing redundant data [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110344 (owner: 10AndyRussG) [06:21:06] (03CR) 10Adamw: [C: 032] Remove $this from closure in UserRoleMessage [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110491 (owner: 10AndyRussG) [06:21:13] (03Merged) 10jenkins-bot: Remove $this from closure in UserRoleMessage [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110491 (owner: 10AndyRussG) [06:32:37] (03CR) 10MZMcBride: "Related: bug 60412" [core] - 10https://gerrit.wikimedia.org/r/110279 (owner: 10Bartosz Dziewoński) [06:52:10] (03CR) 10TTO: "This can potentially be used for other things than drafts, Steven. I think many MW installations would find it useful for a variety of pur" [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO) [07:06:39] (03CR) 10MZMcBride: "This is trivial, but I'm not sure about the name "$wgPasswordDefault" as it inappropriately reminds me of "default password". I think it n" [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [07:34:16] (03PS6) 10Inchikutty: Adding Leaflet scripts to UploadWizard( OPW Round 7 Project-Part 2) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 [07:38:22] (03CR) 10MarkTraceur: [C: 04-1] Adding Leaflet scripts to UploadWizard( OPW Round 7 Project-Part 2) (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 (owner: 10Inchikutty) [08:00:42] (03CR) 10Nikerabbit: "Noooooo! This is not the way to do links in logs. You should pass the page name etc. in the log parameters, and format that in your LogFor" [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/110212 (owner: 10UltrasonicNXT) [08:13:35] (03PS8) 10Inchikutty: Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [08:19:32] (03PS7) 10Inchikutty: Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 [08:19:48] (03PS1) 10Hashar: User::saveOptions() optimization [core] - 10https://gerrit.wikimedia.org/r/110516 [08:20:16] (03CR) 10Hashar: "Proposed again as https://gerrit.wikimedia.org/r/#/c/110516/" [core] - 10https://gerrit.wikimedia.org/r/64941 (owner: 10Hashar) [08:20:25] (03CR) 10Hashar: "Proposed again as Proposed again as https://gerrit.wikimedia.org/r/#/c/110516/" [core] - 10https://gerrit.wikimedia.org/r/110473 (owner: 10Mattflaschen) [08:22:54] (03CR) 10Hashar: [C: 04-2] "This cause https://bugzilla.wikimedia.org/show_bug.cgi?id=60653 aka "Preference with value != default no longer saves properly"." [core] - 10https://gerrit.wikimedia.org/r/110516 (owner: 10Hashar) [08:25:31] (03PS9) 10Inchikutty: Embedding leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [08:29:39] (03CR) 10KartikMistry: "Ping for this simple review :)" [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/109630 (owner: 10KartikMistry) [08:47:22] (03PS1) 10Dereckson: Initial revision: AzharAuth 1.2.0 code import [extensions/AzharAuth] - 10https://gerrit.wikimedia.org/r/110518 [09:12:29] zz_prtksxna: hey [09:27:41] (03CR) 10Hashar: "Mailed Bryan and Ori about this change." [core] - 10https://gerrit.wikimedia.org/r/108890 (owner: 10Hashar) [09:40:06] hey YuviPanda [09:40:13] hi prtksxna [09:40:51] YuviPanda: How is the 90 degree shift of gravity in BLR? :P [09:41:06] prtksxna: heh, not bad. need to make sure I don't fuck up my sleep cycle tho [09:50:04] (03PS1) 10Gilles: Add the ability to know if fullscreen is available [core] - 10https://gerrit.wikimedia.org/r/110523 [09:58:25] (03CR) 10Hashar: "The mediawiki/core coverage report is much nicer: https://integration.wikimedia.org/cover/mediawiki-core/master/php/" [core] - 10https://gerrit.wikimedia.org/r/90584 (owner: 10JanZerebecki) [10:00:17] YuviPanda: So, Mattflaschen updated the patchset, to get the changes I should copy paste the code or is there a better way? I am still on 'master' on my local machine [10:03:48] prtksxna: ah [10:03:54] prtksxna: so do 'git review -d ' [10:03:57] prtksxna: should get you the latest [10:04:27] prtksxna: you should always do that whenever someone updates a patch [10:05:13] YuviPanda: Got it! Will from now on :) [10:05:25] prtksxna: yeah, otherwise it can get messy [10:13:57] (03CR) 10Helder.wiki: "So, should we remove the line" [core] - 10https://gerrit.wikimedia.org/r/110347 (owner: 10Helder.wiki) [10:24:13] prtksxna: move it to promises, and also rip out the functions some more? I'll try to get it merged tonight. [10:26:18] YuviPanda: Right, I'll get that done! [10:26:25] prtksxna: ok! [10:26:37] prtksxna: the beta feature registration can be a separate commit, I think. It's ok [10:26:40] for it to be [10:26:43] a separate commit [10:27:06] YuviPanda: Oh, ok, so just promise and un-nesting for now? [10:27:18] yeah [10:27:31] (03CR) 10Ladsgroup: "I'm one hundred percent against using Arabic fonts for Persian language. It's worse than using Chinese system to write Japanese text, thes" [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/110174 (owner: 10Reza) [10:35:43] (03PS15) 10Prtksxna: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 [10:51:40] (03PS1) 10Hashar: make some jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110535 [10:52:10] (03CR) 10Helder.wiki: "Indeed, this could also be a good replacement for the current hack used at Portuguese Wikibooks to automatically create a navigation bar f" [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO) [10:52:53] (03PS2) 10Hashar: make jslint voting by default [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110385 [10:53:02] (03CR) 10Hashar: [C: 032] make jslint voting by default [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110385 (owner: 10Hashar) [10:53:07] (03PS2) 10Hashar: make some jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110535 [10:53:09] (03Merged) 10jenkins-bot: make jslint voting by default [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110385 (owner: 10Hashar) [10:53:12] (03CR) 10Hashar: [C: 032] make some jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110535 (owner: 10Hashar) [10:54:16] (03CR) 10Hashar: [C: 032] make some jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110535 (owner: 10Hashar) [10:54:21] (03Merged) 10jenkins-bot: make some jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110535 (owner: 10Hashar) [11:08:54] prtksxna: join #wikimedia-growth [11:21:48] (03CR) 10Bartosz Dziewoński: "MZMcBride, I don't think that's the bug you wanted to refer to?" [core] - 10https://gerrit.wikimedia.org/r/110279 (owner: 10Bartosz Dziewoński) [11:24:29] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Can you submit this patch upstream first?" [core] - 10https://gerrit.wikimedia.org/r/110523 (owner: 10Gilles) [11:25:51] (03CR) 10Bartosz Dziewoński: "Yes. You might just want to just use the obsolete event triggered here:" [core] - 10https://gerrit.wikimedia.org/r/110347 (owner: 10Helder.wiki) [11:27:08] (03CR) 10Yuvipanda: "MatmaRex, I think Mz just pointed out that bug as a way of saying 'Why does StevenW have rights to -2?' :)" [core] - 10https://gerrit.wikimedia.org/r/110279 (owner: 10Bartosz Dziewoński) [11:27:30] oh. heh [11:28:17] so much passive aggressiveness [11:30:05] (03CR) 10Helder.wiki: "There is a similar line there already:" [core] - 10https://gerrit.wikimedia.org/r/110347 (owner: 10Helder.wiki) [11:38:11] (03CR) 10Bartosz Dziewoński: "Hmm, so I think this should be working already…" [core] - 10https://gerrit.wikimedia.org/r/110347 (owner: 10Helder.wiki) [11:53:15] (03PS16) 10Prtksxna: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 [11:54:15] (03PS1) 10Hoo man: Update Wikidata [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110536 [11:55:48] (03PS2) 10Hoo man: Update Wikidata [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110536 [12:09:19] hi all [12:09:20] shiva_venky, hey! [12:09:29] tu kaisa hai kya re? [12:09:58] need help with a bug fix [12:10:16] I'm new and this is my first bug fix [12:10:23] https://bugzilla.wikimedia.org/show_bug.cgi?id=19938 [12:10:33] where do I find the code to fix? [12:10:47] I've already cloned the repo with git [12:15:15] (03PS1) 10Hashar: experiment-gating-dependencies [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/110537 [12:15:34] (03CR) 10Hashar: [C: 032] experiment-gating-dependencies [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/110537 (owner: 10Hashar) [12:15:52] (03Merged) 10jenkins-bot: experiment-gating-dependencies [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/110537 (owner: 10Hashar) [12:17:34] (03PS1) 10Hashar: experiment-gating-dependencies [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110538 [12:17:46] (03CR) 10Hashar: [C: 032] experiment-gating-dependencies [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110538 (owner: 10Hashar) [12:17:50] (03Merged) 10jenkins-bot: experiment-gating-dependencies [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110538 (owner: 10Hashar) [12:21:04] shiva_venky: I'd start with includes/special/SpecialSearch.php and dig in from there [12:23:59] (03PS17) 10Prtksxna: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 [12:26:11] DanielK_WMDE [12:26:11] DanielK_WMDE [12:26:11] DanielK_WMDE [12:26:11] DanielK_WMDE [12:26:11] DanielK_WMDE [12:26:11] DanielK_WMDE [12:26:12] DanielK_WMDE, Thanks1 [12:26:39] once would have been enough :P [12:26:48] yeah I'm a n00b :D [12:27:01] welcome, then! [12:27:32] I think I found the problem [12:27:36] I've fixed it [12:27:46] How do I check if it's working? [12:28:08] I need some dummy data, so is there any automated way of feeding data? [12:28:34] DanielK_WMDE ^ [12:32:09] (03PS1) 10Pigpen: Latest state of development [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/110539 [12:32:14] (03PS1) 10Pigpen: Latest state of development [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/110540 [12:32:19] (03PS1) 10Pigpen: Latest state of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/110541 [12:32:24] (03PS2) 10MarkAHershberger: Add error handling if descriptionmsg isn't defined for extension. [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110475 (owner: 10Brian Wolff) [12:33:10] (03CR) 10Pigpen: [C: 032 V: 032] "Latest version" [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/110539 (owner: 10Pigpen) [12:33:58] (03CR) 10Pigpen: [C: 032 V: 032] "Latest version" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/110540 (owner: 10Pigpen) [12:34:44] (03CR) 10Pigpen: [C: 032 V: 032] "Latest version" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/110541 (owner: 10Pigpen) [12:51:19] (03PS1) 10Pastakhov: Add passing by Reference in BaseHook [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/110542 [12:51:38] (03PS1) 10Pastakhov: add several functions [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/110543 [12:52:07] (03CR) 10Pastakhov: [C: 032 V: 032] Add passing by Reference in BaseHook [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/110542 (owner: 10Pastakhov) [12:52:21] (03CR) 10Pastakhov: [C: 032 V: 032] add several functions [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/110543 (owner: 10Pastakhov) [13:11:34] (03CR) 10Hoo man: [C: 04-1] "Don't want this to be deployed w/o https://gerrit.wikimedia.org/r/110545 (which has not yet been approved)" [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110536 (owner: 10Hoo man) [13:11:41] (03PS18) 10Prtksxna: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 [13:35:59] (03PS1) 10MarkAHershberger: Initial commit [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110550 [13:36:01] (03PS1) 10MarkAHershberger: files from thepetwiki [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110551 [13:36:03] (03PS1) 10MarkAHershberger: * Clean up hard-coded DB queries * Move some messages to the i18n file * Set a global for the whitelist instead of a hard-coded url * Indention * Change the whitelist [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110552 [13:36:05] (03PS1) 10MarkAHershberger: remove spurious reference to targetuser [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110553 [13:36:07] (03PS1) 10MarkAHershberger: style updates, whitelist global [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110554 [13:36:09] (03PS1) 10MarkAHershberger: remove useless function [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110555 [13:36:11] (03PS1) 10MarkAHershberger: * Add support for UserMerge if available * Don't attempt to delete page if it is already deleted * Show what will be deleted [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110556 [13:36:13] (03PS1) 10MarkAHershberger: add command line script that helps with mass banning and move shared code to BanPests.php [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110557 [13:36:15] (03PS1) 10MarkAHershberger: Update README.md [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110558 [13:36:17] (03PS1) 10MarkAHershberger: Update README.md [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110559 [13:36:19] (03PS1) 10MarkAHershberger: Update README.md [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110560 [13:36:21] (03PS1) 10MarkAHershberger: Fix Issue #1 [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110561 [13:36:23] (03PS1) 10MarkAHershberger: * Add IP blocking to web ui. * change i18n keys so that they are def unique * Fix issue #3 — list of users shows usernames as page links * Fix issue #2 — show message even when there is nothing to do and do something when there are no p [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110562 [13:36:25] (03PS1) 10MarkAHershberger: thought these files were included in the previous commit [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110563 [13:36:27] (03PS1) 10MarkAHershberger: continuation of fix for issue #2 [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110564 [13:36:29] (03PS1) 10MarkAHershberger: continuation of fix for issue #2 [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110565 [13:36:31] (03PS1) 10MarkAHershberger: * Display blocked IPs/pages on special page [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110566 [13:36:33] (03PS1) 10MarkAHershberger: i18n [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110567 [13:36:35] (03PS1) 10MarkAHershberger: no escaping [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110568 [13:36:37] (03PS1) 10MarkAHershberger: some notices E_STRICT [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110569 [13:36:39] (03PS1) 10MarkAHershberger: Avoid some errors and make better output [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110570 [13:36:41] (03PS1) 10MarkAHershberger: fix a couple of bugs with the special page [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110571 [13:36:43] (03PS1) 10MarkAHershberger: Add error checking for whitelist and back compat to old variable name. [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110572 [13:53:05] (03CR) 10MarkAHershberger: [C: 032] Initial commit [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110550 (owner: 10MarkAHershberger) [13:53:07] (03CR) 10MarkAHershberger: [C: 032] add command line script that helps with mass banning and move shared code to BanPests.php [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110557 (owner: 10MarkAHershberger) [13:53:09] (03CR) 10MarkAHershberger: [C: 032] remove useless function [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110555 (owner: 10MarkAHershberger) [13:53:11] (03CR) 10MarkAHershberger: [C: 032] i18n [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110567 (owner: 10MarkAHershberger) [13:53:13] (03CR) 10MarkAHershberger: [C: 032] fix a couple of bugs with the special page [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110571 (owner: 10MarkAHershberger) [13:53:15] (03CR) 10MarkAHershberger: [C: 032] Update README.md [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110560 (owner: 10MarkAHershberger) [13:53:17] (03CR) 10MarkAHershberger: [C: 032] some notices E_STRICT [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110569 (owner: 10MarkAHershberger) [13:53:19] (03CR) 10MarkAHershberger: [C: 032] * Display blocked IPs/pages on special page [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110566 (owner: 10MarkAHershberger) [13:53:21] (03CR) 10MarkAHershberger: [C: 032] * Clean up hard-coded DB queries * Move some messages to the i18n file * Set a global for the whitelist instead of a hard-coded url * Indent [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110552 (owner: 10MarkAHershberger) [13:53:23] (03CR) 10MarkAHershberger: [C: 032] remove spurious reference to targetuser [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110553 (owner: 10MarkAHershberger) [13:53:25] (03CR) 10MarkAHershberger: [C: 032] Fix Issue #1 [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110561 (owner: 10MarkAHershberger) [13:53:27] (03CR) 10MarkAHershberger: [C: 032] * Add support for UserMerge if available * Don't attempt to delete page if it is already deleted * Show what will be deleted [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110556 (owner: 10MarkAHershberger) [13:53:29] (03CR) 10MarkAHershberger: [C: 032] Add error checking for whitelist and back compat to old variable name. [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110572 (owner: 10MarkAHershberger) [13:53:31] (03CR) 10MarkAHershberger: [C: 032] * Add IP blocking to web ui. * change i18n keys so that they are def unique * Fix issue #3 — list of users shows usernames as [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110562 (owner: 10MarkAHershberger) [13:53:33] (03CR) 10MarkAHershberger: [C: 032] style updates, whitelist global [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110554 (owner: 10MarkAHershberger) [13:53:35] (03CR) 10MarkAHershberger: [C: 032] thought these files were included in the previous commit [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110563 (owner: 10MarkAHershberger) [13:53:37] (03CR) 10MarkAHershberger: [C: 032] no escaping [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110568 (owner: 10MarkAHershberger) [13:53:39] (03CR) 10MarkAHershberger: [C: 032] continuation of fix for issue #2 [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110564 (owner: 10MarkAHershberger) [13:53:41] (03CR) 10MarkAHershberger: [C: 032] Update README.md [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110559 (owner: 10MarkAHershberger) [13:53:43] (03CR) 10MarkAHershberger: [C: 032] continuation of fix for issue #2 [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110565 (owner: 10MarkAHershberger) [13:53:45] (03CR) 10MarkAHershberger: [C: 032] files from thepetwiki [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110551 (owner: 10MarkAHershberger) [13:53:47] (03CR) 10MarkAHershberger: [C: 032] Avoid some errors and make better output [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110570 (owner: 10MarkAHershberger) [13:53:49] (03CR) 10MarkAHershberger: [C: 032] Update README.md [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110558 (owner: 10MarkAHershberger) [13:54:52] (03CR) 10MarkAHershberger: [V: 032] style updates, whitelist global [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110554 (owner: 10MarkAHershberger) [13:54:54] (03CR) 10MarkAHershberger: [V: 032] * Display blocked IPs/pages on special page [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110566 (owner: 10MarkAHershberger) [13:54:57] (03CR) 10MarkAHershberger: [V: 032] add command line script that helps with mass banning and move shared code to BanPests.php [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110557 (owner: 10MarkAHershberger) [13:54:58] (03CR) 10MarkAHershberger: [V: 032] Update README.md [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110559 (owner: 10MarkAHershberger) [13:55:00] (03CR) 10MarkAHershberger: [V: 032] some notices E_STRICT [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110569 (owner: 10MarkAHershberger) [13:55:03] (03CR) 10MarkAHershberger: [V: 032] no escaping [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110568 (owner: 10MarkAHershberger) [13:55:05] (03CR) 10MarkAHershberger: [V: 032] Initial commit [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110550 (owner: 10MarkAHershberger) [13:55:07] (03CR) 10MarkAHershberger: [V: 032] continuation of fix for issue #2 [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110565 (owner: 10MarkAHershberger) [13:55:09] (03CR) 10MarkAHershberger: [V: 032] * Add IP blocking to web ui. * change i18n keys so that they are def unique * Fix issue #3 — list of users shows usernames as [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110562 (owner: 10MarkAHershberger) [13:55:11] (03CR) 10MarkAHershberger: [V: 032] Fix Issue #1 [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110561 (owner: 10MarkAHershberger) [13:55:13] (03CR) 10MarkAHershberger: [V: 032] i18n [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110567 (owner: 10MarkAHershberger) [13:55:15] (03CR) 10MarkAHershberger: [V: 032] continuation of fix for issue #2 [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110564 (owner: 10MarkAHershberger) [13:55:17] (03CR) 10MarkAHershberger: [V: 032] Avoid some errors and make better output [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110570 (owner: 10MarkAHershberger) [13:55:19] (03CR) 10MarkAHershberger: [V: 032] Add error checking for whitelist and back compat to old variable name. [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110572 (owner: 10MarkAHershberger) [13:55:21] (03CR) 10MarkAHershberger: [V: 032] * Add support for UserMerge if available * Don't attempt to delete page if it is already deleted * Show what will be deleted [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110556 (owner: 10MarkAHershberger) [13:55:23] (03CR) 10MarkAHershberger: [V: 032] * Clean up hard-coded DB queries * Move some messages to the i18n file * Set a global for the whitelist instead of a hard-coded url * Indent [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110552 (owner: 10MarkAHershberger) [13:55:25] (03CR) 10MarkAHershberger: [V: 032] Update README.md [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110558 (owner: 10MarkAHershberger) [13:55:27] (03CR) 10MarkAHershberger: [V: 032] files from thepetwiki [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110551 (owner: 10MarkAHershberger) [13:55:29] (03CR) 10MarkAHershberger: [V: 032] thought these files were included in the previous commit [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110563 (owner: 10MarkAHershberger) [13:55:31] (03CR) 10MarkAHershberger: [V: 032] Update README.md [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110560 (owner: 10MarkAHershberger) [13:55:33] (03CR) 10MarkAHershberger: [V: 032] fix a couple of bugs with the special page [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110571 (owner: 10MarkAHershberger) [13:55:35] (03CR) 10MarkAHershberger: [V: 032] remove spurious reference to targetuser [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110553 (owner: 10MarkAHershberger) [13:55:37] (03CR) 10MarkAHershberger: [V: 032] remove useless function [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/110555 (owner: 10MarkAHershberger) [14:01:46] (03CR) 10MZMcBride: "What Yuvi said. :-)" [core] - 10https://gerrit.wikimedia.org/r/110279 (owner: 10Bartosz Dziewoński) [14:20:55] (03PS2) 10Phuedx: Stop logging with the GettingStartedOnRedirect schema. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110375 [14:28:35] (03CR) 10Phuedx: Stop logging with the GettingStartedOnRedirect schema. (035 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110375 (owner: 10Phuedx) [14:37:24] (03PS1) 10Yaron Koren: Fixed display of table of contents for MW 1.22 [extensions/HeaderTabs] - 10https://gerrit.wikimedia.org/r/110574 [14:38:06] (03CR) 10Yaron Koren: [C: 032 V: 031] Fixed display of table of contents for MW 1.22 [extensions/HeaderTabs] - 10https://gerrit.wikimedia.org/r/110574 (owner: 10Yaron Koren) [14:38:20] (03CR) 10Yaron Koren: [V: 032] Fixed display of table of contents for MW 1.22 [extensions/HeaderTabs] - 10https://gerrit.wikimedia.org/r/110574 (owner: 10Yaron Koren) [14:44:11] (03PS1) 10Anomie: Add newlines around scribunto-doc-page-show wikitext [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/110575 [14:53:54] (03CR) 10MZMcBride: "Given the sensitivity and subtlety here, I'd recommend an accompanying inline comment." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/110575 (owner: 10Anomie) [14:56:06] (03CR) 10Anomie: [C: 032] Validate the type of the tagName given to mw.html.create [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/110484 (owner: 10Hoo man) [14:58:04] (03Merged) 10jenkins-bot: Validate the type of the tagName given to mw.html.create [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/110484 (owner: 10Hoo man) [15:08:15] (03PS1) 10Hashar: fix jshintrc issues + default .jshintrc [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/110578 [15:09:09] (03CR) 10Hashar: "Cause the jslint job to pass: https://integration.wikimedia.org/ci/job/mwext-wikihiero-jslint/20/console" [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/110578 (owner: 10Hashar) [15:17:44] <^demon|away> hashar: Good morning :) [15:18:14] <^d> Did you happen to catch the stuff I !logged yesterday re: jenkins? pywikibot jobs were getting stuck again and clogging the queue. [15:19:12] nop :(' [15:19:26] ^d: I have no idea why it blocks zuul/gearman : [15:19:27] ( [15:19:45] will probably wrap that job so it timesout [15:19:46] <^d> Neither do I. But it was that same pywikibot-core-tests again. [15:19:51] iirc our default timeout is 360 minutes [15:20:46] <^d> Well, they *are* super long running jobs. [15:20:58] <^d> It just sucks that they grab spots in the queue and nothing else seems to get through. [15:27:21] (03CR) 10Chad: [C: 032] Force new version of mediawiki-selenium [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110383 (owner: 10Manybubbles) [15:27:30] (03Merged) 10jenkins-bot: Force new version of mediawiki-selenium [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110383 (owner: 10Manybubbles) [15:29:11] (03CR) 10Gilles: "https://github.com/theopolisme/jquery-fullscreen/pull/6" [core] - 10https://gerrit.wikimedia.org/r/110523 (owner: 10Gilles) [15:29:41] (03PS1) 10Phuedx: Update onboarding CTA impression logging. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110580 [15:30:16] (03PS2) 10Gilles: Add the ability to know if fullscreen is available [core] - 10https://gerrit.wikimedia.org/r/110523 [15:39:49] (03PS1) 10Yaron Koren: Re-added Joel Natividad's global var, now called $edgExternalValueVerbose [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/110581 [15:41:37] (03CR) 10Yaron Koren: [C: 032 V: 032] Re-added Joel Natividad's global var, now called $edgExternalValueVerbose [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/110581 (owner: 10Yaron Koren) [15:42:02] (03PS2) 10Addshore: Implement ApiQuerySites class [core] - 10https://gerrit.wikimedia.org/r/110427 [15:44:25] (03PS3) 10Addshore: Implement ApiQuerySites class [core] - 10https://gerrit.wikimedia.org/r/110427 [15:49:58] (03PS4) 10Gilles: Fix the i18n source string for the chunked preference [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 [15:53:43] (03CR) 10Chad: "That's silly when nothing is using it. If we could prove that something had ever used it outside of core, sure. But I'm not going to wait " [core] - 10https://gerrit.wikimedia.org/r/110246 (owner: 10Chad) [15:55:03] (03CR) 10Chad: "Furthermore, the reason I left the 3rd one was precisely *because* it's being used in extensions. That one should be deprecated." [core] - 10https://gerrit.wikimedia.org/r/110246 (owner: 10Chad) [16:04:20] (03PS1) 10Umherirrender: mb_substr() expects parameter 2 to be long, string given [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/110582 [16:04:35] (03CR) 10jenkins-bot: [V: 04-1] mb_substr() expects parameter 2 to be long, string given [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/110582 (owner: 10Umherirrender) [16:16:11] (03CR) 10Anomie: [C: 04-1] "I'm not seeing how exactly this solves bug 58200." (037 comments) [core] - 10https://gerrit.wikimedia.org/r/110427 (owner: 10Addshore) [16:22:01] (03PS1) 10Gerrit Patch Uploader: Indicator for menuForceShow in skin vector [core] - 10https://gerrit.wikimedia.org/r/110584 [16:22:03] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/110584 (owner: 10Gerrit Patch Uploader) [16:27:19] legoktm: think you can help me merge https://gerrit.wikimedia.org/r/#/c/109878/? [16:30:42] anomie: time for a quick question? [16:30:53] YuviPanda: Sure [16:31:05] (03PS1) 10Hashar: remove pywikibot-core-tests (not working) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110586 [16:31:26] anomie: We are planning on showing a small running feed of 'recent edits' on the wikipedia app. Doesn't need to be real time or too up to date, but I'll probably be querying once a minute or so from each device [16:31:33] anomie: so this will be hitting the recent changes API [16:31:40] anomie: is that cached enough to handle this? [16:32:01] ^d: so the pywikbot-core-tests simply does not work. Lame idea is to stop triggering it : https://gerrit.wikimedia.org/r/110586 [16:32:04] (there are about 16million installs of the app right now - and I guess this will trigger maybe once a day for everyone using it) [16:32:17] so approximately, 2-3 million installs, with headroom? [16:32:22] (03CR) 10Chad: [C: 032] remove pywikibot-core-tests (not working) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110586 (owner: 10Hashar) [16:32:26] (03Merged) 10jenkins-bot: remove pywikibot-core-tests (not working) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110586 (owner: 10Hashar) [16:32:30] <^d> hashar: Sounds good to me, merged. [16:32:51] deploying thx [16:33:08] YuviPanda: So hitting action=recentchanges once a minute? Only when the user has that screen in the app open, of course? [16:33:27] anomie: yeah, pretty much [16:33:44] anomie: hit, get about 20 edits or so, display them at 2-3secs per entry, and hit again when I run out [16:35:24] (03PS1) 10Chad: Remove stubiness from AuthPlugin [core] - 10https://gerrit.wikimedia.org/r/110587 [16:36:31] YuviPanda: Querying anonymously, or as the logged-in user? I'd recommend the former for maximum cacheablilty. I'd also suggest running it by ops too, I don't really know the details of how API queries are cached/served. [16:36:37] anomie: anonymously, yeah. [16:36:51] anomie: well, API queries aren't cached at all on varnish, so this would be hitting the apaches [16:36:57] anomie: that is why I am asking you first rather than ops :D [16:37:16] so for all intents and purposes the varnish layer doesn't exist here [16:37:41] YuviPanda: I don't see much problem with it from the MW side, although the more you can reduce the query rate the better. Also, be sure to use maxlag. [16:38:04] anomie: ah, right. hadn't considered maxlag. [16:38:07] (03CR) 10Liangent: [C: 031] Add newlines around scribunto-doc-page-show wikitext [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/110575 (owner: 10Anomie) [16:38:19] anomie: thanks! I'll run it past ops once anyway to be sure, but I think the mw side is the main bottleneck here [16:38:36] * anomie tends to forget maxlag because his bot framework handles it automatically [16:38:37] (03CR) 10BryanDavis: [C: 031] "I like the idea." [core] - 10https://gerrit.wikimedia.org/r/108890 (owner: 10Hashar) [16:39:44] anomie: heh, the primary api this thing hits is just action=mobileview, which is heavily cached (in memcached) [16:49:33] (03PS1) 10Brion VIBBER: Remove old Esperanto character conversion support [core] - 10https://gerrit.wikimedia.org/r/110589 [16:51:06] (03CR) 10Brion VIBBER: [C: 04-2] "Please wait to confirm community consensus before actually merging!" [core] - 10https://gerrit.wikimedia.org/r/110589 (owner: 10Brion VIBBER) [16:54:09] <^d> brion: It's the end of an era. [16:54:27] all hail ULS, the conquering king! [16:54:31] (03CR) 10Anomie: Support ApiPageSet in ApiWatch (031 comment) [core] - 10https://gerrit.wikimedia.org/r/53964 (owner: 10Eranroz) [16:54:36] <^d> (On the upside, the conversion stuff is a pain and I'd love a world without it) [16:54:49] yeah this belongs on the client side now that browsers aren't 2001-era pieces of shit [16:55:00] netscape 4! yeahhhh [16:55:20] <^d> What else uses it? I knew of eo and all the zh's. [16:55:50] oh the zh thing is a different system [16:55:54] that, alas, isn't going away :D [16:56:09] it will remain to haunt your nightmares [16:56:18] chinese, serbian, .... some others i forget [16:56:36] (03CR) 10Anomie: [C: 04-1] "Feel free to ignore the comments marked "(nitpick)" if you disagree." (037 comments) [core] - 10https://gerrit.wikimedia.org/r/53964 (owner: 10Eranroz) [16:57:02] <^d> brion: Ew. [16:57:13] <^d> The zh thing is what I don't support in new search well I think. [16:57:19] <^d> actually, I dunno wtf we do for zh. [16:57:21] <^d> I should find out. [17:02:19] (03CR) 10Parent5446: User::saveOptions() optimization (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110516 (owner: 10Hashar) [17:04:31] (03CR) 10Aaron Schulz: [C: 032] Remove unused function acceptListRedirects() [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/110418 (owner: 10Chad) [17:04:34] (03Merged) 10jenkins-bot: Remove unused function acceptListRedirects() [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/110418 (owner: 10Chad) [17:07:49] (03CR) 10Parent5446: "The tests on this patch are failing because it's still used in unit tests, as an example. We can't assume that just because no WMF-hosted " [core] - 10https://gerrit.wikimedia.org/r/110246 (owner: 10Chad) [17:08:51] (03CR) 10Aaron Schulz: "Why does the block action need to be visible? Can't the unblock entry just have an explanation?" [core] - 10https://gerrit.wikimedia.org/r/49234 (owner: 10Liangent) [17:20:37] (03CR) 10Aaron Schulz: [C: 032] Improve clarity of diff-multi message [core] - 10https://gerrit.wikimedia.org/r/106322 (owner: 10Jackmcbarn) [17:21:07] (03Abandoned) 10Chad: Move global constants that aren't used outside of here to class constants [core] - 10https://gerrit.wikimedia.org/r/110246 (owner: 10Chad) [17:21:50] (03CR) 10Liangent: "Another option could be to parse wikitext first then wrap its output into
, as HTML is not whitespace-sensitive," [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/110575 (owner: 10Anomie) [17:24:02] (03Merged) 10jenkins-bot: Improve clarity of diff-multi message [core] - 10https://gerrit.wikimedia.org/r/106322 (owner: 10Jackmcbarn) [17:31:00] (03PS2) 10EBernhardson: Switch to underscores, because php mangles everything else [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110501 [17:43:25] (03CR) 10Umherirrender: "recheck" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/110582 (owner: 10Umherirrender) [17:48:46] (03CR) 10Anomie: "Don't forget that the list=Flow module needs work too. That probably can be split into multiple Query modules rather than needing its own " (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm) [17:49:56] (03CR) 10Anomie: "True. It doesn't matter to me either way." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/110575 (owner: 10Anomie) [17:52:53] (03CR) 10Hashar: User::saveOptions() optimization (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110516 (owner: 10Hashar) [17:53:44] (03CR) 10BryanDavis: [C: 031] Remove stubiness from AuthPlugin [core] - 10https://gerrit.wikimedia.org/r/110587 (owner: 10Chad) [17:54:10] out for now, will be back tonight [17:54:13] for a short time thogh [17:54:15] * hashar wave [17:57:34] (03PS2) 10Lekshmi: Changed deprecated $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/109903 [18:01:41] (03CR) 10Umherirrender: "See r103836 for the same fix for the other call there." [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/110582 (owner: 10Umherirrender) [18:08:06] (03PS3) 10Lekshmi: Changed deprecated $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/109903 [18:08:29] (03PS1) 10Spage: Fix browser tests for new topic UI [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110597 [18:09:47] (03CR) 10Spage: "PS1 only fixes one of three failures, the easy one :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110597 (owner: 10Spage) [18:13:17] (03PS4) 10Lekshmi: Changed deprecated $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/109903 [18:16:32] (03CR) 1001tonythomas: [C: 04-1] "If you are trying to remove the wgCopyrightIcon block, codes between 5817 and 5822 neeeds to be removed." [core] - 10https://gerrit.wikimedia.org/r/109903 (owner: 10Lekshmi) [18:16:43] (03CR) 10MaxSem: [C: 032] fix jshintrc issues + default .jshintrc [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/110578 (owner: 10Hashar) [18:16:50] (03Merged) 10jenkins-bot: fix jshintrc issues + default .jshintrc [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/110578 (owner: 10Hashar) [18:20:48] (03PS1) 10Chad: Stop using SearchUpdate::updateText() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110598 [18:20:55] (03PS5) 10Lekshmi: Changed deprecated $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/109903 [18:23:20] (03CR) 1001tonythomas: [C: 04-1] "Comment leftover still remains." [core] - 10https://gerrit.wikimedia.org/r/109903 (owner: 10Lekshmi) [18:23:28] jdlrobson: hey! time for https://gerrit.wikimedia.org/r/#/c/109878/? [18:24:59] time for you and time for me [18:25:01] and time yet for a hundred indecisions [18:25:08] and for a hundred visions and revisions [18:25:14] before the taking of a toast and tea! [18:26:20] (03PS6) 10Lekshmi: Changed deprecated $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/109903 [18:30:59] ori: heh :) [18:31:15] ori: I just ran across a similar bit of work from you on the font stack bug :P [18:35:38] (03PS1) 10Chad: Begin indexing unexpanded text forms [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110604 [18:37:57] (03CR) 10Aaron Schulz: [C: 032] Remove unused acceptListRedirects() [core] - 10https://gerrit.wikimedia.org/r/110419 (owner: 10Chad) [18:41:15] (03Merged) 10jenkins-bot: Remove unused acceptListRedirects() [core] - 10https://gerrit.wikimedia.org/r/110419 (owner: 10Chad) [18:43:17] (03CR) 10Aaron Schulz: [C: 032] Adding python 3 support for the Makefile.py file for the zhtable [core] - 10https://gerrit.wikimedia.org/r/99086 (owner: 10shinjiman) [18:43:50] I have to add a jquery event to a set of checkboxes with id = mw-input-wpsearchnamespaces-0 , mw-input-wpsearchnamespaces-1 and so on .. is there some code like $(mw-input-wpsearchnamespaces-* ) to get it all done [18:43:51] ? [18:46:45] (03Merged) 10jenkins-bot: Adding python 3 support for the Makefile.py file for the zhtable [core] - 10https://gerrit.wikimedia.org/r/99086 (owner: 10shinjiman) [18:46:47] tonythomas01: I don't think anything direct like that, probably something like select a containing element, and then get all the checkboxes [18:47:27] select a containing element ? [18:47:43] this action needs to be triggered when I click on a select all checkbox above [18:48:11] found this online [18:48:12] $('input:checkbox').not(this).prop('checked', this.checked); [18:48:17] and looks like it worked [18:51:13] (03PS1) 10EBernhardson: Links in Echo notifications should be internal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110608 [18:54:43] (03CR) 10Aaron Schulz: [C: 032] Make autoblocks update with the parent block (031 comment) [core] - 10https://gerrit.wikimedia.org/r/66366 (owner: 10Parent5446) [18:55:52] (03PS1) 1001tonythomas: Ticking search in all namespaces should tick all the remaining checkboxes. [core] - 10https://gerrit.wikimedia.org/r/110610 [18:57:16] (03CR) 10jenkins-bot: [V: 04-1] Ticking search in all namespaces should tick all the remaining checkboxes. [core] - 10https://gerrit.wikimedia.org/r/110610 (owner: 1001tonythomas) [18:58:24] (03PS2) 1001tonythomas: Ticking search in all namespaces should tick all the remaining checkboxes. [core] - 10https://gerrit.wikimedia.org/r/110610 [18:58:54] (03CR) 10Kaldari: [C: 04-1] "This looks good, but I don't understand why it's part of VectorBeta. It doesn't provide any new Beta options in the preferences and it doe" (031 comment) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [18:59:11] (03Merged) 10jenkins-bot: Make autoblocks update with the parent block [core] - 10https://gerrit.wikimedia.org/r/66366 (owner: 10Parent5446) [18:59:46] (03CR) 10Aaron Schulz: [C: 032] Rollback: Make update of recentchanges table later [core] - 10https://gerrit.wikimedia.org/r/109706 (owner: 10Umherirrender) [19:00:00] hey marktraceur [19:00:05] (03CR) 10jenkins-bot: [V: 04-1] Ticking search in all namespaces should tick all the remaining checkboxes. [core] - 10https://gerrit.wikimedia.org/r/110610 (owner: 1001tonythomas) [19:01:03] Salut, prtksxna [19:01:05] What's up? [19:01:33] tonythomas01: Hmm, I think that would check other checkboxes on the page (outside of search) [19:01:58] marktraceur: I recently spoke to Jared and he tells me you have the best rationale for putting the NavigationPopups in VB :D [19:02:09] bawolff: oh :( missed it earlier [19:02:22] bawolff: the Enable simplified search bar (Vector skin only) is getting ticked too [19:02:28] must find some other way [19:02:33] prtksxna: I didn't realize I had any rationale for that, but one sec [19:02:48] prtksxna: marktraceur visual basic? :P [19:02:54] VectorBeta ye troll [19:03:02] ah :P [19:03:16] marktraceur: There are some comments on https://gerrit.wikimedia.org/r/#/c/109878/ that need to be responded too :) [19:03:21] tonythomas01: Not sure if its "proper" (really not a js person) but, try $('#mw-htmlform-advancedsearchoptions input:checkbox').not(this).prop('checked', this.checked); in the body of that function instead [19:03:31] prtksxna: It was something to the effect of 1. New extensions are hard 2. This is sort of a style change 3. This is all frontend changes [19:03:42] YuviPanda: I just remembered 'dim' from VB [19:03:48] prtksxna: Now, if it's not Vector-specific, we should rethink [19:03:49] prtksxna: hahah! good times [19:03:49] (03Merged) 10jenkins-bot: Rollback: Make update of recentchanges table later [core] - 10https://gerrit.wikimedia.org/r/109706 (owner: 10Umherirrender) [19:03:59] marktraceur: (1) is still the case [19:04:07] YuviPanda: I don't even remember what it does [19:04:08] we could split it out later on [19:04:14] Hm, maybe [19:04:15] prtksxna: equivalent of var in JS [19:04:31] prtksxna: originally stood for 'dimension', since you only needed to declare arrays [19:04:36] and nothing more [19:04:44] bawolff: that worked ;) [19:04:45] * YuviPanda smokes a pipe and reminesces [19:04:50] bawolff: thanks [19:05:12] YuviPanda: I see [19:05:22] marktraceur: do you mind reviewing that patch once? [19:05:31] prtksxna: I have a lot on my plate, was out for four days [19:05:40] Lots of review, lots of fixup [19:05:42] marktraceur: Oh! Vacation? [19:05:47] No, sick as a dog [19:05:53] marktraceur: Oh :( [19:06:05] (03PS3) 1001tonythomas: Ticking search in all namespaces should tick all the remaining checkboxes. [core] - 10https://gerrit.wikimedia.org/r/110610 [19:06:21] http://www.jamendo.com/en/track/30062/sick-as-a-dog [19:07:07] prtksxna: I just read your welcome email [19:07:15] (03CR) 10jenkins-bot: [V: 04-1] Ticking search in all namespaces should tick all the remaining checkboxes. [core] - 10https://gerrit.wikimedia.org/r/110610 (owner: 1001tonythomas) [19:07:19] bawolff: o/ [19:07:36] prtksxna: Welcome to Wikimedia-land :) [19:07:54] bawolff: he also did the campaigns redesign :) [19:08:05] cool [19:08:11] bawolff: Thanks you \o/ [19:08:17] s/Thanks/Thank [19:08:23] * bawolff now wonders what an "Explore experiment" is [19:09:01] (03PS4) 1001tonythomas: Ticking search in all namespaces should tick all the remaining checkboxes. [core] - 10https://gerrit.wikimedia.org/r/110610 [19:09:22] prtksxna: did you get your wikimedia.org email yet? [19:09:29] YuviPanda: Yes, just did :) [19:09:56] prtksxna: sweet [19:10:12] lol, Jared used grey text for part of your welcome message. He's a tricky one [19:10:33] (03PS19) 10Prtksxna: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 [19:10:33] bawolff: pfft, haven't you seen multicolored email in the design list? [19:10:45] I've seen like, light green text! [19:10:47] oh god the multicolored emails [19:10:48] I've gotten some before that were light green [19:10:50] my eyeeees [19:11:33] MatmaRex: I wonder if there's something we could set in mailman that strips html [19:11:49] I think that's already an option or something. The archives are plain text [19:11:55] bawolff: YuviPanda I don't see any colored text! [19:11:55] hmm [19:11:59] and if you get digest mails, the html is stripped [19:12:27] prtksxna: The last paragraph of your welcome email is very dark grey (the other's are black), you have to look closely [19:12:41] * prtksxna looks closely [19:12:43] prtksxna: Its just funny due to the ongoing fight over the use of grey text [19:13:00] bawolff: there's an ongoing fight? [19:13:07] bawolff: I read the papers, I see no fight! [19:13:59] * prtksxna questions his design skills as he can barely see the colors in the email [19:14:02] Hey bawolff, would you have time to review - https://gerrit.wikimedia.org/r/#/c/109878/ [19:15:06] prtksxna: Fight being the angry vibes at https://bugzilla.wikimedia.org/show_bug.cgi?id=58683 [19:15:43] prtksxna: that mostly just means you have a good display [19:15:55] or a bad display, i guess [19:16:03] depending on what you want� [19:16:44] MatmaRex: I had to open up the inspector and confirm the RGB values were different :P [19:16:59] prtksxna: I can look, but I'm really not the best person to review front end code [19:17:19] i'm not sure if i'd have noticed the grey there [19:17:21] it's #333 [19:17:42] about the end of the reasonable values for main text :) [19:17:50] MatmaRex: Bad display, there is a red line running across the screen that makes the 15" display effectively 13", ancient computer this! [19:18:02] MatmaRex: True [19:18:20] bawolff: Do take a look :) [19:18:52] MatmaRex: I just hate grey text with a blind passion [19:19:23] <^d> I personally prefer blue text on red backgrounds. [19:19:27] <^d> But I think I'm in the minority. [19:19:31] I quite like light lime green, though [19:19:38] especially on bright cyan [19:20:24] <^d> Ooh, idea for a feature in resource loader. [19:20:30] white on white for me, long live suprematism [19:20:36] <^d> Each time you request CSS, have it pick random colors to replace existing ones. [19:21:03] ^d: sounds great! [19:21:10] ^d: Also, make it replace your mouse cursor with a pony, that has a rainbow tail that changes slightly each time [19:21:16] ^d: we should also shuffle the fonts when we are at it [19:21:29] marquee all the things? [19:21:37] ooooh, wait. we should actually shuffle letter-spacing and line-spacing [19:21:41] *that* will piss designers off :P [19:21:45] leave everything else as is [19:21:45] ^d: its all possible with CSS now :D [19:21:49] <^d> prtksxna: We've done that before for fundraisers :) [19:22:00] YuviPanda, you are disgusting :P [19:22:00] ^d: I hope you are joking :P [19:22:04] prtksxna: :D [19:22:14] <^d> YuviPanda: ? No joke. [19:22:16] <^d> Ask brion [19:22:21] prtksxna: colors are too easy to dismiss. Subtle spacing issues, not so much :P [19:22:24] ^d: show me? [19:22:38] <^d> Oh this is years and years ago, doesn't exist anymore. [19:23:32] ^d: Then I won't believe it :P [19:23:37] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I don't like this half-solution; at least you'd have to also implement clearing this checkbox when the particular ones are unchecked, and " [core] - 10https://gerrit.wikimedia.org/r/110610 (owner: 1001tonythomas) [19:23:45] ^d: Must. Do it. Again. :D [19:23:51] <^d> https://en.wikipedia.org/wiki/Wikipedia:Wikipedia_Signpost/2007-10-22/Fundraiser,_budget - third paragraph [19:24:02] <^d> "The fundraising notice, linked from all pages on the English Wikipedia, caused some controversy at the beginning of the fundraiser, because it contained a scrolling marquee element that some users found distracting." [19:24:58] teehee [19:25:09] lol - "Getting attention is always going to be a balancing act between success & irritation." [19:26:24] (03CR) 10UltrasonicNXT: "Nikerabbit: can you show me an example or something of how to do this? I'll gladly do it, but there are no docs that I can find on doing i" [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/110212 (owner: 10UltrasonicNXT) [19:26:52] (03PS4) 10Kaldari: Remove unneeded h3s around Create Account links [core] - 10https://gerrit.wikimedia.org/r/110296 [19:28:13] (03CR) 10Nemo bis: "UltrasonicNXT, I've already provided you all you just asked: bug 60667." [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/110212 (owner: 10UltrasonicNXT) [19:31:13] (03CR) 10Prtksxna: Add JS/CSS for the new NavigationPopups (031 comment) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [19:31:32] (03CR) 10Aaron Schulz: getApiWarnings() throws an exception if upload is invalid (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105111 (owner: 10Mayankmadan) [19:32:23] (03CR) 10Aaron Schulz: [C: 04-1] "Per PS2 comment" [core] - 10https://gerrit.wikimedia.org/r/105111 (owner: 10Mayankmadan) [19:35:11] Reedy, around? [19:40:17] (03PS1) 10UltrasonicNXT: Add working RenameUser hook [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/110615 [19:40:34] (03CR) 10Brian Wolff: "causes bug 60691" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/82111 (owner: 10Alex Monk) [19:41:46] (03CR) 10UltrasonicNXT: "How should I escape the user name when adding to the DB? I know I need to, but I'm not sure how." [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/110615 (owner: 10UltrasonicNXT) [19:43:48] (03PS12) 10Parent5446: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 [19:43:54] (03CR) 10UltrasonicNXT: "Ah, ok, that little bit in the docs now is useful, thanks!" [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/110212 (owner: 10UltrasonicNXT) [19:44:36] (03CR) 10jenkins-bot: [V: 04-1] Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [19:44:53] (03PS1) 10Alex Monk: Fix search bar not being shown [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/110616 [19:45:16] (03PS5) 1001tonythomas: Ticking search in all namespaces should tick all the remaining checkboxes. [core] - 10https://gerrit.wikimedia.org/r/110610 [19:45:31] (03CR) 10Dereckson: "Thank you to have noticed and fixed that." [core] - 10https://gerrit.wikimedia.org/r/110190 (owner: 10Dereckson) [19:47:38] (03PS3) 10Umherirrender: Give alreadyrolled error when rollback will be a null edit [core] - 10https://gerrit.wikimedia.org/r/102550 [19:48:20] (03CR) 1001tonythomas: "@Bartosz: Forgot to add the reverse functionality earlier. Now fixed." [core] - 10https://gerrit.wikimedia.org/r/110610 (owner: 1001tonythomas) [19:49:09] (03CR) 10Umherirrender: "Patch Set 3: Rebased" [core] - 10https://gerrit.wikimedia.org/r/102550 (owner: 10Umherirrender) [19:49:33] (03PS13) 10Parent5446: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 [19:50:16] (03PS4) 10Umherirrender: Give alreadyrolled error when rollback will be a null edit [core] - 10https://gerrit.wikimedia.org/r/102550 [19:51:07] (03CR) 10Umherirrender: "Patch Set 4: Removed accidentally added windows newline style (\r\n -> \n)" [core] - 10https://gerrit.wikimedia.org/r/102550 (owner: 10Umherirrender) [19:53:10] (03CR) 10CSteipp: Create block log entries on HideUser blocks too (031 comment) [core] - 10https://gerrit.wikimedia.org/r/49234 (owner: 10Liangent) [19:55:49] (03CR) 10UltrasonicNXT: "Can either of you give me a bit more of a hand? I'm getting bogged down in code that seems very complex for adding a link..." [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/110212 (owner: 10UltrasonicNXT) [19:56:59] (03CR) 10Parent5446: [C: 031] Changed deprecated $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/109903 (owner: 10Lekshmi) [19:57:24] (03CR) 10Jack Phoenix: "Since you're using the Database class properly, it does all the magic for you and you don't need to manually mess with it AFAIK. The case " [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/110615 (owner: 10UltrasonicNXT) [19:57:31] (03CR) 10UltrasonicNXT: "Can I just copy that first if from the first function in that translation example? Do I need any other functions?" [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/110212 (owner: 10UltrasonicNXT) [19:58:20] (03CR) 10Hoo man: [C: 04-2] "Per Chris, LogPage::addEntry will notify IRC/ send to UDP" [core] - 10https://gerrit.wikimedia.org/r/49234 (owner: 10Liangent) [20:04:01] legoktm: bored? wanna investigate why this edit: https://pl.wikipedia.org/w/index.php?title=Dyskusja_Wikipedii:Przyznawanie_uprawnie%C5%84/Mateusz.ns/2&diff=prev&oldid=38573749 didn't trigger a notification? (the two users involved claim so) [20:12:04] (03PS21) 10EBernhardson: Edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 (owner: 10Matthias Mullie) [20:24:05] (03CR) 10CSteipp: "Apologies if you already mentioned this somewhere, but would it make sense to lazy-load the configuration instead of having it load for ev" [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [20:29:19] (03CR) 10Bartosz Dziewoński: "No offense to you personally, but I still don't believe this is an improvement. What is the user has already this option checked, plus som" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110610 (owner: 1001tonythomas) [20:32:44] (03PS2) 10UltrasonicNXT: Add working RenameUser hook [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/110615 [20:33:24] (03CR) 10UltrasonicNXT: "Ok, cool. I've added it to the patchset for the semantic-ness ;)" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/110615 (owner: 10UltrasonicNXT) [20:33:59] (03CR) 10Jhall: [C: 031] cucumber.yml is no longer needed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110350 (owner: 10Zfilipin) [20:34:32] (03CR) 10Jhall: [C: 031] Moved Sauce Labs browser configuration to mediawiki-selenium Ruby gem [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109913 (owner: 10Zfilipin) [20:35:39] !technews [20:35:40] https://meta.wikimedia.org/wiki/Tech/News/Latest [20:38:00] !roadmap [20:38:01] For long-term engineering goals roadmap, see . For short-term WMF deployments roadmap, see . [20:38:31] We have goals!? [20:39:17] <^d> Goals might be a little strong of a word. [20:39:21] <^d> Vague prospects? [20:39:41] <^d> Ruminations? [20:40:36] Apparently we define goals as the notes from scrum meetings [20:42:18] heh [20:42:22] bawolff: be bold [20:42:31] @trusted [20:42:31] I trust: petan|wk.*wikimedia/Petrb (2admin), .*@mediawiki/Krinkle (2admin), .*@wikimedia/Krinkle (2admin), .*@wikimedia/.* (2trusted), .*@wikipedia/.* (2trusted), .*@mediawiki/..* (2trusted), .*@wikipedia/MZMcBride (2admin), .*@wikinews/bawolff (2admin), .*@wikipedia/matma-rex (2admin), .*@wikimedia/qchris (2trusted), [20:43:01] <^d> Speaking of bold, let's see if we can get that other config cleanup in today. [20:44:03] <^d> Meh, prolly not. [20:44:08] <^d> Lotsa comments. [20:48:51] (03PS1) 10Physikerwelt: Move xQueryGenerator to MathSearch specialpage [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/110627 [20:54:13] (03CR) 10Bartosz Dziewoński: [C: 032] Remove unneeded h3s around Create Account links [core] - 10https://gerrit.wikimedia.org/r/110296 (owner: 10Kaldari) [20:55:16] (03PS3) 10Hoo man: Update Wikidata [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110536 [20:56:09] ori: you there? [20:58:03] (03Merged) 10jenkins-bot: Remove unneeded h3s around Create Account links [core] - 10https://gerrit.wikimedia.org/r/110296 (owner: 10Kaldari) [20:59:36] jdlrobson: barely [20:59:57] ori: :) Was just wondering whether to believe the data in http://mobile-reportcard.wmflabs.org/graphs/thanks-daily now :) [21:00:11] due to the schemapocalypse [21:00:21] no one is thanking on mobile which seems suspect. [21:00:23] jdlrobson: yeah, hold off if you could [21:02:19] (03CR) 10Bartosz Dziewoński: "Ops could get mad at immense the wfDeprecated spam that would cause." [core] - 10https://gerrit.wikimedia.org/r/106279 (owner: 10Bartosz Dziewoński) [21:05:01] (03CR) 10Bartosz Dziewoński: "Hmm, this is interesting, but could also look silly. I cc'd some smart people, any comments?" [core] - 10https://gerrit.wikimedia.org/r/110584 (owner: 10Gerrit Patch Uploader) [21:09:04] (03CR) 10Physikerwelt: [C: 032 V: 032] Move xQueryGenerator to MathSearch specialpage [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/110627 (owner: 10Physikerwelt) [21:12:23] (03PS2) 10Chad: Make abstract Config class truly implementation-agnostic [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [21:14:10] (03PS3) 10Chad: Make abstract Config class truly implementation-agnostic [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [21:18:47] (03CR) 10Wikinaut: Various fixes to job running code in Wiki.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/108740 (owner: 10Aaron Schulz) [21:19:23] (03CR) 10Umherirrender: "$wgEditEncoding should be deprecated or removed, because the only setter (in core) is removed with this patch set." [core] - 10https://gerrit.wikimedia.org/r/110589 (owner: 10Brion VIBBER) [21:19:46] (03PS4) 10Hoo man: Update Wikidata [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110536 [21:20:15] (03CR) 10Brion VIBBER: "Good points -- I'll go strip out the setting and updated rel notes as well." [core] - 10https://gerrit.wikimedia.org/r/110589 (owner: 10Brion VIBBER) [21:20:46] (03CR) 10Ori.livneh: [C: 032] Update Wikidata [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110536 (owner: 10Hoo man) [21:21:15] (03CR) 10Bartosz Dziewoński: "Does eo.wp have any community, and if yes, what do they think of this? Just wondering." [core] - 10https://gerrit.wikimedia.org/r/110589 (owner: 10Brion VIBBER) [21:21:42] (03CR) 10Bartosz Dziewoński: "(Nevermind, I see you are taking care of this. :) )" [core] - 10https://gerrit.wikimedia.org/r/110589 (owner: 10Brion VIBBER) [21:21:53] (03CR) 10Wikinaut: "-2" [core] - 10https://gerrit.wikimedia.org/r/108740 (owner: 10Aaron Schulz) [21:22:53] (03CR) 10Chad: "It was broken before this change too, so I'm not sure why you're taking so much offense here." [core] - 10https://gerrit.wikimedia.org/r/108740 (owner: 10Aaron Schulz) [21:23:49] (03Merged) 10jenkins-bot: Update Wikidata [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110536 (owner: 10Hoo man) [21:24:55] (03CR) 10Umherirrender: [C: 031] Code style fixes to ApiBase::requireAtLeastOneParameter [core] - 10https://gerrit.wikimedia.org/r/109321 (owner: 10Parent5446) [21:27:56] (03CR) 10Wikinaut: "filed as new bug https://bugzilla.wikimedia.org/show_bug.cgi?id=60698 (no offense apparent!)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/108740 (owner: 10Aaron Schulz) [21:29:18] (03CR) 10Chad: [C: 032] Fix search bar not being shown [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/110616 (owner: 10Alex Monk) [21:29:21] (03Merged) 10jenkins-bot: Fix search bar not being shown [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/110616 (owner: 10Alex Monk) [21:29:35] (03CR) 10Wikinaut: "Chad, the present commit fixes the general problem (when running a single wiki), but not the case, where the code is shared. This, and onl" [core] - 10https://gerrit.wikimedia.org/r/108740 (owner: 10Aaron Schulz) [21:30:12] thanks ^d [21:30:55] (03CR) 10Bartosz Dziewoński: [C: 032] Code style fixes to ApiBase::requireAtLeastOneParameter [core] - 10https://gerrit.wikimedia.org/r/109321 (owner: 10Parent5446) [21:31:55] (03PS1) 10Chad: Fix search bar not being shown [extensions/LiquidThreads] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110633 [21:32:20] (03PS1) 10Chad: Fix search bar not being shown [extensions/LiquidThreads] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/110634 [21:33:21] (03CR) 10Chad: [C: 032] Fix search bar not being shown [extensions/LiquidThreads] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110633 (owner: 10Chad) [21:33:23] (03Merged) 10jenkins-bot: Fix search bar not being shown [extensions/LiquidThreads] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110633 (owner: 10Chad) [21:33:33] (03CR) 10Chad: [C: 032] Fix search bar not being shown [extensions/LiquidThreads] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/110634 (owner: 10Chad) [21:33:35] (03Merged) 10jenkins-bot: Fix search bar not being shown [extensions/LiquidThreads] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/110634 (owner: 10Chad) [21:34:16] (03Merged) 10jenkins-bot: Code style fixes to ApiBase::requireAtLeastOneParameter [core] - 10https://gerrit.wikimedia.org/r/109321 (owner: 10Parent5446) [21:37:07] <^d> Krenair: Should be live everywhere now. [21:37:10] <^d> Thanks for the quick fix. [21:47:33] (03CR) 10EBernhardson: [C: 032] Edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 (owner: 10Matthias Mullie) [21:47:38] (03CR) 10Deskana: [C: 04-1] "Unworkable from a product standpoint if the entry is created to be suppressed later." [core] - 10https://gerrit.wikimedia.org/r/49234 (owner: 10Liangent) [21:47:44] (03Merged) 10jenkins-bot: Edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 (owner: 10Matthias Mullie) [21:53:43] (03PS1) 10Umherirrender: Document $wgResourceLoaderMaxage in DefaultSettings.php [core] - 10https://gerrit.wikimedia.org/r/110637 [21:54:31] (03CR) 10Umherirrender: "Feel free to reword." [core] - 10https://gerrit.wikimedia.org/r/110637 (owner: 10Umherirrender) [21:57:35] (03CR) 10Umherirrender: "Setting was added with r77011, todo later (Iea8d4e46eac2d971af43d47499d121d0c4e2bff3)" [core] - 10https://gerrit.wikimedia.org/r/110637 (owner: 10Umherirrender) [21:58:05] AaronSchulz: thanks for the JobSpecification thing :) [22:02:15] (03CR) 10Bartosz Dziewoński: Document $wgResourceLoaderMaxage in DefaultSettings.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110637 (owner: 10Umherirrender) [22:05:57] (03PS1) 10UltrasonicNXT: Fix sidebar problems when there are too many users on chat [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/110641 [22:06:07] (03PS1) 10Aaron Schulz: SQLite compatibility fixes [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/110642 [22:06:09] ^d: trivial [22:06:15] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix sidebar problems when there are too many users on chat [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/110641 (owner: 10UltrasonicNXT) [22:08:20] (03CR) 10Chad: [C: 032 V: 032] SQLite compatibility fixes [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/110642 (owner: 10Aaron Schulz) [22:12:18] (03PS3) 10Aaron Schulz: Made ActiveUsers use querycache and do staggered updates on view [core] - 10https://gerrit.wikimedia.org/r/110299 [22:12:34] ^d: I should make you review that too ;) [22:13:39] (03CR) 10PleaseStand: [C: 04-1] "-2: this is still in use in WMF configuration (in wmf-config/CommonSettings.php, located in the operations/mediawiki-config repo)." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109903 (owner: 10Lekshmi) [22:13:40] <^d> ActiveUsers? Nowai. [22:14:20] <^d> I hate querycache, ugh. [22:17:46] thanks AaronSchulz for working on that special page :) more than hoped [22:21:54] (03CR) 10CSteipp: [C: 04-1] "A couple minor issues I found while doing more testing on this." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [22:33:30] (03PS4) 10Aaron Schulz: Made ActiveUsers use querycache and do staggered updates on view [core] - 10https://gerrit.wikimedia.org/r/110299 [22:38:26] ^demon|away: could you look at https://www.mediawiki.org/wiki/Gerrit/Project_ownership#aarcos_.2B2_for_UploadWizard ? Aarcos works with the multimedia team as a full-time volunteer, he will need the +2 in the coming weeks [22:39:36] (03PS1) 10Aaron Schulz: Added --wiki parameter to runJobs.php call [core] - 10https://gerrit.wikimedia.org/r/110644 [22:40:06] (03CR) 10CSteipp: "One more when testing the wrapping script." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [22:40:45] full-time volunteer? heh [22:41:02] MatmaRex: He works with us in the office and stuff, it's a little different [22:41:36] still sounds weird :) [22:41:49] (03CR) 10Hoo man: [C: 031] Added --wiki parameter to runJobs.php call [core] - 10https://gerrit.wikimedia.org/r/110644 (owner: 10Aaron Schulz) [22:41:51] (03CR) 10Kaldari: [C: 04-1] "See previous review" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [22:48:39] (03PS1) 10CSteipp: Add Whirlpool using the password api [core] - 10https://gerrit.wikimedia.org/r/110646 [22:52:42] gwicke, where can I find instructions about setting up the Parsoid extension? https://www.mediawiki.org/wiki/Parsoid/Setup contains only instructions for the node.js server [22:53:32] jgonera, the extension is only needed if you are running a Varnish server and want to prime those caches on each edit [22:53:58] gwicke, I see, Krinkle|detached said that it's also needed if I use memcached [22:54:38] what are you using memcached for? [22:55:06] $wgMainCacheType = CACHE_MEMCACHED; [22:55:06] $wgParserCacheType = CACHE_MEMCACHED; [22:55:07] (03PS1) 10Jack Phoenix: Fix double parsing of the 'description' key in Special:Version. [core] - 10https://gerrit.wikimedia.org/r/110647 [22:55:36] jgonera, that is unrelated to Parsoid itself [22:56:15] VE uses memcached to speed up serialization, but that is also independent of the Parsoid extension [22:56:21] I see, I guess there was a misunderstanding then. so I'm fine running just the server alone? [22:56:37] yes, fine as in 'will work' [22:56:41] won't be fast necessarily [22:56:55] as you'll end up parsing stuff when somebody uses VE [22:57:07] rather than just loading HTML from disk [22:57:11] that's fine, it's just my local dev wiki [22:57:14] k [22:57:17] thanks [22:57:26] yw [23:02:01] hmm, when did we get dates in special:version, I thought that was wontfixed [23:02:51] (03CR) 10Brian Wolff: [C: 032] Fix double parsing of the 'description' key in Special:Version. [core] - 10https://gerrit.wikimedia.org/r/110647 (owner: 10Jack Phoenix) [23:06:12] (03Merged) 10jenkins-bot: Fix double parsing of the 'description' key in Special:Version. [core] - 10https://gerrit.wikimedia.org/r/110647 (owner: 10Jack Phoenix) [23:15:03] jdlrobson: csteipp please review https://gerrit.wikimedia.org/r/#/c/110653/ [23:15:32] Hmm, how is it that ashley is not on the unit tests white list... [23:15:48] beats me [23:16:15] ashley: You should be [23:16:38] you're obviously trusted. You've certainly been around longer than I have [23:16:40] MatmaRex: I'm sure we have many over-fulltime overworking volunteers in Wikimedia projects [23:17:23] chrismcmahon: Could I maybe recommend you spell out password. When I read that commit summary my mind jumped to present working directory [23:18:30] bawolff: probably wise jdlrobson ^^ [23:18:39] bawolff: heh, aye...a couple days ago I thought of writing an e-mail to wikitech-l in May -- May 15th marks my 6th (!) anniversary as a developer [23:19:09] * bawolff tries to look up where the heck that whitelist is anyways [23:20:40] bawolff: someone just added me to it I think [23:20:56] https://gerrit.wikimedia.org/r/110202 [23:21:10] I don't really know how many whitelists there are though [23:21:28] Yep, that's the one I'm thinking of. integration/zuul-config [23:23:52] wow, it runs on a regex of emails... [23:24:35] yeah, that's the one, duplicated twice in that file [23:27:17] so, will anybody add ashley to that list or do i have to do it myself? [23:27:24] I'm just about to [23:27:58] I'm also going to add tonythomas because yeah [23:28:25] I'm just looking at the list of people who don't have it to see who else could reasonably be added [23:30:38] ok, I'll do ashley first, and other randoms that might be controversial in a separate commit [23:31:19] can you also fix my username while you're at it ;) [23:33:06] (03PS1) 10Aaron Schulz: Fixed getDBname() for DatabaseSQLite [core] - 10https://gerrit.wikimedia.org/r/110656 [23:33:08] (03PS1) 10Aaron Schulz: Added some lock()/unlock() support for SQLite using lock file emulation [core] - 10https://gerrit.wikimedia.org/r/110657 [23:33:32] Nemo_bis: What's wrong with your username? [23:33:44] no uppercase ever :O [23:33:59] Just the b, or also the N? [23:34:06] b [23:34:49] oh i didn't do git add [23:35:06] (03PS1) 10Brian Wolff: Add Jack Phoenix. He's been here for about 6 years. [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110658 [23:38:23] (03CR) 10Gergő Tisza: [C: 04-1] "* Thumbs.db is something added by your computer, not a part of Leaflet (Windows has the annoying habit of creating it in every directory w" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 (owner: 10Inchikutty) [23:39:58] (03CR) 10Bartosz Dziewoński: [C: 031] Add Jack Phoenix. He's been here for about 6 years. [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110658 (owner: 10Brian Wolff) [23:41:46] (03CR) 10Alex Monk: [C: 031] Add Jack Phoenix. He's been here for about 6 years. [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110658 (owner: 10Brian Wolff) [23:42:13] Hmm, platonides also isn't on this list [23:44:01] (03CR) 10Alex Monk: [C: 032] Fixed getDBname() for DatabaseSQLite [core] - 10https://gerrit.wikimedia.org/r/110656 (owner: 10Aaron Schulz) [23:47:18] (03Merged) 10jenkins-bot: Fixed getDBname() for DatabaseSQLite [core] - 10https://gerrit.wikimedia.org/r/110656 (owner: 10Aaron Schulz) [23:47:21] (03CR) 10Gergő Tisza: [C: 04-1] Embedding Static Map to UploadWizard [OPW Round 7 project part 1] (036 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 (owner: 10Inchikutty) [23:48:12] (03CR) 10Krinkle: [C: 031] mediawiki.api: Fix token with postWithToken, add test [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [23:55:01] (03CR) 10TTO: Support ApiPageSet in ApiWatch (031 comment) [core] - 10https://gerrit.wikimedia.org/r/53964 (owner: 10Eranroz) [23:57:24] ^d: Can I steal you for 5 seconds for a gerrit issue? [23:57:35] <^d> James_F: Yo [23:57:46] ^d: https://gerrit.wikimedia.org/r/#/admin/projects/VisualEditor/VisualEditor,access [23:57:59] ^d: Given the inheritance, I assumed that l10n-bot would be able to +2. [23:58:07] ^d: But it's not working, for some reason. [23:58:25] <^d> Hmm [23:58:52] <^d> I never did understand how that exclusive flag worked. [23:58:54] And this is breaking l10n-bot, which doesn't understand the answer 'no'. [23:58:57] (03PS1) 10Brian Wolff: Add several users who now have quite a few commits [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110661 [23:59:30] Oh, does the 'exclusive' flag mean 'don't inherit'?