[00:02:03] (03PS19) 10EBernhardson: Edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 (owner: 10Matthias Mullie) [00:02:13] (03CR) 10jenkins-bot: [V: 04-1] Edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 (owner: 10Matthias Mullie) [00:02:25] (03CR) 10EBernhardson: "PS19: rebased" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 (owner: 10Matthias Mullie) [00:02:36] (03CR) 10Mattflaschen: [C: 04-1] "Looks good, except htmlspecialchars is not needed. After that, seems ready for merge." (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 (owner: 10Gilles) [00:03:53] (03PS20) 10EBernhardson: Edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 (owner: 10Matthias Mullie) [00:09:33] (03CR) 10Mattflaschen: [C: 04-1] "I confirmed LaTeXML isn't used in the WMF cluster config." (035 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 (owner: 10Physikerwelt) [00:12:06] (03CR) 10Bartosz Dziewoński: "These nulls seem wrong to be, the respective parameters are clearly documented as taking an array. I'll submit a followup." [core] - 10https://gerrit.wikimedia.org/r/110190 (owner: 10Dereckson) [00:24:44] (03CR) 10Chad: "Let's just deal with it later. I'm still not feeling clever enough to fix it." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108952 (owner: 10Manybubbles) [00:27:33] (03PS1) 10Bartosz Dziewoński: ErrorPageError and subclasses use array() instead of null per their docs [core] - 10https://gerrit.wikimedia.org/r/110275 [00:27:42] (03CR) 10Bartosz Dziewoński: "https://gerrit.wikimedia.org/r/110275" [core] - 10https://gerrit.wikimedia.org/r/110190 (owner: 10Dereckson) [00:28:31] (03PS1) 10Reedy: Allow addition of extra fields and append those values back onto the email text before sending it [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110276 [00:28:42] (03PS3) 10EBernhardson: Respect sizing from user-supplied class [core] - 10https://gerrit.wikimedia.org/r/104650 [00:29:05] (03CR) 10EBernhardson: "upstream hasn't merged a patch in 7 months https://github.com/jaz303/tipsy/pulls?direction=desc&page=1&sort=created&state=closed" [core] - 10https://gerrit.wikimedia.org/r/104650 (owner: 10EBernhardson) [00:30:05] (03CR) 10Parent5446: [C: 031] Remove vestiges of AdminSettings.php [core] - 10https://gerrit.wikimedia.org/r/110254 (owner: 10Chad) [00:31:17] (03CR) 10Parent5446: [C: 04-1] "We can't just remove the constants entirely, since they are used elsewhere." [core] - 10https://gerrit.wikimedia.org/r/110246 (owner: 10Chad) [00:40:53] (03PS13) 10SG: Implement better scrolling via conditionalScroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 [00:41:30] (03CR) 10SG: "Still broken, simply rebased. Going to correct the issues on this version." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 (owner: 10SG) [00:42:20] (03CR) 10EBernhardson: "Need to replace bind with $.proxy. Also there is an oddity, its not really a conflict but perhaps needs some love. When i click 'edit ti" (037 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 (owner: 10Matthias Mullie) [00:43:50] (03PS2) 10Reedy: Allow addition of extra fields and append those values back onto the email text before sending it [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110276 [00:51:25] (03CR) 10CSteipp: [C: 04-1] "Need to bump MW_USER_VERSION to make this work. That is also needed for I92a9fc63b409b182b1d7b48781d73fc7216f8061, so we may want to merge" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [00:54:53] (03PS1) 10Bartosz Dziewoński: "Keep me logged in" on Special:UserLogin should sometimes state duration [core] - 10https://gerrit.wikimedia.org/r/110279 [00:56:32] (03CR) 10Adamw: Accurately report institution activity [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109631 (owner: 10AndyRussG) [01:00:47] (03PS7) 10AndyRussG: Accurately report institution activity [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109631 [01:01:29] (03PS1) 10Awjrichards: Cleanup after processing by removing ChangeLog file [tools/release] - 10https://gerrit.wikimedia.org/r/110282 [01:01:31] (03PS1) 10Awjrichards: Generecize commit handling, allowing user to supply ranges [tools/release] - 10https://gerrit.wikimedia.org/r/110283 [01:01:33] (03PS1) 10Awjrichards: Make 'INFO' output optional with command line argument [tools/release] - 10https://gerrit.wikimedia.org/r/110284 [01:01:37] (03CR) 10jenkins-bot: [V: 04-1] Cleanup after processing by removing ChangeLog file [tools/release] - 10https://gerrit.wikimedia.org/r/110282 (owner: 10Awjrichards) [01:01:39] (03CR) 10jenkins-bot: [V: 04-1] Generecize commit handling, allowing user to supply ranges [tools/release] - 10https://gerrit.wikimedia.org/r/110283 (owner: 10Awjrichards) [01:01:41] (03CR) 10jenkins-bot: [V: 04-1] Make 'INFO' output optional with command line argument [tools/release] - 10https://gerrit.wikimedia.org/r/110284 (owner: 10Awjrichards) [01:02:26] (03PS2) 10JGonera: Remove styles for #mw-createaccount-join [core] - 10https://gerrit.wikimedia.org/r/105982 [01:05:20] (03PS2) 10Awjrichards: Generecize commit handling, allowing user to supply ranges [tools/release] - 10https://gerrit.wikimedia.org/r/110283 [01:05:28] (03CR) 10AndyRussG: "Rebased" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109631 (owner: 10AndyRussG) [01:05:40] (03PS2) 10Awjrichards: Make 'INFO' output optional with command line argument [tools/release] - 10https://gerrit.wikimedia.org/r/110284 [01:06:14] (03PS2) 10Awjrichards: Cleanup after processing by removing ChangeLog file [tools/release] - 10https://gerrit.wikimedia.org/r/110282 [01:06:27] (03PS3) 10Awjrichards: Generecize commit handling, allowing user to supply ranges [tools/release] - 10https://gerrit.wikimedia.org/r/110283 [01:06:36] (03PS3) 10Awjrichards: Make 'INFO' output optional with command line argument [tools/release] - 10https://gerrit.wikimedia.org/r/110284 [01:07:33] (03CR) 10Kaldari: [C: 032] Remove styles for #mw-createaccount-join [core] - 10https://gerrit.wikimedia.org/r/105982 (owner: 10JGonera) [01:09:30] (03PS8) 10AndyRussG: Accurately report institution activity [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109631 [01:10:01] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Contrary to the commit message "Create account" is always constructive. Please fix the code or the commit message :) (I frankly don't care" [core] - 10https://gerrit.wikimedia.org/r/110258 (owner: 10Spage) [01:10:18] (03CR) 10AndyRussG: Accurately report institution activity (032 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109631 (owner: 10AndyRussG) [01:10:21] spage: ^ [01:10:42] (03Merged) 10jenkins-bot: Remove styles for #mw-createaccount-join [core] - 10https://gerrit.wikimedia.org/r/105982 (owner: 10JGonera) [01:13:57] (03CR) 10Legoktm: [C: 04-1] Add dry-run mode to migrateToRevDel.php (032 comments) [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/109777 (owner: 10Alex Monk) [01:17:02] (03PS2) 10Spage: Use new mw-ui-constructive Agora styles [core] - 10https://gerrit.wikimedia.org/r/110258 [01:17:54] (03CR) 10Bartosz Dziewoński: [C: 032] Use new mw-ui-constructive Agora styles [core] - 10https://gerrit.wikimedia.org/r/110258 (owner: 10Spage) [01:21:22] (03Merged) 10jenkins-bot: Use new mw-ui-constructive Agora styles [core] - 10https://gerrit.wikimedia.org/r/110258 (owner: 10Spage) [01:22:00] (03CR) 10Isarra: "What I could see looked sensible, but since most of it went off the side in the diff view and there was no way to see it, that's not sayin" [core] - 10https://gerrit.wikimedia.org/r/110279 (owner: 10Bartosz Dziewoński) [01:22:16] (03Abandoned) 10Awjrichards: git-logs: adds MWApi, a class for interfacing with the MediaWiki API [tools/release] - 10https://gerrit.wikimedia.org/r/95738 (owner: 10Awjrichards) [01:22:27] Someone or something broke beta labs deployment. Wikidata is fatalling on every page. [01:22:27] (03Abandoned) 10Awjrichards: git-logs: Add method to create/edit articles [tools/release] - 10https://gerrit.wikimedia.org/r/95751 (owner: 10Awjrichards) [01:22:38] (03Abandoned) 10Awjrichards: git-logs: Create persistent requests session [tools/release] - 10https://gerrit.wikimedia.org/r/95750 (owner: 10Awjrichards) [01:22:48] Krinkle: known, see #-operations [01:23:03] (03CR) 10SG: "This actually introduces a couple of issues." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu) [01:25:31] (03CR) 10Spage: "Bartosz right, commit message wrong." [core] - 10https://gerrit.wikimedia.org/r/110258 (owner: 10Spage) [01:28:55] (03CR) 10Ladsgroup: "All fixed" [core] - 10https://gerrit.wikimedia.org/r/108681 (owner: 10Ladsgroup) [01:31:25] (03PS1) 10Reedy: Remove ContactPageFundraiser [tools/release] - 10https://gerrit.wikimedia.org/r/110293 [01:33:54] (03PS1) 10Bsitu: Watchlist "show all" results in an "Error" page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110294 [01:34:51] (03CR) 10Adamw: [C: 032] Update summary data when undeleting a course [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109643 (owner: 10AndyRussG) [01:34:59] (03Merged) 10jenkins-bot: Update summary data when undeleting a course [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109643 (owner: 10AndyRussG) [01:35:55] (03CR) 10Legoktm: "I think a constant would be better than a global config option." [core] - 10https://gerrit.wikimedia.org/r/110279 (owner: 10Bartosz Dziewoński) [01:36:07] (03CR) 10Legoktm: [C: 032] Don't show the overlay if the badge is not near the top of the window [extensions/Echo] - 10https://gerrit.wikimedia.org/r/103100 (owner: 10Bartosz Dziewoński) [01:36:19] (03Merged) 10jenkins-bot: Don't show the overlay if the badge is not near the top of the window [extensions/Echo] - 10https://gerrit.wikimedia.org/r/103100 (owner: 10Bartosz Dziewoński) [01:37:57] (03PS1) 10Kaldari: Remove unneeded h3s around Create Account links [core] - 10https://gerrit.wikimedia.org/r/110296 [01:38:43] (03CR) 10jenkins-bot: [V: 04-1] Remove unneeded h3s around Create Account links [core] - 10https://gerrit.wikimedia.org/r/110296 (owner: 10Kaldari) [01:40:36] (03PS3) 10Gerrit Patch Uploader: Clean up whitespace in various javascript files [core] - 10https://gerrit.wikimedia.org/r/108905 [01:41:11] (03CR) 10Krinkle: [C: 032] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/108905 (owner: 10Gerrit Patch Uploader) [01:41:20] (03CR) 10Adamw: [C: 032] Accurately report institution activity [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109631 (owner: 10AndyRussG) [01:41:25] (03PS2) 10Kaldari: Remove unneeded h3s around Create Account links [core] - 10https://gerrit.wikimedia.org/r/110296 [01:41:56] (03CR) 10jenkins-bot: [V: 04-1] Clean up whitespace in various javascript files [core] - 10https://gerrit.wikimedia.org/r/108905 (owner: 10Gerrit Patch Uploader) [01:42:51] (03Merged) 10jenkins-bot: Accurately report institution activity [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109631 (owner: 10AndyRussG) [01:44:25] (03CR) 10Mattflaschen: [C: 032] ErrorPageError and subclasses use array() instead of null per their docs [core] - 10https://gerrit.wikimedia.org/r/110275 (owner: 10Bartosz Dziewoński) [01:45:25] (03Merged) 10jenkins-bot: Clean up whitespace in various javascript files [core] - 10https://gerrit.wikimedia.org/r/108905 (owner: 10Gerrit Patch Uploader) [01:45:47] (03PS2) 10Alex Monk: Add dry-run mode to migrateToRevDel.php [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/109777 [01:47:27] (03Merged) 10jenkins-bot: ErrorPageError and subclasses use array() instead of null per their docs [core] - 10https://gerrit.wikimedia.org/r/110275 (owner: 10Bartosz Dziewoński) [01:48:17] (03PS1) 10Aude: update branches and extension for wikidata [tools/release] - 10https://gerrit.wikimedia.org/r/110297 [01:50:51] (03PS1) 10Aaron Schulz: [WIP] Made ActiveUsers use querycache and do staggered updates on view [core] - 10https://gerrit.wikimedia.org/r/110299 [01:56:33] (03CR) 10Krinkle: mw.loader.store: Wrap script eval in try/catch (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100930 (owner: 10Bartosz Dziewoński) [01:57:41] (03CR) 10Bartosz Dziewoński: "I don't believe Special:UserLogin is cached, is it? I'm pretty sure the last massive refactor was done with no back-compat styles or anyth" [core] - 10https://gerrit.wikimedia.org/r/110296 (owner: 10Kaldari) [01:58:41] Krinkle: is Special:UserLogin cached? it's not, right? [02:00:14] (03CR) 10Krinkle: mediawiki.notification: Hide #mw-notification-area when it's empty (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109124 (owner: 10Bartosz Dziewoński) [02:04:23] (03PS14) 10SG: Implement better scrolling via conditionalScroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 [02:04:53] (03CR) 10SG: "Fixes edit title issue. Should be good now." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 (owner: 10SG) [02:05:02] (03CR) 10Bartosz Dziewoński: "Hey Krinkle, can you just make this work the way you think would be the best (since you're obviously more knowledgeable about RL internals" [core] - 10https://gerrit.wikimedia.org/r/100930 (owner: 10Bartosz Dziewoński) [02:19:53] (03CR) 10Reedy: [C: 04-1] "A couple of people in FR didn't even know about this. A mingle card [1] has been opened for some investigation at their side." [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/110142 (owner: 10Reedy) [02:23:10] (03PS1) 10Mattflaschen: Put back #mw-createaccount-join styling, except colors [core] - 10https://gerrit.wikimedia.org/r/110301 [02:23:58] (03CR) 10Mattflaschen: "Partially reverted in https://gerrit.wikimedia.org/r/110301" [core] - 10https://gerrit.wikimedia.org/r/105982 (owner: 10JGonera) [02:28:33] (03CR) 10Brian Wolff: [C: 04-1] "Sorry, my previous comment was unclear. What I meant was that if {{Special:PopularPages/10}} works, then so should http://mwiki.com/wiki/S" [core] - 10https://gerrit.wikimedia.org/r/107979 (owner: 10Eranroz) [02:28:33] https://www.mediawiki.org/wiki/Special:Template:PopularPages/10 [02:28:56] good job wm-bot... [02:33:12] (03Abandoned) 10Brian Wolff: Add getHit.txt file [core] - 10https://gerrit.wikimedia.org/r/107427 (owner: 10Qitang) [02:33:13] herp [02:35:09] (03CR) 10Brian Wolff: "Do we have to worry about cached pages (Squid cache as parser cache doesn't come into this) but faster updating css for this change?" [core] - 10https://gerrit.wikimedia.org/r/100114 (owner: 10Danny B.) [02:40:35] (03CR) 10Brian Wolff: [C: 031] "This sounds sane to me. cc'ing csteipp since its messing with the css validation code which is security sensitive." [core] - 10https://gerrit.wikimedia.org/r/87648 (owner: 10Lambdafu) [02:47:11] (03CR) 10MZMcBride: "I'm still thinking about this idea." [core] - 10https://gerrit.wikimedia.org/r/110279 (owner: 10Bartosz Dziewoński) [02:50:01] (03CR) 10Brian Wolff: "This kind of feels like something that more belongs in an extension (But I don't feel super strongly about that either way)" [core] - 10https://gerrit.wikimedia.org/r/109853 (owner: 10Yurik) [02:58:29] (03CR) 10Brian Wolff: [C: 04-1] "Seems odd that this only limits logged in users and not logged out users?" [core] - 10https://gerrit.wikimedia.org/r/87269 (owner: 10Reedy) [02:59:36] mdale: I imagine there will be several bugs that will get magically "fixed" by the upgrade [03:06:16] (03CR) 10Brian Wolff: [C: 032] Fix various docs and version numbers from 84a2f570 [core] - 10https://gerrit.wikimedia.org/r/109459 (owner: 10Liangent) [03:09:37] (03Merged) 10jenkins-bot: Fix various docs and version numbers from 84a2f570 [core] - 10https://gerrit.wikimedia.org/r/109459 (owner: 10Liangent) [03:17:04] (03CR) 10Reedy: update branches and extension for wikidata (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/110297 (owner: 10Aude) [03:18:46] (03Restored) 10Reedy: Don't upload if output looks erroneous [tools/release] - 10https://gerrit.wikimedia.org/r/70648 (owner: 10Reedy) [03:18:49] (03PS2) 10Reedy: Don't upload if output looks erroneous [tools/release] - 10https://gerrit.wikimedia.org/r/70648 [03:21:41] (03PS3) 10Reedy: Don't upload if output looks erroneous [tools/release] - 10https://gerrit.wikimedia.org/r/70648 [03:21:58] (03PS4) 10Reedy: Don't upload if output looks erroneous [tools/release] - 10https://gerrit.wikimedia.org/r/70648 [03:22:06] (03CR) 10Reedy: [C: 032] Don't upload if output looks erroneous [tools/release] - 10https://gerrit.wikimedia.org/r/70648 (owner: 10Reedy) [03:22:08] (03Merged) 10jenkins-bot: Don't upload if output looks erroneous [tools/release] - 10https://gerrit.wikimedia.org/r/70648 (owner: 10Reedy) [03:23:35] (03CR) 10Aude: update branches and extension for wikidata (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/110297 (owner: 10Aude) [03:26:02] (03PS1) 10Reedy: Add a newline [tools/release] - 10https://gerrit.wikimedia.org/r/110308 [03:26:37] (03CR) 10Reedy: [C: 032] Add a newline [tools/release] - 10https://gerrit.wikimedia.org/r/110308 (owner: 10Reedy) [03:26:39] (03Merged) 10jenkins-bot: Add a newline [tools/release] - 10https://gerrit.wikimedia.org/r/110308 (owner: 10Reedy) [03:26:56] (03PS2) 10Aude: update branches and extension for wikidata [tools/release] - 10https://gerrit.wikimedia.org/r/110297 [03:27:01] (03CR) 10Reedy: [C: 032] update branches and extension for wikidata [tools/release] - 10https://gerrit.wikimedia.org/r/110297 (owner: 10Aude) [03:27:03] (03Merged) 10jenkins-bot: update branches and extension for wikidata [tools/release] - 10https://gerrit.wikimedia.org/r/110297 (owner: 10Aude) [03:51:21] (03PS1) 10Legoktm: Add missing wfProfileOut [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/110309 [03:51:49] (03CR) 10Reedy: [C: 032] Add missing wfProfileOut [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/110309 (owner: 10Legoktm) [03:51:57] (03Merged) 10jenkins-bot: Add missing wfProfileOut [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/110309 (owner: 10Legoktm) [03:51:57] so fast :D [03:52:04] much code review [03:53:17] Don't we have a tool for finding those? [03:54:11] legoktm: is legobot AFC statistics update bot code on GitHub I can access? [03:54:34] T13|sleeps: umm, which statistics? [03:55:00] The Template:AFC_statistics page [03:55:18] https://en.wikipedia.org/w/index.php?title=Template:AFC_statistics&action=history [03:55:21] that's Earwig's bot [03:55:29] and it's on github yeah [03:55:51] Oh.. why did I think it was legobot? Trout me... [03:55:58] Okay, thanks. [03:58:39] (03PS1) 10Brian Wolff: Have text for play link so it can be clicked by non-css browsers. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/110310 [04:03:46] Reedy: I think people started using $profile = new ProfileSection( __METHOD__ ); which doesn't require an Out call and is easier to read [04:05:13] (03PS1) 10Reedy: Remove unreachable statement [core] - 10https://gerrit.wikimedia.org/r/110311 [04:05:49] Reedy: "Can merge: No" [04:06:04] (03PS2) 10Reedy: Remove unreachable statement [core] - 10https://gerrit.wikimedia.org/r/110311 [04:06:08] (03CR) 10jenkins-bot: [V: 04-1] Remove unreachable statement [core] - 10https://gerrit.wikimedia.org/r/110311 (owner: 10Reedy) [04:06:13] Can Merge Yes [04:06:51] I think I wasn't on mater [04:06:54] *master [04:06:58] then pushed refs/for/master [04:07:00] (03CR) 10Legoktm: [C: 032] Remove unreachable statement [core] - 10https://gerrit.wikimedia.org/r/110311 (owner: 10Reedy) [04:07:58] (03CR) 10AalekhN: "bawolff:Hi i just added a reply seeking your advice please go through it" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106625 (owner: 10AalekhN) [04:08:18] PhpStorm suggests 11.541 issues with core [04:08:20] :/ [04:08:29] half an issue? [04:08:59] nah, its slightly more than half an issue [04:09:16] 11,541 [04:09:22] Though, not all are actually core [04:09:24] * Reedy excludes [04:10:35] (03Merged) 10jenkins-bot: Remove unreachable statement [core] - 10https://gerrit.wikimedia.org/r/110311 (owner: 10Reedy) [04:11:11] Lets try again [04:13:18] 9001 [04:13:44] that means the mediawiki-bugzilla extension and the ExtensionStatus extension have over 2,500 problems alone [04:14:09] >.< [04:14:24] Reedy: file over 9000 bugs? :D [04:15:33] (03CR) 10Brian Wolff: SpecialWhatlinkshere.php : made Special:Whatlinkshere transclude (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106625 (owner: 10AalekhN) [04:16:28] There's a load of stupid shit [04:16:53] And some false positives [04:17:01] Missing @throws tend to be true [04:17:13] ah [04:18:24] 4372 tagged as PHPDoc [04:31:59] superm401: `ssh -v tools.wmflabs.org` rejects me, I don't know if that's the right server for http:/tools.wmflabs.org [04:32:26] I commented on the changeset. If you want to ask about it, though, try #wikimedia-labs [04:32:30] spage: try tools-login.wmflabs.org [04:36:22] (03CR) 10Swalling: [C: 04-2] "I wasn't joking when I said this should be WONTFIXed." [core] - 10https://gerrit.wikimedia.org/r/110279 (owner: 10Bartosz Dziewoński) [04:45:24] superm401: FYI looks like the styleguide is in tools-login:/data/project/styleguide/core/resources/mediawiki.ui/docs/ , last built Jan 20th. [04:45:46] (03CR) 10Swalling: [C: 031] "This is a small error caused by gerrit 105982" [core] - 10https://gerrit.wikimedia.org/r/110301 (owner: 10Mattflaschen) [04:47:47] (03PS11) 10AalekhN: SpecialWhatlinkshere.php : made Special:Whatlinkshere transclude [core] - 10https://gerrit.wikimedia.org/r/106625 [04:48:52] (03CR) 10AalekhN: "bawolff: Please review it" [core] - 10https://gerrit.wikimedia.org/r/106625 (owner: 10AalekhN) [04:53:18] When Git does an auto-merge of files, it adds a <<<< Niharika, it's not duplicating the whole text, it's showing two different versions. [04:58:43] You need a merge tool. [04:58:52] Niharika, what operating system and editor do you use? [04:59:02] Windows - Brackets. [04:59:33] Niharika, try one of the options at http://stackoverflow.com/questions/4957630/how-do-you-merge-in-git-on-windows [04:59:41] superm401: Okay. [04:59:41] I like kdiff3, though I use it on GNU/Linux normally. [05:17:47] (03CR) 10Brian Wolff: Fix the i18n source string for the chunked preference (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 (owner: 10Gilles) [05:20:13] (03CR) 10Legoktm: [C: 04-1] "There's some weird thing about dual licensing on Wikipedia, but an explicit release from Yair Rand should definitely be obtained." (035 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [05:27:14] (03PS10) 10Prtksxna: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 [05:28:53] (03CR) 10Legoktm: Add JS/CSS for the new NavigationPopups (031 comment) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [05:28:55] legoktm: There needs to an empty line at the end of the file? (my editor is doing something funny) [05:28:55] (03PS1) 10Mattflaschen: Fix wrapping of CTA buttons [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110313 [05:28:57] (03CR) 10EBernhardson: "i dont think 60417 is the intended bug" [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 (owner: 10Physikerwelt) [05:29:04] prtksxna: yes, there should be an empty line [05:29:23] you can just add it manually if your editor doesn't do it automatically (mine doesnt) [05:29:29] if not, it's not a huge deal [05:30:00] oh, looks like you figured it out :) [05:30:02] legoktm: I did, I think it got rid of it :P [05:30:10] legoktm: Do you see it in PS10? [05:30:15] (03CR) 10Parent5446: "I also have to agree that the config option is the wrong way to go in this case." [core] - 10https://gerrit.wikimedia.org/r/110279 (owner: 10Bartosz Dziewoński) [05:30:27] the newlines look good to me [05:30:57] legoktm: Also, should I let the format: 'json' be for now? [05:31:04] you can keep it in if you want [05:31:31] legoktm: If it doesn't make any difference I think I'd rather get rid of it [05:31:43] sounds good to me :) [05:32:29] prtksxna, I'm going to -2 until the licensing is resolved, but I'll remove it as soon as that is taken care of. [05:32:32] I think Bartosz's question was a good one, is there a reason you're putting this in the VectorBeta repo instead of creating a new extension? [05:32:56] superm401: Cool! I think yuvipanda is talking to Yair so it shouldn't be a problem :) [05:33:15] legoktm: I'll push with all the stuff that you've pointed out in a bit. I think I'll push the feature flag thing once yuvipanda is up, he said he wanted to tell me something about it [05:33:26] ok [05:33:27] :) [05:34:10] I'm really excited someone is working on this, it's been a total kludge for a long time but is sooo crucial to most wikipedians' workflows [05:34:25] \o/ [05:34:34] (03CR) 10Mattflaschen: [C: 04-2] "Temporary -2 until the licensing question is resolved. Will be glad to remove after that." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [05:35:08] legoktm: Also, who do you think I should talk to about whether this belongs to VectorBeta or not. I spoke to Jared, Vibha and yuvipanda about it. [05:37:33] (03CR) 10Parent5446: [WIP] Made ActiveUsers use querycache and do staggered updates on view (032 comments) [core] - 10https://gerrit.wikimedia.org/r/110299 (owner: 10Aaron Schulz) [05:38:06] Not really sure. I believe the goal is for popups to be released as a beta feature but eventually be a stable thing (correct me if I'm wrong), so it should live in its own extension rather than starting out in VB and being moved later on. The name "VectorBeta" is kinda misleading since this feature has nothing to do with the Vector skin, and will eventually be a "stable" thing that isn't in beta. [05:39:55] The downside is that it's a tad bit harder to get a new extension deployed then putting new code in an existing extension, but if this is a BetaFeature, I think James_F|Away should be able to help with that... :) [05:40:06] legoktm: You are right. I am not completely sure about where things should go anyway. I'll discuss again with Jared [05:40:40] legoktm: You want me to do something like "page = re.query.pages[re.query.pageids[0]];"? [05:40:46] yup! [05:41:17] bbl in an hour-ish [05:42:02] (03PS11) 10Prtksxna: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 [05:43:25] (03CR) 10Prtksxna: Add JS/CSS for the new NavigationPopups (034 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [05:43:39] legoktm: (y) [05:47:04] Reedy: https://www.mediawiki.org/wiki/RL/MGU#Keep_gadgets_central [05:52:07] (03CR) 10Mattflaschen: "Looks good. The edit issue remains, but I'll note it again on the Trello card." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/109672 (owner: 10Phuedx) [05:52:16] (03CR) 10Mattflaschen: [C: 032] Log impressions of the onboarding CTA. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/109672 (owner: 10Phuedx) [05:52:19] (03Merged) 10jenkins-bot: Log impressions of the onboarding CTA. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/109672 (owner: 10Phuedx) [06:07:03] (03PS5) 10Mattflaschen: Auto-launch full tour, not just intro [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/107726 [06:07:35] (03CR) 10Mattflaschen: "Rebased again; currently mergeable" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/107726 (owner: 10Mattflaschen) [06:23:22] (03Abandoned) 10Mattflaschen: Put back #mw-createaccount-join styling, except colors [core] - 10https://gerrit.wikimedia.org/r/110301 (owner: 10Mattflaschen) [06:24:40] (03PS1) 10Mattflaschen: WIP: Tag all GettingStarted-related edits, including 'redirect' [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110315 [06:25:03] (03PS1) 10Spage: Revert "Remove styles for #mw-createaccount-join" [core] - 10https://gerrit.wikimedia.org/r/110316 [06:28:38] (03PS2) 10Spage: Revert "Remove styles for #mw-createaccount-join" [core] - 10https://gerrit.wikimedia.org/r/110316 [06:31:36] Reedy: around by any chance? [06:31:45] Yup [06:31:48] Still in the office... [06:32:12] wanna ask if you remember adding the tyv language back in ... um... august last year maybe? [06:32:38] Sounds familiar [06:32:42] basically I was trying to find out if you remember anythiing weird with it at the time, and no there's nothing broken now [06:32:55] I have user id 1 :D [06:32:56] 04:26, 11 August 2013 [06:33:04] but I was looking at the language file or dns and there's nothing in the git log for it, *yet* there is the language entry [06:33:10] wow nice [06:33:27] *for dns [06:34:15] I added tyv to langlist in I716d555011a2f535114372b8ac72f72dafa8bdf1 [06:34:28] to your side, yeah [06:34:32] https://gerrit.wikimedia.org/r/#/c/78332/ [06:35:03] but something needs to happen in dns, there's a language list there that afaict is maintained separately [06:35:57] https://git.wikimedia.org/history/operations%2Fdns/43644fdd2d43609462fb90656f90a8d93be2c424/templates%2Fhelpers%2Flangs.tmpl [06:36:08] nothing since march but [06:36:09] https://git.wikimedia.org/blob/operations%2Fdns/43644fdd2d43609462fb90656f90a8d93be2c424/templates%2Fhelpers%2Flangs.tmpl [06:36:27] look there's the language entry, so I was just curious if you remembered anything around that [06:36:30] if not, well, no worries [06:36:39] it's more my ocd getting the better of me [06:37:15] Hmm [06:37:38] curious isn't it? [06:38:01] Chances are it was probably mutante that did the dns entries [06:38:25] Does the langlist actually get used anywhere (still)? [06:38:38] the dns one does [06:38:54] I don't know about the other one [06:39:15] If it had been an uncommitted change someone would've noticed and/or committed it [06:39:46] Strange [06:40:22] I mean, it's definitely in both the repos since I see it in my localcopy after git pull [06:40:45] ok well, it was worth a shot seeing if you had any idea [06:41:04] thanks [06:41:40] Might be worth asking Daniel if it carries on annoying your ocd ;) [06:42:44] I will but I think chances are slim; he's the ne I asked about which language(s) might have been added after March and [06:42:53] it seems like he would have commente [06:42:53] d [06:43:03] but you are right, I'll ask anyways :-D :-D [06:50:22] prtksxna: woo, looks good to me, just needs a feature flag and the copyright thing :) [06:52:39] legoktm: I have this, but I am just waiting for yuvipanda [06:53:06] * legoktm stabs yuvipanda  [06:53:11] wake up! [06:53:23] lol [06:54:32] * Jasper_Deng arrests legoktm on suspicion of murder [06:54:46] :< [06:54:48] darn [06:54:57] legoktm: s/i have this/i have this http://pastie.org/8681023 [06:55:08] lol forgot to put the link [06:55:09] And I would have gotten away for it if it weren't for those meddling kids! [06:55:31] * prtksxna pulls legoktm's mask to reveal… [06:55:43] prtksxna: oh yeah, thats basically it. just stick a comment on top of the variable in VectorBeta.php explaining what it does [06:56:12] /** Makes world blow up [06:56:16] * @var bool [06:56:19] */ [06:56:37] $wgUnDisenableSafetyNet = false; [06:57:14] legoktm: Will do (y) [07:10:16] (03CR) 10Gilles: "I don't mind accepting this change as-is, but wouldn't it be a good time to make canPlayType accept regexps for a more future-proof fix?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108646 (owner: 10Brian Wolff) [07:14:10] (03PS5) 10Inchikutty: (WIP)Embedding Static Map to UploadWizard- part of OPW round 7 Project [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 [07:28:54] (03PS6) 10Legoktm: Properly get timestamp position in DiscussionParser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/108329 (owner: 10Whym) [07:42:45] (03CR) 10Legoktm: [C: 032] "I've tested this patch in 3 languages (en, ja, pt) and everything works as expected. Thanks!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/108329 (owner: 10Whym) [07:42:53] (03Merged) 10jenkins-bot: Properly get timestamp position in DiscussionParser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/108329 (owner: 10Whym) [07:51:17] (03CR) 10Legoktm: [C: 031] "I'll +2 after a while if there are no objections." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/107328 (owner: 10Qgil) [07:54:25] (03CR) 10Physikerwelt: "The puppet script should create a file with in /vagrant/settings.d/puppet-managed/10-MathSearch.php" [vagrant] - 10https://gerrit.wikimedia.org/r/108827 (owner: 10Physikerwelt) [07:59:01] (03PS1) 10Legoktm: Increment version number to 0.0.2 [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/110323 [07:59:15] (03CR) 10Legoktm: [C: 032] Increment version number to 0.0.2 [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/110323 (owner: 10Legoktm) [07:59:22] (03Merged) 10jenkins-bot: Increment version number to 0.0.2 [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/110323 (owner: 10Legoktm) [07:59:45] (03PS1) 10Gerrit Patch Uploader: Exclude backlinks from selection [extensions/Cite] - 10https://gerrit.wikimedia.org/r/110324 [07:59:47] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/110324 (owner: 10Gerrit Patch Uploader) [08:03:00] (03PS8) 10Legoktm: Check for a message with no timestamp [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87183 [08:03:37] (03CR) 10Legoktm: "PS8: Rebase and added a little comment" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87183 (owner: 10Legoktm) [08:04:15] (03PS3) 10Legoktm: Don't parse custom footer [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97366 [08:05:26] (03CR) 10Legoktm: [C: 032] "Re-applying Bartosz's +2 after parent patches were merged, this just needed someone to press the rebase button." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97366 (owner: 10Legoktm) [08:05:33] (03Merged) 10jenkins-bot: Don't parse custom footer [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97366 (owner: 10Legoktm) [08:06:56] (03Abandoned) 10Legoktm: Allow sending a message to every single user on all wikis [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/104789 (owner: 10Legoktm) [08:11:30] (03CR) 10Krinkle: "A few code review points to work on (not conclusive or complete)" (0313 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [08:18:04] (03PS8) 10Spage: Update login and HTMLForm to new design [core] - 10https://gerrit.wikimedia.org/r/104011 [08:18:16] (03PS5) 10Legoktm: Show an error to the user if the spamlist has no targets on it [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 [08:19:11] (03CR) 10jenkins-bot: [V: 04-1] Show an error to the user if the spamlist has no targets on it [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 (owner: 10Legoktm) [08:19:15] :< [08:20:03] * legoktm facepalms [08:21:51] (03PS3) 10Gilles: Fix the i18n source string for the chunked preference [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 [08:25:07] (03CR) 10Spage: "This is close, but arranging the Login form's three" [core] - 10https://gerrit.wikimedia.org/r/104011 (owner: 10Spage) [08:25:28] (03CR) 10TTO: "Cscott: Just wondering what needs to occur before the -2 can be removed? It's quite disheartening to see it on the patch :(" [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [08:25:43] (03PS6) 10Legoktm: Show an error to the user if the spamlist has no targets on it [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 [08:33:01] (03CR) 10Legoktm: [C: 04-1] "I'm getting test failures locally, need to investigate what's going on." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 (owner: 10Legoktm) [08:35:18] (03PS3) 10Legoktm: Link to [[mw:Help:Extension:MassMessage]] at top of the special page [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94696 [08:35:18] https://www.mediawiki.org/wiki/Help:Extension:MassMessage [08:35:48] (03PS1) 10Physikerwelt: Change datbase layout [extensions/Math] - 10https://gerrit.wikimedia.org/r/110329 [08:35:57] (03CR) 10jenkins-bot: [V: 04-1] Change datbase layout [extensions/Math] - 10https://gerrit.wikimedia.org/r/110329 (owner: 10Physikerwelt) [08:36:19] (03CR) 10Legoktm: Link to [[mw:Help:Extension:MassMessage]] at top of the special page (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94696 (owner: 10Legoktm) [08:36:19] https://www.mediawiki.org/wiki/Help:Extension:MassMessage [08:36:27] * legoktm huggles wm-bot  [08:37:47] (03CR) 10Yuvipanda: "I asked Yair at https://en.wikipedia.org/w/index.php?title=User_talk:Yair_rand&diff=593087585&oldid=586268861. Since he specifically prov" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [08:42:43] (03CR) 10Nemo bis: "Steven is throwing -2 like candies lately, so the labels he attaches to his comments can probably be safely ignored. I also propose to ign" [core] - 10https://gerrit.wikimedia.org/r/110279 (owner: 10Bartosz Dziewoński) [08:53:33] legoktm: thanks a lot for https://gerrit.wikimedia.org/r/#/c/108329/ :) [08:53:51] np, thanks for the patch! [08:54:17] hopefully Japanese wikis finally will be able to enjoy mentions. [08:56:07] legoktm: so, when I get a 'warn' response from abusefilter, just straight up submitting the edit again should work, right? [08:56:13] I don't need to do anything... [08:56:15] yuvipanda: yes [08:56:24] unless warn + disallow is set [08:56:29] legoktm: hmm, doesn't seem to work for me, I just keep getting rejected :( [08:56:43] is it the same exact edit? [08:56:55] legoktm: yup [08:57:19] :/ [08:57:33] how much time lag in between edits? [08:57:49] legoktm: not much [08:57:50] legoktm: well [08:57:55] legoktm: enough for it to display the message [08:57:57] few seconds? [08:58:02] legoktm: and for me to click 'save' again [08:58:04] legoktm: yeah definitely [08:58:16] legoktm: look at https://test.wikipedia.org/wiki/Special:AbuseLog [08:58:21] legoktm: first 3 [08:58:23] are me [08:58:41] > Warning: This filter was automatically disabled as a safety measure. It reached the limit of matching more than 5.00% of actions. [08:59:13] legoktm: but it still warns me [08:59:15] yuvipanda: the warnings are saved in your session [08:59:23] make sure the same session is being used? [08:59:49] (03PS12) 10Prtksxna: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 [08:59:51] legoktm: how is a 'session' identified? cookies? [09:00:04] dunno, AF is just putting it in $_SESSION [09:00:24] legoktm: Added the feature flag and one other dependency that yuvipanda pointed out [09:01:00] legoktm: ugh, I wonder how I can find out... [09:01:06] another extension o.O [09:01:20] legoktm: also, Captchas work when I submit them, and I suppose they use $_SESSION too [09:01:34] I have no clue how captchas are done [09:01:37] legoktm: it depends on TextExtracts and PageImages. they used to be part of MobileFrontend but were ripped out by max [09:01:44] (the patch, that is) [09:02:04] yeah, I'm excited for someone ripping out Nearby too :D [09:03:30] $wgCaptchaStorageClass = 'CaptchaCacheStore'; [09:03:31] legoktm: yeah that as well [09:03:37] yuvipanda: wmf stores captchas in memcache [09:03:48] legoktm: hmm, so unrelated [09:04:06] afair, sessions are cookie based [09:04:18] are you updating your cookies after every request? [09:04:26] legoktm: I don't know. let me find out [09:07:38] (03PS13) 10Prtksxna: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 [09:11:14] (03CR) 10Prtksxna: Add JS/CSS for the new NavigationPopups (0310 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [09:11:18] yuvipanda: I'm gonna sleep now, it's 1am. I'm guessing you're just saving the cookies upon login and then not updating them for every request [09:11:48] legoktm: I am not even doing login :P [09:11:53] legoktm: yeah, I'll figure something out :) [09:11:54] good night! [09:13:03] (03CR) 10Raimond Spekking: "translatewiki.net will ignore these Wikipedia centric "Terms of Use" messages for now: https://gerrit.wikimedia.org/r/110332" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105873 (owner: 10Bsitu) [09:16:02] (03PS2) 10Hashar: Add Nemo_bis to jenkins trusted users [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110202 (owner: 10Nemo bis) [09:16:24] (03CR) 10Hashar: [C: 032] "Added a comment next to email address so we know it belong to Nemo Bis." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110202 (owner: 10Nemo bis) [09:17:49] (03Merged) 10jenkins-bot: Add Nemo_bis to jenkins trusted users [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110202 (owner: 10Nemo bis) [09:18:28] (03CR) 10Hashar: "deployed" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110202 (owner: 10Nemo bis) [09:23:31] (03CR) 10Reedy: "But it's valentines day soon!!!" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/104789 (owner: 10Legoktm) [09:26:16] (03CR) 10Peachey88: "Reedy, bug 60611" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/104789 (owner: 10Legoktm) [09:34:21] hashar: I'm trying to understand a general principle in the continuous integration config: why do some jobs have a -HEAD variant, and another variant that tests all files regardless of newness? A good example would be puppet-validate vs. pplint-HEAD, in macro.yaml... [09:34:35] No worries if you're busy [09:34:37] awight: tl;dr; that is a mess :-] [09:34:44] (03CR) 10Aklapper: "AalekhN: Please do not add "Please review" comments one minute after attaching a new patchset. The main purpose of Gerrit is reviewing pat" [core] - 10https://gerrit.wikimedia.org/r/106625 (owner: 10AalekhN) [09:34:53] awight: basically phpcs is very slow so we only run PHP_CodeSniffer on files that have been changed in head [09:35:01] same for puppet parser validate [09:35:11] that is a bit of a mess though [09:35:19] hashar: that seems like the right thing to do in any case... when would we want to do the exhaustive thing? [09:35:43] awight: I am not sure, maybe on gating to make sure everything is correct [09:35:50] or after merge to warn about possible regression [09:36:13] but if we get changed file passing (by validating changes in HEAD) I don't think we would ever have to check all files [09:36:24] like if file A is valid in repo and you change file B [09:36:27] you only need to lint B [09:36:36] A is guarantee to still be correct [09:36:47] so when gating we only care about linting B [09:36:54] I think so [09:37:33] At least, if there are filetypes where some weird dependency thing makes this not true, we should surface that by having a special -EXHAUSTIVE variant, if that makes sense... [09:37:53] anyway, thanks that helps me understand what's going on. [09:38:04] the jobs are really a mess [09:38:04] (03PS1) 10AndyRussG: Refactor logic for course-related redundant data [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110334 [09:38:20] awight: if you have any idea/proposal I will be more than happy to help [09:38:35] hashar: Maybe they are a mess, but I find it inspiring. [09:39:16] awight: yeah I try to get tests to run as fast as possible :-] [09:39:19] It's a nice DSL, at least, beats the shit out of the Makefiles I'm used to [09:39:39] the Jenkins Job Builder DSL ? [09:39:51] yeah, zuul more so perhaps ;) [09:39:55] I love it but there is a few drawbacks [09:40:08] if you change a job-template, you end up having to refresh all the jobs [09:40:13] which is painfully long [09:40:31] fwiw, I'm trying to plan this https://www.mediawiki.org/wiki/RFC/Workflow [09:40:38] for some job-templates, I migrated the shell snippets to plain shell files known as "slave-scripts" [09:40:44] they are in integration/jenkins.git under /bin [09:40:57] so we can change the shell script there, deploy it on slaves and bam all jobs start using it [09:41:04] hashar: yeah the generation step seems clunky [09:41:19] ideally I should migrate that under puppet [09:41:29] so whenever a JJB change is merged, we get puppet to refresh the jobs [09:41:34] but I am paranoid :-] [09:41:43] slave-scripts thing is interesting, are they always files? [09:41:52] yup [09:41:58] !gitweb integration/jenkins [09:41:58] https://git.wikimedia.org/summary/?r=integration/jenkins [09:42:00] I thought I saw some inline shell.... [09:42:13] https://git.wikimedia.org/tree/integration%2Fjenkins/master/bin [09:42:35] https://git.wikimedia.org/blob/integration%2Fjenkins/master/bin%2Fmw-install-sqlite.sh takes care of installing MediaWiki with a sqlite backend [09:42:58] (03CR) 10AndyRussG: "Seems to work, still needs a bit more verifying, I think." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110334 (owner: 10AndyRussG) [09:43:18] awight: honestly, I should write doc for all of that. But I have no idea where to start :( [09:43:26] seems like there should be a nice way to represent those slave scripts / xargs call in yaml... [09:43:44] although the explicit thing is fine as well [09:44:32] hashar: A good place to start is a doc with stubs like "jobs are a mess" :p [09:44:39] hehe [09:44:45] then there is a place for your thoughts to crystallize... [09:44:46] I am very bad at writing doc :( [09:45:06] which doesn't help in getting more people involved unfrotunately [09:45:56] if you're not getting enough participation, I think the culprit is that you're doing too much work ;) [09:46:01] Try slacking on the job. [09:46:25] some minor changes are being made by other folks now [09:46:31] so that is already an improvement [09:46:37] and I spend less time debugging jobs failling [09:46:48] woohoo! [09:46:49] legoktm: yeah, think it was just a cookie issue :) seems to work now [09:46:58] what thing I hate, is that developers have to update jenkins jobs whenever they want to create new tests [09:47:10] unlike travis in which it is scaled out to the software repository [09:47:11] hashar: I did have some difficulty installing jenkins... [09:47:17] aka developers can define whatever they want to be running [09:47:31] The jobs require a lot of jenkins config which is perhaps not documented [09:47:39] like master/slave stuff... [09:47:58] yeah you need a few plugins [09:48:05] did that... [09:48:19] I'll give it more effort and let you know what happens. [09:48:55] This is perverse, but a vagrant role would help a lot [09:49:05] I think someone did that already [09:49:08] OH [09:49:10] k, thx [09:49:21] Merljin (not sure about spelling) [09:49:37] he did write a vagrant / shell script to setup Gerrit/Jenkins/Zuul and load the configurations as well [09:49:38] iirc [09:50:09] I don't see anything in the mediawiki/vagrant repo [09:50:18] that was on github maybe [09:50:22] I am trying to find the link [09:50:23] hmm k [09:51:18] awight: http://lists.wikimedia.org/pipermail/wikitech-l/2012-December/065088.html [09:51:20] \O/ [09:51:36] and https://github.com/valhallasw/wikimedia-mkjenkins [09:53:06] That's a great start. Maybe I will pick up on that and pretend I'm doing something useful [09:53:16] (03CR) 10Siebrand: "Eventually, only something like https://gerrit.wikimedia.org/r/#/c/98078/ will properly fix this, by allowing great generic messages in th" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105873 (owner: 10Bsitu) [09:55:17] awight: added doc at https://www.mediawiki.org/wiki/Continuous_integration/Virtual_Machine [09:55:22] I never tried it myself :( [09:57:19] (03CR) 10Siebrand: [C: 032] Link to [[mw:Help:Extension:MassMessage]] at top of the special page [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94696 (owner: 10Legoktm) [09:57:19] https://www.mediawiki.org/wiki/Help:Extension:MassMessage [09:57:28] (03Merged) 10jenkins-bot: Link to [[mw:Help:Extension:MassMessage]] at top of the special page [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94696 (owner: 10Legoktm) [09:57:28] https://www.mediawiki.org/wiki/Help:Extension:MassMessage [09:58:01] hashar: Merlijn's code is pretty succinct, I think it will be easy to massage into our vagrant-puppet. After increasing the VM ram to a few GBs :/ [09:58:32] hehe [09:58:43] he might be interested in helping out [09:58:49] mind you, I never used our vagrant box :-( [09:58:51] hashar: Yeah I'd also like help improve the DRYness, so we don't have to touch jjb-config when adding zuul tasks [09:59:06] (03CR) 10Siebrand: [C: 031] "L10n/i18n reviewed." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 (owner: 10Legoktm) [09:59:15] I think the key there might be to expand the library of job templates [09:59:15] awight: they serve different purposes though [09:59:18] jjb configuring the jobs [09:59:29] zuul defining what jobs an event will trigger [10:01:07] hashar: Err, I'm still looking for the properly parallel term-- job templates and project templates... [10:01:37] the project templating system in Zuul is not very nice since we have to copy paste [10:01:50] could probably generate them all by simply iterating a list [10:02:15] I think the check vs test thing should be more rigid as well [10:02:26] like, jobs should be annotate with "safeness" [10:02:54] that might get rid of a lot of repetition... [10:03:45] ideally, we wouldn't have to specify each pipeline, instead we define what jobs are associated with a project, and the pipelines can be inferred. [10:06:01] This is another spurious thought: perhaps there is a nice way to consolidate the configuration for each project. A bad idea but illustrative example would be, there is a .integration.yaml file in each repo which describes its CI [10:06:24] ... which would bring together jjb and zuul config [10:07:36] Also not a good idea, but in the worst-case scenario we could even generate the zuul and jjb-config from this file. [10:08:17] that would be crazy :-] [10:08:25] (03CR) 10Siebrand: Fix the i18n source string for the chunked preference (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 (owner: 10Gilles) [10:08:33] it would also be kinda slick [10:09:09] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87183 (owner: 10Legoktm) [10:10:08] awight: here is an example of jobs being added at OpenStack https://review.openstack.org/#/c/65140/ [10:10:53] I guess they would be interested in having a wrapper around both Zuul and JJB config [10:12:49] hashar: there are some half-assed things going on there... [10:13:06] although, my first response is that I like everything but their CR tool :p [10:13:20] ahahah [10:13:40] well known to not work. [10:13:45] the good news is that we having a discussion ongoing to review our project management tools [10:13:52] (ie mingle / trello / bugzilla ...) [10:14:03] and one of them (phabricator) might replace Gerrit entirely hehe [10:14:35] baaargh. [10:14:56] It sounded nice after reading the post-postmodern product literature... [10:15:05] but then I looked at the code. And tried to install it. [10:15:21] apparently it has improved a lot over the last few months [10:15:26] AFAICT, they are actually having trouble launching their SaaS business cos the shit is so bad [10:15:34] I bet... [10:15:47] 2 years or so ago, we rejected phabricator because it could not fit our workflow (pre commit review) [10:15:47] There is no way they could run even multiple instances the way things are now! [10:16:05] well would install our own copy I guess [10:16:21] sure... I looked into the hosted thing cos it was so hard to install [10:16:23] gi11es is probably going to push for it [10:16:42] We should really have some people working in it to test the waters [10:16:52] (03CR) 10Siebrand: "Removing myself as reviewer. This is not in my field of expertise." [core] - 10https://gerrit.wikimedia.org/r/107979 (owner: 10Eranroz) [10:18:00] lol there is totally a bug in that openstack patch [10:18:11] layout.yaml line 414 [10:18:13] robla sounded interested in trying it out as a replacement for bugzilla first [10:18:22] THAT sounds productive [10:18:22] (03CR) 10Siebrand: "Thanks, Sam. Removing myself as reviewer in the meantime." [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/110142 (owner: 10Reedy) [10:18:32] I don't think anyone has an investment in bugzilla... [10:18:42] awight: if you have a lauchpad account you can add a comment :-] [10:19:05] * awight creates another troll account [10:19:11] haha [10:20:01] fabrice has cold feet when it comes to diverging from the norm workflow-wise, but honestly I'd rather try it all out in the scope of our team and then showing everyone else how we're using it (phabricator) [10:20:38] that also allows us to work our way towards the missing parts for a gerrit replacement in our corner [10:21:03] Yes. I like [10:21:04] then show the real deal with a live project to everyone else in the foundation, instead of comparing things in theory [10:21:09] Yep. [10:21:12] JeroenDeDauw from the Wikidata team might be interested in joining the phpabricator effort [10:21:21] he has set it up on labs earlier [10:21:27] and wanted to push for it instead of Gerrit [10:21:41] I don't even want to say it, but we might be much better off writing a CR tool in-house. [10:21:53] There is not much of an ecosystem... [10:22:53] we could trick OpenStack to do it for us :-D [10:22:56] * awight blackjacks self to sleep [10:22:57] but that would be django based hehe [10:23:08] * awight washes eyeballs first [10:23:11] see you awight ! have nice dreams [10:23:16] ciao [10:26:55] (03PS9) 10Adamw: Basic state machinery [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/107307 [10:27:05] (03PS6) 10Hashar: default entry point for extension + sqlite db update [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/104508 [10:27:10] (03CR) 10jenkins-bot: [V: 04-1] default entry point for extension + sqlite db update [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/104508 (owner: 10Hashar) [10:27:58] (03CR) 10Hashar: "TwoFactorUserTest::testValidTokens" [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/104508 (owner: 10Hashar) [10:28:49] (03PS1) 10Adamw: add Workflow extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/110337 [10:31:06] (03PS1) 10Adamw: Add project for mwext-Workflow [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110338 [10:34:24] (03Draft3) 10Hashar: allow reporting for postmerge pipeline [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/107252 [10:34:43] (03CR) 10Hashar: [C: 032] allow reporting for postmerge pipeline [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/107252 (owner: 10Hashar) [10:34:48] (03Merged) 10jenkins-bot: allow reporting for postmerge pipeline [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/107252 (owner: 10Hashar) [10:52:34] (03PS8) 10Physikerwelt: WIP: Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 [11:19:43] (03PS1) 10Nikerabbit: Parser functions now format numbers according to page language [core] - 10https://gerrit.wikimedia.org/r/110342 [11:20:44] (03CR) 10Nikerabbit: "Q1: Why is getFunctionLang not deprecated?" [core] - 10https://gerrit.wikimedia.org/r/110342 (owner: 10Nikerabbit) [11:33:30] (03PS1) 10Pastakhov: add class BaseHooks [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/110343 [11:38:18] (03CR) 10Pastakhov: [C: 032 V: 032] add class BaseHooks [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/110343 (owner: 10Pastakhov) [11:41:53] (03PS1) 10AndyRussG: Maintenance script for repairing redundant data [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110344 [11:47:13] (03PS1) 10Pastakhov: initial commit [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/110346 [11:48:30] (03CR) 10Pastakhov: [C: 032 V: 032] initial commit [extensions/PhpTagsFunctions] - 10https://gerrit.wikimedia.org/r/110346 (owner: 10Pastakhov) [11:52:52] (03PS1) 10Helder.wiki: Fire hook "LivePreviewPrepare" [core] - 10https://gerrit.wikimedia.org/r/110347 [11:54:18] (03PS2) 10Helder.wiki: Fire hook "LivePreviewPrepare" [core] - 10https://gerrit.wikimedia.org/r/110347 [11:56:28] (03PS1) 10Zfilipin: ci and default profiles are no longer needed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110348 [12:03:23] (03PS2) 10Pastakhov: Add jobs for mw/ext/PhpTags and mw/ext/PhpTagsFunctions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/110164 [12:04:24] (03PS1) 10Zfilipin: cucumber.yml is no longer needed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110350 [12:04:46] (03CR) 10Bartosz Dziewoński: [C: 032] Revert "Remove styles for #mw-createaccount-join" [core] - 10https://gerrit.wikimedia.org/r/110316 (owner: 10Spage) [12:06:38] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Does not merge." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87183 (owner: 10Legoktm) [12:08:35] (03Merged) 10jenkins-bot: Revert "Remove styles for #mw-createaccount-join" [core] - 10https://gerrit.wikimedia.org/r/110316 (owner: 10Spage) [12:12:51] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I think this needs more description. How does this interact with regular categories? Can you add pages to the "catquery" ones? Does that a" [core] - 10https://gerrit.wikimedia.org/r/109853 (owner: 10Yurik) [12:15:29] (03CR) 10Bartosz Dziewoński: "Needs rebase due to https://gerrit.wikimedia.org/r/#/c/110316/" [core] - 10https://gerrit.wikimedia.org/r/104011 (owner: 10Spage) [12:20:02] so, I've just merged a change, it appeared in beta. i18n had been approved, worked on my vagrant vm, but on beta I see: [12:20:04] multimediaviewer-fileusage-local-section: Parse error at position 0 in input: [12:20:30] that's just a plain string that needs to be translated, no dynamic part in it [12:20:41] has anyone run into something similar before? [12:21:07] MatmaRex: thedj: do you know what is the appropriated method to get the current text from [12:21:08] https://en.wikipedia.org/wiki/Special:MyPage/common.js?action=edit [12:21:17] if CodeEditor is enabled and the user already typed something? [12:21:38] (I'm trying to figure out how to fix the ajaxPreview) [12:21:47] https://en.wikipedia.org/w/index.php?title=User_talk:Js/ajaxPreview.js#Diff_doesn.27t_work_on_pages_where_CodeEditor_is_enabled [12:21:49] (03CR) 10Nik: [C: 032 V: 032] Fixed whitespace in license text. Fixed global ExtensionCredits variable. Fixed autoloading publisher class. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/109072 (owner: 10Nik) [12:21:55] i don't, sorry [12:22:26] (03CR) 10Alexander.lehmann: [C: 032 V: 032] Replaced manual URL generation by retrieving from API. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/109075 (owner: 10Nik) [12:26:54] (03CR) 10Bartosz Dziewoński: "Per the comments, I'll kill the global and set the threshold to 180 days (same as $wgCookieExpiration)." [core] - 10https://gerrit.wikimedia.org/r/110279 (owner: 10Bartosz Dziewoński) [12:38:55] (03PS2) 10Bartosz Dziewoński: "Keep me logged in" on Special:UserLogin should sometimes state duration [core] - 10https://gerrit.wikimedia.org/r/110279 [12:38:59] answering my own question: seems like it was because we were using $.fn.msg() which doesn't seem to be used much (the rest of our code uses mw.message) and breaks for whatever reason beta [12:39:07] *on beta [12:41:13] !gitweb integration/jenkins-job-builder-config [12:41:13] https://git.wikimedia.org/summary/?r=integration/jenkins-job-builder-config [13:17:15] (03CR) 10Nikerabbit: [C: 04-1] Fix the i18n source string for the chunked preference (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 (owner: 10Gilles) [13:28:51] MatmaRex: FYI: I found a way to fix the ajaxPreview when CodeEditor is enabled: https://en.wikipedia.org/w/index.php?diff=593114045 [13:29:35] (03CR) 10Liangent: "The patch itself, which is against an older version of Extension:Math, works in the expected way to fix an issue in that older code. A new" [extensions/Math] - 10https://gerrit.wikimedia.org/r/87519 (owner: 10Liangent) [13:33:52] (03CR) 10Nikerabbit: [C: 04-1] Uninstall GetHumanTimestamp hook for testing core [core] - 10https://gerrit.wikimedia.org/r/99349 (owner: 10saper) [13:42:41] (03Abandoned) 10Addshore: Add assertions in FileBackendTest [core] - 10https://gerrit.wikimedia.org/r/109472 (owner: 10Addshore) [13:52:24] (03CR) 10Frédéric Wang: "@Liangent: I'm not sure which versions you are refering by older and newer. My understanding is that there is currently one dev branch tha" [extensions/Math] - 10https://gerrit.wikimedia.org/r/87519 (owner: 10Liangent) [13:52:42] (03CR) 10Matthias Mullie: "SG: About #1: We can't bind to the node directly. Well, we can, but then when the flyout opens, tipsy will clone those nodes and append th" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu) [14:04:12] (03CR) 10Phuedx: [C: 032] Fix wrapping of CTA buttons [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110313 (owner: 10Mattflaschen) [14:04:15] (03Merged) 10jenkins-bot: Fix wrapping of CTA buttons [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110313 (owner: 10Mattflaschen) [14:10:16] (03CR) 10Yuvipanda: "Yair is fine with the licensing terms: https://en.wikipedia.org/w/index.php?title=User_talk:Yair_rand&diff=593114449&oldid=593087585" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [14:10:34] yuvipanda: \o/ [14:15:39] (03CR) 10MarkAHershberger: [C: 032] Special:PrefixIndex omits stripprefix=1 for "Next page" link [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110248 (owner: 10Se4598) [14:17:41] Should talk to Yair once [14:17:55] (03PS1) 10Yaron Koren: Simplified call to SMW subobject code, based on recommendation from MWJames [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/110367 [14:18:50] (03CR) 10Yaron Koren: [C: 032 V: 032] Simplified call to SMW subobject code, based on recommendation from MWJames [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/110367 (owner: 10Yaron Koren) [14:27:23] (03CR) 10Brian Wolff: Fix the i18n source string for the chunked preference (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 (owner: 10Gilles) [14:27:49] prtksxna: \o/ [14:27:53] prtksxna: yair is okay with it. [14:28:21] as expected [14:28:22] so [14:29:44] prtksxna: come to #wikimedia-tech? [14:29:46] Yair is there [14:33:14] (03PS4) 10Manybubbles: Make document building process more extensible [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108952 [14:33:29] (03CR) 10Manybubbles: [C: 04-1] "Rebased but not yet tested." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108952 (owner: 10Manybubbles) [14:39:13] (03CR) 10Liangent: "I was considering current master as "older", and 2.0 as "newer". I didn't look at branch remotes/origin/dev." [extensions/Math] - 10https://gerrit.wikimedia.org/r/87519 (owner: 10Liangent) [14:46:54] (03PS2) 10Aaron Schulz: Fixed getReaderIndex() handling of $group [core] - 10https://gerrit.wikimedia.org/r/107610 [14:50:01] (03CR) 10Manybubbles: [C: 032] ci and default profiles are no longer needed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110348 (owner: 10Zfilipin) [14:50:05] (03Merged) 10jenkins-bot: ci and default profiles are no longer needed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110348 (owner: 10Zfilipin) [14:50:55] hashar: you are mistaken, I never set up a phpabricator and definitly did not push it intead of gerrit [14:56:28] JeroenDeDauw: sorry, my memory deserves me so :( [14:58:06] JeroenDeDauw: apparently that was marktraceur and ori [14:58:29] (03CR) 10Aaron Schulz: Defer af_throttled query to post-commit auto-commit mode (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/110253 (owner: 10Aaron Schulz) [15:01:36] (03CR) 10Aaron Schulz: [WIP] Made ActiveUsers use querycache and do staggered updates on view (032 comments) [core] - 10https://gerrit.wikimedia.org/r/110299 (owner: 10Aaron Schulz) [15:15:22] (03CR) 10Matthias Mullie: [C: 04-1] "Some occurences of Function.bind, and a rally minor reservation about duplicate code - looks good otherwise" (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 (owner: 10SG) [15:18:26] (03Merged) 10jenkins-bot: Special:PrefixIndex omits stripprefix=1 for "Next page" link [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110248 (owner: 10Se4598) [15:33:17] (03PS1) 10Phuedx: Stop logging with the GettingStartedOnRedirect schema. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110375 [15:36:29] (03PS1) 10Matthias Mullie: Fix infinite scroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110376 [15:37:10] (03PS1) 10Bartosz Dziewoński: mediawiki.util: Don't hardcode selectors in updateTooltipAccessKeys if possible [core] - 10https://gerrit.wikimedia.org/r/110377 [15:37:21] (03CR) 10Matthias Mullie: Add jshint and clean up files which fail its validation (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110107 (owner: 10SG) [15:40:34] (03CR) 10Jack Phoenix: [C: 031] mediawiki.util: Don't hardcode selectors in updateTooltipAccessKeys if possible [core] - 10https://gerrit.wikimedia.org/r/110377 (owner: 10Bartosz Dziewoński) [15:41:06] (03PS1) 10Chiborg: Remove permission info from JSON [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/110378 [15:41:08] (03PS2) 10Bartosz Dziewoński: mediawiki.util: Don't hardcode selectors in updateTooltipAccessKeys if possible [core] - 10https://gerrit.wikimedia.org/r/110377 [15:45:24] (03PS6) 10Inchikutty: Embedding Static Map to UploadWizard [OPW Round 7 project part 1] [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 [15:51:24] (03PS1) 10Manybubbles: Force new version of mediawiki-selenium [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110383 [16:00:15] (03CR) 10Zfilipin: Force new version of mediawiki-selenium (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110383 (owner: 10Manybubbles) [16:02:13] hashar: did you check on the gems? [16:02:16] (03CR) 10Manybubbles: Force new version of mediawiki-selenium (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110383 (owner: 10Manybubbles) [16:02:33] (03PS7) 10Inchikutty: Embedding Static Map to UploadWizard [OPW Round 7 project part 1] [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 [16:11:29] (03PS1) 10Hashar: make jslint voting by default [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110385 [16:12:00] matanya: I havent [16:12:11] matanya: I should talk to zeljkof about it first [16:12:26] ok, thanks [16:20:17] (03CR) 10Matthias Mullie: [C: 032] More fix to 'topic/post edited' tipsy link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109009 (owner: 10Bsitu) [16:20:27] (03Merged) 10jenkins-bot: More fix to 'topic/post edited' tipsy link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109009 (owner: 10Bsitu) [16:22:18] (03CR) 10Chad: "FWIW, we've also got a bug request to sort articles by how recent they are. So I think the concept could be extended to lots of sorts in t" [core] - 10https://gerrit.wikimedia.org/r/109669 (owner: 10Manybubbles) [16:31:16] (03CR) 10Anomie: [C: 032] treat true as empty string, skip false in xml format [core] - 10https://gerrit.wikimedia.org/r/108315 (owner: 10Umherirrender) [16:33:43] (03CR) 10Addshore: Add diff view of changes to board header (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 (owner: 10Bsitu) [16:35:56] (03PS2) 10Aaron Schulz: [WIP] Made ActiveUsers use querycache and do staggered updates on view [core] - 10https://gerrit.wikimedia.org/r/110299 [16:36:10] What would be the current best way to tackle https://bugzilla.wikimedia.org/show_bug.cgi?id=34447 [16:36:11] 1) Fix Extension:SignupAPI [16:36:12] 2) Create a new RFC [16:36:12] 3) Modify core files and submit a patch [16:37:19] (03PS1) 10Addshore: Remove unused uses in files touched by CI:I363b6bd9e [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110391 [16:37:22] (03CR) 10jenkins-bot: [V: 04-1] Remove unused uses in files touched by CI:I363b6bd9e [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110391 (owner: 10Addshore) [16:37:30] akshayagarwal: i'd say it'd be better to do it in core [16:37:34] <^d> +1 [16:37:36] yes [16:37:45] !e SignupAPI | bawolff [16:37:45] bawolff: https://www.mediawiki.org/wiki/Extension:SignupAPI [16:37:49] i don't think an rfc is needed, this is small enough to just do it :) [16:39:03] great, any pointers on how to go about editing the core files? [16:39:04] Best approach - do it, if people complain then write an rfc [16:39:21] easier to be bold then to get consensus [16:39:51] bawolff: makes sense! [16:40:19] akshayagarwal: If you have a git checkout of mediawiki/core, you can just edit the files ( includes/specials/SpecialUserlogin.php ) [16:40:26] and submit patches via git review [16:41:18] (03PS1) 10Manybubbles: Shorten the timeout on update tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110392 [16:42:08] bawolff: hmm…. would that require me to be added to the committers list ( to checkout with write permissions and for me to submit patches) [16:42:36] akshayagarwal: Everyone is allowed to send patches (you have to register an account on gerrit) [16:42:58] We restrict who can "approve" patches, but you don't need any special permission to send a patch [16:43:37] I guess I should mention that ShoutWiki's had a "check username availability (and that passwords match)" feature for a while :) implemented as a part of [[mw:Extension:NewSignupPage]] (that version -- 0.5 -- of the extension isn't yet on git.wm.o but I'm sure that pushing it there won't be a problem) [16:43:37] https://www.mediawiki.org/wiki/Extension:NewSignupPage [16:43:47] (woo, a bot that is actually helpful!) [16:45:45] (03CR) 10Chad: [C: 032] Shorten the timeout on update tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110392 (owner: 10Manybubbles) [16:45:50] (03Merged) 10jenkins-bot: Shorten the timeout on update tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110392 (owner: 10Manybubbles) [16:46:53] (03PS2) 10Physikerwelt: Change datbase layout [extensions/Math] - 10https://gerrit.wikimedia.org/r/110329 [16:47:02] (03CR) 10jenkins-bot: [V: 04-1] Change datbase layout [extensions/Math] - 10https://gerrit.wikimedia.org/r/110329 (owner: 10Physikerwelt) [16:48:08] akshayagarwal: Anyways, if you have an account on gerrit (you can sign up at wikitech.wikimedia.org) and have uploaded your private key in gerrit preferences (At gerrit.wikimedia.org), you should be able to download the repo from ssh://@gerrit.wikimedia.org:29418/mediawiki/core.git and you upload patches with either git review (need to download separately), or a special git... [16:48:09] ...push command (see gerrit help for that one) [16:48:31] !developeraccess [16:48:38] no key? we use to have one [16:48:42] [[developer access]] [16:48:42] https://www.mediawiki.org/wiki/developer_access [16:49:17] ashley: that looks promising! I checked it out on the signup page on shoutwiki.com and it seems to do most of the stuff that Extension:SignupAPI used to do plus many other things, can this be deployed on the WMF sites (wikipedia primarily) mentioned in the bug? [16:49:55] ashley: I think that should solve the bug straight away and the extension is already stable [16:49:57] (03PS3) 10Physikerwelt: Change datbase layout [extensions/Math] - 10https://gerrit.wikimedia.org/r/110329 [16:50:10] Deployment requires making a sacrafice to greg-g and invoking black magic [16:50:23] Read that as: Its difficult to convince people to deploy new extensions to wikipedia [16:50:24] most likely not as-is, I'd guess WMF would want to see some parts of it refactored/hidden behind config vars, but of course I'd be happy if people would be interested in it -- enough to consider deploying it on WMF sites :-) [16:50:29] you need to push people hard [16:51:11] akshayagarwal: you might want to also check in with the e3/whatever that team is calling itself now a days. as far as i know they are perpetually redesigning the log in page [16:51:58] mmmm, delicious bikeshedding [16:52:06] bawolff: yeah, I was in touch with them until around a year back when they were specifically working on creating a new extension to do most of the things done by Extension:SignupAPI [16:52:29] bawolff: but along with the refactoring and other functionalities which were needed [16:52:55] bawolff: know anyone within that team whom I can ping ? [16:55:26] I think Steven Walling has an interest in the login form [16:56:28] thanks bawolff ! [16:58:24] so overall it seems if something (small) can be fixed with a (small) patch in the core and with a (small) review, thats the way to go for quick deployment? [16:59:20] (03CR) 10Physikerwelt: "This change is an improvement with regard to the usage of $wgContentLang only. However, it still uses the amourMath function that can be r" [extensions/Math] - 10https://gerrit.wikimedia.org/r/87519 (owner: 10Liangent) [16:59:37] akshayagarwal: Yes. Although sometimes getting things reviewed in core can face delays too. If your patch lingers in gerrit without review, don't be afraid to ask for people to review [16:59:55] (03PS1) 10Chad: Space out search results just ever so slightly [core] - 10https://gerrit.wikimedia.org/r/110395 [17:00:09] akshayagarwal: quick deployment? is that something related to our glorious future with MediaWiki 2.0, world peace and whatnot? :p [17:00:46] ashley: lolz [17:00:58] ashley: Well world peace is a low hanging fruit, might as well start there [17:01:19] ;) [17:03:49] (03CR) 10Physikerwelt: Rename some global variables that violate the naming convention (035 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 (owner: 10Physikerwelt) [17:03:55] (03PS5) 10Physikerwelt: Rename some global variables that violate the naming convention [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 [17:04:45] (03CR) 10CSteipp: "I'm not opposed to the change. It is more strict about what it allows in the css, and doesn't weaken the current filtering. So security lo" [core] - 10https://gerrit.wikimedia.org/r/87648 (owner: 10Lambdafu) [17:09:47] (03CR) 10Frédéric Wang: "I was asking that because I see" [extensions/Math] - 10https://gerrit.wikimedia.org/r/109488 (owner: 10Physikerwelt) [17:11:10] (03CR) 10Bartosz Dziewoński: [C: 032] Space out search results just ever so slightly [core] - 10https://gerrit.wikimedia.org/r/110395 (owner: 10Chad) [17:12:18] (03PS6) 10Physikerwelt: Rename some global variables that violate the naming convention [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 [17:12:55] (03CR) 10UltrasonicNXT: "Re logFormatter, absolutely, this is really odd! I was considering using seeing if the comments one was installed and using that, and if n" [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/110212 (owner: 10UltrasonicNXT) [17:16:58] <^d> MatmaRex: Yay spacing! [17:17:09] yay [17:17:13] who broke jenkins again [17:17:17] l10n-update time? [17:18:17] <^d> lotsa stuff queued. [17:18:28] <^d> damn qunit again [17:19:27] <^d> Where's hashar or Krinkle|detached when you need them? :p [17:19:36] <^d> What'd you guys do the other day to fix this? [17:20:32] fix what? [17:20:46] ^d: [17:20:52] <^d> qunit gets stuck. [17:21:04] huh [17:21:11] <^d> https://integration.wikimedia.org/zuul/ [17:21:18] <^d> Most of the "queued" stuff is qunit. [17:21:42] i have no idea, haven't seen this before [17:22:30] <^d> It happened like thursday or friday during the architecture pow wow. [17:24:15] restart everything? :D [17:24:31] <^d> shutdown -r now [17:27:32] (03CR) 10Helder.wiki: "This is related to bug 35071." [core] - 10https://gerrit.wikimedia.org/r/95764 (owner: 10Umherirrender) [17:30:21] (03CR) 10SG: [C: 031] Fix infinite scroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110376 (owner: 10Matthias Mullie) [17:32:48] (03PS2) 10UltrasonicNXT: Add links to forum logs [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/110212 [17:37:52] [17:39:06] (03CR) 10EBernhardson: [C: 032] Fix infinite scroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110376 (owner: 10Matthias Mullie) [17:39:09] (03PS3) 10Helder.wiki: Fire hook "LivePreviewPrepare" [core] - 10https://gerrit.wikimedia.org/r/110347 [17:39:54] (03Merged) 10jenkins-bot: Fix infinite scroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110376 (owner: 10Matthias Mullie) [17:40:17] (03CR) 10jenkins-bot: [V: 04-1] Fire hook "LivePreviewPrepare" [core] - 10https://gerrit.wikimedia.org/r/110347 (owner: 10Helder.wiki) [17:43:14] spage: Could you please take a look at https://gerrit.wikimedia.org/r/#/c/109878/ [17:45:17] anomie: could you have another look at https://gerrit.wikimedia.org/r/#/c/105979/ now? [17:46:52] (03CR) 10Anomie: [C: 032] Add mw.ext.TitleBlacklist.test [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/105979 (owner: 10Jackmcbarn) [17:47:03] thanks! [17:47:36] (03PS1) 10Aaron Schulz: Made UpdateSpecialPages support --list/--only with the callback updates [core] - 10https://gerrit.wikimedia.org/r/110398 [17:47:38] (03Merged) 10jenkins-bot: Add mw.ext.TitleBlacklist.test [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/105979 (owner: 10Jackmcbarn) [17:47:46] Has the issue where jenkins-bot just posts "FAILURE" been resolved? [17:47:53] (03PS1) 10Reedy: Remove extra git branch command, already using checkout -q -b instead [tools/release] - 10https://gerrit.wikimedia.org/r/110399 [17:48:24] (03CR) 10Reedy: [C: 032] Remove extra git branch command, already using checkout -q -b instead [tools/release] - 10https://gerrit.wikimedia.org/r/110399 (owner: 10Reedy) [17:49:08] (03PS8) 10Physikerwelt: Add mathsearch role to vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/108827 [17:49:59] (03CR) 10Chad: [V: 032] Remove extra git branch command, already using checkout -q -b instead [tools/release] - 10https://gerrit.wikimedia.org/r/110399 (owner: 10Reedy) [17:50:05] (03CR) 10BryanDavis: [C: 032] "The problem I was seeing turns out to be a bug related to using Chrome and not any misconfiguration of MW." [vagrant] - 10https://gerrit.wikimedia.org/r/108827 (owner: 10Physikerwelt) [17:50:08] superm401: depends which one. if the one where it randomly claims a change can't be merged, then nope. [17:50:23] https://bugzilla.wikimedia.org/show_bug.cgi?id=53895 [17:50:53] (03CR) 10Mattflaschen: "S's patch (now merged) is https://gerrit.wikimedia.org/r/#/c/110316/2" [core] - 10https://gerrit.wikimedia.org/r/110301 (owner: 10Mattflaschen) [17:51:47] MatmaRex, it literally just posted "FAILURE": https://gerrit.wikimedia.org/r/#/c/110316/2 [17:51:57] How about some constructive criticism, jenkins-bot? [17:52:09] heh [17:52:33] that's funny, but unfortunately i can't help with that [17:52:42] but ^d says there's some bug where qunit jobs hang sometimes [17:52:48] maybe this is related [17:52:56] (03Merged) 10jenkins-bot: Add mathsearch role to vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/108827 (owner: 10Physikerwelt) [17:53:02] waaaaah gerrit git fetch's being slow over https [17:53:10] brion: over ssh too [17:53:18] and there's a bug for this, too [17:53:24] no one who could fix this can reproduce it. :D [17:53:46] :P [17:54:21] yay, now with more .gitreview [17:54:50] Filed as https://bugzilla.wikimedia.org/show_bug.cgi?id=60624 [17:59:55] ^d: could you please check configuration of PhpMaps extension? I have difficulties to clone it on translatewiki.net It asks me over and over for a username and password [18:00:09] (03CR) 10PleaseStand: [C: 04-1] "> For the community, you may want to announce which characters were previously ok, but no longer (\a, \c-\1f, etc)." [core] - 10https://gerrit.wikimedia.org/r/87648 (owner: 10Lambdafu) [18:02:00] <^d> I don't see any such extension. [18:02:37] <^d> The *heck*? [18:02:41] <^d> It's definitely on disk. [18:03:34] <^d> state = hidden [18:03:34] <^d> description = Obsolete -- please remove. [18:04:36] ^d hmmm.. translatewiki.net scripts trys to clone it automatically and breaks then [18:05:00] <^d> Hmm, deleting isn't going to be easy at the moment [18:05:08] <^d> Let's just un-hide it for the time being. [18:05:17] is this the first one with state=hidden? [18:05:30] <^d> I dunno of anyone ever using it before. [18:05:33] <^d> I've used read-only. [18:05:35] <^d> But not hidden. [18:05:51] <^d> Anyway, it's visible again. [18:05:56] (03PS4) 10Physikerwelt: Change database layout [extensions/Math] - 10https://gerrit.wikimedia.org/r/110329 [18:06:04] <^d> Should be able to work. I'll make a note to delete it later. [18:06:24] yes works.thanks for your help [18:06:30] <^d> you're welcome [18:12:23] (03CR) 10Physikerwelt: "Frédéric: MW_MATH_MATHJAX was not enabled by default for MediaWiki. It was part of WMF config. If both changes can be merged at the same t" [extensions/Math] - 10https://gerrit.wikimedia.org/r/109488 (owner: 10Physikerwelt) [18:14:36] (03PS11) 1001tonythomas: Check for CoreParserFunction::urlFunction from array to boolean and return values accordingly to htmlspecialchars() [core] - 10https://gerrit.wikimedia.org/r/107017 [18:15:32] hi ^d do you know if Jenkins or gerrit is hung up? I've had a commit stuck on "Starting gate-and-submit jobs" for over an hour now, been in a meeting. [18:16:56] chrismcmahon: jenkins bot just gave me a +1 fast enough. [18:16:57] <^d> jenkins is. something with qunit. [18:17:09] chrismcmahon: not sure with +2 [18:17:13] <^d> hashar isn't around and Krinkle|detached is |detached. [18:17:22] <^d> I'm not sure what they did last week to fix it. [18:18:17] ^d bummer. This commit is something we've been working on for a long time and it's finally done. of course, it has nothing to do with qunit. [18:18:34] <^d> Yeah, but other things get backed up :\ [18:27:02] (03PS1) 10Se4598: adding se4598 to CREDITS [core] - 10https://gerrit.wikimedia.org/r/110407 [18:27:31] ^: someone wants to merge it? :) [18:28:34] (03PS5) 10Gerrit Patch Uploader: Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 [18:29:04] (03CR) 10Legoktm: [C: 032] adding se4598 to CREDITS [core] - 10https://gerrit.wikimedia.org/r/110407 (owner: 10Se4598) [18:32:38] <^d> chrismcmahon, others: jenkins should be getting unstuck now [18:33:37] (03PS1) 10Se4598: update RELEASE-NOTES-1.22 for bug 60543 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110408 [18:34:35] (03Merged) 10jenkins-bot: treat true as empty string, skip false in xml format [core] - 10https://gerrit.wikimedia.org/r/108315 (owner: 10Umherirrender) [18:35:49] (03Merged) 10jenkins-bot: Space out search results just ever so slightly [core] - 10https://gerrit.wikimedia.org/r/110395 (owner: 10Chad) [18:36:17] (03CR) 10Matthias Mullie: "Nevermind - noticed you already dealt with that in the scroll/refactor patch; which looks good ;)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu) [18:37:18] ^d: https://gerrit.wikimedia.org/r/#/c/107545/ [18:37:46] and https://gerrit.wikimedia.org/r/#/c/107610/ too [18:37:55] (03Merged) 10jenkins-bot: adding se4598 to CREDITS [core] - 10https://gerrit.wikimedia.org/r/110407 (owner: 10Se4598) [18:40:01] (03CR) 10Chad: [C: 032] Use regular slaves for user contribs parent revision queries [core] - 10https://gerrit.wikimedia.org/r/107545 (owner: 10Aaron Schulz) [18:40:50] (03PS2) 10Umherirrender: Unroll array_map in ResourceLoaderFileModule::readStyleFiles [core] - 10https://gerrit.wikimedia.org/r/109956 [18:42:45] (03PS6) 10Legoktm: Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [18:43:19] (03CR) 10Umherirrender: "Patch Set 2: Remove try/catch" [core] - 10https://gerrit.wikimedia.org/r/109956 (owner: 10Umherirrender) [18:43:33] (03CR) 10jenkins-bot: [V: 04-1] Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [18:43:49] physikerwelt, is LaTeXML still Firefox-only? [18:43:59] I'm just wondering re the variable patch. [18:49:20] (03CR) 10Mattflaschen: [C: 04-1] "One more." (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 (owner: 10Physikerwelt) [18:49:58] (03CR) 10Umherirrender: "In my opinion the $par should only be used for main function of a special page like the username on Special:Contributions." [core] - 10https://gerrit.wikimedia.org/r/107979 (owner: 10Eranroz) [18:54:46] (03PS2) 10Lambdafu: Do not crash on invalid codepoint references in style attributes. [core] - 10https://gerrit.wikimedia.org/r/87648 [18:55:17] (03CR) 10Brian Wolff: "Rebase to run unit tests" [core] - 10https://gerrit.wikimedia.org/r/87648 (owner: 10Lambdafu) [18:56:40] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: b5df6a2..9a20fc0 [extensions] - 10https://gerrit.wikimedia.org/r/110415 [18:56:42] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: b5df6a2..9a20fc0 [extensions] - 10https://gerrit.wikimedia.org/r/110415 (owner: 10Jenkins-mwext-sync) [18:56:45] (03Abandoned) 10Manybubbles: Add a sort parameter to SearchEngine and api [core] - 10https://gerrit.wikimedia.org/r/109669 (owner: 10Manybubbles) [19:00:20] (03CR) 10Jack Phoenix: [C: 032 V: 032] Add links to forum logs [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/110212 (owner: 10UltrasonicNXT) [19:01:08] (03CR) 10Aaron Schulz: Make DjVu metadata be stored as serialized PHP array. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99544 (owner: 10Brian Wolff) [19:01:44] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 9a20fc0..92f62d3 [extensions] - 10https://gerrit.wikimedia.org/r/110416 [19:01:46] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 9a20fc0..92f62d3 [extensions] - 10https://gerrit.wikimedia.org/r/110416 (owner: 10Jenkins-mwext-sync) [19:02:07] (03CR) 10Aaron Schulz: [C: 032] Remove vestiges of AdminSettings.php [core] - 10https://gerrit.wikimedia.org/r/110254 (owner: 10Chad) [19:02:29] (03Merged) 10jenkins-bot: Use regular slaves for user contribs parent revision queries [core] - 10https://gerrit.wikimedia.org/r/107545 (owner: 10Aaron Schulz) [19:05:41] (03Merged) 10jenkins-bot: Remove vestiges of AdminSettings.php [core] - 10https://gerrit.wikimedia.org/r/110254 (owner: 10Chad) [19:07:03] (03PS1) 10Chad: Remove unused function acceptListRedirects() [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/110418 [19:07:33] ^d: Is it possible to know what kind of thing is in the Job queue? (maybe using some query on labs?) [19:07:36] Fatal error: Call to a member function getId() on a non-object in /usr/local/apache/common-local/php-1.23wmf11/extensions/EducationProgram/includes/notifications/CourseTalkNotification.php on line 108 [19:09:03] <^d> helderwiki: The jobs are stored in redis, not the database. [19:09:16] <^d> On the cluster we've got maintenance scripts that can look at it. [19:09:27] (03PS1) 10Chad: Remove unused acceptListRedirects() [core] - 10https://gerrit.wikimedia.org/r/110419 [19:10:01] I've seen a few reports of categories not updating (on POrtuguese Wikipedia) but I don't know if there is anything I can do to investigate this on my own [19:10:28] ^d: https://pt.wikipedia.org/wiki/WP:Caf�_dos_programadores#Categorias_n.C3.A3o_atualizadas [19:10:47] and then https://pt.wikipedia.org/wiki/WP:Caf�_dos_programadores#Categoria:Siberia [19:11:08] (03PS3) 10Brian Wolff: Do not crash on invalid codepoint references in style attributes. [core] - 10https://gerrit.wikimedia.org/r/87648 (owner: 10Lambdafu) [19:11:44] <^d> helderwiki: 214 queued refreshLinks jobs. [19:12:44] ^d: is it possible to know which links? [19:13:11] <^d> Not without running them. I just ran 10. [19:13:27] <^d> They all referred to Predefinição:Manutenção/Categorizando_por_assunto [19:13:42] <^d> Same root job. [19:14:36] <^d> They seem to be running fine... [19:14:46] (03CR) 10jenkins-bot: [V: 04-1] Do not crash on invalid codepoint references in style attributes. [core] - 10https://gerrit.wikimedia.org/r/87648 (owner: 10Lambdafu) [19:15:39] (03PS1) 10EBernhardson: No-js tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110421 [19:20:41] ^d: is this something that only peoble with shell access can do? [19:20:51] <^d> Yeah [19:22:56] =/ [19:23:13] <^d> The dummy edit to that template is slowly working its way through the queue. [19:23:26] <^d> I don't know why the category wasn't updating to begin with. [19:23:47] (03PS1) 10CSteipp: SECURITY: Escape all shell arguments [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/110423 [19:24:28] (03CR) 10CSteipp: [C: 032] "already deployed" [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/110423 (owner: 10CSteipp) [19:24:30] (03Merged) 10jenkins-bot: SECURITY: Escape all shell arguments [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/110423 (owner: 10CSteipp) [19:24:51] Reedy: ^ done [19:25:16] (03PS1) 10Reedy: SECURITY: Escape all shell arguments [extensions/PdfHandler] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110424 [19:25:40] (03PS1) 10Reedy: SECURITY: Escape all shell arguments [extensions/PdfHandler] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/110425 [19:25:49] Might aswell do that for ease [19:28:00] (03CR) 10Hoo man: [C: 032] ":) Thanks, this makes these more consistent" [core] - 10https://gerrit.wikimedia.org/r/107017 (owner: 1001tonythomas) [19:28:40] ^d:BTW is there some monitoring graph which shows the number of itens in the job queue each day for a given wiki? [19:29:09] <^d> Not for a given wiki afaik. [19:29:18] <^d> There is https://gdash.wikimedia.org/dashboards/jobq/, I can't remember if that's global or enwiki. [19:31:21] interesting :-) [19:31:33] (03Merged) 10jenkins-bot: Check for CoreParserFunction::urlFunction from array to boolean and return values accordingly to htmlspecialchars() [core] - 10https://gerrit.wikimedia.org/r/107017 (owner: 1001tonythomas) [19:31:53] (03CR) 10Reedy: [C: 032] SECURITY: Escape all shell arguments [extensions/PdfHandler] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110424 (owner: 10Reedy) [19:31:57] (03CR) 10Reedy: [C: 032] SECURITY: Escape all shell arguments [extensions/PdfHandler] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/110425 (owner: 10Reedy) [19:32:04] Hi, I am getting started with mediawiki, but I am stuck with cloning the core.git [19:32:20] I get the following error : ssh: connect to host gerrit.wikimedia.org port 29418: Network is unreachable [19:32:26] (03Merged) 10jenkins-bot: SECURITY: Escape all shell arguments [extensions/PdfHandler] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110424 (owner: 10Reedy) [19:32:31] (03Merged) 10jenkins-bot: SECURITY: Escape all shell arguments [extensions/PdfHandler] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/110425 (owner: 10Reedy) [19:33:47] <^d> helderwiki: Most important thing about that graph is that the queued and run numbers are roughly in line. [19:34:01] <^d> You don't want to be queuing way more than you're performing ;-) [19:34:28] (03PS1) 10Reedy: Update to head [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110428 [19:34:30] :-) [19:35:19] (03PS1) 10Reedy: Update to head [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/110429 [19:35:42] (03CR) 10Reedy: [C: 032 V: 032] Update to head [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/110429 (owner: 10Reedy) [19:35:50] (03CR) 10Reedy: [C: 032 V: 032] Update to head [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110428 (owner: 10Reedy) [19:37:16] (03PS1) 10Legoktm: Fix typo in ApiQueryRevisions [core] - 10https://gerrit.wikimedia.org/r/110430 [19:37:20] Reedy: ^ [19:38:28] (03PS1) 10Reedy: Fix userCan related fatal [core] - 10https://gerrit.wikimedia.org/r/110431 [19:38:33] (03PS1) 10Anomie: API: Fix typo in ApiQueryRevisions [core] - 10https://gerrit.wikimedia.org/r/110432 [19:38:37] :D [19:38:38] #first [19:38:41] 3 patches [19:38:56] (03PS2) 10Legoktm: Fix typo in ApiQueryRevisions [core] - 10https://gerrit.wikimedia.org/r/110430 [19:39:01] (03CR) 10Reedy: [C: 032] Fix typo in ApiQueryRevisions [core] - 10https://gerrit.wikimedia.org/r/110430 (owner: 10Legoktm) [19:39:23] (03Abandoned) 10Reedy: Fix userCan related fatal [core] - 10https://gerrit.wikimedia.org/r/110431 (owner: 10Reedy) [19:39:28] (03Abandoned) 10Reedy: API: Fix typo in ApiQueryRevisions [core] - 10https://gerrit.wikimedia.org/r/110432 (owner: 10Anomie) [19:39:59] (03PS1) 10Reedy: Fix typo in ApiQueryRevisions [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110435 [19:41:44] (03CR) 10Kaldari: "True. I guess I was just being paranoid :)" [core] - 10https://gerrit.wikimedia.org/r/110296 (owner: 10Kaldari) [19:42:16] (03CR) 10Reedy: [C: 032 V: 032] Fix typo in ApiQueryRevisions [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110435 (owner: 10Reedy) [19:42:44] (03PS3) 10Kaldari: Remove unneeded h3s around Create Account links [core] - 10https://gerrit.wikimedia.org/r/110296 [19:43:20] heh, you guys are clearly bored [19:43:38] and i have patches to be reviewed [19:44:39] https://gerrit.wikimedia.org/r/#/q/owner:%22Bartosz+Dziewo%25C5%2584ski+%253Cmatma.rex%2540gmail.com%253E%22+status:open,n,z [19:45:21] MatmaRex: what's up with https://gerrit.wikimedia.org/r/#/c/67265/ ? [19:45:49] or are you just going to wait until 1.20 is stable enough for them? [19:45:59] er, 1.21* [19:47:03] I commented [19:47:08] yeah, it can wait [19:47:09] gj [19:47:43] actually, the number of my open non--1'd patches has gone down recently [19:48:05] (03CR) 10jenkins-bot: [V: 04-1] Remove unneeded h3s around Create Account links [core] - 10https://gerrit.wikimedia.org/r/110296 (owner: 10Kaldari) [19:48:17] (03CR) 10Anomie: [C: 031] "I thought Krinkle already did this a while back." [core] - 10https://gerrit.wikimedia.org/r/110347 (owner: 10Helder.wiki) [19:49:18] (03CR) 10Bartosz Dziewoński: "There were some reasons why we only did the post-preview hook instead of the pre-preview one, but I don't remember them right now. mw.hook" [core] - 10https://gerrit.wikimedia.org/r/110347 (owner: 10Helder.wiki) [19:49:46] hi csteipp have you made any changes to auth on the beta cluster? it seems very slow, seems to be hanging on login.wikimedia.beta.wmflabs.org, and I just got an error "Central user log in The provided authentication token is either expired or invalid." [19:50:13] (03Merged) 10jenkins-bot: Fix typo in ApiQueryRevisions [core] - 10https://gerrit.wikimedia.org/r/110430 (owner: 10Legoktm) [19:50:37] chrismcmahon: I haven't changed beta's config, and there haven't been any major changes to CentralAuth recently [19:50:49] chrismcmahon: You only have a few seconds to use the token (30?), so if the cluster is to slow, that might fail [19:50:55] thanks Reedy. we're on that EP extension error. [19:51:13] csteipp: hmm, OK, it is awfully slow today, and I'm not seeing anything particularly funky except for the login host [19:52:24] (03CR) 10Legoktm: [C: 032] ChangesListSpecialPage: Implement doMainQuery() [core] - 10https://gerrit.wikimedia.org/r/105194 (owner: 10Bartosz Dziewoński) [19:55:32] (03CR) 10Manybubbles: [C: 032] "Tested and looks great." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108952 (owner: 10Manybubbles) [19:55:42] (03Merged) 10jenkins-bot: Make document building process more extensible [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108952 (owner: 10Manybubbles) [19:55:50] (03Merged) 10jenkins-bot: ChangesListSpecialPage: Implement doMainQuery() [core] - 10https://gerrit.wikimedia.org/r/105194 (owner: 10Bartosz Dziewoński) [19:56:07] (03CR) 10Legoktm: [C: 032] ChangesListSpecialPage: Implement webOutput() [core] - 10https://gerrit.wikimedia.org/r/105195 (owner: 10Bartosz Dziewoński) [19:58:00] (03CR) 10Legoktm: [C: 032] ChangesListSpecialPage: Stop mutating $opts in buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/105196 (owner: 10Bartosz Dziewoński) [20:00:12] (03Merged) 10jenkins-bot: ChangesListSpecialPage: Implement webOutput() [core] - 10https://gerrit.wikimedia.org/r/105195 (owner: 10Bartosz Dziewoński) [20:01:00] (03Merged) 10jenkins-bot: ChangesListSpecialPage: Stop mutating $opts in buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/105196 (owner: 10Bartosz Dziewoński) [20:02:15] ragesoss: Want another one? [20:02:18] Fatal error: Using $this when not in object context in /usr/local/apache/common-local/php-1.23wmf11/extensions/EducationProgram/includes/UserRolesMessage.php on line 250 [20:03:35] Reedy: AndyRussG has a fix for the first; post that error if you think it's a different situation. [20:04:20] It's completely different :) [20:04:26] :-) [20:05:01] (03PS1) 10Bsitu: Add flow-post-UUID hash to URL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110438 [20:05:50] Hi Reedy [20:06:50] (03PS1) 10Reedy: Fix special related fatal [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/110439 [20:07:03] (03PS1) 10Reedy: Fix special related fatal [extensions/ContactPageFundraiser] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110440 [20:07:08] (03CR) 10Reedy: [C: 032] Fix special related fatal [extensions/ContactPageFundraiser] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110440 (owner: 10Reedy) [20:07:10] (03Merged) 10jenkins-bot: Fix special related fatal [extensions/ContactPageFundraiser] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110440 (owner: 10Reedy) [20:07:41] Thanks! That looks interesting, waiting for more info? [20:08:34] I created a bug and attached a stack trace for it too [20:08:38] (03PS1) 10Reedy: Update ContactPageFundraiser to 1.23wmf12 HEAD [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110441 [20:08:47] (03CR) 10Reedy: [C: 032 V: 032] Update ContactPageFundraiser to 1.23wmf12 HEAD [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110441 (owner: 10Reedy) [20:09:40] Reedy: got the bug report, thx! [20:11:48] (03PS1) 10Mattflaschen: Document OutputPage->mDoNothing [core] - 10https://gerrit.wikimedia.org/r/110443 [20:11:54] mDoNothing is confusing on multiple levels. [20:12:03] ^ I decided to at least document it slightly. [20:12:17] (03CR) 10Legoktm: "I'm not a huge fan of soft deprecating things because it's confusing and when someone tries to hard deprecate it, and it becomes a huge me" [core] - 10https://gerrit.wikimedia.org/r/106279 (owner: 10Bartosz Dziewoński) [20:12:51] MatmaRex: only 1 patch left! [20:13:07] superm401: it's futile anyway. [20:13:11] (03CR) 10Bartosz Dziewoński: [C: 032] Document OutputPage->mDoNothing [core] - 10https://gerrit.wikimedia.org/r/110443 (owner: 10Mattflaschen) [20:13:15] legoktm: yay, thanks for the merges [20:13:23] i should write a few more patches [20:13:29] lots of @todos left [20:13:34] :D [20:14:33] Hey, is it correct that mw-core in postgres only uses SMALLINT (up to 32767) for page_namespace, but (my)SQL the bigger normal int? Should I file a bug or too unrealistic to fix, but let's save DB space? [20:14:40] (03PS1) 10Reedy: Update 2nd time lucky [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110444 [20:14:51] (03CR) 10Brian Wolff: "I love how jenkins-bot just shouts FAILURE in all caps with no reason." [core] - 10https://gerrit.wikimedia.org/r/107017 (owner: 1001tonythomas) [20:14:54] MatmaRex: what's up with https://gerrit.wikimedia.org/r/#/c/64615/ ? [20:15:16] (03CR) 10Reedy: [C: 032 V: 032] Update 2nd time lucky [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110444 (owner: 10Reedy) [20:15:35] (03CR) 10Bartosz Dziewoński: "There's a bug filed about that." [core] - 10https://gerrit.wikimedia.org/r/107017 (owner: 1001tonythomas) [20:15:43] legoktm: on hold [20:15:48] i'll redo the patch sometime [20:15:56] ok [20:15:59] it was blocked by the changeslistspecialpage rewrite :D [20:16:11] if it's -1, don't look at it [20:16:13] is https://bugzilla.wikimedia.org/show_bug.cgi?id=48641 ready to be closed now? [20:16:28] hmm, yeah probably [20:16:41] the only duplicated code left is the webOutput method and its friends, i think [20:17:23] (03Merged) 10jenkins-bot: Document OutputPage->mDoNothing [core] - 10https://gerrit.wikimedia.org/r/110443 (owner: 10Mattflaschen) [20:26:19] (03PS15) 10SG: Implement better scrolling via conditionalScroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 [20:26:41] (03PS16) 10SG: Implement better scrolling via conditionalScroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 [20:26:45] (03CR) 10Hashar: "Poor eggs :-(" [core] - 10https://gerrit.wikimedia.org/r/110443 (owner: 10Mattflaschen) [20:27:24] (03PS1) 10AndyRussG: Check revision object for course talk notification [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110446 [20:27:26] (03CR) 10SG: "Rebased and addressed concerns." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 (owner: 10SG) [20:28:03] (03CR) 10AndyRussG: [C: 04-1] "Needs testing" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110446 (owner: 10AndyRussG) [20:29:28] (03PS1) 10Hashar: tweak postmerge messages [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110447 [20:29:45] (03CR) 10Hashar: [C: 032] tweak postmerge messages [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110447 (owner: 10Hashar) [20:29:49] (03Merged) 10jenkins-bot: tweak postmerge messages [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110447 (owner: 10Hashar) [20:33:19] (03CR) 10Parent5446: "I don't think having the message key vary based on configuration option is a good idea. I feel like it'd be weird if the configuration op" [core] - 10https://gerrit.wikimedia.org/r/110279 (owner: 10Bartosz Dziewoński) [20:38:28] (03PS1) 10Aaron Schulz: Removed some "USE INDEX" clauses [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/110450 [20:41:29] (03CR) 10Anomie: [C: 032] "I don't consider that a BC break, since the globals could well have been absolute URLs before." [core] - 10https://gerrit.wikimedia.org/r/107592 (owner: 10Gilles) [20:42:27] (03CR) 10Parent5446: "Yeah I can't for the life of me figure out why it's giving this error. For some reason PHPUnit is just not using the dataProvider I tell i" [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/104508 (owner: 10Hashar) [20:43:59] (03PS1) 10Aaron Schulz: Added missing prefix to some indexes [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/110451 [20:44:51] (03Merged) 10jenkins-bot: Propagate the favicon information to getInfo() [core] - 10https://gerrit.wikimedia.org/r/107592 (owner: 10Gilles) [20:50:16] (03PS1) 10Aude: update wikidata, fix xml entity data output [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110452 [20:50:19] reedy ^ [20:57:02] (03PS2) 10Aude: update testwikidata, fix xml entity data output [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110452 [21:00:59] (03PS4) 10BryanDavis: Add role::wikimania_scholarships [vagrant] - 10https://gerrit.wikimedia.org/r/108067 [21:01:04] (03CR) 10jenkins-bot: [V: 04-1] Add role::wikimania_scholarships [vagrant] - 10https://gerrit.wikimedia.org/r/108067 (owner: 10BryanDavis) [21:01:47] (03PS5) 10BryanDavis: Add role::wikimania_scholarships [vagrant] - 10https://gerrit.wikimedia.org/r/108067 [21:02:49] (03CR) 10Spage: [C: 04-1] "Needs comment, and I wonder if we want this implicit "highlight this post" directive in the URL fragment of every post action." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110438 (owner: 10Bsitu) [21:03:14] (03CR) 10BryanDavis: "Patch Set 4 was a manual rebase (conflict in roles.pp) and Patch Set 5 was a fix for the dumb syntax error I created in PS 4." [vagrant] - 10https://gerrit.wikimedia.org/r/108067 (owner: 10BryanDavis) [21:04:10] Reedy: still around? [21:04:17] yeah [21:04:27] ok, when ready we need https://gerrit.wikimedia.org/r/110452 [21:04:37] then find ops person for our cron jobs [21:04:56] https://gerrit.wikimedia.org/r/#/c/110371/ [21:05:29] (03PS3) 10Aude: update testwikidata, fix xml entity data output [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110452 [21:06:14] (03CR) 10Reedy: [C: 032 V: 032] update testwikidata, fix xml entity data output [core] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/110452 (owner: 10Aude) [21:14:26] (03CR) 10Parent5446: "Will try and address other problems." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [21:15:04] (03CR) 10Hashar: "I have looked a bit at it, and the data provider are indeed never called :/ No idea what kind of issue in PHPUnit we might ends up hittin" [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/104508 (owner: 10Hashar) [21:21:50] (03PS2) 10Bsitu: Add flow-post-UUID hash to URL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110438 [21:23:45] (03CR) 10Hashar: [C: 032] "deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/110337 (owner: 10Adamw) [21:24:06] (03Merged) 10jenkins-bot: add Workflow extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/110337 (owner: 10Adamw) [21:24:20] (03PS2) 10Adamw: Add project for mwext-Workflow [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110338 [21:24:34] (03CR) 10EBernhardson: [C: 032] Add flow-post-UUID hash to URL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110438 (owner: 10Bsitu) [21:24:42] (03Merged) 10jenkins-bot: Add flow-post-UUID hash to URL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110438 (owner: 10Bsitu) [21:25:58] (03CR) 10Reedy: [C: 032] Fix special related fatal [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/110439 (owner: 10Reedy) [21:26:00] (03Merged) 10jenkins-bot: Fix special related fatal [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/110439 (owner: 10Reedy) [21:26:05] (03CR) 10Hashar: [C: 032] Add project for mwext-Workflow (031 comment) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110338 (owner: 10Adamw) [21:26:10] (03Merged) 10jenkins-bot: Add project for mwext-Workflow [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110338 (owner: 10Adamw) [21:28:34] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/110455 [21:28:38] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/110455 (owner: 10Hashar) [21:29:16] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/110455 (owner: 10Hashar) [21:31:40] !jenkins mwext-Workflow-yamllint [21:31:40] https://integration.wikimedia.org/ci/job/mwext-Workflow-yamllint [21:32:17] (03PS1) 10Hashar: generate mwext-Workflow-yamllint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/110456 [21:32:37] (03CR) 10Hashar: [C: 032] "deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/110456 (owner: 10Hashar) [21:32:52] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/110455 (owner: 10Hashar) [21:32:54] (03Merged) 10jenkins-bot: generate mwext-Workflow-yamllint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/110456 (owner: 10Hashar) [21:33:01] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/110455 [21:33:04] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/110455 (owner: 10Hashar) [21:33:23] awight_: the Workflow extensions has Zuul triggers / tests now :-] [21:35:09] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/110455 (owner: 10Hashar) [21:38:57] (03PS4) 10MrBlueSky: Special:Contributions: add all params to feed URL [core] - 10https://gerrit.wikimedia.org/r/108287 [21:39:21] i know there is a reason but can't remember what it is ... what could have happened where phpunit thinks there are, say, 314 tests to run but then on completion it has only run 164? [21:39:25] (03CR) 10MrBlueSky: "Changed so that year and month are not used for the feed URL." [core] - 10https://gerrit.wikimedia.org/r/108287 (owner: 10MrBlueSky) [21:39:28] it only marked 3 as skipped [21:39:38] by [21:39:49] by "thinks" i'm refering to the status prompt which says like, 63/319 ( 19%) [21:39:50] fatals? [21:39:58] nope, it doesn't even try and run them [21:40:08] it gets to 164/319 and decides its done [21:40:15] heh [21:40:18] segfaults? :D [21:40:22] dont think so :P [21:40:59] example output http://pastie.org/8683585 [21:47:58] (03PS1) 10EBernhardson: Limit Flow API to only respond on enabled pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110458 [21:58:16] (03CR) 10Swalling: [C: 04-1] "The version that is on wmflabs (piramido) works in that it launches the full tour by default. A couple of issues though:" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/107726 (owner: 10Mattflaschen) [21:59:26] (03PS2) 10EBernhardson: Limit Flow API to only respond on enabled pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110458 [22:00:20] (03PS1) 10AndyRussG: No course talk notifications for course sub-pages [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110461 [22:00:39] ragesoss: https://gerrit.wikimedia.org/r/#/c/110461/ [22:01:07] (03PS1) 10Aaron Schulz: Improved HTMLCacheUpdate/RefreshLinks cache use synergy [core] - 10https://gerrit.wikimedia.org/r/110462 [22:06:30] (03PS1) 10Legoktm: Don't use @unserialize [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110463 [22:06:48] (03CR) 10Mattflaschen: [C: 04-1] "Looks great overall. Thanks for cleaning up the codebase. A lot of this is infrastructure that was more useful in the past, but no longe" (035 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/110375 (owner: 10Phuedx) [22:07:03] (03PS2) 10AndyRussG: Check revision object for course talk notification [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110446 [22:17:31] (03PS3) 10Chad: Begin extending CirrusSearch schema with necessary data [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/105220 [22:26:52] (03PS1) 10Aaron Schulz: Made LinksUpdate::updateLinksTimestamp() use a more correct timestamp [core] - 10https://gerrit.wikimedia.org/r/110469 [22:31:18] (03PS4) 10Chad: Begin extending CirrusSearch schema with necessary data [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/105220 [22:34:47] * AaronSchulz pesters TimStarling about https://gerrit.wikimedia.org/r/#/c/107610/ [22:35:12] oh yeah [22:35:28] I've got a code review backlog about a mile long at the moment [22:36:21] (03CR) 10EBernhardson: [C: 032] Don't use @unserialize [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110463 (owner: 10Legoktm) [22:36:28] (03PS3) 10Aaron Schulz: Fixed getReaderIndex() handling of $group [core] - 10https://gerrit.wikimedia.org/r/107610 [22:36:34] (03CR) 10Tim Starling: [C: 032] Fixed getReaderIndex() handling of $group [core] - 10https://gerrit.wikimedia.org/r/107610 (owner: 10Aaron Schulz) [22:37:14] (03Merged) 10jenkins-bot: Don't use @unserialize [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110463 (owner: 10Legoktm) [22:37:19] (03CR) 10EBernhardson: [C: 032] Watchlist "show all" results in an "Error" page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110294 (owner: 10Bsitu) [22:37:59] (03Merged) 10jenkins-bot: Watchlist "show all" results in an "Error" page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110294 (owner: 10Bsitu) [22:39:55] TrevorParscal, do you have a few minutes today to talk about link inspector? [22:39:56] (03CR) 10Aaron Schulz: [C: 04-1] Remove unused stuff from tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109470 (owner: 10Addshore) [22:40:31] (03Merged) 10jenkins-bot: Fixed getReaderIndex() handling of $group [core] - 10https://gerrit.wikimedia.org/r/107610 (owner: 10Aaron Schulz) [22:42:02] (03CR) 10Tim Starling: [C: 032] Allow memory over-allocation in unprotected Lua calls [php/luasandbox] - 10https://gerrit.wikimedia.org/r/109413 (owner: 10Anomie) [22:42:24] (03Merged) 10jenkins-bot: Allow memory over-allocation in unprotected Lua calls [php/luasandbox] - 10https://gerrit.wikimedia.org/r/109413 (owner: 10Anomie) [22:46:17] (03CR) 10Aaron Schulz: Allow PENDINGCHANGELEVEL to work on other pages (032 comments) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/106898 (owner: 10Jackmcbarn) [22:47:32] (03PS3) 10Anomie: Use a child frame in frame:expandTemplate [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/89011 [22:47:36] (03CR) 10Tim Starling: [C: 032] Use a child frame in frame:expandTemplate [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/89011 (owner: 10Anomie) [22:47:52] (03PS4) 10Jackmcbarn: Allow PENDINGCHANGELEVEL to work on other pages [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/106898 [22:49:37] (03PS5) 10Jackmcbarn: Allow PENDINGCHANGELEVEL to work on other pages [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/106898 [22:51:12] (03CR) 10Jackmcbarn: "Sorry for the "noise"; the only two actual changes are the two from the comments." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/106898 (owner: 10Jackmcbarn) [22:51:14] (03CR) 10Chad: [C: 032 V: 032] Removed some "USE INDEX" clauses [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/110450 (owner: 10Aaron Schulz) [22:51:28] (03Merged) 10jenkins-bot: Use a child frame in frame:expandTemplate [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/89011 (owner: 10Anomie) [22:51:33] (03CR) 10Chad: [C: 032 V: 032] Added missing prefix to some indexes [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/110451 (owner: 10Aaron Schulz) [22:51:43] ori: https://gerrit.wikimedia.org/r/#/c/110396/2 [22:51:49] haven't we been here before? [22:52:17] <^d> AaronSchulz: synergy? really? [22:52:19] * ^d pukes [22:52:51] * AaronSchulz questions your level of culture fit [22:53:00] ;) [22:53:32] ori: apache will strip the vary header, right? [22:53:44] * bd808 thinks outside the cardboard shipping container [22:54:18] TimStarling: We tested it in labs and now prod and Ori's trick works [22:54:37] It must put the header in after the redirect code strips the headers out [22:55:21] right... [22:55:53] (03CR) 10Chad: [C: 032] Made LinksUpdate::updateLinksTimestamp() use a more correct timestamp [core] - 10https://gerrit.wikimedia.org/r/110469 (owner: 10Aaron Schulz) [22:55:55] what is different to how it was done before? [22:56:47] i.e. what is this trick exactly? [22:57:31] (03CR) 10Aaron Schulz: [C: 032 V: 032] Allow PENDINGCHANGELEVEL to work on other pages [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/106898 (owner: 10Jackmcbarn) [22:57:58] (03CR) 10Chad: "What's used where? I was moving the defines to the constants. The defines aren't used anywhere in core or extensions as far as I could tel" [core] - 10https://gerrit.wikimedia.org/r/110246 (owner: 10Chad) [22:58:33] He sets an environment var when triggering the rewrite rule and then conditionally adds to the Vary header based on the env var. This seems to add the appropriate Vary header to the response seen by Varnish. [22:59:15] (03Merged) 10jenkins-bot: Made LinksUpdate::updateLinksTimestamp() use a more correct timestamp [core] - 10https://gerrit.wikimedia.org/r/110469 (owner: 10Aaron Schulz) [22:59:18] Without the env trick the Vary header that should be set by the RewriteCond clause is not emited [23:01:08] There is a good writeup of the behavior without the env + Header addition at http://stackoverflow.com/a/3711110/8171 [23:01:42] ok, thanks [23:06:55] (03PS1) 10Bsitu: Add a cacheKey help function + test cases [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110472 [23:07:22] (03PS2) 10Bsitu: Add a cacheKey help function to + test cases to TreeRepository [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110472 [23:09:22] (03CR) 10Chad: [C: 032] Fixed stream wrapper in PhpHttpRequest [core] - 10https://gerrit.wikimedia.org/r/91393 (owner: 10Parent5446) [23:12:46] (03Merged) 10jenkins-bot: Fixed stream wrapper in PhpHttpRequest [core] - 10https://gerrit.wikimedia.org/r/91393 (owner: 10Parent5446) [23:15:41] (03CR) 10Mattflaschen: "Introduced https://bugzilla.wikimedia.org/show_bug.cgi?id=60653" [core] - 10https://gerrit.wikimedia.org/r/64941 (owner: 10Hashar) [23:21:00] (03CR) 10EBernhardson: "* Clicking reply when the area is still on screen sometimes scrolls when it should stay still" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 (owner: 10SG) [23:39:01] (03PS1) 10Mattflaschen: Revert "User::saveOptions() optimization" [core] - 10https://gerrit.wikimedia.org/r/110473 [23:41:00] (03PS11) 10Parent5446: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 [23:41:22] robla: Any idea who's a good person to throw a Lua question to? [23:41:48] (03CR) 10jenkins-bot: [V: 04-1] Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [23:41:57] kaldari: depends on the question. ask the question, and then we can route [23:42:01] :P [23:42:08] I'm tiredish, but probably can answer [23:43:29] Why does "local root = HtmlBuilder.create('table')" create a set of table tags, but "local root = HtmlBuilder.create(); root.tag('table')" doesn't seem to do anything. For example: https://en.wikipedia.org/wiki/Module:Sidebar/sandbox [23:44:24] kaldari: You should'n use the HtmlBuilder anymore, I've recently overhauled that and put it into Scribunto, it's mw.html now [23:45:14] hoo: So now it would be: "local root = mw.html; root.tag('table')"? [23:45:33] kaldari: local root = mw.html.create( 'table' ); [23:45:58] hoo: you mad genius you.. [23:46:06] well, I don't necessarily want table to be the first tag [23:46:18] kaldari: mw.html.create( '' ) [23:46:26] empty string is fine as well ;) [23:46:31] for both the old and the new one [23:46:35] cool, I'll try that [23:47:40] Krinkle|detached , TrevorParscal : I added a sentence about EventEmitter and Factory features in https://www.mediawiki.org/w/index.php?title=OOjs&diff=895567&oldid=835420 [23:47:43] (03CR) 10Parent5446: "The defines might be used by extensions. They cannot be removed unless they are first deprecated." [core] - 10https://gerrit.wikimedia.org/r/110246 (owner: 10Chad) [23:49:03] (03CR) 10Chad: "How on earth to you deprecate a define? Nobody's used it in git or svn as far as I can tell." [core] - 10https://gerrit.wikimedia.org/r/110246 (owner: 10Chad) [23:55:45] hoo: For some reason I can't get that to work without getting a script error: https://en.wikipedia.org/wiki/Module:Sidebar/sandbox https://en.wikipedia.org/wiki/Template:Sidebar/testcases [23:56:21] hoo: do I need some command to import mw.html? [23:56:47] kaldari: No, mw.html is getting loaded per default [23:56:51] let me check the error [23:58:59] kaldari: Yay, you found a bug in there :P [23:59:23] hooray, wait... [23:59:28] I mean boo