[00:02:55] <grrrit-wm>	 (03PS3) 10EBernhardson: Expand makefile commands [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110100 
[00:03:37] <jgonera>	 spage, your patchset also seems to bring back the focus outline for buttons, was this intentional?
[00:04:06] <grrrit-wm>	 (03CR) 10MZMcBride: Removed deprecated $wgDisabledActions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109891 (owner: 10Tinaj1234)
[00:06:14] <jgonera>	 also, superm401 in https://gerrit.wikimedia.org/r/#/c/103494/12/resources/mediawiki.ui/components/default/buttons.less do you want me to remove the whole comment together with the example "<div style="text-align: right;">"? it does seem weird to have an example markup with style attributes so I'd remove all of it
[00:07:17] <grrrit-wm>	 (03PS9) 10Legoktm: [WIP] Revamp API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 
[00:07:20] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Run vagrant browsertests against itself, not beta [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110086 (owner: 10EBernhardson)
[00:07:26] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Expand makefile commands [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110100 (owner: 10EBernhardson)
[00:07:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Run vagrant browsertests against itself, not beta [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110086 (owner: 10EBernhardson)
[00:07:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Expand makefile commands [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110100 (owner: 10EBernhardson)
[00:08:50] <superm401>	 jgonera, yeah, the comment (all the way from "We need a class" through "Styleguide 2.1.4") does not fit in the absence of the actual mw-ui-button-row implementation.
[00:09:04] <jgonera>	 superm401, I agree, removing
[00:09:13] <jgonera>	 spage, anything against it?
[00:10:30] <spage>	 jgonera: O
[00:11:12] <spage>	 jgonera: (swapped keyboards :) )  so, we really need that and it is the desired look, so the right fix is to have a style for it. But this patch is just the buttons.
[00:11:36] <jgonera>	 spage, buttons look like hovered when they're focused so they should be accessible
[00:11:54] <jgonera>	 actually, I'm not sure why the outline is visible, the CSS for outline: none is still there...
[00:11:55] <jgonera>	 hm
[00:12:08] <grrrit-wm>	 (03PS2) 10Ori.livneh: Add a role for GeoData, with default settings so far [vagrant] - 10https://gerrit.wikimedia.org/r/110097 (owner: 10MaxSem)
[00:12:47] <grrrit-wm>	 (03CR) 10Legoktm: "All modules now have an API module, I'm going to now start refactoring the JS and API output." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm)
[00:13:21] <jgonera>	 oh, spage, in fact the outline is visible only in Firefox, but not Chrome
[00:13:25] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Add a role for GeoData, with default settings so far [vagrant] - 10https://gerrit.wikimedia.org/r/110097 (owner: 10MaxSem)
[00:13:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add a role for GeoData, with default settings so far [vagrant] - 10https://gerrit.wikimedia.org/r/110097 (owner: 10MaxSem)
[00:14:33] <spage>	 jgonera, superm401 : if we agree on the name, can we add a minimal .mw-ui-actionbuttons { text-align: right; } somewhere
[00:14:56] <superm401>	 spage, jgonera, no, I don't want to expand this changeset.
[00:14:56] <jgonera>	 spage, let's do it as a follow up commit, I really want to merge this ;)
[00:15:01] <superm401>	 Yeah, it can be done separately.
[00:15:07] <bawolff>	 brion: When you wrote "There are currently (January 2014) some problems with using video and audio on Android web browsers" at commons, which issue were you referring to?
[00:16:00] <brion>	 bawolff: i believe, but i have not investigated it, that no <video> actually appears in output
[00:16:01] <spage>	 jgonera, superm401 understood, that rule is in my follow-up patch
[00:16:01] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] "(Gilles rewrote most of the patch, so not really a self-merge.)" [core] - 10https://gerrit.wikimedia.org/r/107712 (owner: 10Gergő Tisza)
[00:16:08] <brion>	 hence, nothing to playback
[00:16:21] <bawolff>	 brion: ok, so on the mobile site
[00:16:29] <bawolff>	 Wanted to make sure there wasn't a second issue
[00:16:31] <grrrit-wm>	 (03PS1) 10SG: Add jshint and clean up files which fail its validation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110107 
[00:16:31] <brion>	 right
[00:16:47] <brion>	 if you switch to desktop view it may help since that'll load the standard player stuff in theory
[00:16:48] <ebernhardson>	 anyone know Makefiles particularly well?  We have some make commands that are run in a pre-commit hook.  I am looking for some way to conditionally forward some of those make commands via `vagrant ssh -- cd /vagrant/mediawiki/.... && make <command>` since they need to be able to run the code
[00:16:52] <brion>	 but i haven't had a chance to test browsers yet
[00:17:04] <ebernhardson>	 i could just do it in the pre-commit hooks, but was hoping to find some way to do it inside the makefile so i can do normal make
[00:18:00] <bawolff>	 brion: That's accurate afaik. There is also an issue with the native web browser for android not playing the entire video, which I have no idea about (thedj suggested that android's webm implementation might be just super buggy, and not be decoding beyond the first page of the video file)
[00:18:29] <grrrit-wm>	 (03PS15) 10JGonera: Update mediawiki.ui button styles [core] - 10https://gerrit.wikimedia.org/r/103494 
[00:19:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Propagate the favicon information to getInfo() for local repos [core] - 10https://gerrit.wikimedia.org/r/107712 (owner: 10Gergő Tisza)
[00:20:25] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 031] "This is a BC break since the URLs change. I'm not sure if there is any special procedure to follow in such cases; I've asked Anomie to com" [core] - 10https://gerrit.wikimedia.org/r/107592 (owner: 10Gilles)
[00:25:13] <grrrit-wm>	 (03CR) 10Prtksxna: "." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[00:26:49] <grrrit-wm>	 (03CR) 10Prtksxna: Add JS/CSS for the new NavigationPopups (032 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[00:33:45] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "Looks good, except a couple things (both inline):" (032 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/109672 (owner: 10Phuedx)
[00:40:43] <jgonera>	 spage, ebernhardson, I'm having trouble setting up Flow, does any of you have a few minutes?
[00:45:56] <grrrit-wm>	 (03PS9) 10Aarcos: Add functionality to specify the MEDIAWIKI_PASSWORD_VARIABLE environment variable that points to the variable that contains the password [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109661 (owner: 10Zfilipin)
[00:52:00] <jgonera>	 spage, ebernhardson ping!
[00:54:19] <legoktm>	 hey ^demon|away, once you're back can you add shahyar (username: SG) to the wmf ldap group? he's a new member on the Flow team (https://www.mediawiki.org/wiki/Gerrit/Project_ownership#Shahyar_.28username_SG.29_for_.2B2_in_Flow)
[01:26:15] <awjr>	 Reedy: can i integrate our deployment log posting stuff with your make-deploy-notes? i think with some minor refactoring of make-deploy-notes and adding a shelexec in uploadChangelog.php it should be pretty straightforward. that way we can automatically (inasmuch as you run the script) get our fancy deployment logs
[01:35:23] <jackmcbarn>	 kaldari: around? if so, can you look at https://gerrit.wikimedia.org/r/#/c/105384/ again?
[01:36:00] <Reedy>	 awjr: That sounds fine to me
[01:36:18] <kaldari>	 jackmcbarn: hmm, I see what you mean...
[01:36:24] <awjr>	 thanks Reedy
[01:37:28] <kaldari>	 jackmcbarn: I think it should just say null regardless, as "null/invalid" is confusing and misleading.
[01:38:24] <kaldari>	 jackmcbarn: I have no idea why the other hooks say that. It might be left over from when things were less predictable
[01:38:52] <jackmcbarn>	 kaldari: k, new commit incoming. should i change the rest of them, or just make this one different?
[01:39:12] <kaldari>	 jackmcbarn: I would just leave the others how they are :P
[01:39:30] <kaldari>	 jackmcbarn: It's not a big deal if they aren't completely consistant
[01:39:57] <kaldari>	 jackmcbarn: unless you really feel like cleaning them up
[01:40:00] <grrrit-wm>	 (03PS2) 10Jackmcbarn: Add oldRev parameter to DiffRevisionTools hook [core] - 10https://gerrit.wikimedia.org/r/105384 
[01:40:09] <jackmcbarn>	 kaldari: not particularly
[01:40:45] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Add oldRev parameter to DiffRevisionTools hook [core] - 10https://gerrit.wikimedia.org/r/105384 (owner: 10Jackmcbarn)
[01:41:30] <jackmcbarn>	 thanks
[01:44:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add oldRev parameter to DiffRevisionTools hook [core] - 10https://gerrit.wikimedia.org/r/105384 (owner: 10Jackmcbarn)
[01:47:18] <grrrit-wm>	 (03CR) 10Brian Wolff: "recheck" [core] - 10https://gerrit.wikimedia.org/r/99544 (owner: 10Brian Wolff)
[01:47:25] <grrrit-wm>	 (03PS1) 10Reedy: Fixup duplicate class names against extension ContactPage [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/110119 
[01:47:57] <grrrit-wm>	 (03PS3) 10Jackmcbarn: Remove misleading Thank button from some diffs [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/105387 
[01:48:20] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Fixup duplicate class names against extension ContactPage [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/110119 (owner: 10Reedy)
[01:48:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fixup duplicate class names against extension ContactPage [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/110119 (owner: 10Reedy)
[01:48:39] <grrrit-wm>	 (03PS3) 10Brian Wolff: Make DjVu metadata be stored as serialized PHP array. [core] - 10https://gerrit.wikimedia.org/r/99544 
[01:50:08] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make DjVu metadata be stored as serialized PHP array. [core] - 10https://gerrit.wikimedia.org/r/99544 (owner: 10Brian Wolff)
[01:58:16] <grrrit-wm>	 (03PS4) 10Brian Wolff: Make DjVu metadata be stored as serialized PHP array. [core] - 10https://gerrit.wikimedia.org/r/99544 
[02:00:31] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Remove misleading Thank button from some diffs [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/105387 (owner: 10Jackmcbarn)
[02:00:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove misleading Thank button from some diffs [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/105387 (owner: 10Jackmcbarn)
[02:03:04] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] Make RL more forgiving about cache keys that are int-like strings. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103407 (owner: 10Dr0ptp4kt)
[02:07:30] <grrrit-wm>	 (03PS4) 10Parent5446: Make RL more forgiving about cache keys that are int-like strings. [core] - 10https://gerrit.wikimedia.org/r/103407 (owner: 10Dr0ptp4kt)
[02:11:03] <grrrit-wm>	 (03PS5) 10Parent5446: Make RL more forgiving about cache keys that are int-like strings. [core] - 10https://gerrit.wikimedia.org/r/103407 (owner: 10Dr0ptp4kt)
[02:13:53] <grrrit-wm>	 (03CR) 10Parent5446: Removed deprecated $wgDisabledActions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109891 (owner: 10Tinaj1234)
[02:15:32] <grrrit-wm>	 (03PS1) 10Legoktm: Capitalize MediaWiki [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110120 
[02:16:08] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Capitalize MediaWiki [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110120 (owner: 10Legoktm)
[02:16:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Capitalize MediaWiki [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110120 (owner: 10Legoktm)
[02:17:13] <Gloria>	 legoktm: Such abuse.
[02:17:30] <legoktm>	 It was bugging me.
[02:21:44] <grrrit-wm>	 (03CR) 10Aarcos: [C: 031] "I just changed this so we have 3 options to get the password: argument, MEDIAWIKI_PASSWORD and MEDIAWIKI_PASSWORD_VARIABLE. This is more c" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109661 (owner: 10Zfilipin)
[02:26:57] <grrrit-wm>	 (03CR) 10Yurik: "Manybubbles, what issue do you see with sorting? Most people would not even bother to specify ordering (making it auto-default, whichever " [core] - 10https://gerrit.wikimedia.org/r/109669 (owner: 10Manybubbles)
[02:42:01] <grrrit-wm>	 (03CR) 10Brian Wolff: "Re AlekhN: The commit message needs to be word-wrapped (The version on Patch set 5 was better: https://gerrit.wikimedia.org/r/#/c/106625/5" [core] - 10https://gerrit.wikimedia.org/r/106625 (owner: 10AalekhN)
[02:42:56] <grrrit-wm>	 (03CR) 10Pastakhov: preparing for localization (031 comment) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/109883 (owner: 10Pastakhov)
[02:46:22] <grrrit-wm>	 (03PS6) 10Brian Wolff: Made Special:Contributions includable [core] - 10https://gerrit.wikimedia.org/r/106320 (owner: 10AalekhN)
[02:47:55] <grrrit-wm>	 (03PS1) 10Reedy: Cleanup some code [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110123 
[02:47:56] <grrrit-wm>	 (03CR) 10Brian Wolff: [C: 032] "PS5: fix an instance of tabs vs spaces and trailing whitespace." [core] - 10https://gerrit.wikimedia.org/r/106320 (owner: 10AalekhN)
[02:51:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Made Special:Contributions includable [core] - 10https://gerrit.wikimedia.org/r/106320 (owner: 10AalekhN)
[02:55:55] <grrrit-wm>	 (03Abandoned) 10Brian Wolff: Don't allow '-' in db name - seems like bad idea with wikiId. [core] - 10https://gerrit.wikimedia.org/r/59736 (owner: 10Brian Wolff)
[02:58:48] <Krinkle>	 Reedy: It's especially confusing because our cache instance is named $wgMemc
[02:58:50] <Krinkle>	 ARGH!
[02:58:52] <Krinkle>	 superm401: 
[02:58:55] <Reedy>	 :D
[02:59:02] <Reedy>	 That's another global that needs to die die die
[02:59:18] <superm401>	 Yeah, $wgMemc is a pretty unfortunate name.
[03:00:44] <Reedy>	 Back in the days where memcached for everything
[03:01:03] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Cleanup some code [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110123 (owner: 10Reedy)
[03:01:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Cleanup some code [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110123 (owner: 10Reedy)
[03:02:12] <bawolff>	 I don't see that global as being particularly evil
[03:02:21] <superm401>	 Krinkle, I think got it backwards.  Originally (before face4812c6b3cc60d4408601b3d4c7c484596417), it was using native Redis, but it failed completely since it was using PHP serializing, then Redis native increment.
[03:02:34] <bawolff>	 It's not like you're going to change caching backends at any point in the request, ever
[03:02:54] <superm401>	 bawolff, the issue is not the global so much (though there may be a better way to stash it as a singleton).
[03:02:58] <superm401>	 Just the name.
[03:03:18] <bawolff>	 ah. yeah, it is an unfortunate one
[03:04:08] * bawolff  thinks the difference between $wgFoo, wfGetFoo() and Foo::singleton() is pretty much non-existent

[03:27:26] <grrrit-wm>	 (03CR) 10Brian Wolff: [C: 04-1] "Couple nitpicky things, otherwise looks good." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/40096 (owner: 10Alex Monk)
[03:28:48] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] Add functionality to specify the MEDIAWIKI_PASSWORD_VARIABLE environment variable that points to the variable that contains the password [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109661 (owner: 10Zfilipin)
[03:28:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add functionality to specify the MEDIAWIKI_PASSWORD_VARIABLE environment variable that points to the variable that contains the password [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109661 (owner: 10Zfilipin)
[03:31:44] <grrrit-wm>	 (03PS1) 10Reedy: Handle $wgEnableEmail = false better [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110125 
[03:33:18] <Reedy>	 bawolff: ^ :P
[03:37:16] <grrrit-wm>	 (03CR) 10Brian Wolff: "/me still thinks that deprecated configuration items shouldn't be removed unless removing the conversion code is more than a micro-optimiz" [core] - 10https://gerrit.wikimedia.org/r/109891 (owner: 10Tinaj1234)
[03:39:10] <grrrit-wm>	 (03PS1) 10Reedy: Update README [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110127 
[03:44:06] <grrrit-wm>	 (03CR) 10Brian Wolff: [C: 032] "lgtm" [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110125 (owner: 10Reedy)
[03:44:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Handle $wgEnableEmail = false better [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110125 (owner: 10Reedy)
[03:45:21] <grrrit-wm>	 (03PS2) 10Reedy: Update README [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110127 
[03:45:25] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Update README [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110127 (owner: 10Reedy)
[03:45:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update README [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110127 (owner: 10Reedy)
[03:45:47] <bawolff>	 Reedy: what are these install.settings files anyhow. Does anything use them?
[03:47:14] <Reedy>	 I've no idea tbh
[03:50:32] <grrrit-wm>	 (03CR) 10Brian Wolff: "I'm not really a fan of adding tests to check for a behaviour that we consider "wrong"." [core] - 10https://gerrit.wikimedia.org/r/98119 (owner: 10Bartosz Dziewoński)
[04:04:32] <Reedy>	 GRrrr
[04:04:39] <Reedy>	 Something keeps caching my localisation changes
[04:05:13] <grrrit-wm>	 (03CR) 10Brian Wolff: [C: 04-1] "I agree, new preferences should have a really good reason for existing (Triply so for one's that affect parser cache), I don't think this " [core] - 10https://gerrit.wikimedia.org/r/46790 (owner: 10Parent5446)
[04:05:26] <grrrit-wm>	 (03CR) 10EBernhardson: "looks good, only one issue to address in post.html.php" (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu)
[04:06:29] <Gloria>	 Hi shahyar.
[04:11:21] <grrrit-wm>	 (03CR) 10Brian Wolff: "I'm not sure how I feel about this. Calling the project namespace after the wiki name is a pretty long established tradition" [core] - 10https://gerrit.wikimedia.org/r/109056 (owner: 10leucosticte)
[04:13:11] <grrrit-wm>	 (03PS3) 10Brian Wolff: Make Popularpages includeable [core] - 10https://gerrit.wikimedia.org/r/107979 (owner: 10Eranroz)
[04:19:05] <grrrit-wm>	 (03CR) 10Brian Wolff: [C: 04-1] "Minor issue - I think $par's behaviour shouldn't change based on includability (see inline comment). Other then that, this looks good." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/107979 (owner: 10Eranroz)
[04:21:38] <grrrit-wm>	 (03PS2) 10Brian Wolff: Special:Contributions: add all params to feed URL [core] - 10https://gerrit.wikimedia.org/r/108287 (owner: 10MrBlueSky)
[04:22:16] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Special:Contributions: add all params to feed URL [core] - 10https://gerrit.wikimedia.org/r/108287 (owner: 10MrBlueSky)
[04:23:09] <grrrit-wm>	 (03PS3) 10MrBlueSky: Special:Contributions: add all params to feed URL [core] - 10https://gerrit.wikimedia.org/r/108287 
[04:25:04] <bawolff>	 hmm, deletedonly option seems to take a long time, I wonder what that query looks like
[04:25:23] <bawolff>	 An especially long time given I shouldn't have the rights to even look at that info
[04:26:45] <bawolff>	 oh I guess I'm allowed, its revdel data too
[04:36:28] <grrrit-wm>	 (03CR) 10Brian Wolff: [C: 04-1] "year defaults to the current year, and thus the current year is transferred over. If people copy and paste the url into their feed reader," [core] - 10https://gerrit.wikimedia.org/r/108287 (owner: 10MrBlueSky)
[04:38:12] <Reedy>	 			$message = 'contactpage-pagetext-' . $this->formType;
[04:38:12] <Reedy>	 			$text = wfMessage( $message )->parseAsBlock();
[04:38:12] <Reedy>	 			if ( !wfMessage( $message, $text )->isDisabled() ) {
[04:38:26] <Reedy>	 Why would you pass $text to the wfMessage isDisabled call?
[04:40:46] <Reedy>	 https://github.com/wikimedia/mediawiki-extensions-ContactPage/commit/4b93823fa8071d068e239d5e0b7efa3795aed163#diff-eb4145123f368ce8a97af8ac63abd6a8L126
[04:40:48] <Reedy>	 Doesn't help either
[04:44:40] <grrrit-wm>	 (03CR) 10Brian Wolff: [C: 04-1] Check for CoreParserFunction::urlFunction from array to boolean and return values accordingly to htmlspecialchars() (033 comments) [core] - 10https://gerrit.wikimedia.org/r/107017 (owner: 1001tonythomas)
[04:45:19] <bawolff>	 Reedy: I think that's a throw back to wfEmptyMessage()
[04:45:31] <bawolff>	 probably someone doing a find and replace over the entire code base
[04:45:37] <Reedy>	 I was wondering if it was like the "default"
[04:45:45] <Reedy>	 function wfEmptyMsg( $key ) {
[04:46:10] <bawolff>	 older versions of that function used to need 2 parameters I think
[04:47:38] <T13|sleeps>	 addshore or RoanKattouw_away  or any other api gurus around? What's the api call to see if a page has the cascade protection bit on?
[04:47:58] <grrrit-wm>	 (03CR) 10Brian Wolff: "Note, this preference was also fairly broken last time I checked (It was justifying things it shouldn't), so I don't think a whole lot of " [core] - 10https://gerrit.wikimedia.org/r/99322 (owner: 1001tonythomas)
[04:48:14] <T13|sleeps>	 ppprops doesn't seem to return it
[04:49:16] <Reedy>	 query=info
[04:49:17] <Reedy>	 				if ( $row->pr_cascade ) {
[04:49:17] <Reedy>	 					$a['cascade'] = '';
[04:49:17] <Reedy>	 				}
[04:50:34] <bawolff>	 Hmm, that might only include the page with cascading protection, not pages that are protected by extension
[04:50:55] * bawolff  tests

[04:51:05] <T13|sleeps>	 https://en.wikipedia.org/w/api.php?format=jsonfm&title=Main_page&query=info
[04:51:57] <T13|sleeps>	 https://en.wikipedia.org/w/api.php?format=json&title=Main_page&query=info
[04:52:11] <bawolff>	 T13|sleeps: https://en.wikipedia.org/w/api.php?action=query&prop=info&titles=Main_Page&inprop=protection
[04:52:32] <bawolff>	 There's such a thing as aft protection!?
[04:53:21] <bawolff>	 That seems like totally the wrong way to control such a thing (from a semantics of the system point of view)
[04:54:06] <T13|sleeps>	 Lol
[04:54:24] <bawolff>	 oh, I guess it does include the protection via other pages https://en.wikipedia.org/w/api.php?action=query&prop=info&titles=Main_Page|template:Convert&inprop=protection
[04:55:01] <T13|sleeps>	 So it returns an empty cascade attribute if exist and null if not?
[04:57:02] <bawolff>	 looks like
[04:57:59] <T13|sleeps>	 Perfect.
[04:59:02] <T13|sleeps>	 I can use that in my more visually friendly version of Brad's script that shows protection log info on transcluded pages. :)
[05:09:54] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Removed "Justify paragraphs" from MW user Preference. [core] - 10https://gerrit.wikimedia.org/r/99322 (owner: 1001tonythomas)
[05:13:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Removed "Justify paragraphs" from MW user Preference. [core] - 10https://gerrit.wikimedia.org/r/99322 (owner: 1001tonythomas)
[05:15:42] <Gloria>	 Boom.
[05:28:03] <Krinkle>	 TimStarling: You there?
[05:28:08] <TimStarling>	 yes
[05:28:33] <Krinkle>	 TimStarling: I'm looking for another eye on a matter related to your object cache. Got a minute?
[05:28:45] <TimStarling>	 yes, ok
[05:29:03] <Krinkle>	 So most of our caching storages (at least Memcache) maintains value types (set() int, get() int), except Redis.
[05:29:11] <Krinkle>	 Code like this worries me: https://gerrit.wikimedia.org/r/#/c/103407/5/includes/resourceloader/ResourceLoaderModule.php
[05:30:37] <Krinkle>	 I think we should either somehow come up with a fix for retreiving ints in Redis (e.g. always cast to int if int-like, though that'll break the opposite, or always php serialise ints, but that breaks increment, but that could be emulated, should we even use increment on arbitrary keys?) - or we need to change our memcached implementation to ignore its feature of storing ints, and always return strings 
[05:30:37] <Krinkle>	 from get(), which would put the responsibility on the consuming code to cast to integers
[05:30:48] <Krinkle>	 the latter is essentially what this patch suggests
[05:30:59] <Krinkle>	 Except that it does it in 1 very specific and arbitrary spot in our code base
[05:31:44] <TimStarling>	 are you sure that's not done already?
[05:31:49] <TimStarling>	 	protected function unserialize( $data ) {
[05:31:49] <TimStarling>	 		// Ignore digit strings and ints so INCR/DECR work
[05:31:49] <TimStarling>	 		return ( is_int( $data ) || ctype_digit( $data ) ) ? $data : unserialize( $data );
[05:31:49] <TimStarling>	 	}
[05:32:20] <Krinkle>	 The bug in that patch stems from mediawiki-vagrant which, unlike our production, uses Redis, which means storing an integer means getting a string back out.
[05:32:26] <Krinkle>	 TimStarling: That's from Redis, right?
[05:32:33] <TimStarling>	 RedisBagOStuff
[05:32:35] <Krinkle>	 That doesn't cast it
[05:32:39] <TimStarling>	 right..
[05:32:43] <TimStarling>	 well, easily fixed
[05:32:51] <AaronSchulz>	 same as with php memcached
[05:33:06] <Krinkle>	 I don't think $data can ever be int there, only digit-like.
[05:33:19] <Krinkle>	 In Memcached it can however.
[05:33:21] <TimStarling>	 traditionally, in memcached, all scalars were unserialized
[05:33:24] <Krinkle>	 Which is why this code works in production.
[05:33:35] <Krinkle>	 but breaks if main cache is redis
[05:33:35] <TimStarling>	 which meant that you couldn't preserve the difference between (int)0 and '0'
[05:33:42] <TimStarling>	 not sure if that's still the case
[05:34:09] <Krinkle>	 TimStarling: Are you sure? From what I observed our Memcached doesn't serialise integers, but doesn't lose its type data either
[05:34:16] <Krinkle>	 it has native distinction between strings and integers
[05:34:55] <Krinkle>	 in a way that get() can retreive, and increment() can increment without bypassing native INCR.
[05:35:09] <Krinkle>	 (e.g. we don't use the base bagostuff class implementation of increment that emulates it with locks)
[05:35:15] <Krinkle>	 (in memcached)
[05:35:16] <TimStarling>	 in the old memcached client, there is no special handling for ints
[05:35:39] <TimStarling>	 it just does
[05:35:40] <TimStarling>	 		if ( !$this->_fwrite( $sock, "$command\r\n$val\r\n" ) ) {
[05:35:45] <grrrit-wm>	 (03CR) 10MZMcBride: "Tony: do you have time to rebase this change? I think that's the first step toward getting this merged." [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas)
[05:35:46] <TimStarling>	 where $val is typically unchanged from the input
[05:37:54] <TimStarling>	 the serialize() function in RedisBagOStuff is a bit of a disaster
[05:38:01] <TimStarling>	 apologies to whoever wrote it
[05:39:41] <Krinkle>	 TimStarling: Hm.. are you saying that we originally had the same inability to maintain integer's type and that therefore most code probably didn't rely on what ResourceLoader has come to rely on? Would you be for removing this ability from our bagostuff clients that have come to support it for consistency? (lowest denominator being redis and old memcached, so we'd never return actual integers from set(
[05:39:41] <Krinkle>	 )), and then require consumers of cache to deal with casting to integers consistently 
[05:40:20] <Krinkle>	 Or try and implement support for integer return values from clients that don't?
[05:40:28] <TimStarling>	 I think it should ideally be type-preserving
[05:40:34] <Krinkle>	 Right
[05:41:19] <Krinkle>	 The problem there I suppose is that in cases like Redis it doesn't support integer value types, but does support integer operations (it has native INCR). Which means it has no distinction between '123' and 123.
[05:41:57] <TimStarling>	 well, '123' can be serialized
[05:42:06] <Krinkle>	 Ah, the other way around.
[05:42:07] <Krinkle>	 Nice
[05:42:09] <TimStarling>	 therefore anyone who tries to increment it will be screwed
[05:42:17] <TimStarling>	 but maybe that is better than the current situation
[05:42:25] <superm401>	 Are we sure memcached itself preserves types, as opposed to serialization somewhere?
[05:42:36] <TimStarling>	 you mean libmemcached?
[05:43:07] <TimStarling>	 well, I suppose you mean PECL memcached, that's where the serialization would be
[05:43:11] <superm401>	 Or the server itself. I'm not that familiar with the layers.
[05:43:17] <TimStarling>	 the old pure-PHP memcached client definitely does not preserve types
[05:43:30] <superm401>	 But yeah, the idea of serializing only strings seems reasonable.
[05:43:34] <Krinkle>	 Somewhat unrelated to this, I would argue one shouldn't worry about INCR when dealing with a regular int value in a key/value store. if I'm storing a timestamp integer in a key, other code has no business trying to increment that so php serialising that integer couldn't reasonably break anything. We could require incrementable keys to be marked as such. But that's a last resort.
[05:43:39] <superm401>	 Well, everything except int I mean.
[05:43:57] <Krinkle>	 I suppose it would also avoid serialised-like strings being interpreted as such
[05:44:02] <Krinkle>	 Do we protect against that now?
[05:44:12] <superm401>	 Protect against what?
[05:44:37] <TimStarling>	 Krinkle: I think that would be a bigger interface break than what I'm proposing
[05:44:38] <Krinkle>	 e.g. class Foo { $cache->set( $key, serialise( $data ) ); $cache->get( $key ); // should not be unserialised
[05:44:58] <Krinkle>	 TimStarling: Yeah, your approach would fix two bugs, preserving ints and the above ^
[05:45:05] <TimStarling>	 I'm basically looking for a solution with minimal b/c breakage and minimal chance of future stupid type errors in clients
[05:45:12] <superm401>	 serialise( $data ) is a string.
[05:45:26] <superm401>	 But if the Redis client always serialized strings, it would reserialise.
[05:45:31] <Krinkle>	 as it should
[05:45:35] <superm401>	 Then deserialize exactly once when pulling it back out.
[05:45:51] <Krinkle>	 because I'm giving the cache a string, not a php object, so it is my responsibility to unserialise
[05:45:57] <superm401>	 As long as it always serializes strings, and always deserializes non-numeric strings, it should work.
[05:46:23] <Krinkle>	 edge case of course (why would you call serialise on your end calling set() ), but might be good to protect against, especially when dealing with user input.
[05:46:33] <superm401>	 I don't think it's a problematic edge case.
[05:46:38] <grrrit-wm>	 (03PS3) 10Inchikutty: (WIP)Embedding Static Map to UploadWizard- part of OPW round 7 Project [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 
[05:46:44] <superm401>	 serialize (string X) and string X are both strings.
[05:46:49] <superm401>	 For the first, it gives:
[05:46:50] <TimStarling>	 ok, so PECL memcached actually passes types down to libmemcached
[05:46:57] <superm401>	 serialize( serialize ( string X ) ).
[05:47:05] <superm401>	 For the second, it's serialize ( string X )
[05:47:13] <TimStarling>	 http://paste.tstarling.com/p/ULiFqT.html
[05:47:24] <superm401>	 If it always deserializes non-numeric strings once (no loop) when pulling out, both should work.
[05:48:22] <TimStarling>	 and gets types back out of libmemcached: http://paste.tstarling.com/p/GaAIwc.html
[05:48:34] <grrrit-wm>	 (03CR) 10SG: [C: 031] "Seems to me the concerns have been addressed." [core] - 10https://gerrit.wikimedia.org/r/103494 (owner: 10JGonera)
[05:48:41] <TimStarling>	 presumably libmemcached has some way of making the server preserve them
[05:49:16] <superm401>	 Yeah, just not sure what that way is.
[05:51:56] <TimStarling>	 <Krinkle> I suppose it would also avoid serialised-like strings being interpreted as such
[05:52:20] <TimStarling>	 in the pure-PHP memcached client, serialization is specified with a "flag", i.e. in an integer field outside of the value
[05:52:32] <TimStarling>	 there's no detection of strings that look like serialized objects
[05:52:42] <Krinkle>	 Good
[05:52:50] <Krinkle>	 But the redis client doesn't
[05:52:57] <Krinkle>	 it seems to unconditionally unserialise
[05:53:00] <Krinkle>	 but also serialise
[05:53:06] <Krinkle>	 so I suppose that's fine, ish?
[05:53:19] <Krinkle>	 not if we change the code without purging data
[05:53:28] <TimStarling>	 in the redis client, it skips the unserialize if the string is all digits
[05:53:35] <Krinkle>	 yeah
[05:53:53] <TimStarling>	 and the serialize is skipped by the same condition
[05:54:03] <superm401>	 Krinkle, yes, I think it's fine as long as it's symmetric.
[05:54:06] <Krinkle>	 but it doesn't seem plausible that one could fool Redis get() if user input looking like php serialise() is given to set()
[05:54:45] <superm401>	 BTW, we talked about this at https://bugzilla.wikimedia.org/show_bug.cgi?id=56069 back when we did the last round of these changes.
[05:54:51] <superm401>	 See https://bugzilla.wikimedia.org/show_bug.cgi?id=56069#c5 .
[05:55:11] <TimStarling>	 a serialized object is not all digits, so it's not possible to get redis to write a user-input string that looks serialized without serializing the string
[05:55:24] <TimStarling>	 if that makes sense
[05:55:27] <superm401>	 Right
[05:55:39] <TimStarling>	 english needs to be fully parenthesized
[05:55:47] <superm401>	 But it sould actually serialize all user input strings.
[05:56:00] <superm401>	 And deserialize everything coming out of Redis unless it is all numeric digits.
[05:56:03] <superm401>	 I think that should work.
[05:56:18] <superm401>	 If it's all numeric digits coming out, treat it as an int.
[05:56:24] <superm401>	 Cast to int before returning.
[05:56:47] <superm401>	 And things that are neither int nor string also would get serialized going in.
[05:57:51] <superm401>	 And if it's an int going in, cast to string but don't serialize.
[05:58:15] <TimStarling>	 well, there is the slight issue that ctype_digit() is part of libc's epic l10n interface failure
[05:58:51] <Krinkle>	 Do we want to use a regex instead :tollface: ?
[05:58:52] <grrrit-wm>	 (03PS1) 10Reedy: Code cleanup and simplification [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110131 
[05:59:03] <superm401>	 TimStarling, meaning it treats non-Latin digits as digits?
[05:59:20] <TimStarling>	 it may do
[05:59:25] <TimStarling>	 there's no way to be sure
[05:59:31] <grrrit-wm>	 (03PS4) 10Inchikutty: (WIP)Embedding Static Map to UploadWizard- part of OPW round 7 Project [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 
[05:59:37] * Krinkle  files a bug for all this

[05:59:42] <TimStarling>	 well, apart from calling setlocale('C') and breaking anything else in the same process that was using the library
[06:00:42] <superm401>	 In theory... that may not be a problem, since under this scheme anything going into Redis should be either:
[06:00:48] <superm401>	 (string) $some_int
[06:00:50] <superm401>	 or:
[06:01:06] <superm401>	 $serialized_string (which contains at least one non-numeric char).
[06:01:16] <superm401>	 (string) $some_int will pass ctype_digit.
[06:01:26] <superm401>	 But $serialized_string should not, even if non-Latin digits count.
[06:02:11] <TimStarling>	 you mean the caller of BagOStuff is expected to serialize?
[06:02:32] <superm401>	 No, the beginning of set should branch.
[06:02:44] <superm401>	 1. If it's an int, change it to (string) $input
[06:02:55] <TimStarling>	 yes, ok
[06:02:57] <superm401>	 2. Otherwise, change it to PHP_serialize( $input )
[06:03:13] <superm401>	 1 will be only Latin digits.
[06:03:25] <superm401>	 2 should not pass ctype_digit even if non-Latin digits are considered digits.
[06:04:21] <TimStarling>	 anyway, I would be quite happy with preg_match('/^[0-9]$/', $val) and use that sort of thing in my own code
[06:04:31] <grrrit-wm>	 (03PS1) 10Reedy: Remove numerous debug statements [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110132 
[06:04:41] <superm401>	 That's probably fine, but I don't know how big a performance difference it is.
[06:04:44] <TimStarling>	 it is probably faster than libc scanning huge localised digit tables
[06:05:15] <TimStarling>	 you know there is a PCRE JIT now, who was telling me about that?
[06:05:32] <superm401>	 Didn't know that; it's pretty cool though.
[06:05:58] <TimStarling>	 apparently it will be enabled by default in PHP at some point
[06:09:18] <Krinkle>	 Created https://bugzilla.wikimedia.org/show_bug.cgi?id=60563, please leave additional comments as you see fit.
[06:09:33] <Krinkle>	 Thanks for everything so far.
[06:15:15] <grrrit-wm>	 (03CR) 10Jack Phoenix: "The commit message doesn't address /why/ this was done." [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110132 (owner: 10Reedy)
[06:16:19] <Krinkle>	 TimStarling: Hm,. so the only thing we'd effectively change in redis is from if ( is_int/ctype_digit ) -> if ( is_int ), and serialise even digit strings. And on the way out, cast digit strings to php ints
[06:16:32] <Krinkle>	 The only thing this could break I think is if some code right now is storing strings that were meant to be integers
[06:16:37] <Krinkle>	 and then tries to increment them
[06:16:48] <TimStarling>	 yes
[06:17:11] <TimStarling>	 probably the intention of the original code was to account for that case
[06:17:14] <Krinkle>	 Which would only expose the bug, so I suppose that's fine. We might want to do a round of logging to see if this happens anywhere right now.
[06:17:36] <grrrit-wm>	 (03CR) 10Reedy: "Most of them are useless and like trace points from when someone was writing the extension" [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110132 (owner: 10Reedy)
[06:17:43] <TimStarling>	 yes, or we could grep for incr() calls and review them
[06:18:07] <TimStarling>	 would incr() log anything if it were called on a non-numeric string?
[06:18:10] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] "I've filed bug 60563 for this." [core] - 10https://gerrit.wikimedia.org/r/103407 (owner: 10Dr0ptp4kt)
[06:18:35] <TimStarling>	 gtg
[06:20:31] <grrrit-wm>	 (03PS6) 10Krinkle: resourceloader: Account for cache backend casting int value to string [core] - 10https://gerrit.wikimedia.org/r/103407 (owner: 10Dr0ptp4kt)
[06:21:45] <superm401>	 The Redis CLI shows "ERR value is not an integer or out of range" when you try to incr a non-numeric string.
[06:21:58] <superm401>	 I'm not sure how that's passed back up.  Right now, the Redis bagostuff unconditionally deserializes the return value from incrBy.
[06:25:37] <grrrit-wm>	 (03PS2) 10Krinkle: Transclude translation for preference edit section to ensure consistency of translation [core] - 10https://gerrit.wikimedia.org/r/58668 (owner: 10Raimond Spekking)
[06:26:03] <grrrit-wm>	 (03CR) 10Brian Wolff: "Not sure if we care, but this makes things look ugly on my browser (firefox 3.5)" [core] - 10https://gerrit.wikimedia.org/r/108873 (owner: 10Jdlrobson)
[06:26:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Transclude translation for preference edit section to ensure consistency of translation [core] - 10https://gerrit.wikimedia.org/r/58668 (owner: 10Raimond Spekking)
[06:28:28] <grrrit-wm>	 (03PS3) 10Krinkle: $wgContLang->getSpecialPageAliases(); can return null causing functions. [core] - 10https://gerrit.wikimedia.org/r/59522 (owner: 10Alexia)
[06:28:39] <grrrit-wm>	 (03CR) 10Krinkle: "Rebased to resolve merge conflict." [core] - 10https://gerrit.wikimedia.org/r/59522 (owner: 10Alexia)
[06:31:34] <grrrit-wm>	 (03PS1) 10Krinkle: Check for Language::getSpecialPageAliases returning null in SpecialPageFactory [core] - 10https://gerrit.wikimedia.org/r/110134 
[06:32:32] <grrrit-wm>	 (03PS4) 10Krinkle: Check for Language::getSpecialPageAliases returning null in SpecialPageFactory [core] - 10https://gerrit.wikimedia.org/r/59522 (owner: 10Alexia)
[06:33:05] <grrrit-wm>	 (03CR) 10Krinkle: "Fixed coding style of comment, wrapped and rephrased commit message." [core] - 10https://gerrit.wikimedia.org/r/59522 (owner: 10Alexia)
[06:33:11] <grrrit-wm>	 (03Abandoned) 10Krinkle: Check for Language::getSpecialPageAliases returning null in SpecialPageFactory [core] - 10https://gerrit.wikimedia.org/r/110134 (owner: 10Krinkle)
[06:42:18] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Code cleanup and simplification [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110131 (owner: 10Reedy)
[06:42:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Code cleanup and simplification [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110131 (owner: 10Reedy)
[06:42:27] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Remove numerous debug statements [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110132 (owner: 10Reedy)
[06:42:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove numerous debug statements [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110132 (owner: 10Reedy)
[06:46:27] <grrrit-wm>	 (03PS3) 10Krinkle: Transclude translation for preference edit section to ensure consistency of translation [core] - 10https://gerrit.wikimedia.org/r/58668 (owner: 10Raimond Spekking)
[06:46:39] <grrrit-wm>	 (03PS1) 10Reedy: Swap numerous " -> ' [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110135 
[07:09:16] <grrrit-wm>	 (03CR) 10Krinkle: [C: 031] Swap numerous " -> ' [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110135 (owner: 10Reedy)
[07:09:19] <grrrit-wm>	 (03PS5) 10TTO: Add namespace-wide page notice functionality [core] - 10https://gerrit.wikimedia.org/r/105434 
[07:09:30] <grrrit-wm>	 (03CR) 10Krinkle: "Rebased to resolve merge conflict." [core] - 10https://gerrit.wikimedia.org/r/58668 (owner: 10Raimond Spekking)
[07:13:38] <grrrit-wm>	 (03CR) 10Krinkle: "What is the intended use case of oldid?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO)
[07:14:13] <grrrit-wm>	 (03PS3) 10Platonides: Allow redirecting Message objects. [core] - 10https://gerrit.wikimedia.org/r/53189 
[07:14:35] <grrrit-wm>	 (03PS7) 10TTO: Hide edit toolbar Signature button in content namespaces by default [core] - 10https://gerrit.wikimedia.org/r/87649 
[07:16:38] <grrrit-wm>	 (03PS4) 10Krinkle: Implement ability to redirect Message objects [core] - 10https://gerrit.wikimedia.org/r/53189 (owner: 10Platonides)
[07:16:48] <grrrit-wm>	 (03CR) 10Krinkle: "Addressed inline comments regarding coding style." [core] - 10https://gerrit.wikimedia.org/r/53189 (owner: 10Platonides)
[07:17:33] <grrrit-wm>	 (03PS4) 10Krinkle: Allow the bad image list to be redirected elsewhere [core] - 10https://gerrit.wikimedia.org/r/53190 (owner: 10Platonides)
[07:17:43] <grrrit-wm>	 (03PS5) 10Platonides: Allow the bad image list to be redirected elsewhere [core] - 10https://gerrit.wikimedia.org/r/53190 
[07:18:00] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] "Per Tim." [core] - 10https://gerrit.wikimedia.org/r/53190 (owner: 10Platonides)
[07:22:18] <grrrit-wm>	 (03PS1) 10EBernhardson: Perform topic length validation with mb_strlen [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110141 
[07:25:23] <grrrit-wm>	 (03Abandoned) 10Yurik: PATH_INFO-based API actions [core] - 10https://gerrit.wikimedia.org/r/71858 (owner: 10Yurik)
[07:27:08] <grrrit-wm>	 (03CR) 10TTO: Add namespace-wide page notice functionality (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO)
[07:29:11] <grrrit-wm>	 (03PS6) 10TTO: Add namespace-wide page notice functionality [core] - 10https://gerrit.wikimedia.org/r/105434 
[07:31:22] <grrrit-wm>	 (03CR) 10TTO: "Would you prefer if I got rid of oldid?" [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO)
[07:40:50] <grrrit-wm>	 (03PS1) 10Reedy: Make message keys unique, were the same as extension/ContactPage [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/110142 
[07:47:03] <grrrit-wm>	 (03PS1) 10AndyRussG: No undeletion of courses of deleted institutions [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110143 
[07:50:02] <grrrit-wm>	 (03CR) 10Mattflaschen: "Everything else looks good." [core] - 10https://gerrit.wikimedia.org/r/103494 (owner: 10JGonera)
[07:50:14] <grrrit-wm>	 (03PS2) 10AndyRussG: No undeletion of courses of deleted institutions [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110143 
[07:58:18] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Swap numerous " -> ' [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110135 (owner: 10Reedy)
[07:58:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Swap numerous " -> ' [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110135 (owner: 10Reedy)
[08:04:02] <grrrit-wm>	 (03CR) 10Mattflaschen: "See replies inline." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh)
[08:27:54] <grrrit-wm>	 (03CR) 10Parent5446: Make abstract Config class truly implementation-agnostic (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh)
[08:44:17] <grrrit-wm>	 (03PS1) 10Raimond Spekking: Add i18n file [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/110146 
[08:46:08] <grrrit-wm>	 (03PS1) 10Pastakhov: remove functions and constants [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/110147 
[08:46:33] <grrrit-wm>	 (03CR) 10Pastakhov: [C: 032 V: 032] remove functions and constants [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/110147 (owner: 10Pastakhov)
[08:47:33] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 032] "Wooo thanks!" [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/110146 (owner: 10Raimond Spekking)
[08:56:25] <mediawiki>	 too many spammers in http://www.sub-bavaria.de/w/index.php?title=Spezial:Letzte_%C3%84nderungen&limit=500 and it's so difficult to get rid of them
[09:02:28] <mediawiki>	 please support antispam measurements in http://www.sub-bavaria.de/w/index.php?title=Spezial:Letzte_%C3%84nderungen&limit=500  thank you http://sensiblochamaeleon.blogspot.de/2013/10/help-spam-alarm-bei-sub-bavaria.html
[09:05:41] <grrrit-wm>	 (03CR) 10Hashar: "Cause bug 60546 Parsoid: Cannot load any page on Betalabs which had Math function added to it and shows the error PHP fatal error in /data" [core] - 10https://gerrit.wikimedia.org/r/108490 (owner: 10Physikerwelt)
[09:10:06] <grrrit-wm>	 (03PS19) 10Physikerwelt: Remove call to deprecated ParserOptions::getMath [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 
[09:10:34] <grrrit-wm>	 (03CR) 10Physikerwelt: [V: 032] Remove call to deprecated ParserOptions::getMath [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 (owner: 10Physikerwelt)
[09:10:46] <grrrit-wm>	 (03CR) 10Physikerwelt: [C: 032] Remove call to deprecated ParserOptions::getMath [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 (owner: 10Physikerwelt)
[09:24:33] <hashar>	 physikerwelt: hello
[09:25:03] <hashar>	 physikerwelt: ParserOptions::getMath() has been removed though it got deprecated with 1.22
[09:25:10] <hashar>	 physikerwelt: causing bug https://bugzilla.wikimedia.org/show_bug.cgi?id=60546
[09:25:23] <hashar>	 might want to revert the patch that get rid of ParserOptions::getMath() and use  wfDeprecated() instead
[09:28:00] <grrrit-wm>	 (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 4c3da1b..dd9ff82 [extensions] - 10https://gerrit.wikimedia.org/r/110150 
[09:28:02] <grrrit-wm>	 (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 4c3da1b..dd9ff82 [extensions] - 10https://gerrit.wikimedia.org/r/110150 (owner: 10Jenkins-mwext-sync)
[09:29:21] <physikerwelt>	 hashar: the function has been moved to the math extension
[09:29:56] <physikerwelt>	 hashar: the point is that the change was merged without to merge the related change in the math extension
[09:30:25] <hashar>	 physikerwelt: ahhh
[09:30:48] <hashar>	 physikerwelt: so as long as both changes land in wmf branches I guess we will be fine :-]
[09:31:00] <physikerwelt>	 hashar: same problem for https://gerrit.wikimedia.org/r/#/c/109492/
[09:31:55] <physikerwelt>	 hashar: only that this problem was not discoverd or does not occur due to side effects (wmf-config) that I don't know
[09:32:43] <physikerwelt>	 hashar: It would be great if we could modell intra repository dependencies in gerrit
[09:33:28] <physikerwelt>	 hashar: with my comment CR-1 depends on a core change I wanted to avoid that this change is merged before the core change is merged
[09:34:29] <grrrit-wm>	 (03CR) 10Helder.wiki: [C: 031] Use mw.util.getUrl for generating Link URLs [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/110101 (owner: 10Alex Monk)
[09:34:49] <physikerwelt>	 hashar: I expect the same problem for the changes https://gerrit.wikimedia.org/r/#/c/105647/ and https://gerrit.wikimedia.org/r/#/c/105648/
[09:35:36] <physikerwelt>	 hashar: maybe my fault was that I only did a -1 and not a -2 CR on the change
[09:35:54] <hashar>	 we have no support for cross repositories dependencies
[09:36:00] <hashar>	 :(
[09:36:20] <hashar>	 hence why we wfDeprecated() method before removing them
[09:38:03] <physikerwelt>	 hashar: what has been merged now changes the caching behaiviour of core and the math extension
[09:40:43] <physikerwelt>	 hashar: I would feel better if this change has been properly reviewd
[09:46:08] <physikerwelt>	 hashar: on the other side I think I have implemented all the comments of Brian Wolff who seems to be experienced
[09:48:59] <grrrit-wm>	 (03CR) 10TTO: "Ping Reedy and Tim!" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/94593 (owner: 10TTO)
[09:54:59] <hashar>	 physikerwelt: yeah bawolff has a lot of experience
[09:55:09] <hashar>	 you can trust him more than me :-D
[10:05:56] <grrrit-wm>	 (03PS1) 10Njw: Ensure page is valid XML [skins/erudite] - 10https://gerrit.wikimedia.org/r/110152 
[10:12:10] <grrrit-wm>	 (03CR) 10Njw: [C: 032 V: 032] Ensure page is valid XML [skins/erudite] - 10https://gerrit.wikimedia.org/r/110152 (owner: 10Njw)
[10:38:13] <grrrit-wm>	 (03CR) 10Tpt: [C: 031] "Looks good. Thanks!" [core] - 10https://gerrit.wikimedia.org/r/99544 (owner: 10Brian Wolff)
[10:50:25] <grrrit-wm>	 (03PS1) 10Chiborg: Use Revision ID instead of current Rev ID [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/110157 
[10:55:34] <grrrit-wm>	 (03PS4) 10Addshore: Remove unused stuff from tests [core] - 10https://gerrit.wikimedia.org/r/109470 
[11:08:05] <grrrit-wm>	 (03PS1) 10Pastakhov: add hook PhpTagsRuntimeFirstInit [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/110159 
[11:08:21] <grrrit-wm>	 (03PS4) 10Whym: (bug 53132) properly get timestamp position in DiscussionParser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/108329 
[11:08:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] (bug 53132) properly get timestamp position in DiscussionParser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/108329 (owner: 10Whym)
[11:08:40] <grrrit-wm>	 (03CR) 10Pastakhov: [C: 032 V: 032] add hook PhpTagsRuntimeFirstInit [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/110159 (owner: 10Pastakhov)
[11:09:27] <tto>	 Here's an interesting question. What does mExtra['lang'] get used for in RecentChange.php?
[11:09:40] <tto>	 It is certainly assigned to but the value never seems to be used
[11:11:34] <grrrit-wm>	 (03PS5) 10Whym: (bug 53132) properly get timestamp position in DiscussionParser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/108329 
[11:13:20] <grrrit-wm>	 (03CR) 10Whym: "Patch set 4 and 5 only were only to add a line ("Follow-up") into the commit message." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/108329 (owner: 10Whym)
[11:21:39] <grrrit-wm>	 (03PS1) 10TTO: Add $wgLocalInterwikis to handle multiple local prefixes [core] - 10https://gerrit.wikimedia.org/r/110162 
[11:21:41] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 04-1] "This will only "fix" links in post content. Those, however, shouldn't break out anymore (but trigger a vertical scrollbar due to overflow:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108972 (owner: 10Werdna)
[11:25:44] <grrrit-wm>	 (03PS1) 10Pastakhov: Add jobs for mw/ext/PhpTags and remove jobs for mw/ext/Foxway [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/110164 
[11:26:19] <grrrit-wm>	 (03PS10) 1001tonythomas: Removed 'Remember my login' option from the Preferences page [core] - 10https://gerrit.wikimedia.org/r/94614 
[11:26:21] <grrrit-wm>	 (03CR) 10Parent5446: [C: 031] "I can't believe we forgot about this. My patch to core adding wgRevisionId was merged ages ago." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/110157 (owner: 10Chiborg)
[11:30:12] <grrrit-wm>	 (03CR) 1001tonythomas: "Rebased change. Will apply instructions in the further patchset." [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas)
[11:35:57] <grrrit-wm>	 (03PS9) 1001tonythomas: Check for CoreParserFunction::urlFunction from array to boolean and return values accordingly to htmlspecialchars() [core] - 10https://gerrit.wikimedia.org/r/107017 
[11:37:12] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Check for CoreParserFunction::urlFunction from array to boolean and return values accordingly to htmlspecialchars() [core] - 10https://gerrit.wikimedia.org/r/107017 (owner: 1001tonythomas)
[11:39:09] <grrrit-wm>	 (03PS10) 1001tonythomas: Check for CoreParserFunction::urlFunction from array to boolean and return values accordingly to htmlspecialchars() [core] - 10https://gerrit.wikimedia.org/r/107017 
[11:39:22] <grrrit-wm>	 (03CR) 10Matthias Mullie: "I said *vertical*, but obviously meant *horizontal* :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108972 (owner: 10Werdna)
[11:40:02] <grrrit-wm>	 (03PS9) 10TTO: Allow two-tier setup of transwiki import sources [core] - 10https://gerrit.wikimedia.org/r/84194 
[11:41:09] <grrrit-wm>	 (03CR) 1001tonythomas: "@Brian : Done." [core] - 10https://gerrit.wikimedia.org/r/107017 (owner: 1001tonythomas)
[11:43:48] <grrrit-wm>	 (03CR) 10Helder.wiki: "This introduces hardcoded English parameters to our templates." [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/106749 (owner: 10Anomie)
[11:47:00] <grrrit-wm>	 (03CR) 10Parent5446: [C: 04-1] Check for CoreParserFunction::urlFunction from array to boolean and return values accordingly to htmlspecialchars() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/107017 (owner: 1001tonythomas)
[11:48:44] <yuvipanda>	 zz_prtksxna: 'sup
[11:56:02] <grrrit-wm>	 (03CR) 10Calak: [C: 031] Allow two-tier setup of transwiki import sources [core] - 10https://gerrit.wikimedia.org/r/84194 (owner: 10TTO)
[12:24:18] <grrrit-wm>	 (03PS1) 10Se4598: fix Special:PrefixIndex omits stripprefix=1 for "Next page" link [core] - 10https://gerrit.wikimedia.org/r/110168 
[12:27:05] <grrrit-wm>	 (03PS1) 10Njw: Release v1.8 [skins/erudite] - 10https://gerrit.wikimedia.org/r/110169 
[12:27:57] <grrrit-wm>	 (03CR) 10Njw: [C: 032 V: 032] Release v1.8 [skins/erudite] - 10https://gerrit.wikimedia.org/r/110169 (owner: 10Njw)
[13:01:30] <grrrit-wm>	 (03PS2) 10Rjain: Use Revision ID instead of current Rev ID [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/110157 (owner: 10Chiborg)
[13:10:10] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/84194 (owner: 10TTO)
[13:13:50] <grrrit-wm>	 (03PS1) 10Reza: Use Nazli for Persian [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/110174 
[13:35:16] <grrrit-wm>	 (03PS1) 10Manybubbles: WIP Tweak search config for performance [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110178 
[13:35:22] <hashar>	 Reedy: are you awake already? :)
[13:35:33] <hashar>	 physikerwelt: I guess sam is jetlagged still
[14:04:47] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 04-1] Topic and Post appearance tweaks (039 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu)
[14:07:39] <grrrit-wm>	 (03CR) 10Matthias Mullie: Topic and Post appearance tweaks (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu)
[14:09:16] <grrrit-wm>	 (03PS24) 10Matthias Mullie: Topic and Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu)
[14:09:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Topic and Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu)
[14:11:08] <grrrit-wm>	 (03PS25) 10Matthias Mullie: Topic and Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu)
[14:12:08] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 031] "PS24 addresses all of my & ebernhardson's feedback" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu)
[14:24:05] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] "Hell yes!" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110107 (owner: 10SG)
[14:24:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add jshint and clean up files which fail its validation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110107 (owner: 10SG)
[14:35:28] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 031] "I'm not sure about Legoktm's comment." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105873 (owner: 10Bsitu)
[14:36:09] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Use anonymous user in maintenance scripts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109927 (owner: 10EBernhardson)
[14:36:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use anonymous user in maintenance scripts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109927 (owner: 10EBernhardson)
[14:36:46] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Remove useless/unused "use" statements [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109845 (owner: 10Legoktm)
[14:36:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove useless/unused "use" statements [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109845 (owner: 10Legoktm)
[14:37:08] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Ignore temp files from jedit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109809 (owner: 10EBernhardson)
[14:37:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Ignore temp files from jedit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109809 (owner: 10EBernhardson)
[14:38:29] <grrrit-wm>	 (03PS2) 10Matthias Mullie: Ignore temp files from jedit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109809 (owner: 10EBernhardson)
[14:38:37] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Ignore temp files from jedit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109809 (owner: 10EBernhardson)
[14:38:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Ignore temp files from jedit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109809 (owner: 10EBernhardson)
[14:38:55] <MatmaRex>	 werdna: you around?
[14:39:50] <MatmaRex>	 werdna: i was wondering, just how hard would it be to have Flow use regular MediaWiki pages as its backend, without using Parsoid? the code seems to be written with separation of concerns in mind, so that would probably require few changes
[14:39:57] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Remove no longer existing classes from autloading global [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109717 (owner: 10Bsitu)
[14:40:03] <MatmaRex>	 and you'd get link tables etc for free, until Parsoid implements that
[14:40:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove no longer existing classes from autloading global [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109717 (owner: 10Bsitu)
[14:41:50] <grrrit-wm>	 (03CR) 10KartikMistry: Use Nazli for Persian (031 comment) [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/110174 (owner: 10Reza)
[14:44:59] <grrrit-wm>	 (03CR) 10Matthias Mullie: "Perhaps it'd be better to implement a default format method to AbstractFormatter (based on Contributions' Formatter) then, with IContextSo" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109487 (owner: 10Legoktm)
[14:54:12] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Quickfix: $c['user'] was bool, should be User [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110184 
[14:54:34] <grrrit-wm>	 (03CR) 10Matthias Mullie: Use anonymous user in maintenance scripts (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109927 (owner: 10EBernhardson)
[14:54:41] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Quickfix: $c['user'] was bool, should be User [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110184 (owner: 10Matthias Mullie)
[14:54:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Quickfix: $c['user'] was bool, should be User [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110184 (owner: 10Matthias Mullie)
[14:57:29] <grrrit-wm>	 (03PS2) 10Jackmcbarn: Allow all users to view Special:UserRights [core] - 10https://gerrit.wikimedia.org/r/107009 
[14:59:48] <grrrit-wm>	 (03CR) 10Addshore: [C: 031] Add composer.json file [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/109864 (owner: 10Adrian Lang)
[14:59:57] <grrrit-wm>	 (03PS2) 10Matthias Mullie: (bug 58413) Hide usernames until reply form is active [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106275 
[15:00:14] <MatmaRex>	 @seen mmullie
[15:00:14] <wm-bot>	 MatmaRex: I have never seen mmullie
[15:00:18] <MatmaRex>	 @seen mullie
[15:00:19] <wm-bot>	 MatmaRex: Last time I saw mullie they were changing the nickname to , but  is no longer in channel #mediawiki at 12/2/2012 10:25:24 PM (422d16h34m54s ago)
[15:00:53] <mlitn>	 MatmaRex: try @seen mlitn ;)
[15:02:55] <MatmaRex>	 oh. hi :)
[15:03:05] <MatmaRex>	 mlitn: i was wondering, just how hard would it be to have Flow use regular MediaWiki pages as its backend, without using Parsoid? the code seems to be written with separation of concerns in mind, so that would probably require few changes
[15:03:08] <MatmaRex>	 and you'd get link tables etc for free, until Parsoid implements that
[15:03:26] <MatmaRex>	 (i was trying to get someone Flow-y here to ask that, werdna seems afk)
[15:04:57] <grrrit-wm>	 (03CR) 10Matthias Mullie: "Newly submitted patch:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106275 (owner: 10Matthias Mullie)
[15:05:04] <mlitn>	 erm
[15:05:11] <mlitn>	 werdna is probably flying atm
[15:05:12] <grrrit-wm>	 (03PS1) 10Gerrit Patch Uploader: Exclude user interface elements in content from selection [core] - 10https://gerrit.wikimedia.org/r/110186 
[15:05:14] <grrrit-wm>	 (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/110186 (owner: 10Gerrit Patch Uploader)
[15:06:25] <grrrit-wm>	 (03PS5) 10Phuedx: Log impressions of the onboarding CTA. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/109672 
[15:07:18] <mlitn>	 using regular MW pages would be quite hard
[15:07:43] <mlitn>	 using regular Parser instead of Parsoid, however, should be just a config-switch away
[15:08:02] <mlitn>	 (and we should probably document that, somewhere)
[15:08:27] <MatmaRex>	 mlitn: i really meant as a backend � you'd stick them in a namespace and disallow everyone from viewing it
[15:10:58] <mlitn>	 I have not though about that (nor anyone in Flow team, I guess)
[15:11:17] <mlitn>	 but I'm guessing this would come with a wild variety of other unanticipated problems
[15:11:38] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu)
[15:12:03] <mlitn>	 and I don't think it's really something we want to go after - we actually deliberately want to use Parsoid
[15:12:49] <MatmaRex>	 yeah, i understand that, but using parsoid seems to come with a whole new set of troubles right now :)
[15:12:55] <mlitn>	 it's possible not to use parsoid (but parsed), but that means no HTML->wikitext conversion, so all data has to be stored in wikitext, and every single post then has to be re-parsed every time
[15:13:00] <MatmaRex>	 so i guess i'm just throwing the idea out
[15:13:19] <mlitn>	 that's true, there's still a lot to figure out there ^^
[15:13:22] <MatmaRex>	 for consideration
[15:14:02] <MatmaRex>	 mlitn: you could probably also reuse the various caching mechanisms MediaWiki has for the Parser :)
[15:14:27] <MatmaRex>	 i mean, the regular pages are not reparsed every time, despite being wikitext
[15:16:38] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "Should this be JSON format? Also see inline question." (031 comment) [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/110146 (owner: 10Raimond Spekking)
[15:17:30] <mlitn>	 true
[15:17:37] <grrrit-wm>	 (03CR) 10Cscott: "@Reza: can you explain in more detail why you wish the font changed? Open Type has different shaping features for different languages; pe" [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/110174 (owner: 10Reza)
[15:18:03] <mlitn>	 although I don't know too much about how these are cached & if it'd make sense to build on that, right now
[15:18:46] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "I like the idea here, but I think we should update some parts of the interface if the user is not allowed to make any changes (either havi" [core] - 10https://gerrit.wikimedia.org/r/107009 (owner: 10Jackmcbarn)
[15:19:13] <MatmaRex>	 mlitn: afaik these magically come for free if you use ParserOutput
[15:19:46] <mlitn>	 I guess it wouldn't hurt if I looked into that a bit more :)
[15:19:51] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/110143 (owner: 10AndyRussG)
[15:21:07] <grrrit-wm>	 (03CR) 10Raimond Spekking: "It is only for Special:Version. Or do you mean that all new i18n files should be created as JSON files regardless of where the messages ar" [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/110146 (owner: 10Raimond Spekking)
[15:22:05] <grrrit-wm>	 (03CR) 10Siebrand: "Any idea who should approve this? I no longer merge code that's related to FR." [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/110142 (owner: 10Reedy)
[15:22:46] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "Awesome!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110141 (owner: 10EBernhardson)
[15:23:36] <grrrit-wm>	 (03CR) 10Siebrand: "@raimond: Indeed. Especially if the target version if 1.23 and up, JSON should be default." [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/110146 (owner: 10Raimond Spekking)
[15:27:25] <grrrit-wm>	 (03PS9) 10Chad: Track versions of the index for easier maintenance [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109007 
[15:27:48] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] "Rebased and approved." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109007 (owner: 10Chad)
[15:27:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: Track versions of the index for easier maintenance [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109007 (owner: 10Chad)
[15:30:11] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Perform topic length validation with mb_strlen [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110141 (owner: 10EBernhardson)
[15:30:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Perform topic length validation with mb_strlen [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110141 (owner: 10EBernhardson)
[15:30:52] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] ChangesListSpecialPage: Implement buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/103546 (owner: 10Bartosz Dziewoński)
[15:31:11] <grrrit-wm>	 (03CR) 10Phuedx: Log impressions of the onboarding CTA. (032 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/109672 (owner: 10Phuedx)
[15:34:05] <grrrit-wm>	 (03CR) 10Manybubbles: "So the thing this is waiting on is an error message we don't believe we'll be showing to the user frequently, if at all. The gist of the " [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110084 (owner: 10Manybubbles)
[15:34:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: ChangesListSpecialPage: Implement buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/103546 (owner: 10Bartosz Dziewoński)
[15:36:31] <grrrit-wm>	 (03PS1) 10Dereckson: Improve OutputPage::showErrorPage method documentation [core] - 10https://gerrit.wikimedia.org/r/110189 
[15:36:33] <grrrit-wm>	 (03PS1) 10Dereckson: OutputPage::showErrorPage raises a notice if arguments are incoherent [core] - 10https://gerrit.wikimedia.org/r/110190 
[15:37:12] <grrrit-wm>	 (03PS2) 10Dereckson: Improve OutputPage::showErrorPage method documentation [core] - 10https://gerrit.wikimedia.org/r/110189 
[15:37:32] <grrrit-wm>	 (03PS2) 10Dereckson: OutputPage::showErrorPage raises a notice if arguments are incoherent [core] - 10https://gerrit.wikimedia.org/r/110190 
[15:42:49] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] "Since you're already fixing this, I think you should have it use $dbr->makeList( ... LIST_OR/AND ) rather than constructing that SQL manua" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109687 (owner: 10Bartosz Dziewoński)
[15:56:51] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Use InvalidDataException [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110194 
[15:57:30] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Improve OutputPage::showErrorPage method documentation [core] - 10https://gerrit.wikimedia.org/r/110189 (owner: 10Dereckson)
[16:00:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Improve OutputPage::showErrorPage method documentation [core] - 10https://gerrit.wikimedia.org/r/110189 (owner: 10Dereckson)
[16:02:31] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: OutputPage::showErrorPage raises a notice if arguments are incoherent (031 comment) [core] - 10https://gerrit.wikimedia.org/r/110190 (owner: 10Dereckson)
[16:06:12] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: OutputPage::showErrorPage raises a notice if arguments are incoherent [core] - 10https://gerrit.wikimedia.org/r/110190 (owner: 10Dereckson)
[16:06:47] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] OutputPage::showErrorPage raises a notice if arguments are incoherent [core] - 10https://gerrit.wikimedia.org/r/110190 (owner: 10Dereckson)
[16:08:49] <grrrit-wm>	 (03CR) 10Reza: "Its design and style is Arabic, it has a lot Arabic "rlig", its default glyphs has Arabic style. and no way Persian users would like it. W" [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/110174 (owner: 10Reza)
[16:10:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: OutputPage::showErrorPage raises a notice if arguments are incoherent [core] - 10https://gerrit.wikimedia.org/r/110190 (owner: 10Dereckson)
[16:12:42] <grrrit-wm>	 (03PS1) 10Manybubbles: Test to check our addition to Special:Version [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110197 
[16:14:25] <grrrit-wm>	 (03CR) 10Umherirrender: "See also Idbc3ba83af5fba2a13168f26f24f8018a79a34c6, which moves that to a own function." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109687 (owner: 10Bartosz Dziewoński)
[16:27:09] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "With all due respect I'm afraid we no longer care. :)" [core] - 10https://gerrit.wikimedia.org/r/108873 (owner: 10Jdlrobson)
[16:31:42] <grrrit-wm>	 (03CR) 10Reza: Use Nazli for Persian (031 comment) [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/110174 (owner: 10Reza)
[16:34:36] <grrrit-wm>	 (03Abandoned) 10Bartosz Dziewoński: Add parser test for empty self-link with empty fragment [[#|...]] [core] - 10https://gerrit.wikimedia.org/r/98119 (owner: 10Bartosz Dziewoński)
[16:34:36] <wm-bot>	 https://www.mediawiki.org/wiki/#
[16:45:38] <grrrit-wm>	 (03CR) 10PleaseStand: [C: 04-1] ChangesListSpecialPage: Leave doing Boolean algebra to the SQL engine (032 comments) [core] - 10https://gerrit.wikimedia.org/r/109687 (owner: 10Bartosz Dziewoński)
[16:47:47] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Test to check our addition to Special:Version [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110197 (owner: 10Manybubbles)
[16:47:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Test to check our addition to Special:Version [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110197 (owner: 10Manybubbles)
[16:48:14] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Browser test gardening [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109953 (owner: 10Manybubbles)
[16:48:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Browser test gardening [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109953 (owner: 10Manybubbles)
[16:49:14] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "You know what, I'm just going to abandon this and rebase the stack, it seems to be more trouble than it's worth." [core] - 10https://gerrit.wikimedia.org/r/109687 (owner: 10Bartosz Dziewoński)
[16:49:38] <grrrit-wm>	 (03Abandoned) 10Bartosz Dziewoński: ChangesListSpecialPage: Leave doing Boolean algebra to the SQL engine [core] - 10https://gerrit.wikimedia.org/r/109687 (owner: 10Bartosz Dziewoński)
[16:52:24] <grrrit-wm>	 (03CR) 10Chad: "I think we'll get the other patch merged soon enough :)" [core] - 10https://gerrit.wikimedia.org/r/109493 (owner: 10Physikerwelt)
[16:52:56] <grrrit-wm>	 (03CR) 10Chad: "s/the other patch/this patch/" [core] - 10https://gerrit.wikimedia.org/r/109493 (owner: 10Physikerwelt)
[16:52:59] <grrrit-wm>	 (03PS1) 10Nemo bis: Add Nemo_bis to jenkins trusted users [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/110202 
[16:53:14] <^d>	 I don't trust that Nemo_bis character.
[16:53:19] <^d>	 Awfully shady.
[16:53:23] * Nemo_bis  neither

[16:53:38] <Nemo_bis>	 I was asked to
[16:54:54] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Added a simple JobSpecification class for pushing jobs [core] - 10https://gerrit.wikimedia.org/r/109785 (owner: 10Aaron Schulz)
[16:58:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Added a simple JobSpecification class for pushing jobs [core] - 10https://gerrit.wikimedia.org/r/109785 (owner: 10Aaron Schulz)
[17:02:09] <grrrit-wm>	 (03PS10) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement two new hooks superseding 4 old ones [core] - 10https://gerrit.wikimedia.org/r/106279 
[17:02:11] <grrrit-wm>	 (03PS11) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement webOutput() [core] - 10https://gerrit.wikimedia.org/r/105195 
[17:02:13] <grrrit-wm>	 (03PS10) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement doMainQuery() [core] - 10https://gerrit.wikimedia.org/r/105194 
[17:02:15] <grrrit-wm>	 (03PS11) 10Bartosz Dziewoński: ChangesListSpecialPage: Stop mutating $opts in buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/105196 
[17:02:30] <MatmaRex>	 pushing changes to gerrit has become very fast lately
[17:02:41] <MatmaRex>	 instead, pulling is now incredibly slow
[17:02:42] <addshore>	 aude: said exactly the same things yesterday
[17:02:51] <addshore>	 well.. about pushing at least :P
[17:03:30] <MatmaRex>	 it feels like it queues doing the actual everything and just closes the connection first
[17:03:42] <MatmaRex>	 e.g. looking at how the changes appear on irc, etc
[17:12:10] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] "Bug 60471 is filed and has a WIP patch https://gerrit.wikimedia.org/r/#/c/109923/, let's do this." [core] - 10https://gerrit.wikimedia.org/r/109493 (owner: 10Physikerwelt)
[17:15:10] <grrrit-wm>	 (03PS4) 10Eranroz: Make Popularpages includeable [core] - 10https://gerrit.wikimedia.org/r/107979 
[17:15:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove $wgUseTeX for checking if editing tools should be shown [core] - 10https://gerrit.wikimedia.org/r/109493 (owner: 10Physikerwelt)
[17:16:27] <MatmaRex>	 ^d: tell me, if i report issues with gerrit's new change view, will i get any replies?
[17:16:39] <MatmaRex>	 (when i reported boring ones like gerrit not working on Opera i was ignored)
[17:16:52] <^d>	 Replies by whom? Me or upstream?
[17:16:55] <MatmaRex>	 upstream
[17:17:01] <^d>	 You can *always* count on a snarky reply from me ;-)
[17:17:19] <MatmaRex>	 the new view aint half bad, really
[17:17:22] <MatmaRex>	 got some good ideas
[17:17:23] <^d>	 Ah, upstream. So I'd say yes on CS2.
[17:17:31] <^d>	 Shawn's been very receptive to feedback.
[17:17:37] <MatmaRex>	 (and also some bad ones too, which is what i'll report. :P)
[17:18:39] <grrrit-wm>	 (03PS3) 10Prtksxna: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 
[17:18:42] <grrrit-wm>	 (03CR) 10Frédéric Wang: [C: 031] "Looks good to me. Can someone else please check?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 (owner: 10Physikerwelt)
[17:18:44] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[17:19:43] <grrrit-wm>	 (03CR) 10Frédéric Wang: "@Liangent: can you reconsider that again (see Physikerwel's comment)?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/87519 (owner: 10Liangent)
[17:19:53] <grrrit-wm>	 (03CR) 10Chad: "Do we use any of these customized from the defaults in wmf-config? If so it'll need coordinating for deployment. If we just keep the defau" [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 (owner: 10Physikerwelt)
[17:20:18] <prtksxna>	 Something changed drastically in the .jshintrc file!
[17:22:22] <MatmaRex>	 ^d: okay, thanks
[17:22:49] <^d>	 yw.
[17:23:05] <^d>	 I don't think it's awful. I think it's got some rough edges that still need polishing before everyone *has* to use it :)
[17:28:17] <prtksxna>	 Where can I see the JSHint settings that Jenkins is using? I pulled changes for mediawiki hoping to pull a new .jshintrc file but it still does not give errors whereas the Jenkins build has quite a few - https://integration.wikimedia.org/ci/job/mwext-VectorBeta-jslint/13/console
[17:31:38] <yuvipanda>	 prtksxna: .jshintrc?
[17:31:46] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Save generated parser output to cache in RefreshLinks [core] - 10https://gerrit.wikimedia.org/r/109811 (owner: 10Aaron Schulz)
[17:32:19] <yuvipanda>	 prtksxna: what was changed?
[17:32:24] <yuvipanda>	 I'm opening the patchset
[17:32:30] <yuvipanda>	 slow as fuck, of course :P
[17:32:40] <prtksxna>	 yuvipanda: When I run jshint on my machine I get not errors, but jenkins seems to find a lot
[17:32:52] <prtksxna>	 yuvipanda: And I can't get those errors on my machine
[17:33:13] <ebernhardson>	 prtksxna: we've run into this with flow as well, but havn't had a chance to look into it
[17:33:28] <ebernhardson>	 prtksxna: in our case it was because .jshintrc contained only '{}
[17:33:35] <ebernhardson>	 but i'm not sure yet what jenkins was using as its config
[17:33:42] <yuvipanda>	 paulproteus: ah, hmm
[17:33:44] <yuvipanda>	 yeah, weird
[17:33:57] <yuvipanda>	 prtksxna: does jshintrc pass locally for you?
[17:33:59] <yuvipanda>	 jshint as in
[17:34:02] <yuvipanda>	 ebernhardson: how did you work around it?
[17:34:05] <prtksxna>	 yuvipanda: Yes it does
[17:34:11] * apergos  looks around for a Reedy

[17:34:16] <grrrit-wm>	 (03CR) 10Yuvipanda: "recheck" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[17:34:20] <ebernhardson>	 yuvipanda: just found out yesterday :)
[17:34:24] <yuvipanda>	 ebernhardson: haha!
[17:34:38] <prtksxna>	 ebernhardson: This jshint seems to have rules for spacing convention (or something like that)
[17:34:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Save generated parser output to cache in RefreshLinks [core] - 10https://gerrit.wikimedia.org/r/109811 (owner: 10Aaron Schulz)
[17:35:38] <ebernhardson>	 yuvipanda: this is what our new frontend guy came up with (he also noticed the issue) https://gerrit.wikimedia.org/r/#/c/110107/
[17:35:45] <grrrit-wm>	 (03CR) 10Prtksxna: Add JS/CSS for the new NavigationPopups (038 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[17:35:58] <yuvipanda>	 ebernhardson: heh, I was thinking the same 
[17:36:00] <ebernhardson>	 basically still not sure what jenkins was using, but added a bunch of "somefeature": true
[17:36:20] <yuvipanda>	 ebernhardson: this is js spacing issues, while still following the mw js conventions
[17:36:27] <grrrit-wm>	 (03CR) 10Frédéric Wang: "OK, that looks good to me. For backward compatibility, do we want to keep the MW_MATH_MATHJAX mode in the default wgMathValidModes array? " (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/109488 (owner: 10Physikerwelt)
[17:37:27] * ebernhardson  always forgets that mw has 1-off styles that noone else uses :P

[17:37:53] <yuvipanda>	 ebernhardson: our spacing rules are the worst. We use tabs like cavemen
[17:38:00] <yuvipanda>	 (cavepersons? cavepeople?)
[17:38:14] <ebernhardson>	 yuvipanda: buts its way too late to change :P
[17:38:18] <prtksxna>	 And the ( arg ) thing takes a bit of getting used to
[17:38:21] <yuvipanda>	 ebernhardson: inorite :(
[17:38:23] <yuvipanda>	 prtksxna: yeah, it does
[17:38:40] <ebernhardson>	 it ( could , be , worse )
[17:38:40] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Is this Vector-specific? If no, why this repo?" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[17:38:46] <yuvipanda>	 prtksxna: ignore the jshint -1 for now, we'll work around it
[17:39:01] <prtksxna>	 yuvipanda: Isn't it gone now? I think it is
[17:39:03] <yuvipanda>	 MatmaRex: easier than getting a new extension deployed? :P 
[17:39:05] <ebernhardson>	 but only a little :)
[17:39:10] <MatmaRex>	 heh
[17:39:22] <yuvipanda>	 ebernhardson: oh, my recheck actually fixed it. so it is just jenkins being weird
[17:39:33] <ebernhardson>	 yuvipanda: interesting
[17:39:34] <yuvipanda>	 prtksxna: so if it happens again, just put up a new patch, or comment 'recheck'
[17:39:38] <MatmaRex>	 yuvipanda: i see you'll make good use of the comment-but-don't-send-email feature of new gerrit version
[17:39:41] <prtksxna>	 yuvipanda: got it!
[17:39:54] <yuvipanda>	 MatmaRex: I'll pretend to not know that exists :P
[17:40:01] <yuvipanda>	 MatmaRex: I mean, who doesn't want 3 new emails for every new patchset?
[17:40:02] <grrrit-wm>	 (03PS10) 10Alex Monk: Special:ListGroupRights: Add per-namespace restrictions and rights [core] - 10https://gerrit.wikimedia.org/r/40096 
[17:40:03] <yuvipanda>	 WHO?
[17:40:11] <grrrit-wm>	 (03CR) 10Alex Monk: Special:ListGroupRights: Add per-namespace restrictions and rights (033 comments) [core] - 10https://gerrit.wikimedia.org/r/40096 (owner: 10Alex Monk)
[17:41:07] <yuvipanda>	 prtksxna: wow you actually reply 'done' :D I haven't found anyone else who does that :)
[17:41:21] <yuvipanda>	 MatmaRex: unrelated, but review of that change would also be nice :P
[17:41:37] <prtksxna>	 yuvipanda: Oh! I thought I was *supposed* to do that :\
[17:41:53] <MatmaRex>	 yuvipanda: 36-hour day would also be lovely
[17:42:02] <MatmaRex>	 yuvipanda: i do that :( (sometimes)
[17:42:05] * yuvipanda  gives MatmaRex a body double

[17:42:25] <yuvipanda>	 prtksxna: you can, but, idk. Most people just comment after a new patchset saying 'fixed this, this, that'
[17:42:45] <prtksxna>	 yuvipanda: Hitting done is easier than typing :P
[17:43:05] <yuvipanda>	 prtksxna: heh. well, less time spent interacting with gerrit is good for your mental health! PROVEN BY DOCTORS!
[17:43:11] <prtksxna>	 yuvipanda: Plus, I <3 this Gerrit Game!
[17:43:17] <yuvipanda>	 heh!
[17:44:34] <MatmaRex>	 yuvipanda: umm
[17:44:46] <MatmaRex>	 yuvipanda: prtksxna: is that a hack on top of en.wp's WP:POP?
[17:44:54] <yuvipanda>	 MatmaRex: it's a rewrite
[17:45:01] <yuvipanda>	 MatmaRex: well, not a rewrite as such
[17:45:03] <MatmaRex>	 it'd 150 lines of code
[17:45:05] <MatmaRex>	 it can't be a rewrite
[17:45:06] <yuvipanda>	 MatmaRex: a reader focused replacement
[17:45:31] <yuvipanda>	 prtksxna: can you show MatmaRex the design docs you showed me?
[17:45:40] <MatmaRex>	 let me just run the code
[17:45:47] <prtksxna>	 MatmaRex: https://www.mediawiki.org/wiki/Navigation_Popups_(Restyling_and_Enhancements)
[17:46:46] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 04-1] Add JS/CSS for the new NavigationPopups (033 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[17:48:09] <grrrit-wm>	 (03CR) 10Yuvipanda: Add JS/CSS for the new NavigationPopups (032 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[17:48:20] <yuvipanda>	 MatmaRex: requires Extension:PageImages and Extension:TextExtracts
[17:48:56] <MatmaRex>	 i just imported yair's user script, i assume the code is the same (or close enough)
[17:49:02] <MatmaRex>	 and i quite like it, actually
[17:49:06] <MatmaRex>	 nice thing :)
[17:49:20] <yuvipanda>	 MatmaRex: yeah, pretty close. Just BetaFeaturized
[17:49:28] <yuvipanda>	 prtksxna: left some comments
[17:49:39] <grrrit-wm>	 (03CR) 10Alex Monk: Fixup some bits of code, parameter type documentation etc (033 comments) [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/47311 (owner: 10Reedy)
[17:49:53] <MatmaRex>	 tw comments from me: image-less popups have this big empty space at the bottom: http://i.imgur.com/OAeWuEp.png
[17:50:18] <MatmaRex>	 and popups triggered next to the end of page area can end up partially offscreen (e.g. from infobox)
[17:50:20] <prtksxna>	 yuvipanda: Seeing :)
[17:50:28] <MatmaRex>	 that article is https://en.wikipedia.org/wiki/Associa�ao_Atl�tica_Anapolina (random one)
[17:50:29] <grrrit-wm>	 (03CR) 10Nikerabbit: Special:ListGroupRights: Add per-namespace restrictions and rights (031 comment) [core] - 10https://gerrit.wikimedia.org/r/40096 (owner: 10Alex Monk)
[17:50:42] <MatmaRex>	 also, some of the topic images are being upscaled, which looks awful
[17:51:12] <MatmaRex>	 e.g. http://i.imgur.com/IVKgf7K.png
[17:51:13] <prtksxna>	 I wonder how MatmaRex can still see "Last Edited" and the watch icon
[17:51:24] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Renamed "removeDuplicates" field to be slightly clearer [core] - 10https://gerrit.wikimedia.org/r/110208 
[17:51:24] <MatmaRex>	 prtksxna: i used yair's version
[17:51:26] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Renamed "removeDuplicates" field to be slightly clearer [core] - 10https://gerrit.wikimedia.org/r/110208 (owner: 10Aaron Schulz)
[17:51:26] <AaronSchulz>	 ^d: ^
[17:51:38] <MatmaRex>	 prtksxna: i assumed the code was the same or almost the same :)
[17:51:50] <MatmaRex>	 just quick comments, i don't really have time today, sorry :(
[17:52:12] <^d>	 AaronSchulz: Jenkins says nowai
[17:52:19] <AaronSchulz>	 is jenkins broke?
[17:52:25] <prtksxna>	 MatmaRex: I'll make a note. This isn't the complete design right now, I'll be doing that iteratively
[17:52:31] <^d>	 AaronSchulz: not afaik.
[17:52:38] <MatmaRex>	 AaronSchulz: there's a ug about that
[17:52:39] <AaronSchulz>	 I literally just made that
[17:52:47] * yuvipanda  gives MatmaRex another ug

[17:52:53] <MatmaRex>	 AaronSchulz: https://bugzilla.wikimedia.org/show_bug.cgi?id=53895
[17:53:11] <MatmaRex>	 AaronSchulz: you're i think the ninth person i link this to
[17:53:22] <prtksxna>	 MatmaRex: Image upscaling is a problem, but I am not getting the empty space at bottom problem
[17:53:36] <yuvipanda>	 MatmaRex: were you on Firefox?
[17:53:47] <MatmaRex>	 prtksxna: i'm using Opera 12, that might be a factor ;)
[17:54:03] <yuvipanda>	 MatmaRex: that's pre-modern Opera, right? :P
[17:54:04] * yuvipanda  hides

[17:54:07] <MatmaRex>	 i'll be happy to hunt this down myself if it doesn't happen on more standard browsers
[17:54:11] <MatmaRex>	 yuvipanda: yeah
[17:54:13] <MatmaRex>	 just not today
[17:54:15] <MatmaRex>	 or this week
[17:54:19] <MatmaRex>	 or this month, probably
[17:54:23] <prtksxna>	 Any ideas on what we could do about the image upscaling
[17:54:23] <yuvipanda>	 heh
[17:54:32] <MatmaRex>	 prtksxna: display smaller images? :)
[17:54:32] <prtksxna>	 MatmaRex: The month is over before the week is :P
[17:54:36] <AaronSchulz>	 ^d: yeah, definitely jenkins
[17:54:39] <MatmaRex>	 heh
[17:54:47] <AaronSchulz>	 there is nothing to rebase
[17:54:54] * MatmaRex  shoves https://bugzilla.wikimedia.org/show_bug.cgi?id=53895 at AaronSchulz's face

[17:54:55] <prtksxna>	 MatmaRex: But that breaks the design :\ I'll discuss it with the design team
[17:54:57] <MatmaRex>	 that's the bug
[17:55:07] <MatmaRex>	 i didn't manage to get anyone to fix it
[17:55:08] <MatmaRex>	 yet.
[17:55:20] <yuvipanda>	 prtksxna: saw my comments?
[17:55:25] <MatmaRex>	 jenkins/gerrit are fucked and have been for months now
[17:55:36] <prtksxna>	 yuvipanda: Yes, doing another push in a bit
[17:55:41] <yuvipanda>	 prtksxna: sweet
[17:55:59] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "recheck" [core] - 10https://gerrit.wikimedia.org/r/110208 (owner: 10Aaron Schulz)
[17:56:14] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "-1 caused by https://bugzilla.wikimedia.org/show_bug.cgi?id=53895" [core] - 10https://gerrit.wikimedia.org/r/110208 (owner: 10Aaron Schulz)
[17:58:22] <grrrit-wm>	 (03PS1) 10Mwalker: Merge remote-tracking branch 'gerrit/REL1_22' into fundraising/REL1_22 [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/110209 
[17:58:49] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 04-1] Add assertions in FileBackendTest [core] - 10https://gerrit.wikimedia.org/r/109472 (owner: 10Addshore)
[18:00:25] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Add JS/CSS for the new NavigationPopups (031 comment) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[18:02:38] <grrrit-wm>	 (03CR) 10Nikerabbit: Special:ListGroupRights: Add per-namespace restrictions and rights (031 comment) [core] - 10https://gerrit.wikimedia.org/r/40096 (owner: 10Alex Monk)
[18:02:47] <grrrit-wm>	 (03CR) 10Aaron Schulz: "API purge has:" [core] - 10https://gerrit.wikimedia.org/r/87269 (owner: 10Reedy)
[18:03:44] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 04-1] Add page purge limiter [core] - 10https://gerrit.wikimedia.org/r/87269 (owner: 10Reedy)
[18:04:06] <grrrit-wm>	 (03PS3) 10Brian Wolff: Use master db for showing log extract on RevDel success page [core] - 10https://gerrit.wikimedia.org/r/95828 
[18:04:30] <grrrit-wm>	 (03CR) 10Alex Monk: Validate $this->mAddress before storing it (031 comment) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/107018 (owner: 10Legoktm)
[18:04:49] <grrrit-wm>	 (03PS5) 10Physikerwelt: Introduce $wgMathValidModes to adjust the selectable math rendering modes in user preferences [extensions/Math] - 10https://gerrit.wikimedia.org/r/109488 
[18:04:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Introduce $wgMathValidModes to adjust the selectable math rendering modes in user preferences [extensions/Math] - 10https://gerrit.wikimedia.org/r/109488 (owner: 10Physikerwelt)
[18:05:48] <grrrit-wm>	 (03PS4) 10Prtksxna: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 
[18:05:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[18:06:14] <grrrit-wm>	 (03PS16) 10Eranroz: Support ApiPageSet in ApiWatch [core] - 10https://gerrit.wikimedia.org/r/53964 
[18:06:19] <MatmaRex>	 ^d: hey really, git pulls are awful slow
[18:06:30] <MatmaRex>	 ^d: like, it takes a few minutes to pull down changes
[18:06:31] <grrrit-wm>	 (03CR) 10Eranroz: Support ApiPageSet in ApiWatch (0310 comments) [core] - 10https://gerrit.wikimedia.org/r/53964 (owner: 10Eranroz)
[18:06:39] <grrrit-wm>	 (03CR) 10Prtksxna: "recheck" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[18:06:44] <MatmaRex>	 is this just me? and if not, is this known?
[18:07:05] <Nemo_bis>	 MatmaRex: have you tried changing protocol? sometimes it helps for some reason
[18:07:11] <^d>	 MatmaRex: Fine for me....
[18:07:42] <Nemo_bis>	 MatmaRex: debug info appreciated https://bugzilla.wikimedia.org/show_bug.cgi?id=56034
[18:07:48] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 04-1] "Please add mediawiki.util to dependencies of ext.liquidThreads in LiquidThreads.php." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/110101 (owner: 10Alex Monk)
[18:07:52] <MatmaRex>	 Nemo_bis: via ssh
[18:08:12] <MatmaRex>	 i don't see how https could ever be faster
[18:08:18] <MatmaRex>	 also, still a bug
[18:08:25] <grrrit-wm>	 (03CR) 10Prtksxna: Add JS/CSS for the new NavigationPopups (033 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[18:08:49] <grrrit-wm>	 (03PS17) 10Eranroz: Support ApiPageSet in ApiWatch [core] - 10https://gerrit.wikimedia.org/r/53964 
[18:08:59] <MatmaRex>	 Nemo_bis: what debug info?
[18:09:46] <grrrit-wm>	 (03PS5) 10Prtksxna: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 
[18:09:46] <Nemo_bis>	 MatmaRex: dunno, whatever
[18:10:09] <MatmaRex>	 well i have nothing
[18:10:17] <yuvipanda>	 prtksxna: lol jenkins-bot
[18:10:37] <MatmaRex>	 i'm on Windows XP, git version 1.7.9.msysgit.0, location Poland
[18:11:27] <prtksxna>	 yuvipanda: Is there a particular format in which you want me to add the documentation (the one that you mentioned and I ignored in the first comment)
[18:11:40] <grrrit-wm>	 (03CR) 10Mwalker: [C: 032] Merge remote-tracking branch 'gerrit/REL1_22' into fundraising/REL1_22 [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/110209 (owner: 10Mwalker)
[18:12:31] <grrrit-wm>	 (03PS18) 10Eranroz: Support ApiPageSet in ApiWatch [core] - 10https://gerrit.wikimedia.org/r/53964 
[18:12:35] <yuvipanda>	 prtksxna: just adding // <something> is good enough for me, and seems enough in this case
[18:12:43] <yuvipanda>	 prtksxna: for larger pieces of code and libraries, people prefer https://github.com/senchalabs/jsduck/wiki
[18:13:24] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Use master db for showing log extract on RevDel success page [core] - 10https://gerrit.wikimedia.org/r/95828 (owner: 10Brian Wolff)
[18:13:38] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 04-1] "In general, you should ideally *never* use .css in code. Just use classes instead." (033 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[18:13:39] <yuvipanda>	 prtksxna: more comments
[18:14:38] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Add missing uploadstash.us_props for PostgreSQL [core] - 10https://gerrit.wikimedia.org/r/99676 (owner: 10saper)
[18:15:31] <grrrit-wm>	 (03CR) 10Helder.wiki: [C: 04-1] "Indeed." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/110101 (owner: 10Alex Monk)
[18:15:42] <grrrit-wm>	 (03PS6) 10Physikerwelt: Introduce $wgMathValidModes to adjust the selectable math rendering modes in user preferences [extensions/Math] - 10https://gerrit.wikimedia.org/r/109488 
[18:17:58] <prtksxna>	 yuvipanda: Oh, ok, I'll check it out
[18:18:05] <yuvipanda>	 prtksxna: :)
[18:19:01] <grrrit-wm>	 (03PS1) 10Aaron Schulz: UploadStash us_props fix for Postgres [core] - 10https://gerrit.wikimedia.org/r/110210 
[18:19:31] <grrrit-wm>	 (03CR) 10Swalling: "I think we need to follow-up on @MZMcBride's questions..." [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO)
[18:19:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use master db for showing log extract on RevDel success page [core] - 10https://gerrit.wikimedia.org/r/95828 (owner: 10Brian Wolff)
[18:19:48] <grrrit-wm>	 (03PS1) 10Ottomata: Including apache::mods::wsgi for wikimetrics so package is available [vagrant] - 10https://gerrit.wikimedia.org/r/110211 
[18:19:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add missing uploadstash.us_props for PostgreSQL [core] - 10https://gerrit.wikimedia.org/r/99676 (owner: 10saper)
[18:20:53] <grrrit-wm>	 (03CR) 10Ottomata: "Ori, is this ok, even if mode != apache?" [vagrant] - 10https://gerrit.wikimedia.org/r/110211 (owner: 10Ottomata)
[18:22:22] <grrrit-wm>	 (03PS1) 10UltrasonicNXT: Add links to forum logs [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/110212 
[18:23:01] <grrrit-wm>	 (03CR) 10CSteipp: [C: 032] Update Release Notes and Version number [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110070 (owner: 10CSteipp)
[18:24:10] <Krenair>	 Nikerabbit, well LQT already depends on mediawiki.api, which depends on mediawiki.util itself...
[18:25:37] <Nikerabbit>	 Krenair: I'm not a fan of indirect dependencies
[18:25:51] <Nikerabbit>	 those might break when things are refactored
[18:25:52] <MatmaRex>	 ^d: gerritmail now quotes the inline comment someone is replying to <3
[18:25:59] <^d>	 ya
[18:26:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update Release Notes and Version number [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110070 (owner: 10CSteipp)
[18:26:23] <grrrit-wm>	 (03CR) 10Alex Monk: "Isn't really necessary right now since we already depend on mediawiki.api which itself depends on mediawiki.util. But okay..." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/110101 (owner: 10Alex Monk)
[18:26:28] <MatmaRex>	 now just let us reply by mail and i won't have to ever leavy my mail client ~
[18:26:49] <grrrit-wm>	 (03PS2) 10Alex Monk: Use mw.util.getUrl for generating Link URLs [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/110101 
[18:27:02] <grrrit-wm>	 (03PS2) 10Physikerwelt: WIP: Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 
[18:27:11] <grrrit-wm>	 (03PS1) 10CSteipp: SECURITY: Sanitize shell command args [core] - 10https://gerrit.wikimedia.org/r/110215 
[18:27:46] <grrrit-wm>	 (03CR) 10CSteipp: [C: 032] "Already deployed" [core] - 10https://gerrit.wikimedia.org/r/110215 (owner: 10CSteipp)
[18:27:51] <grrrit-wm>	 (03CR) 10Helder.wiki: [C: 031] Use mw.util.getUrl for generating Link URLs [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/110101 (owner: 10Alex Monk)
[18:28:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 (owner: 10Physikerwelt)
[18:29:08] <grrrit-wm>	 (03PS6) 10Prtksxna: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 
[18:29:15] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[18:29:29] <grrrit-wm>	 (03CR) 10Alex Monk: Validate $this->mAddress before storing it (031 comment) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/107018 (owner: 10Legoktm)
[18:30:52] <grrrit-wm>	 (03CR) 10Prtksxna: "recheck" (033 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[18:31:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: SECURITY: Sanitize shell command args [core] - 10https://gerrit.wikimedia.org/r/110215 (owner: 10CSteipp)
[18:33:36] <prtksxna>	 yuvipanda: My recheck comment seems to have no effect
[18:33:57] <grrrit-wm>	 (03CR) 10Adamw: [C: 032] "Nicely dressed kludge ;)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109628 (owner: 10AndyRussG)
[18:34:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Read DB_MASTER only as needed for summary fields [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109628 (owner: 10AndyRussG)
[18:34:12] <grrrit-wm>	 (03PS3) 10Physikerwelt: WIP: Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 
[18:34:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 (owner: 10Physikerwelt)
[18:36:40] <grrrit-wm>	 (03CR) 10Chad: "Let's go ahead and merge today so this can ride with 1.23wmf12." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106445 (owner: 10Chad)
[18:37:10] <grrrit-wm>	 (03PS2) 10Trevor Parscal: Rough sketch of using OOJS and OOJS-UI for data model and UI [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109808 
[18:37:13] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Rough sketch of using OOJS and OOJS-UI for data model and UI [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109808 (owner: 10Trevor Parscal)
[18:38:04] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] Fix logging [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/105444 (owner: 10Alex Monk)
[18:38:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix logging [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/105444 (owner: 10Alex Monk)
[18:39:08] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 04-1] "Moar minor nitpicks!" (034 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[18:39:13] <yuvipanda>	 prtksxna: more!
[18:39:23] <yuvipanda>	 prtksxna: sorry about the minor nis, but I think you will get used to them in a while
[18:40:08] <grrrit-wm>	 (03PS3) 10Trevor Parscal: Rough sketch of using OOJS and OOJS-UI for data model and UI [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109808 
[18:40:15] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Rough sketch of using OOJS and OOJS-UI for data model and UI [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109808 (owner: 10Trevor Parscal)
[18:40:36] <grrrit-wm>	 (03PS4) 10Physikerwelt: WIP: Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 
[18:40:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 (owner: 10Physikerwelt)
[18:42:38] <prtksxna>	 yuvipanda: Hehe! I am a little unsure of what you mean by "move this conditional out as a if/else outside", you're saying put the result in a variable outside and use it there? Can i still use the ? : or should I write an if/else
[18:43:31] <grrrit-wm>	 (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: dd9ff82..b5df6a2 [extensions] - 10https://gerrit.wikimedia.org/r/110217 
[18:43:33] <grrrit-wm>	 (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: dd9ff82..b5df6a2 [extensions] - 10https://gerrit.wikimedia.org/r/110217 (owner: 10Jenkins-mwext-sync)
[18:43:41] <yuvipanda>	 prtksxna: yup!
[18:43:48] <yuvipanda>	 prtksxna: move it to a variable outside and use it inside
[18:44:07] <prtksxna>	 yuvipanda: And write an if else instead of ? :
[18:44:47] <grrrit-wm>	 (03PS4) 10Trevor Parscal: Rough sketch of using OOJS and OOJS-UI for data model and UI [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109808 
[18:44:53] <yuvipanda>	 prtksxna: yeah
[18:45:02] <prtksxna>	 yuvipanda: butwai?
[18:45:05] <yuvipanda>	 prtksxna: clearer and less indentation, usually
[18:45:14] <yuvipanda>	 prtksxna: the code needs to be de-indented a bit
[18:45:44] <yuvipanda>	 prtksxna: the cache thing should also be moved to be a variable
[18:45:57] <yuvipanda>	 prtksxna: that reduces another level of indent
[18:46:10] <prtksxna>	 yuvipanda: got it
[18:46:16] <yuvipanda>	 prtksxna: :)
[18:46:22] <prtksxna>	 yuvipanda: I was looking at the wrong thing
[18:46:25] <yuvipanda>	 prtksxna: ah!
[18:46:26] <yuvipanda>	 ok
[18:46:37] <prtksxna>	 yuvipanda: I was looking at L142
[18:46:52] <prtksxna>	 yuvipanda: But I guess you are talking about L140-145
[18:46:52] <grrrit-wm>	 (03PS5) 10Physikerwelt: WIP: Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 
[18:46:59] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 (owner: 10Physikerwelt)
[18:47:30] <yuvipanda>	 prtksxna: yeah, 142 is fine, I was talking about 140-145
[18:47:33] <yuvipanda>	 prtksxna: and 149
[18:47:44] <yuvipanda>	 prtksxna: 142 is ok I think
[18:47:50] <prtksxna>	 yuvipanda: Right
[18:48:05] <prtksxna>	 yuvipanda: But 149 and 142 are the same
[18:48:08] <prtksxna>	 yuvipanda: Similar
[18:48:22] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Add handler for GetLogTypesOnUser hook [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/105433 (owner: 10Umherirrender)
[18:48:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add handler for GetLogTypesOnUser hook [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/105433 (owner: 10Umherirrender)
[18:48:30] <yuvipanda>	 prtksxna: but conditional in 149 is longer
[18:48:35] <yuvipanda>	 prtksxna: much longer
[18:48:48] <yuvipanda>	 prtksxna: I think ? : is okay if the boolean is a single variable, and nothing more
[18:49:04] <physikerwelt>	 hi, is anybody around how is familar with mediawiki specific javascript
[18:49:28] <physikerwelt>	 I want to find out how to access $wgLang and wfMessage from javascript
[18:49:45] <prtksxna>	 yuvipanda: Understood
[18:50:36] <yuvipanda>	 physikerwelt: https://www.mediawiki.org/wiki/Manual:Messages_API#Using_messages_in_JavaScript
[18:50:44] <yuvipanda>	 physikerwelt: mw.message I think
[18:51:50] <grrrit-wm>	 (03PS2) 10EBernhardson: Use InvalidDataException [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110194 (owner: 10Matthias Mullie)
[18:52:05] <grrrit-wm>	 (03CR) 10EBernhardson: Use InvalidDataException (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110194 (owner: 10Matthias Mullie)
[18:52:08] <grrrit-wm>	 (03PS1) 10Manybubbles: Test general ordering of results [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110218 
[18:52:22] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] "PS2: put exception use statements in alphabetical order" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110194 (owner: 10Matthias Mullie)
[18:52:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use InvalidDataException [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110194 (owner: 10Matthias Mullie)
[18:53:28] <yuvipanda>	 physikerwelt: also there exists window.wgContentLanguage
[18:54:57] <physikerwelt>	 ok cool. do you think I courious if 'image' =>02window.wgContentLanguage01.getImageFile( 'button-math' ) just works
[18:55:06] <Nikerabbit>	 hi yuvipanda
[18:55:32] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] Use mw.util.getUrl for generating Link URLs [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/110101 (owner: 10Alex Monk)
[18:55:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use mw.util.getUrl for generating Link URLs [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/110101 (owner: 10Alex Monk)
[18:56:11] <yuvipanda>	 hi Nikerabbit
[18:56:33] <grrrit-wm>	 (03CR) 10EBernhardson: Create test for bug 59637 (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108879 (owner: 10Werdna)
[18:56:36] <Nikerabbit>	 yuvipanda: did you see I marked one AndroidFFS bug (almost) as wontfix
[18:57:01] <yuvipanda>	 Nikerabbit: oooh?! which one?
[18:57:06] <yuvipanda>	 Nikerabbit: i didn't
[18:58:30] <Nikerabbit>	 yuvipanda: html inside message
[18:58:44] <Nikerabbit>	 only i u b or so are allowed
[19:00:20] <grrrit-wm>	 (03PS7) 10Prtksxna: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 
[19:00:29] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[19:02:50] <grrrit-wm>	 (03CR) 10Prtksxna: Add JS/CSS for the new NavigationPopups (033 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[19:03:32] <grrrit-wm>	 (03CR) 10Prtksxna: "recheck" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[19:05:13] <grrrit-wm>	 (03CR) 10Adamw: [C: 04-1] "Maybe I'm misunderstanding here, but if the summary refresh stuff is generic and not coupled to undelete, it should really be in a separat" (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109643 (owner: 10AndyRussG)
[19:06:15] <grrrit-wm>	 (03PS1) 10UltrasonicNXT: Use placeholder instead of value [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/110219 
[19:07:40] <grrrit-wm>	 (03CR) 10Adamw: [C: 04-1] "The schema upgrade must be deployed in a separate commit from any usage of the new schema. If they are deployed together, the site will b" (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109843 (owner: 10AndyRussG)
[19:07:58] <grrrit-wm>	 (03PS3) 10Nemo bis: Add composer.json file [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/109864 (owner: 10Adrian Lang)
[19:08:32] <grrrit-wm>	 (03PS6) 10Physikerwelt: WIP: Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 
[19:08:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 (owner: 10Physikerwelt)
[19:09:15] <MatmaRex>	 !flaggedrevs del
[19:09:15] <wm-bot>	 Successfully removed flaggedrevs
[19:09:16] <MatmaRex>	 !flaggedrevs is The Flagged Revisions extension allows for Editor and Reviewer users to rate revisions of articles and set those revisions as the default revision to show upon normal page view. https://www.mediawiki.org/wiki/Extension:FlaggedRevs
[19:09:16] <wm-bot>	 Key was added
[19:10:52] <grrrit-wm>	 (03PS7) 10Physikerwelt: WIP: Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 
[19:12:24] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Test general ordering of results [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110218 (owner: 10Manybubbles)
[19:12:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Test general ordering of results [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110218 (owner: 10Manybubbles)
[19:13:06] <physikerwelt>	 yuvipanda: thank you for your suggestions... but for some reason the text is not loaded
[19:13:09] <Krenair>	 MatmaRex, meh, I'm just not quite fast enough :)
[19:13:32] <MatmaRex>	 hmm?
[19:14:16] <Krenair>	 MatmaRex, we replied to that mediawiki-l db error post at roughly the same time but you were slightly faster
[19:15:21] <MatmaRex>	 ah. oh
[19:15:27] <MatmaRex>	 well, we replied differently, so that's good :D
[19:15:57] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 04-1] Add JS/CSS for the new NavigationPopups (033 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[19:16:38] <yuvipanda>	 physikerwelt: hmm?
[19:20:57] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] Add composer.json file [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/109864 (owner: 10Adrian Lang)
[19:22:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add composer.json file [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/109864 (owner: 10Adrian Lang)
[19:26:01] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Update mediawiki.ui button styles [core] - 10https://gerrit.wikimedia.org/r/103494 (owner: 10JGonera)
[19:29:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update mediawiki.ui button styles [core] - 10https://gerrit.wikimedia.org/r/103494 (owner: 10JGonera)
[19:31:35] <grrrit-wm>	 (03PS3) 10Chad: Remove ugly code duplication in ReindexForkController [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106445 
[19:33:07] <grrrit-wm>	 (03CR) 10Reza: "Cscott: If you want more detail by illustrated images of what typographical difference available that is not feasible to resolve just with" [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/110174 (owner: 10Reza)
[19:33:29] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] "Rebased, tested, and approved." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106445 (owner: 10Chad)
[19:33:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove ugly code duplication in ReindexForkController [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106445 (owner: 10Chad)
[19:46:33] <grrrit-wm>	 (03CR) 10SG: "Absolutely. At a later point I will make sure jenkins and the repo are both using the exact same jshint options." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110107 (owner: 10SG)
[19:49:52] <grrrit-wm>	 (03CR) 10Adamw: "OH NO: looks like there is some brokenness." (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109628 (owner: 10AndyRussG)
[19:51:30] <AndyRussG>	 Really? I think it does exist
[19:51:57] <AndyRussG>	 The original codebase is verrry convoluted on this, but that is the function it uses for orgs. For courses it's different :p
[19:52:56] <AndyRussG>	 Oops that was meant for a different channel
[19:54:55] <grrrit-wm>	 (03CR) 10Physikerwelt: "What is the best way to view all the MW config?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 (owner: 10Physikerwelt)
[19:56:34] <spage>	 superm401: can you add Isarra to the Hack "day" calendar?  PM him your gmail so he can invite you, he's setting up a Hangout
[19:58:01] <superm401>	 spage, alright.
[20:02:25] <grrrit-wm>	 (03PS7) 10Spage: [WIP] Update login and HTMLForm to new design [core] - 10https://gerrit.wikimedia.org/r/104011 
[20:04:36] <yuvipanda>	 jdlrobson: prtksxna is working on https://gerrit.wikimedia.org/r/#/c/109878/, and since you are da boss of VectorBeta, wanted to draw your attention to it :)
[20:04:53] <yuvipanda>	 jdlrobson: I'll probably merge it (with a feature flag) at some point of time, if that's ok with you
[20:05:51] <spage>	 superm401: MatmaRex and I don't see Isarra on the Hack day invite
[20:05:52] <grrrit-wm>	 (03PS8) 10Prtksxna: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 
[20:07:35] <grrrit-wm>	 (03CR) 10Prtksxna: Add JS/CSS for the new NavigationPopups (033 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[20:09:11] <grrrit-wm>	 (03PS1) 10Reedy: Fix public vars to protected, add accessors [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110223 
[20:09:35] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Fix public vars to protected, add accessors [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110223 (owner: 10Reedy)
[20:09:36] <superm401>	 spage, sorryjust saw your PM.
[20:09:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix public vars to protected, add accessors [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110223 (owner: 10Reedy)
[20:11:19] <superm401>	 Isarra, you're invited.
[20:13:10] <grrrit-wm>	 (03CR) 10Adamw: "Revert my previous comment... The not-missing function comes from core." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109628 (owner: 10AndyRussG)
[20:14:22] <grrrit-wm>	 (03PS2) 10Bsitu: Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 
[20:16:24] <Isarra>	 superm401: Thanks.
[20:17:00] <jgonera>	 shahyar, have you managed to get Trevor's patch to work?
[20:18:21] <grrrit-wm>	 (03PS3) 10Bsitu: Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 
[20:20:43] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 04-1] Add JS/CSS for the new NavigationPopups (031 comment) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[20:20:48] <yuvipanda>	 prtksxna: last of my comments.
[20:20:56] <yuvipanda>	 jdlrobson: can you look at ^?
[20:21:05] * prtksxna  clicks

[20:21:17] <yuvipanda>	 jdlrobson: not the comment, but the patch?
[20:22:43] <grrrit-wm>	 (03PS9) 10Prtksxna: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 
[20:23:05] <grrrit-wm>	 (03CR) 10Prtksxna: Add JS/CSS for the new NavigationPopups (031 comment) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[20:23:36] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 031] "Looks good to me, but I'm going to give others some time to chip in before I merge." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[20:26:10] <grrrit-wm>	 (03PS1) 10Jdlrobson: Documentation: Tweak documentation of MediaWiki UI buttons [core] - 10https://gerrit.wikimedia.org/r/110225 
[20:26:53] <prtksxna>	 no wait
[20:27:16] <yuvipanda>	 prtksxna: hmm?
[20:27:45] <prtksxna>	 yuvipanda: nothing, i dunno, too sleepy. lol
[20:28:20] <yuvipanda>	 prtksxna: kk go sleep!
[20:31:30] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Documentation: Tweak documentation of MediaWiki UI buttons [core] - 10https://gerrit.wikimedia.org/r/110225 (owner: 10Jdlrobson)
[20:34:27] <grrrit-wm>	 (03PS1) 10Physikerwelt: Introduce orthogonal option to enable MathJax [extensions/Math] - 10https://gerrit.wikimedia.org/r/110226 
[20:34:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Documentation: Tweak documentation of MediaWiki UI buttons [core] - 10https://gerrit.wikimedia.org/r/110225 (owner: 10Jdlrobson)
[20:36:30] <grrrit-wm>	 (03PS2) 10Umherirrender: Rollback: Make update of recentchanges table later [core] - 10https://gerrit.wikimedia.org/r/109706 
[20:39:36] <grrrit-wm>	 (03CR) 10Physikerwelt: "I added the follow-up commit so that one understands what Frédéric means with the orthogonal rendering mode." [extensions/Math] - 10https://gerrit.wikimedia.org/r/109488 (owner: 10Physikerwelt)
[20:40:46] <grrrit-wm>	 (03CR) 10Physikerwelt: "Furthermore it might make sense to merge those two commits in a row. Therby people need to change their config only once." [extensions/Math] - 10https://gerrit.wikimedia.org/r/109488 (owner: 10Physikerwelt)
[20:42:39] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] "I played with this a bit and I hereby declare it Good Enough." [core] - 10https://gerrit.wikimedia.org/r/99258 (owner: 10M4tx)
[20:43:25] <grrrit-wm>	 (03CR) 10Umherirrender: "When transclude it is also possible to pass the limit as parameter: {{Special:PopularPages|limit=10}}, but as $par is also okay" [core] - 10https://gerrit.wikimedia.org/r/107979 (owner: 10Eranroz)
[20:43:26] <wm-bot>	 https://www.mediawiki.org/wiki/Special:Template:PopularPages 
[20:46:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add an SVG version of watch icon [core] - 10https://gerrit.wikimedia.org/r/99258 (owner: 10M4tx)
[20:51:01] <grrrit-wm>	 (03CR) 10Nikerabbit: "Needs rebase?" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/99349 (owner: 10saper)
[20:52:59] <grrrit-wm>	 (03PS12) 10SG: Implement better scrolling via conditionalScroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 
[20:53:08] <grrrit-wm>	 (03CR) 10SG: "Rebased." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 (owner: 10SG)
[20:54:14] <se4598>	 hey hashar, do you have 2 minutes to look at a very simple one line fix for a feature you implemented a while ago? https://gerrit.wikimedia.org/r/110168
[20:56:40] <^d>	 Nikerabbit: Ping.
[20:57:43] <^d>	 Time for a bikeshed. Who's got an opinion and wants to chime in?
[20:57:57] <brion>	 bike shed should be GREEN
[20:58:18] <^d>	 Long as it's old gerrit puke green!
[20:58:45] <AaronSchulz>	 is puke ever that shade of green?
[20:59:05] <^d>	 You should probably see a doctor if so.
[20:59:05] <grrrit-wm>	 (03PS1) 10Reedy: Use real name if set, else use username [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110229 
[20:59:07] <Nikerabbit>	 ^d: sounds dangerous
[20:59:20] <^d>	 Nikerabbit! You can join my bikeshed!
[20:59:25] <grrrit-wm>	 (03CR) 10Adamw: [C: 032] Accurately report institution activity (032 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109631 (owner: 10AndyRussG)
[20:59:33] <^d>	 I'm not happy with the i18n wording we're adding in gerrit 110084.
[20:59:37] <^d>	 Right now, we've got this:
[20:59:42] <^d>	 »   'cirrussearch-parse-error' => "We could not complete your search because we didn't understand it
[20:59:42] <^d>	 . We'll learn how to understand it soon but in the mean time try again with fewer 'special' characte
[20:59:42] <^d>	 rs.",
[20:59:57] <^d>	 I'm...not thrilled with the wording.
[21:00:03] <^d>	 But I'm at a loss for better.
[21:00:22] <yuvipanda>	 werdna: MatmaRex hmm, so if I get a warning abusefilter message, just submitting the same edit again should go through, right?
[21:00:28] <Reedy>	 IT NO WORK. SORRY
[21:00:53] <^d>	 BAD SEARCH, TRY AGAIN!
[21:00:56] <MatmaRex>	 yuvipanda: yeah
[21:01:03] <yuvipanda>	 MatmaRex: hmm, doesn't seem to be happening :|
[21:01:17] <Nikerabbit>	 ugh
[21:01:22] <se4598>	 abusefilter warns and blocks alternating
[21:01:30] <MatmaRex>	 heh
[21:01:35] <se4598>	 if the filter is on warn and block
[21:01:50] <yuvipanda>	 this is just warn
[21:01:54] <^d>	 Nikerabbit: So, I'm trying to come up with something that basically means the same but isn't confusing.
[21:02:04] <yuvipanda>	 it is https://test.wikipedia.org/wiki/Special:AbuseFilter/2
[21:02:47] <se4598>	 ooh, poop-filer is private :(
[21:02:54] <yuvipanda>	 oh?
[21:03:00] <se4598>	 *filter
[21:03:17] <yuvipanda>	 heh, poop-filer
[21:03:27] <Nikerabbit>	 ^d: simple suggestion: "Query was not understood. Please make it simpler." and if you think it's needed, add "The query was logged to improve the search system."
[21:03:31] <^d>	 yuvipanda: Who's filing poop?
[21:03:40] <yuvipanda>	 ^d: me, mhurd and brion, mostly
[21:03:46] <Reedy>	 Nikerabbit: Well, ideally it needs to be logged first ;)
[21:03:47] <yuvipanda>	 (testing abusefilter for the mobile app)
[21:03:51] <^d>	 Nikerabbit: I like that, I like it a lot.
[21:04:45] <grrrit-wm>	 (03PS3) 10Chad: Catch parse errors from Elasticsearch and retry [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110084 (owner: 10Manybubbles)
[21:04:50] <^d>	 Nikerabbit: Thanks!
[21:05:51] <grrrit-wm>	 (03CR) 10Chad: "You're looking for the operations/mediawiki-config repository. Everything should be there." [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 (owner: 10Physikerwelt)
[21:05:54] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 031] "Sounds good to me. Ready to merge?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110084 (owner: 10Manybubbles)
[21:06:48] <^d>	 manybubbles: One typo I'm nitpicking over.
[21:06:53] <^d>	 Otherwise, yes, let's get it in.
[21:07:10] <manybubbles>	 ^d: oh, is there a comment for it?
[21:07:19] <^d>	 No, I just spotted it.
[21:07:22] <^d>	 Typo in qqq message.
[21:07:29] <grrrit-wm>	 (03PS4) 10Chad: Catch parse errors from Elasticsearch and retry [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110084 (owner: 10Manybubbles)
[21:07:34] <^d>	 {{fixed}}
[21:07:34] <wm-bot>	 https://www.mediawiki.org/wiki/Template:fixed 
[21:07:40] <hashar>	 se4598: hello!  The poor strip prefix function is definitely bugged: (
[21:07:44] <^d>	 oh shut up wm-bot
[21:08:51] <se4598>	 hashar: doesn't function correct or bad designed?
[21:09:02] <hashar>	 se4598: basically: our code sucks :-]
[21:09:05] <grrrit-wm>	 (03CR) 10EBernhardson: Fix permissions (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109084 (owner: 10Matthias Mullie)
[21:09:21] <hashar>	 se4598: ideally we would have a list of parameter at one place and all the code would reuse that list
[21:09:32] <grrrit-wm>	 (03PS5) 10EBernhardson: Fix permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109084 (owner: 10Matthias Mullie)
[21:09:44] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Fix permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109084 (owner: 10Matthias Mullie)
[21:09:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109084 (owner: 10Matthias Mullie)
[21:10:05] <grrrit-wm>	 (03PS1) 10Manybubbles: Combine all incoming link counts into one field [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110232 
[21:11:30] <manybubbles>	 ^d: I can't see the difference
[21:11:48] <^d>	 hopefull -> hopefully in final patch set.
[21:11:49] <grrrit-wm>	 (03PS5) 10Manybubbles: Catch parse errors from Elasticsearch and retry [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110084 
[21:12:20] <^d>	 manybubbles: https://gerrit.wikimedia.org/r/#/c/110084/3..4/CirrusSearch.i18n.php
[21:12:22] <se4598>	 hashar: maybe next time :) let's fix what we have a patch for ;-)
[21:12:26] <manybubbles>	 ^d: wow hard to see
[21:12:31] <^d>	 :)
[21:12:43] <manybubbles>	 the whole page is green already
[21:12:49] <manybubbles>	 and one character is more green
[21:12:55] <manybubbles>	 no chance to see that
[21:13:01] <manybubbles>	 well, I can merge if you are happy
[21:13:18] <hashar>	 se4598: sounds good to me. Thanks!
[21:13:32] <^d>	 manybubbles: mergemergemerge!
[21:13:53] <grrrit-wm>	 (03CR) 10Manybubbles: "Reached consensus with Chad that this is good over IRC. Merging." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110084 (owner: 10Manybubbles)
[21:13:58] <grrrit-wm>	 (03PS2) 10Reedy: Use real name if set, else use username [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110229 
[21:14:32] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Use real name if set, else use username [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110229 (owner: 10Reedy)
[21:14:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use real name if set, else use username [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/110229 (owner: 10Reedy)
[21:14:49] <grrrit-wm>	 (03PS2) 10Hashar: Special:PrefixIndex omits stripprefix=1 for "Next page" link [core] - 10https://gerrit.wikimedia.org/r/110168 (owner: 10Se4598)
[21:14:59] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Special:PrefixIndex omits stripprefix=1 for "Next page" link [core] - 10https://gerrit.wikimedia.org/r/110168 (owner: 10Se4598)
[21:15:03] <hashar>	 se4598: I have added a release notes entry
[21:15:52] <se4598>	 hashar: ok, thanks. I found that bug yesterday
[21:16:11] <hashar>	 se4598: completely forgot the next/prev links sorry :(
[21:16:37] <hashar>	 not sure whether we want to backport it in 1.22, I guess it is minor enough that we don't have too
[21:16:39] <hashar>	 to
[21:16:55] <se4598>	 prev-links are still TODO, don't they?
[21:17:23] <hashar>	 damn
[21:17:25] <hashar>	 havent tested that
[21:17:35] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Catch parse errors from Elasticsearch and retry [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110084 (owner: 10Manybubbles)
[21:17:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Catch parse errors from Elasticsearch and retry [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110084 (owner: 10Manybubbles)
[21:17:41] <^d>	 manybubbles: You forgot +2 :)
[21:17:45] <^d>	 You just said "merging"
[21:17:46] <^d>	 :)
[21:18:21] <manybubbles>	 damn it
[21:19:14] <se4598>	 "damn"-time?
[21:22:37] <hashar>	 se4598: i don't have any previous link on Special:PrefixIndex :/
[21:22:44] <grrrit-wm>	 (03CR) 10Chad: Combine all incoming link counts into one field (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110232 (owner: 10Manybubbles)
[21:23:02] <se4598>	 hashar: yep: ### @todo FIXME: Side link to previous
[21:23:19] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Special:PrefixIndex omits stripprefix=1 for "Next page" link [core] - 10https://gerrit.wikimedia.org/r/110168 (owner: 10Se4598)
[21:23:21] <hashar>	 ok
[21:23:24] <hashar>	 se4598: approving the fix
[21:23:32] <hashar>	 se4598: feel free to add back links :-]
[21:23:39] <grrrit-wm>	 (03CR) 10Mattflaschen: "Did Yair Rand okay putting their code under GPLv2 or later?" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna)
[21:24:18] <grrrit-wm>	 (03CR) 10Manybubbles: Combine all incoming link counts into one field (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110232 (owner: 10Manybubbles)
[21:26:18] <se4598>	 hashar: if you think of backport, you take the necessary steps or can I resolve fix the (my own) bug?
[21:26:37] <se4598>	 I'm only a tiny reporter :D
[21:26:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Special:PrefixIndex omits stripprefix=1 for "Next page" link [core] - 10https://gerrit.wikimedia.org/r/110168 (owner: 10Se4598)
[21:26:59] <hashar>	 se4598: that is how MediaWiki and Wikipedia has been build:  tiny edits / reports
[21:27:24] <hashar>	 se4598: I am not sure what is the backport policy for small bugs nowadays.  I guess you can cherry pick the merged change on REL1_22 
[21:28:01] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Combine all incoming link counts into one field (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110232 (owner: 10Manybubbles)
[21:28:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Combine all incoming link counts into one field [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110232 (owner: 10Manybubbles)
[21:28:33] <hashar>	 se4598: though when proposing the change for REL1_22 you will have to move the release notes to release-notes-1.22 file
[21:28:55] <^d>	 manybubbles: Good progress :) https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/CirrusSearch,n,z
[21:29:02] <hashar>	 se4598: or use the 'Backport_to_Stable' flag in bugzilla https://bugzilla.wikimedia.org/show_bug.cgi?id=60543
[21:29:05] <se4598>	 according to https://www.mediawiki.org/wiki/Backporting_fixes I will set the Backport_to_Stable-flag and wait
[21:29:18] <manybubbles>	 ^d: yeah, we developed a bit of a backlog
[21:29:24] <manybubbles>	 I'm almost done with the WIP
[21:29:34] <hashar>	 se4598: ah yeah documentation. Keep forgetting about reading the doc :D
[21:30:26] <se4598>	 undocumented alongside documented parameters are the best
[21:33:09] <grrrit-wm>	 (03PS1) 10EBernhardson: Implement pre-commit hook running less, jshint, and phplint checks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110235 
[21:33:33] <se4598>	 hashar: backport WMF too? I think the one (or 2) weeks doesn't matter
[21:34:08] <hashar>	 se4598: yeah that is not worth the effort
[21:34:23] <hashar>	 se4598: we mostly backport to wmf severe issues / blockers for other extensions
[21:34:44] <hashar>	 se4598: for a tiny change like that which is barely impacting anyone, I guess it can wait a couple weeks
[21:38:38] <grrrit-wm>	 (03PS2) 10Manybubbles: Tweak search config for performance [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110178 
[21:38:51] <manybubbles>	 working through that backlog....
[21:40:43] <AaronSchulz>	 gwicke: I have http://pastebin.com/122qbyz7 working locally \o/
[21:41:07] <grrrit-wm>	 (03PS1) 10Mno2: BetaFeatures: Show number of users who enabled auto-enroll option [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/110238 
[21:43:25] <gwicke>	 AaronSchulz, nice!
[21:44:21] <gwicke>	 AaronSchulz, what's your thinking on making the method and url positional for brevity?
[21:44:48] <gwicke>	 array('GET', 'url', array(/*options*/));
[21:45:33] <grrrit-wm>	 (03CR) 10Physikerwelt: "grep does not find LaTeX at all in that repository. However, there are some links to the local fs that can not be resolved... I'm quite su" [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 (owner: 10Physikerwelt)
[21:46:04] <AaronSchulz>	 or maybe I can leave it as is but make it so that having the first two key/value pairs work as method/URL if the keys are integers
[21:46:23] <AaronSchulz>	 so you could have array( 'GET', <url>, 'headers' => array(...) )
[21:46:50] <hashar>	 I am off , have a good day
[21:47:01] <grrrit-wm>	 (03CR) 10CSteipp: "Posted on the bug" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/105233 (owner: 10CSteipp)
[21:48:08] <gwicke>	 AaronSchulz: ah, had not considered that
[21:49:45] <gwicke>	 makes sense
[21:50:20] <gwicke>	 so either [0] or ["method"], and [1] or ["uri"]
[22:00:46] <grrrit-wm>	 (03PS1) 10Manybubbles: Shirt the shingle size used for suggestions [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110241 
[22:03:24] <grrrit-wm>	 (03PS2) 10Manybubbles: Shrink the shingle size used for suggestions [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110241 
[22:03:27] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Add 'Terms of use' below all user input box [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105873 (owner: 10Bsitu)
[22:03:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add 'Terms of use' below all user input box [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105873 (owner: 10Bsitu)
[22:08:38] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Oh dammit guys, not even all Wikimedia wikis use this license. There's no reason not to use the standard text; you could just add a parame" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105873 (owner: 10Bsitu)
[22:08:45] <MatmaRex>	 paging legal� :P
[22:09:52] <grrrit-wm>	 (03CR) 10EBernhardson: "This isn't going to all wikimedia wiki's, this is going out to specifically the places this is needed. There is another patch on the way " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105873 (owner: 10Bsitu)
[22:13:37] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Also, the messages are not documented at all, and make no mention that this is the same text as the standard one – and we (hopefully) all " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105873 (owner: 10Bsitu)
[22:14:11] <grrrit-wm>	 (03PS2) 10AndyRussG: Add last_active_date column to the orgs table [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109843 
[22:16:16] <grrrit-wm>	 (03PS1) 10Reedy: WIP: Add messages for Trademark Licensing form for foundationwiki [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/110243 
[22:16:30] <grrrit-wm>	 (03CR) 10Reedy: [C: 04-1] WIP: Add messages for Trademark Licensing form for foundationwiki [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/110243 (owner: 10Reedy)
[22:19:54] <grrrit-wm>	 (03PS1) 10Yaron Koren: Improved SMW 1.9 support, given a recent-ish change in the SMW code [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/110244 
[22:20:27] <grrrit-wm>	 (03CR) 10EBernhardson: "If you have concerns watch this space for another patch, but regardless this is going out with tomorrows branch cut." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105873 (owner: 10Bsitu)
[22:20:53] <grrrit-wm>	 (03CR) 10Yaron Koren: [C: 032 V: 032] Improved SMW 1.9 support, given a recent-ish change in the SMW code [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/110244 (owner: 10Yaron Koren)
[22:21:03] <grrrit-wm>	 (03PS2) 10Physikerwelt: Introduce orthogonal option to enable MathJax [extensions/Math] - 10https://gerrit.wikimedia.org/r/110226 
[22:22:31] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Sure, AFAIK you're just deploying to en.wp, in which case you don't even really need a translation; still, this commit introduces a bug th" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105873 (owner: 10Bsitu)
[22:24:17] <grrrit-wm>	 (03CR) 10Adamw: [C: 032] Add last_active_date column to the orgs table [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109843 (owner: 10AndyRussG)
[22:24:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add last_active_date column to the orgs table [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109843 (owner: 10AndyRussG)
[22:24:28] <grrrit-wm>	 (03CR) 10Bsitu: [WIP] Revamp API (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm)
[22:26:54] <grrrit-wm>	 (03PS1) 10Chad: Move global constants that aren't used outside of here to class constants [core] - 10https://gerrit.wikimedia.org/r/110246 
[22:28:24] <grrrit-wm>	 (03CR) 10Deskana: [C: 031] "Looks great. +1." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/105233 (owner: 10CSteipp)
[22:29:43] <grrrit-wm>	 (03PS1) 10Manybubbles: Fix another fun class of parse errors! [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110247 
[22:30:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Move global constants that aren't used outside of here to class constants [core] - 10https://gerrit.wikimedia.org/r/110246 (owner: 10Chad)
[22:30:40] <grrrit-wm>	 (03CR) 10Manybubbles: "Can't be double escaping those ~s." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110247 (owner: 10Manybubbles)
[22:30:44] <AaronSchulz>	 gwicke: now I have http://pastebin.com/1m2BWqd5 
[22:31:29] <AaronSchulz>	 of course SwiftVirtualRESTService could handle etag/content-length internally
[22:31:46] <gwicke>	 AaronSchulz, nice!
[22:32:06] <gwicke>	 could almost handle the body positional too
[22:32:14] <gwicke>	 for put
[22:33:59] <gwicke>	 array('PUT', 'url', 'body');
[22:34:46] <grrrit-wm>	 (03PS1) 10Se4598: Special:PrefixIndex omits stripprefix=1 for "Next page" link [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110248 
[22:34:48] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Shrink the shingle size used for suggestions [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110241 (owner: 10Manybubbles)
[22:35:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Shrink the shingle size used for suggestions [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110241 (owner: 10Manybubbles)
[22:36:11] <gwicke>	 AaronSchulz, do you prefer runMulti over run?
[22:37:05] <grrrit-wm>	 (03CR) 10EBernhardson: "somewhere along the lines, the expand/collapse for moderated posts has disapeared" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 (owner: 10SG)
[22:37:16] <grrrit-wm>	 (03CR) 10Se4598: "backport to 1.22 submitted as I92348b66e95e51fa5cff97cd316012d6a9cf5a86" [core] - 10https://gerrit.wikimedia.org/r/110168 (owner: 10Se4598)
[22:37:51] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Tweak search config for performance [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110178 (owner: 10Manybubbles)
[22:37:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tweak search config for performance [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110178 (owner: 10Manybubbles)
[22:38:47] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Fix another fun class of parse errors! [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110247 (owner: 10Manybubbles)
[22:38:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix another fun class of parse errors! [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110247 (owner: 10Manybubbles)
[22:40:24] <AaronSchulz>	 gwicke: run() was already taken
[22:40:33] <grrrit-wm>	 (03CR) 10EBernhardson: "also the fly-outs for topics along with post moderation dont work, they don't appear to have been bound since the browser jumps to the top" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 (owner: 10SG)
[22:40:35] <^d>	 Who wants an easy core change?
[22:40:36] <^d>	 :)
[22:40:52] <MaxSem>	 ^d, I see "Validating mapping for page type...different...corrected" every time I update index even if there were no changes - is that expected?
[22:41:19] <AaronSchulz>	 gwicke: e.g. ->run( array( 'GET', <url>, ... )
[22:41:19] <^d>	 It shouldn't be different if there's no changes, hm.
[22:41:19] <gwicke>	 AaronSchulz, in the VirtualRESTService class?
[22:41:33] <AaronSchulz>	 yes
[22:42:28] <gwicke>	 could we use func_get_args to save the outer array?
[22:43:21] <gwicke>	 $vrs->run(array('GET',..), arrray('PUT', ..));
[22:44:07] <gwicke>	 although I guess sometimes it is more convenient to build up an array of requests
[22:44:34] <grrrit-wm>	 (03PS26) 10Bsitu: Topic and Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 
[22:45:26] <grrrit-wm>	 (03PS1) 10Aaron Schulz: MultiHttpClient tweaks [core] - 10https://gerrit.wikimedia.org/r/110250 
[22:46:14] <gwicke>	 AaronSchulz, maybe we could switch between array-of-arrays behavior and multiple array params dynamically
[22:46:25] <AaronSchulz>	 gwicke: much easier, otherwise you need to build up an array and use call_user_func_array (as with redis)
[22:47:14] <TimStarling>	 is the patched libevent still needed by hiphop?
[22:47:38] <^d>	 TimStarling: Not if you're building for FastCGI. Then you can just use libevent2 unpatched.
[22:47:39] <gwicke>	 AaronSchulz, I was just wondering if we could use the same method to handle both array-of-arrays and multiple arrays
[22:47:39] <grrrit-wm>	 (03CR) 10Bsitu: [C: 031] "Patch set 26 is a rebase." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu)
[22:47:49] <TimStarling>	 thanks
[22:47:56] <^d>	 you're welcome
[22:48:36] <AaronSchulz>	 gwicke: you could...since the multi-arg way would start with a string arg and the other one an array arg as argument 0
[22:50:08] <gwicke>	 might save some documentation
[22:52:48] <AaronSchulz>	 ^d: https://gerrit.wikimedia.org/r/#/c/110208/
[22:53:07] <AaronSchulz>	 TimStarling: can you look at https://gerrit.wikimedia.org/r/#/c/108740/ ?
[22:53:08] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Renamed "removeDuplicates" field to be slightly clearer [core] - 10https://gerrit.wikimedia.org/r/110208 (owner: 10Aaron Schulz)
[22:55:08] <TimStarling>	 looks good, but it would be nice to see that factored out at some point
[22:55:19] <TimStarling>	 this is not the only place where background shell commands are started
[22:55:35] <TimStarling>	 actually I had to go to a lot of trouble when I did the proc_open() thing to make sure background commands still worked
[22:55:47] <AaronSchulz>	 I was curious how much you tested that case
[22:55:52] <AaronSchulz>	 ok
[22:56:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Renamed "removeDuplicates" field to be slightly clearer [core] - 10https://gerrit.wikimedia.org/r/110208 (owner: 10Aaron Schulz)
[22:56:40] <grrrit-wm>	 (03PS2) 10Aaron Schulz: Various fixes to job running code in Wiki.php [core] - 10https://gerrit.wikimedia.org/r/108740 
[22:56:59] <grrrit-wm>	 (03CR) 10Tim Starling: [C: 032] Various fixes to job running code in Wiki.php [core] - 10https://gerrit.wikimedia.org/r/108740 (owner: 10Aaron Schulz)
[22:57:10] <AaronSchulz>	 ^d: so what's wrong with https://gerrit.wikimedia.org/r/#/c/103399/ ?
[22:57:33] <InezK>	 Hey. Who worked on using/installing HipHop in MediaWiki Vagrant?
[22:57:49] <^d>	 AaronSchulz: Removing setting of $wgTitle can be unpredictable since we've still got deployed extensions *using* $wgTitle.
[22:58:05] <gwicke>	 InezK, Erik & Ori afaik
[22:58:10] <AaronSchulz>	 for jobs?
[22:58:27] <^d>	 AaronSchulz: I think the assignments are trivially removed later.
[22:58:30] <ebernhardson>	 InezK: any problems with it?
[22:58:41] <grrrit-wm>	 (03PS27) 10Bsitu: Topic and Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 
[22:58:41] <^d>	 I'd much rather see us remove actual *uses* of it.
[22:58:47] <InezK>	 ebernhardson: oh, just writing e-mail to you now :)
[22:58:50] <InezK>	 but no, no problems
[22:58:57] <ebernhardson>	 InezK: ok :)
[22:59:08] <ebernhardson>	 couple people have found some issues in it, so there are probably more to go :)
[23:00:20] <TimStarling>	 I'm currently trying to work out what sort of hiphop test server I should make
[23:00:41] <TimStarling>	 for a few months, I've been running PHP in a chroot, with all compiling of PHP and extensions done as non-root
[23:00:47] <TimStarling>	 on my laptop
[23:01:07] <TimStarling>	 trying to work out if that is too ambitious a model for hiphop
[23:01:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Various fixes to job running code in Wiki.php [core] - 10https://gerrit.wikimedia.org/r/108740 (owner: 10Aaron Schulz)
[23:04:24] <TimStarling>	 the dependency on GCC 4.7 makes things interesting, if you consider PPAs to be insecure
[23:06:46] <grrrit-wm>	 (03CR) 10Reedy: WIP: Add messages for Trademark Licensing form for foundationwiki (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/110243 (owner: 10Reedy)
[23:08:31] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Defer af_throttled query to post-commit auto-commit mode [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/110253 
[23:08:56] <grrrit-wm>	 (03PS2) 10Aaron Schulz: Defer af_throttled query to post-commit auto-commit mode [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/110253 
[23:09:36] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Topic and Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu)
[23:09:39] <Reedy>	 AaronSchulz: Wrong version?
[23:09:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Topic and Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu)
[23:09:48] <Reedy>	 Only AFTv5 is deployed on the cluster
[23:09:58] <Reedy>	 We don't care about ArticleFeedback...
[23:10:00] <grrrit-wm>	 (03PS1) 10Chad: Remove vestiges of AdminSettings.php [core] - 10https://gerrit.wikimedia.org/r/110254 
[23:10:22] <AaronSchulz>	 what does this have to do with AF?
[23:10:33] <Reedy>	 Apparently I cannot read
[23:10:39] <Reedy>	 God knows why I thought it was AFT
[23:10:43] <Reedy>	 Is it bed time yet?
[23:11:22] <AaronSchulz>	 not here it is
[23:12:25] <grrrit-wm>	 (03CR) 10Nemo bis: Fix the i18n source string for the chunked preference (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 (owner: 10Gilles)
[23:16:24] <p858snake|l>	 no Reedy, you are not allowed to sleep
[23:16:32] * p858snake|l  hooks Reedy up to a caffine IV

[23:18:04] <Krenair>	 Roan still in a meeting? :/
[23:21:02] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] "Catching them and inlining the error in the middle of other css strings will likely bury it and thus make it undetectable in general produ" [core] - 10https://gerrit.wikimedia.org/r/109956 (owner: 10Umherirrender)
[23:22:09] <grrrit-wm>	 (03CR) 10BryanDavis: "The role applies cleanly via `vagrant provision` but I don't seem to be getting math to render. My first test case was importing [[:meta:H" [vagrant] - 10https://gerrit.wikimedia.org/r/108827 (owner: 10Physikerwelt)
[23:25:39] <grrrit-wm>	 (03PS1) 10Spage: Use new mw-ui-constructive Agora styles [core] - 10https://gerrit.wikimedia.org/r/110258 
[23:26:13] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] "SG had some issues with the :not selectors, but since they are used in a variety of places already will have a single patch to address all" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106275 (owner: 10Matthias Mullie)
[23:26:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: (bug 58413) Hide usernames until reply form is active [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106275 (owner: 10Matthias Mullie)
[23:27:38] <AaronSchulz>	 ^d: https://gerrit.wikimedia.org/r/#/c/106632/
[23:28:06] <grrrit-wm>	 (03CR) 10Mwjames: Improved SMW 1.9 support, given a recent-ish change in the SMW code (031 comment) [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/110244 (owner: 10Yaron Koren)
[23:30:04] <grrrit-wm>	 (03CR) 10Chad: [C: 031] "You beat me to taking care of Special:Search. That one lgtm :)" [core] - 10https://gerrit.wikimedia.org/r/110258 (owner: 10Spage)
[23:32:36] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] Make it a bit safer to paste input to eval.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106632 (owner: 10Aaron Schulz)
[23:34:37] <grrrit-wm>	 (03CR) 10Spage: "This is the minimal change for the core forms using mw-ui-button per Steven Walling and Jared Zimmerman are comfortable with. It applies t" [core] - 10https://gerrit.wikimedia.org/r/110258 (owner: 10Spage)
[23:35:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make it a bit safer to paste input to eval.php [core] - 10https://gerrit.wikimedia.org/r/106632 (owner: 10Aaron Schulz)
[23:37:09] <grrrit-wm>	 (03PS3) 10Aaron Schulz: Defer af_throttled query to post-commit auto-commit mode [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/110253 
[23:37:48] <^d>	 AaronSchulz: Respond to Tyler's comment, otherwise lgtm.
[23:38:00] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Remove commented defines [core] - 10https://gerrit.wikimedia.org/r/107906 (owner: 10Chad)
[23:39:45] <^d>	 AaronSchulz: hoo beat me to it 
[23:40:01] <grrrit-wm>	 (03CR) 10Hoo man: [C: 04-1] Defer af_throttled query to post-commit auto-commit mode (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/110253 (owner: 10Aaron Schulz)
[23:41:02] <AaronSchulz>	 "Invalid JSON response"
[23:41:05] <AaronSchulz>	 thank you gerrit
[23:41:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove commented defines [core] - 10https://gerrit.wikimedia.org/r/107906 (owner: 10Chad)
[23:45:43] <grrrit-wm>	 (03CR) 10Mattflaschen: "This is causing some spurious notices since null is the default in a lot of places (e.g. https://git.wikimedia.org/blob/mediawiki%2Fcore.g" [core] - 10https://gerrit.wikimedia.org/r/110190 (owner: 10Dereckson)
[23:48:22] <grrrit-wm>	 (03Abandoned) 10Trevor Parscal: Rough sketch of using OOJS and OOJS-UI for data model and UI [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109808 (owner: 10Trevor Parscal)
[23:48:45] <grrrit-wm>	 (03CR) 10Jack Phoenix: "I think that the core LogFormatter should really be changed -- it's not unreasonable to assume that wikilinks work here. We can stick to t" [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/110212 (owner: 10UltrasonicNXT)
[23:49:19] <grrrit-wm>	 (03CR) 10Jack Phoenix: [C: 032 V: 032] Use placeholder instead of value [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/110219 (owner: 10UltrasonicNXT)
[23:52:45] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] (bug 56184) Allow 3-way merge from arbitrary revisions [core] - 10https://gerrit.wikimedia.org/r/91943 (owner: 10Liangent)
[23:55:17] <grrrit-wm>	 (03PS3) 10TTO: Give a meaningful message when Special:ActiveUsers is disabled [core] - 10https://gerrit.wikimedia.org/r/109496 
[23:56:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: (bug 56184) Allow 3-way merge from arbitrary revisions [core] - 10https://gerrit.wikimedia.org/r/91943 (owner: 10Liangent)