[00:00:21] (03CR) 10PleaseStand: "Reedy: https://git.wiki.kernel.org/index.php/Git_FAQ#Why_does_Git_not_.22track.22_renames.3F" [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/109630 (owner: 10KartikMistry) [00:03:26] (03CR) 10Werdna: [C: 032] Replace all usages of Function.bind with jQuery.proxy Fixes IE8 errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109788 (owner: 10SG) [00:03:32] (03Merged) 10jenkins-bot: Replace all usages of Function.bind with jQuery.proxy Fixes IE8 errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109788 (owner: 10SG) [00:04:20] gwicke: link targets without all this ./../.../whatever [00:04:26] but I guess I just have to do that myself [00:06:27] (03PS17) 10Adamw: Provision the fundraising-crm project [vagrant] - 10https://gerrit.wikimedia.org/r/94950 [00:07:31] werdna, .replace(/^(?:\.?\.\/)*/, '') [00:07:42] we are thinking about removing the relative prefix [00:07:49] gwicke: yeah, got there eventually [00:07:51] see the wikitext-l discussion [00:08:05] $stripTitle = function( $title ) { return preg_replace( 'm#^(\.{1,2}\/)+#', '', $title ); }; [00:08:21] that would also remove the mw:ExtLink / mw:WikiLink rel attribute from links [00:08:30] that would be annoyiung [00:08:32] annoying* [00:08:34] why would you do that? [00:08:50] seems like a gratuitous break from back-compat [00:08:54] mostly because the info is also in the href [00:09:16] (03CR) 10Reedy: http://www.mediawiki.org --> https://www.mediawiki.org (032 comments) [core] - 10https://gerrit.wikimedia.org/r/108681 (owner: 10Ladsgroup) [00:09:52] if it matches /^(?:[a-zA-Z]:|/, then it is an external link with a protocol [00:10:17] eh, /^(?:[a-zA-Z]:|\/\// [00:10:18] (03CR) 10TTO: "My questions remain re indent-pre: (a) this would be difficult to make happen... how do you propose to do it? By calling Parser#parse? See" [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [00:12:21] (03CR) 10Reedy: Add ZeroMQFeedEngine (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105117 (owner: 10Legoktm) [00:15:52] (03CR) 10Reedy: "Gerrit shows it nicely sometimes:" [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/109630 (owner: 10KartikMistry) [00:19:05] (03CR) 10Reedy: "Shouldn't you probably move ImageQueryPage.php and PageQueryPage.php at the same time?" [core] - 10https://gerrit.wikimedia.org/r/109587 (owner: 10Addshore) [00:20:49] (03CR) 10Parent5446: Add ZeroMQFeedEngine (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105117 (owner: 10Legoktm) [00:21:19] werdna: ebernhardson: I'd recommend filling the .jshintrc file with something non-empty (starting with the common settings per coding conventions and going from there). https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FFlow/master/.jshintrc https://www.mediawiki.org/wiki/CC/JS#Linting [00:21:34] (03CR) 10Bartosz Dziewoński: "That depends on the "distance" of modifications between the files. `git log` has an option to control that, -M I think, and I think it's a" [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/109630 (owner: 10KartikMistry) [00:21:51] One thing you could add to your /* Local */ section is the setting to make sure you're es3 compliant (it would've caught the "new" keyword thing for example) [00:22:09] We use jshint v2.1.11 [00:22:10] (03CR) 10Parent5446: [C: 031] "Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [00:23:04] http://jshint.com/docs/options/#es3 [00:23:25] Why is that an empty file anyway? [00:23:27] (03CR) 10TTO: "Thanks for your feedback. See inline comments, there are a few lingering questions for you." (039 comments) [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [00:23:50] Better than no file at all, but still doesn't make sense [00:23:52] (03CR) 10Reedy: Add ZeroMQFeedEngine (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105117 (owner: 10Legoktm) [00:23:54] Ah, hashar created that. [00:24:04] (03CR) 10Parent5446: Create Special:Purge (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109523 (owner: 10Ebe123) [00:26:16] (03CR) 10Brian Wolff: "I'm unconvinced this is a good idea (See my comment on bugzilla)" [core] - 10https://gerrit.wikimedia.org/r/109523 (owner: 10Ebe123) [00:27:36] (03PS1) 10EBernhardson: Revert "Update wmf/1.23wmf10 to match wmf/1.23wmf11" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109793 [00:27:47] (03CR) 10EBernhardson: [C: 032] Revert "Update wmf/1.23wmf10 to match wmf/1.23wmf11" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109793 (owner: 10EBernhardson) [00:27:54] (03Merged) 10jenkins-bot: Revert "Update wmf/1.23wmf10 to match wmf/1.23wmf11" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109793 (owner: 10EBernhardson) [00:28:01] (03PS1) 10EBernhardson: Revert "update branch to wmf/1.23wmf11" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109794 [00:28:07] (03CR) 10EBernhardson: [C: 032] Revert "update branch to wmf/1.23wmf11" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109794 (owner: 10EBernhardson) [00:28:13] (03Merged) 10jenkins-bot: Revert "update branch to wmf/1.23wmf11" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109794 (owner: 10EBernhardson) [00:29:50] gwicke: aaaand one more question… how do I distinguish interwiki links from external links? [00:30:01] I'm getting this [00:30:01] MeatBall:CriticismIsFeedback [00:30:08] oh, isIW [00:30:09] ignore me [00:30:51] (03PS1) 10Ori.livneh: Revert I829790cd5, removing module storage logging [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/109795 [00:31:42] gwicke: buuuut isIW is not in the spec, and neither is 'sa', whatever that is [00:31:52] (03CR) 10Ori.livneh: [C: 032] Revert I829790cd5, removing module storage logging [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/109795 (owner: 10Ori.livneh) [00:31:53] (03Merged) 10jenkins-bot: Revert I829790cd5, removing module storage logging [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/109795 (owner: 10Ori.livneh) [00:32:07] (03CR) 10Bsitu: [C: 032 V: 032] Update Flow [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109789 (owner: 10Bsitu) [00:32:22] (03CR) 10TTO: Merge Poem extension into core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [00:34:14] (03PS3) 10Bartosz Dziewoński: Make preference "Email me when a page or file on my watchlist is changed" true by default [core] - 10https://gerrit.wikimedia.org/r/100959 (owner: 10Nemo bis) [00:34:23] (03PS1) 10Ori.livneh: Update WikimediaEvents to master [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109796 [00:35:34] (03PS1) 10Ori.livneh: Update WikimediaEvents to master [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/109797 [00:36:23] werdna, that is all private; pretend you never saw it [00:36:33] gwicke: okay, so how do I tell them apart? [00:36:48] you match on the href [00:36:53] uggghhh [00:36:53] whyyy [00:37:11] (03PS1) 10EBernhardson: Update wmf/1.23wmf10 branch to match wmf/1.23wmf11 [extensions/Flow] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/109798 [00:37:22] werdna, that's the safest thing to do [00:37:30] * werdna grumbles [00:37:36] see recent wikitech-l discussions about iw prefix brokenness [00:37:48] what is your use case? [00:37:55] updating link tables? [00:38:29] in that case, it might make more sense for us to expose that info in a json structure server-side [00:38:56] (03CR) 10TTO: Merge Poem extension into core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [00:39:22] (03PS2) 10Reedy: Ignore 'unknown' in XFF [core] - 10https://gerrit.wikimedia.org/r/109721 (owner: 10Umherirrender) [00:39:27] (03CR) 10Reedy: [C: 032] Ignore 'unknown' in XFF [core] - 10https://gerrit.wikimedia.org/r/109721 (owner: 10Umherirrender) [00:40:26] gwicke: yeah, updating links tables [00:40:45] gwicke: Maybe there's already a function somewhere that checks extlinks for a given prefix [00:41:01] gwicke: https://bugzilla.wikimedia.org/show_bug.cgi?id=57512#c14 I believe. [00:41:06] we do that internally when converting html2wt [00:41:18] based on the wiki's interwiki map retrieved through the API [00:41:28] (03PS1) 10Chad: Remove setting referrer from HttpFunctions [core] - 10https://gerrit.wikimedia.org/r/109799 [00:41:57] gwicke: hmph. [00:42:41] gwicke: well, I'll leave them as externals for now anyway [00:44:11] (03Merged) 10jenkins-bot: Ignore 'unknown' in XFF [core] - 10https://gerrit.wikimedia.org/r/109721 (owner: 10Umherirrender) [00:44:21] werdna, k [00:47:20] <^d> https://www.mediawiki.org/wiki/User:%5Edemon/Extensions_using_$wgTitle_really_badly [00:47:23] <^d> Good times. [00:48:28] (03PS1) 10EBernhardson: Catch and log errors in contributions formatting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109801 [00:48:31] (03CR) 10jenkins-bot: [V: 04-1] Catch and log errors in contributions formatting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109801 (owner: 10EBernhardson) [00:49:06] <^d> ack '\$wg(Title|Lang|ContLang|User)->' is even more depressing. [00:49:12] <^d> We're never going to win :( [00:49:49] (03PS2) 10EBernhardson: Catch and log errors in contributions formatting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109801 [00:53:08] <^d> Friendly reminder: gerrit coming down in about ~40mins for update. [00:53:13] (03CR) 10Bsitu: [C: 032] Catch and log errors in contributions formatting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109801 (owner: 10EBernhardson) [00:53:20] (03Merged) 10jenkins-bot: Catch and log errors in contributions formatting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109801 (owner: 10EBernhardson) [00:53:41] (03PS1) 10Bsitu: Catch and log errors in contributions formatting [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109803 [00:53:57] (03PS12) 10Reedy: Error shown ifAdministrator username and passwod match shown on same page of installer [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [00:54:10] * ^d expects everyone to still panic and go "OMG WHERE'D GERRIT GO?" [00:54:42] ^d: you're waiting 'til 5pm, right? [00:54:52] (03CR) 10Bsitu: [C: 032] Catch and log errors in contributions formatting [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109803 (owner: 10Bsitu) [00:54:57] (03Merged) 10jenkins-bot: Catch and log errors in contributions formatting [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109803 (owner: 10Bsitu) [00:54:57] <^d> 5:30, in case people's LDs run late. [00:55:03] (03CR) 10Ori.livneh: [C: 032] Update WikimediaEvents to master [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109796 (owner: 10Ori.livneh) [00:55:27] <^d> ori: I'll finish prepping at 5, but I'll hold off on shutting it down til 5:30. [00:55:50] <^d> (That's 01:30 UTC, for everyone else) [00:55:56] ori, I noticed a while ago that the mobile-specific graphs disappeared completely from http://ganglia.wikimedia.org/latest/?r=hour&cs=&ce=&s=by+name&c=&tab=v&vn=Navigation+Timing&hide-hf=false any particular reason why that happened? [00:56:26] jgonera: i need to e-mail wikitech about it; i moved everything to graphite [00:56:28] !log ori synchronized php-1.23wmf11/extensions/WikimediaEvents 'Ifc697cbe6: Revert I829790cd5, removing module storage logging' [00:56:40] it should have been going into graphite all along but the graphite setup in tampa was brittle and moribund [00:56:55] jgonera: but see [00:56:57] !log springle synchronized wmf-config/db-eqiad.php 'repool db1006, warm up' [00:57:07] <^d> ori: Does that include the job queue counts that Nemo's been complaining about? [00:57:26] no, I forget what the status of that is [00:57:54] <^d> mmk [00:58:06] <^d> (if it's really still on hume, let's just move it to terbium, that can't hurt. [00:58:06] ori, I see, that looks cool! are those graphs at http://git.wikimedia.org/tree/operations%2Fpuppet.git/92fb3b124a54498a9cc64fb4ae92c2cd29064dec/files%2Fgraphite%2Fgdash%2Fdashboards ? [00:58:16] I mean, the code [00:58:16] jgonera: yep [00:58:21] see the frontend/ dir [00:58:25] (03CR) 10Krinkle: "FYI: bypassing Jenkins in postmerge apparently causes Zuul to choke on the postmerge pipeline with an empty job set (upstream bug) that wi" [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109796 (owner: 10Ori.livneh) [00:58:38] ori, I can't see a dir called "frontend" [01:00:20] (03PS1) 10Trevor Parscal: Rough sketch of using OOJS and OOJS-UI for data model and UI [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109808 [01:00:27] (03CR) 10jenkins-bot: [V: 04-1] Rough sketch of using OOJS and OOJS-UI for data model and UI [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109808 (owner: 10Trevor Parscal) [01:00:30] (03CR) 10Ori.livneh: [C: 032] Update WikimediaEvents to master [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/109797 (owner: 10Ori.livneh) [01:00:32] (03CR) 10JGonera: "Oops! Sorry, that explains why I couldn't find that comment that Matt pointed out." [core] - 10https://gerrit.wikimedia.org/r/103494 (owner: 10JGonera) [01:00:54] (03PS1) 10EBernhardson: Ignore temp files from jedit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109809 [01:00:57] (03CR) 10Ori.livneh: "WP:SOFIXIT :)" [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109796 (owner: 10Ori.livneh) [01:01:54] (03CR) 10Krinkle: "Testing locally shows they're still broken even without the "stats_counts" and "stats.gauges" prefixes." [integration/docroot] - 10https://gerrit.wikimedia.org/r/109702 (owner: 10Ori.livneh) [01:02:25] (03CR) 10Krinkle: "* http://graphite.wikimedia.org/render/?from=-24hours&height=180&until=now&width=400&bgcolor=ffffff&fgcolor=000000&target=alias(summarize(" [integration/docroot] - 10https://gerrit.wikimedia.org/r/109702 (owner: 10Ori.livneh) [01:02:46] (03PS1) 10Bsitu: Update Flow [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109810 [01:03:13] MaxSem, is there any page where I can track progress on implementing/deploying your JS minifier based on uglifyjs? [01:03:20] Krinkle: you can go to graphite.wikimedia.org and grab them [01:03:29] jgonera, no [01:03:34] (03Merged) 10jenkins-bot: Update WikimediaEvents to master [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/109797 (owner: 10Ori.livneh) [01:03:41] I haven't had time to work on it recently [01:03:58] MaxSem, is there like a project page or anything at all? a repo? ;) [01:04:09] no [01:04:12] SIKRIT [01:04:15] (03CR) 10Bsitu: [C: 032 V: 032] Update Flow [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109810 (owner: 10Bsitu) [01:04:35] MaxSem, it would be cool if you published this somewhere, maybe someone else would like to work on it too [01:04:42] jgonera, mediawiki/extensions/Minifier [01:04:56] oh, so there is a repo! [01:05:34] (03PS1) 10Aaron Schulz: Save back parser output to cache in RefreshLinks [core] - 10https://gerrit.wikimedia.org/r/109811 [01:05:35] !log ori synchronized php-1.23wmf10/extensions/WikimediaEvents 'Ifc697cbe6: Revert I829790cd5, removing module storage logging' [01:05:59] jgonera: you need to git pull [01:06:12] (03PS3) 10Chad: Use I21440625's indication of file content matches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105235 [01:06:25] (03CR) 10Chad: "PS3 was just a rebase." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105235 (owner: 10Chad) [01:06:31] ori, so gitblit doesn't show the most recent master? [01:06:32] ori: Did other parts of the syntax change or something? I don't know graphite enough to know how to get those graphs, don't remember what they used to look like. Maybe the summarize() or alias() thing doesn't work? Not sure what those did. Or maybe it needs .count or .value at the end? [01:06:48] I'll let hashar figure it out [01:06:59] Krinkle: nah, let's look together. I'll come over [01:07:06] OK [01:07:31] (03Abandoned) 10Chad: Allow other extensions to modify documents to be updated [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105224 (owner: 10Chad) [01:09:48] Krinkle: 2 mins [01:11:08] (03CR) 10Chad: [C: 032] Drop data from Elasticsearch we don't need [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109778 (owner: 10Manybubbles) [01:11:13] (03Merged) 10jenkins-bot: Drop data from Elasticsearch we don't need [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109778 (owner: 10Manybubbles) [01:11:15] (03PS2) 10Aaron Schulz: Save back parser output to cache in RefreshLinks [core] - 10https://gerrit.wikimedia.org/r/109811 [01:13:33] (03PS1) 10Ori.livneh: Use ve.trackSubscribe [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/109812 [01:14:02] MaxSem, what is basically missing in this minifier for it to be used? [01:14:34] ...that it worked:P [01:14:40] (03CR) 10Chad: "Clever, since we'll likely have a Cirrus job coming soon behind it that could benefit from the cache hit." [core] - 10https://gerrit.wikimedia.org/r/109811 (owner: 10Aaron Schulz) [01:14:42] (03CR) 10Reedy: [C: 032] Use ve.trackSubscribe [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/109812 (owner: 10Ori.livneh) [01:14:44] (03Merged) 10jenkins-bot: Use ve.trackSubscribe [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/109812 (owner: 10Ori.livneh) [01:14:49] MaxSem, why doesn't it? [01:15:16] resulting JS doesn't work, need to research why [01:15:31] (03CR) 10Deskana: "Oops. I misclicked and submitted my comments too early." [core] - 10https://gerrit.wikimedia.org/r/49234 (owner: 10Liangent) [01:16:00] (03PS1) 10Ori.livneh: Update WikimediaEvents to master [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109813 [01:16:20] (03PS1) 10Ori.livneh: Update WikimediaEvents to master [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/109814 [01:16:31] (03CR) 10Ori.livneh: [C: 032 V: 032] Update WikimediaEvents to master [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109813 (owner: 10Ori.livneh) [01:16:49] <^d> Gerrit's coming down in 15 minutes. [01:16:57] <^d> Everyone get your commits and comments in :) [01:17:08] (03CR) 10Ori.livneh: [C: 032 V: 032] Update WikimediaEvents to master [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/109814 (owner: 10Ori.livneh) [01:17:39] Do we need to review them so Jenkins fails to merge them a bit later? [01:17:55] <^d> plz don't ;-) [01:18:42] What's actually going to change? [01:18:42] !log ori synchronized php-1.23wmf11/extensions/WikimediaEvents [01:18:53] (03PS1) 10EBernhardson: Catch and log exceptions in Contributions\Query [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109815 [01:19:05] (03CR) 10EBernhardson: [C: 032] Catch and log exceptions in Contributions\Query [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109815 (owner: 10EBernhardson) [01:19:07] !log ori synchronized php-1.23wmf10/extensions/WikimediaEvents [01:19:09] rebasing will preserve scores, for one [01:19:18] <^d> https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.8.html, https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.8.1.html [01:19:19] (03PS1) 10EBernhardson: Catch and log exceptions in Contributions\Query [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109816 [01:19:26] Sweet [01:19:26] (03CR) 10EBernhardson: [C: 032] Catch and log exceptions in Contributions\Query [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109816 (owner: 10EBernhardson) [01:19:32] <^d> yay release notes [01:20:01] (03CR) 10EBernhardson: [V: 032] Catch and log exceptions in Contributions\Query [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109816 (owner: 10EBernhardson) [01:20:02] Update JGit to 3.1.0.201310021548-r [01:20:04] Woo? ;) [01:20:20] MaxSem, ok, I'll add that to my low importance TODO list ;) [01:20:31] (03Merged) 10jenkins-bot: Catch and log exceptions in Contributions\Query [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109815 (owner: 10EBernhardson) [01:20:50] (03CR) 10Bartosz Dziewoński: [C: 032] "Ah whatever, let's do this now, given the overwhelming support." [core] - 10https://gerrit.wikimedia.org/r/100959 (owner: 10Nemo bis) [01:20:59] (03PS2) 10Bartosz Dziewoński: Release notes for I9359682c [core] - 10https://gerrit.wikimedia.org/r/109711 [01:21:04] <^d> Reedy: Oh man, 3.1.0.201310021548 is freaking sweat. [01:21:05] (03CR) 10Bartosz Dziewoński: [C: 032] Release notes for I9359682c [core] - 10https://gerrit.wikimedia.org/r/109711 (owner: 10Bartosz Dziewoński) [01:21:20] <^d> Way more awesome than 3.0.0.201309041009 [01:21:21] sweat? :D [01:21:22] MatmaRex is on a YOLO streak. [01:21:57] heh [01:22:09] i haven't bringed down the sites in a long time! [01:22:21] brung down? [01:22:26] <^d> brought down [01:22:28] brought [01:23:13] (03PS1) 10Bsitu: Update Flow [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109818 [01:23:39] (03CR) 10Bsitu: [C: 032 V: 032] Update Flow [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109818 (owner: 10Bsitu) [01:23:43] duh, yes. thanks [01:23:59] MatmaRex: for all the OR and ANDs in SQL, shouldn't you be using $db->makeList( foo, LIST_AND ) ? [01:24:24] i think it's too late here already. [01:24:40] legoktm: i suppose i could [01:25:50] * ^d is letting the couple of gate and submits finish that are underway [01:25:58] <^d> But please, let's not start new ones folks :) [01:26:05] awwwwwwwwww [01:26:48] !log bsitu synchronized php-1.23wmf11/extensions/Flow 'Update Flow with some special contribs cherry-picks' [01:29:07] <^d> MatmaRex: You had to merge a chain of 3 core changes right before downtime didn't you? [01:29:15] * ^d puts MatmaRex in time-out [01:29:23] <^d> :) [01:30:10] <^d> Or 2, but whatevs, timeout still. [01:30:15] heh [01:30:20] i can merge a few more if you want :> [01:30:48] or just submit them [01:30:55] <^d> It's almost done. [01:30:56] they both don't need tests [01:30:58] <^d> We'll just let it finish [01:31:21] (03Merged) 10jenkins-bot: Make preference "Email me when a page or file on my watchlist is changed" true by default [core] - 10https://gerrit.wikimedia.org/r/100959 (owner: 10Nemo bis) [01:32:04] (03Merged) 10jenkins-bot: Release notes for I9359682c [core] - 10https://gerrit.wikimedia.org/r/109711 (owner: 10Bartosz Dziewoński) [01:34:58] (03PS2) 10Krinkle: Update metric names for Zuul / Gerrit graphite graphs [integration/docroot] - 10https://gerrit.wikimedia.org/r/109702 (owner: 10Ori.livneh) [01:35:38] ori: The graphs now work again locally, though they do stop after last monday for Zuul. I guess that's expected for now right, as that's still to be imported? [01:35:51] (03CR) 10Krinkle: [C: 032] Update metric names for Zuul / Gerrit graphite graphs [integration/docroot] - 10https://gerrit.wikimedia.org/r/109702 (owner: 10Ori.livneh) [01:35:54] (03Merged) 10jenkins-bot: Update metric names for Zuul / Gerrit graphite graphs [integration/docroot] - 10https://gerrit.wikimedia.org/r/109702 (owner: 10Ori.livneh) [01:36:08] no, it should be updating continuously; i'll check the configs [01:36:14] Deployed: https://integration.wikimedia.org/zuul/ [01:36:14] or ask hashar to [01:36:28] gerrit events is up-to-date [01:38:00] ori: It's interesting though that both gerrit and zuul data points are now wrapped one extra level. Seems unlikely for a coincidence. I thought maybe the recent Zuul upgrade changed something internally that we just transparently passed through but I guess this is somewhere on our end. Either way, it works now. [01:38:24] Don't worry about the Zuul data missing for this week, I'll ask hashar later. [01:44:18] ^d: any user-facing changes? [01:44:23] bah, my custom CSS no longer works [01:45:02] (03PS1) 10Reedy: Update OBSOLETE file text [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/109821 [01:45:19] and the font changed to some ugly one, it seems [01:45:27] could have been worse i guess� [01:46:07] Changing ids? [01:46:28] .dataCell.cAPPROVAL.singleLine:last-child { text-align:left; width:10px !important; overflow:hidden; position:absolute} [01:46:44] ah hmm, works now. [01:46:58] refresh all the things [01:47:59] <^d> I should turn on the lucene indexing at some point. [01:48:01] <^d> Not today though. [01:49:44] (03CR) 10Legoktm: [C: 032 V: 032] Update OBSOLETE file text [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/109821 (owner: 10Reedy) [01:50:58] haha, new change screen has one-click CR+2 [01:51:00] * MatmaRex switches [01:51:39] (03CR) 10Chad: [C: 032] Support SearchEngine's new sort parameter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109671 (owner: 10Manybubbles) [01:51:40] (some screenshots for the lazy: http://i.imgur.com/jsD1wLO.png and http://i.imgur.com/of9Z6B0.png ) [01:51:44] (03Merged) 10jenkins-bot: Support SearchEngine's new sort parameter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109671 (owner: 10Manybubbles) [01:52:31] o_0 [01:52:40] <^d> MatmaRex: Those blue buttons were red in a previous iterator. [01:52:43] <^d> *iteration [01:52:49] <^d> :) [01:53:13] you know, that actually isn't half-bad [01:53:23] ori, you could have told me that I'm stupid and I'm not looking at the newest commit at gitblit ;) [01:53:28] and proably is better than the current UI [01:53:42] jgonera: That's not your fault [01:53:48] It caches too aggressively [01:53:51] I tend to just use github [01:54:38] Reedy, I think I selected a specific commit a while ago when I opened this tab, who knows why now [01:54:52] but it's good to know if that happens again without my fault [01:57:56] (03CR) 10Krinkle: [C: 031] "The current version of this patch is good to go in my opinion." [core] - 10https://gerrit.wikimedia.org/r/65440 (owner: 10Waldir) [01:59:00] (03CR) 10Reedy: "Needs a rebase though" [core] - 10https://gerrit.wikimedia.org/r/65440 (owner: 10Waldir) [01:59:28] (03CR) 10Parent5446: "Yeah I'm feeling a bit neutral." [core] - 10https://gerrit.wikimedia.org/r/65440 (owner: 10Waldir) [02:04:26] (03PS3) 10Krinkle: skin: Remove the id "anonlogin" and merge pt-anonlogin with pt-login [core] - 10https://gerrit.wikimedia.org/r/65440 (owner: 10Waldir) [02:04:28] (03CR) 10Krinkle: skin: Remove the id "anonlogin" and merge pt-anonlogin with pt-login (031 comment) [core] - 10https://gerrit.wikimedia.org/r/65440 (owner: 10Waldir) [02:04:34] (03CR) 10Krinkle: [C: 031] skin: Remove the id "anonlogin" and merge pt-anonlogin with pt-login [core] - 10https://gerrit.wikimedia.org/r/65440 (owner: 10Waldir) [02:04:41] (03CR) 10Krinkle: "Rebased to resolve path conflict." [core] - 10https://gerrit.wikimedia.org/r/65440 (owner: 10Waldir) [02:06:08] werdna: do you have a minute to look at this bug fix for Echo? https://gerrit.wikimedia.org/r/#/c/108329/ [02:11:08] csteipp, can you comment on https://www.mediawiki.org/wiki/Requests_for_comment/Passwords ? [02:11:39] The scope has narrowed to just raising the minimum password length to 6. [02:12:27] Contraversial [02:12:59] 123456 [02:13:25] I think we should increase it by one character a year for the next decade [02:17:23] (03CR) 10Reedy: Error shown ifAdministrator username and password match shown on same page of installer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [02:19:43] (03PS4) 10Brian Wolff: Add audio stats to [[Special:TimedMediaHandler]]. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/97998 [02:19:43] https://www.mediawiki.org/wiki/Special:TimedMediaHandler [02:19:48] (03CR) 10Reedy: [C: 032] Add audio stats to [[Special:TimedMediaHandler]]. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/97998 (owner: 10Brian Wolff) [02:19:48] https://www.mediawiki.org/wiki/Special:TimedMediaHandler [02:19:51] (03Merged) 10jenkins-bot: Add audio stats to [[Special:TimedMediaHandler]]. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/97998 (owner: 10Brian Wolff) [02:19:51] https://www.mediawiki.org/wiki/Special:TimedMediaHandler [02:20:33] (03PS2) 10Brian Wolff: Fix getLongDesc if tif file is invalid or has invalid metadata [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/101180 [02:20:37] (03CR) 10Reedy: [C: 032] Fix getLongDesc if tif file is invalid or has invalid metadata [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/101180 (owner: 10Brian Wolff) [02:20:43] (03Merged) 10jenkins-bot: Fix getLongDesc if tif file is invalid or has invalid metadata [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/101180 (owner: 10Brian Wolff) [02:20:53] (03PS5) 10Legoktm: Config: Add Config and GlobalConfig classes [core] - 10https://gerrit.wikimedia.org/r/109266 [02:21:04] (03PS2) 10Brian Wolff: Make DjVu metadata be stored as serialized PHP array. [core] - 10https://gerrit.wikimedia.org/r/99544 [02:21:18] +1s weren't kept... [02:21:30] (03CR) 10Legoktm: Config: Add Config and GlobalConfig classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm) [02:21:33] (03CR) 10Reedy: [C: 032] Make DjVu metadata be stored as serialized PHP array. [core] - 10https://gerrit.wikimedia.org/r/99544 (owner: 10Brian Wolff) [02:22:17] (03CR) 10Reedy: [C: 031] Config: Add Config and GlobalConfig classes [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm) [02:23:44] (03CR) 10jenkins-bot: [V: 04-1] Make DjVu metadata be stored as serialized PHP array. [core] - 10https://gerrit.wikimedia.org/r/99544 (owner: 10Brian Wolff) [02:24:01] (03PS13) 10TTO: Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 [02:24:26] (03PS3) 10Aaron Schulz: Save generated parser output to cache in RefreshLinks [core] - 10https://gerrit.wikimedia.org/r/109811 [02:24:48] (03CR) 10jenkins-bot: [V: 04-1] Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [02:25:16] (03PS2) 10Brian Wolff: Don't include empty categories in Special:Mostlinkedcategories [core] - 10https://gerrit.wikimedia.org/r/103856 [02:25:24] (03CR) 10Reedy: [C: 032] Don't include empty categories in Special:Mostlinkedcategories [core] - 10https://gerrit.wikimedia.org/r/103856 (owner: 10Brian Wolff) [02:25:33] (03CR) 10Aaron Schulz: "I was thinking about both that as well as having htmlcacheupdate jobs do in-place cache replacement instead of just purging (this would be" [core] - 10https://gerrit.wikimedia.org/r/109811 (owner: 10Aaron Schulz) [02:25:45] !log LocalisationUpdate completed (1.23wmf10) at 2014-01-28 02:25:44+00:00 [02:28:57] (03CR) 10Aude: Config: Add Config and GlobalConfig classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm) [02:29:39] (03Merged) 10jenkins-bot: Don't include empty categories in Special:Mostlinkedcategories [core] - 10https://gerrit.wikimedia.org/r/103856 (owner: 10Brian Wolff) [02:30:06] (03PS5) 10Jarry1250: Use
    ,
  • in search suggestions instead of endless
    s. [core] - 10https://gerrit.wikimedia.org/r/41364 [02:31:20] (03CR) 10Aude: "i think omitting the prefix stuff is fine, more simple and less possibility for confusion or error." [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm) [02:31:47] (03PS14) 10TTO: Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 [02:34:09] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 263b8c0..2c0faa4 [extensions] - 10https://gerrit.wikimedia.org/r/109822 [02:37:53] (03PS13) 10Reedy: Error shown if Administrator username and password match in the installer [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [02:40:50] (03CR) 10Aude: Remove unused stuff from tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109470 (owner: 10Addshore) [02:44:05] (03CR) 10Mattflaschen: [C: 04-1] "I'm in favor of this for new variables." [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 (owner: 10Physikerwelt) [02:44:26] (03PS5) 10Reedy: Made Special:Contributions includable [core] - 10https://gerrit.wikimedia.org/r/106320 (owner: 10AalekhN) [02:45:52] (03CR) 10Aude: [C: 031] "looks fine, though shall look again when i'm more awake :)" [core] - 10https://gerrit.wikimedia.org/r/109587 (owner: 10Addshore) [02:47:14] (03CR) 10Reedy: [C: 04-1] Move QueryPage.php to specialpage folder [core] - 10https://gerrit.wikimedia.org/r/109587 (owner: 10Addshore) [02:49:09] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 263b8c0..4b71c52 [extensions] - 10https://gerrit.wikimedia.org/r/109825 [02:49:14] (03CR) 10Reedy: Move QueryPage.php to specialpage folder (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109587 (owner: 10Addshore) [02:52:03] !log LocalisationUpdate completed (1.23wmf11) at 2014-01-28 02:52:02+00:00 [02:57:55] !log springle synchronized wmf-config/db-eqiad.php 'db1006 to LB 400. prep db1027 for s6 master rotation' [03:05:44] ori: The "!log" in here is kind of driving me crazy. [03:05:54] Because I'm programmed to see the response. [03:11:15] !log springle synchronized wmf-config/db-eqiad.php 'rotate s6 master, demote db1027, promote db1023' [03:11:46] !log springle synchronized wmf-config/db-pmtpa.php 'rotate s6 master, demote db1027, promote db1023' [03:16:51] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 263b8c0..641be60 [extensions] - 10https://gerrit.wikimedia.org/r/109829 [03:17:14] (03CR) 10Reedy: [C: 04-1] "You (c|sh)ould possibly set the commit author to Kinsey Moore and their email address" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103238 (owner: 10Cptanu) [03:17:51] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 263b8c0..c39d1e6 [extensions] - 10https://gerrit.wikimedia.org/r/109830 [03:32:37] !log LocalisationUpdate ResourceLoader cache refresh completed at 2014-01-28 03:32:36+00:00 [03:32:41] (03PS1) 10KartikMistry: WIP: Update README [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/109834 [03:33:29] Gloria: OK, let's remove it [03:33:40] I haven't heard anyone say anything positive about it being here [03:33:40] ori: The bot or the prefix? [03:34:02] (c|sh)ould [03:34:05] * Gloria licks Reedy. [03:34:07] the bot. [03:34:22] (03CR) 10KartikMistry: "Reedy, it depends. Did with 'git mv' and result is: https://gerrit.wikimedia.org/r/#/c/109834/" [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/109630 (owner: 10KartikMistry) [03:34:31] +2 [03:36:09] (03PS3) 10KartikMistry: Update README [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/109630 [03:47:37] (03CR) 10Mattflaschen: [C: 04-1] "This is generally good, except that it fails on logged out users and special pages (or other ones where no CTA is shown); see inline." (032 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/109672 (owner: 10Phuedx) [03:52:35] Can someone review https://gerrit.wikimedia.org/r/#/c/83217/ ? [03:52:57] It's a bugfix for the mediawiki.api module. [03:55:02] superm401: it looks OK, but I hate doSomethingAndThenSomethingElse methods [03:55:40] if the operations are sufficiently distinct that they need a conjunction, they should be separate methods [03:57:27] ori, S is taking it, but let me look. [03:57:37] ^ spage [03:58:08] i'm not blocking, but it's worth squinting at for a few minutes to see if there's a way to factor it better [03:58:45] ori, I'm open to suggestions, but I think this particular case is pretty intuitive in practice. [03:59:21] ori, I suppose I could just break off the post part. [03:59:24] (03PS2) 10Brian Wolff: Use master db for showing log extract on RevDel success page [core] - 10https://gerrit.wikimedia.org/r/95828 [03:59:37] Then it would be return api.getToken( tokenType ).then( postWithToken ) or something. [03:59:58] Twice, which is a bit repetitive, but not excessively so. [04:00:43] i think that's better, yeah [04:01:09] ori, it is a private function; you probably noticed, but just double-checking. [04:01:15] I'll comment on the patch and see what people think. [04:01:43] yeah, code readability and organization matters for private apis [04:04:59] (03CR) 10Mattflaschen: "Ori suggested the slight restructuring I mentioned inline." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [04:05:41] spage, see above. Let me know if that part makes sense to you. [04:06:12] (03CR) 10Liangent: "Then an unblock log without a block log looks confusing for other people. I already got confused in such an event when I created this patc" [core] - 10https://gerrit.wikimedia.org/r/49234 (owner: 10Liangent) [04:19:02] (03CR) 10AalekhN: "bawolff:so do i need to include form in case error message displays or alternatively can you please point out the specific thing needed to" [core] - 10https://gerrit.wikimedia.org/r/106625 (owner: 10AalekhN) [04:33:48] (03PS1) 10AndyRussG: Add last_active_date column to the orgs table [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109843 [04:35:59] (03PS1) 10Legoktm: Remove useless/unused "use" statements [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109845 [04:50:02] (03CR) 10Chad: [C: 04-1] Config: Add Config and GlobalConfig classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm) [04:50:09] :< [04:50:32] ^demon|away: what do you mean by factory? [04:51:03] ^demon|away: like how ObjectCache works? [04:51:08] <^demon|away> Yep [04:51:28] (03PS6) 10AndyRussG: Accurately report institution activity [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109631 [04:51:35] ok [04:51:36] <^demon|away> Config::factory() would just construct and return the config object, no requirement for a singleton. [04:52:01] <^demon|away> RequestContext will end up effectively the same, since we'll hang on to the object once we've got it. [04:52:43] mhm [04:52:55] (03CR) 10AndyRussG: "Separated out the DB schema change as a separate patch (I2154eff85aec1ede78f2e65b739c65fc0dad215f)." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109631 (owner: 10AndyRussG) [04:53:58] <^demon|away> legoktm: Other than that it lgtm and I'll merge. [04:54:20] <^demon|away> I see aude left a comment about checking if the key is set, I went back on forth on whether to agree. [04:54:51] yeah, I wasn't sure about that either [04:54:58] <^demon|away> I think getting missing config is a bug and should fail. [04:55:08] <^demon|away> Failing quickly like that is kind of nice in a way :p [04:55:25] well, right now it just will result in a E_WARNING which is the same if you try to access a global that isn't set [04:55:50] <^demon|away> Indeed. [04:56:15] <^demon|away> So yeah, singleton -> factory and then let's merge. [04:56:19] <^demon|away> Enough bikeshedding :) [04:59:35] legoktm: What do you think about this Flow links bug? [05:00:15] Hi shahyar. [05:00:19] (03PS6) 10Legoktm: Config: Add Config and GlobalConfig classes [core] - 10https://gerrit.wikimedia.org/r/109266 [05:00:51] legoktm: https://bugzilla.wikimedia.org/show_bug.cgi?id=57512#c20 [05:01:30] (03CR) 10Legoktm: Config: Add Config and GlobalConfig classes (032 comments) [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm) [05:01:38] ^demon|away: ^ [05:01:50] <^demon|away> Much better :) [05:02:30] Gloria: Right, I think that sums it up IMO. Flow is intended to be cross-wiki, which is why I think some of these "re-implementations of MediaWiki" are needed. [05:02:48] But really, it should be MediaWiki that's being fixed rather than the code being put in extensions. [05:03:19] But that's just my thoughts from reading bugs, I haven't actually looked at that part of the code yet :P [05:04:07] Because of the way Flow is structured, running it through the PHP parser doesn't make sense [05:04:29] I don't see how it's avoidable. [05:04:33] Unless Parsoid can provide links info? [05:04:35] I dunnnnno. [05:06:15] (03CR) 10Chad: [C: 032] "Looks good for now (yay tests), let's merge. Like Tyler said, let's get this in with minimal bikeshedding. We can always follow up later a" [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm) [05:06:41] Reedy said that :P [05:08:15] aw crap [05:08:31] I forgot to update one part of the documentation [05:08:40] (03CR) 10Spage: "Looks good. I filed https://github.com/jshint/jshint/issues/1497 about jshint not warning about foo.new = function () ..." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109788 (owner: 10SG) [05:09:06] (03CR) 10Chad: [C: 04-2] "Blocking merge per IRC, Lego wants to amend one last time." [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm) [05:09:15] <^demon|away> legoktm: Not too late ^ [05:09:16] <^demon|away> :) [05:09:50] <^demon|away> Oh man, seconds. [05:09:56] <^demon|away> jenkins-bot was seconds behind me [05:09:58] <^demon|away> :p [05:10:22] heh, I was just going to do a follow-up, but I'll amend now [05:10:34] <^demon|away> :) [05:10:44] (03PS7) 10Legoktm: Config: Add Config and GlobalConfig classes [core] - 10https://gerrit.wikimedia.org/r/109266 [05:10:52] ok, that should be good now [05:11:26] (03CR) 10Chad: [C: 032] Config: Add Config and GlobalConfig classes [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm) [05:15:27] (03Merged) 10jenkins-bot: Config: Add Config and GlobalConfig classes [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm) [05:15:31] woo [05:15:38] configuration database done, time to go home! [05:17:01] <^demon|away> We've solved all the problems. [05:17:16] <^demon|away> EVERYTHING ELSE IS EASY NOW [05:17:21] I'll send an email to wikitech in a bit, thanks for the merge :D [05:17:35] <^demon|away> yw. thanks for taking initiative [05:27:14] (03PS6) 10Legoktm: Switch API to use Config classes [core] - 10https://gerrit.wikimedia.org/r/109271 (owner: 10Reedy) [05:28:44] (03CR) 10jenkins-bot: [V: 04-1] Switch API to use Config classes [core] - 10https://gerrit.wikimedia.org/r/109271 (owner: 10Reedy) [05:30:12] (03PS7) 10Legoktm: Switch API to use Config classes [core] - 10https://gerrit.wikimedia.org/r/109271 (owner: 10Reedy) [05:35:37] legoktm, congratulations. [05:35:48] Do you think there should be a tracking bug for changing stuff to use the context? [05:36:24] Meaning use the config from the context [05:36:27] (03CR) 10Legoktm: [C: 031] "Rebased, and changed $config->get( 'IP' ) to $config->get( 'IP', '' ) so it doesn't try accessing $wgIP which was causing the tests to fai" [core] - 10https://gerrit.wikimedia.org/r/109271 (owner: 10Reedy) [05:36:51] superm401: so ^ takes care of everything in includes/api [05:36:57] Individual bugs might be tedious. You could do one for core and one for extensions. [05:37:02] Maybe. [05:37:29] For core, someone just has to do it. [05:38:12] Depending on how compatible extensions want to be, we probably want to wait until 1.23 is stable [05:42:20] (03PS2) 10Ori.livneh: Add fan-out writer [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/109494 [06:07:46] (03CR) 10Parent5446: [C: 031] "I know close to nothing about LESS and CSS sprites, so I won't +2, but the code looks like it makes sense." [core] - 10https://gerrit.wikimedia.org/r/99258 (owner: 10M4tx) [06:21:32] (03PS3) 10Mattflaschen: Auto-launch full tour, not just intro [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/107726 [06:21:35] (03CR) 10jenkins-bot: [V: 04-1] Auto-launch full tour, not just intro [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/107726 (owner: 10Mattflaschen) [06:22:02] (03CR) 10Mattflaschen: "Bug ID added. I'll rebase once the parent is merged." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/107726 (owner: 10Mattflaschen) [06:29:03] (03CR) 10Parent5446: [C: 032] "Tested and functional." [core] - 10https://gerrit.wikimedia.org/r/65440 (owner: 10Waldir) [06:32:25] (03Merged) 10jenkins-bot: skin: Remove the id "anonlogin" and merge pt-anonlogin with pt-login [core] - 10https://gerrit.wikimedia.org/r/65440 (owner: 10Waldir) [07:00:00] Wooooooo config [07:00:20] ? [07:00:44] https://gerrit.wikimedia.org/r/109266 has been merged [07:01:52] So in the meantime we can remove a lot of the globals [07:02:02] Until we decide how to abstract the config out to * [07:06:54] (03PS5) 10Ladsgroup: http://www.mediawiki.org --> https://www.mediawiki.org [core] - 10https://gerrit.wikimedia.org/r/108681 [07:07:05] "let's get this in with minimal bikeshedding"? [07:07:51] like, waiting for tim to review it would have killed someone? ugh. [07:08:35] Tim did see it in person when it was written [07:09:00] (03CR) 10Physikerwelt: "However, it's marked as experimental" [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 (owner: 10Physikerwelt) [07:10:00] * @param string $prefix of the variable name [07:10:54] but the idea is that this would allow us to move beyond the strict mapping of config options to var names [07:11:24] that should just be how GlobalConfig works [07:11:36] it has no business being in the abstract class [07:12:00] i'll just submit a patch [07:14:22] Ah, "just before GERRIT downtime", no WMF downtime today [07:19:38] (03PS3) 10Physikerwelt: Rename some global variables that violate the naming convention [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 [07:24:42] (03CR) 10Ori.livneh: "This was hastily merged. The idea of having an abstract Config class is to abstract some notion of a configuration value from the particul" [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm) [07:34:01] (03CR) 10Frédéric Wang: [C: 031] Rename some global variables that violate the naming convention (032 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 (owner: 10Physikerwelt) [07:34:07] browsing commons feels like some kind of javascript-based DDOS sometimes [07:36:26] (03CR) 10Frédéric Wang: [C: 031] Remove one $wgContLang usage. [extensions/Math] - 10https://gerrit.wikimedia.org/r/87519 (owner: 10Liangent) [07:37:32] (03CR) 10Adamw: [C: 04-2] "This is insecure. I need to copy the logic from other jobs which prevents "rake" invocation when the Rakefile has been changed by an unre" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/109428 (owner: 10Adamw) [07:39:27] (03CR) 10Adamw: [C: 04-2] "Blocked until patch I9f0296ce8a450f1e813ecd30c945166fae959179 can be merged." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/109430 (owner: 10Adamw) [07:45:46] (03CR) 10MZMcBride: "Related: bug 60436" [core] - 10https://gerrit.wikimedia.org/r/107988 (owner: 10Aaron Schulz) [07:48:26] (03PS1) 10Ori.livneh: Make abstract Config class truly implementation-agnostic [core] - 10https://gerrit.wikimedia.org/r/109850 [07:51:36] (03CR) 10Ori.livneh: "I submitted I5a5857fcf to address these issues, but reverting this patch and resubmitting it for additional review seems even better." [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm) [07:57:32] Reedy: what actions trigger captchas is a community thing, right? [07:57:46] Reedy: so folks from the WMF can't unilaterally say 'no captchas for you!' [07:58:43] Reedy: right? [08:01:52] it's complicated [08:02:07] ori: heh [08:02:26] ori: hmm, so is the statement 'WMF can not unilaterally decide that we are abolishing all captchas from next friday' reasonably correct? [08:02:41] notwithstanding things like the plwiki issue [08:02:53] https://bugzilla.wikimedia.org/show_bug.cgi?id=49860 [08:02:57] ptwiki, you mean? [08:03:06] gah yeah [08:03:13] yeah, that's what I meant [08:03:14] it depends on what you mean by 'can' [08:03:42] actually, i'll go on a limb and say it's not correct [08:04:01] They "could" [08:04:05] But it's very unlikely [08:04:14] ori: hmm, 'can' as in 'can without attracting a dispoportional amount of spambots and community backlash' [08:04:18] the WMF made farther-reaching unilateral decisions [08:04:27] in the past, so i wouldn't be so sure [08:04:55] hmm [08:05:51] if "can without attracting a dispoportional amount of spambots and community backlash" is your criterion it covers more or less any user-visible changes to vector and monobook :P [08:08:48] but my understanding of such issues goes only as far as knowing to avoid them i think [08:12:24] ori: :P [08:12:28] ori: heh, alright [08:12:34] ori: yeah, I think same for me. [08:15:44] (03PS1) 10Yuvipanda: DO NOT MERGE: Add basic RL module for navpopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109851 [08:15:48] prtksxna: ^ [08:15:49] (03CR) 10jenkins-bot: [V: 04-1] DO NOT MERGE: Add basic RL module for navpopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109851 (owner: 10Yuvipanda) [08:16:08] hey hashar [08:17:24] prtksxna: https://www.mediawiki.org/wiki/Manual:Hooks/BeforePageDisplay [08:17:25] hello [08:18:07] hashar: think we can do https://gerrit.wikimedia.org/r/#/c/106217/ ? :) [08:18:38] ahh$ [08:18:48] was blocked by mediawiki/extensions.git no more updating [08:18:53] which should be fixed now [08:19:12] you can check by looking at /data/project/common/php-master/extension/MobileApp [08:19:50] hashar: oh? [08:19:54] hashar: but this still needs merging no [08:20:25] yup [08:20:43] a +2 will trigger a merge and after merge another jenkins job will take care of deploying the configuration [08:20:54] hashar: woo! merge? [08:21:32] prtksxna: I invited you from my gmail account. accept? [08:21:44] prtksxna: or just call yuvipanda@gmail.com? [08:21:56] yuvipanda: Calling, didn't get any request [08:22:37] yuvipanda: +2 ed [08:24:26] prtksxna: https://dpaste.de/XMwd [08:24:37] prtksxna: .git/hooks/commit-msg [08:24:45] prtksxna: chmod +x .git/hooks/commit-msg [08:26:34] (03PS1) 10Yurik: Search result as a category page parser function [core] - 10https://gerrit.wikimedia.org/r/109853 [08:27:39] prtksxna: git commit --amend [08:28:36] (03CR) 10Ori.livneh: "...on second thought calling for this to be reverted may be a little hotheaded. But I don't think we should start using it until we've tho" [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm) [08:28:50] * Reedy gives ori a torch and a pitchfork [08:29:51] rage rage rage! [08:35:34] (03PS4) 10Physikerwelt: Rename some global variables that violate the naming convention [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 [08:36:09] prtksxna: git push origin HEAD:refs/for/master [08:41:45] (03PS1) 10Prtksxna: Change alert text [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109854 [08:44:17] (03PS2) 10Prtksxna: Change alert text [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109854 [08:48:17] yuvipanda: https://en.wikipedia.org/wiki/User:Yair_rand/NavPopupsRestyled.js [08:57:51] prtksxna: git review -d [09:02:46] yuvipanda: ask here https://www.mediawiki.org/wiki/Navigation_Popups_(Restyling_and_Enhancements) [09:04:41] (03Abandoned) 10Yuvipanda: DO NOT MERGE: Add basic RL module for navpopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109851 (owner: 10Yuvipanda) [09:04:53] (03Abandoned) 10Yuvipanda: Change alert text [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109854 (owner: 10Prtksxna) [09:21:54] (03CR) 10Nemo bis: "Added to https://www.mediawiki.org/w/index.php?title=Manual%3A%24wgMiserMode&diff=892755&oldid=711024 , please remember docs (I only caugh" [core] - 10https://gerrit.wikimedia.org/r/109710 (owner: 10Aaron Schulz) [09:31:08] (03PS1) 10Physikerwelt: Improve loading of textSearch Engine [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/109855 [09:33:00] (03PS2) 10Physikerwelt: Improve loading of textSearch Engine [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/109855 [09:35:10] (03CR) 10Physikerwelt: [C: 032 V: 032] Improve loading of textSearch Engine [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/109855 (owner: 10Physikerwelt) [09:39:23] (03PS1) 10Physikerwelt: Update of mws submodule [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/109856 [09:40:02] (03CR) 10Physikerwelt: [C: 032 V: 032] Update of mws submodule [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/109856 (owner: 10Physikerwelt) [09:58:30] (03CR) 10Siebrand: [C: 031] "i18n reviewed." [core] - 10https://gerrit.wikimedia.org/r/109853 (owner: 10Yurik) [10:04:44] (03PS1) 1001tonythomas: Removed version check for mysql 4.1.0 from SqlBahOStuff::createTables [core] - 10https://gerrit.wikimedia.org/r/109859 [10:06:42] (03CR) 10jenkins-bot: [V: 04-1] Removed version check for mysql 4.1.0 from SqlBahOStuff::createTables [core] - 10https://gerrit.wikimedia.org/r/109859 (owner: 1001tonythomas) [10:13:49] (03PS2) 1001tonythomas: Removed version check for mysql 4.1.0 from SqlBahOStuff::createTables [core] - 10https://gerrit.wikimedia.org/r/109859 [10:16:34] yuvipanda: Are there extra steps to test with the API locally? I can't find stuff like `exintro` on http://localhost:8080/w/api.php [10:17:06] prtksxna: where's exintro from? [10:17:38] prtksxna: ah [10:17:43] yuvipanda: It exists in https://en.wikipedia.org/w/api.php its to "Return only content before the first section" [10:17:57] prtksxna: 'vagrant enable-role mobilefrontend' 'vagrant provision' [10:17:59] then try again? [10:18:06] prtksxna: it comes from a different extension, in this case mobilefrontend [10:18:36] * prtksxna tries [10:18:43] prtksxna: you can also do 'vagrant enable-role apisandbox' and then have en.wikipedia.org/wiki/Special:ApiSandbox locally to test with [10:18:48] much nicer than /w/api.php [10:19:13] yuvipanda: Ah! But I need this to work for Yair's code [10:19:23] prtksxna: yeah, so install it? [10:19:31] prtksxna: MobileFrontend is enabled on all production wikis anyway. [10:19:38] we can make that an explicit dependency later on [10:20:10] yuvipanda: Ok, its provisioning now… [10:22:48] This takes a while! [10:26:38] (03Abandoned) 10Hashar: Add Python 3.3 syntax checker [integration/jenkins] - 10https://gerrit.wikimedia.org/r/99745 (owner: 10Merlijn van Deen) [10:27:01] (03Abandoned) 10Hashar: Add Python 3.3 syntax checker [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98275 (owner: 10Merlijn van Deen) [10:28:13] (03PS2) 10MarkTraceur: Add link to MultimediaViewer docs [integration/docroot] - 10https://gerrit.wikimedia.org/r/108870 [10:28:23] (03CR) 10Hashar: [C: 032] "Thanks Mark!" [integration/docroot] - 10https://gerrit.wikimedia.org/r/108870 (owner: 10MarkTraceur) [10:28:26] (03Merged) 10jenkins-bot: Add link to MultimediaViewer docs [integration/docroot] - 10https://gerrit.wikimedia.org/r/108870 (owner: 10MarkTraceur) [10:32:56] (03PS1) 10Adrian Lang: Add composer.json file [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/109864 [10:42:39] (03PS1) 10Yuvipanda: Explicitly require TextExtracts for MobileFrontend [vagrant] - 10https://gerrit.wikimedia.org/r/109865 [10:42:50] prtksxna: ^ [10:42:56] prtksxna: apply that patch to your vagrant clone [10:43:00] prtksxna: and try doing provision again? [10:44:30] yuvipanda: If I copy paste the command from gerrit it'll do the same detached from head again? [10:44:40] prtksxna: only on your vagrant clone [10:44:44] prtksxna: you can also do git review -d [10:44:50] yuvipanda: You were telling me about an alternative where the branch name is nicer [10:44:55] yuvipanda: Ah yes! [10:44:55] prtksxna: yeah, that's git review -d [10:46:05] yuvipanda: Ah! But I can't do that because git review isn't running properly [10:46:19] prtksxna: it should be now, since the email issue was fixed [10:46:26] prtksxna: if it wants to do a git review -s first [10:46:32] prtksxna: you can also just copy paste the command from gerrit [10:46:43] (03CR) 10Hashar: [C: 032] Ignore certain tidy warnings in assertValidHtmlDocument (032 comments) [core] - 10https://gerrit.wikimedia.org/r/109142 (owner: 10Hoo man) [10:46:47] (03PS5) 10Hoo man: Ignore certain tidy warnings in assertValidHtmlDocument [core] - 10https://gerrit.wikimedia.org/r/109142 [10:46:53] (03CR) 10Hashar: [C: 032] Ignore certain tidy warnings in assertValidHtmlDocument [core] - 10https://gerrit.wikimedia.org/r/109142 (owner: 10Hoo man) [10:48:13] (03CR) 10Nikerabbit: [C: 04-1] Add composer.json file (035 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/109864 (owner: 10Adrian Lang) [10:48:13] yuvipanda: It still isn't :\ So I copied the command on the page [10:48:19] ok [10:48:25] prtksxna: try running provision again? [10:48:37] yuvipanda: Yes, its running [10:48:46] prtksxna: ok [10:48:53] yuvipanda: May I go and get a smoke now? :P [10:48:58] prtksxna: yes sir :P [10:50:08] yuvipanda: Alright, so the provision ran, still no exintro [10:50:14] wat [10:50:21] prtksxna: hard refresh the page? [10:50:24] it works for me [10:50:59] (03PS2) 10Adrian Lang: Add composer.json file [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/109864 [10:52:05] (03Merged) 10jenkins-bot: Ignore certain tidy warnings in assertValidHtmlDocument [core] - 10https://gerrit.wikimedia.org/r/109142 (owner: 10Hoo man) [10:52:24] yuvipanda: Yup, I did a hard refresh :\ [10:52:35] prtksxna: brr, that's weird. [10:52:38] prtksxna: try vagrant reload? [10:52:43] * prtksxna tries [10:55:51] yuvipanda: I still don't see it. And the API query results in http://hastebin.com/bihomawiyo.pl [10:56:11] prtksxna: what's the query you are using? [10:56:45] prtksxna: I see that it gave you an extract. "extract": "Template:Unreferenced", [10:57:28] yuvipanda: For now I am just running Yair's code [10:57:37] yuvipanda: Should I send you a link to that JS again? [10:57:47] prtksxna: hmm, wait. It seems to be looking for pageimages, not extracts [10:58:20] (03PS2) 10Yuvipanda: Add PageImages & TextExtracts to MobileFrontend [vagrant] - 10https://gerrit.wikimedia.org/r/109865 [10:58:26] prtksxna: checkout ^ and try again? [10:58:29] after doing provision [10:59:43] yuvipanda: Checked out, provisioning now [10:59:48] prtksxna: ok [11:02:33] yuvipanda: This is the new response - http://hastebin.com/jesedorano.sm [11:02:52] prtksxna: yeah, that seems correct to me [11:03:05] prtksxna: you probably won't see any page images because that page probably has no images? [11:03:11] yuvipanda: But the code still doesn't do anything and there is still no exintro in http://localhost:8080/w/api.php [11:03:13] prtksxna: you should do the Special:Export and Special:Import thing [11:03:21] yuvipanda: Right, right! [11:03:42] prtksxna: do 'vagrant enable-role apisandbox', provision again, and see /wiki/Special:ApiSandbox has it? [11:03:51] * prtksxna tries [11:07:46] (03PS4) 10Addshore: Move QueryPage.php to specialpage folder [core] - 10https://gerrit.wikimedia.org/r/109587 [11:08:37] (03CR) 10jenkins-bot: [V: 04-1] Move QueryPage.php to specialpage folder [core] - 10https://gerrit.wikimedia.org/r/109587 (owner: 10Addshore) [11:12:53] (03CR) 10Hashar: [C: 04-1] "Sorry there is no puppet-lint available yet, but you can use '{name}-puppet-validate' meanwhile to at least run 'puppet parser validate'." (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/109428 (owner: 10Adamw) [11:31:14] (03CR) 10Zfilipin: MEDIAWIKI_PASSWORD_VARIABLE environment variable points to the variable that contains the password (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109661 (owner: 10Zfilipin) [12:03:08] (03PS8) 10Zfilipin: MEDIAWIKI_PASSWORD_VARIABLE environment variable points to the variable that contains the password [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109661 [12:09:32] (03Restored) 10Arav93: Removed swear words from core repository [core] - 10https://gerrit.wikimedia.org/r/109297 (owner: 10Arav93) [12:10:08] (03PS1) 10Hashar: gerrit-sync-ve: update Gerrit approval command [integration/jenkins] - 10https://gerrit.wikimedia.org/r/109872 [12:10:24] (03CR) 10Hashar: [C: 032] gerrit-sync-ve: update Gerrit approval command [integration/jenkins] - 10https://gerrit.wikimedia.org/r/109872 (owner: 10Hashar) [12:10:27] (03Merged) 10jenkins-bot: gerrit-sync-ve: update Gerrit approval command [integration/jenkins] - 10https://gerrit.wikimedia.org/r/109872 (owner: 10Hashar) [12:11:37] (03Abandoned) 10Hashar: Syncronize VisualEditor: 263b8c0..2c0faa4 [extensions] - 10https://gerrit.wikimedia.org/r/109822 (owner: 10Jenkins-mwext-sync) [12:11:42] (03Abandoned) 10Hashar: Syncronize VisualEditor: 263b8c0..4b71c52 [extensions] - 10https://gerrit.wikimedia.org/r/109825 (owner: 10Jenkins-mwext-sync) [12:11:47] (03Abandoned) 10Hashar: Syncronize VisualEditor: 263b8c0..641be60 [extensions] - 10https://gerrit.wikimedia.org/r/109829 (owner: 10Jenkins-mwext-sync) [12:12:00] (03CR) 10Hashar: [C: 032 V: 032] Syncronize VisualEditor: 263b8c0..c39d1e6 [extensions] - 10https://gerrit.wikimedia.org/r/109830 (owner: 10Jenkins-mwext-sync) [12:26:06] (03CR) 1001tonythomas: "@Reedy: According to Hoo's Comment here:" [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [12:29:08] tonythomas01: You might want to put that into two separate commits... not sure [12:29:21] I'm to jet lagged right now :P [12:30:46] hoo: oh ! :) I will make it two then [12:31:03] (03PS1) 10Prtksxna: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 [12:48:50] (03PS1) 10Pastakhov: preparing for localization [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/109883 [12:57:13] (03PS14) 1001tonythomas: Error shown if Administrator username and password match in the installer [core] - 10https://gerrit.wikimedia.org/r/105428 [12:59:30] (03CR) 1001tonythomas: "I have spitted the $valid check to another patch. Will upload it soon." [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [12:59:53] (03PS15) 1001tonythomas: Error shown if Administrator username and password match in the installer [core] - 10https://gerrit.wikimedia.org/r/105428 [13:00:31] Working on this bug:https://bugzilla.wikimedia.org/show_bug.cgi?id=60460 . When you say remove $wgDisabledActions....should the line of code in DefaultSettings.php be deleted or replaced? [13:26:20] (03CR) 10Yuvipanda: [C: 04-1] Add JS/CSS for the new NavigationPopups (034 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [13:33:22] (03PS1) 1001tonythomas: Changed the password $valid check condition [core] - 10https://gerrit.wikimedia.org/r/109888 [13:37:31] (03CR) 1001tonythomas: "@Hoo: on changing the $valid condition" [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [14:00:33] (03CR) 10Nuria: [C: 031] "Sorry it took me a while to get to this. Had to learn about co-routines and generators to properly understand what this does." (033 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/109494 (owner: 10Ori.livneh) [14:21:34] marktraceur: What is the purpose of `drag-affordance` thing in the MultimediaViewer extension? [14:27:43] prtksxna: the drag affordance div is there to allow opening/closing the metadata area. you can also reveal the area by scrolling the page [14:28:18] gi11es: But clicking on it or dragging it doesn't do anything (On Chrome/Mac OSX) [14:29:20] prtksxna: it's only supposed to respond to click and it works on beta http://en.wikipedia.beta.wmflabs.org/wiki/Lightbox_demo#mediaviewer/File:Sunrise%20over%20fishing%20boats%20in%20Kerala.jpg/0 [14:29:51] (you need to be logged in with mmv activated on beta for that link to work) [14:31:10] the change that fixed the fact that it didn't respond to click hasn't been deployed yet [14:31:27] gi11es: I had activated it on en.wikipedia.org, so it shows up but the drag thing didn't do anything so I was wondering. Got it! [14:31:49] Thanks gi11es! [14:31:50] there are more improvements being worked on, like keyboard shortcuts and the chevron changing its orientation when the metadata area is open [14:32:02] gi11es: Ah! Nice :) [14:33:57] that element is poorly named anyway, I'll see if we should change it. maybe it responded to drag at some point but that's not the current UX anymore [14:34:16] (03PS1) 10Tinaj1234: Removed deprecated $wgDisabledActions [core] - 10https://gerrit.wikimedia.org/r/109891 [14:34:18] (03PS1) 10Manybubbles: Nuke < and > in query strings [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109892 [14:37:27] gi11es: Yup, I think click makes more sense (at least on desktop anyway) [14:41:45] (03CR) 10Manybubbles: [C: 032] "Verified locally with browser and on command line. Installed vagrant from scratch, added Cirrus role, `vagrant ssh`ed, then:" [vagrant] - 10https://gerrit.wikimedia.org/r/109763 (owner: 10Physikerwelt) [14:41:49] (03Merged) 10jenkins-bot: Puppetize CirrusSearch initialization [vagrant] - 10https://gerrit.wikimedia.org/r/109763 (owner: 10Physikerwelt) [14:42:50] (03PS2) 10Manybubbles: Nuke < and > in query strings [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109892 [15:06:45] feature or bug? Preferences/Appearance/Show table of contents (for pages with more than 3 headings) has been removed... [15:10:46] (03PS1) 10Lekshmi: Changed deprecated $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/109896 [15:11:21] hi [15:11:30] (03CR) 10jenkins-bot: [V: 04-1] Changed deprecated $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/109896 (owner: 10Lekshmi) [15:11:33] hi hashar [15:18:55] manybubbles: ^demon|away : we got a fatal error in CirrusSearch. Example: http://simple.wikipedia.beta.wmflabs.org/wiki/Special:Search/Dan_Inosanto || See https://bugzilla.wikimedia.org/show_bug.cgi?id=60529 : [15:19:37] hashar: checking [15:19:49] that is probably from something merging into core but not yet into cirrus [15:19:57] good morning :] [15:20:30] manybubbles: I guess really need to get mediawiki core unit tests to run whenever an extension change is merged [15:20:34] nope, other way around. I thought it was safe to merge but I was dumb [15:20:50] hashar: or something [15:20:54] back in France? [15:21:01] yes I am [15:21:17] went back on Sunday. Lost Monday in the evil lands of jetlagging [15:21:23] and more or less recovering today [15:21:39] daughter waking up at midnight and 5am surely helps [15:23:27] yeah! my son did similar [15:29:01] (03PS1) 10Lekshmi: Changed deprecated $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/109903 [15:29:21] (03PS1) 10Manybubbles: Only use getSort if it exists [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109904 [15:30:28] hashar: ^^^ is fix for problem [15:30:32] my mistake [15:30:34] might :-] [15:30:43] those fatal errors remembers me of Java NPE [15:31:10] a friend who work for the Scala Play framework told me how they are using "Monades" to prevent such issues [15:31:24] basically you make sure your return an object instead of null :D [15:32:20] (03Abandoned) 10Lekshmi: Changed deprecated $wgCopyrightIcon [core] - 10https://gerrit.wikimedia.org/r/109896 (owner: 10Lekshmi) [15:46:24] (03CR) 10Hashar: "You could add in the new methods documentation:" [core] - 10https://gerrit.wikimedia.org/r/109669 (owner: 10Manybubbles) [15:46:55] (03PS5) 10Roopak: Made the password box appear before "Reset your password" link [core] - 10https://gerrit.wikimedia.org/r/108682 [15:46:57] (03CR) 10Hashar: [C: 031] Only use getSort if it exists [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109904 (owner: 10Manybubbles) [15:54:46] (03PS6) 10Roopak: Made the password box appear before "Reset your password" link [core] - 10https://gerrit.wikimedia.org/r/108682 [16:00:40] (03PS7) 10Roopak: Made the password box appear before "Reset your password" link [core] - 10https://gerrit.wikimedia.org/r/108682 [16:01:53] (03PS4) 10Phuedx: Log impressions of the onboarding CTA. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/109672 [16:03:06] (03Abandoned) 10Hashar: tests to compare En, Qqq and messages.inc [core] - 10https://gerrit.wikimedia.org/r/5550 (owner: 10Hashar) [16:03:51] (03PS2) 10Krinkle: Use use-remote-zuul-no-submodules for lint jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/105244 [16:04:22] (03PS8) 10Roopak: Made the password box appear before "Reset your password" link [core] - 10https://gerrit.wikimedia.org/r/108682 [16:07:08] (03CR) 10Hashar: "deploying" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/105244 (owner: 10Krinkle) [16:08:03] (03CR) 10Hashar: [C: 032] Use use-remote-zuul-no-submodules for lint jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/105244 (owner: 10Krinkle) [16:08:24] (03Merged) 10jenkins-bot: Use use-remote-zuul-no-submodules for lint jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/105244 (owner: 10Krinkle) [16:14:22] (03PS2) 10Manybubbles: Add a sort parameter to SearchEngine and api [core] - 10https://gerrit.wikimedia.org/r/109669 [16:16:08] guillom, ping ETC meeting [16:16:13] ECT :) [16:16:33] qgil: yes, trying to join [16:17:24] ori: have a few minutes to talk about Config? :) [16:19:14] guillom, we are waiting patiently :) [16:19:19] qgil: it won't open :( sorry [16:19:26] (03CR) 10Cscott: [C: 04-1] "Patch still doesn't apply to master." [core] - 10https://gerrit.wikimedia.org/r/109297 (owner: 10Arav93) [16:19:42] guillom, "have you turned it off and on" [16:19:47] ? [16:20:14] the hagout, yes. my computer, no, because it takes ages to reboot [16:20:48] guillom, we can do an instant IRC meeting if you wish [16:21:02] or in the etherpad itself [16:21:08] (03PS1) 10Zfilipin: Moved Sauce Labs browser configuration to mediawiki-selenium Ruby gem [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109911 [16:21:52] qgil: whatever works best; sorry about this [16:22:00] I've updated the planning page in any case [16:22:20] (03CR) 10Manybubbles: [C: 032] Moved Sauce Labs browser configuration to mediawiki-selenium Ruby gem [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109911 (owner: 10Zfilipin) [16:22:24] I don't see anything wrong on my end [16:22:32] (03Merged) 10jenkins-bot: Moved Sauce Labs browser configuration to mediawiki-selenium Ruby gem [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109911 (owner: 10Zfilipin) [16:22:50] Will we one day have technology that Just Works? [16:23:24] (03CR) 10Legoktm: [C: 04-1] "Any user facing text should be localized, see https://www.mediawiki.org/wiki/Manual:Messages_API#Using_messages_in_JavaScript on how to do" (033 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 (owner: 10Prtksxna) [16:24:19] (03CR) 10Physikerwelt: Adding wikimetrics role and module (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/108922 (owner: 10Ottomata) [16:24:49] guillom, sumanah hi, letś invade wikimedia-dev for a bit, since the hangout will not work for all of us today [16:25:10] https://www.mediawiki.org/wiki/Engineering_Community_Team#January_2014 & https://etherpad.wikimedia.org/p/ECT-weekly [16:25:13] (03CR) 10Phuedx: Log impressions of the onboarding CTA. (032 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/109672 (owner: 10Phuedx) [16:25:37] guillom, sumanah apart from the regular planning topics, do you have any specific topic for today? [16:26:28] qgil: I managed to join on my phone [16:26:41] (03PS2) 10Pastakhov: preparing for localization [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/109883 [16:26:41] guillom, well, now we are here :) [16:27:19] qgil: ok :) [16:27:33] qgil: sumanah is having IRC issues :/ [16:27:48] qgil: I don't have much to discuss besides planning [16:28:16] I'm back [16:28:20] sumana-h, guillom Ok, I'll start. Nothing special to comment about my monthly goals. This week we will know more about the status of each OPW project. [16:28:20] qgil: One thing regarding planning is that i moved one item to February (publishing discovery reports) [16:28:23] <^demon|away> hashar: sorry about the fatal. [16:28:27] <^demon|away> I see manybubbles fixed it. [16:28:37] guillom, ok [16:28:42] * sumana-h tries to figure out IRC problems [16:28:44] ^d: I didn't merge it I think [16:29:02] * sumana-h keeps up partially via http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-dev/20140128.txt [16:29:03] sumana-h: squash the gremlins [16:29:08] (03CR) 10Chad: [C: 032 V: 032] Only use getSort if it exists [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109904 (owner: 10Manybubbles) [16:29:19] <^d> manybubbles: Is now :p [16:29:27] ^d: I wanted to make sure that method_exists thing is ok for us to use [16:29:31] sumana-h, guillom I should be able to complete the first community metrics KPI this week, but the second might not be 100% ready yet. [16:29:41] I know it is very pythonic but not sure how phpic [16:29:45] <^d> manybubbles: It's an ugly hack, but works for now :) [16:29:46] qgil: understood - anything we can do to help with the delay? [16:29:54] yay ugly hacks! [16:30:18] <^d> hashar: Fix merged, beta should be unbroke soon. [16:30:23] <^d> Again, sorry 'bout that! [16:30:39] sumana-h, mmm not really, it is good that you both can focus your time in your own pending tasks. It's just about little details. [16:30:44] ok [16:31:12] I created a section for February goals btw [16:31:20] sumana-h, guillom I'm meeting the Bitergia team at FOSDEM [16:31:26] cool! [16:31:28] Oh, nice [16:31:37] I saw the Feb goals section, need to fill it in [16:31:38] beta did its job really well though [16:32:05] I found out that Erik actually just wanted a few ideas/facts from me for his FOSDEM talk, not as much prep as I thought, so I will be shooting those off to him hopefully today [16:32:18] Yes, good idea. The ECT Showcase moved to the first week of February, but by next Tuesday each of us should have listed there their Feb goals [16:32:40] sumana-h, wow, good. [16:33:59] yeah! [16:34:16] along the way I'll do some rough gardening re upstream projects [16:34:25] because part of what I want Erik to do is make specific upstream asks [16:34:59] hi sumanah, btw :) [16:35:08] guillom: I forwarded https://blog.wikimedia.org/2014/01/07/tech-news-fighting-technical-information-overload-for-wikimedians/ to someone looking to get into Wikimedia writing stuff - thank you for writing it [16:35:12] hi hoo! [16:35:24] * aude waves [16:35:28] sumanah: Glad it's useful [16:35:45] (hi aude!) [16:36:00] Today I'm finishing up my "what I learned at Hacker School" thing [16:36:08] sumanah, sumanah about upstream projects, we should start from https://www.mediawiki.org/wiki/Bug_management/Upstream_bugtrackers [16:36:17] qgil: got it [16:36:34] (03PS5) 10Umherirrender: Make a single # an invalid title in php and js [core] - 10https://gerrit.wikimedia.org/r/106561 [16:37:31] guillom, and greg-g: (if you're there) - I would like to know more about what we ought to do re this week's Flow deployment - keep an eye out in BZ? communications? etc [16:37:40] if the Flow team + CLs already have it handled, great [16:37:49] sumanah, I hope Erik pitches the projects we develop and we want to push as upstream. Is this also part of the information you plan to prepare? [16:38:04] I don't know the status, just that it was cancelled, I emailed spage for an update last night, but he hasn't responded yet (reasonably) [16:38:15] sumanah: I don't know anything about that deployment, actually [16:38:54] A quick update on the tools review project: Andre has been reaching out to stakeholders, sending reminders, etc and I'm in the process of summarizing the information they've provided. I'm doing this off-wiki for now but I'll be bale to post it on mw.o in the next couple days [16:38:54] sumanah, quiddity might know more [16:39:06] qgil: when you say "the projects we develop and we want to push as upstream" I'm not quite sure whether you mean stuff like the jQuery libraries that Language Team developed, where we want other projects to adopt them in general, or something else [16:39:21] able* [16:39:22] (oh, ya'll meeting'ing?) [16:39:33] sumanah, e.g. Parsoid [16:39:36] greg-g: yeah, we had Hangout issues, so we are chillin' here [16:39:44] greg-g: yes; Hangouts was misbehaving :) [16:39:46] (03CR) 10Umherirrender: "Patch Set 5: Add 'Sandbox#' to tests as suggested by TMg" [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender) [16:40:03] :) [16:40:16] sumanah, yes, projects that we would love others to use as well, out of MediaWiki / Wikimedia [16:40:28] qgil: I think of VE as something we want other projects to adopt as their WYSIWYG editor - it sounds like you would like other projects to adopt Parsoid as well? [16:40:34] sumanah, Limn was another example, not sure how actively the Analytics team wants to push it today [16:40:40] greg-g: As a sidenote, +1 for verbing "meeting". [16:40:52] +1 [16:42:01] sumanah, well yes, VE means Parsoid. The idea was that ECT starts this list based on whatever we know about the teams'intentions, and then we polish the list based on further reality checks [16:42:16] OK, I understand better now [16:42:34] (03PS3) 10Jackmcbarn: Allow PENDINGCHANGELEVEL to work on other pages [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/106898 [16:42:35] guillom: :) :) [16:43:08] sumanah, https://wikitech.wikimedia.org/wiki/Key_Wikimedia_software_projects is a good place to look at. If we want to push a project to become upstream for tohers then it should be listed there [16:43:10] greg-g: guillom - thanks for the Flow update. [16:43:21] VE means parsoid only if it's wikitext <-> html5, right? [16:43:31] indeed [16:43:32] Got it, qgil, thanks! [16:43:39] VE with only html5 doesn't need parsoid, I think. [16:43:54] (03PS2) 10Jackmcbarn: Make the diff the primary link in thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107402 [16:44:01] * greg-g goes back to prepping for his meeting [16:44:01] I think the goal is to have a standalone VE using HTML storage at some point (for 3rd parties, not us)c [16:44:33] (03PS2) 10Hashar: Exceptions can now optionally have a dedup id [core] - 10https://gerrit.wikimedia.org/r/108890 [16:45:02] OK, that's it from me [16:45:34] greg-g, in any case afaik the Parsoid team has intentions of pushing that project as a generic solution for others. The point of the list is precisely to know which are these projects, how realistic it is to promote them beyond MediaWiki/Wikimedia, and whether we are really planning & resourcing to become good upstream maintainers [16:46:14] qgil: btw we started advertising Tech news on social media channels this week [16:46:53] greg-g, sumanah one of the main reasons to get a FOSDEM talk for Erik was to have an opportunity to promote these projects and start having conversations. I hope we don't miss this chance. [16:47:08] (And in case anyone missed it, I gave a quick status update about PM tools review a few lines above.) [16:47:28] Also to highlight the upstream projects we rely on, also to improve our collaboration with these projects. [16:47:32] (03CR) 10Hashar: "The stack trace signature is now based on the redacted trace. There is two reason for that:" [core] - 10https://gerrit.wikimedia.org/r/108890 (owner: 10Hashar) [16:47:48] qgil: Yup, we're on the same page. That's what Erik's going to do and thus part of what I'm helping give him. [16:47:52] guillom, re Tech News and social media, good! [16:48:03] sumanah, great. Just checking. :) [16:48:06] Nod. [16:48:07] ^d: do you remember what the reason for https://www.mediawiki.org/wiki/Special:Code/MediaWiki/69322 was? [16:48:33] sumanah, guillom , anything else? [16:48:42] nothing from me [16:49:22] the good thing about the improvised IRC meeting is that our notes at https://etherpad.wikimedia.org/p/ECT-weekly will be easier to prepare. Still, your help to capture your poins is appreciated. [16:49:32] sure [16:50:24] <^d> jackmcbarn: Because having the webserver write your config is insecure :) [16:50:52] ^d: how so? don't a lot of programs do that? [16:51:08] sumanah, anything else? [16:51:29] nothing from me [16:51:39] <^d> jackmcbarn: Yes, but they're wrong to :) You shouldn't assume that the webserver should be able to write to disk (and a properly secured webserver won't let you) [16:51:44] ok, then. thank you sumanah guillom [16:51:48] <^d> There's some...old thread...between me and Tim about this. [16:51:58] thank you greg-g :) [16:51:59] <^d> I can't remember where. [16:52:13] i've searched around and didn't see it. anyway, couldn't it try to write it itself and if it fails offer it? [16:52:18] (03PS1) 10Zfilipin: Moved Sauce Labs browser configuration to mediawiki-selenium Ruby gem [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109913 [16:52:23] qgil: :) [16:52:54] <^d> jackmcbarn: It could, very easily. But I went for Tim's suggestion of only doing download. [16:53:28] ok, i'll ask Tim about it next time he's about [16:54:07] (03PS1) 10Umherirrender: Avoid variable naming conflicts in DatabasePostgres::selectSQLText [core] - 10https://gerrit.wikimedia.org/r/109914 [16:57:15] <^d> jackmcbarn: If memory serves (and it might not, it's been a long time), I *think* the conversation was between me and Tim on an earlier installer change. [16:57:22] (03CR) 10MarkAHershberger: [C: 032] "approving based on comments." [core] - 10https://gerrit.wikimedia.org/r/109713 (owner: 10Umherirrender) [16:57:26] <^d> Either on the new-installer branch, or post-merge but before the change you reference. [16:57:45] now if only we had a commenter: gerrit operator [16:57:50] i've submitted https://bugzilla.wikimedia.org/show_bug.cgi?id=60534 and cc'd tim. I'll see if he remembers [16:58:05] (03CR) 10Umherirrender: "I have no postgres to test" [core] - 10https://gerrit.wikimedia.org/r/109914 (owner: 10Umherirrender) [16:58:05] <^d> Nemo_bis: We've got some new query operators once I build the index :) [16:58:57] :o [17:00:39] (03Merged) 10jenkins-bot: Correct sequence name for fresh Postgres installation [core] - 10https://gerrit.wikimedia.org/r/109713 (owner: 10Umherirrender) [17:01:20] (03CR) 10Aude: [C: 04-1] "patch looks fine generally but see comment" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109669 (owner: 10Manybubbles) [17:03:35] (03CR) 10Manybubbles: "Aude asks that I declare the visibility for all the new methods which makes sense to me. Should I just do that for all new methods that I" [core] - 10https://gerrit.wikimedia.org/r/109669 (owner: 10Manybubbles) [17:03:48] manybubbles: yes [17:04:00] aude: I figured you'd say that [17:04:13] I just wanted folks who would say "no" to get a chance to argue their case [17:04:31] (03CR) 10Aude: [C: 04-1] "i don't think anything here is offensive" [core] - 10https://gerrit.wikimedia.org/r/109297 (owner: 10Arav93) [17:04:38] ok [17:04:44] no! [17:04:48] lot of the code is left over from php4 days [17:04:48] wait, what are we talking about? [17:04:49] ;) [17:05:53] (03PS3) 10Manybubbles: Make document building process more extensible [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108952 [17:06:17] (03CR) 10Cscott: "I don't have a huge problem with the idea of the patch, but I'm getting really annoyed that we're all wasting our time with a patch that d" [core] - 10https://gerrit.wikimedia.org/r/109297 (owner: 10Arav93) [17:07:37] (03CR) 10Manybubbles: [C: 031] "Fixed an import error, revised a comment, and ran all regression tests. They pass so I removed the WIP." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108952 (owner: 10Manybubbles) [17:08:41] aude: My big problem is that I never _learned_ PHP. I just slam code together that looks like the code around it that works. [17:09:29] (03CR) 10Aude: [C: 04-1] "small suggestion" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109470 (owner: 10Addshore) [17:09:42] (03CR) 10Chad: [C: 032] Nuke < and > in query strings (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109892 (owner: 10Manybubbles) [17:09:48] (03Merged) 10jenkins-bot: Nuke < and > in query strings [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109892 (owner: 10Manybubbles) [17:09:58] (03CR) 10Chad: "Wrong button, meant to vote 0." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109892 (owner: 10Manybubbles) [17:10:22] (03CR) 10Chad: "Well crap...I was too slow. I hate change screen 2." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109892 (owner: 10Manybubbles) [17:10:28] <^d> fucking cs2. [17:10:39] * ^d stabs stabs stabs [17:10:52] (03CR) 10Manybubbles: "You want to propose a change with str_replace?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109892 (owner: 10Manybubbles) [17:11:10] <^d> manybubbles: Will do. [17:11:21] thanks! [17:12:31] manybubbles: like many of us :) [17:13:18] (03Abandoned) 10MaxSem: Removed swear words from core repository [core] - 10https://gerrit.wikimedia.org/r/109297 (owner: 10Arav93) [17:13:32] <^d> MaxSem beat me to it. [17:13:38] <^d> What a silly patch. [17:13:44] * MaxSem high-fives ^d [17:15:38] ^d: that was great for a laugh [17:15:55] (03CR) 10Aude: Make abstract Config class truly implementation-agnostic (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [17:17:56] (03CR) 10Aude: "i wonder about having an interface for Config instead of an abstract class that gets extended?" [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm) [17:18:39] I feel a bit sad for the author though. https://gerrit.wikimedia.org/r/#/q/owner:aravikn%2540gmail.com,n,z [17:19:08] :/ [17:20:55] ^d: btw, I stumbled upon https://www.mediawiki.org/wiki/User:%5Edemon/Extensions_using_$wgTitle_really_badly earlier today and I wanted to tell you to not worry about the Nimbus skin, we (ShoutWiki) have fixed that and we'll try to commit that (and several other patches, too) upstream soon; for social tools (LinkFilter, PictureGame, PollNY, SocialProfile's UserBoard), patches are welcome :) most of those should be simple, too, save for UserB [17:20:56] oard (it's sorta obscure and could do with a bit of codebase restructuring...any and all ideas on how to get rid of wgTitle there are more than welcome) [17:21:36] (03CR) 10Pastakhov: [C: 032 V: 032] preparing for localization [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/109883 (owner: 10Pastakhov) [17:22:02] <^d> ashley: Coooooool :) [17:22:37] <^d> I have a few easy ones I wrote that needs review too [17:22:38] <^d> https://gerrit.wikimedia.org/r/#/q/status:open+topic:wgTitle-ugh,n,z [17:23:32] (03CR) 10Legoktm: [C: 032 V: 032] Don't use $wgTitle when there's valid ones on hand [extensions/WikiArticleFeeds] - 10https://gerrit.wikimedia.org/r/108846 (owner: 10Chad) [17:23:35] (03Abandoned) 10Pastakhov: Refactoring for the extension PHP Tags [extensions/Foxway] (PhpTags) - 10https://gerrit.wikimedia.org/r/109043 (owner: 10Pastakhov) [17:23:48] (03CR) 10Legoktm: [C: 04-1] "Left inline comments on the commit message. -1 is for RequestContext::getConfig throwing a fatal error since Config::factory was removed." (036 comments) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [17:25:35] (03CR) 10Legoktm: "I used an abstract class because of Config::factory. If we remove it like Ori has proposed, an interface would make sense IMO." [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm) [17:28:36] (03CR) 10Chad: "@Ori: the point was to go ahead and get something in rather than bikeshedding endlessly. Like I said, we can always follow up (and I see y" [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm) [17:31:01] (03CR) 10Chad: Make abstract Config class truly implementation-agnostic (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [17:31:03] (03CR) 10Nemo bis: "Ahem Arav93, I hope by now you're not convinced that MediaWiki devs are a bunch of jerks. legoktm: around? [17:34:37] sup [17:39:14] (03CR) 10Jack Phoenix: [C: 032 V: 032] Remove all uses of $wgTitle from FanBox extension [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/109046 (owner: 10Chad) [17:39:58] (03CR) 10Phuedx: [C: 032 V: 032] Remove uses of Special:GettingStarted from task toolbar [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103740 (owner: 10Mattflaschen) [17:40:39] (03CR) 10Cscott: "I applaud your efforts Nemo, but I'd rather you not call me a jerk. I am willing to help in good faith." [core] - 10https://gerrit.wikimedia.org/r/109297 (owner: 10Arav93) [17:41:03] (03CR) 10Legoktm: "Didn't get to all of Anomie's comments yet, but responded to some of them." (036 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm) [17:41:58] (03CR) 10Aaron Schulz: [C: 032] Avoid variable naming conflicts in DatabasePostgres::selectSQLText [core] - 10https://gerrit.wikimedia.org/r/109914 (owner: 10Umherirrender) [17:42:44] (03PS7) 10Legoktm: [WIP] Revamp API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 [17:42:47] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Revamp API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm) [17:44:35] ^d: I'm surprised Flow isn't on your list...have you seen https://bugzilla.wikimedia.org/show_bug.cgi?id=58664 ? [17:44:56] <^d> It's less bad. [17:45:06] <^d> I was grepping for things calling methods on $wgTitle. [17:45:09] <^d> Those are the worst. [17:45:11] ah [17:45:19] <^d> ack `\$wgTitle->' [17:45:20] (03Merged) 10jenkins-bot: Avoid variable naming conflicts in DatabasePostgres::selectSQLText [core] - 10https://gerrit.wikimedia.org/r/109914 (owner: 10Umherirrender) [17:45:30] <^d> s/`/'/ [17:46:40] (03PS8) 10Legoktm: [WIP] Revamp API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 [17:47:28] (03CR) 10Legoktm: "PS8 was just a rebase." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm) [17:48:00] (03CR) 10Anomie: [C: 04-1] "Missed a few, and broke a few." (0324 comments) [core] - 10https://gerrit.wikimedia.org/r/109271 (owner: 10Reedy) [17:54:15] (03PS1) 10Physikerwelt: WIP: Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 [17:54:18] (03CR) 10jenkins-bot: [V: 04-1] WIP: Editbutton for math [extensions/Math] - 10https://gerrit.wikimedia.org/r/109923 (owner: 10Physikerwelt) [17:54:58] (03PS2) 10Raimond Spekking: Add i18n file [extensions/YetAnotherKeywords] - 10https://gerrit.wikimedia.org/r/108026 [17:56:48] (03CR) 10Nemo bis: "Cscott, in case you were serious, I know you were being helpful. I just hope Arav93 will understand that too. :)" [core] - 10https://gerrit.wikimedia.org/r/109297 (owner: 10Arav93) [17:59:43] Nemo_bis: I looked at arav93's previous patches, and there's a long list of abandoned and broken patches in his wake [17:59:48] (03CR) 10Physikerwelt: "I tried to implement that hook but I got stuck in the middle of the work. (I3d126c1c252c27fa65ab8fb42ffab66a2d99cfa8)" [core] - 10https://gerrit.wikimedia.org/r/109493 (owner: 10Physikerwelt) [18:00:10] Nemo_bis: he seems to be in the habit of attaching a dozen reviewers to his broken patches then dropping them on the floor. [18:00:26] Nemo_bis: he clearly needs someone to hand-hold him on how to best uphold his half of the social contract [18:02:48] (03CR) 10Parent5446: [C: 04-1] Removed deprecated $wgDisabledActions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109891 (owner: 10Tinaj1234) [18:04:06] cscott: True, but I think he mostly chose completely wrong problems to work on. Swear words are just the most egregious example. :) [18:04:27] (03CR) 10Mattflaschen: [C: 04-1] "See inline, particularly the commit message." (036 comments) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [18:06:16] (03CR) 10Anomie: [WIP] Revamp API (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm) [18:06:25] Nemo_bis: i'm not sure, look at https://gerrit.wikimedia.org/r/107840 for example, lots of helpful advice but he dropped it on the floor. [18:06:39] (03CR) 10Phuedx: [C: 032] Remove Special:GettingStarted and notifications [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/106458 (owner: 10Mattflaschen) [18:06:42] (03Merged) 10jenkins-bot: Remove Special:GettingStarted and notifications [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/106458 (owner: 10Mattflaschen) [18:07:31] (03PS1) 10EBernhardson: Use anonymous user in maintenance scripts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109927 [18:10:12] (03PS2) 10EBernhardson: Use anonymous user in maintenance scripts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109927 [18:11:16] (03CR) 10Ottomata: Adding wikimetrics role and module (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/108922 (owner: 10Ottomata) [18:12:55] (03CR) 10Raimond Spekking: "inline note" (031 comment) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/109883 (owner: 10Pastakhov) [18:13:38] (03CR) 10Krinkle: mediawiki.api: Fix token with postWithToken, add test (031 comment) [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [18:16:22] (03CR) 10Krinkle: mediawiki.api: Fix token with postWithToken, add test (031 comment) [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [18:32:24] (03CR) 10Phuedx: [C: 032] Simplify the firstedit tour by removing special VE handling [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/107618 (owner: 10Mattflaschen) [18:38:20] <^d> MaxSem: So, GeoData. [18:38:30] yessir? [18:38:34] <^d> Are you looking at moving that to Elastic soon-ish? [18:38:38] yep [18:38:43] (03PS2) 10Aaron Schulz: Added a simple JobSpecification class for pushing jobs [core] - 10https://gerrit.wikimedia.org/r/109785 [18:38:49] talked with Nik about it last week [18:38:57] <^d> Gotcha. Did you guys take any notes? [18:39:13] was drafting an email, but decided to actually play with it a bit first [18:39:40] * ^d nods [18:39:47] nope. basically, we decided that coordinates will be added to the main index [18:40:04] <^d> So you guys will hook into our updates? [18:40:12] Cirrus will provide a way to extend schema and updater [18:40:13] <^d> Rather than maintain your own index via Elastica? [18:40:20] <^d> Yeah, we're working on that right now. [18:40:20] yep [18:40:28] <^d> Ok, sounds good. Keeps it simple :) [18:40:46] I was wondering where is your schema? [18:41:03] <^d> It's dynamically generated. [18:41:10] from what? [18:41:15] <^d> The two files you're interested in are MappingConfigBuilder and AnalysisConfigBuilder [18:42:37] <^d> I've already added hooks to those two classes for extending the schema. [18:45:32] (03CR) 10Parent5446: [C: 031] Removed version check for mysql 4.1.0 from SqlBahOStuff::createTables [core] - 10https://gerrit.wikimedia.org/r/109859 (owner: 1001tonythomas) [18:45:41] Awww [18:46:19] (03Abandoned) 10EBernhardson: Update wmf/1.23wmf10 branch to match wmf/1.23wmf11 [extensions/Flow] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/109798 (owner: 10EBernhardson) [18:47:08] (03CR) 10Parent5446: [C: 04-1] Changed deprecated $wgCopyrightIcon (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109903 (owner: 10Lekshmi) [18:48:09] (03CR) 10Aaron Schulz: [C: 032] Remove setting referrer from HttpFunctions [core] - 10https://gerrit.wikimedia.org/r/109799 (owner: 10Chad) [18:48:56] (03CR) 10Parent5446: "I like the being bold, but I did mention that $prefix was *definitely* a bad idea. Anyway, nothing a follow-up patch can't fix." [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm) [18:49:06] (03CR) 10Hashar: "deployed. Nice catch Timo." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/105244 (owner: 10Krinkle) [18:49:13] (03PS1) 10Aude: update wikibase, fix for url/commons links not actually being linked [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109935 [18:49:39] (03CR) 10EBernhardson: [C: 032] fetchSubtreeNodeList() on a non-object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109708 (owner: 10Bsitu) [18:50:04] (03Merged) 10jenkins-bot: fetchSubtreeNodeList() on a non-object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109708 (owner: 10Bsitu) [18:52:07] (03Merged) 10jenkins-bot: Remove setting referrer from HttpFunctions [core] - 10https://gerrit.wikimedia.org/r/109799 (owner: 10Chad) [18:52:08] chrismcmahon: physikerwelt does math stuff, IIRD [18:52:09] err [18:52:11] IIRC i mean [18:53:24] (03CR) 10Mattflaschen: "Also, this shows we need PHPUnit tests for getting and using the configuration from the context." [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [19:04:36] (03PS5) 10Aaron Schulz: Removed unused postConnectionBackoff() from LoadMonitor [core] - 10https://gerrit.wikimedia.org/r/105140 [19:05:01] ^d: have to keep rebasing :/ [19:05:55] (03CR) 10Legoktm: "Sorry, I missed this in my review dashboard." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105873 (owner: 10Bsitu) [19:11:15] Is there some MediaWiki function to validate / canonicalise URLs? [19:11:29] Reedy: fun explorer.exe bug...try to rename a file by clicking on it and just changing it's casing [19:11:47] (03CR) 10Chad: [C: 032] Removed unused postConnectionBackoff() from LoadMonitor [core] - 10https://gerrit.wikimedia.org/r/105140 (owner: 10Aaron Schulz) [19:11:48] it doesn't work, you have to change a letter at the same time, then change it back [19:12:17] <^d> werdna: wfParseUrl() will use php's parse_url(), but slightly smarter. [19:12:41] <^d> ? [19:12:45] <^d> Maybe, just guessing. [19:12:55] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: c39d1e6..12e4b41 [extensions] - 10https://gerrit.wikimedia.org/r/109937 [19:12:57] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: c39d1e6..12e4b41 [extensions] - 10https://gerrit.wikimedia.org/r/109937 (owner: 10Jenkins-mwext-sync) [19:13:14] * AaronSchulz doesn't really use this laptop to game anymore and wonders more and more whether to nuke everything and just Linux like his other two boxes [19:13:18] ^d: I could use wfParseUrl() and check if it returns false [19:13:19] ah, right, laziness [19:13:36] <^d> werdna: Seems reasonable :) [19:14:55] (03CR) 10MaxSem: [C: 032] Removed version check for mysql 4.1.0 from SqlBahOStuff::createTables [core] - 10https://gerrit.wikimedia.org/r/109859 (owner: 1001tonythomas) [19:16:47] (03Merged) 10jenkins-bot: Removed unused postConnectionBackoff() from LoadMonitor [core] - 10https://gerrit.wikimedia.org/r/105140 (owner: 10Aaron Schulz) [19:18:00] (03Merged) 10jenkins-bot: Removed version check for mysql 4.1.0 from SqlBahOStuff::createTables [core] - 10https://gerrit.wikimedia.org/r/109859 (owner: 1001tonythomas) [19:22:00] (03CR) 10Hashar: "In mw core we try to get visibility added to any new method. Preferring protected over private in case the class got extended." [core] - 10https://gerrit.wikimedia.org/r/109669 (owner: 10Manybubbles) [19:27:07] (03CR) 10Reedy: [C: 032 V: 032] update wikibase, fix for url/commons links not actually being linked [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109935 (owner: 10Aude) [19:31:26] Reedy: AaronSchulz: any clue where scap-recompile is ? [19:31:41] Math needs another script to be compiled (texvccheck) https://gerrit.wikimedia.org/r/#/c/109284/1/puppet/manifests/roles.pp [19:32:01] hashar: It's sort of not needed [19:32:17] /usr/bin/scap-recompile [19:32:50] Though, that does remind me [19:32:59] ah wikimedia-task-appserver [19:34:05] The current scap-recompile is out of date [19:34:14] Because nothing ever changes [19:34:14] install -d /srv/deployment/mediawiki/uncommon/"$mwVerNum"/bin [19:34:14] install -m 755 "$builddir"/texvc /srv/deployment/mediawiki/uncommon/"$mwVerNum"/bin [19:34:17] need to become [19:34:30] install -d /srv/deployment/mediawiki/uncommon/bin [19:34:30] install -m 755 "$builddir"/texvc /srv/deployment/mediawiki/uncommon/bin [19:35:20] Good luck getting that deployed ;) [19:35:44] should be puppetized instead? [19:35:59] https://gerrit.wikimedia.org/r/#/c/93116/ need merging too [19:36:30] I w [19:36:43] I build texvccheck on tin and was just going to deploy it as such when I'd done with this deplpoy [19:37:18] should go in the scap/ dir [19:37:21] in puppet [19:37:47] but debs! [19:38:24] What's left in wikimedia-task-appserver that's needed to be moved? [19:39:30] there's wmf11 going out to some wikis today right? including uh incubatorwiki? [19:39:37] Very little [19:39:43] apergos: It's already gone, yup [19:39:48] oh good [19:40:03] hping it fixes errors that were preventing a dump run [19:40:15] NS_MODULE? [19:40:21] http://p.defau.lt/?Frd8QHGpvrdCqG4epS5q4A scap and appserver [19:40:28] yep [19:40:32] nailed it in one [19:40:45] (03PS1) 10Ottomata: Removing deprecated user_metrics module [vagrant] - 10https://gerrit.wikimedia.org/r/109942 [19:42:09] (03CR) 10Physikerwelt: Adding wikimetrics role and module (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/108922 (owner: 10Ottomata) [19:43:11] (03CR) 10Ori.livneh: [C: 032] Removing deprecated user_metrics module [vagrant] - 10https://gerrit.wikimedia.org/r/109942 (owner: 10Ottomata) [19:43:13] (03Merged) 10jenkins-bot: Removing deprecated user_metrics module [vagrant] - 10https://gerrit.wikimedia.org/r/109942 (owner: 10Ottomata) [19:44:45] looking good, thanks! [19:44:52] great [19:47:04] (03PS4) 10Mattflaschen: Auto-launch full tour, not just intro [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/107726 [19:48:55] hashar: will you patch the file? [19:50:30] physikerwelt: not sure [19:50:39] physikerwelt: well yeah we need, but scap-recompile is a bit evil [19:51:34] physikerwelt: I thought about adding a new make file in extensions/Math which would compile them boths [19:52:37] hashar: I hope that whatever solution we do now will not be needed for long [19:55:28] hashar: ok. I think the easier way would be to change the makefile at Math/math [19:55:56] (03PS1) 10Hashar: Makefile in root directory [extensions/Math] - 10https://gerrit.wikimedia.org/r/109946 [19:56:04] hoo: ^^^^ [19:56:05] that would provide a basic entry point [19:56:16] but we will still have to tweak scap-recompile [19:56:17] <^demon|lunch> Who owns ClickTracking? [19:56:18] <^demon|lunch> :) [19:56:25] didn't we disable it already [19:56:33] <^demon|lunch> It's still in wmf branches. [19:56:54] ^demon|lunch: is it expected that I can no longer add a reviewer just by typing the first letters and pressing enter? [19:57:07] <^demon|lunch> Bleh :( [19:57:21] hashar: but than we still have to change the 02scap-recompile01 [19:57:26] it used to finish autocomplete and confirm; now it opens the side-by-side diff of the commit message O_o [19:57:34] hashar = [19:57:35] it's so stupid that it must be my fault, right? [19:57:36] * ? [19:57:45] <^demon|lunch> Nemo_bis: You wouldn't believe me if I told you how many times they break that. [19:57:47] hoo: sorry pinged wrong person :-D [19:57:50] physikerwelt: yeah [19:57:57] <^demon|lunch> Nemo_bis: It's the most fragile autocomplete I've ever seen. [19:58:16] it's quite mysterious an autocomplete indeed [19:59:00] <^demon|lunch> And re: clicktracking, I think you're right. [19:59:09] <^demon|lunch> Nobody will merge my change then? :( [19:59:44] hashar: ok if you think that's the way to go... I was thinking it might be easier to change the makefile in Math/math and keep the 02scap-recompile01 script untouched [20:00:01] physikerwelt: talking about that with sam in #wikimedia-operations [20:00:16] we should remove wikimedia-task-appserver I guess [20:30:02] (03CR) 10Aude: Make abstract Config class truly implementation-agnostic (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [20:30:20] (03PS1) 10Manybubbles: Browser test gardening [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109953 [20:33:40] (03PS3) 10Manybubbles: Add a sort parameter to SearchEngine and api [core] - 10https://gerrit.wikimedia.org/r/109669 [20:33:42] hokay, in robots.txt there's a sitemap url for en.wikinews.org which is missing the query string required to create the sitemap. How would I get this updated? [20:36:26] (03CR) 10Parent5446: Make abstract Config class truly implementation-agnostic (033 comments) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [20:41:22] (03CR) 10Chad: Make abstract Config class truly implementation-agnostic (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109850 (owner: 10Ori.livneh) [20:42:48] (03CR) 10Parent5446: [C: 04-1] "Spacing throughout the patch should be tabs. Otherwise patch looks good. Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/109853 (owner: 10Yurik) [20:43:44] (03CR) 10Chad: [C: 032] Remove math specific code from ParserOptions [core] - 10https://gerrit.wikimedia.org/r/108490 (owner: 10Physikerwelt) [20:44:09] (03CR) 10Chad: [C: 032] Remove $wgUseTeX for checking if editing tools should be shown [core] - 10https://gerrit.wikimedia.org/r/109493 (owner: 10Physikerwelt) [20:45:59] (03CR) 10Chad: [C: 04-1] "Missed Bartosz's comment. Holding off for that." [core] - 10https://gerrit.wikimedia.org/r/109493 (owner: 10Physikerwelt) [20:47:01] (03Merged) 10jenkins-bot: Remove math specific code from ParserOptions [core] - 10https://gerrit.wikimedia.org/r/108490 (owner: 10Physikerwelt) [20:50:38] (03CR) 10Chad: [C: 032] Remove $wgUseTeX [extensions/Math] - 10https://gerrit.wikimedia.org/r/109492 (owner: 10Physikerwelt) [20:50:47] (03Merged) 10jenkins-bot: Remove $wgUseTeX [extensions/Math] - 10https://gerrit.wikimedia.org/r/109492 (owner: 10Physikerwelt) [20:51:43] (03CR) 10Chad: [C: 032] Makefile in root directory [extensions/Math] - 10https://gerrit.wikimedia.org/r/109946 (owner: 10Hashar) [20:51:53] (03Merged) 10jenkins-bot: Makefile in root directory [extensions/Math] - 10https://gerrit.wikimedia.org/r/109946 (owner: 10Hashar) [20:52:19] (03CR) 10Aude: [C: 032] "works fine and helps address the bug" [core] - 10https://gerrit.wikimedia.org/r/100563 (owner: 10Daniel Kinzler) [20:53:17] (03PS1) 10Umherirrender: Unroll array_map in ResourceLoaderFileModule::readStyleFiles [core] - 10https://gerrit.wikimedia.org/r/109956 [20:55:03] Chad merged https://gerrit.wikimedia.org/r/#/c/109492/ that depends on https://gerrit.wikimedia.org/r/#/c/109493/ that was stared to be merged but interrupted [20:55:23] in this configuration the edit math button is gone [20:56:04] (03Merged) 10jenkins-bot: (bug 47070) check content model namespace on import. [core] - 10https://gerrit.wikimedia.org/r/100563 (owner: 10Daniel Kinzler) [20:56:18] (03PS2) 10Yurik: Search result as a category page parser function [core] - 10https://gerrit.wikimedia.org/r/109853 [20:56:33] (03PS2) 10JanZerebecki: Use PHPUnit filter/whitelist to select the files that need testing. [core] - 10https://gerrit.wikimedia.org/r/90584 [20:56:39] (03CR) 10Hashar: [C: 032] "Ohh that patch got bumped. Approving per addshore/jeroen. We will see what happens when the code coverage job runs (output at: https://int" [core] - 10https://gerrit.wikimedia.org/r/90584 (owner: 10JanZerebecki) [20:57:30] (03CR) 10Yurik: "PS2 Fixed indentation" [core] - 10https://gerrit.wikimedia.org/r/109853 (owner: 10Yurik) [20:57:50] there are tree options: 1) rollback https://gerrit.wikimedia.org/r/#/c/109492/ 2) merge https://gerrit.wikimedia.org/r/#/c/109493/ 3) comment on my question on how to access the PHP variable/function $wgLang/wfMessage from JavaScript. (preferred) [20:59:40] (03CR) 10Physikerwelt: "now we have a real problem since" [core] - 10https://gerrit.wikimedia.org/r/109493 (owner: 10Physikerwelt) [21:01:50] (03Merged) 10jenkins-bot: Use PHPUnit filter/whitelist to select the files that need testing. [core] - 10https://gerrit.wikimedia.org/r/90584 (owner: 10JanZerebecki) [21:05:23] (03PS4) 10Chad: Add a sort parameter to SearchEngine and api [core] - 10https://gerrit.wikimedia.org/r/109669 (owner: 10Manybubbles) [21:05:29] (03CR) 10Yurik: [C: 04-1] "inline" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109669 (owner: 10Manybubbles) [21:06:38] (03CR) 10Yurik: [C: 04-1] "see my comment for PS3" [core] - 10https://gerrit.wikimedia.org/r/109669 (owner: 10Manybubbles) [21:07:15] (03PS10) 10Ori.livneh: Adding wikimetrics role and module [vagrant] - 10https://gerrit.wikimedia.org/r/108922 (owner: 10Ottomata) [21:09:10] (03PS11) 10Ottomata: Adding wikimetrics role and module [vagrant] - 10https://gerrit.wikimedia.org/r/108922 [21:10:22] (03CR) 10Chad: "I totally agree with Yurk, I hadn't thought of that (or seen the comment) when I was amending PS3." [core] - 10https://gerrit.wikimedia.org/r/109669 (owner: 10Manybubbles) [21:10:32] (03CR) 10Chad: "*Yurik" [core] - 10https://gerrit.wikimedia.org/r/109669 (owner: 10Manybubbles) [21:11:49] (03CR) 10Physikerwelt: [C: 031] Adding wikimetrics role and module [vagrant] - 10https://gerrit.wikimedia.org/r/108922 (owner: 10Ottomata) [21:17:15] (03PS12) 10Ori.livneh: Adding wikimetrics role and submodule [vagrant] - 10https://gerrit.wikimedia.org/r/108922 (owner: 10Ottomata) [21:17:40] (03CR) 10Ori.livneh: [C: 032] Adding wikimetrics role and submodule [vagrant] - 10https://gerrit.wikimedia.org/r/108922 (owner: 10Ottomata) [21:17:43] (03Merged) 10jenkins-bot: Adding wikimetrics role and submodule [vagrant] - 10https://gerrit.wikimedia.org/r/108922 (owner: 10Ottomata) [21:24:12] (03CR) 10Parent5446: [C: 031] "Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/109853 (owner: 10Yurik) [21:27:43] (03PS1) 10EBernhardson: New vagrant-browsertests make command [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110062 [21:30:20] (03CR) 10EBernhardson: [C: 032] New vagrant-browsertests make command [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110062 (owner: 10EBernhardson) [21:30:27] (03Merged) 10jenkins-bot: New vagrant-browsertests make command [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110062 (owner: 10EBernhardson) [21:38:08] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/109960 (owner: 10L10n-bot) [21:38:17] (03PS1) 10CSteipp: SECURITY: Sanitize shell command args [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110069 [21:38:20] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/Agora] - 10https://gerrit.wikimedia.org/r/109961 (owner: 10L10n-bot) [21:38:26] (03PS1) 10CSteipp: Update Release Notes and Version number [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110070 [21:38:28] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/109962 (owner: 10L10n-bot) [21:38:35] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/109963 (owner: 10L10n-bot) [21:38:42] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/109964 (owner: 10L10n-bot) [21:38:50] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/109965 (owner: 10L10n-bot) [21:39:07] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/BreadCrumbs] - 10https://gerrit.wikimedia.org/r/109966 (owner: 10L10n-bot) [21:39:14] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/CategoryTagSorter] - 10https://gerrit.wikimedia.org/r/109967 (owner: 10L10n-bot) [21:39:17] wuuuut [21:39:21] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/109968 (owner: 10L10n-bot) [21:39:24] (03PS1) 10CSteipp: SECURITY: Sanitize shell command args [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/110071 [21:39:29] (03PS1) 10CSteipp: Update release notes and version number [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/110072 [21:39:39] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/109970 (owner: 10L10n-bot) [21:39:46] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/109972 (owner: 10L10n-bot) [21:40:01] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/Configure] - 10https://gerrit.wikimedia.org/r/109974 (owner: 10L10n-bot) [21:40:05] (03PS1) 10Ottomata: Updating wikimetrics submodule with fix for config directories in cloned repo [vagrant] - 10https://gerrit.wikimedia.org/r/110073 [21:40:08] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/109975 (owner: 10L10n-bot) [21:40:19] (03PS1) 10CSteipp: Sanitize shell command args [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/110074 [21:40:23] (03PS1) 10CSteipp: Update release notes and version number [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/110075 [21:40:29] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/109977 (owner: 10L10n-bot) [21:40:34] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/109958 (owner: 10L10n-bot) [21:40:51] (03CR) 10Ori.livneh: [C: 032] Updating wikimetrics submodule with fix for config directories in cloned repo [vagrant] - 10https://gerrit.wikimedia.org/r/110073 (owner: 10Ottomata) [21:41:22] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109971 (owner: 10L10n-bot) [21:44:20] ^demon|lunch: ^^ [21:44:26] Gerrit upgrade related? :/ [21:44:37] (03PS1) 10CSteipp: SECURITY: Escape all shell arguments [extensions/PdfHandler] (REL1_19) - 10https://gerrit.wikimedia.org/r/110080 [21:44:51] <^demon|lunch> Reedy: Maybe? It's grrrrrrrit-wm [21:44:55] <^demon|lunch> Maybe stream-events changed. [21:45:10] Does Raymond usually C2/V2 them? [21:45:12] * Reedy checks [21:45:31] (03PS1) 10CSteipp: SECURITY: Escape all shell arguments [extensions/PdfHandler] (REL1_21) - 10https://gerrit.wikimedia.org/r/110081 [21:45:38] Reedy: Nope, the bot does that [21:45:49] might be that it's broken... no idea [21:45:58] (03Merged) 10jenkins-bot: Updating wikimetrics submodule with fix for config directories in cloned repo [vagrant] - 10https://gerrit.wikimedia.org/r/110073 (owner: 10Ottomata) [21:46:01] https://gerrit.wikimedia.org/r/#/c/108234/ [21:46:11] (03PS1) 10CSteipp: SECURITY: Escape all shell arguments [extensions/PdfHandler] (REL1_22) - 10https://gerrit.wikimedia.org/r/110082 [21:46:21] https://gerrit.wikimedia.org/r/#/c/109971 [21:46:49] I guess that means the question is why Raimond is apparently doing them manually today [21:47:38] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 12e4b41..0b5d86b [extensions] - 10https://gerrit.wikimedia.org/r/110083 [21:47:40] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 12e4b41..0b5d86b [extensions] - 10https://gerrit.wikimedia.org/r/110083 (owner: 10Jenkins-mwext-sync) [21:48:00] Reedy: 1) because translatewiki.net script is broken due to missing rights for project:VisualEditor/VisualEdirtor [21:48:04] (03CR) 10CSteipp: [C: 032] "Deployed on cluster" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110069 (owner: 10CSteipp) [21:48:18] (03CR) 10CSteipp: [C: 032] Update Release Notes and Version number [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110070 (owner: 10CSteipp) [21:48:46] Reedy: 2) and sorry for confusion, I used the wrong user for some +2 of translatarions. now I am using L10n-bot [21:48:59] (03CR) 10CSteipp: [C: 032] SECURITY: Sanitize shell command args [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/110071 (owner: 10CSteipp) [21:49:19] (03PS1) 10Manybubbles: Catch parse errors from Elasticsearch and retry [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110084 [21:49:19] Raymond_: That's fine :). It was more checking that somewhat isn't "newly" broken from the gerrit upgrade [21:49:22] (03CR) 10CSteipp: [C: 032] Update release notes and version number [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/110072 (owner: 10CSteipp) [21:49:42] (03CR) 10CSteipp: [C: 032] Sanitize shell command args [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/110074 (owner: 10CSteipp) [21:49:49] Reedy: nothing with the update. rights requested today: https://www.mediawiki.org/wiki/Gerrit/Project_ownership#L10n-bot_and_Raymond_.2B2_for_VisualEditor.2FVisualEditor [21:49:54] (03CR) 10CSteipp: [C: 032] Update release notes and version number [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/110075 (owner: 10CSteipp) [21:50:16] (03CR) 10CSteipp: [C: 032] SECURITY: Escape all shell arguments [extensions/PdfHandler] (REL1_19) - 10https://gerrit.wikimedia.org/r/110080 (owner: 10CSteipp) [21:50:34] (03CR) 10CSteipp: [C: 032] SECURITY: Escape all shell arguments [extensions/PdfHandler] (REL1_21) - 10https://gerrit.wikimedia.org/r/110081 (owner: 10CSteipp) [21:50:50] (03CR) 10CSteipp: [C: 032] SECURITY: Escape all shell arguments [extensions/PdfHandler] (REL1_22) - 10https://gerrit.wikimedia.org/r/110082 (owner: 10CSteipp) [21:53:22] (03Merged) 10jenkins-bot: SECURITY: Escape all shell arguments [extensions/PdfHandler] (REL1_19) - 10https://gerrit.wikimedia.org/r/110080 (owner: 10CSteipp) [21:53:30] (03Merged) 10jenkins-bot: SECURITY: Escape all shell arguments [extensions/PdfHandler] (REL1_21) - 10https://gerrit.wikimedia.org/r/110081 (owner: 10CSteipp) [21:53:47] (03CR) 10Chad: "Why does that actually depend on this? We still set this for back-compat in DefaultSettings, plus wmf-config sets it to true as well." [core] - 10https://gerrit.wikimedia.org/r/109493 (owner: 10Physikerwelt) [21:54:21] (03Merged) 10jenkins-bot: SECURITY: Escape all shell arguments [extensions/PdfHandler] (REL1_22) - 10https://gerrit.wikimedia.org/r/110082 (owner: 10CSteipp) [21:57:27] (03CR) 10jenkins-bot: [V: 04-1] SECURITY: Sanitize shell command args [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110069 (owner: 10CSteipp) [21:57:29] (03CR) 10jenkins-bot: [V: 04-1] Update Release Notes and Version number [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110070 (owner: 10CSteipp) [21:58:31] (03PS1) 10EBernhardson: Run vagrant browsertests against itself, not beta [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110086 [22:00:49] (03CR) 10Chad: [C: 04-1] Catch parse errors from Elasticsearch and retry (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110084 (owner: 10Manybubbles) [22:02:21] (03CR) 10Manybubbles: [C: 04-1] Catch parse errors from Elasticsearch and retry (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110084 (owner: 10Manybubbles) [22:02:45] (03Merged) 10jenkins-bot: SECURITY: Sanitize shell command args [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/110071 (owner: 10CSteipp) [22:02:50] (03Merged) 10jenkins-bot: Update release notes and version number [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/110072 (owner: 10CSteipp) [22:02:52] (03Merged) 10jenkins-bot: Sanitize shell command args [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/110074 (owner: 10CSteipp) [22:02:56] (03Merged) 10jenkins-bot: Update release notes and version number [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/110075 (owner: 10CSteipp) [22:03:41] (03CR) 10Chad: "I was hoping to keep it simple...I'm not seeing a built-in type that would work well here. I guess we could store it as a string and just " [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109007 (owner: 10Chad) [22:04:29] (03PS2) 10CSteipp: SECURITY: Sanitize shell command args [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110069 [22:05:05] (03CR) 10Manybubbles: "Simple might be to just store it as two ints? If that doesn't turn out to be simple then float is fine." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109007 (owner: 10Chad) [22:05:39] (03CR) 10Mwalker: "I don't have a technical problem with this change -- as it's pretty much a noop from a code standpoint -- but I'm wondering what's the poi" [core] - 10https://gerrit.wikimedia.org/r/109586 (owner: 10Addshore) [22:07:30] (03PS5) 10Chad: Track versions of the index for easier maintenance [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109007 [22:08:19] (03CR) 10CSteipp: [C: 032] SECURITY: Sanitize shell command args [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110069 (owner: 10CSteipp) [22:12:59] (03CR) 10Kaldari: [C: 04-1] Add COPYING (031 comment) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/108973 (owner: 10Reedy) [22:13:26] (03PS1) 10Werdna: Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 [22:13:38] (03CR) 10jenkins-bot: [V: 04-1] Extract wiki and external links, file and template usages from text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110090 (owner: 10Werdna) [22:14:17] (03Merged) 10jenkins-bot: SECURITY: Sanitize shell command args [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110069 (owner: 10CSteipp) [22:14:48] (03PS2) 10CSteipp: Update Release Notes and Version number [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/110070 [22:15:13] Hi, I intend to solve the following bug, but I need some guidance. [22:15:18] Bug : https://bugzilla.wikimedia.org/show_bug.cgi?id=34925 [22:15:49] csteipp: let me know once you're done fiddling with REL1_22; and I'll transition fundraising off our monkeypatched version [22:17:15] (03PS5) 10Manybubbles: Add a sort parameter to SearchEngine and api [core] - 10https://gerrit.wikimedia.org/r/109669 [22:19:09] (03PS6) 10Chad: Track versions of the index for easier maintenance [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109007 [22:19:28] (03CR) 10Manybubbles: Add a sort parameter to SearchEngine and api (032 comments) [core] - 10https://gerrit.wikimedia.org/r/109669 (owner: 10Manybubbles) [22:21:18] (03CR) 10Kaldari: [C: 032] Adding HiDPI 'Heart' SVG icon [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/96356 (owner: 10Sniok) [22:21:20] (03Merged) 10jenkins-bot: Adding HiDPI 'Heart' SVG icon [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/96356 (owner: 10Sniok) [22:23:59] (03PS2) 10Manybubbles: Catch parse errors from Elasticsearch and retry [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110084 [22:25:00] (03CR) 10Manybubbles: Catch parse errors from Elasticsearch and retry (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/110084 (owner: 10Manybubbles) [22:28:52] Hi, I intend to solve the following bug, but I need some guidance. [22:28:54] Bug : https://bugzilla.wikimedia.org/show_bug.cgi?id=34925 [22:30:46] gwicke: should the vrs support overlapping prefixes (e.g. using the most specific one)? [22:30:51] pawan: you can hang around here a bit longer and see if anyone with knowledge shows up (I don't actually know who to ping for you) -- or you can send an email to wikitech-l@lists.wikimedia.org (it also helps to subscribe to that list at https://lists.wikimedia.org/mailman/listinfo/wikitech-l) [22:32:21] mwalker : thanks. I will send a mail [22:32:30] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 0b5d86b..4c3da1b [extensions] - 10https://gerrit.wikimedia.org/r/110094 [22:32:32] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 0b5d86b..4c3da1b [extensions] - 10https://gerrit.wikimedia.org/r/110094 (owner: 10Jenkins-mwext-sync) [22:34:05] AaronSchulz, I guess longest match would make most sense [22:34:26] an efficient way to implement that would be a single regexp ordered by length [22:35:39] the option would be to just not allow that at all [22:35:44] *other option [22:35:50] (03PS7) 10Chad: Track versions of the index for easier maintenance [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109007 [22:36:13] AaronSchulz, in file systems mounting into a subdir is also common [22:36:43] do you see a good reason to disallow that? [22:37:45] just simplicity, but it's fine if there is a use for it [22:39:14] with a single regexp that should still be fairly efficient [22:46:08] (03CR) 10Yurik: "I have been thinking about this feature, and more and more come to realization that it might be better to include the ordering inside the " [core] - 10https://gerrit.wikimedia.org/r/109669 (owner: 10Manybubbles) [22:46:51] (03PS1) 10MaxSem: Add a role for GeoData, with default settings so far [vagrant] - 10https://gerrit.wikimedia.org/r/110097 [22:54:49] (03CR) 10Chad: "The problem is that each backend supports its own set of query parameters. There's no standardization here :\" [core] - 10https://gerrit.wikimedia.org/r/109669 (owner: 10Manybubbles) [23:02:25] (03CR) 10Parent5446: [C: 031] "The purpose is to obey the one-class-per-file rule." [core] - 10https://gerrit.wikimedia.org/r/109586 (owner: 10Addshore) [23:03:01] (03CR) 10Reedy: "A couple can't be changed (config in static methods) with the code as is. Minor refactoring will likely be needed" (0320 comments) [core] - 10https://gerrit.wikimedia.org/r/109271 (owner: 10Reedy) [23:04:56] (03PS3) 10BryanDavis: Add role::wikimania_scholarships [vagrant] - 10https://gerrit.wikimedia.org/r/108067 [23:05:39] (03PS8) 10Reedy: Switch API to use Config classes [core] - 10https://gerrit.wikimedia.org/r/109271 [23:06:42] (03CR) 10Aude: "bump. would be nice to have these tests passing again :)" [core] - 10https://gerrit.wikimedia.org/r/99349 (owner: 10saper) [23:06:57] (03CR) 10Aude: [C: 031] Uninstall GetHumanTimestamp hook for testing core [core] - 10https://gerrit.wikimedia.org/r/99349 (owner: 10saper) [23:07:55] (03CR) 10BryanDavis: "Patchset #3 takes a new approach suggested by Ori of using a named virtualhost rather than needing to exclude the default mediawiki role." [vagrant] - 10https://gerrit.wikimedia.org/r/108067 (owner: 10BryanDavis) [23:08:34] (03CR) 10Physikerwelt: "Doesn't DefaultSettings sets this to false? Only WMF uses wmf-config or? Especially for private wiki's that update from time to time only," [core] - 10https://gerrit.wikimedia.org/r/109493 (owner: 10Physikerwelt) [23:12:38] (03PS1) 10EBernhardson: Lint checks in makefile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110100 [23:14:29] (03PS2) 10EBernhardson: Lint checks in makefile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110100 [23:19:17] spage: has bingle been running for you guys? [23:19:33] i dont think cronjobs have been running, at least not ours [23:19:42] (03CR) 10SG: [C: 031] Lint checks in makefile [extensions/Flow] - 10https://gerrit.wikimedia.org/r/110100 (owner: 10EBernhardson) [23:20:10] (03PS2) 10Prtksxna: Add JS/CSS for the new NavigationPopups [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/109878 [23:32:14] (03PS1) 10Alex Monk: Use mw.util.getUrl for generating Link URLs [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/110101 [23:34:05] anomie: https://gerrit.wikimedia.org/r/#/c/107592/3 is a (tiny) API BC break, can you check if you are OK with it? [23:37:22] gwicke: also, were you thinking of virtual URLs or virtual paths (like filebackend)? [23:37:28] (03CR) 10Manybubbles: "I can switch it to an operator in the query string. That would have been much easier for me to implement in the first place but this seem" [core] - 10https://gerrit.wikimedia.org/r/109669 (owner: 10Manybubbles) [23:37:46] * AaronSchulz likes having encoding dealt with on the lowest level [23:38:26] hardware UTF8 decoders? [23:38:28] AaronSchulz, you with or without protocol? [23:38:30] (03CR) 10Mwalker: "Ordinarily I would agree; but I don't believe we have such a policy -- in fact https://www.mediawiki.org/wiki/Manual:Coding_conventions#Fi" [core] - 10https://gerrit.wikimedia.org/r/109586 (owner: 10Addshore) [23:38:32] (03CR) 10Chad: "Sometimes I wonder how the SearchEngine code would look if we were starting over ;-)" [core] - 10https://gerrit.wikimedia.org/r/109669 (owner: 10Manybubbles) [23:38:39] *you mean* [23:39:08] we can support protocols too, but absolute paths seem to be more compact for the common case [23:39:35] /foo vs. file://foo or the like [23:41:19] actually, callers have to deal with encoding since it's so general (unlike filebackend, which has a narrower idea of what paths are) [23:45:12] (03PS1) 10Kaldari: Improving SVG icon [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/110103 [23:45:47] gwicke: what this comes down to is whether you'd have to use virtual paths like /swift/v1/container/a/b/c.png or /swift/v1/container%2Fa%2Fb%2Fc.png [23:46:16] I suppose if the service instance can munge URLs, any of them could work either way [23:46:42] (03CR) 10Kaldari: [C: 032] Improving SVG icon [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/110103 (owner: 10Kaldari) [23:46:43] I think that should be handled by the service [23:46:44] (03Merged) 10jenkins-bot: Improving SVG icon [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/110103 (owner: 10Kaldari) [23:46:54] * AaronSchulz is sure how much the virtual and "over the wire" URLs should like similar [23:47:06] (03CR) 10Chad: [C: 032] "One class per file. It's the standard in most new code we write now. We should enforce it all over the place. It'd make life a bajillion t" [core] - 10https://gerrit.wikimedia.org/r/109586 (owner: 10Addshore) [23:47:25] AaronSchulz, are we using container/a/b/c.png externally? [23:47:58] to me that looks cleaner in any case [23:48:05] the percent encoding is backend-specific [23:48:25] and could also be done in a proxy in front of swift, so it would be consistent again [23:49:04] in the case of swift, actually we just use "/", though either works if you talk to the proxy [23:49:09] upload paths are all using / [23:49:13] externally [23:50:00] is there support in swift for prefix matching a la container/a/ ? [23:50:01] I'm also thinking about gerrit for example, where a "/" may mean hierarchy and "%2F" is just a character of the same basename [23:50:34] (03Merged) 10jenkins-bot: Split Title and User ArrayFromResult classes to own files [core] - 10https://gerrit.wikimedia.org/r/109586 (owner: 10Addshore) [23:50:42] in that case the vfs might not just be able to always use "/" since it would cause problems for some uses [23:50:51] normally the service implementation should be able to figure out which part of the path to encode when talking to the backend [23:51:09] do you see a case where that is not easily possible? [23:51:57] of course you could always use a custom prefix to avoid this kind of ambiguity [23:52:05] (03PS8) 10Chad: Track versions of the index for easier maintenance [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109007 [23:52:19] a vfs specific one...it would be nice to have more cases overall when thinking about this [23:52:56] for something like swift the rule seems to be to encode slashes from some level on down [23:52:59] (03CR) 10Brian Wolff: "I agree, except I would argue that dummy exception classes can be an exception (Which is not an issue with this patch, just saying in gene" [core] - 10https://gerrit.wikimedia.org/r/109586 (owner: 10Addshore) [23:53:10] that should be fairly simple in the service provider [23:53:48] for Rashomon we have kind of moved away from caring about slashes and relative links [23:53:51] gwicke: so then you are leaning towards using unencoded paths (except maybe for "/" in a few cases)? [23:54:10] instead we plan to use to make relative links work independent of the context [23:54:35] AaronSchulz, yes, in the VFS interface [23:54:36] as long as "/" means hierarchy (as it usually does), the rest of the escaping is usually obvious [23:55:00] and the service instance can handle that [23:55:06] *nod* [23:56:29] (03CR) 10Chad: [C: 032] "Self merge. Look how evil I'm being." [extensions/ClickTracking] - 10https://gerrit.wikimedia.org/r/109045 (owner: 10Chad) [23:56:31] (03Merged) 10jenkins-bot: Tidy up Title/RevId handling in trackRequest() [extensions/ClickTracking] - 10https://gerrit.wikimedia.org/r/109045 (owner: 10Chad)