[00:19:28] (03PS4) 10TTO: Add extra views (tabs) for files in a foreign repository [core] - 10https://gerrit.wikimedia.org/r/104182 [00:24:32] (03PS9) 10Ori.livneh: Move non-SpecialPage specific functions into MassMessage class [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94706 (owner: 10Legoktm) [00:24:56] (03CR) 10MarkAHershberger: "Definitely grep all the code before removing anything. It is too soon to remove deprecations of things that were deprecated in 1.22." [core] - 10https://gerrit.wikimedia.org/r/108490 (owner: 10Physikerwelt) [00:24:58] (03PS10) 10TTO: Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 [00:25:59] (03CR) 10Ori.livneh: [C: 032] Move non-SpecialPage specific functions into MassMessage class [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94706 (owner: 10Legoktm) [00:26:05] (03Merged) 10jenkins-bot: Move non-SpecialPage specific functions into MassMessage class [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94706 (owner: 10Legoktm) [00:26:22] (03PS15) 10Ori.livneh: Add API module to send MassMessages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 (owner: 10Legoktm) [00:26:27] (03PS11) 10Ori.livneh: Add tests for API module [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87416 (owner: 10Legoktm) [00:26:31] (03PS11) 10TTO: Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 [00:32:01] (03CR) 10TTO: "> Oh, and what happens if the Poem extension is *not* uninstalled? Has that been tested?" [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [00:33:32] (03CR) 10Ori.livneh: [C: 032] Add API module to send MassMessages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 (owner: 10Legoktm) [00:33:39] (03Merged) 10jenkins-bot: Add API module to send MassMessages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 (owner: 10Legoktm) [00:33:51] (03CR) 10Ori.livneh: [C: 032] Add tests for API module [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87416 (owner: 10Legoktm) [00:33:57] (03Merged) 10jenkins-bot: Add tests for API module [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87416 (owner: 10Legoktm) [00:38:29] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/109547 (owner: 10L10n-bot) [00:39:00] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/109546 (owner: 10L10n-bot) [00:40:19] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/LanguageTag] - 10https://gerrit.wikimedia.org/r/109549 (owner: 10L10n-bot) [00:40:43] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/109550 (owner: 10L10n-bot) [00:41:40] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/109524 (owner: 10L10n-bot) [00:48:19] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/109525 (owner: 10L10n-bot) [00:48:29] ori: thank you :D [00:49:10] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/109526 (owner: 10L10n-bot) [00:49:52] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/APC] - 10https://gerrit.wikimedia.org/r/109527 (owner: 10L10n-bot) [00:50:48] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/109528 (owner: 10L10n-bot) [00:51:02] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/109529 (owner: 10L10n-bot) [00:52:00] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/109530 (owner: 10L10n-bot) [00:54:42] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/109532 (owner: 10L10n-bot) [02:01:48] (03Abandoned) 10Hashar: Fix fatal in ParserCache::getKey() [core] - 10https://gerrit.wikimedia.org/r/97704 (owner: 10MaxSem) [02:12:03] !log LocalisationUpdate completed (1.23wmf10) at 2014-01-27 02:12:03+00:00 [02:17:20] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/Configure] - 10https://gerrit.wikimedia.org/r/109536 (owner: 10L10n-bot) [02:22:28] !log LocalisationUpdate completed (1.23wmf11) at 2014-01-27 02:22:27+00:00 [02:24:00] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/Convert2Wiki] - 10https://gerrit.wikimedia.org/r/109538 (owner: 10L10n-bot) [02:24:24] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/109539 (owner: 10L10n-bot) [02:25:25] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/Comments] - 10https://gerrit.wikimedia.org/r/109534 (owner: 10L10n-bot) [02:25:36] (03PS2) 10Shirayuki: i18n: remove leading tab character [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109513 [02:26:34] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/Cite] - 10https://gerrit.wikimedia.org/r/109533 (owner: 10L10n-bot) [02:28:37] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/Editcount] - 10https://gerrit.wikimedia.org/r/109540 (owner: 10L10n-bot) [02:28:52] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109541 (owner: 10L10n-bot) [02:29:09] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/109542 (owner: 10L10n-bot) [02:30:26] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/FirstSteps] - 10https://gerrit.wikimedia.org/r/109543 (owner: 10L10n-bot) [02:30:58] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/109544 (owner: 10L10n-bot) [02:31:14] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109545 (owner: 10L10n-bot) [02:33:43] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/109553 (owner: 10L10n-bot) [02:34:09] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/109554 (owner: 10L10n-bot) [02:35:15] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/109557 (owner: 10L10n-bot) [02:35:45] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/109558 (owner: 10L10n-bot) [02:37:04] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/109559 (owner: 10L10n-bot) [02:37:24] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/109560 (owner: 10L10n-bot) [02:37:58] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/109561 (owner: 10L10n-bot) [02:38:43] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/109562 (owner: 10L10n-bot) [02:39:15] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/109563 (owner: 10L10n-bot) [02:39:28] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/109564 (owner: 10L10n-bot) [02:40:11] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/109566 (owner: 10L10n-bot) [02:41:36] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/Transliterator] - 10https://gerrit.wikimedia.org/r/109570 (owner: 10L10n-bot) [02:44:05] (03CR) 10Raimond Spekking: [C: 032] Localisation updates from https://translatewiki.net. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109573 (owner: 10L10n-bot) [02:44:19] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109573 (owner: 10L10n-bot) [02:44:24] !log LocalisationUpdate ResourceLoader cache refresh completed at 2014-01-27 02:44:23+00:00 [02:44:25] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/UserThrottle] - 10https://gerrit.wikimedia.org/r/109574 (owner: 10L10n-bot) [02:46:20] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: ed7678e..0e7d5eb [extensions] - 10https://gerrit.wikimedia.org/r/109610 [02:46:21] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: ed7678e..0e7d5eb [extensions] - 10https://gerrit.wikimedia.org/r/109610 (owner: 10Jenkins-mwext-sync) [02:46:39] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/109567 (owner: 10L10n-bot) [02:49:21] (03CR) 10Raimond Spekking: [C: 032] i18n: remove leading tab character [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109513 (owner: 10Shirayuki) [02:49:30] (03Merged) 10jenkins-bot: i18n: remove leading tab character [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109513 (owner: 10Shirayuki) [03:16:50] !log springle synchronized wmf-config/db-eqiad.php 'repool db1010, depool db1023' [03:39:03] thedj: Around? [04:15:40] (03PS1) 10Gnosygnu: v1.1.4.1 [xowa] - 10https://gerrit.wikimedia.org/r/109614 [04:15:58] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/109614 (owner: 10Gnosygnu) [04:22:09] (03PS2) 10Gnosygnu: v1.1.4.1 [xowa] - 10https://gerrit.wikimedia.org/r/109614 [04:23:00] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/109614 (owner: 10Gnosygnu) [05:09:51] (03PS6) 10Legoktm: [WIP] Revamp API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 [05:09:54] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Revamp API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm) [05:24:46] (03PS5) 10Inchikutty: Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 [05:33:28] Change on 12commons a page User:Petrb was modified, changed by SLS COMPANY link https://commons.wikimedia.org/w/index.php?diff=114872095 edit summary: [+631] [05:42:52] Hrm, wm-bot shouldn't be reporting that in here. [05:43:09] Change on 12commons a page User:Petrb was modified, changed by MZMcBride link https://commons.wikimedia.org/w/index.php?diff=114872383 edit summary: [-631] rvv [06:20:08] (03PS7) 10Inchikutty: Embedding static and leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [06:37:45] (03CR) 10Adamw: [V: 032] Only add students to Special:Students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109462 (owner: 10AndyRussG) [06:40:10] (03CR) 10Adamw: [V: 032] Fix enrollment status on Special:Student [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109463 (owner: 10AndyRussG) [06:40:38] (03CR) 10Adamw: [C: 032] Only add students to Special:Students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109462 (owner: 10AndyRussG) [06:40:47] (03Merged) 10jenkins-bot: Only add students to Special:Students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109462 (owner: 10AndyRussG) [06:40:53] (03CR) 10Adamw: [C: 032] Fix enrollment status on Special:Student [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109463 (owner: 10AndyRussG) [06:41:00] (03Merged) 10jenkins-bot: Fix enrollment status on Special:Student [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109463 (owner: 10AndyRussG) [07:00:33] !log springle synchronized wmf-config/db-eqiad.php 'repool db1023' [07:15:17] (03CR) 10Parent5446: Merge Poem extension into core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [07:19:28] (03CR) 10Parent5446: [C: 031] Add extra views (tabs) for files in a foreign repository [core] - 10https://gerrit.wikimedia.org/r/104182 (owner: 10TTO) [07:28:35] (03PS1) 10Legoktm: Use context instead of global [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109624 [07:38:06] @trusted [07:38:06] I trust: petan|wk.*wikimedia/Petrb (2admin), .*@mediawiki/Krinkle (2admin), .*@wikimedia/Krinkle (2admin), .*@wikimedia/.* (2trusted), .*@wikipedia/.* (2trusted), .*@mediawiki/..* (2trusted), .*@wikipedia/MZMcBride (2admin), .*@wikinews/bawolff (2admin), .*@wikipedia/matma-rex (2admin), .*@wikimedia/qchris (2trusted), [07:38:27] meaning Gloria can use wmbot to handle Tanvir's connection issues in here [07:38:45] Is the bot an op? [07:38:45] ehh, wm-bot doesn't have cs though... [07:38:47] ugh [07:38:54] :/ [07:39:00] Nile Rodgers wins for album of the year! [07:41:41] http://www.youtube.com/watch?v=4S-HuLUWbbc rifftastic [07:48:34] !log springle synchronized wmf-config/db-eqiad.php 'depool db1015' [08:03:28] (03PS1) 10AndyRussG: Read DB_MASTER only as needed for summary fields [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109628 [08:08:16] (03PS2) 10AndyRussG: Read DB_MASTER only as needed for summary fields [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109628 [08:14:21] (03CR) 10Adamw: Read DB_MASTER only as needed for summary fields (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109628 (owner: 10AndyRussG) [08:21:05] (03PS1) 10Pastakhov: Refactoring for the extension PhpTags [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/109629 [08:21:47] (03CR) 10Pastakhov: [C: 032 V: 032] Refactoring for the extension PhpTags [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/109629 (owner: 10Pastakhov) [08:33:18] (03PS1) 10KartikMistry: Update README [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/109630 [08:36:04] (03CR) 10TTO: Merge Poem extension into core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [08:36:12] (03PS2) 10KartikMistry: Update README [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/109630 [08:39:20] (03PS12) 10TTO: Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 [08:54:50] (03PS1) 10AndyRussG: Accurately report institution activity [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109631 [08:54:57] (03CR) 10jenkins-bot: [V: 04-1] Accurately report institution activity [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109631 (owner: 10AndyRussG) [09:10:44] (03PS2) 10AndyRussG: Accurately report institution activity [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109631 [09:10:51] (03CR) 10jenkins-bot: [V: 04-1] Accurately report institution activity [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109631 (owner: 10AndyRussG) [09:16:13] (03PS3) 10AndyRussG: Accurately report institution activity [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109631 [09:16:20] (03CR) 10jenkins-bot: [V: 04-1] Accurately report institution activity [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109631 (owner: 10AndyRussG) [09:19:32] (03PS1) 10Mglaser: Make MySQLi work with non-standard port (bug 58153) [core] - 10https://gerrit.wikimedia.org/r/109634 [09:40:43] (03CR) 10Matthias Mullie: [C: 032] Use context instead of global [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109624 (owner: 10Legoktm) [09:40:51] (03Merged) 10jenkins-bot: Use context instead of global [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109624 (owner: 10Legoktm) [09:44:00] (03PS2) 10Mglaser: Make MySQLi work with non-standard port (bug 58153) [core] - 10https://gerrit.wikimedia.org/r/109634 [09:53:01] (03CR) 10Matthias Mullie: "I agree on using ->msg() instead of wfMessage()" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109487 (owner: 10Legoktm) [09:54:36] ori: the layout thrashing links were very useful. Hadn't been considering that what looks like a simple attribute read on a DOM object might not be a simple attribute read [09:54:38] all the time [09:55:28] not much practical changes yet, since I wasn't doing much Layout changes anyway. [09:55:38] but good to know :) [09:56:47] cool! [09:57:29] ori: :) [09:57:40] ori: I'm using browserify. Should be interesting to see if I end up using any node modules [10:05:24] * ori looked it up [10:08:10] (03CR) 10Helder.wiki: ":-)" [vagrant] - 10https://gerrit.wikimedia.org/r/109605 (owner: 10Ori.livneh) [10:21:47] (03CR) 10Matthias Mullie: Anonymous editor warning (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109445 (owner: 10Werdna) [10:32:11] (03CR) 10Addshore: Fix phpdoc in SwiftFileBackend (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109588 (owner: 10Addshore) [10:32:58] (03PS1) 10Addshore: Put callback function within class in SiteConfigurationTest [core] - 10https://gerrit.wikimedia.org/r/109640 [10:38:00] (03PS2) 10Addshore: Fix phpdoc in SwiftFileBackend [core] - 10https://gerrit.wikimedia.org/r/109588 [10:38:57] (03CR) 10Matthias Mullie: Fix permissions (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109084 (owner: 10Matthias Mullie) [10:39:10] (03PS4) 10Matthias Mullie: Fix permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109084 [10:42:33] (03PS3) 10AndyRussG: Read DB_MASTER only as needed for summary fields [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109628 [10:43:16] (03CR) 10Gilles: [C: 032] Fix counting error [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109602 (owner: 10Ocean behind ears) [10:43:28] (03Merged) 10jenkins-bot: Fix counting error [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109602 (owner: 10Ocean behind ears) [10:44:33] !log springle synchronized wmf-config/db-eqiad.php 'repool db1015, warm up' [10:48:40] (03CR) 10Matthias Mullie: [C: 032] Do not apply font styles on non-plain-text headers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109029 (owner: 10SG) [10:48:47] (03Merged) 10jenkins-bot: Do not apply font styles on non-plain-text headers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109029 (owner: 10SG) [11:22:17] (03CR) 10Phuedx: [C: 031] Simplify the firstedit tour by removing special VE handling [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/107618 (owner: 10Mattflaschen) [11:36:23] (03CR) 10Addshore: [C: 031] (bug 47070) check content model namespace on import. [core] - 10https://gerrit.wikimedia.org/r/100563 (owner: 10Daniel Kinzler) [11:37:13] (03PS1) 10AndyRussG: Update summary data when undeleting a course [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109643 [12:04:05] (03PS1) 10Pastakhov: restore operator 'foreach' [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/109651 [12:05:23] (03PS2) 10Pastakhov: restore operator 'foreach' [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/109651 [12:06:10] (03CR) 10Pastakhov: [C: 032 V: 032] restore operator 'foreach' [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/109651 (owner: 10Pastakhov) [12:22:45] (03CR) 10Arav93: "Helder, Oh. I don't know how I'm supposed to do that." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/109461 (owner: 10Arav93) [13:17:19] (03PS21) 10Gilles: Create jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [13:17:50] (03CR) 10Gilles: [C: 032] Create jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [13:21:22] (03Merged) 10jenkins-bot: Create jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [13:26:36] (03CR) 1001tonythomas: "@Bartoz - Is renaming the message necessary?" [core] - 10https://gerrit.wikimedia.org/r/107360 (owner: 1001tonythomas) [13:26:53] !log springle synchronized wmf-config/db-eqiad.php 'depool db1006' [13:28:09] (03CR) 10Nikerabbit: [C: 032 V: 032] Replace deprecated wfMsg with wfMessage [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/109601 (owner: 10Svemir Brkic) [13:37:58] (03CR) 10Dereckson: "Can you test it on your development wiki with the following page content?" [core] - 10https://gerrit.wikimedia.org/r/108205 (owner: 10Arav93) [13:41:53] (03PS1) 10Arav93: Altered the time separator for Slovene from colon to period [core] - 10https://gerrit.wikimedia.org/r/109658 [13:50:01] (03PS10) 1001tonythomas: Error shown ifAdministrator username and passwod match shown on same page of installer [core] - 10https://gerrit.wikimedia.org/r/105428 [14:05:02] (03PS6) 10Physikerwelt: Add mathsearch role to vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/108827 [14:10:12] (03PS1) 10Gerrit Patch Uploader: Remove IE80Fixes.css [core] - 10https://gerrit.wikimedia.org/r/109660 [14:10:18] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/109660 (owner: 10Gerrit Patch Uploader) [14:36:11] (03PS2) 10Physikerwelt: Update to MathJax 2.3 [extensions/Math] - 10https://gerrit.wikimedia.org/r/109490 [14:38:09] (03PS1) 10Zfilipin: WIP Run UploadWizard API tests at CloudBees [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109661 [14:38:57] (03PS3) 10Brian Wolff: Put the space before category links to consideration [core] - 10https://gerrit.wikimedia.org/r/108205 (owner: 10Arav93) [14:39:17] (03CR) 10Brian Wolff: "Rebase for jenkins" [core] - 10https://gerrit.wikimedia.org/r/108205 (owner: 10Arav93) [14:42:24] (03CR) 10jenkins-bot: [V: 04-1] Put the space before category links to consideration [core] - 10https://gerrit.wikimedia.org/r/108205 (owner: 10Arav93) [14:43:22] (03CR) 10Jack Phoenix: [C: 04-1] "Unless Microsoft has fixed the textarea scrolling bug within the past four years or so (which I somehow doubt), these hacks are very neces" [core] - 10https://gerrit.wikimedia.org/r/109660 (owner: 10Gerrit Patch Uploader) [14:55:00] (03CR) 10Manybubbles: Track versions of the index for easier maintenance (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109007 (owner: 10Chad) [14:58:03] (03CR) 10Physikerwelt: "Frédéric: Thank you very much for your comments. I updated the change according to your comments. Please recheck." [extensions/Math] - 10https://gerrit.wikimedia.org/r/109490 (owner: 10Physikerwelt) [14:59:38] (03CR) 10Jack Phoenix: [C: 032 V: 032] This has been optimized for over 2 years now [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/109044 (owner: 10Chad) [15:00:41] (03CR) 10Jack Phoenix: [C: 032 V: 032] Adds an i18n file for the base of the extension [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/107874 (owner: 10Raimond Spekking) [15:02:03] (03CR) 10Jack Phoenix: [C: 032 V: 032] Turn Comments class into a ContextSource [extensions/Comments] - 10https://gerrit.wikimedia.org/r/106665 (owner: 10Legoktm) [15:12:33] (03CR) 10Legoktm: "I changed the typehints because I was planning on re-using the formatter to integrate in the CheckUser extension, which doesn't have a Con" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109487 (owner: 10Legoktm) [15:14:47] (03PS2) 10Zfilipin: WIP Run UploadWizard API tests at CloudBees [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109661 [15:14:57] (03CR) 10jenkins-bot: [V: 04-1] WIP Run UploadWizard API tests at CloudBees [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109661 (owner: 10Zfilipin) [15:18:38] (03PS3) 10Zfilipin: WIP Run UploadWizard API tests at CloudBees [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109661 [15:26:12] (03CR) 10Fomafix: "I have IE8 on Windows 7 and I can't reproduce a scrolling bug." [core] - 10https://gerrit.wikimedia.org/r/109660 (owner: 10Gerrit Patch Uploader) [15:28:48] (03PS4) 10Zfilipin: WIP Run UploadWizard API tests at CloudBees [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109661 [15:28:57] (03CR) 10jenkins-bot: [V: 04-1] WIP Run UploadWizard API tests at CloudBees [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109661 (owner: 10Zfilipin) [15:35:07] (03PS5) 10Zfilipin: WIP Run UploadWizard API tests at CloudBees [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109661 [15:46:05] (03PS6) 10Zfilipin: MEDIAWIKI_PASSWORD_VARIABLE environment variable points to the variable that contains the password [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109661 [15:47:19] (03PS1) 10Manybubbles: Add a sort parameter to SearchEngine and api [core] - 10https://gerrit.wikimedia.org/r/109669 [15:49:21] (03CR) 10Manybubbles: "I haven't added this to the default search page at this point because I'm not sure it is particularly useful there. It might be useful in" [core] - 10https://gerrit.wikimedia.org/r/109669 (owner: 10Manybubbles) [15:53:06] (03PS1) 10Manybubbles: Support SearchEngine's new sort parameter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109671 [16:01:04] (03PS1) 10Phuedx: Log impressions of the onboarding CTA. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/109672 [16:07:56] (03PS3) 10Bartosz Dziewoński: Fix phpdoc in SwiftFileBackend [core] - 10https://gerrit.wikimedia.org/r/109588 (owner: 10Addshore) [16:08:03] (03CR) 10Bartosz Dziewoński: [C: 032] Fix phpdoc in SwiftFileBackend [core] - 10https://gerrit.wikimedia.org/r/109588 (owner: 10Addshore) [16:09:48] (03PS4) 10Manybubbles: Track versions of the index for easier maintenance [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109007 (owner: 10Chad) [16:12:03] (03Merged) 10jenkins-bot: Fix phpdoc in SwiftFileBackend [core] - 10https://gerrit.wikimedia.org/r/109588 (owner: 10Addshore) [16:12:14] (03CR) 10Manybubbles: "Fixed small copy paste typo and updated version numbers to 0.1 so I could see them output properly." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109007 (owner: 10Chad) [16:15:33] (03CR) 10Manybubbles: Add cirrus search (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/108845 (owner: 10Physikerwelt) [16:18:00] (03CR) 10Manybubbles: "Chad: I believe you mentioned to me in person that you had another version of this that was less crazy." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108952 (owner: 10Manybubbles) [16:20:22] (03CR) 10Manybubbles: "I2071f04b is currently on test2wiki and will make it onto all others this Thursday. We can wait to merge then." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106445 (owner: 10Chad) [16:22:14] (03PS5) 10Physikerwelt: Add cirrus search [vagrant] - 10https://gerrit.wikimedia.org/r/108845 [16:26:47] (03CR) 10Jhall: [C: 031] MEDIAWIKI_PASSWORD_VARIABLE environment variable points to the variable that contains the password [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109661 (owner: 10Zfilipin) [16:35:33] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Quoting comment 9 on bug 58153 from Alex Legler: That won't handle the syntax for persistent connections correctly which is 'p:: (03CR) 10Bartosz Dziewoński: Make MySQLi work with non-standard port (bug 58153) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109634 (owner: 10Mglaser) [16:36:48] (03PS6) 10Physikerwelt: Add cirrus search [vagrant] - 10https://gerrit.wikimedia.org/r/108845 [16:47:30] (03PS3) 10Frédéric Wang: Update to MathJax 2.3 [extensions/Math] - 10https://gerrit.wikimedia.org/r/109490 (owner: 10Physikerwelt) [16:53:57] (03CR) 10Frédéric Wang: "OK, I tested again the MW_MATH_MATHJAX with the three MathJax output modes and that seems to work." [extensions/Math] - 10https://gerrit.wikimedia.org/r/109490 (owner: 10Physikerwelt) [16:55:55] (03PS1) 10Chad: Don't override limits and offsets in SearchEngine::create() [core] - 10https://gerrit.wikimedia.org/r/109679 [16:56:11] (03CR) 10Ottomata: "Thanks Ori!" [vagrant] - 10https://gerrit.wikimedia.org/r/108640 (owner: 10Ottomata) [16:56:25] Well this is new, git pull gives "key_verify failed for server_host_key" [16:57:13] (03CR) 10Manybubbles: [C: 031] Don't override limits and offsets in SearchEngine::create() [core] - 10https://gerrit.wikimedia.org/r/109679 (owner: 10Chad) [16:58:42] (03CR) 10Ottomata: "Hmm, good idea! I will think about this. I wouldn't want to force people to update whenever they run puppet but using submodule init to " [vagrant] - 10https://gerrit.wikimedia.org/r/108922 (owner: 10Ottomata) [16:59:17] <^d> bawolff: There's a bug about it. [16:59:25] <^d> tl;dr: Try again, it'll probably work. [16:59:40] !bug key_verify failed for server_host_key [16:59:40] https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=key_verify+failed+for+server_host_key [16:59:43] thanks, it did [16:59:46] that one [16:59:59] it fucks up unit test runners from time to time too [17:00:13] if something inexplicably fails saying it can't be merged, that's the root cause [17:00:24] <^d> And translatewiki from time to time. [17:00:37] sadly no one cares but me [17:09:48] (03CR) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement buildMainQueryConds() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103546 (owner: 10Bartosz Dziewoński) [17:11:33] (03CR) 10Parent5446: [C: 04-1] "Minor style issue. Otherwise good to go." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [17:12:42] hmm [17:13:16] <^d> MatmaRex: I care. Hard to fix when it's basically impossible to reproduce reliably. [17:13:50] sql engines are smart enough to make !(a=='a' or b=='b') and (a!='a' and b!='b') the same? [17:13:54] ^d: :( [17:14:13] have the same behavior when executing the query* [17:15:40] (03CR) 10Physikerwelt: [C: 031] Don't override limits and offsets in SearchEngine::create() [core] - 10https://gerrit.wikimedia.org/r/109679 (owner: 10Chad) [17:25:50] (03PS8) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement two new hooks superseding 4 old ones [core] - 10https://gerrit.wikimedia.org/r/106279 [17:25:52] (03PS9) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement webOutput() [core] - 10https://gerrit.wikimedia.org/r/105195 [17:25:54] (03PS9) 10Bartosz Dziewoński: ChangesListSpecialPage: Stop mutating $opts in buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/105196 [17:25:56] (03PS1) 10Bartosz Dziewoński: ChangesListSpecialPage: Leave doing Boolean algebra to the SQL engine [core] - 10https://gerrit.wikimedia.org/r/109687 [17:26:17] oh poop. didn't mean to push that many commits, just one [17:26:18] meh [17:26:29] (03CR) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement buildMainQueryConds() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103546 (owner: 10Bartosz Dziewoński) [17:26:42] !log csteipp synchronized php-1.23wmf10/extensions/TimedMediaHandler 'bug 56699 refix' [17:27:14] ragesoss: --^ that was for you :) [17:28:51] bawolff: sweet, it works! [17:31:36] (03CR) 10jenkins-bot: [V: 04-1] ChangesListSpecialPage: Leave doing Boolean algebra to the SQL engine [core] - 10https://gerrit.wikimedia.org/r/109687 (owner: 10Bartosz Dziewoński) [17:34:15] (03CR) 10Mdale: "In agreement with Mattflaschen would be ideal if it returned a promise." (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108472 (owner: 10Brian Wolff) [17:36:45] (03CR) 10Bartosz Dziewoński: ChangesListSpecialPage: Stop mutating $opts in buildMainQueryConds() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105196 (owner: 10Bartosz Dziewoński) [17:37:12] (03CR) 10Bartosz Dziewoński: "I don't think we should deprecate them until we stop using them ourselves, and we are using them ourselves a lot (see the first comment he" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106279 (owner: 10Bartosz Dziewoński) [17:37:29] (03PS1) 10BryanDavis: Always return an array from SwiftFileBackend::addMissingMetadata [core] - 10https://gerrit.wikimedia.org/r/109690 [17:37:38] (03PS9) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement two new hooks superseding 4 old ones [core] - 10https://gerrit.wikimedia.org/r/106279 [17:37:40] (03PS2) 10Bartosz Dziewoński: ChangesListSpecialPage: Leave doing Boolean algebra to the SQL engine [core] - 10https://gerrit.wikimedia.org/r/109687 [17:37:42] (03PS10) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement webOutput() [core] - 10https://gerrit.wikimedia.org/r/105195 [17:37:44] (03PS9) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement doMainQuery() [core] - 10https://gerrit.wikimedia.org/r/105194 [17:37:46] (03PS10) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/103546 [17:37:48] (03PS10) 10Bartosz Dziewoński: ChangesListSpecialPage: Stop mutating $opts in buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/105196 [17:38:21] legoktm: i fixed all the stuff you asked me to fix ^, thanks for reviews [17:39:48] (03CR) 10Bartosz Dziewoński: [C: 032] Don't override limits and offsets in SearchEngine::create() [core] - 10https://gerrit.wikimedia.org/r/109679 (owner: 10Chad) [17:39:55] (03CR) 10BryanDavis: Always return an array from SwiftFileBackend::addMissingMetadata (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109690 (owner: 10BryanDavis) [17:42:53] (03PS11) 1001tonythomas: Error shown ifAdministrator username and passwod match shown on same page of installer [core] - 10https://gerrit.wikimedia.org/r/105428 [17:43:24] (03CR) 10Bartosz Dziewoński: "I think it is, since if no one updates the translations they will show up in a broken way. You could alternatively not remove the current " [core] - 10https://gerrit.wikimedia.org/r/107360 (owner: 1001tonythomas) [17:46:15] (03Merged) 10jenkins-bot: Don't override limits and offsets in SearchEngine::create() [core] - 10https://gerrit.wikimedia.org/r/109679 (owner: 10Chad) [17:47:30] (03CR) 1001tonythomas: "@Parent5446: Done!" [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [17:49:47] (03CR) 10Isarra: "IE8 may well behave differently in XP - windows can be fun like that. If you test it in an XP VM and it works there, then it should be fin" [core] - 10https://gerrit.wikimedia.org/r/109660 (owner: 10Gerrit Patch Uploader) [17:52:47] (03CR) 10Brian Wolff: "For reference, IE8 has 3.75% of our hits. I agree with Jack that it warrants continued support." [core] - 10https://gerrit.wikimedia.org/r/109660 (owner: 10Gerrit Patch Uploader) [17:53:09] Hey, if I have some commentary after the fact about the architecture summit thing, is there any right place to put it? [17:53:40] (03CR) 10Aaron Schulz: [C: 04-1] Always return an array from SwiftFileBackend::addMissingMetadata (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109690 (owner: 10BryanDavis) [17:53:56] I was contemplating writing a blog post on my blog that nobody reads... [17:54:46] (03PS2) 10BryanDavis: Always return an array from SwiftFileBackend::addMissingMetadata [core] - 10https://gerrit.wikimedia.org/r/109690 [17:55:05] Isarra: we could probably link such things on the summit page [17:55:25] (03CR) 10BryanDavis: Always return an array from SwiftFileBackend::addMissingMetadata (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109690 (owner: 10BryanDavis) [17:55:26] this actually sounds like a pretty good idea [17:55:49] Hmm, aye... [17:56:08] * MatmaRex does that [17:56:15] (03PS2) 10Phuedx: Log impressions of the onboarding CTA. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/109672 [17:56:19] so [17:56:23] who knows about AbuseFilter [17:56:25] I guess I should fix my blog so it's actually usable again. [17:56:27] (03CR) 10Aaron Schulz: [C: 032] Always return an array from SwiftFileBackend::addMissingMetadata [core] - 10https://gerrit.wikimedia.org/r/109690 (owner: 10BryanDavis) [17:56:28] and how it interacts with the API? [17:56:35] legoktm! [17:56:40] Isarra: but he's not here yet! [17:56:43] >.> [17:56:48] * YuviPanda eyes MatmaRex and bawolff and Isarra [17:56:58] I don't know anything! [17:57:02] any idea if there's a specific easy to trigger abusefilter rule on testwiki? [17:57:07] YuviPanda: all i can tell you is that it does interact with it. [17:57:09] I know enough to be scared [17:57:14] Find a rule and trigger it. [17:57:14] hehe [17:57:30] Or add a rule that triggers on everything! [17:57:49] do I wander around the streets looking for a rule to trigger? [17:57:54] bawolff: that sounds like a lot [17:57:54] hmm [17:57:56] or a little [17:58:00] Add a global rule that tags random edits CHICKEN! Confuse the hell out of the users! [17:58:06] (I've never interacted with abusefilter) [17:58:12] ...I should probably turn that rule off one of these days. [17:58:25] Er, filter. [17:58:39] Isarra: i boldly added a section. :D https://www.mediawiki.org/wiki/Architecture_Summit_2014#Notes_and_retrospectives [17:58:50] MatmaRex: Excellent. [17:58:57] * Isarra waits for it to load. [17:59:05] i'll put the etherpads there for a start, i think [17:59:09] YuviPanda: I think it would be cool if its custom language was changed to lua. That's about the extent of my thoughts on abusefilter [17:59:21] bawolff: ah, hmm, ok! [17:59:31] YuviPanda: https://test.wikipedia.org/wiki/Special:AbuseFilter/1 [17:59:50] (03Merged) 10jenkins-bot: Always return an array from SwiftFileBackend::addMissingMetadata [core] - 10https://gerrit.wikimedia.org/r/109690 (owner: 10BryanDavis) [17:59:57] I think you can trigger that. :P [18:00:48] Isarra: oh, hmm, there's also https://www.mediawiki.org/wiki/Architecture_Summit_2014/Retrospective [18:01:07] LINK IT TOO. [18:01:22] (03CR) 10Parent5446: [C: 032] Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [18:01:37] Someone else can clean it all up later? I dunno. [18:02:09] legoktm: I must say I laughed at the "Developers are still unsure who "Max" is" line in the signpost [18:02:19] (03CR) 10Cscott: [C: 04-2] Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [18:02:46] Isarra: wooh, thanks [18:04:15] Isarra: hmm, doesn't seem to be working https://test.wikipedia.org/wiki/Test_abuse_Filter [18:05:42] YuviPanda: What the... worked for me, but I'm logged in... [18:05:49] i was anon [18:05:54] I see that. [18:05:58] let me try logged in [18:06:00] Odd. [18:06:02] (03CR) 10Cscott: "Please do not +2 this without more discussion." [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [18:06:06] Isarra: OMG YOU CAN SEEE MY IP ADDRESSS!!! [18:06:07] :P [18:06:14] WHAT. [18:06:49] Isarra: hmm, so it does affect me if I'm logged in [18:07:11] 'Revoke the user's autoconfirmed status' is something it does. o_O [18:07:26] Isarra: heh, so can't do that for anon edits [18:07:31] and hence skip everything? :P [18:07:47] wat, really? [18:07:52] That seems like a weird reaction. Shouldn't it just only do that part for the ones it can, and do the rest for others? [18:07:56] no [18:07:59] YuviPanda: you forgot a space [18:08:01] so it didn't match [18:08:05] wooh [18:08:09] MatmaRex: I just copy pasted it [18:08:14] I literally copied what he wrote and it did work. [18:08:29] YuviPanda: no you didn't. [18:08:35] hmm? [18:08:38] the filter has "the abuse filter will block this" [18:08:41] you had "The abusefilter will block this" [18:08:54] https://test.wikipedia.org/w/index.php?title=Test_abuse_Filter&diff=193234&oldid=193233 [18:09:17] MatmaRex: look at the second edit [18:09:28] MatmaRex: I messed up caps and space the first time [18:09:47] caps shouldn't matter [18:10:13] ok, let's see [18:10:43] https://test.wikipedia.org/wiki/Special:AbuseFilter/examine/242110 [18:11:28] are variable names case-sensitive? [18:11:48] hmm [18:12:00] the filter matches that change when i use the box at the top [18:12:13] yeah, but it went through didn't i? [18:12:14] *it [18:12:19] yeah [18:12:27] someone should totally file a bug. [18:12:45] * YuviPanda looks at Isarra [18:12:46] (03PS1) 10Matthias Mullie: Display "This comment was by " instead of content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109696 [18:12:49] and probably a private one, too. :P [18:13:02] * YuviPanda looks at MatmaRex [18:13:13] (03CR) 10Gergő Tisza: MEDIAWIKI_PASSWORD_VARIABLE environment variable points to the variable that contains the password (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109661 (owner: 10Zfilipin) [18:14:27] (03PS2) 10Matthias Mullie: Display "This comment was by " instead of content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109696 [18:15:39] (03PS7) 10Aarcos: MEDIAWIKI_PASSWORD_VARIABLE environment variable points to the variable that contains the password [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109661 (owner: 10Zfilipin) [18:17:41] (03CR) 10Cscott: "Tyler, this is the second time I've seen you prematurely +2 a parser-related patch. (https://gerrit.wikimedia.org/r/77961 is the other, w" [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [18:17:43] MatmaRex: think you can file that? [18:18:01] :( [18:18:19] nooooo [18:19:39] (03CR) 10Werdna: Anonymous editor warning (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109445 (owner: 10Werdna) [18:19:54] Wait, so why was it failing to trigger? [18:20:02] (03CR) 10PleaseStand: "> Quoting comment 9 on bug 58153 from Alex Legler: That won't handle the syntax for persistent connections correctly which is 'p:: (03CR) 10Reedy: "Was this git mv?" [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/109630 (owner: 10KartikMistry) [18:20:42] (03CR) 10Ori.livneh: Adding wikimetrics role and module (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/108922 (owner: 10Ottomata) [18:22:07] MatmaRex: file it! file it! [18:22:11] Isarra: MatmaRex thinks it is a bug [18:22:21] But WHY? [18:22:26] WHAT... oh, nevermind. [18:22:33] * Isarra wanders off, clutching her head. [18:22:49] i'm kinda busy [18:22:51] aso lazy [18:22:53] also you found it [18:23:03] QED [18:23:30] MatmaRex: we could make legoktm do it [18:24:25] MatmaRex: or point csteipp to it? I suppose it could be considered a security issue [18:25:52] (03CR) 10Bartosz Dziewoński: [C: 031] "I tested on a real IE8 on a real Windows XP with this patch and I could not reproduce the issue. I'm going to merge this unless you try an" [core] - 10https://gerrit.wikimedia.org/r/109660 (owner: 10Gerrit Patch Uploader) [18:30:38] (03PS3) 10Phuedx: Log impressions of the onboarding CTA. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/109672 [18:34:48] (03CR) 10Parent5446: "If you have an idea for adding the tag without changing existing parser functionality and without adding another implementation, th" [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [18:35:45] (03CR) 10PleaseStand: [C: 04-1] "This was tried before and found to cause the undesirable behavior described in (03CR) 10PleaseStand: "And yes, I tested this change, and it still causes the undesirable whitespace to be shown." [core] - 10https://gerrit.wikimedia.org/r/108205 (owner: 10Arav93) [18:37:09] (03CR) 10Cscott: Merge Poem extension into core (0310 comments) [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [18:37:33] (03CR) 10Cscott: "Tyler, please see the discussion on bugzilla." [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [18:47:51] (03PS5) 10Manybubbles: Always search plain text and stemmed text [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108951 [18:48:25] (03CR) 10Manybubbles: "I officially deem this change worth it even though it could cause trouble. It will fix more then it breaks." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108951 (owner: 10Manybubbles) [18:50:16] (03PS1) 10Ori.livneh: Update WikimediaShopLink to master [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/109699 [18:51:18] (03CR) 10Chad: [C: 032] Always search plain text and stemmed text [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108951 (owner: 10Manybubbles) [18:51:28] (03Merged) 10jenkins-bot: Always search plain text and stemmed text [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108951 (owner: 10Manybubbles) [18:54:24] (03CR) 10Ori.livneh: [C: 032] Update WikimediaShopLink to master [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/109699 (owner: 10Ori.livneh) [18:54:29] (03CR) 10Werdna: [C: 032] Display "This comment was by " instead of content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109696 (owner: 10Matthias Mullie) [18:55:04] (03Merged) 10jenkins-bot: Display "This comment was by " instead of content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109696 (owner: 10Matthias Mullie) [18:55:48] (03PS1) 10Ori.livneh: Update WikimediaShopLink to master [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109700 [18:56:42] (03PS3) 10Werdna: Create test for bug 59637 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108879 [18:57:39] (03Merged) 10jenkins-bot: Update WikimediaShopLink to master [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/109699 (owner: 10Ori.livneh) [18:57:55] (03CR) 10Ori.livneh: [C: 032] Update WikimediaShopLink to master [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109700 (owner: 10Ori.livneh) [19:00:22] ori: someone posted about that on VPT already, btw, dunno if you've seen it [19:00:34] (03CR) 10Werdna: Anonymous editor warning (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109445 (owner: 10Werdna) [19:01:07] MatmaRex: I linked it from the bug, so I think he saw [19:01:45] (03Merged) 10jenkins-bot: Update WikimediaShopLink to master [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109700 (owner: 10Ori.livneh) [19:02:38] (03PS1) 10Ori.livneh: Update metric names for Zuul / Gerrit graphite graphs [integration/docroot] - 10https://gerrit.wikimedia.org/r/109702 [19:03:38] (03CR) 10Matthias Mullie: Anonymous editor warning (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109445 (owner: 10Werdna) [19:04:58] !skinning [19:04:58] From scratch: https://www.mediawiki.org/wiki/Manual:Skinning/Tutorial / Based on another skin: http://blog.redwerks.org/2012/02/28/mediawiki-subskin-tutorial/ / See also !skins for general help and list of available skins [19:05:25] !log ori synchronized php-1.23wmf11/extensions/WikimediaShopLink 'I21e34fe0f: Update WikimediaShopLink to master for PHP link insert' [19:07:41] !log ori synchronized php-1.23wmf10/extensions/WikimediaShopLink 'I21e34fe0f: Update WikimediaShopLink to master for PHP link insert' [19:07:49] i think the suggestion to move it to the footer is sensible [19:08:13] !log reedy synchronized wmf-config/ [19:08:27] we should move it to a big blinking popup, ideally [19:09:11] legoktm: if you like Jetbrains stuff http://www.jetbrains.com/labs/glass/ :) [19:09:12] Reedy: ^ [19:09:22] I saw that [19:09:43] heh [19:09:44] I don't have glass though ;) [19:09:49] :) [19:09:50] right [19:09:54] still cool [19:10:06] Is it written in java? [19:10:13] Reedy: unfortunately yes [19:10:16] :D [19:10:19] Reedy: although the server side part can be anything [19:12:01] !log reedy synchronized docroot/bits/favicon/commons.ico [19:12:53] (03CR) 10Gergő Tisza: [C: 04-1] MEDIAWIKI_PASSWORD_VARIABLE environment variable points to the variable that contains the password (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109661 (owner: 10Zfilipin) [19:14:28] (03PS2) 10Chad: WIP: Rework the document building process to be more extensible [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108952 (owner: 10Manybubbles) [19:14:30] (03CR) 10jenkins-bot: [V: 04-1] WIP: Rework the document building process to be more extensible [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108952 (owner: 10Manybubbles) [19:15:33] MatmaRex: is there any reason jquery.suggestion couldn't be loaded using mw.loader.using() once the search input is focussed? [19:15:40] (03CR) 10Chad: "I'm still not a fan of RedirectsAndIncomingLinks, but I haven't come up with anything clever yet." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108952 (owner: 10Manybubbles) [19:17:16] ori: hmmm. i don't think there's any technical one, but i could see that being slightly annoying [19:17:34] ori: actually, it'd have to be changed to check the input's contents when it's loaded, i think [19:17:40] right [19:17:59] (also, there are two modules doing the search suggestions now, working together) [19:18:02] why would it be annoying? it'd be cached after the first request [19:18:08] (the other one is mw.searchSuggest or something) [19:19:02] ori: personally i can feel when modules are lazy-loaded in some cases, e.g. mediawiki.notification when clicking the Watch star [19:19:14] (i even filed a bug about that one) [19:19:50] maybe they should load on $(window).ready [19:20:00] er, $(window).load [19:21:14] (03PS8) 10SG: Implement better scrolling via conditionalScroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 [19:22:19] (03CR) 10Kaldari: [C: 032] Send Thanks log entries to UDP [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/99619 (owner: 10Legoktm) [19:22:27] (03Merged) 10jenkins-bot: Send Thanks log entries to UDP [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/99619 (owner: 10Legoktm) [19:22:35] MatmaRex: the thing is that you expect the watchstar to be more or less instant, whereas there's a deliberate programmatic debounce w/ search suggestions, and you have to wait for a round-trip to the server either way [19:24:10] yeah [19:24:24] MatmaRex: https://test.wikipedia.org/w/index.php?title=Test_page_for_app_testing/AbuseFilter&curid=75440&diff=193252&oldid=193251 went through as well :| [19:24:28] ori: on a related note, i have a few open patches for the suggestions thingy� :( [19:25:00] https://gerrit.wikimedia.org/r/#/q/is:open+message:suggestions,n,z [19:26:06] MatmaRex: ok, adding to my queue [19:26:38] MatmaRex: can you confirm I'm not doing something stupid with expecting that edit to be blocked? [19:27:12] (03PS1) 10Umherirrender: Rollback: Make update of recentchanges table later [core] - 10https://gerrit.wikimedia.org/r/109706 [19:27:50] YuviPanda: yeah, it seems it should be blocked :/ [19:28:03] MatmaRex: ok [19:28:07] goddamnit. [19:28:21] YuviPanda: let's try disabling the one checkbox and trying again? [19:28:29] (03PS1) 10Bsitu: fetchSubtreeNodeList() on a non-object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109708 [19:28:30] MatmaRex: ok [19:28:38] let me do that [19:28:52] MatmaRex: done [19:28:58] MatmaRex: err [19:29:03] MatmaRex: apparently I don't have permissions [19:29:08] ugh, me too [19:29:12] MatmaRex: oh, probably because it took away my autoconfirmed when I tripped it? [19:29:13] (03PS2) 10Bsitu: fetchSubtreeNodeList() on a non-object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109708 [19:29:16] I think I'm admin or somesuch there [19:30:58] you probably need to be a crat [19:31:02] (03CR) 10Werdna: [C: 031] "I like this approach better." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108635 (owner: 10Matthias Mullie) [19:31:05] hey Reedy [19:31:10] Reedy: can I be crat on testwiki? [19:31:18] NO [19:31:20] kthx [19:31:53] YuviPanda: What username? [19:32:01] does it matter? [19:32:06] make everyone a bureaucrat [19:32:16] (03PS2) 10Bartosz Dziewoński: Make preference "Email me when a page or file on my watchlist is changed" true by default [core] - 10https://gerrit.wikimedia.org/r/100959 (owner: 10Nemo bis) [19:32:47] Reedy: Yuvipanda [19:33:12] (03CR) 10Bartosz Dziewoński: "Rebased. I'll do this in a week barring opposition." [core] - 10https://gerrit.wikimedia.org/r/100959 (owner: 10Nemo bis) [19:33:17] Done [19:33:19] (03CR) 10Bartosz Dziewoński: [C: 031] Make preference "Email me when a page or file on my watchlist is changed" true by default [core] - 10https://gerrit.wikimedia.org/r/100959 (owner: 10Nemo bis) [19:33:21] Reedy: thanks [19:34:40] (03CR) 10SG: "I have drastically scaled back the amount of refactoring involved in ui.js. The reason for this is that Matthias' recent patch sets have c" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 (owner: 10SG) [19:35:34] (03PS9) 10SG: Implement better scrolling via conditionalScroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 [19:36:50] MatmaRex: wtf, can't do it even as a crat?! [19:37:06] You cannot edit this filter, because it contains one or more restricted actions. Please ask a user with permission to add restricted actions to make the change for you. [19:37:09] MatmaRex: ^ [19:37:14] (03CR) 10Mattflaschen: "See inline." (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108472 (owner: 10Brian Wolff) [19:38:18] bawolff, let me know if you want me to clarify the Promise idea for https://gerrit.wikimedia.org/r/#/c/108472/ [19:38:37] (03PS1) 10Aaron Schulz: Put expensive info action count behind $wgMiserMode [core] - 10https://gerrit.wikimedia.org/r/109710 [19:38:40] The mw.api code is also a good example of how they can be used. [19:38:42] YuviPanda: lol [19:38:43] ori: geeze, I didn't notice there was another one of those queries [19:38:44] (03PS1) 10Bartosz Dziewoński: Release notes for I9359682c [core] - 10https://gerrit.wikimedia.org/r/109711 [19:38:46] superm401: Will do, I basically have to look up docs (I'm a bit of a js newb) [19:38:52] (03CR) 10Bartosz Dziewoński: "Release notes: https://gerrit.wikimedia.org/r/109711" [core] - 10https://gerrit.wikimedia.org/r/95742 (owner: 10Bartosz Dziewoński) [19:39:17] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Pending dependency." [core] - 10https://gerrit.wikimedia.org/r/109711 (owner: 10Bartosz Dziewoński) [19:39:25] (03PS1) 10Aaron Schulz: Put expensive info action count behind $wgMiserMode [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109712 [19:39:50] YuviPanda: probably some user groups config needs fixing [19:39:51] Reedy: can you try doing it? https://test.wikipedia.org/wiki/Special:AbuseFilter/1 tick the 'revoke user's autoconfirmed status' checkbox off? [19:39:54] (03PS1) 10Umherirrender: Correct sequence name for fresh Postgres installation [core] - 10https://gerrit.wikimedia.org/r/109713 [19:39:55] paging Reedy� [19:40:10] Noting I have global staff and sysop [19:40:19] bawolff, no problem. Another example is GettingStarted, which uses them in a pretty simple way: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGettingStarted.git/b9daddf82107e807c65435a32d4699b4c233eceb/resources%2Fext.gettingstarted.api.js [19:40:26] WFM [19:40:41] (03CR) 10Umherirrender: "FYI: I have no Postgres to test" [core] - 10https://gerrit.wikimedia.org/r/109713 (owner: 10Umherirrender) [19:40:47] https://test.wikipedia.org/wiki/Special:AbuseFilter/history/1 [19:40:50] Basically, you call resolve when the asynchronous operation complete, then call .done() to listen for successful completion. Then there are failure modes, which are also covered in the docs. [19:40:53] ok, now trying to trigger it again [19:41:24] MatmaRex: that triggered it! [19:41:29] lols [19:41:32] lololo [19:41:41] Reedy: can you put that check back on? [19:42:43] (03PS10) 10SG: Implement better scrolling via conditionalScroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 [19:48:09] (03PS1) 10Bsitu: Remove no longer existing classes from autloading global [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109717 [19:51:12] (03CR) 10Reedy: [C: 032] Put expensive info action count behind $wgMiserMode (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109710 (owner: 10Aaron Schulz) [19:52:13] gwicke: you about? Parsoid doesn't seem to work for me anymore. There's nothing in extensions/Parsoid/js/api [19:53:04] (03PS1) 10Manybubbles: Fix some error message handling [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109718 [19:54:18] (03Merged) 10jenkins-bot: Put expensive info action count behind $wgMiserMode [core] - 10https://gerrit.wikimedia.org/r/109710 (owner: 10Aaron Schulz) [19:57:19] (03PS2) 10Manybubbles: Fix some error message handling [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109718 [19:58:58] (03PS3) 10Manybubbles: Fix some error message handling [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109718 [20:03:03] (03PS1) 10Umherirrender: Ignore 'unknown' in XFF [core] - 10https://gerrit.wikimedia.org/r/109721 [20:03:09] (03CR) 10Bartosz Dziewoński: [C: 032] Use box-sizing:border-box for textarea [core] - 10https://gerrit.wikimedia.org/r/105207 (owner: 10Gerrit Patch Uploader) [20:03:17] (03CR) 10Hashar: [C: 032] "Landing this on slaves… Still need to create JJB templates and jobs though." [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107163 (owner: 10Hashar) [20:03:22] (03PS3) 10Hashar: json-lint.php: recursively lint json files with PHP [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107163 [20:03:28] (03CR) 10Hashar: [C: 032] json-lint.php: recursively lint json files with PHP [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107163 (owner: 10Hashar) [20:03:40] (03Abandoned) 10Umherirrender: Restore templatelinks count on info=action [core] - 10https://gerrit.wikimedia.org/r/109506 (owner: 10Umherirrender) [20:04:27] (03Merged) 10jenkins-bot: json-lint.php: recursively lint json files with PHP [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107163 (owner: 10Hashar) [20:07:08] TrevorParscal: are you around? mind looking at https://gerrit.wikimedia.org/r/#/c/95822/ [20:07:26] (03Merged) 10jenkins-bot: Use box-sizing:border-box for textarea [core] - 10https://gerrit.wikimedia.org/r/105207 (owner: 10Gerrit Patch Uploader) [20:07:58] 1 Fatal error: Class 'Flow\Model\FlowException' not found in /usr/local/apache/common-local/php-1.23wmf11/extensions/Flow/includes/Model/Workflow.php on line 96 [20:09:07] (03PS2) 10Bartosz Dziewoński: Remove IE80Fixes.css [core] - 10https://gerrit.wikimedia.org/r/109660 (owner: 10Gerrit Patch Uploader) [20:09:14] (03PS3) 10Bartosz Dziewoński: Remove IE80Fixes.css [core] - 10https://gerrit.wikimedia.org/r/109660 (owner: 10Gerrit Patch Uploader) [20:10:22] (03PS11) 10SG: Implement better scrolling via conditionalScroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 [20:14:13] (03CR) 10Chad: [C: 032] Fix some error message handling [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109718 (owner: 10Manybubbles) [20:14:18] (03Merged) 10jenkins-bot: Fix some error message handling [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109718 (owner: 10Manybubbles) [20:15:20] werdna, I guess you found the Readme [20:15:25] & new repository [20:22:01] (03Abandoned) 10Krinkle: Fix crash in mw.page.watch.updateWatchLink() when title not set [core] - 10https://gerrit.wikimedia.org/r/92596 (owner: 10Catrope) [20:23:16] how can i get a mapping from langcode -> language name? [20:23:27] (03CR) 10Jack Phoenix: [C: 031] "So I tested this on my Acer eMachines eM250, running Windows XP Home and IE8 with [[:en:Barack Obama]] as the article -- no jumping or any" [core] - 10https://gerrit.wikimedia.org/r/109660 (owner: 10Gerrit Patch Uploader) [20:23:27] https://www.mediawiki.org/wiki/:en:Barack_Obama [20:24:04] jorm: in JS? PHP? on a MediaWiki page? [20:24:16] well, i'm trying to solve for a bug in winter. [20:24:19] (03CR) 10Lethosor: [C: 031] "This works for me on a clean install with Postgres" [core] - 10https://gerrit.wikimedia.org/r/109713 (owner: 10Umherirrender) [20:24:34] actually i have no idea how to do it in JS [20:24:41] in MW, {{#language:en}} [20:24:42] https://www.mediawiki.org/wiki/%23language:Template:en [20:24:45] the bug is that the langlinks given by the API give me the following: langcode, url, and articlename in foreign language [20:24:54] but language links on the side are the name of the language. [20:25:08] so i'm generating them right now, but, like, they all say "cat" [20:25:17] when they should say "english, german, french" [20:25:30] jorm: I just did this for the app. Let me fish out the API call.. [20:25:51] ideally, i can just get a big array and keep it in a library and do look ups. [20:25:57] jorm: there's an API call that generates this mapping once - I then store it and do look ups [20:26:07] good good [20:26:20] i'll do it once and then save it to a .js file! [20:26:26] jorm: https://en.wikipedia.org/wiki/Special:ApiSandbox#action=query&meta=siteinfo&format=json&siprop=languages [20:27:03] hmmm, it actually sounds reasonable for the prop=langlinks call to return this [20:27:48] (03CR) 10Bartosz Dziewoński: [C: 032] Remove IE80Fixes.css [core] - 10https://gerrit.wikimedia.org/r/109660 (owner: 10Gerrit Patch Uploader) [20:28:03] i think it should. [20:28:03] MatmaRex: yeah, especially if we want 'name of language X in language Y' [20:28:17] ty, yuvi. [20:28:21] jorm: yw! [20:28:29] ^d: I can't get "CodeReview=-1 -CodeReview=-2" to work in any gerrit search [20:28:29] i'm gonna save that off, and then grind it in perl to make an array and just hold it. [20:28:37] is there some magic trick to make it work? [20:28:56] jorm: I've a script that gets me the same data but ordered by 'number of articles per wikipedia' or some such. let me know if you want that. [20:29:42] jorm: generates https://dpaste.de/TNyE [20:29:53] <^d> AaronSchulz: Not sure :\ [20:30:08] (03CR) 10Aaron Schulz: Put expensive info action count behind $wgMiserMode (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109710 (owner: 10Aaron Schulz) [20:30:14] (03CR) 10Aaron Schulz: [C: 032] Put expensive info action count behind $wgMiserMode [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109712 (owner: 10Aaron Schulz) [20:30:51] (03Merged) 10jenkins-bot: Remove IE80Fixes.css [core] - 10https://gerrit.wikimedia.org/r/109660 (owner: 10Gerrit Patch Uploader) [20:32:15] AaronSchulz: Code-Review [20:32:18] with a hyphen [20:32:36] (03PS1) 10Reedy: Add LoadExtensionSchemaUpdates subscriber [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/109730 [20:32:36] ask me why i know this. [20:33:11] (03CR) 10Reedy: [C: 032] Add LoadExtensionSchemaUpdates subscriber [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/109730 (owner: 10Reedy) [20:33:29] that gives an "unsupported" error [20:33:38] (03Merged) 10jenkins-bot: Put expensive info action count behind $wgMiserMode [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109712 (owner: 10Aaron Schulz) [20:33:55] AaronSchulz: label:�, then [20:34:03] (03CR) 10Reedy: [V: 032] Add LoadExtensionSchemaUpdates subscriber [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/109730 (owner: 10Reedy) [20:34:06] https://gerrit.wikimedia.org/r/#/q/label:Code-Review%253D-2,n,z [20:35:28] !log aaron synchronized php-1.23wmf11/includes/actions/InfoAction.php '5f94782c2bf09ce6c00b6ad37a68d08fef802fe5' [20:39:29] MatmaRex: there are lots of outdated docs in this... [20:39:41] so 'status:open -label:Code-Review=-1 -label:Code-Review=-2 Verified>=1 reviewer:"aschulz@wikimedia.org"' seems to be reasonable [20:40:25] to bad everyone has to each figure this out after messing around with misleading docs [20:51:52] ^d: around? can you go through https://www.mediawiki.org/wiki/Gerrit/Project_ownership ? there's a bunch of outstanding trivial requests [20:53:25] <^d> If someone could archive the ones that are done it'd make it easier to read that page. [20:53:28] woo. fixed that. what a pain. [20:53:37] <^d> Too many green checkmarks :p [20:53:45] if anyone wants in the future, i have a little library that does language look ups by code. [20:55:22] jorm: btw, I think we use http://cldr.unicode.org/ on the server side for it [20:55:31] it also has things like 'name of language X in language Y', I think [20:55:34] (not too sure) [20:55:40] yup, it does [20:56:13] jorm: https://github.com/twitter/twitter-cldr-js is a heavier weight version that is pure JS [20:56:30] nevermind the link, they don't have language names [20:56:53] this will serve for the demo. [20:56:59] gwicke: yeah [20:57:09] gwicke: you saw my commit? [20:58:28] ^d: can do i guess [20:59:30] ^d: hmm, does terry's "{{ok}}" under "Sam Smith (phuedx)" mean {{done}} or {{support}}? [20:59:31] https://www.mediawiki.org/wiki/Template:ok [21:00:01] <^d> I assume the latter. [21:00:06] <^d> I dunno who would've done it but me :) [21:01:08] <^d> I'm going with support. [21:01:12] <^d> It's not done, for sure [21:01:20] (03CR) 10Aaron Schulz: Add assertions in FileBackendTest (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109472 (owner: 10Addshore) [21:01:21] archived! [21:02:47] ^d: 7 open remaining [21:03:01] five last seem obvious to me [21:07:26] <^d> Archived another that is weird & old. [21:07:30] <^d> Did 4 of the remaining 6. [21:07:36] <^d> Left 2, since they've only got 1 comment each [21:07:43] !log csteipp synchronized php-1.23wmf11/extensions/PdfHandler 'bug 60339' [21:08:11] !log csteipp synchronized php-1.23wmf10/extensions/PdfHandler 'bug 60339' [21:09:35] <^d> MatmaRex: Look better? :) [21:10:59] ^d: sexy. thanks [21:11:20] (03PS1) 10Manybubbles: Default boost-templates properly [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109737 [21:11:51] (03CR) 10Bsitu: "It would be nice to detect lost session as well. Eg, a user is logged in when he/she starts a thread, after some long typing, the session" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109445 (owner: 10Werdna) [21:12:45] (03CR) 10Werdna: "I think that case should be covered separately – in the same code as the edit conflict handling perhaps." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109445 (owner: 10Werdna) [21:13:54] (03CR) 10Chad: [C: 032] "How the heck did we miss this?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109737 (owner: 10Manybubbles) [21:13:59] (03Merged) 10jenkins-bot: Default boost-templates properly [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109737 (owner: 10Manybubbles) [21:16:49] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 0e7d5eb..3acd206 [extensions] - 10https://gerrit.wikimedia.org/r/109739 [21:16:51] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 0e7d5eb..3acd206 [extensions] - 10https://gerrit.wikimedia.org/r/109739 (owner: 10Jenkins-mwext-sync) [21:22:00] (03PS1) 10Chad: Don't log every redirect, it's too spammy [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109742 [21:26:36] (03PS4) 10AndyRussG: Accurately report institution activity [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109631 [21:26:44] (03CR) 10Manybubbles: [C: 032] "Spam not tasty?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109742 (owner: 10Chad) [21:27:02] (03CR) 10jenkins-bot: [V: 04-1] Accurately report institution activity [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109631 (owner: 10AndyRussG) [21:27:04] (03Merged) 10jenkins-bot: Don't log every redirect, it's too spammy [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109742 (owner: 10Chad) [21:28:08] <^d> demon@fluorine:/a/mw-log$ cat CirrusSearch.log | wc -l [21:28:08] <^d> 6100 [21:28:08] <^d> demon@fluorine:/a/mw-log$ cat CirrusSearch.log | grep 'which is a redirect' | wc -l [21:28:10] <^d> 5050 [21:28:12] <^d> manybubbles: ^ [21:28:18] (03PS1) 10Mwalker: Adding VEF currency to GC [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/109753 [21:28:30] (03CR) 10Mwalker: [C: 032 V: 032] Adding VEF currency to GC [core] (fundraising/REL1_22) - 10https://gerrit.wikimedia.org/r/109753 (owner: 10Mwalker) [21:28:36] ^d: spam not tasty [21:28:37] <^d> manybubbles: It was 82% of that log :p [21:28:42] nice [21:28:48] (03PS1) 10Ori.livneh: MediaWiki Apache site: listen to *:8080 as well as *:80 [vagrant] - 10https://gerrit.wikimedia.org/r/109754 [21:29:23] (03CR) 10Ori.livneh: [C: 032 V: 032] MediaWiki Apache site: listen to *:8080 as well as *:80 [vagrant] - 10https://gerrit.wikimedia.org/r/109754 (owner: 10Ori.livneh) [21:30:06] <^d> full text search for '<}¶bbbbb¶¶¶¶bbbbbBBBBBB¶' took 52288 millis and 52285 Elasticsearch millis [21:30:16] <^d> People search crazy things. [21:30:26] (03PS9) 10Ottomata: Adding wikimetrics role and module [vagrant] - 10https://gerrit.wikimedia.org/r/108922 [21:30:48] No kidding, how does one even accidentally type ¶ into the box [21:30:53] (03PS2) 10Chad: Remove commented defines [core] - 10https://gerrit.wikimedia.org/r/107906 [21:31:16] <^d> bawolff: People who love latex too much? [21:32:08] ^d: that is really a stupid amount of time [21:32:14] <^d> srsly. [21:32:32] <^d> We did the whole MW side of things in...a few ms. [21:32:40] <^d> But we waited ~52 seconds for elasticsearch? [21:32:43] <^d> Stupid. [21:33:06] the difference ms there are the round trip network time and lvs and stuff [21:33:09] we hope it is always small [21:33:20] (03PS5) 10AndyRussG: Accurately report institution activity [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109631 [21:33:50] it makes a pretty stupid query when Elasticsearch expands it. probably a bug [21:33:59] I mean, anything that takes more than a second or so is a bug [21:34:13] <^d> slow log is helpful here. [21:34:31] yeah, I haven't been looking at it lately because I've been busy with other crap [21:35:53] (03CR) 10Matthias Mullie: "I was thinking about fetching mw.config.get( 'wgUserName' ) in JS and send that along with the submission API POST." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109445 (owner: 10Werdna) [21:36:04] (03PS4) 10Physikerwelt: Update to MathJax 2.3 [extensions/Math] - 10https://gerrit.wikimedia.org/r/109490 [21:36:52] https://bugzilla.wikimedia.org/show_bug.cgi?id=60496 [21:39:53] (03CR) 10Physikerwelt: [C: 032] "@Frédéric: You can view the diff between patch sets by selecting the "Reference Version" on the Gerrit Change page." [extensions/Math] - 10https://gerrit.wikimedia.org/r/109490 (owner: 10Physikerwelt) [21:40:17] (03CR) 10Matthias Mullie: "Perhaps also check with product before pushing it through, though. The intent probably was to only display a message when users are no lon" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109445 (owner: 10Werdna) [21:41:07] (03CR) 10TMg: [C: 04-1] "If you add at least 'Sandbox#' and 'meta:' (or 'en:' or something similar) to the valid test cases I don't have a problem with making '#' " (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender) [21:41:35] How do you undo Oversighted revisions? [21:42:57] manually, probably [21:43:33] Seems like it [21:43:38] Special:Oversight shows diff and details [21:43:52] Oh, werdna, duh [21:43:57] We can use Krenairs script! [21:43:57] :D [21:44:29] * Reedy tests it [21:45:08] Bad Krenair [21:45:56] <^d> Reedy: When will wmf11 be on all wikis? [21:46:01] <^d> By thurs? [21:46:08] Yeah [21:46:22] <^d> k, just wondering when I can finally merge non-urgent a cirrus thing. [21:46:52] <^d> a non-urgent [21:47:01] (03CR) 10Physikerwelt: "There is Bug 60471 now... I was not sure how to implement the hook ad hoc. Probably I find an adequate example in the next days." [core] - 10https://gerrit.wikimedia.org/r/109493 (owner: 10Physikerwelt) [21:48:42] Reedy, hi? [21:48:46] (03CR) 10Aarcos: [C: 04-1] MEDIAWIKI_PASSWORD_VARIABLE environment variable points to the variable that contains the password (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109661 (owner: 10Zfilipin) [21:50:21] <^d> manybubbles: $ cat CirrusSearch-slow.log | grep -P "[<>=]" | wc -l [21:50:23] <^d> 21 [21:50:31] how do i get a page's text as wikitext from the api? [21:50:32] <^d> So yeah, people are hitting it. [21:50:39] (03PS1) 10Matthias Mullie: Fix comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109761 [21:50:42] mostly accidentally I think [21:50:44] easy fix [21:50:50] it isn't crushing us so let them have fun [21:51:12] Reedy, I saw "Reedy tests it", then "Disconnected (Connection reset by peer)", then the joining/title messages and "Reedy: Bad Krenair" [21:51:33] <^d> jorm: api.php?action=query&prop=revisions&titles=Foo&rvprop=content [21:52:08] <^d> jorm: for other revision-related queries, open up action=help and ctrl+f for prop=revisions and rvprop [21:52:14] (03CR) 10Reedy: "See bug 60499" [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 (owner: 10Alex Monk) [21:52:20] Krenair: https://bugzilla.wikimedia.org/show_bug.cgi?id=60499 [21:52:33] Doesn't respect table prefixes [21:52:49] <^d> manybubbles: Indeed, but eventually we'll have more people searching, so we need to be careful. [21:52:53] <^d> Especially if it's a bug :) [21:53:03] yeah. it finds _everything_ [21:53:19] ugh what [21:53:22] danke! [21:53:43] <^d> manybubbles: But yeah, it's mostly accidental. A little bit of html, mostly gibberish. Doesn't look like people are trying to *use* it as any sort of syntax. [21:53:46] <^d> jorm: yw. [21:53:55] Krenair: array( 'hidden.hidden_rev_id > ' . $dbw->addQuotes( $lastRevId ) ), [21:53:58] Hidden is hard coded [21:54:07] There is no chance of a table prefix being appended automagically by MW [21:55:52] Of course, if the fields are unique enough (already prefixed in the trable) you don't need table1.t1_col [21:56:07] this "query: pages: pageid" shit sucks. [21:56:25] jorm: you *can* also use action=raw [21:56:50] https://en.wikipedia.org/w/index.php?title=Barack_Obama&action=raw [21:57:01] <^d> manybubbles: The other common theme I see in the slow log is for queries containing /[-~]/ [21:57:02] but that might end up being harder to use than the API from JS [21:57:17] <^d> Also, [*] [21:57:25] well ~ is known slow and shitty. it might dry up when we stop highlighting it [21:57:38] * isn't super quick but I haven't seen it be _too_ slow [21:57:48] can you give me an example of -? [21:57:53] $wgMiserModeSpecialActiveUsers [21:58:06] <^d> manybubbles: wikidatawiki: full text search for '-endo' took 43626 millis and 43624 Elasticsearch millis [21:58:17] Didn't we already go through the active users is too slow thing? [21:58:20] !log csteipp synchronized php-1.23wmf11/includes 'bug 60339' [21:58:36] <^d> bawolff: We did, and I was involved last time. I'm trying very hard not to get involved this time. [21:58:41] <^d> :) [21:59:00] Reedy, "this specific reason" - what specific reason? just to catch queries which break when table prefixes are used? [21:59:07] ^d: that is because that query devolves into one that doesn't find _anything_ and so finds everything [21:59:23] Krenair: Well, where the MW code doesn't cater for prefixed tables, when it needs to [21:59:25] <^d> Indeed. Can we optimize the "find everything because your query sucked" case? [21:59:28] it'll be faster when I fix the script score to only hit the top X documents [21:59:31] I've caught RoanKattouw out a few times with this before [21:59:34] yeah, probably [21:59:38] let me sleep on it tonight [21:59:57] Reedy, and you wanted it to have a read-only dryrun mode as well right? [22:00:06] Possibly [22:00:10] Not sure if that's actually needed [22:00:24] Didn't Chad agree though? [22:00:33] (03CR) 10Werdna: [C: 032] Fix comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109761 (owner: 10Matthias Mullie) [22:00:40] (03Merged) 10jenkins-bot: Fix comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109761 (owner: 10Matthias Mullie) [22:00:53] Reedy, agree that we needed a dryrun mode? [22:01:13] I don't remember discussing it with him... [22:02:30] !log csteipp synchronized php-1.23wmf10/includes 'bug 60339' [22:03:21] sorry my connection is resetting every minute [22:03:24] array( 'hidden', 'user' ) changes to array( 'hidden' => 'hidden', 'user' => 'user' ) then? [22:04:08] (03CR) 10TMg: "Maybe I should explain why I came to the conclusion that [[#]] and [[:]] shouldn't be valid wikitext. Simple reason: Users will think this" [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender) [22:04:08] https://www.mediawiki.org/wiki/# https://www.mediawiki.org/wiki/: [22:05:08] Krenair: I think that should work (as long as there's no other user table non prefixed in the database) [22:07:19] Krenair: Nope, doesn't work [22:07:51] (03PS1) 10Physikerwelt: Puppetize CirrusSearch initialization [vagrant] - 10https://gerrit.wikimedia.org/r/109763 [22:08:05] Reedy, how are we supposed to work with table prefixes then? [22:08:36] (03CR) 10Chad: [C: 031] Puppetize CirrusSearch initialization [vagrant] - 10https://gerrit.wikimedia.org/r/109763 (owner: 10Physikerwelt) [22:11:00] append $wgDBprefix to everything that MW doesn't take care of for us? [22:12:29] can't use action=raw via ajax. [22:13:34] (03PS1) 10Reedy: Use table prefixes in migrateToRevDel.php [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/109765 [22:13:36] Krenair: ^ [22:14:09] jorm: Why not? [22:14:17] (03PS2) 10Reedy: Use table prefixes in migrateToRevDel.php [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/109765 [22:14:20] cross domain issues. [22:14:40] oh, that would be correct then, I was thinking you were on the same origin [22:15:08] Krenair: Looks like it's missing a few newlines [22:15:08] Warning: There may be an issue with revision ID 1. It has rev_parent_id=0 which means that it may be treated as a revision which starts a new page.Done! 2 oversighted revision(s) are now converted to suppressed revisions. [22:15:14] (03CR) 10Physikerwelt: [C: 04-1] "Since it looks like code review for vagrant works orders of magnitude better compared to code review for the math extension I resubmitted " [vagrant] - 10https://gerrit.wikimedia.org/r/108845 (owner: 10Physikerwelt) [22:15:56] Reedy, I thought I fixed that... [22:16:33] (03PS1) 10Reedy: Add a couple of newlines [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/109766 [22:16:46] (03PS2) 10Physikerwelt: Rename global variables that violate the naming convention [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 [22:17:02] Reedy, is there anything we might need to change in SpecialOversight::getSelectFields ? [22:17:27] (03PS4) 10Physikerwelt: Introduce $wgMathValidModes to adjust the selectable math rendering modes in user preferences [extensions/Math] - 10https://gerrit.wikimedia.org/r/109488 [22:17:46] Krenair: No. It's not using hidden. [22:18:06] (03PS7) 10Physikerwelt: Add mathsearch role to vagrant [vagrant] - 10https://gerrit.wikimedia.org/r/108827 [22:19:00] Guess I'm going to have to set up a wiki DB with a table name prefix at some point and test your commit [22:19:41] (03PS1) 10Reedy: Use table prefixes in migrateToRevDel.php [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/109767 [22:19:49] ^ A slightly simpler way of doing it [22:20:09] As I pasted the output, it does work ;) [22:22:32] (03PS18) 10Physikerwelt: Remove call to deprecated ParserOptions::getMath [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 [22:23:42] does testwiki have debug logging enable? if so where does that go? [22:24:17] maybe [22:24:18] somewhere [22:24:21] :) [22:24:42] mw1017 [22:25:02] Krenair: 2 migrated revisions from oversight seem to be unrestorable... [22:25:16] what? [22:26:29] it looks like the logging goes to udp://$wmfUdp2logDest/testwiki, not sure yet where that ends up [22:26:44] ebernhardson: flourine [22:26:46] spelt correctly [22:26:50] /a/mw-log [22:26:57] Reedy: excellent, thanks [22:27:09] Reedy, what do you mean unrestorable? [22:29:30] Krenair: Just missing stupid non default permissions [22:29:34] * werdna fluoridates Reedy  [22:29:46] Script works fine from my testing of deleting using oversight [22:29:51] Fixed maintenance script [22:29:52] run [22:29:56] add permissions [22:29:57] restore [22:29:59] PROFIT [22:30:34] (03CR) 10Physikerwelt: "Thank you MarkAHershberger. No references to getMath... only the extension DataValues has a getMath method but it's unrelated to the getMa" [core] - 10https://gerrit.wikimedia.org/r/108490 (owner: 10Physikerwelt) [22:30:51] Your change looks good and still runs without table prefixes. Your console log shows that it works with table prefixes so I think it's okay to approve [22:31:14] (03CR) 10Reedy: "For reference, after fixing the table prefixing issues, this script worked fine for migrating the logs to revision delete" [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 (owner: 10Alex Monk) [22:31:53] (03CR) 10Alex Monk: [C: 032] Use table prefixes in migrateToRevDel.php [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/109767 (owner: 10Reedy) [22:32:35] (03Abandoned) 10Reedy: Use table prefixes in migrateToRevDel.php [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/109765 (owner: 10Reedy) [22:32:54] And I suspect Jenkins isn't running on that extension [22:33:02] Very likely [22:33:49] (03CR) 10Alex Monk: [V: 032] "No Jenkins here" [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/109767 (owner: 10Reedy) [22:34:52] (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 3acd206..263b8c0 [extensions] - 10https://gerrit.wikimedia.org/r/109772 [22:34:54] (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 3acd206..263b8c0 [extensions] - 10https://gerrit.wikimedia.org/r/109772 (owner: 10Jenkins-mwext-sync) [22:35:44] (03PS2) 10Reedy: Add a couple of newlines [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/109766 [22:37:40] (03CR) 10Parent5446: Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [22:37:49] omfg [22:38:13] (03CR) 10Alex Monk: [C: 032 V: 032] Add a couple of newlines [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/109766 (owner: 10Reedy) [22:39:14] (03CR) 10Krinkle: "Class MathRenderer is defined by extension (mediawiki-extensions-Math), ideally core should not have any references to extensions. Especia" [core] - 10https://gerrit.wikimedia.org/r/109493 (owner: 10Physikerwelt) [22:43:34] (03CR) 10Parent5446: [C: 031] Make preference "Email me when a page or file on my watchlist is changed" true by default [core] - 10https://gerrit.wikimedia.org/r/100959 (owner: 10Nemo bis) [22:48:35] (03PS5) 10Ebe123: Create Special:Purge [core] - 10https://gerrit.wikimedia.org/r/109523 [22:49:58] (03PS1) 10Alex Monk: Add dry-run mode to migrateToRevDel.php [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/109777 [22:51:32] (03PS1) 10Manybubbles: Drop data from Elasticsearch we don't need [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109778 [22:52:14] (03CR) 10Maryana: "Sorry to come back to this late in the game, but I'm hearing a lot of recommendations to switch to http://opensource.org/licenses/MIT for " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108974 (owner: 10Reedy) [22:52:50] gwicke: best way to extract links / templates / embedded images from a Parsoid output? Just look for them with XPath? [22:53:01] (03CR) 10Bartosz Dziewoński: "If authors of all the code you're using agree, yes." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108974 (owner: 10Reedy) [22:53:16] (03CR) 10Bartosz Dziewoński: "all the code you have in this extension*" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108974 (owner: 10Reedy) [22:53:44] werdna: heh, for link tables? [22:53:50] doesn't parsoid provide that information? :/ [22:53:57] MatmaRex: well, it does, but as markup in the DOM [22:53:58] afaik [22:54:03] ugh [22:54:06] (03CR) 10Brian Wolff: "Generally you would need permission from everyone who has contributed to the extension in order to do that." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108974 (owner: 10Reedy) [22:54:09] (03CR) 10Werdna: "WMF has Copyright on everything written by WMF employees and contractors." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108974 (owner: 10Reedy) [22:54:27] well, i did suggest not using parsoid for flow because it was not necessarily production-ready for this� [22:54:48] no edit conflict detection in gerrit [22:55:15] MatmaRex: Well, we *are* going to use it anyway because we think it's production ready enough. [22:55:27] I mean, in terms of link detection, it's still possible [22:55:28] (03CR) 10Alex Monk: "Have no volunteers contributed to Flow so far then?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108974 (owner: 10Reedy) [22:55:39] werdna: i hope this goes better than the last time people thought something using Parsoid was production-ready [22:55:58] werdna: link tables are used for more than links, btw [22:56:02] {{#ifexist uses them [22:56:09] some lua functions too [22:56:15] (scribunto lua) [22:56:31] i sure hope you'll get that supported, somehow :( [22:56:50] Don't have to invalidate #ifexist if the wikitext output never gets invalidated ;) [22:56:57] werdna, https://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec [22:57:14] gwicke: so there's no separate listing? You just have to pull it out of the DOM? [22:57:44] right now we don't extract that info server-side [22:58:01] MatmaRex: Don't be so negative! If you think there are specific problems with using Parsoid in this case, then let us know. Otherwise, it's not helpful to make "ominous" comments like that. [22:58:05] but we'll probably do so once we start dealing with link tables etc [22:58:12] (03CR) 10Bartosz Dziewoński: "They did, even some GCI students. Here's a list of committers to this repo:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108974 (owner: 10Reedy) [22:58:27] MatmaRex: To me it just sounds like sniping, which is not appreciated. [22:58:35] (03CR) 10Werdna: "http://p.defau.lt/?M9IEK9F1k4jfedttJRUOPA" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108974 (owner: 10Reedy) [22:58:36] werdna: i did file bugs [22:58:46] great! [22:58:46] and i did comment on bugs [22:58:57] doesn't look like that was taken into account by anyone os far [23:00:21] (03CR) 10Bartosz Dziewoński: "(Alternatively, you can just revert the commit made by them.)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108974 (owner: 10Reedy) [23:00:38] werdna, https://developer.mozilla.org/en-US/docs/Web/API/Document.querySelectorAll [23:00:50] Numerous of those are WMF staff [23:01:03] Reedy: I know. [23:01:14] gwicke: thanks. It'll be in JS though :p [23:01:15] erm [23:01:17] it won't be in JS [23:01:41] Brings up an interesting point about, would i18n changes need to have copyright status changed [23:01:43] libxml would probably be xpath [23:02:08] * bawolff would guess no(?) [23:02:46] (03CR) 10Alex Monk: "And what were the reasons given for wanting to change to MIT, Maryana?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108974 (owner: 10Reedy) [23:03:11] okay. i have another api question! [23:03:19] I would guess its to do with all the uncertainty around GPL with javascript [23:03:24] given this: [23:03:24] http://en.wikipedia.org/w/api.php?action=query&prop=revisions&titles=Cat&rvprop=content&format=jsonfm [23:03:32] how do i get a single section? [23:03:32] * Reedy goes out to buy some paint [23:03:34] The other extensions get along with GPL2 happily [23:03:38] like i was section editing. [23:03:41] werdna: hmm, how exactly do you resolve link colors at display time? [23:03:46] or how in general, at least :P [23:03:50] or where in the code do i look [23:03:57] jorm: &rvsection [23:06:00] (03PS1) 10Bsitu: Fix leftover user_text occurrences [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109781 [23:06:16] (03PS1) 10Bsitu: rev_mod_user_text is deprecated [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109782 [23:06:20] (03CR) 10Bartosz Dziewoński: "VisualEditor is on MIT. MIT's more free-as-in-beer but less free-as-in-Richard-Stallman, it makes code more hassle-free to reuse but possi" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108974 (owner: 10Reedy) [23:06:35] Krenair: I believe there's some flame wars on the internet about the subject. [23:06:43] bawolff: some? [23:06:51] you mean numerous [23:06:52] ok, many [23:06:53] just ask marktraceur [23:06:59] (03CR) 10EBernhardson: [C: 032] Fix leftover user_text occurrences [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109781 (owner: 10Bsitu) [23:07:05] (03Merged) 10jenkins-bot: Fix leftover user_text occurrences [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109781 (owner: 10Bsitu) [23:07:08] lol, free-as-in-RMS [23:07:16] (03CR) 10EBernhardson: [C: 032] rev_mod_user_text is deprecated [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109782 (owner: 10Bsitu) [23:07:24] (03Merged) 10jenkins-bot: rev_mod_user_text is deprecated [extensions/Flow] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109782 (owner: 10Bsitu) [23:08:09] From what I understand, the debate was something about how its very unclear what consists as "distributing" code vs using code with js, and what consists of object code when JS is involved [23:08:47] MatmaRex: includes/Redlinker.php [23:12:00] werdna: yeah, found it already and reading [23:12:07] thanks [23:13:56] (03PS1) 10EBernhardson: update branch to wmf/1.23wmf11 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109783 [23:15:20] (03CR) 10Isarra: [C: 031] "Whee!" [core] - 10https://gerrit.wikimedia.org/r/100959 (owner: 10Nemo bis) [23:15:38] (03CR) 10EBernhardson: [C: 032] update branch to wmf/1.23wmf11 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109783 (owner: 10EBernhardson) [23:15:44] (03Merged) 10jenkins-bot: update branch to wmf/1.23wmf11 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109783 (owner: 10EBernhardson) [23:17:11] (03CR) 10Krinkle: "Please, please. Do *not* redefine, reuse or delete modules still being or recently having been used. This has caused problems in the past " [core] - 10https://gerrit.wikimedia.org/r/103078 (owner: 10Daniel Friesen) [23:18:16] (03CR) 10Krinkle: "Example of breakage: http://i.imgur.com/SP90fMf.png" [core] - 10https://gerrit.wikimedia.org/r/103078 (owner: 10Daniel Friesen) [23:21:44] (03PS1) 10EBernhardson: Update wmf/1.23wmf10 to match wmf/1.23wmf11 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109784 [23:22:04] (03CR) 10EBernhardson: [C: 032] Update wmf/1.23wmf10 to match wmf/1.23wmf11 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109784 (owner: 10EBernhardson) [23:22:11] (03Merged) 10jenkins-bot: Update wmf/1.23wmf10 to match wmf/1.23wmf11 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109784 (owner: 10EBernhardson) [23:30:57] (03PS1) 10Aaron Schulz: Added a simple JobSpecification class for pushing jobs [core] - 10https://gerrit.wikimedia.org/r/109785 [23:32:25] <^d> Oooh [23:32:42] (03CR) 10Aaron Schulz: "Might want to add a check to prevent non-JSON serializable items in $params" [core] - 10https://gerrit.wikimedia.org/r/109785 (owner: 10Aaron Schulz) [23:33:34] (03PS1) 10SG: Introduce Function.bind polyfill, fix IE8 errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109788 [23:33:40] (03CR) 10jenkins-bot: [V: 04-1] Introduce Function.bind polyfill, fix IE8 errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109788 (owner: 10SG) [23:34:45] (03CR) 10Krinkle: "The change this follows-up (Ia193571) did handle this correctly by leaving a compatible module definition under the old name (to be remove" [core] - 10https://gerrit.wikimedia.org/r/103078 (owner: 10Daniel Friesen) [23:35:28] (03CR) 10Jdlrobson: "Woops When I did the rewriting of skins.monobook/vector to skins.monobook/vector.common I left skins.monobook/vector to prevent any cache " [core] - 10https://gerrit.wikimedia.org/r/103078 (owner: 10Daniel Friesen) [23:36:16] (03CR) 10Jdlrobson: "Krinkle any ideas on way we can better protect against cache breakage in future by tracking CSS regressions on cached pages...?" [core] - 10https://gerrit.wikimedia.org/r/103078 (owner: 10Daniel Friesen) [23:36:41] (03PS2) 10SG: Introduce Function.bind polyfill, fix IE8 errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109788 [23:36:47] (03CR) 10jenkins-bot: [V: 04-1] Introduce Function.bind polyfill, fix IE8 errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109788 (owner: 10SG) [23:38:04] Krinkle: are there any requirements regarding polyfils in mediawiki? Specifically we found out our js doesn't work in ie8 due to a missing Function.prototype.bind [23:38:23] (03CR) 10Krinkle: "Function.prototype.bind is an ES5 methods. We support various browsers that have javascript engines implementing the ES3 standard. There s" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109788 (owner: 10SG) [23:38:26] we can add it fairly easily, just want to see if there is a more official way than just in our files [23:38:27] (03CR) 10Krinkle: [C: 04-1] Introduce Function.bind polyfill, fix IE8 errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109788 (owner: 10SG) [23:38:33] oh, you already saw it :) thanks [23:38:37] (03PS3) 10SG: Introduce Function.bind polyfill, fix IE8 errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109788 [23:38:41] ebernhardson: Yep :) [23:39:11] (03CR) 10Bartosz Dziewoński: "Ugh, I was under the impression this did it the same was as Jon's change, I think. Sorry. Yeah, I say let's restore skins.common the same " [core] - 10https://gerrit.wikimedia.org/r/103078 (owner: 10Daniel Friesen) [23:39:30] ebernhardson: Basically, we support ES3 engines. Function.bind is part of ES5 and we can't require that yet in our browser landscape today. [23:39:59] Krinkle: sorry about that one D: [23:40:01] ebernhardson: Individual projects can drop support for ES3 engines if they like, and one day we'll do so from the MediaWiki core feature test in the startup module, but for now we support it at the base level. [23:40:17] Krinkle: ok that makes sense. [23:41:13] ebernhardson: If you go with dropping IE8 and using a feature test, make sure the feature test runs without exceptions in ES3 engines. Example: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js#L74-L92 [23:41:44] Maintain your own list of features you require of course, doesn't have to be the same list. [23:41:58] Krinkle: we will just use jQuery.proxy [23:42:14] it gives us what we need without having to use a polyfill [23:42:34] Youd' list any native method that is new in ES5 that you make use of in the project. Then it will either not run in older browsers, or (if mediawiki supplies an es5 polyfill as it will soon I suspect) it will run if there is a polyfil for those methods available [23:42:39] shahyar: Okay :) [23:43:59] I was wondering whether or not we had a repository of polyfills, guess not [23:44:14] Krinkle: want me to submit a fix for skins.common or is somebody on it already? [23:44:54] shahyar: es5 has many good polyfils out there, I don't think we would start maintaining our own. When the day comes, we'd ship it like we ship jquery. [23:45:25] MatmaRex: Depends, it might be too late. I haven't found any reports. Maybe another bug cancelled it out. If we can find any trace of it happening though, let's do it. [23:45:32] I'm not suggesting we maintain our own; I simply thought we'd already pull one in [23:45:58] Can somebody tell me what's wrong with this XPath? //[starts-with(@typeof, "mw:Image")] [23:46:03] MatmaRex: When I refreshed the page locally (soft refresh, no hard one, still logged out) it was gone, and I haven't been able to reproduce it on other pages on my wiki or with other wikis. [23:46:04] I get this: Warning: DOMXPath::query(): Invalid expression in /Users/andrew/wm-dev/core/extensions/Flow/includes/ReferenceExtractor.php on line 23 [23:46:06] greg-g: thinking through our deploy plans, we will have to scap as part of the deploy. [23:46:09] werdna: might need //* [23:46:14] werdna: //*[asdf] [23:46:24] i think you have to select a tag(could be wrong, been awhile) [23:46:27] Krinkle: i haven't seen that mysel either, and i haven't heard any reports about that being broken [23:46:30] ebernhardson++ [23:46:44] greg-g: is a scap ok? [23:46:51] Krinkle: i think there's ~10 days until the caches clear entirely [23:47:00] so it might be worth it [23:47:10] ebernhardson: yeah, you're the only ones in the window, so go ahead and get started whenever. and yeah, scap is fine. [23:47:38] greg-g: ok excellent, thanks [23:47:47] * greg-g nods [23:52:48] (03PS16) 10Adamw: Provision the fundraising-crm project [vagrant] - 10https://gerrit.wikimedia.org/r/94950 [23:53:48] (03CR) 10Daniel Friesen: "When I did this I was under the impression that skins.common had not yet been deployed to wmf." [core] - 10https://gerrit.wikimedia.org/r/103078 (owner: 10Daniel Friesen) [23:54:22] (03PS1) 10Bsitu: Update Flow [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/109789 [23:54:53] Fatal error: Call to undefined function mysqli_connect_error() in /var/www/DevWiki/core/includes/db/DatabaseMysqli.php on line 215 [23:54:55] * AaronSchulz sighs [23:56:06] (03PS4) 10SG: Replace all usages of Function.bind with jQuery.proxy Fixes IE8 errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109788 [23:56:41] (03CR) 10Bartosz Dziewoński: "Wait, that's true, it should not ever been deployed." [core] - 10https://gerrit.wikimedia.org/r/103078 (owner: 10Daniel Friesen) [23:56:53] Krinkle: ^ [23:56:55] hey gwicke, the data-parsoid blocks don't seem to be spec'd out here. Is that intentional? [23:56:56] https://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec#Wiki_links [23:57:00] (03CR) 10Deskana: "Here's what I'm not understanding. If the block was accidental, then why does the block" [core] - 10https://gerrit.wikimedia.org/r/49234 (owner: 10Liangent) [23:57:01] gwicke: can I not rely on them? [23:57:02] apparently i've already forgotten what that patch was [23:58:20] werdna, they are private information explicitly not part of the spec [23:58:30] they will be removed from the DOM soonish [23:58:50] what info are you looking for?