[00:08:12] (03PS1) 10Physikerwelt: Remove $wgUseTeX [extensions/Math] - 10https://gerrit.wikimedia.org/r/109492 [00:13:23] (03CR) 10Physikerwelt: [C: 04-1] "This change is dependend on a core change." [extensions/Math] - 10https://gerrit.wikimedia.org/r/109492 (owner: 10Physikerwelt) [00:29:46] (03PS1) 10Physikerwelt: Remove $wgUseTeX for checking if editing tools should be shown [core] - 10https://gerrit.wikimedia.org/r/109493 [00:38:13] (03PS2) 10Physikerwelt: Remove $wgUseTeX for checking if editing tools should be shown [core] - 10https://gerrit.wikimedia.org/r/109493 [00:39:55] (03CR) 10Physikerwelt: "in particular this change" [extensions/Math] - 10https://gerrit.wikimedia.org/r/109492 (owner: 10Physikerwelt) [00:43:46] (03PS1) 10Ori.livneh: Add fan-out writer [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/109494 [00:44:17] (03CR) 10jenkins-bot: [V: 04-1] Add fan-out writer [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/109494 (owner: 10Ori.livneh) [00:55:07] (03PS1) 10Physikerwelt: Rename global variables that violate the naming convention [extensions/Math] - 10https://gerrit.wikimedia.org/r/109495 [01:19:27] (03PS4) 10Physikerwelt: Add cirrus search [vagrant] - 10https://gerrit.wikimedia.org/r/108845 [01:19:47] (03PS3) 10Physikerwelt: Add mathsearch test data [vagrant] - 10https://gerrit.wikimedia.org/r/108856 [01:20:08] (03PS3) 10Physikerwelt: install MathWebSearch [vagrant] - 10https://gerrit.wikimedia.org/r/108869 [01:56:31] (03PS1) 10TTO: Give a meaningful message when Special:ActiveUsers is disabled [core] - 10https://gerrit.wikimedia.org/r/109496 [02:01:53] !log LocalisationUpdate completed (1.23wmf10) at 2014-01-26 02:01:52+00:00 [02:02:41] !log LocalisationUpdate completed (1.23wmf11) at 2014-01-26 02:02:40+00:00 [02:09:05] !log LocalisationUpdate ResourceLoader cache refresh completed at 2014-01-26 02:09:05+00:00 [02:15:18] (03CR) 10Aaron Schulz: "I don't have strong feelings, but I don't see the use in listing a page people can't really use. We don't do these for PopularPages ect." [core] - 10https://gerrit.wikimedia.org/r/109496 (owner: 10TTO) [02:15:24] (03CR) 10TTO: "> I would also like to see the implementation reuse the existing 'indent-pre' code paths, in order to ensure that we don't introduce new c" [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [02:17:09] (03PS1) 10Physikerwelt: Fix problems with textsearch [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/109497 [02:18:40] (03CR) 10Physikerwelt: [C: 032 V: 032] Fix problems with textsearch [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/109497 (owner: 10Physikerwelt) [02:24:18] (03CR) 10TTO: "I'm mainly thinking of WMF wikis here - the querypage-disabled message cites "performance reasons", which is more of an explanation than t" [core] - 10https://gerrit.wikimedia.org/r/109496 (owner: 10TTO) [02:32:55] (03CR) 10Legoktm: "You can override isListed() to return $wgMiserMode to avoid listing it if it's disabled." [core] - 10https://gerrit.wikimedia.org/r/109496 (owner: 10TTO) [02:33:03] (03CR) 10Aaron Schulz: "Maybe this can just be backported to the next branch instead of in master." [core] - 10https://gerrit.wikimedia.org/r/109496 (owner: 10TTO) [02:40:19] (03CR) 10PleaseStand: "Would it perhaps be preferable to add an EditPageBeforeEditToolbar hook to the Math extension, and from there, add the additional mw.toolb" [core] - 10https://gerrit.wikimedia.org/r/109493 (owner: 10Physikerwelt) [03:07:24] I just had an epiphany... Is there any way that the software could grade images and apply classes based on that rating? [03:08:10] Maybe based on some kind of feedback system? [03:09:42] Then people could add a rule to their .css to {display: none;} all images with certain gradings. [03:10:30] (03PS2) 10TTO: Give a meaningful message when Special:ActiveUsers is disabled [core] - 10https://gerrit.wikimedia.org/r/109496 [03:11:07] (03CR) 10TTO: "> Maybe this can just be backported to the next branch instead of in master." [core] - 10https://gerrit.wikimedia.org/r/109496 (owner: 10TTO) [03:23:06] (03PS8) 10TTO: Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 [03:26:07] T13|sleeps: not currently [03:26:18] one could build a extension [03:27:17] Think it's a good idea or a waste of time? lol [03:48:23] I just love how vim php syntax highlighting breaks on // "foo" [03:49:03] (03CR) 10Aaron Schulz: Various fixes to job running code in Wiki.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/108740 (owner: 10Aaron Schulz) [04:38:05] (03CR) 10Parent5446: "Mark what's your opinion on this? I'm kind of hesitant to remove 1.22-deprecated code." [core] - 10https://gerrit.wikimedia.org/r/108490 (owner: 10Physikerwelt) [04:51:28] (03CR) 10Parent5446: [C: 032] Add Special:Diff as an internally-linkable redirect to diff pages [core] - 10https://gerrit.wikimedia.org/r/63395 (owner: 10Jérémie Roquet) [04:51:28] (03PS1) 10Hoo man: Add some wfProfileOut [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/109499 [04:51:44] (03CR) 10jenkins-bot: [V: 04-1] Add some wfProfileOut [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/109499 (owner: 10Hoo man) [04:54:13] (03Merged) 10jenkins-bot: Add Special:Diff as an internally-linkable redirect to diff pages [core] - 10https://gerrit.wikimedia.org/r/63395 (owner: 10Jérémie Roquet) [04:55:38] (03PS2) 10Hoo man: Add some wfProfileOut [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/109499 [05:06:43] (03PS1) 10Hoo man: Add a wfProfileOut call [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/109500 [05:07:51] ^-- if anybody wants to rise his review counter... [05:46:11] (03CR) 10Reedy: [C: 032] Add missing wfProfileOut calls [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/109499 (owner: 10Hoo man) [05:46:17] (03Merged) 10jenkins-bot: Add missing wfProfileOut calls [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/109499 (owner: 10Hoo man) [05:47:01] (03CR) 10Reedy: [C: 032] Add a wfProfileOut call [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/109500 (owner: 10Hoo man) [05:47:03] (03Merged) 10jenkins-bot: Add a wfProfileOut call [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/109500 (owner: 10Hoo man) [05:58:10] who's still in SF? [05:58:18] anyone? [06:13:56] (03PS3) 10TTO: Add extra views (tabs) for files in a foreign repository [core] - 10https://gerrit.wikimedia.org/r/104182 [06:41:34] !log reedy updated /a/common to {{Gerrit|I3f9759db9}}: Let admins add users to new groups on zhwikivoyage [06:41:34] https://www.mediawiki.org/wiki/Template:Gerrit [06:56:03] Reedy: stop working [08:35:08] (03Abandoned) 10Hoo man: Make LuaEngineTestBase easier reusable [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107895 (owner: 10Hoo man) [08:46:42] (03CR) 10Hoo man: [C: 04-1] "Didn't test, only had a quick glance" (031 comment) [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 (owner: 10Jackmcbarn) [09:24:22] (03PS1) 10Umherirrender: Restore templatelinks count on info=action [core] - 10https://gerrit.wikimedia.org/r/109506 [09:44:41] (03CR) 10Hoo man: [C: 04-1] "Would have been easier to just check for the return value of urlFunction in the two functions the bug is about rather than changing so muc" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/107017 (owner: 1001tonythomas) [09:53:55] (03CR) 10Physikerwelt: "I would not say remove, the code is moved to the extension." [core] - 10https://gerrit.wikimedia.org/r/108490 (owner: 10Physikerwelt) [09:59:25] (03CR) 10Hoo man: [C: 04-1] "I think the main issue is that the handling of the result of User::getPasswordValidity is broken, which should rather be fixed." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [10:06:34] (03CR) 10Physikerwelt: "Yes I think that would be better. Bus is that not a follow up commit. This commit does not affect the user and removes only $wgUseTeX that" [core] - 10https://gerrit.wikimedia.org/r/109493 (owner: 10Physikerwelt) [11:18:33] (03PS1) 10UltrasonicNXT: Add rename user hook [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/109509 [11:47:36] (03PS9) 10Martineznovo: Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [11:47:38] (03CR) 10jenkins-bot: [V: 04-1] Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [12:04:23] (03PS1) 10UltrasonicNXT: Stop storing user names in DB [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/109512 [12:04:54] (03Abandoned) 10UltrasonicNXT: Add rename user hook [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/109509 (owner: 10UltrasonicNXT) [12:06:06] (03PS1) 10Shirayuki: i18n: remove leading tab character [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109513 [12:07:16] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Stop storing user names in DB [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/109512 (owner: 10UltrasonicNXT) [12:14:44] (03CR) 10Helder.wiki: "I believe this broke custom toggles, by making their text uncopyable :-(" [core] - 10https://gerrit.wikimedia.org/r/105689 (owner: 10Gerrit Patch Uploader) [12:33:56] Gloria: you there ? [12:38:44] (03CR) 10Helder.wiki: "More comments on" [core] - 10https://gerrit.wikimedia.org/r/105689 (owner: 10Gerrit Patch Uploader) [13:07:03] (03PS1) 10UltrasonicNXT: Fix sidebar names displaying user id instead of name [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/109517 [13:07:56] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix sidebar names displaying user id instead of name [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/109517 (owner: 10UltrasonicNXT) [13:14:33] (03PS7) 1001tonythomas: Check for CoreParserFunction::urlFunction from array to boolean and return values accordingly to htmlspecialchars() [core] - 10https://gerrit.wikimedia.org/r/107017 [13:15:21] (03CR) 10jenkins-bot: [V: 04-1] Check for CoreParserFunction::urlFunction from array to boolean and return values accordingly to htmlspecialchars() [core] - 10https://gerrit.wikimedia.org/r/107017 (owner: 1001tonythomas) [13:17:15] (03PS8) 1001tonythomas: Check for CoreParserFunction::urlFunction from array to boolean and return values accordingly to htmlspecialchars() [core] - 10https://gerrit.wikimedia.org/r/107017 [13:20:51] tonythomas01: tell me [13:24:19] Nemo_bis: that was on an how to get the array value for a key, when a function returns the array. It should be something like $temp = func(); if ($temp['key'] === value ) [13:24:22] right ? [13:26:39] sounds correct but I'm not into PHP tricks :) [13:27:58] Nemo_bis: thanks [14:12:50] (03PS5) 1001tonythomas: Error shown ifAdministrator username and passwod match shown on same page of installer [core] - 10https://gerrit.wikimedia.org/r/105428 [14:20:02] (03PS6) 1001tonythomas: Error shown ifAdministrator username and passwod match shown on same page of installer [core] - 10https://gerrit.wikimedia.org/r/105428 [14:21:16] (03CR) 10jenkins-bot: [V: 04-1] Error shown ifAdministrator username and passwod match shown on same page of installer [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [14:23:12] (03CR) 10Bartosz Dziewoński: "We could clone the existing messages, I suppose… writing a bot to do that on twn would take like five minutes if you don't have an "admin " [core] - 10https://gerrit.wikimedia.org/r/109296 (owner: 10Microchip08) [14:23:48] (03PS7) 1001tonythomas: Error shown ifAdministrator username and passwod match shown on same page of installer [core] - 10https://gerrit.wikimedia.org/r/105428 [14:26:40] (03CR) 10Bartosz Dziewoński: [C: 031] "We should just have a hook that would allow one to modify the contents of $toolarray before it's used, and preferably deprecate EditPageBe" [core] - 10https://gerrit.wikimedia.org/r/109493 (owner: 10Physikerwelt) [14:35:04] (03CR) 10Addshore: [C: 031] Error shown ifAdministrator username and passwod match shown on same page of installer [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [14:48:57] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Actually, I want to see either a followup commit or a bug filed first. :>" [core] - 10https://gerrit.wikimedia.org/r/109493 (owner: 10Physikerwelt) [14:55:34] (03PS1) 10Nullzero: Preload abusefilter-warning if created page is blank [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/109518 [15:15:02] (03CR) 10Se4598: "the commit message is unclear to me (Where and for whom?)." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/109518 (owner: 10Nullzero) [15:22:17] (03CR) 10Alex Monk: [C: 032] SpecialWantedcategories: Actually strike the category if it was emptied [core] - 10https://gerrit.wikimedia.org/r/106552 (owner: 10Bartosz Dziewoński) [15:22:29] (03PS2) 10Nullzero: Preload abusefilter-warning if created page is blank [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/109518 [15:25:37] (03Merged) 10jenkins-bot: SpecialWantedcategories: Actually strike the category if it was emptied [core] - 10https://gerrit.wikimedia.org/r/106552 (owner: 10Bartosz Dziewoński) [15:34:21] (03PS1) 10Ebe123: Create Special:Purge [core] - 10https://gerrit.wikimedia.org/r/109523 [15:56:05] (03Abandoned) 10Ebe123: Create Special:Purge [core] - 10https://gerrit.wikimedia.org/r/109523 (owner: 10Ebe123) [16:01:53] (03Restored) 10Ebe123: Create Special:Purge [core] - 10https://gerrit.wikimedia.org/r/109523 (owner: 10Ebe123) [16:02:06] (03PS2) 10Ebe123: Create Special:Purge [core] - 10https://gerrit.wikimedia.org/r/109523 [16:46:39] hi . I am pretty proficient in Javascript . Could someone please help me get started into open source development for the WIkiMedia foundation. Thnaks [16:48:28] (03PS3) 10Ebe123: Create Special:Purge [core] - 10https://gerrit.wikimedia.org/r/109523 [16:50:08] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/109551 (owner: 10L10n-bot) [16:50:38] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/109548 (owner: 10L10n-bot) [16:53:00] thej, have you read https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker ? [16:55:30] Krenair , currently reading . setting up my virtual env [16:56:58] could you please help me set up my dev env ? [16:57:26] how intimidating is the code for beginners ? [16:59:19] (03CR) 10Addshore: Remove unused stuff from tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109470 (owner: 10Addshore) [17:00:37] (03PS3) 10Addshore: Remove unused stuff from tests [core] - 10https://gerrit.wikimedia.org/r/109470 [17:00:53] (03CR) 10Parent5446: Error shown ifAdministrator username and passwod match shown on same page of installer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [17:01:29] (03CR) 10Addshore: Expand MWTimestamp tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109478 (owner: 10Addshore) [17:01:31] (03PS2) 10Addshore: Expand MWTimestamp tests [core] - 10https://gerrit.wikimedia.org/r/109478 [17:03:09] (03CR) 10Parent5446: [C: 031] "Minor style issue, but otherwise patch looks good." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104182 (owner: 10TTO) [17:04:03] (03CR) 10Parent5446: [C: 032] Expand MWTimestamp tests [core] - 10https://gerrit.wikimedia.org/r/109478 (owner: 10Addshore) [17:05:27] thej, what do you want to know specifically? [17:07:18] (03Merged) 10jenkins-bot: Expand MWTimestamp tests [core] - 10https://gerrit.wikimedia.org/r/109478 (owner: 10Addshore) [17:11:18] (03PS8) 1001tonythomas: Error shown ifAdministrator username and passwod match shown on same page of installer [core] - 10https://gerrit.wikimedia.org/r/105428 [17:39:47] (03PS1) 10Lethosor: Fix rebuildall.php fatal error with PostgreSQL [core] - 10https://gerrit.wikimedia.org/r/109583 [17:42:35] (03PS2) 10Lethosor: Fix rebuildall.php fatal error with PostgreSQL [core] - 10https://gerrit.wikimedia.org/r/109583 [17:51:58] (03PS1) 10Addshore: Add initial tests for UserArrayFromResult [core] - 10https://gerrit.wikimedia.org/r/109584 [17:52:00] (03PS1) 10Addshore: Initial Tests for TitleArrayFromResult [core] - 10https://gerrit.wikimedia.org/r/109585 [17:52:02] (03PS1) 10Addshore: Split Title and User ArrayFromResult classes to own files [core] - 10https://gerrit.wikimedia.org/r/109586 [17:58:17] (03CR) 10Hoo man: Error shown ifAdministrator username and passwod match shown on same page of installer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [18:15:21] (03PS1) 10Addshore: Move QueryPage.php to specialpage folder [core] - 10https://gerrit.wikimedia.org/r/109587 [18:16:32] (03CR) 10jenkins-bot: [V: 04-1] Move QueryPage.php to specialpage folder [core] - 10https://gerrit.wikimedia.org/r/109587 (owner: 10Addshore) [18:18:53] (03PS2) 10Addshore: Move QueryPage.php to specialpage folder [core] - 10https://gerrit.wikimedia.org/r/109587 [18:20:05] (03CR) 10jenkins-bot: [V: 04-1] Move QueryPage.php to specialpage folder [core] - 10https://gerrit.wikimedia.org/r/109587 (owner: 10Addshore) [18:21:25] (03PS9) 1001tonythomas: Error shown ifAdministrator username and passwod match shown on same page of installer [core] - 10https://gerrit.wikimedia.org/r/105428 [18:23:08] (03CR) 1001tonythomas: "@hoo: updated as you recommended." [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [18:26:45] (03CR) 10Hoo man: [C: 04-1] "Yay for more unit tests :)" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/109584 (owner: 10Addshore) [18:27:40] (03PS3) 10Addshore: Move QueryPage.php to specialpage folder [core] - 10https://gerrit.wikimedia.org/r/109587 [18:29:06] (03CR) 10Addshore: Add initial tests for UserArrayFromResult (032 comments) [core] - 10https://gerrit.wikimedia.org/r/109584 (owner: 10Addshore) [18:32:31] (03PS2) 10Addshore: Add initial tests for UserArrayFromResult [core] - 10https://gerrit.wikimedia.org/r/109584 [18:32:33] (03PS2) 10Addshore: Initial Tests for TitleArrayFromResult [core] - 10https://gerrit.wikimedia.org/r/109585 [18:32:45] (03PS2) 10Addshore: Split Title and User ArrayFromResult classes to own files [core] - 10https://gerrit.wikimedia.org/r/109586 [18:35:22] (03CR) 10Hoo man: [C: 031] "Didn't test. Please notice that this is not going to show an error if User::newFromName can't construct a user name (but it also didn't be" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [18:38:39] (03CR) 10Hoo man: [C: 032] Add initial tests for UserArrayFromResult [core] - 10https://gerrit.wikimedia.org/r/109584 (owner: 10Addshore) [18:41:50] (03Merged) 10jenkins-bot: Add initial tests for UserArrayFromResult [core] - 10https://gerrit.wikimedia.org/r/109584 (owner: 10Addshore) [18:48:38] (03PS1) 10Addshore: Fix phpdoc in SwiftFileBackend [core] - 10https://gerrit.wikimedia.org/r/109588 [18:59:58] (03PS1) 10Addshore: Remove unused globals [core] - 10https://gerrit.wikimedia.org/r/109589 [19:02:34] (03CR) 10Bartosz Dziewoński: "Omg nooo, this is going to conflict with my unmerged junk I'm tired of rebasing" [core] - 10https://gerrit.wikimedia.org/r/109589 (owner: 10Addshore) [19:03:04] (03CR) 10Addshore: "fix it in your patch? ;p" [core] - 10https://gerrit.wikimedia.org/r/109589 (owner: 10Addshore) [19:03:48] (03CR) 10Bartosz Dziewoński: "It's probably fixed by the unmerged ones. https://gerrit.wikimedia.org/r/#/q/topic:watchlist+is:open,n,z" [core] - 10https://gerrit.wikimedia.org/r/109589 (owner: 10Addshore) [19:09:37] (03Abandoned) 10Addshore: Remove unused globals [core] - 10https://gerrit.wikimedia.org/r/109589 (owner: 10Addshore) [19:11:19] (03CR) 10Frédéric Wang: "I have not tested again but strictly speaking the new modules/MathML-fonts/ fonts are not part of MathJax 2.3 and should be taken with th" [extensions/Math] - 10https://gerrit.wikimedia.org/r/109490 (owner: 10Physikerwelt) [19:34:22] (03Restored) 10Bartosz Dziewoński: Remove unused globals [core] - 10https://gerrit.wikimedia.org/r/109589 (owner: 10Addshore) [19:36:20] (03CR) 10Bartosz Dziewoński: "They're currently not merged yet, I'll get this patch sorted out as well." [core] - 10https://gerrit.wikimedia.org/r/107360 (owner: 1001tonythomas) [19:41:49] (03CR) 10Bartosz Dziewoński: "(I'd appreciate if you could rebase on top of https://gerrit.wikimedia.org/r/#/c/106279/ , which is currently the top of the stack of my p" [core] - 10https://gerrit.wikimedia.org/r/107360 (owner: 1001tonythomas) [19:42:09] rebase incoming [19:42:33] (03PS10) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement execute() [core] - 10https://gerrit.wikimedia.org/r/103240 [19:42:35] (03PS6) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement two new hooks superseding 4 old ones [core] - 10https://gerrit.wikimedia.org/r/106279 [19:42:37] (03PS2) 10Bartosz Dziewoński: Remove unused globals [core] - 10https://gerrit.wikimedia.org/r/109589 (owner: 10Addshore) [19:42:39] (03PS7) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement webOutput() [core] - 10https://gerrit.wikimedia.org/r/105195 [19:42:41] (03PS6) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement doMainQuery() [core] - 10https://gerrit.wikimedia.org/r/105194 [19:42:43] (03PS8) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/103546 [19:42:45] (03PS10) 10Bartosz Dziewoński: No longer display the number of rows shown on Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/103239 [19:42:47] (03PS7) 10Bartosz Dziewoński: ChangesListSpecialPage: Stop mutating $opts in buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/105196 [19:42:51] eww [19:43:03] (03CR) 10Bartosz Dziewoński: [C: 032] "Has dependencies now. Sorry about that." [core] - 10https://gerrit.wikimedia.org/r/109589 (owner: 10Addshore) [19:44:49] oh right [19:48:10] MatmaRex: the qqq for https://gerrit.wikimedia.org/r/#/c/103239/10 is now wrong [19:48:34] (03CR) 10Legoktm: [C: 04-1] "qqq needs re-updating." [core] - 10https://gerrit.wikimedia.org/r/103239 (owner: 10Bartosz Dziewoński) [19:49:19] D: [19:49:32] argh [19:49:41] can i fix it on twn after we merge this? [19:50:04] actually, whatever [19:50:12] fixing [19:50:50] (03PS1) 10Legoktm: Fix typo: "oaram" --> "param" [core] - 10https://gerrit.wikimedia.org/r/109592 [19:51:51] (03CR) 10Yuvipanda: [C: 032] Fix typo: "oaram" --> "param" [core] - 10https://gerrit.wikimedia.org/r/109592 (owner: 10Legoktm) [19:52:42] boom i got to it [19:52:51] :D [19:52:52] (03PS11) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement execute() [core] - 10https://gerrit.wikimedia.org/r/103240 [19:52:54] (03PS7) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement two new hooks superseding 4 old ones [core] - 10https://gerrit.wikimedia.org/r/106279 [19:52:56] (03PS3) 10Bartosz Dziewoński: Remove unused globals [core] - 10https://gerrit.wikimedia.org/r/109589 (owner: 10Addshore) [19:52:58] (03PS8) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement webOutput() [core] - 10https://gerrit.wikimedia.org/r/105195 [19:53:00] (03PS7) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement doMainQuery() [core] - 10https://gerrit.wikimedia.org/r/105194 [19:53:02] (03PS9) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/103546 [19:53:04] (03PS11) 10Bartosz Dziewoński: No longer display the number of rows shown on Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/103239 [19:53:06] (03PS8) 10Bartosz Dziewoński: ChangesListSpecialPage: Stop mutating $opts in buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/105196 [19:53:11] xD [19:53:54] (03CR) 10Legoktm: [C: 032] No longer display the number of rows shown on Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/103239 (owner: 10Bartosz Dziewoński) [19:54:50] (03CR) 10Bartosz Dziewoński: [C: 032] Remove unused globals [core] - 10https://gerrit.wikimedia.org/r/109589 (owner: 10Addshore) [19:56:54] (03Merged) 10jenkins-bot: Fix typo: "oaram" --> "param" [core] - 10https://gerrit.wikimedia.org/r/109592 (owner: 10Legoktm) [20:00:33] (03CR) 10Legoktm: [C: 032] "Trivial documentation fix can be done in a follow-up." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103240 (owner: 10Bartosz Dziewoński) [20:01:55] (03CR) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement execute() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103240 (owner: 10Bartosz Dziewoński) [20:02:17] thanks [20:03:02] (03Merged) 10jenkins-bot: No longer display the number of rows shown on Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/103239 (owner: 10Bartosz Dziewoński) [20:03:45] (03CR) 10Legoktm: ChangesListSpecialPage: Implement execute() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103240 (owner: 10Bartosz Dziewoński) [20:03:48] (03Merged) 10jenkins-bot: ChangesListSpecialPage: Implement execute() [core] - 10https://gerrit.wikimedia.org/r/103240 (owner: 10Bartosz Dziewoński) [20:04:35] (03Merged) 10jenkins-bot: Remove unused globals [core] - 10https://gerrit.wikimedia.org/r/109589 (owner: 10Addshore) [20:04:46] I'm going to get lunch now, I'll review the next one after that [20:15:10] (03CR) 10Addshore: [C: 031] ChangesListSpecialPage: Implement buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/103546 (owner: 10Bartosz Dziewoński) [20:18:21] (03CR) 10Addshore: [C: 04-1] ChangesListSpecialPage: Implement doMainQuery() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105194 (owner: 10Bartosz Dziewoński) [20:21:08] (03CR) 10Addshore: [C: 031] "Did test and with the same username and password we get the error :)" [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [20:26:32] (03PS2) 10Ori.livneh: Unconditionally insert shop link via PHP [extensions/WikimediaShopLink] - 10https://gerrit.wikimedia.org/r/98885 [20:27:37] (03PS3) 10Ori.livneh: Unconditionally insert shop link via PHP [extensions/WikimediaShopLink] - 10https://gerrit.wikimedia.org/r/98885 [20:28:07] MatmaRex or Reedy, if you have a chance ^ [20:30:12] actually, there's a bit of dead code that could be eliminated [20:33:09] (03PS4) 10Ori.livneh: Unconditionally insert shop link via PHP [extensions/WikimediaShopLink] - 10https://gerrit.wikimedia.org/r/98885 [20:33:11] there [20:33:24] wut, what is that extension? :o [20:33:50] i know, right [20:34:33] ah, i'm probably not on that geolocation whitelist or somehting [20:35:42] it's pretty ridiculous imo. the fundraiser is a very special case.. i don't think this sort of geo-targetting is warranted otherwise [20:35:59] couldn't we check the geolocation server-side? [20:36:07] or rather, why are we not? legal stuff? [20:36:28] because we don't want to vary the html cache by ip [20:36:30] (or in other words, why is it a separate service (?) on bits?) [20:36:38] ugh [20:37:03] well, then i dunno, make it a RL module that will display #shoplink-whatever{display:none} if appropriate [20:37:53] no, we're just not going to geo-target like that [20:38:15] but we already are doing that? [20:38:16] whatever [20:38:32] this is pretty silly either way :/ [20:38:41] the shop ships to all countries you can send mail to from the US [20:38:52] which means north koreans will be deeply misled by the presence of that link [20:39:08] heh [20:39:26] Hmm, Iranians for not too much longer? [20:39:41] hm, i've never tried to ship anything to iran [20:39:54] iirc, Iran is trade embargo'd by the US? [20:40:25] we should just disable the extension on the farsi wikipedia [20:41:07] i don't think other us-hosted web properties go out of their way to hide retail links from iranian visitors [20:41:46] ori: the code looks reasonable, i assume you tested it? [20:41:50] yeah [20:41:58] also, do we want to submit the cleanup patch, or do we not care? [20:42:40] i look at the default js payload about 50 times a day now and i squint at the modules i don't like [20:43:01] so i won't forget. legoktm suggested folding the extension into WikimediaMessages which is probably what i'll do after 30 days pass [20:43:42] the cleanup patch is basically PS1 of that changeset [20:44:04] i forgot about caching effects so my initial pass just dropped the JS altogether [20:44:19] (03CR) 10Bartosz Dziewoński: [C: 032] "YOLO" [extensions/WikimediaShopLink] - 10https://gerrit.wikimedia.org/r/98885 (owner: 10Ori.livneh) [20:44:21] (03Merged) 10jenkins-bot: Unconditionally insert shop link via PHP [extensions/WikimediaShopLink] - 10https://gerrit.wikimedia.org/r/98885 (owner: 10Ori.livneh) [20:44:40] \o/ [20:45:50] thanks very much, i'll make sure the shop people expect it [20:46:58] my pleasure [20:47:06] * Nemo_bis pats MatmaRex  [20:48:15] (03CR) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement doMainQuery() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105194 (owner: 10Bartosz Dziewoński) [20:49:17] i'm heading out to get a haircut but will look at the watchlist patch series when i get back. iirc the base change needs a complicated manual rebase :/ [20:49:28] (03CR) 10Parent5446: [C: 04-1] Error shown ifAdministrator username and passwod match shown on same page of installer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [20:49:41] heh [20:49:46] ori: i rebased some stuff today [20:49:47] lol [20:49:51] and legoktm merged some [20:50:04] (03PS8) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement doMainQuery() [core] - 10https://gerrit.wikimedia.org/r/105194 [20:52:08] * Nemo_bis points to "log-rolling" warning by WMF ED https://meta.wikimedia.org/wiki/Grants:APG/FDC_portal/Annual_report_on_the_Funds_Dissemination_Committee_process_2012-2013#The_WMF_Executive_Director.E2.80.99s_Reflections_on_the_FDC_Process [20:52:34] (03CR) 10Parent5446: [C: 032] "Unfortunately there are cases where $options can be a string." [core] - 10https://gerrit.wikimedia.org/r/109583 (owner: 10Lethosor) [20:54:50] (03CR) 10Parent5446: [C: 032] Initial Tests for TitleArrayFromResult [core] - 10https://gerrit.wikimedia.org/r/109585 (owner: 10Addshore) [20:55:47] (03Merged) 10jenkins-bot: Fix rebuildall.php fatal error with PostgreSQL [core] - 10https://gerrit.wikimedia.org/r/109583 (owner: 10Lethosor) [20:57:55] (03Merged) 10jenkins-bot: Initial Tests for TitleArrayFromResult [core] - 10https://gerrit.wikimedia.org/r/109585 (owner: 10Addshore) [21:04:08] (03PS1) 10Svemir Brkic: Replace deprecated wfMsg with wfMessage [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/109601 [21:21:18] legoktm: around? [21:21:24] wanna sanity-check me? [21:21:25] yup [21:21:28] sure [21:22:07] about these feeds on changeslistspecialpage. how about i kill them and instead make the recentchanges and recentchangeslinked feeds api modules? [21:22:14] watchlist and contributions already work that way [21:22:33] (they have api modules, feedwatchlist and feedcontributions, that generate feeds) [21:22:49] would it be backwards compatible? [21:23:00] if we keep a redirect from the old URLs, then it should be [21:23:57] yeah, sounds good to me then [21:24:48] alright. i'll look how hard would that be [21:54:27] ugh, i've forgotten how much writing api modules sucks. [22:08:08] we should consider a simplified result return model for api 2.0 [22:08:33] i've recommended 'simple json model, screw xml' :P :) [22:17:17] (03PS1) 10Ocean behind ears: Fix counting error [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109602 [22:18:12] brion: i am actually trying to make a feed api module [22:18:23] oh god help you [22:18:27] or rather, shoehorn existing feed output system into the api [22:18:29] you have to work against the api there :D [22:30:08] (03CR) 10Aaron Schulz: [C: 04-1] Fix phpdoc in SwiftFileBackend (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109588 (owner: 10Addshore) [22:42:54] hehe, I just read what brion said about mentoring at the architecture summit and then I find him being so encouraging here :P [22:44:15] :) [22:45:35] reminds me i've got a lot of notes to go through and some documents to ponder over [22:46:41] that's going to be hard [22:47:20] who else could do that [22:48:14] from the outside, the most visible thing for me is that we discovered the Wikia folks! so little interaction in the past (except some small teamworking and shared offices) [23:04:43] (03CR) 10Parent5446: [C: 04-1] Create Special:Purge (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109523 (owner: 10Ebe123) [23:07:15] (03PS4) 10Legoktm: Create Special:Purge [core] - 10https://gerrit.wikimedia.org/r/109523 (owner: 10Ebe123) [23:15:03] (03CR) 10Legoktm: [C: 031] "1 minor code quality thing, other than that looks good." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/103546 (owner: 10Bartosz Dziewoński) [23:22:35] (03CR) 10Legoktm: [C: 031] "Consider this a +2 when parent patch is merged." [core] - 10https://gerrit.wikimedia.org/r/105194 (owner: 10Bartosz Dziewoński) [23:30:18] (03PS1) 10Ori.livneh: Add a role for the Gadgets extension [vagrant] - 10https://gerrit.wikimedia.org/r/109605 [23:30:56] (03CR) 10Ori.livneh: [C: 032] Add a role for the Gadgets extension [vagrant] - 10https://gerrit.wikimedia.org/r/109605 (owner: 10Ori.livneh) [23:40:54] (03CR) 10Legoktm: [C: 031] ChangesListSpecialPage: Stop mutating $opts in buildMainQueryConds() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105196 (owner: 10Bartosz Dziewoński) [23:46:44] (03CR) 10Legoktm: [C: 04-1] "Now that we have a method of marking hooks as deprecated, I think you should use that." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106279 (owner: 10Bartosz Dziewoński) [23:46:50] aaaand that's everything! [23:48:58] (03CR) 10Legoktm: [C: 031] ChangesListSpecialPage: Implement webOutput() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105195 (owner: 10Bartosz Dziewoński)