[00:06:58] (03CR) 10Physikerwelt: "Indeed no longer needed, iff math 2.0 is merged some day... I moved to the dev branch and now I'm tring to break it down in changes that c" [extensions/Math] - 10https://gerrit.wikimedia.org/r/87519 (owner: 10Liangent) [00:07:20] php in a MW message [00:07:21] eval [00:07:22] DONE. [00:07:33] Reedy: WFM. [00:08:47] Reedy: Certainly, I think we'd want code review before on-wiki configuration goes live for WMF cluster. [00:08:54] Reedy: Lest we have config edit wars. [00:09:05] ok... if there are no further concerns I'll merge that change https://gerrit.wikimedia.org/r/#/c/105187/11 [00:09:53] Just use FlaggedRevs [00:10:21] Tim: "I can see both sides of the argument, and I hate them both." [00:10:45] Remove all globals [00:11:08] Reedy: Umm. No thank you. :-) [00:11:09] ^d: WAR ON GLOBALS [00:11:25] <^d> Global objects annoy me. [00:11:28] <^d> Global config not so much. [00:11:36] <^d> Hence I raised my hand for the "not urgent" group. [00:11:48] we need only one global [00:11:50] $GLOBAL [00:11:57] <^d> That's not a global. [00:11:59] $GLOBALS [00:12:00] <^d> It's a SUPER global! [00:12:00] shit [00:12:02] it's a SUPERGLOBAL [00:12:02] physikerwelt: I can ask csteipp to review if to need it. [00:12:03] MEGAGLOBAL [00:12:11] (03PS11) 10Siebrand: Add OOJS UI v0.1.0-pre (da9ec955a8) to core [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [00:12:11] <^d> FREAKINGAWESOMEGLOBAL [00:12:35] super > not super [00:12:40] WEEEJS [00:12:43] $wgFreakingAwesomeGlobal, you mean? [00:13:03] RoanKattouw_away: https://gerrit.wikimedia.org/r/98887 [00:13:08] SUPERMEGAFREAKINGAWESOMEGLOBAL [00:13:11] I love the way that scans [00:13:22] <^d> siebrand: $GLOBALS['wgFreakingAwesomeGlobal'] [00:13:24] SUperMEgaFREAkingAWEsome global [00:13:35] $wgGlobals [00:13:38] ^d: Oh, right, that's composer ready... [00:13:53] (03CR) 10Jforrester: Add OOJS UI v0.1.0-pre (da9ec955a8) to core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [00:13:56] James_F: My only concern is that I don't know if people will complain about the notice [00:13:58] (03CR) 10jenkins-bot: [V: 04-1] Add OOJS UI v0.1.0-pre (da9ec955a8) to core [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [00:14:04] * ^d is being opinionated on IRC instead of in person [00:14:10] <^d> I would wait in line, but standing. [00:14:11] James_F: if that's not the case I don't see a problem [00:14:31] heh [00:14:53] * brion gets a telepresence robot for ^d [00:15:36] * ^d shuts down his robot clone [00:16:03] * brion protests ^d's robot clone [00:16:46] (03CR) 10Siebrand: Add OOJS UI v0.1.0-pre (da9ec955a8) to core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [00:18:21] (03CR) 10Hashar: [C: 04-2] "If we really want to tie mw/core and oojs can we please use a submodule? Shipping it with MediaWiki tarball would be a job for the make-r" [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [00:20:40] (03CR) 10Bartosz Dziewoński: "Sweet Jesus no, no submodules." [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [00:21:13] (03CR) 10Chad: "A submodule on master? Ugh...haven't we already learned enough mistakes from submodules?" [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [00:21:29] <^d> MatmaRex: You read my mind. [00:21:43] submodules! they're horrid [00:21:53] <^d> I've been meaning to try out the submodule-like thing [00:21:56] <^d> Sub...paths? [00:21:58] <^d> Subtree? [00:22:00] surely copy pasting code is a better than submodules ? [00:22:00] <^d> Something like that. [00:22:03] cp -R [00:22:21] <^d> Printing out the code and retyping it by hand is superior to submodules. [00:22:22] + that grow the mediawiki/core.git repo [00:22:36] ^d: on paper tape right? [00:22:55] ^d: +1 [00:23:00] <^d> Hell, not having any code at all and giving up to go home is superior to submodules. [00:23:03] <^d> :) [00:23:22] i'd just like them to update automatically like svn externals did [00:23:33] but... without sucking like svn externals [00:23:33] <^d> lol, because that was safe. [00:23:37] <^d> ;-) [00:23:41] I was about to propose a OO extension to register the submodules :D [00:23:44] err [00:23:55] I was about to propose a OO mediawiki extension to register the ResourceLoader modules [00:24:59] (03CR) 10Jforrester: "Note that OOjs already ships in this form with MW; this is adding the second half of bug 56572 only." [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [00:25:35] (03PS8) 10Mattflaschen: Remove Special:GettingStarted and notifications [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/106458 [00:25:45] hashar: Eww. [00:26:04] hashar: These are intended to be core libraries used by lots and lots of MW core UI, eventually. [00:26:14] I have to agree with hashar. Just copy/pasting code in is not a good idea [00:26:18] hashar: Making core depend on an extension is not cool. [00:26:46] yeah we had the same execuse for ORM* classes [00:26:48] :/ [00:26:52] (03CR) 10Mattflaschen: "Done in patch set 8. I also changed the commit message and made a small comment change." (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/106458 (owner: 10Mattflaschen) [00:27:05] Can somebody explain the actual disadvantages of submodules? [00:27:15] (03CR) 10Hoo man: [C: 032] "Not much of a big deal" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/106891 (owner: 10Anjanasasindran123) [00:27:17] (Other than the disadvantage for git users.) [00:27:21] I am merely complaining about copy pasting though and would like the inclusion of OO* libs to have a bit more consensus [00:27:23] (03Merged) 10jenkins-bot: Increased the number of rows in AbuseFilter's Filter testing textarea [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/106891 (owner: 10Anjanasasindran123) [00:27:33] parent5446: People need to type "git checkout master && git pull && git submodule update" instead of "git checkout master && git pull" [00:27:40] parent5446: some people do not know how to use git submodules :D [00:27:54] parent5446: And "git clone … && git submodule --init" instead of "git clone …". [00:27:57] (03CR) 10Siebrand: "I only just now spot that a release notes entry is missing." [core] - 10https://gerrit.wikimedia.org/r/105871 (owner: 10Chad) [00:28:39] OK so in the end it's an experience problem, not a functionality problem [00:28:42] (03CR) 10Hoo man: [C: 04-1] "needs a rebase" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/106699 (owner: 1001tonythomas) [00:28:43] Just wanted to clarify that [00:28:59] lol, that should be a propaganda type post [00:29:21] git sudmodules are reallllly annoying to use to me [00:29:25] "everytime you feel like fixing something, kill a global state variable" [00:29:29] sub-* [00:29:29] parent5446: Right now OOjs and OOjs-UI are built and the distribution is copied; as a submodule we'd probably need to work out some magic way to reach down just into the dist/ directory. [00:30:00] every time you feel like killing a global, replace it with a camelcase class hierarchy that consists of the config var name followed by 'Context' [00:30:14] Built? Is the source for building it in core? [00:30:34] parent5446: Of course not, it's in the repo in Gruntfile.js. [00:30:57] (03CR) 10Hoo man: [C: 032] "Looks good :) Thanks for the patch" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/106885 (owner: 10Amruthasangeeth) [00:30:58] parent5446: Checkout oojs/core.git, run grunt, find in dist/ some built files, done. [00:31:02] (03Merged) 10jenkins-bot: Increased the number of rows of AbuseFilter's Examine Past diffs table [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/106885 (owner: 10Amruthasangeeth) [00:31:06] <^d> Protip: if you're wanting to swap out a $wgTitle, RequestContext::getMain()->getTitle() is not really a different title ;-) [00:31:21] <^d> It's just shifting blame. [00:31:36] :( [00:31:40] and I would much prefer rely on $wgTitle [00:31:56] ^d: better $this->getTitle() at least, you can have different contexts live in the system [00:32:00] never use a global context :D [00:32:04] <^d> Indeed. [00:32:04] after all, globals are part of PHP and attempting to make it more java like with single ton instead does not solve any probeem [00:32:15] <^d> brion: Try to use the best available title around you. [00:32:19] James_f: I'm a little confused. Is OOJS *anywhere* in core right now? [00:32:27] parent5446: Yes. [00:32:31] if you can't use the title object you love, love the one you're with [00:32:41] Where? [00:32:48] i gotta read up on OOJS :D [00:32:56] brion: My thoughts exactly [00:32:59] <^d> brion: Unless you've only got $wgTitle. Then there's no love. [00:33:03] <^d> :) [00:33:07] ^d: only hate. pure hate. [00:33:10] parent5446: resources/oojs [00:33:20] parent5446: As of wmf4 or something. [00:33:28] O_0. JS! [00:33:38] Oooooooooooooooooooooh [00:33:40] <^d> brion: `ack '\$wgTitle->'` has been my tool to find evil things ;-) [00:33:41] I'm really stupid [00:33:42] brion, parent5446: Eat dinner with RoanKattouw_away and Krinkle and they'll be happy to talk about it. :-) [00:33:48] grep is a wonderful thing [00:33:49] I did not realize you were adding Oojs UI [00:33:57] I am having trouble including a JS file in VectorBeta. I am trying to add it to $wgResourceModules, but it doesn't get loaded - http://hastebin.com/hihepahohi.coffee [00:33:59] parent5446: Oh, c'mon. Don't judge yourself that harshly. [00:34:00] <^d> ebernhardson: ack is better than grep :) [00:34:02] Also, I don't understand why it doesn't say $wgResourceModules['ext.VectorBeta'] = … as it does in all the documentation that I've read. [00:34:07] <^d> siebrand: oo(man), js [00:34:08] parent5446: We can do that for you perfectly fine. [00:34:09] ^d: well, it was ack-grep, but thats implied :) [00:34:12] parent5446: Yeah, sorry. [00:34:13] anyway we are going to need a TitleValueFormatter( RequestContext::getMain(), TitleValue::varyingSingleton( 'User:Hashar' ) )->toText() ; [00:34:13] :P [00:34:29] parent5446: Bit confusing for OOjs-UI to go into the resources/oojs directory, perhaps. [00:34:35] parent5446: Thought it's similar to jQuery. [00:34:57] Nah I just didn't notice the file names [00:35:09] * ^d moves all of ./resources to a submodule [00:35:16] <^d> (I don't use resources, it wastes space!) [00:35:20] we are more or like supposed to put third party libs in includes/lib [00:35:20] though for javascript that should probably be resources/lib :D [00:35:32] but we don't do that for query [00:35:33] jquery [00:36:00] hashar: there's an RFC for that [00:36:06] ^d: Ha. [00:36:09] about separating core files and third-party libs [00:36:19] That's my RFC! :) [00:36:20] (and formerly-core-now-third-party libs) [00:36:24] I would really love to just kill sidebar out of mediawiki namespace and into a json-style config namespace [00:36:24] Oh wait nevermind [00:36:25] Is the RfC on the table for discussion? [00:36:25] <^d> James_F: Delete all the files you don't need [00:36:28] Mine is related [00:36:31] i think it's daniel friesen's [00:36:33] <^d> The new way of making MW light and mean! [00:36:39] (i poked it a bit too) [00:36:42] ^d: Who needs MessagesFr.php? :-) [00:36:42] Yeah it is. My RFC is the opposite [00:36:45] And it'd be cool if we could do that for very high level globals (e.g. things like $wgEditis) [00:36:55] <^d> James_F: Only one I need is MessagesEn! [00:37:07] ^d: And MessagesQqq! [00:37:09] https://www.mediawiki.org/wiki/Requests_for_comment/Isolate_custom_jQuery_libraries [00:37:11] Hmm I need MessagesSr.php to test language converter [00:37:16] These days I only use index.php [00:37:17] <^d> James_F: Why would I need qqq? I'm not translating! [00:37:17] otherwise, agree :) [00:37:20] James_F: I do use MessagesFr.php with $rtl = true; Very handy since I can read french LTR [00:37:29] also https://www.mediawiki.org/wiki/Talk:Requests_for_comment/Isolate_custom_jQuery_libraries#Slightly_different_directory_layout_proposal_36058 [00:37:31] and RTL [00:37:31] hashar: I like en_rtl personally. [00:37:38] <^d> oh man en_rtl [00:37:52] But it's not available in production(?). [00:37:54] wonder whether I can mw is smart enough to recognize 'fr_rtl' [00:38:23] ?uselang=en-rtl doesn't work :( [00:38:30] bawolff: Not in prod. [00:38:42] it should be a variant [00:38:45] like pig latin [00:38:47] (patch pending) [00:38:50] pig latin ???? [00:39:02] MatmaRex: Srsly? [00:39:06] liangent and i have a pending patch to add a pig latin english variant to mediawiki, yes [00:39:12] (disabled by default) [00:39:16] crazy [00:39:19] but it fucks up preprocessor [00:39:25] and tests fail :( [00:39:33] https://gerrit.wikimedia.org/r/#/c/72053/ [00:39:36] Hmm. [00:39:38] "New language variant 'en-x-piglatin' for easier variant testing" [00:39:47] If we did something like $conf->get( 'wgFoo' ); it would give us options [00:39:48] cscott was looking into that a few weeks ago [00:39:55] for later [00:39:57] <^d> We need to bring tlh back. [00:39:58] <^d> Obvs. [00:40:06] Totes. [00:40:12] bawolff: let's drop the wg [00:40:15] ^d: I had an account there [00:40:15] while we're at it [00:40:28] prefix should be mg [00:40:39] * cscott perks up [00:40:40] MatmaRex: I'd rather have $wg->get( 'foo' ); :P [00:40:53] Or, maybe, 'foo', given we don't need to namespace them if they're not globals? [00:40:57] bawolff: that's almost like wikia's $wg->Server [00:41:00] <^d> $get->my->variable( 'foo' ) [00:41:06] +1. [00:41:06] <^d> Reads like a nice sentence. [00:41:12] _get_foo() [00:41:20] with a global __call(); [00:41:21] $get->their->variable( 'foo' ) [00:41:30] ;-) [00:41:32] <^d> We could make a new megaclass called Config. [00:41:32] $get->it()? [00:41:39] <^d> For each variable, we have a new method. [00:41:44] <^d> So hundreds and hundreds of methods. [00:41:48] or we could do it namespace like: MediaWiki\Configuration::getInstance()->getFoobar(); [00:42:03] I thought we weren't using namespaces in PHP? [00:42:08] I am worried about having an explosion of config namespaces [00:42:11] <^d> James_F: I use them in Cirrus ;-) [00:42:19] ^d: Oh. Oh well. :-) [00:42:19] OH REALLY ????????????????????????? [00:42:21] Like with Zero: Schema:, etc [00:42:22] James_F: not in core afaik [00:42:26] MatmaRex: Aha. [00:42:29] We should just have configuration: [00:42:29] <^d> hashar: Yeah, I sold out. [00:42:29] hashar: Sorry. :-( [00:42:31] Wikibase uses them extensivel [00:42:32] y [00:42:34] ^d: and I thought you were strongly opposing Namespaces! [00:42:43] <^d> I did. [00:42:44] I assume hhvm works fine with namespaces, then? [00:42:44] THAT IS A REVOLUTION !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! [00:42:46] except for maybe campaign, which makes sense to have its own namespace [00:42:50] <^d> James_F: Yeah long since fixed. [00:42:50] i'd prefer to pass a global context object around so we can handle multiple wikis in one process (for occasional interwiki things) [00:42:55] * hashar invokes Jeroen  [00:42:55] ^d: Aha. Good. [00:43:02] let me log it [00:43:06] cscott: https://gerrit.wikimedia.org/r/#/c/72053/ [00:43:09] having a config singleton is just a slightly better interface on global vars [00:43:09] <^d> James_F: Only major syntax thing that's missing is finally support, since that's very new. [00:43:12] !log Chad now accepting PHP namespaces [00:43:13] cscott: the pig latin thing [00:43:19] brion: True. [00:43:24] cscott: language conversion messing up preprocessor [00:43:33] variant conversion* [00:43:33] brion: So $get->our->variable( 'foo' ) [00:43:33] brion: better being "more like Java evil over engineering" ? [00:43:34] of course doing multiple things in one php process is a recipe for danger ;) [00:43:40] ;-) [00:43:55] <^d> Tim mentioned MW 2.0 earlier ;-) [00:44:01] <^d> Maybe it's time for a TOTAL REWRITE [00:44:01] Woo-hoo. [00:44:04] (i actually had good luck at StatusNet with switching global configurations within one process to handle background jobs) [00:44:04] In Node! [00:44:11] <^d> James_F: You trying to make me quit? [00:44:14] python / Django [00:44:15] ^d: Yes! [00:44:17] (that had configs in a database/array hybrid) [00:44:19] Ooh, Django. [00:44:26] <^d> Unchained? [00:44:27] so i just had to swap out one global array :D [00:44:30] Absolutely. [00:44:41] anyway MW 2.0 will just be a very thin layer between the javascript executing in the client and all the javascript backend services [00:44:57] so it is probably going to end up being only a thousand of lines and we could even get several mediawiki 2.0 [00:45:03] yeah, fixing the interaction of the language converter and the preprocessor is still on my todo list [00:45:06] or even ship it in several languages [00:45:08] !2.0 [00:45:09] Not gonna happen in your lifetime :) In the meantime, here's a wishlist: http://www.mediawiki.org/wiki/Project:2.0 [00:45:19] subnamespsaces :D [00:45:28] MatmaRex: thx [00:45:40] yw [00:45:42] MatmaRex: it's scheduled for "just as soon as i fix the remaining image bugs in VE and Parsoid" [00:45:51] cscott: yay [00:46:04] cscott: So… five years' time? ;-) [00:46:07] A search.wikipedia.org would be awesome [00:46:09] [00:46:12] this year [00:46:15] would be nice browser homepage [00:46:23] <^d> I want search.wm.o [00:46:24] it's also on the critical path for zhwiki support for the new pdf backend [00:46:26] hashar: .wikimedia.org? [00:46:30] <^d> Rather than it being for the stupid apple gateway. [00:46:35] James_F: nobody knows wikimedia [00:46:45] <^d> search.wm.o is taken by silly applez :( [00:46:47] hashar: But we'd want to show up media, sources, etc. [00:46:53] James_F: WikiPedia is a muchhhh stronger brand. You could still have it search commons / wikisource etc [00:46:54] (03CR) 10Hoo man: "Still interested in doing this? Needs coordination with whoever used the old format (mobile and VE probably)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/80137 (owner: 10Werdna) [00:47:02] hashar: Or just 301 it. [00:47:15] <^d> Note to self: figure out who to bug about getting search.wm.o [00:47:17] <^d> I want. [00:47:18] James_F: anyway the domain is irrelevant. Having a nice and easy search page would be very nice [00:47:24] hashar: Agreed. [00:47:24] yeah i forget why apple didn't just want to use opensearch [00:47:27] lot of people are asking me about it [00:47:30] their ways are mysterious [00:47:31] <^d> brion: Because apple. [00:47:31] @seen anomie [00:47:32] Technical_13: Last time I saw anomie they were quitting the network with reason: Quit: ... N/A at 1/23/2014 10:57:14 PM (1h50m17s ago) [00:47:38] <^d> James_F, hashar: On my idea list. [00:47:40] <^d> No time yet. [00:47:43] <^d> But would like to do. [00:47:43] and now that we have elastic search, we can probably write a thin dedicated app on top of ES to let people search it [00:47:48] (03CR) 10Siebrand: [C: 032] Create ChangesListSpecialPage as a base class for Watchlist and RC [core] - 10https://gerrit.wikimedia.org/r/102458 (owner: 10Bartosz Dziewoński) [00:47:48] <^d> Ewwww [00:47:49] <^d> No [00:48:00] <^d> hashar: Letting people have direct query access to elastic is dangerous! [00:48:03] <^d> ;-) [00:48:03] siebrand, MatmaRex: Yay. [00:48:36] whee [00:48:36] ^d: might want to harness the queries to prevent them from killing ES :D [00:48:49] Can I get one of you fine developers to deploy or discuss my suggested solution to... [00:48:50] <^d> Anyway, lots of ideas. [00:48:56] <^d> Running out of energy today though. [00:48:59] !b 59200 [00:48:59] https://bugzilla.wikimedia.org/59200 [00:48:59] <^d> Wizard needs food. [00:49:30] Technical_13: tl;dr :P [00:49:46] :p [00:50:11] Technical_13: most of us are attending a conference right now. So we have little bandwidth available this week [00:50:13] !workforus [00:50:14] sorry :'( [00:50:31] Where is the work for us link? [00:50:53] ok my new strategy: hire engineers from the FUTURE who can use hindsight to make us do stuff right the first time [00:51:08] (03Merged) 10jenkins-bot: Create ChangesListSpecialPage as a base class for Watchlist and RC [core] - 10https://gerrit.wikimedia.org/r/102458 (owner: 10Bartosz Dziewoński) [00:51:13] <^d> brion: I've been saying that for ages. [00:51:19] lol [00:51:24] * Technical_13 supports the proposal. [00:51:28] PASSED [00:51:29] Technical_13: [[wmf:jobs]] [00:51:30] <^d> Or, build a time machine so we can go back and whack 5-year-ago brion/Tim/others. [00:51:31] (03CR) 10Siebrand: [C: 032] Changes list legend modules cleanup [core] - 10https://gerrit.wikimedia.org/r/103197 (owner: 10Bartosz Dziewoński) [00:51:31] <^d> :) [00:51:37] brion: :-P [00:51:38] @link [00:51:38] https://wikimediafoundation.org/wiki/jobs [00:51:48] ^d: 5 year ago? oh no go farther [00:52:03] some of these bad decisions go back to lee when me & tim were mere minions :D [00:52:07] '02 and '03 baby [00:52:13] brion: Excuses, excuses. :-) [00:52:22] !workforus is https://wikimediafoundation.org/wiki/Jobs [00:52:22] Key was added [00:52:26] ^d: Err, what would you do with search.wm.o? [00:52:35] <^d> Cool search stuff [00:52:40] We have the www portals. [00:52:50] ^d: http://www.wikipedia.org/ <- but make it not look like crap? [00:52:55] <^d> :) [00:53:06] ^d: I also disagree, BTW. WMF needs should be a superset of MW but we can't have WMF drive needs exclusively. What about Wikia, etc.? [00:53:12] brion: That's award-winning design! [00:53:13] (03CR) 10Siebrand: [C: 032] ChangesListSpecialPage and subclasses: Reorder functions [core] - 10https://gerrit.wikimedia.org/r/103200 (owner: 10Bartosz Dziewoński) [00:53:17] :) [00:53:18] People really like the top-half. [00:53:23] The books are atrocious. [00:53:29] Technical_13: is there a way to get the bot to @link automatically? [00:53:30] <^d> I only ever end up on the www portals by accident [00:53:31] <^d> ;-) [00:53:32] it gets a little eye-glazing in the 200-language list tho yeah [00:53:38] <^d> James_F: An argument for another day :) [00:53:38] and iirc it doesn't do typeahead suggestions [00:53:41] @linkie-on [00:53:41] Links will be automatically translated in this channel now [00:53:44] we could run a design context to replace the www.wikipedia.org page [00:53:44] ^d: :-) [00:53:46] <^d> Preferably when I've had several beers. [00:53:50] oh no that got in good [00:53:52] It has autocomplete/search suggestions. [00:53:54] ^d: So… in three hours' time? [00:54:17] MatmaRex: [[meta:Wm-bot]] [00:54:17] https://meta.wikimedia.org/wiki/Wm-bot [00:54:17] <^d> I plan on being on my couch and not moving in 3 hours time. [00:54:29] tldr [00:54:29] (03PS7) 10Gergő Tisza: WIP Trying to install PIL [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109080 (owner: 10Zfilipin) [00:54:30] [[o really]] [00:54:30] http://enwp.org/o_really [00:54:34] also, i'm not admin [00:54:42] personally i'm more concerned by the invisibility of the community [00:54:44] yay introverts at conferences in our home towns [00:54:49] we don't go out and par-ty [00:54:50] also, @link isn't even mentioned there [00:54:51] we sleep :P [00:54:58] [[mw:hello]] [00:54:58] https://www.mediawiki.org/wiki/hello [00:55:03] Interesting. [00:55:06] when i hit a wp site i'd like to immediately see the community of editors behind the page in some way [00:55:19] avatars. [00:55:25] (03Merged) 10jenkins-bot: Changes list legend modules cleanup [core] - 10https://gerrit.wikimedia.org/r/103197 (owner: 10Bartosz Dziewoński) [00:55:25] A wordpress site? [00:55:28] rotating 3d avatars. [00:55:30] cscott: Articles are unsigned. And people don't visit an article to see the authors. [00:55:33] and be able to ask questions, etc, and feel like it's *people* behind it [00:55:36] They care about the content. [00:55:37] brion: you are evil [00:55:40] :D [00:55:46] Gloria: yeah, that's because we never show them the people [00:55:48] can i port my Mii from my Wii? [00:55:56] scaryyyyy [00:55:57] <^d> brion likes [00:55:58] and then no one edits the articles, because some invisible people are responsible for that [00:56:01] <^d> Just ask him about the fundraiser. [00:56:06] ^d: we only did that the one time [00:56:08] then commons folks will delete your avatar because they are non-free ! [00:56:09] (03PS8) 10Gergő Tisza: WIP Trying to install PIL [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109080 (owner: 10Zfilipin) [00:56:13] (03Merged) 10jenkins-bot: ChangesListSpecialPage and subclasses: Reorder functions [core] - 10https://gerrit.wikimedia.org/r/103200 (owner: 10Bartosz Dziewoński) [00:56:14] cscott: No one edits the articles? That's an interesting theory. ;-) [00:56:14] <^d> brion: And you LOVED it [00:56:16] and i included a disclaimer that it was satan's fault [00:56:16] let's just make a second-life like interface for wikis. to find an article you have to walk through a huge library in 3d and find the right book [00:56:21] Gloria: the stats back me up [00:56:23] complete with disgruntled librarians [00:56:24] It happens to be demonstrably untrue. [00:56:33] Gloria: i think the facts are on my side [00:56:36] gi11es: +1 [00:56:48] wikipedia RPG [00:56:49] cscott: https://en.wikipedia.org/wiki/Special:RecentChanges [00:56:50] (03PS5) 10PleaseStand: Rename RedirectSpecialPage subclasses [core] - 10https://gerrit.wikimedia.org/r/106888 (owner: 10Bartosz Dziewoński) [00:56:52] People are editing. [00:57:01] Several hundred thousand times per day. [00:57:09] "I'll give you the article on Dogsledding, if you can find who stole my rubies!" [00:57:13] <^d> gi11es: Luckily we've got a former Linden person with us :) [00:57:16] somebody please cite the recent statistics for # of active editors on wikipedia for me. [00:57:33] i'm chatting over dinner, and i don't care enough about the Internets Being Wrong to look up the citations right now [00:57:39] Facts? Someone else brought the facts, I hope! [00:57:58] Gloria: Be nice. You know the data better than that. [00:57:58] <^d> Facts are for people who don't use persuasive enough language ;-) [00:58:08] ask siri [00:58:10] James_F: It's disputed data. [00:58:16] try http://techland.time.com/2013/10/25/wikipedias-editor-problem-explained/ [00:58:18] editing conflicts would be settled with a combat mode [00:58:18] Gloria: By whom? [00:58:30] James_F: Marc-Andre, I think. Probably others. [00:58:43] Gloria: 'Cos it's the very first I've heard that rational people dispute the data (as opposed to the interpretation). [00:58:43] wmf believes the statistics [00:58:45] James_F: Manufacturing a crisis benefits certain employees. [00:59:04] anyway, i'm not really hetted up for a whole flame war on this [00:59:04] <^d> cscott: I dislike the phrase "wmf does [foo]" [00:59:07] Gloria: Don't call people in aid of things they haven't said. [00:59:09] <^d> As if we're all 1 giant person [00:59:12] <^d> And share the same thoughts. [00:59:21] ^d: you didn't go to the orientation session did you [00:59:24] we'll fix that [00:59:30] * brion gets the brainslugs [00:59:31] James_F: He's directly disputed the claim that "Wikipedia is dying!!!". [00:59:34] Just recently, I think. [00:59:40] ^d: the last allhands meeting contained extensive focus on this. to the extend that it is possible to say that "wmf" has an opinion, it was expressed there. without audible dissent. [00:59:42] @configure default-link-wiki=mw [00:59:42] Value mw was stored into default-link-wiki to config [00:59:47] Because of tools like AbuseFilter, etc. [00:59:54] that might be more appropriate for this channel. [00:59:56] The rate of editing can decrease without, y'know, death. [01:00:07] Gloria: Well done for failing to parse my statement. :-) [01:00:14] Or it can increase without, y'know, that being a good thing. [01:00:15] the latest graph is https://commons.wikimedia.org/wiki/File:Active_Editors.png [01:00:15] *at any rate* i was just proposing an alternative focus for the site's web design. [01:00:15] [[Hello]] [01:00:15] https://www.mediawiki.org/wiki/Hello [01:00:21] <^d> brion: I'll never drink your wiki kool-aid! [01:00:22] James_F|Away: SPEAK AMERICAN. [01:00:39] quiddity: yes, that's pretty convincing. [01:00:40] ^d: it's spiked with vodka [01:00:46] cscott: https://www.mediawiki.org/wiki/Winter [01:01:06] i was making a web design point, which is just that our current design focuses on content (as Gloria noted), not people [01:01:20] i believe it is possible to design the site with a different focus. and i think that's worth exploring. [01:01:28] * cscott goes back to dinner [01:02:06] (03PS1) 10TheDJ: Conditionally load jquery.ui.dialog for Scribuntu errors [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/109262 [01:02:36] http://www.mediawiki.org/wiki/Extension:TogetherJS [01:02:46] if we're passing around [[mw:]] links [01:02:46] https://www.mediawiki.org/wiki/ [01:04:38] (03CR) 10PleaseStand: "Rebased on top of I7be2352f so tests pass." [core] - 10https://gerrit.wikimedia.org/r/106888 (owner: 10Bartosz Dziewoński) [01:05:05] * cscott just realized MZMcBride's new nick [01:05:09] (03PS9) 10Gergő Tisza: WIP Trying to install PIL [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109080 (owner: 10Zfilipin) [01:05:35] (03CR) 10Bartosz Dziewoński: [C: 031] "I'm afraid to just merge this, but I like it." [core] - 10https://gerrit.wikimedia.org/r/109239 (owner: 10PleaseStand) [01:07:55] MatmaRex: [[User:Technical 13]] modified [[Wm-bot]] ( /* @link */ All the details... ) ▶ https://meta.wikimedia.org/w/index.php?diff=7207250 (tl;dr btw) [01:07:55] https://www.mediawiki.org/wiki/User:Technical_13 https://www.mediawiki.org/wiki/Wm-bot [01:09:13] @trusted [01:09:13] I trust: petan|wk.*wikimedia/Petrb (2admin), .*@mediawiki/Krinkle (2admin), .*@wikimedia/Krinkle (2admin), .*@wikimedia/.* (2trusted), .*@wikipedia/.* (2trusted), .*@mediawiki/..* (2trusted), .*@wikipedia/MZMcBride (2admin), .*@wikinews/bawolff (2admin), .*@wikipedia/matma-rex (2admin), .*@wikimedia/qchris (2trusted), [01:09:24] am i admin now? woot [01:09:48] hmmm, let's try this and i'll kill it if somebody's annoyed [01:09:50] (03CR) 10Gergő Tisza: "Tested on cloudbees, the current version works." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109080 (owner: 10Zfilipin) [01:09:51] @linkie-on [01:09:51] Links are already automatically translated in this channel [01:10:00] since when. [01:10:02] [[cat]] [01:10:02] https://www.mediawiki.org/wiki/cat [01:10:08] alrighty [01:10:09] thanks [01:10:45] [[meta:Wm-bot#.40configure]] if you want to change the default wiki to meta or something... [01:10:45] https://meta.wikimedia.org/wiki/Wm-bot#.40configure [01:11:03] @whoami [01:11:03] You are root identified by name .*@wikimedia/Technical-13 [01:11:21] mw.org's probably fine [01:14:39] (03CR) 10Gergő Tisza: "Note that the subdir is called 'tests' now." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109080 (owner: 10Zfilipin) [01:23:12] (03CR) 10Aarcos: [C: 031] "Thanx for testing Gergo !" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109080 (owner: 10Zfilipin) [01:25:19] (03PS10) 10Gergő Tisza: WIP Trying to install PIL [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109080 (owner: 10Zfilipin) [01:25:44] (03CR) 10Gergő Tisza: [C: 032] "Merging based on Aarcos' +1." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109080 (owner: 10Zfilipin) [01:25:51] (03Merged) 10jenkins-bot: Change requirements.txt so that PIL actually installs on Cloudbees [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109080 (owner: 10Zfilipin) [01:29:05] marktraceur: I am having trouble including a JS file in VectorBeta. I am trying to add it to $wgResourceModules, but it doesn't get loaded - http://hastebin.com/hihepahohi.coffee [01:31:13] (03PS2) 10Inchikutty: Adding Leaflet scripts to UploadWizard(WIP) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 [01:36:33] (03PS7) 10Bartosz Dziewoński: Move toctoggle from mediawiki.util.js to separate file mediawiki.toc.js [core] - 10https://gerrit.wikimedia.org/r/106132 (owner: 10Gerrit Patch Uploader) [01:36:48] (03CR) 10Bartosz Dziewoński: [C: 032] "Rebased." [core] - 10https://gerrit.wikimedia.org/r/106132 (owner: 10Gerrit Patch Uploader) [01:38:54] (03CR) 10Bartosz Dziewoński: Check for missing timestamp using JavaScript (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97480 (owner: 10Legoktm) [01:40:27] (03CR) 10jenkins-bot: [V: 04-1] Move toctoggle from mediawiki.util.js to separate file mediawiki.toc.js [core] - 10https://gerrit.wikimedia.org/r/106132 (owner: 10Gerrit Patch Uploader) [01:41:33] wtf [01:42:19] (03CR) 10Bartosz Dziewoński: "Fomafix, wanna look into the tests?" [core] - 10https://gerrit.wikimedia.org/r/106132 (owner: 10Gerrit Patch Uploader) [01:45:22] (03PS1) 10Inchikutty: Embedding leaflet map based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [01:45:52] (03PS1) 10Aarcos: Change to directory of the script so it can be launch from anywhere. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109265 [01:45:55] (03CR) 10jenkins-bot: [V: 04-1] Change to directory of the script so it can be launch from anywhere. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109265 (owner: 10Aarcos) [01:47:26] (03PS2) 10Gergő Tisza: Change to directory of the script so it can be launch from anywhere. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109265 (owner: 10Aarcos) [01:47:46] (03PS4) 10Anomie: API: Fix setnotificationtimestamp with no pages given [core] - 10https://gerrit.wikimedia.org/r/62229 [01:50:41] (03PS1) 10Legoktm: Config: Add Config and GlobalConfig classes [core] - 10https://gerrit.wikimedia.org/r/109266 [01:57:06] (03CR) 10Bartosz Dziewoński: [C: 032] Remove TODO for use of TRUNCATE and replace with comment [core] - 10https://gerrit.wikimedia.org/r/108960 (owner: 10Umherirrender) [01:58:36] (03CR) 10Bartosz Dziewoński: [C: 032] Do not load special pages in WatchedItem::load [core] - 10https://gerrit.wikimedia.org/r/104024 (owner: 10Umherirrender) [02:00:31] (03Merged) 10jenkins-bot: Remove TODO for use of TRUNCATE and replace with comment [core] - 10https://gerrit.wikimedia.org/r/108960 (owner: 10Umherirrender) [02:01:29] (03Merged) 10jenkins-bot: Do not load special pages in WatchedItem::load [core] - 10https://gerrit.wikimedia.org/r/104024 (owner: 10Umherirrender) [02:01:46] (03CR) 10Gergő Tisza: [C: 032] Change to directory of the script so it can be launch from anywhere. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109265 (owner: 10Aarcos) [02:02:23] (03Merged) 10jenkins-bot: Change to directory of the script so it can be launch from anywhere. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109265 (owner: 10Aarcos) [02:08:51] !log springle synchronized wmf-config/db-eqiad.php 'depool db1010 for schema changes' [02:12:22] (03CR) 10Parent5446: [C: 032] AutoLoaderTest: Add support for class aliases [core] - 10https://gerrit.wikimedia.org/r/109239 (owner: 10PleaseStand) [02:15:42] (03Merged) 10jenkins-bot: AutoLoaderTest: Add support for class aliases [core] - 10https://gerrit.wikimedia.org/r/109239 (owner: 10PleaseStand) [02:18:35] !log LocalisationUpdate completed (1.23wmf10) at 2014-01-24 02:18:35+00:00 [02:31:07] (03CR) 10Hydriz: "> Why are you adding a global?" [core] - 10https://gerrit.wikimedia.org/r/108487 (owner: 10Hydriz) [02:31:28] !log springle synchronized wmf-config/db-eqiad.php 'depool db1018 for schema changes' [02:34:30] !log LocalisationUpdate completed (1.23wmf11) at 2014-01-24 02:34:30+00:00 [02:41:19] (03PS3) 10Hydriz: Add the ability to export pages within a prefix. [core] - 10https://gerrit.wikimedia.org/r/108487 [02:41:43] (03PS3) 10Inchikutty: Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 [02:49:41] (03PS2) 10Inchikutty: Embedding leaflet map based on OSM data to UploadWizard(WIP) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [02:51:33] (03PS4) 10Inchikutty: Adding Leaflet scripts to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109063 [02:52:14] (03PS3) 10Inchikutty: Embedding leaflet map based on OSM data to UploadWizard(WIP) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [03:00:38] (03CR) 10Daniel Kinzler: [C: 04-1] Initial implementation of the JSON configuration store. (037 comments) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [03:01:30] (03PS6) 10Spage: [WIP] Update login and HTMLForm to new design [core] - 10https://gerrit.wikimedia.org/r/104011 [03:02:40] !log LocalisationUpdate ResourceLoader cache refresh completed at 2014-01-24 03:02:40+00:00 [03:02:49] (03PS4) 10Inchikutty: Embedding leaflet map based on OSM data to UploadWizard(WIP) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [03:03:32] (03PS1) 10Reedy: WIP: Switch API to use Config classes [core] - 10https://gerrit.wikimedia.org/r/109271 [03:05:33] (03CR) 10jenkins-bot: [V: 04-1] WIP: Switch API to use Config classes [core] - 10https://gerrit.wikimedia.org/r/109271 (owner: 10Reedy) [03:09:44] (03PS1) 10Dan-nl: updating extension version [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/109272 [03:10:57] (03PS2) 10Dan-nl: updating extension version from 0.1.0 to 0.1.1 [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/109272 [03:11:38] (03Abandoned) 10Dan-nl: updating extension version from 0.1.0 to 0.1.1 [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/109272 (owner: 10Dan-nl) [03:18:32] (03PS1) 10Dan-nl: updating version nr from 0.1.0 to 0.1.1 [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/109273 [03:19:11] (03CR) 10Dan-nl: [C: 032 V: 032] updating version nr from 0.1.0 to 0.1.1 [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/109273 (owner: 10Dan-nl) [03:26:51] (03PS5) 10Inchikutty: Embedding leaflet map based on OSM data to UploadWizard(WIP) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [03:30:32] (03PS3) 10Skizzerz: Add in preliminary MS SQL support [core] - 10https://gerrit.wikimedia.org/r/105138 [03:31:18] (03CR) 10jenkins-bot: [V: 04-1] Add in preliminary MS SQL support [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz) [03:32:05] (03CR) 10Skizzerz: "patch set 3 includes fixes for pretty much everything mentioned earlier in the comments. I'll be doing a rebase with patch set 4 and fixin" [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz) [04:00:44] (03PS4) 10Skizzerz: Add in preliminary MS SQL support [core] - 10https://gerrit.wikimedia.org/r/105138 [04:13:15] (03PS5) 10Skizzerz: Add in preliminary MS SQL support [core] - 10https://gerrit.wikimedia.org/r/105138 [04:20:14] (03CR) 10Skizzerz: "Issues highlighted in https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs-lenient-HEAD/6762/console have been fixed for the next" [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz) [04:25:01] (03CR) 10Bartosz Dziewoński: "Let's kill the wg. Document Config#get as accepting 'foo' instead of 'wgFoo' and prepend/uppercase-first as appropriate." [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm) [05:01:35] (03PS3) 10Pastakhov: Refactoring for the extension PHP Tags [extensions/Foxway] (PhpTags) - 10https://gerrit.wikimedia.org/r/109043 [05:08:33] (03PS1) 10Shirayuki: i18n: fix typo [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109276 [05:54:17] (03CR) 10Reedy: "Not everything is wg prefixed" [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm) [06:05:13] MatmaRex, Reedy: I like function get( $name, $prefix = 'wg' ) [06:05:50] yeah, that sounds nice to me oto [06:05:52] too* [06:06:30] get( 'IP', '' ); [06:06:31] I'm not sure about the uppercasing the first letter though [06:07:58] both ways would probably be fine [06:08:08] uppercasing might prove troublesome if we have different prefixes [06:08:25] Yeah [06:08:28] We're not consistent [06:14:49] * legoktm pokes gerrit [06:16:34] wtf [06:16:48] it's like stuck [06:18:46] git push to gerrit is not working [06:18:47] its stuck [06:19:26] (03PS2) 10Reedy: Switch API to use Config classes [core] - 10https://gerrit.wikimedia.org/r/109271 [06:19:29] WFM [06:19:41] legoktm: That's the API migrated [06:19:42] :D [06:19:53] woo :DDD [06:20:09] git push gerrit HEAD:refs/for/master <-- it's hanging [06:20:25] 36 files changed, 171 insertions(+), 236 deletions(-) [06:20:25] hmm [06:20:30] something onn my computer is downloading [06:20:46] crap hotel wifi? [06:21:31] no...I'm downloading something but I don't know what is doing the downloading [06:21:32] wtf [06:22:44] stupid mac appstore [06:22:44] lego if even Windows 8.1 shows which process, surely you must be able to do so on Linux/Mac [06:22:52] I don't want the new iTunes!!! [06:23:02] (03CR) 10jenkins-bot: [V: 04-1] Switch API to use Config classes [core] - 10https://gerrit.wikimedia.org/r/109271 (owner: 10Reedy) [06:23:06] yeah I found it [06:23:07] this is what happens when you enable autoupdating [06:23:08] it was the app store [06:23:17] i can't turn it off [06:23:19] (03CR) 10Reedy: "Uh, that was fail" [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm) [06:24:03] Reedy: $prefix = false doesn't really make sense to me as a default [06:24:14] right [06:24:19] why would anyone use ->get( 'Sitename', 'wg' ) instead of ->get( 'Sitename' ) [06:24:21] er [06:24:23] but having it as true and then using it as such is wrong [06:24:26] ->get( 'wgSitename' ) [06:24:48] public function get( $name, $prefix = 'wg' ) { [06:25:02] you don't like that? [06:25:15] I would have pushed that to gerrit by now except my computer is being super stupid [06:25:17] No, that was a correction [06:25:21] ok [06:26:01] * legoktm tries git review [06:26:03] public function get( $name, $addPrefix = true ) { [06:26:03] if ( $addPrefix ) { [06:26:03] return $GLOBALS["wg$name"]; [06:26:03] } [06:26:03] return $GLOBALS[$name]; [06:26:05] } [06:26:07] There's numerous versions [06:28:39] this is so stupid >.> [06:29:56] (03PS1) 10Reedy: Fix testValidyntax to testValidSyntax [core] - 10https://gerrit.wikimedia.org/r/109278 [06:30:05] * Jasper_Deng doesn't like to use strings like [22:26:11] Reedy return $GLOBALS["wg$name"]; without using the concatenation operator (+) [06:30:44] (03CR) 10Bartosz Dziewoński: [C: 032] Fix testValidyntax to testValidSyntax [core] - 10https://gerrit.wikimedia.org/r/109278 (owner: 10Reedy) [06:31:12] Jasper_Deng: php uses . for string concatenation [06:31:49] * Jasper_Deng thought you could use +, still "wg$string"... doesn't make much sense [06:32:16] (I mean it's valid but without . it looks strange) [06:33:57] (03Merged) 10jenkins-bot: Fix testValidyntax to testValidSyntax [core] - 10https://gerrit.wikimedia.org/r/109278 (owner: 10Reedy) [06:34:56] (03PS6) 10Inchikutty: Embedding static and leaflet maps based on OSM data to UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109263 [06:35:55] (03PS2) 10Legoktm: Config: Add Config and GlobalConfig classes [core] - 10https://gerrit.wikimedia.org/r/109266 [06:36:06] it worked!!! [06:37:24] * Jasper_Deng wonders how lego comes up with ideas like that one [06:37:31] like, whose idea was it to make config classes? [06:37:33] pretty neat [06:37:36] (03PS3) 10Reedy: Switch API to use Config classes [core] - 10https://gerrit.wikimedia.org/r/109271 [06:37:42] Unanimous decision today [06:38:26] yeah, I think the idea was originally in ^d's RfC [06:38:56] Reedy: did you do that manually? [06:39:36] (03PS1) 10Reedy: Remove scary isset( $GLOBALS['wgRightsCode'] ) [core] - 10https://gerrit.wikimedia.org/r/109279 [06:39:44] Find and replace [06:39:48] ah [06:40:06] well you're going to have to adapt it for the no 'wg' prefix now :/ [06:40:11] * Jasper_Deng would've thought register_globals etc. was already phased out [06:40:20] 'wg -> ' [06:40:44] !5.4 [06:40:44] Traits? In MediaWiki? Yeah right, we wish. In the mean time, make your own wish: https://www.mediawiki.org/wiki/PHP_5.4 [06:40:47] !5.5 [06:41:09] Jasper_Deng: Removed in 5.4 [06:41:17] Jasper_Deng: register_globals goes away in 5.4, but MW supports 5.3 [06:41:17] Min PHP we support is 5.3.2 [06:41:21] and most of the cluster is 5.3 [06:41:47] I thought it was gone by like 5.2... [06:42:36] (03PS4) 10Reedy: Switch API to use Config classes [core] - 10https://gerrit.wikimedia.org/r/109271 [06:42:48] http://php.net/register_globals [06:44:44] (03CR) 10jenkins-bot: [V: 04-1] Switch API to use Config classes [core] - 10https://gerrit.wikimedia.org/r/109271 (owner: 10Reedy) [06:45:09] too slow jenkins [06:45:31] (03PS5) 10Reedy: Switch API to use Config classes [core] - 10https://gerrit.wikimedia.org/r/109271 [06:47:38] (03CR) 10jenkins-bot: [V: 04-1] Switch API to use Config classes [core] - 10https://gerrit.wikimedia.org/r/109271 (owner: 10Reedy) [06:48:12] :< [06:48:34] heh [06:48:35] IP [06:48:44] Damn you :P [06:48:54] get( 'IP', '' ) [06:48:57] looks strange [06:49:18] maybe allow false there? and convert false into ''? [06:49:26] get( 'IP', false ) [06:49:32] or null, w/e [06:49:51] $prefix = $prefix ?: ''; [06:51:19] doing get ( 'Foobar', 'eg' ) looks strange too [06:51:31] get( 'egFoobar', false ) [06:52:28] because we just made the prefix a suffix :P [06:52:32] get('eg', 'Foo'); … function get( $prefix, $name = false ) { if($name == false) {$name = $prefix; $prefix = false; [06:52:44] === * [06:53:09] PHP should support margin any function parameter as optional [06:53:18] (Ruby does that, it's sometimes nice) [06:53:22] marking* [06:53:45] if you can use named parameters it's not so bad [06:54:06] get( prefix = '', name = '' ) or whatever [06:57:43] yeah it leads to disaster w/o what Reedy mentions [06:58:03] b/c you could then be inadvertently passing in something you don't think you are [06:58:53] php has some functions where it will take the parameter in any order [06:58:59] implode and explode being different? [06:59:03] Something stupid like that [06:59:57] at that point you might as well do implode( func_get_args() ) [07:00:50] heh [07:02:03] I like the current method of get( $name, $prefix = 'wg' ) tbh [07:02:20] simple for most cases, looks a bit odd for the edge cases [07:03:20] we do have to deal with wmglobal... [07:03:22] but arguably [07:03:36] That's not so much of an issue [07:03:39] I would like a simple get() [07:03:59] ofc though that would be pretty ugly [07:04:07] which is what we had originally [07:05:32] (03PS2) 10Anomie: Remove scary isset( $GLOBALS['wgRightsCode'] ) [core] - 10https://gerrit.wikimedia.org/r/109279 (owner: 10Reedy) [07:06:36] (03CR) 10Anomie: [C: 031] "Consider this a +2, unless you disagree with how I changed your commit summary." [core] - 10https://gerrit.wikimedia.org/r/109279 (owner: 10Reedy) [07:10:52] (03PS8) 10Gerrit Patch Uploader: Move toctoggle from mediawiki.util.js to separate file mediawiki.toc.js [core] - 10https://gerrit.wikimedia.org/r/106132 [07:10:54] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/106132 (owner: 10Gerrit Patch Uploader) [07:18:38] !log springle synchronized wmf-config/db-eqiad.php 'repool db1018' [07:22:17] I think port 22 here is just slow [07:22:24] opening up an sftp connection is really slow [07:23:13] my irc client seems to be having more issues [07:23:23] :/ [07:23:24] well [07:23:26] s/client/bouncer/ [07:23:41] that's on a higher port for me, so no issues [07:24:20] mines using 4242 [07:32:39] (03CR) 10AndyRussG: [C: 031] "There's a lot here and in the RfC! +1 on loads of stuff, including concurrency, data, access control, exception handling, description vers" (032 comments) [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/107307 (owner: 10Adamw) [07:39:04] hey people, https://gerrit.wikimedia.org/r/#/c/103233/ and https://gerrit.wikimedia.org/r/#/c/103239/ really want to be reviewed already [07:39:22] hi prtksxna [07:39:31] yuvipanda: o/ [07:40:09] prtksxna: heya [07:40:44] yuvipanda: Right, so you saw what I tried? [07:40:59] prtksxna: yeah, needs to be written slightly differently [07:41:00] moment [07:41:17] yuvipanda: Just point me to the documentation and I'll try to figure it out :D [07:42:26] prtksxna: look at http://hastebin.com/fehuhafawe.coffee [07:42:35] prtksxna: you pointed me to the docs I was going to point you to :P [07:43:07] Oh? [07:43:36] yuvipanda: Won't we need to put 'remoteExtPath' and 'localBasePath' in 'skins.vector.beta' as well? [07:43:50] prtksxna: oh, yeah, that too :P [07:44:09] prtksxna: so a 'module' can contain scripts & styles too. so you wanted to register a new module, as I have done [07:44:18] yuvipanda: Hm. But why can't I include the JS in skins.vector.beta? [07:44:22] and then call it [07:44:32] prtksxna: because then it gets registered, and then never added [07:44:41] prtksxna: I think they load only css from that [07:44:57] prtksxna: like, css & js have to be loaded separately, no? [07:45:00] yuvipanda: "and then call it" < from where? [07:45:01] prtksxna: wait let me clone it [07:45:06] moment [07:45:08] clongin [07:45:12] * prtksxna waits [07:48:54] prtksxna: look at VectorBeta.hooks.php [07:49:05] prtksxna: line 57 [07:49:07] that function [07:49:24] prtksxna: it is a hook (an even?) called when the Vector skin tries to figure out which styles to show [07:49:30] and they add that module if it is not present [07:49:39] as you can see it is a css specific module [07:49:58] yuvipanda: Ah! Yes! [07:50:05] prtksxna: you can read more about hooks at https://www.mediawiki.org/wiki/Manual:Hooks [07:50:33] prtksxna: so you need to hook into https://www.mediawiki.org/wiki/Manual:Hooks/BeforePageDisplay [07:50:38] yuvipanda: That explains the PS in the email [07:50:57] prtksxna: and use $out->addModules [07:51:05] you can also conditionally load that JS [07:51:15] for example if you don't want it on some pages [07:51:17] or somesuch [07:51:23] prtksxna: yeah :) [07:52:04] yuvipanda: Alright! I'll go through it :) [07:52:09] yuvipanda: Thanks! [07:52:12] prtksxna: yw :) [07:56:34] prtksxna: also, don't reuse code from Yair's gadget at all. [07:56:40] Licensing is a stupid tricky weird thingy [07:56:47] yuvipanda: Got it! Won't! [07:59:43] (03CR) 10Reedy: "For anyone else looking at this code, we were discussing whether this format for prefixing should be used." [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm) [08:13:09] (03PS1) 10Pastakhov: Fix the protocol selection for maps. it is auto. (version 0.5.2) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/109281 [08:14:01] (03CR) 10Reedy: "Another question is whether we should be renaming the "SiteConfiguration" items from the Context, rather than just replacing them" [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm) [08:15:40] (03CR) 10Reedy: "Works for me. My LocalSettings had a commented out $wgRightsCode entry in it too." [core] - 10https://gerrit.wikimedia.org/r/109279 (owner: 10Reedy) [08:23:16] (03CR) 10Pastakhov: [C: 032] Fix the protocol selection for maps. it is auto. (version 0.5.2) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/109281 (owner: 10Pastakhov) [08:23:26] (03Merged) 10jenkins-bot: Fix the protocol selection for maps. it is auto. (version 0.5.2) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/109281 (owner: 10Pastakhov) [08:36:23] (03PS9) 10Gerrit Patch Uploader: Move toctoggle from mediawiki.util.js to separate file mediawiki.toc.js [core] - 10https://gerrit.wikimedia.org/r/106132 [08:36:25] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/106132 (owner: 10Gerrit Patch Uploader) [08:53:39] (03CR) 10Physikerwelt: [C: 032] Validate TeX input for all renderers, not just texvc (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/105187 (owner: 10Physikerwelt) [09:02:07] (03PS1) 10Physikerwelt: Add compilation script for texvccheck [vagrant] - 10https://gerrit.wikimedia.org/r/109284 [09:35:35] (03PS5) 10TTO: Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 [09:36:22] (03CR) 10jenkins-bot: [V: 04-1] Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [09:46:08] (03PS6) 10TTO: Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 [09:50:50] (03CR) 10TTO: [C: 04-1] http://www.mediawiki.org --> https://www.mediawiki.org (031 comment) [core] - 10https://gerrit.wikimedia.org/r/108681 (owner: 10Ladsgroup) [09:59:35] (03PS4) 10Pastakhov: Refactoring for the extension PHP Tags [extensions/Foxway] (PhpTags) - 10https://gerrit.wikimedia.org/r/109043 [10:00:33] (03CR) 10Pastakhov: [C: 032] Refactoring for the extension PHP Tags [extensions/Foxway] (PhpTags) - 10https://gerrit.wikimedia.org/r/109043 (owner: 10Pastakhov) [10:00:40] (03CR) 10jenkins-bot: [V: 04-1] Refactoring for the extension PHP Tags [extensions/Foxway] (PhpTags) - 10https://gerrit.wikimedia.org/r/109043 (owner: 10Pastakhov) [10:53:17] (03PS4) 10Ladsgroup: http://www.mediawiki.org --> https://www.mediawiki.org [core] - 10https://gerrit.wikimedia.org/r/108681 [10:53:53] (03CR) 10Ladsgroup: "all fixed" [core] - 10https://gerrit.wikimedia.org/r/108681 (owner: 10Ladsgroup) [10:56:37] (03CR) 10Cjucovschi: [C: 031] "looks good" [vagrant] - 10https://gerrit.wikimedia.org/r/109284 (owner: 10Physikerwelt) [11:41:09] (03CR) 10Ladsgroup: http://www.mediawiki.org --> https://www.mediawiki.org (031 comment) [core] - 10https://gerrit.wikimedia.org/r/108681 (owner: 10Ladsgroup) [12:11:29] (03CR) 1001tonythomas: "@Siebrand : Umherrinder helped me restore my earlier patch set. https://gerrit.wikimedia.org/r/#/c/99171/" [core] - 10https://gerrit.wikimedia.org/r/108673 (owner: 1001tonythomas) [13:03:45] (03CR) 10Arav93: "Brian, I hope this was the change that you expected." [core] - 10https://gerrit.wikimedia.org/r/108205 (owner: 10Arav93) [13:39:53] zz_yuvipanda: Around? [13:43:30] (03PS1) 10Microchip08: Make show/hide link in RC individually localizable [core] - 10https://gerrit.wikimedia.org/r/109296 [13:44:30] (03CR) 10Microchip08: "I'm not convinced this is the best way of doing it, but I can't think of a better way." [core] - 10https://gerrit.wikimedia.org/r/109296 (owner: 10Microchip08) [14:12:03] (03PS3) 1001tonythomas: Increased the number of rows in AbuseFilter's Filter testing textarea [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/106699 [14:12:05] (03CR) 10jenkins-bot: [V: 04-1] Increased the number of rows in AbuseFilter's Filter testing textarea [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/106699 (owner: 1001tonythomas) [14:34:55] (03PS4) 1001tonythomas: Increased the number of rows in AbuseFilter's Filter testing textarea [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/106699 [15:16:28] (03CR) 10Anomie: [C: 032] API: Remove obsolete wgRightsCode from siteinfo [core] - 10https://gerrit.wikimedia.org/r/109279 (owner: 10Reedy) [15:17:21] (03CR) 10Chad: "Maybe we should add some tests too?" [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm) [15:19:50] (03Merged) 10jenkins-bot: API: Remove obsolete wgRightsCode from siteinfo [core] - 10https://gerrit.wikimedia.org/r/109279 (owner: 10Reedy) [15:22:20] ;o [15:26:24] (03CR) 10Nemo bis: "Just for curiosity, there are thousands wikis for which it's impossible to get license info from API: https://archive.org/search.php?query" [core] - 10https://gerrit.wikimedia.org/r/109279 (owner: 10Reedy) [15:30:00] Working on this bug:https://bugzilla.wikimedia.org/show_bug.cgi?id=43604 .Is it ok to remove the nova plugin? [15:31:34] (03PS1) 10Arav93: Removed swear words from core repository [core] - 10https://gerrit.wikimedia.org/r/109297 [15:32:18] (03CR) 10jenkins-bot: [V: 04-1] Removed swear words from core repository [core] - 10https://gerrit.wikimedia.org/r/109297 (owner: 10Arav93) [15:33:42] what prudish new contributors we have :D :P [15:35:01] Nemo_bis: the grep results are really great :) [15:36:42] (03CR) 10Phuedx: [C: 031] Remove Special:GettingStarted and notifications [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/106458 (owner: 10Mattflaschen) [15:40:58] tonythomas01: I guess this applies: mediawiki has been written by a biotechnologist, a cinema student, a poker player, a quantic computer doctor and others. None were PHP expert, so you can definitely help. [15:42:15] (03PS5) 10Umherirrender: Add Title::hasFragment and use it [core] - 10https://gerrit.wikimedia.org/r/104750 [15:43:05] (03Abandoned) 10Arav93: Removed swear words from core repository [core] - 10https://gerrit.wikimedia.org/r/109297 (owner: 10Arav93) [15:49:53] How can i learn more about how mediawiki works? [15:51:04] (03PS1) 10Pigpen: Latest state of development [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/109301 [15:51:09] (03PS1) 10Pigpen: Latest state of development [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/109302 [15:51:13] (03PS1) 10Pigpen: Latest state of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/109303 [15:52:55] (03PS2) 1001tonythomas: Added Link to Bugzilla Etiquette in footer [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106757 [15:54:07] (03CR) 10Pigpen: [C: 032 V: 032] "Latest changes" [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/109301 (owner: 10Pigpen) [15:54:29] (03CR) 10Pigpen: [C: 032 V: 032] "Latest changes" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/109302 (owner: 10Pigpen) [15:54:43] (03Restored) 10Arav93: Removed swear words from core repository [core] - 10https://gerrit.wikimedia.org/r/109297 (owner: 10Arav93) [15:55:01] (03CR) 10Pigpen: [C: 032 V: 032] "Latest changes" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/109303 (owner: 10Pigpen) [16:24:36] (03PS1) 10Umherirrender: Add release notes for RdfMetaData [core] - 10https://gerrit.wikimedia.org/r/109304 [16:29:05] (03PS7) 10Ottomata: Adding wikimetrics role and module [vagrant] - 10https://gerrit.wikimedia.org/r/108922 [16:39:54] (03CR) 10Parent5446: [C: 04-1] "What's the purpose of this patch?" [core] - 10https://gerrit.wikimedia.org/r/109297 (owner: 10Arav93) [16:41:14] (03PS2) 10Matthias Mullie: Alternative way of dealing with edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108635 [16:45:53] (03PS1) 10Anomie: Message for checkuser OAuth group [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/109309 [16:46:00] (03PS1) 10Matthias Mullie: Move destroy-form functionality in its own function, instead of binding cancel [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109310 [16:47:10] (03CR) 10Matthias Mullie: "How about https://gerrit.wikimedia.org/r/#/c/108635/ for improving this code?`" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 (owner: 10Matthias Mullie) [16:49:30] (03CR) 10Phuedx: [C: 04-1] "The last point in the commit message should either be made more explicit or be removed." (031 comment) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/107618 (owner: 10Mattflaschen) [16:52:18] (03CR) 10Bartosz Dziewoński: "What's stopping this from being merged to document current behavior?" [core] - 10https://gerrit.wikimedia.org/r/98119 (owner: 10Bartosz Dziewoński) [16:52:36] (03Abandoned) 10Bartosz Dziewoński: Preferences: Show search namespace options in a matrix [core] - 10https://gerrit.wikimedia.org/r/78464 (owner: 10Bartosz Dziewoński) [16:54:07] (03CR) 10Cscott: "This will need parsoid support." [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [16:55:27] (03CR) 10Cscott: "Oh, and what happens if the Poem extension is *not* uninstalled? Has that been tested? We should ensure something reasonable happens, si" [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [16:57:41] (03PS4) 10Bartosz Dziewoński: Add parser test for empty self-link with empty fragment [[#|...]] [core] - 10https://gerrit.wikimedia.org/r/98119 [16:57:41] https://www.mediawiki.org/wiki/# [16:58:33] (03CR) 10Nikerabbit: [C: 032] Add Title::hasFragment and use it [core] - 10https://gerrit.wikimedia.org/r/104750 (owner: 10Umherirrender) [17:01:38] (03Merged) 10jenkins-bot: Add Title::hasFragment and use it [core] - 10https://gerrit.wikimedia.org/r/104750 (owner: 10Umherirrender) [17:03:44] (03CR) 10Cscott: "And is 'crap' really that offensive?" [core] - 10https://gerrit.wikimedia.org/r/109297 (owner: 10Arav93) [17:06:32] (03CR) 10Cscott: "Also, the patch doesn't even apply to master. :(" [core] - 10https://gerrit.wikimedia.org/r/109297 (owner: 10Arav93) [17:09:48] (03PS3) 10Mattflaschen: Simplify the firstedit tour by removing special VE handling [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/107618 [17:10:11] (03CR) 10Mattflaschen: Simplify the firstedit tour by removing special VE handling (031 comment) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/107618 (owner: 10Mattflaschen) [17:10:15] how can i learn more about MediaWiki's functioning? [17:11:44] (03CR) 10Umherirrender: "See also Patch Set Iefc83708ccb2a427ede63f1a0ecbfe8d2f6211ea to fix the underlying problem with empty self links." [core] - 10https://gerrit.wikimedia.org/r/98119 (owner: 10Bartosz Dziewoński) [17:19:47] wm-bot, :) [17:20:49] Nemo_bis, around? [17:21:57] (03CR) 10Subramanya Sastry: [C: 04-1] "Is there a reason to use
with embedded

and
tags instead of wrapping the entire verbatim section in a

	 (03PS3) 10Umherirrender: Make a single # an invalid title in php and js [core] - 10https://gerrit.wikimedia.org/r/106561 
[17:22:27] 	 mayankmadan: sort
[17:22:40] 	 How can i get more familiar with mediawiki's functioning
[17:25:08] 	 mayankmadan: heh, easy questions always you ask :P
[17:25:34] 	 one way is to go look what the others are looking, review the others' code which is waiting for review
[17:25:51] 	 * are doing
[17:26:29] 	 (03CR) 10Anomie: [C: 04-1] Conditionally load jquery.ui.dialog for Scribuntu errors (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/109262 (owner: 10TheDJ)
[17:26:42] 	 (03PS4) 10Umherirrender: Make a single # an invalid title in php and js [core] - 10https://gerrit.wikimedia.org/r/106561 
[17:27:49] 	 (03CR) 10Umherirrender: "Patch Set 4: Use (new) Title::hasFragment in php" [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender)
[17:35:37] 	 (03PS3) 10Legoktm: Config: Add Config and GlobalConfig classes [core] - 10https://gerrit.wikimedia.org/r/109266 
[17:39:06] 	 (03Abandoned) 10Alex Monk: Removed swear words from core repository [core] - 10https://gerrit.wikimedia.org/r/109297 (owner: 10Arav93)
[17:44:19] 	 (03PS2) 10Legoktm: Conditionally load jquery.ui.dialog for Scribuntu errors [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/109262 (owner: 10TheDJ)
[17:48:05] 	 anomie: can you look at https://gerrit.wikimedia.org/r/#/c/105979/ again? nobody else seems to want to look at it
[17:48:56] 	 (03CR) 10Chad: [C: 032] Limit the project cache size. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/108883 (owner: 10Andrew Bogott)
[17:48:59] 	 (03Merged) 10jenkins-bot: Limit the project cache size. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/108883 (owner: 10Andrew Bogott)
[17:51:41] 	 jackmcbarn: Remind me next week?
[17:52:13] 	 kk
[17:53:01] 	 (03PS1) 10UltrasonicNXT: Blocked from chat [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/109315 
[17:53:43] 	 (03CR) 10UltrasonicNXT: [C: 032 V: 032] Blocked from chat [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/109315 (owner: 10UltrasonicNXT)
[17:54:06] 	 (03CR) 10Parent5446: "Reviewed as much as I could. Will try to do more later." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz)
[17:54:29] 	 (03CR) 10Umherirrender: "See also I9374eb485605c8af8d2a4d236120e97ec642d44a or linked bug 58647" [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender)
[18:00:29] 	 (03CR) 10Hoo man: [C: 04-1] Increased the number of rows in AbuseFilter's Filter testing textarea (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/106699 (owner: 1001tonythomas)
[18:01:56] 	 "the architects" still sounds weird to me :)
[18:02:18] 	 Matrix?
[18:02:25] 	 dito
[18:04:09] 	 yah
[18:04:35] 	 (03CR) 10Parent5446: "Definitely get rid of the prefix. The idea here is that we want to move away from globals, and eventually get rid of them altogether." [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm)
[18:05:08] 	 (03CR) 10Parent5446: "If necessary you can have a static mapping between config key names and their corresponding global." [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm)
[18:05:14] 	 o_0
[18:05:16] 	 :/
[18:05:17] 	 Big array is big
[18:06:05] 	 (03CR) 10Parent5446: Config: Add Config and GlobalConfig classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm)
[18:07:35] 	 (03CR) 10Reedy: "How many globals do we have in core alone? :/" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm)
[18:08:09] 	 Reedy: about 500
[18:08:46] 	 Find in DefaultSettings.php shows 1132
[18:08:49] 	 but that includes comments
[18:09:01] 	 also, someone please merge https://gerrit.wikimedia.org/r/#/c/98119/ before the naysayers reappear
[18:09:08] 	 (03CR) 10Siebrand: [C: 04-1] "Please fix the code style issues pointed out in https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs-strict-HEAD/6762/console" [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz)
[18:09:15] 	 I did a search for \n$wg and found around 700
[18:09:25] 	 \$wg.* =
[18:09:27] 	 853
[18:10:18] 	 hey anomie. got a minute? Small question
[18:10:56] 	 $ grep -Ec "^[$]wg" DefaultSettings.php 
[18:10:57] 	 742
[18:11:35] 	 with lots of $wgGroupPermissions and other dupes though
[18:11:39] 	 yuvipanda: Not at the moment, ask again in about an hour
[18:11:45] 	 anomie: ok, thanks
[18:12:17] 	 (03CR) 10Parent5446: "I might have asked this already, but my memory is terrible: why is "#" considered invalid, but "#test" is valid. Both titles don't actuall" [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender)
[18:12:42] 	 ROTFLOL
[18:12:43] 	 $ grep -Eo "^[$]wg[^ =\[]+" DefaultSettings.php | sort -u | wc -l
[18:12:43] 	 666
[18:12:46] 	 (03CR) 10Martineznovo: [C: 04-1] "Please, don't use !!. It's already been in use by a Wikia extension [1]" [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO)
[18:13:09] 	 there are 678 different $wg� strings in DefaultSettings.
[18:13:17] 	 you're welcome.
[18:13:34] 	 (03CR) 10Hashar: "Congratulations guys in figuring out a solution there! You are the bests." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109080 (owner: 10Zfilipin)
[18:13:49] 	 MatmaRex: did you exclude comments?
[18:13:59] 	 my result is more evil so it must be true
[18:14:19] 	 nope
[18:14:24] 	 can do if you really want
[18:14:54] 	 i just counted our "CommonSettings" and there are 898
[18:15:08] 	 Nemo_bis: 667.
[18:15:20] 	 ok, whatever
[18:15:21] 	 hundreds
[18:15:22] 	 MatmaRex: paste please
[18:15:23] 	 geez
[18:15:31] 	 MatmaRex: pasta please
[18:15:43] 	 viva la pappa pappa col popopopomodoro
[18:15:59] 	 Nemo_bis: http://pastebin.com/dARwHWWz
[18:16:20] 	 $wgConf doesn't count, 666!
[18:16:23] 	 sublime's really awesome for doing data processing :)
[18:16:32] 	 > 1
[18:18:10] 	 why is tyler not on irc? :/
[18:18:17] 	 who's sitting close to him?
[18:18:23] <^d>	 marktraceur is
[18:18:35] 	 tyler is never on irc
[18:18:42] 	 he sometimes is
[18:18:44] 	 and mark left lolol
[18:19:07] 	 (03CR) 10Parent5446: "I'd abandon this patch if the other one is the correct one." [core] - 10https://gerrit.wikimedia.org/r/108673 (owner: 1001tonythomas)
[18:19:29] 	 what's $wgCommandLineMode
[18:19:38] <^d>	 It's true when we're in the command line
[18:19:41] <^d>	 It's a stupid variable.
[18:19:44] <^d>	 We should get rid of it
[18:20:16] 	 (03CR) 10Parent5446: "Keep in mind when I say "make a mapping", you don't have to map *every* conf key to every global. Just the ones that don't have the wg pre" [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm)
[18:20:24] 	 ...
[18:20:32] 	 which is like all of them.
[18:20:33] 	 so I was right, 666
[18:20:39] 	 :p
[18:21:08] 	 (03Abandoned) 1001tonythomas: Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/108673 (owner: 1001tonythomas)
[18:21:11] 	 nobody thinks templates is the worst thing ever? :)
[18:21:37] 	 Other things are worsererer
[18:21:38] 	 ;)
[18:22:06] 	 (03CR) 10Nemo bis: "> How many globals do we have in core alone? :/" [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm)
[18:22:18] 	 title strings as primary keys (and usernames too, i think) were pretty bad choices. 
[18:22:41] 	 eh, we user user_id in a lot of places
[18:23:04] 	 (03CR) 10Siebrand: [C: 04-1] Removed "Enable section editing via [edit] links" from preferences (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas)
[18:23:39] 	 i'm thinking of rev_user_text
[18:23:46] 	 i know that's an issue for us supporting user renames
[18:23:58] 	 (03PS5) 10Bartosz Dziewoński: Add parser test for empty self-link with empty fragment [[#|...]] [core] - 10https://gerrit.wikimedia.org/r/98119 
[18:23:58] 	 https://www.mediawiki.org/wiki/#
[18:24:08] 	 silly bot.
[18:24:19] 	 (03CR) 10Siebrand: [C: 032] Message for checkuser OAuth group [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/109309 (owner: 10Anomie)
[18:24:44] 	 (03Merged) 10jenkins-bot: Message for checkuser OAuth group [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/109309 (owner: 10Anomie)
[18:25:29] 	 (03CR) 10Parent5446: "I prefer var_dump( $GLOBALS );" [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm)
[18:25:54] 	 can he just get on IRC?
[18:26:13] 	 (03CR) 10Nikerabbit: "You could do messages like below and parse them as wikitext and wrap the resulting html inside class=plainlinks to avoid ugly external lin" [core] - 10https://gerrit.wikimedia.org/r/109296 (owner: 10Microchip08)
[18:26:56] 	 legoktm: someone needs to poke him
[18:27:03] 	 he's sitting in the back
[18:27:05] 	 marktraceur!
[18:27:13] 	 marktraceur: poke tyler
[18:27:28] 	 he's not paying attention
[18:27:33] 	 let's throw paper planes
[18:28:25] 	 (03CR) 10Legoktm: "Do you want to get on IRC? Your method counts stuff like $wgContLang as global settings..." [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm)
[18:30:34] 	 (03PS4) 10Legoktm: Config: Add Config and GlobalConfig classes [core] - 10https://gerrit.wikimedia.org/r/109266 
[18:31:42] 	 https://etherpad.wikimedia.org/p/shit_tim_says
[18:31:44] * werdna  hides
[18:31:44] 	 (03CR) 10Siebrand: Make show/hide link in RC individually localizable (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109296 (owner: 10Microchip08)
[18:31:50] 	 (03CR) 10Legoktm: Config: Add Config and GlobalConfig classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm)
[18:32:09] 	 xD
[18:33:11] 	 :)
[18:33:27] 	 (03PS18) 1001tonythomas: Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 
[18:34:53] 	 yes definitely, particularly for new people
[18:35:31] 	 (03PS1) 10Parent5446: Code style fixes to ApiBase::requireAtLeastOneParameter [core] - 10https://gerrit.wikimedia.org/r/109321 
[18:35:36] 	 trailing white space is not okay. :)
[18:35:42] 	 (03CR) 10Parent5446: "Follow-up: https://gerrit.wikimedia.org/r/109321" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/64649 (owner: 10Parent5446)
[18:38:03] 	 (03CR) 10Parent5446: "Oh yeah that's a good point. Going on IRC now." [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm)
[18:38:10] 	 (03CR) 10Siebrand: [C: 032] i18n: fix typo [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109276 (owner: 10Shirayuki)
[18:38:10] 	 parent5446: hi
[18:38:16] 	 (03PS19) 1001tonythomas: Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 
[18:38:28] 	 I don't think storing a mapping of variables is going to work
[18:38:32] 	 there are just too many
[18:38:54] 	 I'd be willing to bet 99% of variables start with a "wg" and the rest are "eg" 
[18:39:00] 	 (03Merged) 10jenkins-bot: i18n: fix typo [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109276 (owner: 10Shirayuki)
[18:39:36] 	 (03CR) 10Parent5446: Config: Add Config and GlobalConfig classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm)
[18:39:43] 	 there are a few exceptions
[18:39:46] 	 but yes
[18:39:58] 	 it's funny that this is a hard question to answer.
[18:40:00] 	 Yeah, I meant only storing a mapping of non-wg variables.
[18:40:05] 	 by which i mean not very funny
[18:40:22] 	 well, in core I think the only one is $IP
[18:40:33] 	 (03CR) 1001tonythomas: "@Siebrand: Reworded the RELEASE NOTES message." [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas)
[18:40:35] 	 not really hard
[18:40:59] 	 I just know that if we really want to get away from globals, the wg has to go.
[18:41:05] 	 static $specialGlobals = array( '$IP', '$parserMemc', '$messageMemc', '$hackwhere', '$haveProctitle' );
[18:41:16] 	 (Or rather the issue is that there should not be such a close tie between the global name and the conf name.)
[18:41:21] 	 they are those that don't begin with $wg
[18:41:29] 	 (we may have removed some of them, already)
[18:41:38] 	 Well, $parserMemc and $messageMemc are not meant to be accessed
[18:41:46] 	 There are global functions that retrieve them
[18:41:52] 	 wfGetParserCache()
[18:42:14] 	 it's a global variable
[18:42:33] 	 If you're talking about config management, I don't think things like $IP should be settable from that
[18:42:34] 	 (03CR) 10Siebrand: [C: 031] Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas)
[18:42:52] 	 that excerpt is from check-vars.php, which complains if you have a non $wg global, btw
[18:42:53] 	 actually bawolff is right
[18:43:01] 	 the things that don't have $wg are usually not config settings
[18:43:26] 	 that's true
[18:43:28] 	 There's undoubtedly crappy extensions that are exceptions though
[18:43:33] 	 well, screw 'em
[18:44:44] 	 (03CR) 10Parent5446: [C: 032] Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas)
[18:44:44] 	 Hi Platonides. :-)
[18:45:12] 	 I note that I did not move $wgParser etc to Config::get() in the API
[18:45:16] 	 /anything that's an object
[18:45:22] 	 In that case non-wg globals aren't even an issue anymore
[18:45:28] 	 parent5446: Thanks ! had been on that for a while. 
[18:45:29] 	 (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: bea2018..06afe09 [extensions] - 10https://gerrit.wikimedia.org/r/109323 
[18:45:31] 	 (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: bea2018..06afe09 [extensions] - 10https://gerrit.wikimedia.org/r/109323 (owner: 10Jenkins-mwext-sync)
[18:45:33] 	 except for $eg
[18:45:43] 	 $smw
[18:45:47] 	 ...what is eg?
[18:45:51] 	 extension global
[18:45:51] 	 extension global
[18:45:53] 	 (03CR) 10Siebrand: [C: 04-1] "I think this feature should not introduce yet another global. If it's worth having, it should just be there, and perform." [core] - 10https://gerrit.wikimedia.org/r/108487 (owner: 10Hydriz)
[18:45:54] 	 tonythomas01: No problem. :)
[18:45:54] 	 extension global
[18:45:55] 	 Some people use it
[18:45:59] 	 Some people just use $wg
[18:46:05] 	 It's not enforcedd
[18:46:07] 	 Oh
[18:46:10] 	 Its been added and removed from the coding conventions a couple times
[18:46:15] 	 Yeah none of my extensions use eg
[18:46:16] 	 Indeed.
[18:46:16] 	 Extension:Global
[18:46:17] 	 :P
[18:46:22] 	 Extension:MediaWiki
[18:46:31] 	 yuvipanda: Don't give JeroenDeDauw any ideas ;)
[18:46:42] 	 Reedy: pfft, *you* are the one who pinged him
[18:46:55] 	 I think at the moment we don't have to worry too much about extension configs.
[18:47:05] 	 Considering the extensions don't use this new Config class anyway
[18:47:11] 	 but they should
[18:47:21] 	 It's a back compat thing I guess too
[18:47:33] 	 Migration happens
[18:47:40] 	 They should, but the only catch would be the extension would migrate $eg... to $wg...
[18:47:44] 	 Configuring MediaWiki and extensions in 2 different ways just feels stupid
[18:47:47] 	 no one uses eg
[18:47:49] 	 (03Merged) 10jenkins-bot: Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas)
[18:47:55] 	 i haven't seen it used anywhere
[18:48:05] * legoktm  greps
[18:48:06] 	 grep time
[18:48:07] 	 i think there's some really old leftovers
[18:48:24] 	 MatmaRex: https://github.com/wikimedia/mediawiki-extensions-Drafts/blob/master/Drafts.php#L43
[18:48:24] 	 anywhere that matters, at the very least
[18:48:27] 	 in third party extensions
[18:49:02] 	 Over 500 $eg so far
[18:49:05] 	 legoktm: let's change that and do $wgFoo = &$egFoo;
[18:49:12] 	 :<
[18:49:12] 	 or something like that
[18:49:14] 	 994
[18:49:18] 	 I like the current solution of optional prefix
[18:49:21] 	 (the other way, actually)
[18:49:42] 	 or Config#get could chekc both eg and wg
[18:49:48] 	 ew no
[18:50:28] 	 Haha
[18:50:31] 	 899 $smw
[18:50:46] 	 Not all globals though
[18:50:57] 	 OK so I wouldn't mind having the prefix, but it shouldn't be called the prefix
[18:51:04] 	 It should be something like a domain
[18:51:10] 	 Or a settings groups
[18:51:17] 	 And it should be required to be specified
[18:51:27] 	 so right now its ->get( $name, $prefix = 'wg' )
[18:51:38] 	 Turn it into ->get( $group, $name )
[18:51:50] 	 And if $group is 'mediawiki', use 'wg' prefix
[18:51:55] 	 I like that the common case doesn't need $wg
[18:52:08] 	 eh
[18:53:11] 	 settings are a common code, the call should be short. If we have to do ->get( 'mediawiki', 'foo' ) that's extra typing for a very common case
[18:53:37] 	 (03PS2) 1001tonythomas: Removed "Justify paragraphs" from MW user Preference. [core] - 10https://gerrit.wikimedia.org/r/99322 
[18:54:03] 	 paravoid: ugh, that's getting wordy
[18:54:16] 	 we could have another class
[18:54:21] 	 (03CR) 10Yuvipanda: [C: 032] "Seems to work." [vagrant] - 10https://gerrit.wikimedia.org/r/109284 (owner: 10Physikerwelt)
[18:54:21] 	 sorry?
[18:54:28] 	 $conf = new ConfGetter('wg');
[18:54:29] 	 (03Merged) 10jenkins-bot: Add compilation script for texvccheck [vagrant] - 10https://gerrit.wikimedia.org/r/109284 (owner: 10Physikerwelt)
[18:54:29] 	 physikerwelt: ^
[18:54:33] 	 merged :)
[18:54:33] 	 $conf ->get('Foo')
[18:54:41] 	 but that kinda sucks imo too
[18:54:47] 	 MatmaRex: Don't se need a factory for ConfGetters?
[18:54:48] 	 (03CR) 10Jdlrobson: [C: 032] Add support for new MobileFrontend copyright warnings [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/104907 (owner: 10M4tx)
[18:54:51] 	 s/se/we/
[18:54:53] 	 whatever
[18:54:54] 	 (03Merged) 10jenkins-bot: Add support for new MobileFrontend copyright warnings [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/104907 (owner: 10M4tx)
[18:54:57] 	 :P
[18:55:07] 	 legoktm: don't you need a factory for factories?
[18:55:14] 	 exactly!
[18:55:19] 	 Javafication!
[18:55:34] 	 bawolff: pfft, I've been writing Java for the last year and I've written 0 factories!
[18:55:57] 	 AbstractFactoryBuilderFactory...
[18:57:03] 	 I only built one Singleton
[18:57:28] 	 (03Abandoned) 10Bsitu: The comment about eventlogging schema definition is quite confusing [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96902 (owner: 10Bsitu)
[18:57:58] 	 Well think about it this way
[18:58:08] 	 Oh wait, lemme collect my thoughts
[18:58:19] <^d>	 yuvipanda: You need factory singleton builders.
[18:58:43] 	 ^d: sounds like a nice band name.
[18:58:50] 	 Yeah on second thought I don't like the settings group idea
[18:58:58] 	 But I still don't like having prefixes
[18:59:21] 	 Hey, isnt it weird that mail goes to every reviewer even when the Gerrit patch is in a Can Merge: No condition or, jenkins bot give a -2 ? 
[18:59:55] 	 why so?
[19:00:23] <^d>	 It's easy to write features when you ignore performance too.
[19:00:26] * ^d  rolls eyes
[19:00:47] 	 Nikerabbit: re https://gerrit.wikimedia.org/r/#/c/109296/ -� we need a {{#link:}} parser functions for used in messages that would generate internal links with arbitrary href
[19:00:47] 	 https://www.mediawiki.org/wiki/%23link:Template: 
[19:00:57] 	 what do you think about that?
[19:00:59] 	 siebrand: ^
[19:01:26] 	 what's wrong with using fullurl: ?
[19:01:39] 	 ^
[19:01:58] 	 MatmaRex: Or we could just kill those ugly obsolete icons...
[19:02:04] 	 Platonides: [http://example.com/ links] generate icons
[19:02:08] 	 class=external something
[19:02:15] 	  ?
[19:02:22] 	 that's a stupid crappy workaroud
[19:02:29] 	 you beated me, bawolff :)
[19:02:35] 	 D:
[19:02:41] 	 i weep every time i see that in our code
[19:02:41] 	 (03CR) 10Parent5446: [C: 04-1] "Massively outdated now that SpecialVersion has been basically rewritten." [core] - 10https://gerrit.wikimedia.org/r/55507 (owner: 10Daniel Friesen)
[19:02:50] 	 and it appears a few times there
[19:02:52] 	 MatmaRex: then we couldn't backport messages
[19:03:10] 	 Nemo_bis: nothing some search&replace couldn't fix
[19:03:14] 	 or we'd just change the keys
[19:03:18] 	 I'm not sure how {{#link:http://foo.com}} being any less hacky?
[19:03:18] 	 https://www.mediawiki.org/wiki/%23link:Template:http://foo.com 
[19:03:21] 	 wouldn't be that many of them
[19:03:26] 	 unless I misunderstand
[19:03:32] 	 MatmaRex: not true, you can't add plainlinks with that
[19:03:41] 	 Nemo_bis: sorry?
[19:03:43] 	 (03CR) 10Umherirrender: "'#test' is a valid title relative to the current page, like '/sub', which have a title part, but is also relative (when sub pages are enab" [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender)
[19:03:45] 	 if there aren't many, why is it worth adding a parserfuntion?
[19:04:25] 	 because piecewise messages really suck
[19:04:29] 	 like, seriously
[19:04:35] 	 both for devs and translators
[19:05:04] 	 Mike Swartz knows what's up.
[19:05:40] 	 MatmaRex: wanna implement?
[19:05:45] 	 (03Abandoned) 10Bsitu: (bug 33214) feedcontributions fails on showsizediff in miser [core] - 10https://gerrit.wikimedia.org/r/28771 (owner: 10Bsitu)
[19:06:13] 	 Nikerabbit: can do if someone promises to merge it
[19:06:34] 	 i'd just have to figure out how to disable it in non-message-parsing contexts
[19:06:52] 	 I don't think I entirely agree with hexmode
[19:07:11] 	 i'm waiting for the point
[19:07:15] 	 but what he said is true
[19:07:19] 	 (or feels true)
[19:07:27] 	 I think its partially true
[19:07:44] 	 I think platform uses rfc's. I don't think the other teams really do
[19:08:01] 	 (03PS3) 10Parent5446: User::saveOptions() optimization [core] - 10https://gerrit.wikimedia.org/r/64941 (owner: 10Hashar)
[19:08:21] 	 LESS RFC was submitted by jon robson (mobile), steven w (features) and me (features at the time) 
[19:08:28] 	 Swift
[19:08:34] 	 gmail is down -.-
[19:08:42] 	 ori: but that wasn't a "foundation activity", was it?
[19:08:54] 	 MatmaRex: i don't know what that means
[19:08:59] 	 it was not resourced, no
[19:09:08] 	 it was our initiative
[19:09:15] 	 yeah, that's what i meant mostly
[19:09:18] 	 MatmaRex: that would solve some cases, but I'm not sure would solve all
[19:09:20] 	 (03PS4) 10Parent5446: User::saveOptions() optimization [core] - 10https://gerrit.wikimedia.org/r/64941 (owner: 10Hashar)
[19:09:29] 	 ok, I take back the platform comment, I'd say its used unevenly by wmf teams
[19:09:51] 	 is there any kind of a long term plan for what mediawiki is going to look like in another 10 years?  
[19:09:55] 	 or a plan to make a plan?
[19:10:05] 	 (03CR) 10Parent5446: [C: 032] User::saveOptions() optimization [core] - 10https://gerrit.wikimedia.org/r/64941 (owner: 10Hashar)
[19:10:33] 	 OwynD: You mean like when people said we'd have the VisualEditor type thing 5 years or so ago? ;)
[19:10:50] 	 MatmaRex: the general problem is "I want to pass some raw html, which needs some text from the message inside it, properly escaped"
[19:10:50] 	 i think the RFCs are a great start... and there seem to be areas of action coming together around those
[19:11:23] 	 OwynD: I can sketch a 5-year-plan for a Great Leap Forward for MW from Product's POV, if you'd find it helpful.
[19:11:27] 	 Nikerabbit: hmmm
[19:11:40] 	 OwynD: But… that's a WMF Management POV, not a "MediaWiki developer community" POV…
[19:11:46] 	 Nikerabbit: that is possible already � the problem is "I want to wrap some text in a HTML element"
[19:11:46] 	 James_F: like [[Future]]? :)
[19:11:46] 	 https://www.mediawiki.org/wiki/Future
[19:12:05] 	 but that element is almost always an 
[19:12:07] 	 oh yeah, like that
[19:12:16] 	 although that page just says "visual editor"
[19:12:19] 	 or , , but that's possible already
[19:12:29] 	 yep, a bit incomplete :P
[19:12:35] 	 Nemo_bis: Didn't know about that page.
[19:12:52] 	 Nemo_bis: It… needs work.
[19:13:00] 	 (03PS5) 1001tonythomas: Increased the number of rows in AbuseFilter's Filter testing textarea [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/106699 
[19:13:02] 	 MatmaRex: how is that possible already?
[19:13:04] 	 (03CR) 10Parent5446: [C: 04-1] "Needs rebase" [core] - 10https://gerrit.wikimedia.org/r/99430 (owner: 1001tonythomas)
[19:13:09] 	 Nikerabbit: raw parameters?
[19:13:26] 	 (03Merged) 10jenkins-bot: User::saveOptions() optimization [core] - 10https://gerrit.wikimedia.org/r/64941 (owner: 10Hashar)
[19:13:37] 	 MatmaRex: but then you have to split the thing inside to another message, creating lego
[19:13:46] 	 <3 legos!
[19:13:48] 	 yeah
[19:13:54] 	 that depends on what you're inserting
[19:13:55] 	 james_f: yeah i think that would be pretty interesting.
[19:14:01] 	 i saw people stuff an  in a message
[19:14:07] 	 no message splitting necessary in that case
[19:14:20] 	 James_F: blame brion!
[19:14:28] 	 If I want " world", I would have to do wfMessage( 'button', Html::element( 'button', null, wfMessage( 'hi' ) )
[19:14:57] 	 and have message $1 world, hi
[19:15:00] 	 that's not good
[19:15:07] 	 wikia and wmf have different plans to build very similar features... 
[19:15:11] 	 Nikerabbit: well
[19:15:21] 	 at this point you could just allow raw html in messages
[19:15:25] 	 i don't think the product guys on either side have figured out how to work that out
[19:15:27] 	 but we don't want to do that, i think
[19:15:45] 	 MatmaRex: we definitely don't
[19:15:50] 	 OwynD: Sure, will see what I can do.
[19:15:52] 	 but the engineers working on core need to know that stuff so they can build a flexible foundation for all those product ideas
[19:16:12] 	 OwynD: I'd really like us to collaborate as much as possible.
[19:16:21] 	 Nikerabbit: That won't even work. It would have to be a raw param.
[19:16:33] 	 OwynD: But sadly we seem to be building functionallty-similar things at different times / with different needs / on different platforms.
[19:16:37] 	 parent5446: yeah yeah, just an example of the horribleness
[19:16:37] 	 yep
[19:16:53] 	 Nikerabbit: Agreed, just expanding on the horribleness. ;)
[19:17:11] 	 there may be no way around that, but some of the things we've done are actually replacements for things that are in core now, that weren't when we started
[19:17:15] 	 Then there are some places in core where messages are parsed, and others where they're not.
[19:17:18] 	 like resourceloader vs assetmanager
[19:17:36] 	 parent5446: there's an ancient bug for that btw
[19:17:43] 	 I would prefer something like "[$1](Hello) World", wfMessage( 'button' )->superSpecialParam( Html::element( ', null, $1 ) );
[19:17:44] 	 OwynD: Indeed.
[19:17:48] 	 OwynD: And vv.
[19:17:55] 	 i think the things that do overlap are definitely things that shouldn't be in core.
[19:18:00] 	 Nikerabbit: ughhhh
[19:18:04] 	 OwynD: I'd like to hope that, at least, WMF and Wikia can learn from each others' mistakes when re-doing the work.
[19:18:05] 	 more syntax? :/
[19:18:12] 	 OwynD: But we don't even seem to do that. :-(
[19:18:14] 	 but they all depend on core features. so for me, that's the deciding factor on where to put code
[19:18:34] 	 MatmaRex: General solution is not possible without extending syntax
[19:18:56] 	 it is with parser functions ;)
[19:19:01] 	 (03PS1) 10Hoo man: Fix comment on JobQueue::push [core] - 10https://gerrit.wikimedia.org/r/109329 
[19:19:17] 	 MatmaRex: then you need two passes or something
[19:19:59] 	 (03CR) 10Hashar: "Sounds like I completely forgot about that patch. Thanks ! Hopefully not going to cause any harm." [core] - 10https://gerrit.wikimedia.org/r/64941 (owner: 10Hashar)
[19:20:49] 	 imho we've got a few major things we'd like to do
[19:20:51] 	 MatmaRex: I assume you were thinking of something {{#SomethingSpecial:raw html goes here|param|param}}
[19:20:51] 	 https://www.mediawiki.org/wiki/%23SomethingSpecial:Template:raw_html_goes_here 
[19:21:15] 	 1) more separation of skin/front end UI from data/actions.  
[19:21:35] 	 MatmaRex: to now allow arbitrary html injection, we would need a safe way to pass the raw html there, perhaps some kind of token thing, where we pass token to the function which we have registered to the parser
[19:21:37] 	 Nikerabbit: i really wanted to do this for just links
[19:21:45] 	 2) more of an SOA for mediawiki-> external services (for scaling /web farming)
[19:21:49] 	 preciswly for this reason
[19:22:03] 	 3) structured data (because text is kind of hard to work with)
[19:22:08] 	 allowing arbitrary links isn't a security issue
[19:22:16] 	 "arbitrary"
[19:22:26] 	 i guess those are the main things... 
[19:22:30] 	 (03CR) 10Umherirrender: "Needs release notes and I am not sure, why the setting in DefaultSettings.php should stay there." [core] - 10https://gerrit.wikimedia.org/r/99430 (owner: 1001tonythomas)
[19:22:53] 	 MatmaRex: makes little sense to me to build an insufficient solution we need to extend later on anyway
[19:22:59] 	 and then generally "performance" and "modernizing/refactoring"  but those have fewer visible interface points.
[19:23:17] 	 legoktm: 
[19:23:21] 	 Wondering... why jenkins-job-builder doesn't specify -config as a git submodule?
[19:23:24] 	 My laptop does not have working wifi
[19:23:29] 	 Pinging me has NULL EFFECT
[19:23:55] 	 brb, snack time
[19:27:19] 	 (03PS5) 1001tonythomas: Remove preference "Show table of contents (for pages with more ...)" [core] - 10https://gerrit.wikimedia.org/r/99430 
[19:28:05] 	 (03CR) 10jenkins-bot: [V: 04-1] Remove preference "Show table of contents (for pages with more ...)" [core] - 10https://gerrit.wikimedia.org/r/99430 (owner: 1001tonythomas)
[19:28:53] 	 (03Abandoned) 10Umherirrender: Add message wrongpassword as html on Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/104797 (owner: 10Umherirrender)
[19:29:55] 	 (03PS2) 10Hoo man: Fix comment on JobQueue::push [core] - 10https://gerrit.wikimedia.org/r/109329 
[19:30:24] 	 (03CR) 10Legoktm: [C: 032] "Yay!" [core] - 10https://gerrit.wikimedia.org/r/109329 (owner: 10Hoo man)
[19:30:59] 	 Does anyone here know anything about good practices when making a skin?
[19:31:07] 	 ...are there any established good practices?
[19:31:12] 	 There aren't, are there?
[19:32:15] 	 Ghah.
[19:32:17] 	 daniel friesen made a tutorial which is easy to follow
[19:32:48] 	 I asked for good practices.
[19:33:14] 	 the way it teaches to do it could be considered a good practise
[19:34:25] 	 (03Merged) 10jenkins-bot: Fix comment on JobQueue::push [core] - 10https://gerrit.wikimedia.org/r/109329 (owner: 10Hoo man)
[19:34:51] 	 (03Abandoned) 10Bsitu: Update watchlist preference for new users [core] - 10https://gerrit.wikimedia.org/r/68297 (owner: 10Bsitu)
[19:35:22] 	 It's perhaps better than nothing, but it doesn't really... well, it's a bit out of date and doesn't really address bigger issues.
[19:35:50] 	 It's mostly just a list of things you can do, from what I recall.
[19:35:52] 	 (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 06afe09..5dff7fc [extensions] - 10https://gerrit.wikimedia.org/r/109332 
[19:35:54] 	 (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 06afe09..5dff7fc [extensions] - 10https://gerrit.wikimedia.org/r/109332 (owner: 10Jenkins-mwext-sync)
[19:35:54] 	 Isarra: I think Daniel had a page somewhere
[19:36:10] 	 oh sorry, Nikerabbit already said that
[19:37:16] 	 (03CR) 10Reedy: "Stating the obvious... It'd be nice if we didn't bikeshed on this for too long" [core] - 10https://gerrit.wikimedia.org/r/109266 (owner: 10Legoktm)
[19:38:16] 	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/99430 (owner: 1001tonythomas)
[19:41:30] 	 (03PS6) 1001tonythomas: Remove preference "Show table of contents (for pages with more ...)" [core] - 10https://gerrit.wikimedia.org/r/99430 
[19:41:54] 	 (03CR) 10Legoktm: [C: 032] Change behavior of Special:Watchlist when user's watchlist is empty [core] - 10https://gerrit.wikimedia.org/r/103233 (owner: 10Bartosz Dziewoński)
[19:44:45] 	 (03CR) 1001tonythomas: "Rebased the change. @Siebrand, Can you go through it again please ? Earlier it was a Can merge: No" [core] - 10https://gerrit.wikimedia.org/r/99430 (owner: 1001tonythomas)
[19:45:44] 	 (03Merged) 10jenkins-bot: Change behavior of Special:Watchlist when user's watchlist is empty [core] - 10https://gerrit.wikimedia.org/r/103233 (owner: 10Bartosz Dziewoński)
[19:47:02] 	 (03CR) 1001tonythomas: "I will add the RELEASE NOTES." [core] - 10https://gerrit.wikimedia.org/r/99430 (owner: 1001tonythomas)
[19:48:24] 	 (03PS8) 10Legoktm: No longer display the number of rows shown on Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/103239 (owner: 10Bartosz Dziewoński)
[19:48:54] 	 (03PS1) 10Aarcos: Allow the script to read username and password from env variables: MEDIAWIKI_USER and MEDIAWIKI_PASSWORD [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 
[19:49:15] 	 oh yeah, tim is making a good point there about configuration
[19:49:24] 	 (03CR) 10jenkins-bot: [V: 04-1] Allow the script to read username and password from env variables: MEDIAWIKI_USER and MEDIAWIKI_PASSWORD [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 (owner: 10Aarcos)
[19:49:50] 	 monolithic configuration vs a dozen different config systems is another range of problems
[19:50:04] 	 I seem to recall an extension (Collection related?) parsing CommonSettings/InitialiseSettings from noc..
[19:50:06] 	 (03CR) 10Legoktm: [C: 04-1] Allow the script to read username and password from env variables: MEDIAWIKI_USER and MEDIAWIKI_PASSWORD (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 (owner: 10Aarcos)
[19:51:12] 	 (03PS7) 10MZMcBride: Remove preference "Show table of contents (for pages with more ...)" [core] - 10https://gerrit.wikimedia.org/r/99430 (owner: 1001tonythomas)
[19:52:08] 	 (03CR) 10MZMcBride: Remove preference "Show table of contents (for pages with more ...)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99430 (owner: 1001tonythomas)
[19:53:00] 	 (03PS8) 1001tonythomas: Remove preference "Show table of contents (for pages with more ...)" [core] - 10https://gerrit.wikimedia.org/r/99430 
[19:53:35] 	 tonythomas01: Hi.
[19:53:41] 	 tonythomas01: You overwrote my changes to the commit message. :-(
[19:54:09] 	 Gloria: I am extremely sorry. I almost gave git review -R before you clicked :( 
[19:54:15] 	 but one doubt 
[19:54:27] 	 No worries.
[19:54:45] 	 Gloria: should 'showtoc' => 1 be still set in Defaultsettings.php ?
[19:54:51] 	 tonythomas01: I'm not sure.
[19:54:57] 	 The commit message should be accurate, though. :-)
[19:54:59] <^d>	 In $wgDefaultUserOptions?
[19:55:03] <^d>	 No, if you remove the pref.
[19:55:12] 	 Indeed.
[19:55:23] 	 ^d: ok. So, the commit message should be updated then 
[19:55:34] 	 I wrote it like he variable 'showtoc' is still set to 1, in
[19:55:35] 	 includes/DefaultSettings.php, thereby making the table of contents box
[19:55:35] 	 still auto inserted.
[19:55:38] 	 tonythomas01: I'll update the commit message.
[19:55:44] 	 Gloria: Thanks ! 
[19:55:44] 	 (03CR) 10Parent5446: "Yeah I think the core of the problem is that the parser treats # as having no fragment rather than an empty fragment. If we're going to le" [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender)
[19:56:21] 	 (03CR) 10Gergő Tisza: Allow the script to read username and password from env variables: MEDIAWIKI_USER and MEDIAWIKI_PASSWORD (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 (owner: 10Aarcos)
[19:56:49] 	 (03PS9) 10MZMcBride: Remove preference "Show table of contents (for pages with more ...)" [core] - 10https://gerrit.wikimedia.org/r/99430 (owner: 1001tonythomas)
[19:58:41] 	 (03CR) 10Chad: [C: 032 V: 032] Replace usage of deprecated Title::escapeLocalURL() [extensions/PrivateDomains] - 10https://gerrit.wikimedia.org/r/104367 (owner: 10Siebrand)
[19:59:16] 	 (03CR) 10Chad: [C: 032 V: 032] Replace usage of deprecated Title::escapeLocalURL() [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/104364 (owner: 10Siebrand)
[19:59:50] 	 (03CR) 10Chad: [C: 032 V: 032] Replace usage of deprecated Title::escapeLocalURL() [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/104368 (owner: 10Siebrand)
[20:00:04] 	 (03CR) 10MZMcBride: "Related: bug 17006" [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender)
[20:00:06] 	 (03CR) 10Chad: [C: 032 V: 032] Replace deprecated SpecialPage::resolveAliasWithSubpage() [extensions/SkinPerNamespace] - 10https://gerrit.wikimedia.org/r/104384 (owner: 10Siebrand)
[20:01:12] 	 (03CR) 10Addshore: [C: 031] Improve organization of TestsAutoLoader [core] - 10https://gerrit.wikimedia.org/r/96039 (owner: 10Aude)
[20:01:23] 	 (03CR) 10Chad: [C: 032] Call Linker methods statically [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/106927 (owner: 10Siebrand)
[20:01:46] 	 (03CR) 10Chad: [V: 032] Call Linker methods statically [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/106927 (owner: 10Siebrand)
[20:02:01] 	 (03CR) 10Chad: [C: 032 V: 032] Call Linker methods statically [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/106928 (owner: 10Siebrand)
[20:02:54] 	 (03CR) 10Addshore: [C: 031] Add test to validate special page aliases [core] - 10https://gerrit.wikimedia.org/r/97118 (owner: 10Aude)
[20:03:15] 	 (03CR) 10Chad: [C: 032] Pass context to HTMLForm, don't use HTMLForm::setTitle [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/105964 (owner: 10Siebrand)
[20:03:23] 	 (03Merged) 10jenkins-bot: Pass context to HTMLForm, don't use HTMLForm::setTitle [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/105964 (owner: 10Siebrand)
[20:04:01] 	 (03CR) 10Addshore: [C: 031] Ignore testRunLegacyHooks in findHooks.php [core] - 10https://gerrit.wikimedia.org/r/101069 (owner: 10Legoktm)
[20:04:45] 	 (03PS2) 10Aarcos: Allow the script to read username and password from env variables: MEDIAWIKI_USER and MEDIAWIKI_PASSWORD [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 
[20:04:56] 	 (03CR) 10jenkins-bot: [V: 04-1] Allow the script to read username and password from env variables: MEDIAWIKI_USER and MEDIAWIKI_PASSWORD [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 (owner: 10Aarcos)
[20:05:24] 	 (03CR) 10Addshore: [C: 031] Let BlockTest.php respect database constraints [core] - 10https://gerrit.wikimedia.org/r/100334 (owner: 10saper)
[20:05:48] 	 (03CR) 10MZMcBride: "Bartosz: Is there anything I can do to help get this change merged?" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński)
[20:06:20] 	 ^d: vagrant provision && vagrant up
[20:06:25] 	 (03PS9) 10Bartosz Dziewoński: No longer display the number of rows shown on Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/103239 
[20:06:27] 	 ^d: This is trivially done already.
[20:06:45] <^d>	 Vagrant is slow, it requires VirtualBox.
[20:07:04] 	 (03CR) 10TheDJ: "Related: I270aacd12cd682c833c8e92026fc212668926a44" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński)
[20:07:05] 	 (03CR) 10Bartosz Dziewoński: "I need to clean this up again first. :/" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński)
[20:07:09] 	 It's not that slow IME.
[20:07:14] 	 (03CR) 10Addshore: [C: 031] StatusTest is language dependant [core] - 10https://gerrit.wikimedia.org/r/97325 (owner: 10Platonides)
[20:07:45] 	 I mean, I get better performance from MW on Vagrant on my laptop than I get on the cluster.
[20:07:48] 	 So…
[20:07:54] * bawolff  likes just doing git clone
[20:07:58] 	 (03CR) 10Bartosz Dziewoński: "I killed the unused parameter." [core] - 10https://gerrit.wikimedia.org/r/103239 (owner: 10Bartosz Dziewoński)
[20:08:01] 	 Yeah I've never had Vagrant performance problems
[20:08:06] <^d>	 I get better performance on my native OS on my laptop than I do on a VM.
[20:08:10] 	 Although it'd be nice if we had VMWare Fusion support
[20:08:11] 	 (03CR) 10Nullzero: "@Anomie: So I wrote that contentmodel must be given if title is omitted. I think only this should be enough because if whoever calls API w" [core] - 10https://gerrit.wikimedia.org/r/108307 (owner: 10Nullzero)
[20:08:21] 	 Maybe when we have performance from the cluster to be better we can worry about this?
[20:08:22] * ^d  has never gotten vagrant working with parallels
[20:08:28] <^d>	 Maybe one day it will be possible
[20:08:43] 	 (03CR) 10Addshore: [C: 04-1] Make phpunit pick the test @groups (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97328 (owner: 10Platonides)
[20:09:06] 	 I'm just stuck in my ways, and I already have mediawiki set up in my native os
[20:09:19] 	 Vagrant is for vagrants.
[20:09:41] 	 (03PS3) 10Aarcos: Allow the script to read username and password from env variables: MEDIAWIKI_USER and MEDIAWIKI_PASSWORD [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 
[20:09:44] 	 (03CR) 10jenkins-bot: [V: 04-1] Allow the script to read username and password from env variables: MEDIAWIKI_USER and MEDIAWIKI_PASSWORD [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 (owner: 10Aarcos)
[20:09:56] 	 and flagrants
[20:10:12] 	 Flagrant vagrants.
[20:10:26] 	 bawolff: So do I.
[20:10:44] 	 bawolff: But re-imaging when I switched installs was a pain, so I moved over to just plain Vagrant.
[20:10:48] 	 (03CR) 10Aarcos: Allow the script to read username and password from env variables: MEDIAWIKI_USER and MEDIAWIKI_PASSWORD (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 (owner: 10Aarcos)
[20:11:26] 	 The nice thing about if we have everything just work without complicated packages/required virtualization/etc, is when the complex packages break, its more complicated to fix, especially if people hide behind the packages most of the time
[20:12:04] 	 bawolff: The nice thing is that it's hard to fix?
[20:12:07] 	 yuvipanda: Reedy: Don't worry, I already have plenty of ideas that can scare the living hell out of MW devs. Not all that hard really
[20:12:11] 	 bawolff: But sure
[20:12:15] 	 bawolff: Fixing Apache is a pain.
[20:12:21] 	 (03CR) 10Chad: [C: 032 V: 032] Avoid calling User::getSkin and remove pre-1.19 compat [extensions/FacebookOpenGraph] - 10https://gerrit.wikimedia.org/r/106943 (owner: 10Siebrand)
[20:12:22] 	 bawolff: Oh wait, we already have that dependency.
[20:12:45] 	 s/Apache/your webserver/
[20:12:51] 	 I can tell you right now if MediaWiki is rewritten in Javascript I'm out of here.
[20:12:56] 	 :P
[20:13:00] 	 parent5446: Bye?
[20:13:01] 	 James_F: Gramatically bad, I mean its nice not having complex dependencies that are hidden, since that's extra complexity that can break
[20:13:08] 	 parent5446: TiddlyWiki?
[20:13:25] 	 bawolff: Sure, I was just being unhelpful. :-)
[20:13:33] 	 parent5446: it's still less bad than PHP. :P
[20:13:43] 	 what about erlang
[20:13:45] 	 bawolff: But my point was that we already have complicated systems that we depend on which we're refusing to see.
[20:13:47] 	 > Javascript is better than PHP
[20:13:58] 	 This isn't the time for jokes
[20:14:02] 	 parent5446: It's faster to run on the servers. It's faster to develop.
[20:14:04] 	 PHP is better than javascript.  citation needed. :)
[20:14:14] 	 parent5446: There are lots of bad things about PHP, and lots about Javascript.
[20:14:18] 	 James_F: Yes, I guess that is true
[20:14:28] 	 parent5446: Languages suck. Rewrite mediawiki in machine code
[20:14:28] 	 parent5446: To a large extent, this is a matter of preference.
[20:14:49] 	 Capital S in JavaScript.
[20:14:53] 	 that's what HHVM basically does.  but it's just for performance.
[20:14:57] 	 Not even the guy who created JS likes JS.
[20:15:07] 	 Gloria: Not according to Krinkle.
[20:15:10] 	 Part of the reason why Google is making Dart
[20:15:20] 	 hey guys, is there anybody at the summit who does/did DPL development?
[20:15:22] 	 Gloria: JavaScript™ is an implementation of Javascript, or something.
[20:15:27] 	 tor_: me sort of
[20:15:38] <^d>	 siebrand: Hey, if you could rebase https://gerrit.wikimedia.org/r/#/c/99195/ I'll +2
[20:15:52] 	 tor_: Which DPL? I sort of take care of the Wikimedia one
[20:16:09] 	 (03PS1) 10Jenkins-mwext-sync: Syncronize VisualEditor: 5dff7fc..ed7678e [extensions] - 10https://gerrit.wikimedia.org/r/109412 
[20:16:11] 	 (03CR) 10Jenkins-mwext-sync: [C: 032 V: 032] Syncronize VisualEditor: 5dff7fc..ed7678e [extensions] - 10https://gerrit.wikimedia.org/r/109412 (owner: 10Jenkins-mwext-sync)
[20:16:13] 	 <^d> You do the hard part, I'll swoop in for the easy part.
[20:16:14] 	 bawolff: https://www.mediawiki.org/wiki/Extension:DynamicPageList_(third-party) this one
[20:16:28] 	 tor_: yeah, that one is a mess
[20:16:30] 	 yeah, was just about to link to that
[20:16:47] <^d>	 Gloria: You know how I roll :)
[20:16:47] 	 is there a better one?  or should we just take that one over and fix it.
[20:17:09] 	 ^d: My family tells me when moving a piano, I reach for the bench. ;-)
[20:17:18] 	 OwynD: You're asking the maintainer of one extension whether the competing extension has a better alternative? :-)
[20:17:19] 	 OwynD: https://www.mediawiki.org/wiki/Extension:DynamicPageList_(third-party)  is less scary (relatively), mostly because it does significantly less
[20:17:35] 	 That's the same link.
[20:17:39] 	 d'oh
[20:17:47] 	 https://www.mediawiki.org/wiki/Extension:DynamicPageList_(Wikimedia) 
[20:17:48] 	 StevenW: much of http://www.slate.com/articles/arts/culturebox/2014/01/new_york_times_website_redesign_reviewed.html applies to http://unicorn.wmflabs.org/winter/ ; see esp. part starting with "There is white space."
[20:17:51] 	 Also, OwynD was absent.
[20:17:58] 	 [12:17]  OwynD: You're asking the maintainer of one extension whether the competing extension has a better alternative? :-)
[20:18:01] 	 lost my net connecton for  a sec
[20:18:05] 	 (03PS1) 10Anomie: Allow memory over-allocation in unprotected Lua calls [php/luasandbox] - 10https://gerrit.wikimedia.org/r/109413 
[20:18:07] 	  https://www.mediawiki.org/wiki/Extension:DynamicPageList_(Wikimedia) is less scary (relatively), mostly because it does significantly less
[20:18:08] 	 OwynD: https://www.mediawiki.org/wiki/Extension:DynamicPageList_(Wikimedia) is less scary (relatively), mostly because it does significantly less
[20:18:10] 	 Ish.
[20:18:16] 	 Heh.
[20:18:19] 	 (Snap.)
[20:18:26] 	 maintainer doesn't necessarily imply ego. :)
[20:18:27] 	 ori: we discussed that a bit on the design list too.
[20:18:27] 	 I fixed some security bugs in the third party one a while back
[20:18:34] 	 and by a "bit" I mean to death
[20:18:35] 	 OwynD: True, and bawolff is wonderful. :-)
[20:18:55] 	 Agreed.
[20:19:09] 	 The third party one has a function that's literally 10000 line functions
[20:19:14] 	 Oh good.
[20:19:18] 	 StevenW: ah, OK. I am not accustomed to your talk-oriented development methodology
[20:19:25] 	 ori: :-D
[20:19:45] 	 And it used to manually set $wgUseRawHtml = true from a parser hook (*shudder*)
[20:19:47] 	 ori: you mean like the LESS RFC?
[20:19:52] 	 http://lists.wikimedia.org/pipermail/design/2014-January/thread.html#start
[20:20:00] 	 For those interested in the discussion re: Winter.
[20:20:00] 	 StevenW: minus the whole implementation bit, yeah
[20:20:41] 	 OK, I kid. I should make it clear that StevenW and I love each other in a deeply awkward, homoerotic way and that we aren't actually fighting. Go back to bed, kids.
[20:21:15] 	 Phew.
[20:21:23] 	 tor_: For the Wikimedia DPL, I think it would be really cool to refactor it to be sane, and allow multiple backends, so it could use elasticsearch type backend, which would be much more scalable
[20:21:43] 	 How hard would it be to rename an extension if it's initially released with a really dumb name?
[20:21:55] 	 Isarra: not very
[20:22:00] 	 Excellent!
[20:22:04] 	 Isarra: Easy, but painful for re-users potentially.
[20:22:09] 	 You can create a new repo and reimport it and stuff
[20:22:14] 	 Hmm.
[20:22:20] 	 DynamicPageList_(Wikimedia) has been renamed 3 times
[20:22:21] 	 Isarra: Do you mean the extension's display name, the repo name, the parser hook, or something else?
[20:22:26] 	 often to a worse name 
[20:22:34] 	 Do people tend to use extensions before they entirely work?
[20:22:37] 	 Isarra: E.g.  ->  in wikitext is a bit disruptive.
[20:22:43] 	 bawolff: totally. we'll think about going that route, but since we have a lot of communities using the more powerful (and less performant) version, the transition would be a pain for the users :(
[20:22:43] 	 Isarra: Welcome to MediaWiki. :-)
[20:22:52] 	 ...before they work at all?
[20:22:53] 	 actually i think it would be nice if there was some kind of a mediawiki "library" 
[20:22:54] 	 Isarra: sometimes, particularly if its useful
[20:22:59] 	 ...crap.
[20:23:14] 	 (03CR) 10Bartosz Dziewoński: "+1 to what Tyler said." [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender)
[20:23:23] 	 Actually, this might be a reason TO use a really dumb name in the first place - so nobody finds it.
[20:23:30] 	 lol
[20:24:00] 	 Well even the foundation has FlaggedRevisions/PendingChanges, Echo/Notifiactions, etc
[20:24:41] 	 bawolff: is there a list of that the WMF version of DPL does not do that the 3rdparty version does? Would be really helpful.
[20:24:57] 	 It'd be a big list
[20:25:05] 	 (and certainly beats reading the code to find out :P)
[20:25:24] 	 yeah, we might want to talk to the community and find some examples of what they're using DPL for 
[20:25:27] 	 WMF dpl lists everything it does on its extension page, so it'd basically be comparing the docs
[20:25:31] 	 and then evaluate whether we could switch
[20:25:41] 	 k, lets do that
[20:25:46] 	 (03PS1) 10Umherirrender: Little change of readability in Title::secureAndSplit [core] - 10https://gerrit.wikimedia.org/r/109415 
[20:25:46] 	 Careful... once you find out you may want to strangle them.
[20:26:08] 	 but the 3rd party DPL does a lot.
[20:26:08] 	 Isarra: we wouldn't do that, we love our users :)
[20:26:08] 	 That's what happened when I tried, anyway. All the uses were so exceedingly dumb... and horrible... and awful and AAAAGH MY EYES.
[20:26:12] 	 (03PS1) 10Addshore: Fix file comments and add README file [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/109416 
[20:26:19] <^d>	 If you want to name your extension something and one already exists....
[20:26:22] * yuvipanda  gives Isarra eyes
[20:26:23] <^d>	 Just slap v5 on the end.
[20:26:32] 	 i know some people use it to build user pages that list everything they've edited, since it lets you do that.
[20:26:34] 	 You wouldn't love them anymore after looking into how they use DPL.
[20:26:40] 	 Gerrit == CodeReviewv5
[20:26:50] 	 It's HORRIBLE.
[20:27:21] 	 Isarra: sure I would still love them, they pay my bills ;)
[20:27:28] 	 Heh.
[20:27:44] 	 Do these include psychiatry bills?
[20:27:49] 	 I don't know if/how hiphop would help, but my past experience writing long-running php servers has been painful
[20:27:50] 	 Reedy, was there a way to run a query for each wiki? e.g. on deployment-prep or production?
[20:27:52] 	 Not yet ;)
[20:27:58] 	 it's way too easy to write a memory leak
[20:28:00] 	 (03PS3) 10Addshore: General fixes, style and comments / phpdoc [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/95768 
[20:28:03] 	 tor_: btw, if you're interested in category intersection type things, there's been some interesting stuff done at commons, where  Dschwen made a thing that can intersect categories to infinite depth
[20:28:06] 	 Be careful around DPL.
[20:28:20] 	 (03CR) 10Addshore: General fixes, style and comments / phpdoc (031 comment) [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/95768 (owner: 10Addshore)
[20:28:26] 	 (03PS2) 10Addshore: Fix file comments and add README file [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/109416 
[20:28:30] 	 bawolff: I imagine that's way more specialized than DPL, right?
[20:28:46] 	 tor_: yes, its a specialized deamon written in c
[20:29:09] 	 tor_: https://commons.wikimedia.org/wiki/Help:FastCCI
[20:29:13] 	 thx
[20:29:28] 	 (03CR) 10Legoktm: [C: 04-1] ChangesListSpecialPage: Implement execute() (035 comments) [core] - 10https://gerrit.wikimedia.org/r/103240 (owner: 10Bartosz Dziewoński)
[20:29:41] 	 embolden the monolith
[20:30:12] <^d>	 When I get bold I start axing hundred line swaths of MediaWiki ;-)
[20:30:19] <^d>	 "Who uses this crap? "
[20:30:24] 	 I hope this doesn't cause the number of languages to explode, that would be unfortunate
[20:30:31] 	 Krenair: foreachwiki and sql.php
[20:30:40] 	 fastCCI is pretty interesting, haven't seen that before
[20:30:50] <^d>	 bawolff: Am I the only MediaWiki developer who doesn't know Javascript?
[20:30:52] 	 OwynD: It just happened recently. Its really cool
[20:31:00] 	 ^d: I don't know it very well
[20:31:08] 	 bawolff: Well we can do the client side in Dart, the server side in PHP, the parser in Node.JS, something else in Erlang.....
[20:31:12] 	 Neither do I..
[20:31:16] 	 as I noticed when I tried to understand wtf TimedMediaHandler was doing
[20:31:16] <^d>	 bawolff: I can barely read it. Can't write it at all.
[20:31:29] * ^d  fears our node.js future
[20:31:45] 	 nah, python!
[20:31:51] <^d>	 python's cool
[20:31:56] 	 Reedy, so how do I get it to run a query on each wiki?
[20:32:00] 	 javascript was the first language I learned, but I certainly don't feel comfortable doing anything large in our js
[20:32:08] 	 well, moving to abstracted services makes it easier to do tools in different languages.
[20:32:23] 	 (03PS4) 10Aarcos: Allow the script to read username and password from env variables: MEDIAWIKI_USER and MEDIAWIKI_PASSWORD [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 
[20:32:49] 	 I'd like a conservative approach - have it call other mediawiki instances running on different machines at the beginning
[20:32:52] 	 Almost forgot about Python. All of our maintenance scripts could be in that
[20:33:00] 	 Or maybe just do shell scripts for everything
[20:33:25] 	 Krenair: sudo -u apache foreachwiki sql.php query.sql
[20:33:36] 	 oh ok, has to be in a file
[20:33:42] 	 It doesn't
[20:33:53] 	 But with the wrappers it's easier
[20:34:16] 	 though
[20:34:18] 	 " * Maintenance script that sends SQL queries from the specified file to the database."
[20:37:06] 	 PHP Warning:  fopen(willNeedOSMigration.sql): failed to open stream: Permission denied in /data/project/apache/common-local/php-master/maintenance/sql.php on line 76
[20:37:38] 	 so I need to make my query file readable by apache
[20:38:11] 	 trying to find Aaron Schultz (?) -- is he at the summit today?
[20:39:03] 	 +1 to what Yuri said also
[20:39:16] 	 Reedy, chmodded it to 777, still got the error? :/
[20:39:18] 	 +2 ;) like where this is headed
[20:39:27] 	 that's kind of the point i was making.  when you switch off the local version, it should just disappear.
[20:39:33] 	 that would be awesome.
[20:39:57] 	 core = interfaces, extensions = implementations
[20:40:01] 	 tor_, yes he's here
[20:40:06] 	 so is the revision storage RFC the next step aka 1st implementation?
[20:40:06] 	 standing up talking to james I think
[20:41:59] 	 (03PS5) 10Addshore: Add basic unit test for dieOnBadUser api method [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/95647 
[20:42:14] 	 (03CR) 10Addshore: Add basic unit test for dieOnBadUser api method (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/95647 (owner: 10Addshore)
[20:42:31] 	 brb, lunch
[20:50:05] 	 (03PS1) 10UltrasonicNXT: Hotfix; prevent JS errors [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/109423 
[20:50:28] 	 (03CR) 10UltrasonicNXT: [C: 032 V: 032] Hotfix; prevent JS errors [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/109423 (owner: 10UltrasonicNXT)
[20:53:39] 	 why is this null edit visible in the page history? https://en.wikipedia.org/w/index.php?title=Texas_Revolution&diff=592227260&oldid=592227245
[20:53:48] 	 Krenair: thanks, grabbed him, good chat :)
[20:56:29] 	 jackmcbarn: how do you know it's a null edit?
[20:56:39] 	 Nemo_bis: diff shows "No difference"
[20:56:48] 	 jackmcbarn: and you trust it?
[20:56:56] 	 yes... shouldn't i?
[20:57:04] 	 there was or is a bug about that
[20:57:22] 	 where you see a bug there are legion, so
[20:58:33] 	 jackmcbarn: there was a bug with trimming trailing newlines, i think
[20:58:51] 	 gloria would know
[20:59:13] 	 or bugzilla search
[20:59:21] 	 (03PS12) 10Siebrand: Replace  and  by  and  in i18n [core] - 10https://gerrit.wikimedia.org/r/99195 
[21:00:07] 	 (03PS10) 10Parent5446: Remove preference "Show table of contents (for pages with more ...)" [core] - 10https://gerrit.wikimedia.org/r/99430 (owner: 1001tonythomas)
[21:00:23] 	 (03CR) 10Parent5446: "PS10: Removed trailing whitespace." [core] - 10https://gerrit.wikimedia.org/r/99430 (owner: 1001tonythomas)
[21:04:27] 	 (03CR) 10Parent5446: [C: 032] Remove preference "Show table of contents (for pages with more ...)" [core] - 10https://gerrit.wikimedia.org/r/99430 (owner: 1001tonythomas)
[21:05:50] 	 (03CR) 10Parent5446: [C: 032] Ignore testRunLegacyHooks in findHooks.php [core] - 10https://gerrit.wikimedia.org/r/101069 (owner: 10Legoktm)
[21:08:09] 	 (03Merged) 10jenkins-bot: Remove preference "Show table of contents (for pages with more ...)" [core] - 10https://gerrit.wikimedia.org/r/99430 (owner: 1001tonythomas)
[21:09:35] 	 (03Merged) 10jenkins-bot: Ignore testRunLegacyHooks in findHooks.php [core] - 10https://gerrit.wikimedia.org/r/101069 (owner: 10Legoktm)
[21:12:31] 	 (03CR) 10Legoktm: Add basic unit test for dieOnBadUser api method (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/95647 (owner: 10Addshore)
[21:13:31] 	 (03PS6) 10Legoktm: Add basic unit test for dieOnBadUser api method [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/95647 (owner: 10Addshore)
[21:13:43] 	 addshore: >.<
[21:13:44] 	 I'm fixing it though
[21:13:50] 	 (03CR) 10Legoktm: [C: 032] Add basic unit test for dieOnBadUser api method [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/95647 (owner: 10Addshore)
[21:14:00] 	 (03Merged) 10jenkins-bot: Add basic unit test for dieOnBadUser api method [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/95647 (owner: 10Addshore)
[21:14:13] 	 legoktm: :D
[21:14:38] 	 hehe
[21:16:55] 	 (03CR) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement execute() (035 comments) [core] - 10https://gerrit.wikimedia.org/r/103240 (owner: 10Bartosz Dziewoński)
[21:17:02] 	 (03PS9) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement execute() [core] - 10https://gerrit.wikimedia.org/r/103240 
[21:17:19] 	 legoktm, actually changed my mind, will stay down here
[21:17:26] 	 okay :(
[21:19:44] 	 (03PS1) 10Addshore: Remove unused variable in foreach loop [extensions/APC] - 10https://gerrit.wikimedia.org/r/109425 
[21:22:10] 	 (03CR) 10Legoktm: [C: 032 V: 032] General fixes, style and comments / phpdoc [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/95768 (owner: 10Addshore)
[21:23:05] 	 (03CR) 10Legoktm: [C: 032 V: 032] Fix file comments and add README file [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/109416 (owner: 10Addshore)
[21:23:46] 	 (03PS1) 10Umherirrender: More use of Title::hasFragment [core] - 10https://gerrit.wikimedia.org/r/109426 
[21:25:01] 	 (03CR) 10Legoktm: [C: 032] Remove unused variable in foreach loop [extensions/APC] - 10https://gerrit.wikimedia.org/r/109425 (owner: 10Addshore)
[21:25:03] 	 (03Merged) 10jenkins-bot: Remove unused variable in foreach loop [extensions/APC] - 10https://gerrit.wikimedia.org/r/109425 (owner: 10Addshore)
[21:25:05] 	 (03PS1) 10Addshore: General code cleanup [extensions/AWS] - 10https://gerrit.wikimedia.org/r/109427 
[21:28:57] 	 (03PS1) 10Adamw: Add jobs for mediawiki-vagrant erblint and "rake lint" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/109428 
[21:29:01] 	 (03PS1) 10Nikerabbit: Update jStorage [core] - 10https://gerrit.wikimedia.org/r/109429 
[21:30:29] 	 (03CR) 10Mglaser: [C: 04-1] "Please move the description of message parameters to from tiff_invalid_file to tiff_bad_file. Other than that, the change looks good" (031 comment) [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/107039 (owner: 1001tonythomas)
[21:31:28] 	 (03PS2) 10Umherirrender: Little change of readability in Title::secureAndSplit [core] - 10https://gerrit.wikimedia.org/r/109415 
[21:32:01] 	 (03CR) 10Umherirrender: "Patch Set 2: Also break a double assignment in two statements" [core] - 10https://gerrit.wikimedia.org/r/109415 (owner: 10Umherirrender)
[21:33:47] 	 (03PS1) 10Adamw: Run additional, non-voting lint jobs for mediawiki-vagrant [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/109430 
[21:34:54] 	 (03PS1) 10Bsitu: Add diff view of changes to board header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 
[21:36:39] 	 (03PS1) 10Umherirrender: Add hints to two function comments in Title.php [core] - 10https://gerrit.wikimedia.org/r/109432 
[21:36:40] 	 "Should we go find Nemo then?"
[21:38:15] 	 legoktm: I was officially removed from authors
[21:38:28] 	 yes, we were just talking about that
[21:38:42] 	 I figured ;)
[21:39:35] 	 legoktm: how is afc permission unenforceable?
[21:42:27] 	 (03PS1) 10Reedy: Minor code tweaks [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/109433 
[21:42:48] 	 (03PS1) 10Addshore: General tidy up [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/109434 
[21:44:33] 	 (03CR) 10Bsitu: Do not apply font styles on non-plain-text headers (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109029 (owner: 10SG)
[21:46:40] 	 (03CR) 10Legoktm: [C: 032 V: 032] General code cleanup [extensions/AWS] - 10https://gerrit.wikimedia.org/r/109427 (owner: 10Addshore)
[21:49:02] 	 (03CR) 10Legoktm: [C: 04-1] Minor code tweaks (031 comment) [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/109433 (owner: 10Reedy)
[21:59:19] 	 (03CR) 10UltrasonicNXT: "Thanks for this!" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/109434 (owner: 10Addshore)
[22:00:32] 	 (03CR) 10Addshore: "yes, indeed, if you dont need it there is no reason to define it :)" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/109434 (owner: 10Addshore)
[22:00:55] 	 (03CR) 10Siebrand: Add diff view of changes to board header (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109431 (owner: 10Bsitu)
[22:01:57] 	 (03PS2) 10UltrasonicNXT: General tidy up [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/109434 (owner: 10Addshore)
[22:02:47] 	 (03CR) 10UltrasonicNXT: "I'll remove it then?" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/109434 (owner: 10Addshore)
[22:03:15] 	 (03CR) 10Addshore: [C: 031] "Your additional changes all look good." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/109434 (owner: 10Addshore)
[22:07:09] 	 (03PS2) 10Reedy: Minor code tweaks [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/109433 
[22:08:14] 	 (03CR) 10UltrasonicNXT: "Saving the log id to $logid, is it worth it if it's never going to be used?" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/109434 (owner: 10Addshore)
[22:09:19] 	 (03CR) 10Addshore: "no. But by the looks of things you still need to call the $logEntry->insert() function, just ignore the return value ( as is in the change" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/109434 (owner: 10Addshore)
[22:09:57] 	 (03CR) 10Legoktm: [C: 032 V: 032] Minor code tweaks [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/109433 (owner: 10Reedy)
[22:10:06] 	 (03CR) 10Siebrand: [C: 032] "There's an open bug for getting the access rights for L10n bot fixed. Can someone please look into that?" [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/109417 (owner: 10L10n-bot)
[22:10:11] 	 (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/109417 (owner: 10L10n-bot)
[22:11:27] 	 (03CR) 10UltrasonicNXT: [C: 032 V: 032] "Sorry, I was reading the patchset wrong, and thought you had added the '$logId = ' bit, not taken it away! My mistake." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/109434 (owner: 10Addshore)
[22:16:51] 	 (03CR) 10Bsitu: [C: 031] Fix permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109084 (owner: 10Matthias Mullie)
[22:17:04] 	 jackmcbarn, MatmaRex: Did you find the bug?
[22:24:05] 	 (03CR) 10Reedy: WIP RFC: Generic data store (031 comment) [core] - 10https://gerrit.wikimedia.org/r/79029 (owner: 10MaxSem)
[22:27:55] 	 (03CR) 10Legoktm: [C: 04-1] Fix permissions (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109084 (owner: 10Matthias Mullie)
[22:28:13] 	 (03CR) 10Gergő Tisza: [C: 032] "Tested on Cloudbees." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 (owner: 10Aarcos)
[22:28:23] 	 (03Merged) 10jenkins-bot: Allow the script to read username and password from env variables: MEDIAWIKI_USER and MEDIAWIKI_PASSWORD [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/109335 (owner: 10Aarcos)
[22:30:18] 	 canhasbucket?
[22:30:38] 	 Reedy is a lolrus.
[22:30:57] 	 (03CR) 10Anomie: [C: 04-1] "(see PS1)" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/109262 (owner: 10TheDJ)
[22:32:23] 	 who invited Gloria anyway
[22:32:31] 	 werdna: Quim, apparently.
[22:32:45] 	 no I mean to the channel
[22:32:47] 	 :p
[22:32:58] 	 :D
[22:33:13] 	 443 Gloria #wikimedia-dev is already on channel
[22:33:14] 	 dammit
[22:46:28] 	 parent5446: Yo.
[23:01:41] 	 Gloria: Hey
[23:08:20] 	 (03CR) 10SPQRobin: [C: 032 V: 032] "Thanks for the gerrit change; merging." [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/102639 (owner: 10Gerrit Patch Uploader)
[23:22:37] 	 (03CR) 10Skizzerz: Add in preliminary MS SQL support (034 comments) [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz)
[23:29:17] 	 (03CR) 10Werdna: Fix permissions (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109084 (owner: 10Matthias Mullie)
[23:30:05] 	 (03PS1) 10AndyRussG: Fix summary info for institutions [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109439 
[23:40:01] 	 (03CR) 10Adamw: [C: 032 V: 032] Fix summary info for institutions [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/109439 (owner: 10AndyRussG)
[23:40:23] 	 (03PS5) 10Bartosz Dziewoński: Add an SVG version of watch icon [core] - 10https://gerrit.wikimedia.org/r/99258 (owner: 10M4tx)
[23:40:39] 	 qgil: ^
[23:41:05] 	 (03CR) 10Bartosz Dziewoński: "Simple rebase, the screen.css file just got split. Still works and looks okay at a very quick glance." [core] - 10https://gerrit.wikimedia.org/r/99258 (owner: 10M4tx)
[23:41:43] 	 bd808: I've changed dinner from Chaat to CPK https://www.mediawiki.org/wiki/Architecture_Summit_2014/Dinner_sign-up#Dinner_Leader:_Timo_Tijhof (Already went to Chaat two days in a row).
[23:42:11] 	 Yesterday my dinner plan was CPK, but my lead was cancelled due to too many leads. There was interest in it though, so I've brought it back.
[23:42:23] 	 You may want to list elsewhere if you prefer a different place :)
[23:42:38] 	 Krinkle: Thanks for the heads up. I'll look at the list again :)
[23:43:00] 	 ori: Hm.. you may want to list a restaurant. Or are you cooking?
[23:43:53] 	 Krinkle: Aww.
[23:44:42] 	 Krinkle: folding my group into Roan's, since the restaurant he picked can accommodate a larger group
[23:45:35] 	 ori: s/he/James/ ;-)
[23:47:11] 	 (03PS2) 10SG: Do not apply font styles on non-plain-text headers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109029 
[23:47:17] 	 Wow, impressed! https://www.google.com/maps/preview/
[23:48:19] 	 (03CR) 10Chad: [C: 032] Replace  and  by  and  in i18n [core] - 10https://gerrit.wikimedia.org/r/99195 (owner: 10Siebrand)
[23:49:04] 	 (03CR) 10Addshore: [C: 04-1] Fix permissions (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109084 (owner: 10Matthias Mullie)
[23:50:11] 	 (03PS3) 10SG: Do not apply font styles on non-plain-text headers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109029 
[23:51:44] 	 (03Merged) 10jenkins-bot: Replace  and  by  and  in i18n [core] - 10https://gerrit.wikimedia.org/r/99195 (owner: 10Siebrand)
[23:53:20] 	 (03CR) 10Siebrand: [C: 031] "L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/99322 (owner: 1001tonythomas)
[23:53:37] 	 (03CR) 10Addshore: "To avoid messing with global stuff too much I suggest something similar to the setup and teardown that can be seen in https://github.com/w" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109084 (owner: 10Matthias Mullie)
[23:53:48] 	 parent5446: I was going to bother you about a few things, but I think legoktm beat me to it.
[23:53:55] 	 parent5446: Thanks for merging those preference kills.
[23:53:58] 	 Two down today!
[23:54:08] 	 (03CR) 10Nikerabbit: [C: 032] More use of Title::hasFragment [core] - 10https://gerrit.wikimedia.org/r/109426 (owner: 10Umherirrender)
[23:54:32] 	 (03CR) 10Nikerabbit: [C: 032] StatusTest is language dependant [core] - 10https://gerrit.wikimedia.org/r/97325 (owner: 10Platonides)
[23:56:28] 	 cat-eg-ori-es
[23:56:54] 	 (03Merged) 10jenkins-bot: Add hints to two function comments in Title.php [core] - 10https://gerrit.wikimedia.org/r/109432 (owner: 10Umherirrender)
[23:57:43] 	 (03Merged) 10jenkins-bot: More use of Title::hasFragment [core] - 10https://gerrit.wikimedia.org/r/109426 (owner: 10Umherirrender)
[23:57:45] 	 (03Merged) 10jenkins-bot: StatusTest is language dependant [core] - 10https://gerrit.wikimedia.org/r/97325 (owner: 10Platonides)
[23:59:52] 	 hexmode: https://www.mediawiki.org/wiki/ResourceLoader/Features