[00:00:14] (03PS1) 10MarkTraceur: Add MultimediaViewer doc jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/108857 [00:00:44] (03CR) 10Hashar: [C: 032] Add jsduck jobs for MultimediaViewer [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/108854 (owner: 10MarkTraceur) [00:01:19] (03PS1) 10Gergő Tisza: WIP add jsduck support for MediaViewer [vagrant] - 10https://gerrit.wikimedia.org/r/108858 [00:02:35] (03CR) 10Hashar: [C: 032] Add jsduck jobs for MultimediaViewer [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/108854 (owner: 10MarkTraceur) [00:02:53] (03Merged) 10jenkins-bot: Add jsduck jobs for MultimediaViewer [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/108854 (owner: 10MarkTraceur) [00:02:57] (03CR) 10MarkTraceur: [C: 032] Add MultimediaViewer doc jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/108857 (owner: 10MarkTraceur) [00:03:38] (03PS20) 10Bsitu: Topic and Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 [00:03:54] (03PS2) 10MarkTraceur: Add MultimediaViewer doc jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/108857 [00:04:00] (03CR) 10MarkTraceur: [C: 032] Add MultimediaViewer doc jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/108857 (owner: 10MarkTraceur) [00:04:04] (03Merged) 10jenkins-bot: Add MultimediaViewer doc jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/108857 (owner: 10MarkTraceur) [00:04:59] (03CR) 10Chad: [C: 032] Updating Cirrus to master (a310e9f9) [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/108829 (owner: 10Chad) [00:05:02] (03CR) 10Chad: [C: 032] Updating Cirrus to master (a310e9f9) [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/108828 (owner: 10Chad) [00:05:17] does anyone have experience with debugging gem installation in puppet? i'm having a hard time with this patch: https://gerrit.wikimedia.org/r/#/c/108858/ [00:06:10] it logs that the package is ensured when run vagrant provision, but then the gem is not there [00:07:01] I think that's something we explicitly don't do in production [00:08:52] (03Merged) 10jenkins-bot: Updating Cirrus to master (a310e9f9) [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/108829 (owner: 10Chad) [00:08:54] (03Merged) 10jenkins-bot: Updating Cirrus to master (a310e9f9) [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/108828 (owner: 10Chad) [00:11:33] !log demon synchronized php-1.23wmf10/extensions/CirrusSearch 'Cirrus to master, with better job queues' [00:13:54] (03CR) 10Jeroen De Dauw: "Gerg: at this moment it is not used by any extensions, since it is not there yet. The reason I'm suggesting to also have it in 1.22.x is p" [core] - 10https://gerrit.wikimedia.org/r/105092 (owner: 10Jeroen De Dauw) [00:15:24] !log demon synchronized php-1.23wmf10/extensions/CirrusSearch 'Rolling back Cirrus -- fatals' [00:16:48] (03PS1) 10Chad: Updating Elastica to master [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/108860 [00:17:28] (03CR) 10Chad: [C: 032 V: 032] Updating Elastica to master [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/108860 (owner: 10Chad) [00:18:20] !log demon synchronized php-1.23wmf10/extensions/Elastica 'Elastica to master' [00:19:28] (03CR) 10MarkAHershberger: [C: 031] "It looks like this doesn't add any functionality that could trip up anything else in MW. Adding it for 1.22.2 would make it available to " [core] - 10https://gerrit.wikimedia.org/r/105092 (owner: 10Jeroen De Dauw) [00:20:42] (03PS2) 10Gergő Tisza: WIP add jsduck support for MediaViewer [vagrant] - 10https://gerrit.wikimedia.org/r/108858 [00:21:21] !log demon synchronized php-1.23wmf10/extensions/CirrusSearch 'Cirrus to master, with better job queues' [00:21:22] (03PS1) 10Adamw: Merge "Adding owner and group parameters to git::clone" [vagrant] - 10https://gerrit.wikimedia.org/r/108861 [00:22:12] (03Abandoned) 10Adamw: Merge "Adding owner and group parameters to git::clone" [vagrant] - 10https://gerrit.wikimedia.org/r/108861 (owner: 10Adamw) [00:22:42] !log demon synchronized php-1.23wmf11/extensions/CirrusSearch 'Cirrus to master, with better job queues' [00:23:26] (03CR) 10Gergő Tisza: "Ori: any idea what I am doing wrong here? puppet seems to do something about the gem, but then it is not there." [vagrant] - 10https://gerrit.wikimedia.org/r/108858 (owner: 10Gergő Tisza) [00:24:24] (03PS15) 10Adamw: Provision the fundraising-crm project [vagrant] - 10https://gerrit.wikimedia.org/r/94950 [00:24:37] (03PS4) 10Adamw: SmashPig payments listener and role [vagrant] - 10https://gerrit.wikimedia.org/r/96227 [00:24:43] (03PS2) 10Adamw: Enable STOMP; add some helpful gateway default config [vagrant] - 10https://gerrit.wikimedia.org/r/105423 [00:29:02] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/107794 (owner: 10Reedy) [00:29:04] (03Merged) 10jenkins-bot: Add COPYING [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/107794 (owner: 10Reedy) [00:29:38] (03PS3) 10Reedy: Add COPYING [extensions/Cite] - 10https://gerrit.wikimedia.org/r/107784 [00:29:44] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/Cite] - 10https://gerrit.wikimedia.org/r/107784 (owner: 10Reedy) [00:29:49] (03Merged) 10jenkins-bot: Add COPYING [extensions/Cite] - 10https://gerrit.wikimedia.org/r/107784 (owner: 10Reedy) [00:30:00] (03PS3) 10Reedy: Add COPYING [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/107779 [00:31:21] (03PS3) 10Reedy: Add COPYING [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/107778 [00:31:26] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/107778 (owner: 10Reedy) [00:31:28] (03Merged) 10jenkins-bot: Add COPYING [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/107778 (owner: 10Reedy) [00:32:51] (03PS27) 10Adamw: (bug 53835) Autodiscover classfiles via namespace hierarchy [core] - 10https://gerrit.wikimedia.org/r/59804 [00:35:09] (03PS2) 10Krinkle: Apply coding conventions for JavaScript [core] - 10https://gerrit.wikimedia.org/r/108826 (owner: 10Gerrit Patch Uploader) [00:35:23] (03CR) 10Krinkle: [C: 032] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/108826 (owner: 10Gerrit Patch Uploader) [00:39:16] (03Merged) 10jenkins-bot: Clean up whitespace in various javascript files [core] - 10https://gerrit.wikimedia.org/r/108826 (owner: 10Gerrit Patch Uploader) [00:47:05] (03PS3) 10Reedy: Add COPYING [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/107775 [00:47:09] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/107775 (owner: 10Reedy) [00:47:11] (03Merged) 10jenkins-bot: Add COPYING [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/107775 (owner: 10Reedy) [00:48:28] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/107774 (owner: 10Reedy) [00:48:31] (03Merged) 10jenkins-bot: Add COPYING [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/107774 (owner: 10Reedy) [00:48:46] (03CR) 10CSteipp: [C: 031] "Haven't tested, but looks fine" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92461 (owner: 10Reedy) [00:49:03] (03PS1) 10MarkTraceur: Make jsduck voting on MultimediaViewer [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/108865 [00:49:54] (03CR) 10MarkTraceur: [C: 032] Make jsduck voting on MultimediaViewer [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/108865 (owner: 10MarkTraceur) [00:49:58] (03Merged) 10jenkins-bot: Make jsduck voting on MultimediaViewer [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/108865 (owner: 10MarkTraceur) [00:50:37] (03PS3) 10Reedy: Add COPYING [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/107771 [00:50:42] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/107771 (owner: 10Reedy) [00:50:44] (03Merged) 10jenkins-bot: Add COPYING [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/107771 (owner: 10Reedy) [00:51:16] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/107772 (owner: 10Reedy) [00:51:21] (03Merged) 10jenkins-bot: Add COPYING [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/107772 (owner: 10Reedy) [00:51:48] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/107779 (owner: 10Reedy) [00:51:50] (03Merged) 10jenkins-bot: Add COPYING [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/107779 (owner: 10Reedy) [00:52:11] (03PS1) 10Physikerwelt: remove unused private variable [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/108867 [00:57:43] (03PS2) 10Physikerwelt: remove unused private variable [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/108867 [00:57:54] (03CR) 10Physikerwelt: [C: 032 V: 032] remove unused private variable [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/108867 (owner: 10Physikerwelt) [00:59:22] (03CR) 10CSteipp: "The patch looks ok, although in general I don't like the duplication of the log, and it seems like there should be a better way." [core] - 10https://gerrit.wikimedia.org/r/49234 (owner: 10Liangent) [01:00:17] (03PS1) 10MarkTraceur: Move the right things for publishing MMV docs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/108868 [01:00:29] (03CR) 10MarkTraceur: [C: 032] Move the right things for publishing MMV docs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/108868 (owner: 10MarkTraceur) [01:00:51] (03Merged) 10jenkins-bot: Move the right things for publishing MMV docs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/108868 (owner: 10MarkTraceur) [01:00:54] (03PS1) 10Physikerwelt: install MathWebSearch [vagrant] - 10https://gerrit.wikimedia.org/r/108869 [01:04:00] (03PS1) 10MarkTraceur: Add link to MultimediaViewer docs [integration/docroot] - 10https://gerrit.wikimedia.org/r/108870 [01:06:56] (03PS1) 10EBernhardson: Whitelist 'protect' and 'unprotect' core actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108871 [01:07:37] (03PS2) 10EBernhardson: Whitelist 'protect' and 'unprotect' core actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108871 [01:09:33] (03PS1) 10Jdlrobson: Remove the fade in image in favour of background gradient [core] - 10https://gerrit.wikimedia.org/r/108873 [01:10:33] (03PS28) 10Adamw: (bug 53835) Autodiscover classfiles via namespace hierarchy [core] - 10https://gerrit.wikimedia.org/r/59804 [01:10:38] (03PS18) 10Gilles: Create jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [01:11:10] (03CR) 10jenkins-bot: [V: 04-1] (bug 53835) Autodiscover classfiles via namespace hierarchy [core] - 10https://gerrit.wikimedia.org/r/59804 (owner: 10Adamw) [01:13:00] (03PS29) 10Adamw: (bug 53835) Autodiscover classfiles via namespace hierarchy [core] - 10https://gerrit.wikimedia.org/r/59804 [01:14:28] (03PS1) 10Hashar: gerrit-sync-ve: switch to jenkins-mwext-sync user [integration/jenkins] - 10https://gerrit.wikimedia.org/r/108874 [01:14:39] (03CR) 10Hashar: [C: 032] gerrit-sync-ve: switch to jenkins-mwext-sync user [integration/jenkins] - 10https://gerrit.wikimedia.org/r/108874 (owner: 10Hashar) [01:14:42] (03Merged) 10jenkins-bot: gerrit-sync-ve: switch to jenkins-mwext-sync user [integration/jenkins] - 10https://gerrit.wikimedia.org/r/108874 (owner: 10Hashar) [01:16:56] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu) [01:17:34] (03CR) 10Adamw: "I agree that we should evaluate the performance and memory impact before deploying. I wrote some naive profiling tests, and discovered th" [core] - 10https://gerrit.wikimedia.org/r/59804 (owner: 10Adamw) [01:21:05] awight: i dont want to just jump late into the patch, but have you looked at generating a classmap from the directory structure, basically applying your technique from a maint script and having the autoloader just receive a php class => dir array that the maint script wrote to disk? [01:21:25] thats how composer gets arround the slowness of directory access in autoloaders [01:22:37] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/78790 (owner: 10Reedy) [01:23:31] (03CR) 10Reedy: Fix indenting. Localise description (031 comment) [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/78790 (owner: 10Reedy) [01:23:59] (03CR) 10Siebrand: Fix indenting. Localise description (031 comment) [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/78790 (owner: 10Reedy) [01:24:29] (03CR) 10Siebrand: Fix indenting. Localise description (031 comment) [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/78790 (owner: 10Reedy) [01:24:42] ebernhardson: interesting. There might be a small advantage there... but what do you mean by "slowness of directory access"? [01:24:50] There is no fstat call, for xample [01:25:21] we just calculate the expected path, and if it isn't there, we fail [01:25:26] awight: ahh, i didn't look to close but PSR-(1? or 0?) had some inconsistencies where a file could have multiple possible paths [01:25:35] so the autolaoder had to check them [01:25:37] ebernhardson: yeah I scrapped that ;) [01:25:56] There are definitely places where it makes sense, but in our context it seemed expensive and unuseful [01:26:25] awight: so by slowness, i basically just meant fstat :) building the classmap ontop is a small gain, but compared to the rest of what MW does its proably incredibly minimal [01:27:26] ebernhardson: Yeah I think the compile-time step would be a new category of thing to maintain, also [01:31:24] ebernhardson: What I'd really like to learn is how one would profile the AutoLoader... [01:31:30] or the setup fastpath [01:31:43] awight: try xhprof? [01:31:57] awight: it is a freaking amazing php profilter [01:32:03] s/filter/filer/ [01:32:19] Yah I can get numbers from xdebug which seem reasonable, but they don't mean much cos it only covers a single invocation. [01:32:38] Unfortunately, you can't run the autoloader in a 10,000x loop [01:34:18] Gloria: what's the question? [01:34:28] legoktm: mooeypoo was having vagrant troubles. [01:35:37] mooeypoo: I have no clue. I know yurik got it to work on windows [01:36:24] mooeypoo: https://www.mediawiki.org/wiki/User:Yurik/Installing_Linux_virtual_box_under_Windows_7 [01:36:59] (03CR) 10Siebrand: [C: 04-1] "I agree with Matmarex that if you're renaming message keys, you should got all the way and rename the class and the file, too. There is on" [core] - 10https://gerrit.wikimedia.org/r/83584 (owner: 10Reedy) [01:37:40] awight: the xdebug stuff doesn't really mean much, xdebug adds an overhead of its own that really negates profiling information [01:38:34] awight: as for autoload in a loop, easiest would probably be to replace include $file; with $this->include($file) and use phpunit to mock just the include method [01:40:43] legoktm, yeah, yurik got it to work on Windows 7 :\ [01:41:06] But I'm so close now! I used to have a problem with git, now git seems to be working - but the VM connection is the issue (seems to be at least). [01:41:06] are you on 8? [01:41:09] :\ yes [01:41:13] :( [01:41:19] ... yes. [01:41:32] I do all my code work in Ubuntu (in a VM) [01:41:44] but I want to see if I can get an environment going in Windows too [01:42:00] I actually almost managed to get things going without vagrant [01:42:28] but then ran into random mw errors when trying to get parsoid/VE to work, and decided to once more try vagrant instead. Maybe I should go back to seeing if I can get those to work. [01:43:47] node.js works, got lamp server to work, installed mediawiki locally... VisualEditor is fetched fine through git, parsoid service is loaded (workers ready and all) -- and mediawiki carshed. [01:44:16] carshed? [01:44:17] ;D [01:44:44] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (036 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105873 (owner: 10Bsitu) [01:45:21] It did, vividly, in my mind, when instead of loading I got fatal errors. [01:45:34] I have a very vivid imagination [01:47:06] (03PS1) 10Werdna: Create test for bug 59637 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108879 [01:50:51] marktraceur: hey o/ [01:51:13] Hi! [01:51:22] prtksxna: How can I help you? :) [01:51:51] prtksxna: Sec, I have to go shoot someone (nerfily) [01:51:58] marktraceur: the changes that I need to make are mostly cosmetic [01:52:00] marktraceur: oh ok [01:52:29] marktraceur: wait what :P [01:53:28] (03PS2) 10Chad: Begin abstracting more of the database-specific search backend out [core] - 10https://gerrit.wikimedia.org/r/108187 [02:03:41] prtksxna: So yeah, my suggestion stands: Detect whether the preference is loaded, and whether the gadget is loaded, and then load your script [02:03:57] Dependent on the script that sets up the things you need [02:04:43] marktraceur: so, make no changes to the current gadget? any change I make should be on top of what is already happening? [02:04:55] (03Abandoned) 10Siebrand: (bug 28525) Add GENDER support for mwe-upwiz-source-ownwork-assert-* [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/31180 (owner: 10Amire80) [02:05:25] marktraceur: Did you get a chance to look at the JS? Doesn't it need some restructuring? Won't it end up stepping on someones feet in the future? [02:05:37] prtksxna: Well, maybe make changes that will support what you're doing - a 'loaded' event might be useful, e.g. [02:06:51] marktraceur: Alright! I think I understand. Will you be reviewing my code as well right? [02:07:06] marktraceur: I'll ping you if I get stuck somewhere! [02:07:09] Uhhh [02:07:23] ok, progress: Vagrant is up, things seem to be working ('vagrant ssh' works!) -- *but* http://127.0.0.1:8080 returns "No data received"... anyone has any idea? [02:07:30] prtksxna: I *might* review your code. [02:07:36] prtksxna: I have a lot of irons in the fire [02:08:20] marktraceur: Oh, alright. Cool! [02:11:27] (03CR) 10Reedy: "'Listadmins' => array( 'ListAdmins' )," [core] - 10https://gerrit.wikimedia.org/r/83584 (owner: 10Reedy) [02:11:38] (03CR) 10Parent5446: [C: 031] Begin abstracting more of the database-specific search backend out [core] - 10https://gerrit.wikimedia.org/r/108187 (owner: 10Chad) [02:17:25] (03CR) 10Parent5446: [C: 04-1] (bug 53835) Autodiscover classfiles via namespace hierarchy (031 comment) [core] - 10https://gerrit.wikimedia.org/r/59804 (owner: 10Adamw) [02:18:43] (03CR) 10Siebrand: "Also change, and yes, I guess..." [core] - 10https://gerrit.wikimedia.org/r/83584 (owner: 10Reedy) [02:26:46] <^d> AaronSchulz: cirrusSearchUpdatePages: 0 queued; 2480 claimed (2461 active, 19 abandoned); 0 delayed [02:27:03] <^d> That active number's been hovering around 2400 all afternoon. It seems...high [02:28:37] !log LocalisationUpdate completed (1.23wmf10) at 2014-01-22 02:28:36+00:00 [02:52:58] (03PS3) 10Gergő Tisza: WIP add jsduck support for MediaViewer [vagrant] - 10https://gerrit.wikimedia.org/r/108858 [02:55:51] !log LocalisationUpdate completed (1.23wmf11) at 2014-01-22 02:55:50+00:00 [03:09:09] (03CR) 10Gergő Tisza: "Apparently it is installed for root; the executable is in /root/.gem/bin/jsduck." [vagrant] - 10https://gerrit.wikimedia.org/r/108858 (owner: 10Gergő Tisza) [03:20:53] anyone knows how to handle Vagrant error "The requested URL /w/index.php was not found on this server." -- the vm's up, server seems to work okay--- but mediawiki is absent :\ ? [03:22:44] (03PS1) 10Andrew Bogott: Limit the dictionary cache size. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/108883 [03:23:47] (03CR) 10Andrew Bogott: "chad, is this what you meant?" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/108883 (owner: 10Andrew Bogott) [03:24:14] (03CR) 10Gergő Tisza: "This is caused by puppet/modules/misc/files/gem-home.sh (I35659c7) -> bug 60320" [vagrant] - 10https://gerrit.wikimedia.org/r/108858 (owner: 10Gergő Tisza) [03:33:21] !log LocalisationUpdate ResourceLoader cache refresh completed at 2014-01-22 03:33:21+00:00 [03:45:18] <^demon|away> AaronSchulz: Heh, they all shifted from active to abandoned. [03:45:21] <^demon|away> It'll be fine. [04:14:19] (03PS2) 10Andrew Bogott: Limit the project cache size. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/108883 [04:28:20] (03PS1) 10Mattflaschen: Generate CSS for KSS through RL, so it's exactly the same CSS [core] - 10https://gerrit.wikimedia.org/r/108885 [04:29:53] (03PS2) 10Mattflaschen: Generate CSS for KSS through ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/108885 [04:44:15] (03PS27) 10Alex Monk: Cross-wiki user rights UI should show target wiki groups instead of local [core] - 10https://gerrit.wikimedia.org/r/36330 [05:03:54] (03PS1) 10Hashar: Exceptions can now optionally have a dedup id [core] - 10https://gerrit.wikimedia.org/r/108890 [05:07:03] (03CR) 10Hashar: [C: 04-1] Exceptions can now optionally have a dedup id (031 comment) [core] - 10https://gerrit.wikimedia.org/r/108890 (owner: 10Hashar) [05:15:19] (03CR) 10Legoktm: "I can't think of a use case of where we would want to disallow posting in any talk namespace." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94698 (owner: 10Legoktm) [05:20:01] (03PS1) 10Gnosygnu: v1.1.3.2 [xowa] - 10https://gerrit.wikimedia.org/r/108892 [05:20:03] (03PS1) 10Gnosygnu: v1.1.3.2 [xowa] - 10https://gerrit.wikimedia.org/r/108893 [05:20:34] (03Abandoned) 10Gnosygnu: v1.1.3.2 [xowa] - 10https://gerrit.wikimedia.org/r/108892 (owner: 10Gnosygnu) [05:20:48] (03Abandoned) 10Gnosygnu: v1.1.3.2 [xowa] - 10https://gerrit.wikimedia.org/r/108893 (owner: 10Gnosygnu) [05:23:03] (03PS1) 10Gnosygnu: v1.1.3.2 [xowa] - 10https://gerrit.wikimedia.org/r/108894 [05:23:37] (03Abandoned) 10Gnosygnu: v1.1.3.2 [xowa] - 10https://gerrit.wikimedia.org/r/108894 (owner: 10Gnosygnu) [05:28:23] (03CR) 10Swalling: [C: 031] "Matt and I reviewed this patch locally on his vagrant, in most of the places using mw.ui in prod now:" [core] - 10https://gerrit.wikimedia.org/r/103494 (owner: 10JGonera) [05:37:56] (03CR) 10Mattflaschen: [C: 04-1] "Looks good overall, just a few minor things to address." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/103494 (owner: 10JGonera) [05:39:40] (03PS2) 10Hydriz: Add the ability to export pages within a prefix. [core] - 10https://gerrit.wikimedia.org/r/108487 [05:43:51] (03PS1) 10Gnosygnu: v1.1.3.2 [xowa] - 10https://gerrit.wikimedia.org/r/108896 [05:44:51] (03Abandoned) 10Gnosygnu: v1.1.3.2 [xowa] - 10https://gerrit.wikimedia.org/r/108896 (owner: 10Gnosygnu) [06:31:25] !log reedy synchronized wmf-config/InitialiseSettings.php [06:33:05] go reedy [06:36:07] ori: hmm, any resources you could think of off the top of your head about DOM performance on the client side? Writing JS for the app now, and since it does no HTTP requests directly, I just have to make sure I don't do stupid things with the DOM [06:36:36] other than just the usual performance things you've to take care of in writing any code? DOM specific stuff? [06:39:07] (03CR) 10Alex Monk: [C: 04-1] Update CentralAuth recent change notification code (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92461 (owner: 10Reedy) [06:39:59] People in club quarters should join shayar and I in the hotel bar. [06:44:23] *me [06:44:28] apology accepted [06:44:48] * ori teases werdna [06:47:41] yuvipanda: have to think about it, you are targetting a recent webkit right? [06:47:42] yuvipanda: http://wilsonpage.co.uk/preventing-layout-thrashing/ [06:47:51] ori: yeah, recentish webkit [06:48:17] & https://github.com/wilsonpage/fastdom [06:59:05] is there an easy way to send mass massges to a list of users with a pre-defined template with two variables? [06:59:29] like, using Special:MassMessage? ;-) [06:59:38] legoktm: globally? [06:59:44] yup [06:59:47] do it from meta [06:59:59] ori: thanks! [06:59:59] I think matanya said massges in order to include mass massages in the question [07:00:15] matanya: https://meta.wikimedia.org/wiki/GMD [07:00:31] format the list using https://meta.wikimedia.org/wiki/Template:Target [07:00:50] legoktm: the use case : https://meta.wikimedia.org/wiki/Admin_activity_review/2013/Data [07:01:13] I doubt you'll be able to use that one [07:01:14] makes sense [07:01:19] but you'd need to format the list [07:01:25] all listed users should be notified using the template: https://meta.wikimedia.org/wiki/Admin_activity_review/2013/Notice_to_inactive_right_holders/en?action=edit [07:01:52] but not sure how to assing the variables [07:01:57] not those who've been already notified, excluded or removed [07:02:24] of course [07:02:39] remember to ask a data refresh first [07:02:56] i can format the list easily, my question is regarding the variables [07:03:47] {{target|user=USERNAME | site=xx.wikipedia.org}} [07:03:55] I'm not aware of any variable [07:04:02] 08.00 < legoktm> format the list using https://meta.wikimedia.org/wiki/Template:Target [07:05:53] legoktm: i need in my message to refer to a specific right [07:06:42] you can either a) use a complicated parser function with a {{subst:#switch: {{PAGENAME}} ...}} or just create different lists for each right and send multiple messages [07:06:45] (I recommend the latter) [07:07:25] thank you legoktm i will :) [07:15:01] (03PS1) 10Reedy: Short circuit in notifyRCFeeds [core] - 10https://gerrit.wikimedia.org/r/108900 [07:18:42] (03PS2) 10Reedy: Short circuit in notifyRCFeeds [core] - 10https://gerrit.wikimedia.org/r/108900 [07:20:47] (03CR) 10Alex Monk: [C: 032] Short circuit in notifyRCFeeds [core] - 10https://gerrit.wikimedia.org/r/108900 (owner: 10Reedy) [07:22:24] Conspiracy. [07:22:54] (03PS5) 10Reedy: Update CentralAuth recent change notification code [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92461 [07:23:02] (03PS6) 10Reedy: Update CentralAuth recent change notification code [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92461 [07:24:12] (03Merged) 10jenkins-bot: Short circuit in notifyRCFeeds [core] - 10https://gerrit.wikimedia.org/r/108900 (owner: 10Reedy) [07:27:47] (03CR) 10PleaseStand: (bug 53835) Autodiscover classfiles via namespace hierarchy (033 comments) [core] - 10https://gerrit.wikimedia.org/r/59804 (owner: 10Adamw) [07:30:39] Reedy, actually can we rely on that core change for CA yet? [07:35:05] (03CR) 10Adamw: [C: 04-2] "I ran some profiling and found the following:" [core] - 10https://gerrit.wikimedia.org/r/59804 (owner: 10Adamw) [07:38:49] Just make sure it is merged first? [07:39:31] (03PS1) 10Reedy: Extract CentralAuth RC feed formatting [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/108901 [07:41:21] (03PS2) 10Reedy: Abstract CentralAuth RC feed formatting [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/108901 [07:43:32] Reedy, yeah... I guess we don't really need to wait for it to be in a release... [07:44:30] It's a pretty trivial dependency [07:44:56] (03CR) 10Alex Monk: [C: 032] Update CentralAuth recent change notification code [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92461 (owner: 10Reedy) [07:44:58] (03Merged) 10jenkins-bot: Update CentralAuth recent change notification code [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92461 (owner: 10Reedy) [07:45:35] (03Restored) 1001tonythomas: Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas) [07:58:01] (03CR) 10Aaron Schulz: [C: 032] Fix transcodes on files with long non-ascii names [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108170 (owner: 10Brian Wolff) [07:58:05] (03Merged) 10jenkins-bot: Fix transcodes on files with long non-ascii names [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108170 (owner: 10Brian Wolff) [08:22:42] (03CR) 10Adamw: "*Gurp* all times above are in microseconds, not milliseconds." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/59804 (owner: 10Adamw) [08:24:11] (03CR) 10Bartosz Dziewoński: "This is perverse. I like it." [core] - 10https://gerrit.wikimedia.org/r/108885 (owner: 10Mattflaschen) [09:05:04] (03PS30) 10Adamw: (bug 53835) Autodiscover classfiles via namespace hierarchy [core] - 10https://gerrit.wikimedia.org/r/59804 [09:26:56] (03CR) 10Andrew Bogott: [C: 032] Pass in a region to getHostByInstanceId [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/108009 (owner: 10Andrew Bogott) [09:27:01] (03Merged) 10jenkins-bot: Pass in a region to getHostByInstanceId [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/108009 (owner: 10Andrew Bogott) [09:27:32] (03CR) 10Matthias Mullie: [C: 032] Abort email notifications coming out of RecentChange [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108849 (owner: 10EBernhardson) [09:27:41] (03Merged) 10jenkins-bot: Abort email notifications coming out of RecentChange [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108849 (owner: 10EBernhardson) [09:28:52] (03CR) 10Matthias Mullie: [C: 032] Adjust classname to match capitalization [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108853 (owner: 10EBernhardson) [09:29:00] (03Merged) 10jenkins-bot: Adjust classname to match capitalization [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108853 (owner: 10EBernhardson) [09:46:50] (03CR) 10Matthias Mullie: Whitelist 'protect' and 'unprotect' core actions (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108871 (owner: 10EBernhardson) [09:47:04] (03PS3) 10Matthias Mullie: Whitelist 'protect' and 'unprotect' core actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108871 (owner: 10EBernhardson) [09:47:16] (03CR) 10Matthias Mullie: [C: 032] Whitelist 'protect' and 'unprotect' core actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108871 (owner: 10EBernhardson) [09:47:23] (03Merged) 10jenkins-bot: Whitelist 'protect' and 'unprotect' core actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108871 (owner: 10EBernhardson) [09:54:31] (03PS1) 10Manybubbles: WIP:Never run the plain highlighter on fuzzy queries [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108902 [09:54:36] (03PS1) 10Matthias Mullie: Whitelisted actions (like procted, unprotect) should be linked to [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108903 [10:02:53] (03CR) 10Matthias Mullie: Add 'Terms of use' below all user input box (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105873 (owner: 10Bsitu) [10:05:05] (03CR) 10Physikerwelt: "ok it's a valid patch that fixes the bug... but I think the code might be hard to understand" (031 comment) [extensions/LastModified] - 10https://gerrit.wikimedia.org/r/94091 (owner: 10Hydriz) [10:06:32] (03CR) 10Matthias Mullie: "I don't know Ruby!" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108879 (owner: 10Werdna) [10:07:02] (03PS5) 10Physikerwelt: Remove math specific code from ParserOptions [core] - 10https://gerrit.wikimedia.org/r/108490 [10:07:28] (03PS11) 10Physikerwelt: Validate TeX input for all renderers, not just texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/105187 [10:08:26] (03PS15) 10Physikerwelt: Remove call to deprecated ParserOptions::getMath [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 [10:16:03] (03CR) 10Physikerwelt: "Oh. I did not realize that you support branch now... great." [vagrant] - 10https://gerrit.wikimedia.org/r/107802 (owner: 10Physikerwelt) [10:19:53] (03CR) 10Physikerwelt: [C: 031] Fix compatibility with all skins [extensions/LastModified] - 10https://gerrit.wikimedia.org/r/106878 (owner: 10Hydriz) [10:46:56] (03CR) 10Hydriz: Check if the article exists first before actually displaying it. (031 comment) [extensions/LastModified] - 10https://gerrit.wikimedia.org/r/94091 (owner: 10Hydriz) [11:13:19] hi all [11:13:19] shiva_venkatesh, hey! [11:13:36] I'm using php with sql on WAMP [11:13:41] I need some help [11:14:42] How do I connect my php file to sql on WAMP [11:41:35] (03CR) 10Physikerwelt: Check if the article exists first before actually displaying it. (031 comment) [extensions/LastModified] - 10https://gerrit.wikimedia.org/r/94091 (owner: 10Hydriz) [11:56:15] (03PS1) 10Gerrit Patch Uploader: Clean up whitespace in various javascript files [core] - 10https://gerrit.wikimedia.org/r/108905 [11:56:17] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/108905 (owner: 10Gerrit Patch Uploader) [12:22:41] (03CR) 10Arav93: "Should anything else be added?" [core] - 10https://gerrit.wikimedia.org/r/108205 (owner: 10Arav93) [12:28:24] (03CR) 1001tonythomas: "You should go through Brians inline comment." [core] - 10https://gerrit.wikimedia.org/r/108205 (owner: 10Arav93) [12:52:26] (03PS2) 10Arav93: Put the space before category links to consideration [core] - 10https://gerrit.wikimedia.org/r/108205 [12:53:29] (03CR) 10Arav93: "Thanks 01tonythomas, I read the comments and made the changes." [core] - 10https://gerrit.wikimedia.org/r/108205 (owner: 10Arav93) [12:56:00] (03PS3) 10Amire80: Restore confirmation msgs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108700 (owner: 10Matthias Mullie) [12:59:51] (03CR) 10Amire80: [C: 032] Restore confirmation msgs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108700 (owner: 10Matthias Mullie) [12:59:56] (03Merged) 10jenkins-bot: Restore confirmation msgs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108700 (owner: 10Matthias Mullie) [13:27:18] !logs [13:27:18] channel logs: http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki/ html version: http://tools.wmflabs.org/wm-bot/logs/index.php?display=%23mediawiki [13:52:28] (03PS2) 10Gerrit Patch Uploader: Clean up whitespace in various javascript files [core] - 10https://gerrit.wikimedia.org/r/108905 [13:52:30] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/108905 (owner: 10Gerrit Patch Uploader) [14:33:48] !log csteipp synchronized php-1.23wmf11/includes/media 'bug60339' [14:34:15] !log csteipp synchronized php-1.23wmf10/includes/media 'bug60339' [15:13:11] (03CR) 10Legoktm: [C: 032] Fix compatibility with all skins [extensions/LastModified] - 10https://gerrit.wikimedia.org/r/106878 (owner: 10Hydriz) [15:13:14] (03Merged) 10jenkins-bot: Fix compatibility with all skins [extensions/LastModified] - 10https://gerrit.wikimedia.org/r/106878 (owner: 10Hydriz) [15:26:53] (03PS6) 10Gerrit Patch Uploader: Move toctoggle from mediawiki.util.js to separate file mediawiki.toc.js [core] - 10https://gerrit.wikimedia.org/r/106132 [15:26:55] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/106132 (owner: 10Gerrit Patch Uploader) [15:51:44] (03PS1) 10Ottomata: Adding wikimetrics role and module [vagrant] - 10https://gerrit.wikimedia.org/r/108922 [15:54:25] (03PS2) 10Ottomata: Adding wikimetrics role and module [vagrant] - 10https://gerrit.wikimedia.org/r/108922 [15:57:08] (03PS16) 10Umherirrender: Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas) [15:59:06] (03CR) 10Umherirrender: "Patch Set 16: Rebased (on top of Patch Set 13)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas) [16:14:10] (03PS4) 10TheDJ: CodeEditor: Add basic code completion and snippet support [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/106693 [17:08:35] (03PS1) 10Chad: Remove UpdatePages jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108925 [17:12:52] (03CR) 10Nemo bis: "Does this mean it's now possible to disable/abort enotifwatchlist for select pages, events or log types? We have a couple bugs needing it " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108849 (owner: 10EBernhardson) [17:17:19] (03PS2) 10Siebrand: Remove FakeMemCachedClient [core] - 10https://gerrit.wikimedia.org/r/106915 [17:22:32] (03PS2) 10Siebrand: Use 'brackets' message instead of hard coded brackets [core] - 10https://gerrit.wikimedia.org/r/100184 [17:25:14] (03PS2) 10Siebrand: Remove some deprecated global functions [core] - 10https://gerrit.wikimedia.org/r/106919 [17:27:15] (03PS1) 10Helder.wiki: Remove old username [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/108927 [17:27:21] (03PS1) 10Chad: Remove outdated todo. Never gonna happen. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108928 [17:27:44] (03CR) 10Chad: [C: 032] Remove outdated todo. Never gonna happen. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108928 (owner: 10Chad) [17:27:48] (03Merged) 10jenkins-bot: Remove outdated todo. Never gonna happen. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108928 (owner: 10Chad) [17:28:51] (03PS2) 10Siebrand: Remove deprecated MediaWiki::articleFromTitle() and WikiPage::createUpdates() [core] - 10https://gerrit.wikimedia.org/r/106920 [17:31:42] (03PS2) 10Siebrand: Avoid calling User::getSkin and remove pre-1.19 compat [extensions/FacebookOpenGraph] - 10https://gerrit.wikimedia.org/r/106943 [17:32:40] (03CR) 10Siebrand: Avoid calling User::getSkin and remove pre-1.19 compat (031 comment) [extensions/FacebookOpenGraph] - 10https://gerrit.wikimedia.org/r/106943 (owner: 10Siebrand) [17:38:48] (03PS1) 10Helder.wiki: Remove old username [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/108931 [17:42:38] (03PS1) 10Helder.wiki: Remove old username [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/108932 [17:47:10] (03PS1) 10Helder.wiki: Remove old username [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/108933 [17:49:09] ok, loitered long enough. time to get to SF :D [17:49:20] cu guys in a bit. [17:49:44] you're in town? [17:49:49] you need to say hi. [17:50:26] (03PS1) 10Helder.wiki: Remove old username [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/108935 [17:51:11] jorm: i'm going to Club Quarters now. [17:51:27] should be there around 1'ish [17:51:31] i'm working from home today but i'll be around thursday and friday. [17:52:35] (03PS1) 10Helder.wiki: Remove old username [extensions/UserOptionStats] - 10https://gerrit.wikimedia.org/r/108936 [17:53:04] jorm: cool [17:53:43] (03PS1) 10Helder.wiki: Remove old username [extensions/PrefStats] - 10https://gerrit.wikimedia.org/r/108937 [17:53:54] well i'm not sure what all CQ folks are doing, if they are all out in town or working at WMF, but i'm sure someone can drop me a line. :D [17:56:12] (03PS1) 10Helder.wiki: Remove old username [extensions/Widgets] - 10https://gerrit.wikimedia.org/r/108938 [17:56:31] (03CR) 10Jdlrobson: [C: 04-1] "On Mac I'm having issues running this." [core] - 10https://gerrit.wikimedia.org/r/108885 (owner: 10Mattflaschen) [17:56:54] hi [17:57:11] gi11es: So TrevorParscal has reviewed the fullscreen patch again, if you're game to finish it off [17:57:18] (03PS1) 10Helder.wiki: Remove old username [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/108939 [17:57:45] gi11es: His thought is that the event should get a context object passed in that has the element and a boolean telling us whether it's fullscreened or not [17:58:02] I explained in detail to mark already, but I think the point is that we need to pass the boolean fullscreen state into the event handler due to asynchronous event handling in JavaScript [17:58:08] yes [17:58:13] (03PS1) 10Helder.wiki: Remove old username [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/108940 [17:58:28] I considered passing both the element and a booleanized value [17:58:31] how about that? [17:58:48] yes, pass both [17:58:55] gi11es: TrevorParscal seems to think that an object with both is the best answer, but I'm open to either way [17:59:04] Oh, maybe I misunderstood [17:59:17] yes, object with both [17:59:20] sounds good to me, I almost did this [17:59:24] 'kay [17:59:31] (03PS1) 10Helder.wiki: Remove old username [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/108941 [17:59:34] Maybe we can get it merged today [17:59:55] that will give the user of the event the option to either know what change of state caused the event, or what the current state is (using the isFullscreened data) which might not always be the same due to async event handling [18:01:57] (03PS2) 10Werdna: Create test for bug 59637 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108879 [18:02:23] (03CR) 10Werdna: "Don't worry, I don't know anything about Ruby either." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108879 (owner: 10Werdna) [18:02:45] (03CR) 10Werdna: Create test for bug 59637 (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108879 (owner: 10Werdna) [18:03:34] werdna: did you ask about the time/date thing in rtl? [18:03:45] wrong room ... [18:05:11] (03CR) 10EBernhardson: [C: 032] Whitelisted actions (like procted, unprotect) should be linked to [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108903 (owner: 10Matthias Mullie) [18:05:17] (03Merged) 10jenkins-bot: Whitelisted actions (like procted, unprotect) should be linked to [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108903 (owner: 10Matthias Mullie) [18:07:36] ebernhardson: just asking in -i18n now [18:10:31] (03PS1) 10Chad: Remove WikibaseQueryEngine submodule, repo to be deleted [extensions] - 10https://gerrit.wikimedia.org/r/108942 [18:10:45] (03CR) 10Chad: [C: 032 V: 032] Remove WikibaseQueryEngine submodule, repo to be deleted [extensions] - 10https://gerrit.wikimedia.org/r/108942 (owner: 10Chad) [18:13:00] andre__: Could I get added to the default CC list for the Wikimedia/Logstash component? [18:15:46] bd808: you are [18:15:50] on it, I mean [18:18:55] (03PS19) 10Gilles: Create jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [18:19:28] (03CR) 10Hashar: Add link to MultimediaViewer docs (031 comment) [integration/docroot] - 10https://gerrit.wikimedia.org/r/108870 (owner: 10MarkTraceur) [18:19:32] (03CR) 10jenkins-bot: [V: 04-1] Create jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [18:23:01] (03CR) 10Bsitu: Add 'Terms of use' below all user input box (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105873 (owner: 10Bsitu) [18:25:11] (03CR) 10EBernhardson: [C: 032] Add quick and dirty script to convert a Flow page to text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107733 (owner: 10Werdna) [18:25:20] (03Merged) 10jenkins-bot: Add quick and dirty script to convert a Flow page to text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107733 (owner: 10Werdna) [18:26:47] (03PS1) 10EBernhardson: Must provide make target for ee-flow rule [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108944 [18:27:37] hashar: FFS, it turns out I actually don't have the rights to modify jobs, it just doesn't *crash* when I try that [18:27:56] marktraceur: something must be wrong in Jenkins permission matrix :( [18:28:14] moizsyed, hi [18:28:37] Yeah [18:29:00] Also amusing: Jenkins will happily give you a valid-looking configuration page, and API token, for users that DON'T BLOODY EXIST [18:29:40] ...wat [18:29:48] (03CR) 10OliverKeyes: [C: 031] "Looks good; 14 is too large, 9 too small, and 11 juuust right :)." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/108512 (owner: 10Roopak) [18:30:32] hashar: Also, the docs say integration.mediawiki.org...confusing but I'll fix it [18:31:06] thx [18:31:15] 1 1 with rob [18:31:38] (03CR) 10OliverKeyes: "In the future, though, please add the actual extension maintainers to the review list." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/108512 (owner: 10Roopak) [18:32:05] (03CR) 10Bsitu: [C: 032] Changed the font size used for subheading in notificatons [extensions/Echo] - 10https://gerrit.wikimedia.org/r/108512 (owner: 10Roopak) [18:32:14] (03Merged) 10jenkins-bot: Changed the font size used for subheading in notificatons [extensions/Echo] - 10https://gerrit.wikimedia.org/r/108512 (owner: 10Roopak) [18:32:17] (03CR) 10MarkTraceur: Add link to MultimediaViewer docs (031 comment) [integration/docroot] - 10https://gerrit.wikimedia.org/r/108870 (owner: 10MarkTraceur) [18:32:32] hashar: Now that's ^^ good to go, FWIW [18:35:23] (03CR) 10Jdlrobson: "recheck" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/104907 (owner: 10M4tx) [18:39:23] (03PS3) 10Bsitu: Add 'Terms of use' below all user input box [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105873 [18:39:48] werdna: you do have BROWSER_LABEL set properly, yes? $ echo $BROWSER_LABEL [18:39:49] chrome [18:40:52] chrismcmahon: was using BROWSER_LABEL=phantomjs bundle exec phantomjs [18:41:01] have just tried using export and it also fails [18:41:44] werdna: sorry about window switch. still thinking. [18:42:29] werdna: wait, "bundle exec phantomjs"? that's garbled I think [18:42:43] sorry, bundle exec cucumber [18:42:48] werdna: yep [18:43:13] how does one use ruby-debug? [18:45:39] (03PS21) 10Bsitu: Topic and Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 [18:45:43] (03PS2) 10EBernhardson: Must provide make target for ee-flow rule [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108944 [18:46:13] (03CR) 10Bsitu: "Rebased, haven't addressed the feedback yet" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu) [18:46:30] (03CR) 10Bsitu: [C: 04-1] Topic and Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu) [18:47:23] ori: Excellent. I guess I didn't remember that you set that up (logstash in bugzilla) [18:56:32] (03CR) 10Aaron Schulz: [C: 032] Remove FakeMemCachedClient [core] - 10https://gerrit.wikimedia.org/r/106915 (owner: 10Siebrand) [18:57:41] (03PS3) 10EBernhardson: Must provide make target for ee-flow rule [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108944 [18:58:22] (03PS2) 10EBernhardson: Run update.php in `make master` [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106484 (owner: 10Spage) [18:58:44] (03CR) 10EBernhardson: [C: 032] Run update.php in `make master` [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106484 (owner: 10Spage) [18:58:49] (03Merged) 10jenkins-bot: Run update.php in `make master` [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106484 (owner: 10Spage) [18:59:14] (03CR) 10EBernhardson: [C: 032] Must provide make target for ee-flow rule [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108944 (owner: 10EBernhardson) [18:59:19] (03Merged) 10jenkins-bot: Must provide make target for ee-flow rule [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108944 (owner: 10EBernhardson) [18:59:49] (03Merged) 10jenkins-bot: Remove FakeMemCachedClient [core] - 10https://gerrit.wikimedia.org/r/106915 (owner: 10Siebrand) [19:06:02] (03PS2) 10Umherirrender: Split documentation for $wgRCLinkLimits/$wgRCLinkDays [core] - 10https://gerrit.wikimedia.org/r/108466 [19:10:25] (03CR) 10EBernhardson: [C: 04-1] "per bennys comment" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107149 (owner: 10Matthias Mullie) [19:12:02] (03CR) 10EBernhardson: [C: 032] Additional Makefile commands [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108475 (owner: 10EBernhardson) [19:12:05] (03CR) 10jenkins-bot: [V: 04-1] Additional Makefile commands [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108475 (owner: 10EBernhardson) [19:26:58] Krenair: Creme eggs. Yes or no? [19:27:25] yes. [19:32:18] !log reedy synchronized wmf-config/ [19:36:13] (03CR) 10Anomie: Various fixes to job running code in Wiki.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/108740 (owner: 10Aaron Schulz) [19:36:31] (03CR) 10Reedy: "Will the translate exports just re-add them? Or not because the old username doesn't exist because it was renamed etc?" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/108931 (owner: 10Helder.wiki) [19:42:07] (03PS2) 10EBernhardson: Additional Makefile commands [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108475 [19:44:36] (03PS1) 10Reedy: Add COPYING [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/108949 [19:50:57] (03PS3) 10Reedy: Fix indenting. Localise description [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/78790 [19:51:09] (03CR) 10Zbynek: [C: 032 V: 032] "License file looks OK." [extensions/GeoGebra] - 10https://gerrit.wikimedia.org/r/104481 (owner: 10Rudolf.grossmann) [19:55:04] (03CR) 10Reedy: "Where do we put class_alias() calls? There's non currently in core for example" [core] - 10https://gerrit.wikimedia.org/r/83584 (owner: 10Reedy) [19:56:21] (03PS1) 10Manybubbles: Lower default batch size for skipParse [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108950 [19:56:42] (03PS1) 10Manybubbles: WIP: Always search plain text and stemmed text [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108951 [19:57:18] (03CR) 10Umherirrender: "When the GUI has this, api.php action=purge should also have this. Needs null entry in DefaultSettings.php for wgRateLimits like the other" [core] - 10https://gerrit.wikimedia.org/r/87269 (owner: 10Reedy) [19:57:28] (03PS1) 10Manybubbles: WIP: Build documents in three hooks [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108952 [19:59:13] (03CR) 10Manybubbles: "I wanted to see how this three hook thing compares to having a single hook like in Iff0bf5d52ad2f35921c6734f3fb748bf360f2e9d so I wrote th" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108952 (owner: 10Manybubbles) [19:59:32] (03PS2) 10Manybubbles: Remove UpdatePages jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108925 (owner: 10Chad) [20:00:04] (03CR) 10Reedy: "There is?" [core] - 10https://gerrit.wikimedia.org/r/87269 (owner: 10Reedy) [20:01:05] (03CR) 10Manybubbles: [C: 031] Begin abstracting more of the database-specific search backend out [core] - 10https://gerrit.wikimedia.org/r/108187 (owner: 10Chad) [20:01:50] (03CR) 10Anomie: [C: 031] "Seems sane. Haven't tested" [core] - 10https://gerrit.wikimedia.org/r/108287 (owner: 10MrBlueSky) [20:03:06] (03CR) 10Umherirrender: "Yah, was a draft from yesterday, DefaultSettings.php was already added by you yesterday. sorry." [core] - 10https://gerrit.wikimedia.org/r/87269 (owner: 10Reedy) [20:03:31] (03PS2) 10Manybubbles: WIP:Never run the plain highlighter on fuzzy queries [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108902 [20:04:32] (03CR) 10Helder.wiki: "The account was renamed on Translatewiki a few years ago[1], and is not used anymore." [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/108931 (owner: 10Helder.wiki) [20:06:26] (03CR) 10Umherirrender: "Release notes? There is a "Removed classes" section already." [core] - 10https://gerrit.wikimedia.org/r/108179 (owner: 10Aaron Schulz) [20:06:41] (03PS2) 10Anomie: Requested additional options [extensions/Collection] - 10https://gerrit.wikimedia.org/r/107620 [20:06:43] (03CR) 10jenkins-bot: [V: 04-1] Requested additional options [extensions/Collection] - 10https://gerrit.wikimedia.org/r/107620 (owner: 10Anomie) [20:09:44] (03PS3) 10Anomie: Requested additional options [extensions/Collection] - 10https://gerrit.wikimedia.org/r/107620 [20:18:43] (03PS1) 10Umherirrender: Remove TODO for use of TRUNCATE and replace with comment [core] - 10https://gerrit.wikimedia.org/r/108960 [20:21:15] Reedy, you may have already answered this but it seems I got disconnected just after I asked it earlier: is there some way of finding out what happened to a wiki password reset email to someone? [20:22:01] yes there is, to some degree (whether it was sent) [20:22:20] was it you asking some days ago? IIRC the answer was that it had been sent [20:22:32] no idea how/if more can be found [20:24:18] No this came to my attention yesterday [20:31:55] (03CR) 10Frédéric Wang: [C: 031] Validate TeX input for all renderers, not just texvc (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/105187 (owner: 10Physikerwelt) [20:35:46] (03PS8) 10AndyRussG: Basic state machinery [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/107307 (owner: 10Adamw) [20:39:54] (03CR) 10Chad: [C: 032 V: 032] Replace usage of deprecated Title::escapeLocalURL() [extensions/ScanSet] - 10https://gerrit.wikimedia.org/r/104361 (owner: 10Siebrand) [20:40:53] (03CR) 10Chad: [C: 032] Replace usage of deprecated Title::escapeLocalURL() [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/104363 (owner: 10Siebrand) [20:40:55] (03Merged) 10jenkins-bot: Replace usage of deprecated Title::escapeLocalURL() [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/104363 (owner: 10Siebrand) [20:41:26] (03CR) 10Chad: [C: 032 V: 032] Replace usage of deprecated Title::escapeLocalURL() [extensions/Video] - 10https://gerrit.wikimedia.org/r/104366 (owner: 10Siebrand) [20:44:15] is there any way to get interwiki/sister project stuff about a page from the api? [20:44:22] more specifically sister project stuff. [20:45:05] which sister projects? [20:45:34] wikiversity, wiktionary, etc. [20:45:40] there are things in teh page - templates. [20:45:48] but i'm wanting to explore automating that. [20:46:07] per this: https://meta.wikimedia.org/wiki/Requests_for_comment/Interproject_links_interface [20:46:13] hmmm, eventually wikidata api (only wikivoyage and wikisource + wikipedia) [20:46:26] eventually all projects [20:47:49] e.g. https://www.wikidata.org/w/api.php?action=wbgetentities&ids=q60&format=json [21:13:44] (03PS2) 10Ori.livneh: Making default apache vhost listen be *:80 [vagrant] - 10https://gerrit.wikimedia.org/r/108640 (owner: 10Ottomata) [21:14:18] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/108949 (owner: 10Reedy) [21:14:20] (03Merged) 10jenkins-bot: Add COPYING [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/108949 (owner: 10Reedy) [21:14:59] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/107765 (owner: 10Reedy) [21:15:01] (03Merged) 10jenkins-bot: Add COPYING [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/107765 (owner: 10Reedy) [21:15:46] (03PS5) 10Reedy: Minor parameter documentation improvements [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/76006 [21:17:32] (03PS1) 10Reedy: Add COPYING [extensions/timeline] - 10https://gerrit.wikimedia.org/r/108967 [21:18:16] guys [21:18:20] zomg [21:18:22] liek [21:18:22] hai [21:18:27] HAI :D [21:18:37] lol coincidence, ty [21:18:42] anyway, when I am uploading my first version of an extension [21:18:47] what should I do exactly [21:18:56] I'm stuck with it again... [21:18:57] Have you got a gerrit reepo for it? [21:19:00] yep [21:19:04] hai Joeytje50 [21:19:13] hai [21:19:17] You can just make the commit and git review it [21:19:41] have you made a local copy of the repo and put the files in it? [21:19:42] and what's this with gitreview? [21:20:15] git push origin HEAD:refs/for/master [21:20:25] cd /to/your/extension [21:20:26] git init. [21:20:44] git remote add origin ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/YOUREXTNAMEHERE.git [21:20:46] git fetch origin [21:20:50] git push HEAD:refs/for/master [21:20:54] something along those lines [21:20:58] (03CR) 10Anomie: Add tests for API's assert={user|bot} (031 comment) [core] - 10https://gerrit.wikimedia.org/r/108291 (owner: 10Legoktm) [21:21:11] can never reminder the exact ssh url though [21:21:11] (03PS3) 10Reedy: Add COPYING [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/107764 [21:21:16] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/107764 (owner: 10Reedy) [21:21:21] (03Merged) 10jenkins-bot: Add COPYING [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/107764 (owner: 10Reedy) [21:21:29] jenkins is sooooooo fast [21:22:04] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/timeline] - 10https://gerrit.wikimedia.org/r/108967 (owner: 10Reedy) [21:22:06] (03Merged) 10jenkins-bot: Add COPYING [extensions/timeline] - 10https://gerrit.wikimedia.org/r/108967 (owner: 10Reedy) [21:22:07] git fetch origin [21:22:07] Permission denied (publickey) [21:22:18] might need to specify username [21:22:24] didn't ask me for one [21:22:27] in case your local username is different from the one you are using for Gerrit [21:22:37] yeah it default to your local username [21:22:42] as an example, my local username is "amusso", my gerrit username is "hashar" [21:22:50] so my URL have to be: hashar@gerrit.wikimedia.org [21:23:02] ah ok [21:23:09] (or you can play with ssh configuration file to specify the username for *.wikimedia.org hosts) [21:23:36] in ~/.ssh/config something like: [21:23:39] (03PS1) 10Reedy: Add COPYING [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/108968 [21:23:40] Host *.wikimedia.org [21:23:44] User hashar [21:24:06] you also need to add your ssh public key in your Gerrit preferences [21:24:13] (03PS3) 10Reedy: Added missing message to OpenStackManager.i18n file [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/108513 (owner: 10Tinaj1234) [21:24:18] (03CR) 10Reedy: [C: 032] Added missing message to OpenStackManager.i18n file [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/108513 (owner: 10Tinaj1234) [21:24:20] (03Merged) 10jenkins-bot: Added missing message to OpenStackManager.i18n file [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/108513 (owner: 10Tinaj1234) [21:24:27] Reedy: hi, thanks for merging https://gerrit.wikimedia.org/r/108163 , have you looked if it on now and works? [21:24:31] (03CR) 10Anomie: [C: 032] Expand documentation around $wgAPI*Modules [core] - 10https://gerrit.wikimedia.org/r/108411 (owner: 10Umherirrender) [21:24:40] Joeytje50: should get a ssh key at https://gerrit.wikimedia.org/r/#/settings/ssh-keys :D [21:24:52] focusing on meeting now [21:24:56] hasharMeeting: the fingerprint? [21:25:00] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/108968 (owner: 10Reedy) [21:25:06] Joeytje50: the public part of your key [21:25:06] (03Merged) 10jenkins-bot: Add COPYING [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/108968 (owner: 10Reedy) [21:25:16] should be ~/.ssh/id_rsa.pub [21:26:10] something like: ssh-rsa AAAAB3Nz……. hashar@wmflabs [21:26:18] where ……. is a ton of alphanumeritcs [21:27:50] (03Merged) 10jenkins-bot: Expand documentation around $wgAPI*Modules [core] - 10https://gerrit.wikimedia.org/r/108411 (owner: 10Umherirrender) [21:29:57] (03PS1) 10Reedy: Add COPYING [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/108969 [21:30:40] (03PS1) 10Reedy: Add COPYING [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/108970 [21:32:10] awight: cheers for the phantom tips [21:32:23] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/108970 (owner: 10Reedy) [21:32:27] I think my problem though is that I don't understand how ruby is calling phantom [21:32:28] (03Merged) 10jenkins-bot: Add COPYING [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/108970 (owner: 10Reedy) [21:32:30] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/108969 (owner: 10Reedy) [21:32:33] hasharMeeting: was that git push HEAD:refs/for/master meant as a literal command? [21:32:34] (03Merged) 10jenkins-bot: Add COPYING [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/108969 (owner: 10Reedy) [21:32:44] or should I replace something in the refs/for/master [21:33:15] (03PS2) 10Reedy: Add COPYING [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/107795 [21:33:20] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/107795 (owner: 10Reedy) [21:33:22] (03Merged) 10jenkins-bot: Add COPYING [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/107795 (owner: 10Reedy) [21:33:29] werdna: right on. If you invent anything useful, send it back our way. [21:33:32] (03PS3) 10Manybubbles: Never run the plain highlighter on fuzzy queries [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108902 [21:33:44] awight: shall do [21:33:51] (03PS2) 10Reedy: Add COPYING [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/107793 [21:33:54] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/107793 (owner: 10Reedy) [21:34:12] (03PS3) 10Reedy: Add COPYING [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/107789 [21:34:17] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/107789 (owner: 10Reedy) [21:34:19] (03Merged) 10jenkins-bot: Add COPYING [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/107789 (owner: 10Reedy) [21:34:45] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/107788 (owner: 10Reedy) [21:34:46] Joeytje50: git push origin [21:34:47] (03Merged) 10jenkins-bot: Add COPYING [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/107788 (owner: 10Reedy) [21:34:57] Joeytje50: then you have to specify what you want to push and to what [21:35:04] (03CR) 10Reedy: [V: 032] Add COPYING [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/107793 (owner: 10Reedy) [21:35:21] so you would usually push your last commits (HEAD) and want them to be purposed in Gerrit against the master branch ( refs/for/master ) [21:35:32] Joeytje50: so should be : git push origin HEAD:refs/for/master [21:35:39] git-review is a python utility which wrap around that [21:35:42] (03CR) 10EBernhardson: [C: 032] Additional Makefile commands [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108475 (owner: 10EBernhardson) [21:35:48] (03Merged) 10jenkins-bot: Additional Makefile commands [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108475 (owner: 10EBernhardson) [21:35:48] you are not required to use git-review though [21:36:14] error: src refspec HEAD does not match any. [21:36:53] (03CR) 10Sharihareswara: [C: 031] "Nicely done! Congrats on getting your change submitted into Gerrit." [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/108474 (owner: 10Robert Roos) [21:37:25] (03PS1) 10Reedy: Add COPYING [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/108971 [21:38:22] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/108971 (owner: 10Reedy) [21:38:24] (03Merged) 10jenkins-bot: Add COPYING [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/108971 (owner: 10Reedy) [21:38:26] (03PS1) 10Werdna: Allow word breaks at any place in links. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108972 [21:39:55] (03PS1) 10Reedy: Add COPYING [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/108973 [21:40:44] afternoon [21:41:08] werdna: is Flow GPL? [21:41:27] I believe so, but that is a Maryana question [21:42:08] The header in Flow.php looks GPL-esk, but doesn't actually say [21:42:21] ask ebernhardson as well maybe [21:42:26] (03PS1) 10Reedy: Add COPYING [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108974 [21:42:29] my contract requires me to release everything under GPL [21:42:31] I'll make a changeset and add them for review [21:42:33] Right, exactly [21:42:37] jdlrobson, are you around? [21:42:41] Kaldari seems to MIT everything [21:42:58] (03CR) 10Ottomata: Making default apache vhost listen be *:80 (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/108640 (owner: 10Ottomata) [21:43:03] (03CR) 10Werdna: "http://jsfiddle.net/72MHH/ shows this working correctly." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108972 (owner: 10Werdna) [21:43:52] (03PS1) 10Reedy: Add COPYING [extensions/Echo] - 10https://gerrit.wikimedia.org/r/108975 [21:43:55] thedj: In SF? [21:44:30] Reedy: well technically I can also MIT [21:44:59] I don't care so much which it is :) [21:45:14] just GPL and we can sort it out later [21:45:27] WMF holds copyright in everything so they can relicense as they see fit [21:45:33] I created a changeset and CC'd Maryana etc [21:46:00] Reedy: yup, at Club Quarters now [21:46:07] (03CR) 10Werdna: [C: 031] Add COPYING [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108974 (owner: 10Reedy) [21:46:17] thedj: I guess you can bring other folks from the club quarters to the wmf office [21:46:37] thedj: I definitely want to meet folks tonight to avoid wasting 2 hours tomorrow morning :-] [21:47:01] hasharMeeting: i could. if i knew where in CQ they are :D [21:47:12] thedj: ask the reception maybe ? [21:47:21] thedj: everyone should be flagged with "Wikimedia" or something [21:47:23] yuvipanda: poke! [21:47:26] or we could ask Rachel Farrand [21:47:32] they usually won't give out room numbers at hotels for security reasons [21:47:35] they will however call rooms for you [21:47:56] "hey would you mind calling everyone? :D" [21:48:05] Who's actually there? ;) [21:48:17] who would we still have here then ? because i think most contractors are actually already in the office today :D [21:48:19] ask on the hangout? [21:48:29] Daniel Kinzler and Krenair are already in the office [21:48:31] (for starters) [21:48:48] thedj: ah yeah we have set up a google hangout room . If you have a data plan on your phone and google hangout installed, I can get you invited in the room [21:48:58] No Rachel on irc :( [21:48:59] thedj: just pass me in private your google email registered for hangout [21:49:06] Reedy: try ichat [21:49:07] :D [21:49:17] err jabber / google chat [21:50:03] she is out for lunch [21:51:56] i have a gophone contract for the month, so i also have data :D [21:53:51] hasharMeeting: I've set up git-review, and all seemed fine and quite easy to do actually, but then of course on the last step of https://www.mediawiki.org/wiki/Gerrit/git-review#Submitting_changes_with_git-review [21:54:10] it gave me Fatal: Needed a single revision [21:55:12] Joeytje50: ahh [21:55:16] with the commit, it said On branch master Initial commit Untracked files: [list] nothing added to commit but untracked files present [21:55:18] you did git init but need a commit [21:55:32] do you have any commit in repository ? [21:55:35] git log would tell [21:55:45] or to see HEAD commit: git show --stat [21:56:03] fatal: bad default revision HEAD [21:56:05] if you have untracked files (list), you want to add those files with git add [21:56:07] fatal: bad default revision 'HEAD' [21:56:10] yeah so you have no commit [21:56:14] ah ok [21:56:17] you want to add untracked files to the index [21:56:19] with : git add [21:56:25] ok [21:56:32] once you are happy with files you have added, you can review the patch with: git diff --staged [21:56:37] (03CR) 10Anomie: "This looks like it'll shape up much better than the old version." (039 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm) [21:56:40] then craft a commit with git commit [21:56:44] fill in a message [21:57:01] then review the commit with git show [21:57:07] git show? [21:57:11] not git-review? [21:57:20] git show is used to inspect a commit [21:57:25] shows up the commit message and the diff [21:57:34] ah [21:57:57] but my commit will be 58kb, so I don't think that'll fit in the bash interface :P [21:58:07] I highly recommend reading the progit book at http://www.git-scm.com/book :D [21:58:22] git show will paginate the output if it is too long [21:58:29] so you are only show the first page [21:58:34] then press space bar to get the next page [21:58:40] ah ok [21:59:08] I assume if it's okay, I can commit it gia git-review [21:59:10] via* [21:59:22] (03PS1) 10Spage: Remove unneeded 'require "page-object"' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108979 [22:01:44] (03CR) 10Chad: [C: 032] Update/add documentation in the LoadBalancer class [core] - 10https://gerrit.wikimedia.org/r/106872 (owner: 10Siebrand) [22:02:02] hasharMeeting: when I run git-review I get another error [22:02:12] error: could not apply 9c1cb6e... Version 1.0 [22:02:48] where Version 1.0 is the message I used for this commit [22:02:49] might be because it is the first commit [22:03:02] can you try pushing directly (i.e. without git-review) [22:03:09] should be: git push origin HEAD:refs/for/master [22:03:12] (03CR) 10Chad: [C: 032] Provide correct type as input for LoadMonitor::postConnectionBackoff() [core] - 10https://gerrit.wikimedia.org/r/106873 (owner: 10Siebrand) [22:03:23] (03CR) 10Chad: [C: 032] Call Linker::formatSize statically [extensions/MediaFunctions] - 10https://gerrit.wikimedia.org/r/106874 (owner: 10Siebrand) [22:03:29] (03CR) 10Chad: [V: 032] Call Linker::formatSize statically [extensions/MediaFunctions] - 10https://gerrit.wikimedia.org/r/106874 (owner: 10Siebrand) [22:03:41] Total 0 (delta 0), reused 0 (delta 0) [22:05:07] hasharMeeting: is that supposed to happen? it says "error: failed to push some refs to 'ssh://Joeytje50@gerrit.wikimedia.org:29418/mediawiki/extensions/Tabs.git" [22:05:21] (03Merged) 10jenkins-bot: Update/add documentation in the LoadBalancer class [core] - 10https://gerrit.wikimedia.org/r/106872 (owner: 10Siebrand) [22:05:26] Joeytje50: not sure [22:05:36] Joeytje50: anyone should be able to push under refs/for/master [22:06:13] (03Merged) 10jenkins-bot: Provide correct type as input for LoadMonitor::postConnectionBackoff() [core] - 10https://gerrit.wikimedia.org/r/106873 (owner: 10Siebrand) [22:06:29] hasharMeeting: it also says "! [remote rejected] HEAD -> refs/for/master (no new changes)" [22:06:41] ohh [22:06:55] seems change is already in gerrit so [22:06:59] (03CR) 10Alex Monk: "Looks good, but needs a foundation config change so production doesn't break." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/108901 (owner: 10Reedy) [22:07:09] hmm no [22:07:24] does "git show" shows up your commit ? [22:07:49] meeting break [22:08:41] (03CR) 10Reedy: "I merged and deployed my original config change... So I just need to add a formatter key to finish it off before deployed" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/108901 (owner: 10Reedy) [22:09:45] !log reedy updated /a/common to {{Gerrit|Ie95fdf8e9}}: Adjust linkpurge and renderfile limits [22:09:59] hasharMeeting: yes it does show something, but not all the changes I've made, somehow [22:10:23] it shows an old version of the dir, and shows an (END) thing there [22:11:01] (03PS1) 10Reedy: Add COPYING [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/108983 [22:11:03] ctrl+c doesn't seem to clear the (END) label there [22:11:08] (03CR) 10SG: [C: 031] "That's all secondary and can be solved in a later patch. This resolves the current outstanding issue of how the code itself is structured " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101903 (owner: 10Matthias Mullie) [22:11:39] (03PS1) 10Reedy: Add COPYING [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/108984 [22:13:14] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/108983 (owner: 10Reedy) [22:13:21] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/108984 (owner: 10Reedy) [22:13:23] (03Merged) 10jenkins-bot: Add COPYING [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/108983 (owner: 10Reedy) [22:13:26] (03Merged) 10jenkins-bot: Add COPYING [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/108984 (owner: 10Reedy) [22:14:14] (03CR) 10Chad: [C: 032 V: 032] Replace deprecated Block::infinity (1.18) [extensions/AuthorProtect] - 10https://gerrit.wikimedia.org/r/106910 (owner: 10Siebrand) [22:14:39] (03PS1) 10Reedy: Add COPYING [extensions/EmailCapture] - 10https://gerrit.wikimedia.org/r/108985 [22:14:47] (03CR) 10Chad: [C: 032] Add stats groups to searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108835 (owner: 10Manybubbles) [22:14:54] (03Merged) 10jenkins-bot: Add stats groups to searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108835 (owner: 10Manybubbles) [22:15:14] (03CR) 10Chad: [C: 032] Lower default batch size for skipParse [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108950 (owner: 10Manybubbles) [22:15:19] (03Merged) 10jenkins-bot: Lower default batch size for skipParse [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108950 (owner: 10Manybubbles) [22:16:58] (03PS1) 10Reedy: Add COPYING [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/108986 [22:20:43] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/EmailCapture] - 10https://gerrit.wikimedia.org/r/108985 (owner: 10Reedy) [22:20:45] (03Merged) 10jenkins-bot: Add COPYING [extensions/EmailCapture] - 10https://gerrit.wikimedia.org/r/108985 (owner: 10Reedy) [22:20:58] (03CR) 10Werdna: "Yeah, see I still think too much code is duplicated. The way I would handle the slight differences would be to add a "getConflictHandler" " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 (owner: 10Matthias Mullie) [22:21:08] (03PS2) 10Manybubbles: WIP: Always search plain text and stemmed text [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108951 [22:23:14] (03PS2) 10Reedy: Add wfWaitForSlaves() call in ClearMessageBlobs loop [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/108838 [22:24:46] (03CR) 10Chad: [C: 04-1] "I like the idea in theory. Comments inline." (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108952 (owner: 10Manybubbles) [22:26:20] (03CR) 10Chad: [C: 032] Never run the plain highlighter on fuzzy queries [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108902 (owner: 10Manybubbles) [22:26:26] (03Merged) 10jenkins-bot: Never run the plain highlighter on fuzzy queries [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108902 (owner: 10Manybubbles) [22:28:08] (03PS1) 10Joeytje50: Version 1.0 [extensions/Tabs] - 10https://gerrit.wikimedia.org/r/108992 [22:28:10] (03PS1) 10Joeytje50: Version 1.0 [extensions/Tabs] - 10https://gerrit.wikimedia.org/r/108993 [22:29:13] hasharMeeting: am I doing it right? [22:29:34] I have no idea where my files would be visible on the webinterface there [22:30:32] Joeytje50: That looks to have worked at least [22:31:06] yeah, but how do I see if the correct version is on gerrit now? [22:31:24] https://gerrit.wikimedia.org/r/#/c/108992/1 [22:31:28] Look at the patchset at the bottom [22:31:30] it's numerous diffs [22:32:15] You've got numerous unresolved rebase issues [22:33:03] (03CR) 10Reedy: "Most files have merge conflicts that need resolving" (035 comments) [extensions/Tabs] - 10https://gerrit.wikimedia.org/r/108992 (owner: 10Joeytje50) [22:33:13] (03CR) 10Reedy: [C: 04-1] Version 1.0 [extensions/Tabs] - 10https://gerrit.wikimedia.org/r/108992 (owner: 10Joeytje50) [22:33:47] ok, what did I do wrong? [22:34:21] If you look at the code, you'll see the issues [22:34:36] You've had some merge conflicts during a rebase or similar, and you haven't resolved them [22:34:41] so the files won't even pass php -l [22:36:17] (03PS1) 10Bsitu: BufferedCache merge() has invalid callback for BagOStuff [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108996 [22:37:01] I'll try putting the correct files in the directory again and then running https://www.mediawiki.org/wiki/Gerrit/git-review#Submitting_changes_with_git-review [22:37:07] that should work just fine right, Reedy? [22:37:35] Sort of [22:37:44] As long as you don't have the 2 prior commits as dependancies [22:38:07] (03CR) 10SG: "So, what does that mean, that we want mw.flow.action.topic to inherit from mw.flow.action, which implements generic functions as such?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 (owner: 10Matthias Mullie) [22:38:29] Reedy: so just delete the whole directory, and create a new plain one [22:38:32] and then git init? [22:39:23] Well, no [22:39:24] https://git.wikimedia.org/summary/?r=mediawiki/extensions/Tabs.git [22:39:26] (03CR) 10Manybubbles: [C: 04-1] WIP: Build documents in three hooks (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108952 (owner: 10Manybubbles) [22:39:35] You've already got commits submitted [22:39:55] Clone that repo [22:40:02] Put your changes into that directory [22:40:03] commit, push [22:41:03] so git clone ssh://Joeytje50@gerrit.wikimedia.org:29418/mediawiki/extensions/Tabs.git right? [22:41:30] yup [22:45:19] (03PS1) 10Joeytje50: Version 1.0 [extensions/Tabs] - 10https://gerrit.wikimedia.org/r/109000 [22:45:32] Reedy: did this one go through correctly? [22:45:33] Joeytje50: That looks better [22:45:38] Let me check it [22:45:43] You'll want to abandon the other 2 [22:47:26] Reedy: what do I need to do for that then? [22:47:55] (03CR) 10Reedy: [C: 04-1] Version 1.0 (034 comments) [extensions/Tabs] - 10https://gerrit.wikimedia.org/r/109000 (owner: 10Joeytje50) [22:48:10] If you visit https://gerrit.wikimedia.org/r/108992 there is an abandon button [22:49:14] (03Abandoned) 10Joeytje50: Version 1.0 [extensions/Tabs] - 10https://gerrit.wikimedia.org/r/108992 (owner: 10Joeytje50) [22:49:29] (03PS20) 10MarkTraceur: Create jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [22:49:36] (03Abandoned) 10Reedy: Version 1.0 [extensions/Tabs] - 10https://gerrit.wikimedia.org/r/108993 (owner: 10Joeytje50) [22:51:19] (03Abandoned) 10Alex Monk: WIP: Fix Echo email notifications [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/91906 (owner: 10Alex Monk) [22:52:26] Reedy: should the single-value array for magic words really be in a seperate file? [22:53:22] I'm not sure how well exporting from translatewiki works with a mixed file [22:53:36] mk [22:55:16] (03CR) 10Legoktm: [C: 04-1] Add COPYING (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/108975 (owner: 10Reedy) [22:59:46] awjr: Hey, is there a way to make a property in Mingle that is a link? I want to add a property to stories that links to the patch in gerrit, but without having to open the whole bloody description every time [23:03:24] (03PS22) 10Bsitu: Topic and Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 [23:07:15] (03CR) 10Legoktm: Add tests for API's assert={user|bot} (031 comment) [core] - 10https://gerrit.wikimedia.org/r/108291 (owner: 10Legoktm) [23:09:20] marktraceur: yeah you can create arbitrary properties [23:09:30] let's see if i can remember how to do it... [23:09:40] oh yeah [23:09:40] awjr: I made a text property, but clicking on it brings up the edit interface [23:09:44] oh [23:09:48] oh i see what you mean [23:10:05] i do not know the answer to that, but my hunch is no [23:10:28] marktraceur: we track links to gerrit in comments to the stor [23:10:29] y [23:10:42] Hrm [23:10:48] (03CR) 10Anomie: Add tests for API's assert={user|bot} (031 comment) [core] - 10https://gerrit.wikimedia.org/r/108291 (owner: 10Legoktm) [23:10:52] Seems less helpful, because you have to load the page still [23:10:58] But meh [23:11:05] one thing you can do in transitions, is enforce that a certain action get taken - so for us when a card gets moved from in development -> awaiting code review, it prompts the user to enter a comment [23:11:16] which by convention we use as an opportunity to add links to patchsets [23:11:17] awjr: We're definitely doing that [23:11:27] But it'd be nicer to have the link somewhere accessible from the wall [23:11:28] Meh [23:11:31] it would [23:11:50] it would be nice to be able to control what shows up in the card preview from the wall [23:11:54] but afaik you cannot [23:15:44] Nikerabbit, hey [23:16:04] Nikerabbit, could you take a look at https://gerrit.wikimedia.org/r/#/c/105444/4 ? [23:22:06] (03PS1) 10Chad: WIP: Track versions of the index for easier maintenance [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109007 [23:22:47] (03PS2) 10Chad: WIP: Track versions of the index for easier maintenance [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109007 [23:27:40] (03CR) 10Alex Monk: [C: 032] Abstract CentralAuth RC feed formatting [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/108901 (owner: 10Reedy) [23:27:44] (03Merged) 10jenkins-bot: Abstract CentralAuth RC feed formatting [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/108901 (owner: 10Reedy) [23:31:40] (03PS9) 10Reedy: Adds the spoofuser table to the centralauth database. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/39008 (owner: 10Techman224) [23:31:46] (03CR) 10Reedy: [C: 032] Adds the spoofuser table to the centralauth database. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/39008 (owner: 10Techman224) [23:31:48] (03Merged) 10jenkins-bot: Adds the spoofuser table to the centralauth database. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/39008 (owner: 10Techman224) [23:32:12] (03PS4) 10Reedy: Changed Special:GlobalUsers to inherit from AlphabeticPager [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97531 (owner: 10Zsaigol) [23:32:28] (03CR) 10Chad: "Definitely a WIP. Should track all indexes, not just basenames (they can theoretically be different)." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/109007 (owner: 10Chad) [23:34:20] Krenair: the usual function to override is getMessageParameters isntead of extractParameters [23:34:25] (03CR) 10Chad: [C: 032] Remove deprecated MediaWiki::articleFromTitle() and WikiPage::createUpdates() [core] - 10https://gerrit.wikimedia.org/r/106920 (owner: 10Siebrand) [23:36:31] Nikerabbit, okay... what's the pros/cons of doing it that way instead? [23:36:38] (03CR) 10Chad: [C: 032] Remove some deprecated global functions [core] - 10https://gerrit.wikimedia.org/r/106919 (owner: 10Siebrand) [23:37:18] (03CR) 10Chad: [C: 032] Replace deprecated wfStreamFile (1.19) [extensions/SlimboxThumbs] - 10https://gerrit.wikimedia.org/r/106916 (owner: 10Siebrand) [23:37:26] ok, I must move from the coffee shop to campus, through snowey new york streets. See you in a bit! [23:37:46] (03Merged) 10jenkins-bot: Remove deprecated MediaWiki::articleFromTitle() and WikiPage::createUpdates() [core] - 10https://gerrit.wikimedia.org/r/106920 (owner: 10Siebrand) [23:37:48] (03CR) 10jenkins-bot: [V: 04-1] Remove some deprecated global functions [core] - 10https://gerrit.wikimedia.org/r/106919 (owner: 10Siebrand) [23:39:03] (03PS1) 10Bsitu: More fix to 'topic/post edited' tipsy link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/109009 [23:40:39] (03PS2) 10Chad: Remove deprecated ParserOptions::getSkin() [core] - 10https://gerrit.wikimedia.org/r/106875 (owner: 10Siebrand) [23:40:41] (03PS1) 10Joeytje50: Minor changes [extensions/Tabs] - 10https://gerrit.wikimedia.org/r/109010 [23:41:01] (03CR) 10Chad: [C: 032] Remove deprecated ParserOptions::getSkin() [core] - 10https://gerrit.wikimedia.org/r/106875 (owner: 10Siebrand) [23:41:20] (03CR) 10Chad: [C: 032 V: 032] Call Linker methods statically [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/106922 (owner: 10Siebrand) [23:41:20] Reedy: looks like something went wrong there... of course [23:41:34] Krenair: not confusing reviewers? ;) [23:41:39] ? [23:41:52] [00:40:41] (PS1) Joeytje50: Minor changes [extensions/Tabs] - https://gerrit.wikimedia.org/r/109010 [23:42:04] What about it? [23:42:07] You didn't amend? [23:42:10] is that all okay? [23:42:30] I only removed some whitespace and put that parser function in another file [23:42:38] doesn't even look like it got that other file [23:42:44] NO idea what I did wrong [23:42:51] git add? [23:42:53] git commit -a [23:42:55] git add -A . [23:43:04] git commit -a -m "Minor changes" [23:43:11] git-review [23:44:36] (03PS5) 10SG: Implement better scrolling via conditionalScroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 [23:44:43] (03CR) 10jenkins-bot: [V: 04-1] Implement better scrolling via conditionalScroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 (owner: 10SG) [23:45:11] (03Merged) 10jenkins-bot: Remove deprecated ParserOptions::getSkin() [core] - 10https://gerrit.wikimedia.org/r/106875 (owner: 10Siebrand) [23:45:43] Reedy: so why is it showing it like I've made some huge changes? [23:46:21] It looks like it's a new commit on top of what is already there [23:46:40] (03CR) 10Chad: [C: 04-1] Limit the project cache size. (031 comment) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/108883 (owner: 10Andrew Bogott) [23:50:24] (03PS5) 10Alex Monk: Fix logging [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/105444 [23:50:41] Reedy: so how can I fix this exactly? I'm really getting frustrated with how extremely horrible the UI is for git by now... [23:51:03] There isn't really a UI for git... [23:51:25] but what is there is really horrible for beginners [23:51:42] (03PS3) 10Manybubbles: WIP: Always search plain text and stemmed text [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108951 [23:51:47] (03CR) 10jenkins-bot: [V: 04-1] WIP: Always search plain text and stemmed text [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108951 (owner: 10Manybubbles) [23:52:22] (03PS10) 10Ori.livneh: Change modal to use API instead of special page, refactor [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103079 (owner: 10Mattflaschen) [23:52:26] (03CR) 10Ori.livneh: [C: 032] Change modal to use API instead of special page, refactor [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103079 (owner: 10Mattflaschen) [23:52:52] (03PS6) 10SG: Implement better scrolling via conditionalScroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 [23:52:59] How did you make that second commit? [23:53:10] (03Merged) 10jenkins-bot: Change modal to use API instead of special page, refactor [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103079 (owner: 10Mattflaschen) [23:53:12] (03CR) 10jenkins-bot: [V: 04-1] Implement better scrolling via conditionalScroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 (owner: 10SG) [23:54:06] (03PS7) 10SG: Implement better scrolling via conditionalScroll [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 [23:54:23] Reedy: I made some changes in the files in my XAMPP's /htdocs/w/extensions/Tabs/ folder [23:54:37] then copied the updated files to the git directory [23:54:44] then did git add -A . [23:55:05] git commit -a -m "Minor changes" [23:55:08] git-review [23:56:49] (03CR) 10Parent5446: [C: 031] Replace deprecated SpecialPage::resolveAlias() [extensions/ShoutWikiAds] - 10https://gerrit.wikimedia.org/r/104380 (owner: 10Siebrand) [23:58:03] (03CR) 10Parent5446: [C: 031] "Has this been tested? I really don't have the means to test this, but if it works I can give approval." [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/106917 (owner: 10Siebrand) [23:58:35] (03CR) 10Parent5446: [C: 031] Call Linker methods statically [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/106938 (owner: 10Siebrand)