[00:00:03] thought so [00:01:13] Your concern about the speed of the requests on the WMF cluster.. [00:01:19] I'm really not sure we need to worry about that :) [00:01:45] I don't think so either [00:02:14] cross-wiki user rights form is usually used a few times very close together and then not again for a few hours [00:04:23] legoktm, although perhaps it would be a good idea to cache them since we know they're likely to be used again shortly [00:05:35] I think caching won't hurt anything and will probably make a noticeable performance gain [00:05:49] noticeable == few seconds [00:06:16] (03PS1) 10Brian Wolff: Make sure jquery.ui.dialog is loaded if there are pop up videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108472 [00:06:37] (03PS1) 10Brian Wolff: Follow-up 08091667f4c7, avoid flash of unstyled content [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108473 [00:07:57] (03CR) 10Brian Wolff: "I'm back to thinking this did cause the problem. See Ia903cded423a" [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/88943 (owner: 10Mattflaschen) [00:09:15] Krenair: commons descriptions are fetched by doing ?action=render over http, so I think wikis can access other wikis apis from inside the cluster [00:09:34] but its probably better to use db queries where that makes sense [00:10:53] user groups will only be stored in the database after https://www.mediawiki.org/wiki/Requests_for_comment/Configuration_database_2 ! [00:11:10] (03CR) 10Brian Wolff: "Please see follow-up I6273eb461fcf8897a77b685c36db825328bcac93" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/92052 (owner: 10Spage) [00:11:22] bawolff: his patch is fetching the user groups that are available on a remote wiki [00:11:47] You should still be able to do that without http I think [00:11:49] legoktm, wondering if there's any point ignoring wfMemcKey (client wiki-specific) and using a global key like CentralAuthUser::memcKey does [00:12:00] bawolff: how? :P [00:12:26] Krenair: that would make sense [00:12:27] for wmf wikis I suspect it won't matter much since the stewards do all their stuff from meta [00:14:14] I was thinking of $wgConf->getConfig, but i just looked at the code, and it looks scarier than doing an api request [00:15:47] that doesn't work on the wmf cluster due to how user groups are organized unfortunately [00:16:08] $ mwscript eval.php --wiki=metawiki [00:16:09] > var_dump($wgConf->get( 'wgGroupPermissions', 'enwiki')); [00:16:09] NULL [00:16:09] We can't use that stuff because extensions modify things after the config is loaded [00:16:16] It used to use that [00:16:23] (https://gerrit.wikimedia.org/r/#/c/36330/ btw) [00:17:53] then we realised it wasn't going to work [00:18:08] legoktm: What about $wgConf->loadFullData(); var_dump( $wgConf->get( 'wgGroupPermissions', 'enwiki') ); [00:18:29] although that would be moot with Krenair's point [00:19:23] And also for some other reasons it doesn't work on WMF's cluster, I don't remember why [00:35:20] bawolff, legoktm: What was the last message you received from me in this channel? [00:35:27] [04:19:23 PM] And also for some other reasons it doesn't work on WMF's cluster, I don't remember why [00:35:39] Anyone know why https://gerrit.wikimedia.org/r/#/c/108200/6/handlers/Mp4Handler/Mp4Handler.php isn't highlighting the trailing whitespace on line 131 [00:35:42] right, like legoktm showed [00:35:48] bawolff, legoktm: I do rely on wgConf working for getting the hostname and script path now though btw [00:35:55] legoktm, can you check that will actually work? [00:36:04] Krenair: I don't have cluster access :| [00:36:09] oh [00:36:31] Reedy, you about? [00:36:49] (03CR) 10Brian Wolff: [C: 04-1] "One last nitpicky bit of trailing whitespace (on line 131), otherwise this is good." (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 (owner: 1001tonythomas) [00:37:15] bawolff, hm... maybe because it doesn't end in a semicolon or parenthesis or something? [00:37:41] maybe. Locally git show highlights it bright red [00:38:26] I feel slightly bad about nitpicking over trailing whitespace in TMH given the state of the rest of that extension [00:41:20] liangent: around? [00:41:42] (03PS3) 10Hoo man: New diff variables regarding pre-save transformed wikitext [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/86815 (owner: 10Liangent) [00:43:39] (03PS4) 10Hoo man: New diff variables regarding pre-save transformed wikitext [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/86815 (owner: 10Liangent) [00:43:47] liangent: ^ [00:44:18] (03CR) 10Hoo man: "Removed removed_lines_pst as that's pretty pointless" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/86815 (owner: 10Liangent) [00:46:43] liangent: In case you're around, just give that change a +1 if you're fine with it [00:47:01] going to merge it anyway later on as I want to get those out of gerrit :P [00:49:07] (03PS2) 10Nullzero: Update documentation and suppress warning when parsing summary [core] - 10https://gerrit.wikimedia.org/r/108307 [00:50:21] (03CR) 10jenkins-bot: [V: 04-1] Update documentation and suppress warning when parsing summary [core] - 10https://gerrit.wikimedia.org/r/108307 (owner: 10Nullzero) [00:52:18] (03PS3) 10Nullzero: Update documentation and suppress warning when parsing summary [core] - 10https://gerrit.wikimedia.org/r/108307 [00:57:25] ori, thanks for the review. Anything I can look at for you? [00:57:30] (03PS9) 10Mattflaschen: Change modal to use API instead of special page, refactor [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103079 [01:04:13] * bawolff wonders why I get no js when viewing commons from my old version of opera [01:07:47] (03PS1) 10Robert Roos: Added file. [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/108474 [01:19:47] (03PS1) 10EBernhardson: Additional Makefile commands [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108475 [01:29:16] (03PS1) 10EBernhardson: Define missing constant [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108476 [01:35:17] (03PS1) 10EBernhardson: Remove invalid defaulted parameter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108477 [01:38:09] (03PS1) 10EBernhardson: Remove deprecated getCreatorText parameter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108479 [01:39:55] !log springle synchronized wmf-config/db-eqiad.php 'repool db1039, warm up' [01:50:07] (03PS1) 10EBernhardson: Repair some small programming errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108480 [01:50:33] (03PS5) 10Hoo man: New diff variables regarding pre-save transformed wikitext [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/86815 (owner: 10Liangent) [01:51:32] (03CR) 10Hoo man: [C: 032] "Worked like a charm" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/86815 (owner: 10Liangent) [01:51:37] (03Merged) 10jenkins-bot: New diff variables regarding pre-save transformed wikitext [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/86815 (owner: 10Liangent) [01:54:21] (03CR) 10Nikerabbit: New class for parsing MediaWiki:Sidebar-like messages into modern, nested navigation menus. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/108045 (owner: 10Jack Phoenix) [01:54:42] (03CR) 10Hoo man: [C: 032] "Documentation-only change" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/96463 (owner: 10Siebrand) [01:54:46] (03Merged) 10jenkins-bot: Remove underscore from class names LBFactory_* [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/96463 (owner: 10Siebrand) [02:04:26] (03CR) 10Nikerabbit: "There is no need to revert." [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/108192 (owner: 10Ori.livneh) [02:12:17] !log springle synchronized wmf-config/db-eqiad.php 'repool db1022, db1039 full steam' [02:12:45] !log LocalisationUpdate completed (1.23wmf10) at 2014-01-20 02:12:45+00:00 [02:22:29] !log LocalisationUpdate completed (1.23wmf11) at 2014-01-20 02:22:28+00:00 [02:40:25] !log LocalisationUpdate ResourceLoader cache refresh completed at 2014-01-20 02:40:25+00:00 [02:40:59] (03CR) 10Ori.livneh: "2014-01-16, #wikimedia-operations, lightly edited to remove bots and offtopic chatter: " [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/108192 (owner: 10Ori.livneh) [02:41:21] (03PS1) 10Brian Wolff: Let TMH detect webm files using opus and VP9 codecs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108482 [02:47:04] (03CR) 10Brian Wolff: "I should of course note that this doesn't actually make VP9 work, as that requires libav upgrade" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108482 (owner: 10Brian Wolff) [03:08:06] (03CR) 10Whym: "I'm not sure what the current state of those unit tests is - I ran "php phpunit.php ../../extensions/Echo/tests/DiscussionParserTest.php" " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/108329 (owner: 10Whym) [03:15:17] (03CR) 10Ori.livneh: "@Nemo -- good point, will do." [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/108192 (owner: 10Ori.livneh) [03:26:53] (03CR) 10EBernhardson: "These tests should be in a reasonable state, in mediawiki-vagrant these tests return" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/108329 (owner: 10Whym) [03:31:25] (03CR) 10EBernhardson: "jenkins-bot not running the tests is just related to whitelisting." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/108329 (owner: 10Whym) [03:48:38] (03CR) 10MZMcBride: "I believe Nike made the same point at ." [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/108192 (owner: 10Ori.livneh) [04:33:15] (03CR) 10Liangent: "@Hoo man: "Removed removed_lines_pst as that's pretty pointless" - this is working when somebody is appending "123" to a page by overwriti" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/86815 (owner: 10Liangent) [05:51:12] (03PS1) 10Gnosygnu: v1.1.3.1 [xowa] - 10https://gerrit.wikimedia.org/r/108485 [05:51:47] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/108485 (owner: 10Gnosygnu) [06:10:10] (03PS1) 10Microchip08: Remove `login-throttled` system message reuse [core] - 10https://gerrit.wikimedia.org/r/108486 [06:21:47] (03CR) 10Nemo bis: "I don't understand how that log relates to this change: they're about the deploy of I2da436caa, not of I862b01e6b; I don't remember, and g" [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/108192 (owner: 10Ori.livneh) [06:27:27] (03CR) 10Parent5446: New class for parsing MediaWiki:Sidebar-like messages into modern, nested navigation menus. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/108045 (owner: 10Jack Phoenix) [06:33:14] (03CR) 10Nemo bis: Allow hiding patrol entries from Special:Log for all users (031 comment) [core] - 10https://gerrit.wikimedia.org/r/42279 (owner: 10Brian Wolff) [06:41:10] (03PS2) 10Microchip08: Remove `login-throttled` system message reuse [core] - 10https://gerrit.wikimedia.org/r/108486 [07:31:44] (03PS1) 10Hydriz: (bug 3760) Export titles matching a wildcard [core] - 10https://gerrit.wikimedia.org/r/108487 [08:20:27] (03PS2) 10Whym: (bug 53132) properly get timestamp position in DiscussionParser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/108329 [08:23:18] (03CR) 10Ori.livneh: "Perhaps you missed the fact that cog-sprite.svg was the third most requested URI on the bits cluster. I'm not exactly sure how the story h" [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/108192 (owner: 10Ori.livneh) [08:27:53] (03CR) 10Nemo bis: "Well, it's simple: because you didn't mention that part in the commit message. :) Thanks for clarifying, I remembered that cog-sprite figu" [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/108192 (owner: 10Ori.livneh) [08:35:45] (03PS12) 10Physikerwelt: Remove call to deprecated ParserOptions::getMath [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 [08:45:35] (03CR) 10Nemo bis: "Pretty graph-candy appreciated if anyone has some, by the way. :) Couldn't find anything with (03PS1) 10Physikerwelt: Remove math specific code from ParserOptions [core] - 10https://gerrit.wikimedia.org/r/108490 [09:06:54] anyone have opinions of AMD? [09:21:40] (03PS24) 10Alex Monk: Cross-wiki user rights UI should show target wiki groups instead of local [core] - 10https://gerrit.wikimedia.org/r/36330 [09:22:24] (03CR) 10jenkins-bot: [V: 04-1] Cross-wiki user rights UI should show target wiki groups instead of local [core] - 10https://gerrit.wikimedia.org/r/36330 (owner: 10Alex Monk) [09:24:46] (03CR) 10Daniel Kinzler: [C: 04-1] "-1 as per hoo. see replies." (039 comments) [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [09:26:28] (03PS25) 10Alex Monk: Cross-wiki user rights UI should show target wiki groups instead of local [core] - 10https://gerrit.wikimedia.org/r/36330 [09:28:54] (03PS5) 10Ori.livneh: Only load mw.PopUpMediaTransform on pages that plausibly need it [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/99597 [09:34:24] Ryan_Lane, any idea how I can rebase https://gerrit.wikimedia.org/r/#/c/48749/ onto the latest version of the dependency? [09:38:41] Krenair: you need to do it manually. there's a conflict [09:38:56] yes I can handle the conflict [09:39:12] I just can't remember which command I need to start the rebase [09:40:25] Krenair: fetch both changes, and then with the change https://gerrit.wikimedia.org/r/#/c/48749/ checked out, do git rebase [09:41:07] Krenair: so you would fetch 36330 first, then 48749, and then do 'git rebase 02d75daed837e44dbd735674d73a93b2564b80a2' [09:42:01] ... where is that commit hash from? [09:42:26] oh right, I see, ignore me [09:42:33] Krenair: next to PS25 on https://gerrit.wikimedia.org/r/#/c/36330/14 [09:52:44] yuvipanda, okay so that's fine, now I have an issue because a file touched in the old version has since been deleted [09:53:08] Krenair: hmm, so you need to delete that from the conflict too? [09:53:13] I git rm'd it and then tried to continue but it thinks nothing happened [09:53:34] Krenair: what does git status say? [09:54:00] # (all conflicts fixed: run "git rebase --continue") [09:54:09] among other things [09:56:08] Krenair: git rebase --continue tells you 'nothing to do'? [09:57:13] No changes - did you forget to use 'git add'? [09:57:14] If there is nothing left to stage, chances are that something else already introduced the same changes; you might want to skip this patch. [09:58:13] Krenair: sigh, out of my range now, sorry :( [10:00:20] will try skipping :/ [10:05:14] (03PS7) 10Alex Monk: Fix interwiki userrights form tool links [core] - 10https://gerrit.wikimedia.org/r/48749 [10:07:59] Krenair: did that work? [10:08:33] seems to have [10:08:41] woo! nice :) [10:24:09] (03CR) 10Daniel Kinzler: [C: 04-1] "-1 as per Theopolisme: core now has assertValidHtml, so we should use it." [core] - 10https://gerrit.wikimedia.org/r/107842 (owner: 10Daniel Kinzler) [10:26:12] (03PS1) 10Physikerwelt: Localisation updates from https://translatewiki.net. [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/108491 [10:26:52] (03PS2) 10Physikerwelt: Localisation updates from https://translatewiki.net. [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/108491 [10:29:15] (03CR) 10Physikerwelt: [C: 032 V: 032] Merge recent changes of master branch [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/108491 (owner: 10Physikerwelt) [10:56:00] (03CR) 10Hoo man: "That still sounds pretty weird... I just wanted to cut down the huge amount of variables we offer (and may have to compute) a bit." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/86815 (owner: 10Liangent) [11:07:10] (03PS3) 10Microchip08: Remove `login-throttled` system message reuse [core] - 10https://gerrit.wikimedia.org/r/108486 [11:23:18] (03CR) 10Hoo man: [C: 04-1] "Some replies" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [11:34:21] today is the day of GCI Results :) [11:56:26] (03PS8) 10Matthias Mullie: Refactor edit-post JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105674 [12:12:32] (03PS5) 10Matthias Mullie: Refactor post-reply JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105699 [12:37:53] (03CR) 10Helder.wiki: Make sure jquery.ui.dialog is loaded if there are pop up videos (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108472 (owner: 10Brian Wolff) [12:40:04] (03CR) 10Matthias Mullie: Refactor post-reply JavaScript (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105699 (owner: 10Matthias Mullie) [12:40:58] (03CR) 10Helder.wiki: Follow-up 08091667f4c7, avoid flash of unstyled content (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108473 (owner: 10Brian Wolff) [12:43:42] (03PS6) 10Matthias Mullie: Refactor title-reply JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106534 [12:46:04] (03PS7) 1001tonythomas: Changed Mp4Handler class call from wfMsgto wfMessage [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 [12:52:51] (03PS3) 10Matthias Mullie: Refactor new-topic JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106556 [12:53:53] (03PS3) 10Matthias Mullie: Refactor edit-header JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107187 [13:02:07] (03PS4) 10Matthias Mullie: Refactor edit-header JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107187 [13:03:48] (03PS1) 10Physikerwelt: Style: Apply stylize.php [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/108502 [13:05:49] (03CR) 10Physikerwelt: [C: 032] Style: Apply stylize.php [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/108502 (owner: 10Physikerwelt) [13:06:42] (03PS16) 10Matthias Mullie: Edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 [13:21:49] Even though I gave my correct user name and password Iam not able to login into my Gerrit account [13:31:14] amrutha, are you trying to log in gerrit.wikimedia.org ? [13:39:43] yes [13:41:06] I tried several times.Still the same error is occuring [13:42:43] amrutha: could you paste the error message? [13:43:28] (not that I'm saying I'm able to solve, but someone may) [13:43:56] It is nothing but, its saying that invalid username or password [13:45:57] amrutha: Even I filed a bug for a gorgot link in gerrit login page [13:45:57] https://bugzilla.wikimedia.org/show_bug.cgi?id=58205 [13:46:16] Reedy, Working on this bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=54157... I was wondering if the message of 'right-listall' should be same as 'action-listall'? [13:49:26] amrutha: and saper said, you can reset your password via https://wikitech.wikimedia.org/wiki/Special:Password in his comment https://bugzilla.wikimedia.org/show_bug.cgi?id=58205#c1 [13:49:32] amrutha: you tried that ? [13:50:48] tony, I tried even that.still no result. [13:51:24] amrutha: Could you get the password resetted for Wikitech atleast ? [13:53:19] tony:I did tried doing that.But still its not getting logged in. [13:54:37] (03CR) 10Brian Wolff: "Re helder: im pretty sure it doesnt make a difference. In the actual output, styles get output first." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108473 (owner: 10Brian Wolff) [13:58:10] amrutha: Did your password for atleast Wikitech change ? [14:00:48] (03CR) 10Brian Wolff: "Re helder: hmm you're probably right that something in mwembed library should do that. This is a bit of a voodoo fix: removing jquery.ui.d" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108472 (owner: 10Brian Wolff) [14:01:09] tony:Yes, wikitech is getting logged in using the changed password [14:05:10] amrutha: In that case, I am helpless. I think some others here may be able to help you with resetting the password for gerrit [14:07:09] ok [14:19:42] (03PS1) 10Roopak: Changed the font size used for subheading in notificatons [extensions/Echo] - 10https://gerrit.wikimedia.org/r/108512 [14:26:31] (03PS1) 10Tinaj1234: Added missing message to OpenStackManager.i18n [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/108513 [14:26:34] (03CR) 10jenkins-bot: [V: 04-1] Added missing message to OpenStackManager.i18n [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/108513 (owner: 10Tinaj1234) [14:28:52] When I raised the problem regarding the login in #gerrit, they asked me to contact the site's administrator.What should I do? [14:32:12] (03PS1) 10Gerrit Patch Uploader: Caption of TOC in page content language instead of user language [core] - 10https://gerrit.wikimedia.org/r/108514 [14:32:19] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/108514 (owner: 10Gerrit Patch Uploader) [14:35:27] (03PS2) 10Tinaj1234: Added missing message to OpenStackManager.i18n file [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/108513 [15:01:03] (03PS17) 10Matthias Mullie: Edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 [15:02:54] (03PS18) 10Matthias Mullie: Edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 [15:03:17] (03CR) 10Matthias Mullie: "PS16 = rebase; PS17 adresses feedback on PS15" (0312 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 (owner: 10Matthias Mullie) [15:15:01] (03PS3) 10Bartosz Dziewoński: (bug 53132) properly get timestamp position in DiscussionParser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/108329 (owner: 10Whym) [15:15:33] (03CR) 10Bartosz Dziewoński: "Rebasing to run tests (since I am on the whitelist)." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/108329 (owner: 10Whym) [15:16:20] (03CR) 10Bartosz Dziewoński: "As you can see above (https://integration.wikimedia.org/ci/job/mwext-Echo-testextensions-master/1139/console), they pass on jenkins at lea" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/108329 (owner: 10Whym) [15:17:04] (03CR) 10Bartosz Dziewoński: "Dupe of https://gerrit.wikimedia.org/r/#/c/108306/ ?" [core] - 10https://gerrit.wikimedia.org/r/108323 (owner: 10Gerrit Patch Uploader) [15:17:13] (03CR) 10Bartosz Dziewoński: "Dupe of https://gerrit.wikimedia.org/r/#/c/108323/ ?" [core] - 10https://gerrit.wikimedia.org/r/108306 (owner: 10Gerrit Patch Uploader) [15:18:36] (03CR) 10Bartosz Dziewoński: [C: 032] Allow extensions to set a custom error message in the BlockIp hook [core] - 10https://gerrit.wikimedia.org/r/108285 (owner: 10Legoktm) [15:22:05] (03Merged) 10jenkins-bot: Allow extensions to set a custom error message in the BlockIp hook [core] - 10https://gerrit.wikimedia.org/r/108285 (owner: 10Legoktm) [15:22:50] (03CR) 10Bartosz Dziewoński: "Are the new messages intentionally different?" [core] - 10https://gerrit.wikimedia.org/r/108486 (owner: 10Microchip08) [15:23:37] (03CR) 10Bartosz Dziewoński: Remove `login-throttled` system message reuse (031 comment) [core] - 10https://gerrit.wikimedia.org/r/108486 (owner: 10Microchip08) [15:25:29] (03CR) 10Whym: "Nice, so I'll conclude that something was messed up in my environment about the test failures I saw. I'll probably try mediawiki-vagrant." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/108329 (owner: 10Whym) [15:25:41] (03CR) 10Bartosz Dziewoński: "Why me? I don't know how this thing works :(" [extensions/Score] - 10https://gerrit.wikimedia.org/r/102367 (owner: 10Brian Wolff) [15:26:30] (03Abandoned) 10Bartosz Dziewoński: mediawiki.action.edit.js: remove a weird hack from 2010 [core] - 10https://gerrit.wikimedia.org/r/53029 (owner: 10Bartosz Dziewoński) [15:38:35] (03PS4) 10Microchip08: Remove `login-throttled` system message reuse [core] - 10https://gerrit.wikimedia.org/r/108486 [15:40:50] (03CR) 10Brian Wolff: "Because i have no idea who does :s" [extensions/Score] - 10https://gerrit.wikimedia.org/r/102367 (owner: 10Brian Wolff) [15:51:21] (03PS5) 10Microchip08: Remove `login-throttled` system message reuse [core] - 10https://gerrit.wikimedia.org/r/108486 [15:52:24] (03CR) 10Microchip08: "Spaces removed from messages.inc in favour of tabs; fixed inconsistent {{duplicate}} template call in Qqq." [core] - 10https://gerrit.wikimedia.org/r/108486 (owner: 10Microchip08) [17:25:57] (03CR) 10Parent5446: Remove math specific code from ParserOptions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/108490 (owner: 10Physikerwelt) [17:54:14] m4tx & theopolisme congrats! I hope you have a wonderful time at Google's HQ! :) [17:54:58] Thanks! Yeah, I've got to figure out a way to set up a visit to the foundation offices as well :) [17:55:26] thanks MegaAlex :P [17:55:38] Well, I think you will have a free day in SF :) [17:55:48] One? [17:56:00] Iirc 4 days [17:57:04] I mean a day that they will explore SF on their own :) [18:02:02] (03PS2) 10Tim Landscheidt: Remove math specific code from ParserOptions [core] - 10https://gerrit.wikimedia.org/r/108490 (owner: 10Physikerwelt) [18:26:19] I guess that means results are now known :) [18:33:27] MatmaRex: have you seen it already? http://google-opensource.blogspot.com/2014/01/google-code-in-2013-drumroll-please.html :) [18:42:14] Congrats, m4tx and theopolisme. :-) [18:42:50] Thanks, MZMcBride! [18:43:08] (03CR) 10Yuvipanda: [C: 04-1] "(from other conversations) - the parser seems to return a 'flat' array while it really should be returning nested one. Having a 'children'" [core] - 10https://gerrit.wikimedia.org/r/108045 (owner: 10Jack Phoenix) [18:45:38] thanks :) [18:49:57] theopolisme: m4tx: haven't seen it yet, congrats :D [18:50:22] I have a question. What does [[SULUTIL:]] point to on commons? Can it be fixed? The tool is no longer at https://toolserver.org/~quentinv57/sulinfo/$1 it's on labs now https://tools.wmflabs.org/quentinv57-tools/tools/sulinfo.php?username=$1 [18:51:29] Technical_13: i think you want to look at [[meta:Interwiki map]] [18:51:42] @link [18:51:42] https://meta.wikimedia.org/wiki/Interwiki_map [18:52:46] MatmaRex: can I get the admin bit on meta to fix it please? [18:53:03] j/k Can someone with admin please fix it though.. :p [18:53:26] i don't even know how exactly to do that, i just know where to go about it :) [18:53:37] i think Nemo_bis is involved in maintaining that? [18:54:16] MatmaRex: your information is 1y old [18:54:26] MatmaRex: thanks :P [18:54:44] though, of course, after me the deluge [18:55:16] MatmaRex: Replace `| Sulutil || //toolserver.org/~quentinv57/sulinfo/$1` with `| Sulutil || //tools.wmflabs.org/quentinv57-tools/tools/sulinfo.php?username=$1` [18:55:17] Technical_13: it's correct this way; it doesn't work on labs yet [18:55:56] (03PS1) 10Matthias Mullie: Move flow( 'setupEditForm' ) to base/action.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108535 [18:56:01] when it's ok it will be redirectd, don't worry; stewards and Meta sysops know very well about that interwiki [18:56:17] (i'm not a Meta admin) [18:56:24] Seems to work fine on labs and enwp has already updated all of its internal links I can see and ACC tool on labs is using tools.wmflabs version. [18:56:50] isn't the labs version still slow? [18:56:51] in case you didn't notice, nobody cares about en.wiki [18:57:02] lol I did notice. :p [18:57:26] legoktm: it's faster than toolserver especially since toolserver doesn't work 92% of the time [18:58:22] {{cn}} [19:00:19] I think we should use [[m:Special:CentralNotice]]. [19:00:19] But others don't agree. [19:00:42] CentralAuth* [19:00:56] it's close, but doesn't have all the features of sulinfo yet [19:16:24] (03PS1) 10Ottomata: Adding owner and group parameters to git::clone [vagrant] - 10https://gerrit.wikimedia.org/r/108538 [19:16:47] (03Draft1) 10AndyRussG: Fix protocol-relative URL for enrolling students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/108290 [19:21:01] (03CR) 10Legoktm: [C: 031] "LGTM, I'll wait a little bit to see if anyone else has any comments before merging." [core] - 10https://gerrit.wikimedia.org/r/36330 (owner: 10Alex Monk) [19:31:42] (03CR) 10AndyRussG: Fix protocol-relative URL for enrolling students (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/108290 (owner: 10AndyRussG) [19:31:59] (03PS4) 10AalekhN: SpecialContributions.php : made Special:Contributions includable [core] - 10https://gerrit.wikimedia.org/r/106320 [19:34:46] (03CR) 10Legoktm: [C: 04-1] "See https://bugzilla.wikimedia.org/show_bug.cgi?id=60239#c4, 14px is too big" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/108512 (owner: 10Roopak) [19:35:23] (03CR) 10Hoo man: [C: 04-1] Cross-wiki user rights UI should show target wiki groups instead of local (039 comments) [core] - 10https://gerrit.wikimedia.org/r/36330 (owner: 10Alex Monk) [19:37:49] hello hoo [19:37:59] hi legoktm :) [19:37:59] when are you flying in? [19:38:07] I'm sitting next to Krenair right now :P [19:38:24] Daniel is flying tomorrow, I'll head of (and arrive) on Wednesday [19:38:33] but only leaving on Monday [19:38:45] awesome [19:39:31] I hope I'll soon have a bit more time for reviews... got a bit done yesterday [19:42:59] (03PS3) 10Physikerwelt: Remove math specific code from ParserOptions [core] - 10https://gerrit.wikimedia.org/r/108490 [19:48:40] (03CR) 10Physikerwelt: "no thwre is no particular reason for a quick deletion" [core] - 10https://gerrit.wikimedia.org/r/108490 (owner: 10Physikerwelt) [20:26:54] (03PS26) 10Alex Monk: Cross-wiki user rights UI should show target wiki groups instead of local [core] - 10https://gerrit.wikimedia.org/r/36330 [20:29:11] (03Abandoned) 10Jforrester: Go to top button for pages [core] - 10https://gerrit.wikimedia.org/r/108306 (owner: 10Gerrit Patch Uploader) [20:29:46] (03PS2) 10Jforrester: Go to top button for pages [core] - 10https://gerrit.wikimedia.org/r/108323 (owner: 10Gerrit Patch Uploader) [20:30:29] (03CR) 10Hoo man: [C: 031] "Looks ok now, didn't test" [core] - 10https://gerrit.wikimedia.org/r/36330 (owner: 10Alex Monk) [20:30:47] (03CR) 10Alex Monk: Cross-wiki user rights UI should show target wiki groups instead of local (038 comments) [core] - 10https://gerrit.wikimedia.org/r/36330 (owner: 10Alex Monk) [20:32:02] (03CR) 10Legoktm: [C: 04-1] "So I ran the script once, migrated a revision which worked fine, then tried running it again, and it gave me a database error because it t" (031 comment) [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 (owner: 10Alex Monk) [20:33:22] (03CR) 10jenkins-bot: [V: 04-1] Go to top button for pages [core] - 10https://gerrit.wikimedia.org/r/108323 (owner: 10Gerrit Patch Uploader) [20:41:01] (03CR) 10Hoo man: "Just two notes for whoever is doing final review" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/36330 (owner: 10Alex Monk) [20:41:22] ragesoss: Are you the E:WikiLove guy? [20:41:45] Technical_13: no, kaldari is the main dev of that. [20:42:03] with desgin contributions from jorm. [20:42:12] I was looking at the idea page to find ways to better customize https://en.wikipedia.org/wiki/User:Technical_13/Scripts/ACC_WikiLove.js and saw your name... [20:42:35] It's a custom script for sending "Welcome" WikiLove messages... [20:43:03] I'm trying to figure out how to make the $1 message "optional" instead of "required" [20:43:07] yeah, I played around with customizing wikilove when it was still in the script phase. [20:43:21] but I'm not of much help with the .js details. [20:43:38] Ryan's not here right now jorm are you awake? [20:44:37] sort of. [20:45:03] Is there a way to currently make that field optional? [20:47:33] no idea. [20:47:37] you'll have to ask kaldari. [20:53:17] lol thanks jorm [21:15:18] (03PS1) 10Brian Wolff: Remove z-index on cannot play file warning [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108631 [21:22:10] (03CR) 10Brian Wolff: [C: 04-1] "Hmm, the z-index is probably in case the message overlaps with the play button. Hold off on this for a little bit." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108631 (owner: 10Brian Wolff) [21:29:57] (03PS1) 10Matthias Mullie: Move flow( 'loadReplyForm' ) to base/action.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108634 [21:30:00] (03PS1) 10Matthias Mullie: Alternative way of dealing with edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108635 [21:33:32] (03CR) 10Matthias Mullie: Move flow( 'setupEditForm' ) to base/action.js (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108535 (owner: 10Matthias Mullie) [21:34:33] (03CR) 10Matthias Mullie: Edit conflicts (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 (owner: 10Matthias Mullie) [21:35:35] @Seen kaldari [21:35:43] @seen kaldari [21:35:43] Technical_13: Last time I saw kaldari they were quitting the network with reason: Quit: kaldari N/A at 1/18/2014 1:52:27 AM (2d19h43m16s ago) [21:39:18] (03PS1) 10Brian Wolff: Make play button have higher z-index so its clickable. [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/108637 [21:40:34] (03PS2) 10Brian Wolff: Increase z-index on cannot play file warning [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108631 [21:41:04] You know what, sometimes I think its a wonder that anyone can actually play videos [21:41:46] I usually download them and play them in VLC. [21:43:41] Gloria: Well I just fixed a bug where the download link was broken in some situations, so some people couldn't do that [21:44:34] Gloria: On commons, if your browser didn't support video, it popped up with a message "Click here for help playing this file", which wasn't a clickable link [21:45:15] (03CR) 10Addshore: [C: 031] Use PHPUnit filter/whitelist to select the files that need testing. [core] - 10https://gerrit.wikimedia.org/r/90584 (owner: 10JanZerebecki) [21:46:14] (03CR) 10Addshore: [C: 031] Make it possible for extensions to specify which version of MediaWiki they support via Composer. [core] - 10https://gerrit.wikimedia.org/r/105092 (owner: 10Jeroen De Dauw) [21:47:17] bawolff: Stay classy, Commons. [21:54:46] (03CR) 10Addshore: [C: 031] Add tests for API's assert={user|bot} [core] - 10https://gerrit.wikimedia.org/r/108291 (owner: 10Legoktm) [21:58:38] Who can spot what's wrong with this html: [21:58:40] For a better video playback experience we recommend a [ HTML5 video browser].
[22:09:55] not even to mention the _new instead of _blank [22:13:47] ... [22:14:14] funny, is that generated by JS or PHP [22:15:48] Nemo_bis: Its generated by js [22:17:14] I see, again those ugly inconsistencies [22:17:17] looks decently broken :P [22:17:29] can't remember when the rendering was last changed, should be a few months though [22:18:45] The code is saying replace the $1 with an element (like an actually created DOM element), and the message is treating $1 as a url, and assuming the message is parsed [22:19:03] which if that did actually work sounds like the most horrible api ever [22:27:25] (03PS1) 10Brian Wolff: Fix broken link in mwe-embedplayer-for_best_experience message [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108639 [22:27:43] (03PS1) 10Ottomata: Making default apache vhost listen be *:80 [vagrant] - 10https://gerrit.wikimedia.org/r/108640 [22:29:34] (03CR) 10Ottomata: "Ori, I'd rather not use mediawiki-vagrant's apache module, because it makes my modules only work with your setup. I'm puppetizing wikimet" [vagrant] - 10https://gerrit.wikimedia.org/r/108640 (owner: 10Ottomata) [22:33:05] (03CR) 10Brian Wolff: "For reference, this was previously outputting the following api:" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108639 (owner: 10Brian Wolff) [23:02:57] am i crazy, or does the API not send page ids? [23:03:12] you're crazy [23:03:33] Now, can you be more spcific about the request you are sending? [23:04:01] http://en.wikipedia.org/w/api.php?action=parse&page=User:Jorm&format=jsonfm [23:04:07] here's what i'm trying to do. [23:04:16] i'm trying to unspool this: [23:04:17] http://en.wikipedia.org/w/api.php?action=query&meta=userinfo&uiprop=options&titles=Jorm&prop=revisions&rvlimit=400&format=jsonfm [23:04:33] jorm: it probably sends them if you ask it to [23:04:39] "pageid": 1502847, [23:04:43] but the document structure is: query -> pages -> pageid(unknown) -> revisions [23:04:47] and i want revisions. [23:04:52] jorm: &indexpageids=1 [23:05:00] https://en.wikipedia.org/w/api.php?action=query&meta=userinfo&uiprop=options&titles=Jorm&prop=revisions&rvlimit=400&format=jsonfm&indexpageids=1 [23:05:05] you have a new array at the top now [23:05:22] hrm. [23:05:25] oh, the parse request.... [23:05:35] i just want the revision list for a page. [23:05:57] and walking that tree without knowing the middle id is gonna be a pain. [23:06:06] also i fucking hate javascript. [23:06:49] .map() [23:07:14] if you don't want to do the &indexpageids=1 [23:09:45] jorm: ah you've discovered the API's query module and how it lists page records [23:09:54] yeah it kinds sucks butt [23:10:05] you can iterate over the list that you expect to have one item and grab it out [23:10:11] it's just... damn annoying to do [23:10:31] yeah. [23:10:36] you know, i'm gonna go "fuck it" [23:10:48] because seriously? faking up a history page is probably not needed with the Winter demo. [23:10:58] Contributions is a big enough pain in the ass. [23:11:33] i think it's time to upload a new version. [23:11:39] \o/ [23:17:02] I'm trying to set up mediawiki-vagrant on a new system, and it stalls on... notice: /Stage[main]/Git/Package[git]/ensure: ensure changed 'purged' to 'latest' [23:17:15] pour your hate into this: http://unicorn.wmflabs.org/winter/ [23:17:20] ori et al, any suggestions? [23:18:03] jorm: Its too nosy. Its asking for name [23:18:34] jorm: there's no max-width, so it seems great so far. [23:18:49] click that "typography" thing in the sidebar [23:19:02] (it's a toggle) [23:19:28] and shit should work, btw. [23:19:31] like, lots of shit. [23:19:34] links, etc. [23:19:38] your user page, etc. [23:20:05] the sad thing that broke is the highlighting of the section you're about to edit. [23:20:26] feedback link in the sidebar [23:21:34] jorm: more and more i think "gosh i wish the sidebar were fixed" [23:21:49] the problem is that the sidebar has an unknown height. [23:21:54] (i've thought about this a lot!) [23:22:03] :) [23:22:12] but my favorite thing about winter is how the sidebar's border just. . . disappears when you scroll. [23:22:23] jared wants to get rid of the sidebar entirely. [23:22:31] but language links... it's a problem. [23:22:39] well [23:22:51] we may have to give up the idea of showing a gigantic huge list on every page [23:22:56] if you want to see what i was banging my head about, go to your usermenu and click "contributions" [23:23:11] yeah. hopefully langeng has some ideas. [23:23:17] cute as it is, it's *big*, awkward to use, and requires loading a ton of fonts (or special autonym font [23:24:00] yah. [23:24:11] protip: loading talk pages in this thing is. . . entertaining. [23:24:14] in mobile apps we're definitely thinking about showing you some 'favorite' languages at the top -- like having a button or menu item to get you the language list, then showing you english, your browser language, your user language, and anything you've clicked on a lot in the past [23:24:19] and then the rest, searchable [23:24:22] because i'm not pulling Common.css, so a lot breaks. [23:24:31] tiny screens and big lists never mix well :D [23:25:07] i want to do a thing where, when you enable the typography clicker, that shit like infoboxes float outside of the main content area and into the right gutter. [23:25:35] jorm: oh a small fix for your demo -- don't forget to scroll back to top of page after loading a new article [23:25:49] * jorm adds to the to-do list. [23:25:58] easy to do irc, window.scrollTo(0,0) or something [23:26:00] *iirc [23:26:32] jorm: pooh i like the drop-down ToC [23:26:34] *ooh [23:28:02] oh, i totally misread you for a second. [23:28:03] yeah. [23:28:08] heh [23:28:26] in earlier versions, that didn't appear until you scrolled past the in-page TOC but we decided to just drop it in there. [23:28:42] hmm, that sidebar border fadeout is a little weird [23:29:07] it might be simpler to just keep the border at the top where the sidebar is "not empty" and have a fading gradient below? [23:30:09] jorm: practical question about the logos: are you using two separate images (one image+text and one text-only) or cropping off the image portion of the logo when the top bar collapses? [23:30:46] it occurs to me i can check that myself ;) [23:30:49] yeah it's cropped [23:30:57] we'll have to consider logo sizing guidelines at some point :D [23:31:12] yes. [23:31:31] but in this case, i tried desperately to avoid having to goof with image switching. so it's just the same image. [23:31:37] jquery.waypoints is a wonderful, wonderful thing. [23:31:51] :D [23:31:56] MatmaRex: how is it weird for you? for me, the fadeout is super smooth. [23:32:25] yeah, it is smooth [23:32:37] but, say, you scroll down a bit so it fades out, then just up with Home [23:32:41] and you see it fade back in [23:33:01] i need to get the sidebar collapse tokens to work so i can see what happens to the border when you goof with them. [23:33:05] i dunno, the behavior just feels weird for me [23:34:19] i can see it maybe being distracting. [23:34:39] jorm: i like that this design still works well at 1/2 of a 1920x1080 screen [23:34:54] gmail tricking poops its pants at that size and collapses all my vertical spacing for no reason [23:35:13] i tried to be as minimally invasive as possible to the DOM. [23:35:23] you can see my horrible hacks at libs/winter.js [23:35:27] :D [23:35:41] there's only a few - like deleting section edit links to insert the buttons and the like. [23:35:56] whee iOS 7.1 beta 4 is out... i gotta read some release notes [23:37:07] ooh "A property, minimal-ui, has been added for the viewport meta tag key that allows minimizing the top and bottom bars on the iPhone as the page loads. While on a page using minimal-ui, tapping the top bar brings the bars back." [23:48:41] (03CR) 10MZMcBride: "Bump?" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/98257 (owner: 10Legoktm) [23:49:32] jorm: oh, also. the fixed top bar makes anchor links rather unusable [23:49:39] jorm: like the links to references [23:49:49] it's a known issue, actually. [23:49:51] the part you wanted to look at is hidden by the bar :/ [23:49:53] yeah, i assume [23:49:54] i think i listed it. [23:50:11] but it's also a solved problem; i'm just lazy. [23:50:12] i haven't seen anyone solve it anywhere yet [23:50:45] i guess you could want for fragment changes and always scroll by additional 100px down [23:50:52] yep. [23:51:02] but gods, that's awful [23:51:05] yup. [23:51:27] and this could be done in a different way [23:51:42] by "moving" the scrollbar from body to some inner element that actually contains the content [23:52:02] (it makes fancy header state transitions harder i guess, though) [23:53:54] well, the DOM construct for the prototype is slightly different than a standard vector layout. [23:54:10] so in practice, it may be weirder. [23:54:11] Re: interlanguage links in the sidebar, and unknown length of it - we might be able to get it down to ~5-10 links, with https://www.mediawiki.org/wiki/Beta_Features/New_Features#Better_Interlanguage_Links [23:55:37] step 1: take over world. step 2: declare esperanto the sole language of the new world order. step 3: shorter interlanguage link lists! [23:55:59] (03CR) 10MZMcBride: "This change needs to be rebased. :-(" [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas)