[00:00:32] jgonera: mw.Title's getUrl() ? [00:01:22] spage, mw.util.getUrl(), but I'm not sure yet how to get the link to Privacy policy (which is SITENAME:Privacy_policy) [00:02:48] ah, I should use a message, mw.msg( 'privacypage' ) [00:02:52] (03PS1) 10Brian Wolff: Fix js bug where error report was always for first link. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108172 [00:07:54] (03CR) 10Ori.livneh: Expand load.php's "no modules requested" output to be friendlier (032 comments) [core] - 10https://gerrit.wikimedia.org/r/108008 (owner: 10MZMcBride) [00:08:22] mw.util.getUrl jgonera [00:08:26] sorry for the late reply [00:08:46] yeah, found it, thanks ;) [00:09:02] (03CR) 10Bartosz Dziewoński: "Killjoys all around :(" [core] - 10https://gerrit.wikimedia.org/r/108008 (owner: 10MZMcBride) [00:10:23] <^demon|away> MatmaRex: Nobody has any fun anymore :( [00:10:49] yeah [00:10:56] (03CR) 10Chad: [C: 032] "I doubt anyone ever even knew this existed but us." [core] - 10https://gerrit.wikimedia.org/r/108166 (owner: 10Aaron Schulz) [00:11:14] :(( [00:11:15] (03CR) 10MZMcBride: Expand load.php's "no modules requested" output to be friendlier (032 comments) [core] - 10https://gerrit.wikimedia.org/r/108008 (owner: 10MZMcBride) [00:11:16] :`( [00:11:41] * ori sobs bitterly. [00:11:47] we should draw some hidden dicks in one of the tiny SVG icons! [00:11:50] (03PS2) 10Ori.livneh: Expand load.php's "no modules requested" output to be friendlier [core] - 10https://gerrit.wikimedia.org/r/108008 (owner: 10MZMcBride) [00:12:01] <^demon|away> MatmaRex: I'm sure we need more svg tests. [00:12:28] (03CR) 10Ori.livneh: [C: 032] Expand load.php's "no modules requested" output to be friendlier [core] - 10https://gerrit.wikimedia.org/r/108008 (owner: 10MZMcBride) [00:13:34] <^d> ori: AaronSchulz and I are trying to make MW faster. Each class we remove is some non-0 amount of time and memory we'll no longer spend processing it in $wgAutoloadClasses. [00:13:47] <^d> Enough micro-optimizations and we'll have a whole optimization! [00:14:13] * AaronSchulz is trying to conserve complexity by deleting stuff as things are added ;) [00:14:36] (03Merged) 10jenkins-bot: Removed expiremental LSLockManager class [core] - 10https://gerrit.wikimedia.org/r/108166 (owner: 10Aaron Schulz) [00:14:47] ori: ty [00:15:21] i still think it's 'web'! :P [00:15:36] (03Merged) 10jenkins-bot: Expand load.php's "no modules requested" output to be friendlier [core] - 10https://gerrit.wikimedia.org/r/108008 (owner: 10MZMcBride) [00:15:44] Many Web sites make up the Internet. [00:15:46] but, as one ezra koenig put it [00:15:55] who gives a fuck about an oxford comma? i've seen those english dramas too. they're cruel. [00:16:36] <^d> AaronSchulz: Something like that :) [00:16:41] <^d> I think we're in a losing battled though [00:16:46] <^d> *battle [00:19:11] gwicke: I wonder that RdfMetaData was for? [00:21:04] greg-g: do you have a moment to scheme? [00:21:16] (03PS1) 10Aaron Schulz: Removed RdfMetaData [core] - 10https://gerrit.wikimedia.org/r/108179 [00:21:54] AaronSchulz, is that the thing in the skin? [00:22:32] (03CR) 10Aaron Schulz: [C: 031] Fix transcodes on files with long non-ascii names (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108170 (owner: 10Brian Wolff) [00:22:46] (03CR) 10Aaron Schulz: "Haven't tested" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108170 (owner: 10Brian Wolff) [00:24:23] AaronSchulz: RdfMetaData was for a feature that ^d killed I think [00:24:43] at least a year ago [00:24:50] was Daniel Friesen involved in it? [00:25:05] <^d> Rdf? [00:25:07] <^d> Was that me? [00:25:13] (03PS4) 10JGonera: [WIP] Add Compact personal bar beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99586 [00:25:18] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add Compact personal bar beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99586 (owner: 10JGonera) [00:25:22] I thought it was [00:25:32] you don't remember who and what you killed! [00:27:09] includes/Metadata.php lists Evan as author [00:27:37] <^d> AaronSchulz: I kill so many things. [00:27:38] Oh, looks like it was Reedy who killed it [00:27:51] yeah, that's probably why I jumped to your name [00:27:58] It deserved it [00:28:09] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/88868 [00:28:18] lol [00:28:21] Nearly 3 years ago [00:29:40] #Comment by Bawolff (Talk | contribs | block) 22:19, 10 June 2011 [00:29:40] There's still references to this feature in the installer. [00:29:47] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/88873 [00:30:35] (03CR) 10Kaldari: [C: 032] "It's had 2 +1s and I doubt anyone else is going to review this." [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/106435 (owner: 10Kaldari) [00:30:37] (03Merged) 10jenkins-bot: Modify the Special:LonelyPages query to ignore disambiguation pages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/106435 (owner: 10Kaldari) [00:32:33] (03PS5) 10JGonera: [WIP] Add Compact personal bar beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99586 [00:35:14] (03PS1) 10Chad: Remove unused variable [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108183 [00:40:16] (03CR) 10Jdlrobson: [C: 032] "+2ing but this code has issues.. shall I raise a bug or just hope for a follow up? :)" (033 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107633 (owner: 10Kaldari) [00:40:32] (03Merged) 10jenkins-bot: Story 1604: Remember mobile thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107633 (owner: 10Kaldari) [00:42:01] bawolff: https://gerrit.wikimedia.org/r/#/c/106219/ [00:42:42] will look in a moment [00:44:11] (03CR) 10CSteipp: [C: 032] "The login/creation flow needs some work in general, but I don't think this makes the situation any worse, and greatly helps the specific i" [core] - 10https://gerrit.wikimedia.org/r/106844 (owner: 10Brion VIBBER) [00:45:30] (03PS1) 10Chad: Begin abstracting more of the database-specific search backend out [core] - 10https://gerrit.wikimedia.org/r/108187 [00:48:03] (03Merged) 10jenkins-bot: Add hooks in API action=createaccount for Captcha [core] - 10https://gerrit.wikimedia.org/r/106844 (owner: 10Brion VIBBER) [00:49:19] brion: Did you want to make that change to https://gerrit.wikimedia.org/r/#/c/108088/ yet, or leave it for a followup? [00:53:52] (03PS2) 10TheDJ: Update ACE to Jan 17, 2014 [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/108050 [01:01:42] (03CR) 10Kaldari: [C: 04-1] Add oldRev parameter to DiffRevisionTools hook (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105384 (owner: 10Jackmcbarn) [01:05:48] (03CR) 10Jackmcbarn: Add oldRev parameter to DiffRevisionTools hook (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105384 (owner: 10Jackmcbarn) [01:16:35] (03CR) 10Brian Wolff: [C: 04-1] "This double escapes the message. Otherwise its fine." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106219 (owner: 10Aaron Schulz) [01:17:30] 7 items deleted, 2 items excluded, 24 folders created, 3,013 files transferred, 52,018 files are up to date [01:19:43] (03CR) 10Spage: "Problem with mw-ui-button hyperlinks." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/103494 (owner: 10JGonera) [01:21:39] (03PS3) 10Aaron Schulz: Improved vague/incomplete $1 thumb.php error messages [core] - 10https://gerrit.wikimedia.org/r/106219 [01:27:02] (03PS1) 10Nullzero: Also show a warning on page deletion if a page is transcluded [core] - 10https://gerrit.wikimedia.org/r/108188 [01:28:40] (03PS10) 10Anomie: Add API action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/70749 [01:31:07] (03CR) 10Bsitu: "The patch needs a rebase." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106449 (owner: 10EBernhardson) [01:36:23] AaronSchulz: Hmm, there's some docs that suggest one's always supposed to do wfMessage( 'foo' )->text() instead of wfMessage( 'foo' );. I'm not sure if that's still a convention or not [01:40:53] (03CR) 10Parent5446: [C: 031] Also show a warning on page deletion if a page is transcluded [core] - 10https://gerrit.wikimedia.org/r/108188 (owner: 10Nullzero) [01:40:59] (03CR) 10Brian Wolff: "There's some docs that say one should always use wfMessage( 'foo' )->text() instead of only wfMessage( 'foo' ). I'm not sure if that is a " [core] - 10https://gerrit.wikimedia.org/r/106219 (owner: 10Aaron Schulz) [01:44:19] spage, ebernhardson, werdna: ping re: https://bugzilla.wikimedia.org/show_bug.cgi?id=57659 ? [01:44:22] (03CR) 10Bsitu: Make error reporting more verbose. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107149 (owner: 10Matthias Mullie) [01:45:09] (03CR) 10Parent5446: [C: 04-1] "Inline. Otherwise looks good." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/108187 (owner: 10Chad) [01:46:36] ori, legoktm is working on Flow API for real, https://gerrit.wikimedia.org/r/#/c/107411/ [01:47:50] do you think can you help him see that work through before expanding deployment? [01:48:09] https://bugzilla.wikimedia.org/show_bug.cgi?id=59937#c3 [01:48:15] Lord Jesus Almighty. [01:48:21] Grahhhh. [01:48:35] yeah, I expect to have it finished in a day or two [01:52:11] sweet [02:12:09] And then there's Maude. [02:12:12] Hello, https://bugzilla.wikimedia.org/show_bug.cgi?id=60178 [02:12:58] !log LocalisationUpdate completed (1.23wmf10) at 2014-01-18 02:12:58+00:00 [02:13:58] (03CR) 10Nikerabbit: [C: 04-1] "Yes, always define the output format." [core] - 10https://gerrit.wikimedia.org/r/106219 (owner: 10Aaron Schulz) [02:17:37] (03CR) 10Aaron Schulz: [C: 032] Also show a warning on page deletion if a page is transcluded [core] - 10https://gerrit.wikimedia.org/r/108188 (owner: 10Nullzero) [02:18:56] logmsgbot is in here now? [02:19:00] !logging [02:19:00] There is no such key, you probably want to try: !debug, [02:19:06] Herp. [02:20:46] (03Merged) 10jenkins-bot: Also show a warning on page deletion if a page is transcluded [core] - 10https://gerrit.wikimedia.org/r/108188 (owner: 10Nullzero) [02:21:02] (03PS4) 10Aaron Schulz: Improved vague/incomplete $1 thumb.php error messages [core] - 10https://gerrit.wikimedia.org/r/106219 [02:22:37] logmsgbot using "!log" in here isn't a bug, but it'll bother me forever. [02:23:07] Ahm, wtf [02:23:20] In the mw-bot days we would configure it with !log is Wrong channel [02:24:11] wm-bot responding to !log got disabled in this channel just the other day [02:24:38] Probably because of logmsgbot triggering it? [02:25:10] I filed and resolved https://bugzilla.wikimedia.org/show_bug.cgi?id=60190 [02:25:53] RoanKattouw: Is Flow ready for enwiki? And is enwiki ready for Flow? [02:26:05] !log LocalisationUpdate completed (1.23wmf11) at 2014-01-18 02:26:05+00:00 [02:26:17] Gloria: I don't know, ask the Flow people :) [02:26:21] I haven't looked at Flow in months [02:27:59] RoanKattouw: The Flow people are probably biased. [02:28:28] Gloria: based on the UI I saw on mw wiki? [02:28:36] you guys all know my view on that [02:29:14] Well sure [02:29:30] But they have more than zero information and I have actually zero information [02:29:57] Sorry, I'm new around here. [02:30:00] ;-) [02:30:16] lol [02:30:27] Having zero information seems like a feature to me. [02:30:30] You'll have an honest opinion. [02:31:10] Someone has to make a determination whether it's ready for production. [02:33:16] Gloria: Wasn't it just the other week we found out that blocking didn't work on flow - that seems like quite a big oversight if flow was really this close to being ready [02:34:01] Yeah I was about to mention that [02:35:27] RoanKattouw, Gloria: I modified logmsgbot to log both here and #wikimedia-operations because I thought it was a bit lame that developers were congregating in #wikimedia-operations [02:35:27] bawolff: Tell the bug. [02:35:29] :-) [02:35:47] Let's get rid of -operations and -dev and return to -tech. [02:35:53] +1 [02:36:03] Is it the fact messages are duplicated here that is annoying, or the '!log' ? [02:36:08] the fact that, even [02:36:14] The !log, mostly. [02:36:22] But it may soon be the messages, dunno. [02:36:23] Gloria: Lets make a fourth irc channel without bots, its too distracting! [02:36:27] call it #wikipedia [02:36:30] _usability [02:36:37] _security [02:36:45] Well, the solution, IMO, is not to use Freenode as a means of communication for two daemons running on the Wikimedia production cluster [02:36:53] A single bot should notify IRC and update the SAL. [02:37:22] And the SAL should be redone. [02:37:24] Because it sucks. [02:37:27] There's a bug for that. [02:37:28] yes [02:37:29] ® [02:37:40] poke ops [02:38:05] But... I have been thinking about IRC a lot and how fragmented and tribal it is, and I like the thought of getting rid of -operations and -dev and returning to -tech [02:38:29] why don't you try and squeeze that into the summit agenda? [02:38:36] FIX ALL THE THINGS [02:38:39] gj Gloria [02:39:04] it's basically the one forum where a decision like this has a snowball's chance of being made [02:39:15] Heh. [02:39:26] it's --> the Architecture Summit? [02:39:27] * bawolff remembers when I only joined #mediawiki by default [02:39:31] I wouldn't go into it with that attitude. [02:39:31] yeah [02:39:41] If you do, you'll only find disappointment. [02:39:51] There will be discussion and debate about important topics. [02:40:20] If anything good comes of that, it'll be a bonus. [02:46:10] !log LocalisationUpdate ResourceLoader cache refresh completed at 2014-01-18 02:46:09+00:00 [02:54:49] (03CR) 10Brian Wolff: [C: 032] Improved vague/incomplete $1 thumb.php error messages [core] - 10https://gerrit.wikimedia.org/r/106219 (owner: 10Aaron Schulz) [02:56:42] (03PS2) 10Brian Wolff: Fix transcodes on files with long non-ascii names [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108170 [02:56:59] (03CR) 10Brian Wolff: "PS2: Fix error in comment" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108170 (owner: 10Brian Wolff) [02:58:02] (03Merged) 10jenkins-bot: Improved vague/incomplete $1 thumb.php error messages [core] - 10https://gerrit.wikimedia.org/r/106219 (owner: 10Aaron Schulz) [03:13:42] Hello. [03:14:41] hi [03:24:12] (03CR) 10Brian Wolff: "I have a nitpicky alternative fix that I would prefer, however since that's nitpicky if you don't like that idea, what you have here would" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106552 (owner: 10Bartosz Dziewoński) [03:24:46] https://gerrit.wikimedia.org/r/#/c/108191/ [03:28:23] (03PS1) 10Ori.livneh: Update ULS to master for I862b01e6b (@embed fix) [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/108192 [03:29:15] (03CR) 10Ori.livneh: [C: 032 V: 032] Update ULS to master for I862b01e6b (@embed fix) [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/108192 (owner: 10Ori.livneh) [03:32:52] !log ori synchronized php-1.23wmf10/extensions/UniversalLanguageSelector 'Update ULS to master for I862b01e6b (@embed fix)' [03:36:02] (03PS1) 10Ori.livneh: Update UniversalLanguageSelector to master [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/108193 [03:36:46] (03CR) 10Ori.livneh: [C: 032 V: 032] Update UniversalLanguageSelector to master [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/108193 (owner: 10Ori.livneh) [03:38:05] !log ori synchronized php-1.23wmf11/extensions/UniversalLanguageSelector/resources/js/ext.uls.webfonts.js 'Update UniversalLanguageSelector to master for I2da436caa: Wait till rendering thread completion before applying webfonts (Bug: 59958)' [03:39:00] !log ori synchronized php-1.23wmf11/extensions/UniversalLanguageSelector 'Update ULS to master for I862b01e6b (@embed fix)' [04:20:44] (03CR) 10Brian Wolff: [C: 04-1] "First of all the commit message reverted to a version with issues. The version in Patchset 5 was fine." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/106625 (owner: 10AalekhN) [04:43:52] (03CR) 10Brian Wolff: [C: 04-1] SpecialContributions.php : made Special:Contributions includable (033 comments) [core] - 10https://gerrit.wikimedia.org/r/106320 (owner: 10AalekhN) [04:49:36] (03PS3) 10TTO: Stop using prettifyIP for user links [core] - 10https://gerrit.wikimedia.org/r/92263 [04:58:01] (03CR) 10Brian Wolff: "Does anyone have any objections to allowing this codec? I certainly can't think of any." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/103402 (owner: 10Michał Łazowik) [05:13:04] (03CR) 10Brian Wolff: bug 55742: fix types in JSON videoinfo output (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/89846 (owner: 10Brion VIBBER) [05:13:19] (03PS10) 10Spage: Update mediawiki.ui button styles [core] - 10https://gerrit.wikimedia.org/r/103494 (owner: 10JGonera) [05:16:27] (03CR) 10Brian Wolff: [C: 032] Don't pass arguments to methods that don't need them [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/106930 (owner: 10Siebrand) [05:16:30] (03Merged) 10jenkins-bot: Don't pass arguments to methods that don't need them [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/106930 (owner: 10Siebrand) [05:18:18] (03CR) 10Spage: "PS10 responds to my own comments:" [core] - 10https://gerrit.wikimedia.org/r/103494 (owner: 10JGonera) [05:24:31] (03PS2) 10Brian Wolff: Clean up RL module definitions. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/92052 (owner: 10Spage) [05:31:56] (03CR) 10Brian Wolff: [C: 032] "I tested the patch, and nothing exploded." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/92052 (owner: 10Spage) [05:31:59] (03Merged) 10jenkins-bot: Clean up RL module definitions. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/92052 (owner: 10Spage) [05:43:18] (03PS2) 10Brian Wolff: Pull upstream fix for File_Ogg [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/86262 (owner: 10J) [05:44:06] (03PS3) 10Brian Wolff: Pull upstream fix for File_Ogg [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/86262 (owner: 10J) [05:47:03] (03CR) 10Brian Wolff: [C: 032] Pull upstream fix for File_Ogg [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/86262 (owner: 10J) [05:47:06] (03Merged) 10jenkins-bot: Pull upstream fix for File_Ogg [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/86262 (owner: 10J) [05:48:03] Hi tonythomas01 [05:52:02] basile: Hi ! [05:52:09] sorry bawolff Hi [05:52:14] nick error [05:53:36] tonythomas01: I've noticed you've been going through the list of easy bugs recently, you may be interested in bug 60194 [05:54:11] bawolff:that looks good [05:54:21] bawolff: going through :) Thanks [05:55:18] bawolff: its assigned to someone else ? [05:55:42] oh, you can ignore that, all timedmediahandler bugs are assigned to mdale by default [05:56:08] Long time ago we used to auto-assign extension bugs to people, then we stopped, except for some reason not for TimedMediaHandler [05:56:38] feel free to unasign it from him and take it for yourself (or just do it without messing with the assignment) [05:58:25] mwalker|away: you're away now, but now I'm here :/ [05:59:59] yurik hi [06:00:22] diwanship, hey [06:00:29] bawolff: ok :) [06:01:09] i was filing bug.. which product i shall choose ? MediaWiki ->General ? [06:01:22] diwanship, api [06:01:22] There's probably lots of other little things in TimedMediaHandler, if your bored and looking for things to do (e.g. Mp4Handler class calls wfMsg instead of wfMessage) [06:02:11] Yurik but there is no product specifying API [06:03:02] diwanship, specify product MediaWiki, Component - API [06:03:16] ohhh ok thanks [06:04:25] bawolff: Please ping me on such bugs as we have about 4 or 5 fresh contributors here. [06:04:33] bawolff: and of course all looking for easy bugs [06:06:46] (03PS11) 10Spage: Update mediawiki.ui button styles [core] - 10https://gerrit.wikimedia.org/r/103494 (owner: 10JGonera) [06:07:59] (03CR) 10Spage: "PS11 implements Jared-style quiet buttons, not rainbow quiet." [core] - 10https://gerrit.wikimedia.org/r/103494 (owner: 10JGonera) [06:08:26] (03PS4) 10Spage: [WIP] Update login and HTMLForm to new design [core] - 10https://gerrit.wikimedia.org/r/104011 [06:22:30] (03PS1) 1001tonythomas: Added timedmedia-wav message [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108199 [06:29:55] bawolff: is there a bug reported in BZ for the second one you told ? Mp4Handler class calls wfMsg instead of wfMessag ? [06:30:09] No, I haven't reported that one [06:30:35] bawolff: Should I ? [06:31:50] If you want to. If you're intending to fix it, you could just submit a patch without there being a bug filed (Especially for small issues) [06:33:08] bawolff: I will [06:33:21] submit the patch [06:34:16] (03CR) 10Brian Wolff: "Could you also update the comment in WebVideoTranscode::getPrimarySourceAttributes (The comment should also mention timedmedia-flac which " [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108199 (owner: 1001tonythomas) [06:37:56] (03PS2) 1001tonythomas: Added timedmedia-wav message Updated comment in WebVideoTranscode::getPrimarySourceAttributes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108199 [06:38:37] (03CR) 1001tonythomas: "Bawolff: done" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108199 (owner: 1001tonythomas) [06:43:12] legoktm: hmm, do you know how cached RC api call is? [06:43:31] we're considering having a runny stream of 'just edited articles' on the 'home' page [06:43:33] of the app [06:43:55] as in, if I hit it 10million times a day [06:43:57] will it die? [06:44:10] I don't think the API is cached at all. [06:44:41] yuvipanda: https://www.mediawiki.org/wiki/Requests_for_comment/Publishing_the_RecentChanges_feed#External_endpoint <-- I think that's the proper way to do it ;) [06:45:05] brrr, yes [06:45:09] I need to work on that someday [06:45:30] also, while that makes sense for enwiki, for wikis that only have an edit every 5-10 minutes, it doesn't need to be auto-updating [06:45:39] legoktm: ? [06:45:58] legoktm: i was thinking something like 'grab 20 edits, recycle them for a bit and then do some more' [06:46:07] is the app only for enwiki or for other Wikipedias too? [06:46:15] legoktm: every wiki, yeah [06:46:16] ohohoh [06:46:18] you can switch in settings [06:46:18] hmm [06:46:24] how often are you going to hit it? [06:46:27] legoktm: it's just a way of showing 'look this is aliveee!' [06:46:32] legoktm: every app startup [06:46:43] multiple times a day, I'd guess [06:46:52] on about 15 million devices for Android, and idk how many on iOS [06:46:53] you should probably talk to anomie about it [06:47:01] hmm, right [06:47:29] I'll do that later when he's awake, I suppose [06:47:44] legoktm: websockets for this, in the app, feel a bit like overkill :D [06:48:01] legoktm: the other option is to do a GMail style 'edits in the last minute' counter that's just an estimate. [06:48:15] no API requests there, but we'll auto-update the params once a day or somesuch [06:49:03] I prefer using xmpp over websockets [06:49:42] no reason we can't have both [06:50:00] websockets are easier to setup and maintain, since the necessary components are already on our infra [06:50:04] nginx & node [06:50:18] while if you do xmpp you most probably have to get an erlang based thing on in here [06:50:58] legoktm: we also know how to easily scale it out. just add more machines [06:51:15] "Need to figure out how to make it scale and hardened" [06:51:35] yeah, hardening is probably easier with xmpp [06:51:41] scaling too, come to think of it [06:52:00] ejabbered is written in erlang yeah, but its already hardened and tested [06:52:11] indeed [06:52:19] not disagreeing. [06:52:46] legoktm: is that going to be talked about in the arch summit? [06:53:30] legoktm: personally, I don't care if it is xmpp or ws, as long as it isn't goddamn IRC... [06:53:50] if I can get it on the agenda? But I'm pushing for Configuration much harder [06:54:07] legoktm: ah, yeah [06:54:12] sounds more important, that [06:54:13] yuvipanda: well, sending JSON packets over IRC is going to be like 10 lines of config to set up [06:54:38] legoktm: true, but if you're going to do JSON might as well use a better protocol than IRC [06:54:46] indeed! [06:54:54] if we do xmpp, it'll be xml though [06:55:11] awww [06:55:26] (03PS1) 1001tonythomas: Changed Mp4Handler class call from wfMsgto wfMessage [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 [06:55:44] XMPP packets can embed arbitrary XML subdocuments, which could carry structured data directly instead of embedding a JSON blob in XML or something --brion [06:55:58] plus, the code is already merged into core for XML formatting [06:56:04] yeah, putting JSON in XML feels weird [07:00:34] (03CR) 10Brian Wolff: "Deprecated is spelt wrong in the commit message (I'm pretty sure MediaWiki is the only reason I can spell that word, when I first started " (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 (owner: 1001tonythomas) [07:01:05] json in xml? Why not have the worst of both worlds... [07:09:48] (03CR) 10Brian Wolff: [C: 04-1] "Sorry, totally missed a bunch of stuff (all minor though) the first time I looked at it. See inline" (033 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108199 (owner: 1001tonythomas) [07:28:36] (03PS2) 1001tonythomas: Changed Mp4Handler class call from wfMsgto wfMessage [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 [07:29:37] (03PS3) 1001tonythomas: Changed Mp4Handler class call from wfMsgto wfMessage [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 [07:29:40] (03CR) 10jenkins-bot: [V: 04-1] Changed Mp4Handler class call from wfMsgto wfMessage [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 (owner: 1001tonythomas) [07:31:27] (03PS12) 10Spage: Update mediawiki.ui button styles [core] - 10https://gerrit.wikimedia.org/r/103494 (owner: 10JGonera) [07:31:33] (03PS4) 1001tonythomas: Changed Mp4Handler class call from wfMsgto wfMessage [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 [07:32:13] (03CR) 10jenkins-bot: [V: 04-1] Changed Mp4Handler class call from wfMsgto wfMessage [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 (owner: 1001tonythomas) [07:33:13] (03PS5) 10Spage: [WIP] Update login and HTMLForm to new design [core] - 10https://gerrit.wikimedia.org/r/104011 [07:33:43] bawolff: and if you want to review them, there's https://gerrit.wikimedia.org/r/93740 [07:34:22] LQT but you know something about CSS I think [07:46:28] I'll add it to my list [07:47:02] * bawolff generally finds front end changes scary, as a lot more can go wrong, but that looks straightforward [07:48:40] (03PS5) 1001tonythomas: Changed Mp4Handler class call from wfMsgto wfMessage [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 [07:59:57] (03PS3) 1001tonythomas: Added timedmedia-wav message [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108199 [08:23:16] (03PS1) 10Brian Wolff: Output ogg metadata on image description page. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108203 [08:39:39] (03CR) 10Gilles: [C: 031] "Doesn't seem like it would cause any harm, since we already support 16-bit PCM. A simple explanation of the difference between the two for" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/103402 (owner: 10Michał Łazowik) [08:40:59] (03PS4) 10Brian Wolff: Added timedmedia-wav message [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108199 (owner: 1001tonythomas) [08:41:51] (03CR) 10Brian Wolff: [C: 032] "PS4: tiny pedantic nitpick about a space in a comment." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108199 (owner: 1001tonythomas) [08:41:54] (03Merged) 10jenkins-bot: Added timedmedia-wav message [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108199 (owner: 1001tonythomas) [09:04:11] (03PS2) 10Umherirrender: Add message wrongpassword as html on Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/104797 [09:04:53] (03CR) 10Brian Wolff: Changed Mp4Handler class call from wfMsgto wfMessage (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 (owner: 1001tonythomas) [09:15:36] (03CR) 10Brian Wolff: [C: 032] "Tested, it works. merging." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/103402 (owner: 10Michał Łazowik) [09:15:36] (03Merged) 10jenkins-bot: Allow to upload WAV files with 32 bit float uncmopressed audio [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/103402 (owner: 10Michał Łazowik) [09:22:07] (03CR) 10PleaseStand: [C: 04-1] Changed Mp4Handler class call from wfMsgto wfMessage (034 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 (owner: 1001tonythomas) [09:26:41] (03PS1) 10Arav93: Put the space before category links to consideration [core] - 10https://gerrit.wikimedia.org/r/108205 [09:34:11] (03CR) 10Brian Wolff: "I haven't tested this. A very quick look over though:" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/108205 (owner: 10Arav93) [09:39:06] (03CR) 10Arav93: "I completely agree with the commit message part. I tried to phrase it in a better way but I couldn't find anything better." [core] - 10https://gerrit.wikimedia.org/r/108205 (owner: 10Arav93) [09:55:51] (03PS6) 1001tonythomas: Changed Mp4Handler class call from wfMsgto wfMessage [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108200 [10:02:52] ori: Hie ori, hope you doing great :) [10:03:14] Can someone please tell me how should I add data to Specials pages, because the Edit option doesn't come over there [10:03:38] Ex: http://127.0.0.1:8080/wiki/Special:MostLinkedCategories [10:12:42] (03PS1) 10Legoktm: Add some more documentation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/108207 [10:22:14] is there a class wise documentation for wiki media? [10:52:26] !log springle synchronized wmf-config/db-eqiad.php 'repool db1041' [10:55:55] Working on this bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=33334 ... page_restrictions column should be removed from page table. But Title::loadRestrictionsFromRows compiles list of page_restrictions from both page table and page_restriction table. What should be done with this function? [10:59:00] it should be changed:P [10:59:40] MaxSem, changed or removed? [11:00:58] changed) [11:01:20] just kill everything related to $oldFashionedRestrictions [11:04:05] (03PS1) 10Ori.livneh: Strip descriptions from ResourceLoaderSchemaModule modules [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/108211 [11:12:03] MaxSem, I commented all functions wherever $oldFashionedRestrictions occured . But I just can't complete the installation. This is what I get: http://tinypic.com/r/fycrom/5 [11:12:47] MaxSem, I did the schema patches already [11:13:20] eh, what are you trying to accomplish? development should be done on already installed MW [11:14:57] MaxSem, I'm trying to see if the page_restrictions column will be deleted right after the database is created [11:23:29] (03CR) 10Bartosz Dziewoński: SpecialWantedcategories: Actually strike the category if it was emptied (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106552 (owner: 10Bartosz Dziewoński) [11:23:55] (03PS2) 10Bartosz Dziewoński: SpecialWantedcategories: Actually strike the category if it was emptied [core] - 10https://gerrit.wikimedia.org/r/106552 [12:02:11] (03CR) 10Rtdwivedi: [C: 04-1] "Submit action fails to save the changes. The problem is with this change and not with https://gerrit.wikimedia.org/r/#/c/106507/2 . In 6 c" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/106524 (owner: 10Tpt) [12:04:58] (03CR) 10Rtdwivedi: [C: 031] Add FileProvider [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/106507 (owner: 10Tpt) [12:15:33] (03PS3) 10Tpt: Refactoring of Page: pages edition PHP code [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/106524 [13:20:10] Hello. [13:52:39] Hie, I am trying to understand MediaWiki's code. Can someone please help me with what the Profiler class does? [14:03:36] (03Abandoned) 10Amire80: Show a warning when deleting a page to which there are links [core] - 10https://gerrit.wikimedia.org/r/65581 (owner: 10Ronengi) [14:03:46] So as far as I could find in this link, https://www.mediawiki.org/wiki/Manual:How_to_debug, Profiling is all about getting traceback of functions executed for debugging information. Can anyone validate my observation? [15:14:48] !log springle synchronized wmf-config/db-eqiad.php 'warm up db1033 in s7' [15:31:38] !log springle synchronized wmf-config/db-eqiad.php 'depool db1028' [15:45:01] why is logmsgbot talking here? O_o [15:45:59] Nemo_bis: It searches new friends ;) [15:52:41] /msg hoo I'm working on this bug:https://bugzilla.wikimedia.org/show_bug.cgi?id=33334. Prepared the schema patch. But still not sure of it. Will it be ok, if I upload it in gerrit, so that one of you can help me with it? [16:01:26] (03PS1) 10Tinaj1234: Removing page_restrictions from page table [core] - 10https://gerrit.wikimedia.org/r/108219 [16:02:26] hoo: then I hope it doesn't feel guilty of the netsplit :P [16:03:31] I want to add data to Special Pages, How to do so? [16:09:46] Gloria: https://bugzilla.wikimedia.org/show_bug.cgi?id=33334 you set easy on that one? :P [16:11:50] (03CR) 10Hoo man: [C: 04-2] "Prior to deploying this, all page restrictions have to be converted to the new format (the updateRestrictions.php maintenance script does " (033 comments) [core] - 10https://gerrit.wikimedia.org/r/108219 (owner: 10Tinaj1234) [16:27:29] (03CR) 10Bartosz Dziewoński: "There's definitely a bunch more of places which refer to this field, and which should be killed if this is to happen. Also, we'd need to r" [core] - 10https://gerrit.wikimedia.org/r/108219 (owner: 10Tinaj1234) [16:31:59] hmmm [16:32:11] there is only one occurence of 'fuck' in all of core code. [16:32:28] and 9 shits. 4 of those in one comment in Title.php. [16:32:39] i expected more from you, MediaWiki. [16:40:01] (03Abandoned) 10Bartosz Dziewoński: Always disallow user JS on Special:UserLogin [core] - 10https://gerrit.wikimedia.org/r/106855 (owner: 10Bartosz Dziewoński) [16:58:14] (03PS2) 10Bartosz Dziewoński: Rename RedirectSpecialPage subclasses [core] - 10https://gerrit.wikimedia.org/r/106888 [16:58:58] (03CR) 10jenkins-bot: [V: 04-1] Rename RedirectSpecialPage subclasses [core] - 10https://gerrit.wikimedia.org/r/106888 (owner: 10Bartosz Dziewoński) [17:01:01] (03PS3) 10Bartosz Dziewoński: Rename RedirectSpecialPage subclasses [core] - 10https://gerrit.wikimedia.org/r/106888 [17:01:50] (03CR) 10Bartosz Dziewoński: "Fixed per the comments, rebased. Thanks." [core] - 10https://gerrit.wikimedia.org/r/106888 (owner: 10Bartosz Dziewoński) [17:02:54] (03CR) 10jenkins-bot: [V: 04-1] Rename RedirectSpecialPage subclasses [core] - 10https://gerrit.wikimedia.org/r/106888 (owner: 10Bartosz Dziewoński) [17:08:52] (03PS1) 10Jackmcbarn: Don't pass empty strings to strpos [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/108220 [17:40:36] hoo|away: Schema changes are easy! [17:45:59] Gloria: In theory yes, but this one requires a lot of changes at a lot of places... sadly :/ [17:46:44] Really? [17:46:54] The "new" table has existed for many years, I think. [17:47:00] I can't remember when page.page_restrictions was still used. [17:47:31] hoo|away: If it's mis-tagged, just fix it. :P [17:50:43] heya NathRyan [17:51:25] hey mooey [17:53:02] NathRyan, so, you want to start developing MediaWiki stuff , you're in the right place :) [17:53:26] That's a good place to start as an overview - https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker [18:29:21] (03CR) 10Umherirrender: "Have also a look at MediaWikiTestCase.php around line 396" (038 comments) [core] - 10https://gerrit.wikimedia.org/r/108219 (owner: 10Tinaj1234) [18:31:07] ori: any ideas best way to change $wgServer for hhvm running on port 9999(or whatever)? It looks like vagrant/puppet isn't explicitly setting it, just passing it to the mediawiki installer. It looks like i could use @mediawiki::settings w/ header/footer to add an if(defined('HHVM_VERSION')) but feels hacky [18:42:00] ebernhardson: hm, good question. let me take a look. [18:42:17] ebernhardson: btw, have you noticed that there is now an 'hhvm-nightly' package in facebook's repository? [18:42:58] ori: i saw it but havn't tried it yet, the release 2.3.3 is now working well with 2.2+mod_fastcgi [18:43:10] ebernhardson: fuck off, seriously? [18:43:15] that is very exciting [18:43:23] although its slightly different, because we prev had DocumentRoot=/var/www, but hhvm is requiring the php files to be inside document root [18:43:29] so had to swap that around to /vagrant/mediawiki [18:45:13] ebernhardson: the $server_url line in roles.pp:38 is not helpful? [18:45:58] ori: the difficultly, perhaps i was being too lenient, but i was trying to have apache still on 8080, with hhvm on an independant port [18:45:59] (03PS3) 10EBernhardson: Hack together apache -> hhvm [vagrant] - 10https://gerrit.wikimedia.org/r/105834 [18:46:25] ori: rather than replacing it, because that $server_url goes into mediawiki module and passes through to the installer directly [18:47:25] (which i suppose also adds the complexity that 9999 needs to be manually forwarded in Vagrantfile-extra.rb as well) [18:47:28] ebernhardson: i'd say replace it; toggling roles is easy enough [18:47:34] hmm, ok [18:47:58] we don't have a concept of mutual exclusion with respect to roles but could always add one [18:50:10] ori: is there anyway to see which roles are enabled from inside a class? currently the mediawiki class brings in apache, it would need to then decide between apache and hhvm [18:51:16] i suppose could almost just use a global variable, but i dont fully understand puppet's order of execution [18:51:43] neither does puppet [18:51:47] :) [18:51:57] it's tricky, i don't have a good answer.. thinking about it [18:52:17] ok, i'll think about it a bit too [18:52:27] the order of execution is deliberately unspecified because puppet wants you to think about dependency relations rather than explicit ordering [18:52:51] the patch i just updated though uses fastcgi and runs hhvm on 9999, just needs the additional port forward and mostly seems to work [18:54:13] i'm quite impressed with hhvm tough, i go from 1 trans/sec to 11trans/sec comparing siege on zend vs hhvm [18:54:23] against Main_Page [19:00:59] hi paravoid [19:01:30] ebernhardson and i have a puppet problem [19:01:34] context: https://dpaste.de/DA0J/raw [19:02:35] basically a role needs to set a variable based on which of two possible classes are included [19:02:48] php or hhvm [19:20:23] (03PS4) 10Ori.livneh: Hack together apache -> hhvm [vagrant] - 10https://gerrit.wikimedia.org/r/105834 (owner: 10EBernhardson) [19:21:16] (03CR) 10Ori.livneh: "PS4: some minor whitespace fixes; moved multiverse stuff to apt module (might as well enable it unconditionally to keep things simple)" [vagrant] - 10https://gerrit.wikimedia.org/r/105834 (owner: 10EBernhardson) [19:22:44] * ebernhardson needs to setup vim with autocmd for the varying tab/space settings in projects [19:22:52] soon :) [19:34:16] (03PS7) 10Umherirrender: Add $wgHideUserContribLimit config setting [core] - 10https://gerrit.wikimedia.org/r/98267 [19:40:49] Can you not import your skin.js or common.js from one wiki to another? [19:41:11] /* Import all of my enwp scripts */// [[User:Technical 13/enwpScripts]] mw.loader.load( '//en.wikipedia.org/w/index.php?title=User:Technical_13/common.js&action=raw&ctype=text/javascript' );// Stable scripts mw.loader.load( '//en.wikipedia.org/w/index.php?title=User:Technical_13/vector.js&action=raw&ctype=text/javascript' );// Beta scripts [19:41:23] doesn't seem to be working... https://meta.wikimedia.org/wiki/User:Technical_13/common.js [19:42:47] (03PS1) 10Westurner: Updated includes/Skin.php footer images #30113 [core] - 10https://gerrit.wikimedia.org/r/108221 [19:42:53] Also, Krinkle|detached I used /* import the Global SUL tool by User:Krinkle */// [[User:Krinkle]][[File:Krinkle Global SUL.js]] mw.loader.load('//meta.wikimedia.org/w/index.php?title=User:Krinkle/Tools/Global_SUL.js&action=raw&ctype=text/javascript'); and now my preferences page says "Your account is active on 699 project sites." How do I find out which 20 or so failed? [19:46:08] (03PS2) 10Westurner: Updated includes/Skin.php footer images #30113 [core] - 10https://gerrit.wikimedia.org/r/108221 [19:49:24] (03PS3) 10Westurner: Updated includes/Skin.php footer images #30113 [core] - 10https://gerrit.wikimedia.org/r/108221 [19:52:20] Krinkle|detached: when you reattach, I'm interested in learning more about how [[commons:Template:GlobalJsUsage]] works... [20:08:17] (03PS1) 10Ori.livneh: Create python::pil; relax restrictions on packages.pp [vagrant] - 10https://gerrit.wikimedia.org/r/108222 [20:09:09] (03CR) 10Ori.livneh: [C: 032] "Gergő: FYI." [vagrant] - 10https://gerrit.wikimedia.org/r/108222 (owner: 10Ori.livneh) [20:09:11] (03Merged) 10jenkins-bot: Create python::pil; relax restrictions on packages.pp [vagrant] - 10https://gerrit.wikimedia.org/r/108222 (owner: 10Ori.livneh) [20:13:32] (03PS4) 10Westurner: Updated includes/Skin.php footer images #30113 [core] - 10https://gerrit.wikimedia.org/r/108221 [20:15:57] thedj: thedj[work]: Around? [20:17:47] rm -f $( which tidy) # go to... [20:18:21] (03CR) 10Westurner: "Ready for review." [core] - 10https://gerrit.wikimedia.org/r/108221 (owner: 10Westurner) [20:22:55] (03CR) 10Westurner: "HTML works on Chrome 31. AFAIK, there shouldn't be any problems with an 'empty' span that's "display:block"." [core] - 10https://gerrit.wikimedia.org/r/108221 (owner: 10Westurner) [20:32:57] (03PS1) 10Ori.livneh: Remove all usage of virtual resources [vagrant] - 10https://gerrit.wikimedia.org/r/108223 [20:35:31] Can you not import your skin.js or common.js from one wiki to another? /* Import all of my enwp scripts */// [[User:Technical 13/enwpScripts]] mw.loader.load( '//en.wikipedia.org/w/index.php?title=User:Technical_13/common.js&action=raw&ctype=text/javascript' );// Stable scripts mw.loader.load( '//en.wikipedia.org/w/index.php?title=User:Technical_13/vector.js&action=raw&ctype=text/javascript' );// Beta scripts doesn't seem to be working [20:35:50] https://meta.wikimedia.org/wiki/User:Technical_13/common.js [20:39:12] (03PS1) 10Ori.livneh: Add python::* classes accidentally omitted from 1d92fb85c5 [vagrant] - 10https://gerrit.wikimedia.org/r/108224 [20:39:12] (03CR) 10Ori.livneh: [C: 032] Remove all usage of virtual resources [vagrant] - 10https://gerrit.wikimedia.org/r/108223 (owner: 10Ori.livneh) [20:39:12] (03Merged) 10jenkins-bot: Remove all usage of virtual resources [vagrant] - 10https://gerrit.wikimedia.org/r/108223 (owner: 10Ori.livneh) [20:39:13] (03CR) 10Ori.livneh: [C: 032] Add python::* classes accidentally omitted from 1d92fb85c5 [vagrant] - 10https://gerrit.wikimedia.org/r/108224 (owner: 10Ori.livneh) [20:39:14] (03Merged) 10jenkins-bot: Add python::* classes accidentally omitted from 1d92fb85c5 [vagrant] - 10https://gerrit.wikimedia.org/r/108224 (owner: 10Ori.livneh) [20:45:13] ebernhardson: https://gerrit.wikimedia.org/r/#/c/108225/ was prompted by your patch, which i'll amend [20:51:25] (03PS1) 10Ori.livneh: Add apache::mods::* to make Apache mods multiply-includable [vagrant] - 10https://gerrit.wikimedia.org/r/108225 [20:51:29] (03CR) 10Ori.livneh: [C: 032] Add apache::mods::* to make Apache mods multiply-includable [vagrant] - 10https://gerrit.wikimedia.org/r/108225 (owner: 10Ori.livneh) [20:51:29] (03Merged) 10jenkins-bot: Add apache::mods::* to make Apache mods multiply-includable [vagrant] - 10https://gerrit.wikimedia.org/r/108225 (owner: 10Ori.livneh) [20:52:19] (03PS1) 10Ori.livneh: Lint [vagrant] - 10https://gerrit.wikimedia.org/r/108226 [20:52:23] (03CR) 10Ori.livneh: [C: 032] Lint [vagrant] - 10https://gerrit.wikimedia.org/r/108226 (owner: 10Ori.livneh) [20:52:24] (03Merged) 10jenkins-bot: Lint [vagrant] - 10https://gerrit.wikimedia.org/r/108226 (owner: 10Ori.livneh) [21:01:15] (03PS5) 10Ori.livneh: Hack together apache -> hhvm [vagrant] - 10https://gerrit.wikimedia.org/r/105834 (owner: 10EBernhardson) [21:19:16] ebernhardson: yt? [21:22:28] ori: yea [21:32:33] (03PS1) 10Legoktm: Allow extensions to set a custom error message in the BlockIp hook [core] - 10https://gerrit.wikimedia.org/r/108285 [21:35:19] (03PS5) 10Westurner: Updated includes/Skin.php footer images #30113 [core] - 10https://gerrit.wikimedia.org/r/108221 [21:37:14] (03CR) 10Westurner: "TODO: Expert advice on encoding CSS background-image: url() [which should be in server-side configuration, AFAIU]" [core] - 10https://gerrit.wikimedia.org/r/108221 (owner: 10Westurner) [21:40:05] (03PS2) 10Legoktm: Allow extensions to set a custom error message in the BlockIp hook [core] - 10https://gerrit.wikimedia.org/r/108285 [21:41:14] (03CR) 10Parent5446: [C: 032] Add $wgHideUserContribLimit config setting [core] - 10https://gerrit.wikimedia.org/r/98267 (owner: 10Umherirrender) [21:44:27] (03Merged) 10jenkins-bot: Add $wgHideUserContribLimit config setting [core] - 10https://gerrit.wikimedia.org/r/98267 (owner: 10Umherirrender) [21:45:58] (03CR) 10Jack Phoenix: [C: 031] Allow extensions to set a custom error message in the BlockIp hook [core] - 10https://gerrit.wikimedia.org/r/108285 (owner: 10Legoktm) [21:53:06] ebernhardson: i think i know how we can do this, just writing a comment [21:53:31] ori: actually i have it mostly ready and working, using apache::conf [21:53:52] just testing now [21:55:50] (03CR) 10Ori.livneh: [C: 04-1] "Here's how I think we could do this:" [vagrant] - 10https://gerrit.wikimedia.org/r/105834 (owner: 10EBernhardson) [21:56:08] ebernhardson: cool, take a look at my comment tho. but if your approach is better happy to go with that [21:57:11] bbl [21:57:16] ok, thanks [21:57:41] oh, we probably have to do your way mine doesn't seem to disable properly [21:57:50] (03PS1) 10MrBlueSky: Special:Contributions: add all params to feed URL [core] - 10https://gerrit.wikimedia.org/r/108287 [22:02:03] hmm, actually the only thing its missing is restarting apache...will have to think abotu how [22:02:20] ebernhardson: notify => Service['apache2']? [22:02:32] ori: no, i mean when removing the role [22:02:40] ori: vagrant disable-role hhvm && vagrant provision doesn't restart apache [22:02:54] it does delete the config as it should though [22:03:29] ebernhardson: how does it delete the config? is there a recursively-managed directory? [22:03:36] ori: through apache::conf, yea [22:04:06] ori: its injecting an extra file into /etc/apache/site.d/devwiki/hhvm, similar to xhprof [22:06:05] (03PS1) 10Raimond Spekking: Make 2 messages optional for translation [core] - 10https://gerrit.wikimedia.org/r/108288 [22:06:17] (03CR) 10Raimond Spekking: [C: 032 V: 032] Make 2 messages optional for translation [core] - 10https://gerrit.wikimedia.org/r/108288 (owner: 10Raimond Spekking) [22:09:21] ebernhardson: hrm, might have an idea, sec [22:10:04] ori: if you were leaving you can do that too, this can wait :) [22:18:48] ebernhardson: you could add this to apache's init.pp: exec { '/bin/true': onlyif => '/usr/sbin/check_apache_config_freshness', notify => Service['Apache2'] } [22:19:09] lol [22:19:09] ebernhardson: where 'check_apache_config_freshness' gets the maximum mtime of the config dirs and the files they contain [22:19:17] If you need to use /bin/true in a higher-level language, something's wrong [22:19:18] and compares it to the pidfile [22:19:37] RoanKattouw: :D [22:19:50] ori: hmm, yea that makes sense [22:20:33] if the exec itself performs the check and calls apache2ctl restart if the process is stale, then you may end up restarting apache twice in a single run [22:21:11] so the exec itself should be a no-op but the condition for it should contain the freshness check [22:21:28] that way if apache is fresh the 'real' command isn't called and apache2 isn't notified [22:23:35] RoanKattouw: if there is an afterlife i am sure programmers will be made to answer for such kludges [22:23:44] but i'm an atheist so hedging my bets [22:25:17] Oh man in that version of afterlife I'm sure I'm doomed [22:26:21] heheh [22:27:13] ebernhardson: for bonus points, wrap the kludge in a generic abstraction [22:28:05] config_dir { path => '/etc/apache2/conf.d', service => 'apache2', } [22:29:18] restarts apache2 when the max mtime of (conf.d, conf.d/*) is greater than process start time [22:30:23] * ori off for real. bye! [23:13:05] (03CR) 10Legoktm: [C: 032] Remove unused variable [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108183 (owner: 10Chad) [23:13:12] (03Merged) 10jenkins-bot: Remove unused variable [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/108183 (owner: 10Chad) [23:22:52] (03CR) 10Legoktm: Cleaned up extension and refactored Special Page. (031 comment) [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/53860 (owner: 10Parent5446)