[00:00:24] mwalker: (switching here) i merged it [00:00:34] yay [00:00:40] * mwalker goes and pokes rhodium [00:00:46] bd808: I went throught it completely, signed up for the mailing lists, registered as Tech ambassador, created a wikitech account, signed up to gerrit, added ssh keys and everything else. [00:00:49] mwalker: would you like me to force a puppet run somewhere? or are you ok with waiting up to 30 mins for it to get picked up? [00:01:04] oh oh! yes please! please run a run on rhodium [00:01:11] * ori runs to run a run. [00:01:42] (03CR) 10EBernhardson: Test for AbuseFilter integration (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107623 (owner: 10Matthias Mullie) [00:01:47] mwalker: you can tail -f /var/log/puppet.log to follow along [00:01:59] mwalker: or rather you can't, because: err: Could not retrieve catalog from remote server: Error 400 on SERVER: Invalid parameter temp_dir at /etc/puppet/manifests/role/ocg.pp:34 on node rhodium.eqiad.wmnet [00:02:07] nooooooo [00:02:11] :'( [00:02:14] so many tears [00:02:22] puppets don't cry [00:02:44] Adi__: Very ambitious. What help are you looking for now? [00:03:25] bd808: To start with, does gerrit only functions using ssh, or it supports a http/https link too like github? [00:04:29] You can fetch using http/https but I think you must use ssh to push [00:04:57] <^demon|away> You can push via https. [00:05:05] There is a problem with my network, the ports abouve 1024 are restricted for security reasons of the organization. :( [00:05:06] <^demon|away> (http always redirects to https :)) [00:05:33] Adi__: ^demon|away is the keeper of gerrit so lets go with his answer :) [00:05:50] <^demon|away> Adi__: If you go to https://gerrit.wikimedia.org/r/#/settings/http-password while you're logged in, you should see your username & a randomized password there. [00:05:55] <^demon|away> You can push with those credentials. [00:05:58] demon|away: That is great to know. :)) [00:07:30] demon|away : Ok so, I have the account id and password now, what would I set my remote origin as? [00:08:29] Adi__: https://@gerrit.wikimedia.org/r/mediawiki/core ? [00:08:40] <^demon|away> /r/p/, but otherwise what bd808 said [00:08:58] :) [00:09:00] tx [00:09:02] tnx [00:10:29] bd808: Will you please suggest me some bug to take as an initial task? [00:11:45] Adi__: What kind of things are you comfortable with? Php, javascript, something else? [00:12:14] PHP, HTML, CSS... Javascripts not so much. [00:12:40] Ok. Lets look at https://www.mediawiki.org/wiki/Annoying_little_bugs as a starting point [00:12:53] greg-g: spage tried to give me instructions on how to get https://gerrit.wikimedia.org/r/106306 deployed with tomorrows train (its a mediawiki-config patch). but i dont understand and hes taking time off [00:12:55] (03CR) 10Mattflaschen: [C: 032] "Deploying hotfix." [extensions/GettingStarted] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/107734 (owner: 10Mattflaschen) [00:12:57] (03Merged) 10jenkins-bot: Change how presence of VisualEditor is determined [extensions/GettingStarted] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/107734 (owner: 10Mattflaschen) [00:13:02] (03CR) 10Mattflaschen: [C: 032] "Deploying hotfix." [extensions/GettingStarted] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107735 (owner: 10Mattflaschen) [00:13:04] (03Merged) 10jenkins-bot: Change how presence of VisualEditor is determined [extensions/GettingStarted] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107735 (owner: 10Mattflaschen) [00:13:27] greg-g: any pointers :) something about adding to deployment calendar (but probably not https://wikitech.wikimedia.org/wiki/Deployments ? ) and having our bug be a blocker on the deployment bug(which? i cant find it, but our bug is https://bugzilla.wikimedia.org/show_bug.cgi?id=59794) [00:14:17] ebernhardson: is this for the enabling on enwiki? [00:14:23] configuration changes dont get as part of the train usuallu [00:14:31] greg-g: no, its for making flow permissions settable to global grousp [00:15:13] basically, it adjust wmf-config/CommonSettings.php and adds 4 strings to $wgAvailablerights [00:15:16] $wgAvailableRights [00:15:45] what Reedy said, so, is all the code in place? [00:15:58] yup, its in place. So we just need a normal deploy window? [00:16:12] yeah [00:16:17] not tomorrow :) [00:16:30] but, well, ugh I guess [00:16:33] hmm, and friday is a no deploy [00:16:49] and next monday is vaca, then arch, so can i have something on the 27th i guess? [00:16:53] and next week is "only if really needed, not just emergencies, but, really, think about it twice" [00:17:17] it can be done if needed [00:17:40] JFDI [00:17:44] it just wont happen without asking for it to be [00:17:45] yeah, mostly the "no" was for "please plan ahead/let us know" ;) but, is this needed soon? [00:17:47] or that [00:18:00] finding out, sec [00:18:06] <^demon|away> Everything's needed. [00:18:12] mwalker: have you figured it out? [00:18:25] should be trivial... [00:18:45] ori: no... it's confusing... the internet suggests its because I have a duplicated class definition somewhere [00:18:50] mwalker: it's class { 'ocg': [00:18:52] if the patch is not applied, then its impossible to assign flow rights to global groups, which makes it harder for admins to assign things like spam prevention [00:18:56] i think we can just wait for the 27th [00:18:59] mwalker: ocg is unqualified, so it gets looked up in the current scope [00:19:07] mwalker: where it refers to the class in which it is being declared [00:19:19] so 'ocg' is resolving to 'role::ocg' inside 'role::ocg' [00:19:19] i can just dp ot tomorrow [00:19:21] do it [00:19:27] ebernhardson: /me shrugs, you can do it tomorrow, post mw deploy (so like 1-ish pm pacific [00:19:31] damn phone [00:19:35] oh.... that's totally non intuitive -- how do I make it resolve to the module? [00:19:37] or Reedy, since he offered :) [00:19:38] mwalker: the fix is to change manifests/role/ocg.pp to say class { '::ocg': [00:19:43] (03PS1) 10Mattflaschen: Bump GettingStarted to 1.23wmf9 branch for hotfix [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/107741 [00:20:00] (03CR) 10Mattflaschen: [C: 032] "Deploying hotfix." [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/107741 (owner: 10Mattflaschen) [00:20:17] '::' being the root node, then the module name (since ocg is a top-level module) [00:20:37] bd808: Most are already taken or submitted, I found this one interesting https://bugzilla.wikimedia.org/show_bug.cgi?id=11269, but there is no file named SpecialPage.php under the includes/ , there is SpecialPageFactory.php, but not this one. [00:21:09] it has likely moved recently Adi__ [00:21:10] mwalker: if you submit a patch quickly i can merge / sync [00:21:17] Adi__: Looking now... [00:21:27] ori: just did :) https://gerrit.wikimedia.org/r/#/c/107742/ [00:21:41] (03PS1) 10Mattflaschen: Bump GettingStarted to 1.23wmf10 branch for hotfix [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107743 [00:22:00] (03CR) 10Mattflaschen: [C: 032] "Deploying hotfix." [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107743 (owner: 10Mattflaschen) [00:23:08] mwalker: err: Could not retrieve catalog from remote server: Error 400 on SERVER: Duplicate definition: Class[Ocg] is already defined in file /etc/puppet/manifests/role/ocg.pp at line 34; cannot redefine at /etc/puppet/manifests/role/ocg.pp:17 on node rhodium.eqiad.wmnet [00:23:14] * ori looks [00:24:09] Adi__: Start by looking at specials/SpecialMostlinkedcategories.php (mentioned in the bug report) and see where that takes you. [00:24:35] Ok [00:25:16] ori: hmm... that makes senseish... but I was hoping it wouldn't happen if a host did not have both roles assigned [00:25:36] mwalker: it's only because test implicitly inherits the non-test class [00:25:38] puppet is crazy [00:25:50] (03Merged) 10jenkins-bot: Bump GettingStarted to 1.23wmf9 branch for hotfix [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/107741 (owner: 10Mattflaschen) [00:25:51] just rename role::ocg to role::ocg::production [00:26:11] that way there is no implicit inheritance relationship [00:26:46] (03Merged) 10jenkins-bot: Bump GettingStarted to 1.23wmf10 branch for hotfix [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107743 (owner: 10Mattflaschen) [00:26:58] ^ mwalker [00:27:01] oh [00:27:03] beat me to it [00:28:16] mwalker: err: Could not retrieve catalog from remote server: Error 400 on SERVER: Could not find class accounts::cscott for rhodium.eqiad.wmnet at /etc/puppet/manifests/site.pp:2034 on node rhodium.eqiad.wmnet [00:28:44] interesting; that's definitely his shell account name [00:29:21] mwalker: he doesn't have an account defined [00:29:29] mwalker: labs shell != prod [00:29:51] site.pp:2034 is the only instance of 'cscott' in the puppet repo [00:30:17] * cscott thinks his name is being taken in vain [00:30:18] just remove that line for now and ask jeff to look after access issues [00:30:22] *nods* [00:30:47] cscott: no offense, just not something i am allowed to do on a whim [00:31:12] ori: https://gerrit.wikimedia.org/r/107745 [00:31:25] cscott: how do you not have shell / deploy rights? [00:31:27] so many sign ups... :( Wikimedia should really consider building a unified login system... something like persona of Mozilla community.... (Suggestion) [00:31:44] mwalker: i've cleverly been in boston whenever anyone has wanted to give me more responsibility? ;) [00:31:46] bd808: I got the jist of it, I would work through it and get back to you. :) [00:32:39] mwalker: iirc i came close to getting more bits when hashar went on vacation and named me one of the keepers-of-zuul [00:32:39] cscott: that's a good trick [00:32:48] Adi__: Sounds good. You don't have to find me specifically either. Just come back and ask good questions and it's likely that someone will answer. :) [00:32:54] but i never had to use my powers in anger before hashar returned [00:32:56] mwalker: err: Failed to apply catalog: Could not find dependency File[/usr/local/sbin/grain-ensure] for Exec[/usr/local/sbin/grain-ensure add deployment_target ocg] at /etc/puppet/modules/salt/manifests/grain.pp:54 [00:33:05] that sounds like Ryan_Lane's fault [00:33:18] bd808: Sure :) Thanks for help, I'll get back after attending my classes. Have a good day.! [00:33:27] hurm... ya... [00:33:39] I didn't touch trebuchet except to add more targets for it [00:33:55] (03PS1) 10Catrope: Update VisualEditor to 1.23wmf9 branch for cherry-picks [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/107746 [00:34:11] actually; is that something that a rhodium needs to have a trebuchet role associated with it I wonder [00:34:17] the file exists, but it looks like the minion class is not present [00:34:19] that sounds right [00:34:43] do you have deployment::target anywhere? [00:35:22] is rhodium just special because it's FR? [00:35:40] I do; it's in the ,modules/ocg/manifests/init.pp file [00:35:52] and rhodium is potentially special because this is the first time we've touched it [00:36:05] it's supposed to be the load testing box for ocg [00:36:07] mwalker: it doesn't include 'standard' role [00:36:08] (03PS1) 10Catrope: Update VisualEditor to 1.23wmf10 branch for cherry-picks [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107747 [00:37:16] mwalker: yes, that's it [00:37:36] mwalker: the standard role includes the role 'base', and 'base' includes role::salt::minions [00:38:01] Ryan_Lane: ping above was not actually your fault, disregard [00:38:16] mwalker: so just add 'standard' to the includes in site.pp for rhodium [00:38:21] https://gerrit.wikimedia.org/r/107748 [00:38:23] heh [00:39:42] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to 1.23wmf9 branch for cherry-picks [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/107746 (owner: 10Catrope) [00:39:51] mwalker: it's running, so at least no logic errors [00:39:53] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to 1.23wmf10 branch for cherry-picks [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107747 (owner: 10Catrope) [00:39:57] whooo [00:40:20] it's interesting that I can't tail /var/log/puppet.log -- it just shows me the results of the last run [00:40:21] mwalker: err: /Stage[main]/Ocg/Package[fonts-smc]/ensure: change from purged to present failed: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold install fonts-smc' returned 100: Reading package lists... E: Unable to locate package fonts-smc [00:40:28] mwalker: try it now [00:40:41] it wasn't scrolling for a while, which is why it might have looked frozen [00:41:57] bd808: One last question for now, how to get a sample database to work on on my machine? Is there any way to generate seed entries? [00:43:13] bd808|BUFFER: One last question for now, how to get a sample database to work on on my machine? Is there any way to generate seed entries? [00:44:19] mwalker: also, E: Unable to locate package fonts-nakula [00:44:36] *grumble* [00:44:46] mwalker: other than these two font packages, though, it looks like everything worked. puppet did not attempt to start the service, though, because of the failed dependencies [00:44:53] *nods* [00:45:03] that's an awesome step in the right direction at least! [00:46:06] weird, it is in sid [00:46:20] ori: Can you tell me regarding database seed entries for my local machine? [00:46:52] Adi__: it depends what you mean by 'seed entries'. there is no readymade way to populate the wiki with content [00:47:04] it is a standing request IIRC but not someone anyone got around to implementing [00:47:25] if you just mean the basic database tables required for running mediawiki, those are set up by the installer [00:47:40] I mean, I am trying to work on pagination on a page, but its content is empty... :| [00:48:22] there's an 'edit' button, you know :) [00:49:00] (03PS1) 10Legoktm: Properly handle exceptions in flow-parsoid-utils [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107749 [00:49:03] (03PS1) 10Legoktm: ApiParsoidUtils: Handle the page not existing nicely [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107750 [00:49:09] Ok so the only way is to do it manually, thats fine. :) [00:49:17] mwalker: are those fonts really required? you can't comment them out for now or something? [00:49:32] Adi__: yeah. it's a valid thing to want, there's just no quick and easy solution to my knowledge. [00:49:48] ori: I could; but try https://gerrit.wikimedia.org/r/#/c/107751/ if you would -- that's cscott's latest and greatest list of packages [00:50:09] which does not include the two fonts that do not exist [00:50:14] mwalker: i'll verify that those packages are present if you remove the trailing whitespace on line 40 [00:50:15] All right, I just thought there may be some test case data to populate all the tables with. [00:50:31] (03CR) 10EBernhardson: [C: 031] "There is still some scrolling wonkiness, but this fixes the original bug and since there are a variety of scrolling issues elsewhere i'm w" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105123 (owner: 10Bsitu) [00:50:47] Anyways thanks ori. :) [00:50:56] Adi__: np, sorry i couldn't help. [00:50:59] heh; done [00:51:01] (03PS4) 10Legoktm: [WIP] Revamp API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 [00:51:41] Its perfectly fine. A new issue to open probably. :) [00:51:51] Adi__: yes, that'd be a good idea [00:51:57] make sure there isn't one already, there may be [00:52:26] Adi__: https://bugzilla.wikimedia.org/show_bug.cgi?id=46869 [00:54:11] I don't think that bug wants all databases to be prepolulated, it talks about "15 test pages", I don't know what they are. [00:54:58] Adi__: i think 15 is just a rough number; it'd still be useful if your reported your exact requirements on that bug, even if they didn't exactly match the request [00:55:07] (03PS1) 10Aaron Schulz: Fixed use of X-Newest in Swift backend [core] - 10https://gerrit.wikimedia.org/r/107752 [00:55:25] (03PS1) 10Aaron Schulz: Fixed use of X-Newest in Swift backend [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107753 [00:55:51] (03CR) 10Aaron Schulz: [C: 032] Fixed use of X-Newest in Swift backend [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107753 (owner: 10Aaron Schulz) [00:56:03] mwalker: it ran to completion. the service failed to start but it's probably because you need to deploy it first, right? [00:56:09] *nods8 [00:56:26] and whooooohoooo! [00:57:01] :) [00:58:53] now to test that my brand new PPA works; and then to have someone import all those packages; and then... *profit* [00:59:04] (03CR) 10Bsitu: [WIP] Auto-wrapping escaper for templates (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103317 (owner: 10EBernhardson) [00:59:50] * ori cautiously retreats [00:59:50] (03Merged) 10jenkins-bot: Fixed use of X-Newest in Swift backend [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107753 (owner: 10Aaron Schulz) [01:00:09] *nods* it's for the best [01:00:26] at least I'll test the PPA in labs first -- now that I have the puppet script [01:00:53] but seriously; so many cookies [01:02:20] (03CR) 10Ori.livneh: [C: 032] Fixed use of X-Newest in Swift backend [core] - 10https://gerrit.wikimedia.org/r/107752 (owner: 10Aaron Schulz) [01:05:05] ori: Submitted now. https://bugzilla.wikimedia.org/show_bug.cgi?id=60116 [01:05:20] (03Merged) 10jenkins-bot: Fixed use of X-Newest in Swift backend [core] - 10https://gerrit.wikimedia.org/r/107752 (owner: 10Aaron Schulz) [01:06:29] Bye all. [01:06:29] Adi__, good bye! [01:10:04] (03CR) 10Werdna: "I do like the general approach. Much nicer than what I had :-)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101903 (owner: 10Matthias Mullie) [01:11:11] (03CR) 10Legoktm: Test for SpamBlacklist integration (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107569 (owner: 10Matthias Mullie) [01:28:34] (03CR) 10Werdna: "Looks fine at a glance, provided the underlying code is good. My caveat about trying to make the similarly formatted files use related cod" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105674 (owner: 10Matthias Mullie) [01:31:59] (03PS2) 10Kaldari: Story 1604: Remember mobile thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107633 [01:32:01] (03CR) 10jenkins-bot: [V: 04-1] Story 1604: Remember mobile thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107633 (owner: 10Kaldari) [01:34:11] (03CR) 10Werdna: "Reviewed, but not in detail." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105699 (owner: 10Matthias Mullie) [01:34:35] is there a standard for how to format multi-line docblock comments? @param string $var type stuff? [01:34:46] mostly, how much indentation for the second line? [01:35:16] (03PS1) 10Bsitu: Anon users creating new header results in SQL error [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107757 [01:37:14] (03PS2) 10Bsitu: Anon users creating new header results in SQL error [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107757 [01:38:22] (03PS3) 10Kaldari: Story 1604: Remember mobile thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107633 [01:40:15] (03CR) 10Kaldari: [C: 04-2] "Don't merge until dependency is merged." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107633 (owner: 10Kaldari) [01:42:57] ebernhardson: Indetion of what? [01:44:08] (03CR) 10Krinkle: "I've various of these big commits in my working copy as well. It helps if you don't refactor actual code at the same time too much, that's" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [01:44:22] (03PS11) 10Krinkle: JSDuck-ify /resources/mediawiki.language/* [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [01:44:29] (03PS1) 10Shirayuki: i18n: fix "user-is-moderator" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/107758 [01:44:51] (03CR) 10Krinkle: [C: 031] JSDuck-ify /resources/mediawiki.language/* [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [01:44:55] (03PS2) 10Krinkle: JSDuck-ify /resources/mediawiki/mediawiki.Uri.js [core] - 10https://gerrit.wikimedia.org/r/107630 (owner: 10Bartosz Dziewoński) [01:46:00] Reedy: sec i'll make a pastie [01:46:26] Reedy: for example, http://pastie.org/8637577 [01:46:38] there i've just used an extra tab to indent, but not sure if there is a standard to follow [01:46:54] i've seen other projects indent all the way to past $value [01:47:11] ah [01:47:46] Usually we don't indent [01:48:04] ok, whatever is normal i can copy [01:48:16] Though, I'm not sure if anyone would care that much [01:49:00] I note https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP doesn't make any reference to multi line comments liek that [01:50:31] I think I've seen people use a couple spaces to indent multiline things like that sometimes [01:55:54] (03CR) 10jenkins-bot: [V: 04-1] Added concurrent HEAD request support for Swift [core] - 10https://gerrit.wikimedia.org/r/107759 (owner: 10Aaron Schulz) [01:59:39] (03CR) 10Krinkle: JSDuck-ify /resources/mediawiki/mediawiki.Uri.js (034 comments) [core] - 10https://gerrit.wikimedia.org/r/107630 (owner: 10Bartosz Dziewoński) [01:59:51] (03PS3) 10Krinkle: JSDuck-ify /resources/mediawiki/mediawiki.Uri.js [core] - 10https://gerrit.wikimedia.org/r/107630 (owner: 10Bartosz Dziewoński) [01:59:58] (03CR) 10Krinkle: [C: 031] JSDuck-ify /resources/mediawiki/mediawiki.Uri.js [core] - 10https://gerrit.wikimedia.org/r/107630 (owner: 10Bartosz Dziewoński) [02:01:28] (03PS1) 10Krinkle: Add OOjs to jsduck index [core] - 10https://gerrit.wikimedia.org/r/107760 [02:03:48] (03PS1) 10Krinkle: Improve mediawiki.js documentation [core] - 10https://gerrit.wikimedia.org/r/107761 [02:03:59] (03PS1) 10Reedy: Add COPYING [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/107762 [02:04:49] (03PS1) 10Reedy: Move initial setting of $extNode out of the conditional [core] - 10https://gerrit.wikimedia.org/r/107763 [02:05:31] (03PS7) 10Krinkle: Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [02:06:24] (03PS1) 10Reedy: Add COPYING [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/107764 [02:07:31] (03PS1) 10Reedy: Add COPYING [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/107765 [02:08:07] (03PS1) 10Reedy: Add COPYING [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/107766 [02:10:29] (03PS1) 10Reedy: Add COPYING [extensions/cldr] - 10https://gerrit.wikimedia.org/r/107769 [02:11:31] (03PS1) 10Reedy: Add COPYING [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/107770 [02:11:42] ^ Easy to verify, easy to review :) [02:12:15] (03PS1) 10Reedy: Add COPYING [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/107771 [02:12:40] (03PS1) 10Reedy: Add COPYING [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/107772 [02:12:52] (03PS1) 10Reedy: Add COPYING [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/107773 [02:13:15] (03PS1) 10Reedy: Add COPYING [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/107774 [02:13:56] (03PS1) 10Reedy: Add COPYING [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/107775 [02:14:16] (03PS1) 10Reedy: Add COPYING [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/107776 [02:15:28] (03PS1) 10Reedy: Add COPYING [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/107778 [02:15:45] (03PS1) 10Reedy: Add COPYING [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/107779 [02:17:50] (03PS1) 10Reedy: Add COPYING [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/107781 [02:18:48] (03PS1) 10Reedy: Add COPYING [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/107782 [02:19:14] (03PS1) 10Reedy: Add COPYING [extensions/Cite] - 10https://gerrit.wikimedia.org/r/107784 [02:20:03] (03PS1) 10Reedy: Add COPYING [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/107785 [02:20:19] (03PS1) 10Reedy: Add COPYING [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107786 [02:24:12] (03PS1) 10Reedy: Add COPYING [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/107788 [02:24:43] (03PS1) 10Reedy: Add COPYING [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/107789 [02:24:52] (03CR) 10Mattflaschen: [C: 04-1] Add COPYING (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/107770 (owner: 10Reedy) [02:25:01] (03PS1) 10Reedy: Add COPYING [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/107790 [02:25:40] Gah [02:25:49] (03CR) 10Aarcos: Functionality to create a new image in upload-wizard_tests.py (035 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [02:26:50] (03PS1) 10Reedy: Nuke != SMW [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/107791 [02:27:45] Hmm. I wonder what's the best way to fix all those [02:29:47] (03PS2) 10Reedy: Add COPYING [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/107762 [02:30:32] (03PS2) 10Reedy: Add COPYING [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/107764 [02:31:09] (03PS2) 10Reedy: Add COPYING [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/107765 [02:31:32] (03PS2) 10Reedy: Add COPYING [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/107766 [02:31:58] (03PS2) 10Reedy: Add COPYING [extensions/cldr] - 10https://gerrit.wikimedia.org/r/107769 [02:32:38] (03PS2) 10Reedy: Add COPYING [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/107770 [02:33:11] (03PS2) 10Reedy: Add COPYING [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/107771 [02:33:46] (03PS2) 10Reedy: Add COPYING [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/107772 [02:34:08] (03PS2) 10Reedy: Add COPYING [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/107773 [02:34:34] (03PS2) 10Reedy: Add COPYING [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/107774 [02:35:00] (03PS2) 10Reedy: Add COPYING [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/107775 [02:35:26] (03PS2) 10Reedy: Add COPYING [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/107776 [02:35:57] (03PS2) 10Reedy: Add COPYING [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/107778 [02:36:29] (03PS2) 10Reedy: Add COPYING [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/107779 [02:36:49] (03PS2) 10Reedy: Add COPYING [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/107781 [02:37:11] (03PS2) 10Reedy: Add COPYING [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/107782 [02:37:52] (03PS2) 10Reedy: Add COPYING [extensions/Cite] - 10https://gerrit.wikimedia.org/r/107784 [02:38:15] (03PS2) 10Reedy: Add COPYING [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/107785 [02:38:32] (03PS2) 10Reedy: Add COPYING [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107786 [02:38:54] (03PS2) 10Reedy: Add COPYING [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/107788 [02:39:15] (03PS2) 10Reedy: Add COPYING [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/107789 [02:39:49] (03PS2) 10Reedy: Add COPYING [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/107790 [02:41:51] (03PS1) 10Reedy: Add COPYING [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/107793 [02:42:32] (03PS1) 10Reedy: Add COPYING [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/107794 [02:43:19] (03PS1) 10Reedy: Add COPYING [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/107795 [02:43:37] (03PS1) 10Reedy: Add COPYING [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/107796 [02:43:48] (03PS1) 10Reedy: Add COPYING [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/107797 [02:44:16] (03PS1) 10Reedy: Add COPYING [extensions/WikimediaShopLink] - 10https://gerrit.wikimedia.org/r/107798 [02:47:20] (03PS7) 10thibaultmarin: PGFTikZ extension: initial import [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/38487 [02:48:22] (03PS2) 10Reedy: Revert "Add sequence support for externallinks table" [core] - 10https://gerrit.wikimedia.org/r/107415 [02:50:23] (03PS1) 10Reedy: Add https://gerrit.wikimedia.org/r/107415 as a live hack [tools/release] - 10https://gerrit.wikimedia.org/r/107799 [02:51:12] (03PS14) 10Andrew Bogott: Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 [03:11:57] (03PS15) 10Andrew Bogott: Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 [03:34:26] (03CR) 10Reedy: [C: 032] Add extensions/BetaFeatures/sql/create_counts.sql to sql files loaded [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/107455 (owner: 10Reedy) [03:34:29] (03Merged) 10jenkins-bot: Add extensions/BetaFeatures/sql/create_counts.sql to sql files loaded [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/107455 (owner: 10Reedy) [03:36:04] (03CR) 10Reedy: [C: 032] Add https://gerrit.wikimedia.org/r/107415 as a live hack [tools/release] - 10https://gerrit.wikimedia.org/r/107799 (owner: 10Reedy) [03:36:06] (03Merged) 10jenkins-bot: Add https://gerrit.wikimedia.org/r/107415 as a live hack [tools/release] - 10https://gerrit.wikimedia.org/r/107799 (owner: 10Reedy) [03:36:27] (03PS2) 10Reedy: Add COPYING [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/107797 [03:36:36] (03CR) 10Reedy: [C: 032] Add COPYING [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/107797 (owner: 10Reedy) [03:36:38] (03Merged) 10jenkins-bot: Add COPYING [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/107797 (owner: 10Reedy) [03:51:31] (03PS16) 10Andrew Bogott: Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 [03:53:22] (03PS17) 10Andrew Bogott: Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 [03:54:07] (03CR) 10Santhosh: [C: 032] "There is a LICENSE file in the repo. It is a license file about CLDR data. It may cause confusion unless we rename it or move somewhere" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/107769 (owner: 10Reedy) [03:54:15] (03Merged) 10jenkins-bot: Add COPYING [extensions/cldr] - 10https://gerrit.wikimedia.org/r/107769 (owner: 10Reedy) [04:33:00] (03CR) 10Brian Wolff: "Sorry, I was actually wrong, i missed the '(', ')' causing stderr to be redirected. However, this change is probably still a good idea" [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/107161 (owner: 1001tonythomas) [04:44:16] (03PS2) 10Brian Wolff: Removed the 2>&1 from doTransform and replaced wfShellExec with wfShellExecWithStderr [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/107161 (owner: 1001tonythomas) [04:44:30] (03CR) 10Brian Wolff: [C: 032] Change 2>&1 in doTransform to use wfShellExecWithStderr instead [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/107161 (owner: 1001tonythomas) [04:44:32] (03Merged) 10jenkins-bot: Change 2>&1 in doTransform to use wfShellExecWithStderr instead [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/107161 (owner: 1001tonythomas) [04:53:09] (03CR) 10Brian Wolff: [C: 032] Fix depreciation warnings in FileBackend construction for EasyTimeline [extensions/timeline] - 10https://gerrit.wikimedia.org/r/104536 (owner: 1001tonythomas) [04:53:15] (03Merged) 10jenkins-bot: Fix depreciation warnings in FileBackend construction for EasyTimeline [extensions/timeline] - 10https://gerrit.wikimedia.org/r/104536 (owner: 1001tonythomas) [04:57:26] (03CR) 10Brian Wolff: [C: 032] Fix depreciation warnings in FileBackend construction for ConfirmEdit [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/104535 (owner: 1001tonythomas) [04:57:30] (03Merged) 10jenkins-bot: Fix depreciation warnings in FileBackend construction for ConfirmEdit [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/104535 (owner: 1001tonythomas) [05:40:00] (03CR) 10Brian Wolff: [C: 032] Add COPYING [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/107781 (owner: 10Reedy) [05:40:03] (03Merged) 10jenkins-bot: Add COPYING [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/107781 (owner: 10Reedy) [05:45:48] (03PS1) 10Physikerwelt: Share Git module between Vagrant and Wikimedia Labs [vagrant] - 10https://gerrit.wikimedia.org/r/107802 [05:53:18] (03PS11) 10Physikerwelt: Remove call to deprecated ParserOptions::getMath [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 [05:55:26] (03PS4) 10Physikerwelt: Bug 59792: parsoid server failed to start [vagrant] - 10https://gerrit.wikimedia.org/r/106008 [06:10:20] ori: :D [06:10:30] blaming me for things, shame shame ;) [06:10:46] usually I'd take it, but that code hadn't changed in a whil [06:10:48] *while [06:11:04] and we can actually kill off grain-ensure. the functionality needed exists in salt now [06:19:25] (03PS18) 10Andrew Bogott: Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 [06:25:32] (03PS19) 10Andrew Bogott: Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 [06:27:15] (03PS20) 10Andrew Bogott: Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 [06:29:03] (03PS21) 10Andrew Bogott: Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 [06:32:36] (03PS22) 10Andrew Bogott: Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 [06:32:43] (03CR) 10jenkins-bot: [V: 04-1] Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 (owner: 10Andrew Bogott) [06:33:38] (03PS23) 10Andrew Bogott: Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 [06:40:12] (03PS24) 10Andrew Bogott: Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 [06:42:21] (03PS25) 10Andrew Bogott: Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 [06:45:32] (03PS26) 10Andrew Bogott: Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 [07:08:32] (03CR) 10Jalexander: [C: 032 V: 032] Add COPYING [extensions/WikimediaShopLink] - 10https://gerrit.wikimedia.org/r/107798 (owner: 10Reedy) [07:09:21] (03PS27) 10Andrew Bogott: Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 [07:16:32] (03Abandoned) 10Andrew Bogott: Allow for creation of service group without initial user. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105845 (owner: 10Andrew Bogott) [07:18:07] (03PS28) 10Andrew Bogott: Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 [07:22:47] (03Abandoned) 10Andrew Bogott: Add maintenance tool to clean up the old service-group schema. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105848 (owner: 10Andrew Bogott) [07:23:01] (03Abandoned) 10Andrew Bogott: Switch reading to the new service group schema. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105847 (owner: 10Andrew Bogott) [07:41:36] (03PS2) 10Krinkle: Use regular slaves for user contribs parent revision queries [core] - 10https://gerrit.wikimedia.org/r/107545 (owner: 10Aaron Schulz) [08:03:13] I have the most terrible headache, and my clothes are missing. [08:04:46] mmm! [08:19:15] (03PS1) 10Mwalker: Stopping submodule tracking of dependencies [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107812 [08:20:15] (03PS1) 10Mwalker: Actually allow config files... [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107813 [08:20:17] (03CR) 10jenkins-bot: [V: 04-1] Actually allow config files... [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107813 (owner: 10Mwalker) [08:20:43] (03CR) 10Mwalker: [C: 032] Stopping submodule tracking of dependencies [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107812 (owner: 10Mwalker) [08:21:29] (03CR) 10Mwalker: [C: 032 V: 032] Actually allow config files... [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107813 (owner: 10Mwalker) [08:21:36] (03Merged) 10jenkins-bot: Actually allow config files... [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107813 (owner: 10Mwalker) [08:39:06] hi hashar [08:40:47] hiii YuviPanda [08:41:00] hashar: I heara the VE bug got fixed? :) [08:41:11] YuviPanda: not to my knowledge [08:41:16] oh? [08:41:30] I thought you started using a different way of updating those that doesn't depend on Gerrit? [08:57:00] (03CR) 10Gilles: A way to blacklist flickr users. (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [09:01:00] (03CR) 10Gilles: "console.err/console.warn are also worth considering since they're less penalizing, I don't know what you guys would normally use to signif" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [09:04:19] (03CR) 10Gergő Tisza: A way to blacklist flickr users. (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [09:06:11] (03CR) 10Gilles: A way to blacklist flickr users. (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [09:08:47] (03CR) 10Gilles: [C: 04-1] Add site icon to filerepoinfo API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/107712 (owner: 10Gergő Tisza) [09:11:36] legoktm: around? [09:11:43] about to sleep [09:11:48] sup? [09:13:21] YuviPanda: ? [09:13:41] legoktm: ah, ok [09:13:43] legoktm: go sleep then [09:13:48] legoktm: wanted to ask about AbuseFilter :D [09:13:54] and if it gives descriptive error messages [09:14:37] it should! [09:14:38] and if they are like, templates. [09:14:40] or just text [09:14:45] legoktm: are they documented somewhere? [09:14:47] mediawiki messages actually [09:14:51] aha! [09:14:56] just set up a filter on test.wp and play around in apisandbox [09:15:02] hmm, alright [09:15:09] legoktm: but is there a list of them for enwiki for example? [09:15:23] each filter can have a custom warning [09:16:00] legoktm: can you link me to a mediawiki message on enwiki? [09:16:50] take a look at https://en.wikipedia.org/wiki/Special:AbuseFilter/33 [09:17:03] (03CR) 10Ori.livneh: [C: 032] "Thanks" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/107770 (owner: 10Reedy) [09:17:18] https://en.wikipedia.org/wiki/MediaWiki:Abusefilter-warning-talkblanking [09:17:38] (03Merged) 10jenkins-bot: Add COPYING [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/107770 (owner: 10Reedy) [09:17:50] (03PS1) 10Mwalker: Initial submodule and node_modules generation script [services/ocg-collection/deploy] - 10https://gerrit.wikimedia.org/r/107815 [09:18:17] ah [09:18:19] legoktm: sweet [09:18:44] (03CR) 10Mwalker: [C: 032 V: 032] Initial submodule and node_modules generation script [services/ocg-collection/deploy] - 10https://gerrit.wikimedia.org/r/107815 (owner: 10Mwalker) [09:18:48] legoktm: renders terribly oln mobile [09:18:49] *on [09:19:00] :| [09:19:10] https://en.m.wikipedia.org/wiki/MediaWiki:Abusefilter-warning-talkblanking [09:19:23] !log ori updated /a/common to {{Gerrit|Id13e614e5}}: repool db1042 [09:19:23] Id13e614e5}}: repool db1042: Wrong channel, try again. [09:19:37] ick [09:19:45] legoktm: yeah, ick indeed. [09:20:19] ick to which bot? [09:20:39] ori: ick to yuvi's link :P [09:20:51] *facepalm* I hate gerrit [09:21:05] mwalker: meeeeeeee too [09:21:24] YuviPanda: since they all use the same base template, it shouldn't be hard to fix. [09:21:34] but I'm going to sleep now, so in the morning [09:22:10] legoktm: ok! [09:23:26] (03CR) 10Matthias Mullie: Move tests to Flow\Tests namespace (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107561 (owner: 10Matthias Mullie) [09:27:32] (03CR) 10Matthias Mullie: Test for SpamBlacklist integration (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107569 (owner: 10Matthias Mullie) [09:27:44] (03PS3) 10Matthias Mullie: Test for SpamBlacklist integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107569 [09:28:17] (03PS1) 10Mwalker: Initial submodule and node_modules generation script [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/107816 [09:28:46] (03CR) 10Mwalker: [C: 032 V: 032] Initial submodule and node_modules generation script [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/107816 (owner: 10Mwalker) [09:31:17] (03PS4) 10Matthias Mullie: Test for AbuseFilter integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107623 [09:35:36] (03PS1) 10Mwalker: Aaand... initial wmf-deploy w/ puppet links [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/107817 [09:36:28] (03PS2) 10Mwalker: Aaand... initial wmf-deploy w/ puppet links [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/107817 [09:36:35] (03CR) 10Mwalker: [C: 032 V: 032] Aaand... initial wmf-deploy w/ puppet links [services/ocg-collection] (wmf-deploy) - 10https://gerrit.wikimedia.org/r/107817 (owner: 10Mwalker) [09:42:47] (03PS1) 10Mwalker: Do not allow someone to commit a LocalSettings.js file [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/107818 [09:42:59] (03CR) 10Mwalker: [C: 032 V: 032] Do not allow someone to commit a LocalSettings.js file [services/ocg-collection] - 10https://gerrit.wikimedia.org/r/107818 (owner: 10Mwalker) [09:49:48] (03CR) 10Matthias Mullie: "You're right - the addToIndex, removeFromIndex and replaceInIndex were merging into BufferedCache and it wouldn't work reliably (it didn't" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107377 (owner: 10Matthias Mullie) [09:49:58] (03PS2) 10Matthias Mullie: If we fail to CAS, remove cached data so it's re-read from DB [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107377 [10:08:19] (03Abandoned) 10Hashar: unregister VisualEditor (replication broken in Gerrit) [extensions] - 10https://gerrit.wikimedia.org/r/107574 (owner: 10Hashar) [10:15:17] (03PS1) 10Mwalker: Default config should reflect module names [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107824 [10:15:36] (03CR) 10Mwalker: [C: 032] Default config should reflect module names [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107824 (owner: 10Mwalker) [10:19:08] (03CR) 10Tpt: [C: 032] "Thanks" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/107773 (owner: 10Reedy) [10:19:15] (03Merged) 10jenkins-bot: Add COPYING [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/107773 (owner: 10Reedy) [10:38:31] (03CR) 10Gilles: [C: 031] Refactor Flickr API calls [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107267 (owner: 10Gergő Tisza) [10:45:45] * mwalker revises his earlier statement; Node.JS can also go rot in the same hell as gerrit [10:46:08] why is an integer not autocoercable into a string!? [10:48:47] (03PS1) 10Mwalker: Apparently ints cannot be coerced into strings automatically [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107827 [10:49:00] (03CR) 10Mwalker: [C: 032] Apparently ints cannot be coerced into strings automatically [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107827 (owner: 10Mwalker) [10:52:25] mwalker: well, what if it is an integer that cannot be seen by a human being? [10:52:27] WHAT THEN!? [10:53:57] well; given that V8 stores integers internally as IEEE 64bit floating point numbers; there is no number that can be stored that does not have a human readable form [10:54:13] -0 is a bit strange; but it's still a number [10:54:43] heh, was just kidding. [10:55:16] I know; I just wish to stab this language in the stomach and leave it to die bleeding in the street [10:55:39] * mwalker wonders if it's too late to rewrite the damn thing in python [10:55:57] probably, yeah [10:56:11] * YuviPanda is starting to write a deployments-dashboard in... Go [10:56:14] let's see how that goes. [10:56:31] interesting language choice [10:57:00] I was interested in Go... [10:57:08] ...for 5 minutes [10:57:10] mwalker: wanted something that's not Python or Node. So it was Scala or Go. [10:57:21] Scala means I've to manage a JVM, so Go was simpler [10:57:26] ...until I noticed pascal-style assignment operator [10:57:31] heh :P [10:57:40] the irritating thing about Go for me so far has been error handling. [10:57:53] almost, but not quite, as annoying as Java's Checked Exceptions [10:58:07] let me guess; like every other pet language of the day; it doesn't have any? [10:58:31] mwalker: no, it has too much. [10:58:43] it's overall a good thing, perhaps [10:58:55] mwalker: if you read a file for example, you *have* to handle the errors, or it won't compile [10:59:07] you can handle it by ignoring it too [10:59:11] but you have to do that explicitly [10:59:12] oh; I actually like that [10:59:36] it's overall a good thing, since it doesn't have the problem Java's has (propogating checked exceptions breaks inheritance/interface implementation) [11:00:07] what? you mean catch ( Exception ex ) {} isn't acceptable? :p [11:00:13] :P [11:00:20] I've my Java IDE configured to do [11:00:34] catch ( e ) { throw new RuntimException(e); } [11:00:45] converting checked exceptions to unchecked all the time [11:01:05] * mwalker grimaces [11:01:13] :P [11:01:30] mwalker: the number of times that exist in my android code is so high. often with notes like 'this can not happen' [11:01:52] mwalker: for example, if I am putting a string into a JSON object, I need to handle a JSONException [11:02:00] that's stupid, since I know it won't ever be triggered [11:02:15] unless I, say, put a Window or something into it, rather than values. [11:02:50] and other times, like when you try to get the current package's properties, and have to handle PackageNotFound exception [11:02:55] but since java is typed... [11:03:07] it could have been deleted! [11:03:13] mwalker: signature of .put is put(String key, Object Value) [11:03:39] mwalker: hmm, they actually have overloads [11:03:44] still have a checked exception. [11:03:49] stupid, really. [11:04:21] mwalker: anyway, let's see how this one goes. This is just a developer dashboard, so I could experiment with languages [11:04:25] I used to say that Java was a language that could bring me to a screaming rage in less than 5 minutes [11:04:30] plus am just doing it on my spare time, and won't get deployed to production anyway [11:04:33] mwalker: now is it 30s? :) [11:05:03] no; my standards are higher now [11:05:17] desk pounding in 5 minutes [11:05:20] rage in 15 [11:05:36] mwalker: :D [11:05:44] mwalker: I work almost exclusively with Java these day [11:05:45] s [11:05:50] MaxSem: btw -- the ppa stuff we did today / yesterday -- seems to be working [11:05:58] so yay! *high five* [11:05:58] mwalker: so detox by writing puppet code. Not sure that's much better [11:06:01] wee [11:06:14] puppet can go die in a fire [11:06:32] I want to go back to *real* languages; like C [11:06:35] it hardly needs help for that. often does that by itself. [11:06:42] hah [11:06:43] http://www.youtube.com/watch?v=e-UbViuK4fY [11:06:44] soooo true [11:06:46] yeah. we hardly have any C code though [11:07:05] mwalker: you should try Go sometime. [11:08:19] MaxSem: I've always wondered how these people don't destroy their voices [11:08:34] I don't even know how to do that to my larynx [11:09:08] why do you think they don't? [11:09:29] mwalker: sounds pre-destroyed to me [11:09:37] I also have no idea what they're saying [11:09:52] * YuviPanda listens more carefully [11:10:13] reading the lyrics I can understand them [11:10:54] MaxSem: we need to extract our barbie girl performance from someone's camera [11:10:56] I need to find out who [11:28:33] hashar: care to merge https://gerrit.wikimedia.org/r/#/c/98853/ ? [11:28:44] it would be very handy for a bunch of tests i'm currently writing... [11:28:58] or maybe you want to merge it, YuviPanda :) [11:30:04] (03PS8) 10Daniel Kinzler: [WIP] Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 [11:41:00] (03PS1) 10Mwalker: Add syslog logging [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107832 [11:42:20] (03PS1) 10Mwalker: Add syslog logging [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/107833 [11:42:47] (03CR) 10Mwalker: [C: 032] Add syslog logging [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107832 (owner: 10Mwalker) [11:42:58] (03CR) 10Mwalker: [C: 032] Add syslog logging [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/107833 (owner: 10Mwalker) [11:44:58] mwalker, why aren't you sleeping? [11:45:13] wanted to get this crap done [11:46:36] so much JS Love [11:49:20] that and I know eloquence is sad because he doesn't have anything to play with [11:49:28] and there's this big matt shaped blocker [11:52:10] but ok; now sleep time [11:52:41] MaxSem: see you in a couple of hours :p [11:52:55] * mwalker suspects the damn thing will break as soon as I go to bed [11:52:56] >.> [11:53:01] *shrugs* [11:57:48] Hello. [12:13:32] (03PS1) 10Gerrit Patch Uploader: Patch to remove success box on changing any preference or switching tab [core] - 10https://gerrit.wikimedia.org/r/107837 [12:13:34] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/107837 (owner: 10Gerrit Patch Uploader) [12:17:47] (03PS2) 1001tonythomas: Patch to remove success box on changing any preference or switching tab [core] - 10https://gerrit.wikimedia.org/r/107837 (owner: 10Gerrit Patch Uploader) [12:18:01] (03PS3) 1001tonythomas: Patch to remove success box on changing any preference or switching tab [core] - 10https://gerrit.wikimedia.org/r/107837 (owner: 10Gerrit Patch Uploader) [12:20:57] (03CR) 1001tonythomas: "You should go through this for future use." [core] - 10https://gerrit.wikimedia.org/r/107837 (owner: 10Gerrit Patch Uploader) [12:49:31] (03CR) 1001tonythomas: [C: 031] "Tested in my browser. Looks good to me. Dont know whehter there are some issues." [core] - 10https://gerrit.wikimedia.org/r/107837 (owner: 10Gerrit Patch Uploader) [13:10:50] (03CR) 10Phe: [C: 031] Don’t use 0 as proofreading level for edits from unallowed users [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/107597 (owner: 10Tpt) [13:39:49] (03PS7) 10AalekhN: SpecialWhatlinkshere.php : made Special:Whatlinkshere transclude [core] - 10https://gerrit.wikimedia.org/r/106625 [13:41:10] (03CR) 10Gilles: Add site icon to filerepoinfo API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/107712 (owner: 10Gergő Tisza) [13:50:45] (03PS1) 10Hashar: Syncronize VisualEditor 6f37b46..6f37b46 [extensions] - 10https://gerrit.wikimedia.org/r/107839 [13:51:08] (03Abandoned) 10Hashar: Syncronize VisualEditor 6f37b46..6f37b46 [extensions] - 10https://gerrit.wikimedia.org/r/107839 (owner: 10Hashar) [13:55:08] (03PS8) 10AalekhN: SpecialWhatlinkshere.php : made Special:Whatlinkshere transclude [core] - 10https://gerrit.wikimedia.org/r/106625 [13:59:10] (03PS2) 10Gilles: Propagate the favicon information to getInfo() for local repos [core] - 10https://gerrit.wikimedia.org/r/107712 (owner: 10Gergő Tisza) [14:09:38] yurik there? i was going through edit part. have some questions though [14:10:35] (03PS9) 10AalekhN: SpecialWhatlinkshere.php : made Special:Whatlinkshere transclude [core] - 10https://gerrit.wikimedia.org/r/106625 [14:13:01] (03PS1) 10Arav93: Renamed Special:Version to Special:Software [core] - 10https://gerrit.wikimedia.org/r/107840 [14:22:32] (03CR) 10Liangent: "Bug 4155?" [core] - 10https://gerrit.wikimedia.org/r/107840 (owner: 10Arav93) [14:22:47] (03CR) 10Liangent: "and maybe [[Special:About]]?" [core] - 10https://gerrit.wikimedia.org/r/107840 (owner: 10Arav93) [14:24:27] (03PS1) 10Hashar: Script to sync VisualEditor in mediawiki/extensions.git [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107841 [14:24:35] (03CR) 10Hashar: [C: 032] Script to sync VisualEditor in mediawiki/extensions.git [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107841 (owner: 10Hashar) [14:24:38] (03Merged) 10jenkins-bot: Script to sync VisualEditor in mediawiki/extensions.git [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107841 (owner: 10Hashar) [14:33:41] (03PS1) 10Daniel Kinzler: Refactor SpecialCategories [core] - 10https://gerrit.wikimedia.org/r/107842 [14:37:09] (03CR) 10jenkins-bot: [V: 04-1] Refactor SpecialCategories [core] - 10https://gerrit.wikimedia.org/r/107842 (owner: 10Daniel Kinzler) [14:58:13] (03PS2) 10Daniel Kinzler: Refactor SpecialCategories [core] - 10https://gerrit.wikimedia.org/r/107842 [15:00:32] (03CR) 10Bartosz Dziewoński: [C: 031] "JSDuck makes documenting weirdly structured code somewhat of a pain, thought :/ I guess that's what we get for writing in dynamic language" [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [15:03:40] (03PS1) 10Hashar: gerrit-sync-ve: move hook init just before push [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107845 [15:03:43] (03PS1) 10Hashar: gerrit-sync-ve: clone anon repo, push over ssh [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107846 [15:03:46] (03PS1) 10Hashar: gerrit-sync-ve: split update and pushing [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107847 [15:03:56] (03CR) 10Hashar: [C: 032] gerrit-sync-ve: clone anon repo, push over ssh [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107846 (owner: 10Hashar) [15:03:59] (03CR) 10Hashar: [C: 032] gerrit-sync-ve: split update and pushing [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107847 (owner: 10Hashar) [15:04:02] (03CR) 10Hashar: [C: 032] gerrit-sync-ve: move hook init just before push [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107845 (owner: 10Hashar) [15:04:05] (03Merged) 10jenkins-bot: gerrit-sync-ve: move hook init just before push [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107845 (owner: 10Hashar) [15:04:08] (03Merged) 10jenkins-bot: gerrit-sync-ve: clone anon repo, push over ssh [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107846 (owner: 10Hashar) [15:04:11] (03Merged) 10jenkins-bot: gerrit-sync-ve: split update and pushing [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107847 (owner: 10Hashar) [15:05:06] (03CR) 10Alexandros Kosiaris: [C: 032] Satisfy lintian [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/105968 (owner: 10Alexandros Kosiaris) [15:08:56] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] "Yes it is!" [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/107791 (owner: 10Reedy) [15:09:05] (03CR) 10Anomie: "Don't forget to update [[mw:Extension:Scribunto/Lua reference manual]]" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107046 (owner: 10Jackmcbarn) [15:12:11] (03CR) 10Tpt: [C: 032] "Thanks" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/107597 (owner: 10Tpt) [15:12:17] (03Merged) 10jenkins-bot: Don’t use 0 as proofreading level for edits from unallowed users [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/107597 (owner: 10Tpt) [15:13:05] (03PS1) 10Hashar: gerrit-sync-ve: git show --no-patch is 1.8+ [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107849 [15:13:09] (03CR) 10Aklapper: [C: 04-1] "Wrong bug number in commit message, should be 41555" [core] - 10https://gerrit.wikimedia.org/r/107840 (owner: 10Arav93) [15:13:22] (03CR) 10Hashar: [C: 032] gerrit-sync-ve: git show --no-patch is 1.8+ [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107849 (owner: 10Hashar) [15:13:25] (03Merged) 10jenkins-bot: gerrit-sync-ve: git show --no-patch is 1.8+ [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107849 (owner: 10Hashar) [15:14:24] (03CR) 10Anomie: "Is there need to mention that various files are under the MIT license?" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107786 (owner: 10Reedy) [15:15:09] (03CR) 10Anomie: [C: 032] "May as well" [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/107785 (owner: 10Reedy) [15:15:11] (03Merged) 10jenkins-bot: Add COPYING [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/107785 (owner: 10Reedy) [15:16:15] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Thanks, but you broke it :( (or we found a JSDuck bug)." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/107630 (owner: 10Bartosz Dziewoński) [15:19:52] (03CR) 10Aklapper: "I only see two URL targets changed. Did you actually try this patch? Or does it depend on some other patchset to work properly? Because ch" [core] - 10https://gerrit.wikimedia.org/r/107840 (owner: 10Arav93) [15:21:11] (03PS3) 10Gilles: Propagate the favicon information to getInfo() for local repos [core] - 10https://gerrit.wikimedia.org/r/107712 (owner: 10Gergő Tisza) [15:21:18] (03CR) 10Bartosz Dziewoński: [C: 04-1] Renamed Special:Version to Special:Software [core] - 10https://gerrit.wikimedia.org/r/107840 (owner: 10Arav93) [15:27:44] (03CR) 10Aklapper: "See my inline comments, refering to style and not to the code itself." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/106625 (owner: 10AalekhN) [15:28:51] (03CR) 10Bartosz Dziewoński: [C: 032] Add OOjs to jsduck index [core] - 10https://gerrit.wikimedia.org/r/107760 (owner: 10Krinkle) [15:32:02] (03Merged) 10jenkins-bot: Add OOjs to jsduck index [core] - 10https://gerrit.wikimedia.org/r/107760 (owner: 10Krinkle) [15:36:03] (03CR) 10Krinkle: JSDuck-ify /resources/mediawiki/mediawiki.Uri.js (031 comment) [core] - 10https://gerrit.wikimedia.org/r/107630 (owner: 10Bartosz Dziewoński) [15:39:20] (03CR) 10Bartosz Dziewoński: JSDuck-ify /resources/mediawiki/mediawiki.Uri.js (031 comment) [core] - 10https://gerrit.wikimedia.org/r/107630 (owner: 10Bartosz Dziewoński) [15:39:34] (03PS3) 10AalekhN: SpecialContributions.php : made Special:Contributions includable [core] - 10https://gerrit.wikimedia.org/r/106320 [15:41:21] (03Abandoned) 10Dzahn: fix leading spaces, tab levels in footer [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106671 (owner: 10Dzahn) [16:01:43] (03PS1) 10Hoo man: Allow changing the title used by Scribunto_LuaEngineTestBase [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107856 [16:01:51] anomie: ^ Works :) [16:02:12] (03CR) 10Aklapper: [C: 04-1] "Same problem as in patchset 2 (tab vs. whitespace) - Maybe take a look yourself at https://gerrit.wikimedia.org/r/#/c/106320/3/includes/sp" [core] - 10https://gerrit.wikimedia.org/r/106320 (owner: 10AalekhN) [16:05:12] hmmmmm [16:05:22] is https://doc.wikimedia.org/mediawiki-core/master/js/ supposed to be automatically generated? [16:05:35] because it says it was last updated on Mon 06 Jan 2014 23:28:36 [16:05:41] hashar: ^ [16:06:26] MatmaRex: bug fill it please :-D [16:06:40] I fixed the PHP doc yesterday, the js doc probably has a similar issue [16:06:56] * YuviPanda waves at hashar [16:06:59] basically the doxygen job was referring to variables such as GERRIT_* which is no more existing [16:07:13] alright, will do [16:07:25] (03CR) 10Bartosz Dziewoński: Improve mediawiki.js documentation (034 comments) [core] - 10https://gerrit.wikimedia.org/r/107761 (owner: 10Krinkle) [16:07:58] hashar: can https://gerrit.wikimedia.org/r/#/c/106217/ be merged now? [16:08:01] I saw https://gerrit.wikimedia.org/r/#/c/107853/ happen [16:09:05] (03PS2) 10Bartosz Dziewoński: Improve mediawiki.js documentation [core] - 10https://gerrit.wikimedia.org/r/107761 (owner: 10Krinkle) [16:10:56] (03CR) 10Bartosz Dziewoński: [C: 031] "Will +2 if you're okay with my changes." [core] - 10https://gerrit.wikimedia.org/r/107761 (owner: 10Krinkle) [16:11:54] YuviPanda: can't look t it right now, sorry [16:12:06] hashar: alright, I'll ping you again tomorrow :) [16:29:12] (03CR) 10Krinkle: [C: 032] JSDuck-ify /resources/mediawiki.language/* [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [16:29:26] (03PS4) 10Krinkle: JSDuck-ify /resources/mediawiki/mediawiki.Uri.js [core] - 10https://gerrit.wikimedia.org/r/107630 (owner: 10Bartosz Dziewoński) [16:30:29] (03CR) 10Jackmcbarn: "Done." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107046 (owner: 10Jackmcbarn) [16:30:39] (03CR) 10Krinkle: JSDuck-ify /resources/mediawiki/mediawiki.Uri.js (031 comment) [core] - 10https://gerrit.wikimedia.org/r/107630 (owner: 10Bartosz Dziewoński) [16:30:46] (03CR) 10Krinkle: [C: 031] JSDuck-ify /resources/mediawiki/mediawiki.Uri.js [core] - 10https://gerrit.wikimedia.org/r/107630 (owner: 10Bartosz Dziewoński) [16:31:29] (03PS10) 10AalekhN: SpecialWhatlinkshere.php : made Special:Whatlinkshere transclude [core] - 10https://gerrit.wikimedia.org/r/106625 [16:32:05] (03CR) 10Anomie: [C: 032] Allow changing the title used by Scribunto_LuaEngineTestBase [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107856 (owner: 10Hoo man) [16:32:17] hoo: There you go [16:32:31] :) Thanks [16:33:10] (03Merged) 10jenkins-bot: JSDuck-ify /resources/mediawiki.language/* [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [16:33:54] (03CR) 10jenkins-bot: [V: 04-1] JSDuck-ify /resources/mediawiki/mediawiki.Uri.js [core] - 10https://gerrit.wikimedia.org/r/107630 (owner: 10Bartosz Dziewoński) [16:33:56] (03Merged) 10jenkins-bot: Allow changing the title used by Scribunto_LuaEngineTestBase [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107856 (owner: 10Hoo man) [16:35:43] hashar: Did you change something to doc.wikimedia.org? [16:35:45] https://doc.wikimedia.org/VisualEditor/master/ is 404 [16:35:46] huh [16:35:47] It's now at https://doc.wikimedia.org/VisualEditor/ ? [16:35:49] Hm.. [16:35:57] nice segfault… https://integration.wikimedia.org/ci/job/mediawiki-core-jsduck/3304/console [16:36:03] Krinkle: the docs are no longer autogenerated, btw [16:36:09] i just filed a bug aobut it [16:36:43] (03CR) 10AalekhN: "Aklapper:i think i cleared all the style prob......if any thing other present please reply" [core] - 10https://gerrit.wikimedia.org/r/106625 (owner: 10AalekhN) [16:36:55] hashar: Ah, version_dir='' [16:37:09] Probably GERRIT/ZUUL var missing that was removed in the last upgrade [16:37:13] (03PS5) 10Bartosz Dziewoński: JSDuck-ify /resources/mediawiki/mediawiki.Uri.js [core] - 10https://gerrit.wikimedia.org/r/107630 [16:37:14] I thought you caught htem all [16:37:23] (03CR) 10Bartosz Dziewoński: [C: 031] JSDuck-ify /resources/mediawiki/mediawiki.Uri.js [core] - 10https://gerrit.wikimedia.org/r/107630 (owner: 10Bartosz Dziewoński) [16:38:02] huh, are still running ruby 1.8? [16:38:14] isn't it past EOL yet? [16:39:53] Krinkle: good evening [16:40:35] Krinkle: so yeah someone noticed late at night yesterday that the mw/core PHP doc was no more being generated. That was because the script used GERRIT env variable which are no more around [16:40:46] Krinkle: i did a few greps but haven't looked at all the places though [16:40:51] (03CR) 10Anomie: [C: 032] Don't always count CASCADINGSOURCES as expensive [core] - 10https://gerrit.wikimedia.org/r/107714 (owner: 10Jackmcbarn) [16:40:53] (03PS1) 10Krinkle: Fix jsduck publish errors (GERRIT_BRANCH -> ZUUL_BRANCH) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/107860 [16:41:03] \O/ [16:41:46] (03PS2) 10Hashar: Fix jsduck publish errors (GERRIT_BRANCH -> ZUUL_BRANCH) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/107860 (owner: 10Krinkle) [16:41:49] (03CR) 10jenkins-bot: [V: 04-1] Fix jsduck publish errors (GERRIT_BRANCH -> ZUUL_BRANCH) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/107860 (owner: 10Krinkle) [16:41:55] :( [16:42:09] (03PS3) 10Krinkle: Fix jsduck publish errors (GERRIT_BRANCH -> ZUUL_BRANCH) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/107860 [16:42:18] was just adding a reference to bug: 60137 [16:42:18] :( [16:42:19] hashar: bug -> Bug, please. [16:42:27] My patch was already broken it seems [16:42:36] * MatmaRex filed https://bugzilla.wikimedia.org/show_bug.cgi?id=60138 for the old Ruby stuff [16:42:46] or not.. [16:42:50] weird [16:43:02] race condition? [16:43:08] some git ssh commands fails on gallium for some reason [16:43:18] such as Gerrit giving hash key mismatch [16:43:46] !log reedy synchronized php-1.23wmf11 [16:43:46] Wrong channel, try again. [16:44:07] Reedy: wat ^ [16:44:07] (03Merged) 10jenkins-bot: Don't always count CASCADINGSOURCES as expensive [core] - 10https://gerrit.wikimedia.org/r/107714 (owner: 10Jackmcbarn) [16:44:12] Krinkle: also I have been working on a job to update VisualEditor in mediawiki/extensions.git [16:44:39] Krinkle: that will be done by Gerrit user 'jenkins-bot' which need an email address. Should I make you a recipient of such email and if so would you prefer your gmail or wm.o email ? [16:45:35] hashar: btw, It seems this also caused all existing versions/branches to be deleted. [16:45:46] because we rm-rf the target dir, which was now one level too far up [16:45:58] e.g. the old master/ and REL_* didn't stay. [16:46:08] Got any ideas to make this future proof? [16:46:16] maybe default to "unknown" or abort early? [16:46:47] I'm deleting the bad docs now [16:46:49] and pushing new jobs [16:47:36] (03CR) 10Krinkle: [C: 032] "Pushed mediawiki-core-jsduck, mediawiki-core-jsduck-publish, mwext-VisualEditor-doc-publish and mwext-VisualEditor-doc-test." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/107860 (owner: 10Krinkle) [16:47:52] (03Merged) 10jenkins-bot: Fix jsduck publish errors (GERRIT_BRANCH -> ZUUL_BRANCH) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/107860 (owner: 10Krinkle) [16:48:11] Krinkle: was it because the GERRIT_BRANCH was undefined ? [16:48:11] hashar: For VisualEditor that is, the other versions were nuked. [16:48:14] Yes [16:48:26] We got lucky for mediawiki-core, the old ones stayed because it has one extra directory level [16:48:27] could add a check to make sure it is set to something [16:48:36] mediawiki-core wasn't wiped, only mediawiki-core//js [16:48:43] but VisualEditor was wiped [16:48:46] :/ [16:48:46] naturally [16:49:10] I've deleted https://doc.wikimedia.org/VisualEditor/* and https://doc.wikimedia.org/mediawiki-core/js/ [16:49:28] e.g. the bad published directories [16:49:43] Krinkle: and for jenkins-bot email alias do you want your gmail or wikimedia email to be spammed ? [16:49:59] hashar: What e-mail is this? [16:50:18] What kind of e-mail [16:50:20] I will craft commit message on mediawiki/extensions.git to update VE [16:50:22] and push that to Gerrit [16:50:33] the jenkins-bot user thus need an email address [16:50:43] so maybe some notifications by Gerrit [16:50:52] easily filtered since they will be to: jenkins-bot [16:51:09] To: jenkins-bot@wikimedia.org [16:51:53] hashar: gmail, like other gerrit stuff. I'll filter it there. [16:52:15] thanks! [16:52:22] (03CR) 10Krinkle: [C: 032] JSDuck-ify /resources/mediawiki/mediawiki.Uri.js [core] - 10https://gerrit.wikimedia.org/r/107630 (owner: 10Bartosz Dziewoński) [16:55:45] (03Merged) 10jenkins-bot: JSDuck-ify /resources/mediawiki/mediawiki.Uri.js [core] - 10https://gerrit.wikimedia.org/r/107630 (owner: 10Bartosz Dziewoński) [17:01:53] (03PS1) 10Hashar: gerrit-sync-ve: use jenkins-bot as committer name [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107861 [17:02:03] (03CR) 10Hashar: [C: 032] gerrit-sync-ve: use jenkins-bot as committer name [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107861 (owner: 10Hashar) [17:02:06] (03Merged) 10jenkins-bot: gerrit-sync-ve: use jenkins-bot as committer name [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107861 (owner: 10Hashar) [17:03:10] (03PS1) 10Hashar: mwext-VisualEditor-sync-gerrit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/107862 [17:05:08] (03CR) 10UltrasonicNXT: "Awesome, thankyou!" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/107361 (owner: 10Raimond Spekking) [17:06:03] (03PS2) 10Hashar: mwext-VisualEditor-sync-gerrit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/107862 [17:06:17] (03CR) 10Hashar: [C: 032] mwext-VisualEditor-sync-gerrit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/107862 (owner: 10Hashar) [17:06:36] (03Merged) 10jenkins-bot: mwext-VisualEditor-sync-gerrit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/107862 (owner: 10Hashar) [17:08:35] !log reedy started scap: testwiki to 1.23wmf11 and build l10n cache [17:08:35] Wrong channel, try again. [17:08:51] :P [17:09:10] Has logmsgbot got amnesia? [17:13:14] Reedy: No. [17:15:17] ^d: good morning :-] [17:15:23] <^d> hi hi [17:15:34] ^d: so I got a job to update VisualEditor in mediawiki/extensions.git [17:15:44] hey guys, I'm wondering, what is the best way to store data that needs to be transferrable between different instances of a specific tag extension? [17:15:46] but I need jenkins-bot user in Gerrit to have an email address: https://integration.wikimedia.org/ci/job/mwext-VisualEditor-sync-gerrit/8/console [17:16:05] ^d: jenkins-bot in LDAP has the jenkins-bot@wikimedia.org address. Registered by RobH a few minutes ago. [17:16:12] I am not sure what needs to be done on Gerrit side. [17:16:21] so foobarbaz, let's say I want to prepend the contents of the previous tab to the next tab, how do I do that? [17:16:23] nor do I know jenkins-bot password to change it :/ [17:16:24] (03CR) 10UltrasonicNXT: [C: 032 V: 032] "First of all, whenever you submit a patch for MediaWikiChat, remember to ad me in the Reviewers section so I get alerted :)" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/107758 (owner: 10Shirayuki) [17:16:38] the output would have to be "foobarfoobaz" [17:16:42] in that example [17:16:53] <^d> hashar: Do we just need some permissions on that repo? [17:17:16] ^d: yeah will need jenkins-bot to be able to V+2 C+2 and --submit on mediawiki/extensions.git [17:17:53] <^d> Should be able to already since it's got the whole mediawiki/* hierarchy. [17:18:11] what I've tried is defining an array in the parser object, via $parser->tagData = array('previous'=>''); and then later redefining the $parser->tagData['previous'] to whatever the contents of that tag would be [17:18:37] but the problem I'm having now is that it doesn't seem to "remember" it between individual tags [17:19:52] ^d: probably [17:20:05] so does anyone have any idea what the best way is to temporarily save data to be used in other tags? [17:20:10] ^d: just need jenkins-bot to have an email address assigned :-) [17:20:25] <^d> Why does it need that now but not before? [17:20:40] cause we never pushed anything [17:20:48] <^d> Oh duh :p [17:21:03] jenkins-bot is merely for Zuul to listen for stream-events :-D [17:21:10] and report back in Gerrit. [17:21:19] Might want a different username one day [17:23:33] got to leave [17:23:47] whenever the email is added, you can try retriggering the updating job : https://integration.wikimedia.org/ci/job/mwext-VisualEditor-sync-gerrit/8/console [17:24:04] that should ultimately send a change in Gerrit and auto approve it :D [17:24:38] heading back home *wave* [17:25:36] :o [17:25:38] well [17:25:56] hashar has no excuses not to implement release notes conflict rebasing, then. :D [17:29:16] !log reedy finished scap: testwiki to 1.23wmf11 and build l10n cache (duration: 23m 24s) [17:29:16] Wrong channel, try again. [17:30:40] (03CR) 10Anomie: [C: 04-1] Allow PENDINGCHANGELEVEL to work on other pages (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/106898 (owner: 10Jackmcbarn) [17:31:53] i wanted to confirm that to get an edit token of a wiki page , intoken parameter must be set to value 'edit'. am i right? coz while calling an API m getting this warning: "*": "Unrecognized value for parameter 'intoken': edit" [17:32:54] it is just a simple api call to get the page info [17:32:54] (03PS12) 10Jackmcbarn: Add an API action to test blacklisted URLs [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 [17:33:26] (03PS13) 10Jackmcbarn: Add an API action to test blacklisted URLs [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 [17:36:31] (03CR) 10MaxSem: [C: 032] Add COPYING [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/107766 (owner: 10Reedy) [17:36:38] (03Merged) 10jenkins-bot: Add COPYING [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/107766 (owner: 10Reedy) [17:38:39] (03PS1) 10Chad: Fix undefined variable [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107867 [17:39:43] Who broke my watchlist on dewiki.beta.wmflabs? ;) (PHP fatal error) Is someone aware of this issue? [17:42:08] (03PS2) 10Chad: Fix undefined variable [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107867 [17:43:15] se4598: full URL please? [17:43:28] https://de.wikipedia.beta.wmflabs.org/wiki/Spezial:Beobachtungsliste or any watchlist on beta project [17:43:44] PHP fatal error in /data/project/apache/common-local/php-master/includes/specials/SpecialWatchlist.php line 454: [17:43:44] Call to a member function getOption() on a non-object @MatmaRex [17:44:15] D: [17:44:21] then it might be me [17:44:28] (03PS2) 10Jackmcbarn: Allow PENDINGCHANGELEVEL to work on other pages [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/106898 [17:44:46] (03PS1) 10Raimond Spekking: Adds an i18n file for the base of the extension [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/107874 [17:45:03] (03CR) 10Jackmcbarn: "For now, this will always count as expensive. Once I get a core change in, I'll be able to change it to only count as expensive when it re" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/106898 (owner: 10Jackmcbarn) [17:45:19] !log reedy rebuilt wikiversions.cdb and synchronized wikiversions files: testwiki back to 1.23wmf9 till window [17:45:19] Wrong channel, try again. [17:45:44] Reedy: wtf is up with logmsgbot today [17:45:57] MatmaRex: blame shows me for the codeline https://gerrit.wikimedia.org/r/94677 [17:46:41] yeah, that's definitely the source of the problem [17:46:52] it worked in my tests… :( [17:47:28] Reedy: i'm going to need a backport to wmf11 to fix a fatal, i tihnk [17:47:36] omfg [17:47:37] Fair enough [17:48:48] (03CR) 10Bartosz Dziewoński: "Aw poop, this causes fatals because I forgot to set a variable. No idea how I missed this before. Patch on the way." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/94677 (owner: 10Bartosz Dziewoński) [17:50:52] (03PS1) 10Jackmcbarn: Add WikiPage::isDataLoaded() [core] - 10https://gerrit.wikimedia.org/r/107875 [17:53:22] (03PS1) 10Bartosz Dziewoński: SpecialWatchlist: Fix a fatal due to undefined variable [core] - 10https://gerrit.wikimedia.org/r/107876 [17:53:56] !log reedy synchronized docroot and w [17:53:57] Wrong channel, try again. [17:54:53] (03CR) 10Bartosz Dziewoński: "Followup: https://gerrit.wikimedia.org/r/#/c/107876/1 . I missed it because the fatal only happens if $wgEnotifWatchlist is true. I checke" [core] - 10https://gerrit.wikimedia.org/r/94677 (owner: 10Bartosz Dziewoński) [17:54:55] (03Abandoned) 10Jackmcbarn: Add WikiPage::isDataLoaded() [core] - 10https://gerrit.wikimedia.org/r/107875 (owner: 10Jackmcbarn) [17:55:18] (03PS1) 10Bartosz Dziewoński: SpecialWatchlist: Fix a fatal due to undefined variable [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/107877 [17:55:23] Reedy: wanna? ^ [17:55:32] se4598: thanks for the report [17:55:46] (03CR) 10Ori.livneh: [C: 032] "How did we miss this? Eep." [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/107877 (owner: 10Bartosz Dziewoński) [17:56:03] (03PS2) 10Ori.livneh: SpecialWatchlist: Fix a fatal due to undefined variable [core] - 10https://gerrit.wikimedia.org/r/107876 (owner: 10Bartosz Dziewoński) [17:56:08] (03CR) 10Ori.livneh: [C: 032] SpecialWatchlist: Fix a fatal due to undefined variable [core] - 10https://gerrit.wikimedia.org/r/107876 (owner: 10Bartosz Dziewoński) [17:56:19] (03CR) 10Reedy: [C: 032] SpecialWatchlist: Fix a fatal due to undefined variable [core] - 10https://gerrit.wikimedia.org/r/107876 (owner: 10Bartosz Dziewoński) [17:56:37] double-kill! [17:56:41] Reedy: thanks [17:56:43] ori: Because php -l is pretty useless [17:56:53] Basic static analysis would catch these things... [17:57:02] if ( $wgEnotifWatchlist && $user->getOption( 'enotifwatchlistpages' ) ) { [17:57:16] (03CR) 10Jackmcbarn: "Never mind about that, FRPageConfig::getStabilitySettings really is always expensive." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/106898 (owner: 10Jackmcbarn) [17:57:16] breaking news, $user doesn't get executed if !$wgEnotifWatchlist ;) [17:57:31] * Reedy is enlightened [17:57:45] has anybody ever written a phplint too? [17:57:46] tool* [17:58:41] phpcs only ever complains about bullshit whitespace rules [17:59:30] <^d> We used to have a linter that used runkit. [17:59:43] <^d> But runkit's pretty abandonware at this point iirc. [17:59:49] the top of the line option for PHP is https://github.com/facebook/pfff [17:59:56] I don't remember if phpmd finds undefined variables or not, but it finds unused ones so I would guess it also finds undefined [17:59:57] which is actually capable of some static analysis [18:00:08] (03Merged) 10jenkins-bot: SpecialWatchlist: Fix a fatal due to undefined variable [core] (wmf/1.23wmf11) - 10https://gerrit.wikimedia.org/r/107877 (owner: 10Bartosz Dziewoński) [18:00:09] pfff [18:00:11] perfect [18:00:28] ^d: The top of the line for pretty much anything PHP related is from Facebook [18:00:49] (03Merged) 10jenkins-bot: SpecialWatchlist: Fix a fatal due to undefined variable [core] - 10https://gerrit.wikimedia.org/r/107876 (owner: 10Bartosz Dziewoński) [18:00:52] <^d> That was ori, not me. [18:01:13] you all look the same to me. [18:01:17] (03CR) 10MarkTraceur: "You're the best, Theo - patch to come this hour" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [18:01:21] Damn you white people [18:01:29] ^d: Two characters, three characters [18:01:30] what's the diff [18:01:33] !log reedy synchronized php-1.23wmf11/includes/specials/SpecialWatchlist.php [18:01:34] Wrong channel, try again. [18:01:36] "non-Australians" [18:01:39] * werdna synchronises Reedy  [18:01:46] why is logmsgbot posting to this channel [18:01:49] for the sixth time today [18:02:12] MatmaRex: i changed it, after a lengthy public discussion [18:02:24] :o [18:02:24] involving me and myself [18:02:27] should I change it back? [18:02:34] (03CR) 10Krinkle: Improve mediawiki.js documentation (033 comments) [core] - 10https://gerrit.wikimedia.org/r/107761 (owner: 10Krinkle) [18:02:34] it's slightly useful [18:02:36] I figured it's a bit lame that we all congregate in #wikimedia-operations [18:02:39] like op wannabes [18:02:42] it's fine either way if you find a way to shut up wm-bot [18:02:42] but logmsgbot replying isn't the best [18:02:54] <^d> What's lame is this channel. [18:02:56] <^d> :) [18:03:00] +1 [18:03:44] https://github.com/facebook/pfff/wiki/Scheck hmm [18:03:45] well, logmsgbot is a very simple relay, it just outputs what you write to its tcp socket [18:03:57] so i'd rather not customize its output per-channel [18:04:00] can't wm-bot ignore logmsgbot? [18:04:26] * ^d ignores all the bots :p [18:04:31] who knows? petan? [18:04:33] @help [18:04:33] I am running http://meta.wikimedia.org/wiki/WM-Bot version wikimedia bot v. 1.20.2.0 my source code is licensed under GPL and located at https://github.com/benapetr/wikimedia-bot I will be very happy if you fix my bugs or implement new features [18:04:35] @info [18:04:35] http://bots.wmflabs.org/~wm-bot/dump/%23wikimedia-dev.htm [18:04:57] <^d> !log somebody broke getSlaveServerTest for Sqlite. [18:04:57] Wrong channel, try again. [18:05:00] it can, i think [18:05:01] https://meta.wikimedia.org/wiki/WM-Bot#.40infobot-ignore.2B [18:05:03] <^d> !log [18:05:03] Wrong channel, try again. [18:05:05] <^d> !log [18:05:05] Wrong channel, try again. [18:05:06] <^d> !log [18:05:07] Wrong channel, try again. [18:05:14] <^d> I CAN DO THIS ALL DAY, BOT [18:05:29] @infobot-ignore+ !log [18:05:29] Item !log was inserted to ignore list [18:05:34] !log [18:05:34] Wrong channel, try again. [18:05:37] fucker. [18:05:51] !del log [18:05:51] There is no such key, you probably want to try: !deleteuser, !extensiondistributor, !protect, !resourceloader, !revdelete, !security, !uploadbyurl, !worstcase, !memoserv, [18:05:53] @infobot-ignore+ log [18:05:53] Item log was inserted to ignore list [18:05:59] !log [18:06:03] !log [18:06:04] well, this works [18:06:09] but i'm not sure if it's a good idea [18:06:13] @infobot-ignore- !log [18:06:13] Item !log was removed from list [18:06:19] why on earth not?! [18:06:24] ori: it would be `!log del` [18:06:24] seems like a good solution to me [18:06:29] but then it would suggest all other keys [18:06:32] !logg [18:06:32] There is no such key, you probably want to try: !anonnotice, !debug, [18:06:45] see also ! [18:06:45] MatmaRex: right, like "/foo/myfile rm" [18:06:45] ! [18:06:45] https://bugzilla.wikimedia.org/show_bug.cgi?id=56740 Typing "!" into a channel shouldn't cause the bot to print the list of all bangcodes it knows [18:06:46] (03CR) 10Aaron Schulz: [C: 031] API: Add prop=redirects and list=allredirects (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104764 (owner: 10Anomie) [18:07:07] ori: i didn't write it. :D [18:07:12] @infobot-ignore+ log [18:07:12] Item log is already in list [18:07:23] (03CR) 10Matthias Mullie: Make error reporting more verbose. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107149 (owner: 10Matthias Mullie) [18:07:37] (03PS1) 10Werdna: Load more than 10 discussions in compacted views. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107878 [18:07:47] hmm, actually @infobot-ignore+ seems to be smarter than i thought [18:07:51] so it would just ignore !logs [18:08:11] probably good, apart from the fact that there's no feedback for people !logging on the wrong channel [18:08:16] !log del [18:08:23] ah, that won't work now. oh well. [18:08:25] :D [18:12:45] (03PS1) 10Krinkle: Fix jsduck publish errors for mediawiki-core (GERRIT_BRANCH -> ZUUL_BRANCH) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/107879 [18:13:13] (03CR) 10Matthias Mullie: "I already suggested this a while ago, so this still is fine for me." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106850 (owner: 10Bsitu) [18:13:42] @infobot-ignore+ @infobot-ignore- [18:13:43] Item @infobot-ignore- was inserted to ignore list [18:13:49] uhoh. [18:13:50] <^d> But what happens when people try to log in the wrong place? [18:13:52] <^d> !log [18:13:56] <^d> Now I'm not warned. [18:14:00] Wrong channel. [18:14:00] <^d> There was a reason for the msg. [18:16:35] @infobot-ignore- @infobot-ignore- [18:16:35] Item @infobot-ignore- was removed from list [18:16:47] this only matches the part after '!' and before ' ', it seems [18:17:20] @help [18:17:20] I am running http://meta.wikimedia.org/wiki/WM-Bot version wikimedia bot v. 1.20.2.0 my source code is licensed under GPL and located at https://github.com/benapetr/wikimedia-bot I will be very happy if you fix my bugs or implement new features [18:18:08] (03CR) 10Krinkle: [C: 032] "Pushed mediawiki-core-jsduck-publish, and rebuild the last job." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/107879 (owner: 10Krinkle) [18:18:22] MatmaRex: https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Uri [18:18:25] (03Merged) 10jenkins-bot: Fix jsduck publish errors for mediawiki-core (GERRIT_BRANCH -> ZUUL_BRANCH) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/107879 (owner: 10Krinkle) [18:18:48] Guest58681: thanks [18:19:12] ori: ^d: i think i'll remove that for now and see what happens [18:19:16] probably no one will care but me [18:19:20] @infobot-ignore- log [18:19:20] Item log was removed from list [18:19:23] !log [18:19:24] Wrong channel, try again. [18:19:44] no, seriously [18:19:49] just ignore it [18:19:59] it's more important than the reminder [18:20:05] we should ignore logmsgbot instead [18:20:13] but i don't know if it's possible, and if yes, how [18:22:11] (03PS1) 10Chad: Ehcache more like mehcache [core] - 10https://gerrit.wikimedia.org/r/107880 [18:25:42] (03CR) 10Gergő Tisza: Propagate the favicon information to getInfo() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/107592 (owner: 10Gilles) [18:27:03] (03PS3) 10Krinkle: Improve mediawiki.js documentation [core] - 10https://gerrit.wikimedia.org/r/107761 [18:27:14] (03PS4) 10Krinkle: Improve mediawiki.js documentation [core] - 10https://gerrit.wikimedia.org/r/107761 [18:27:18] (03CR) 10Krinkle: [C: 031] Improve mediawiki.js documentation [core] - 10https://gerrit.wikimedia.org/r/107761 (owner: 10Krinkle) [18:27:55] (03CR) 10Krinkle: [C: 04-1] "Can you elaborate?" [core] - 10https://gerrit.wikimedia.org/r/107880 (owner: 10Chad) [18:28:39] (03Abandoned) 10Bartosz Dziewoński: Revert "Add legend to Special:RecentChanges and Special:Watchlist" [core] - 10https://gerrit.wikimedia.org/r/101603 (owner: 10Danny B.) [18:28:43] (03Abandoned) 10Bartosz Dziewoński: Revert "SpecialRecentChanges: Use $wgRecentChangesFlags in makeLegend()" [core] - 10https://gerrit.wikimedia.org/r/101604 (owner: 10Danny B.) [18:29:01] mehcache? that doesn't sound very enthusiastic [18:29:11] (03CR) 10Krinkle: "(Introduced in 2011 in 1.16.3)" [core] - 10https://gerrit.wikimedia.org/r/107880 (owner: 10Chad) [18:29:36] (03PS2) 10Mattflaschen: Auto-launch full tour, not just intro [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/107726 [18:29:39] (03CR) 10jenkins-bot: [V: 04-1] Auto-launch full tour, not just intro [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/107726 (owner: 10Mattflaschen) [18:31:36] (03CR) 10Gergő Tisza: Propagate the favicon information to getInfo() for local repos (032 comments) [core] - 10https://gerrit.wikimedia.org/r/107712 (owner: 10Gergő Tisza) [18:32:06] rebase incoming… [18:32:28] (03PS11) 10Bartosz Dziewoński: Create ChangesListSpecialPage as a base class for Watchlist and RC [core] - 10https://gerrit.wikimedia.org/r/102458 [18:32:30] (03PS8) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement execute() [core] - 10https://gerrit.wikimedia.org/r/103240 [18:32:32] (03PS8) 10Bartosz Dziewoński: Changes list legend modules cleanup [core] - 10https://gerrit.wikimedia.org/r/103197 [18:32:34] (03PS5) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement two new hooks superseding 4 old ones [core] - 10https://gerrit.wikimedia.org/r/106279 [18:32:36] (03PS6) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement webOutput() [core] - 10https://gerrit.wikimedia.org/r/105195 [18:32:38] (03PS5) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement doMainQuery() [core] - 10https://gerrit.wikimedia.org/r/105194 [18:32:40] (03PS7) 10Bartosz Dziewoński: Change behavior of Special:Watchlist when user's watchlist is empty [core] - 10https://gerrit.wikimedia.org/r/103233 [18:32:42] (03PS7) 10Bartosz Dziewoński: ChangesListSpecialPage and subclasses: Reorder functions [core] - 10https://gerrit.wikimedia.org/r/103200 [18:32:44] (03PS7) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/103546 [18:32:46] (03PS7) 10Bartosz Dziewoński: No longer display the number of rows shown on Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/103239 [18:32:48] (03PS6) 10Bartosz Dziewoński: ChangesListSpecialPage: Stop mutating $opts in buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/105196 [18:33:37] three merge conflicts, heh. [18:38:09] (03CR) 10Chad: "It was an experiment that didn't pan out, and now the code's just bitrotting?" [core] - 10https://gerrit.wikimedia.org/r/107880 (owner: 10Chad) [18:39:11] (03CR) 10Bartosz Dziewoński: [C: 032] Improve mediawiki.js documentation [core] - 10https://gerrit.wikimedia.org/r/107761 (owner: 10Krinkle) [18:41:55] (03CR) 10Krinkle: "I mean, this commit doesn't explain why it is being removed, nor what "mehcache" is (maybe ehcache is compatible with mehcache, and we don" [core] - 10https://gerrit.wikimedia.org/r/107880 (owner: 10Chad) [18:42:55] (03CR) 10Bartosz Dziewoński: "Krinkle's a real killjoy." [core] - 10https://gerrit.wikimedia.org/r/107880 (owner: 10Chad) [18:43:51] (03Merged) 10jenkins-bot: Improve mediawiki.js documentation [core] - 10https://gerrit.wikimedia.org/r/107761 (owner: 10Krinkle) [18:44:05] It's fun as a first patch set, but ^d can't seriously expect this to get merged without any rationale (explaining it never worked, or maybe it worked, but we don't want to maintain it anymore?) or (if it did work and we're dropping it) some release notes probably. [18:44:10] (03PS2) 10Chad: Ehcache more like mehcache [core] - 10https://gerrit.wikimedia.org/r/107880 [18:44:39] <^d> I expected it to get merged as soon as I confirmed we didn't use it in prod anymore. [18:44:47] k [18:44:50] <^d> :) [18:45:03] You're impossible and I like you for that. [18:45:33] (03CR) 10Bartosz Dziewoński: Improve mediawiki.js documentation (031 comment) [core] - 10https://gerrit.wikimedia.org/r/107761 (owner: 10Krinkle) [18:45:47] <^d> Krinkle: I explained that mehcache is a pun :) [18:45:57] eh? [18:45:57] :) [18:49:16] (03CR) 10Krinkle: Improve mediawiki.js documentation (031 comment) [core] - 10https://gerrit.wikimedia.org/r/107761 (owner: 10Krinkle) [18:58:42] (03CR) 10Mattflaschen: [C: 04-1] "First, I think it may be good to have an eye-catching color. Not confirming your email is bad (you can't even reset your password), so we" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/94117 (owner: 10Gerrit Patch Uploader) [18:58:52] (03CR) 10Helder.wiki: Improve mediawiki.js documentation (031 comment) [core] - 10https://gerrit.wikimedia.org/r/107761 (owner: 10Krinkle) [19:02:45] ^d: does anything use DBABagOStuff.php ? [19:03:12] <^d> Heh, Tim said a long time ago it was for developers to use for testing caching but it's not suitable for any real install. [19:03:34] <^d> But I think CACHE_DB makes a better test, if memcached is too much of a burden for testing. [19:04:06] (03CR) 10Mattflaschen: "Actually, you might not need to confirm your email to reset the password (see the bug). However, if it's mistyped, you might not know unt" [core] - 10https://gerrit.wikimedia.org/r/94117 (owner: 10Gerrit Patch Uploader) [19:05:21] ^d: so that could die too [19:05:31] <^d> I think so, yeah [19:05:52] gwicke: it's too bad...ecache uses a nice RESTful interface ;) [19:05:56] *ehcache [19:06:04] !log reedy rebuilt wikiversions.cdb and synchronized wikiversions files: wikipedias to 1.23wmf10 [19:06:05] Wrong channel, try again. [19:06:08] jgonera, the TDD hangout is full. Is that being streamed or recorded? [19:06:11] * AaronSchulz is trying to find the list of problems we had with it [19:06:24] I know one was that if a lot of stuff expired at once it just fell over [19:07:02] superm401, yes, Chip is setting up a new hangout so that we can record it [19:07:09] jgonera, great, thanks. [19:07:44] (03CR) 10Anomie: API: Add prop=redirects and list=allredirects (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104764 (owner: 10Anomie) [19:09:41] superm401, https://etherpad.wikimedia.org/p/currentmeeting [19:10:51] Thanks, jgonera [19:11:21] jgonera: do you guys always meet on currentmeeting and then move the notes elsewhere? [19:11:32] that is brilliant [19:13:32] !log reedy rebuilt wikiversions.cdb and synchronized wikiversions files: testwiki, testwiki, testwikidatawiki and mediawikiwiki to 1.23wmf11 [19:13:33] Wrong channel, try again. [19:22:39] !log reedy synchronized database lists files: [19:22:39] Wrong channel, try again. [19:24:41] heh [19:30:09] !log reedy synchronized wmf-config/ [19:30:09] Wrong channel, try again. [19:31:15] (03CR) 10Aarcos: "I am surprised that this moderately complex piece of code doesn't come with a "single" unit test. The more when this will become part of a" [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [19:33:43] (03PS1) 10Chad: Remove DBABagOStuff [core] - 10https://gerrit.wikimedia.org/r/107891 [19:33:47] <^d> AaronSchulz: ^ [19:35:33] ^d: <3 [19:35:37] "Ehcache more like mehcache" [19:35:52] <^d> Krinkle didn't like my pun :( [19:36:29] Krinkle is too serious [19:36:50] <^d> Omg, duh. [19:36:55] <^d> I should make you review my LQT changes. [19:36:57] <^d> Since you're here. [19:36:58] <^d> :D [19:37:08] ^d: Pretty sure I'm writing code at the moment to convert LQT pages to Flow [19:37:14] so we can just let it die anyway [19:37:42] <^d> In which case I'll have to redo what I did for LQT but for Flow. [19:37:49] <^d> I imagine. [19:37:53] what was it? [19:38:35] <^d> Let LQT modify the page schema so I can index stuff about discussions :) [19:38:39] <^d> But maybe it's not needed? [19:39:02] <^d> Roughly, this was the start: https://gerrit.wikimedia.org/r/#/c/105220/1/classes/Hooks.php [19:39:23] (03CR) 10Aaron Schulz: [C: 032] Ehcache more like mehcache [core] - 10https://gerrit.wikimedia.org/r/107880 (owner: 10Chad) [19:39:33] (03PS2) 10Aaron Schulz: Remove DBABagOStuff [core] - 10https://gerrit.wikimedia.org/r/107891 (owner: 10Chad) [19:40:23] <^d> Ugh. [19:40:26] <^d> Don't merge the second one. [19:40:29] <^d> AaronSchulz: ^ [19:40:32] <^d> I left one thing. [19:41:07] (03PS1) 10Inchikutty: Embedding Static Map to UploadWizard( part of OPW round 7 Project) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 [19:42:26] (03CR) 10Reedy: "https://bugzilla.wikimedia.org/show_bug.cgi?id=60145" [core] - 10https://gerrit.wikimedia.org/r/106489 (owner: 10PleaseStand) [19:43:13] (03Merged) 10jenkins-bot: Ehcache more like mehcache [core] - 10https://gerrit.wikimedia.org/r/107880 (owner: 10Chad) [19:43:26] (03PS3) 10Chad: Remove DBABagOStuff [core] - 10https://gerrit.wikimedia.org/r/107891 [19:44:12] ^d: Oh, it's search related [19:44:13] (03PS4) 10Chad: Remove DBABagOStuff [core] - 10https://gerrit.wikimedia.org/r/107891 [19:44:19] <^d> werdna: Yuppp :) [19:44:23] I thought you meant "index" in the SQL sense [19:44:28] <^d> You thought I was just generally caring about LQT? :p [19:44:44] yeah, fair :p [19:45:13] <^d> werdna: Anyway, we need to talk while you're here I think :) [19:45:21] <^d> Want to make sure we're doing things right for search + Flow [19:45:42] Reedy, I guess you need agreement from all previous committers to merge those new COPYING files? [19:45:53] Krenair: Not really [19:45:59] ... how not? [19:46:02] I only did ones that were headered with GPL [19:46:09] Any with no headers I left for the moment [19:46:12] ahh, I see [19:46:17] And skipped the MIT ones for the moment [19:46:19] (03PS2) 10Aaron Schulz: Added concurrent HEAD request support for Swift [core] - 10https://gerrit.wikimedia.org/r/107759 [19:46:38] ^d: we should also talk, like, in general [19:47:04] <^d> :) [19:48:37] (03CR) 10Aaron Schulz: [C: 032] Remove DBABagOStuff [core] - 10https://gerrit.wikimedia.org/r/107891 (owner: 10Chad) [19:51:48] (03Merged) 10jenkins-bot: Remove DBABagOStuff [core] - 10https://gerrit.wikimedia.org/r/107891 (owner: 10Chad) [19:58:08] (03PS3) 10Aaron Schulz: Added concurrent HEAD request support for Swift [core] - 10https://gerrit.wikimedia.org/r/107759 [19:59:28] Reedy: thanks for deploying my config change [20:04:14] gwicke: finally got around to https://gerrit.wikimedia.org/r/#/c/107759/3 [20:04:29] (03PS1) 10Hoo man: Make LuaEngineTestBase easier reusable [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107895 [20:05:03] AaronSchulz, awesome [20:05:09] James_F: does VE have a minimum mw version it is committed to supporting? [20:05:13] (03CR) 10jenkins-bot: [V: 04-1] Make LuaEngineTestBase easier reusable [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107895 (owner: 10Hoo man) [20:05:27] AaronSchulz, this week and next week are pretty full for me [20:05:55] I can't promise that I'll look at it immediately [20:06:33] Krinkle: do you know, by any chance? [20:06:42] ori: Not yet, but we're looking to back-port a bunch of minor fixes from 1.23xxx to 1.22 for the 1.22.2 release if Mark and Marcus will let us, so that we can support that. [20:07:34] ori: The extension does get branched like any other, so mwext-ve@REL1_21 / mediawiki@REL1_21 and same for _22 and _23 basically. [20:07:38] * ori nods [20:07:48] thanks to both of you [20:09:26] (03PS2) 10Hoo man: Make LuaEngineTestBase easier reusable [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107895 [20:12:47] (03PS1) 10Aaron Schulz: Moved SpecialPageFactory to specialpage/ [core] - 10https://gerrit.wikimedia.org/r/107897 [20:12:54] * AaronSchulz wonders what ZhClient is [20:16:08] and why isn't ZhConversion.php under language/ or something? [20:17:08] good ZhQuestions [20:18:01] James_F: any hunch as to why provisioning VE on Vagrant now only modifies the 'Edit' tab to 'Edit source', leaving no way to edit with VE? [20:18:40] manually specifying ?veaction=edit doesn't help [20:18:58] Seems like it should almost be a .ser [20:19:18] James_F: I have $wgDefaultUserOptions['visualeditor-enable'] = 1 , $wgHiddenPrefs[] = 'visualeditor-enable'; , $wgVisualEditorNamespaces = array( NS_MAIN, NS_USER ); [20:19:29] and the page in question is NS_MAIN [20:20:06] ori: Hmm. Sounds like VE init is failing to load given the symptoms. [20:20:13] ori: Or is bailing due to browser issue? [20:20:27] What version of MW do you have? 1.23wmf2+? [20:20:40] HEAD. I may have done something dumb. Hang on. [20:21:51] ori: Does VE show up in Special:Version? [20:24:52] James_F: disregard, and in fact erase this conversation from your memory. [20:25:01] * James_F laughs. [20:25:05] What conversation? ;-) [20:25:17] VE is broken.........due to a local change I made and was about to submit. [20:25:33] just /clear and move on :P [20:25:54] Kk. :-0 [20:26:18] (03PS1) 10Aaron Schulz: Removed ZhClient; unused by core and extensions [core] - 10https://gerrit.wikimedia.org/r/107901 [20:27:45] (03CR) 10Werdna: [WIP] Auto-wrapping escaper for templates (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103317 (owner: 10EBernhardson) [20:30:02] (03CR) 10Parent5446: [C: 032] Moved SpecialPageFactory to specialpage/ [core] - 10https://gerrit.wikimedia.org/r/107897 (owner: 10Aaron Schulz) [20:33:06] (03Merged) 10jenkins-bot: Moved SpecialPageFactory to specialpage/ [core] - 10https://gerrit.wikimedia.org/r/107897 (owner: 10Aaron Schulz) [20:34:09] <^d> AaronSchulz: I wonder how many other unused things we can find :) [20:38:08] anomie: any ideas how i can do the linkclassifier things i'm doing at https://en.wikipedia.org/wiki/User:Jackmcbarn/common.js in a less hacky way, without copying and pasting your whole script? [20:38:57] (03CR) 10Chad: [C: 032] Removed ZhClient; unused by core and extensions [core] - 10https://gerrit.wikimedia.org/r/107901 (owner: 10Aaron Schulz) [20:40:10] (03PS1) 10Aaron Schulz: Avoid expensive backlink counts for info action in miser mode [core] - 10https://gerrit.wikimedia.org/r/107903 [20:42:22] (03PS1) 10Krinkle: mwext-VisualEditor-doc: Update publish and test to match new logistics [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/107905 [20:42:25] (03CR) 10jenkins-bot: [V: 04-1] mwext-VisualEditor-doc: Update publish and test to match new logistics [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/107905 (owner: 10Krinkle) [20:42:56] (03Merged) 10jenkins-bot: Removed ZhClient; unused by core and extensions [core] - 10https://gerrit.wikimedia.org/r/107901 (owner: 10Aaron Schulz) [20:43:28] (03PS2) 10Krinkle: mwext-VisualEditor-doc: Update publish and test to match new logistics [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/107905 [20:44:31] (03PS1) 10Chad: Remove commented defines [core] - 10https://gerrit.wikimedia.org/r/107906 [20:45:39] jgonera, chrismcmahon, Željko, thanks for the great TDD presentation. [20:45:51] hashar: Hm.. Looks like Jenkins or Zuul failed again weirdly for a jjb-config patch set [20:45:54] https://gerrit.wikimedia.org/r/#/c/107905/1 [20:45:59] superm401 and everyone else, thanks for participating! [20:46:01] I did a no-op edit in the commit message and that fixed it [20:46:05] Any idea? [20:46:09] I was trying to use the browsertests role. I couldn't get it working, but I'm not sure if it's my current setup or an actual bug. [20:46:12] Maybe the mirror is behind? [20:46:17] Krinkle: have a look at the Zuul log on gallium in /var/log/zuul/zuul.log [20:46:21] Will try to remember to retest with MW-Vagrant later. [20:46:27] Krinkle: might be a Gerrit error [20:46:49] thanks superm401, I have not tried the vagrant instance in some time, but I am afraid it is lagging our current setup by quite a lot. [20:47:40] chrismcmahon, :(. Yeah, for the workshop I used my host, but I would like to get MWV working again. [20:47:47] (03CR) 10jenkins-bot: [V: 04-1] Remove commented defines [core] - 10https://gerrit.wikimedia.org/r/107906 (owner: 10Chad) [20:48:02] 2014-01-16 20:42:23,174 ERROR zuul.IndependentPipelineManager: Unable to find change queue for project integration/jenkins-job-builder-config [20:48:28] 2014-01-16 20:42:23,100 INFO zuul.IndependentPipelineManager: Unable to merge change [20:48:38] 2014-01-16 20:42:23,101 INFO zuul.IndependentPipelineManager: Reporting change , actions: [, {'verified': -1}>] [20:48:43] hashar: Hm.. "unable to merge" [20:48:53] It fails to do a local merge [20:49:01] it worked the second time though [20:52:33] Krinkle: :/ Maybe the debug.log has more details [20:54:16] AssertionError: len(["7a1ef2722536f7f94c196dae62cff60d57ccf0ac\t\t'refs/changes/05/107905/1' of ssh://gerrit.wikimedia.org:29418/integration/jenkins-job-builder-config\n"]) != len(['Total 3 (delta 2), reused 3 (delta 2)', ' * branch refs/changes/05/107905/1 -> FETCH_HEAD']) [20:54:27] we have a bug around for that assertion [20:54:30] I haven't investigated it [20:54:56] Krinkle: https://bugzilla.wikimedia.org/show_bug.cgi?id=59991 :/ [20:56:36] (03PS1) 10Ori.livneh: Update UniversalLanguageSelector to master [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107911 [20:57:35] (03CR) 10Ori.livneh: [C: 032 V: 032] Update UniversalLanguageSelector to master [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107911 (owner: 10Ori.livneh) [20:59:20] ^d: I can't log in to gerrit and someone advised that I should talk to you. Mind if I PM? [20:59:47] <^d> Sure go ahead [20:59:58] hashar: oh yeah, I ran into that too with gitpython. I found out that if I repeated the same function call again, it worked fine [21:00:34] hashar: https://github.com/legoktm/afch-updater/blob/master/main.py#L53 is how I worked around it [21:00:46] !log ori synchronized php-1.23wmf10/extensions/UniversalLanguageSelector/resources/js/ext.uls.webfonts.js 'Update UniversalLanguageSelector to master for I2da436caa: Wait till rendering thread completion before applying webfonts (Bug: 59958)' [21:00:46] Wrong channel, try again. [21:01:27] @infobot-ignore+ log [21:01:27] Item log was inserted to ignore list [21:02:12] ^d: https://gerrit.wikimedia.org/r/107903 [21:02:42] <^d> !log [21:02:50] <^d> ori: Make the bot ignore the other bot. [21:02:53] <^d> I want my warnings. [21:03:28] I don't run wm-bot, and the docs don't indicate that it has this capability [21:03:37] (03CR) 10Chad: [C: 032] Avoid expensive backlink counts for info action in miser mode [core] - 10https://gerrit.wikimedia.org/r/107903 (owner: 10Aaron Schulz) [21:04:09] <^d> ori: Then take logmsgbot out of here? Status quo was fine :\ [21:04:33] I wonder why those ApiQueryExtLinksUsage::run query are slow sometimes [21:04:53] it takes a puppet commit, a run on neon, and a service restart. seriously, you're going to throw a tantrum over this? [21:05:37] <^d> Who's throwing a tantrum? [21:06:33] (03CR) 10Hashar: [C: 032] jobs for labs/migration [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/107914 (owner: 10Hashar) [21:06:53] (03Merged) 10jenkins-bot: Avoid expensive backlink counts for info action in miser mode [core] - 10https://gerrit.wikimedia.org/r/107903 (owner: 10Aaron Schulz) [21:07:04] (03Merged) 10jenkins-bot: jobs for labs/migration [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/107914 (owner: 10Hashar) [21:07:04] do what you like, I won't argue [21:13:15] (03PS1) 10Hashar: jobs for labs/migration [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/107917 [21:13:27] (03CR) 10Hashar: [C: 032] jobs for labs/migration [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/107917 (owner: 10Hashar) [21:13:31] (03Merged) 10jenkins-bot: jobs for labs/migration [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/107917 (owner: 10Hashar) [21:21:37] (03CR) 10Matthias Mullie: [C: 031] "The patch looks fine." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106449 (owner: 10EBernhardson) [21:22:10] (03PS1) 10Hashar: labs-migration-assistant-pep8 is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/107918 [21:22:20] (03CR) 10Hashar: [C: 032] labs-migration-assistant-pep8 is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/107918 (owner: 10Hashar) [21:22:24] (03Merged) 10jenkins-bot: labs-migration-assistant-pep8 is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/107918 (owner: 10Hashar) [21:22:31] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/107907/ is easy [21:22:43] ori: Yeah already seen and in my queue [21:22:48] cool, thanks [21:23:00] Thanks for implementing it so quickly :) [21:25:12] (03CR) 10Kaldari: Story 1604: Remember mobile thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107633 (owner: 10Kaldari) [21:27:13] ori: Looks fine but please do put in the conditional to see if mw.track is defined [21:27:37] b/c isn't essential but we strive to keep it where we reasonably can, especially in cases where it's super easy like here [21:28:25] RoanKattouw: OK. What about the namespacing ('ve.')? [21:29:00] does that look right or should be it 'visualEditor'? 'ext.visualEditor.[topic]' might be misleading because that convention is used for file names. [21:30:32] (03CR) 10Werdna: "Looks fine in principle. Haven't reviewed extensively." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103064 (owner: 10EBernhardson) [21:31:10] ori: ve. is fine with me [21:31:52] * ori nods. [21:34:00] (03PS3) 10Krinkle: mwext-VisualEditor-doc: Update publish and test to match new logistics [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/107905 [21:35:47] (03CR) 10MZMcBride: "I completely agree with Siebrand that the commit message could have (and in my opinion, should have) been much better." [core] - 10https://gerrit.wikimedia.org/r/105871 (owner: 10Chad) [21:36:10] (03CR) 10Krinkle: [C: 032] "Pushed mwext-VisualEditor-doc-publish and mwext-VisualEditor-doc-test." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/107905 (owner: 10Krinkle) [21:36:26] (03Merged) 10jenkins-bot: mwext-VisualEditor-doc: Update publish and test to match new logistics [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/107905 (owner: 10Krinkle) [21:38:58] (03PS13) 10MarkTraceur: Create jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [21:39:01] (03CR) 10Aarcos: [C: 04-1] Propagate the favicon information to getInfo() for local repos (031 comment) [core] - 10https://gerrit.wikimedia.org/r/107712 (owner: 10Gergő Tisza) [21:46:43] (03CR) 10Gergő Tisza: Create jquery.fullscreen (033 comments) [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [21:46:50] (03CR) 10Theopolisme: "@Aarcos: this is "actually" an external library (yeah I know, it's a fine line ;) ), so presumably the tests should be hosted on github. I" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [21:48:38] (03CR) 10Gergő Tisza: "Aarcos: it certainly should have tests but that should be done upstream ( https://github.com/theopolisme/jquery-fullscreen ); we don't nor" [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [21:52:48] (03CR) 10Theopolisme: Create jquery.fullscreen (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [21:54:18] ^d: where did we get to with https://gerrit.wikimedia.org/r/#/c/74678 ? [21:54:50] <^d> I hadn't thought about it in ages. [21:55:05] <^d> There's going to be a config track at the architecture summit next week. [21:55:10] It was waiting on the config DB RfC to be completed and implemented right? [21:55:10] <^d> I suppose I'll poke my head in that. [21:55:24] <^d> One of the like 3 competing RfCs, yeah :p [21:55:32] There's going to be a track for that? [21:55:44] I read the schedule earlier and was disappointed that it wasn't on there :/ [21:55:51] (03CR) 10BryanDavis: "I think this could use some test cases in IPTest::provideToUnsigned(). Otherwise it looks like it should work." [core] - 10https://gerrit.wikimedia.org/r/107543 (owner: 10Aaron Schulz) [21:56:37] <^d> Krenair: I think Diederik responded to that. [21:57:16] <^d> http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/74837 [21:58:08] <^d> :) [21:58:54] Ah yes, I see [21:59:07] (I hadn't read the replies yet) [21:59:09] thanks legoktm [21:59:15] :) [21:59:28] I had a wtf reaction when I read his original email :P [22:00:32] ^d: any idea how far we're going with decisions at the summit? i.e. will things end up getting approved there? [22:01:27] <^d> Dunno. I think it depends on the RfC and how much consensus there is. [22:01:41] <^d> Some of them might make sense to start rubber stamping...all we needed was the right people in the room to discuss it. [22:01:53] <^d> I imagine lots will get discussed and then asked to revise. [22:02:15] (03CR) 10Alex Monk: "Current status: We're waiting for a proper configuration DB system to be implemented, which should hopefully be discussed at the Architect" [core] - 10https://gerrit.wikimedia.org/r/74678 (owner: 10Alex Monk) [22:02:36] (03CR) 10Gergő Tisza: Create jquery.fullscreen (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [22:05:17] (03CR) 10Alex Monk: "consider allowing adding/removing of groups" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/74678 (owner: 10Alex Monk) [22:28:30] (03CR) 10Werdna: "Nice to see the API get into a nicer shape." (0311 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 (owner: 10Legoktm) [22:29:27] (03CR) 10Werdna: [C: 031] Properly handle exceptions in flow-parsoid-utils [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107749 (owner: 10Legoktm) [22:34:03] (03CR) 10Werdna: [C: 032] ApiParsoidUtils: Handle the page not existing nicely [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107750 (owner: 10Legoktm) [22:34:07] (03PS2) 10Inchikutty: Embedding Static Map to UploadWizard( part of OPW round 7 Project) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107892 [22:35:32] (03CR) 10Werdna: [C: 032] Fix issues on clicking "x comments" link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105123 (owner: 10Bsitu) [22:35:39] (03Merged) 10jenkins-bot: Fix issues on clicking "x comments" link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105123 (owner: 10Bsitu) [22:42:09] (03CR) 10Werdna: refs 58880 - Implement better scrolling via conditionalScroll Refactor ui.js to a cleaner and simpler format (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 (owner: 10SG) [22:46:57] (03CR) 10Werdna: [C: 032] "I am pretty sure that this is okay." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106688 (owner: 10Matthias Mullie) [22:47:03] (03Merged) 10jenkins-bot: Add more AbuseFilter vars [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106688 (owner: 10Matthias Mullie) [22:51:47] (03CR) 10Werdna: [C: 032] Cache requested workflows in UrlGenerator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106475 (owner: 10EBernhardson) [22:51:53] (03Merged) 10jenkins-bot: Cache requested workflows in UrlGenerator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106475 (owner: 10EBernhardson) [22:52:46] (03CR) 10Werdna: [C: 032] Fix leftover user_text occurrences [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106512 (owner: 10Matthias Mullie) [22:52:49] (03CR) 10jenkins-bot: [V: 04-1] Fix leftover user_text occurrences [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106512 (owner: 10Matthias Mullie) [22:54:03] (03PS2) 10Werdna: Fix leftover user_text occurrences [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106512 (owner: 10Matthias Mullie) [22:54:25] (03CR) 10Werdna: [C: 032] Fix leftover user_text occurrences [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106512 (owner: 10Matthias Mullie) [22:54:31] (03Merged) 10jenkins-bot: Fix leftover user_text occurrences [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106512 (owner: 10Matthias Mullie) [23:00:01] (03CR) 10Werdna: "A few formatting issues. Otherwise looks fine (but untested)" (039 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105873 (owner: 10Bsitu) [23:02:05] (03CR) 10Werdna: [C: 032] Immediately trigger new scroll event after adding infinite scoll content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106249 (owner: 10Matthias Mullie) [23:02:10] (03Merged) 10jenkins-bot: Immediately trigger new scroll event after adding infinite scoll content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106249 (owner: 10Matthias Mullie) [23:03:33] (03CR) 10Werdna: [C: 032] Call flow-init on correct element [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106514 (owner: 10Matthias Mullie) [23:03:39] (03Merged) 10jenkins-bot: Call flow-init on correct element [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106514 (owner: 10Matthias Mullie) [23:05:05] (03CR) 10Werdna: [C: 032] Fix fatal from exception, and improve its message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106869 (owner: 10Spage) [23:05:10] (03Merged) 10jenkins-bot: Fix fatal from exception, and improve its message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106869 (owner: 10Spage) [23:05:39] (03PS1) 10Chad: Split cirrusSearchLinksUpdate into two jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107927 [23:11:04] (03PS2) 10Aaron Schulz: Workaround ip2long limitation [core] - 10https://gerrit.wikimedia.org/r/107543 [23:11:08] (03PS2) 10Chad: Split cirrusSearchLinksUpdate into two jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107927 [23:24:29] (03PS1) 10Eranroz: Make Popularpages includeable [core] - 10https://gerrit.wikimedia.org/r/107979 [23:26:49] (03CR) 10Bsitu: [C: 04-2] "There are some more tweaks coming!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu) [23:28:28] (03PS2) 10Eranroz: Make Popularpages includeable [core] - 10https://gerrit.wikimedia.org/r/107979 [23:35:10] (03PS1) 10Chad: Clean up RevisionDelete hook to use LinksUpdate code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107983 [23:37:01] (03CR) 10Werdna: "Looks good, one small comment + a few things S mentioned." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106449 (owner: 10EBernhardson) [23:37:38] ^d: I hear there's a bug open to replace bugzilla [23:40:13] (03CR) 10MarkTraceur: [C: 04-1] "Concurring with Aaron but otherwise this is good." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/107712 (owner: 10Gergő Tisza) [23:41:22] (03CR) 10Werdna: [C: 031] "I would actually say just merge this patch with the upstream." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106466 (owner: 10EBernhardson) [23:45:03] (03PS10) 10Jforrester: Add OOJS UI v0.1.0-pre (da9ec955a8) to core [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [23:46:31] (03CR) 10jenkins-bot: [V: 04-1] Add OOJS UI v0.1.0-pre (da9ec955a8) to core [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [23:49:09] (03PS1) 10Chad: Rename UpdatePagesJob -> MassIndexJob [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107987 [23:55:53] <^d> AaronSchulz: That whole chain of changes (ending in 107987) should make things a lot more clear. [23:57:05] <^d> LinksUpdate(Prioritized) jobs are what tag onto core's LinksUpdate and are generally responsible for page updates. LinksUpdateSecondary are just the link count updates that come after, then we'll rename UpdatePagesJob to MassIndexJob because it's only used during mass indexing now and the name sucks. [23:57:58] <^d> manybubbles|away: Also ^ [23:59:14] (03CR) 10Manybubbles: Rename UpdatePagesJob -> MassIndexJob (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107987 (owner: 10Chad) [23:59:19] (03CR) 10Manybubbles: Split cirrusSearchLinksUpdate into two jobs (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107927 (owner: 10Chad)