[00:02:16] (03CR) 10Alex Monk: "new patch set coming" (036 comments) [core] - 10https://gerrit.wikimedia.org/r/36330 (owner: 10Alex Monk) [00:03:02] (03PS11) 10Ori.livneh: SpecialWatchlist: Split #execute into subfunctions like SpecialRecentChanges [core] - 10https://gerrit.wikimedia.org/r/94677 (owner: 10Bartosz Dziewoński) [00:03:06] (03CR) 10Ori.livneh: [C: 032] SpecialWatchlist: Split #execute into subfunctions like SpecialRecentChanges [core] - 10https://gerrit.wikimedia.org/r/94677 (owner: 10Bartosz Dziewoński) [00:04:32] (03CR) 10Ori.livneh: [C: 04-1] "Small nitpick" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97451 (owner: 10Bartosz Dziewoński) [00:05:03] (03PS22) 10Alex Monk: Cross-wiki user rights UI should show target wiki groups instead of local [core] - 10https://gerrit.wikimedia.org/r/36330 [00:05:08] hoo, well we can't remove the test just because jenkins doesn't run a web server [00:05:36] (03CR) 10Bartosz Dziewoński: Always load 'mediawiki.special.changeslist' on appropriate pages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97451 (owner: 10Bartosz Dziewoński) [00:05:39] ori: ^ [00:06:00] Krenair: You can hack around it if you skip the test in case no web server is enabled [00:06:13] (03CR) 10Bartosz Dziewoński: "Fixed in https://gerrit.wikimedia.org/r/#/c/103197/7/includes/specialpage/ChangesListSpecialPage.php" [core] - 10https://gerrit.wikimedia.org/r/97451 (owner: 10Bartosz Dziewoński) [00:06:36] usually you would try to Mock the http request away, but we're in global state paradise so that's impossible [00:07:06] (03CR) 10Bartosz Dziewoński: "Actually, even in https://gerrit.wikimedia.org/r/#/c/102458/10 . But that's fixed later anyway." [core] - 10https://gerrit.wikimedia.org/r/97451 (owner: 10Bartosz Dziewoński) [00:07:14] hoo, is there an easy way to check for the web server being on, without firing an http request at it? [00:07:20] ori: ^ [00:07:28] (03CR) 10Gergő Tisza: [C: 032] Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [00:07:31] (03PS11) 10Ori.livneh: Always load 'mediawiki.special.changeslist' on appropriate pages [core] - 10https://gerrit.wikimedia.org/r/97451 (owner: 10Bartosz Dziewoński) [00:07:43] (03CR) 10Ori.livneh: [C: 032] "this changes is fine, then" [core] - 10https://gerrit.wikimedia.org/r/97451 (owner: 10Bartosz Dziewoński) [00:08:06] Krenair: Not really... you could check the port or so... but that sounds even more evil [00:08:13] english is my second language too. i am allowed to crack jokes [00:08:16] (03Merged) 10jenkins-bot: SpecialWatchlist: Split #execute into subfunctions like SpecialRecentChanges [core] - 10https://gerrit.wikimedia.org/r/94677 (owner: 10Bartosz Dziewoński) [00:08:20] (03Merged) 10jenkins-bot: Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [00:08:53] ;) [00:08:57] thanks [00:08:58] (03CR) 10jenkins-bot: [V: 04-1] Cross-wiki user rights UI should show target wiki groups instead of local [core] - 10https://gerrit.wikimedia.org/r/36330 (owner: 10Alex Monk) [00:09:12] How can jenkins even count as a valid test environment if it doesn't have a web server? Seriously? [00:09:59] (03PS1) 10BryanDavis: Bundle vagrant-vbguest plugin [vagrant] - 10https://gerrit.wikimedia.org/r/107518 [00:10:10] Krenair: uhm... Travis also doesn't have a webserver... I always run my tests w/o a webserver (in a VM) [00:10:15] bd808: wooooo [00:10:21] These are UNIT tests, not integration ones [00:10:45] ori: It seems to be working for me. See what you think. [00:10:52] (03CR) 10GWicke: Add Reference to relevant bug in new MSIE 6 CSS sanitization tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106160 (owner: 10GWicke) [00:10:53] but you are moreover trying to build an integration one which our Jenkins setup doesn't really fit for [00:11:01] bd808: yep, testing. this looks awesome. [00:11:11] (03PS2) 10Gergő Tisza: Add vagrant support for running the UploadWizard smoke tests [vagrant] - 10https://gerrit.wikimedia.org/r/107429 [00:11:13] (03CR) 10jenkins-bot: [V: 04-1] Add vagrant support for running the UploadWizard smoke tests [vagrant] - 10https://gerrit.wikimedia.org/r/107429 (owner: 10Gergő Tisza) [00:11:33] (03PS2) 10GWicke: Add Reference to relevant bug in new MSIE 6 CSS sanitization tests [core] - 10https://gerrit.wikimedia.org/r/106160 [00:12:18] (03CR) 10Gergő Tisza: "Added workaround." [vagrant] - 10https://gerrit.wikimedia.org/r/107429 (owner: 10Gergő Tisza) [00:12:20] (03CR) 10jenkins-bot: [V: 04-1] Add Reference to relevant bug in new MSIE 6 CSS sanitization tests [core] - 10https://gerrit.wikimedia.org/r/106160 (owner: 10GWicke) [00:12:22] (03Merged) 10jenkins-bot: Always load 'mediawiki.special.changeslist' on appropriate pages [core] - 10https://gerrit.wikimedia.org/r/97451 (owner: 10Bartosz Dziewoński) [00:12:50] (03CR) 10CSteipp: "Minor note in case we run into performance issues later on. I don't think it should prevent merging." (031 comment) [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 (owner: 10Alex Monk) [00:13:55] csteipp, I seriously suggest giving that script a LOT of testing before merging [00:13:56] (03PS3) 10Gergő Tisza: Add vagrant support for running the UploadWizard smoke tests [vagrant] - 10https://gerrit.wikimedia.org/r/107429 [00:14:21] particularly in cases involving records to calculate rev_parent_id being all over the place (e.g. other tables) [00:15:00] (03CR) 10Gergő Tisza: "(rebased)" [vagrant] - 10https://gerrit.wikimedia.org/r/107429 (owner: 10Gergő Tisza) [00:15:40] (03CR) 10Hoo man: [C: 04-1] "Didn't test, but this at least needs some documentation (in the UI). Also you should apply trim to the filter ids so that a list like "1, " [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105617 (owner: 10Jackmcbarn) [00:15:57] (03PS7) 10Mattflaschen: Remove uses of Special:GettingStarted from task toolbar [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103740 [00:16:27] (03PS5) 10Mattflaschen: Remove Special:GettingStarted and notifications [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/106458 [00:17:31] (03CR) 10Ori.livneh: [C: 04-1] "Cool, looks good. The pip package provider will query the Python package index on each Puppet run unless a specified version is specified," [vagrant] - 10https://gerrit.wikimedia.org/r/107429 (owner: 10Gergő Tisza) [00:17:45] *unless a version is specified [00:17:49] (03CR) 10BryanDavis: Bundle vagrant-vbguest plugin (033 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/107518 (owner: 10BryanDavis) [00:18:41] (03CR) 10Hoo man: [C: 032] "I'm fine with this... it's not hard to just remove/fix the title field in case it's invalid so this isn't really an UI issue." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105424 (owner: 10Jackmcbarn) [00:18:50] (03Merged) 10jenkins-bot: Prevent fatal error in Special:AbuseFilter/test [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105424 (owner: 10Jackmcbarn) [00:22:10] (03CR) 10Ori.livneh: Bundle vagrant-vbguest plugin (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/107518 (owner: 10BryanDavis) [00:22:12] (03PS4) 10Gergő Tisza: Add vagrant support for running the UploadWizard smoke tests [vagrant] - 10https://gerrit.wikimedia.org/r/107429 [00:22:38] (03PS3) 10GWicke: Add Reference to relevant bug in new MSIE 6 CSS sanitization tests [core] - 10https://gerrit.wikimedia.org/r/106160 [00:22:40] (03PS1) 10Chad: Two fixups to SearchResult [core] - 10https://gerrit.wikimedia.org/r/107520 [00:22:52] <^d> AaronSchulz: ^ [00:23:12] (03CR) 10GWicke: "rebased." [core] - 10https://gerrit.wikimedia.org/r/106160 (owner: 10GWicke) [00:26:23] (03CR) 10Subramanya Sastry: [C: 032] Add Reference to relevant bug in new MSIE 6 CSS sanitization tests [core] - 10https://gerrit.wikimedia.org/r/106160 (owner: 10GWicke) [00:28:39] (03CR) 10Ori.livneh: [C: 04-1] "one last tiny thing, sorry :)" (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/107429 (owner: 10Gergő Tisza) [00:29:17] (03Merged) 10jenkins-bot: Add Reference to relevant bug in new MSIE 6 CSS sanitization tests [core] - 10https://gerrit.wikimedia.org/r/106160 (owner: 10GWicke) [00:31:41] (03CR) 10PleaseStand: "I should have split off the incomplete MariaDB / Percona detection, so it would not have been merged and backported. At least it is not us" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/106489 (owner: 10PleaseStand) [00:35:52] (03CR) 10CSteipp: [C: 04-1] Moved account creation throttle to ping limiter (031 comment) [core] - 10https://gerrit.wikimedia.org/r/65867 (owner: 10Parent5446) [00:35:57] (03CR) 10Aaron Schulz: [C: 032] Two fixups to SearchResult [core] - 10https://gerrit.wikimedia.org/r/107520 (owner: 10Chad) [00:36:56] (03CR) 10JGonera: [C: 04-1] "Just a few minor comments, other than that looks good." (035 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103737 (owner: 10Mattflaschen) [00:38:13] (03CR) 10CSteipp: "I hate to do this, but it would be nicer if the units were in ()'s. On first reading, I thought you were asking a question in the comment." [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/106858 (owner: 10Mattflaschen) [00:39:15] (03Merged) 10jenkins-bot: Two fixups to SearchResult [core] - 10https://gerrit.wikimedia.org/r/107520 (owner: 10Chad) [00:40:13] (03PS2) 10BryanDavis: Bundle vagrant-vbguest plugin [vagrant] - 10https://gerrit.wikimedia.org/r/107518 [00:41:20] what is Gergő Tisza's IRC nick? [00:42:08] (03PS5) 10Ori.livneh: Add vagrant support for running the UploadWizard smoke tests [vagrant] - 10https://gerrit.wikimedia.org/r/107429 (owner: 10Gergő Tisza) [00:42:32] (03CR) 10Ori.livneh: [C: 032] "Made a couple of small tweaks. Seems to work. Thanks!" [vagrant] - 10https://gerrit.wikimedia.org/r/107429 (owner: 10Gergő Tisza) [00:42:34] (03Merged) 10jenkins-bot: Add vagrant support for running the UploadWizard smoke tests [vagrant] - 10https://gerrit.wikimedia.org/r/107429 (owner: 10Gergő Tisza) [00:43:08] bd808: fancy [00:43:56] ori: Gergo's nick is tgr [00:44:23] tgr: oh! hey. sorry. i didn't want to annoy you with small lint issues so i made a couple of small tweaks to the patch before merging [00:45:23] Heh. I remember trying to get my first vagrant puppet patches past you. Brutal. [00:45:31] ori, i am thankful that someone tells me how to do puppet properly :) [00:45:47] my experience is mostly limited to googling one-liners [00:46:23] tgr: the packages:: thing is a mediawiki-vagrant-specific hack that we settled on as the least-evil approach to different optional roles requiring the same packages [00:51:03] ori: yeah, that's explained well in packages.pp [00:51:37] i didn't use it because there is a comment saying packages there should not have parameters [00:51:55] but i probably just misunderstood what a parameter means in puppet [00:52:38] (03PS2) 10Jdlrobson: Fix image paths [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107513 [00:52:40] (03PS1) 10Jdlrobson: WIP: Add Fixed header experiment to Vector Beta [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107523 [00:53:16] (03PS3) 10Ori.livneh: Bundle vagrant-vbguest plugin [vagrant] - 10https://gerrit.wikimedia.org/r/107518 (owner: 10BryanDavis) [00:54:16] (03PS4) 10Ori.livneh: Bundle vagrant-vbguest plugin [vagrant] - 10https://gerrit.wikimedia.org/r/107518 (owner: 10BryanDavis) [00:54:22] (03CR) 10Ori.livneh: [C: 032] "Woot! This is awesome." [vagrant] - 10https://gerrit.wikimedia.org/r/107518 (owner: 10BryanDavis) [00:54:25] (03Merged) 10jenkins-bot: Bundle vagrant-vbguest plugin [vagrant] - 10https://gerrit.wikimedia.org/r/107518 (owner: 10BryanDavis) [01:00:15] (03PS1) 10Gergő Tisza: PIL package fixes [vagrant] - 10https://gerrit.wikimedia.org/r/107524 [01:00:44] (03CR) 10Ori.livneh: [C: 032] PIL package fixes [vagrant] - 10https://gerrit.wikimedia.org/r/107524 (owner: 10Gergő Tisza) [01:00:47] (03Merged) 10jenkins-bot: PIL package fixes [vagrant] - 10https://gerrit.wikimedia.org/r/107524 (owner: 10Gergő Tisza) [01:01:25] (03CR) 10Gergő Tisza: "PIL still seems to be reinstalled on every puppet run:" [vagrant] - 10https://gerrit.wikimedia.org/r/107524 (owner: 10Gergő Tisza) [01:03:56] (03PS1) 10Ori.livneh: Add AUTHORS.txt [vagrant] - 10https://gerrit.wikimedia.org/r/107527 [01:05:55] (03CR) 10EBernhardson: "Unless there is a complaint, will switch getPretty to getAlphaDecimal" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 (owner: 10EBernhardson) [01:06:44] (03CR) 10Aaron Schulz: [C: 031] Add protectionLevels variable to mw.title output [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107046 (owner: 10Jackmcbarn) [01:06:48] (03CR) 10Legoktm: WIP: Add Fixed header experiment to Vector Beta (032 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107523 (owner: 10Jdlrobson) [01:07:03] (03CR) 10preilly: [C: 031] Add AUTHORS.txt [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [01:07:51] (03CR) 10Ori.livneh: "Reviewers, please let me know if you wish to be excluded or if you would like to appear under a different name or e-mail address. I will m" [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [01:08:52] (03CR) 10Aaron Schulz: [C: 032] Allow SearchResults to specify that they matched file content [core] - 10https://gerrit.wikimedia.org/r/105234 (owner: 10Chad) [01:09:25] (03CR) 10jenkins-bot: [V: 04-1] Allow SearchResults to specify that they matched file content [core] - 10https://gerrit.wikimedia.org/r/105234 (owner: 10Chad) [01:10:13] (03CR) 10MZMcBride: "What's the (intended) sort order?" [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [01:10:51] (03CR) 10Jdlrobson: [C: 04-2] "I should have made clear this was mashed up in a 30mins session and is nowhere near ready for code review." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107523 (owner: 10Jdlrobson) [01:11:02] (03CR) 10Ori.livneh: ""Nearly-alphabetical". I goofed. Because there are so many reviewers, though, I'll just wait until it's ready to merge before re-sorting." [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [01:12:09] What's the proper way to make tests for stuff that requires MediaWiki to be run by a web server? [01:12:18] (03CR) 10MarkTraceur: [C: 031] Add AUTHORS.txt [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [01:12:24] (03CR) 10Diederik: [C: 031] Add AUTHORS.txt [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [01:13:07] Krenair: there's a repository of selenium tests, IIRC [01:13:30] chrismcmahonafk, zeljkof ^ see Krenair's question [01:13:33] (03CR) 10BryanDavis: Add AUTHORS.txt (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [01:13:44] ori, from the server side (php) [01:14:05] what is the dependency, exactly? [01:14:11] (03CR) 10Parent5446: [C: 031] "I mean, I don't mind being included, but I kind of only contributed one line to this entire project. :P" [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [01:14:25] probably use test doubles to mock/stub the dependency [01:14:30] ori, My test does not work when MediaWiki is not accessible via HTTP [01:15:19] Krenair: see https://github.com/wikimedia/mediawiki-extensions-EventLogging/blob/master/tests/RemoteSchemaTest.php#L43 [01:15:42] and the class it tests, https://github.com/wikimedia/mediawiki-extensions-EventLogging/blob/master/includes/RemoteSchema.php#L32 [01:15:59] $this->http = $http ?: new Http(); [01:16:26] Stub all the things! [01:17:14] the key line being '$this->http = $http ?: new Http();' in the constructor [01:17:41] the pattern is called 'dependency injection' [01:17:55] ... Yeah I'm completely lost now. [01:18:25] (03CR) 10CSteipp: "In testing this, I noticed that when resetting as an anonymous users (so you reset and login), the success page doesn't look like the user" [core] - 10https://gerrit.wikimedia.org/r/106218 (owner: 10Parent5446) [01:18:26] basically phpunit gives you a simple api for creating classes on the fly that have methods that return certain values [01:18:53] I don't want to check what methods are being called on an object [01:18:57] rather than hard-coding mediawiki's 'Http' class, you allow an alternate implementation to be speciied as a parameter to the constructor [01:19:02] I want to check to see whether MediaWiki can be accessed via HTTP or not [01:20:24] you don't have to use the test double (the fake Http object) to express test expectations; you can just rig it to return certain values in response to certain method calls, in order to get your test to work when you're not running as a server. [01:20:28] what are you actually *testing*? [01:20:31] The issue is this failure: MWException: Failed to make HTTP request to /wiki/api.php?format=json&action=query&meta=siteinfo&siprop=usergroups for foreign user groups [01:20:53] However, if there is no web server to connect to, there is no way to test this, so the test should be skipped [01:20:56] you might just want to skip the test [01:20:57] yeah [01:21:03] (03CR) 10Adamw: "My changes haven't been merged to master, so I should only be in the AUTHORS.txt on that branch :p" [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [01:21:51] if (/* not reachable */) { $this->markTestSkipped('This test requires that MediaWiki be accessible via HTTP.'); } [01:22:36] ori: https://gerrit.wikimedia.org/r/#/c/107498/ [01:22:49] ori, so I'll just have to send a request to see if it's there or not? [01:22:51] is there actually a way to invoke the phpunit tests in the context of a web request? [01:22:53] Ugh. This entire situation is ridiculous. [01:23:02] well, again [01:23:05] what are you *actually* testing? [01:23:49] https://gerrit.wikimedia.org/r/#/c/36330/22/tests/phpunit/includes/UserTest.php [01:24:04] AaronSchulz: i can merge, but springle is around -- better to ping him, no? (springle, this is https://gerrit.wikimedia.org/r/#/c/107498/) [01:24:15] This is working perfectly on my machine. Jenkins is not so happy [01:25:35] ori: I merged it and then was like "oh...wait" [01:25:50] (03CR) 10Gergő Tisza: [C: 031] Add AUTHORS.txt [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [01:25:55] (03CR) 10Matthias Mullie: "Please do! I didn't like "pretty" as term, but lacked a better alternative." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 (owner: 10EBernhardson) [01:26:04] (03PS2) 10Ori.livneh: Revert "SpecialContributions: Avoid using 'contributions' slave for getParentLengths" [core] - 10https://gerrit.wikimedia.org/r/107498 (owner: 10Aaron Schulz) [01:26:07] (03CR) 10Ori.livneh: [C: 032] Revert "SpecialContributions: Avoid using 'contributions' slave for getParentLengths" [core] - 10https://gerrit.wikimedia.org/r/107498 (owner: 10Aaron Schulz) [01:26:41] Krenair: it's a bad test, because localhost/wiki is not necessarily the same [01:27:00] ori, what? [01:27:09] you should be testing the code that you are running, not the code that a remote host is running [01:27:32] But that's exactly what I'm doing... [01:27:41] (03CR) 10EBernhardson: [C: 031] Add AUTHORS.txt [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [01:28:30] Are we having a C1 party? [01:28:32] (03PS1) 10Kaldari: Update name of toast module so mobile thanks isn't broken. [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107528 [01:28:44] c1? [01:28:47] (03CR) 10Reedy: [C: 031] Add AUTHORS.txt [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [01:29:07] (03PS2) 10Kaldari: Regression: Update name of toast module so mobile thanks isn't broken. [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107528 [01:29:09] (03CR) 10CSteipp: [C: 031] Add AUTHORS.txt [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [01:29:26] (03CR) 10Ori.livneh: [C: 031] Add AUTHORS.txt [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [01:29:30] well, okay. [01:29:59] (03Merged) 10jenkins-bot: Revert "SpecialContributions: Avoid using 'contributions' slave for getParentLengths" [core] - 10https://gerrit.wikimedia.org/r/107498 (owner: 10Aaron Schulz) [01:30:16] Krenair: where is the code that makes the request? [01:30:23] Krenair: is it a UserGetImplicitGroups hook handler, perhaps? [01:30:57] ori, in includes/User.php, new line 4162 [01:32:43] (03CR) 10Springle: "My understanding from Tim (old conversation) is that wfGetDB() will open a new connection for each different set of arguments." [core] - 10https://gerrit.wikimedia.org/r/107498 (owner: 10Aaron Schulz) [01:34:19] AaronSchulz: ^ that's jfmi [01:34:38] I'll look at LoadBalancer [01:34:46] if it's wrong i'd like to know either way [01:34:59] Krenair: public static function getAllRemoteGroups( $wikiId, $httpReqClass = 'MWHttpRequest' ) [01:35:10] Krenair: then: $req = $httpReqClass::factory( $url ); [01:36:04] I don't plan to modify that function because of jenkins being silly [01:36:04] Krenair: you could also make it a static public property of the User class [01:36:17] jenkins is not being silly [01:36:25] It's got a MediaWiki install [01:36:26] (03CR) 10Legoktm: [C: 031] Add AUTHORS.txt [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [01:36:42] It's not being exposed on a public webserver thoug [01:36:43] Apparently, it does not run a web server to allow access to this install [01:36:43] h [01:36:54] It doesn't even need to be public [01:36:58] Just locally-accessible [01:37:18] Krenair: your test should pass if the code you are testing is correct and fail if the code your testing is incorrect [01:37:39] it should not depend on external resources. an http request to 127.0.0.1 is an external resource. [01:37:49] it's extrinsic to the system you are testing [01:38:04] I'm just going to throw out that test. [01:38:44] (03PS23) 10Alex Monk: Cross-wiki user rights UI should show target wiki groups instead of local [core] - 10https://gerrit.wikimedia.org/r/36330 [01:38:55] (03CR) 10Jdlrobson: [C: 032] Regression: Update name of toast module so mobile thanks isn't broken. [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107528 (owner: 10Kaldari) [01:39:10] Krenair: does MWHttpRequest work with file:// URIs? [01:39:20] It shouldn't... [01:39:42] (03Merged) 10jenkins-bot: Regression: Update name of toast module so mobile thanks isn't broken. [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107528 (owner: 10Kaldari) [01:39:43] Krenair: if so, you could set wgCanonicalServer for the $wikiId to be a file:// URI [01:41:15] ori, nope, it gives an http-invalid-url error, as expected [01:42:43] springle: yeah, it still seems like calling wfGetDB() with a group and then without it will return the same connection (defined by mReadIndex) [01:44:42] Thanks anyway ori [01:46:44] springle: I guess you could have << $this->mRevMetaDB = wfGetDB( DB_SLAVE ); >> right before << $this->mDb = wfGetDB( DB_SLAVE, 'contributions' ); >> and use that as a quick work-around [01:53:46] AaronSchulz: is the reverse true also? call first without a group and later with one returns the same connection? [01:54:43] that case should work fine [01:55:05] the $group case is picky whereas the non-$group case tries to grab anything [01:55:44] ideally one could do this without worrying about order so much some way... [01:55:54] i suppose could add a 'normal' group. would that be less hackish or more so :) [01:59:05] (03PS13) 10Bsitu: Topic and Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 [02:17:45] (03PS2) 10Jackmcbarn: Support searching for multiple filter IDs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105617 [02:18:24] (03PS3) 10Jackmcbarn: Support searching for multiple filter IDs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105617 [02:39:39] (03CR) 10Mattflaschen: [C: 031] "Finally, a change we can all get behind. ;)" [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [02:46:46] Why does grrrit-wm output owner? [02:46:59] Some people enjoy the pings? [02:47:19] I'd prefer to have a piece of the subject line over the owner, personally. [02:47:26] Because 107527 means nothing to me. [02:48:13] Gloria: If your change is being commented on, or someone amends your change, a ping is useful, yes [02:48:28] (03CR) 10Mattflaschen: [C: 04-1] "I don't think it's supposed to include the extensions/. Double-checking." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107513 (owner: 10Jdlrobson) [02:48:33] (It omits the owner if the owner themselves does something. Although there's an edge case where they forgot to implement that) [02:49:26] Fair enoguh. [02:49:28] enough [02:49:39] * Gloria pets grrrit-wm. [02:49:51] Yuvi and I have discussed grrrit-wm responding with "Working ...". [02:49:57] Someone should write that. That's important. [02:50:11] I think a subject line would be useful in cases where there is no comment [02:50:23] Oh wait they implemented that already [02:50:33] Right. [02:50:37] [18:12] grrrit-wm (CR) Catrope: [C: 2] Update OOjs UI to v0.1.0-pre (af97c1caec) [VisualEditor/VisualEditor] - https://gerrit.wikimedia.org/r/107409 (owner: Trevor Parscal) [02:50:38] [18:13] grrrit-wm (Merged) jenkins-bot: Update OOjs UI to v0.1.0-pre (af97c1caec) [VisualEditor/VisualEditor] - https://gerrit.wikimedia.org/r/107409 (owner: Trevor Parscal) [02:51:16] The use-case was a random -1 or whatever with only the ID to work with. [02:54:23] (03CR) 10Theopolisme: "Some replies inline." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [02:55:47] Yeah [02:56:03] I dislike the [C: -1] "(20 comments)" ones [02:56:05] (03CR) 10SPQRobin: "@Hydriz: this change is exactly trying to fix what you want to fix in Change-Id I00f6cd55c2e8d783cefc2615b5730f0e45fff03a" [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/107313 (owner: 10Ebe123) [03:00:47] (03CR) 10thibaultmarin: "I believe I was added to the list of reviewers by mistake. I think you meant to add thibaut.horel@gmail.com (for this changeset https://g" [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [03:04:56] (03CR) 10Mattflaschen: "Fix is inline." (032 comments) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107513 (owner: 10Jdlrobson) [03:07:32] (03PS2) 10Mattflaschen: Specify unit for $wgCUDMaxAge [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/106858 [03:08:16] (03CR) 10Mattflaschen: "No problem, done." [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/106858 (owner: 10Mattflaschen) [03:39:20] (03CR) 10Ori.livneh: [C: 031] "Juliusz's $.extend points are valid, IMO; the remainder are a matter of style. Looks good." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103737 (owner: 10Mattflaschen) [03:59:01] (03PS1) 10Aaron Schulz: Workaround ip2long limitation [core] - 10https://gerrit.wikimedia.org/r/107543 [04:15:06] (03PS1) 10Aaron Schulz: Use regular slaves for user contribs parent revision queries [core] - 10https://gerrit.wikimedia.org/r/107545 [04:18:57] (03CR) 10Aaron Schulz: [C: 032] Handle invalid keys in Lua-to-PHP calls for LuaStandalone [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107383 (owner: 10Anomie) [04:20:57] (03Merged) 10jenkins-bot: Handle invalid keys in Lua-to-PHP calls for LuaStandalone [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107383 (owner: 10Anomie) [04:24:59] (03CR) 10Hydriz: "I am okay with this new change, since third-party users can just configure the settings themselves. I am still rather edgy about using nam" [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/107313 (owner: 10Ebe123) [04:56:02] * Hazard-SJ starts crying :'( [04:56:39] Louder. [04:57:43] * Hazard-SJ starts crying louder :'( [04:57:59] * Hazard-SJ sighs [04:58:05] Louder. [04:58:19] Not going any louder :( [05:16:00] (03CR) 10Dan-nl: [C: 032 V: 032] "+2 based on bryan’s +1 and gergo’s +1" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/107038 (owner: 10Dan-nl) [05:58:55] (03CR) 10Physikerwelt: "I think texvccheck is not beeing compiled automatically." (032 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/105187 (owner: 10Physikerwelt) [06:07:02] (03CR) 10AndyRussG: "Wow!! I really like tons of things here, including, but not limited to, the use of interfaces, the extensibility, the tests..." (035 comments) [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/107307 (owner: 10Adamw) [06:11:25] (03PS10) 10Physikerwelt: Remove call to deprecated ParserOptions::getMath [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 [06:19:00] (03CR) 10Physikerwelt: "Amire80, thank you. For everything works as before. However I don't want to review my own change." [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 (owner: 10Physikerwelt) [06:26:32] (03CR) 10PleaseStand: [C: 04-1] "This is pretty much the same issue as bug 48951." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/107408 (owner: 10Matthias Mullie) [06:53:40] (03PS9) 10Spage: Build living style guide as Special:StyleGuide [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [07:17:47] (03CR) 10Fomafix: "It is a big difference if a whole page is loaded in an other skin or if just parts of the content are from an other skin. The parts can ha" [core] - 10https://gerrit.wikimedia.org/r/107359 (owner: 10Gerrit Patch Uploader) [07:34:12] (03CR) 10Mayankmadan: "There are no comments in patch set 11" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [07:38:20] (03CR) 10Spage: "I find the Special:StyleGuide approach useful because I can see the CSS with different skins and Beta features. So I resuscitated this pa" [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [07:47:49] (03CR) 10Legoktm: "I think this will be easier to merge if you split it up into multiple patches. Maybe one removing all the dead wikis, another for all the " [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [08:21:18] (03CR) 10TTO: "I intend to send a message to wikitech-l (I can't find a more suitable mailing list...) about interwikis which may render this patch obsol" [core] - 10https://gerrit.wikimedia.org/r/84303 (owner: 10TTO) [08:53:31] (03CR) 10Gilles: [C: 031] "Would +2 if I could" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [09:13:21] (03PS1) 10Hashar: check-sync: tweak user facing message [extensions] - 10https://gerrit.wikimedia.org/r/107552 [09:13:41] (03CR) 10Hashar: [C: 032 V: 032] check-sync: tweak user facing message [extensions] - 10https://gerrit.wikimedia.org/r/107552 (owner: 10Hashar) [09:30:57] (03CR) 10Zfilipin: "I think I was also added to the list by mistake. I do not remember contributing code to the project, and I could not find my name in git l" [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [09:41:31] (03CR) 10Gilles: Create jquery.fullscreen (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [09:49:29] (03PS2) 10Legoktm: [WIP] Revamp API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 [10:00:47] (03PS3) 10Legoktm: [WIP] Revamp API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 [10:14:45] (03CR) 10Gilles: [C: 04-1] A way to blacklist flickr users. (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [10:28:17] (03CR) 10MaxSem: [V: 032] Update help URL [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/107495 (owner: 10MaxSem) [10:49:00] (03CR) 10Grunny: [C: 031] "Zeljko: use git log --author="zeljko" instead of --grep. It looks like you have three commits to this project:" [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [11:10:48] (03PS1) 10Matthias Mullie: Add fromStorageRow -> toStorageRow roundtrip test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107560 [11:15:13] (03PS1) 10Matthias Mullie: Move tests to Flow\Tests namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107561 [11:27:36] (03PS1) 10Mwalker: Add Image Metadata to Image Database [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/107562 [11:31:34] (03PS2) 10Matthias Mullie: Add fromStorageRow -> toStorageRow roundtrip test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107560 [11:32:26] (03PS1) 10Matthias Mullie: Use PostRevisionTestCase helper method to build PostRevision object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107563 [11:33:59] (03CR) 10jenkins-bot: [V: 04-1] Add Image Metadata to Image Database [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/107562 (owner: 10Mwalker) [11:38:59] (03CR) 10Zfilipin: [C: 031] "Thanks Grunny, in that case +1 :)" [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [12:29:53] hey hashar,are you able to approve https://gerrit.wikimedia.org/r/#/c/107138/ ? [12:37:11] How can I clone wikimedia / qa-browsertests using the gerrit clone ? [12:39:04] hmm, i don't see that project in gerrit [12:39:10] wikimedia/qa.... [12:39:35] tonythomas01: ah, it not wikimedia/ in front of it [12:39:37] qa/browsertests [12:39:48] git clone https://gerrit.wikimedia.org/r/qa/browsertests [12:40:10] tonythomas01: and feel free to join #wikimedia-qa IRC channel :-] [12:40:34] dan-nl: do you need in production as well ? [12:40:56] dan-nl: nm, will deploy [12:41:31] yes, but that can happen with the regular deploy [12:41:40] beta first is fine [12:42:29] dan-nl: and it is deployed on production =) [12:42:41] cool, thanks! [12:52:19] Hello! :) [12:57:37] !git qa/browsertests [12:57:38] MediaWiki development is using git, a distributed source control manager, starting on March 21st, 2012; details: https://www.mediawiki.org/wiki/Git_happens Instructions for using it: https://www.mediawiki.org/wiki/Git/Workflow To get an account: https://www.mediawiki.org/wiki/Project:Labsconsole_accounts [12:57:40] grrr [12:57:44] !g qa/browsertests [12:57:44] https://gerrit.wikimedia.org/r/#q,qa/browsertests,n,z [12:57:49] !gitweb qa/browsertests [12:57:49] https://git.wikimedia.org/summary/?r=qa/browsertests [13:06:49] Nemo_bis: wanna whitelist yourself in Zuul configuration so you get tests running on change you submit ? [13:08:27] Gloria, Regarding the bug:https://bugzilla.wikimedia.org/show_bug.cgi?id=33334 ... I created schema patches and when I mediawiki on my localhost I get this error..http://tinypic.com/r/343hl5v/5 ..Can you got through it? [13:14:44] (03PS1) 10Matthias Mullie: Tests for SpamRegex & SpamBlacklist integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107568 [13:20:10] tina: Going by the error message, you need to run the update.php(located in the maintenance directory). Check https://www.mediawiki.org/wiki/Manual:Update.php [13:20:59] (03PS2) 10Matthias Mullie: Test for SpamRegex integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107568 [13:22:33] (03PS1) 10Matthias Mullie: Test for SpamBlacklist integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107569 [13:24:56] (03PS3) 10Roopak: Re-sized #guider_overlay's z-index [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/107333 [13:28:48] (03CR) 10AndyRussG: [C: 031] Basic state machinery [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/107307 (owner: 10Adamw) [13:35:57] (03PS1) 10Hashar: explicitly define success/failure messages [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/107570 [13:36:11] (03CR) 10Hashar: [C: 032] explicitly define success/failure messages [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/107570 (owner: 10Hashar) [13:36:15] (03Merged) 10jenkins-bot: explicitly define success/failure messages [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/107570 (owner: 10Hashar) [13:49:35] hey hashar [14:00:18] (03PS4) 10Anjanasasindran123: Changed "OK" to "Thank" in confirmation dialog box [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107350 [14:06:56] (03PS1) 10Hashar: register some new extensions [extensions] - 10https://gerrit.wikimedia.org/r/107572 [14:07:09] (03CR) 10Hashar: [C: 032 V: 032] register some new extensions [extensions] - 10https://gerrit.wikimedia.org/r/107572 (owner: 10Hashar) [14:14:39] (03CR) 10SPQRobin: [C: 032 V: 032] Use namespace ID for Module: namespace This commit changes all the proper names for namespaces into their IDs. This change was meant for the [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/107313 (owner: 10Ebe123) [14:17:28] (03PS1) 10Hashar: unregister VisualEditor (replication broken in Gerrit) [extensions] - 10https://gerrit.wikimedia.org/r/107574 [14:18:48] (03CR) 10Hashar: "On beta we will simply pull VisualEditor" [extensions] - 10https://gerrit.wikimedia.org/r/107574 (owner: 10Hashar) [14:27:17] (03CR) 10Hashar: "Change to the beta auto updater is https://gerrit.wikimedia.org/r/#/c/107575/ , it simply goes to VisualEditor dir and then does a git pul" [extensions] - 10https://gerrit.wikimedia.org/r/107574 (owner: 10Hashar) [14:38:04] (03CR) 10Manybubbles: "boost-templates and prefer-recent are anchored at the front of the query. I'm not really sure why actually. I'd combine prefer-recent in" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107505 (owner: 10Chad) [14:38:26] (03CR) 10Chad: [C: 04-2] "We don't want to remove the submodule though." [extensions] - 10https://gerrit.wikimedia.org/r/107574 (owner: 10Hashar) [14:42:14] (03CR) 10Hashar: (bug 17630) Add edit page permission check (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105167 (owner: 10Cargan) [14:42:36] (03Abandoned) 10Hashar: fixed spacing [core] - 10https://gerrit.wikimedia.org/r/106225 (owner: 10Cargan) [14:42:50] (03CR) 10MarkAHershberger: [C: 032] Make WikiPage::$mPreparedEdit public [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107488 (owner: 10Reedy) [14:45:18] (03PS10) 10Andrew Bogott: Switch reading to the new service group schema. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105847 [14:45:20] (03PS10) 10Andrew Bogott: Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 [14:45:22] (03PS10) 10Andrew Bogott: Add maintenance tool to clean up the old service-group schema. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105848 [14:45:25] (03CR) 10jenkins-bot: [V: 04-1] Switch reading to the new service group schema. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105847 (owner: 10Andrew Bogott) [14:45:27] (03CR) 10jenkins-bot: [V: 04-1] Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 (owner: 10Andrew Bogott) [14:45:29] (03CR) 10jenkins-bot: [V: 04-1] Add maintenance tool to clean up the old service-group schema. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105848 (owner: 10Andrew Bogott) [14:46:38] (03Merged) 10jenkins-bot: Make WikiPage::$mPreparedEdit public [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107488 (owner: 10Reedy) [14:47:21] (03PS11) 10Andrew Bogott: Switch reading to the new service group schema. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105847 [14:47:23] (03PS11) 10Andrew Bogott: Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 [14:47:25] (03PS11) 10Andrew Bogott: Add maintenance tool to clean up the old service-group schema. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105848 [14:47:29] (03CR) 10jenkins-bot: [V: 04-1] Add maintenance tool to clean up the old service-group schema. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105848 (owner: 10Andrew Bogott) [14:56:21] (03CR) 10Parent5446: Moved account creation throttle to ping limiter (031 comment) [core] - 10https://gerrit.wikimedia.org/r/65867 (owner: 10Parent5446) [14:56:26] (03PS10) 10Parent5446: Moved account creation throttle to ping limiter [core] - 10https://gerrit.wikimedia.org/r/65867 [15:05:07] (03PS1) 10SG: refs 58880 - Implement better scrolling via conditionalScroll Refactor ui.js to a cleaner and simpler format [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 [15:05:10] (03CR) 10jenkins-bot: [V: 04-1] refs 58880 - Implement better scrolling via conditionalScroll Refactor ui.js to a cleaner and simpler format [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 (owner: 10SG) [15:11:01] (03PS1) 10SG: Missing semicolon [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107581 [15:11:48] (03Abandoned) 10SG: Missing semicolon [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107581 (owner: 10SG) [15:12:37] (03PS2) 10SG: refs 58880 - Implement better scrolling via conditionalScroll Refactor ui.js to a cleaner and simpler format [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 [15:15:39] (03PS1) 10Cscott: Support . [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107582 [15:15:41] (03PS1) 10Cscott: Use an es6 Set to track templates. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107583 [15:15:43] (03PS1) 10Cscott: Document the need to export TEXINPUTS if building LaTeX sources manually. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107584 [15:15:45] (03PS1) 10Cscott: Add missing texlive-generic-extra dependency. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107585 [15:15:47] (03PS1) 10Cscott: Add childSelector/childSelectorAll helpers. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107586 [15:15:49] (03PS1) 10Cscott: Basic table support. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107587 [15:16:27] (03CR) 10jenkins-bot: [V: 04-1] Add childSelector/childSelectorAll helpers. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107586 (owner: 10Cscott) [15:20:38] (03PS3) 10Andrew Bogott: Allow for creation of service group without initial user. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105845 [15:20:40] (03PS12) 10Andrew Bogott: Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 [15:25:25] (03PS1) 10Alexander.lehmann: initial code commit Change-Id: I90cd3534e5fd210c315feb27b3b7be808d8cc6ad [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/107589 [15:28:25] (03CR) 10SG: "So, there's a couple of issues to begin with." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 (owner: 10SG) [15:29:11] (03CR) 10Ottomata: [C: 031] Add AUTHORS.txt [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [15:33:44] (03CR) 10Nik: [C: 032 V: 032] initial code commit Change-Id: I90cd3534e5fd210c315feb27b3b7be808d8cc6ad [extensions/PubSubHubbub] - 10https://gerrit.wikimedia.org/r/107589 (owner: 10Alexander.lehmann) [15:34:57] (03PS13) 10Andrew Bogott: Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 [15:57:02] could somebody merge https://gerrit.wikimedia.org/r/106552 ? trivial one-line patch [15:57:28] (03CR) 10Nikerabbit: "How is this going to keep up to date if manual step is required to build the pages?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [16:06:48] (03CR) 10Yurik: [C: 031] Add AUTHORS.txt [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [16:10:50] (03PS1) 10Alexander.lehmann: test2 [extensions/PubSubHubbub] (feature/initial-commit) - 10https://gerrit.wikimedia.org/r/107591 [16:13:15] (03PS1) 10Gilles: Propagate the favicon information to getInfo() [core] - 10https://gerrit.wikimedia.org/r/107592 [16:13:34] (03PS1) 10Alexander.lehmann: test3 [extensions/PubSubHubbub] (feature/initial-commit) - 10https://gerrit.wikimedia.org/r/107593 [16:15:23] is anybody in the office on 3? [16:15:36] (03CR) 10Daniel Kinzler: [C: 04-1] "This is incomplete and needs tests - I meant to submit this as a draft, sorry." [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [16:15:40] (03Abandoned) 10Alexander.lehmann: test3 [extensions/PubSubHubbub] (feature/initial-commit) - 10https://gerrit.wikimedia.org/r/107593 (owner: 10Alexander.lehmann) [16:15:54] (03Abandoned) 10Alexander.lehmann: test2 [extensions/PubSubHubbub] (feature/initial-commit) - 10https://gerrit.wikimedia.org/r/107591 (owner: 10Alexander.lehmann) [16:20:11] from where I can download source code of media wiki ? [16:23:23] BHAVANA: Github is one option. https://github.com/wikimedia/ [16:24:44] (03CR) 10Anomie: [C: 032] Make PROTECTIONLEVEL count as expensive [core] - 10https://gerrit.wikimedia.org/r/107199 (owner: 10Jackmcbarn) [16:27:06] (03CR) 10Mattflaschen: [C: 032] "Looks good, thanks." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/107333 (owner: 10Roopak) [16:27:39] (03Merged) 10jenkins-bot: Re-sized #guider_overlay's z-index [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/107333 (owner: 10Roopak) [16:28:06] (03CR) 10Anomie: [C: 031] "Looks sane, haven't tested" [core] - 10https://gerrit.wikimedia.org/r/107592 (owner: 10Gilles) [16:28:12] (03Merged) 10jenkins-bot: Make PROTECTIONLEVEL count as expensive [core] - 10https://gerrit.wikimedia.org/r/107199 (owner: 10Jackmcbarn) [16:33:23] (03CR) 10Aklapper: "Adding "Bug: 58880" as last line instead of "refs 58880" also welcome, see http://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 (owner: 10SG) [16:38:14] (03PS1) 10Tpt: Don’t use 0 as proofreading level for edits from unallowed users [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/107597 [16:41:34] Thank u Niharika [16:48:02] (03CR) 10Anomie: "One style nitpick, and a suggestion on improving the unit tests. Code works correctly in manual testing though." (033 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107046 (owner: 10Jackmcbarn) [16:49:09] (03CR) 10Mwjames: "@Tim:" [core] - 10https://gerrit.wikimedia.org/r/62174 (owner: 10Jakub Vrána) [16:50:05] BHAVANA: try http://www.mediawiki.org/wiki/Download too. has 'stable' versions [17:04:46] (03CR) 10Anomie: [C: 031] "Looks good, seems to work. Not +2ing yet in case anyone else wants to review, more eyes are better." [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/105979 (owner: 10Jackmcbarn) [17:07:52] (03PS1) 10Anomie: MathJax must not process every [extensions/Math] - 10https://gerrit.wikimedia.org/r/107601 [17:11:50] (03CR) 10Parent5446: Add protectionLevels variable to mw.title output (033 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107046 (owner: 10Jackmcbarn) [17:20:47] (03CR) 10Frédéric Wang: [C: 031] MathJax must not process every [extensions/Math] - 10https://gerrit.wikimedia.org/r/107601 (owner: 10Anomie) [17:21:00] brion: found anyone for the user creation patch review? [17:24:02] (03PS5) 10Daniel Kinzler: Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 [17:25:26] (03PS6) 10Daniel Kinzler: Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 [17:33:50] (03CR) 10Physikerwelt: [C: 032] "I like that soulution. Tested and works perfectly." [extensions/Math] - 10https://gerrit.wikimedia.org/r/107601 (owner: 10Anomie) [17:34:23] (03CR) 10Matthias Mullie: "Just some quick feedback." (037 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 (owner: 10SG) [17:37:33] (03PS2) 10Matthias Mullie: Test for SpamBlacklist integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107569 [17:38:00] (03PS3) 10Adamw: Basic state machinery [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/107307 [17:48:54] (03PS2) 10Cscott: WIP: Basic table support. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107587 [17:48:56] (03PS1) 10Cscott: Use latest gammalatex to clean up temp file handling. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107606 [17:48:58] (03PS1) 10Cscott: WIP: fixes to table support. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107607 [17:49:25] (03CR) 10jenkins-bot: [V: 04-1] Use latest gammalatex to clean up temp file handling. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107606 (owner: 10Cscott) [17:49:29] (03CR) 10Cscott: [C: 032] Support . [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107582 (owner: 10Cscott) [17:50:00] (03Merged) 10jenkins-bot: Support . [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107582 (owner: 10Cscott) [17:54:53] (03CR) 10Cscott: [C: 032] Use an es6 Set to track templates. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107583 (owner: 10Cscott) [17:55:17] (03Merged) 10jenkins-bot: Use an es6 Set to track templates. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107583 (owner: 10Cscott) [17:55:27] (03CR) 10Cscott: [C: 032] Document the need to export TEXINPUTS if building LaTeX sources manually. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107584 (owner: 10Cscott) [17:55:38] (03CR) 10Cscott: [C: 032] Add missing texlive-generic-extra dependency. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107585 (owner: 10Cscott) [17:55:48] (03Merged) 10jenkins-bot: Document the need to export TEXINPUTS if building LaTeX sources manually. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107584 (owner: 10Cscott) [17:56:06] (03Merged) 10jenkins-bot: Add missing texlive-generic-extra dependency. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107585 (owner: 10Cscott) [17:56:44] (03PS2) 10Cscott: Use latest gammalatex to clean up temp file handling. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107606 [17:56:47] (03PS2) 10Cscott: WIP: fixes to table support. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107607 [17:56:49] (03PS3) 10Cscott: WIP: Basic table support. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107587 [17:56:51] (03PS2) 10Cscott: Add childSelector/childSelectorAll helpers. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107586 [17:57:39] (03CR) 10jenkins-bot: [V: 04-1] Add childSelector/childSelectorAll helpers. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107586 (owner: 10Cscott) [17:57:57] (03CR) 10Cscott: [C: 032] Use latest gammalatex to clean up temp file handling. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107606 (owner: 10Cscott) [17:58:20] (03Merged) 10jenkins-bot: Use latest gammalatex to clean up temp file handling. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107606 (owner: 10Cscott) [18:01:33] (03PS2) 10Aaron Schulz: Added simpler handleError() method RedisConnectionPool [core] - 10https://gerrit.wikimedia.org/r/102361 [18:03:37] (03Abandoned) 10Aaron Schulz: Removed comment reference to removed setting [core] - 10https://gerrit.wikimedia.org/r/106762 (owner: 10Aaron Schulz) [18:14:15] (03CR) 10Adamw: "PS3: I cleaned up Description a bit, and corrected the classname for StateVariables." [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/107307 (owner: 10Adamw) [18:14:44] (03CR) 10Adamw: Basic state machinery (034 comments) [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/107307 (owner: 10Adamw) [18:20:03] (03CR) 10Bartosz Dziewoński: "Ah, okay, this makes sense then – thanks for the explanation." [core] - 10https://gerrit.wikimedia.org/r/107359 (owner: 10Gerrit Patch Uploader) [18:23:48] (03CR) 10Bartosz Dziewoński: Use current preference overriding for live preview (031 comment) [core] - 10https://gerrit.wikimedia.org/r/107359 (owner: 10Gerrit Patch Uploader) [18:25:07] (03CR) 10Bartosz Dziewoński: Use current preference overriding for live preview (031 comment) [core] - 10https://gerrit.wikimedia.org/r/107359 (owner: 10Gerrit Patch Uploader) [18:25:42] (03PS1) 10Aaron Schulz: Fixed getReaderIndex() handling of $group [core] - 10https://gerrit.wikimedia.org/r/107610 [18:26:59] (03CR) 10Bartosz Dziewoński: "Ugh, I spent so much time on enhancing our docs and this is still not merged? :/" [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [18:29:58] manybubbles: http://en.wikipedia.beta.wmflabs.org/wiki/Special:Version :-( [18:30:11] (03CR) 10Bartosz Dziewoński: [C: 04-1] "There is no message called 'thank'. Have you tested this code? :/" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107350 (owner: 10Anjanasasindran123) [18:30:22] (03PS2) 10Aklapper: [4.4] Sync with upstream 4.4 [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98028 [18:31:29] lol [18:33:35] (03CR) 10BryanDavis: [C: 031] "I haven't tested but the code looks good." [core] - 10https://gerrit.wikimedia.org/r/102361 (owner: 10Aaron Schulz) [18:33:37] (03PS10) 10Bartosz Dziewoński: JSDuck-ify /resources/mediawiki.language/* [core] - 10https://gerrit.wikimedia.org/r/98380 [18:35:33] (03Abandoned) 10EBernhardson: [WIP] Attach workflows to posts, to get appropriate title into parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97060 (owner: 10EBernhardson) [18:38:45] (03CR) 10Guido.iaquinti: [C: 031] Add missing admin-users-valid i18n key [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/107185 (owner: 10BryanDavis) [18:40:34] James_F: chad is fixing it [18:40:53] manybubbles: Great. [18:41:04] (03CR) 10CSteipp: [C: 032] Specify unit for $wgCUDMaxAge [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/106858 (owner: 10Mattflaschen) [18:41:06] (03Merged) 10jenkins-bot: Specify unit for $wgCUDMaxAge [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/106858 (owner: 10Mattflaschen) [18:47:32] (03PS1) 10Chad: Make getElasticsearchVersion() not static [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107611 [18:49:17] (03CR) 10BryanDavis: [C: 031] Make getElasticsearchVersion() not static [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107611 (owner: 10Chad) [18:49:28] (03CR) 10Manybubbles: [C: 032] Make getElasticsearchVersion() not static [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107611 (owner: 10Chad) [18:49:39] (03Merged) 10jenkins-bot: Make getElasticsearchVersion() not static [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107611 (owner: 10Chad) [18:52:54] (03PS3) 10Aaron Schulz: Removed unused postConnectionBackoff() from LoadMonitor [core] - 10https://gerrit.wikimedia.org/r/105140 [18:54:44] (03CR) 10jenkins-bot: [V: 04-1] Removed unused postConnectionBackoff() from LoadMonitor [core] - 10https://gerrit.wikimedia.org/r/105140 (owner: 10Aaron Schulz) [18:55:09] ^d: https://gerrit.wikimedia.org/r/#/c/107610 [18:57:25] (03PS1) 10Manybubbles: Fix Special:Version for real this time [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107612 [18:57:51] (03CR) 10Manybubbles: [C: 032] "Self merging because crashing is bad." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107612 (owner: 10Manybubbles) [18:57:57] (03Merged) 10jenkins-bot: Fix Special:Version for real this time [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107612 (owner: 10Manybubbles) [18:57:58] (03PS1) 10Chad: Typofix that was causing all kinds of profiling errors [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107613 [18:58:46] <^d> manybubbles: I finally spotted what was causing that ^ [18:58:53] <^d> Look at the same line a dozen times...never looks wrong [18:59:21] (03CR) 10Manybubbles: [C: 032] Typofix that was causing all kinds of profiling errors [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107613 (owner: 10Chad) [18:59:27] (03Merged) 10jenkins-bot: Typofix that was causing all kinds of profiling errors [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107613 (owner: 10Chad) [18:59:40] (03CR) 10EBernhardson: "resolveFromCache doesn't resepect the $wiki parameter" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100373 (owner: 10Matthias Mullie) [18:59:43] I wish I could run profiling in dev where I'd complain to me if I was doing it wrong [18:59:48] (03CR) 10EBernhardson: [C: 04-1] User User cache when loading usernames [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100373 (owner: 10Matthias Mullie) [19:02:37] I've previously seen some sort of notification box that pops up in the top right hand corner and then fades away, anyone know where that is from? [19:02:57] (03PS14) 10Bsitu: Topic and Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 [19:03:22] ebernhardson: mw.notify? [19:03:30] I think? [19:03:43] ebernhardson: yeah, that's the one [19:03:45] YuviPanda: maybe i'll check, thanks [19:04:11] ebernhardson: http://www.mediawiki.org/wiki/ResourceLoader/Default_modules#mediawiki.notify [19:04:27] James_F: fixed [19:04:31] (03PS1) 10Chad: Make function not static and remove static class variable [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107614 [19:04:56] (03CR) 10EBernhardson: [C: 04-1] "Could we instead use http://www.mediawiki.org/wiki/ResourceLoader/Default_modules#mediawiki.notify ? Also this needs a rebase" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100953 (owner: 10Werdna) [19:05:42] (03CR) 10AndyRussG: "@Adamw, re: the external libraries: not at all a PITA. I would have also tried including the upstream code in the repo, but I wasn't sure " [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [19:05:59] (03PS4) 10Aaron Schulz: Removed unused postConnectionBackoff() from LoadMonitor [core] - 10https://gerrit.wikimedia.org/r/105140 [19:08:06] (03PS1) 10Chad: Remove DeletePagesJob::build() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107615 [19:11:51] (03CR) 10Manybubbles: [C: 032] Make function not static and remove static class variable [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107614 (owner: 10Chad) [19:11:55] (03Merged) 10jenkins-bot: Make function not static and remove static class variable [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107614 (owner: 10Chad) [19:12:04] (03CR) 10Manybubbles: [C: 032] Remove DeletePagesJob::build() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107615 (owner: 10Chad) [19:12:08] (03Merged) 10jenkins-bot: Remove DeletePagesJob::build() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107615 (owner: 10Chad) [19:17:01] (03PS2) 10EBernhardson: Topic headers smaller and less saturated [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105222 [19:20:51] (03PS1) 10Chad: Refactor all external index tracking into OtherIndex class [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107617 [19:20:53] (03CR) 10jenkins-bot: [V: 04-1] Refactor all external index tracking into OtherIndex class [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107617 (owner: 10Chad) [19:22:04] (03CR) 10Jdlrobson: [C: 04-1] "There are a few issues with this. I defined this hook and changing $html seems to have no effect on any skin. Plus in CologneBlue all is o" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/101895 (owner: 10Aude) [19:23:11] (03PS2) 10Chad: Refactor all external index tracking into OtherIndex class [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107617 [19:24:49] (03CR) 1001tonythomas: [C: 04-1] "as Legoktm commented :" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107350 (owner: 10Anjanasasindran123) [19:28:48] (03CR) 10MarkTraceur: "Theo, FYI, I'm working on this patch today, I want fullscreen by Friday. :)" [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [19:28:54] (03CR) 10MarkTraceur: [C: 04-1] Create jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [19:29:49] (03PS1) 10Mattflaschen: Simplify the firstedit tour by removing special VisualEditor handling [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/107618 [19:35:03] (03PS2) 10Mattflaschen: Simplify the firstedit tour by removing special VE handling [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/107618 [19:35:28] anomie: around? [19:35:48] jackmcbarn: Yes [19:35:59] (03CR) 10Fomafix: Use current preference overriding for live preview (032 comments) [core] - 10https://gerrit.wikimedia.org/r/107359 (owner: 10Gerrit Patch Uploader) [19:36:01] when you say i should have one of the unit tests use an empty array, do you mean the second level for one would be empty? when does that happen in core? [19:36:13] as in { edit = {} } [19:36:50] (03PS1) 10Anomie: Requested additional options [extensions/Collection] - 10https://gerrit.wikimedia.org/r/107620 [19:37:30] jackmcbarn: Yes, that. And I see it locally for every existing page I test that doesn't have protection set. [19:37:40] that's odd, i don't [19:37:52] i get {} if a page has no protection set [19:39:21] (03PS1) 10Chad: Avoid loading revisions for every search result [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107621 [19:40:47] oh, i see [19:40:52] for pages that exist, i get that [19:41:00] for pages that don't, i get {} [19:41:05] * jackmcbarn goes to try creation-protection [19:42:27] anomie: why don't i get { create = {} } for pages that don't exist then? [19:43:24] jackmcbarn: Different code path in Title::loadRestrictions, looks like. [19:43:38] is one of those behaviors "right"? [19:43:59] (i'm in favor of changing it to { create = {} }) [19:44:08] jackmcbarn: I wouldn't say either is wrong [19:44:46] no available restriction types is perfectly valid also, btw [19:44:52] we have that on Wikidata [19:44:58] (03PS1) 10Matthias Mullie: Test for AbuseFilter integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107623 [19:45:04] (03CR) 10jenkins-bot: [V: 04-1] Test for AbuseFilter integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107623 (owner: 10Matthias Mullie) [19:45:40] does it make sense for one of the inner arrays to ever contain the empty string? [19:45:43] jackmcbarn: Remember that until your recent patch there was no explicitly public access to $title->mRestrictions, and Title::getRestrictions hides the difference. [19:45:48] why does core protection test that? [19:46:24] (03CR) 10Manybubbles: Avoid loading revisions for every search result (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107621 (owner: 10Chad) [19:47:34] (03PS2) 10Matthias Mullie: Test for AbuseFilter integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107623 [19:47:40] (03CR) 10jenkins-bot: [V: 04-1] Test for AbuseFilter integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107623 (owner: 10Matthias Mullie) [19:48:22] (03CR) 10Hashar: "> We don't want to remove the submodule though." [extensions] - 10https://gerrit.wikimedia.org/r/107574 (owner: 10Hashar) [19:50:26] (03PS5) 10Jackmcbarn: Add protectionLevels variable to mw.title output [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107046 [19:51:26] jackmcbarn: No idea. The tests were added like that in r65504. [19:53:05] (03PS3) 10Matthias Mullie: Test for AbuseFilter integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107623 [19:53:25] (03CR) 10Umherirrender: "The patch with the schema changes was merged 2 month before and part of release 1.22, there was a bug about a error in oracle related to t" [core] - 10https://gerrit.wikimedia.org/r/105243 (owner: 10Umherirrender) [19:55:45] (03PS1) 10Hashar: run operations/mediawiki-config tests in parallel [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/107629 [19:56:17] (03CR) 10Hashar: [C: 032] run operations/mediawiki-config tests in parallel [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/107629 (owner: 10Hashar) [19:56:22] (03Merged) 10jenkins-bot: run operations/mediawiki-config tests in parallel [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/107629 (owner: 10Hashar) [19:57:26] clever hashar, working without being on IRC :D [19:57:31] heh [19:57:32] hmmm [19:57:41] is it "a URI" or "an URI"? [19:57:49] i say "a URI" [19:58:28] a URI [19:58:44] a URI [19:58:57] the question is, it is a U-R-I or yuri [19:59:03] (03PS15) 10Bsitu: Topic and Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 [19:59:08] obviosuly its U-R-I ;P [19:59:17] heh [19:59:24] You or Eye [20:00:29] (03PS1) 10Bartosz Dziewoński: JSDuck-ify /resources/mediawiki/mediawiki.Uri.js [core] - 10https://gerrit.wikimedia.org/r/107630 [20:00:31] feel free to bikeshed ^ :D [20:00:52] well, should really be JSWitch [20:01:25] (03Abandoned) 10btongminh: Output plain text database name in installer if driver not installed [core] - 10https://gerrit.wikimedia.org/r/103379 (owner: 10btongminh) [20:02:11] hmm, anyone know where parsoid went? i dont have a js/ dir there so its probably a new repository ? [20:02:35] nm, its in the git log [20:04:23] (03PS1) 10Mattflaschen: Change how presence of VisualEditor is determined [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/107631 [20:04:47] (03CR) 10Gergő Tisza: A way to blacklist flickr users. (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [20:05:35] MatmaRex: It depends on whether it's being pronounced to start with a vowel sound ("oorie", maybe?) or a consonant sound (likely a palatal approximant, like "you"). Yay, English. [20:05:45] (03PS9) 10Gergő Tisza: A way to blacklist flickr users. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [20:06:03] anomie: yeah, my question was, how the hell do you pronounce that [20:06:26] you are I. [20:06:37] MatmaRex: That's the problem. Can you rewrite your sentence to just avoid using the indefinite article with "URI"? ;) [20:06:47] haha [20:06:53] Personally, "you are eye" [20:07:08] I am? [20:07:25] "Of course, it's company policy never to imply ownership in the event of a dildo. We have to use the indefinite article, "a dildo", never … your dildo." [20:07:32] Eye are see. [20:07:46] (also, english is my second language and unfortunately i mostly know it in writing; my pronounciation in general is at best funny) [20:08:13] MatmaRex: i can tell, because most native speakers dont know what an indefinite article is ;) [20:08:22] haha [20:09:24] ebernhardson: if it's indefinite, how could they define it? [20:09:37] little bit off-topic, does anyone know of a way to display all lines that are in one file but not in some other file? [20:09:39] MatmaRex: most important rule of english is https://en.wikipedia.org/wiki/WP:IAR :) [20:09:44] (03PS1) 10Kaldari: Story 1604: Remember mobile thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107633 [20:10:15] jackmcbarn: php -r 'var_dump(array_diff(file($a), file($b)));' off the top of my head, but theres probably a better way [20:10:26] that'll do [20:10:28] since array_diff isn't really diff but a set comparaision type thing [20:10:48] (03CR) 10Chad: Avoid loading revisions for every search result (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107621 (owner: 10Chad) [20:11:52] jackmcbarn: I usually use something along the lines of diff -u file1 file2 | grep '^-' (or '^+', depending) [20:12:29] Although that depends on order [20:12:44] * MatmaRex uses http://pe.ppy.sh/2009/06/265/ [20:14:11] (03PS12) 10MarkTraceur: Create jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [20:14:54] jackmcbarn: If I remember it, fgrep -v -f file1 file2 might do it, although I don't know how well that'd do with really huge files [20:15:01] err, -xv [20:15:03] your diff command did what i needed [20:15:29] in case anyone was curious, i was trying to get a list of users who edited a wikipedia page before a certain timestamp, but didn't after [20:17:18] (03CR) 10Manybubbles: Avoid loading revisions for every search result (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107621 (owner: 10Chad) [20:18:47] (03CR) 10Legoktm: "We're already storing this data in the user's session, is there a reason that can't be used?" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107633 (owner: 10Kaldari) [20:20:34] (03CR) 10Anomie: [C: 032] Add protectionLevels variable to mw.title output [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107046 (owner: 10Jackmcbarn) [20:21:49] (03Merged) 10jenkins-bot: Add protectionLevels variable to mw.title output [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107046 (owner: 10Jackmcbarn) [20:29:18] (03CR) 10Legoktm: Test for SpamBlacklist integration (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107569 (owner: 10Matthias Mullie) [20:31:02] (03CR) 10SG: refs 58880 - Implement better scrolling via conditionalScroll Refactor ui.js to a cleaner and simpler format (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 (owner: 10SG) [20:39:15] (03CR) 10Bsitu: Make error reporting more verbose. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107149 (owner: 10Matthias Mullie) [20:49:06] (03CR) 10AndyRussG: Notifications for course talk page edits (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/105147 (owner: 10AndyRussG) [20:50:52] (03CR) 10Adamw: Notifications for course talk page edits (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/105147 (owner: 10AndyRussG) [20:54:55] (03CR) 10AndyRussG: Notifications for course talk page edits (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/105147 (owner: 10AndyRussG) [20:57:28] (03CR) 10Chad: [C: 032] Add missing admin-users-valid i18n key [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/107185 (owner: 10BryanDavis) [20:57:32] (03Merged) 10jenkins-bot: Add missing admin-users-valid i18n key [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/107185 (owner: 10BryanDavis) [20:58:10] (03CR) 10Chad: [C: 031] Add AUTHORS.txt [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [20:58:43] (03CR) 10Chad: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106904 (owner: 10L10n-bot) [21:01:46] (03PS1) 10Chad: Don't suggest if the search term is a known title [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/107663 [21:02:32] (03Abandoned) 10Chad: Don't suggest if the search term is a known title [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/107663 (owner: 10Chad) [21:02:35] (03CR) 10WikidataJenkins: "Build failed." [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/107663 (owner: 10Chad) [21:06:01] (03PS2) 10Chad: Don't build suggestions if core doesn't need them [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105826 (owner: 10Manybubbles) [21:07:00] (03PS3) 10Chad: Don't build suggestions if core doesn't need them [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105826 (owner: 10Manybubbles) [21:07:19] (03CR) 10Chad: [C: 032] Don't build suggestions if core doesn't need them [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105826 (owner: 10Manybubbles) [21:07:28] (03Merged) 10jenkins-bot: Don't build suggestions if core doesn't need them [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105826 (owner: 10Manybubbles) [21:08:19] (03PS4) 10Cscott: Basic table support. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107587 [21:08:21] (03PS3) 10Cscott: Add childSelector/childSelectorAll helpers. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107586 [21:08:32] (03Abandoned) 10Cscott: WIP: fixes to table support. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107607 (owner: 10Cscott) [21:09:37] (03PS1) 10Aaron Schulz: Fixed wrong usage of $tmpFile in Swift backend [core] - 10https://gerrit.wikimedia.org/r/107711 [21:09:44] (03PS1) 10Gergő Tisza: Add site icon to filerepoinfo API [core] - 10https://gerrit.wikimedia.org/r/107712 [21:09:46] (03CR) 10WikidataJenkins: "Build failed." [core] - 10https://gerrit.wikimedia.org/r/107711 (owner: 10Aaron Schulz) [21:09:48] (03CR) 10WikidataJenkins: "Build failed." [core] - 10https://gerrit.wikimedia.org/r/107712 (owner: 10Gergő Tisza) [21:09:51] (03PS1) 10Aaron Schulz: Fixed wrong usage of $tmpFile in Swift backend [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107713 [21:09:59] (03CR) 10Aaron Schulz: [C: 032] Fixed wrong usage of $tmpFile in Swift backend [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107713 (owner: 10Aaron Schulz) [21:10:01] (03CR) 10WikidataJenkins: "Build failed." [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107713 (owner: 10Aaron Schulz) [21:10:24] gah, it works thogh :) [21:10:35] sorry folks! [21:11:56] (03PS1) 10Jackmcbarn: Don't always count CASCADINGSOURCES as expensive [core] - 10https://gerrit.wikimedia.org/r/107714 [21:12:17] (03CR) 10Aude: "please excuse our bot ;)" [core] - 10https://gerrit.wikimedia.org/r/107711 (owner: 10Aaron Schulz) [21:12:19] (03CR) 10WikidataJenkins: "Build failed." [core] - 10https://gerrit.wikimedia.org/r/107714 (owner: 10Jackmcbarn) [21:12:34] um, what?? [21:12:47] oh. not just me [21:12:50] disregard me [21:13:12] (03CR) 10Aude: "please excuse the bot ;)" [core] - 10https://gerrit.wikimedia.org/r/107714 (owner: 10Jackmcbarn) [21:13:24] ignore the bot [21:13:31] aude: will the "real" jenkins give that V+1? [21:13:35] yeah [21:13:46] ours is for wikidata only and seems to work [21:14:07] (03CR) 10Aude: "ignore the bot" [core] - 10https://gerrit.wikimedia.org/r/107712 (owner: 10Gergő Tisza) [21:15:05] (03PS2) 10Aude: Improve organization of TestsAutoLoader [core] - 10https://gerrit.wikimedia.org/r/96039 [21:15:56] (03Merged) 10jenkins-bot: Fixed wrong usage of $tmpFile in Swift backend [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107713 (owner: 10Aaron Schulz) [21:18:27] (03CR) 10Krinkle: [C: 031] Add AUTHORS.txt [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [21:19:09] (03CR) 10Chad: [C: 032] Fixed wrong usage of $tmpFile in Swift backend [core] - 10https://gerrit.wikimedia.org/r/107711 (owner: 10Aaron Schulz) [21:19:34] (03CR) 10Anomie: [C: 031] "Looks ok, haven't tested" [core] - 10https://gerrit.wikimedia.org/r/107714 (owner: 10Jackmcbarn) [21:21:40] hashar: is there any way to have particular extensions enabled when running tests in jenkins? [21:22:21] (03Merged) 10jenkins-bot: Fixed wrong usage of $tmpFile in Swift backend [core] - 10https://gerrit.wikimedia.org/r/107711 (owner: 10Aaron Schulz) [21:25:39] (03PS1) 10EBernhardson: Utilize LinkBatch for gender, NS_USER, and NS_USER_TALK lookups [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107717 [21:26:59] (03CR) 10Ragesoss: Add AUTHORS.txt (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/107527 (owner: 10Ori.livneh) [21:28:11] (03PS1) 10Hashar: mwcore-docgen: GERRIT_BRANCH > ZUUL_BRANCH [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107718 [21:28:25] (03CR) 10Manybubbles: [C: 032] Refactor all external index tracking into OtherIndex class [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107617 (owner: 10Chad) [21:28:30] (03Merged) 10jenkins-bot: Refactor all external index tracking into OtherIndex class [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107617 (owner: 10Chad) [21:28:32] (03CR) 10Hashar: [C: 032] mwcore-docgen: GERRIT_BRANCH > ZUUL_BRANCH [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107718 (owner: 10Hashar) [21:28:35] (03Merged) 10jenkins-bot: mwcore-docgen: GERRIT_BRANCH > ZUUL_BRANCH [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107718 (owner: 10Hashar) [21:33:57] (03CR) 10Manybubbles: "If you search while the page before the delete hits the index you get a perfect link that takes you to a 404 page with:" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107621 (owner: 10Chad) [21:38:20] (03PS1) 10Manybubbles: Fix forceSearchIndex's deletes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107722 [21:40:31] (03CR) 10Chad: [C: 032] Fix forceSearchIndex's deletes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107722 (owner: 10Manybubbles) [21:40:34] (03Merged) 10jenkins-bot: Fix forceSearchIndex's deletes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107722 (owner: 10Manybubbles) [21:46:48] (03CR) 10Manybubbles: [C: 031] "BTW, this passes all tests in the update suite meaning Cirrus is properly keeping the index up to date reasonably fast in development. Si" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107621 (owner: 10Chad) [21:51:37] (03CR) 10Theopolisme: [C: 04-1] "A problem and some comments" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [21:59:51] (03PS1) 10Mattflaschen: Auto-launch full tour, not just intro [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/107726 [21:59:59] i seem to be good at finding bugs that only occur when you do something nobody in their right mind would do [22:08:11] hey what is it that automatically locks the DB when slaves are lagged [22:08:15] and how does it figure out the lag? [22:08:26] werdna: LoadBalancer.php I think [22:08:35] Or LBFactory, one of those [22:08:36] andrew-macbook:core andrew$ ack -i 'readonly_lag' includes/ [22:08:36] andrew-macbook:core andrew$ [22:08:39] * werdna wtfs [22:08:40] On the cluster it's LBFactory_multi [22:08:58] It figures out the lag by sending SHOW SLAVE STATUS queries I think [22:10:04] ebernhardson: ^^ [22:10:11] RoanKattouw: we're trying to run a deliberately lagged slave [22:10:24] but we keep getting The administrator who locked it offered this explanation: The database has been automatically locked while the slave database servers catch up to the master [22:11:22] (03PS2) 10Chad: Avoid loading revisions for every search result [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107621 [22:11:29] lockfile doesn't seem to exist [22:12:05] Right [22:12:26] So you want it to continue despite the lagged slave? [22:12:28] (03CR) 10Manybubbles: [C: 032] Avoid loading revisions for every search result [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107621 (owner: 10Chad) [22:12:33] (03Merged) 10jenkins-bot: Avoid loading revisions for every search result [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107621 (owner: 10Chad) [22:12:52] here we go [22:12:54] load balancer [22:12:54] 250: $wgReadOnly = 'The database has been automatically locked ' . [22:13:01] are you using 'fake lag'? [22:13:03] 243: if ( $wgReadOnly || $this->mAllowLagged || $laggedSlaveMode ) { [22:13:09] ebernhardson: looks like there's a config option [22:13:13] should be < 5 sec [22:13:17] or you will get that [22:14:13] AaronSchulz: oh, we are using pt-slave-delay [22:14:25] AaronSchulz: trying to reproduce an issue caused in prod by slave lag [22:14:46] We can set allowLagged on the LB config [22:14:55] sometimes the MW fake lag stuff is enough (since use end up with two conns to the DB in different isolations (one that can't see the changes of the other) [22:15:10] but I can imagine cases were you might need real lag and stale results in general [22:20:02] ebernhardson: so are you fixing this or should I? [22:21:23] werdna: you can, looks like you have an idea where your going [22:21:33] werdna: if you have to tweak the LBFactoryMulti config, thats in orig/LocalSettings.php [22:21:42] It *looks* that way [22:22:11] are you editing it now? [22:22:15] Found a swap file by the name "/var/tmp/LocalSettings.php.swp" [22:22:35] i just exited [22:22:42] and there is a . before that :P [22:25:53] hmph, actually it looks like I can't add it to the config [22:26:25] if ( $lag === false ) { [22:26:26] wfDebugLog( 'replication', "Server #$i is not replicating\n" ); [22:26:26] unset( $loads[$i] ); [22:27:16] hmph, so we can either hack LBFactoryMulti, hack LoadBalancer, or use a different lagging mechanism [22:27:24] it actually shouldn't be lagged at all right now, i turned off pt-slave-lag 10 minutes ago [22:27:31] they both report the same position in the replication log [22:27:35] ebernhardson: right, is it replicating though? [22:28:00] werdna: yea, you can check with mysql --defaults-file=/etc/mysql/my-slave.cnf -e "show slave status" [22:28:23] actually [22:28:27] ERROR 1227 (42000) at line 1: Access denied; you need (at least one of) the SUPER,REPLICATION CLIENT privilege(s) for this operation [22:28:29] werdna: yea, you can check with mysql --defaults-file=/etc/mysql/my-slave.cnf -e "show slave status\G" -u root -pvagrant [22:29:29] werdna: and the master with mysql -u root -e "show master status\G" [22:30:09] > var_dump( $lb->getLagTimes() ) [22:30:09] array(2) { [22:30:09] [0]=> [22:30:09] int(0) [22:30:09] [1]=> [22:30:11] bool(false) [22:30:13] } [22:32:20] (03PS1) 10Chad: Less static Result(Set) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107729 [22:32:20] yea i wasn't sure what that false means [22:32:36] see includes/db/DatabaseMysqlBase.php, line 627 [22:32:54] my guess is that the wiki user doesn't have the right to use SHOW SLAVE STATUS [22:33:20] I bet it's trying to log in with root / no password and getting a permission denied error? [22:33:43] because you gave me a different username / password for the slave to the master [22:34:00] heh, thats probably it [22:34:12] because its not a vagrant server, but i re-used the config [22:34:34] you should be able to tweak that the same way the port 4306 sneaks in [22:34:41] with the masterTemplatOverride [22:34:43] (03PS2) 10Manybubbles: Move boost-templates into other operator handling [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107505 (owner: 10Chad) [22:38:17] (03CR) 10EBernhardson: [C: 04-1] "I dont think this will work as intended, the cache is typically a BufferedCache implementation. which just stuffs this request into an ar" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107377 (owner: 10Matthias Mullie) [22:39:32] ebernhardson: okay now it's broken \o/ [22:39:33] (Cannot contact the database server: Access denied for user 'root'@'localhost' (using password: YES) (127.0.0.1)) [22:39:43] (03PS2) 10EBernhardson: Move tests to Flow\Tests namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107561 (owner: 10Matthias Mullie) [22:40:07] werdna: :) [22:40:40] okay it's the slave that's broken [22:41:04] werdna: perhaps mysql grants? [22:41:14] well we're using the same user/password, no? [22:41:22] or I got it the wrong way around [22:41:35] it looks right to my eyes [22:42:00] hmph [22:42:33] oh, yea it is. slave is only accepting unix socket connections i think [22:42:40] GRANT ALL PRIVILEGES ON *.* TO 'root'@'localhost' [22:42:47] sql [22:43:40] werdna: needs identified by [22:43:51] just did this and then realised how dumb of an idea it was [22:43:51] GRANT ALL PRIVILEGES ON *.* TO 'root'@'localhost' [22:43:59] * werdna quickly runs mysql> revoke all on *.* from root@'%'; [22:44:52] tried this, didn't work: grant all on *.* to root@'127.0.0.1' identified by 'vagrant' with grant option; [22:45:00] werdna: that now revoked socket access too :P [22:45:03] * ebernhardson fixes with mysqladmin [22:45:40] mysql> grant all on *.* to root@'localhost' identified by 'vagrant' with grant option; [22:45:40] Query OK, 0 rows affected (0.00 sec) [22:45:55] urgh mysql permissions are the worst [22:46:33] (03CR) 10Manybubbles: "Works with the small addition of a trim( $val, '"' )." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107505 (owner: 10Chad) [22:47:29] werdna: shrug .. just comment the slave and leave it for another day [22:47:30] ok now I'm just lost [22:48:12] done [22:48:32] I don't know how it was working before though [22:48:40] surely adding the correct user + password shouldn't have broken it? [22:49:26] just set it back to normal password, and now it's broken in that different way now [22:49:27] bleh [22:49:31] maybe it's just connecting wrong? [22:49:36] ohhhhh [22:49:41] I bet that's it [22:49:50] I bet it's actually connecting to the master [22:50:20] would explain the slave not running and the permissions issue [22:50:33] maybe masterTemplateOverrides isn't being applied correctly [22:50:57] hmm, var_dump( wfGetDB( DB_SLAVE ) ); looks to have the right port [22:51:16] oh, not anymore [22:51:19] it did last night :P [22:51:21] maybe it's connecting with a unix domain socket [22:51:32] oh, because its commented out now :) [22:51:35] (03CR) 10Cscott: [C: 032] Add childSelector/childSelectorAll helpers. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107586 (owner: 10Cscott) [22:51:56] (03Merged) 10jenkins-bot: Add childSelector/childSelectorAll helpers. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107586 (owner: 10Cscott) [22:52:09] (03PS2) 10Mattflaschen: Change how presence of VisualEditor is determined [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/107631 [22:53:13] (03CR) 10Manybubbles: [C: 032] "Verified locally after small fix. Merging." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107505 (owner: 10Chad) [22:53:23] (03Merged) 10jenkins-bot: Move boost-templates into other operator handling [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107505 (owner: 10Chad) [22:54:23] (03CR) 10Catrope: [C: 032] Change how presence of VisualEditor is determined [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/107631 (owner: 10Mattflaschen) [22:54:26] (03Merged) 10jenkins-bot: Change how presence of VisualEditor is determined [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/107631 (owner: 10Mattflaschen) [22:57:11] (03CR) 10Bsitu: [C: 031] [SCHEMA CHANGE] Shorten uuids to 88 bits. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [23:00:48] (03CR) 10Bsitu: [C: 031] "getAlphaDecimal() is better and more descriptive function name than getPretty()" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 (owner: 10EBernhardson) [23:04:14] (03PS2) 10Jackmcbarn: Allow InputBoxes to be used to move pages [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/97559 [23:08:40] bd808, ori: Hie ori, hie bd808, I am completed with all the installation of the wikimedia vagrant, thought pip still doesn't takes my proxy. I was going through Bugzilla to look for something which I could start with but it I am little confused. Can you please assist me with an Initial task so that I understand how to work? [23:08:49] (03CR) 10Jdlrobson: "I suspect it would be good to explore as a standalone extension which uses the php implementation of kss?" [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [23:10:21] Adi__: Have you looked at https://www.mediawiki.org/wiki/Starter_kit ? [23:10:46] all right. [23:11:37] (03PS1) 10Werdna: Add quick and dirty script to convert a Flow page to text. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107733 [23:13:32] (03PS1) 10Mattflaschen: Change how presence of VisualEditor is determined [extensions/GettingStarted] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/107734 [23:13:48] (03PS1) 10Mattflaschen: Change how presence of VisualEditor is determined [extensions/GettingStarted] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107735 [23:14:06] superm401: can you elaborate what the problem is here > https://gerrit.wikimedia.org/r/#/c/107513/2/VectorBeta.php ? [23:15:10] jdlrobson, key should be remoteExtPath. [23:15:29] ahhh thanks superm401 :D [23:15:37] jdlrobson, no problem. :) [23:16:10] (03PS3) 10Jdlrobson: Fix image paths [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107513 [23:16:13] superm401: fixed :D ^ [23:17:22] (03CR) 10Mattflaschen: [C: 032] "Fix verified locally." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107513 (owner: 10Jdlrobson) [23:17:25] (03Merged) 10jenkins-bot: Fix image paths [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107513 (owner: 10Jdlrobson) [23:19:00] (03CR) 10EBernhardson: [C: 04-1] "Needs lower case Redlinker to match class name. Php doesn't care, but the auto loader does." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107561 (owner: 10Matthias Mullie) [23:19:22] (03CR) 10Bsitu: [C: 031] Fix warning [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107150 (owner: 10Matthias Mullie) [23:19:42] (03PS3) 10EBernhardson: Move tests to Flow\Tests namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107561 (owner: 10Matthias Mullie) [23:19:56] (03CR) 10EBernhardson: [C: 032] Move tests to Flow\Tests namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107561 (owner: 10Matthias Mullie) [23:19:59] (03Merged) 10jenkins-bot: Move tests to Flow\Tests namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107561 (owner: 10Matthias Mullie) [23:20:07] (03PS3) 10EBernhardson: Add fromStorageRow -> toStorageRow roundtrip test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107560 (owner: 10Matthias Mullie) [23:22:19] (03CR) 10Spage: "That would be getAlphadecimal(), "alphadecimal" is one word." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 (owner: 10EBernhardson) [23:23:20] (03CR) 10EBernhardson: [C: 032] Add fromStorageRow -> toStorageRow roundtrip test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107560 (owner: 10Matthias Mullie) [23:23:25] (03Merged) 10jenkins-bot: Add fromStorageRow -> toStorageRow roundtrip test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107560 (owner: 10Matthias Mullie) [23:23:36] (03PS2) 10EBernhardson: Use PostRevisionTestCase helper method to build PostRevision object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107563 (owner: 10Matthias Mullie) [23:33:42] (03CR) 10EBernhardson: [C: 032] Use PostRevisionTestCase helper method to build PostRevision object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107563 (owner: 10Matthias Mullie) [23:33:47] (03Merged) 10jenkins-bot: Use PostRevisionTestCase helper method to build PostRevision object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107563 (owner: 10Matthias Mullie) [23:35:05] Wow gerrit [23:35:11] Get your head in the game [23:38:18] (03PS3) 10EBernhardson: Test for SpamRegex integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107568 (owner: 10Matthias Mullie) [23:42:08] (03CR) 10Bsitu: refs 58880 - Implement better scrolling via conditionalScroll Refactor ui.js to a cleaner and simpler format (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107580 (owner: 10SG) [23:43:33] (03CR) 10EBernhardson: [C: 032] Test for SpamRegex integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107568 (owner: 10Matthias Mullie) [23:43:39] (03Merged) 10jenkins-bot: Test for SpamRegex integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107568 (owner: 10Matthias Mullie) [23:43:45] (03CR) 10Werdna: [C: 031] "Looks fine" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107717 (owner: 10EBernhardson) [23:46:24] (03CR) 10EBernhardson: [C: 04-1] Utilize LinkBatch for gender, NS_USER, and NS_USER_TALK lookups (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107717 (owner: 10EBernhardson) [23:47:51] (03CR) 10Werdna: Utilize LinkBatch for gender, NS_USER, and NS_USER_TALK lookups (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107717 (owner: 10EBernhardson) [23:50:46] (03CR) 10EBernhardson: Test for SpamBlacklist integration (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107569 (owner: 10Matthias Mullie) [23:51:51] (03CR) 10Aklapper: [C: 04-1] "Thanks! Some small comments: Your patch seems to mix tabs and whitespaces for indentation - please keep this consistent. Also, the commit " [core] - 10https://gerrit.wikimedia.org/r/106320 (owner: 10AalekhN) [23:57:45] (03CR) 10Aklapper: [C: 04-1] "See inline comments (mostly style improvements)" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/106625 (owner: 10AalekhN)