[00:01:25] (03CR) 10Gergő Tisza: "It is based on that for historical reasons (used to be part of the second blacklist patch, it was easier to just split the commit than to " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107267 (owner: 10Gergő Tisza) [00:04:19] (03CR) 10Alex Monk: "Okay, please rebase then" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107267 (owner: 10Gergő Tisza) [00:05:54] (03PS1) 10MarkAHershberger: rel notes [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107270 [00:06:37] (03PS1) 10Kaldari: Update MobileFrontend [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/107271 [00:07:06] 'D:\programming\mediawiki\extensions\Spreadsheet\lib\spreadsheet-js\lib\highcharts\samples\data\AAPL.txt' (78 megabytes) [00:07:19] (03CR) 10MarkAHershberger: [C: 032] rel notes [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107270 (owner: 10MarkAHershberger) [00:09:29] (03PS5) 10Gergő Tisza: A way to blacklist flickr users. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [00:09:32] (03PS2) 10Gergő Tisza: Refactor Flickr API calls [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107267 [00:10:44] (03CR) 10jenkins-bot: [V: 04-1] rel notes [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107270 (owner: 10MarkAHershberger) [00:13:29] (03Abandoned) 10Kaldari: Update MobileFrontend [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/107271 (owner: 10Kaldari) [00:13:51] (03CR) 10Gergő Tisza: "PhpStorm tends to automatically un-fix bracket spacing :( I think I got them all now." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107267 (owner: 10Gergő Tisza) [00:29:24] (03PS1) 10Kaldari: Update MobileFrontend [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/107272 [00:29:38] (03CR) 10Kaldari: [C: 032 V: 032] Update MobileFrontend [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/107272 (owner: 10Kaldari) [00:32:26] (03PS1) 10MarkAHershberger: bump version number [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107273 [00:34:10] (03CR) 10MarkAHershberger: [C: 032] bump version number [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107273 (owner: 10MarkAHershberger) [00:37:11] (03Merged) 10jenkins-bot: bump version number [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107273 (owner: 10MarkAHershberger) [00:43:27] (03CR) 10BryanDavis: [C: 031] json-lint.php: recursively lint json files with PHP [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107163 (owner: 10Hashar) [00:44:48] (03PS13) 10Aarcos: Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [00:49:46] (03CR) 10Aarcos: "Hi there folks," [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [00:52:58] (03PS1) 10CSteipp: SECURITY: Fix RevDel log entry information leaks [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/107276 [00:53:00] (03PS1) 10CSteipp: SECURITY: Return error on invalid XML for SVGs [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/107277 [00:53:02] (03PS1) 10CSteipp: SECURITY: Disallow -o-link in styles [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/107278 [00:53:04] (03PS1) 10CSteipp: SECURITY: Don't normalize U+FF3C to \ [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/107279 [00:53:06] (03PS1) 10CSteipp: SECURITY: Disallow stylesheets in svg [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/107280 [00:55:23] (03PS1) 10Reedy: Swap hook subscribers for Closures/Anonymous functions etc [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/107281 [00:56:47] (03CR) 10MarkAHershberger: [C: 032] SECURITY: Fix RevDel log entry information leaks [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/107276 (owner: 10CSteipp) [00:57:16] (03CR) 10MarkAHershberger: [C: 032] SECURITY: Disallow stylesheets in svg [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/107280 (owner: 10CSteipp) [00:58:14] (03CR) 10MarkAHershberger: [C: 032] SECURITY: Don't normalize U+FF3C to \ [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/107279 (owner: 10CSteipp) [00:58:44] (03CR) 10MarkAHershberger: [C: 032] SECURITY: Disallow -o-link in styles [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/107278 (owner: 10CSteipp) [00:59:17] (03CR) 10MarkAHershberger: [C: 032] SECURITY: Return error on invalid XML for SVGs [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/107277 (owner: 10CSteipp) [01:02:46] (03PS1) 10Mglaser: SECURITY: Disallow stylesheets in svg [core] - 10https://gerrit.wikimedia.org/r/107282 [01:06:18] (03PS1) 10MarkAHershberger: bump to 1.19.10 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/107283 [01:06:48] (03PS11) 10Theopolisme: Create jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/99021 [01:06:59] marktraceur: ^ [01:07:03] (03PS1) 10Reedy: Simplify/reorder SkinCopyrightFooter subscriber [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/107284 [01:07:49] (03CR) 10MarkAHershberger: [C: 032] bump to 1.19.10 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/107283 (owner: 10MarkAHershberger) [01:08:37] theopolisme: Grazie, maybe we can get this out this week [01:08:41] I'll work on it tomorrow [01:09:17] (03PS1) 10Mglaser: SECURITY: Disallow -o-link in styles [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107285 [01:10:07] (03Merged) 10jenkins-bot: bump to 1.19.10 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/107283 (owner: 10MarkAHershberger) [01:10:32] (03CR) 10Theopolisme: "Licensing issues should be resolved." [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [01:10:50] (03PS1) 10Mwalker: Renaming to a more cannonical mw-ocg-service [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107286 [01:11:12] (03CR) 10jenkins-bot: [V: 04-1] Renaming to a more cannonical mw-ocg-service [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107286 (owner: 10Mwalker) [01:11:15] (03PS1) 10Mglaser: SECURITY: Return error on invalid XML for SVGs [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107287 [01:11:46] (03CR) 10MarkAHershberger: [C: 032] SECURITY: Disallow stylesheets in svg [core] - 10https://gerrit.wikimedia.org/r/107282 (owner: 10Mglaser) [01:12:07] (03PS1) 10Mglaser: SECURITY: Fix RevDel log entry information leaks [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107288 [01:12:16] (03CR) 10MarkAHershberger: [C: 032] SECURITY: Return error on invalid XML for SVGs [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107287 (owner: 10Mglaser) [01:12:43] (03CR) 10MarkAHershberger: [C: 032] SECURITY: Disallow -o-link in styles [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107285 (owner: 10Mglaser) [01:13:28] (03PS2) 10Mwalker: Renaming to a more cannonical mw-ocg-service [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107286 [01:14:39] (03CR) 10jenkins-bot: [V: 04-1] Renaming to a more cannonical mw-ocg-service [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107286 (owner: 10Mwalker) [01:16:12] (03CR) 10jenkins-bot: [V: 04-1] SECURITY: Return error on invalid XML for SVGs [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107287 (owner: 10Mglaser) [01:16:43] (03Merged) 10jenkins-bot: SECURITY: Disallow stylesheets in svg [core] - 10https://gerrit.wikimedia.org/r/107282 (owner: 10Mglaser) [01:17:10] (03PS3) 10Mwalker: Renaming to a more cannonical mw-ocg-service [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107286 [01:17:21] (03PS1) 10Kaldari: Update MobileFrontend [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107290 [01:17:26] (03CR) 10jenkins-bot: [V: 04-1] SECURITY: Fix RevDel log entry information leaks [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107288 (owner: 10Mglaser) [01:17:30] (03CR) 10Kaldari: [C: 032 V: 032] Update MobileFrontend [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107290 (owner: 10Kaldari) [01:17:45] (03PS1) 10Mglaser: SECURITY: Disallow stylesheets in svg [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107291 [01:18:19] (03CR) 10MarkAHershberger: [C: 032] SECURITY: Fix RevDel log entry information leaks [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107288 (owner: 10Mglaser) [01:19:27] (03CR) 10MarkAHershberger: [C: 032] SECURITY: Disallow stylesheets in svg [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107291 (owner: 10Mglaser) [01:19:43] (03CR) 10MarkAHershberger: [V: 032] SECURITY: Disallow stylesheets in svg [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107291 (owner: 10Mglaser) [01:20:13] (03CR) 10Mglaser: "This should have been on REL1_22 branch. Gerrit doesn't let me abandon the change. Maybe because there's an attempt to cherry pick? I'll t" [core] - 10https://gerrit.wikimedia.org/r/107282 (owner: 10Mglaser) [01:21:33] (03CR) 10Mwalker: [C: 032] Renaming to a more cannonical mw-ocg-service [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107286 (owner: 10Mwalker) [01:21:46] (03CR) 10MarkAHershberger: [V: 032] SECURITY: Fix RevDel log entry information leaks [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107288 (owner: 10Mglaser) [01:22:54] (03Merged) 10jenkins-bot: SECURITY: Disallow -o-link in styles [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107285 (owner: 10Mglaser) [01:24:03] (03CR) 10MarkAHershberger: [V: 032] SECURITY: Return error on invalid XML for SVGs [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107287 (owner: 10Mglaser) [01:28:53] (03CR) 10MarkAHershberger: SECURITY: Return error on invalid XML for SVGs [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107287 (owner: 10Mglaser) [01:29:01] (03CR) 10MarkAHershberger: [C: 032 V: 032] SECURITY: Return error on invalid XML for SVGs [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107287 (owner: 10Mglaser) [01:30:23] (03PS6) 10Gergő Tisza: A way to blacklist flickr users. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [01:31:51] (03CR) 10Gergő Tisza: "Modified to work with usernames as well as NSIDs." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [01:32:15] (03PS2) 10MarkAHershberger: SECURITY: Fix RevDel log entry information leaks [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/107276 (owner: 10CSteipp) [01:32:40] (03CR) 10MarkAHershberger: [C: 032 V: 032] SECURITY: Fix RevDel log entry information leaks [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/107276 (owner: 10CSteipp) [01:33:41] (03CR) 10jenkins-bot: [V: 04-1] SECURITY: Return error on invalid XML for SVGs [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107287 (owner: 10Mglaser) [01:35:59] (03PS1) 10CSteipp: SECURITY: Fix RevDel log entry information leaks [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/107293 [01:36:01] (03PS1) 10CSteipp: SECURITY: Return error on invalid XML for SVGs [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/107294 [01:36:03] (03PS1) 10CSteipp: SECURITY: Disallow -o-link in styles [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/107295 [01:36:05] (03PS1) 10CSteipp: SECURITY: Don't normalize U+FF3C to \ [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/107296 [01:36:08] (03PS1) 10CSteipp: SECURITY: Disallow stylesheets in svg [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/107297 [01:36:10] (03PS1) 10CSteipp: Update Releasenotes and version number for 1.21.4 [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/107298 [01:37:53] marktraceur, legoktm: Is https://bugzilla.wikimedia.org/show_bug.cgi?id=54905 still deserving of the "Major","High" tuple? If so, what's the treatment we can give? [01:41:53] (03CR) 10MarkAHershberger: [C: 032 V: 032] SECURITY: Fix RevDel log entry information leaks [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/107293 (owner: 10CSteipp) [01:42:18] James_F: We discussed it and thought it might be a performance issue, legoktm may submit another patchset [01:42:22] Er wait [01:42:26] No [01:42:29] Because that may work [01:42:47] James_F: Message pre-opening-link is directed at the popup [01:44:17] (03CR) 10MarkAHershberger: [C: 032 V: 032] SECURITY: Return error on invalid XML for SVGs [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/107294 (owner: 10CSteipp) [01:44:40] (03CR) 10MarkAHershberger: [C: 032 V: 032] SECURITY: Disallow -o-link in styles [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/107295 (owner: 10CSteipp) [01:44:55] (03CR) 10MarkAHershberger: [C: 032 V: 032] SECURITY: Don't normalize U+FF3C to \ [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/107296 (owner: 10CSteipp) [01:45:23] (03CR) 10MarkAHershberger: [C: 032 V: 032] SECURITY: Disallow stylesheets in svg [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/107297 (owner: 10CSteipp) [01:45:58] (03CR) 10MarkAHershberger: [C: 032 V: 032] Update Releasenotes and version number for 1.21.4 [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/107298 (owner: 10CSteipp) [01:48:19] (03PS1) 10CSteipp: SECURITY: Improve css javascript detection [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107301 [01:48:58] (03PS1) 10Mwalker: Actually allow a custom config file [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107302 [01:49:10] (03PS1) 10CSteipp: SECURITY: Don't cache when a call could autocreate [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107303 [01:49:55] (03CR) 10CSteipp: [C: 032] SECURITY: Improve css javascript detection [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107301 (owner: 10CSteipp) [01:50:44] (03CR) 10Reedy: [C: 032] Remove AssertEdit [tools/release] - 10https://gerrit.wikimedia.org/r/106544 (owner: 10Reedy) [01:51:37] (03CR) 10MarkAHershberger: [C: 032 V: 032] SECURITY: Don't cache when a call could autocreate [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107303 (owner: 10CSteipp) [01:51:45] (03Merged) 10jenkins-bot: Remove AssertEdit [tools/release] - 10https://gerrit.wikimedia.org/r/106544 (owner: 10Reedy) [01:52:28] (03CR) 10MarkAHershberger: [C: 032 V: 032] SECURITY: Improve css javascript detection [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107301 (owner: 10CSteipp) [01:59:06] (03PS7) 10Gergő Tisza: A way to blacklist flickr users. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [02:02:53] (03PS1) 10CSteipp: Update Releasenotes and version number for 1.19.10 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/107304 [02:05:17] (03CR) 10Gergő Tisza: "Now works with lists." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [02:11:04] (03PS1) 10Adamw: Initial commit: contrib and git bookkeeping [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/107306 [02:11:06] (03PS1) 10Adamw: Basic state machinery [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/107307 [02:14:34] (03PS1) 10MarkAHershberger: Revert "SECURITY: Fix RevDel log entry information leaks" [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/107309 [02:16:27] (03Abandoned) 10MarkAHershberger: Revert "SECURITY: Fix RevDel log entry information leaks" [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/107309 (owner: 10MarkAHershberger) [02:40:43] (03PS1) 10Mwalker: I apparently refactored something -- now we can download [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107311 [02:41:01] (03CR) 10Mwalker: [C: 032] Actually allow a custom config file [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107302 (owner: 10Mwalker) [02:41:18] (03CR) 10Mwalker: [C: 032] I apparently refactored something -- now we can download [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107311 (owner: 10Mwalker) [02:53:33] (03PS1) 10Mwalker: More refactor damage [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107312 [02:53:59] (03CR) 10Mwalker: [C: 032] More refactor damage [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107312 (owner: 10Mwalker) [02:56:00] (03PS1) 10Ebe123: Use namespace ID for Module: namespace This commit changes all the proper names for namespaces into their IDs. This change was meant for the Module: and Module_talk: namespaces (ID 828 and 829 respectivily) specifically, but for consistancy in the array, [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/107313 [02:57:46] (03PS1) 10MarkAHershberger: Revert "bump to 1.19.10" [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/107314 [02:58:18] (03CR) 10MarkAHershberger: [C: 032 V: 032] Revert "bump to 1.19.10" [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/107314 (owner: 10MarkAHershberger) [03:00:08] (03CR) 10MarkAHershberger: [C: 032 V: 032] Update Releasenotes and version number for 1.19.10 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/107304 (owner: 10CSteipp) [03:10:32] anyone know what it takes to get gerrit to move something from "merge pending" to "merged"? [03:10:54] * hexmode looks for someone not away [03:11:01] I thought jenkins-bot did that. [03:11:31] Gloria: :) maybe but then what about these: https://gerrit.wikimedia.org/r/#/q/owner:%22CSteipp+%253Ccsteipp%2540wikimedia.org%253E%22,n,z [03:12:16] I've seen submitted before... I forget why it happens. [03:12:20] It came up in making Gerrit reports. [03:12:31] I'm gonna try something. [03:12:34] Ryan_Lane might know. [03:12:52] btw, Gloria, I don't think we've met. So: hello! [03:13:09] Hi. :-) [03:14:42] I think I messed it up. It is probably my fault. Was trying to submit to get around recurrances of https://bugzilla.wikimedia.org/show_bug.cgi?id=58094 [03:15:42] hexmode: gloria = mz [03:15:57] So much outing. [03:15:57] oh, gloria [03:16:17] Ryan_Lane: are you not with the wmf any more? [03:16:26] I am not [03:16:39] But still with Wikimedia. <3 [03:17:08] And we've both lived in NOLA [03:17:21] * hexmode thinks Ryan_Lane is his BFF :P [03:17:29] :D [03:18:02] Ryan_Lane: Hmm, will you be around for the Architecture Summit? [03:18:23] Gloria: will you? [03:18:29] (03CR) 10Mayankmadan: "Aarcos, I don't understand what was wrong with the supplyParams and the createRequest function? There is a lot of course that is being dup" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [03:18:33] I'll be in SF from January 22 to January 26. [03:18:41] Wednesday to Sunday. [03:18:45] You? [03:18:49] \o/ [03:18:50] yep [03:18:54] wed-sat [03:19:00] (03CR) 10Mayankmadan: "*code" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [03:19:06] Neat. :-) [03:19:10] wed evening -> sat afternoon [03:19:16] Gloria: I won't [03:19:22] LAME. [03:19:28] I'll be in SF, though, of course [03:19:35] Crash! [03:19:49] maybe I'll get lunch/dinner with folks [03:19:55] well, I'll be working another job ;) [03:20:01] Pffffft. [03:20:10] Yes, lunch/dinner would be nice. [03:20:11] Ryan_Lane is MW enterprise! [03:20:15] :D [03:20:23] It counts as professional development for my job. [03:20:25] I'm working for a ride sharing company called Lyft [03:20:29] Because we use MediaWiki internally. [03:20:51] there's nothing I could do for wikimedia that would count as professional development ;) [03:20:52] Ryan_Lane: Doing ops? [03:20:58] devops, yeah [03:21:02] Nice. [03:21:16] Ryan_Lane: my client (huge MW internal company) wants to host a MW enterprise thing in houston. I'm gonna tell them to contact Lyft, too. [03:21:45] heh. we use atlassian tools ;) [03:21:49] lame [03:22:09] they did say not-mw-centric [03:22:23] but I'm trying to tell them all other wikis suck [03:22:39] honestly confluence is good for enterprise users [03:22:50] no doubt [03:23:00] though I prefer MW, it's such a pain in the ass to get to a usable state [03:23:04] I'm too freetarded for it. [03:23:23] And wikitext. [03:23:30] and wikitext, yes [03:23:32] which is why I'm surprised that $CLIENT uses MW [03:23:36] Users are hopeless. :-( [03:23:43] though for what most people need VE would work fine [03:23:53] but I think it had more to do with the way it was introduced [03:24:18] w/o IT, that is [03:24:26] so go with the free one. [03:24:38] well, it could be moinmoin [03:24:38] the one that runs Wikipedia [03:24:50] I switched openstack to MW [03:24:59] actually, I need to fix a skin issue for them [03:25:02] for ULS [03:25:03] (03PS1) 10Ottomata: Updating list-roles helper regex [vagrant] - 10https://gerrit.wikimedia.org/r/107316 [03:25:05] (03PS1) 10Ottomata: Adding role::hadoop and role::hive [vagrant] - 10https://gerrit.wikimedia.org/r/107317 [03:25:08] so that they can use translate [03:25:21] (I used the strapping skin for them) [03:25:21] * Gloria bites tongue. [03:33:45] (03PS7) 10Bsitu: Topic and Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 [03:35:12] (03CR) 10Bsitu: [C: 04-2] Topic and Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu) [03:35:21] (03CR) 10Andrew Bogott: [C: 031] "Looks good -- one very unimportant comment inline." (031 comment) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/104320 (owner: 10Ryan Lane) [03:37:40] (03PS9) 10Bsitu: Topic and Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 [03:37:59] hexmode: Did you figure out the submitted thing? [03:38:06] I will [03:38:12] Okay. Chad may be aroudn. [03:38:13] I was taking a break [03:38:14] around [03:38:25] ^d: around? [03:38:43] <^d> Trying not to be :p [03:38:45] <^d> What's up? [03:39:41] ^d: feel free to tell me you don't have time, but I'm trying to figure out this: https://gerrit.wikimedia.org/r/#/q/owner:%22CSteipp+%253Ccsteipp%2540wikimedia.org%253E%22,n,z [03:40:10] why do so many have "merge pending" and how can I get them merged? [03:40:31] <^d> Well, the parent in that change has to merge before the chain will. [03:40:33] I think it has to do with https://gerrit.wikimedia.org/r/#/c/107277/ [03:40:38] (03PS1) 10Pastakhov: fix property 'zoom' for google map api (version 0.5.1) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/107318 [03:40:39] <^d> Yep. [03:40:48] <^d> Press rebase button on that one and all should be magic. [03:41:01] nope, no auto rebase [03:41:10] unless something has changed [03:41:15] * hexmode tries again [03:41:42] I'll try to manually rebase [03:41:47] <^d> `git fetch --all` [03:41:51] <^d> `git fetch https://gerrit.wikimedia.org/r/mediawiki/core refs/changes/04/107304/1 && git checkout FETCH_HEAD` [03:42:04] <^d> `git rebase origin/REL_19` [03:42:11] <^d> {{solve conflicts}} [03:42:20] <^d> `git push origin HEAD:refs/for/REL1_19` [03:42:29] <^d> lather, rinse, repeat for any other branches. [03:42:38] * hexmode tries [03:43:09] (03PS2) 10Pastakhov: fix property 'zoom' for google map api (version 0.5.1) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/107318 [03:43:51] <^d> I should do a better job of not being here. [03:44:11] <^demon|away> :) [03:44:11] (03CR) 10Pastakhov: [C: 032] fix property 'zoom' for google map api (version 0.5.1) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/107318 (owner: 10Pastakhov) [03:44:21] (03Merged) 10jenkins-bot: fix property 'zoom' for google map api (version 0.5.1) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/107318 (owner: 10Pastakhov) [03:44:38] (03PS1) 10Springle: SpecialContributions: Avoid using 'contributions' slave for getParentLengths [core] - 10https://gerrit.wikimedia.org/r/107319 [03:46:10] (03PS2) 10Legoktm: SpecialContributions: Avoid using 'contributions' slave for getParentLengths [core] - 10https://gerrit.wikimedia.org/r/107319 (owner: 10Springle) [03:47:44] hrm.... no joy [04:21:32] (03PS1) 10CSteipp: SECURITY: Don't normalize U+FF3C to \ [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107320 [04:24:28] (03PS2) 10CSteipp: SECURITY: Return error on invalid XML for SVGs [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107287 (owner: 10Mglaser) [04:36:12] (03PS2) 10CSteipp: rel notes [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107270 (owner: 10MarkAHershberger) [04:37:19] (03CR) 10CSteipp: [C: 032] SECURITY: Don't normalize U+FF3C to \ [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107320 (owner: 10CSteipp) [04:37:53] (03CR) 10CSteipp: [C: 032] SECURITY: Return error on invalid XML for SVGs [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107287 (owner: 10Mglaser) [04:40:37] (03Merged) 10jenkins-bot: SECURITY: Don't normalize U+FF3C to \ [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107320 (owner: 10CSteipp) [04:41:21] (03Merged) 10jenkins-bot: SECURITY: Return error on invalid XML for SVGs [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107287 (owner: 10Mglaser) [04:42:40] (03CR) 10CSteipp: [C: 032] rel notes [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107270 (owner: 10MarkAHershberger) [04:46:02] (03Merged) 10jenkins-bot: rel notes [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107270 (owner: 10MarkAHershberger) [04:55:51] (03PS6) 10Mattflaschen: Client-side wrapper for GettingStartedGetPages API [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103737 [04:56:52] (03CR) 10Mattflaschen: "Done in patch set 6. You just call the subclass constructor when you want to use it. It does not affect regular mw.Api objects." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103737 (owner: 10Mattflaschen) [04:58:46] (03PS1) 10CSteipp: Update Release Notes [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107321 [04:59:05] (03CR) 10CSteipp: [C: 032 V: 032] Update Release Notes [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107321 (owner: 10CSteipp) [05:00:38] I get this on the code review : -Message Qqq missing. Can someone elaborate what it means ? [05:01:25] (03PS8) 10Mattflaschen: Change modal to use API instead of special page, refactor [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103079 [05:04:14] tonythomas01: https://www.mediawiki.org/wiki/Localisation#Adding_new_messages [05:07:41] (03PS5) 10Mattflaschen: WIP: Remove uses of Special:GettingStarted from task toolbar [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103740 [05:09:35] My bug is rearrange the elements under the namespaces select box in alphabetic order. I found the php file which must be changed but I need some guidance on how to proceed. The file is core/core/includes/WatchedItem.php [05:09:36] legoktm: I should have went throught that earlier. Thanks [05:09:45] (03PS3) 10Mattflaschen: Remove Special:GettingStarted and notifications [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/106458 [05:12:57] MaxSem ping [05:15:14] (03PS7) 10Mattflaschen: Client-side wrapper for GettingStartedGetPages API [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103737 [05:16:28] (03CR) 10Mattflaschen: "Sorry, I missed the formatting fix before. That's done now too." (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103737 (owner: 10Mattflaschen) [05:27:15] (03PS3) 1001tonythomas: Gave a new error message for !isValidTiff() [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/107039 [05:39:56] (03PS1) 10Legoktm: Use wfGetCache( CACHE_ANYTHING ) instead of $wgMemc [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/107322 [06:06:30] (03CR) 10CSteipp: "The 1.22 patch was the same as for master. No reason to revert this." [core] - 10https://gerrit.wikimedia.org/r/107282 (owner: 10Mglaser) [06:17:05] (03PS1) 10Cscott: CJK support using the xeCJK package. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107323 [06:17:26] (03CR) 10jenkins-bot: [V: 04-1] CJK support using the xeCJK package. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107323 (owner: 10Cscott) [06:18:11] (03PS2) 10Cscott: CJK support using the xeCJK package. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107323 [06:21:26] (03PS3) 10CSteipp: SECURITY: Added missing auth check in img_auth.php [core] - 10https://gerrit.wikimedia.org/r/104787 (owner: 10Aaron Schulz) [06:21:28] (03PS1) 10CSteipp: SECURITY: Don't normalize U+FF3C to \ [core] - 10https://gerrit.wikimedia.org/r/107324 [06:21:30] (03PS1) 10CSteipp: SECURITY: Disallow -o-link in styles [core] - 10https://gerrit.wikimedia.org/r/107325 [06:21:32] (03PS1) 10CSteipp: SECURITY: Return error on invalid XML for SVGs [core] - 10https://gerrit.wikimedia.org/r/107326 [06:21:34] (03PS1) 10CSteipp: SECURITY: Fix RevDel log entry information leaks [core] - 10https://gerrit.wikimedia.org/r/107327 [06:33:18] I have to rename 'userrights' to 'usergroups' in special pages. Is the specials directory in includes in the core repo the right one? The bug is https://bugzilla.wikimedia.org/show_bug.cgi?id=44205 [06:39:19] (03PS1) 10Qgil: Remove background color of footer in email notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/107328 [06:40:38] (03CR) 10CSteipp: [C: 032] "Already in production" [core] - 10https://gerrit.wikimedia.org/r/107324 (owner: 10CSteipp) [06:41:02] (03CR) 10CSteipp: [C: 032] "Already in production" [core] - 10https://gerrit.wikimedia.org/r/104787 (owner: 10Aaron Schulz) [06:44:04] (03Merged) 10jenkins-bot: SECURITY: Added missing auth check in img_auth.php [core] - 10https://gerrit.wikimedia.org/r/104787 (owner: 10Aaron Schulz) [06:44:45] (03Merged) 10jenkins-bot: SECURITY: Don't normalize U+FF3C to \ [core] - 10https://gerrit.wikimedia.org/r/107324 (owner: 10CSteipp) [06:46:42] (03PS1) 10CSteipp: Fix Lua stack overflow [php/luasandbox] - 10https://gerrit.wikimedia.org/r/107329 [06:46:44] (03PS1) 10CSteipp: Handle invalid keys in Lua-to-PHP calls for LuaSandbox [php/luasandbox] - 10https://gerrit.wikimedia.org/r/107330 [06:46:46] (03PS1) 10CSteipp: Update changelog [php/luasandbox] - 10https://gerrit.wikimedia.org/r/107331 [06:47:33] (03CR) 10CSteipp: [C: 032] "Already in production" [core] - 10https://gerrit.wikimedia.org/r/107325 (owner: 10CSteipp) [06:47:54] (03CR) 10CSteipp: [C: 032] "Already on production" [core] - 10https://gerrit.wikimedia.org/r/107326 (owner: 10CSteipp) [06:48:10] (03CR) 10CSteipp: [C: 032] "Already on production" [core] - 10https://gerrit.wikimedia.org/r/107327 (owner: 10CSteipp) [06:48:47] (03CR) 10CSteipp: [C: 032] "Already in production" [php/luasandbox] - 10https://gerrit.wikimedia.org/r/107329 (owner: 10CSteipp) [06:49:05] (03CR) 10CSteipp: [C: 032] "Already in production" [php/luasandbox] - 10https://gerrit.wikimedia.org/r/107330 (owner: 10CSteipp) [06:49:10] (03Merged) 10jenkins-bot: Fix Lua stack overflow [php/luasandbox] - 10https://gerrit.wikimedia.org/r/107329 (owner: 10CSteipp) [06:49:17] (03CR) 10CSteipp: [C: 032] Update changelog [php/luasandbox] - 10https://gerrit.wikimedia.org/r/107331 (owner: 10CSteipp) [06:49:51] (03Merged) 10jenkins-bot: Handle invalid keys in Lua-to-PHP calls for LuaSandbox [php/luasandbox] - 10https://gerrit.wikimedia.org/r/107330 (owner: 10CSteipp) [06:50:16] (03Merged) 10jenkins-bot: Update changelog [php/luasandbox] - 10https://gerrit.wikimedia.org/r/107331 (owner: 10CSteipp) [06:51:08] (03Merged) 10jenkins-bot: SECURITY: Disallow -o-link in styles [core] - 10https://gerrit.wikimedia.org/r/107325 (owner: 10CSteipp) [06:51:11] (03Merged) 10jenkins-bot: SECURITY: Return error on invalid XML for SVGs [core] - 10https://gerrit.wikimedia.org/r/107326 (owner: 10CSteipp) [06:51:52] (03Merged) 10jenkins-bot: SECURITY: Fix RevDel log entry information leaks [core] - 10https://gerrit.wikimedia.org/r/107327 (owner: 10CSteipp) [06:54:01] (03PS1) 10Cscott: Fix TeX "pool overflow" with very long filenames. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107332 [06:55:10] (03CR) 10Cscott: [C: 032] Ensure that image output stream errors are handled. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/107258 (owner: 10Cscott) [06:55:34] (03CR) 10Cscott: [C: 032] Improve error-handling by avoiding use of the promise .done() method. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107257 (owner: 10Cscott) [06:55:56] (03CR) 10Cscott: [C: 032] CJK support using the xeCJK package. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107323 (owner: 10Cscott) [06:56:15] (03PS1) 10Roopak: Re-sized #guider_overlay's z-index [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/107333 [06:56:17] (03Merged) 10jenkins-bot: Improve error-handling by avoiding use of the promise .done() method. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107257 (owner: 10Cscott) [06:56:19] (03Merged) 10jenkins-bot: CJK support using the xeCJK package. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107323 (owner: 10Cscott) [06:56:21] (03CR) 10jenkins-bot: [V: 04-1] Ensure that image output stream errors are handled. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/107258 (owner: 10Cscott) [06:56:29] (03PS1) 10CSteipp: SECURITY: Prevent XSS by 'data-videopayload' [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/107334 [06:56:47] (03CR) 10CSteipp: [C: 032] "Already in production" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/107334 (owner: 10CSteipp) [06:57:09] (03Merged) 10jenkins-bot: SECURITY: Prevent XSS by 'data-videopayload' [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/107334 (owner: 10CSteipp) [06:58:21] (03PS1) 10CSteipp: SECURITY: Don't return username from AutoLogin [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/107336 [06:58:26] (03CR) 10Cscott: [V: 032] "Jenkins failed on a transient network error. Override, since we've independently tested this commit on travis." [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/107258 (owner: 10Cscott) [06:58:42] (03CR) 10CSteipp: [C: 032] "Already in production" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/107336 (owner: 10CSteipp) [06:58:45] (03Merged) 10jenkins-bot: SECURITY: Don't return username from AutoLogin [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/107336 (owner: 10CSteipp) [07:03:31] (03PS2) 10Roopak: Re-sized #guider_overlay's z-index [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/107333 [07:50:37] (03PS1) 10Gerrit Patch Uploader: (Bug 60030) Use $content of the hook for toc hiding [core] - 10https://gerrit.wikimedia.org/r/107337 [07:50:42] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/107337 (owner: 10Gerrit Patch Uploader) [08:00:56] (03CR) 10Cscott: [C: 032] Fix TeX "pool overflow" with very long filenames. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107332 (owner: 10Cscott) [08:01:14] (03Merged) 10jenkins-bot: Fix TeX "pool overflow" with very long filenames. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107332 (owner: 10Cscott) [08:02:10] (03CR) 10Robert Vogel: "Seems to be pretty bleeding edge. SpecialPage::getTitle just get's deprecated in MW 1.23 and SpecialPage::getPageTitle is not available un" [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/103908 (owner: 10Legoktm) [08:03:25] (03CR) 10Robert Vogel: [C: 032 V: 032] "Thank you" [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/106740 (owner: 10Siebrand) [08:04:57] (03CR) 10Hydriz: [C: 04-1] "Any reason why namespace IDs should be used instead of their corresponding constants? It is always preferred to call the defined constants" [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/107313 (owner: 10Ebe123) [08:05:16] (03CR) 10Robert Vogel: [C: 032 V: 032] "Thank you." [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/105955 (owner: 10Siebrand) [08:08:39] (03PS4) 10Gerrit Patch Uploader: Move toctoggle from mediawiki.util.js to separate file mediawiki.toc.js [core] - 10https://gerrit.wikimedia.org/r/106132 [08:08:44] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/106132 (owner: 10Gerrit Patch Uploader) [08:10:15] (03CR) 10Fomafix: (Bug 60030) Use $content of the hook for toc hiding (031 comment) [core] - 10https://gerrit.wikimedia.org/r/107337 (owner: 10Gerrit Patch Uploader) [08:17:57] (03CR) 10Nikerabbit: [C: 032 V: 032] Avoid calling deprecated User::getSkin() [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/106945 (owner: 10Siebrand) [08:19:58] (03CR) 10Nikerabbit: [C: 032 V: 032] Avoid using User::getSkin() [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/106926 (owner: 10Siebrand) [08:20:28] (03CR) 10Nikerabbit: [C: 04-1] Avoid calling User::getSkin and remove pre-1.19 compat (031 comment) [extensions/FacebookOpenGraph] - 10https://gerrit.wikimedia.org/r/106943 (owner: 10Siebrand) [08:20:49] (03CR) 10Nikerabbit: [C: 032] Avoid using deprecated User::getSkin() [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/106935 (owner: 10Siebrand) [08:20:51] (03Merged) 10jenkins-bot: Avoid using deprecated User::getSkin() [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/106935 (owner: 10Siebrand) [08:21:10] (03CR) 10Nikerabbit: [C: 032 V: 032] Call Linker methods statically [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/106941 (owner: 10Siebrand) [08:21:49] (03CR) 10Nikerabbit: [C: 032 V: 032] Avoid using deprecated User::getSkin() [extensions/ShoutWikiAds] - 10https://gerrit.wikimedia.org/r/106940 (owner: 10Siebrand) [08:23:57] (03CR) 10Nikerabbit: [C: 032] Call Linker methods statically [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/106934 (owner: 10Siebrand) [08:23:59] (03Merged) 10jenkins-bot: Call Linker methods statically [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/106934 (owner: 10Siebrand) [08:29:36] The bug I'm currently trying to work on is https://bugzilla.wikimedia.org/show_bug.cgi?id=54749. Here if the f parameter is not specified, changes should be made everywhere. In which function must the changes be made? I'm a newbie to bug-fixing. [08:33:56] (03CR) 10Hydriz: "Also, if you are referring to the fact that this doesn't work, it's due to the sequence of how the WikimediaIncubator extension and the Sc" [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/107313 (owner: 10Ebe123) [09:09:35] Hm, I've come up with some ideas to rationalise interwiki prefixes in MediaWiki and the WMF cluster, and I'm interested in more feedback [09:09:41] is wikitech-l the place to go? [09:10:04] I couldn't find a more specific "MediaWiki development" or "WMF tech" mailing list, wiki-tech-l seems mixed [09:27:18] The bug I'm currently trying to work on is https://bugzilla.wikimedia.org/show_bug.cgi?id=54749. Here if the f parameter is not specified, changes should be made everywhere. In which function must the changes be made? I'm a newbie to bug-fixing, so can someone help me? [09:31:36] arav93, I couldn't know what your question is without making me actively click the link. [09:32:05] You might want to mention at least the area or file location when asking, so people who have expertise in that area could know, when/if they read your question. [09:33:03] hey andre__ [09:33:11] Morning yuvipanda [09:33:19] andre__: I just recategorized https://bugzilla.wikimedia.org/show_bug.cgi?id=60032 but am unsure if that is the correct component / product [09:33:32] since that sounds like a site capacity issue rather than a mediawiki as such issue [09:33:34] andre__: morning! :) [09:35:18] core/core/thumb.php is the file I'm working on . I'm supposed to print all the parameters that the call takes if the f parameter is not present. How am I supposed to do that? Please help. [09:41:57] (03PS2) 10Matthias Mullie: Create stub post object instead of failing completely [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107151 [09:45:47] I'm working on https://bugzilla.wikimedia.org/show_bug.cgi?id=38624 which deals with the Contest.git under Extensions. I'm supposed to rename 'goto this page' link anchor to something better. Please help me for the same. I tried grep -R 'goto this page' * . But that gives nothing at all. [09:46:03] (03PS3) 10Matthias Mullie: Create stub post object instead of failing completely [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107151 [09:48:21] tomsca: look through the i18n.php file for the message name contest-contest-reminder-page or similar - bug reporter might not have used the precise wording [09:48:30] also, use git grep rather than grep [09:49:37] There is a Contest.i18n.php file. So this might be where I find it? [09:50:29] (03PS2) 10Adamw: Basic state machinery [extensions/Workflow] - 10https://gerrit.wikimedia.org/r/107307 [09:54:11] tto: contest-contest-reminder-page' => 'The content for the reminder email comes from [[$1|this page]]. This is what I got. Now would you please tell me how I must proceed? [09:56:41] That all? I think someone else must have changed it since the bug was filed. You could close the bug as RESOLVED WORKSFORME then. [09:57:57] Oh. So this is fixed? [10:33:57] (03PS1) 10Matthias Mullie: Don't use complex datatypes as CAS tokens [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107348 [10:37:42] (03CR) 10Andrew Bogott: [C: 032] Start using full-qualified ec2 id for the page url. [openstack-wikistatus] - 10https://gerrit.wikimedia.org/r/104484 (owner: 10Andrew Bogott) [10:37:50] (03CR) 10Andrew Bogott: [V: 032] Start using full-qualified ec2 id for the page url. [openstack-wikistatus] - 10https://gerrit.wikimedia.org/r/104484 (owner: 10Andrew Bogott) [10:45:01] (03PS1) 10Anjanasasindran123: Changed "OK" to "Thank" in confirmation dialog box [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107350 [10:50:59] (03PS2) 1001tonythomas: Changed "OK" to "Thank" in confirmation dialog box [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107350 (owner: 10Anjanasasindran123) [10:54:03] (03CR) 1001tonythomas: [C: 04-1] "You need to add it to messges in wgResourceModules array in Thanks.php" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107350 (owner: 10Anjanasasindran123) [11:04:15] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This doesn't work, please read how our localisation messages system works: https://www.mediawiki.org/wiki/Manual:Messages_API#Using_messag" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107350 (owner: 10Anjanasasindran123) [11:10:55] (03CR) 10Bartosz Dziewoński: [C: 04-1] "One problem and some nitpicking inline. I'd prefer if the cleanup and the bugfix were in separate commits (this is much easier to do when " (034 comments) [core] - 10https://gerrit.wikimedia.org/r/106132 (owner: 10Gerrit Patch Uploader) [11:14:05] I wanted to hide the message box created by [11:14:06] $out->wrapWikiMsg( [11:14:06] "
\n$1\n
", [11:14:06] 'savedprefs' [11:14:06] ); [11:14:35] Can I do it by using the same $out element ? [11:14:38] liek [11:14:51] $out->hide() or sth similar ? [11:15:56] (03CR) 10Gilles: "When I set this up on my local machine, I only had to enter the public API key, not the API secret. I think you would be fine putting any " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [11:17:29] tonythomas01: why do you want to hide it? [11:17:36] some context would help :) [11:17:55] tto: forgot it. Its for https://bugzilla.wikimedia.org/show_bug.cgi?id=17496 [11:18:08] tto: Where I need to hide the box after say, 4 sec [11:18:14] now the box remains all day [11:18:42] $out is a PHP variable (server-side) and isn't going to do anything once the page has been sent to the user [11:18:51] does the output object $out have something like hide() [11:18:51] ? [11:19:07] not as far as I know, and I don't see why it would [11:19:24] you want to be using JavaScript for this [11:20:09] tto: so I should be adding something like $out->addScript( code to hide the div) ? [11:20:28] more or less, but it would be worthwhile to check if there is anything in core that already does what you want [11:20:42] mw.jsMessage comes to mind, but I don't think it is quite right for this scenario [11:21:05] sorry, mw.util.jsMessage [11:21:22] http://www.mediawiki.org/wiki/ResourceLoader/Default_modules#jsMessage [11:21:25] mw.util.jsMessage ? [11:21:26] ok [11:21:40] it has an auto timeout, but it appears in an unexpected area of the page and is fairly inconspicuous [11:22:38] by the way, you might want to add your JavaScript cdode to resources/mediawiki.special/mediawiki.special.preferences.js [11:22:59] you may need to create a new function and hook it up somehow... I'll leave that up to you as one of the challenges of programming :) [11:25:43] tto: Looks challenging :) Let me try [11:27:02] looking at the code you probably will not need to create a new function [11:28:42] got to go now, hopefully others can help if you are stuck [11:38:37] Hi I'm working on https://bugzilla.wikimedia.org/show_bug.cgi?id=38910. The image alt value when passed 0 it's treated as an empty value because of the code in includes/media/MediaTransformOutput.php: $alt = empty( $options['alt'] ) ? '' : $options['alt']; Would $alt = empty( $options['alt'] ) ? '0' : $options['alt']; do the trick? Pleas [12:01:26] Is this bug fixed? https://bugzilla.wikimedia.org/show_bug.cgi?id=17988 [12:03:51] (03PS3) 10Anjanasasindran123: Changed "OK" to "Thank" in confirmation dialog box [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107350 [12:07:18] (03CR) 1001tonythomas: [C: 031] Changed "OK" to "Thank" in confirmation dialog box [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107350 (owner: 10Anjanasasindran123) [12:21:32] (03CR) 10Dan-nl: "theopolisme," [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/107038 (owner: 10Dan-nl) [12:27:50] How can I reproduce http://is.wikipedia.org/w/index.php?title=RARIK&oldid=1275127 in my localhost? [12:29:58] (03PS8) 10Andrew Bogott: Switch reading to the new service group schema. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105847 [12:30:00] (03PS8) 10Andrew Bogott: Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 [12:30:02] (03PS8) 10Andrew Bogott: Add maintenance tool to clean up the old service-group schema. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105848 [12:41:14] (03PS9) 10Andrew Bogott: Switch reading to the new service group schema. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105847 [12:41:16] (03PS9) 10Andrew Bogott: Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 [12:41:18] (03PS9) 10Andrew Bogott: Add maintenance tool to clean up the old service-group schema. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105848 [12:43:27] sa [12:43:28] türk varmı [12:43:29] xdéé [12:49:35] (03PS1) 10Gerrit Patch Uploader: (Bug 60036) Use current skin for live preview [core] - 10https://gerrit.wikimedia.org/r/107359 [12:49:40] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/107359 (owner: 10Gerrit Patch Uploader) [12:49:42] (03CR) 10Aklapper: "In theory it should not be needed anymore." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98035 (owner: 10Aklapper) [13:00:11] (03PS5) 10Gerrit Patch Uploader: Move toctoggle from mediawiki.util.js to separate file mediawiki.toc.js [core] - 10https://gerrit.wikimedia.org/r/106132 [13:00:13] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/106132 (owner: 10Gerrit Patch Uploader) [13:05:59] I'd like to fix https://bugzilla.wikimedia.org/show_bug.cgi?id=17988 , https://bugzilla.wikimedia.org/show_bug.cgi?id=39339 and https://bugzilla.wikimedia.org/show_bug.cgi?id=12752. Would someone please help me fix one among these? [13:23:21] I'm working on this bug:https://bugzilla.wikimedia.org/show_bug.cgi?id=33334 and I have to remove page.page_restriction column from database. Shall I build a patch this way: https://gerrit.wikimedia.org/r/#/c/17608/ ..I went through the patch and it seems like the best way to approach this bug. [13:24:08] I'd like to fix https://bugzilla.wikimedia.org/show_bug.cgi?id=17988 , https://bugzilla.wikimedia.org/show_bug.cgi?id=39339 and https://bugzilla.wikimedia.org/show_bug.cgi?id=12752. Would someone please help me fix one among these? [13:27:52] tinaj: you probably should read the second link at https://www.mediawiki.org/wiki/Schema_change [13:28:47] then just upload your patch and ensure it's advertised as much as needed (including some reviewers) [13:33:29] Nemo_bis, got it ! [13:35:24] (03PS1) 1001tonythomas: Splitted date and time in message 'rclistfrom' [core] - 10https://gerrit.wikimedia.org/r/107360 [13:37:35] (03CR) 1001tonythomas: "I dont know whether I have edited the Documentation file correctly." [core] - 10https://gerrit.wikimedia.org/r/107360 (owner: 1001tonythomas) [13:42:47] (03PS2) 10Gerrit Patch Uploader: (Bug 60036) Use current language and current skin for live preview [core] - 10https://gerrit.wikimedia.org/r/107359 [13:42:49] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/107359 (owner: 10Gerrit Patch Uploader) [13:43:04] (03PS1) 10Raimond Spekking: Remove unused messages [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/107361 [13:44:15] (03CR) 10TMg: [C: 031] mw.loader.store: Wrap script eval in try/catch (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100930 (owner: 10Bartosz Dziewoński) [13:45:40] (03CR) 10Gilles: [C: 04-1] Add blacklisting feature for flickr in backend (034 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [13:50:21] Nemo_bis: can you go through https://gerrit.wikimedia.org/r/#/c/107360/ on splitting the date and time in rclistfrom ? [13:59:01] afk soon [14:04:30] Where can i find all the languages and thier shortforms supported by wikipedia? [14:06:34] diwanship: you meant the messages used by mediawiki ? [14:07:05] tonythomas01 yes [14:07:11] (03PS3) 10Gerrit Patch Uploader: Use current preference overriding for live preview [core] - 10https://gerrit.wikimedia.org/r/107359 [14:07:15] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/107359 (owner: 10Gerrit Patch Uploader) [14:08:15] diwanship: I think you will find it in languages/messages/MessagesEn.php [14:08:24] (03CR) 10jenkins-bot: [V: 04-1] Use current preference overriding for live preview [core] - 10https://gerrit.wikimedia.org/r/107359 (owner: 10Gerrit Patch Uploader) [14:08:33] diwanship: if you are looking for Engliish [14:10:04] tonythomas01 is there any wikipage of supported languages coz i am making a tutorial on meta so i want a wikipage from which a user can see list of languages and respective shortforms [14:10:14] diwanship: You can find list of the languages supported by MediaWiki here https://git.wikimedia.org/blob/mediawiki%2Fcore.git/master/languages%2fNames.php [14:11:44] thanks MegaAlex and tonythomas01 :) [14:12:29] diwanship: k [14:13:48] (03PS4) 10Gerrit Patch Uploader: Use current preference overriding for live preview [core] - 10https://gerrit.wikimedia.org/r/107359 [14:13:50] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/107359 (owner: 10Gerrit Patch Uploader) [14:13:50] ehm if Beta experiments aren't being actively worked on, can we just disable them all together ? [14:13:56] specifically nearby [14:15:36] I count broken navboxes layout, non working close window widget and now non-working links for results... [14:17:38] (03PS4) 10Aklapper: [4.4] Sync MoreBugUrl extension, add our custom patches [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98035 [14:18:32] (03CR) 10Aklapper: "Patchset 4 adds our custom RequestTracker.pm again and moves it from /Bugzilla/BugUrl/ to /extensions/MoreBugUrl/. I also updated the comm" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98035 (owner: 10Aklapper) [14:23:32] (03PS1) 10Manybubbles: Escape more bad syntax [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107369 [14:47:37] (03PS1) 10Manybubbles: Return timestamp from index rather than database [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107373 [14:47:41] (03CR) 10Gilles: [C: 04-1] Create jquery.fullscreen (036 comments) [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [14:48:04] (03PS2) 10Manybubbles: Return timestamp from index rather than database [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107373 [14:58:44] hashar: Thanks to https://gerrit.wikimedia.org/r/#/c/105920/ and the fact that I really don't want to install phpunit manually, I can no longer run unit tests locally. :( Debian only has 3.6.10: . Ubuntu too: [14:59:39] anomie: 3.6 is no more supported, you will get to install a package from a later debian version, use pear/composer version or from a local phpunit source checkout [14:59:52] (03PS1) 10Aude: Update Wikibase, fix for xml api exceptions [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107375 [14:59:58] hashar: 3.6.10 *is* the latest version in Debian. [15:00:09] anomie: I am pretty sure we have been relying on phpunit 3.7 for quite long time now [15:00:44] hashar: I've never had any problems. It looks like Wikibase decided to add some new 3.7 feature, causing bug 59759. [15:05:04] !bug 59759 [15:05:04] https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=59759 [15:05:59] anomie: feel free to bring the bug to the wikidata team and get them to revert back to support phpunit 3.6 [15:06:42] Niharika: hey! you had pinged me a few days earlier? [15:18:25] yuvipanda: Hey. Yeah, but never mind now. Talked to sucheta afterwards. :) [15:20:08] Niharika: ah ok :) [15:20:13] Niharika: sorry about not responding that day [15:20:18] hey hashar! [15:20:36] RoanKattouw_away: was telling me they found a way around the VE issue? [15:21:29] yuvipanda: apparently got cancelled [15:21:34] ow :( [15:21:59] RoanKattouw_away: any idea when it'll happen again? [15:28:57] hashar: Looking into the issue a bit, that particular 3.7-only function is only used in three extensions: Diff, EducationProgram, and DataTypes. :/ [15:34:46] (03PS1) 10Matthias Mullie: If we fail to CAS, remove cached data so it's re-read from DB [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107377 [15:36:10] anomie: please follow up with wikidata. I am myself fine requiring 3.7 and think folks still relying on 3.6 should simply upgrade their setup. [15:36:36] anomie: I think Niklas made a similar case when started using phpunit 3.6, he ended up using pear [15:36:46] anomie: using composer, it should be quite easy to upgrade :] [15:36:50] hashar: I'm preparing an email to wikitech-l [15:36:58] Ugh, that's another mess I don't want to mess with. [15:36:59] anomie: yeah or that :-] [15:37:21] on Jenkins we use phpunit 3.7.x [15:37:31] I am fine supporting 3.6, but I don't think it is really needed [15:37:37] given how easy it is to install it [15:42:30] (03CR) 10Ottomata: "Hmm, hold off on testing this one. I'm having a Hive error that I need to fix." [vagrant] - 10https://gerrit.wikimedia.org/r/107317 (owner: 10Ottomata) [15:45:45] (03PS1) 10Matthias Mullie: Don't use complex datatypes as CAS tokens [core] - 10https://gerrit.wikimedia.org/r/107380 [15:47:33] (03Abandoned) 10Matthias Mullie: Don't use complex datatypes as CAS tokens [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107348 (owner: 10Matthias Mullie) [15:57:07] (03PS8) 10Matthias Mullie: [WIP] Auto-wrapping escaper for templates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103317 (owner: 10EBernhardson) [15:57:10] (03PS5) 10Matthias Mullie: Simplify edit-title template [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103069 (owner: 10EBernhardson) [15:57:31] (03CR) 10Matthias Mullie: [C: 032] Simplify edit-title template [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103069 (owner: 10EBernhardson) [15:58:30] (03CR) 10Matthias Mullie: [C: 031] "I'll change my +2 to +1 because gerrit will keep trying to merge it & parent patch is still WIP." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103069 (owner: 10EBernhardson) [15:58:45] (03PS1) 10Cscott: Follow redirects. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/107382 [15:59:20] (03PS1) 10Anomie: Handle invalid keys in Lua-to-PHP calls for LuaStandalone [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107383 [16:03:42] (03CR) 10Chad: [C: 032] Return timestamp from index rather than database [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107373 (owner: 10Manybubbles) [16:03:47] (03Merged) 10jenkins-bot: Return timestamp from index rather than database [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107373 (owner: 10Manybubbles) [16:03:56] (03PS5) 10Aklapper: [4.4] Sync MoreBugUrl extension, add our custom patches [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98035 [16:05:45] (03CR) 10Aklapper: "For Patchset 4, the empty fields issue still exists for Mingle and SFAllura URLs. Removing such an "empty" URL triggers" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98035 (owner: 10Aklapper) [16:12:20] (03CR) 10Legoktm: [C: 04-1] "See inline comments." (032 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107350 (owner: 10Anjanasasindran123) [16:12:52] (03CR) 10Matthias Mullie: [WIP] Auto-wrapping escaper for templates (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103317 (owner: 10EBernhardson) [16:14:15] (03CR) 10Chad: Allow SearchResults to specify that they matched file content (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105234 (owner: 10Chad) [16:19:07] <^d> Krenair: Hiiiii [16:23:49] (03CR) 10Legoktm: "Yeah, I just submitted patches for all extensions in gerrit, this can be merged whenever 1.23 is stable enough for you." [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/103908 (owner: 10Legoktm) [16:24:44] (03PS1) 10Cscott: Improve accent position for Vietnamese. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107385 [16:26:18] (03PS1) 10Cscott: Update multiwiki test case to include korean text. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107386 [16:29:13] (03CR) 10Cscott: [C: 032] Follow redirects. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/107382 (owner: 10Cscott) [16:29:49] (03CR) 10Aklapper: "Patchset 5 replaced "use base" by "use parent" and added "use 5.10.1;" and works fine now on zirconium!" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98035 (owner: 10Aklapper) [16:31:15] (03Merged) 10jenkins-bot: Follow redirects. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/107382 (owner: 10Cscott) [16:37:48] (03PS2) 10Ottomata: Adding role::hadoop and role::hive [vagrant] - 10https://gerrit.wikimedia.org/r/107317 [16:38:09] (03CR) 10Ottomata: "Ok! ready!" [vagrant] - 10https://gerrit.wikimedia.org/r/107317 (owner: 10Ottomata) [16:38:58] (03CR) 10Ottomata: Adding role::hadoop and role::hive (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/107317 (owner: 10Ottomata) [16:39:13] (03CR) 10Chad: [C: 032] Escape more bad syntax [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107369 (owner: 10Manybubbles) [16:39:18] (03Merged) 10jenkins-bot: Escape more bad syntax [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107369 (owner: 10Manybubbles) [16:39:27] (03CR) 10Chad: [C: 032] Split request logs out from debug logs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106430 (owner: 10Manybubbles) [16:39:32] (03Merged) 10jenkins-bot: Split request logs out from debug logs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106430 (owner: 10Manybubbles) [16:39:50] (03CR) 10Chad: [C: 032] Start getting PhantomJS working for tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106720 (owner: 10Manybubbles) [16:39:56] (03Merged) 10jenkins-bot: Start getting PhantomJS working for tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106720 (owner: 10Manybubbles) [16:39:58] andre__, guillom and anybody else, do you have any pointsfor our IRC eeting? Please add them to https://www.mediawiki.org/wiki/Engineering_Community_Team/Meetings#2014-01-14 [16:40:26] qgil, shall I add "Project Management Tools Evaluation" and "Progress on Bugzilla 4.4 upgrade" maybe? [16:40:35] (03CR) 10Chad: [C: 032] Remove log10 from boost in prefix search [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106906 (owner: 10Manybubbles) [16:40:37] mmmaybe :) [16:40:40] (03Merged) 10jenkins-bot: Remove log10 from boost in prefix search [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106906 (owner: 10Manybubbles) [16:40:49] I take that as a yyyyyes. :) [16:41:27] it's more a yesssss ;) [16:42:04] You have a funny accent. ;) [16:42:14] redmine? [16:51:23] jzerebecki: https://bugs.launchpad.net/ubuntu/+source/gnome-keyring/+bug/771272 [16:53:02] jzerebecki: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=704204 [16:58:17] Coren, gwicke_away marcoil spage you ref Facebook Open Academy, yo might be interested in https://www.mediawiki.org/wiki/Engineering_Community_Team/Meetings#2014-01-14 starting now at #wikimedia-meetbot [16:58:23] (03CR) 10Matthias Mullie: [C: 032] Test to try instantiating all objects from container [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105240 (owner: 10EBernhardson) [16:58:29] (03Merged) 10jenkins-bot: Test to try instantiating all objects from container [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105240 (owner: 10EBernhardson) [16:58:43] (03PS1) 10Anomie: Improve API query RevDel handling [core] - 10https://gerrit.wikimedia.org/r/107389 [16:59:01] guillom, please join #wikimedia-meetbot [16:59:18] qgil: Bleh. Scheduling conflict; I have a meeting re labs. I'll idle on channel and keep a distracted eye [17:00:01] (03CR) 10Matthias Mullie: [C: 032] Call msg ->text() or escaped() instead of parse() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105435 (owner: 10Spage) [17:00:05] (03Merged) 10jenkins-bot: Call msg ->text() or escaped() instead of parse() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105435 (owner: 10Spage) [17:04:12] (03CR) 10Aarcos: "Matankmadan: I left some comments in revision 11, addressing your questions. Hope that makes sense, let me know otherwise. Thanx for helpi" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [17:35:49] (03CR) 10Matthias Mullie: [C: 031] Batch loading workflows for history links (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105144 (owner: 10Bsitu) [17:40:06] (03CR) 10UltrasonicNXT: [C: 032 V: 032] "Yeah, copy paste error, not sure how I managed to to that!" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/107361 (owner: 10Raimond Spekking) [17:41:30] (03PS1) 10Cscott: Update documentation for db helper; improve handling of missing keys. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/107392 [17:42:59] (03PS1) 10Cscott: Improve internal documentation. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107393 [17:43:18] (03CR) 10jenkins-bot: [V: 04-1] Improve internal documentation. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107393 (owner: 10Cscott) [17:43:40] hello [17:46:17] (03PS2) 10Cscott: Improve internal documentation. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107393 [17:47:22] (03CR) 10Cscott: [C: 032] Update multiwiki test case to include korean text. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107386 (owner: 10Cscott) [17:47:30] (03CR) 10Cscott: [C: 032] Improve accent position for Vietnamese. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107385 (owner: 10Cscott) [17:47:54] (03Merged) 10jenkins-bot: Improve accent position for Vietnamese. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107385 (owner: 10Cscott) [17:47:56] (03Merged) 10jenkins-bot: Update multiwiki test case to include korean text. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107386 (owner: 10Cscott) [17:53:13] What I need to learn for contributing in GSOC for wikimedia ? [17:56:38] (03CR) 10EBernhardson: [WIP] Auto-wrapping escaper for templates (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103317 (owner: 10EBernhardson) [17:58:03] BHAVANA: That really depends on what project you want to do [17:59:57] (03CR) 10Krinkle: mw.loader.store: Wrap script eval in try/catch (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100930 (owner: 10Bartosz Dziewoński) [18:00:25] TimStarling: could you take a look at https://bugzilla.wikimedia.org/show_bug.cgi?id=60015 [18:01:12] It's a small change, but I'm not sure if there was any reason for not doing that before (other than not noticing) [18:01:31] Not sure Tim is necesserily the right person to review that [18:01:45] me too [18:02:05] but I have no idea who to ask :) [18:02:34] mdale is not with wmf anymore as far as I see [18:02:39] He never was [18:02:44] oh [18:02:47] okay [18:02:49] CC him and Jan Gerber [18:03:00] I've seen mdale commenting recently on bugs at least [18:03:04] Not sure about Jan though [18:03:15] You can also try the "multimedia" guys in WMF [18:03:35] Added both of them as reviewers on gerrit [18:03:53] Gilles Dubuc, Mark Holmquist and Gergő Tisza [18:03:53] ~three weeks ago :) [18:04:12] thanks, will ty [18:04:14] *try [18:04:28] The change is fairly trivial [18:04:42] yup [18:05:05] I'm more worried about how will that play with player [18:05:20] or any other non-obvvious stuff [18:06:09] hmm, bug got some automatic cc's apparently [18:06:23] probably just being in TMH [18:06:45] and got assigned to mdale [18:07:03] so that's probably enough of spam ;) [18:11:46] gi11es: marktraceur ^ [18:12:25] lazowik: Hi! [18:12:31] hello! [18:12:50] lazowik: I think mdale is still working on TMH, as part of his work with Kaltura [18:12:59] But I'm not sure if that will include this bug [18:13:08] mhm [18:13:31] I'm mostly concerned about impact it might have on production [18:13:49] Yeah [18:14:03] I don't think I have the expertise to deal with this [18:14:06] code-wise is trivial [18:14:25] *it's [18:15:09] marktraceur: any idea who other than mdale can I ask? [18:15:28] * lazowik waves MatmaRex [18:16:14] lazowik: I'd point wildly at gi11es, bd808, and bawolff (the latter of whom is not here sadly) [18:16:32] But mostly that's unbased accusatory pointing [18:16:42] :p [18:17:40] well, that's actually what I expected while submitting the patch :) [18:19:53] * bd808 reads backscroll and then hides from TMH review [18:20:12] hehe <- sad laughter [18:20:33] The change *looks* simple but I don't know all the implications of adding a codec format [18:20:43] me the same [18:20:52] (03Abandoned) 10Hoo man: Add aria properties to TOC for accessibility [core] - 10https://gerrit.wikimedia.org/r/79053 (owner: 10Hoo man) [18:21:04] of course license-wise that's ok [18:21:35] but other idk [18:23:22] thedj: thedj[work]: around? [18:24:31] i am not getting a way to start contributing in wikimedia [18:25:09] BHAVANA: As Reedy already asked, what exactly do you want to work on? [18:25:30] hi [18:27:24] ho [18:27:39] (03CR) 10Cscott: [C: 032] Improve internal documentation. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107393 (owner: 10Cscott) [18:27:58] (03CR) 10Cscott: [C: 032] Update documentation for db helper; improve handling of missing keys. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/107392 (owner: 10Cscott) [18:28:04] (03Merged) 10jenkins-bot: Improve internal documentation. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107393 (owner: 10Cscott) [18:28:21] I want to work on development [18:28:36] Of what? [18:29:31] https://www.mediawiki.org/wiki/Annoying_little_bugs [18:29:41] mobile applications [18:30:26] (03Merged) 10jenkins-bot: Update documentation for db helper; improve handling of missing keys. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/107392 (owner: 10Cscott) [18:30:38] BHAVANA: #wikimedia-mobile [18:31:01] they have different apps, wikipedia, commons app,.. [18:31:10] wikiLovesMonuments app [18:33:20] (03CR) 10Krinkle: Create jquery.fullscreen (032 comments) [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [18:38:30] (03CR) 10Krinkle: Move toctoggle from mediawiki.util.js to separate file mediawiki.toc.js (032 comments) [core] - 10https://gerrit.wikimedia.org/r/106132 (owner: 10Gerrit Patch Uploader) [18:38:50] ori, got a moment? I tried following your instructions regarding OCG and got this: https://gist.github.com/MaxSem/273abe58d3b560323e93 [18:40:53] MaxSem: before doing anything else, update your guest additions [18:41:04] 'vagrant ssh' then 'update-guest-additions' [18:44:56] ori, update-guest-additions: command not found [18:46:10] (03PS2) 10Aude: Update Wikibase, fix for xml api exceptions [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107375 [18:47:13] Reedy: ^ [18:47:59] MaxSem: can you rerun vagrant provision? [18:48:41] aude: I saw ;) [18:48:42] ori, same stuff [18:48:43] (03PS3) 10Aude: Update Wikibase, fix for xml api exceptions [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107375 [18:48:49] ok [18:49:28] we'll need to repopulate the sites table, as it is specific to the site group and we will need code that is in the update [18:49:49] so when time, 1) put wikisource on wmf10 [18:49:51] 2) [18:49:53] run script [18:49:56] 3) enable wikibase [18:50:14] MaxSem: wget https://raw.github.com/wikimedia/mediawiki-vagrant/master/puppet/modules/virtualbox/files/update-guest-additions and run it [18:50:20] inside the guest [18:50:43] long url is long [18:52:55] http://thelongestlistofthelongeststuffatthelongestdomainnameatlonglast.com/wearejustdoingthistobestupidnowsincethiscangoonforeverandeverandeverbutitstilllookskindaneatinthebrowsereventhoughitsabigwasteoftimeandenergyandhasnorealpointbutwehadtodoitanyways.html [18:54:04] :) [18:54:27] haha [18:54:39] I've just broken google knowledge graph box [18:54:40] https://www.google.pl/search?q=llanfairpwllgwyngyllgogerychwyrndrobwllllantysiliogogogoch&oq=llanfairpwllgwyngyllgogerychwyrndrobwllllantysiliogogogoch&aqs=chrome..69i57j69i60j0l4.267j0j7&sourceid=chrome&espv=210&es_sm=119&ie=UTF-8 [18:54:41] (03PS1) 10Reedy: Update VE to master [extensions] - 10https://gerrit.wikimedia.org/r/107400 [18:54:53] hmm, is that channel supposed not to be spammed? :p [18:55:02] (03CR) 10Reedy: [C: 032] Update VE to master [extensions] - 10https://gerrit.wikimedia.org/r/107400 (owner: 10Reedy) [18:55:23] (03CR) 10Reedy: [V: 032] Update VE to master [extensions] - 10https://gerrit.wikimedia.org/r/107400 (owner: 10Reedy) [19:01:10] (03PS1) 10Jackmcbarn: Make the diff the primary link in thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/107402 [19:03:31] (03CR) 10Reedy: [C: 032 V: 032] Update Wikibase, fix for xml api exceptions [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107375 (owner: 10Aude) [19:05:57] [18:49:50] run script [19:06:04] the populate site table one? [19:08:28] Reedy: is wikisource on wmf10? [19:08:41] Yes [19:09:18] if so, yes and we might need to truncate sites and site_identifiers fist [19:09:19] first [19:09:44] truncate on which wikis? just wikisource? [19:09:47] wikisource [19:09:49] only [19:10:38] Doing that now [19:11:39] (03PS15) 10Gergő Tisza: Add blacklisting feature for flickr in backend [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [19:11:42] (03PS8) 10Gergő Tisza: A way to blacklist flickr users. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [19:11:45] (03PS3) 10Gergő Tisza: Refactor Flickr API calls [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107267 [19:12:41] (03PS1) 10Matthias Mullie: Strip binary data from values to be json_encode'ed [core] - 10https://gerrit.wikimedia.org/r/107408 [19:14:52] (03CR) 10Gergő Tisza: "I misunderstood what the API key is good for, thanks for correcting that. I added a key (not the one used in production) to the default co" (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [19:16:27] (03CR) 10EBernhardson: "some sort of base64 conversion would be convenient, then it could also display the binary data, but as a first step this looks like the ri" [core] - 10https://gerrit.wikimedia.org/r/107408 (owner: 10Matthias Mullie) [19:17:25] (03PS1) 10Aklapper: Some smaller CSS and linebreak cleanup [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/107410 [19:17:58] (03PS1) 10Legoktm: [WIP] Revamp API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107411 [19:19:13] (03PS1) 10Legoktm: Use GET request to fetch token from API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107413 [19:19:40] (03CR) 10Aklapper: "(Note to myself: We did not touch this file for 4.4 so this could go in both for 4.2 and 4.4, after testing.)" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/107410 (owner: 10Aklapper) [19:20:05] (03PS1) 10Legoktm: Fix type hinting in AbstractBlock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107414 [19:20:13] (03CR) 10Reedy: "This shouldn't have been merged. Wikimedia hasn't finished schema migration for external links id addition (it takes a while)" [core] - 10https://gerrit.wikimedia.org/r/105243 (owner: 10Umherirrender) [19:20:19] (03PS1) 10Reedy: Revert "Add sequence support for externallinks table" [core] - 10https://gerrit.wikimedia.org/r/107415 [19:20:28] (03CR) 10Aaron Schulz: [C: 032] Don't use complex datatypes as CAS tokens [core] - 10https://gerrit.wikimedia.org/r/107380 (owner: 10Matthias Mullie) [19:20:32] (03PS1) 10Reedy: Revert "Add sequence support for externallinks table" [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107416 [19:20:41] (03CR) 10Reedy: [C: 032] Revert "Add sequence support for externallinks table" [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107416 (owner: 10Reedy) [19:21:32] (03CR) 10Matthias Mullie: "I planned to do base64_encode first, so that it can be decoded in JS." [core] - 10https://gerrit.wikimedia.org/r/107408 (owner: 10Matthias Mullie) [19:22:15] (03CR) 10EBernhardson: [C: 032] Fix type hinting in AbstractBlock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107414 (owner: 10Legoktm) [19:22:51] (03PS4) 10Daniel Kinzler: Introducing TitleValue [core] - 10https://gerrit.wikimedia.org/r/106517 [19:24:00] (03CR) 10EBernhardson: [C: 032] Use GET request to fetch token from API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107413 (owner: 10Legoktm) [19:24:03] (03Merged) 10jenkins-bot: Fix type hinting in AbstractBlock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107414 (owner: 10Legoktm) [19:24:32] (03Merged) 10jenkins-bot: Use GET request to fetch token from API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107413 (owner: 10Legoktm) [19:26:04] (03Merged) 10jenkins-bot: Don't use complex datatypes as CAS tokens [core] - 10https://gerrit.wikimedia.org/r/107380 (owner: 10Matthias Mullie) [19:26:15] (03Merged) 10jenkins-bot: Revert "Add sequence support for externallinks table" [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107416 (owner: 10Reedy) [19:28:39] (03CR) 10Aude: "mostly pointing out the obvious" (0311 comments) [core] - 10https://gerrit.wikimedia.org/r/106517 (owner: 10Daniel Kinzler) [19:29:24] (03CR) 10Greg Grossmeier: "See: https://bugzilla.wikimedia.org/show_bug.cgi?id=49189" [core] - 10https://gerrit.wikimedia.org/r/105243 (owner: 10Umherirrender) [19:32:39] (03CR) 10Umherirrender: [C: 031] SpecialContributions: Avoid using 'contributions' slave for getParentLengths [core] - 10https://gerrit.wikimedia.org/r/107319 (owner: 10Springle) [19:33:56] (03CR) 10Fomafix: Move toctoggle from mediawiki.util.js to separate file mediawiki.toc.js (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106132 (owner: 10Gerrit Patch Uploader) [19:37:43] (03PS1) 10Aude: Update Wikibase, allow populate sites script to run without Wikibase enabled [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107418 [19:37:54] (03PS1) 10Aaron Schulz: Limit attempts to render the same thumbnail after failures [core] - 10https://gerrit.wikimedia.org/r/107419 [19:40:25] What is the difference between a user and a global user? Like if i have a account on wiki then am I a user or global user? [19:40:27] (03CR) 10Reedy: [C: 032 V: 032] Update Wikibase, allow populate sites script to run without Wikibase enabled [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107418 (owner: 10Aude) [19:41:51] diwanship: on Wikimedia's wikis, making an account on one wiki makes it on the rest (barring name conflict issues) [19:42:51] in other words, you're both. some things about your account are per-wiki (local) and others are global [19:43:33] (03CR) 10Mattflaschen: "See inline." (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/106458 (owner: 10Mattflaschen) [19:43:48] jackmcbarn so rights may differ on different wikis? [19:43:54] yes [19:44:10] a few rights are global (steward, for example), but for the most part, they're all per-wiki [19:44:26] ok thanks got it [19:44:27] :) [19:45:29] jackmcbarn, note that steward rights are also local [19:45:39] which just confuses things [19:45:48] but they're assigned globally [19:45:51] which is what i presume diwanship meant [19:46:00] locally as well though [19:46:15] do we actually do that? [19:46:26] yes [19:46:34] where/why? [19:46:44] Well meta is the most obvious example [19:47:53] oh, you mean the local source of the global rights [19:47:54] other wikis in cases where the steward would like to fiddle with things that can't be changed interwiki (e.g. grant/remove groups not existing on meta) [19:48:40] well, to my knowledge no other global group has an associated local group everywhere [19:52:04] (03PS1) 10Aklapper: [4.4] Update custom search-links so Saved Reports are displayed [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/107423 [19:52:49] (03CR) 10Umherirrender: "I am not sure, if the title object should allow access to internal cache logic. Other parser functions are using its own (static) cache to" [core] - 10https://gerrit.wikimedia.org/r/107199 (owner: 10Jackmcbarn) [19:54:23] (03CR) 10Gergő Tisza: "Aarcos, can you test this on mediawiki-vagrant? I am getting various errors when running pip (first "No distributions at all found for os>" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [19:56:25] (03CR) 10Jackmcbarn: "The implode is virtually instantaneous and isn't worth caching. Using the title's own cache allows other usages of the variable to benefit" [core] - 10https://gerrit.wikimedia.org/r/107199 (owner: 10Jackmcbarn) [19:58:33] (03CR) 10Bartosz Dziewoński: "This is going to conflict with my refactor (https://gerrit.wikimedia.org/r/#/q/topic:watchlist+is:open,n,z) in wonderful ways :(" [core] - 10https://gerrit.wikimedia.org/r/107360 (owner: 1001tonythomas) [20:02:08] (03PS14) 10Aarcos: Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [20:02:55] (03PS1) 10Manybubbles: Fix typo [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107425 [20:04:22] (03CR) 10Manybubbles: [C: 032] "self merging because the old one was horrible" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107425 (owner: 10Manybubbles) [20:04:27] (03Merged) 10jenkins-bot: Fix typo [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107425 (owner: 10Manybubbles) [20:05:05] (03CR) 10Umherirrender: "You would still use title objects from the title cache in Title::newFromText for loading the restriction the first time, so the loaded res" [core] - 10https://gerrit.wikimedia.org/r/107199 (owner: 10Jackmcbarn) [20:06:56] (03CR) 10Jackmcbarn: "I don't really see the benefit. I'll let Anomie decide." [core] - 10https://gerrit.wikimedia.org/r/107199 (owner: 10Jackmcbarn) [20:07:52] ^demon, around? got (what should be) a simple git question [20:08:07] <^demon> Shoot. [20:08:41] Trying to rebase an old patch onto the latest master, but release notes has since been deleted [20:08:43] CONFLICT (modify/delete): RELEASE-NOTES-1.22 deleted in HEAD and modified in Cross-wiki user rights UI should show target wiki groups instead of local. Version Cross-wiki user rights UI should show target wiki groups instead of local of RELEASE-NOTES-1.22 left in tree. [20:09:07] how do I make it discard any changes to RELEASE-NOTES-1.22? [20:09:33] git rm RELE*1.22 [20:09:39] git rebase --continue [20:09:53] alex@alex:/var/www/MediaWiki/Git/core ((2a4dfa1...)|REBASE)$ git rm RELE*1.22 [20:09:54] fatal: pathspec 'RELE*1.22' did not match any files [20:10:11] anomie: ^ [20:10:15] <^demon> Whatever the file is. [20:10:17] I tried that already :) (but with the full name) [20:10:18] right, it's not there... try using the full name [20:10:34] I had that yesterday [20:10:48] oh okay, so I think it might've succeeded the first time... messages printed to console looked errory [20:11:03] (03CR) 10Aaron Schulz: [C: 032] SpecialContributions: Avoid using 'contributions' slave for getParentLengths [core] - 10https://gerrit.wikimedia.org/r/107319 (owner: 10Springle) [20:11:05] jackmcbarn: What am I looking at? [20:11:10] (CR) Jackmcbarn: "I don't really see the benefit. I'll let Anomie decide." [core] - https://gerrit.wikimedia.org/r/107199 (owner: Jackmcbarn) [20:11:40] should i be using the title's cache the way i am, or should i use a separate level of cache, basically? [20:13:05] (03PS20) 10Alex Monk: Cross-wiki user rights UI should show target wiki groups instead of local [core] - 10https://gerrit.wikimedia.org/r/36330 [20:13:23] (03CR) 10Alex Monk: "(rebased)" [core] - 10https://gerrit.wikimedia.org/r/36330 (owner: 10Alex Monk) [20:13:30] (03PS1) 10Qitang: Add getHit.txt file [core] - 10https://gerrit.wikimedia.org/r/107427 [20:14:34] (03Merged) 10jenkins-bot: SpecialContributions: Avoid using 'contributions' slave for getParentLengths [core] - 10https://gerrit.wikimedia.org/r/107319 (owner: 10Springle) [20:14:48] jackmcbarn: I don't see the need for a separate cache there. [20:16:27] jackmcbarn: It doesn't seem terribly likely that one call to your function will be followed by over 1000 other titles being created and then another call to your function with that same original title. [20:17:09] (03CR) 10Anomie: "It doesn't seem terribly likely to me that one call to this function will be followed by over 1000 other titles being created and then ano" [core] - 10https://gerrit.wikimedia.org/r/107199 (owner: 10Jackmcbarn) [20:17:47] thanks [20:18:33] also, is that something you're going to test yourself, or should i add another reviewer to test it? [20:20:01] (03PS1) 10Gergő Tisza: Add vagrant support for running the UploadWizard smoke tests [vagrant] - 10https://gerrit.wikimedia.org/r/107429 [20:27:19] (03CR) 10Umherirrender: "It could be possible that this parser function is used to show a conditional edit link at the top of the page, a big table with 1000 links" [core] - 10https://gerrit.wikimedia.org/r/107199 (owner: 10Jackmcbarn) [20:32:48] >_> [20:40:54] (03PS1) 10Manybubbles: Handle near match conflicts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107433 [20:45:06] (03PS1) 10Reedy: Add extensions/BetaFeatures/sql/create_counts.sql to sql files loaded [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/107455 [20:45:08] (03PS1) 10Anomie: pageid parser function is expensive, make it so [core] - 10https://gerrit.wikimedia.org/r/107456 [20:53:42] (03PS4) 10Anomie: API: Add prop=redirects and list=allredirects [core] - 10https://gerrit.wikimedia.org/r/104764 [20:55:54] Can someone review some JSDuck cleanup on GuidedTour? [20:55:56] https://gerrit.wikimedia.org/r/#/c/86057/ [20:56:00] I'd really appreciate it. [20:56:35] (03PS1) 10MaxSem: Add TextExtracts [tools/release] - 10https://gerrit.wikimedia.org/r/107473 [20:58:38] jackmcbarn: (should have pinged me) I'll test it at some point soon. Bug me in 22 or 23 hours if I haven't by then. [20:58:46] kk [20:59:59] * anomie neatly avoids timezone issues inherent in saying "tomorrow afternoon" [21:06:52] hi ^d [21:07:32] <^d> hi [21:07:36] (03PS1) 10MaxSem: Add TextExtracts [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107479 [21:09:41] (03PS1) 10MaxSem: Add TextExtracts [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/107481 [21:09:46] ^d: do you think you (pl) would be able give me some help this year if I wanted to add Elasticsearch support for translation memory? [21:10:06] <^d> Love to :) [21:10:20] (03CR) 10MaxSem: [C: 032] Add TextExtracts [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/107481 (owner: 10MaxSem) [21:10:36] (03CR) 10MaxSem: [C: 032] Add TextExtracts [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107479 (owner: 10MaxSem) [21:11:01] (03CR) 10Mattflaschen: "Hmm, this definitely solves the problem in this case." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/107333 (owner: 10Roopak) [21:11:03] (03CR) 10MaxSem: [C: 032] Add TextExtracts [tools/release] - 10https://gerrit.wikimedia.org/r/107473 (owner: 10MaxSem) [21:11:35] ^d: cool [21:11:37] (03Merged) 10jenkins-bot: Add TextExtracts [tools/release] - 10https://gerrit.wikimedia.org/r/107473 (owner: 10MaxSem) [21:13:19] (03CR) 10MaxSem: [V: 032] Add TextExtracts [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/107481 (owner: 10MaxSem) [21:13:59] can anyone think of a remotely plausible use-case for a wiki being configured to prevent most users from editing any existing pages, but allowing them to create new ones? [21:14:55] (03CR) 10Bartosz Dziewoński: [C: 032] "LEEEEROY JEEENKINS" [core] - 10https://gerrit.wikimedia.org/r/103387 (owner: 10Yaron Koren) [21:18:55] (03CR) 10Anomie: [C: 04-1] "Return object needs work, it has 0-indexed sequences:" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107046 (owner: 10Jackmcbarn) [21:19:58] jackmcbarn: a wiki used to host requests for something? [21:20:06] jackmcbarn: Why? [21:20:13] where you can only add new requests but not edit existing ones [21:21:49] (03Merged) 10jenkins-bot: Fix to avoid IE "compatibility view" [core] - 10https://gerrit.wikimedia.org/r/103387 (owner: 10Yaron Koren) [21:27:04] <^d> Krenair: When you gonna review my LQT changes? :p [21:29:21] (03PS15) 10Aarcos: Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [21:30:47] (03CR) 10Aarcos: [C: 031] "I tested this patch and it works but someone else has to approve." [vagrant] - 10https://gerrit.wikimedia.org/r/107429 (owner: 10Gergő Tisza) [21:32:47] (03CR) 10Parent5446: "That is an operations problem. I'm a bit surprised that code is deployed so spontaneously that nobody checks to see if schema changes need" [core] - 10https://gerrit.wikimedia.org/r/105243 (owner: 10Umherirrender) [21:35:23] !roadmap [21:35:23] For long-term engineering goals roadmap, see . For short-term WMF deployments roadmap, see . [21:37:42] anomie: because of https://bugzilla.wikimedia.org/show_bug.cgi?id=35238 [21:37:52] (03CR) 10EBernhardson: "the mentioned patch is going to be in the next hhvm release, 2.3.3. Will update when that comes out." [vagrant] - 10https://gerrit.wikimedia.org/r/105834 (owner: 10EBernhardson) [21:40:38] (03CR) 10Jackmcbarn: "Given the comment at https://git.wikimedia.org/blob/mediawiki%2Fcore.git/55da056f08df570e7a893edf5c9607b819f511df/includes%2Fparser%2FCore" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107046 (owner: 10Jackmcbarn) [21:40:49] (03CR) 10Greg Grossmeier: "MediaWiki is deployed from master on the Beta Cluster every 3 minutes. MediaWiki is deployed to WMF production cluster every week. This nu" [core] - 10https://gerrit.wikimedia.org/r/105243 (owner: 10Umherirrender) [21:41:55] ^d: Am not sure I know enough about CirrusSearch to do that.. [21:43:45] greg-g: Isn't there guidelines for schema related changes and feature flags? [21:43:57] Reedy: should be.... lemme see [21:44:04] * greg-g is on a call [21:44:09] "That is an operations problem. I'm a bit surprised that code is deployed so spontaneously that nobody checks to see if schema changes need to be made. We're not going to hold up merging code just because the WMF database is taking a while." [21:44:11] Is pretty wrong [21:44:14] We can, and we will [21:44:37] They can't just break wikis [21:44:45] And I'm not managing backport reverts for X time [21:44:46] right [21:44:52] It's essentially as bad as the live hacks [21:45:00] Pretty sure it doesn't break a wiki if you run update.php like you're supposed to after updating [21:45:19] We don't use update.php on the cluster for a reason [21:45:22] (which is the server admin's job) [21:45:22] Krenair: the dbs weren't ready/done with the schema change [21:45:23] Schema changes can take a fucking age [21:45:42] sure, on a little 2 person wiki, run update.php, for wmf wikis? hah [21:45:44] (03CR) 10Parent5446: "I'm not even going to bother explaining how that's a terrible method of deploying software." [core] - 10https://gerrit.wikimedia.org/r/105243 (owner: 10Umherirrender) [21:45:50] lolololol [21:45:52] sorry Tyler [21:46:37] (03CR) 10Reedy: "I'm not sure anyone said it wasn't" [core] - 10https://gerrit.wikimedia.org/r/105243 (owner: 10Umherirrender) [21:47:27] Found it [21:47:48] (03CR) 10Reedy: "https://www.mediawiki.org/wiki/Development_policy#Database_patches" [core] - 10https://gerrit.wikimedia.org/r/105243 (owner: 10Umherirrender) [21:47:50] (03CR) 10Greg Grossmeier: "Tyler: If you think continuous deployment and the use of feature flags is a bad method, please do explain. Unfortunately, it's pretty well" [core] - 10https://gerrit.wikimedia.org/r/105243 (owner: 10Umherirrender) [21:48:30] This is one (of X) schema changes to make future schema changes quicker [21:48:33] u [21:48:49] Has he got a time machine to go back and have it fixed at time of introduction? [21:50:23] I note the merging of the commit to add the column was delayed for an ahe [21:50:24] *age [21:51:15] 7.5 months... And that's not including the change set I pulled those changes out of [21:51:56] (03CR) 10CSteipp: [C: 031] "Looks like it should work, and is a good check. But I'll defer to anyone who is a lua developer." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107383 (owner: 10Anomie) [21:52:14] (03CR) 10Gergő Tisza: [C: 04-1] "Apparently this will compile PIL with the wrong flags (zlib support missing)." [vagrant] - 10https://gerrit.wikimedia.org/r/107429 (owner: 10Gergő Tisza) [21:53:41] (03CR) 10Anomie: [C: 04-1] "Needs validation:" (031 comment) [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/105979 (owner: 10Jackmcbarn) [21:54:32] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This looks like a bad way to do this, we should just pass on the URL parameters verbatim if anything." [core] - 10https://gerrit.wikimedia.org/r/107359 (owner: 10Gerrit Patch Uploader) [21:55:47] (03PS2) 10Ebe123: Use namespace ID for Module: namespace This commit changes all the proper names for namespaces into their IDs. This change was meant for the Module: and Module_talk: namespaces (ID 828 and 829 respectivily) specifically, but for consistancy in the array, [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/107313 [21:58:22] <^d> Krenair: I'm more worried about the LQT side :) [21:58:43] <^d> If you can review it and +1, and manybubbles can review and +1, I'll count that as a +2 in this case. [22:00:04] (03CR) 10Anomie: "Keep it an array, just munge it to be 1-based instead of 0-based. The correct output would be something like this:" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107046 (owner: 10Jackmcbarn) [22:03:42] (03PS1) 10Reedy: Make WikiPage::$mPreparedEdit public [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107488 [22:03:59] (03PS2) 10Reedy: Make WikiPage::$mPreparedEdit public [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107488 [22:09:28] (03PS7) 10Jackmcbarn: Add mw.ext.TitleBlacklist.test [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/105979 [22:12:09] (03CR) 10Ori.livneh: "I think you know this already, but just in case: we support the use of pip as a Package provider in Puppet, so you can do:" [vagrant] - 10https://gerrit.wikimedia.org/r/107429 (owner: 10Gergő Tisza) [22:13:46] (03PS2) 10Ori.livneh: Updating list-roles helper regex [vagrant] - 10https://gerrit.wikimedia.org/r/107316 (owner: 10Ottomata) [22:13:50] (03CR) 10Ori.livneh: [C: 032] Updating list-roles helper regex [vagrant] - 10https://gerrit.wikimedia.org/r/107316 (owner: 10Ottomata) [22:13:53] (03Merged) 10jenkins-bot: Updating list-roles helper regex [vagrant] - 10https://gerrit.wikimedia.org/r/107316 (owner: 10Ottomata) [22:14:58] (03CR) 10Gergő Tisza: "I didn't, thanks! But it seems pip does not compile the optional dependencies into PIL, even if they are present." [vagrant] - 10https://gerrit.wikimedia.org/r/107429 (owner: 10Gergő Tisza) [22:15:04] (03CR) 10CSteipp: "I agree with Anomie on the message issue, so I don't think we should push this out without a fix." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/106845 (owner: 10Brion VIBBER) [22:16:05] (03CR) 10Brion VIBBER: "Thanks for the feedback! *nod* alright I'll see if I can modify the hook usage to return a cleaner result in place of the error, but not a" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/106845 (owner: 10Brion VIBBER) [22:16:21] woot [22:17:24] (03CR) 10Ori.livneh: "Weeee, very nice. A couple of very minor points inline, but looks good otherwise." (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/107317 (owner: 10Ottomata) [22:19:48] (03CR) 10Ori.livneh: "It's a known issue with (yay) a known workaround:" [vagrant] - 10https://gerrit.wikimedia.org/r/107429 (owner: 10Gergő Tisza) [22:19:59] (03CR) 10Chad: [C: 032] Handle near match conflicts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107433 (owner: 10Manybubbles) [22:20:07] (03Merged) 10jenkins-bot: Handle near match conflicts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107433 (owner: 10Manybubbles) [22:24:54] (03PS3) 10Ottomata: Adding role::hadoop and role::hive [vagrant] - 10https://gerrit.wikimedia.org/r/107317 [22:25:14] (03CR) 10Ottomata: Adding role::hadoop and role::hive (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/107317 (owner: 10Ottomata) [22:25:56] (03PS4) 10Ottomata: Adding role::hadoop and role::hive [vagrant] - 10https://gerrit.wikimedia.org/r/107317 [22:27:25] (03PS4) 10Mattflaschen: Remove Special:GettingStarted and notifications [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/106458 [22:27:27] (03PS6) 10Mattflaschen: WIP: Remove uses of Special:GettingStarted from task toolbar [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103740 [22:30:04] (03CR) 10VitaliyFilippov: "Too bad this commit removes the single way for an extension to modify the indexed text. I've used it in TikaMW to index binary file conten" [core] - 10https://gerrit.wikimedia.org/r/79025 (owner: 10Chad) [22:30:40] (03CR) 10Ori.livneh: [C: 032] "Works, unblocks me." [vagrant] - 10https://gerrit.wikimedia.org/r/107202 (owner: 10Ori.livneh) [22:30:43] (03Merged) 10jenkins-bot: Bugfix for 'reset-roles' argument handling [vagrant] - 10https://gerrit.wikimedia.org/r/107202 (owner: 10Ori.livneh) [22:30:45] (03PS2) 10Ori.livneh: Bugfix for 'reset-roles' argument handling [vagrant] - 10https://gerrit.wikimedia.org/r/107202 [22:33:05] (03CR) 10Ori.livneh: [C: 04-1] "Puppet::Parser::AST::Resource failed with error ArgumentError: Could not find declared class ::cdh4::hadoop" [vagrant] - 10https://gerrit.wikimedia.org/r/107317 (owner: 10Ottomata) [22:34:56] (03CR) 10Aaron Schulz: [C: 032] pageid parser function is expensive, make it so [core] - 10https://gerrit.wikimedia.org/r/107456 (owner: 10Anomie) [22:35:26] (03CR) 10TheDJ: "Other than the 2 small notes, I'm good to go on this." (032 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/105187 (owner: 10Physikerwelt) [22:38:15] (03Merged) 10jenkins-bot: pageid parser function is expensive, make it so [core] - 10https://gerrit.wikimedia.org/r/107456 (owner: 10Anomie) [22:42:31] (03PS5) 10Ottomata: Adding role::hadoop and role::hive [vagrant] - 10https://gerrit.wikimedia.org/r/107317 [22:45:33] (03PS6) 10Ottomata: Adding role::hadoop and role::hive [vagrant] - 10https://gerrit.wikimedia.org/r/107317 [22:46:21] (03PS7) 10Ottomata: Adding role::hadoop and role::hive [vagrant] - 10https://gerrit.wikimedia.org/r/107317 [22:49:38] (03CR) 10Raimond Spekking: "Perfect. I have enabled the extension on translatewiki.net now: https://translatewiki.net/wiki/Special:Translate/ext-mediawikichat" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/107361 (owner: 10Raimond Spekking) [22:51:19] (03PS1) 10MaxSem: Update help URL [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/107495 [22:52:04] (03CR) 10MaxSem: [C: 032] "Trivial." [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/107495 (owner: 10MaxSem) [22:52:11] (03PS3) 10Jackmcbarn: Add protectionLevels variable to mw.title output [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107046 [22:56:27] (03CR) 10TheDJ: "Why again did this process strong.error ?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/83399 (owner: 10Frédéric Wang) [22:56:52] anyone here have less than 4gb of ram on their dev machine? [22:57:17] why? [22:57:32] trying to get a sense of who would be negatively impacted if mediawiki-vagrant's default vm memory allocation is increased to 2048mb [22:57:37] (03PS1) 10EBernhardson: [WIP] Mysql slave with permenant slave-lag [vagrant] - 10https://gerrit.wikimedia.org/r/107497 [22:57:41] i have 3 gb [22:57:45] (03PS1) 10Aaron Schulz: Revert "SpecialContributions: Avoid using 'contributions' slave for getParentLengths" [core] - 10https://gerrit.wikimedia.org/r/107498 [22:57:45] but i don't use vagrant ;) [22:58:06] (i'll have 4 when i kill this silly 32-bit system here finally) [22:58:23] i wish ruby had a portable way of checking ram size [22:58:48] (03CR) 10EBernhardson: [C: 04-1] "This is pretty far from being usable, only putting it up because its far enough along to setup the second mysql on my labs vagrant instanc" [vagrant] - 10https://gerrit.wikimedia.org/r/107497 (owner: 10EBernhardson) [23:14:20] (03PS8) 10Ori.livneh: Adding role::hadoop and role::hive [vagrant] - 10https://gerrit.wikimedia.org/r/107317 (owner: 10Ottomata) [23:14:22] (03PS1) 10Ori.livneh: Specify config.vm.hostname as value for facter 'fqdn' fact [vagrant] - 10https://gerrit.wikimedia.org/r/107504 [23:16:42] (03PS1) 10Chad: Move boost-templates into other operator handling [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/107505 [23:17:38] (03CR) 10Ottomata: [C: 032] Specify config.vm.hostname as value for facter 'fqdn' fact [vagrant] - 10https://gerrit.wikimedia.org/r/107504 (owner: 10Ori.livneh) [23:17:41] (03Merged) 10jenkins-bot: Specify config.vm.hostname as value for facter 'fqdn' fact [vagrant] - 10https://gerrit.wikimedia.org/r/107504 (owner: 10Ori.livneh) [23:25:54] (03PS10) 10Bsitu: Topic and Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 [23:26:05] (03CR) 10jenkins-bot: [V: 04-1] Topic and Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu) [23:26:45] (03CR) 10Ori.livneh: [C: 032] "Really nice. A couple of ideas for future commits:" [vagrant] - 10https://gerrit.wikimedia.org/r/107317 (owner: 10Ottomata) [23:26:47] (03Merged) 10jenkins-bot: Adding role::hadoop and role::hive [vagrant] - 10https://gerrit.wikimedia.org/r/107317 (owner: 10Ottomata) [23:29:10] (03PS11) 10Bsitu: Topic and Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 [23:32:06] (03CR) 10Jackmcbarn: [C: 04-1] "Hold on." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107046 (owner: 10Jackmcbarn) [23:40:51] (03PS21) 10Alex Monk: Cross-wiki user rights UI should show target wiki groups instead of local [core] - 10https://gerrit.wikimedia.org/r/36330 [23:43:50] Anyone familiar with Jenkins around? [23:44:03] ^d? [23:44:16] (03CR) 10jenkins-bot: [V: 04-1] Cross-wiki user rights UI should show target wiki groups instead of local [core] - 10https://gerrit.wikimedia.org/r/36330 (owner: 10Alex Monk) [23:45:14] (well, more our jenkins setup really.) [23:45:42] <^d> Sup? [23:45:49] (03PS5) 10Chad: Allow SearchResults to specify that they matched file content [core] - 10https://gerrit.wikimedia.org/r/105234 [23:45:51] * ^d was mid-commit, sorry for lag [23:46:10] (03PS12) 10Bsitu: Topic and Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 [23:46:26] ^d, is jenkins' wiki api at /wiki/api.php ? [23:46:49] Already on it [23:46:53] (when run from that wiki of course) [23:49:42] <^d> Krenair: Now that I have no clue about. [23:49:50] <^d> Sowwy :( [23:49:51] ^d: I already have it [23:49:55] just let me finish my CR [23:50:17] the issue is this failure: MWException: Failed to make HTTP request to /wiki/api.php?format=json&action=query&meta=siteinfo&siprop=usergroups for foreign user groups [23:50:31] I know [23:50:44] (that was for ^d) [23:53:51] (03PS1) 10Jdlrobson: Fix image paths [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107513 [23:54:35] (03CR) 10Hoo man: [C: 04-1] "Took a quick glance." (037 comments) [core] - 10https://gerrit.wikimedia.org/r/36330 (owner: 10Alex Monk) [23:55:43] (03CR) 10Jackmcbarn: "All good now." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107046 (owner: 10Jackmcbarn) [23:55:52] (03PS4) 10Jackmcbarn: Add protectionLevels variable to mw.title output [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107046 [23:58:00] (03CR) 10Ori.livneh: [C: 04-1] "Looks good. Because mw.Debug.Profile is a singleton you might as well avoid using 'this', and instead do something like var self = mw.Debu" [core] - 10https://gerrit.wikimedia.org/r/104318 (owner: 10EBernhardson)