[00:01:09] (03CR) 10Alex Monk: [C: 032] Revert "Include short descriptions for extensions bundled in the release" [core] - 10https://gerrit.wikimedia.org/r/107107 (owner: 10MaxSem) [00:04:09] (03Merged) 10jenkins-bot: Revert "Include short descriptions for extensions bundled in the release" [core] - 10https://gerrit.wikimedia.org/r/107107 (owner: 10MaxSem) [00:20:05] (03PS1) 10Legoktm: Allow local prefs to show up on global prefs page [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/107109 [00:39:28] hoo, around? [00:40:20] Krenair: More or less ;) [00:40:47] hoo, I've found a bunch of old CA log entries from 2009 sitting around with wrong-language information in them :/ [00:41:38] mh? [00:45:41] hoo, http://pastebin.com/CWgPtrCh [00:46:36] Ah, I see the content language stuff [00:46:55] Yes [00:47:47] "222 rows" mh... that's not really much... [00:47:58] DELETE FROM... [00:48:02] hehe [00:48:33] (03PS2) 10MarkAHershberger: make release notes ordering more consistant [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107012 [00:48:50] Reedy: Come on... people will notice... SET log_params = 'locked' WHERE ... [00:49:05] Nobody will notice... ever :P [00:49:07] How will they notice if it's not there? [00:49:08] :D [00:49:15] :D [00:49:22] (03CR) 10MarkAHershberger: "think previous jenkins failure was intermittent, so trying to force a rebuild." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107012 (owner: 10MarkAHershberger) [00:51:20] Krenair: I don't think this really matters... if you think it does, I guess we can force Chris into updating these... just hacking some SQL queries will suffice :P [00:51:29] A maint. script for that seems a bit over the top [00:51:46] hoo, no I don't think it matters at all [00:52:20] just a random anomaly I noticed as I accidentally had mysql spam me with a few thousand entries earlier [00:53:07] We had that stuff in various areas before... I can remember then we migrated to the new messages API we had a lot of these pop up :P [00:53:12] * when [00:58:37] hoo: also we apparently have 2432 entries where log_action=NULL, 'hide', 'lock', 'lockandhid', 'unhide', or 'unlock' under log_type='globalauth' [00:58:47] probably all legacy too... [00:59:46] I like NULL :P [00:59:55] hope these aren't recent [01:00:17] ew, I think it's 2432... [01:00:32] er* [01:00:33] (03CR) 10MarkAHershberger: [C: 032] make release notes ordering more consistant [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107012 (owner: 10MarkAHershberger) [01:02:28] hoo, I think the log_action=NULL ones are deleted [01:02:57] might be labs messing with you [01:03:33] (03Merged) 10jenkins-bot: make release notes ordering more consistant [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107012 (owner: 10MarkAHershberger) [01:03:50] hoo: in all of them, log_deleted & 1 [01:04:51] mh... look probably labs messing with their views... hard to tell, though [01:05:54] Yes I'm pretty sure that's what it is [01:06:58] Give me on the of the ids and I'll look it up on production [01:08:13] 6622436 [01:09:40] http://p.defau.lt/?yiCkkGGW2dDi3idA_HHHcA [01:09:41] (03CR) 10MarkAHershberger: "thanks for reverting the var_dump() -- clearly why self-merging is wrong." [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [01:10:08] um. [01:10:35] Reedy, that's enwiki [01:10:45] Where are we supposed to be? [01:10:51] metawiki [01:10:51] meta? [01:11:30] log_action is setstatus for that one [01:11:54] yeah okay, so it is just labs blanking it hoo [01:12:42] thought so :/ [01:13:12] Labs became incredibly useless for such things recently... had similar stuff in the last weeks more and more often [01:13:22] TS seems to have cut down its views also :( [01:14:36] * hoo beats himself for beeing stupid [01:14:38] unrelated [01:25:25] (03PS1) 10MarkAHershberger: Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/107110 [01:26:27] (03CR) 10MarkAHershberger: "Please see https://gerrit.wikimedia.org/r/107110 for the follow-up." [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [01:29:12] (03PS2) 10MarkAHershberger: Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/107110 [01:31:50] (03PS3) 10MarkAHershberger: Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/107110 [01:32:52] (03CR) 10MarkAHershberger: Include short descriptions for extensions bundled in the release (034 comments) [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [03:08:12] (03PS1) 10MarkAHershberger: Add sequence support for externallinks table [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107111 [03:09:20] (03CR) 10MarkAHershberger: [C: 032] Add sequence support for externallinks table [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107111 (owner: 10MarkAHershberger) [03:10:31] (03PS1) 10MarkAHershberger: Changed FOR UPDATE handling in Postgresql [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107112 [03:11:41] (03CR) 10MarkAHershberger: [C: 032] Changed FOR UPDATE handling in Postgresql [core] - 10https://gerrit.wikimedia.org/r/69767 (owner: 10Parent5446) [03:13:06] (03Merged) 10jenkins-bot: Add sequence support for externallinks table [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107111 (owner: 10MarkAHershberger) [03:13:16] (03CR) 10MarkAHershberger: [C: 032] Changed FOR UPDATE handling in Postgresql [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107112 (owner: 10MarkAHershberger) [03:15:47] (03Merged) 10jenkins-bot: Changed FOR UPDATE handling in Postgresql [core] - 10https://gerrit.wikimedia.org/r/69767 (owner: 10Parent5446) [03:17:08] (03Merged) 10jenkins-bot: Changed FOR UPDATE handling in Postgresql [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107112 (owner: 10MarkAHershberger) [03:20:13] (03CR) 10MarkAHershberger: [C: 04-2] "One of the suggested alternatives is now merged." [core] - 10https://gerrit.wikimedia.org/r/103379 (owner: 10btongminh) [03:29:02] (03CR) 10MarkAHershberger: "I'd like to get this into the 1.22.1 release (coming out tomorrow). If the page is put in place (I've also requested this on the talk pag" [core] - 10https://gerrit.wikimedia.org/r/102081 (owner: 10PleaseStand) [04:17:32] (03CR) 10Parent5446: [C: 04-1] "Agreed with Platonides. User::isIP functions that way on purpose. The change made to the regex in IP.php, however, seems to work fine, so " [core] - 10https://gerrit.wikimedia.org/r/107044 (owner: 10Yuvipanda) [04:21:59] (03CR) 10Parent5446: [C: 032] "Oh yeah didn't think about that." [core] - 10https://gerrit.wikimedia.org/r/106944 (owner: 10PleaseStand) [04:25:03] (03CR) 10Parent5446: [C: 04-1] Change return value of self::urlFunction from array to boolean (032 comments) [core] - 10https://gerrit.wikimedia.org/r/107017 (owner: 1001tonythomas) [04:25:40] (03Merged) 10jenkins-bot: Revert "Mechanism for renaming/aliasing classes" [core] - 10https://gerrit.wikimedia.org/r/106944 (owner: 10PleaseStand) [04:25:52] (03PS2) 10Parent5446: Add an &wpWatchlist option [core] - 10https://gerrit.wikimedia.org/r/107043 (owner: 10Yuvipanda) [04:26:19] (03CR) 10Legoktm: [C: 031] "It's a wiki, you can just move it ;-)" [core] - 10https://gerrit.wikimedia.org/r/102081 (owner: 10PleaseStand) [04:45:04] (03CR) 10PleaseStand: "I have moved the page, and I will now rebase this change against current master and address Siebrand's comment regarding HTTPS links." [core] - 10https://gerrit.wikimedia.org/r/102081 (owner: 10PleaseStand) [05:04:54] (03PS2) 10PleaseStand: Check for very old PCRE versions in installer and updater [core] - 10https://gerrit.wikimedia.org/r/102081 [05:05:06] (03PS3) 10PleaseStand: Check for very old PCRE versions in installer and updater [core] - 10https://gerrit.wikimedia.org/r/102081 [06:03:29] (03PS1) 10Gnosygnu: v1.1.2.1 [xowa] - 10https://gerrit.wikimedia.org/r/107114 [06:03:59] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/107114 (owner: 10Gnosygnu) [06:21:32] (03PS1) 10Legoktm: Rename GlobalPreferences::resetUserSettings [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/107115 [06:21:34] (03PS1) 10Legoktm: Only create table if wiki is the central database [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/107116 [07:25:34] (03CR) 10Legoktm: [C: 032] Allow local prefs to show up on global prefs page [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/107109 (owner: 10Legoktm) [07:25:39] (03Merged) 10jenkins-bot: Allow local prefs to show up on global prefs page [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/107109 (owner: 10Legoktm) [07:25:48] (03CR) 10Legoktm: [C: 032] Rename GlobalPreferences::resetUserSettings [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/107115 (owner: 10Legoktm) [07:25:53] (03Merged) 10jenkins-bot: Rename GlobalPreferences::resetUserSettings [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/107115 (owner: 10Legoktm) [07:25:56] (03CR) 10Legoktm: [C: 032] Only create table if wiki is the central database [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/107116 (owner: 10Legoktm) [07:26:02] (03Merged) 10jenkins-bot: Only create table if wiki is the central database [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/107116 (owner: 10Legoktm) [07:26:30] (03Abandoned) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/103940 (owner: 10Legoktm) [07:35:16] (03PS5) 1001tonythomas: Change return value of self::urlFunction from array to boolean [core] - 10https://gerrit.wikimedia.org/r/107017 [07:42:06] (03CR) 1001tonythomas: "@Parent5446: Changed." [core] - 10https://gerrit.wikimedia.org/r/107017 (owner: 1001tonythomas) [08:41:17] (03CR) 10Fomafix: Move toctoggle from mediawiki.util.js to separate file mediawiki.toc.js (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106132 (owner: 10Gerrit Patch Uploader) [08:50:26] what's the mingle view for velocity? [09:00:43] !jenkins mwext-TemplateData-qunit [09:00:43] https://integration.wikimedia.org/ci/job/mwext-TemplateData-qunit [09:07:45] (03CR) 10Gergő Tisza: [C: 031] image url not evaluated [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/107038 (owner: 10Dan-nl) [09:09:12] (03Abandoned) 10Pastakhov: fix bug 15538 [core] - 10https://gerrit.wikimedia.org/r/106657 (owner: 10Pastakhov) [09:10:13] hashar: finally we're up at the same time :) [09:10:38] don't get mistaken, I am still sleeping :-] Just pretending to be awake while waiting for coffee to take effect hehe [09:11:28] I'm debating whether or not to have tea or get ready for bed :) Thanks for helping with KSS-doc setup, I need to get back to it. [09:11:47] KSS? [09:11:53] a CSS documentation /linter? [09:13:05] hashar, the thing that builds https://wikitech.wikimedia.org/wiki/Deployments which we should put on doc.wikimedia.org [09:13:24] ^ I mean http://ee-flow-extra.instance-proxy.wmflabs.org/w/resources/mediawiki.ui/docs/section-2.html [09:14:49] are 1.23wmfXX deployments cancelled the week of January 20th? It looks that way from https://wikitech.wikimedia.org/wiki/Deployments [09:16:00] yeah week of Jan 20th is the MEdiaWiki Summit [09:16:06] so most of us are flying in SF office [09:16:20] and can't do any deployment since we are going to be busy drinking beers with you guys [09:16:31] and spend 2 days discussing about MediaWiki future hehe [09:17:24] ahh [09:17:39] spage: did you know mw/core had a directory /docs/uidesign/ ? :D [09:17:48] hashar, what are your dates? [09:18:02] MaxSem: I am landing on Jan 20th around noon PST iirc [09:18:25] should be in hotel lobby washed and ready around 4pm [09:18:41] (since custom takes me usually 2 hours, + 1 hour of BART + 1 hour of shower) [09:19:19] I'm arriving late on 19th [09:19:35] full hour of shower, wow [09:19:59] given I wake up at 5am and land at 9pm … yeah definitely need a shower [09:20:55] hashar: that's a different kind of design than beveled bottom buttons :) I hope to see you when you're here, I always learn a lot [09:21:22] spage: we can book something on tuesday morning maybe ? [09:21:34] spage: feel free to gather some more people if you want :] [09:21:42] I am terrible at organizing meeting /tutorials [09:22:35] MaxSem: landing at 1pm. and I have no hotel apparently :-] [09:23:01] eugh [09:25:25] (03CR) 10TheDJ: "Alternative idea, I think using XHR+CORS -> Blob -> Worker should work." [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/106673 (owner: 10TheDJ) [09:28:20] hashar: I was looking at docs/design :P docs/uidesign is interesting, thanks. I prefer a Special:DesignGuide, you need to see design in context so you can try it with different skins, RTL languages, beta features, etc. but writing a special page just for a fragment of HTML is a hassle. [09:30:28] spage: in that directory I usually only have a look / points folks to docs/uidesign/monospace.html which highlight how crazy font: monospace; is :D [09:48:44] (03CR) 10Parent5446: "Shouldn't a check also be added to index.php et. al? We also check the PHP version there." [core] - 10https://gerrit.wikimedia.org/r/102081 (owner: 10PleaseStand) [09:50:09] (03CR) 10Parent5446: [C: 04-1] Change return value of self::urlFunction from array to boolean (032 comments) [core] - 10https://gerrit.wikimedia.org/r/107017 (owner: 1001tonythomas) [10:07:22] (03CR) 10MaxSem: "We don't need to check for every possible problem on every request. After all, the obsolete PCRE problem is quite rare and affects only us" [core] - 10https://gerrit.wikimedia.org/r/102081 (owner: 10PleaseStand) [10:16:58] (03CR) 10Dzahn: [C: 031] "what andre said" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106883 (owner: 10Tinaj1234) [10:17:50] (03PS9) 10Amire80: Remove call to deprecated ParserOptions::getMath [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 (owner: 10Physikerwelt) [10:18:18] (03CR) 10Dzahn: Added Link to Bugzilla Etiquette in footer (031 comment) [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106757 (owner: 1001tonythomas) [10:29:56] (03PS7) 10Amire80: Validate TeX input for all renderers, not just texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/105187 (owner: 10Physikerwelt) [10:32:37] (03CR) 10Amire80: "Just some code style changes. Shouldn't change much, but please re-test." [extensions/Math] - 10https://gerrit.wikimedia.org/r/105187 (owner: 10Physikerwelt) [10:33:10] (03CR) 10Amire80: "Just some code style changes. Shouldn't change anything, but please re-test." [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 (owner: 10Physikerwelt) [10:35:10] (03PS1) 10Gerrit Patch Uploader: Ensure a space of 0.5em between dt and dd in legend [core] - 10https://gerrit.wikimedia.org/r/107126 [10:35:12] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/107126 (owner: 10Gerrit Patch Uploader) [10:42:22] hey, CSS gurus/designers,, 'dis true? font-weight: bold; /* This might look stupid, but is needed to prevent double-bolding with Arial font */ [10:43:38] in BZ skins/contrib/Wikimedia/global.css [10:44:45] https://bugzilla.wikimedia.org/show_bug.cgi?id=59749 [10:45:53] (03CR) 10Dzahn: "please wait for test results per last comment on the linked bug" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/105921 (owner: 10TTO) [11:13:43] (03CR) 10Dzahn: "please reach consensus on the bug or get more reviews" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106864 (owner: 1001tonythomas) [11:14:30] (03CR) 10Hashar: "Wikimedia uses getAll() in operations/mediawiki-config.git at wmf-config/CommonSettings.php" [core] - 10https://gerrit.wikimedia.org/r/107034 (owner: 10Tinaj1234) [11:22:16] (03PS1) 10Gergő Tisza: Add $wgFavicon to siteinfo API [core] - 10https://gerrit.wikimedia.org/r/107127 [11:23:43] (03CR) 10Dzahn: "do we really not need these because _all_ links are https already or do we have http links mixed in there (like see https://gerrit.wikimed" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106761 (owner: 1001tonythomas) [12:10:37] (03CR) 10Tinaj1234: "Sure :)" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106883 (owner: 10Tinaj1234) [12:28:55] (03PS2) 10Gerrit Patch Uploader: Use textarea instead of input for wpReason [core] - 10https://gerrit.wikimedia.org/r/107042 (owner: 10Yuvipanda) [12:28:57] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/107042 (owner: 10Yuvipanda) [12:36:01] (03CR) 10Mdale: [C: 032 V: 032] "COPYING file should commit to repo." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/95781 (owner: 10Mdale) [12:47:39] My bug is to arrange the contents of select box in alphabetical order. I have found the php file which must changed but I don't know how I must proceed. So how should I proceed? The file to changed is core/core/includes/WatchedItem.php [13:54:48] (03CR) 10Theopolisme: image url not evaluated (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/107038 (owner: 10Dan-nl) [13:58:57] (03PS2) 10Dan-nl: image url not evaluated [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/107038 [13:59:26] (03CR) 10Dan-nl: "* addressed Theopolisme inline comment in ps1." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/107038 (owner: 10Dan-nl) [14:01:16] (03PS6) 1001tonythomas: Change return value of self::urlFunction from array to boolean [core] - 10https://gerrit.wikimedia.org/r/107017 [14:22:15] My bug is to arrange the contents of select box in alphabetical order. I have found the php file which must changed but I don't know how I must proceed. So how should I proceed? The file to changed is core/core/includes/WatchedItem.php [14:33:38] (03CR) 10Alex Monk: [C: 032] Fix link to article history not working properly when not using short URLs [extensions/LastModified] - 10https://gerrit.wikimedia.org/r/107013 (owner: 10Hydriz) [14:33:40] (03Merged) 10jenkins-bot: Fix link to article history not working properly when not using short URLs [extensions/LastModified] - 10https://gerrit.wikimedia.org/r/107013 (owner: 10Hydriz) [14:40:19] (03CR) 10Anomie: [C: 032] Add $wgFavicon to siteinfo API [core] - 10https://gerrit.wikimedia.org/r/107127 (owner: 10Gergő Tisza) [14:43:17] (03PS1) 10Matthias Mullie: Make error reporting more verbose. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107149 [14:43:20] (03PS1) 10Matthias Mullie: Fix warning [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107150 [14:43:23] (03PS1) 10Matthias Mullie: Create stub post object instead of failing completely [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107151 [14:43:26] (03PS1) 10Matthias Mullie: Fix MultiGetList results from cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107152 [14:43:29] (03Merged) 10jenkins-bot: Add $wgFavicon to siteinfo API [core] - 10https://gerrit.wikimedia.org/r/107127 (owner: 10Gergő Tisza) [14:59:02] Hi all [14:59:02] Shiva_V, hey! [14:59:10] (03CR) 10Anomie: Allow customizing post_zip destination (032 comments) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/106847 (owner: 10MaxSem) [14:59:48] I want to get started with wikimedia [15:00:02] Can somebody guide me from the begginning? [15:00:16] hi Shiva_V - do you want to get started with development? [15:00:28] Yeah for GSoC [15:00:57] https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker [15:01:20] but the most important part is to pick something to do and start hacking:) [15:02:27] Shiva_V: https://www.mediawiki.org/wiki/Annoying_little_bugs [15:03:56] tagged easy and sorted by most votes: https://bugzilla.wikimedia.org/buglist.cgi?columnlist=opendate%2Cvotes%2Cbug_severity%2Cpriority%2Cop_sys%2Cbug_status%2Cresolution%2Cshort_desc&field0-0-0=votes&keywords=easy&keywords_type=allwords&list_id=266612&order=votes%20DESC%2C&query_format=advanced&resolution=---&type0-0-0=greaterthan&value0-0-0=-1 [15:05:57] Thanks :) [15:13:26] (03CR) 10Anomie: [C: 031] "Seems ok to me, haven't tested." (031 comment) [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/106435 (owner: 10Kaldari) [15:19:58] (03PS1) 1001tonythomas: Removed the 2>&1 from doTransform and replaced wfShellExec with wfShellExecWithStderr [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/107161 [15:22:50] (03CR) 10Fomafix: "The current default settings for textarea in skins/common/commonElements.css is unusable as explained in the commit message. Either the de" [core] - 10https://gerrit.wikimedia.org/r/105207 (owner: 10Gerrit Patch Uploader) [15:23:58] (03CR) 10Zfilipin: [C: 04-1] Start getting PhantomJS working for tests (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106720 (owner: 10Manybubbles) [15:25:36] (03CR) 10Manybubbles: Start getting PhantomJS working for tests (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106720 (owner: 10Manybubbles) [15:26:58] (03PS2) 10Manybubbles: Start getting PhantomJS working for tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106720 [15:35:42] (03CR) 10MarkTraceur: [C: 031] "I'm OK with this solution, but 15 is not 25 (OK because the bug filer +1'd), and I'd almost rather have this be configurable (but OK becau" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/106891 (owner: 10Anjanasasindran123) [15:39:55] (03PS1) 10Hashar: json-lint.php: recursively lint json files with PHP [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107163 [15:40:03] hoo, regarding this code review :https://gerrit.wikimedia.org/r/#/c/107034/ I was thinking of deprecating the getAll()...but how do I call the function I want to keep inside getAll() ? [15:40:29] hoo, what about the parameters that is to be passed to that function? [15:43:00] (03CR) 10Zfilipin: "Why did you commit tests/browser/screenshot1.png?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106720 (owner: 10Manybubbles) [15:43:30] tina: "but how do I call the function I want to keep inside getAll() ? " what exactly do you mean with that? [15:43:34] (03PS3) 10Manybubbles: Start getting PhantomJS working for tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106720 [15:43:52] (03CR) 10Manybubbles: "Committed too fast." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106720 (owner: 10Manybubbles) [15:47:30] (03CR) 10Krinkle: [C: 04-1] "Instead of a separate module, this could perhaps be better suited as merely a separate file. Part of the mediawiki.page.ready module perha" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106132 (owner: 10Gerrit Patch Uploader) [15:50:48] (03CR) 10Zfilipin: [C: 031] Start getting PhantomJS working for tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106720 (owner: 10Manybubbles) [15:51:01] off to get a nap, see you tonight [15:52:35] jarry1250_: done! https://github.com/Jarry1250/labs-signpost/pull/1 [15:58:42] (03CR) 10Tinaj1234: "I thought of rewording the error tag as well. But couldn't find it. Anybody think that is necessary?" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106883 (owner: 10Tinaj1234) [16:04:04] (03PS2) 10Krinkle: json-lint.php: recursively lint json files with PHP [integration/jenkins] - 10https://gerrit.wikimedia.org/r/107163 (owner: 10Hashar) [16:05:04] (03CR) 10Mwalker: [C: 032] Add ability to have additional renderer settings [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/106749 (owner: 10Anomie) [16:19:57] (03PS2) 10Chad: Remove log10 from boost in prefix search [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106906 (owner: 10Manybubbles) [16:20:07] (03PS1) 10Mwalker: Merge remote-tracking branch 'origin/OCG' [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/107166 [16:20:09] (03PS1) 10Mwalker: Localisation updates from https://translatewiki.net. [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/107167 [16:20:11] <^d> Blah that's not what I wanted to do. [16:21:33] (03CR) 10Mwalker: "Yes; this is an empty commit -- I couldn't merge the OCG branch without forcing this commit which apparently resolved itself earlier in th" [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/107167 (owner: 10Mwalker) [16:23:49] (03PS1) 10Anomie: Fix for breakage re-introduced in I364e192e [core] - 10https://gerrit.wikimedia.org/r/107168 [16:23:51] (03CR) 10Anomie: "Sigh. You broke things AGAIN with your change of MySQLMasterPos::$pos to private. I563bde45 told you exactly what it broke, why in the wor" [core] - 10https://gerrit.wikimedia.org/r/103890 (owner: 10Siebrand) [16:26:22] (03CR) 10Mwalker: Allow customizing post_zip destination (031 comment) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/106847 (owner: 10MaxSem) [16:28:21] jarry1250_: thanks [16:30:45] (03CR) 10Anomie: [C: 032] "It's not clear in Gerrit whether this is merging OCG into master, or master into OCG. Let's find out." [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/107166 (owner: 10Mwalker) [16:30:52] (03Merged) 10jenkins-bot: Merge remote-tracking branch 'origin/OCG' [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/107166 (owner: 10Mwalker) [16:34:54] (03CR) 10Krinkle: Add mw.ext.TitleBlacklist.test (031 comment) [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/105979 (owner: 10Jackmcbarn) [16:44:00] (03PS1) 10Anomie: Merge OCG branch into master [extensions/Collection] - 10https://gerrit.wikimedia.org/r/107175 [16:50:10] (03CR) 10Anomie: "No idea. Can we just abandon it now?" [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/107167 (owner: 10Mwalker) [16:53:11] (03CR) 10Scimonster: [C: 031] Ensure a space of 0.5em between dt and dd in legend [core] - 10https://gerrit.wikimedia.org/r/107126 (owner: 10Gerrit Patch Uploader) [16:55:40] James_F: do you know when the VE repo renames are going to happen? [16:59:20] YuviPanda: We just canceled them [16:59:25] oh? [16:59:33] for today or...? [16:59:46] We chickened out and are now going to use a Jenkins postmerge job to update the submodule instead [16:59:52] brrr [17:00:00] RoanKattouw: that still breaks other extensions I think [17:00:09] RoanKattouw: so my extension can't get deployed on betalabs [17:00:10] Which ones? [17:00:14] MobileApp [17:00:16] as in [17:00:20] Allegedly the only reason VE is broken is because it has the same name as another repo [17:00:43] hashar told me that VE needs to be unbroken before new extensions can be add3ed [17:00:44] *added [17:00:49] because Gerrit was borking on those [17:01:03] I'm unsure of the details. [17:05:06] RoanKattouw: any idea why you pulled out of the rename? [17:05:23] We figured it would break too many things [17:05:44] like people's local clones? :) [17:08:14] For one [17:08:17] Jenkins, too [17:08:50] RoanKattouw: hmm, I'm not sure if that'll fix my issue (new extensions) but I guess I can poke hashar again when he comes back tomorrow [17:18:04] (03CR) 10TMg: [C: 031] mw.loader.store: More fault tolerance [core] - 10https://gerrit.wikimedia.org/r/100930 (owner: 10Bartosz Dziewoński) [17:22:59] (03PS1) 10Dereckson: Call Twitter API 1.1 instead of 1.0 [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/107180 [17:23:10] (03PS11) 10Matthias Mullie: [WIP] Edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 [17:23:16] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 (owner: 10Matthias Mullie) [17:25:01] (03PS12) 10Matthias Mullie: [WIP] Edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 [17:25:45] (03PS1) 10UltrasonicNXT: Fix links to users with spaces in their usernames [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/107181 [17:27:51] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix links to users with spaces in their usernames [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/107181 (owner: 10UltrasonicNXT) [17:29:19] (03PS2) 10MaxSem: Allow customizing post_zip destination [extensions/Collection] - 10https://gerrit.wikimedia.org/r/106847 [17:43:25] (03CR) 10Anomie: [C: 04-1] "The way that the 'AbortNewAccount' hook's error message is handled in SpecialUserlogin.php is causing API error responses like this:" (032 comments) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/106845 (owner: 10Brion VIBBER) [17:43:59] (03CR) 10saper: "Well, it's a dirty hack, we need a proper fix but let's go on with this ;)" [core] - 10https://gerrit.wikimedia.org/r/69767 (owner: 10Parent5446) [17:44:20] (03PS1) 10Jforrester: Fix links to "Typography Update" to be "Typography refresh" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/107183 [17:48:28] (03CR) 10Anomie: "Change seems ok, although reviewing this causes me to notice that the status objects being returned from $loginForm->addNewaccountInternal" [core] - 10https://gerrit.wikimedia.org/r/106844 (owner: 10Brion VIBBER) [17:56:46] marktraceur: At some point, can you take me through https://gerrit.wikimedia.org/r/#/c/100519/ at your laptop? /me lazy. ;-0\ [17:57:33] James_F: "yes" [17:57:47] (03CR) 10Aklapper: [C: 04-1] "Needs rework. On Zirconium, accessing https://bugzilla.wikimedia.org/show_bug.cgi?id=49597 triggers an issue with RT being in the "See Als" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98035 (owner: 10Aklapper) [17:57:59] marktraceur: Ta. [17:59:15] (03CR) 10Dzahn: "that's cause it's really not there:" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98035 (owner: 10Aklapper) [18:05:47] (03PS1) 10BryanDavis: Add missing admin-users-valid i18n key [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/107185 [18:13:20] (03CR) 10BryanDavis: Localisation updates from https://translatewiki.net. (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106904 (owner: 10L10n-bot) [18:26:08] (03PS1) 10Matthias Mullie: Refactor edit-header JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107187 [18:37:15] (03PS1) 10Mwalker: I broke it, now I fixed it [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107188 [18:37:33] (03PS3) 10Gerrit Patch Uploader: Move toctoggle from mediawiki.util.js to separate file mediawiki.toc.js [core] - 10https://gerrit.wikimedia.org/r/106132 [18:37:35] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/106132 (owner: 10Gerrit Patch Uploader) [18:38:14] (03CR) 10Mwalker: [C: 032 V: 032] I broke it, now I fixed it [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/107188 (owner: 10Mwalker) [18:39:16] (03PS2) 10Matthias Mullie: Fix MultiGetList results from cache [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107152 [18:41:26] (03PS1) 10Cscott: Use runs emitted by icu-bidi to implement Unicode bidi algorithm. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107190 [18:41:28] (03PS1) 10Cscott: Bidi improvements: turn off script-specific OpenFont features for LTR embeds. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107191 [18:41:48] (03CR) 10jenkins-bot: [V: 04-1] Use runs emitted by icu-bidi to implement Unicode bidi algorithm. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107190 (owner: 10Cscott) [18:41:50] (03CR) 10jenkins-bot: [V: 04-1] Bidi improvements: turn off script-specific OpenFont features for LTR embeds. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107191 (owner: 10Cscott) [18:43:21] (03CR) 10Fomafix: "I marked the remaining global function mediaWiki.util.toggleToc() as deprecated in patch set 3." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106132 (owner: 10Gerrit Patch Uploader) [18:46:09] (03PS2) 10Cscott: Bidi improvements: turn off script-specific OpenFont features for LTR embeds. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107191 [18:46:11] (03PS2) 10Cscott: Use runs emitted by icu-bidi to implement Unicode bidi algorithm. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107190 [18:51:40] (03CR) 10Bartosz Dziewoński: [C: 032] Ensure a space of 0.5em between dt and dd in legend [core] - 10https://gerrit.wikimedia.org/r/107126 (owner: 10Gerrit Patch Uploader) [18:55:11] (03Merged) 10jenkins-bot: Ensure a space of 0.5em between dt and dd in legend [core] - 10https://gerrit.wikimedia.org/r/107126 (owner: 10Gerrit Patch Uploader) [18:55:42] (03CR) 10Anomie: [C: 04-1] "I'm not too fond of loading the restrictions here unconditionally, considering that the separate restriction loading probably exists becau" (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107046 (owner: 10Jackmcbarn) [18:56:05] (03CR) 10Anomie: "Also, adding some unit tests for the new feature would be nice." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107046 (owner: 10Jackmcbarn) [18:58:28] (03PS2) 10Bartosz Dziewoński: Use box-sizing:border-box for textarea [core] - 10https://gerrit.wikimedia.org/r/105207 (owner: 10Gerrit Patch Uploader) [18:58:54] (03CR) 10Bartosz Dziewoński: [C: 031] "I'm going to merge this sometime, assuming Daniel doesn't dig out his explanation." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105207 (owner: 10Gerrit Patch Uploader) [19:02:54] (03CR) 10Anomie: [C: 04-1] Add mw.ext.TitleBlacklist.test (031 comment) [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/105979 (owner: 10Jackmcbarn) [19:05:14] oh heh, I managed to upgrade only to 13.04 - might have something to do with WMF-specific stuff [19:06:48] wrong channel [19:06:59] anomie: wait, so DBMasterPos has a getMasterPos method? [19:07:09] that seems wierd [19:08:09] AaronSchulz: It does since https://gerrit.wikimedia.org/r/#/c/105727/ :/ [19:08:26] it's probably easier to just leave all that stuff public [19:08:46] if you just made a revert commit I'd probably merge that [19:09:03] AaronSchulz: Heh, I was going to make the same offer. Sure, I'll do it. [19:09:05] having getMasterPos() spec'ed as returning an int seems limiting for other rdbmses [19:09:56] if there were non-speced accessors that are db type specific that could work too...but this seems to be a bit more trouble that it's worth [19:11:31] I guess it's kind of like FileBackendStoreOpHandle...a simple value object that is just "hot potato'ed" around by the more generic classes and used by the related classes that understand how to use it [19:13:30] AaronSchulz: Hmm. The only thing is, DatabaseBase::masterPosWait is assuming that DBMasterPos has a field "$pos" that is a timestamp, which it doesn't necessarily (although the MySQL version does). [19:14:03] I have no objection to making that an explicitly public field on DBMasterPos, but the function has more flexibility. I could go either way. [19:17:46] the fact that the fake slave lag stuff assumes MySQLMasterPos but is in the base class is already total garbage [19:19:06] Krinkle: You chiming in on the jquery.fullscreen licensing is blocking any movement on it, can you please respond? [19:21:36] (03PS5) 10Jackmcbarn: Add mw.ext.TitleBlacklist.test [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/105979 [19:22:04] (03CR) 10Mwalker: [C: 032 V: 032] Merge OCG branch into master [extensions/Collection] - 10https://gerrit.wikimedia.org/r/107175 (owner: 10Anomie) [19:22:43] (03PS6) 10Jackmcbarn: Add mw.ext.TitleBlacklist.test [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/105979 [19:23:04] (03PS6) 10Krinkle: mw.loader.store: More fault tolerance [core] - 10https://gerrit.wikimedia.org/r/100930 (owner: 10Bartosz Dziewoński) [19:23:36] (03CR) 10Krinkle: "Avoid "more (generically wanted thing in software)", clarified subject." [core] - 10https://gerrit.wikimedia.org/r/100930 (owner: 10Bartosz Dziewoński) [19:23:50] anomie: maybe all the fake slave lag stuff should just be moved to the mysql classes [19:24:22] anomie: re https://gerrit.wikimedia.org/r/#/c/107046/ , PROTECTIONLEVEL isn't even an expensive function call. also, making a new title already counts as expensive, and this saves a callback to php [19:24:26] any other DBs that have master/slave support would subclass those methods, and thus would have to re-implement that functionality anyway [19:24:35] is it really worth doing? [19:24:58] AaronSchulz: Probably. Although it looks like the base class might still need stub methods for LoadBalancer to call. I'll try to look at that this afternoon yet. [19:24:59] (03CR) 10CSteipp: "It would definitely change the behavior. Is there a problem / bug this is fixing?" [core] - 10https://gerrit.wikimedia.org/r/106855 (owner: 10Bartosz Dziewoński) [19:25:28] maybe a FakeMasterPos class can exists too [19:25:51] for classes that don't override the methods [19:26:11] jackmcbarn: PROTECTIONLEVEL on another title probably should be expensive if it isn't. [19:26:17] it isn't [19:26:30] (on the current title is probably ok to be non-expensive) [19:26:39] (03CR) 10Bartosz Dziewoński: "None I know of. It just seemed like a silly behavior; I'm not particularly attached to this patch, though. :)" [core] - 10https://gerrit.wikimedia.org/r/106855 (owner: 10Bartosz Dziewoński) [19:27:19] (03CR) 10Hoo man: "I like the idea, but this needs (manual) testing" [core] - 10https://gerrit.wikimedia.org/r/106855 (owner: 10Bartosz Dziewoński) [19:29:16] (03CR) 10Krinkle: mw.loader.store: Wrap script eval in try/catch (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100930 (owner: 10Bartosz Dziewoński) [19:29:20] (03CR) 10Krinkle: [C: 04-1] mw.loader.store: Wrap script eval in try/catch [core] - 10https://gerrit.wikimedia.org/r/100930 (owner: 10Bartosz Dziewoński) [19:29:20] anomie: would it be better to make it expensive based on mRestrictionsLoaded than whether or not it's the same page? [19:30:24] (03PS6) 10Kaldari: Modify the Special:LonelyPages query to ignore disambiguation pages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/106435 [19:30:24] jackmcbarn: Could do, although I'm wary of poking at mRestrictionsLoaded directly. See comment in Title.php line 51. [19:30:51] (03PS2) 10Ori.livneh: Fixed temp URL breakage in Swift [core] - 10https://gerrit.wikimedia.org/r/106777 (owner: 10Aaron Schulz) [19:31:00] gah, i didn't even see that. why are (almost) all of them declared "var" if they're meant to be private? [19:31:43] jackmcbarn: because PHP4 has no field visibility modifiers :D [19:31:44] PHP4 left overs... I kid you not [19:32:05] should that be fixed, or will it break a bunch of things? [19:32:11] both, yes [19:32:37] * jackmcbarn goes to code new accessors [19:35:33] (03CR) 10Bartosz Dziewoński: mw.loader.store: Wrap script eval in try/catch (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100930 (owner: 10Bartosz Dziewoński) [19:39:07] (03PS14) 10Gergő Tisza: Add blacklisting feature for flickr in backend [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [19:40:04] (03CR) 10Gergő Tisza: "Disabled the tests for now, will revisit after bug 59921 is fixed." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [19:43:46] (03Abandoned) 10Anomie: Fix for breakage re-introduced in I364e192e [core] - 10https://gerrit.wikimedia.org/r/107168 (owner: 10Anomie) [19:44:58] (03PS13) 10Matthias Mullie: [WIP] Edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 [19:45:57] marktraceur: https://github.com/theopolisme/jquery-fullscreen/issues/4#issuecomment-32203674 [19:46:19] (03PS5) 10Matthias Mullie: Refactor edit-post JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105674 [19:47:22] Thanks Krinkle [19:49:01] ori: were you reviewing https://gerrit.wikimedia.org/r/#/c/106777/ ? [19:49:13] AaronSchulz: no, just fixed a typo [19:49:20] oh [19:49:45] should i merge it? i presume you know what you're doing [19:50:00] I'd like to backport it to wmf10 [19:50:43] (03PS3) 10Ori.livneh: Fixed temp URL breakage in Swift [core] - 10https://gerrit.wikimedia.org/r/106777 (owner: 10Aaron Schulz) [19:51:19] (03CR) 10Ori.livneh: [C: 032] "Looks sane, Aaron knows what he's doing" [core] - 10https://gerrit.wikimedia.org/r/106777 (owner: 10Aaron Schulz) [19:54:43] (03Merged) 10jenkins-bot: Fixed temp URL breakage in Swift [core] - 10https://gerrit.wikimedia.org/r/106777 (owner: 10Aaron Schulz) [19:55:13] (03PS1) 10Aaron Schulz: Fixed temp URL breakage in Swift [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107197 [19:56:44] (03CR) 10Aaron Schulz: [C: 032] Fixed temp URL breakage in Swift [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107197 (owner: 10Aaron Schulz) [19:58:36] (03PS1) 10Jackmcbarn: Make PROTECTIONLEVEL count as expensive [core] - 10https://gerrit.wikimedia.org/r/107199 [19:59:54] (03Merged) 10jenkins-bot: Fixed temp URL breakage in Swift [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107197 (owner: 10Aaron Schulz) [20:01:00] (03PS1) 10Anomie: Move MySQL-specific fakeMaster/fakeSlave stuff to DatabaseMysqlBase [core] - 10https://gerrit.wikimedia.org/r/107200 [20:01:07] AaronSchulz: https://gerrit.wikimedia.org/r/107200 [20:02:00] when i use the new accessors from scribunto, what's the best way to not break compatibility? [20:02:13] type seconds %seconds jobs %jobs seconds/job [20:02:14] ParsoidCacheUpdateJobOnDependencyChange 6267920.37101 64.633 415917 4.993 15.07 [20:02:33] anomie: will look after lunch [20:03:27] (03PS1) 10MarkAHershberger: Add function to clear mPreparedEdit, to use in cases of mutable content [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107201 [20:03:31] greg-g: we have an upcoming patch to cut the displayed size of uuid's in flow by half. Part of this requires changing all the primary keys we use in sql from binary(16) to binary(11), and as such requires putting flow into a read-only mode. based on the new deployment calendar i think i put that into 'next month' and you schedule us a time? [20:04:16] would it be acceptable to have logic to use the accessor in 1.23+ and the "private" members 1.22-? [20:04:23] jackmcbarn: If the code in Scribunto can do something sane without those accessors, use is_callable to test before calling (and probably put in a @todo to clean it up later). If not... we've just been breaking compatibility with older MW versions in that sort of case. [20:04:34] jackmcbarn: Yeah, probably. With @todo. [20:04:47] (03PS1) 10Ori.livneh: Bugfix for 'reset-roles' argument handling [vagrant] - 10https://gerrit.wikimedia.org/r/107202 [20:05:36] (03PS5) 10Matthias Mullie: Refactor title JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101903 [20:05:37] ebernhardson: yessir, that's a good plan for that type of change [20:05:45] go ahead and add, I'll get to it after lunch [20:06:41] (03PS1) 10MarkAHershberger: Revert "Include short descriptions for extensions bundled in the release" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107204 [20:07:08] (03CR) 10MarkAHershberger: [C: 032] Revert "Include short descriptions for extensions bundled in the release" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107204 (owner: 10MarkAHershberger) [20:08:16] (03PS6) 10Matthias Mullie: Refactor edit-post JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105674 [20:09:21] hello [20:09:34] good evening, hashar [20:09:36] (03CR) 10Anomie: [C: 031] "Haven't tested yet." [core] - 10https://gerrit.wikimedia.org/r/107199 (owner: 10Jackmcbarn) [20:10:48] (03PS1) 10CSteipp: Add editmyoptions right to a new grant [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/107205 [20:10:50] (03CR) 10jenkins-bot: [V: 04-1] Revert "Include short descriptions for extensions bundled in the release" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107204 (owner: 10MarkAHershberger) [20:12:04] (03PS7) 10Matthias Mullie: Refactor edit-post JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105674 [20:13:58] (03PS2) 10MarkAHershberger: Revert "Include short descriptions for extensions bundled in the release" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107204 [20:14:31] (03CR) 10MarkAHershberger: [C: 032] Revert "Include short descriptions for extensions bundled in the release" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107204 (owner: 10MarkAHershberger) [20:15:04] (03CR) 10Anomie: [C: 032] Add editmyoptions right to a new grant [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/107205 (owner: 10CSteipp) [20:15:27] (03Merged) 10jenkins-bot: Add editmyoptions right to a new grant [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/107205 (owner: 10CSteipp) [20:15:56] (03PS4) 10Matthias Mullie: Refactor post-reply JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105699 [20:17:04] (03PS5) 10Matthias Mullie: Refactor title-reply JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106534 [20:18:00] (03CR) 10jenkins-bot: [V: 04-1] Revert "Include short descriptions for extensions bundled in the release" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107204 (owner: 10MarkAHershberger) [20:22:40] (03PS2) 10Matthias Mullie: Refactor new-topic JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106556 [20:23:47] (03PS2) 10Matthias Mullie: Refactor edit-header JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/107187 [20:28:18] (03CR) 10Alex Monk: "How does that bug block this?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [20:34:56] guys, I see https://www.mediawiki.org/wiki/Manual:$wgOut#Deprecation $wgOut shouldn't be used if possible, but what is the preferred way of doing it now? [20:35:19] I tried doing $parser->getOutput(); but that is not the same [20:35:54] how can I get the OutputPage I need to work with from a tag extension? [20:36:24] (03PS14) 10Matthias Mullie: Edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 [20:37:11] i am correct in assuming we are deprecating use of jquery ui? [20:38:39] jorm: superm401 is probably the person to ask [20:39:04] i'm trying to figure out how to build a split-button drop down and everything is pointing to jquery or bootstrap. [20:39:11] and the pickings are slim. [20:39:14] jorm, I'm just one of the people working on it. [20:39:28] But yeah, we're planning to move away from jQuery UI. [20:39:32] this is for a prototype demo but i'd like to keep it as clean as possible. [20:39:33] Joeytje50: why would you want to? [20:39:41] and bootstrap isn't in the cards either, i'd assume. [20:39:42] But part of the reason it's not deprecated officially is that we just don't have replacements for a lot of functionality in jQuery UI [20:39:54] Joeytje50: parsing will not necessarily happen during page rendering [20:40:04] Joeytje50: alternatively, many parses could occur during page rendering [20:40:18] yeah, i figured. [20:40:23] (03PS15) 10Matthias Mullie: Edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 [20:40:46] what I need it for is I need to add a single
tag to the page, since an should always be linked to a either via the form="" attribute, or being nested in it [20:41:18] since I don't want to spam tags all over the page for this extension I want to make, but I do need to use a lot of s, I'd like to just assign the form="" attribute [20:41:31] but for that to work, I need to append/prepend a to the page only once [20:41:58] MatmaRex: so what I'd like the OutputPage for is to append/prepend the [20:42:29] hmmm [20:43:18] Joeytje50: why don't you just insert the when inserting the first ? [20:43:28] you can store custom properties on the Parser instance you get, and AFAIK it's not reused for other parses, so you can store the state in there [20:43:49] (also, i didn't know about the attribute, nice thing to know (but no IE support :( )) [20:44:21] (03CR) 10MarkAHershberger: Revert "Include short descriptions for extensions bundled in the release" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107204 (owner: 10MarkAHershberger) [20:44:38] (03CR) 10MarkAHershberger: [C: 032] Revert "Include short descriptions for extensions bundled in the release" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107204 (owner: 10MarkAHershberger) [20:45:38] (03CR) 10Aaron Schulz: [C: 032] Move MySQL-specific fakeMaster/fakeSlave stuff to DatabaseMysqlBase [core] - 10https://gerrit.wikimedia.org/r/107200 (owner: 10Anomie) [20:45:40] MatmaRex: same goes for me about that parser property storing, how do I do that? [20:46:06] also, I just need the form="" attribute for making sure the HTML is syntactically and semantically correct [20:47:53] (03Merged) 10jenkins-bot: Revert "Include short descriptions for extensions bundled in the release" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107204 (owner: 10MarkAHershberger) [20:48:17] Hie, I am newbie and beginning my jouney in Wikimedia. I installed the wikimedia-vagrant and followed the instructions given on this link: http://www.mediawiki.org/wiki/MediaWiki-Vagrant. The setup runs correctly, but I cannot find any page when i connect to 127.0.0.1:8080. Also, inside the vagrant, I couldn't locate the wikimedia folder at the specified path. Am i missing something? pls help. [20:48:32] (03PS1) 10MarkAHershberger: Include short descriptions for extensions bundled in the release [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107211 [20:48:35] Joeytje50: let me see :) [20:48:53] (03CR) 10Cscott: [C: 032] Use runs emitted by icu-bidi to implement Unicode bidi algorithm. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107190 (owner: 10Cscott) [20:49:02] (03CR) 10Cscott: [C: 032] Bidi improvements: turn off script-specific OpenFont features for LTR embeds. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107191 (owner: 10Cscott) [20:49:28] (03CR) 10MarkAHershberger: [C: 032] "self merge for release" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107211 (owner: 10MarkAHershberger) [20:49:34] (03Merged) 10jenkins-bot: Move MySQL-specific fakeMaster/fakeSlave stuff to DatabaseMysqlBase [core] - 10https://gerrit.wikimedia.org/r/107200 (owner: 10Anomie) [20:49:53] Hie, I am newbie and beginning my jouney in Wikimedia. I installed the wikimedia-vagrant and followed the instructions given on this link: http://www.mediawiki.org/wiki/MediaWiki-Vagrant. The setup runs correctly, but I cannot find any page when i connect to 127.0.0.1:8080. Also, inside the vagrant, I couldn't locate the wikimedia folder at the specified path. Am i missing something? pls help. [20:50:16] (03Merged) 10jenkins-bot: Use runs emitted by icu-bidi to implement Unicode bidi algorithm. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107190 (owner: 10Cscott) [20:50:18] (03Merged) 10jenkins-bot: Bidi improvements: turn off script-specific OpenFont features for LTR embeds. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107191 (owner: 10Cscott) [20:51:12] Adi__: are you running the browser inside of your virtual machine? [20:51:40] not actually, how to do that. [20:51:49] I use the command vagrant up in terminal [20:52:03] it runs everything. sorry I am not familiar with vagrant functionality [20:52:20] then i use vagrant ssh and in my OS i connect to the browser [20:52:22] * saper neither :( [20:52:23] Joeytje50: hmm, that actully looks not very pleasant to do :/ [20:52:42] MatmaRex: should I just use a static variable in the class then? [20:52:43] (03PS3) 10Dan-nl: image url not evaluated [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/107038 [20:52:47] Joeytje50: the Cite extension does that (i think i mentioned it you you already sometime) [20:53:00] (03CR) 10jenkins-bot: [V: 04-1] Include short descriptions for extensions bundled in the release [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107211 (owner: 10MarkAHershberger) [20:53:05] yeah, that cite extension seems to be some kind of Mother Of All Extensions :P [20:53:09] Joeytje50: you can look at Cite_body.php and search it for "extCite" [20:53:36] Joeytje50: i don't think you should. as i mentioned, page parses can happen in various circumstances [20:53:55] for a very simple one, when a registered user saves an edit, the page is usually parsed twice [20:54:04] Adi__: sorry, not using vagrant [20:54:13] once for the user (with his user preferences), and once for anonymous users to be saved in the cache (with default preferences) [20:54:35] (or at least, that's my understanding, i might very well be wrong) [20:55:16] saper: Then how to you proceed with the development, whats the alternative/ [20:56:37] MatmaRex: from what it seems like to me, the way Cite does it is just doing $parser->extCite = something, and then checking that [20:56:43] Adi__: I am just checking out mediawiki via SSH (https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker manual installation) on my server [20:58:52] saper: Thank you saper, I have the software requirement already installed, but I wish to work with the vagrant. [20:58:54] Joeytje50: yeah, at a glance that's it [20:59:00] (03CR) 10BryanDavis: "One little nit to pick at." (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/107038 (owner: 10Dan-nl) [20:59:17] Joeytje50: but note the functions clearState and cloneState, which to me seem like some deep magic [20:59:39] Cite seems quite badly inline-documented [20:59:40] (as in, i really do not want to understand why on earth is that stuff needed) [20:59:48] Hie, I am newbie and beginning my jouney in Wikimedia. I installed the wikimedia-vagrant and followed the instructions given on this link: http://www.mediawiki.org/wiki/MediaWiki-Vagrant. The setup runs correctly, but I cannot find any page when i connect to 127.0.0.1:8080. Also, inside the vagrant, I couldn't locate the wikimedia folder at the specified path. Am i missing something? pls help. [21:00:38] (03PS4) 10Dan-nl: image url not evaluated [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/107038 [21:00:41] You're confusing terms! ;) [21:01:11] (03CR) 10Dan-nl: "* addressing bryan’s inline comment in ps3." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/107038 (owner: 10Dan-nl) [21:01:19] Adi__: please, don't just repeat the question [21:02:04] saper: Please tell me how I am supposed you ask, I guess there must be others who use vagrant, isn't it so? [21:03:16] Adi__: repeating the question on and on will not help [21:03:58] saper: Sorry, I'll take care of spamming, but please suggest an alternative. tnx. :) [21:04:26] !wikipmediawiki [21:04:26] Confused about the differences between MediaWiki, Wikimedia, Wikipedia and wiki? See https://www.mediawiki.org/wiki/Wikipmediawiki [21:04:39] Adi__: recommended reading ^ :) [21:04:48] (sorry, i know nothing about vagrant myself) [21:05:40] Adi__: It sounds like Vagrant didn't properly configure your virtual machine. There are quite a few things that could possibly have gone wrong. Check your vagrant/logs/puppet directory for clues about where things may have broken. [21:05:53] MatmaRex: All right. [21:06:04] bd808: Sure, i'll do so. :) [21:08:40] One issue that has been reported recently is that the virtualbox kernel extensions in the default image that is downloaded don't work correctly with the latest virtualbox versions. Let me see if I can find the bug report that has a work around. [21:09:30] (03CR) 10BryanDavis: [C: 031] "It would be nice to see the commit message updated to reflect the change to add proxy support." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/107038 (owner: 10Dan-nl) [21:12:48] bd808: Please take a look at this: http://fpaste.org/68088/38964742/ [21:13:07] Adi__: Looking now. [21:14:37] (03PS5) 10Dan-nl: image url not evaluated [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/107038 [21:15:13] i want to setup one of our labs instances with a permenantly lagged slave(via pt-slave-delay). Before i start doing this all by hand is there anything already setup for doing this in labs? [21:15:19] (03CR) 10Dan-nl: "* addressed bryan’s comment in ps4." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/107038 (owner: 10Dan-nl) [21:16:20] thanks for your help bd808 and hashar [21:17:30] (03CR) 10MarkAHershberger: "REL1_22 here: https://gerrit.wikimedia.org/r/#/c/106953/" [core] - 10https://gerrit.wikimedia.org/r/106489 (owner: 10PleaseStand) [21:18:12] Adi__: There are a lot of failures in that log output that look to me like the initial `apt-get update` failed to work as expected. I would try running `vargrant provision` again first. If that doesn't fix things for you check out https://bugzilla.wikimedia.org/show_bug.cgi?id=59712 for the manual steps that Gilles went through when he had problems last week. [21:18:47] us [21:18:50] bd808: All right sure, thankx Bryan, let me go through it. [21:19:00] MatmaRex: thanks for the help, this seems to work really well [21:19:08] I now use $parser->tabsData = array(...); [21:19:16] and then just refer to that [21:19:36] bd808, Adi__: i think i know what the problem is [21:19:44] the upstream git ppa [21:19:46] Joeytje50: yay [21:19:51] * ori investigates [21:20:02] ori: please elaborate. [21:20:16] just not going to get into the clearState/cloneState things :P [21:20:24] this works well enough for me [21:20:27] ah, no, it's something else [21:20:29] Mon Jan 13 16:22:16 +0000 2014 /Stage[main]/Apt/Exec[apt-get update] (err): Failed to call refresh: Command exceeded timeout at /tmp/vagrant-puppet-1/modules-0/apt/manifests/init.pp:10 [21:20:50] Joeytje50: hah [21:21:01] ori: Ok let me try the solution which bd808 gave. [21:21:08] Adi__: run 'ssh vagrant' to get a terminal shell, then "sudo apt-get update", wait for it to finish, log out of the VM (run 'logout') and run 'vagrant provision'. [21:21:15] bd808's solution is good regardless [21:21:37] i mean, updating guest additions is something you should do regardless if it fixes this specific issue [21:22:54] ori: I had done that later. [21:24:12] oh bd808 recommended rerunning vagrant provision [21:24:16] yeah that probably would fix it too [21:24:17] ori: have a look. http://fpaste.org/68098/38964822/ its still executing. [21:24:31] yeah, it'll work now, i bet [21:24:56] ori: I feel the same. :) [21:26:42] ori: Also, i took a precaution this time to close SELinux on my fedora by using "setenforce 0". In my experience, it creates weird problems at times. [21:27:52] (03CR) 10BryanDavis: [C: 031] image url not evaluated [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/107038 (owner: 10Dan-nl) [21:28:11] ah, cool. i know nothing about that but i'll keep that in mind if people using SELinux report strange problems [21:28:32] (03PS1) 10Ori.livneh: Increase default timeout of Exec resources to 900 seconds [vagrant] - 10https://gerrit.wikimedia.org/r/107214 [21:28:35] ^ bd808 [21:28:52] ugh, trailing whitespace [21:29:11] (03PS2) 10Ori.livneh: Increase default timeout of Exec resources to 900 seconds [vagrant] - 10https://gerrit.wikimedia.org/r/107214 [21:32:22] (03PS1) 10Ori.livneh: Tweak 'unless' condition for 'add hhvm apt key' Exec [vagrant] - 10https://gerrit.wikimedia.org/r/107216 [21:32:24] (03CR) 10BryanDavis: [C: 032] Increase default timeout of Exec resources to 900 seconds [vagrant] - 10https://gerrit.wikimedia.org/r/107214 (owner: 10Ori.livneh) [21:32:26] (03Merged) 10jenkins-bot: Increase default timeout of Exec resources to 900 seconds [vagrant] - 10https://gerrit.wikimedia.org/r/107214 (owner: 10Ori.livneh) [21:33:43] thanks [21:35:05] (03CR) 10Gergő Tisza: "We don't have a test Flickr API key for UploadWizard right now (using the same key that's used in production for Commons seems unwise). Th" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [21:35:32] tgr: ping [21:35:48] (03PS1) 10Hashar: mediawiki-core-regression-REL1_22 to dashboard [integration/docroot] - 10https://gerrit.wikimedia.org/r/107247 [21:35:56] (03CR) 10Hashar: [C: 032] mediawiki-core-regression-REL1_22 to dashboard [integration/docroot] - 10https://gerrit.wikimedia.org/r/107247 (owner: 10Hashar) [21:35:59] (03Merged) 10jenkins-bot: mediawiki-core-regression-REL1_22 to dashboard [integration/docroot] - 10https://gerrit.wikimedia.org/r/107247 (owner: 10Hashar) [21:36:40] hoo: i'm listening [21:37:09] tgr: Did you open the bug about privacy issues with the flickr feature? Couldn't find it... [21:38:03] hoo: there is a privacy warning when you enter the flickr url [21:38:12] ah, that's fine :) [21:38:13] has been from the beginning, I just never noticed it [21:38:31] Couldn't test it, as I'm not +sysop on commons [21:38:33] :) [21:43:52] ori: Please have a look. http://fpaste.org/68103/49373138/ Most of the things worked correctly but phpsh failed. [21:45:28] Adi__: you're probably on a slow connection, causing some parts of the provisioning process that depend on the network to fail [21:45:38] Adi__: the root cause is: 'Cannot fetch index base URL http://pypi.python.org/simple/' [21:45:58] * bd808 was about to type basically the same things [21:45:58] but that is the canonical URL of pypi's index, and it works, and it lists 1.3.3. [21:46:03] hoo: you can type $('#mwe-upwiz-upload-ctrl-flickr-container').show() into the JS console and then test [21:46:10] but you did not hear it from me :) [21:46:22] (03PS2) 10Michał Łazowik: Allow to upload WAV files with 32 bit float uncmopressed audio [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/103402 [21:46:25] hoo: you heard it from me! [21:46:28] j/k [21:46:56] :D [21:46:57] ori: I am behind a proxy network, when i used vagrant up, i setup the proxy variables after installing the plugin vagrant-proxyconf. I tested it by doing curl from the vagrant. [21:47:22] Adi__: try 'vagrant provision' again? [21:47:29] all right. [21:56:13] (03CR) 10BryanDavis: Tweak 'unless' condition for 'add hhvm apt key' Exec (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/107216 (owner: 10Ori.livneh) [21:56:45] (03CR) 10Ori.livneh: Tweak 'unless' condition for 'add hhvm apt key' Exec (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/107216 (owner: 10Ori.livneh) [21:57:23] (03PS2) 10Ori.livneh: Tweak 'unless' condition for 'add hhvm apt key' Exec [vagrant] - 10https://gerrit.wikimedia.org/r/107216 [21:58:28] (03CR) 10Isarra: "Only changing the background colour of the spaces won't work, though - there are quite a few characters that display as what we would call" [core] - 10https://gerrit.wikimedia.org/r/106763 (owner: 10Jackmcbarn) [22:00:17] (03PS3) 10BryanDavis: Tweak 'unless' condition for 'add hhvm apt key' Exec [vagrant] - 10https://gerrit.wikimedia.org/r/107216 (owner: 10Ori.livneh) [22:00:24] (03CR) 10BryanDavis: [C: 032] Tweak 'unless' condition for 'add hhvm apt key' Exec [vagrant] - 10https://gerrit.wikimedia.org/r/107216 (owner: 10Ori.livneh) [22:00:27] (03Merged) 10jenkins-bot: Tweak 'unless' condition for 'add hhvm apt key' Exec [vagrant] - 10https://gerrit.wikimedia.org/r/107216 (owner: 10Ori.livneh) [22:10:06] ori: Same error. :( I tried a few things. I configured https and ftp proxy as well in vagrant and tested via curl. I configured http,https and ftp proxy for my system OS too. I feel like proxy settings is the trick here. Is there any other place where I should add it? Because my network bandwidth is over 50Mbps. :( [22:11:14] (03PS2) 10Jackmcbarn: Add protectionLevels variable to mw.title output [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107046 [22:12:58] Adi__: Did you say earlier that you had installed vagrant-proxyconf locally? If so you can add create a Vagrantfile-extra.rb file to configure it as shown at https://github.com/tmatilai/vagrant-proxyconf [22:13:41] (03CR) 10Jackmcbarn: "Please don't merge this until https://gerrit.wikimedia.org/r/#/c/107199/ is merged." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107046 (owner: 10Jackmcbarn) [22:14:12] bd808: Yes i did install it, and i configured it according to: https://github.com/tmatilai/vagrant-proxyconf . I believe it is working because i can curl after login in the vagrant image. [22:14:45] bd808: Also, my apt-get update worked.! [22:16:12] So it's pip that is failing for you now? [22:17:39] yes, Cannot fetch index base URL http://pypi.python.org/simple/ [22:18:36] also, I got a folder named mediawiki now, I see the banner when loggin in which wasnt visible earlier, but there are no files located in the folder, I believe their download failed too. [22:19:45] Hmmm. That sounds like both git and pip (python) aren't picking up your proxy configuration. [22:20:19] yes, I am not able to figure out how to debug this. Let me try a manual git clone from inside my VM. [22:20:29] I theory pip/python respect the http_proxy and https_proxy environment variables [22:23:00] bd808: git clone worked from inside the vm [22:23:17] somehow, vagrant provision doesn't pick my proxy. [22:24:30] hashar: it would be nice if you could take another look at https://gerrit.wikimedia.org/r/98853 ;) [22:24:45] ahh [22:25:45] hoo: you would have to ping me about it again this week :) [22:25:55] hoo: I am afraid I am going to forget about that change again [22:26:17] hashar: Will try to remember [22:26:20] Adi__: Sounds like you are getting closer to a working setup. Sorry that your use case is so untested. [22:27:06] haha.... lets see if we can pull this off. [22:35:50] (03CR) 10Nemo bis: "Hello Tyler, thank you for working on this! It's hugely needed and I'm confident Niklas or others will be able to review a patch, but not " [core] - 10https://gerrit.wikimedia.org/r/72867 (owner: 10Parent5446) [22:47:25] bd808, ori: I tried out few more things. I manually tried to run "/usr/bin/pip install -q phpsh==1.3.3" from inside the VM. It gave me the same error that cannot index file, though my curl and wget work. Then I manually added my proxy settings to the /etc/bash.bashrc file and tried to run the installation from within the VM again. The error persists. Now I am seriously out of clue. [22:48:04] Adi__: can you try running: sudo pip instal https://pypi.python.org/packages/source/p/phpsh/phpsh-1.3.3.tar.gz#md5=6fa296c3c51b3179665e9b6fe8d87b2c [22:50:52] ori: Still not able to connect, url timed out. Dont know how i get response using "curl www.google.com" :( [22:51:04] could be https [22:51:15] what if you try the same command, but change 'https' to 'http'? [22:52:15] ^ Adi__ [22:52:22] curl http://www.google.com, https://... both work.... pip install http https both same errorr. [22:52:46] URLError: [22:52:53] blah. Okay, try curl https://pypi.python.org/packages/source/p/phpsh/phpsh-1.3.3.tar.gz#md5=6fa296c3c51b3179665e9b6fe8d87b2c -o phpsh/phpsh-1.3.3.tar.gz [22:53:03] er, rather: [22:53:07] blah. Okay, try curl https://pypi.python.org/packages/source/p/phpsh/phpsh-1.3.3.tar.gz#md5=6fa296c3c51b3179665e9b6fe8d87b2c -o phpsh-1.3.3.tar.gz [22:53:14] this will download it to your disk [22:53:22] then 'sudo pip install phpsh-1.3.3.tar.gz' [22:57:11] ori: oops got DC. [22:57:40] (03PS1) 10Cscott: Improve error-handling by avoiding use of the promise .done() method. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/107257 [22:57:50] Adi___: curl https://pypi.python.org/packages/source/p/phpsh/phpsh-1.3.3.tar.gz -o phpsh-1.3.3.tar.gz && sudo pip install phpsh-1.3.3.tar.gz [22:59:41] ori: hack succesful [22:59:50] :) [23:02:49] (03PS1) 10Cscott: Ensure that image output stream errors are handled. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/107258 [23:03:23] ori: "VAGRANT_HTTP_PROXY="http://proxy.example.com:8080" vagrant provision", read some stuff and trying this now, whats your bet on this one? :) [23:03:25] (03PS1) 10MarkAHershberger: Make MagicWordArray compatible with PCRE 8.34+ [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107259 [23:05:03] (03CR) 10MarkAHershberger: [C: 032] Make MagicWordArray compatible with PCRE 8.34+ [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107259 (owner: 10MarkAHershberger) [23:08:13] (03Merged) 10jenkins-bot: Make MagicWordArray compatible with PCRE 8.34+ [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107259 (owner: 10MarkAHershberger) [23:09:31] marktraceur, hey. got some real life stuff to do first and then i'll relicense it [23:09:39] Glad to get this going finally! :) [23:09:55] (03PS1) 10MarkAHershberger: Couple of updates for RELEASE-NOTES [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107260 [23:10:10] Sweet, thanks [23:10:25] theopolisme: I still want to final-code-review once it's licensed properly, but I'm optimistic [23:10:34] Of course [23:11:25] (03CR) 10MarkAHershberger: [C: 032] Couple of updates for RELEASE-NOTES [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107260 (owner: 10MarkAHershberger) [23:14:34] (03Merged) 10jenkins-bot: Couple of updates for RELEASE-NOTES [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107260 (owner: 10MarkAHershberger) [23:16:30] (03PS2) 10MarkAHershberger: Include short descriptions for extensions bundled in the release [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107211 [23:17:29] (03CR) 10MarkAHershberger: [C: 032] Include short descriptions for extensions bundled in the release [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107211 (owner: 10MarkAHershberger) [23:18:27] (03CR) 10MarkAHershberger: [C: 032] Add function to clear mPreparedEdit, to use in cases of mutable content [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107201 (owner: 10MarkAHershberger) [23:18:44] (03CR) 10Aaron Schulz: [C: 032] Fixed fatal error when getLocalCopy() fails [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107040 (owner: 10MarkAHershberger) [23:20:32] (03Merged) 10jenkins-bot: Include short descriptions for extensions bundled in the release [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107211 (owner: 10MarkAHershberger) [23:21:18] (03CR) 10jenkins-bot: [V: 04-1] Add function to clear mPreparedEdit, to use in cases of mutable content [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107201 (owner: 10MarkAHershberger) [23:24:38] (03Merged) 10jenkins-bot: Fixed fatal error when getLocalCopy() fails [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107040 (owner: 10MarkAHershberger) [23:34:22] ori, bd808: thank you for all the help. :) my wiki instance is running at least which wouldn't be possible without you. I am still trying to figure out whats wrong with proxy settings and PIP. If i get to something, I'll let you guys know. Thanks again. :) [23:34:59] Adi___: You're welcome. Thanks for being patient and working through the problems. [23:36:43] ori, bd808: Thats kind of you. And also appologies if you guys found anything inappropiate, I am new to opensource community so I am always not so sure. Have a good day. :) [23:39:17] (03CR) 10MarkTraceur: [C: 032] "Quoth James_F: "Lol just merge it"" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100519 (owner: 10Legoktm) [23:39:28] marktraceur: "Lol"?! [23:39:38] (03Merged) 10jenkins-bot: Load popup script in same place as personal url [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100519 (owner: 10Legoktm) [23:39:38] lol [23:40:03] (03PS2) 10MarkAHershberger: Add function to clear mPreparedEdit, to use in cases of mutable content [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107201 [23:40:15] James_F: Yes lol [23:40:24] (03CR) 10MarkAHershberger: [C: 032] Add function to clear mPreparedEdit, to use in cases of mutable content [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107201 (owner: 10MarkAHershberger) [23:40:41] Krenair: We should have an Architecture Summit Bingo card, and "Getting James_F to say 'lol' out loud" should be one of the squares [23:42:38] marktraceur: :-P [23:42:47] Krenair: Also, no. :-) [23:43:05] James_F: No? [23:43:28] James_F: https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=95260&oldid=95258 [23:43:29] marktraceur: Seen legoktm's comment on https://gerrit.wikimedia.org/r/#/c/102383/ re. testing? [23:43:38] Krenair: No I won't say "lol" out loud. :-) [23:43:44] marktraceur: Ta. Coffee it is. [23:43:57] Well that was marktraceur's idea, but okay. [23:44:00] (03Merged) 10jenkins-bot: Add function to clear mPreparedEdit, to use in cases of mutable content [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107201 (owner: 10MarkAHershberger) [23:44:49] (03CR) 10MarkTraceur: "You should be able to do something like create a feature that depends on a skin that doesn't exist, or delete all of the skins from the re" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/102383 (owner: 10Legoktm) [23:47:38] (03PS1) 10MarkAHershberger: Avoid extra parsing in prepareContentForEdit() [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107266 [23:48:28] (03CR) 10MarkAHershberger: [C: 032] Avoid extra parsing in prepareContentForEdit() [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107266 (owner: 10MarkAHershberger) [23:51:35] (03Merged) 10jenkins-bot: Avoid extra parsing in prepareContentForEdit() [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107266 (owner: 10MarkAHershberger) [23:54:41] (03PS4) 10Gergő Tisza: A way to blacklist flickr users. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [23:54:43] (03PS1) 10Gergő Tisza: Refactor Flickr API calls [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107267 [23:56:55] (03CR) 10Gergő Tisza: "Rebasing made this change a lot bigger since UW now handles about a dozen URL types, so I split the refactoring part into a parent commit." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [23:58:23] (03CR) 10Alex Monk: [C: 04-1] "Seems like a good idea, shouldn't be based on the blacklisting stuff though." (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/107267 (owner: 10Gergő Tisza)