[00:26:35] (03CR) 10MarkAHershberger: [C: 032] WebInstaller: Don't call getSoftwareLink() [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/106953 (owner: 10MarkAHershberger) [00:29:39] (03Merged) 10jenkins-bot: WebInstaller: Don't call getSoftwareLink() [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/106953 (owner: 10MarkAHershberger) [00:51:56] (03CR) 10Parent5446: Maintenance script to migrate legacy Oversight data (031 comment) [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 (owner: 10Alex Monk) [00:56:03] (03PS16) 10Alex Monk: Maintenance script to migrate legacy Oversight data [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 [01:12:41] (03CR) 10Parent5446: [C: 04-1] Maintenance script to migrate legacy Oversight data (032 comments) [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 (owner: 10Alex Monk) [01:19:10] (03PS1) 10Jackmcbarn: Allow all users to view Special:UserRights [core] - 10https://gerrit.wikimedia.org/r/107009 [01:40:32] (03CR) 10Peachey88: Allow all users to view Special:UserRights (032 comments) [core] - 10https://gerrit.wikimedia.org/r/107009 (owner: 10Jackmcbarn) [01:43:38] (03CR) 10Jackmcbarn: "re Peachey88: Those messages don't seem necessary to me. Seeing the interface read-only conveys the same information that they used to." [core] - 10https://gerrit.wikimedia.org/r/107009 (owner: 10Jackmcbarn) [02:22:45] (03PS17) 10Alex Monk: Maintenance script to migrate legacy Oversight data [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 [02:24:57] (03PS18) 10Alex Monk: Maintenance script to migrate legacy Oversight data [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 [02:44:12] (03PS10) 10Ori.livneh: SpecialWatchlist: Synchronise some code with newer versions from RC [core] - 10https://gerrit.wikimedia.org/r/94628 (owner: 10Bartosz Dziewoński) [02:46:17] (03CR) 10Ori.livneh: [C: 032] SpecialWatchlist: Synchronise some code with newer versions from RC [core] - 10https://gerrit.wikimedia.org/r/94628 (owner: 10Bartosz Dziewoński) [02:47:23] (03PS11) 10Ori.livneh: SpecialWatchlist: JS enhancements to namespace selector (like RC) [core] - 10https://gerrit.wikimedia.org/r/94617 (owner: 10Bartosz Dziewoński) [02:50:04] (03Merged) 10jenkins-bot: SpecialWatchlist: Synchronise some code with newer versions from RC [core] - 10https://gerrit.wikimedia.org/r/94628 (owner: 10Bartosz Dziewoński) [02:53:12] (03CR) 10Ori.livneh: [C: 032] SpecialWatchlist: JS enhancements to namespace selector (like RC) [core] - 10https://gerrit.wikimedia.org/r/94617 (owner: 10Bartosz Dziewoński) [02:54:34] (03CR) 10MarkAHershberger: [C: 032] DatabaseInstaller::setVarsFromRequest needs array [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/105985 (owner: 10Siebrand) [02:56:11] (03Merged) 10jenkins-bot: SpecialWatchlist: JS enhancements to namespace selector (like RC) [core] - 10https://gerrit.wikimedia.org/r/94617 (owner: 10Bartosz Dziewoński) [02:58:36] (03Merged) 10jenkins-bot: DatabaseInstaller::setVarsFromRequest needs array [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/105985 (owner: 10Siebrand) [03:07:30] (03CR) 10MarkAHershberger: [C: 032] Generate Utf8Case.ser directly from UnicodeData.txt [core] - 10https://gerrit.wikimedia.org/r/76882 (owner: 10PleaseStand) [03:10:52] (03Merged) 10jenkins-bot: Generate Utf8Case.ser directly from UnicodeData.txt [core] - 10https://gerrit.wikimedia.org/r/76882 (owner: 10PleaseStand) [03:11:36] (03PS1) 10Jack Phoenix: Set the correct special page headers so that "What links here" and "Page info" won't show up on the toolbox when you're viewing these special pages. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/107011 [03:16:46] (03CR) 10Jack Phoenix: [C: 032 V: 032] Set the correct special page headers so that "What links here" and "Page info" won't show up on the toolbox when you're viewing these specia [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/107011 (owner: 10Jack Phoenix) [03:29:22] (03PS2) 10Legoktm: Add new messages indicator from a hook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/95102 [03:31:11] (03CR) 10Legoktm: "Addressed comments, and now using the new version of the hook." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/95102 (owner: 10Legoktm) [03:31:47] (03CR) 10MarkAHershberger: [C: 04-1] "When I tested this, it still showed the problem in the DB portion of the installer. I don't think this is what you intended and it certai" [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [03:31:49] (03PS3) 10Legoktm: Add new messages indicator from a hook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/95102 [03:33:40] (03CR) 10Legoktm: [C: 032] Call Linker::link statically (1.18) [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/106752 (owner: 10Siebrand) [03:33:42] (03Merged) 10jenkins-bot: Call Linker::link statically (1.18) [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/106752 (owner: 10Siebrand) [03:35:05] (03CR) 10Legoktm: [C: 032 V: 032] Call Linker::link statically (1.18) [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/106743 (owner: 10Siebrand) [03:37:13] (03CR) 10Legoktm: [C: 031] Call Linker statically (1.19) (031 comment) [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/106739 (owner: 10Siebrand) [03:38:22] (03CR) 10Jack Phoenix: "Right; apologies for the delay in reviewing this. (Please feel free to poke me on IRC if there's something you need reviewed)" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/100767 (owner: 10UltrasonicNXT) [03:45:22] (03CR) 10Legoktm: "@Anomie: Since that commit is already pretty large I didn't want to include anything else it that wasn't directly related to RL stuff." [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/101626 (owner: 10Legoktm) [03:46:09] (03PS1) 10MarkAHershberger: make release notes ordering more consistant [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107012 [03:47:16] (03CR) 10MarkAHershberger: [C: 032] "non-functional self-merge." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107012 (owner: 10MarkAHershberger) [03:49:01] (03PS14) 10MarkAHershberger: Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/89340 [03:52:17] (03CR) 10jenkins-bot: [V: 04-1] make release notes ordering more consistant [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107012 (owner: 10MarkAHershberger) [04:07:09] (03PS15) 10MarkAHershberger: Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/89340 [04:09:27] (03CR) 10MarkAHershberger: Include short descriptions for extensions bundled in the release (033 comments) [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [04:14:25] (03PS11) 10Legoktm: Load scripts and styles via ResourceLoader [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 [04:15:02] (03PS19) 10AndyRussG: Let instructors and other roles add students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 [04:15:06] (03CR) 10Legoktm: Load scripts and styles via ResourceLoader (033 comments) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 (owner: 10Legoktm) [04:15:50] (03CR) 10AndyRussG: "Rebasin'..." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [04:17:54] (03CR) 10Legoktm: "@Anomie: I've added a check to verify $wgGlobalCssJsConfig has been configured before registering the modules with RL." (033 comments) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 (owner: 10Legoktm) [04:18:43] (03PS16) 10MarkAHershberger: Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/89340 [04:50:25] (03CR) 1001tonythomas: "@Mark: Actually, I meant to check whether the username and entered password of the Wiki Administrator account is given same. Of course, it" [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [04:51:05] (03CR) 10TTO: "> Parser tests should be slightly expanded to have decent coverage of "verbatim"" [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [05:00:49] Reedy: Hi, as told in https://bugzilla.wikimedia.org/show_bug.cgi?id=59881#c1 , I should check for the return type of self::urlFunction to be string , when $title == NULL ? [05:06:06] hello [05:09:24] (03CR) 10MZMcBride: "Yeah, just one additional test should be fine. You could flip the current tests and make most of them use "verbatim" and have just one use" [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [05:21:29] (03CR) 10Parent5446: "I have a suggestion:" [core] - 10https://gerrit.wikimedia.org/r/106944 (owner: 10PleaseStand) [05:23:39] (03CR) 10Parent5446: [C: 04-1] Rename RedirectSpecialPage subclasses (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106888 (owner: 10Bartosz Dziewoński) [05:27:38] (03PS2) 1001tonythomas: Result shown if username and password are same on same page of installer [core] - 10https://gerrit.wikimedia.org/r/105428 [05:42:09] (03PS1) 10Hydriz: Fix link to article history not working properly when not using short URLs [extensions/LastModified] - 10https://gerrit.wikimedia.org/r/107013 [05:45:14] (03PS20) 10AndyRussG: Let instructors and other roles add students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 [06:01:58] (03CR) 10AndyRussG: "Thanks!! Treeish URLs added in headers... that's basically what you meant?" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [06:04:52] (03PS4) 10TTO: Merge Poem extension into core [core] - 10https://gerrit.wikimedia.org/r/106861 [06:05:39] (03CR) 10AndyRussG: Let instructors and other roles add students (035 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [06:06:54] (03CR) 10TTO: "I swapped the parser tests to and added one for . I also tossed out a disabled test which came from the Poem extension, b" [core] - 10https://gerrit.wikimedia.org/r/106861 (owner: 10TTO) [06:10:57] (03PS1) 10Legoktm: API: Don't check for 'globalunblock' right [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/107015 [06:42:23] (03CR) 10Adamw: [C: 032] "Thanks, and sorry to be a PITA about the contributed libraries." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [06:42:31] (03Merged) 10jenkins-bot: Let instructors and other roles add students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [06:42:40] (03CR) 10Adamw: Let instructors and other roles add students (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [06:43:43] (03PS4) 10AalekhN: SpecialWhatlinkshere.php : made Special:Whatlinkshere transclude [core] - 10https://gerrit.wikimedia.org/r/106625 [07:00:51] (03PS1) 10Legoktm: Use $this->msg instead of wfMessage [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/107016 [07:20:39] (03PS1) 1001tonythomas: Chagned return value of self::urlFunction from array to string [core] - 10https://gerrit.wikimedia.org/r/107017 [07:35:26] (03PS1) 10Legoktm: Validate $this->mAddress before storing it [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/107018 [07:58:15] (03PS2) 10MZMcBride: Chagned return value of self::urlFunction from array to string [core] - 10https://gerrit.wikimedia.org/r/107017 (owner: 1001tonythomas) [08:03:01] (03PS5) 10MZMcBride: SpecialWhatlinkshere.php : made Special:Whatlinkshere transclude [core] - 10https://gerrit.wikimedia.org/r/106625 (owner: 10AalekhN) [09:34:37] (03PS1) 1001tonythomas: Used [[MediaWiki:Parentheses]] instead of hardcoded parentheses [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/107020 [09:36:27] (03CR) 10Peachey88: [C: 04-1] Used [[MediaWiki:Parentheses]] instead of hardcoded parentheses (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/107020 (owner: 1001tonythomas) [09:40:13] (03PS2) 1001tonythomas: Used [[MediaWiki:Parentheses]] instead of hardcoded parentheses [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/107020 [09:45:07] (03CR) 10Fomafix: "See comment." (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/107020 (owner: 1001tonythomas) [09:46:21] (03CR) 1001tonythomas: "I think,by giving return 'false' , I can change the return value back to string ?" [core] - 10https://gerrit.wikimedia.org/r/107017 (owner: 1001tonythomas) [10:14:03] (03PS3) 1001tonythomas: Used [[MediaWiki:Parentheses]] instead of hardcoded parentheses [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/107020 [11:28:59] (03CR) 10Parent5446: [C: 04-1] "The 'found' => false actually does something. It is returned to the parser and tells the parser to try and use different methods to parse " [core] - 10https://gerrit.wikimedia.org/r/107017 (owner: 1001tonythomas) [12:10:02] (03PS1) 10UltrasonicNXT: Hide the join link in sidebar if user is in chat [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/107024 [12:12:36] (03PS2) 10UltrasonicNXT: Hide the join link in sidebar if user is in chat [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/107024 [12:13:03] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Hide the join link in sidebar if user is in chat [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/107024 (owner: 10UltrasonicNXT) [12:23:13] (03PS6) 10Umherirrender: Add $wgHideUserContribLimit config setting [core] - 10https://gerrit.wikimedia.org/r/98267 [12:24:04] (03CR) 10Umherirrender: "Patch Set 6: Rebased and resolved conflict" [core] - 10https://gerrit.wikimedia.org/r/98267 (owner: 10Umherirrender) [12:27:45] (03CR) 10UltrasonicNXT: "Ok, no prob. I'll have a think about the UI sometime (although for me, the tooltop doesn't disappear until you move the mouse :P )." [extensions/Comments] - 10https://gerrit.wikimedia.org/r/100767 (owner: 10UltrasonicNXT) [12:36:56] (03PS9) 10Bartosz Dziewoński: Always load 'mediawiki.special.changeslist' on SpecialRecentChanges and subclasses [core] - 10https://gerrit.wikimedia.org/r/97451 [12:38:35] (03CR) 10jenkins-bot: [V: 04-1] Always load 'mediawiki.special.changeslist' on SpecialRecentChanges and subclasses [core] - 10https://gerrit.wikimedia.org/r/97451 (owner: 10Bartosz Dziewoński) [12:38:49] * MatmaRex slaps jenkins-bot around a bit with a large trout [12:43:06] (03CR) 10MarkAHershberger: "I realize what you meant to check. When I tested it, though, I didn't see the check happening where you expected it." [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [12:44:39] (03PS1) 10Umherirrender: rebuildrecentchanges.php leaves some rc_source empty [core] - 10https://gerrit.wikimedia.org/r/107025 [12:46:00] (03PS10) 10Bartosz Dziewoński: Create ChangesListSpecialPage as a base class for Watchlist and RC [core] - 10https://gerrit.wikimedia.org/r/102458 [12:46:02] (03PS7) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement execute() [core] - 10https://gerrit.wikimedia.org/r/103240 [12:46:04] (03PS7) 10Bartosz Dziewoński: Changes list legend modules cleanup [core] - 10https://gerrit.wikimedia.org/r/103197 [12:46:06] (03PS4) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement two new hooks superseding 4 old ones [core] - 10https://gerrit.wikimedia.org/r/106279 [12:46:08] (03PS5) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement webOutput() [core] - 10https://gerrit.wikimedia.org/r/105195 [12:46:10] (03PS4) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement doMainQuery() [core] - 10https://gerrit.wikimedia.org/r/105194 [12:46:12] (03PS6) 10Bartosz Dziewoński: Change behavior of Special:Watchlist when user's watchlist is empty [core] - 10https://gerrit.wikimedia.org/r/103233 [12:46:14] (03PS6) 10Bartosz Dziewoński: ChangesListSpecialPage and subclasses: Reorder functions [core] - 10https://gerrit.wikimedia.org/r/103200 [12:46:16] (03PS6) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/103546 [12:46:18] (03PS6) 10Bartosz Dziewoński: No longer display the number of rows shown on Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/103239 [12:46:20] (03PS10) 10Bartosz Dziewoński: SpecialWatchlist: Split #execute into subfunctions like SpecialRecentChanges [core] - 10https://gerrit.wikimedia.org/r/94677 [12:46:22] (03PS10) 10Bartosz Dziewoński: Always load 'mediawiki.special.changeslist' on appropriate pages [core] - 10https://gerrit.wikimedia.org/r/97451 [12:46:24] (03PS5) 10Bartosz Dziewoński: ChangesListSpecialPage: Stop mutating $opts in buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/105196 [12:46:45] hooray for large rebases [13:06:09] (03CR) 10jenkins-bot: [V: 04-1] ChangesListSpecialPage: Implement buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/103546 (owner: 10Bartosz Dziewoński) [13:09:18] who are working search again ? [13:09:36] en.wp reports that the index hasn't updated for a couple of days. [13:09:45] manybubbles [13:09:50] @seen manybubbles [13:09:50] MatmaRex: Last time I saw manybubbles they were changing the nickname to manybubbles|away, but manybubbles|away is no longer in channel because he quitted the network 02:03:05.8984840 ago. The nick change was done in #wikimedia-qa at 1/11/2014 6:12:05 PM (18h57m44s ago) [13:10:03] and chad [13:10:05] @seen ^d [13:10:06] MatmaRex: Last time I saw ^d they were changing the nickname to ^demon|away, but ^demon|away is no longer in channel because he quitted the network 1.13:06:27.9340780 ago. The nick change was done in #wikidata at 1/10/2014 8:56:06 PM (1d16h13m59s ago) [13:10:19] wondering if it is because we are building the new index or because it's down. [13:10:22] (03CR) 10Bartosz Dziewoński: "recheck" [core] - 10https://gerrit.wikimedia.org/r/103546 (owner: 10Bartosz Dziewoński) [13:10:41] the new and old search should be independent [13:10:53] unless someone broke something :) [13:11:12] well it might be that the one stresses out the other :D [13:12:32] (03PS3) 1001tonythomas: Result shown if WIki Administrator username and password are same on same page of installer [core] - 10https://gerrit.wikimedia.org/r/105428 [13:12:50] who knows, i have no idea how it's all set up [13:13:27] ok, i have half an hour for a few reviews.. [13:15:21] * MatmaRex has 35 pending patches to core [13:15:23] MatmaRex: what shall we do with that search field patch ? [13:15:40] thedj: it needs rebase, and i need to thing about it [13:15:54] think* [13:16:34] blegh gerrit is slow again [13:16:44] still* [13:17:06] yeah but last 4 days has been worse than usual [13:17:49] i can't even fetch all atm... [13:18:15] same here [13:18:23] someone broke it just before the weekend, eh [13:18:40] and jenkins keeps producing bullshit failures [13:19:04] https://bugzilla.wikimedia.org/show_bug.cgi?id=59930 [13:20:04] apparenltly caused by git fetches timing out [13:20:26] Is the bot in #mediawiki opensource? [13:21:08] yes [13:21:14] you mean wikibugs? [13:21:55] segd: https://git.wikimedia.org/blob/wikimedia%2Fbugzilla%2Fwikibugs/master/wikibugs [13:22:30] (03CR) 10TheDJ: [C: 032] mediawiki.searchSuggest: Blacklist Konqueror < 4.11 [core] - 10https://gerrit.wikimedia.org/r/95871 (owner: 10Bartosz Dziewoński) [13:22:39] Its so hard to find a good announce bots for Recentchanges >_< [13:40:41] MatmaRex: what is the 189 in the echo overlay patch ? [13:40:51] https://gerrit.wikimedia.org/r/#/c/103099/1/modules/overlay/ext.echo.overlay.js [13:41:38] thedj: am i supposed to remember now? :/ [13:41:45] i should have commented, i guess [13:41:54] anyway, the right side doesn't work [13:42:03] i think it's the width of the overlay [13:42:15] ah [13:42:23] yes, it's 200-21/2+1 [13:42:35] it's not absolutely positioned in the window. it's just offset -200 to the left [13:42:37] where 200 is width, 21 is pokey width (as commented), and 1 is just in case [13:43:33] humm, it worked when i tested it afair [13:43:50] i know it has position:relative, but that shouldn't matter [13:51:46] hmm, now how many p-personal elements did i delete to trigger that error.. [13:57:31] How do I hide a li? I've tried wrapping it in a span with style="display: none;" but that get's parsed out. I've tried
  • ? [13:58:40] .hidden is style="display: none;" and it hides the text, but leaves the bullet [13:59:01] that's impossible [13:59:08] can you link example page where this happens? [13:59:49] it happens on http://ddowiki.com/edit/MediaWiki:Userrights-groups-help [14:00:05] I can give you permissions if needed to tinker with it. [14:00:44] Technical_13: display: none hides these just fine (applied via web console) [14:00:54] uhm, there is no
  • there at all [14:01:01] refresh [14:01:06] I was tinkering [14:01:30] *
  • [14:03:04] Yep, MediaWiki will create one and there's on in the html [14:03:10] * one [14:03:18] Huh... I was going of the doc saying to do it that way to change the list style.. [14:03:24] D: [14:03:27] remove that doc [14:03:35] that's stupid [14:03:44] you have to construct the entire HTML list, i'm afraid [14:03:53]
    • …
      • etc.
    [14:03:54] (03PS2) 10TheDJ: Make sure the overlay is visible, even if the badge is near the edge [extensions/Echo] - 10https://gerrit.wikimedia.org/r/103099 (owner: 10Bartosz Dziewoński) [14:05:33] That's not a big problem... let me do that... My other question is about JavaScript. I have a callback for that page too that isn';t working right, and I'm dumbfounded (I still don't grasp callbacks very well yet). SOurce for script is at http://ddowiki.com/page/User:Technical_13/vector.js [14:06:08] (03CR) 10TheDJ: [C: 032] Make sure the overlay is visible, even if the badge is near the edge [extensions/Echo] - 10https://gerrit.wikimedia.org/r/103099 (owner: 10Bartosz Dziewoński) [14:06:15] (03Merged) 10jenkins-bot: Make sure the overlay is visible, even if the badge is near the edge [extensions/Echo] - 10https://gerrit.wikimedia.org/r/103099 (owner: 10Bartosz Dziewoński) [14:07:48] I should probably submit a patch sometime for the li thing. You should be able to define stuff using the shorthand. [14:08:31] your script does not wait for the DOM ready. [14:08:35] (03CR) 10Hoo man: [C: 04-1] Used [[MediaWiki:Parentheses]] instead of hardcoded parentheses (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/107020 (owner: 1001tonythomas) [14:09:10] Something like if the parser detects a li inside of an li line with no
    • and with attributes, apply attributes to shorthand. [14:09:14] Oh.. so... [14:09:53] updateTable(updateInfo); should be something like $(function(){updateTable(updateInfo);}); [14:10:02] (03PS1) 10Tinaj1234: Removed SiteConfiguration::getAll() [core] - 10https://gerrit.wikimedia.org/r/107034 [14:10:46] well yes, but you also already set all your variables that get dom elements straight at the top [14:11:14] so wrap it all in a function and then $(thatfunction) [14:11:19] hoo: on https://gerrit.wikimedia.org/r/#/c/107020/ , I find it difficult to add the space ' '. is there a way other than ' ' . $this->.. ? [14:11:34] It gets all of that stuff fine, it's just the fact that it processes the table manipulation before waiting for the api to return it's results. [14:12:04] Technical_13: well then it gets that stuff per chance, it's not guaranteed [14:12:08] tonythomas01: Not really... there is a word separator message around, if you like... but just following my code comment should work fine [14:12:28] How do I make it wait to process the table if the api results aren't done? [14:12:31] if it's async loaded from the top of the document it would break. [14:12:32] hoo: :) I will upload the new patchset [14:13:21] Technical_13: call the callback only from success: [14:13:57] so add updateInfo() to the end of success? [14:14:57] Technical_13: yes, now you execute callback() straight from the setup process of your request, before it has executed it basically. [14:15:42] http://ddowiki.com/page/User:Technical_13/vector.js [14:15:44] like that? [14:16:28] (03PS4) 1001tonythomas: Used [[MediaWiki:Parentheses]] instead of hardcoded parentheses [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/107020 [14:16:52] (03CR) 10Hoo man: [C: 04-1] "You can't just remove a function which is right now being used within Wikimedia deployed code." [core] - 10https://gerrit.wikimedia.org/r/107034 (owner: 10Tinaj1234) [14:18:13] tonythomas01: ' ' . $ [14:18:15] ... [14:18:19] notice the spaces :P [14:18:32] ' '.$thi... that's not really readable [14:18:36] hoo: hehe :) I noticed , but hesitated [14:18:42] ok [14:18:47] uploading a new on [14:19:39] thedj: Is http://ddowiki.com/page/User:Technical_13/vector.js correct now? If not, can you copy it to a pastebin or jsfiddle and show me what you mean (then I can reuse it forever muh-hahahaha) [14:19:57] (03PS5) 1001tonythomas: Used [[MediaWiki:Parentheses]] instead of hardcoded parentheses [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/107020 [14:23:24] hoo: ok now ? [14:25:29] tonythomas01: You didn't test that, did you? :P You really should test changes [14:26:20] hoo: Looks like it caused some errors right ? [14:26:38] tonythomas01: The message you want is named parentheses not parantheses [14:26:40] ;) [14:27:18] :) spells ! [14:29:09] (03CR) 10Parent5446: "I'm confused. How can getAll() be replaced by existing functions?" [core] - 10https://gerrit.wikimedia.org/r/107034 (owner: 10Tinaj1234) [14:29:43] Technical_13: that works ? [14:31:28] no. :( [14:32:32] Technical_13: hehe [14:33:08] (03PS6) 1001tonythomas: Used [[MediaWiki:Parentheses]] instead of hardcoded parentheses [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/107020 [14:33:14] I wish I could find some documentation that would explain it so I can understand. It's not a particularly graspable concept. [14:34:06] what does it do ? [14:34:16] hoo: Corrected , I guess. ! [14:34:16] or rather what is it supposed to do. [14:34:33] parse the table on Special:Userrights and then ? [14:34:35] tonythomas01: Taking a look [14:35:06] Yes [14:35:28] It is suppose to change the red x to a green check if the user meets that requirement for promotion [14:35:37] well it doesn't help that the canonical name of that page is UserRights [14:35:42] (03CR) 10Hoo man: [C: 032] Used [[MediaWiki:Parentheses]] instead of hardcoded parentheses [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/107020 (owner: 1001tonythomas) [14:35:59] tonythomas01: Still doesn't ahve the extra spaces... but who cares :P [14:36:03] Technical_13: oh no, correction. [14:36:08] it isn't. [14:36:12] >if(window.mw){ mw.config.set({"wgCanonicalNamespace":"Special","wgCanonicalSpecialPageName":"Userrights","wgNamespaceNumber":-1, [14:36:12] (03Merged) 10jenkins-bot: Used [[MediaWiki:Parentheses]] instead of hardcoded parentheses [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/107020 (owner: 1001tonythomas) [14:36:44] I know that part is right... When I look at the console log, it tells me that it has retrieved the information [14:36:49] hoo: Thanks :) [14:36:55] tonythomas01: Oh... and you should always try to test your changes at least briefly ;) [14:37:03] It just doesn't retrieve it until after it has done the code to update the table. [14:37:11] hoo: I will. was in a haste this time. [14:37:15] (03CR) 1001tonythomas: "I cant understand why, if I give" [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [14:37:27] "Collected: Edits: 396 Registration: Invalid Date Age in months: NaN Today in months: 24168 Account is NaN months old " [14:37:33] (03PS2) 10Bartosz Dziewoński: Don't show the overlay if the badge is not near the top of the window [extensions/Echo] - 10https://gerrit.wikimedia.org/r/103100 [14:37:36] for example in the console [14:37:59] Yes, I'll deal with the invalid registration dates after I get the rest working... :p [14:38:36] "Collected: Edits: 131 Registration: Fri Apr 13 2012 20:31:16 GMT-0400 (Eastern Daylight Time) Age in months: 24147 Today in months: 24168 Account is 21 months old " is another example with a valid reg date [14:39:10] Technical_13: i'll run it on wp. [14:40:00] I use ddowiki as a testing ground since I'm a steward there (and can do about anything). I do have some similar script ideas for wp and understanding callbacks will be needed. [14:40:26] (03CR) 10Hoo man: [C: 04-1] "Just a nitpick, looks good :)" (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/106891 (owner: 10Anjanasasindran123) [14:41:00] Keep in mind that ddowiki is using mw 1.19.x and older versions of jQuery [14:42:02] I appreciate this. It will greatly help me undertand getting information from the api and using callbacks. I'll post some documentation on what I learn on mediawikiwiki too so others can figure it out easily. [14:42:41] (03PS2) 10AalekhN: SpecialContributions.php : made Special:Contributions includable [core] - 10https://gerrit.wikimedia.org/r/106320 [14:48:06] Technical_13: eh this is gonna take a while :D [14:49:43] (03PS6) 10AalekhN: SpecialWhatlinkshere.php : made Special:Whatlinkshere transclude [core] - 10https://gerrit.wikimedia.org/r/106625 [14:51:35] No worries. I can give you full rights on ddowiki if you want to work on it there where the table is already set up... [15:01:02] age in months ? [15:01:38] Yes. [15:01:45] months since Jan 2000 [15:01:56] For now, I may need to go back further. [15:02:13] It is to make it easy to check if the account is at least six months old. [15:03:09] I'll probably need to tweek that number once the other parts are working (so that it is a floor number and 5.01 months doesn't count as the 6 month requirement for promotion). [15:03:19] why not new Date().getTime() - regDate().getTime() and then just check that [15:03:31] anyway, at least this runs: https://en.wikipedia.org/w/index.php?title=User:TheDJ/common.js&action=edit [15:03:44] (03CR) 10Alex Monk: [C: 032] API: Don't check for 'globalunblock' right [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/107015 (owner: 10Legoktm) [15:04:15] Technical_13: doing calc with Date objects is tricky. [15:04:16] (03Merged) 10jenkins-bot: API: Don't check for 'globalunblock' right [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/107015 (owner: 10Legoktm) [15:04:49] for instance getMonth is 0 based. [15:05:01] Yeah, that part is the easy stuff for me.. :p [15:05:36] well good luck from here, i need to go do some reallife stuff now :D [15:05:52] lol have fun with that [15:08:25] hrrmmm. [15:08:34] TypeError: data.query is undefined [15:12:01] I think it is because you changed urUsername to $('#username') which is an object and not a value. [15:12:31] I switched it back to what I had and it processed the script, but still didn't display the table. [15:12:40] $('#username').val() might work too. [15:16:02] (03CR) 10Bartosz Dziewoński: [C: 032] "Alright. I'll add this to Tech News and post an additional notification at VPT." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/95102 (owner: 10Legoktm) [15:16:09] !technews [15:16:09] https://meta.wikimedia.org/wiki/Tech/News/Latest [15:16:35] (03Merged) 10jenkins-bot: Add new messages indicator from a hook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/95102 (owner: 10Legoktm) [15:22:54] !roadmap [15:22:54] For long-term engineering goals roadmap, see . For short-term WMF deployments roadmap, see . [15:24:32] (03PS1) 10Dan-nl: image url not evaluated [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/107038 [15:24:58] Hrmm... I think I may have gotten it working with a few minor tweeks... [15:25:44] (03CR) 10Bartosz Dziewoński: "Announced at:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/95102 (owner: 10Legoktm) [15:30:42] (03PS5) 10Umherirrender: Raw option of parser functions should match complete word [core] - 10https://gerrit.wikimedia.org/r/100198 [15:30:44] legoktm: i cc'd you on a bug. https://bugzilla.wikimedia.org/show_bug.cgi?id=51640 [15:31:46] (03CR) 10Umherirrender: "Patch Set 5: Rebased" [core] - 10https://gerrit.wikimedia.org/r/100198 (owner: 10Umherirrender) [15:36:02] (03PS4) 10Anjanasasindran123: Increased the number of rows in AbuseFilter's Filter testing textarea [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/106891 [15:45:46] (03CR) 1001tonythomas: [C: 031] "Looks ok to me now!" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/106891 (owner: 10Anjanasasindran123) [15:47:33] (03PS1) 1001tonythomas: Gave a new error message for !isValidTiff() [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/107039 [15:49:44] (03PS2) 1001tonythomas: Gave a new error message for !isValidTiff() [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/107039 [16:02:02] (03PS1) 10MarkAHershberger: Fixed fatal error when getLocalCopy() fails [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107040 [16:06:02] That is really wierd... Apparently bot edits or minor edits don't get added to a user's edit count? [16:07:49] http://ddowiki.com/page/Special:Contributions/Kobold_sneak says that "This user has made 2,719 edits." which is a bot account, but according to the api "This account is 17 months old and has made 101 edits." [16:08:19] Is that an api bug? [16:10:58] (03CR) 10MarkAHershberger: "Use strtolower on both sides of the comparison to eliminate case." [core] - 10https://gerrit.wikimedia.org/r/105428 (owner: 1001tonythomas) [16:11:31] Technical_13: what api were you using and how? [16:12:37] Technical_13, https://github.com/wikimedia/mediawiki-core/pull/16 - this commit message really needs to specify which input we're changing [16:12:46] We have a lot of s in MediaWiki [16:13:02] http://ddowiki.com/api.php?action=query&format=json&list=allusers&auprop=editcount|registration&aulimit=1&aufrom=Kobold+sneak MatmaRex [16:13:02] And it also needs to be uploaded to Gerrit rather than Github [16:13:16] Krenair: the Gerrit uploader wasn't working. [16:13:29] So upload it properly...? [16:13:48] I'm not knowledgable on how to do that at this point. [16:14:08] Technical_13: that says "editcount":2719 to me? [16:14:51] Odd, because http://ddowiki.com/page/User:Technical_13/vector.js returns 101 with the same api call. [16:15:08] Technical_13, do you have a labs account? [16:15:21] Krenair: I do have a wikitech account. [16:15:21] (03PS2) 10Umherirrender: Give alreadyrolled error when rollback will be a null edit [core] - 10https://gerrit.wikimedia.org/r/102550 [16:15:27] Okay good [16:15:32] Have you put your SSH key in Gerrit? [16:15:43] I don't think so. [16:16:01] I'm not that good with SSHing into things yet. [16:16:16] I need to sit and practice at some point [16:16:40] sign in to gerrit.wikimedia.org using your wikitech login [16:16:59] go to https://gerrit.wikimedia.org/r/#/settings/ssh-keys and add your ~/.ssh/id_rsa.pub [16:21:01] Technical_13, done? [16:21:20] trying to remember my wikitech account credentials. xD [16:24:44] added my key from wikitech to gerrit [16:24:59] Krenair: ^^ [16:25:01] (03CR) 10Umherirrender: "You should amend your previous commit instead of upload a new one, see https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change" [core] - 10https://gerrit.wikimedia.org/r/106225 (owner: 10Cargan) [16:25:01] Okay, do you know what your shell username is? [16:25:03] (03CR) 10Umherirrender: "You should amend your previous commit instead of upload a new one, see https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change" [core] - 10https://gerrit.wikimedia.org/r/105167 (owner: 10Cargan) [16:25:37] I think I do. [16:25:59] It's the same as my labs with a hyphen instead of a space iirc [16:26:19] Instance shell account name: technical-13 [16:26:25] yes I think that's it [16:26:25] from preferences on labs [16:26:31] Do you have git-review installed on your PC? [16:26:35] nope [16:26:50] Okay [16:27:23] Open your .ssh/config file and add these lines to the bottom: "Host gerrit.wikimedia.org", "User " followed by your shell username, "Port 29418" [16:28:08] with quotes? each on own line, or oneline as it shows here? [16:28:18] No, without the quotes. Each on its own line [16:28:50] where is my .ssh/config file? I'm a complete newb with this stuff [16:28:55] ~/.ssh/config [16:29:04] it might not exist yet, if not create it with that as the contents [16:29:29] Where would I create it? [16:29:37] Um [16:29:39] I said ~/.ssh/config [16:29:56] That doesn't mean a lot to me, and I don't really know bash yet. [16:30:35] Okay, so just "nano ~/.ssh/config" [16:31:07] Type in the text, and do Ctrl+X, then hit 'Y', and Enter to save [16:31:20] I'm assuimg I need to log into someplace to put that, probably an SSH connection with putty or something? [16:31:25] no [16:31:30] this is on your local machine [16:31:54] or wherever you're running git/mediawiki from anyway [16:31:54] I have a windows machine, will that matter? [16:32:11] um, yes. Are you running Git Bash or something? [16:32:23] I don't have any of that yet. [16:32:36] ... So how did you upload that patch set to github? [16:32:44] web interface [16:32:50] ew [16:32:54] yep [16:33:41] Is there a tutorial someplace for setting all this stuff up? [16:33:57] (03PS2) 10Umherirrender: Do not load special pages in WatchedItem::load [core] - 10https://gerrit.wikimedia.org/r/104024 [16:33:59] I'd like to learn to do it right, but it is going to be a learning curve for me. [16:34:26] guys, I'm trying to check some of the coding conventions, but https://www.mediawiki.org/wiki/Manual:Coding_conventions#Release_notes is quite unclear to me [16:34:37] what is a RELEASE-NOTES file? [16:34:38] Technical_13, https://www.mediawiki.org/wiki/Git/Tutorial [16:34:53] is there an example of how I should format that file? [16:34:58] Thanks. I'll work through that and come back with questions (I'm sure) [16:35:46] My patches don't do much, so there is no rush on them anyways... [16:36:00] I'm assuming there is no way to port them from github to gerrit. [16:36:35] There's usually a bot that does it but it doesn't appear to be working. YuviPanda? [16:39:24] guys, does anyone here know what a RELEASE-NOTES file is? [16:39:47] (referring to https://www.mediawiki.org/wiki/Manual:Coding_conventions#Release_notes) [16:40:08] Joeytje50: I would think it is a text file that explains the changes made in a version of software and mentioning known bugs usually. [16:40:12] Yes, it's the RELEASE-NOTES-* files you find at the root of the mediawiki/core repo [16:40:49] krenair: where could I find it? [16:41:01] ....the root of the mediawiki/core repo? [16:43:00] Joeytje50, https://git.wikimedia.org/raw/mediawiki%2Fcore.git/HEAD/RELEASE-NOTES-1.23 [16:43:58] sorry, I don't have any experience with git/github at all [16:44:08] I'm only just getting into it [16:44:50] you don't need to know anything about github, only git [16:56:56] Technical_13, how's it going so far? [16:58:42] Really slow... I'm being distracted by my two year old a lot, so I may not git it all until tomorrow when she's gone home with her mother (I made a punny lol). [17:04:38] (03PS5) 10Bartosz Dziewoński: mw.loader.store: More fault tolerance [core] - 10https://gerrit.wikimedia.org/r/100930 [17:09:11] (03CR) 10Aklapper: "Thanks for the patch! This looks good to me, but I'd first prefer to finish upgrading Bugzilla to 4.4 (working on this) before getting thi" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106883 (owner: 10Tinaj1234) [17:31:12] (03CR) 10Aklapper: "I've commented in https://bugzilla.wikimedia.org/show_bug.cgi?id=55536#c5 that I am not convinced that the proposed UI change has more adv" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106864 (owner: 1001tonythomas) [17:55:56] (03PS4) 1001tonythomas: Result shown if WIki Administrator username and password are same on same page of installer [core] - 10https://gerrit.wikimedia.org/r/105428 [18:08:55] (03CR) 10Physikerwelt: [C: 031] Fix depreciation warnings in FileBackend construction for EasyTimeline (031 comment) [extensions/timeline] - 10https://gerrit.wikimedia.org/r/104536 (owner: 1001tonythomas) [18:10:53] (03CR) 10Physikerwelt: [C: 031] Fix depreciation warnings in FileBackend construction for ConfirmEdit (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/104535 (owner: 1001tonythomas) [18:19:40] Krenair: which pull request? [18:19:42] * YuviPanda looks [18:19:46] Krenair: the automatic thing isn't running no w [18:21:37] Krenair: I see a couple of patches for core, moving them over now [18:21:47] YuviPanda, the mediawiki/core ones [18:21:53] yeah doing now [18:22:04] some of them from 4 months ago [18:23:40] (03PS1) 10Yuvipanda: input -> textarea [core] - 10https://gerrit.wikimedia.org/r/107042 [18:23:46] there we go [18:27:51] (03PS1) 10Yuvipanda: Add an &wpWatchlist option [core] - 10https://gerrit.wikimedia.org/r/107043 [18:31:02] (03CR) 10Alex Monk: [C: 04-1] "* Commit message needs to specify which input you're changing. We have a lot of them in MediaWiki." [core] - 10https://gerrit.wikimedia.org/r/107042 (owner: 10Yuvipanda) [18:32:05] (03CR) 10Alex Monk: "Also note this comes from https://github.com/wikimedia/mediawiki-core/pull/16 not Yuvi" [core] - 10https://gerrit.wikimedia.org/r/107042 (owner: 10Yuvipanda) [18:35:29] Nemo_bis: I don't get it -- are you saying there's no bug because the specs clearly state that this is not the correct behavior? [18:38:37] oh, no, you were just making sure the referenced images / files used stable links. thanks. [18:38:51] ori: no, I'm saying that if there's a bug which makes the software not behave according to the specs you can't say the specs are wrong [18:39:04] yes, that too [18:39:21] replace "you can't say" with "you've alreadfy not proved" [18:39:40] who said the specs are wrong? [18:39:53] anyway, the most useful thing any dev can do now is jumping on the patch to review it [18:40:05] you said someting about the design/approach being fundamentally flawed, IIRC [18:40:51] it's fundamentally flawed because it makes the cost of failing to update excluded selectors catastrophic for site performance [18:41:28] a whitelist approach would mean that if someone forgets to update them, maybe some template or page element doesn't get additional font support until someone notices [18:43:14] I got this argument and I have no opinion for or against, I was just pointing out that IMHO the reasoning provided didn't (yet) warrant/sustain that conclusion [18:43:27] this has happened repeatedly [18:43:44] the bug summary was well (better) scoped and actionable so I was a bit confused about what was the topic of hte report [18:44:19] hmm speaking of which, was there a report floating somewhere about some past incident [18:44:52] hi sucheta :) [18:45:11] i made the mistake of reporting several to the team directly rather than logging them in bugzilla, but they're not hard to reconstruct from the commit logs [18:45:33] thj [18:45:38] strike that [18:45:40] Nemo_bis, Hi. [18:46:26] then maybe a meta-bug could be filed about why you think a whitelist approach is better etc.? With such exctracts from commit logs and whatever. Dunno. [18:47:23] I just felt that in that specific case of that specific page there was an actionable low hanging fruit (as opposed to some more general reflection/rethinking one can make) [18:47:51] (03PS3) 1001tonythomas: Change return value of self::urlFunction from array to boolean [core] - 10https://gerrit.wikimedia.org/r/107017 [18:47:55] it's not specific to that page; there's a race condition that makes the fonts load depending on the order stylesheets / javascript resources are evaluated [18:49:03] typically the way to resolve race conditions is to impose an explicit order of operations rather than just delay something to make it run later, which is why i'm not sold on the patch [18:52:15] MatmaRex: thanks, I'll take a look [18:53:43] MatmaRex: do you understand what is going on there? https://gerrit.wikimedia.org/r/#/c/107028/ I mean [18:54:07] why does yielding resolve the race condition, exactly? [18:54:30] oh please, don't make me look at that [18:54:49] most of the ULS code i've seen hurt to look at :( [18:55:28] (03PS2) 1001tonythomas: Fix depreciation warnings in FileBackend construction for ConfirmEdit [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/104535 [18:56:21] well, the patch itself is simple; it just wraps a call with a setTimeout(.., 0) to make it cooperative [18:56:45] i don't see how that would do anything unless mw.uls.init does something weird after calling its callback [18:56:59] fixed delay to fix a race condition???? [18:57:08] MaxSem: no, 0 ms delay :D [18:57:32] (that makes sense in some rare cases – JS sucks) [18:57:32] MaxSem: delay of 0 is equivalent to yielding the UI thread to any already-queued operations [18:58:05] MaxSem: there's actually a proposal to have a clearer idiom for it with more tightly-specified behavior -- 'setImmediate' [18:58:07] aka, when you don't want the "unresponsive script" dialog on firefox to appear, you do that :P [18:58:21] ...and a prayer that it does what was intended in all circumstances on all browsers.... [18:58:34] mmmh, let's see what that code does, i guess [18:58:38] * MatmaRex clones the repo [18:59:29] also, i should probably see what the race condition is… [19:00:36] (03PS2) 1001tonythomas: Fix depreciation warnings in FileBackend construction for EasyTimeline [extensions/timeline] - 10https://gerrit.wikimedia.org/r/104536 [19:00:51] meh, of course it doesn't say that anywhere [19:01:24] (03CR) 1001tonythomas: "@Parent:- How does the patch look ?" [core] - 10https://gerrit.wikimedia.org/r/107017 (owner: 1001tonythomas) [19:02:03] anyway, doing some guessing, i honestly don't see how that timeout could allow any styles to be loaded [19:02:19] don't browsers do this kind of stuff "lazily" when the value of font-family is requested? [19:04:48] (03PS4) 1001tonythomas: Change return value of self::urlFunction from array to boolean [core] - 10https://gerrit.wikimedia.org/r/107017 [19:05:20] how large is that stupid ULS repo :/ [19:09:12] very [19:11:40] (03PS1) 10Yuvipanda: Fix for IP detection. [core] - 10https://gerrit.wikimedia.org/r/107044 [19:13:40] 46.63 MiB download. [19:15:49] (03CR) 10jenkins-bot: [V: 04-1] Fix for IP detection. [core] - 10https://gerrit.wikimedia.org/r/107044 (owner: 10Yuvipanda) [19:16:42] mw.uls.init doesn't even seem to always call its callback [19:16:42] wtf [19:17:42] MatmaRex: welcome to the asynchronous programming [19:18:42] no [19:18:50] asynchronous programming i can do all day [19:18:54] it's alogical one that beats me :) [19:19:14] it only calls the callback if everything was already initialized [19:19:18] or partially initialized [19:19:23] but not if it wasn't initialized at all [19:21:05] (03PS1) 10Yuvipanda: Update Installer.php [core] - 10https://gerrit.wikimedia.org/r/107045 [19:25:47] (03CR) 10Platonides: [C: 04-1] "Why does User:isIP() need to be fixed?" [core] - 10https://gerrit.wikimedia.org/r/107044 (owner: 10Yuvipanda) [19:28:53] why on earth is gerrit so slowww? :/ [19:29:30] (03CR) 10Yuvipanda: "(Is from https://github.com/wikimedia/mediawiki-core/pull/14)" [core] - 10https://gerrit.wikimedia.org/r/107044 (owner: 10Yuvipanda) [19:55:05] (03CR) 10Technical 13: "It's intended to change " [core] - 10https://gerrit.wikimedia.org/r/107042 (owner: 10Yuvipanda) [19:58:17] java [19:58:23] (03CR) 10PleaseStand: "> 2) Instead of just doing duplicate entries in the autoloader, keep the alias: syntax so that deprecation warnings can still be done. Whe" [core] - 10https://gerrit.wikimedia.org/r/106944 (owner: 10PleaseStand) [20:00:55] MatmaRex: were you going to review it? [20:03:00] i'm being shamelessly lazy [20:08:28] (03PS1) 10Jackmcbarn: Add restrictions variable to mw.title output [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/107046 [20:21:06] (03PS2) 10Gerrit Patch Uploader: Move toctoggle from mediawiki.util.js to separate file mediawiki.toc.js [core] - 10https://gerrit.wikimedia.org/r/106132 [20:21:08] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/106132 (owner: 10Gerrit Patch Uploader) [20:24:45] (03CR) 10Aaron Schulz: [C: 032] rebuildrecentchanges.php leaves some rc_source empty [core] - 10https://gerrit.wikimedia.org/r/107025 (owner: 10Umherirrender) [20:24:53] ori: uhm, probably not [20:25:10] i have no idea why that patch would do anything, though [20:25:24] i looked at it a bit, but i gave up five levels of indirection down [20:25:37] and i think i have some uni work to do for tomorrow, eh [20:25:41] ori: ^ [20:27:02] MatmaRex: yes, better to do that! :) thanks anyhow [20:27:38] (03CR) 10Aaron Schulz: "Not sure if this is worth a backport. It may still fail harshly further down the pipeline. Is there some outside user that ran into this." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107040 (owner: 10MarkAHershberger) [20:28:01] (03Merged) 10jenkins-bot: rebuildrecentchanges.php leaves some rc_source empty [core] - 10https://gerrit.wikimedia.org/r/107025 (owner: 10Umherirrender) [20:33:38] (03CR) 10Hoo man: [C: 04-1] "Message Qqq missing." [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/107039 (owner: 1001tonythomas) [20:46:00] (03CR) 10Hoo man: [C: 04-1] "Please have a look at https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP and follow these in the API module." (033 comments) [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/87546 (owner: 10Stwalkerster) [20:59:55] (03CR) 10Physikerwelt: [C: 031] Fix depreciation warnings in FileBackend construction for ConfirmEdit [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/104535 (owner: 1001tonythomas) [21:00:37] (03CR) 10Physikerwelt: [C: 031] Fix depreciation warnings in FileBackend construction for EasyTimeline [extensions/timeline] - 10https://gerrit.wikimedia.org/r/104536 (owner: 1001tonythomas) [21:05:47] (03CR) 10UltrasonicNXT: [C: 04-1] "The {{PLURAL}} you have added isn't working for me. It's evaluated in javascript, and although the docs (http://www.mediawiki.org/wiki/Man" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/106887 (owner: 10Raimond Spekking) [21:20:42] (03PS3) 10UltrasonicNXT: Consistency tweaks, round 2 [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/106887 (owner: 10Raimond Spekking) [21:22:46] (03CR) 10UltrasonicNXT: [C: 032 V: 032] "Fixed that with help from MatmaRex in IRC. This looks good to go." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/106887 (owner: 10Raimond Spekking) [21:29:09] (03PS7) 10Stwalkerster: Add an API module for querying AntiSpoof results. [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/87546 [21:33:08] (03CR) 10Stwalkerster: "Fixed. Sorry about the constant style fixes, I usually swap between about 3 different coding styles for different projects, and StyleCop n" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/87546 (owner: 10Stwalkerster) [21:51:59] hey guys, I'm trying to set up git-review on my computer, but when I follow the steps on https://www.mediawiki.org/wiki/Gerrit/git-review#Windows [21:52:10] (03CR) 10Fomafix: "The change https://gerrit.wikimedia.org/r/105207 is needed for textarea { box-sizing:border-box }." [core] - 10https://gerrit.wikimedia.org/r/107042 (owner: 10Yuvipanda) [21:52:13] I get an error when I do $ git-review -s [21:52:52] No '.gitreview' file found in this repository. We don't know where your gerrit is. Please manually create a remote named "gerrit" and try again. [21:52:56] What does that mean? [21:54:27] Joeytje50: You should do something like "git remote add gerrit ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer.git" for the project you're using and then try running git-review again [21:54:40] Also whatever project you're using should have a .gitreview file. [21:54:57] just a blank .gitreview file? [21:55:05] or should it have something in it? [21:55:12] It should have thing in it, yes :) [21:55:22] what would be in it then? [21:55:23] :/ [21:55:33] whoops, wrong window. [21:55:55] Joeytje50: I dunno, you can look at most other projects in Gerrit for examples [21:56:14] MultimediaViewer has one, for example [21:58:24] marktraceur: http://i.imgur.com/hW4tWK4.png [21:59:33] Joeytje50: You may not have Gerrit set up correctly [21:59:50] I may not have Gerrit set up at all, I have no idea [21:59:55] I'm just following the guides [21:59:59] Joeytje50: Have you gone through the setup instructions for creating and authorising your public key? [22:00:07] https://www.mediawiki.org/wiki/Gerrit/Getting_started that guide says to go to https://www.mediawiki.org/wiki/Gerrit/git-review#Windows [22:00:10] so that's what I did [22:00:30] I'm completely new to this, so I'm just trying to get familiar with this [22:00:34] Joeytje50: Have you gone to gerrit.wikimedia.org, logged in, and added your public key? [22:00:51] "added your public key"? [22:01:02] Joeytje50: https://www.mediawiki.org/wiki/Gerrit/Tutorial#Set_Up_SSH_Keys_in_Gerrit [22:25:35] (03PS6) 10Tim Starling: Raw option of parser functions should match complete word [core] - 10https://gerrit.wikimedia.org/r/100198 (owner: 10Umherirrender) [22:25:41] (03CR) 10Tim Starling: [C: 032] Raw option of parser functions should match complete word [core] - 10https://gerrit.wikimedia.org/r/100198 (owner: 10Umherirrender) [22:29:34] (03Merged) 10jenkins-bot: Raw option of parser functions should match complete word [core] - 10https://gerrit.wikimedia.org/r/100198 (owner: 10Umherirrender) [22:45:44] (03CR) 10MarkAHershberger: "This was reported by an outside user (https://bugzilla.wikimedia.org/show_bug.cgi?id=40166#c5), so I think it is worth a backport." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/107040 (owner: 10MarkAHershberger) [22:47:23] (03PS2) 10Gerrit Patch Uploader: Rework mediawiki.feedback.js [core] - 10https://gerrit.wikimedia.org/r/105457 [22:47:25] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [23:14:12] (03CR) 10MarkAHershberger: "ps13 works" [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [23:22:26] (03PS17) 10MarkAHershberger: Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/89340 [23:22:53] (03CR) 10MarkAHershberger: [C: 032] Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [23:25:45] self-merge hexmode? [23:26:21] (03Merged) 10jenkins-bot: Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [23:27:50] (03CR) 10Alex Monk: "Should not have been self-merged." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [23:47:38] guys, I'm getting REALLY confused with how this all works. What is the bare minimum I need to do to create a new MW extension? [23:48:15] !e Example [23:48:15] https://www.mediawiki.org/wiki/Extension:Example [23:48:36] meh, that actually seems rather complicated [23:48:48] try looking at something like, hmm [23:48:50] maybe Poem [23:48:51] !e Poem [23:48:51] https://www.mediawiki.org/wiki/Extension:Poem [23:50:19] MatmaRex: okay, but I've created the code for a working extension already, I'm sorry for my unclear question, but what I meant was, what is the bare minimum I need to do to get it added to MediaWiki [23:50:25] I've seen all sorts of stuff with git [23:50:31] and things like that [23:50:39] but the more I look into that, the deeper it gets [23:50:50] "added to MediaWiki"? [23:51:01] Joeytje50, it really depends on what you want it to do [23:51:08] well yeah, like https://www.mediawiki.org/wiki/Special:ExtensionDistributor/Poem [23:51:57] Joeytje50: you have to ask to have a repository created for it [23:52:29] where can I do that? [23:52:34] i'm finding out [23:52:42] this seems to be the way: https://www.mediawiki.org/wiki/Gerrit/New_repositories#Step_3:_Request_space_for_your_extension [23:52:53] or you can ask ^demon when he's around [23:52:55] @seen ^demon [23:52:55] MatmaRex: Last time I saw ^demon they were quitting the network with reason: Quit: Page closed N/A at 12/20/2013 10:03:15 PM (23d1h49m40s ago) [23:53:06] @seen ^d [23:53:06] MatmaRex: Last time I saw ^d they were changing the nickname to ^demon|away, but ^demon|away is no longer in channel because he quitted the network 1.23:49:28.6550410 ago. The nick change was done in #wikidata at 1/10/2014 8:56:06 PM (2d2h56m59s ago) [23:53:14] ^d, rather. [23:53:17] If you ask him he will tell you to put the request on mw.org [23:53:21] So might aswell just do that [23:54:00] hexmode, you self-merged? [23:54:08] code with var_dump()? [23:54:10] Joeytje50: so, once you have that repository created and the extension committed in it, you can create a description/manual page for it on mediawiki.org, and that's it [23:54:45] and what's the buisness with git then? [23:55:03] Joeytje50: hmm also, i'm not sure how automated extensiondistributor are [23:55:09] ^d will know :) [23:55:31] Joeytje50: we use git to track changes to MediaWiki and all of its extensions hosted on gerrit.wikimedia.org [23:55:37] can I leave him a talk page message? [23:55:56] because it looks like he's been gone for 2 days, so I wouldn't want to wait days before I catch him [23:55:56] probably, but no idea if he checks those [23:56:04] you might want to mail him, or mail the wikitech list instead [23:56:05] !lists [23:56:05] mediawiki-l and wikitech-l are the primary mailing lists for MediaWiki-related issues. See https://www.mediawiki.org/wiki/Mailing_lists for details. [23:56:13] or wait for someone more competent than me to appear here [23:57:53] Joeytje50: He's gone for 2 days because it's a weekend [23:58:05] Don't leave him a talk page message [23:58:09] Leave a message in the correct place [23:58:09] okay [23:59:45] (03PS1) 10MaxSem: Revert "Include short descriptions for extensions bundled in the release" [core] - 10https://gerrit.wikimedia.org/r/107107