[00:31:35] marktraceur: would you be willing to counter sign an RSA key of mine? [00:32:29] I signed up for a launchpad PPA today; and that's apparently a recommended thing to get done [00:32:59] gpg signing party? [00:33:53] I'd be interested too [00:34:12] sure! [00:34:32] mine is on key servers (wicke@wikidev.net) [00:35:57] just sent you a signed mail [00:37:22] interesting; how did you add additional email addresses to your key? [00:37:55] with the gpg commandline IIRC [00:37:56] mwalker: I'm not super into crypto, I doubt it would be very helpful [00:38:15] ah; I thought you were the one always sending out signed emails [00:38:20] * mwalker mind is oviously going [00:38:24] http://www.katescomment.com/how-to-add-additional-email-addresses-to-your-gpg-identity/ [00:38:58] please also add a photo ;) [00:39:19] hah; I just found that in google [00:39:40] (03PS1) 10Aaron Schulz: Optimized copyFileBackend to use MD5 from listing if given (e.g. Swift) [core] - 10https://gerrit.wikimedia.org/r/106638 [00:41:44] mwalker: I have a couple well connected signatures on mine [00:42:00] (paravoid and this other really interesting dude) [00:42:05] hehe [00:42:21] ok; I'll send you a signed email in a second -- I'm adding all my other identites and metadata [00:42:26] we totally should have a signing party [00:42:45] my gpg key fp is on my business card, to make that easy [00:43:12] I should add a photo, too [00:46:43] mwalker: I send out signed emails but nobody has signed my key and it's not on a keyserver so pretty useless [00:47:06] ah; more evidence for needed keysigning party; after I finish my metadata exploration I'll send out an email [00:47:13] we can maybe do it tomorrow lunch [00:47:22] +1 [00:47:43] greg-g: will you be in the office tomorrow? [00:47:52] mwalker: yessir [00:47:58] mwalker: But I also basically don't care enough, hilariously [00:47:58] coool [00:48:03] marktraceur: against keyserver? [00:48:05] And need a haircut. [00:48:09] greg-g: No, just lazy [00:48:19] k, some are anti-keyserver for privacy reasons [00:48:39] My key is hosted publicly and linked in every mail I send [00:48:39] why you shouldn't auto-upload all your sigs, send their signed key to them, let them upload it if they want [00:48:45] marktraceur: not as easy! [00:48:49] ;) [00:48:57] True [00:48:58] easy, freedom, privacy, pick 2? [00:49:07] pick 1, probably ;) [00:49:12] :P [00:49:13] I kinda picked one and a half I guess [00:49:27] it's not so bad any more these days [00:49:43] inb4 back in my day [00:50:36] alright, /me goes to do dinner and things [00:51:17] 1:58 [00:51:22] * thedj will sleep [00:51:37] eh 1:51 perhaps i'm already asleep [01:01:41] (03CR) 10BryanDavis: [C: 032] Optimized copyFileBackend to use MD5 from listing if given (e.g. Swift) [core] - 10https://gerrit.wikimedia.org/r/106638 (owner: 10Aaron Schulz) [01:16:48] robla: yt? [01:17:05] yup...one sec while I wrap up one thing... [01:17:12] sure thing [01:17:53] (03CR) 10Parent5446: [C: 031] Optimized copyFileBackend to use MD5 from listing if given (e.g. Swift) [core] - 10https://gerrit.wikimedia.org/r/106638 (owner: 10Aaron Schulz) [01:18:09] mobile just discovered that mobile diffs are broken in production and we've got a fix (https://bugzilla.wikimedia.org/show_bug.cgi?id=59848) - we'd like to get it out asap and would normally ask greg for permission to do this out of band, but i think he's off to dinner [01:20:56] let me look through the patch/etc [01:21:30] hah [01:21:36] Oh dear [01:21:53] Reedy: no one else is deploying anything right now, right? [01:21:59] I've no idea [01:22:02] I know I'm not [01:22:03] to wikitech! [01:22:26] Nope, all clear [01:22:59] awjr: go for it [01:23:54] thanks robla :) [01:24:04] np [01:24:27] i think we have discovered a bug in gerrit [01:24:40] just one? [01:25:49] heh just one this one time :) [01:25:58] robla, greg-g , Reedy: we found a typo in cache key which is breaking Flow in production (https://bugzilla.wikimedia.org/show_bug.cgi?id=59884) - we'd like to get it out asap ... [01:26:27] spage head's up that MaxSem is currently deploying a quick fix for mobile diffs [01:26:58] awjr: Yup just asking for permission, thanks for the template :) [01:27:37] :) [01:28:10] spage, where's the fix checked in? [01:28:46] robla: it's coming, Benny's testing it locally. [01:30:26] (03PS1) 10MaxSem: Update MobileFrontend to wmf/1.23wmf9 tip [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106643 [01:31:23] MaxSem: did you backport the fix or did you pull in other unrelated updates? [01:31:33] robla, backporting [01:31:53] cool, thx [01:34:25] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to wmf/1.23wmf9 tip [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106643 (owner: 10MaxSem) [01:37:32] (03Merged) 10jenkins-bot: Update MobileFrontend to wmf/1.23wmf9 tip [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106643 (owner: 10MaxSem) [01:37:45] (03PS1) 10MaxSem: Update MobileFrontend to wmf/1.23wmf10 tip [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106645 [01:37:51] (03PS1) 10Bsitu: Fix invalid memcache key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106646 [01:39:56] (03CR) 10Spage: [C: 032] "the rootpath cache keys match now" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106646 (owner: 10Bsitu) [01:40:00] (03Merged) 10jenkins-bot: Fix invalid memcache key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106646 (owner: 10Bsitu) [01:41:58] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to wmf/1.23wmf10 tip [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106645 (owner: 10MaxSem) [01:43:05] robla it's this one-liner, https://gerrit.wikimedia.org/r/#/c/106646/ [01:44:51] * robla looks [01:45:56] spage: how long has this been broken? [01:46:41] We think write one key, read the same (typo fail), fall back to slave DB but the DB update isn't there yet in production [01:47:17] robla, I'm done, thanks [01:47:29] robla: it's failed since we deployed 1.23wmf10 today. Now that's odd because we've had this typo for a while, but we've improved surrounding caching [01:48:12] (03PS2) 10Aaron Schulz: Optimized copyFileBackend to use MD5 from listing if given (e.g. Swift) [core] - 10https://gerrit.wikimedia.org/r/106638 [01:48:23] (03CR) 10Aaron Schulz: [C: 032] "Pinging Jenkins" [core] - 10https://gerrit.wikimedia.org/r/106638 (owner: 10Aaron Schulz) [01:49:39] spage: ok...go ahead [01:49:58] MaxSem: spage: y'all are monitoring the fatal log, right? [01:50:26] yep, boring as before [01:52:11] (03Merged) 10jenkins-bot: Optimized copyFileBackend to use MD5 from listing if given (e.g. Swift) [core] - 10https://gerrit.wikimedia.org/r/106638 (owner: 10Aaron Schulz) [01:52:39] (03PS1) 10Aaron Schulz: Optimized copyFileBackend to use MD5 from listing if given (e.g. Swift) [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106647 [01:52:45] (03CR) 10Aaron Schulz: [C: 032] Optimized copyFileBackend to use MD5 from listing if given (e.g. Swift) [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106647 (owner: 10Aaron Schulz) [01:56:52] (03Merged) 10jenkins-bot: Optimized copyFileBackend to use MD5 from listing if given (e.g. Swift) [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106647 (owner: 10Aaron Schulz) [02:01:18] (03PS1) 10Spage: Update Flow to master (bug 59884) [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106649 [02:04:11] (03CR) 10Bsitu: [C: 032] Update Flow to master (bug 59884) [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106649 (owner: 10Spage) [02:04:51] AaronSchulz: are you backporting the Filebackend change for deployment tonight? [02:07:28] (03Merged) 10jenkins-bot: Update Flow to master (bug 59884) [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106649 (owner: 10Spage) [02:16:51] (03CR) 10Gergő Tisza: Add blacklisting feature for flickr in backend (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [02:19:03] Is there a new known problem with SUL on mediawikiwiki specifically? If I log-in at Enwiki, SUL doesn't log me in at mediawikiwiki, but it does work everywhere else. I've tried in Firefox and Opera, with cache cleared in both. I've tried logging in-and-out with different accounts, but the problem persists. [02:21:33] robla: I'm not running it today, just getting it in wmf10 so I can run it sooner [02:22:22] (03PS1) 10Aklapper: Display useful links on Bugzilla front page [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106650 [02:27:09] (03CR) 10Parent5446: Make it a bit safer to paste input to eval.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106632 (owner: 10Aaron Schulz) [02:27:35] I think we have Gerrit per-patch review data in a bulk format now. I wonder if anyone's used it yet. We could add new reports. [03:09:09] legoktm, WMF has almost 880 wikis now [03:09:14] wut [03:09:18] (according to all.dblist) [03:09:26] sigh [03:09:39] I'll correct myself then [03:10:08] it doesn't matter that much :) [03:23:49] anyone familiar with flaggedrevs around? [03:23:54] Just ask your question. [03:24:04] Also, hello. [03:25:14] i'm talking to Risker about pc2 at https://en.wikipedia.org/wiki/Wikipedia:Pending_changes/Request_for_Comment_2014#Discussion . how is enwiki's implementation of flaggedrevs modified from the regular version? i'm looking at the configfiles and can't see any modifed code being used [03:26:08] Are you looking at flaggedrevs.php? [03:26:11] yes [03:26:13] There's a lot of config for that extension. [03:26:16] Oh. [03:26:19] config, but not modifications [03:26:33] it's the same code that's in git and that every other wm wiki runs, just with different config set, right? [03:26:43] en.wiki did some stupid shit. [03:26:47] Like naming it "Pending Changes". [03:26:50] Let me look. [03:27:12] https://noc.wikimedia.org/conf/flaggedrevs.php.txt [03:27:48] It looks like it has some customization. [03:28:01] Under $wgDBname = 'enwiki' [03:28:13] i'm looking there. isn't that all configuration? [03:28:26] or are some of those variables not things that are supposed to be touched? [03:28:32] There's a brief mention of FR at https://noc.wikimedia.org/conf/CommonSettings.php.txt [03:28:46] I'm not sure what you're asking. [03:28:53] Of course it's all configuration... [03:29:06] risker says "There are localized changes that are unsupported" [03:29:07] What do you mean by "things" when you're asking about touching? [03:29:18] isn't everything we're doing with it supported? [03:29:20] You'll have to ask Risker what she means, then. [03:29:43] Risker follows technical discussions and knows FR pretty well. [03:29:49] she also said we should change pending changes to flagged revisions, which really confused me [03:29:53] But whether she's right about level of support... is a different matter. [03:30:09] They're basically the same thing. [03:30:18] en.wiki renamed the extension for marketing purposes. [03:30:19] Or something. [03:30:26] It was a stupid decision then, still stupid now. [03:30:27] so an RfC to change one to the other would just be politics, no technical anything? [03:30:37] Change what, exactly? [03:30:45] Do you mean the interface customizations? [03:30:46] pending changes to flagged revisions [03:30:48] Is that what you're asking about? [03:30:52] How about trying a completely different RFC, like "change Pending Changes to Flagged Revisions"; at least that extension's being maintained. [03:30:55] Right, we finally got to what you were really asking about. [03:30:56] Okay. [03:31:02] You could've just started with... [03:31:07] she's talking about PC and FR like they're two different things [03:31:08] in general [03:31:14] and i don't see it at all [03:31:21] They're distinct because the Wikimedia Foundation made a distinction. [03:31:27] Look at Special:Version for the actual software. [03:31:36] (03CR) 10Nischayn22: Add blacklisting feature for flickr in backend (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [03:31:42] RfC + enwiki + FR + silly name changes = just why. [03:31:50] but they're really the same code with just a language message changed somewhere? [03:31:51] https://en.wikipedia.org/wiki/Special:Version [03:31:56] right, i see FR there [03:31:57] no mention of PC [03:32:05] There is a mention, actually. [03:32:08] But it's irrelevant here. [03:32:26] It's in a parser function hook name. [03:32:35] Anyway, I believe the en.wiki shit was all done in the MediaWiki namespace. [03:32:36] FR=reviewing all pages in certain namespaces, PC=making edits to select pages need review like protection [03:32:48] Because it was completely specific to en.wiki. [03:33:01] That's using the stabilisation thing right AaronSchulz? [03:33:03] the naming is kind of...well, mostly branding [03:33:08] jackmcbarn: https://en.wikipedia.org/wiki/MediaWiki:Flaggedrevs-protect-legend [03:33:29] Krenair: well for PC it just uses ?action=protect [03:33:35] ah [03:33:46] but it's a similar concept under the hood [03:34:13] https://en.wikipedia.org/w/index.php?title=Special%3APrefixIndex&prefix=Flaggedrevs&namespace=8 [03:35:02] so the only difference is between PC and FR is what the enwiki admins changed the messages in the MediaWiki namespace to be [03:35:10] jackmcbarn: If there's a particular part of the user interface you're interested in, just specify ?uselang=qqx [03:35:51] There's history about this on the wiki. [03:35:54] You could do a bit of research. :-) [03:36:26] my question's answered basically. a political difference rather than a technical one [03:36:28] thanks for your help [03:36:29] jackmcbarn, from a purely extension-code point of view it seems that way, however enwiki uses a particularly unique config for PC [03:36:36] jackmcbarn: and some UI bits [03:36:49] Krenair: You can't modify the word "unique" like that. ;-) [03:36:55] Unique is binary. [03:37:09] jackmcbarn: Perhaps social, not political. [03:37:16] It was a marketing gimmick, as I said. [03:37:16] yeah, that's what i meant [03:37:22] I'd say the biggest UI difference is that with PC you can have pages go from totally not having any flaggedrevs UI to having it based on ?action=protect settings [03:37:33] I can't remember who actually did it. Maybe RobLa. [03:37:44] with FR, all pages an certain namespaces must be reviewable, no per-page exceptions [03:37:46] Gloria, you're right of course. I would assume it is unique. [03:38:02] though you can indeed change the default versions around via special:Stabilization [03:38:12] en.wiki is one of a kind! [03:39:49] so $wgFlaggedRevsProtection = true; is what makes enwiki stick out? [03:41:29] seems that way. [03:41:31] thanks again [03:44:11] pretty much [04:25:52] (03PS1) 10Aaron Schulz: Fixed silly doc typos [core] - 10https://gerrit.wikimedia.org/r/106654 [04:30:10] (03CR) 10PleaseStand: [C: 04-1] "I looked at the XML and found a problem ('stroke-width="NaN"'). I have not yet checked whether there are major rendering differences with " (033 comments) [core] - 10https://gerrit.wikimedia.org/r/106506 (owner: 10Bartosz Dziewoński) [05:20:28] (03PS1) 10Pastakhov: fix bug 15538 [core] - 10https://gerrit.wikimedia.org/r/106657 [05:23:42] (03CR) 10BryanDavis: "Strange changes to qqq file." (032 comments) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106511 (owner: 10L10n-bot) [05:38:39] Hello i wanted to know if there is any difference between API:Backlinks and Special:Whatlinkshere? [05:43:23] yurik? [06:36:28] (03PS10) 10Gergő Tisza: Add blacklisting feature for flickr in backend [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [06:36:30] (03CR) 10jenkins-bot: [V: 04-1] Add blacklisting feature for flickr in backend [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [06:53:07] (03CR) 10Adamw: [C: 04-1] "Docblocks will be associated with the structural element immediately after the block. See my inline comment for more thoughts, such as: d" (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95158 (owner: 10Ragesoss) [06:58:07] (03CR) 10Parent5446: Maintenance script to migrate legacy Oversight data (034 comments) [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 (owner: 10Alex Monk) [07:01:30] (03CR) 10Parent5446: [C: 032] Add ability to mark hooks as deprecated [core] - 10https://gerrit.wikimedia.org/r/106436 (owner: 10Aude) [07:02:03] (03CR) 10jenkins-bot: [V: 04-1] Add ability to mark hooks as deprecated [core] - 10https://gerrit.wikimedia.org/r/106436 (owner: 10Aude) [07:07:36] (03CR) 10Parent5446: "Minor doc issue. After that this is good to merge." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/52676 (owner: 10MrBlueSky) [07:08:40] (03CR) 10Adamw: [C: 04-2] "Err... I'm really hoping that this whole infrastructure is dropped in a later commit. It seems like it would work, but it reminds me of t" (032 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95307 (owner: 10AndyRussG) [07:12:31] (03CR) 10Adamw: "wow. Sorry, removing my -2 for the moment. I'd like to ask a few questions before I "help" any more here." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95307 (owner: 10AndyRussG) [07:18:05] (03CR) 10GWicke: [C: 04-1] "Adding a -1 as I believe that the current patch is moving us in the wrong direction." [core] - 10https://gerrit.wikimedia.org/r/99792 (owner: 10Anomie) [07:20:43] (03CR) 10Parent5446: Changed temporary password system to use tokens. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106218 (owner: 10Parent5446) [07:23:32] (03CR) 10Parent5446: Changed temporary password system to use tokens. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106218 (owner: 10Parent5446) [07:25:21] (03PS3) 10Parent5446: Changed temporary password system to use tokens. [core] - 10https://gerrit.wikimedia.org/r/106218 [07:25:30] (03CR) 10Parent5446: Changed temporary password system to use tokens. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106218 (owner: 10Parent5446) [07:28:41] (03CR) 10Adamw: [C: 032] "Great!" (034 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98183 (owner: 10AndyRussG) [07:32:33] (03CR) 10Adamw: [C: 032] "Very scary" (032 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/99316 (owner: 10AndyRussG) [07:32:40] (03Merged) 10jenkins-bot: Style deletion warning messages [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/99316 (owner: 10AndyRussG) [07:38:47] (03CR) 10MZMcBride: "Any idea how to move forward here?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [07:44:07] (03CR) 10Adamw: [C: 032] Fix undelete courses and institutions [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98475 (owner: 10AndyRussG) [07:44:14] (03Merged) 10jenkins-bot: Fix undelete courses and institutions [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98475 (owner: 10AndyRussG) [08:05:51] (03CR) 10Adamw: [C: 032] Let instructors and volunteers assign articles (034 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 (owner: 10AndyRussG) [08:06:01] (03Merged) 10jenkins-bot: Let instructors and volunteers assign articles [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 (owner: 10AndyRussG) [08:13:06] (03PS3) 10Aude: Add ability to mark hooks as deprecated [core] - 10https://gerrit.wikimedia.org/r/106436 [08:36:38] (03PS1) 10Legoktm: Turn Comments class into a ContextSource [extensions/Comments] - 10https://gerrit.wikimedia.org/r/106665 [08:42:39] (03PS1) 10Legoktm: Exit early in Comment::isSpam [extensions/Comments] - 10https://gerrit.wikimedia.org/r/106666 [08:44:19] hello [08:44:55] (03PS2) 10PleaseStand: WebInstaller: Don't call getSoftwareLink() [core] - 10https://gerrit.wikimedia.org/r/106489 [08:46:00] (03CR) 10Jack Phoenix: [C: 032 V: 032] Exit early in Comment::isSpam [extensions/Comments] - 10https://gerrit.wikimedia.org/r/106666 (owner: 10Legoktm) [08:46:44] (03Abandoned) 10PleaseStand: Clean up config-support-* messages [core] - 10https://gerrit.wikimedia.org/r/106490 (owner: 10PleaseStand) [08:48:23] (03Abandoned) 10PleaseStand: Web installer: Remove support for old config-support-* translations [core] - 10https://gerrit.wikimedia.org/r/106491 (owner: 10PleaseStand) [08:49:07] (03CR) 10Pastakhov: "This path help me resolve error 'The file is a corrupt or otherwise unreadable ZIP file. It cannot be properly checked for security.', whe" [core] - 10https://gerrit.wikimedia.org/r/106657 (owner: 10Pastakhov) [08:51:21] (03CR) 10PleaseStand: "Copied my comments from I4b10f8b8." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/106489 (owner: 10PleaseStand) [08:58:58] (03CR) 10Legoktm: [C: 032] "Lets see what breaks :)" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106555 (owner: 10Nemo bis) [08:59:57] yay, let's [09:01:21] ok, someone just needs to upload something to gerrit. [09:02:44] (03CR) 10Nemo bis: "something" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106555 (owner: 10Nemo bis) [09:02:52] \o/ [09:03:30] (03CR) 10Nemo bis: "comment [test]" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/106666 (owner: 10Legoktm) [09:03:43] looks ok [09:04:28] I'll be around for a bit so we can revert if needed [09:05:51] (03Abandoned) 10Nemo bis: Add gerritfeed-wm for a full feed relayed to IRC [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/87663 (owner: 10Nemo bis) [09:08:31] (03CR) 10Santhosh: [C: 032] Set defaultrebase=0 in .gitreview [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/106655 (owner: 10KartikMistry) [09:08:40] (03Merged) 10jenkins-bot: Set defaultrebase=0 in .gitreview [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/106655 (owner: 10KartikMistry) [09:09:26] (03Abandoned) 10Santhosh: Added ext.uls.compactlinks.js as a Resource Loader module [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/103218 (owner: 10Niharika29) [09:09:34] (03PS1) 10Hashar: Wikibase lint now just vote +1 [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/106667 [09:09:47] (03CR) 10Hashar: [C: 032] Wikibase lint now just vote +1 [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/106667 (owner: 10Hashar) [09:09:51] (03Merged) 10jenkins-bot: Wikibase lint now just vote +1 [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/106667 (owner: 10Hashar) [09:10:17] (03CR) 10Santhosh: [C: 032] Set defaultrebase=0 in .gitreview [extensions/Translate] - 10https://gerrit.wikimedia.org/r/106656 (owner: 10KartikMistry) [09:11:28] (03Merged) 10jenkins-bot: Set defaultrebase=0 in .gitreview [extensions/Translate] - 10https://gerrit.wikimedia.org/r/106656 (owner: 10KartikMistry) [09:18:24] (03CR) 10Gilles: Improve the test coverage to also check prev/next scroll (035 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106560 (owner: 10Gilles) [09:24:08] (03CR) 10Gilles: "In fact, regarding Aaron's comment on the redundant return, it's rather that I was returning the wrong value in the update case, as seen h" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106560 (owner: 10Gilles) [09:27:02] (03PS2) 10Gilles: Improve the test coverage to also check prev/next scroll [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106560 [09:31:46] (03CR) 10Santhosh: [C: 032] composer.json [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106525 (owner: 10Nikerabbit) [09:31:49] (03Merged) 10jenkins-bot: composer.json [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106525 (owner: 10Nikerabbit) [09:37:00] https://www.mediawiki.org/wiki/Talk:Beta_Features/Nearby_Pages#Latest_update_breaks_navboxes [09:51:37] (03CR) 10Parent5446: [C: 032] Add ability to mark hooks as deprecated [core] - 10https://gerrit.wikimedia.org/r/106436 (owner: 10Aude) [09:54:49] (03Merged) 10jenkins-bot: Add ability to mark hooks as deprecated [core] - 10https://gerrit.wikimedia.org/r/106436 (owner: 10Aude) [10:03:20] (03CR) 10SG: [C: 04-1] "This is making me discover an inherent bug in Flow: it should not be using textarea.click to handle this event. The problem with this is t" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106275 (owner: 10Matthias Mullie) [10:03:21] (03CR) 10SG: [C: 04-1] "This is making me discover an inherent bug in Flow: it should not be using textarea.click to handle this event. The problem with this is t" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106275 (owner: 10Matthias Mullie) [10:05:34] (03PS6) 10Henning Snater: Always display "In other languages" section [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106257 [10:09:09] Nemo_bis: hmmmm^ [10:09:31] some repos are excluded from here, but the new regex will make them show up here [10:09:38] and Flow is double counted now I guess [10:10:03] (03CR) 10Gilles: "I've done some research to see what other large web properties do. The interesting ones:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/97919 (owner: 10Gergő Tisza) [10:11:29] O_o [10:12:03] that should be easy to fix, remove the overlapping regexes [10:14:06] dunno about the exclusions [10:14:08] (03PS1) 10Nemo bis: Avoid double posting to #wikimedia-dev [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106670 [10:14:12] legoktm: ^ [10:14:53] I guess we could write a regex that doesn't match all the extensions? [10:15:02] crossposting doesn't seem to be an issue, it was already done for some repos [10:15:20] I doubt you people want all the stuff we do in #wikidata here [10:15:31] maybe but I'm doing something now and that looks a bit ugly/long [10:15:47] dunno hoo [10:15:58] yeah, I can't think of a not-ugly way to do it [10:17:42] (03CR) 10Dzahn: [C: 032 V: 032] Fix a small typo in Bugzilla's sudo function [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106633 (owner: 10Aklapper) [10:22:17] the double posting is easy though [10:28:56] (03PS1) 10Dzahn: fix leading spaces, tab levels in footer [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106671 [10:33:20] (03PS1) 10Marcoil: Keep track of known commits, tell rt clients to restart if using old version [services/parsoid] - 10https://gerrit.wikimedia.org/r/106672 [10:36:43] (03CR) 10Gilles: [V: 04-1] "Some of the tests fail for me: http://pastebin.com/txapD3fb" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [10:36:44] (03CR) 10Gilles: [V: 04-1] "Some of the tests fail for me: http://pastebin.com/txapD3fb" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [10:40:26] (03CR) 10Legoktm: [C: 032] Avoid double posting to #wikimedia-dev [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106670 (owner: 10Nemo bis) [10:42:08] (03PS2) 10Dzahn: fix leading spaces, tab levels in footer [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106671 [10:44:24] (03CR) 10KartikMistry: [C: 032] "LGTM." [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106500 (owner: 10Santhosh) [10:44:28] (03Merged) 10jenkins-bot: Page layout, grid, base css framework [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106500 (owner: 10Santhosh) [10:44:40] (03PS1) 10TheDJ: Enable ACE webworkers [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/106673 [10:44:45] (03PS3) 10Dzahn: fix leading spaces, tab levels in footer [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106671 [10:46:54] (03PS7) 10Tobias Gritschacher: Always display "In other languages" section [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106257 (owner: 10Henning Snater) [10:48:00] (03CR) 10Zfilipin: "Niklas, I do not see any failed tests:" [extensions/Translate] - 10https://gerrit.wikimedia.org/r/104925 (owner: 10Amire80) [10:49:22] Nemo_bis: I filed https://bugzilla.wikimedia.org/show_bug.cgi?id=59900, going to sleep now. [10:50:06] good night [10:50:18] (yes, no emergencies) [10:50:20] (03CR) 10Nikerabbit: "Yes there was an issue which prevented latest code getting to Sandbox which was fixed." [extensions/Translate] - 10https://gerrit.wikimedia.org/r/104925 (owner: 10Amire80) [10:52:34] (03CR) 10Hoo man: [C: 04-1] "also needs a manual rebase and an announcement" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96232 (owner: 10Jens Ohlig) [10:58:54] (03PS2) 10TheDJ: Use page ContentModel to choose editor language [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104721 [10:59:04] (03CR) 10TheDJ: Use page ContentModel to choose editor language (031 comment) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104721 (owner: 10TheDJ) [11:00:29] (03CR) 10Dzahn: [C: 032 V: 032] "as stated above, since this modified an upstream file it is freshly added to this repo, but the actual diff applied is just our hack:" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/90546 (owner: 10Aklapper) [11:00:35] (03PS1) 10Tpt: Fix i18n message error in Page: pages diff [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/106674 [11:00:46] (03CR) 10KartikMistry: "(minor) inline comments." (033 comments) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106661 (owner: 10Santhosh) [11:01:07] (03CR) 10Tpt: [C: 032] "Very minor change (fix of a typo issue)" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/106674 (owner: 10Tpt) [11:01:13] (03Merged) 10jenkins-bot: Fix i18n message error in Page: pages diff [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/106674 (owner: 10Tpt) [11:10:01] (03CR) 10Dzahn: "Andre, works on kaulen, but we'll need a new version of this for 4.4. diffing attachment.cgi there shows other changes" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/90546 (owner: 10Aklapper) [11:23:05] (03PS1) 10Siebrand: Revert "Localisation updates from https://translatewiki.net." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106675 [11:23:24] (03PS1) 10Addshore: Fix Undefined Index and array_merge warning in Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106676 [11:23:37] (03CR) 10Aarcos: [C: 032] "LGTM, thanx for the tests !" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106560 (owner: 10Gilles) [11:23:40] (03CR) 10Siebrand: [C: 032] "Some changes got made to qqq that shouldn't have. Going to repeat the updates and export, and see if the incorrect changes persist." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106675 (owner: 10Siebrand) [11:23:42] (03Merged) 10jenkins-bot: Revert "Localisation updates from https://translatewiki.net." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106675 (owner: 10Siebrand) [11:24:11] (03Merged) 10jenkins-bot: Improve the test coverage to also check prev/next scroll [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/106560 (owner: 10Gilles) [11:24:43] (03CR) 10Addshore: [C: 04-1] "unwanted changes got dragged into this" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106676 (owner: 10Addshore) [11:27:38] (03CR) 10Yuvipanda: "This should probably be reverted, since this re-clutters -dev again and also makes the rest of the mediawiki/ entries under wikimedia-dev " [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106555 (owner: 10Nemo bis) [11:27:45] (03PS2) 10Addshore: Fix Undefined Index and array_merge warning in Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106676 [11:28:30] (03CR) 10Yuvipanda: "The way to implement -feed is to make a change to grrrit-wm that also sends a raw feed there." [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106555 (owner: 10Nemo bis) [11:29:07] (03CR) 10Hoo man: [C: 032] Fix Undefined Index and array_merge warning in Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106676 (owner: 10Addshore) [11:29:14] (03PS1) 10Yuvipanda: Revert "Setup/restore #mediawiki-feed" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106680 [11:29:17] (03CR) 10jenkins-bot: [V: 04-1] Revert "Setup/restore #mediawiki-feed" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106680 (owner: 10Yuvipanda) [11:29:23] (03Merged) 10jenkins-bot: Fix Undefined Index and array_merge warning in Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106676 (owner: 10Addshore) [11:30:36] (03CR) 10Siebrand: "Tyler, can you please consider merging this?" [core] - 10https://gerrit.wikimedia.org/r/103890 (owner: 10Siebrand) [11:33:38] (03PS2) 10Yuvipanda: Revert "Setup/restore #mediawiki-feed" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106680 [11:33:45] (03CR) 10Nemo bis: "I never heard complaints of #wikimedia-dev being cluttered due to MediaWiki extensions, what do you mean? Maybe you can explain on bug 599" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106555 (owner: 10Nemo bis) [11:34:13] (03PS3) 10Nemo bis: Revert "Setup/restore #mediawiki-feed" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106680 (owner: 10Yuvipanda) [11:34:39] (03CR) 10Yuvipanda: [C: 032 V: 032] Revert "Setup/restore #mediawiki-feed" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106680 (owner: 10Yuvipanda) [11:34:54] Nemo_bis: I'm implementing the 'raw-channel' now [11:35:02] (03CR) 10Nemo bis: "Do you mean https://gerrit.wikimedia.org/r/87663 should be (restored and) merged?" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106680 (owner: 10Yuvipanda) [11:39:23] (03PS1) 10Yuvipanda: Add support for a Firehose Channel that gets *all* changes [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106681 [11:39:26] (03CR) 10jenkins-bot: [V: 04-1] Add support for a Firehose Channel that gets *all* changes [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106681 (owner: 10Yuvipanda) [11:39:39] (03PS2) 10Yuvipanda: Add support for a Firehose Channel that gets *all* changes [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106681 [11:41:45] (03CR) 10Parent5446: [C: 032] Update documentation for database related classes [core] - 10https://gerrit.wikimedia.org/r/103890 (owner: 10Siebrand) [11:41:52] (03CR) 10Parent5446: [C: 032] Remove superfluous spaces and doc tweak [core] - 10https://gerrit.wikimedia.org/r/105931 (owner: 10Siebrand) [11:42:12] Nemo_bis: hmm, even you aren't there in -feed? [11:42:30] (03CR) 10Parent5446: [C: 032] Specify DBMasterPos::getMasterPos() [core] - 10https://gerrit.wikimedia.org/r/105727 (owner: 10Siebrand) [11:44:35] (03CR) 10Parent5446: [C: 032] Ensure variables in database classes are defined, used and correctly cased [core] - 10https://gerrit.wikimedia.org/r/105722 (owner: 10Siebrand) [11:44:37] (03CR) 10Parent5446: [C: 032] Update formatting [core] - 10https://gerrit.wikimedia.org/r/105728 (owner: 10Siebrand) [11:44:41] (03CR) 10Yuvipanda: "Reimplemented in Ia7ef98f2146781c073ba09d9bef53cd4147e5903" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/87663 (owner: 10Nemo bis) [11:45:01] YuviPanda: why would I, I only want the log for now; I lost any hopes for #wikimedia-dev to be useful [11:45:07] heh [11:45:12] (03Merged) 10jenkins-bot: Update documentation for database related classes [core] - 10https://gerrit.wikimedia.org/r/103890 (owner: 10Siebrand) [11:45:13] (03CR) 10Parent5446: [C: 032] Rename $desired_schema to $desiredSchema [core] - 10https://gerrit.wikimedia.org/r/105723 (owner: 10Siebrand) [11:45:37] andre__: PNG attachments fixed [11:45:40] (03CR) 10Parent5446: [C: 032] Make tableNamesWithUseIndexOrJOIN() and makeUpdateOptions() protected [core] - 10https://gerrit.wikimedia.org/r/105724 (owner: 10Siebrand) [11:45:57] (03Merged) 10jenkins-bot: Remove superfluous spaces and doc tweak [core] - 10https://gerrit.wikimedia.org/r/105931 (owner: 10Siebrand) [11:45:57] mutante, thanks, I'll port to 4.4 later or next week [11:46:05] andre__: awesome:) thx [11:46:38] (03PS3) 10Yuvipanda: Add support for a Firehose Channel that gets *all* changes [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106681 [11:47:49] (03CR) 10Parent5446: [C: 032] Return correct values and types [core] - 10https://gerrit.wikimedia.org/r/105725 (owner: 10Siebrand) [11:48:20] (03CR) 10Yuvipanda: "Reimplemented in Ia7ef98f2146781c073ba09d9bef53cd4147e5903" [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106680 (owner: 10Yuvipanda) [11:50:00] (03PS4) 10Yuvipanda: Add support for a Firehose Channel that gets *all* changes [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106681 [11:51:46] (03PS5) 10Yuvipanda: Add support for a Firehose Channel that gets *all* changes [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106681 [11:51:56] (03CR) 10Parent5446: [C: 04-1] $serverIndex can be an array, so print_r() it (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105726 (owner: 10Siebrand) [11:52:42] (03CR) 10Yuvipanda: [C: 032 V: 032] Add support for a Firehose Channel that gets *all* changes [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106681 (owner: 10Yuvipanda) [11:53:18] Nemo_bis: ^ [11:53:18] done [11:53:48] logging back in authenticated [11:54:21] (03CR) 10jenkins-bot: [V: 04-1] Specify DBMasterPos::getMasterPos() [core] - 10https://gerrit.wikimedia.org/r/105727 (owner: 10Siebrand) [11:54:24] (03CR) 10jenkins-bot: [V: 04-1] Update formatting [core] - 10https://gerrit.wikimedia.org/r/105728 (owner: 10Siebrand) [11:54:28] Nemo_bis: let me know if it breaks or somesuch [11:55:00] oki, thanks :) [11:55:43] Nemo_bis: yw. Sorry I couldn't do that earlir [11:55:44] (03PS1) 10Yuvipanda: Have corefeatures repos post to both -dev & -corefeatures [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106682 [11:55:45] *earlier [11:55:56] (03CR) 10Yuvipanda: [C: 032 V: 032] Have corefeatures repos post to both -dev & -corefeatures [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106682 (owner: 10Yuvipanda) [11:57:06] okay, that should do it [11:58:42] (03Merged) 10jenkins-bot: Ensure variables in database classes are defined, used and correctly cased [core] - 10https://gerrit.wikimedia.org/r/105722 (owner: 10Siebrand) [11:58:44] (03Merged) 10jenkins-bot: Rename $desired_schema to $desiredSchema [core] - 10https://gerrit.wikimedia.org/r/105723 (owner: 10Siebrand) [12:04:26] (03CR) 10Parent5446: [C: 032] "Re-try" [core] - 10https://gerrit.wikimedia.org/r/105727 (owner: 10Siebrand) [12:05:51] (03CR) 10jenkins-bot: [V: 04-1] Make tableNamesWithUseIndexOrJOIN() and makeUpdateOptions() protected [core] - 10https://gerrit.wikimedia.org/r/105724 (owner: 10Siebrand) [12:05:53] (03CR) 10jenkins-bot: [V: 04-1] Return correct values and types [core] - 10https://gerrit.wikimedia.org/r/105725 (owner: 10Siebrand) [12:09:02] Could someone tell me where I can find the bug mentioned in https://bugzilla.wikimedia.org/show_bug.cgi?id=45771 in the code? [12:09:05] (03Merged) 10jenkins-bot: Specify DBMasterPos::getMasterPos() [core] - 10https://gerrit.wikimedia.org/r/105727 (owner: 10Siebrand) [12:09:51] (03Merged) 10jenkins-bot: Update formatting [core] - 10https://gerrit.wikimedia.org/r/105728 (owner: 10Siebrand) [12:19:57] (03CR) 10Siebrand: $serverIndex can be an array, so print_r() it (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105726 (owner: 10Siebrand) [12:21:25] (03CR) 10Siebrand: [C: 032] "Adding another +2. misc unit tests failed on checkout." [core] - 10https://gerrit.wikimedia.org/r/105724 (owner: 10Siebrand) [12:24:39] arav93_: I think it would be in somewhere includes/WatchedItem.php [12:24:40] (03Merged) 10jenkins-bot: Make tableNamesWithUseIndexOrJOIN() and makeUpdateOptions() protected [core] - 10https://gerrit.wikimedia.org/r/105724 (owner: 10Siebrand) [12:24:49] (03CR) 10Aklapper: [C: 031] "Do whatever you want, I need to completely rewrite fscking mess anyway at some point: https://bugzilla.wikimedia.org/show_bug.cgi?id=59889" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106671 (owner: 10Dzahn) [12:25:25] (03Merged) 10jenkins-bot: Return correct values and types [core] - 10https://gerrit.wikimedia.org/r/105725 (owner: 10Siebrand) [12:26:37] I have a JavaScript that I want to run on a Special page, do I have to load it in the console to get it to run or is there a way I can make it run on special pages automatically? [12:43:21] (03PS1) 10TheDJ: [Do not merge] CodeEditor should not load WikiEditor if disabled [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/106685 [12:56:14] (03PS1) 10Siebrand: Fix invalid JSON [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106686 [12:56:53] (03CR) 10Siebrand: [C: 032] Fix invalid JSON [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106686 (owner: 10Siebrand) [12:56:55] (03Merged) 10jenkins-bot: Fix invalid JSON [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106686 (owner: 10Siebrand) [13:00:11] (03CR) 10Siebrand: "Fixed. Caused by invalid JSON. bs in, bs out. Stupid syntax ;)." (032 comments) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106511 (owner: 10L10n-bot) [13:02:17] (03PS1) 10Matthias Mullie: Add more AbuseFilter vars [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106688 [13:03:14] (03CR) 10Siebrand: [C: 032] Localisation updates from https://translatewiki.net. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106687 (owner: 10L10n-bot) [13:03:17] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106687 (owner: 10L10n-bot) [13:17:00] (03CR) 10Aklapper: [C: 04-1] "Please update the commit message (see http://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines ) by explaining which problem your ch" [core] - 10https://gerrit.wikimedia.org/r/106657 (owner: 10Pastakhov) [13:29:09] (03CR) 10Aarcos: [C: 04-1] Solves visibility issue on the progress bar (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105694 (owner: 10Gilles) [13:29:39] (03PS1) 10Matthias Mullie: Parse error messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106690 [13:47:18] qchris: hi! Seems you added some code in Gerrit to let us rename repositories https://gerrit.wikimedia.org/r/#/q/project:gerrit+branch:wmf+topic:rename-project,n,z [13:47:27] qchris: do you happen to know whether that got upstreamed? [13:47:34] It didn't [13:47:36] :-( [13:47:51] They did not really comment on my first approach. [13:47:58] is that because you lacked time to babysit it or that upstream rejected it ? [13:48:02] ahh [13:48:17] After some time I rebased everything and incorporated the little feedback. But it did not go in :-( [13:48:32] damn upstream [13:48:40] need to send Chad @ Googleplex to rant about it [13:48:40] Users want to have this feature (not just us) [13:48:47] But upstream feels it's too complicated. [13:48:57] that is a pity [13:48:57] Totally! [13:49:10] maybe I will be able to convince OpenStack to rewrite Gerrit to python [13:49:16] Hahaha. [13:49:17] to/in [13:49:29] Python to rule the world! [13:49:38] would you mind commenting back on https://bugzilla.wikimedia.org/show_bug.cgi?id=47554#c4 ? [13:49:47] though that is a bug related to " move mediawiki/rcsub.git under mediawiki/tools " [13:49:52] maybe I should fill in another bug [13:50:09] * qchris reads the bug [13:51:07] I'll comment on the bug. [13:53:18] thank you [14:07:39] (03PS1) 10TheDJ: CodeEditor: Add basic code completion and snippet support [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/106693 [14:08:14] yeah baby ^^ [14:09:00] thedj[work]: Missing spaces :P [14:09:11] ({ -> ( { [14:09:23] ah [14:10:06] (03PS2) 10TheDJ: CodeEditor: Add basic code completion and snippet support [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/106693 [14:11:40] (03PS3) 10TheDJ: CodeEditor: Add basic code completion and snippet support [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/106693 [14:11:45] and lets not mix comment styles :D [14:28:05] (03Abandoned) 10Jeroen De Dauw: Remove no longer applicable Wikibase jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/106498 (owner: 10Jeroen De Dauw) [14:45:04] (03CR) 10Gilles: Solves visibility issue on the progress bar (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105694 (owner: 10Gilles) [14:45:42] (03PS1) 1001tonythomas: Increased the number of rows in AbuseFilter's Filter testing textarea [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/106699 [14:51:02] (03CR) 10Siebrand: Changed temporary password system to use tokens. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106218 (owner: 10Parent5446) [14:52:04] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/106218 (owner: 10Parent5446) [14:54:50] (03PS1) 10Gilles: Solves visibility issue on the progress bar [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106704 [14:57:55] (03PS1) 10Hashar: Wikibase: drop test pipeline / do lint on gate [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/106705 [14:58:01] (03CR) 10Hashar: [C: 032] Wikibase: drop test pipeline / do lint on gate [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/106705 (owner: 10Hashar) [14:58:05] (03Merged) 10jenkins-bot: Wikibase: drop test pipeline / do lint on gate [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/106705 (owner: 10Hashar) [14:58:27] (03PS3) 10Gilles: Solves visibility issue on the progress bar [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105694 [14:59:06] (03PS11) 10Gergő Tisza: Add blacklisting feature for flickr in backend [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [14:59:13] (03CR) 10jenkins-bot: [V: 04-1] Add blacklisting feature for flickr in backend [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [14:59:24] (03CR) 10Gilles: [C: 04-1 V: 04-1] "Ignore this changeset, it's a dupe created by mistake" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106704 (owner: 10Gilles) [15:05:31] (03PS12) 10Gergő Tisza: Add blacklisting feature for flickr in backend [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [15:05:38] (03CR) 10jenkins-bot: [V: 04-1] Add blacklisting feature for flickr in backend [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [15:07:28] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106489 (owner: 10PleaseStand) [15:14:23] (03CR) 10Siebrand: [C: 032] Fixed silly doc typos [core] - 10https://gerrit.wikimedia.org/r/106654 (owner: 10Aaron Schulz) [15:17:17] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/106322 (owner: 10Jackmcbarn) [15:17:43] (03Merged) 10jenkins-bot: Fixed silly doc typos [core] - 10https://gerrit.wikimedia.org/r/106654 (owner: 10Aaron Schulz) [15:18:24] win 2 [15:24:28] (03CR) 10PleaseStand: WebInstaller: Don't call getSoftwareLink() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106489 (owner: 10PleaseStand) [15:30:00] (03CR) 10Anomie: "Your TTL stuff is drifting rather far off topic here, as it's entirely unrelated to this change." [core] - 10https://gerrit.wikimedia.org/r/99792 (owner: 10Anomie) [15:33:15] (03PS1) 10Aklapper: Set product parameter in guided bug entry form link on enter_bug.cgi [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106710 [15:34:39] (03CR) 10Aklapper: [C: 031] "Successfully tested on boogs.wmflabs.org, can go in directly (plus file is the same in 4.2 and 4.4)" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106710 (owner: 10Aklapper) [15:37:25] (03PS1) 10Gilles: Fix the i18n source string for the chunked preference [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 [15:40:00] !logs [15:40:00] channel logs: http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki/ html version: http://tools.wmflabs.org/wm-bot/logs/index.php?display=%23mediawiki [15:41:04] (03CR) 10Siebrand: "Inline comment." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106489 (owner: 10PleaseStand) [15:43:41] (03CR) 10Anomie: [C: 032] "Looks good, works locally (including when I create a .css page with content model wikitext). Keeping the BC until the 1.23 release doesn't" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104721 (owner: 10TheDJ) [15:43:43] (03Merged) 10jenkins-bot: Use page ContentModel to choose editor language [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104721 (owner: 10TheDJ) [15:49:41] (03PS1) 10Aklapper: [4.4] Apply custom changes to attachment.cgi [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106713 [15:51:04] (03CR) 10Aklapper: "Version for 4.4: https://gerrit.wikimedia.org/r/#/c/106713/" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/90546 (owner: 10Aklapper) [15:51:31] (03CR) 10Aarcos: "I will let Mark comment on the correctness of this change since he introduced most of the code in" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105694 (owner: 10Gilles) [15:55:53] (03CR) 10Dzahn: "confirmed on 4.4/zirconium. it's also just the diff with our hack as it was for 4.2 in https://gerrit.wikimedia.org/r/#/c/90546/" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106713 (owner: 10Aklapper) [15:58:47] (03CR) 10Dzahn: [C: 032 V: 032] Set product parameter in guided bug entry form link on enter_bug.cgi [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106710 (owner: 10Aklapper) [16:04:34] (03Abandoned) 10Tim Landscheidt: Define labs-toollabs-debbuild separately [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/104964 (owner: 10Tim Landscheidt) [16:04:37] (03PS1) 10Cscott: Update `mocha` and `request` dependencies. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/106718 [16:04:39] (03PS1) 10Cscott: Add --no-compat option to avoid pediapress compatibility overhead. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/106719 [16:09:49] (03PS1) 10Manybubbles: Start getting PhantomJS working for tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106720 [16:13:35] (03CR) 10BryanDavis: "Thanks for fixing this Siebrand." (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106511 (owner: 10L10n-bot) [16:17:03] (03PS2) 10Umherirrender: Make a single # an invalid title in php and js [core] - 10https://gerrit.wikimedia.org/r/106561 [16:20:14] (03CR) 10Dzahn: "deployed on kaulen and zirconium" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106710 (owner: 10Aklapper) [16:39:14] (03PS8) 10UltrasonicNXT: Consistency tweaks in preparatation for adding extension to translatewiki.net [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/102679 (owner: 10Raimond Spekking) [16:39:59] (03CR) 10UltrasonicNXT: [C: 032 V: 032] "Well this is fine to me, and has no-one else has commented in a while, I'm submitting it." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/102679 (owner: 10Raimond Spekking) [16:58:03] (03CR) 10Cscott: [C: 032] Update `mocha` and `request` dependencies. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/106718 (owner: 10Cscott) [16:58:14] (03CR) 10Cscott: [C: 032] Add --no-compat option to avoid pediapress compatibility overhead. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/106719 (owner: 10Cscott) [16:59:36] (03CR) 10Rtdwivedi: [C: 031] "I think the code is fine but I suggest amending the commit message to include the point that this change introduces the use of namespaces " [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97295 (owner: 10Tpt) [17:00:39] (03PS4) 10Tpt: Explode ProofreadPageRenderer into smaller not static classes [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97295 [17:00:58] (03PS1) 10Jackmcbarn: Don't use deprecated link call [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/106732 [17:01:09] (03CR) 10Tpt: [C: 032] "Reviewed by Aarti" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97295 (owner: 10Tpt) [17:01:14] (03Merged) 10jenkins-bot: Explode ProofreadPageRenderer into smaller not static classes [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97295 (owner: 10Tpt) [17:01:57] (03Merged) 10jenkins-bot: Update `mocha` and `request` dependencies. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/106718 (owner: 10Cscott) [17:01:59] (03Merged) 10jenkins-bot: Add --no-compat option to avoid pediapress compatibility overhead. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/106719 (owner: 10Cscott) [17:04:08] (03CR) 10Rtdwivedi: [C: 031] Adds a label for Page: pages content [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101678 (owner: 10Tpt) [17:04:34] (03CR) 10Tpt: [C: 032] "Reviewed by Aarti" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101678 (owner: 10Tpt) [17:04:39] (03Merged) 10jenkins-bot: Adds a label for Page: pages content [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101678 (owner: 10Tpt) [17:20:06] (03CR) 10Brian Wolff: "On the php side (in the preferences part) this should probably be run through formatNum, or perhaps be instead specified in bytes and run " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 (owner: 10Gilles) [17:25:20] (03CR) 10Gilles: "$wgLang->formatSize looks like the right one, I'll give it a try" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 (owner: 10Gilles) [17:28:49] !easy [17:28:50] Bugzilla maintains a list of easy bugs for us, that are considered a good first step for new MediaWiki developers. See https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=keyword%3Aeasy for the list. [17:33:56] (03PS2) 10Gilles: Fix the i18n source string for the chunked preference [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106711 [17:34:28] (03PS2) 1001tonythomas: Increased the number of rows in AbuseFilter's Filter testing textarea [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/106699 [17:36:30] Am I doing something wrong? var watchtoken = mw.user.tokens.get( 'watchToken' ); doesn't seem to be returning a valid token.' [17:37:29] Hey bawolff [17:37:38] Am I doing something wrong? var watchtoken = mw.user.tokens.get( 'watchToken' ); doesn't seem to be returning a valid token. [17:37:51] I tried var api = new mw.Api(); var watchtoken = api.get( { action: 'tokens', type: 'watch' } ); too, and that just crashed the script. [17:38:20] that looks right [17:38:32] (03CR) 10Jdlrobson: "I'm really disappointed this change got rushed through." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106148 (owner: 10Kaldari) [17:38:47] There used to be a complication where watchtokens were different for the api then in the user interface, but I'm not sure if that's true anymore [17:39:07] https://en.wikipedia.org/w/index.php?title=User%3ATechnical_13%2FSandBox%2FACCHelp.js&diff=590099089&oldid=590096902 [17:39:54] that change crashed the script (I forgot to pull up the console and it's tough testing scripts on pages that can't be reloaded). [17:40:32] All the script is suppose to do is add a simple watch link so that I don't have to navigate to the user's page to watch it... [17:41:03] Is the token needed if I go through index.php? [17:41:50] * bawolff checks [17:42:58] Technical_13: via the index.php route, the token changes for every page [17:43:39] Technical_13: Where in the api it uses the same token for all requests [17:43:49] so you can't use the api token with index.php [17:44:12] so, yes, it needs a token and I couldn't just make a static //en.wikipedia.org/wiki/index.php?title=User:$1&action=watch [17:44:14] I guess this is because index.php tends to have the token stored as a GET parameter, which tends to get in log files [17:44:51] yeah [17:45:32] Thanks. I'll play around with it some more... [17:45:54] (If you're curious, line 69 of includes/actions/WatchAction.php vs line 98 of includes/api/ApiWatch.php [17:46:29] That's in the Github repo, right? [17:47:13] somewhere in github. I'm looking at my local download [17:48:01] also at https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/includes%2Factions%2FWatchAction.php#L69 [17:48:02] (03PS2) 10Jdlrobson: Reflect upstream changes [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106305 [17:48:25] (03Abandoned) 10Jdlrobson: Reflect upstream changes [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106305 (owner: 10Jdlrobson) [17:49:17] (03PS1) 10Jdlrobson: Make italics within blockquotes normal to make them distinguisable [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106736 [17:50:24] (03CR) 10Jdlrobson: "Please do not rush merge this. I'm simply showing had we not rush merged the last change we could have worked out other solutions." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106736 (owner: 10Jdlrobson) [17:51:20] (03PS1) 10Jackmcbarn: Autoaccept reverts to the last stable revision [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/106737 [17:51:39] Technical_13: You might also be interested in the watch method of the mw.Api class [17:52:16] Where can I find more documentation on that? What I tried based on what I found crashed the script all together... [17:54:10] (03CR) 10Krinkle: Make a single # an invalid title in php and js (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender) [17:54:11] Something along the lines of var api = new mw.Api(); api.watch( 'Food', function() {alert('ok')}, function () {alert('error')} ); [17:54:30] * bawolff awaits the people who actually are good at js to come and tell me I did that wrong :) [17:54:38] lol [17:55:41] api.watch( '`pagename`') then it seems should do it... [17:56:13] bawolff: Use promise.done() and promise.fail() instead of watch( ..., function ok, function err ) [17:57:56] Krinkle: :) [17:58:11] api.watch( 'Food' ).done( function () { .. } ) [17:58:26] or if you just want a callback always, watch( 'food' ).always( function () { } ) [17:58:35] or indeed separate .done().fail() [17:58:38] :) [18:02:54] (03PS1) 10Siebrand: Call Linker::link statically (1.18) [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/106739 [18:04:49] (03PS1) 10Siebrand: Call Linker::link statically (1.18) [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/106740 [18:06:57] (03PS1) 10Siebrand: Call Linker::link statically (1.18) [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/106741 [18:07:43] (03PS1) 10Siebrand: Call Linker::link statically (1.18) [extensions/Interlanguage] - 10https://gerrit.wikimedia.org/r/106742 [18:10:17] (03PS1) 10Siebrand: Call Linker::link statically (1.18) [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/106743 [18:11:37] (03PS1) 10Siebrand: Remove pre-1.18 compatibility note for Linker::link [core] - 10https://gerrit.wikimedia.org/r/106745 [18:12:03] (03PS1) 10Siebrand: Call Linker::link statically (1.18) [extensions/SelectCategory] - 10https://gerrit.wikimedia.org/r/106746 [18:12:05] Krinkle: How would I write it to just return the token? var tokenAPIwatch = api.watch( 'mw.config.get(wgPagename")' ).always(return data); [18:12:35] var tokenAPIwatch = api.watch( 'mw.config.get("wgPagename")' ).always(return data);//fixed missing quote [18:14:13] Technical_13: It is an asynchronous method, by design you cannot do an assignment like that [18:14:27] Also, what value do you expect to yield? [18:14:37] .watch() doesn't provide a token, that's an internal system. [18:15:01] https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Api.plugin.watch-method-watch [18:15:16] You can get 2 pieces of data from the .done() handler [18:15:19] - message: [18:15:23] - watched {boolean} [18:15:34] which will indicate whether you switched from watched to unwatched, or from unwatched to watched. [18:15:35] Then that's not what I need... [18:15:37] oh cool, we have auto-generated docs for js? That should be advertised more widely [18:15:55] bawolff: Still a work in progress, but yes, getting there. [18:16:06] I just need to get a watch token so that I can create a (un)watch link on a page. [18:16:09] They are referenced from https://www.mediawiki.org/wiki/RL/DM [18:16:16] Technical_13: Why would you do that? [18:17:03] Because when I create accounts, it is a pain to navigate from the password has been mailed special page, to the user page to watch it... [18:17:13] (03PS2) 10Siebrand: Call Linker::[user]link statically (1.19) [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/106739 [18:17:16] ? [18:17:21] I just want to add a link next to the username on the user created page. [18:17:24] I have no idea what that means [18:17:44] (03PS1) 10Anomie: Add ability to have additional renderer settings [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/106749 [18:17:44] If you're within javascript execution, you can just use mw.Api#watch, no need to deal with any tokens. [18:19:13] (03PS1) 10Siebrand: Call Linker::link statically (1.18) [extensions/ArticleFeedback] - 10https://gerrit.wikimedia.org/r/106750 [18:19:15] Hey ! Can we directly clone the wikimedia-bugzilla-modifications to submit a patch ? [18:19:24] So I would create a dummy link "#" and set up an onClick handler that would mw.Api#watch a page (not the page I am on)? [18:19:25] or is there another way ? [18:19:39] tonythomas01: They definitely should be somewhere [18:19:44] that's clonable [18:19:51] (03CR) 10GWicke: "Is it? Could you explain the difference?" [core] - 10https://gerrit.wikimedia.org/r/99792 (owner: 10Anomie) [18:20:08] I want to be able to watch User:Foo from Special:Userlogin [18:20:15] Technical_13: Yes, any