[00:00:00] (03PS1) 10Aaron Schulz: Fixed minor unit test dir leakage [core] - 10https://gerrit.wikimedia.org/r/106461 [00:01:23] (03PS1) 10MarkTraceur: Fix MultimediaViewer EventLogging code [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/106462 [00:03:20] (03CR) 10MarkTraceur: [C: 032] Fix MultimediaViewer EventLogging code [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/106462 (owner: 10MarkTraceur) [00:07:54] (03PS1) 10MarkTraceur: Fix MultimediaViewer EventLogging code [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106463 [00:09:06] (03CR) 10MarkTraceur: [C: 032 V: 032] Fix MultimediaViewer EventLogging code [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106463 (owner: 10MarkTraceur) [00:10:12] (03PS1) 10Bsitu: Temporarily add obsolete columns to $allowUpateColumns [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106464 [00:12:28] (03CR) 10MaxSem: [C: 032 V: 032] Update Collection to master tip [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106459 (owner: 10MaxSem) [00:12:45] (03CR) 10MaxSem: [C: 032 V: 032] Update Collection to master tip [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/106456 (owner: 10MaxSem) [00:19:39] (03CR) 10BryanDavis: [C: 032] Fixed minor unit test dir leakage [core] - 10https://gerrit.wikimedia.org/r/106461 (owner: 10Aaron Schulz) [00:22:07] (03PS1) 10EBernhardson: Utilize Post::getRootPost instead of TreeRepository [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106466 [00:23:17] (03PS1) 10MaxSem: Revert "Update Collection to master tip" [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/106467 [00:23:28] (03CR) 10MaxSem: [C: 032 V: 032] Revert "Update Collection to master tip" [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/106467 (owner: 10MaxSem) [00:24:03] (03Merged) 10jenkins-bot: Fixed minor unit test dir leakage [core] - 10https://gerrit.wikimedia.org/r/106461 (owner: 10Aaron Schulz) [00:25:38] AaronSchulz, csteipp: In what cases (if any) might a revision with rev_parent_id=0 be treated as creating a page? Could this cause the rev_deleted to be ignored? [00:26:22] I ask because I decided to have a go at fixing up https://gerrit.wikimedia.org/r/#/c/18229/10/migrateToRevDel.php and it has to safely deal with all kinds of ridiculous edge cases like this [00:27:04] IIRC $this->output( "Warning: There may be an issue with revision ID {$hiddenRow->hidden_rev_id}. It has rev_parent_id=0 which means that it may be treated as a revision which starts a new page." ); was put there for a reason, but I don't remember what it was [00:27:22] (03CR) 10BryanDavis: [C: 032] Made use of proper backend-fail-store message [core] - 10https://gerrit.wikimedia.org/r/106457 (owner: 10Aaron Schulz) [00:27:39] AaronSchulz may have to answer that one. I don't know off the top of my head. [00:31:07] (03Merged) 10jenkins-bot: Made use of proper backend-fail-store message [core] - 10https://gerrit.wikimedia.org/r/106457 (owner: 10Aaron Schulz) [00:32:49] now trying to test my changes so far and got this while trying to OS a revision: Fatal error: Call to undefined method ChangesList::newFromUser() in /var/www/MediaWiki/Git/extensions/Oversight/HideRevision_body.php on line 158 [00:33:34] (03PS2) 10Ori.livneh: Update EventLogging to master [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/106145 [00:33:42] (03CR) 10Ori.livneh: [C: 032 V: 032] Update EventLogging to master [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/106145 (owner: 10Ori.livneh) [00:34:27] ugh, it's been removed. [00:35:28] guess I need to rebase [00:35:59] well it does work now, sort of. [00:41:08] AaronSchulz: i'm getting a bunch of 'LoadBalancer::reuseConnection: this connection was not opened as a foreign connection' in my logs, is that something to worry about? [00:42:21] the debug logs? not something to worry about really [00:43:19] (03CR) 10Alex Monk: "new patchset incoming" (0314 comments) [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 (owner: 10Alex Monk) [00:43:41] AaronSchulz: ok thanks, was worried we did something wierd in flow with the external db [00:44:10] (03PS1) 10MaxSem: Revert "Update Collection to master tip" [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106470 [00:44:17] (03CR) 10MaxSem: [C: 032 V: 032] Revert "Update Collection to master tip" [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106470 (owner: 10MaxSem) [00:44:18] Krenair: I don't think it affects rev_deleted [00:44:24] (03PS11) 10Alex Monk: (bug 18598) Maintenance script to migrate legacy Oversight data [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 [01:01:29] theopolisme: Hey, sorry to say so, but we're probably pushing the fullscreen release out to next week pending your core patch [01:01:42] * theopolisme groans [01:01:59] It'll go out though! [01:02:04] Couldn't reach Krinkle? [01:02:14] He's been around, he left comments on GitHub even [01:02:33] He seems more interested in technical feedback than licensing thoughts though [01:02:34] ah well [01:02:38] Heh [01:02:39] We'll push him on it later [01:02:48] For now the technical comments seem important enough to delay [01:03:00] Namely? [01:03:56] (By the way, marktraceur, I've been doing just a bit of code review for MultimediaViewer, hope that's okay...) [01:04:31] theopolisme: It has! I love having more reviewers around, especially at a busy time like this [01:04:59] And I did suggest that we'd give you +2 if you kept it up, so it's a good idea regardless [01:05:27] theopolisme: I think Krinkle had a bunch of thoughts about how the code should be structured. He commented on the core patch with a link to his comments IIRC [01:05:48] Yeah, all of those modifications were made a while ago [01:06:35] Mainly in "Rewrite stuff" https://github.com/theopolisme/jquery-fullscreen/commit/590420259fb762b8dd0d51e60e4c245d86d2630a ;) marktraceur [01:07:03] Oh, well. Lol. [01:08:07] (03PS12) 10Alex Monk: (bug 18598) Maintenance script to migrate legacy Oversight data [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 [01:08:22] theopolisme: Then why is he still not happy [01:08:25] Bloody hell. [01:08:46] Bleh. [01:09:46] Maybe he's just busy. I dunno. [01:11:16] (03PS1) 10EBernhardson: Cache requested workflows in UrlGenerator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106475 [01:11:20] Kinda weird that he hasn't replied or anything though. He was active on IRC 5 hrs ago :( [01:12:04] Yeah. [01:12:11] I asked him but he was quiet so I said meh [01:12:18] (03CR) 10Alex Monk: (bug 18598) Maintenance script to migrate legacy Oversight data (033 comments) [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 (owner: 10Alex Monk) [01:12:48] csteipp, I left notes for the rest of the problems with this changeset (that I know about), would appreciate it if you could take a look if/when you get a moment [01:13:32] oh ffs I did it on the previous patch set. [01:14:39] (03CR) 10Alex Monk: "(Same comments, most recent patch set this time)" (033 comments) [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 (owner: 10Alex Monk) [01:18:00] (03PS2) 10Mattflaschen: Remove Special:GettingStarted and notifications [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/106458 [01:27:40] (03CR) 10EBernhardson: [C: 032] Temporarily add obsolete columns to $allowUpateColumns [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106464 (owner: 10Bsitu) [01:27:46] (03Merged) 10jenkins-bot: Temporarily add obsolete columns to $allowUpateColumns [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106464 (owner: 10Bsitu) [01:27:57] (03CR) 10EBernhardson: "oops, actually this might have a problem" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106464 (owner: 10Bsitu) [01:29:02] (03CR) 10EBernhardson: "sigh, already merged :P The worry is we might be setting those to null, and rev_user_text is a 'NOT NULL' field." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106464 (owner: 10Bsitu) [01:29:21] (03PS1) 10EBernhardson: Revert "Temporarily add obsolete columns to $allowUpateColumns" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106477 [01:29:54] (03CR) 10EBernhardson: "re-submit this patch after the train goes out tomorrow, i'm a little woried it might break things. More relevant comments in the related " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106477 (owner: 10EBernhardson) [01:30:01] (03CR) 10EBernhardson: [C: 032] Revert "Temporarily add obsolete columns to $allowUpateColumns" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106477 (owner: 10EBernhardson) [01:30:06] (03Merged) 10jenkins-bot: Revert "Temporarily add obsolete columns to $allowUpateColumns" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106477 (owner: 10EBernhardson) [01:31:12] (03CR) 10CSteipp: [C: 04-1] "Mostly minor stuff and I would have preferred to see some of the refactoring done in separate patches, but working with my testing and see" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/106218 (owner: 10Parent5446) [01:38:46] So I just ran across GitLab again [01:38:53] And apparently it supports public repositories now [01:39:09] Does anyone remember if there were any other problems with it or if we should revisit now? [01:39:25] Eloquence, you were a major part of that conversation IIRC [01:39:37] (https://gitlab.com/gitlab-org/gitlab-ce/blob/master/README.md e.g., is their own hosting site) [01:39:50] I think the biggest part of the problem was it took so much time for everyone to get used to gerrit, that nobody wants to repeat the process [01:39:59] Heh [01:40:13] bawolff: One of the "benefits" of GitLab is IIRC the workflow is very similar to GitHub [01:40:19] So I doubt it would be much of an issue [01:40:20] is gitlab an alternative to gerrit or gitblit? [01:40:32] ori: It's basically a GitHub clone. So both. [01:40:53] Also it may have a CI server, but that can be a totally other conversation. [01:41:01] Especially since it's separate [01:41:15] are there public instances of a scale comparable to us? [01:41:29] I don't see anything on https://www.mediawiki.org/wiki/Git/Gerrit_evaluation#GitLab that isn't marked as no longer true [01:41:51] Interesting. [01:42:21] marktraceur, no strong recollection of gitlab's flaws/strengths. having a more fork/pull request-like process would certainly be worth re-evaluating at some point if it can be done entirely with free software. [01:42:44] I also think Phabricator's code review tooling should probably be re-evaluated at some point as at the very least, there are probably good ideas in there. [01:43:05] I think we should use phabricator, yes [01:43:19] : "New critical vulnerabilities recently discovered in GitLab enable unauthenticated API access, remote code execution, local file inclusion and unauthorized access to private repositories. All users should update GitLab and gitlab-shell immediately." [01:43:25] doesn't inspire a tremendous amount of confidence [01:43:26] (03CR) 10Gergő Tisza: [C: 032] Add support for more Flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx) [01:43:29] that's from november of last year [01:43:34] (03Merged) 10jenkins-bot: Add support for more Flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx) [01:43:49] IIRC there was one big bug we couldn't move forward without them fixing, but it also seemed like it duplicated a lot of stuff we didn't need [01:43:53] tgr: \o/ yay! [01:44:32] marktraceur: but the stakes have changed; it's enough that a platform would be our choice if we were starting out now. you need to make the case for a migration. [01:44:40] it's not enough, rather. [01:44:46] * bawolff agrees [01:44:51] True [01:45:07] and you should assume that the reflexive attitude will be that you are out of your mind [01:45:12] ori: The UI improvements and workflow superiority sound like great places to start that case :) [01:45:25] because it would be a very expensive migration, in terms of hours spent making it work [01:45:48] True [01:46:00] I'll muse about it and maybe draft some bikeshed-l mails [01:46:02] you'd need a stronger case [01:46:56] i am only telling you this because i think we should in fact migrate and i'd like to see a proposal succeed, but i wouldn't endorse anything automatically. it'll be very tough to be persuasive on this front. [01:47:03] Yup [01:47:16] ori: My brain is all over trying to come up with brilliant points [01:48:09] well, saying that something is better in some loose way doesn't go very far. you need to identify an actual problem with our current setup that is sufficiently severe to potentially warrant a migration [01:48:33] so i'd start with gerrit rather than gitlab [01:49:41] http://en.wikipedia.org/wiki/Arch_Linux [01:49:44] pacman...hehe [01:50:12] gerrit has scaled well and has proven reliable and secure, so the motivation has to come from elsewhere [01:50:32] presumably like me and many other people you think its usability is poor [01:50:58] but articulating it precisely and quantifying its impact (so it could be weighed against the cost of migrating) is very hard [01:51:59] ori: Hence the upcoming drafting and revising process :) [01:52:06] But not now! Now is board game time. [01:52:23] people (myself included) have mostly just resorted to venting hyperbolically, which is good for a laugh but isn't actionable [01:52:24] * ori nods [01:52:32] (i'm procrastinating, in case you can't tell) [01:56:36] marktraceur: heh, both ceph and local fs give me this problem [01:56:45] * AaronSchulz wonders if it is a sqlite concurrency problem [02:00:19] (03PS3) 10Bsitu: Tweak and bug fix to modified tipsy and diff link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105421 [02:01:24] (03PS4) 10Bsitu: Tweak and bug fix to modified tipsy and diff link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105421 [02:24:35] (03CR) 10Anomie: [C: 04-1] "Added some inline comments pointing where the problem with tags is coming from." (033 comments) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/104794 (owner: 10AalekhN) [02:28:54] (03PS1) 10Mattflaschen: Import populate script from Gist [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/106479 [02:29:33] (03PS2) 10Mattflaschen: Import populate script from Gist [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/106479 [02:34:10] (03PS1) 10Bsitu: Remove obsolete columns during update [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106481 [02:35:10] (03PS2) 10Bsitu: Remove obsolete columns during update [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106481 [02:49:15] (03PS1) 10Manybubbles: Escape more bad syntax [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106482 [03:04:01] (03CR) 10Legoktm: [C: 031] Add ability to mark hooks as deprecated [core] - 10https://gerrit.wikimedia.org/r/106436 (owner: 10Aude) [03:13:21] (03CR) 10Parent5446: Improve clarity of diff-multi message (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106322 (owner: 10Jackmcbarn) [03:15:31] (03CR) 10Parent5446: "UserArray only needs one piece of identifying data in order to make the user object. In this case your query is fetching rev_user_text, wh" [core] - 10https://gerrit.wikimedia.org/r/106322 (owner: 10Jackmcbarn) [03:16:03] (03CR) 10Jackmcbarn: "That's not the issue. The issue is in the case where it doesn't do a query." [core] - 10https://gerrit.wikimedia.org/r/106322 (owner: 10Jackmcbarn) [03:17:34] (03CR) 10Parent5446: (bug 18598) Maintenance script to migrate legacy Oversight data (031 comment) [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 (owner: 10Alex Monk) [03:33:15] (03CR) 10Mattflaschen: [C: 032] Vector: Rewrite p-personal with nesting. [core] - 10https://gerrit.wikimedia.org/r/106299 (owner: 10Jdlrobson) [03:35:34] (03CR) 10Parent5446: [C: 031] "Ah, good point. There's probably a way to work around that, but it's probably too difficult to bother with for this patch. Carry on." [core] - 10https://gerrit.wikimedia.org/r/106322 (owner: 10Jackmcbarn) [03:36:49] (03CR) 10Parent5446: (bug 18598) Maintenance script to migrate legacy Oversight data (033 comments) [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 (owner: 10Alex Monk) [03:49:31] (03CR) 10Parent5446: [C: 04-1] "As mentioned, still needs qqq." [core] - 10https://gerrit.wikimedia.org/r/105234 (owner: 10Chad) [03:54:33] (03CR) 10Legoktm: "Bump?" [core] - 10https://gerrit.wikimedia.org/r/100113 (owner: 10Legoktm) [03:56:19] legoktm: Just add reviewers. [03:56:24] I added a few. [03:56:36] ok, I added one more [04:04:00] (03CR) 10Legoktm: [C: 032] Declare visibility on all properties in ForkController [core] - 10https://gerrit.wikimedia.org/r/106442 (owner: 10Chad) [04:07:02] Hello. :) [04:08:02] (03Merged) 10jenkins-bot: Declare visibility on all properties in ForkController [core] - 10https://gerrit.wikimedia.org/r/106442 (owner: 10Chad) [04:16:09] (03CR) 10Legoktm: [C: 04-1] "Also left a comment on the bug." (033 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106430 (owner: 10Manybubbles) [04:20:12] (03CR) 10Legoktm: DatabaseInstaller::setVarsFromRequest needs array (031 comment) [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/105985 (owner: 10Siebrand) [04:26:26] (03CR) 10Legoktm: [C: 031] "One little thing I missed earlier." (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/95647 (owner: 10Addshore) [04:27:50] (03CR) 10Legoktm: [C: 032] Replace deprecated User::editToken with User::getEditToken (1.19) [core] - 10https://gerrit.wikimedia.org/r/106213 (owner: 10Siebrand) [04:34:31] (03Merged) 10jenkins-bot: Replace deprecated User::editToken with User::getEditToken (1.19) [core] - 10https://gerrit.wikimedia.org/r/106213 (owner: 10Siebrand) [04:40:59] (03CR) 10EBernhardson: "Poked around some more, enabling multiverse repositories allows installing libapache2-mod-fastcgi." [vagrant] - 10https://gerrit.wikimedia.org/r/105834 (owner: 10EBernhardson) [04:43:14] (03CR) 10EBernhardson: [C: 032] Remove obsolete columns during update [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106481 (owner: 10Bsitu) [04:43:29] (03Merged) 10jenkins-bot: Remove obsolete columns during update [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106481 (owner: 10Bsitu) [04:44:21] (03CR) 10Legoktm: [C: 04-2] "Errr, what were you trying to do here? Merge commits shouldn't end up on gerrit like this." [core] - 10https://gerrit.wikimedia.org/r/106144 (owner: 10SG) [04:46:44] (03CR) 10Chad: [C: 04-2] Add the user to Cirrus logs (034 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106430 (owner: 10Manybubbles) [04:55:28] (03CR) 10Legoktm: [C: 032] Replace usage of deprecated Title::escapeLocalURL() [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/104362 (owner: 10Siebrand) [04:55:36] (03Merged) 10jenkins-bot: Replace usage of deprecated Title::escapeLocalURL() [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/104362 (owner: 10Siebrand) [04:56:04] (03CR) 10Chad: [C: 031] "lgtm, will merge if Siebrand says the i18n is ok." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106460 (owner: 10BryanDavis) [04:59:54] (03CR) 10Legoktm: "Can we not hardcode this specifically for WMF projects and use a default of $wgRightsText (or w/e) and have a hook in WikimediaMessages?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105873 (owner: 10Bsitu) [05:08:06] (03Abandoned) 10SG: Merge "Move redirect rendering into WikitextContent" [core] - 10https://gerrit.wikimedia.org/r/106144 (owner: 10SG) [05:10:00] (03CR) 10Legoktm: Update CentralAuth recent change notification code (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92461 (owner: 10Reedy) [05:27:19] (03PS1) 10Spage: Run update.php in `make master` [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106484 [06:01:04] (03CR) 10KartikMistry: [C: 032] "LGTM." [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106259 (owner: 10Amire80) [06:01:08] (03Merged) 10jenkins-bot: Add more browser test steps [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106259 (owner: 10Amire80) [06:26:03] Aaron|home: Oh no! [06:26:11] Aaron|home: If you get further information let me know [06:37:49] (03PS1) 10KartikMistry: Update special page Special:ContentTranslation [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106485 [06:42:31] (03PS2) 10KartikMistry: Update special page Special:ContentTranslation [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106485 [06:49:08] I am confused a li'l bit in Why do we use parameter indexpageids to parse the revision content of a page? [06:49:32] can anyone tell me? [06:50:26] sure [06:50:47] so basically if you look at https://en.wikipedia.org/w/api.php?action=query&prop=revisions&titles=API&format=jsonfm [06:50:56] (03PS1) 10Pastakhov: update to version 0.4.4 [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/106487 [06:51:22] the pages are returned as query.pages.[SOME NUMBER].info [06:51:24] and you want info [06:51:34] when you're using JS, it's not easy to iterate over the values [06:51:52] so what you do is iterate over the indexpageids [06:53:10] diwanship: did that make sense? ^ [06:53:40] legoktm yes thanks got it [06:53:44] :) [06:57:18] In practice I've found that iteration is not hard, but if you know there's only gonna be one result, accessing that one result is laborious [06:57:33] Because you don't know what its key will be and you don't really want to write a loop [06:57:47] So with indexpageids you can do something like query.pages[query.pageids[0]].info [06:58:50] (03PS1) 10KartikMistry: Update extension setup files [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106488 [06:59:14] (03PS2) 10KartikMistry: Update extension setup files [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106488 [06:59:39] RoanKattouw thanks thats one more reason :) [07:00:03] RoanKattouw: I was talking to Ori earlier about how we don't clear/update msg blobs on scap [07:00:44] though it seems to only matter if some msg was updated and no key changes made to the $wgResourceLoaderModule [07:01:17] periodic l10nupdate eventually cleans it up though [07:11:47] (03PS1) 10PleaseStand: WebInstaller: Don't call getSoftwareLink() [core] - 10https://gerrit.wikimedia.org/r/106489 [07:11:52] (03PS1) 10PleaseStand: Clean up config-support-* messages [core] - 10https://gerrit.wikimedia.org/r/106490 [07:12:02] (03PS1) 10PleaseStand: Web installer: Remove support for old config-support-* translations [core] - 10https://gerrit.wikimedia.org/r/106491 [07:26:20] (03PS3) 10KartikMistry: Update extension setup files [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106488 [07:28:46] (03CR) 10PleaseStand: Clean up config-support-* messages (034 comments) [core] - 10https://gerrit.wikimedia.org/r/106490 (owner: 10PleaseStand) [07:46:50] (03CR) 10PleaseStand: "Another way to fix this: I6dbc9d32 and I4b10f8b8." [core] - 10https://gerrit.wikimedia.org/r/103379 (owner: 10btongminh) [07:47:54] (03CR) 10Nikerabbit: [C: 04-1] Update special page Special:ContentTranslation (031 comment) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106485 (owner: 10KartikMistry) [07:53:16] (03PS3) 10KartikMistry: Update special page Special:ContentTranslation [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106485 [08:08:25] (03CR) 10Siebrand: Clean up config-support-* messages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106490 (owner: 10PleaseStand) [08:10:05] (03CR) 10Siebrand: [C: 04-1] Web installer: Remove support for old config-support-* translations (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106491 (owner: 10PleaseStand) [08:10:59] (03CR) 10Siebrand: [C: 04-1] "I think you should squash the two follow-up patch sets into this one." [core] - 10https://gerrit.wikimedia.org/r/106489 (owner: 10PleaseStand) [08:13:24] (03CR) 10Siebrand: [C: 04-1] "cot-desc change is missing in ContentTranslation.php. Also see inline comment." (031 comment) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106488 (owner: 10KartikMistry) [08:27:00] (03CR) 10Nikerabbit: [C: 032] Update special page Special:ContentTranslation [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106485 (owner: 10KartikMistry) [08:27:02] (03Merged) 10jenkins-bot: Update special page Special:ContentTranslation [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106485 (owner: 10KartikMistry) [08:38:58] (03PS4) 10KartikMistry: Update extension setup files [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106488 [08:39:09] (03CR) 10Siebrand: [C: 032] Add missing i18n for search region [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106460 (owner: 10BryanDavis) [08:39:11] (03Merged) 10jenkins-bot: Add missing i18n for search region [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106460 (owner: 10BryanDavis) [08:41:28] (03PS3) 10Siebrand: DatabaseInstaller::setVarsFromRequest needs array [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/105985 [08:47:01] (03CR) 10Nikerabbit: [C: 04-1] Update extension setup files (031 comment) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106488 (owner: 10KartikMistry) [08:50:57] (03PS5) 10KartikMistry: Update extension setup files [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106488 [09:19:40] (03CR) 10Nikerabbit: [C: 032] Replace deprecated User::editToken with User::getEditToken (1.19) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/106211 (owner: 10Siebrand) [09:19:47] (03Merged) 10jenkins-bot: Replace deprecated User::editToken with User::getEditToken (1.19) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/106211 (owner: 10Siebrand) [09:24:32] (03PS1) 10Jeroen De Dauw: Remove no longer applicable Wikibase jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/106497 [09:27:20] (03PS1) 10Jeroen De Dauw: Remove no longer applicable Wikibase jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/106498 [09:36:05] (03CR) 10Nikerabbit: [C: 032] Update extension setup files [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106488 (owner: 10KartikMistry) [09:36:08] (03Merged) 10jenkins-bot: Update extension setup files [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106488 (owner: 10KartikMistry) [09:58:16] (03PS1) 10Santhosh: Page layout, grid, base css framework [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106500 [09:58:17] (03CR) 10jenkins-bot: [V: 04-1] Page layout, grid, base css framework [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106500 (owner: 10Santhosh) [09:58:45] (03PS1) 10Nikerabbit: Add ContentTranslation to #mediawiki-i18n [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106501 [10:02:41] (03CR) 10Nikerabbit: "I thought we decided to do (almost) everything in JS." [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106500 (owner: 10Santhosh) [10:13:11] (03PS2) 10Santhosh: Page layout, grid, base css framework [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106500 [10:13:13] (03CR) 10jenkins-bot: [V: 04-1] Page layout, grid, base css framework [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106500 (owner: 10Santhosh) [10:16:10] (03PS3) 10Santhosh: Page layout, grid, base css framework [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106500 [10:44:43] whois polybuildr [10:54:45] (03PS2) 10Pastakhov: update to version 0.4.4 [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/106487 [11:08:39] hey guys, does anyone know how I can hook a function to run *after* the whole page content is parsed? [11:18:46] (03PS1) 10Hashar: restore mwext-Translate-phpcs-strict [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/106503 [11:19:45] (03CR) 10Hashar: [C: 032] restore mwext-Translate-phpcs-strict [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/106503 (owner: 10Hashar) [11:20:01] (03Merged) 10jenkins-bot: restore mwext-Translate-phpcs-strict [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/106503 (owner: 10Hashar) [11:35:33] (03CR) 10KartikMistry: "See inline comments." (032 comments) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106500 (owner: 10Santhosh) [11:37:51] (03CR) 10Daniel Kinzler: "The approach looks good, but I didn't check the individual queries in detail." [core] - 10https://gerrit.wikimedia.org/r/103589 (owner: 10Anomie) [11:38:34] (03PS4) 10Santhosh: Page layout, grid, base css framework [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106500 [11:39:43] (03CR) 10Daniel Kinzler: [C: 031] "CR1 as per PS4" [core] - 10https://gerrit.wikimedia.org/r/101895 (owner: 10Aude) [11:54:23] (03CR) 10KartikMistry: "Mostly tab/space issues." (0310 comments) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106500 (owner: 10Santhosh) [12:01:01] (03CR) 10Bartosz Dziewoński: [C: 031] Add ability to mark hooks as deprecated [core] - 10https://gerrit.wikimedia.org/r/106436 (owner: 10Aude) [12:09:49] (03PS1) 10Physikerwelt: Resolve merge conflicts [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/106504 [12:15:04] (03CR) 10Siebrand: DatabaseInstaller::setVarsFromRequest needs array (031 comment) [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/105985 (owner: 10Siebrand) [12:19:36] (03CR) 10Siebrand: [C: 04-1] "See inline comment. qqq is missing, as already pointed out before." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105234 (owner: 10Chad) [12:23:16] (03CR) 10Hashar: [C: 032] Remove no longer applicable Wikibase jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/106497 (owner: 10Jeroen De Dauw) [12:23:22] (03Merged) 10jenkins-bot: Remove no longer applicable Wikibase jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/106497 (owner: 10Jeroen De Dauw) [12:23:54] (03CR) 10Hashar: "deployed" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/106497 (owner: 10Jeroen De Dauw) [12:24:09] (03PS1) 10Bartosz Dziewoński: Optimize all SVGs (attempt 2) [core] - 10https://gerrit.wikimedia.org/r/106506 [12:24:33] (03CR) 10Hashar: "Zuul part deployed https://gerrit.wikimedia.org/r/#/c/106497/" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/106498 (owner: 10Jeroen De Dauw) [12:27:24] (03PS1) 10Tpt: Add FileProvider [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/106507 [12:27:24] (03CR) 10jenkins-bot: [V: 04-1] Add FileProvider [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/106507 (owner: 10Tpt) [12:27:42] (03CR) 10Siebrand: [C: 04-1] "i18n/L10 reviewed. Fine." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/106322 (owner: 10Jackmcbarn) [12:28:10] (03PS2) 10Bartosz Dziewoński: Optimize all SVGs (attempt 2) [core] - 10https://gerrit.wikimedia.org/r/106506 [12:28:16] (03CR) 10Bartosz Dziewoński: "Second attempt: https://gerrit.wikimedia.org/r/#/c/106506/" [core] - 10https://gerrit.wikimedia.org/r/103894 (owner: 10Bartosz Dziewoński) [12:41:32] (03CR) 10Bartosz Dziewoński: "Doesn't merge again :(" [core] - 10https://gerrit.wikimedia.org/r/64533 (owner: 10Balloonguy) [12:46:22] Could someone review? https://gerrit.wikimedia.org/r/#/c/101820/ [12:46:24] (03CR) 10Bartosz Dziewoński: [C: 04-1] Warn if page was edited while deletion was being confirmed [core] - 10https://gerrit.wikimedia.org/r/64533 (owner: 10Balloonguy) [12:48:40] (03Abandoned) 10Bartosz Dziewoński: Exclude toggle button of collapsible elements from user selection [core] - 10https://gerrit.wikimedia.org/r/105621 (owner: 10Gerrit Patch Uploader) [12:49:07] (03CR) 10Bartosz Dziewoński: "Fomafix, it should work if you copy the Change-Id line from the summary here. Oh well, whatever." [core] - 10https://gerrit.wikimedia.org/r/105621 (owner: 10Gerrit Patch Uploader) [12:50:09] (03CR) 10Bartosz Dziewoński: [C: 032] "Should be good." [core] - 10https://gerrit.wikimedia.org/r/105689 (owner: 10Gerrit Patch Uploader) [12:53:24] (03Merged) 10jenkins-bot: Exclude toggle button of collapsible elements from user selection [core] - 10https://gerrit.wikimedia.org/r/105689 (owner: 10Gerrit Patch Uploader) [12:56:59] Could someone review? https://gerrit.wikimedia.org/r/#/c/101820/ [13:16:05] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu) [13:19:25] (03CR) 10Matthias Mullie: "ee-flow has flow data in a separate db, right?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106484 (owner: 10Spage) [13:20:21] (03CR) 10Manybubbles: Add the user to Cirrus logs (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106430 (owner: 10Manybubbles) [13:20:27] (03CR) 10Nikerabbit: Fix logging (032 comments) [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/105444 (owner: 10Alex Monk) [13:21:42] (03CR) 10Siebrand: [C: 04-1] "Per Niklas." [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/105444 (owner: 10Alex Monk) [13:21:44] (03CR) 10Rtdwivedi: [C: 031] Increase scan size on horizontal edit mode [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101481 (owner: 10Tpt) [13:21:45] (03CR) 10Nikerabbit: [C: 04-1] Fix logging [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/105444 (owner: 10Alex Monk) [13:22:16] (03CR) 10Tpt: [C: 032] "Thanks for review" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101481 (owner: 10Tpt) [13:22:25] (03Merged) 10jenkins-bot: Increase scan size on horizontal edit mode [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101481 (owner: 10Tpt) [13:24:38] (03CR) 10Physikerwelt: [C: 032 V: 032] Resolve merge conflicts [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/106504 (owner: 10Physikerwelt) [13:32:19] (03PS3) 10Pastakhov: update to version 0.5.0 [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/106487 [13:36:13] (03CR) 10Pastakhov: [C: 032] update to version 0.5.0 [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/106487 (owner: 10Pastakhov) [13:36:27] (03Merged) 10jenkins-bot: update to version 0.5.0 [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/106487 (owner: 10Pastakhov) [13:40:07] (03CR) 10Siebrand: [C: 032] always show diff link if available [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105637 (owner: 10Nullzero) [13:40:22] (03Merged) 10jenkins-bot: always show diff link if available [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105637 (owner: 10Nullzero) [13:43:05] (03PS1) 10Matthias Mullie: Fix leftover user_text occurrences [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106512 [13:44:42] (03CR) 10Matthias Mullie: "IP searches on Special:Contributions will not work on new data, without this patch" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106512 (owner: 10Matthias Mullie) [13:48:11] (03CR) 10Siebrand: "Some L10n reservations." (033 comments) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/106487 (owner: 10Pastakhov) [13:55:18] (03PS1) 10Matthias Mullie: Call flow-init on correct element [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106514 [13:55:39] Could you say how I can clone for this bug https://bugzilla.wikimedia.org/show_bug.cgi?id=45771 [14:05:38] (03PS10) 10MrBlueSky: Add associated namespace option to Special:NewPages [core] - 10https://gerrit.wikimedia.org/r/52676 [14:07:19] (03CR) 10Pastakhov: "Thanks for help" (033 comments) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/106487 (owner: 10Pastakhov) [14:08:40] (03CR) 10MrBlueSky: "I have moved the new function to DatabaseBase as Parent5446 suggested." [core] - 10https://gerrit.wikimedia.org/r/52676 (owner: 10MrBlueSky) [14:13:01] (03CR) 10Siebrand: update to version 0.5.0 (031 comment) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/106487 (owner: 10Pastakhov) [14:14:02] (03CR) 10Gilles: [C: 04-1] "I'm not super familiar with existing best practices when it comes to writing new backend endpoints, is anyone on the review list more fami" (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [14:15:57] (03CR) 10Gilles: "I'll take a look at this once my concerns about the backend have been clarified." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [14:16:55] (03CR) 10Siebrand: update to version 0.5.0 (031 comment) [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/106487 (owner: 10Pastakhov) [14:26:02] (03PS1) 10Pastakhov: fix L10n reservations [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/106516 [14:27:02] siebrand: ^^^ [14:27:19] (03PS2) 10Siebrand: fix L10n reservations [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/106516 (owner: 10Pastakhov) [14:28:05] (03CR) 10Siebrand: [C: 031] "You're welcome. Looks good!" [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/106516 (owner: 10Pastakhov) [14:34:45] (03CR) 10Pastakhov: [C: 032] "Thank you, again :-)" [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/106516 (owner: 10Pastakhov) [14:34:54] (03Merged) 10jenkins-bot: Tweak messages [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/106516 (owner: 10Pastakhov) [14:48:09] (03CR) 10Siebrand: "Adding me as a reviewer is preferred, although I do try to catch up with all changes every day. I do miss some now and then, though." [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/106516 (owner: 10Pastakhov) [14:52:32] (03PS1) 10KartikMistry: Update translation typing browsertest [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106518 [14:52:39] (03CR) 10Siebrand: Remove Special:GettingStarted and notifications (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/106458 (owner: 10Mattflaschen) [14:54:27] (03CR) 10Siebrand: [C: 032] Localisation updates from https://translatewiki.net. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106511 (owner: 10L10n-bot) [14:54:30] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106511 (owner: 10L10n-bot) [14:58:54] (03CR) 10Daniel Kinzler: [C: 032] Add validation of the content model edited by EditPage [core] - 10https://gerrit.wikimedia.org/r/97835 (owner: 10Tpt) [15:02:11] (03Merged) 10jenkins-bot: Add validation of the content model edited by EditPage [core] - 10https://gerrit.wikimedia.org/r/97835 (owner: 10Tpt) [15:05:07] (03Abandoned) 10IAlex: Sync RELEASE-NOTES-1.22 between master and REL1_22 [core] - 10https://gerrit.wikimedia.org/r/97100 (owner: 10IAlex) [15:08:23] (03PS3) 10Jackmcbarn: Improve clarity of diff-multi message [core] - 10https://gerrit.wikimedia.org/r/106322 [15:27:18] (03CR) 10Anomie: "In MediaWiki, there are two ways to run an extension's unit tests. Method 1 is by pointing phpunit at the extension's directory where it w" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [15:31:07] (03PS5) 10Santhosh: Page layout, grid, base css framework [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106500 [15:33:33] (03CR) 10Siebrand: Do not suggest to use unused local vars (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106297 (owner: 10Siebrand) [15:42:21] (03CR) 10Chad: Add the user to Cirrus logs (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106430 (owner: 10Manybubbles) [15:46:44] (03CR) 10Chad: Add the user to Cirrus logs (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106430 (owner: 10Manybubbles) [15:47:19] (03CR) 10Manybubbles: Add the user to Cirrus logs (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106430 (owner: 10Manybubbles) [15:54:41] (03CR) 10Chad: Add the user to Cirrus logs (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106430 (owner: 10Manybubbles) [15:55:56] (03PS1) 10Manybubbles: Don't suggest anything if a result is a full match [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106523 [16:00:45] (03CR) 10Chad: [C: 032] Don't suggest anything if a result is a full match [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106523 (owner: 10Manybubbles) [16:00:50] (03Merged) 10jenkins-bot: Don't suggest anything if a result is a full match [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106523 (owner: 10Manybubbles) [16:01:17] (03CR) 10Chad: [C: 032] Escape more bad syntax [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106482 (owner: 10Manybubbles) [16:01:23] (03Merged) 10jenkins-bot: Escape more bad syntax [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106482 (owner: 10Manybubbles) [16:02:51] (03PS1) 10Tpt: Refactoring of Page: pages edition PHP code [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/106524 [16:05:40] (03PS1) 10Nikerabbit: composer.json [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106525 [16:11:47] (03CR) 10Anomie: "> It seems to me however that the logic for composite continuation keys should be factored out, either into the base class or into a separ" [core] - 10https://gerrit.wikimedia.org/r/103589 (owner: 10Anomie) [16:13:49] (03PS2) 10Reedy: Revert "Change Collection to a deploy branch" [tools/release] - 10https://gerrit.wikimedia.org/r/106296 (owner: 10Mwalker) [16:14:06] (03CR) 10Reedy: [C: 032] Revert "Change Collection to a deploy branch" [tools/release] - 10https://gerrit.wikimedia.org/r/106296 (owner: 10Mwalker) [16:14:07] (03Merged) 10jenkins-bot: Revert "Change Collection to a deploy branch" [tools/release] - 10https://gerrit.wikimedia.org/r/106296 (owner: 10Mwalker) [16:15:13] (03PS5) 10Reedy: Retry commands if failed [tools/release] - 10https://gerrit.wikimedia.org/r/104970 [16:15:16] (03CR) 10Reedy: [C: 032] Retry commands if failed [tools/release] - 10https://gerrit.wikimedia.org/r/104970 (owner: 10Reedy) [16:15:19] (03Merged) 10jenkins-bot: Retry commands if failed [tools/release] - 10https://gerrit.wikimedia.org/r/104970 (owner: 10Reedy) [16:30:30] (03PS1) 10Aude: Add wikisource sitelink section message for Wikidata [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/106528 [16:30:42] (03CR) 10Anomie: Modify the Special:LonelyPages query to ignore disambiguation pages (031 comment) [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/106435 (owner: 10Kaldari) [16:36:56] (03CR) 10Daniel Kinzler: [C: 032] Add wikisource sitelink section message for Wikidata [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/106528 (owner: 10Aude) [16:36:58] (03Merged) 10jenkins-bot: Add wikisource sitelink section message for Wikidata [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/106528 (owner: 10Aude) [16:37:54] Hi guys i had a doubt about Special:Whatlinkshere page ....can someone please give me a link for tutorial about this page functonality in detail????? [16:40:39] There probably isn't one [16:56:51] (03PS1) 10Anomie: API: Allow special pages for action=parse&title= [core] - 10https://gerrit.wikimedia.org/r/106530 [17:11:55] (03PS4) 10Matthias Mullie: Refactor edit-post JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105674 [17:11:57] (03PS4) 10Matthias Mullie: Refactor title JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101903 [17:11:59] (03PS3) 10Matthias Mullie: Refactor post-reply JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105699 [17:12:01] (03PS1) 10Matthias Mullie: Refactor title-reply JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106534 [17:14:54] (03PS1) 10Reedy: Hack to fix bug 59780 [extensions/TimedMediaHandler] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106535 [17:15:13] (03CR) 10Reedy: [C: 032] Hack to fix bug 59780 [extensions/TimedMediaHandler] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106535 (owner: 10Reedy) [17:15:21] (03PS2) 10Matthias Mullie: Refactor title-reply JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106534 [17:15:23] (03Merged) 10jenkins-bot: Hack to fix bug 59780 [extensions/TimedMediaHandler] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106535 (owner: 10Reedy) [17:15:31] (03PS2) 10Reedy: Hack to fix bug 59780 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/106134 [17:15:38] (03CR) 10Reedy: [C: 032] Hack to fix bug 59780 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/106134 (owner: 10Reedy) [17:15:40] (03Merged) 10jenkins-bot: Hack to fix bug 59780 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/106134 (owner: 10Reedy) [17:16:24] (03PS3) 10Matthias Mullie: Refactor title-reply JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106534 [17:18:03] (03CR) 10Alex Monk: Fix logging (031 comment) [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/105444 (owner: 10Alex Monk) [17:18:47] (03PS4) 10Alex Monk: Fix logging [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/105444 [17:20:48] (03PS4) 10Matthias Mullie: Refactor title-reply JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106534 [17:21:10] (03PS2) 10Amire80: Update translation typing browser test [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106518 (owner: 10KartikMistry) [17:21:28] (03CR) 10Amire80: [C: 032] Update translation typing browser test [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106518 (owner: 10KartikMistry) [17:21:30] (03Merged) 10jenkins-bot: Update translation typing browser test [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106518 (owner: 10KartikMistry) [17:24:06] (03CR) 10Matthias Mullie: "I've made more progress on getting rid of form-controls's JS showing/hiding in https://gerrit.wikimedia.org/r/#/c/106534/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106275 (owner: 10Matthias Mullie) [17:27:31] (03CR) 10Aaron Schulz: Make it easy to get the number of the currently running child (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106443 (owner: 10Chad) [17:38:28] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Does not merge." [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104722 (owner: 10TheDJ) [17:45:51] (03PS1) 10Reedy: Update TMH [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106541 [17:46:09] (03CR) 10Reedy: [C: 032 V: 032] Update TMH [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106541 (owner: 10Reedy) [17:50:37] (03PS1) 10Reedy: Remove AssertEdit [tools/release] - 10https://gerrit.wikimedia.org/r/106544 [18:01:16] (03CR) 10Bartosz Dziewoński: [C: 032] "Works when tested. I assume you know what you're doing. :)" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104510 (owner: 10TheDJ) [18:01:21] (03Merged) 10jenkins-bot: CodeEditor: Update to package 12.02.2013 (December 2013) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104510 (owner: 10TheDJ) [18:01:37] (03CR) 10Alex Monk: (bug 18598) Maintenance script to migrate legacy Oversight data (034 comments) [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 (owner: 10Alex Monk) [18:01:44] (03PS2) 10Bartosz Dziewoński: Remove trailing commas [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104717 (owner: 10TheDJ) [18:01:57] (03CR) 10Bartosz Dziewoński: [C: 032] Remove trailing commas [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104717 (owner: 10TheDJ) [18:01:57] (03Merged) 10jenkins-bot: Remove trailing commas [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104717 (owner: 10TheDJ) [18:02:46] (03PS13) 10Alex Monk: Maintenance script to migrate legacy Oversight data [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 [18:03:47] (03CR) 10Alex Monk: "copying over my standing comments/issues from previous patchset" (032 comments) [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 (owner: 10Alex Monk) [18:04:47] (03PS1) 10Aude: Update WikimediaMessages to master [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106545 [18:21:07] (03CR) 10Legoktm: [C: 032 V: 032] Add ContentTranslation to #mediawiki-i18n [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106501 (owner: 10Nikerabbit) [18:22:02] legoktm: thanks for taking care of that [18:22:06] np [18:25:26] YuviPanda: why are labs/tools/grrrit changes relayed both here and on #wikimedia-labs? [18:25:59] looks like I revealed an embarassing secret of grrrit [18:26:05] (or it was just being restarted :p) [18:26:47] Nemo_bis: iirc James_F|Away enabled that? [18:26:56] Nemo_bis: oh noes, my evil plan to fragment IRC channels has been exposed?!! [18:27:07] Nemo_bis: I suppose it's just explicitly listed [18:27:17] Nemo_bis: https://gerrit.wikimedia.org/r/#/c/102346/ [18:27:35] I'm happy there are plenty of people who are not me who work on it :) [18:29:54] legoktm: that used not to work [18:30:25] it does now I guess [18:30:28] legoktm: or can https://bugzilla.wikimedia.org/show_bug.cgi?id=52529 just be resolved by listing all channels explicitly for the "feed" channel [18:31:43] gwicke: does https://gerrit.wikimedia.org/r/#/c/86642/ look ok? [18:32:12] (03CR) 10UltrasonicNXT: "Any other comments for this Jack? :)" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/100767 (owner: 10UltrasonicNXT) [18:32:22] (03PS1) 10Bartosz Dziewoński: SpecialWantedcategories: Actually strike the category if it was emptied [core] - 10https://gerrit.wikimedia.org/r/106552 [18:32:38] (03CR) 10Bartosz Dziewoński: "Followup: https://gerrit.wikimedia.org/r/106552" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100210 (owner: 10Bartosz Dziewoński) [18:33:15] Nemo_bis: so the problem is that if it goes to another channel, you have to explicitly list it for -dev. So I guess we could just actually list out every prefix? [18:33:34] (03CR) 10GWicke: [C: 032] filebackend: Added supported for retrieving file metadata/headers [core] - 10https://gerrit.wikimedia.org/r/86642 (owner: 10Aaron Schulz) [18:33:57] AaronSchulz, I +2ed it [18:34:20] (03CR) 10Umherirrender: "@Siebrand: It looks like a config issue, which makes working on branches not possible, but that does not hurt, because backporting can be " [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/105985 (owner: 10Siebrand) [18:34:27] legoktm: what wildcards work^ [18:34:35] any regular expression [18:34:44] so feed would just be .* I assume [18:35:03] (03CR) 10Mattflaschen: ContentModel: Use CM to choose CE language (031 comment) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104721 (owner: 10TheDJ) [18:35:22] problem then is if a new top level prefix is created, by default it will go to -feed and not -dev [18:35:54] maybe we only want mediawiki.* anyway [18:36:45] (03Merged) 10jenkins-bot: filebackend: Added supported for retrieving file metadata/headers [core] - 10https://gerrit.wikimedia.org/r/86642 (owner: 10Aaron Schulz) [18:36:56] legoktm: can we try? [18:38:47] sure [18:40:44] should it really be everything, hmm [18:41:43] mediawiki, apps, analytics, wikimedia, integration, labs, VisualEditor, qa, oojs? but nt pywikibot and operations? [18:41:54] (03PS1) 10Chad: Limit searches at 500 per page [core] - 10https://gerrit.wikimedia.org/r/106553 [18:42:06] (because those two used to have their own repos and mailing lists even) [18:45:02] (03CR) 10Manybubbles: [C: 031] Limit searches at 500 per page [core] - 10https://gerrit.wikimedia.org/r/106553 (owner: 10Chad) [18:52:15] oh well, trying that [18:52:18] (03PS1) 10Nemo bis: Setup/restore #mediawiki-feed [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106555 [18:52:29] legoktm: ^ [18:54:04] (03CR) 10Legoktm: [C: 04-1] Setup/restore #mediawiki-feed (031 comment) [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106555 (owner: 10Nemo bis) [18:54:19] Should be good except for that [18:56:08] (03CR) 10Aaron Schulz: [C: 032] Limit searches at 500 per page [core] - 10https://gerrit.wikimedia.org/r/106553 (owner: 10Chad) [18:57:03] (03PS2) 10Nemo bis: Setup/restore #mediawiki-feed [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106555 [18:58:16] (03PS3) 10Nemo bis: Setup/restore #mediawiki-feed [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106555 [18:58:35] (03PS1) 10Matthias Mullie: Refactor new-topic JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106556 [18:59:15] (03CR) 10Nemo bis: Setup/restore #mediawiki-feed (031 comment) [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/106555 (owner: 10Nemo bis) [18:59:22] marktraceur: lol #-staff rejects me again [18:59:27] (03Merged) 10jenkins-bot: Limit searches at 500 per page [core] - 10https://gerrit.wikimedia.org/r/106553 (owner: 10Chad) [18:59:54] Wat [19:10:29] (03PS1) 10Aaron Schulz: Fixed file props test failure for MemoryFileBackend [core] - 10https://gerrit.wikimedia.org/r/106557 [19:12:08] (03CR) 10Aaron Schulz: "Note that extension is used to help guess MIME type. The other backends do this, it was just an oversight here." [core] - 10https://gerrit.wikimedia.org/r/106557 (owner: 10Aaron Schulz) [19:12:11] manybubbles, PHP Warning: Search backend error during full text search for '+--+'. Error message is: SearchPhaseExecutionException[Failed to execute phase [dfs], all shards failed [19:12:28] MaxSem: fix already in master for that [19:12:48] it'll fix most of the queryies [19:13:39] I should try some [19:17:24] Reedy: you can watch the failures in real time! [19:19:46] (03CR) 10Aaron Schulz: API: Allow special pages for action=parse&title= (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106530 (owner: 10Anomie) [19:30:12] (03PS1) 10Umherirrender: Make a single # an invalid title in php and js [core] - 10https://gerrit.wikimedia.org/r/106561 [19:30:15] (03CR) 10Anomie: API: Allow special pages for action=parse&title= (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106530 (owner: 10Anomie) [19:37:42] (03CR) 10Aaron Schulz: [C: 032] "Those can be cleaned up later then" [core] - 10https://gerrit.wikimedia.org/r/106530 (owner: 10Anomie) [19:37:44] (03CR) 10Reedy: [C: 032 V: 032] Update WikimediaMessages to master [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106545 (owner: 10Aude) [19:41:23] (03Merged) 10jenkins-bot: API: Allow special pages for action=parse&title= [core] - 10https://gerrit.wikimedia.org/r/106530 (owner: 10Anomie) [19:46:25] hey guys, what would be the best way to load a dynamic stylesheet based on all the tags used on the page? [19:46:31] (03CR) 10Bartosz Dziewoński: "There's a bug for this, btw." [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender) [19:47:40] I need to insert a stylesheet that allows each tag to function properly, so it would be a lot easier to just insert one stylesheet with all dynamic styles in it after all tags have loaded (storing the information needed to generate the styles in a global variable for further access) [19:48:01] (03CR) 10Bartosz Dziewoński: "OK, not this exactly, but related: see https://gerrit.wikimedia.org/r/#/c/98119/ and https://bugzilla.wikimedia.org/58647" [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender) [19:48:27] but for that to work, I would need to 1) load the styles *after* the tags have all been parsed, and 2) after the required variable has been defined [19:49:20] what I currently use is https://www.mediawiki.org/wiki/Manual:OutputPage.php -> addInlineStyle('') [19:49:37] and I add that as $wgHooks['BeforePageDisplay'][] [19:50:14] but that, for some reason, doesn't work the way I want it to, since for some reason, the global variable I defined is still at its default value [19:51:13] is there any way to fix this? Or should I just insert the dynamic styles to the body for each of the tags used (which seems really bad) [19:52:39] TL:DR; - What is the best way to load dynamic styles based on each of a tag extension's tag usages? [19:53:11] (03CR) 10MegaAlex: "I am fine with using wfExpandUrl and plainlinks even when the link is external." [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [19:59:22] Joeytje50: in your tag extension hook, you should be able to do it. let me find an example [19:59:49] Joeytje50: take a look at how Cite does it: https://github.com/wikimedia/mediawiki-extensions-Cite/blob/master/Cite_body.php#L166 [20:01:02] legoktm: and what is ext.cite there? [20:01:11] it's a resourceloader module [20:01:12] but [20:01:18] you should be able to use addInlineStyle there [20:01:50] or not :/ [20:01:52] hmm [20:01:52] and that won't add the styles every time it's used? [20:02:31] because what I'd suspect from the resourceloader is that it stores everything to add, and when the page is DOMReady in JS it runs it [20:02:44] nevermind, that won't work [20:02:54] which wouldn't work for me, since I can't use resourceloader, since I need to use dynamic CSS [20:06:03] legoktm: so are there any other extensions that you know of which add dynamic styles? [20:08:27] not off the top of my head [20:08:58] (03PS1) 10Aaron Schulz: filebackend: Added supported for retrieving file metadata/headers [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106567 [20:08:59] Geshi does I think [20:09:36] $css[] = ''; [20:09:58] * YuviPanda pastebins Reedy [20:10:04] ty [20:11:17] http://www.php.net/manual/en/function.http-build-query.php [20:11:23] 5.4.0 The enc_type parameter was added. [20:12:16] (03CR) 10Cscott: [C: 032] Automatically open/close inline decorations around bidi runs. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/106446 (owner: 10Cscott) [20:12:27] (03CR) 10Cscott: [C: 032] Allow env/line/paragraph breaks in the middle of 'inline' decorations. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/106447 (owner: 10Cscott) [20:12:36] (03Merged) 10jenkins-bot: Automatically open/close inline decorations around bidi runs. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/106446 (owner: 10Cscott) [20:12:40] (03PS1) 10Cscott: Update README to mention g++ dependency. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/106568 [20:12:48] (03Merged) 10jenkins-bot: Allow env/line/paragraph breaks in the middle of 'inline' decorations. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/106447 (owner: 10Cscott) [20:13:00] (03CR) 10Cscott: [C: 032] Update README to mention g++ dependency. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/106568 (owner: 10Cscott) [20:13:20] (03Merged) 10jenkins-bot: Update README to mention g++ dependency. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/106568 (owner: 10Cscott) [20:14:18] (03CR) 10Aaron Schulz: [C: 032] filebackend: Added supported for retrieving file metadata/headers [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106567 (owner: 10Aaron Schulz) [20:14:38] ah Reedy, after checking geshi's source code, I think I get how it's done: [20:15:20] from what I see there, a method self::buildHeadItem is called to return the dynamic styles, and those are added via $parser->getOutput()->addHeadItem() [20:15:57] but what it seems like here, the addHeadItem() is called every time the tag is used [20:16:10] so how is it prevented that the styles are added a million times? [20:16:23] I'm not exactly sure [20:16:32] Might be worth quickly testing it [20:16:38] As if it's there repeatedly... that's a bug, yup [20:16:52] I'll try [20:17:07] Well, multiple might actually be wanted [20:17:12] For different languages [20:17:23] (03Merged) 10jenkins-bot: filebackend: Added supported for retrieving file metadata/headers [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106567 (owner: 10Aaron Schulz) [20:17:28] But even then, it could add multiple per language [20:24:46] (03CR) 10Reedy: "Caused bug 59880" [core] - 10https://gerrit.wikimedia.org/r/101226 (owner: 10Aaron Schulz) [20:36:13] sorry, I was called away [20:36:44] Reedy: I just checked, geshi adds 1 stylesheet per language it uses, yes [20:37:11] so what it seems to me is that the addHeadItem checks for identical strings, and then adds the ones that are already added [20:37:23] doesn't add the ones that are already added* <_> [20:37:43] Not quite [20:37:44] $out->addHeadItem( $highlighter::buildHeadItem( $geshi ), "source-$lang" ); [20:37:50] function addHeadItem( $section, $tag = false ) { [20:37:59] * Add some text to the "". [20:37:59] * If $tag is set, the section with that tag will only be included once [20:37:59] * in a given page. [20:38:05] But yes, one per tag [20:38:08] And if the tag is the same... [20:38:23] I see [20:38:55] and is there a way to remove head items by $tag? [20:39:27] $parserOutput->mHeadItems is public... [20:39:45] okay, I'll check that [20:39:47] tyvm! [20:44:36] (03PS1) 10Aaron Schulz: Fixed bogus var usage in SwiftFileBackend [core] - 10https://gerrit.wikimedia.org/r/106616 [20:45:14] (03PS1) 10Aaron Schulz: Fixed bogus var usage in SwiftFileBackend [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106617 [20:46:29] (03CR) 10Aaron Schulz: [C: 032] Fixed bogus var usage in SwiftFileBackend [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106617 (owner: 10Aaron Schulz) [20:48:32] (03CR) 10Aaron Schulz: [C: 032] Fixed bogus var usage in SwiftFileBackend [core] - 10https://gerrit.wikimedia.org/r/106616 (owner: 10Aaron Schulz) [20:49:34] if you do, I suppose fuzzy search should add to fun [20:49:45] (03Merged) 10jenkins-bot: Fixed bogus var usage in SwiftFileBackend [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106617 (owner: 10Aaron Schulz) [20:49:59] ahem, was stuck at line of backscroll: Reedy> I should try some [20:52:09] (03Merged) 10jenkins-bot: Fixed bogus var usage in SwiftFileBackend [core] - 10https://gerrit.wikimedia.org/r/106616 (owner: 10Aaron Schulz) [20:53:21] (03PS1) 10Bartosz Dziewoński: Remove max-width: 715px; for content per user feedback [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106618 [20:55:14] (03CR) 10Jdlrobson: [C: 04-2] "No. As stated this is by design." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106618 (owner: 10Bartosz Dziewoński) [20:55:32] (03Abandoned) 10Bartosz Dziewoński: Remove max-width: 715px; for content per user feedback [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106618 (owner: 10Bartosz Dziewoński) [20:57:42] (03CR) 10Chad: "Just because something is by design doesn't mean it's not a mistake." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106618 (owner: 10Bartosz Dziewoński) [20:58:38] (03CR) 10Bartosz Dziewoński: "(Note, this was previously raised as bug 59815, I intentionally didn't link it in the commit message.)" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106618 (owner: 10Bartosz Dziewoński) [20:59:58] <^d> MatmaRex: The installer was by design too. Doesn't mean it's a good design :) [21:06:48] <^d> AaronSchulz: I replied to you on https://gerrit.wikimedia.org/r/#/c/106443/ [21:07:31] jdlrobson: you around? [21:08:33] (03CR) 10Chad: [C: 032] Remove classes and functions deprecated in MediaWiki 1.17 [core] - 10https://gerrit.wikimedia.org/r/104156 (owner: 10Siebrand) [21:10:55] (03CR) 10Aaron Schulz: [C: 032] "I misread that comment" [core] - 10https://gerrit.wikimedia.org/r/106443 (owner: 10Chad) [21:11:54] (03Merged) 10jenkins-bot: Remove classes and functions deprecated in MediaWiki 1.17 [core] - 10https://gerrit.wikimedia.org/r/104156 (owner: 10Siebrand) [21:13:49] (03Merged) 10jenkins-bot: Make it easy to get the number of the currently running child [core] - 10https://gerrit.wikimedia.org/r/106443 (owner: 10Chad) [21:26:22] (03PS3) 10TheDJ: Remove extraneous border in CodeEditor [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104722 [21:26:57] (03CR) 10Swalling: "To expand on this:" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106618 (owner: 10Bartosz Dziewoński) [21:30:46] (03CR) 10Parent5446: Modify the Special:LonelyPages query to ignore disambiguation pages (031 comment) [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/106435 (owner: 10Kaldari) [21:31:07] (03CR) 10Bartosz Dziewoński: [C: 032] Remove extraneous border in CodeEditor [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104722 (owner: 10TheDJ) [21:31:09] (03Merged) 10jenkins-bot: Remove extraneous border in CodeEditor [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104722 (owner: 10TheDJ) [21:33:25] (03CR) 10Parent5446: [C: 031] Make a single # an invalid title in php and js [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender) [21:35:50] (03CR) 10Chad: "Is there a bug for this? Or something we're actively trying to fix?" [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender) [21:38:08] (03CR) 10AalekhN: "Adding new commit and abandoning this commit since my local memory got corrupted" [core] - 10https://gerrit.wikimedia.org/r/105991 (owner: 10AalekhN) [21:38:32] (03CR) 10Parent5446: "It's a bit of a follow-up to the previous patch where we made empty titles invalid. I think there is a bug for it, but the motivation is t" [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender) [21:39:25] (03Abandoned) 10AalekhN: A possible Solution to Bug 35486 [core] - 10https://gerrit.wikimedia.org/r/105991 (owner: 10AalekhN) [21:40:07] (03CR) 10Chad: "Legacy reasons implies there's still a reason for them to be allowed. We we very sure this isn't the case anymore?" [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender) [21:40:51] <^d> secureAndSplit(), scariest function in MediaWiki. [21:41:00] <^d> Well, after doAllQuotes(). Now *that* is some scary shit. [21:42:06] <^d> Hmm, it's doQuotes() now, must've gotten moved out of doAllQuotes(). [21:44:09] ^d: The EditPage class has some nice functions also... don't forget about it [21:44:26] <^d> EditPage doesn't exist. [21:44:34] <^d> I refuse to acknowledge that it exists. [21:44:35] <^d> :p [21:44:38] (03PS1) 10TheDJ: JSHint: fix the last jslint/hint failures [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/106623 [21:45:33] "Method length is 321 Lines (15 allowed)" :P [21:45:58] * hoo|away hoo [21:46:03] 321? that's nothing special :D [21:46:05] doh [21:46:19] MatmaRex: Well... EditPage is special [21:46:28] <^d> We should put more lines of code in them. Then we don't have to look as many places for the code. [21:46:32] hoo: check out SpecialWatchlist#execute [21:46:41] <^d> "Oh where's Foo? Oh, in Bar function like everything else" [21:46:46] (and after you do, merge my stack of changes that kills that monster) [21:46:50] MatmaRex: I know that... I worked with both classes... EditPage is the scariest one yet [21:47:05] <^d> We'll make MediaWiki one giant global function [21:47:13] <^d> wfMediaWiki() [21:47:17] just like in 2005! [21:47:30] <^d> Now now, don't be mean. [21:47:32] <^d> 2004. [21:48:13] 10 indents... wow [21:48:35] ^d: heh... ever looked at DokuWiki's source? :P [21:49:24] hoo: are you saying we just hired one of their devs because otherwise we wouldn't be able to understand their source? :D [21:49:35] [IIRC] [21:49:57] Nemo_bis: I'd already be happy if we understood our own source :P [21:49:58] :D [21:50:05] <^d> I understand our source. [21:50:10] <^d> The parts that matter, at least :) [21:50:24] +1 for the part that matters [21:50:40] who needs this page editing thing anyway... anybody using that? :P [21:51:02] hoo: heh, i wanted to one-up you, but Parser.php only goes up to 10 indents too [21:51:18] :D [21:51:39] Parser isn't what it used to be... [21:52:35] haha, ResourceLoader.php goes up to 12! [21:52:44] wow [21:52:50] but it's not really this scary [21:53:04] (03PS1) 10Aaron Schulz: Fixed http_build_query warnings on PHP < 5.4 [core] - 10https://gerrit.wikimedia.org/r/106624 [21:53:17] and i think that's the winner [21:53:24] some jquery junk goes up to 14, but that's not our code [21:53:31] <^d> Nobody wins here. [21:53:33] <^d> We all lose :p [21:54:05] (03CR) 10Chad: "Maybe it's time to bump the minimum ;-)" [core] - 10https://gerrit.wikimedia.org/r/106624 (owner: 10Aaron Schulz) [21:54:20] !5.4 [21:54:21] Traits? In MediaWiki? Yeah right, we wish. In the mean time, make your own wish: https://www.mediawiki.org/wiki/PHP_5.4 [21:55:46] <^d> Traits aren't nearly as cool as all of the nasty old shit they got rid of. [21:56:14] <^d> I like the fact that we won't have to modify GPCSERS superglobals anymore. [21:56:17] <^d> Or copy them into memory. [21:56:28] <^d> Or waste cycles checking if people were stupid and turned on settings they shouldn't. [21:57:13] :D Bad thing they removed register globals... luckily the brower vendors bring that fun back by polluting window with element ids (really, they do) [21:58:15] ^d: do update the !5.4 :) [21:58:59] <^d> I can do one better. [21:59:16] I'm a little afraid of people going round to replace the array syntax with "nicer" one after [21:59:25] maybe not necessary in core, but extensions [21:59:32] <^d> Nicer is relative. [21:59:37] <^d> I thought it was a stupid addition. [22:00:25] <^d> Mehhh, we can't bump to 5.4 [22:00:28] <^d> Stupid ubuntu lts. [22:00:50] I also still have an old CentOS server rotting around with php 5.3 [22:01:03] server actually isn't old... the OS just is [22:01:49] Biggest improvement is that they fixed some of the segfault issues [22:02:07] On we have with Wikibase and another one I found sometimes else (no clue) [22:02:10] * Pne [22:02:14] * One [22:02:41] <^d> We should run PHP nightlies on the cluster. [22:02:43] <^d> That'd be fun :) [22:03:00] ^d: Just wrap it into gdb :P [22:04:01] Reedy: https://gerrit.wikimedia.org/r/#/c/106624/ [22:04:47] (03CR) 10Chad: [C: 032] Fixed http_build_query warnings on PHP < 5.4 [core] - 10https://gerrit.wikimedia.org/r/106624 (owner: 10Aaron Schulz) [22:05:24] (03CR) 10TMg: [C: 04-1] "Strong oppose by that reasoning (German): https://de.wikipedia.org/wiki/Benutzer_Diskussion:PerfektesChaos#Vorlage:fullurl::" [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender) [22:05:26] (03PS1) 10AalekhN: SpecialWhatlinkshere.php : made Special:Whatlinkshere transclude [core] - 10https://gerrit.wikimedia.org/r/106625 [22:07:06] (03CR) 10AalekhN: "Link For the new commit plase reiew it" [core] - 10https://gerrit.wikimedia.org/r/105991 (owner: 10AalekhN) [22:08:36] (03PS1) 10Aaron Schulz: Fixed http_build_query warnings on PHP < 5.4 [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106626 [22:09:12] (03CR) 10Chad: [C: 032] Fixed http_build_query warnings on PHP < 5.4 [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106626 (owner: 10Aaron Schulz) [22:09:20] (03Merged) 10jenkins-bot: Fixed http_build_query warnings on PHP < 5.4 [core] - 10https://gerrit.wikimedia.org/r/106624 (owner: 10Aaron Schulz) [22:09:50] (03CR) 10Hoo man: "Just wanted to note that this isn't about anchors, but about Title object... and I really don't think that an empty string can make a vali" [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender) [22:10:11] * objects, doh [22:10:38] (03CR) 10TMg: [C: 04-1] "Same reasoning as here: https://gerrit.wikimedia.org/r/#/c/106561/" [core] - 10https://gerrit.wikimedia.org/r/98119 (owner: 10Bartosz Dziewoński) [22:12:47] (03Merged) 10jenkins-bot: Fixed http_build_query warnings on PHP < 5.4 [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106626 (owner: 10Aaron Schulz) [22:14:22] (03CR) 10TMg: "Why was this merged? What was the actual problem with using : as a title? Instead of fixing things this patch actually broke pages and rem" [core] - 10https://gerrit.wikimedia.org/r/99674 (owner: 10Umherirrender) [22:15:35] (03PS7) 10Alex Monk: Fix slightly broken behaviour with suppressed revisions on Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/40283 [22:17:09] (03CR) 10Parent5446: Make a single # an invalid title in php and js (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106561 (owner: 10Umherirrender) [22:17:24] (03CR) 10Hoo man: "The bug report (https://bugzilla.wikimedia.org/show_bug.cgi?id=54044) holds a valid reason to fix this handling. An empty title can't be s" [core] - 10https://gerrit.wikimedia.org/r/99674 (owner: 10Umherirrender) [22:18:20] when did people from dewiki discover gerrit? :P [22:18:27] (03CR) 10Alex Monk: "Decided it would be easier to rewrite what I had done in SpecialUndelete. Not 100% tested" [core] - 10https://gerrit.wikimedia.org/r/40283 (owner: 10Alex Monk) [22:19:14] (03CR) 10BryanDavis: [C: 032] "Change matches code in FSFileBackend and SwiftFileBackend." [core] - 10https://gerrit.wikimedia.org/r/106557 (owner: 10Aaron Schulz) [22:20:49] (03PS2) 10AalekhN: SpecialWhatlinkshere.php : made Special:Whatlinkshere transclude [core] - 10https://gerrit.wikimedia.org/r/106625 [22:22:28] (03Merged) 10jenkins-bot: Fixed file props test failure for MemoryFileBackend [core] - 10https://gerrit.wikimedia.org/r/106557 (owner: 10Aaron Schulz) [22:22:31] (03CR) 10CSteipp: [C: 031] "I approve of the concept. Someone else can merge my code :)" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/90546 (owner: 10Aklapper) [22:23:56] (03PS1) 10Ori.livneh: Update VisualEditor for cherry pick I5cc44c5ef35 (bug 59867) [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106628 [22:24:50] James_F: +1? [22:25:19] (03CR) 10Jforrester: [C: 031] Update VisualEditor for cherry pick I5cc44c5ef35 (bug 59867) [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106628 (owner: 10Ori.livneh) [22:25:25] Done. [22:25:43] James_F: did https://gerrit.wikimedia.org/r/#/c/97835/ make it into 10? [22:26:12] ori: Yes. That's what caused this breakage. [22:26:18] aha [22:26:24] i knew that [22:26:27] just testing you [22:26:35] ori: Code making it into 10 a few hours before the cut, after everyone had already tested everything. :-( [22:26:56] (03CR) 10Ori.livneh: [C: 032 V: 032] Update VisualEditor for cherry pick I5cc44c5ef35 (bug 59867) [core] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106628 (owner: 10Ori.livneh) [22:28:05] (03CR) 10Jforrester: "Caused bug 59867." [core] - 10https://gerrit.wikimedia.org/r/97835 (owner: 10Tpt) [22:36:06] (03PS11) 10MegaAlex: Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [22:42:48] (03PS2) 10Manybubbles: WIP:Split request logs out from debug logs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106430 [22:43:42] (03CR) 10Manybubbles: [C: 04-2] "-2 for WIP. WIP because it is not done but a start to look at." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106430 (owner: 10Manybubbles) [22:46:34] <^d> manybubbles: Oh man, you cleaned up Updater. [22:46:36] <^d> I <3 you [22:52:58] (03PS8) 10Milimetric: Implementing mediawiki oauth for node [passport-mediawiki] - 10https://gerrit.wikimedia.org/r/103866 [22:53:02] (03PS1) 10Cscott: Update dependencies for Ubuntu 12.04. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/106630 [22:53:03] (03PS1) 10Cscott: Update mocha dependency (again!). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/106631 [22:53:08] (03CR) 10Milimetric: [C: 032 V: 032] Implementing mediawiki oauth for node [passport-mediawiki] - 10https://gerrit.wikimedia.org/r/103866 (owner: 10Milimetric) [22:53:29] (03CR) 10Cscott: [C: 032] Update dependencies for Ubuntu 12.04. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/106630 (owner: 10Cscott) [22:53:38] (03CR) 10Cscott: [C: 032] Update mocha dependency (again!). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/106631 (owner: 10Cscott) [22:53:55] (03Merged) 10jenkins-bot: Update dependencies for Ubuntu 12.04. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/106630 (owner: 10Cscott) [22:54:00] (03Merged) 10jenkins-bot: Update mocha dependency (again!). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/106631 (owner: 10Cscott) [22:56:01] (03CR) 10Spage: [C: 04-1] "May Galloway's comments" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105426 (owner: 10Spage) [23:04:02] * AaronSchulz keeps ending up with Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/core commits [23:05:07] * AaronSchulz does reset and cherry-pick [23:07:50] (03PS1) 10Aaron Schulz: Make it a bit safer to paste input to eval.php [core] - 10https://gerrit.wikimedia.org/r/106632 [23:09:17] (03PS1) 10Aklapper: Fix a small typo in Bugzilla's sudo function [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106633 [23:09:52] <^d> AaronSchulz: `git pull -r` [23:10:17] (03CR) 10Aklapper: [C: 031] Fix a small typo in Bugzilla's sudo function [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106633 (owner: 10Aklapper) [23:14:05] mwalker, this is the dom templating stuff I mentioned: https://github.com/bebebebebe/templating [23:14:35] awesome; I shall review for tomorrow [23:14:37] distal rather than jstal [23:15:06] https://github.com/bebebebebe/templating/blob/master/distal/table.html [23:15:14] as an example of a table [23:18:51] (03PS15) 10Ori.livneh: Rename Watchlist request parameters for consistency with RC's ones [core] - 10https://gerrit.wikimedia.org/r/89380 (owner: 10Bartosz Dziewoński) [23:23:45] (03CR) 10Ori.livneh: [C: 032] "anti webmail hipster!" [core] - 10https://gerrit.wikimedia.org/r/89380 (owner: 10Bartosz Dziewoński) [23:26:48] (03Merged) 10jenkins-bot: Rename Watchlist request parameters for consistency with RC's ones [core] - 10https://gerrit.wikimedia.org/r/89380 (owner: 10Bartosz Dziewoński) [23:27:25] MatmaRex: It's slowly all getting merged. :-) [23:27:29] MatmaRex: Good work, BTW. [23:27:43] yay [23:27:45] thanks [23:32:53] mwalker, the distal implementation is 368 lines so pretty hackable [23:33:20] I'll also take a look at the angularjs and react implementations [23:34:14] should concentrate on the format though, adapting one of those implementations to slightly different syntax should not be hard [23:35:01] *nods* that's sorta what I was thinking; but I'll look too -- and explore XHP -- just so that I'm more familiar with what everyone else is doing