[00:08:55] <superm401>	 jdlrobson, the HTTPS link icon (the lock) doesn't seem to take effect on VectorBeta (it shows the external icon instead).
[00:08:58] <superm401>	 Wasn't sure if that was intentional.
[00:09:51] <kaldari>	 StevenW: Am I supposed to be deploying VectorBeta to wmf8, wmf9, or both?
[00:11:29] <Aaron|home>	 why is $wgLBFactoryConf giving deprecation notices? arg
[00:11:46] <Aaron|home>	 I mean easy to update, but seems silly
[00:21:52] <grrrit-wm>	 (03PS1) 10EBernhardson: Dont try and do sane things, like generalizing specific exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106165 
[00:22:52] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Revert "Utilize BufferedCache in TreeRepository" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106159 (owner: 10EBernhardson)
[00:22:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Utilize BufferedCache in TreeRepository" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106159 (owner: 10EBernhardson)
[00:22:59] <StevenW>	 kaldari: I think just wmf9
[00:23:06] <grrrit-wm>	 (03PS1) 10EBernhardson: Revert "Utilize BufferedCache in TreeRepository" [extensions/Flow] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106167 
[00:23:10] <StevenW>	 let me check
[00:23:40] <StevenW>	 yeah, wmf9
[00:23:42] <StevenW>	 kaldari: ^
[00:23:50] <kaldari>	 thanks
[00:24:34] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032] Revert "Utilize BufferedCache in TreeRepository" [extensions/Flow] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106167 (owner: 10EBernhardson)
[00:24:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Utilize BufferedCache in TreeRepository" [extensions/Flow] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106167 (owner: 10EBernhardson)
[00:24:55] <grrrit-wm>	 (03PS1) 10Kaldari: Update VectorBeta to master [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106168 
[00:25:16] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Update VectorBeta to master [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106168 (owner: 10Kaldari)
[00:25:42] <grrrit-wm>	 (03CR) 10Kaldari: [V: 032] Update VectorBeta to master [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106168 (owner: 10Kaldari)
[00:32:09] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 031] "I think FastCGI is a hard requirement -- the point of running HHVM behind Apache on Vagrant (rather than expose the built-in server direct" [vagrant] - 10https://gerrit.wikimedia.org/r/105834 (owner: 10EBernhardson)
[00:33:23] <Reedy>	 greg-g: CategoryTree bug reopened...
[00:33:24] <grrrit-wm>	 (03CR) 10Kaldari: "Oh, I didn't realize that VectorBeta totally replaced Vector either. Nevermind :)" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106153 (owner: 10Kaldari)
[00:33:38] <grrrit-wm>	 (03Abandoned) 10Kaldari: Removing 3 lines that are identical to those already in Vector [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106153 (owner: 10Kaldari)
[00:34:14] <Reedy>	 Uncaught ReferenceError: categoryTreeLoadChildren is not defined 
[00:35:04] <Reedy>	 Looks like a typo to me
[00:35:10] <Reedy>	 categoryTree.loadChildren
[00:37:07] <Reedy>	 categoryTreeLoadChildren is only  used one
[00:37:09] <Reedy>	 *once
[00:37:57] <Reedy>	 Hmm. If https://gerrit.wikimedia.org/r/#/c/88897/ had been merged more recently..
[00:39:52] <ori>	 backport!
[00:40:40] <Reedy>	 Backport what? :P
[00:41:10] <Reedy>	 Have we made any javascript scoping changes?
[00:44:15] <Reedy>	 ori: Busy?
[00:44:52] <ori>	 Reedy: about to head out in a few but i can look at something if it's quick
[00:44:53] <ori>	 what's up?
[00:45:31] <Reedy>	 console is complaining about categoryTreeLoadChildren not being defined
[00:45:41] <Reedy>	 Looking at the code, it doesn't seem to be done so as a global function
[00:45:55] <Reedy>	 there is however other places using categoryTree.loadChildren
[00:46:18] <Reedy>	 I just changed
[00:46:19] <Reedy>	 $html .= 'categoryTreeLoadChildren("' . Xml::escapeJsString( $title->getDBkey() ) . '", '
[00:46:20] <Reedy>	 for
[00:46:26] <Reedy>	 $html .= 'categoryTree.LoadChildren("' . Xml::escapeJsString( $title->getDBkey() ) . '", '
[00:46:35] <Reedy>	 Now it's Uncaught ReferenceError: categoryTree is not defined 
[00:47:25] <Reedy>	 Noting CategoryTreet code hasn't been changed in a while.. So presumably it's a change in core
[00:47:43] <ori>	 where are you seeing this?
[00:47:56] <Reedy>	 https://meta.wikimedia.org/wiki/Grants:PEG/Index/Reports
[00:48:00] <ori>	 sometimes ReferenceErrors are a red herring
[00:48:28] <ori>	 if there's a syntax error and a dependent script fails to parse
[00:48:29] <Reedy>	 The categoryTreeLoadChildren looks very odd when there's only one usage anywhere in the code
[00:48:56] <ori>	 could be a load-order issue too
[00:49:21] <ori>	 what extension is this coming from?
[00:49:26] <Reedy>	 CategoryTree
[00:50:15] <ori>	 it's also included in the page source so it has to load syncronously
[00:50:15] <Reedy>	 https://github.com/wikimedia/mediawiki-extensions-CategoryTree/commits/master
[00:50:27] <Reedy>	 No code changes since November
[00:50:39] <Reedy>	 And that was CSS
[00:54:03] <ori>	 it gets defined in a closure and yet the attempt to reference it is in global scope in a <script> tag
[00:54:04] * ori  boggles

[00:54:23] <grrrit-wm>	 (03CR) 10Jdlrobson: "This change seems to break any page served via MobileFrontend that uses Scribunto." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/5617 (owner: 10Tim Starling)
[00:55:10] <Reedy>	 And apparently worked in 1.23wmf8
[00:57:32] <ori>	 Reedy: https://gerrit.wikimedia.org/r/#/c/105623/ removed $wgAjax = true
[00:57:36] <ori>	 Reedy: was that intentional?
[00:57:48] <Reedy>	 Yes
[00:58:00] <Reedy>	 It is true by default in MW
[00:58:02] <ori>	 also $wgCategoryTreeDynamicTag = true; used to go before the extension was loaded
[00:58:26] <grrrit-wm>	 (03CR) 10Jdlrobson: "(I see this is an old patch so I'm not sure why I have only now run into this error.)" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/5617 (owner: 10Tim Starling)
[00:58:28] <Reedy>	 With it before, it won't make any difference
[00:58:59] <ori>	 right
[00:59:02] <ori>	 so it was false before
[00:59:14] <ori>	 because setting it to true wasn't doing anything
[00:59:16] <Reedy>	 $wgCategoryTreeDynamicTag = false;
[00:59:20] <ori>	 whereas now it actually sticks
[00:59:31] <ori>	 you turned a voodoo line into a line that does something
[00:59:34] <Reedy>	 $wgCategoryTreeDynamicTag is false in the extension too
[00:59:54] <Reedy>	 OH
[00:59:57] <Reedy>	 It's gonna be that isn't it
[00:59:57] <ori>	 yes :)
[01:00:17] <Reedy>	 I never bothered git blaming to find who added it in the wrong place...
[01:01:01] <Reedy>	 I'll kill that line
[01:01:27] <ori>	 and the wmgCategoryTreeDynamicTag bit in InitialiseSettings.php
[01:01:38] <ori>	 to make it clear that we're not actually specifying a value but letting the extension keep its default
[01:03:38] <Reedy>	 $wgCategoryTreeDynamicTag is false in the extension
[01:05:13] <grrrit-wm>	 (03CR) 10GWicke: "It adds a mechanism by which extensions can make themselves completely uncacheable. This makes it easy to continue depending on order of e" [core] - 10https://gerrit.wikimedia.org/r/99792 (owner: 10Anomie)
[01:07:58] <Reedy>	 Uncaught ReferenceError: categoryTreeLoadChildren is not defined
[01:08:41] <grrrit-wm>	 (03CR) 10Aaron Schulz: Make SELECT queries against slaves in updateCollation.php (032 comments) [core] - 10https://gerrit.wikimedia.org/r/106162 (owner: 10Reedy)
[01:11:03] <grrrit-wm>	 (03CR) 10Reedy: Make SELECT queries against slaves in updateCollation.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106162 (owner: 10Reedy)
[01:11:13] <marktraceur>	 Anyone have any idea how to get more information out of Jenkins for qunit?
[01:11:16] <marktraceur>	 https://integration.wikimedia.org/ci/job/mwext-MultimediaViewer-qunit/181/console
[01:11:22] <marktraceur>	 Not very helpful
[01:12:02] <grrrit-wm>	 (03PS1) 10Bsitu: Revert "Utilize BufferedCache in TreeRepository" [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106177 
[01:13:23] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 031] Revert "Utilize BufferedCache in TreeRepository" [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106177 (owner: 10Bsitu)
[01:15:37] <grrrit-wm>	 (03PS1) 10Kaldari: Update MobileFrontend [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106178 
[01:15:56] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032 V: 032] Update MobileFrontend [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106178 (owner: 10Kaldari)
[01:16:07] <grrrit-wm>	 (03PS1) 10Jackmcbarn: Use gender-neutral wording in Special:Preferences [core] - 10https://gerrit.wikimedia.org/r/106179 
[01:19:00] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032] Revert "Utilize BufferedCache in TreeRepository" [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106177 (owner: 10Bsitu)
[01:23:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Utilize BufferedCache in TreeRepository" [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106177 (owner: 10Bsitu)
[01:44:37] <Jasper_Deng>	 rschen7754 how do I set a filter's filter group? I see no such option in the filter interface
[01:44:59] <Jasper_Deng>	 it needs to be set to the Flow group
[01:45:33] <Jasper_Deng>	 ehh he's not in this channel
[01:45:33] <jackmcbarn>	 Jasper_Deng: it should be between description and hits
[01:45:54] <Jasper_Deng>	 it's not though
[01:46:07] <jackmcbarn>	 what server?
[01:46:18] <Jasper_Deng>	 mw.org
[01:46:27] <Jasper_Deng>	 there's no documentation on the extension page
[01:48:52] <grrrit-wm>	 (03PS2) 10Chad: Remove searchlimit preference [core] - 10https://gerrit.wikimedia.org/r/105871 
[01:49:41] <Aaron|home>	 $ ssh -V
[01:49:42] <Aaron|home>	 OpenSSH_4.6p1, OpenSSL 0.9.8e 23 Feb 2007
[01:49:54] <Aaron|home>	 csteipp: I'm sure mysysgit has no vulnerabilities or anything
[01:50:31] * Jasper_Deng  guesses quiddity is testing something, that IP has no contribs/logs

[01:50:48] <Jasper_Deng>	 oh right
[01:50:50] <Jasper_Deng>	 flow spam
[01:50:55] <Jasper_Deng>	 doesn't show up in logs
[01:51:16] <jackmcbarn>	 Jasper_Deng: i think i found the problem, i'll know in a minute
[01:51:18] <quiddity>	 yup. bug filed. Sorry and thanks
[01:51:40] <grrrit-wm>	 (03CR) 10Chad: Allow SearchResults to specify that they matched file content (032 comments) [core] - 10https://gerrit.wikimedia.org/r/105234 (owner: 10Chad)
[01:52:32] <grrrit-wm>	 (03CR) 10Chad: [C: 031] Automatically create new search index [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/104774 (owner: 10Chad)
[01:52:52] <quiddity>	 Jasper_Deng, rschen7754 is in #wikimedia-corefeatures if you still need to find him
[01:53:04] <Jasper_Deng>	 oh he's in stewards
[01:53:29] <Jasper_Deng>	 that'll explain why the filter isn't working though
[01:53:50] <jackmcbarn>	 Jasper_Deng: require_once "$IP/extensions/AbuseFilter/AbuseFilter.php"; needs to appear before require_once "$IP/extensions/Flow/Flow.php"; (and require_once "$IP/extensions/ArticleFeedbackv5/ArticleFeedbackv5.php";) in the config it looks like
[01:53:59] <jackmcbarn>	 because if AbuseFilter.php loads after, it clobbers the list of groups
[01:54:21] <Jasper_Deng>	 hhm... that would be a thing involving shuffling it around in the config file
[01:54:26] <Jasper_Deng>	 but it shouldn't be that way
[01:56:00] <jackmcbarn>	 i'll open a bug about it
[01:57:14] * Jasper_Deng  revdeletes the spam blacklist hit that lego pointed out in -stewards

[01:57:33] <Jasper_Deng>	 (revert if you don't like it)
[01:58:34] <jackmcbarn>	 hmm, that's odd. it looks like it does load in the "right" order
[01:58:37] * jackmcbarn  looks closer

[02:02:11] <Reedy>	 $wmg
[02:04:11] <^d>	 Reedy: https://gerrit.wikimedia.org/r/#/c/104774/ :)
[02:05:20] <jackmcbarn>	 okay, i'm totally clueless as to why the group doesn't show up
[02:06:08] <Jasper_Deng>	 maybe Reedy could find out why
[02:06:26] <Jasper_Deng>	 also, it depends on where abusefilter.php is included
[02:07:44] <Reedy>	 Not starting down another rabbit hole now
[02:08:13] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Automatically create new search index [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/104774 (owner: 10Chad)
[02:08:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Automatically create new search index [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/104774 (owner: 10Chad)
[02:25:58] <^d>	 Reedy: Thanks. Life will be easier now :)
[04:07:47] <grrrit-wm>	 (03PS5) 10Mattflaschen: Client-side wrapper for GettingStartedGetPages API [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103737 
[04:09:47] <grrrit-wm>	 (03CR) 10Mattflaschen: "Done in patch set 5." (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103737 (owner: 10Mattflaschen)
[04:10:05] <grrrit-wm>	 (03CR) 10Mattflaschen: "Removing -2 per further review and Phuedx's feedback" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103737 (owner: 10Mattflaschen)
[04:13:28] <grrrit-wm>	 (03CR) 10Legoktm: Add mw.ext.TitleBlacklist.test (033 comments) [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/105979 (owner: 10Jackmcbarn)
[04:22:15] <grrrit-wm>	 (03PS4) 10Jackmcbarn: Add mw.ext.TitleBlacklist.test [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/105979 
[04:30:36] <grrrit-wm>	 (03PS3) 10Mattflaschen: WIP: Remove uses of Special:GettingStarted from task toolbar [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103740 
[04:31:20] <grrrit-wm>	 (03CR) 10Mattflaschen: "Thanks. Done in patch set 3." (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103740 (owner: 10Mattflaschen)
[04:35:13] <grrrit-wm>	 (03PS1) 10Santhosh: Set up the extension with basic files and configurations [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106186 
[04:36:29] <grrrit-wm>	 (03PS2) 10Santhosh: Set up the extension with basic files and configurations [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106186 
[04:40:50] <Gloria>	 <ori> sometimes ReferenceErrors are a red herring
[04:40:54] <Gloria>	 Sometimes a cigar is just a cigar.
[04:47:19] <grrrit-wm>	 (03PS1) 10Parent5446: Add HMAC-cookie CSRF protection; deprecate session token [core] - 10https://gerrit.wikimedia.org/r/106187 
[04:51:23] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add HMAC-cookie CSRF protection; deprecate session token [core] - 10https://gerrit.wikimedia.org/r/106187 (owner: 10Parent5446)
[04:58:07] <grrrit-wm>	 (03CR) 10Parent5446: [C: 04-1] "WIP, reviews appreciated." [core] - 10https://gerrit.wikimedia.org/r/106187 (owner: 10Parent5446)
[04:59:36] <legoktm>	 that's a private bug...?
[05:04:24] <grrrit-wm>	 (03CR) 10Parent5446: Update documentation for database related classes (032 comments) [core] - 10https://gerrit.wikimedia.org/r/103890 (owner: 10Siebrand)
[05:05:58] <grrrit-wm>	 (03CR) 10Parent5446: [C: 031] Ensure variables in database classes are defined, used and correctly cased (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105722 (owner: 10Siebrand)
[05:08:11] <grrrit-wm>	 (03CR) 10Parent5446: "@Siebrand, the referenced patch for MF was merged. Is there still a conflict?" [core] - 10https://gerrit.wikimedia.org/r/96170 (owner: 10Legoktm)
[05:08:30] <ori>	 grrr, I found what is making that JPEG unit test fail
[05:09:06] <ori>	 it's an HHVM bug
[05:09:14] <Gloria>	 Which JPEG unit test?
[05:09:27] <ori>	 Gloria: https://travis-ci.org/wikimedia/mediawiki-core/builds/16555674
[05:10:00] <ori>	 1) BitmapMetadataHandlerTest::testIPTCDatesInvalid 
[05:10:06] <Gloria>	 Fun.
[05:10:24] <Gloria>	 https://integration.wikimedia.org/ci/job/mwext-Echo-testextensions-master/1130/console
[05:11:45] <grrrit-wm>	 (03CR) 10Parent5446: Add associated namespace option to Special:NewPages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/52676 (owner: 10MrBlueSky)
[05:19:29] <Aaron|home>	 Unable to find current revision in submodule path 'ValueView'
[05:19:31] <Aaron|home>	 annoying
[05:46:31] <grrrit-wm>	 (03PS7) 10Mattflaschen: Change modal to use API instead of special page, refactor [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103079 
[05:47:05] <grrrit-wm>	 (03CR) 10Mattflaschen: "Rebased" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103079 (owner: 10Mattflaschen)
[05:49:44] <grrrit-wm>	 (03PS4) 10Mattflaschen: WIP: Remove uses of Special:GettingStarted from task toolbar [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103740 
[05:51:31] <grrrit-wm>	 (03CR) 10Mattflaschen: "Rebased on top of https://gerrit.wikimedia.org/r/#/c/103079/7 ("Change modal..."). It doesn't really matter which JS module gets de-speci" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103740 (owner: 10Mattflaschen)
[05:53:34] <grrrit-wm>	 (03PS3) 10Santhosh: Set up the extension with basic files and configurations [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106186 
[06:07:31] <ori>	 anyone have php 5.5 handy?
[06:08:52] <legoktm>	 ori: km-mpb:projects km$ php --version
[06:08:52] <legoktm>	 PHP 5.5.7 (cli) (built: Dec 16 2013 17:00:24)
[06:10:20] <ori>	 legoktm: can you run this script:
[06:10:27] <ori>	 <?php var_dump( date_create( '19420713250502' ) );
[06:10:43] <legoktm>	 bool(false)
[06:11:14] <ori>	 k, thanks
[06:37:42] <ori>	 legoktm: https://bugzilla.wikimedia.org/show_bug.cgi?id=55532#c2 ftr
[06:39:31] <legoktm>	 neat
[06:39:58] <grrrit-wm>	 (03PS8) 10Aaron Schulz: Removed cloudfiles dependency in SwiftFileBackend [core] - 10https://gerrit.wikimedia.org/r/101226 
[06:52:31] <grrrit-wm>	 (03PS2) 10Parent5446: Add HMAC-cookie CSRF protection; deprecate session token [core] - 10https://gerrit.wikimedia.org/r/106187 
[06:54:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add HMAC-cookie CSRF protection; deprecate session token [core] - 10https://gerrit.wikimedia.org/r/106187 (owner: 10Parent5446)
[06:56:16] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "Do you mean that the URLs are longer than the prescribed maximum line length? If so, that's a pitty for policy." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/105989 (owner: 10Odder)
[07:06:36] <grrrit-wm>	 (03CR) 10Odder: "And that's the reason your -1 this patch? Good grief." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/105989 (owner: 10Odder)
[07:09:12] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] Set up the extension with basic files and configurations (035 comments) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106186 (owner: 10Santhosh)
[07:10:21] <grrrit-wm>	 (03CR) 10Nemo bis: [C: 04-1] "see bug" [core] - 10https://gerrit.wikimedia.org/r/106179 (owner: 10Jackmcbarn)
[07:11:33] <grrrit-wm>	 (03CR) 10Nemo bis: "(did you mean "they edits"?)" [core] - 10https://gerrit.wikimedia.org/r/106179 (owner: 10Jackmcbarn)
[07:12:39] <grrrit-wm>	 (03PS3) 10Parent5446: Add HMAC-cookie CSRF protection; deprecate session token [core] - 10https://gerrit.wikimedia.org/r/106187 
[07:13:09] <grrrit-wm>	 (03PS2) 10Siebrand: Set up jobs for ContentTranslation repo [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105941 
[07:14:23] <grrrit-wm>	 (03CR) 10Siebrand: "Odder: As I explain on my comment for PS1: Your change is not verifiable. You can also create one or two bugzilla reports with the change " [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/105989 (owner: 10Odder)
[07:17:52] <grrrit-wm>	 (03PS3) 10Nemo bis: Namespace translations for Serbian, Serbo-Croatian [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/105989 (owner: 10Odder)
[07:19:48] <grrrit-wm>	 (03CR) 10Nemo bis: "Odder, we have hundreds of (possibly over a thousand) commits with a (long) URL to translatewiki.net. It's good practice to link a bug or " [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/105989 (owner: 10Odder)
[07:23:15] <grrrit-wm>	 (03CR) 10Siebrand: "I prefer to not be involved in discussions about gender." [core] - 10https://gerrit.wikimedia.org/r/106179 (owner: 10Jackmcbarn)
[07:29:15] <grrrit-wm>	 (03CR) 10Siebrand: "@Tyler: I see this code in MobileFrontend.alias.php:" [core] - 10https://gerrit.wikimedia.org/r/96170 (owner: 10Legoktm)
[07:29:37] <grrrit-wm>	 (03PS1) 10Tim Weyer: Customized description [extensions/GlobalUserGroups] - 10https://gerrit.wikimedia.org/r/106195 
[07:31:15] <grrrit-wm>	 (03CR) 10Legoktm: "Hmm, looks like it got un-done in If61beb984e8e2c82375a85a7d4d629e6a148f47e." [core] - 10https://gerrit.wikimedia.org/r/96170 (owner: 10Legoktm)
[07:35:40] <grrrit-wm>	 (03CR) 10Odder: "But the link has been there all along – I pasted it into a comment in PS1." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/105989 (owner: 10Odder)
[07:36:32] <grrrit-wm>	 (03CR) 10Jforrester: "This'll be tedious if it doesn't allow over-riding of the handler for "edit", which is a long-term objective for integrating things like V" [core] - 10https://gerrit.wikimedia.org/r/96170 (owner: 10Legoktm)
[07:39:52] <grrrit-wm>	 (03CR) 10Legoktm: "Agreed, MZ brought that up at bug 11456#c13. I think the easiest way will be to just add a hook, and let the extension (VE) figure out wha" [core] - 10https://gerrit.wikimedia.org/r/96170 (owner: 10Legoktm)
[07:42:36] <grrrit-wm>	 (03CR) 10Jforrester: "WFM. We'll need to put equivalent hooks in about a thousand places in MW core, but at least we won't have to change this one. :-)" [core] - 10https://gerrit.wikimedia.org/r/96170 (owner: 10Legoktm)
[07:42:51] <legoktm>	 lol
[07:43:03] <James_F>	 legoktm: It's almost like we could have spoken in IRC. ;-)
[07:43:15] <legoktm>	 :P
[07:43:32] <James_F>	 legoktm: Actually, we're also thinking (long-term) about a visual history mode, so maybe a hook for that too?
[07:44:00] <legoktm>	 hooks are easy to add but hard to remove :/
[07:44:28] <legoktm>	 But I think it makes sense to add
[07:44:37] <legoktm>	 I need to rebase that entire thing
[07:44:54] <James_F>	 Sorry.
[07:45:32] <grrrit-wm>	 (03CR) 10Siebrand: Set up the extension with basic files and configurations (031 comment) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106186 (owner: 10Santhosh)
[07:45:33] <James_F>	 The alternative would be putting a hook on action=edit and have Special:Edit always call action=edit, whatever handles that this week.
[07:48:42] <grrrit-wm>	 (03PS4) 10Siebrand: Namespace translations for Serbian, Serbo-Croatian [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/105989 (owner: 10Odder)
[07:48:50] <grrrit-wm>	 (03CR) 10Nemo bis: "Sure, but only the commit is included in git log, git.wikimedia.org etc." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/105989 (owner: 10Odder)
[07:49:36] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] "Thanks." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/105989 (owner: 10Odder)
[07:50:21] <legoktm>	 James_F: err, that's basically what happens in this patch. Special:Edit/Foo just redirects to ?title=Foo&action=edit
[07:50:30] <James_F>	 legoktm: That's what I'm saying.
[07:50:32] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032 V: 032] Customized description [extensions/GlobalUserGroups] - 10https://gerrit.wikimedia.org/r/106195 (owner: 10Tim Weyer)
[07:50:48] <James_F>	 legoktm: As in, rather than have a hook here, leave it as is and do the hook purely on action=edit.
[07:51:00] <legoktm>	 ah.
[07:51:04] <Gloria>	 That change isn't ready.
[07:51:05] <James_F>	 legoktm: Given that it seems very odd to want different behaviour for action=edit and Special:Edit.
[07:51:18] <Gloria>	 If we add Special:Edit or whatever, we have to support it and its variants forever.
[07:51:24] <Gloria>	 And we're not ready to do that.
[07:51:37] <legoktm>	 why not?
[07:51:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Namespace translations for Serbian, Serbo-Croatian [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/105989 (owner: 10Odder)
[07:51:55] <Gloria>	 What problem is it solving?
[07:52:29] <legoktm>	 there is no way to link a user to the edit/history interface without an external link
[07:52:37] <Gloria>	 I think that's a parser problem.
[07:52:49] <James_F>	 Wat?
[07:52:51] <legoktm>	 eh?
[07:53:17] <Gloria>	 [https://en.wikipedia.org/w/index.php?title=foo&action=edit] isn't an external link.
[07:53:20] <Gloria>	 There's an open about this.
[07:53:23] <Gloria>	 Open bug, even.
[07:53:29] <James_F>	 You are confused.
[07:53:44] <Gloria>	 Okay.
[07:53:46] <James_F>	 We're not talking about whether the link shows up as external or internal in the skin (that isn't a parser bug).
[07:54:06] <James_F>	 We're talking about whether you can make an internal wikitext link (using [[ ]] rather than [ ]) for this function.
[07:54:14] <Gloria>	 Right.
[07:54:19] <Gloria>	 I'm saying that picking a syntax is problematic.
[07:54:21] <legoktm>	 oh
[07:54:22] <legoktm>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=11477
[07:54:33] <Gloria>	 And that the reason for the syntax being needed is probably unsound.
[07:54:52] <Gloria>	 The use-cases seem to revolve around link color and icon.
[07:55:01] <grrrit-wm>	 (03PS1) 10Siebrand: Replace deprecated User::editToken with User::getEditToken (1.19) [extensions/AuthorProtect] - 10https://gerrit.wikimedia.org/r/106196 
[07:55:06] <James_F>	 Gloria: But it's not picking a syntax, it's extending one already picked years ago.
[07:56:55] <Gloria>	 Should it be [[Special:Action/Edit]]? Why pollute the namespace with single words?
[07:57:12] <Gloria>	 Page links can't store the full link with internal links, I believe.
[07:57:18] <Gloria>	 With very long titles.
[07:57:31] <Gloria>	 But that's not as important.
[07:58:36] <James_F>	 So [[Special:WhatLinksHere]], [[Special:MovePage]], etc. should all be moved in your eyes?
[07:58:39] <Gloria>	 {{fullurl:}} covers this already.
[07:59:07] <Gloria>	 James_F: I'd prefer more consistency, personally.
[07:59:15] <James_F>	 Is that a yes?
[07:59:24] <Gloria>	 My hesitation is adding new Special pages to the root namespace and then having to support them forever.
[07:59:27] <Gloria>	 Because they will get used.
[07:59:28] <Gloria>	 And localized.
[07:59:44] <legoktm>	 The intention of my patch is that people will use it ;)
[07:59:47] <Gloria>	 And in many cases, it's not even clear why it's preferable other than link color.
[07:59:59] <grrrit-wm>	 (03PS9) 10Aaron Schulz: Removed cloudfiles dependency in SwiftFileBackend [core] - 10https://gerrit.wikimedia.org/r/101226 
[08:00:16] <grrrit-wm>	 (03CR) 10Siebrand: Allow SearchResults to specify that they matched file content (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105234 (owner: 10Chad)
[08:00:20] <legoktm>	 consistenty.
[08:00:21] <Gloria>	 It may end up that we use action paths.
[08:00:25] <legoktm>	 consistency*
[08:00:29] <Gloria>	 We could have [/edit/foo text]
[08:00:35] <legoktm>	 Action paths would be nice
[08:00:57] <legoktm>	 But no reason that should stop us from this too.
[08:00:59] <grrrit-wm>	 (03CR) 10Aaron Schulz: "Passing all tests with Ceph .72 Emperor" [core] - 10https://gerrit.wikimedia.org/r/101226 (owner: 10Aaron Schulz)
[08:01:01] <James_F>	 I'd love https://en.wikipedia.org/edit/Foobar and https://en.wikipedia.org/history/Foobar to work.
[08:01:09] <legoktm>	 https://wikitech.wikimedia.org/wiki/Action_paths
[08:01:13] <James_F>	 But this doesn't have anything to do with that.
[08:01:22] <James_F>	 Raise a site config bug.
[08:01:39] <legoktm>	 Also that would re-bring up the actions versus special pages issue
[08:01:45] <Gloria>	 Right.
[08:02:03] <Gloria>	 Plus "Edit" should really be "EditPage", no?
[08:02:17] <James_F>	 Why?
[08:02:21] <James_F>	 The action name is "edit".
[08:02:27] <legoktm>	 I'd probably rename MovePage --> Move.
[08:02:45] <James_F>	 The fact that it's "EditPage.php" due to archaîc code reasons isn't a good one.
[08:02:47] <Gloria>	 So will it be Special:VEEdit?
[08:02:50] <James_F>	 legoktm: Yes.
[08:03:04] <grrrit-wm>	 (03PS1) 10Siebrand: Replace deprecated User::editToken with User::getEditToken (1.19) [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/106197 
[08:03:09] <James_F>	 Gloria: Long term, we'll probably over-ride action=edit.
[08:03:10] <Gloria>	 James_F: You could have multiple types of editing.
[08:03:21] <Gloria>	 Like editing an item.
[08:03:24] <Gloria>	 Special:EditItem
[08:03:26] <grrrit-wm>	 (03PS1) 10Siebrand: Replace deprecated User::editToken with User::getEditToken (1.19) [extensions/Video] - 10https://gerrit.wikimedia.org/r/106198 
[08:03:37] <Gloria>	 In that context, it would make sense to not have an ambiguous Special:Edit.
[08:03:51] <James_F>	 Gloria: Or Special:Edit could be written properly and able to work out what editor to provide you with?
[08:04:38] <James_F>	 So Special:Edit/<page> edits the page, but Special:Edit/<item>/<title> lets you edit the Wikibase item's title?
[08:05:05] <Gloria>	 https://www.wikidata.org/wiki/Q40?action=edit
[08:05:36] <James_F>	 Wikibase has some development holes. News at 11.
[08:05:47] <legoktm>	 Not a bug, feature!
[08:05:48] * YuviPanda  11

[08:05:49] <Gloria>	 Being explicit is generally preferable to not.
[08:05:53] <YuviPanda>	 gah, nevermind.
[08:05:54] <Gloria>	 With URL parameters, you're explicit.
[08:06:08] <Gloria>	 With slash separators, it's not as easy.
[08:06:30] <Gloria>	 I think before we add a bunch of special pages, we take time to consider the issue further.
[08:06:33] <Gloria>	 That was my point.
[08:07:40] <Gloria>	 We could also just extend internal wikilink syntax.
[08:07:48] <Gloria>	 [[foo|bar|edit]]
[08:07:55] <James_F>	 Ha.
[08:07:55] <James_F>	 No.
[08:08:06] <James_F>	 You have no idea what our corpus is like.
[08:08:08] <Gloria>	 We could have layered pipe tricks.
[08:08:13] <Gloria>	 I have some idea.
[08:08:21] <Gloria>	 {{#edit:foo}}
[08:08:28] <James_F>	 And yet you suggest a breaking change to wikitext.
[08:08:56] <Gloria>	 It would be the first.
[08:11:18] <YuviPanda>	 hmm, no hashar. sigh
[08:11:25] <grrrit-wm>	 (03PS1) 10Siebrand: Replace deprecated User::editToken with User::getEditToken (1.19) [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/106200 
[08:11:36] <James_F>	 YuviPanda: Probably not for an hour or so.
[08:11:51] <grrrit-wm>	 (03PS1) 10Siebrand: Replace deprecated User::editToken with User::getEditToken (1.19) [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/106201 
[08:12:12] <YuviPanda>	 James_F: yeah, I've forced myself into a more regular sleep cycle, so wake up during Indian mornings than eastern european mornings :)
[08:12:39] <James_F>	 YuviPanda: Boo. :-)
[08:12:45] <YuviPanda>	 heh
[08:12:59] <grrrit-wm>	 (03PS1) 10Siebrand: Replace deprecated User::editToken with User::getEditToken (1.19) [extensions/Commentbox] - 10https://gerrit.wikimedia.org/r/106202 
[08:13:02] <James_F>	 YuviPanda: How can I rely on you to keep US hours if you don't?! ;-)
[08:13:11] <YuviPanda>	 haha :D
[08:13:19] <YuviPanda>	 James_F: I sleep at 12PST sharp now
[08:13:30] <YuviPanda>	 and even eat three times a day! 
[08:13:53] <James_F>	 … is that three bowls of food one after the other in the morning? ;-)
[08:14:10] <legoktm>	 siebrand: are you submitting those manually?
[08:14:30] <grrrit-wm>	 (03PS1) 10Siebrand: Replace deprecated User::editToken with User::getEditToken (1.19) [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/106205 
[08:14:47] <grrrit-wm>	 (03PS1) 10Siebrand: Replace deprecated User::editToken with User::getEditToken (1.19) [extensions/CommunityVoice] - 10https://gerrit.wikimedia.org/r/106206 
[08:15:48] <grrrit-wm>	 (03PS1) 10Siebrand: Replace deprecated User::editToken with User::getEditToken (1.19) [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/106207 
[08:16:17] <grrrit-wm>	 (03PS1) 10Siebrand: Replace deprecated User::editToken with User::getEditToken (1.19) [extensions/LogEntry] - 10https://gerrit.wikimedia.org/r/106208 
[08:16:35] <grrrit-wm>	 (03PS1) 10Siebrand: Replace deprecated User::editToken with User::getEditToken (1.19) [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/106209 
[08:16:42] <grrrit-wm>	 (03CR) 10PleaseStand: [C: 04-1] Add Reference to relevant bug in new MSIE 6 CSS sanitization tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106160 (owner: 10GWicke)
[08:16:47] <grrrit-wm>	 (03PS1) 10Siebrand: Replace deprecated User::editToken with User::getEditToken (1.19) [extensions/CreateRedirect] - 10https://gerrit.wikimedia.org/r/106210 
[08:17:56] <grrrit-wm>	 (03CR) 10Hydriz: [C: 032 V: 032] Replace deprecated User::editToken with User::getEditToken (1.19) [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/106201 (owner: 10Siebrand)
[08:18:07] <siebrand>	 legoktm: yes
[08:18:14] <legoktm>	 :o
[08:18:52] <legoktm>	 When I did it, I made all the changes via PHPStorm's find + replace, then had a python script show me the diff and then autosubmit
[08:19:01] <grrrit-wm>	 (03PS2) 10Siebrand: Replace deprecated User::editToken with User::getEditToken (1.19) [extensions/CommunityVoice] - 10https://gerrit.wikimedia.org/r/106206 
[08:20:01] <Nemo_bis>	 legoktm: commit the script to mediawiki/tools ? :)
[08:21:27] <legoktm>	 let me find it...it was pretty simple
[08:21:47] <grrrit-wm>	 (03PS1) 10Siebrand: Replace deprecated User::editToken with User::getEditToken (1.19) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/106211 
[08:22:01] <grrrit-wm>	 (03PS1) 10Yuvipanda: Add simple RL module with current pagestyles from Android app [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/106212 
[08:22:04] <siebrand>	 I have scripts to commit and push to all repos.
[08:22:05] <YuviPanda>	 legoktm: trivial patch for an extension that's not deployed ^?
[08:22:12] <legoktm>	 sure
[08:24:08] <grrrit-wm>	 (03CR) 10Legoktm: Add simple RL module with current pagestyles from Android app (033 comments) [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/106212 (owner: 10Yuvipanda)
[08:24:09] <grrrit-wm>	 (03PS2) 10Siebrand: Replace deprecated User::editToken with User::getEditToken (1.19) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/106211 
[08:26:21] <grrrit-wm>	 (03PS1) 10Siebrand: Replace deprecated User::editToken with User::getEditToken (1.19) [core] - 10https://gerrit.wikimedia.org/r/106213 
[08:28:41] <grrrit-wm>	 (03PS4) 10Santhosh: Set up the extension with basic files and configurations [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106186 
[08:29:24] <grrrit-wm>	 (03PS2) 10Yuvipanda: Add simple RL module with current pagestyles from Android app [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/106212 
[08:29:30] <YuviPanda>	 legoktm: so, localpath isn't needed if I specify the full path, which I am
[08:29:43] <YuviPanda>	 legoktm: I am doing that because I might have to reuse styles from MF, and this makes it easier
[08:30:28] <YuviPanda>	 legoktm: and I think remoteextpath is only needed if you have images and stuff, which this one does not...
[08:33:22] <YuviPanda>	 legoktm: so I guess it's ok?
[08:33:31] <YuviPanda>	 well, I'll just put them in anyway
[08:33:32] <YuviPanda>	 clearer
[08:35:25] <YuviPanda>	 legoktm: updated! :)
[08:35:28] <grrrit-wm>	 (03PS3) 10Yuvipanda: Add simple RL module with current pagestyles from Android app [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/106212 
[08:40:11] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032 V: 032] Set up the extension with basic files and configurations [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106186 (owner: 10Santhosh)
[08:42:01] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032 V: 032] Add simple RL module with current pagestyles from Android app [extensions/MobileApp] - 10https://gerrit.wikimedia.org/r/106212 (owner: 10Yuvipanda)
[08:42:07] <YuviPanda>	 legoktm: thanks!
[08:42:09] <legoktm>	 YuviPanda: sorry, was afk for a bit
[08:42:10] <legoktm>	 :)
[08:42:21] <YuviPanda>	 now to get this deployed on betalabs
[08:42:42] <YuviPanda>	 hey hashar!
[08:43:17] <hashar>	 good morning
[08:43:26] <grrrit-wm>	 (03PS1) 10KartikMistry: Add special page Special:ContentTranslation [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106214 
[08:43:28] <legoktm>	 good night for me :)
[08:43:29] <YuviPanda>	 hashar: good morning! :)
[08:43:36] <YuviPanda>	 legoktm: heh, go sleep!
[08:43:57] <YuviPanda>	 hashar: I asked Chris about getting an extension deployed on BetaLabs, and was told to ping you to find out what to do.
[08:44:38] <hashar>	 ah
[08:44:43] <hashar>	 we should write a doc about it :-D
[08:44:48] <YuviPanda>	 yes, yes :D
[08:45:00] <YuviPanda>	 hashar: this should be trivial, since all it does is have a bunch of RL modules. No other code whatsoever.
[08:45:03] <YuviPanda>	 (for the wikipedia app)
[08:45:17] <hashar>	 YuviPanda: https://etherpad.wikimedia.org/p/beta-new-ext
[08:45:21] <YuviPanda>	 mmm!
[08:45:31] * YuviPanda  watchs

[08:45:34] <YuviPanda>	 *watches
[08:46:38] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "Code uses global method that's been deprecated since 1.18." (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/106152 (owner: 10Aaron Schulz)
[08:48:18] <grrrit-wm>	 (03CR) 10Siebrand: Handle missing revisions a bit better (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/106152 (owner: 10Aaron Schulz)
[08:49:23] <hashar>	 ahh
[08:49:28] <hashar>	 YuviPanda:  it is already somewhere on https://wikitech.wikimedia.org/wiki/Nova_Resource:Deployment-prep/How_code_is_updated :D
[08:49:35] <hashar>	 will copy paste there
[08:49:41] <YuviPanda>	 :D
[08:49:55] <hashar>	 there must be a documentation for production already
[08:50:31] <YuviPanda>	 ya
[08:50:50] <YuviPanda>	 but MaxSem will probably do the deployment when it is time
[08:51:00] <YuviPanda>	 and I've already followed the 'how to write an extension for deployment'
[08:51:57] <grrrit-wm>	 (03CR) 10Siebrand: "This was partially reverted in https://gerrit.wikimedia.org/r/#/c/106146." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95519 (owner: 10Aaron Schulz)
[08:52:15] <hashar>	 YuviPanda: https://wikitech.wikimedia.org/wiki/Nova_Resource:Deployment-prep/How_code_is_updated#How_to_add_a_new_extension_on_beta
[08:52:21] <YuviPanda>	 owoo, thanks!
[08:52:55] <hashar>	 YuviPanda: you can read the 'my code introduces a new features that is not yet for production'  at the bottom
[08:53:16] <hashar>	 which explains the feature switch
[08:54:18] <hashar>	 YuviPanda: and remember that operations/mediawiki-config.git is shared between production and beta :-D So you don't want the extension to be enabled in production if it is not ready / added to wmf branches yet.
[08:54:47] <hashar>	 added that to wiki page
[08:56:02] <YuviPanda>	 hashar: hmm, so I'm a bit confused about this extension
[08:56:12] <YuviPanda>	 hashar: since it only has CSS files and nothing more.
[08:56:21] <YuviPanda>	 so... no PHP at all
[08:56:38] <hashar>	 ah also, the extension should be planned for deployment to production
[08:56:43] <hashar>	 beta is not meant to be a dev area
[08:56:46] <YuviPanda>	 ofcourse
[08:56:54] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "-1 for open questions." (033 comments) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106214 (owner: 10KartikMistry)
[08:56:57] <YuviPanda>	 the app is going to be released in end of february
[08:57:01] <YuviPanda>	 so that's about 6 weeks away
[08:57:18] <YuviPanda>	 hashar: so I want this to be in beta for a week or so and then it can ride the train, I guess
[08:57:59] <hashar>	 sounds good
[08:58:09] <hashar>	 what is the extension name ?
[08:58:26] <YuviPanda>	 hashar: MobileApp
[09:01:33] <hashar>	 I am not sure why you need yet another extension though
[09:01:38] <hashar>	 don't we have MobileFrontend already ?
[09:02:51] <YuviPanda>	 hashar: that's for the web, and this is for the app. not much cross-use, and also very different teams.
[09:03:02] <grrrit-wm>	 (03PS1) 10Pastakhov: update to version 0.4.3 [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/106216 
[09:14:38] <grrrit-wm>	 (03CR) 10Pastakhov: [C: 032] update to version 0.4.3 [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/106216 (owner: 10Pastakhov)
[09:14:48] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] update to version 0.4.3 [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/106216 (owner: 10Pastakhov)
[09:20:19] <grrrit-wm>	 (03PS1) 10Parent5446: Changed temporary password system to use tokens. [core] - 10https://gerrit.wikimedia.org/r/106218 
[09:20:32] <grrrit-wm>	 (03CR) 10Parent5446: "See https://gerrit.wikimedia.org/r/106218" [core] - 10https://gerrit.wikimedia.org/r/27472 (owner: 10Parent5446)
[09:20:33] <ori>	 andre__: hello! am i wrong in thinking that there used to be an HHVM keyword in BZ?
[09:27:30] <andre__>	 ori: No you are right, but it was used for four tickets or so, so it was turned into a tracking bug
[09:28:01] <ori>	 andre__: platform is taking it on in earnest this coming quarter, so it's likely to see a *lot* more activity
[09:28:08] <andre__>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=40926
[09:28:33] <ori>	 there will be a very long tail of small bugs to fix to power through the migration, and in fact how well we keep track of them will be one of the biggest tests of the migration process
[09:28:56] <andre__>	 yeah, see comment 2 there in the report
[09:29:08] <andre__>	 ori, could you add a comment to that report?
[09:29:15] <ori>	 yeah, definitely
[09:29:51] * andre__  whistles and mumbles "It wasn't me!"

[09:34:39] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Let me just say, with no +1 or -1, that I don't believe this to be an improvement." [core] - 10https://gerrit.wikimedia.org/r/106179 (owner: 10Jackmcbarn)
[09:34:52] <ori>	 yeah, as soon as you mentioned it i remembered that bug
[09:39:16] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Improved vague/incomplete $1 thumb.php error messages [core] - 10https://gerrit.wikimedia.org/r/106219 
[09:40:29] <grrrit-wm>	 (03PS2) 10Parent5446: Changed temporary password system to use tokens. [core] - 10https://gerrit.wikimedia.org/r/106218 
[09:43:49] <grrrit-wm>	 (03CR) 10Parent5446: [C: 04-1] "Also needs rebase. The SpecialPage classes have since been split into different files and put into a directory." [core] - 10https://gerrit.wikimedia.org/r/96170 (owner: 10Legoktm)
[09:44:12] <ori>	 andre__: is that enough for re-instating it?
[09:44:31] <ori>	 i'd be a bit disappointed if we had to seriously debate it
[09:44:42] <andre__>	 ori, I hope so. I'll wait a little bit more for feedback but if there's none I'll go ahead soon
[09:50:34] <ori>	 andre__: cool, much obliged. (also: hi!)
[09:50:41] <andre__>	 :)
[09:50:56] <grrrit-wm>	 (03PS2) 10Santhosh: Add special page Special:ContentTranslation [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106214 (owner: 10KartikMistry)
[09:54:49] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "i18n reviewed." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/106219 (owner: 10Aaron Schulz)
[09:55:38] <grrrit-wm>	 (03PS3) 10Santhosh: Add special page Special:ContentTranslation [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106214 (owner: 10KartikMistry)
[09:56:17] <grrrit-wm>	 (03CR) 10Aaron Schulz: Improved vague/incomplete $1 thumb.php error messages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106219 (owner: 10Aaron Schulz)
[09:56:22] * Aaron|home  sighs

[09:57:05] <grrrit-wm>	 (03PS1) 10Amire80: Adding initial GWT scenarios [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106221 
[09:58:06] <grrrit-wm>	 (03PS2) 10Aaron Schulz: Handle missing revisions a bit better [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/106152 
[09:58:51] <grrrit-wm>	 (03CR) 10Yuvipanda: "Trying to test this locally..." [vagrant] - 10https://gerrit.wikimedia.org/r/105834 (owner: 10EBernhardson)
[09:59:11] <grrrit-wm>	 (03PS2) 10Ori.livneh: Use file handle caching in newSequentialPerNodeIDs() [core] - 10https://gerrit.wikimedia.org/r/105241 (owner: 10Aaron Schulz)
[09:59:19] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Use file handle caching in newSequentialPerNodeIDs() [core] - 10https://gerrit.wikimedia.org/r/105241 (owner: 10Aaron Schulz)
[09:59:57] <grrrit-wm>	 (03PS4) 10KartikMistry: Add special page Special:ContentTranslation [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106214 
[10:00:16] <grrrit-wm>	 (03CR) 10SuchetaG: [C: 032] Adding initial GWT scenarios [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106221 (owner: 10Amire80)
[10:02:08] <grrrit-wm>	 (03CR) 10SuchetaG: [V: 032] Adding initial GWT scenarios [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106221 (owner: 10Amire80)
[10:03:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use file handle caching in newSequentialPerNodeIDs() [core] - 10https://gerrit.wikimedia.org/r/105241 (owner: 10Aaron Schulz)
[10:04:32] <grrrit-wm>	 (03PS2) 10Aaron Schulz: Removed unused postConnectionBackoff() from LoadMonitor [core] - 10https://gerrit.wikimedia.org/r/105140 
[10:10:21] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] Add special page Special:ContentTranslation (034 comments) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106214 (owner: 10KartikMistry)
[10:11:57] <grrrit-wm>	 (03CR) 10Siebrand: Changed temporary password system to use tokens. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106218 (owner: 10Parent5446)
[10:12:50] * ori  waves

[10:15:01] <grrrit-wm>	 (03PS2) 10Pastakhov: update to version 0.4.3 [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/106216 
[10:15:21] <grrrit-wm>	 (03CR) 10Pastakhov: [C: 032] update to version 0.4.3 [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/106216 (owner: 10Pastakhov)
[10:15:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: update to version 0.4.3 [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/106216 (owner: 10Pastakhov)
[10:15:45] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] Removed unused postConnectionBackoff() from LoadMonitor [core] - 10https://gerrit.wikimedia.org/r/105140 (owner: 10Aaron Schulz)
[10:16:49] <grrrit-wm>	 (03CR) 10Yuvipanda: "$wgServer is set to 127.0.0.1:8080, so hitting 9999 just redirects to that." [vagrant] - 10https://gerrit.wikimedia.org/r/105834 (owner: 10EBernhardson)
[10:17:14] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 04-1] Hack together apache -> hhvm [vagrant] - 10https://gerrit.wikimedia.org/r/105834 (owner: 10EBernhardson)
[10:17:18] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n reviewed." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/106152 (owner: 10Aaron Schulz)
[10:17:27] <grrrit-wm>	 (03PS5) 10KartikMistry: Add special page Special:ContentTranslation [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106214 
[10:19:42] <grrrit-wm>	 (03CR) 10Yuvipanda: "curl -I '127.0.0.1:9000/w/index.php?title=Special:Version'" [vagrant] - 10https://gerrit.wikimedia.org/r/105834 (owner: 10EBernhardson)
[10:20:01] <grrrit-wm>	 (03CR) 10Siebrand: Improved vague/incomplete $1 thumb.php error messages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106219 (owner: 10Aaron Schulz)
[10:21:27] <gi11es>	 I'm trying to set up gerrit locally to push to MultimediaViewer, the same I did for UploadWizard
[10:21:40] <gi11es>	 but I don't see the "gerrit" remote(s) for that repo
[10:22:12] <gi11es>	 as a result, can't do git review -s
[10:22:37] <gi11es>	 does anybody know what I might be missing? as far as I'm aware, I set things up the same way I did for UploadWizard
[10:22:40] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 (owner: 10Catrope)
[10:24:04] <gi11es>	 or maybe git review -s the step that actually adds the gerrit remote?
[10:24:22] <grrrit-wm>	 (03PS1) 10Amire80: Add env.rb and clarify the GWT [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106222 
[10:26:10] <grrrit-wm>	 (03CR) 10SuchetaG: [C: 032 V: 032] Add env.rb and clarify the GWT [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106222 (owner: 10Amire80)
[10:26:20] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Call to a member function getCommonMetaArray() on a non-object at File.php on line 586 [core] - 10https://gerrit.wikimedia.org/r/105998 (owner: 10Reedy)
[10:26:34] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Call to a member function getCommonMetaArray() on a non-object at File.php on line 586 [core] - 10https://gerrit.wikimedia.org/r/105998 (owner: 10Reedy)
[10:28:06] <gi11es>	 ah, seems like I can't ssh anymore, that must be it. odd that it worked fine yesterday
[10:28:45] <grrrit-wm>	 (03PS2) 10Siebrand: Call to a member function getCommonMetaArray() on a non-object at File.php on line 586 [core] - 10https://gerrit.wikimedia.org/r/105998 (owner: 10Reedy)
[10:28:57] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Call to a member function getCommonMetaArray() on a non-object at File.php on line 586 [core] - 10https://gerrit.wikimedia.org/r/105998 (owner: 10Reedy)
[10:28:59] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Call to a member function getCommonMetaArray() on a non-object at File.php on line 586 [core] - 10https://gerrit.wikimedia.org/r/105998 (owner: 10Reedy)
[10:29:03] <hashar>	 :(
[10:29:13] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Call to a member function getCommonMetaArray() on a non-object at File.php on line 586 [core] - 10https://gerrit.wikimedia.org/r/105998 (owner: 10Reedy)
[10:29:29] <hashar>	 Reedy: siebrand I think I screwed something on jenkins
[10:30:16] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "Please update the commit message in accordance with https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines" [core] - 10https://gerrit.wikimedia.org/r/106001 (owner: 10AalekhN)
[10:30:44] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "sorry screwed jenkins :(" [core] - 10https://gerrit.wikimedia.org/r/105998 (owner: 10Reedy)
[10:34:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Call to a member function getCommonMetaArray() on a non-object at File.php on line 586 [core] - 10https://gerrit.wikimedia.org/r/105998 (owner: 10Reedy)
[10:36:45] <grrrit-wm>	 (03PS1) 10Cargan: fixed spacing [core] - 10https://gerrit.wikimedia.org/r/106225 
[10:47:02] <gi11es>	 is it normal for gerrit/master to be behind origin/master? with the extra commits all coming from bots
[10:48:58] <hashar>	 gi11es: you have two remotes, one of them being out of date
[10:49:27] <hashar>	 gi11es:  git-review uses (by default) a remote named 'gerrit'
[10:49:39] <hashar>	 but you can ask git-review to use 'origin' as a default instead
[10:50:17] <hashar>	 using the parameter defaultremote  
[10:52:16] <gi11es>	 ah, updating the remotes did the trick, thanks
[10:52:48] <grrrit-wm>	 (03PS2) 10Gilles: Solves visibility issue on the progress bar [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105694 
[11:08:22] <siebrand>	 hashar: no problem. That happens.
[11:09:08] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] "Thanks." [core] - 10https://gerrit.wikimedia.org/r/106225 (owner: 10Cargan)
[11:09:18] <grrrit-wm>	 (03CR) 10Santhosh: [C: 032] Add special page Special:ContentTranslation [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106214 (owner: 10KartikMistry)
[11:11:05] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Set up jobs for ContentTranslation repo [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105941 (owner: 10Siebrand)
[11:11:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Set up jobs for ContentTranslation repo [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105941 (owner: 10Siebrand)
[11:12:22] <grrrit-wm>	 (03CR) 10Hashar: "deployed" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105941 (owner: 10Siebrand)
[11:20:02] <grrrit-wm>	 (03CR) 10Santhosh: [V: 032] Add special page Special:ContentTranslation [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106214 (owner: 10KartikMistry)
[11:21:23] <grrrit-wm>	 (03CR) 10Siebrand: "Thanks" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105941 (owner: 10Siebrand)
[11:22:30] <grrrit-wm>	 (03PS2) 10Hashar: Zuul status page: support for progress bar [integration/docroot] - 10https://gerrit.wikimedia.org/r/105967 
[11:23:41] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "had to fix up styling a bit, renamed change_progress CSS class to zuul-change-progress." [integration/docroot] - 10https://gerrit.wikimedia.org/r/105967 (owner: 10Hashar)
[11:23:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Zuul status page: support for progress bar [integration/docroot] - 10https://gerrit.wikimedia.org/r/105967 (owner: 10Hashar)
[11:23:48] <hashar>	 oh
[11:23:50] <hashar>	 that is fast
[11:25:56] <grrrit-wm>	 (03PS1) 10Amire80: Add a steps file with all steps pending [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106227 
[11:26:35] <grrrit-wm>	 (03CR) 10KartikMistry: [C: 032] "LGTM." [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106227 (owner: 10Amire80)
[11:26:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add a steps file with all steps pending [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106227 (owner: 10Amire80)
[11:29:09] <grrrit-wm>	 (03CR) 10Hashar: "recheck" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/106116 (owner: 10Hashar)
[12:15:06] <grrrit-wm>	 (03PS1) 10Amire80: Add ContentTranslationPage class to the browser tests [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106228 
[12:16:26] <grrrit-wm>	 (03CR) 10KartikMistry: [C: 032] "LGTM." [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106228 (owner: 10Amire80)
[12:16:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add ContentTranslationPage class to the browser tests [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106228 (owner: 10Amire80)
[12:38:58] <grrrit-wm>	 (03PS1) 10Hydriz: Migrating to use new JSON message backend. [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/106229 
[12:46:21] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "I18n reviewed" (031 comment) [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/106229 (owner: 10Hydriz)
[12:48:54] <grrrit-wm>	 (03CR) 10Siebrand: Add a steps file with all steps pending (031 comment) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106227 (owner: 10Amire80)
[12:53:21] <grrrit-wm>	 (03PS1) 10Hydriz: Fix missing apostrophe in maintenance/generateJsonI18n.php [core] - 10https://gerrit.wikimedia.org/r/106230 
[12:57:06] <grrrit-wm>	 (03PS2) 10Hydriz: Migrating to use new JSON message backend. [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/106229 
[13:00:57] <grrrit-wm>	 (03CR) 10IAlex: "The point is that all hooks should be documented. If you want to discourage its use or say that it is temporary, then this should be state" [core] - 10https://gerrit.wikimedia.org/r/101663 (owner: 10IAlex)
[13:02:42] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "Added Niklas as reviewer" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106230 (owner: 10Hydriz)
[13:06:51] <grrrit-wm>	 (03CR) 10Hydriz: Fix missing apostrophe in maintenance/generateJsonI18n.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106230 (owner: 10Hydriz)
[13:07:47] <Niharika>	 Hello! 
[13:08:39] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "I18n reviewed." [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/106229 (owner: 10Hydriz)
[13:10:18] <grrrit-wm>	 (03CR) 10Hydriz: "Yes I did. Shall I leave this patch for you to merge?" [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/106229 (owner: 10Hydriz)
[13:10:59] <arav93>	 Could someone tell me why this cannot be merged? https://gerrit.wikimedia.org/r/#/c/101820/
[13:11:21] <grrrit-wm>	 (03Abandoned) 10Hydriz: Adding the main working files for the PrefixExport extension. [extensions/PrefixExport] - 10https://gerrit.wikimedia.org/r/27927 (owner: 10Hydriz)
[13:12:47] <grrrit-wm>	 (03PS1) 10Amire80: Change "article" to "page" [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106235 
[13:12:51] <grrrit-wm>	 (03CR) 10Raimond Spekking: "@Hydriz: I will prepare the change on translatewiki.net side now and merge your patchset when ready." [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/106229 (owner: 10Hydriz)
[13:13:03] <grrrit-wm>	 (03CR) 10Siebrand: Fix missing apostrophe in maintenance/generateJsonI18n.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106230 (owner: 10Hydriz)
[13:14:59] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "Thanks" [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106235 (owner: 10Amire80)
[13:16:08] <grrrit-wm>	 (03PS1) 10Jack Phoenix: Fix the JS so that it actually works. [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/106240 
[13:17:05] <grrrit-wm>	 (03CR) 10Jack Phoenix: [C: 032 V: 032] Fix the JS so that it actually works. [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/106240 (owner: 10Jack Phoenix)
[13:26:33] <grrrit-wm>	 (03CR) 10KartikMistry: [C: 032] "LGTM." [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106235 (owner: 10Amire80)
[13:32:55] <grrrit-wm>	 (03Abandoned) 10Addshore: Add RemoveIdentifierQuotes method and tests [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore)
[13:33:57] <grrrit-wm>	 (03PS4) 10Addshore: Add basic unit test for dieOnBadUser api method [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/95647 
[13:34:13] <grrrit-wm>	 (03CR) 10Addshore: "PS4 is a rebase" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/95647 (owner: 10Addshore)
[13:37:27] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrating to use new JSON message backend. [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/106229 (owner: 10Hydriz)
[13:40:21] <grrrit-wm>	 (03Abandoned) 10Addshore: Refactor skins/SideBarTest [core] - 10https://gerrit.wikimedia.org/r/95772 (owner: 10Addshore)
[13:49:02] <grrrit-wm>	 (03CR) 10Amire80: [C: 032 V: 032] Change "article" to "page" [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106235 (owner: 10Amire80)
[13:50:19] <grrrit-wm>	 (03PS1) 10Amire80: Add a step for the "view page" link [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106245 
[13:50:30] <DanielK_WMDE_>	 springle-away: thanks all the fish, err, review!
[13:54:55] <grrrit-wm>	 (03PS1) 10Amire80: Support for URL params in browser tests [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106246 
[14:04:41] <grrrit-wm>	 (03CR) 10Springle: [C: 031] "Like getDB(). Query opts logic seems sane." [core] - 10https://gerrit.wikimedia.org/r/103546 (owner: 10Bartosz Dziewoński)
[14:12:17] <grrrit-wm>	 (03CR) 10Springle: [C: 031] "I'm ok with the InnoDB "feature". In fact part of the reason for pushing out MariaDB 5.5.34 to production recently was to get access to so" [core] - 10https://gerrit.wikimedia.org/r/103589 (owner: 10Anomie)
[14:14:40] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Immediately trigger new scroll event after adding infinite scoll content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106249 
[14:38:10] <grrrit-wm>	 (03PS1) 10Amire80: Add test steps for columns and language labels [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106252 
[14:39:13] <grrrit-wm>	 (03CR) 10KartikMistry: "Then(/^I see a "(.*?)" link that points to the page "(.*?)" on the same wiki$/) do |arg1, arg2|" [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106245 (owner: 10Amire80)
[14:39:32] <hoo>	 anomie: Around?
[14:40:01] <anomie>	 hoo: Just a minute
[14:40:56] <hoo>	 anomie: Ok, it's not important, I just wondered a bit cause people keep copying the old HtmlBuilder code around to various wikis
[14:41:02] <grrrit-wm>	 (03CR) 10KartikMistry: [C: 032] "LGTM." [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106246 (owner: 10Amire80)
[14:41:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Support for URL params in browser tests [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106246 (owner: 10Amire80)
[14:44:04] <grrrit-wm>	 (03CR) 10Amire80: "No, it should be Then()." [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106245 (owner: 10Amire80)
[14:53:13] <anomie>	 hoo: Well, mw.html goes out with 1.23wmf10 (starting tomorrow). Then I suppose Module:HtmlBuilder could be changed to just "return mw.html", I don't think you broke compatibility.
[14:54:38] <hoo>	 anomie: We heavily did... first of all, you can no longer use the dot syntax for calling, also our module is way more strict with parameters
[14:55:45] <hoo>	 the version from enwiki eg. just silently ignores invalid input, much like PHP would do
[14:55:57] <anomie>	 hoo: Oh yeah, the dot thing.
[14:56:13] <anomie>	 But I think the stricter parameters is a good thing.
[14:57:00] <hoo>	 It is :) But eg. the current Module:Infobox from enwiki heavily relies on the fact that you can pass whatever you want to HtmlBuilder and it still keeps going
[14:57:34] <hoo>	 That module could be made a wrapper around Capiunto one day, btw...
[15:08:20] <grrrit-wm>	 (03PS1) 10Amire80: Add more browser test steps [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106259 
[15:12:47] <grrrit-wm>	 (03PS1) 10Manybubbles: Skip combining highlights correctly [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106261 
[15:14:44] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "Bc for 1.18 and earlier can be removed." (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104706 (owner: 10Nullzero)
[15:15:24] <grrrit-wm>	 (03PS1) 10Manybubbles: Add more timing and fix others [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106262 
[15:26:51] <grrrit-wm>	 (03PS1) 10Manybubbles: Don't ever ever search for nothing [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106265 
[15:27:24] <grrrit-wm>	 (03PS2) 10Manybubbles: Don't ever ever search for nothing [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106265 
[15:33:06] <Nemo_bis>	 sounds like a valid proverb
[15:44:39] * hoo  eyes hashar https://gerrit.wikimedia.org/r/98853

[15:46:10] <grrrit-wm>	 (03CR) 10KartikMistry: [C: 032] "LGTM after explanation from Amir." [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106245 (owner: 10Amire80)
[15:46:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add a step for the "view page" link [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106245 (owner: 10Amire80)
[15:51:23] <grrrit-wm>	 (03PS1) 10Aklapper: [4.4] Remove link to per-bug-queries.html.tmpl [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106268 
[15:53:10] <grrrit-wm>	 (03CR) 10Aklapper: [C: 031] "I actually had a runtime error locally on my Bugzilla 4.4, that's why I found this, and removing this line fixed it." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106268 (owner: 10Aklapper)
[15:54:57] <grrrit-wm>	 (03CR) 10KartikMistry: [C: 032] "LGTM." [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106252 (owner: 10Amire80)
[15:54:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add test steps for columns and language labels [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106252 (owner: 10Amire80)
[16:00:05] <marktraceur>	 Are there issues with Gerrit SSH?
[16:01:38] <grrrit-wm>	 (03CR) 10Siebrand: always show diff link if available (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105637 (owner: 10Nullzero)
[16:05:17] <grrrit-wm>	 (03CR) 10Dzahn: [C: 032] [4.4] Remove link to per-bug-queries.html.tmpl [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106268 (owner: 10Aklapper)
[16:05:24] <grrrit-wm>	 (03CR) 10Dzahn: [V: 032] [4.4] Remove link to per-bug-queries.html.tmpl [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/106268 (owner: 10Aklapper)
[16:06:53] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "all jobs refreshed!" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/106116 (owner: 10Hashar)
[16:07:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: point git://integration.wm.o to zuul.eqiad.wmnet [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/106116 (owner: 10Hashar)
[16:08:49] <grrrit-wm>	 (03CR) 10Skizzerz: [C: 032 V: 032] Replace deprecated User::editToken with User::getEditToken (1.19) [extensions/AuthorProtect] - 10https://gerrit.wikimedia.org/r/106196 (owner: 10Siebrand)
[16:09:52] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Generalize .flow-creator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106269 
[16:11:31] <grrrit-wm>	 (03CR) 10Skizzerz: [C: 031] Guard against no valid IPs being provided to GlobalBlocking::checkIpsForBlock [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/105636 (owner: 10Legoktm)
[16:14:04] <grrrit-wm>	 (03PS2) 10Amire80: Add more browser test steps [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106259 
[16:22:06] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] Fix missing apostrophe in maintenance/generateJsonI18n.php (032 comments) [core] - 10https://gerrit.wikimedia.org/r/106230 (owner: 10Hydriz)
[16:25:07] <mayankmadan>	 dr0ptp4kt, what is the "configure launch page" test here? https://www.mediawiki.org/wiki/Wikipedia_Zero/Test_cases 
[16:27:30] <grrrit-wm>	 (03CR) 10Manybubbles: Refactor Connection::getPageType() (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105971 (owner: 10Chad)
[16:27:43] <dr0ptp4kt>	 mayankmadan, in today's codebase, that refers to the showLangs case where there are 2 or more language codes in the configuration entry and showZeroPage is set to true. lemme find the relevant lines of code.
[16:28:39] <Nemo_bis>	 this thing? https://meta.wikimedia.org/wiki/Wikipedia_Zero_Starting_Page
[16:28:46] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-1] "This needs some extensive testing, too. I see a lot of places where fields are being renamed, and more (e.g. SpecialChangeEmail.php) where" (038 comments) [core] - 10https://gerrit.wikimedia.org/r/106187 (owner: 10Parent5446)
[16:29:58] <mayankmadan>	 dr0ptp4kt, zeljkof, i know that the GCI is over but can i still try to make a testing env for zero?
[16:30:35] <dr0ptp4kt>	 Nemo_bis, thx for providing the link to mayankmadan!
[16:31:31] <chrismcmahonbrb>	 mayankmadan: it would be great if you want to keep contributing anywhere you would like
[16:31:49] <mayankmadan>	 thats great
[16:33:38] <dr0ptp4kt>	 mayankmadan, could you elaborate on the definition of a 'testing env'? i don't know of anything prohibiting you from volunteering time, and we appreciate any help...if zeljkof is cool with it, sounds cool. sounds like chrismcmahon(brb) who work with zjelko says it's cool!
[16:41:04] <grrrit-wm>	 (03CR) 10Tpt: [C: 032] "Reviewed by Aarti" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97294 (owner: 10Tpt)
[16:42:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unneeded use of global variables [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97294 (owner: 10Tpt)
[16:43:25] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Merge RELEASE-NOTES-1.22 into HISTORY [core] - 10https://gerrit.wikimedia.org/r/106274 
[16:44:37] <dr0ptp4kt>	 mayankmadan, https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FZeroRatedMobileAccess.git/6438388620b3c5b7672b1e3a70feb8aa6d29061d/includes%2FPageRenderingHooks.php#L933 is a good place in the middle of the page lifecycle for examining the runtime logic for the "landing page"
[16:44:58] <mayankmadan>	 okay
[16:45:33] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] "Great." [core] - 10https://gerrit.wikimedia.org/r/106274 (owner: 10Bartosz Dziewoński)
[16:46:11] <grrrit-wm>	 (03CR) 10Tpt: [C: 032] "Reviewed by Phe" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97210 (owner: 10Tpt)
[16:46:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add custom DifferenceEngine for Page: pages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97210 (owner: 10Tpt)
[16:50:10] <grrrit-wm>	 (03CR) 10Siebrand: "No worries. I'll add them soon. Just didn't have time to do it sooner." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/105985 (owner: 10Siebrand)
[16:50:49] <grrrit-wm>	 (03PS2) 10Manybubbles: Refactor Connection::getPageType() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105971 (owner: 10Chad)
[16:50:55] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] Refactor Connection::getPageType() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105971 (owner: 10Chad)
[16:51:20] <grrrit-wm>	 (03CR) 10Nikerabbit: Add special page Special:ContentTranslation (037 comments) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106214 (owner: 10KartikMistry)
[16:52:38] <MatmaRex>	 hmmm
[16:52:47] <MatmaRex>	 do we have a nice standard way of deprecating hooks?
[16:53:21] <^d>	 Exterminate
[16:53:57] <MatmaRex>	 also, could somebody who has all extensions checked out grep them for me for something?
[16:54:08] <aude>	 which one?
[16:54:25] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Skip combining highlights correctly [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106261 (owner: 10Manybubbles)
[16:54:47] <^d>	 MatmaRex: For what?
[16:54:49] <MatmaRex>	 SpecialRecentChangesFilters|SpecialRecentChangesQuery|SpecialRecentChangesPanel|SpecialWatchlistFilters|SpecialWatchlistGetNonRevisionTypes|SpecialWatchlistQuery
[16:54:54] <^d>	 On it.
[16:55:01] * aude  let chad do

[16:55:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Refactor Connection::getPageType() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105971 (owner: 10Chad)
[16:55:10] * hoo  whistles *wikibase*

[16:55:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Skip combining highlights correctly [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106261 (owner: 10Manybubbles)
[16:55:13] <aude>	 the query one gets used
[16:55:17] <MatmaRex>	 i know
[16:55:19] <grrrit-wm>	 (03CR) 10Nullzero: "@Siebrand: Is there anyway to revert back to patch set #2? That patch is the one that you want." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104706 (owner: 10Nullzero)
[16:55:29] <aude>	 i think filters too
[16:55:30] <MatmaRex>	 i want to deprecate the 'Query' and 'Filters' ones (all four of them)
[16:55:34] <MatmaRex>	 and replace them with better ones
[16:55:35] <aude>	 wikibase uses all :)
[16:55:38] <aude>	 probably
[16:55:38] <hoo>	 Yep
[16:55:41] <MatmaRex>	 i know
[16:55:42] <^d>	 http://p.defau.lt/?VyhiMoZtYZsfrKsotU95Tg
[16:55:44] <MatmaRex>	 you'll thank me :)
[16:55:46] <hoo>	 We use all of them in a very hacky way
[16:55:54] <grrrit-wm>	 (03CR) 10Siebrand: "I think you have to cherry pick that, and resubmit it with the same change ID." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104706 (owner: 10Nullzero)
[16:55:54] <MatmaRex>	 i knoooow
[16:56:01] <MatmaRex>	 i want to unbreak them a bit
[16:56:15] <MatmaRex>	 it's silly that the Query ones take completely different parameters
[16:56:19] <MatmaRex>	 in completely different order
[16:56:23] <aude>	 true
[16:56:28] <hoo>	 MatmaRex: give us more context in the ones that allow us to change the query
[16:56:48] <hoo>	 I think we still use the wgRequest in there
[16:57:03] <hoo>	 - the
[16:57:04] <MatmaRex>	 hoo: i was thinking about wfRunHooks( 'ChangesListSpecialPageQuery', array( &$tables, &$fields, &$conds, &$query_options, &$join_conds, $opts )
[16:57:11] <MatmaRex>	 maybe a $this wouldn't hurt either
[16:57:32] <aude>	 it might be good to know what is calling it, so $this
[16:57:35] <MatmaRex>	 ah, also, $this->getPageTitle() or something like that would be necessary (or $this instead)
[16:57:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix missing apostrophe in maintenance/generateJsonI18n.php [core] - 10https://gerrit.wikimedia.org/r/106230 (owner: 10Hydriz)
[16:57:42] <hoo>	 not a fan of passing $this
[16:57:52] <hoo>	 don't expose more interfaces than needed
[16:57:56] <aude>	 true true
[16:58:14] <MatmaRex>	 ^d: thanks
[16:58:20] <^d>	 yw
[16:58:28] <aude>	 but watchlist might want to do different than recent changes, for example
[16:58:31] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Add more timing and fix others [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106262 (owner: 10Manybubbles)
[16:58:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add more timing and fix others [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106262 (owner: 10Manybubbles)
[16:58:46] <MatmaRex>	 aude: absolutely
[16:58:51] <MatmaRex>	 i just forgot a parameter :)
[16:59:05] <MatmaRex>	 let me just finish what i have here and push it out
[16:59:06] <hoo>	 Yep, passing that as a string should be fine
[16:59:08] * aude  doesn't like &$this

[16:59:10] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Don't ever ever search for nothing [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106265 (owner: 10Manybubbles)
[16:59:13] <MatmaRex>	 nice thing you're all here when i need you for once :D
[16:59:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't ever ever search for nothing [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106265 (owner: 10Manybubbles)
[16:59:19] <hoo>	 heh
[16:59:25] <aude>	 :)
[16:59:34] <^d>	 Anyone who's ever written &$this needs to remember we're using PHP5 now.
[17:00:03] <hoo>	 ^d: But I want to completely replace $this!1111 :P
[17:00:43] <hoo>	 I wonder what PHP would do in that case :P
[17:05:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Merge RELEASE-NOTES-1.22 into HISTORY [core] - 10https://gerrit.wikimedia.org/r/106274 (owner: 10Bartosz Dziewoński)
[17:07:06] <MatmaRex>	 aude: hoo: on a side note, SpecialWatchlistFilters and SpecialRecentChangesFilters do get passed $this
[17:07:23] <MatmaRex>	 ugh, wtf is that failure above
[17:07:23] <hoo>	 bad... not sure we use that
[17:07:26] <MatmaRex>	 https://integration.wikimedia.org/ci/job/mediawiki-core-phpunit-misc/17957/console : FAILURE in 19m 14s
[17:07:36] <MatmaRex>	 well, guess who didn't even touch any php files.
[17:07:40] <grrrit-wm>	 (03PS1) 10Matthias Mullie: (bug 58413) Hide usernames until reply form is active [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106275 
[17:07:49] <MatmaRex>	 hudson.plugins.git.GitException: Command "fetch -t origin refs/zuul/master/Zdef9ee464e6f4c85a2d2719857fb3599"
[17:07:51] <MatmaRex>	 welllll
[17:07:53] <hoo>	 Looks like zuul got git repo troubles again
[17:08:16] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032 V: 032] "Stupid broken jenkins." [core] - 10https://gerrit.wikimedia.org/r/106274 (owner: 10Bartosz Dziewoński)
[17:09:38] <marktraceur>	 Maybe related to the SSH problems with gerrit earlier?
[17:15:50] <grrrit-wm>	 (03PS4) 10M4tx: Add support for more Flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 
[17:15:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add support for more Flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx)
[17:16:55] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Make command to update ee-flow from anywhere configured [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105838 (owner: 10EBernhardson)
[17:16:57] <grrrit-wm>	 (03PS1) 10Manybubbles: Update CirrusSearch to master [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106277 
[17:17:25] <grrrit-wm>	 (03PS1) 10Manybubbles: Update CirrusSearch to master [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/106278 
[17:17:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make command to update ee-flow from anywhere configured [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105838 (owner: 10EBernhardson)
[17:18:21] <MatmaRex>	 aude: hoo: patch coming up
[17:18:25] <MatmaRex>	 when gerrit wakes up
[17:18:27] <grrrit-wm>	 (03PS8) 10Bartosz Dziewoński: Create ChangesListSpecialPage as a base class for Watchlist and RC [core] - 10https://gerrit.wikimedia.org/r/102458 
[17:18:28] <grrrit-wm>	 (03PS5) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement execute() [core] - 10https://gerrit.wikimedia.org/r/103240 
[17:18:29] <grrrit-wm>	 (03PS8) 10Bartosz Dziewoński: SpecialWatchlist: Don't overwrite context now that we don't have to [core] - 10https://gerrit.wikimedia.org/r/94289 
[17:18:30] <grrrit-wm>	 (03PS10) 10Bartosz Dziewoński: SpecialWatchlist: Use FormOptions for parameter handling [core] - 10https://gerrit.wikimedia.org/r/94288 
[17:18:31] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement webOutput() [core] - 10https://gerrit.wikimedia.org/r/105195 
[17:18:32] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement doMainQuery() [core] - 10https://gerrit.wikimedia.org/r/105194 
[17:18:33] <grrrit-wm>	 (03PS8) 10Bartosz Dziewoński: SpecialWatchlist: Synchronise some code with newer versions from RC [core] - 10https://gerrit.wikimedia.org/r/94628 
[17:18:34] <MatmaRex>	 awwww crap
[17:18:34] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: Change behavior of Special:Watchlist when user's watchlist is empty [core] - 10https://gerrit.wikimedia.org/r/103233 
[17:18:36] <grrrit-wm>	 (03PS8) 10Bartosz Dziewoński: SpecialWatchlist: Reorder some stuff in #execute [core] - 10https://gerrit.wikimedia.org/r/94627 
[17:18:36] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: ChangesListSpecialPage and subclasses: Reorder functions [core] - 10https://gerrit.wikimedia.org/r/103200 
[17:18:37] <hoo>	 oO
[17:18:37] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/103546 
[17:18:38] <MatmaRex>	 i didn't mean to do that
[17:18:38] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: No longer display the number of rows shown on Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/103239 
[17:18:39] <grrrit-wm>	 (03PS7) 10Bartosz Dziewoński: Always load 'mediawiki.special.changeslist' on SpecialRecentChanges and subclasses [core] - 10https://gerrit.wikimedia.org/r/97451 
[17:18:40] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: ChangesListSpecialPage: Stop mutating $opts in buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/105196 
[17:18:41] <MatmaRex>	 oh well
[17:18:41] <grrrit-wm>	 (03PS5) 10Bartosz Dziewoński: Changes list legend modules cleanup [core] - 10https://gerrit.wikimedia.org/r/103197 
[17:18:42] <grrrit-wm>	 (03PS9) 10Bartosz Dziewoński: SpecialWatchlist: JS enhancements to namespace selector (like RC) [core] - 10https://gerrit.wikimedia.org/r/94617 
[17:18:43] <grrrit-wm>	 (03PS14) 10Bartosz Dziewoński: Rename Watchlist request parameters for consistency with RC's ones [core] - 10https://gerrit.wikimedia.org/r/89380 
[17:18:44] <hoo>	 what the hell
[17:18:44] <grrrit-wm>	 (03PS8) 10Bartosz Dziewoński: SpecialWatchlist: Split #execute into subfunctions like SpecialRecentChanges [core] - 10https://gerrit.wikimedia.org/r/94677 
[17:18:45] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement two new hooks superseding 4 old ones [core] - 10https://gerrit.wikimedia.org/r/106279 
[17:18:49] <MatmaRex>	 i must have accidentally rebased the stack :D
[17:18:57] <MatmaRex>	 the last one is the one we care about
[17:19:09] <MatmaRex>	 (yeah, i have this many stacked changes pending)
[17:19:26] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Usages of the old hooks, courtesy of Chad: http://p.defau.lt/?VyhiMoZtYZsfrKsotU95Tg" [core] - 10https://gerrit.wikimedia.org/r/106279 (owner: 10Bartosz Dziewoński)
[17:19:29] <aude>	 wow
[17:19:41] <hoo>	 luckily I'm not reviewer on many of them :P
[17:20:40] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Update CirrusSearch to master [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106277 (owner: 10Manybubbles)
[17:20:48] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Update CirrusSearch to master [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/106278 (owner: 10Manybubbles)
[17:21:37] <hoo>	 the moment you realize *all* of your variable names are camelCase except of *one*
[17:22:01] <MatmaRex>	 heh, join_conds?
[17:22:09] <hoo>	 nah, in Capiunto
[17:22:14] <hoo>	 currently writing doc.
[17:23:22] <hoo>	 "PHPUnit_Framework_Exception: Unknown key(s): 1" search and replace all would have been to easy, I guess :P
[17:32:53] <grrrit-wm>	 (03PS3) 10Tpt: Explode ProofreadPageRenderer into smaller not static classes [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97295 
[17:44:45] <grrrit-wm>	 (03PS1) 10Cscott: Move to WMF repo; add .gitreview; update copyright. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/106285 
[17:47:43] <grrrit-wm>	 (03CR) 10Nikerabbit: Adding initial GWT scenarios (031 comment) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106221 (owner: 10Amire80)
[17:50:40] <grrrit-wm>	 (03PS1) 10M4tx: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard into bug/42964 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106291 
[17:51:48] <grrrit-wm>	 (03Abandoned) 10M4tx: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard into bug/42964 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/106291 (owner: 10M4tx)
[17:53:39] <grrrit-wm>	 (03PS3) 10JGonera: [WIP] Add Compact personal bar beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99586 
[17:54:14] <marktraceur>	 jgonera: Is *someone* from product aware of the new beta feature?
[17:54:32] <jgonera>	 marktraceur, which beta feature? personal bar?
[17:54:35] <marktraceur>	 Yeah
[17:54:37] <Nemo_bis>	 looks like Beta is going to be the new home of every and crazy gadget
[17:54:49] <Nemo_bis>	 (solution to the problem of central gadgets?)
[17:54:51] <jgonera>	 I suppose? It's described where all the other features are
[17:54:56] <jgonera>	 anyway, it's not ready yet
[17:54:58] <marktraceur>	 Nemo_bis: No, ostensibly we're supposed to curate them a bit
[17:55:13] <Nemo_bis>	 hm
[17:55:24] <marktraceur>	 jgonera: Please actually tell someone - the staging area is just that, we try to keep track of what's actually running
[17:55:27] <grrrit-wm>	 (03PS5) 10M4tx: Add support for more Flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 
[17:55:29] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add support for more Flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx)
[17:55:40] <jgonera>	 marktraceur, but it's not running, it's not merged and it's -2
[17:55:56] <marktraceur>	 Well
[17:55:58] <jgonera>	 marktraceur, plus, the whole idea came from Jared, so I assumed he talked to the right people
[17:56:03] <marktraceur>	 We'd like to know *before* it's running :)
[17:56:08] <marktraceur>	 Eh
[17:56:11] <marktraceur>	 I wouldn't assume that
[17:56:27] <jgonera>	 ok, who should I let know before merging then?
[17:56:40] <marktraceur>	 Either Howie or James_F, I would say
[17:56:44] <grrrit-wm>	 (03PS1) 10MaxSem: Redo API [extensions/Collection] - 10https://gerrit.wikimedia.org/r/106293 
[17:56:54] <jgonera>	 ok, I'll let them know
[17:57:09] <AaronSchulz>	 ^d: https://gerrit.wikimedia.org/r/#/c/106219/1
[17:57:31] * AaronSchulz  wasted a lot of time with debug statements to find the cause of some errors last night

[17:58:23] <^d>	 Heh
[17:58:42] <AaronSchulz>	 I guess $1 is better than a message like the others obviously
[18:01:12] <grrrit-wm>	 (03PS6) 10M4tx: Add support for more Flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 
[18:05:12] <grrrit-wm>	 (03PS6) 10Chad: WIP: Implement interwiki searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105986 
[18:05:16] <grrrit-wm>	 (03CR) 10M4tx: "Sorry for the mess. I had some problems with merging the patch. I fixed the problems that Gergő Tisza mentioned." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx)
[18:08:16] <grrrit-wm>	 (03CR) 10Mwalker: [C: 032] Redo API [extensions/Collection] - 10https://gerrit.wikimedia.org/r/106293 (owner: 10MaxSem)
[18:10:59] <grrrit-wm>	 (03PS1) 10Tim Landscheidt: Define labs-toollabs-debian-glue separately [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/106295 
[18:11:03] <grrrit-wm>	 (03CR) 10Nikerabbit: Set up the extension with basic files and configurations (0310 comments) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106186 (owner: 10Santhosh)
[18:12:22] <grrrit-wm>	 (03CR) 10Tim Landscheidt: "@hashar Only one way to find out if this works :-)." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/106295 (owner: 10Tim Landscheidt)
[18:12:38] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 04-1] "Scroll-to doesn't seem to work right on this one. It works for shorter topics, but for topics with more than a page worth of replies its " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105123 (owner: 10Bsitu)
[18:12:50] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 04-1] "This complicates translation and I see no obvious benefit - the unspecified form can basically be anything depending on whether translator" [core] - 10https://gerrit.wikimedia.org/r/106179 (owner: 10Jackmcbarn)
[18:14:08] <grrrit-wm>	 (03CR) 10EBernhardson: "it does fix the marked bugs though, so almost there" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105123 (owner: 10Bsitu)
[18:14:25] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: Rewrite CSS for vectorTabs and #p-personal with nesting [core] - 10https://gerrit.wikimedia.org/r/90171 (owner: 10Jdlrobson)
[18:14:31] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: Hygiene: Cleanup IE6 specific rules by using the underscore hack [core] - 10https://gerrit.wikimedia.org/r/94163 (owner: 10Jdlrobson)
[18:15:23] <grrrit-wm>	 (03PS2) 10Siebrand: DatabaseInstaller::setVarsFromRequest needs array [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/105985 
[18:15:51] <grrrit-wm>	 (03PS1) 10Mwalker: Revert "Change Collection to a deploy branch" [tools/release] - 10https://gerrit.wikimedia.org/r/106296 
[18:15:55] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Don't suggest if the search term is a known title [core] - 10https://gerrit.wikimedia.org/r/105705 (owner: 10Manybubbles)
[18:17:06] <grrrit-wm>	 (03CR) 10Cscott: [C: 032] Move to WMF repo; add .gitreview; update copyright. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/106285 (owner: 10Cscott)
[18:19:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't suggest if the search term is a known title [core] - 10https://gerrit.wikimedia.org/r/105705 (owner: 10Manybubbles)
[18:20:03] <grrrit-wm>	 (03CR) 10Siebrand: Set up the extension with basic files and configurations (032 comments) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106186 (owner: 10Santhosh)
[18:20:03] <^d>	 manybubbles: ^ That's merged to core.
[18:20:17] <^d>	 I don't feel like backporting all over the place, so we'll hold off on the Cirrus change.
[18:21:07] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx)
[18:21:48] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99586 (owner: 10JGonera)
[18:24:34] <grrrit-wm>	 (03CR) 10Nikerabbit: Set up the extension with basic files and configurations (031 comment) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/106186 (owner: 10Santhosh)
[18:26:04] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Generalize .flow-creator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106269 (owner: 10Matthias Mullie)
[18:26:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Generalize .flow-creator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106269 (owner: 10Matthias Mullie)
[18:28:23] <grrrit-wm>	 (03PS1) 10Siebrand: Do not suggest to use unused local vars [core] - 10https://gerrit.wikimedia.org/r/106297 
[18:30:06] <grrrit-wm>	 (03CR) 10EBernhardson: "the user interaction just feels a bit funny. mousedown expands the text box because thats when :active is triggered, but the username doe" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106275 (owner: 10Matthias Mullie)
[18:30:18] <grrrit-wm>	 (03CR) 10Greg Grossmeier: "Not sure about 1.22.1 personally; new feature not used by many other extensions yet and it's Jan 8th (ie: way past 1.22 release). I'm supe" [core] - 10https://gerrit.wikimedia.org/r/105092 (owner: 10Jeroen De Dauw)
[18:30:55] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] Do not suggest to use unused local vars [core] - 10https://gerrit.wikimedia.org/r/106297 (owner: 10Siebrand)
[18:31:19] <siebrand>	 For those aiming to increase their "CR:+2" numbers, please have a look at https://gerrit.wikimedia.org/r/#/q/status:open+topic:replace-deprecated,n,z for easy merges.
[18:34:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Do not suggest to use unused local vars [core] - 10https://gerrit.wikimedia.org/r/106297 (owner: 10Siebrand)
[18:37:00] <grrrit-wm>	 (03PS2) 10Aaron Schulz: Improved vague/incomplete $1 thumb.php error messages [core] - 10https://gerrit.wikimedia.org/r/106219 
[18:38:18] <jdlrobson>	 MatmaRex: are you feeling bold today? I could really do with some +2s on some Vector refactoring. I promise to be extremely attentive to any regressions these may cause….
[18:38:32] <grrrit-wm>	 (03PS1) 10Jdlrobson: Vector: Componentize screen.less [core] - 10https://gerrit.wikimedia.org/r/106298 
[18:38:33] <grrrit-wm>	 (03PS1) 10Jdlrobson: Vector: Rewrite p-personal with nesting. [core] - 10https://gerrit.wikimedia.org/r/106299 
[18:38:34] <grrrit-wm>	 (03PS1) 10Jdlrobson: Vector: Rewrite footer styling with nesting [core] - 10https://gerrit.wikimedia.org/r/106300 
[18:38:35] <grrrit-wm>	 (03PS1) 10Jdlrobson: Vector: Rewrite vectorTabs with nesting [core] - 10https://gerrit.wikimedia.org/r/106301 
[18:38:36] <grrrit-wm>	 (03PS1) 10Jdlrobson: Vector: Rewrite navigation.less with nesting [core] - 10https://gerrit.wikimedia.org/r/106302 
[18:38:38] <grrrit-wm>	 (03PS1) 10Jdlrobson: Vector: Rewrite notifications.less with nesting [core] - 10https://gerrit.wikimedia.org/r/106303 
[18:38:38] <grrrit-wm>	 (03PS1) 10Jdlrobson: Vector: Rewrite search with nesting [core] - 10https://gerrit.wikimedia.org/r/106304 
[18:38:47] <grrrit-wm>	 (03PS1) 10Jdlrobson: Reflect upstream changes [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106305 
[18:39:04] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-2] "Dependency not merged." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106305 (owner: 10Jdlrobson)
[18:41:15] <grrrit-wm>	 (03CR) 10EBernhardson: "The hhvm server only has /w/, and its mounted to the root. So Special:Version is available as:" [vagrant] - 10https://gerrit.wikimedia.org/r/105834 (owner: 10EBernhardson)
[18:46:04] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Remove searchlimit preference [core] - 10https://gerrit.wikimedia.org/r/105871 (owner: 10Chad)
[18:49:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove searchlimit preference [core] - 10https://gerrit.wikimedia.org/r/105871 (owner: 10Chad)
[18:54:51] <grrrit-wm>	 (03CR) 10GWicke: [C: 032] Removed cloudfiles dependency in SwiftFileBackend [core] - 10https://gerrit.wikimedia.org/r/101226 (owner: 10Aaron Schulz)
[18:54:55] <MatmaRex>	 jdlrobson: heh, nice
[18:55:23] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Vector: Rewrite search with nesting [core] - 10https://gerrit.wikimedia.org/r/106304 (owner: 10Jdlrobson)
[18:55:48] <grrrit-wm>	 (03CR) 10Umherirrender: [C: 031] "Thanks" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/105985 (owner: 10Siebrand)
[18:56:40] <grrrit-wm>	 (03CR) 10Siebrand: "Umherirrender: Any reason why you can't work on branches other than master? I'd explain it if you want..." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/105985 (owner: 10Siebrand)
[18:56:59] <grrrit-wm>	 (03CR) 10Jdlrobson: "recheck" [core] - 10https://gerrit.wikimedia.org/r/106304 (owner: 10Jdlrobson)
[18:57:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Removed cloudfiles dependency in SwiftFileBackend [core] - 10https://gerrit.wikimedia.org/r/101226 (owner: 10Aaron Schulz)
[18:58:16] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/106219 (owner: 10Aaron Schulz)
[19:00:56] <grrrit-wm>	 (03CR) 10Bsitu: "Normally stuff works in FF would work in Chrome, but it doesn't work this time and it is caused by the .focus(). :(" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105123 (owner: 10Bsitu)
[19:01:26] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Whitelist 'useskin' and 'uselang' when choosing buttons to show [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/100934 (owner: 10Mattflaschen)
[19:01:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Whitelist 'useskin' and 'uselang' when choosing buttons to show [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/100934 (owner: 10Mattflaschen)
[19:12:53] <grrrit-wm>	 (03PS2) 10EBernhardson: Dont try and do sane things, like generalizing specific exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106165 
[19:18:14] <marktraceur>	 Krinkle: Hey, did you see the email about the licensing issue?
[19:18:20] <Krinkle>	 Yes
[19:18:33] <marktraceur>	 We'd like to get that sorted, like...today if possible
[19:18:36] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032] Dont try and do sane things, like generalizing specific exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106165 (owner: 10EBernhardson)
[19:18:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Dont try and do sane things, like generalizing specific exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106165 (owner: 10EBernhardson)
[19:22:48] <qgil_>	 gwicke_away, are you really away? 
[19:23:22] <marktraceur>	 Krinkle: Are the upstream issues really that bad?
[19:27:18] <marktraceur>	 And/or are they better now with the changes?
[19:28:48] <gwicke>	 qgil_, was on the move
[19:29:32] <qgil_>	 gwicke, ah, I see you now :)
[19:30:17] <Krinkle>	 marktraceur: I don't know?
[19:30:57] <marktraceur>	 OK, I'm now hearing that Fabrice is OK with waiting on it.
[19:31:01] <marktraceur>	 So never mind, no worries
[19:31:12] <marktraceur>	 I mean, merging it would be a good idea, but it can wait.
[19:31:25] <AaronSchulz>	 csteipp: https://bugzilla.wikimedia.org/show_bug.cgi?id=59793 should
[19:31:48] <AaronSchulz>	 use oauth instead of extensions maybe?
[19:33:32] <AaronSchulz>	 ^d: can those cdb classes go in /libs?
[19:33:44] <^d>	 Prolly, now that I removed the last of the MW dependencies.
[19:42:36] <grrrit-wm>	 (03CR) 10Cscott: [V: 032] Move to WMF repo; add .gitreview; update copyright. [extensions/Collection/OfflineContentGenerator/text_renderer] - 10https://gerrit.wikimedia.org/r/106285 (owner: 10Cscott)
[19:44:19] <grrrit-wm>	 (03PS10) 10MegaAlex: Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis)
[19:48:15] <jackmcbarn>	 is there a helper function to let me easily get a column from a ResultWrapper into an array?
[19:49:09] <Reedy>	 No
[19:56:33] <hashar>	 Krinkle: hey :-D
[19:57:10] <hashar>	 Krinkle: I have tweaked our zuul status page to include progress bar.  Basically copy pasted the stuff jeblair wrote for OpenStack.
[20:00:03] <Krinkle>	 yep, saw it.
[20:00:04] <Krinkle>	 nice
[20:01:05] <grrrit-wm>	 (03Abandoned) 10AalekhN: A Possible Solution to Bug 4365 [core] - 10https://gerrit.wikimedia.org/r/106001 (owner: 10AalekhN)
[20:03:15] <grrrit-wm>	 (03PS1) 10Kaldari: Add hook to allow extensions to modify the LonelyPages query [core] - 10https://gerrit.wikimedia.org/r/106318 
[20:05:19] <Reedy>	 MatmaRex: ^ 106318... Weren't you looking at removing hooks like that earlier?
[20:06:37] <grrrit-wm>	 (03CR) 10Kaldari: "@M4tx: I wasn't complaining. It was a compliment!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx)
[20:08:47] <grrrit-wm>	 (03CR) 10Kaldari: [C: 031] Add support for more Flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx)
[20:13:01] <grrrit-wm>	 (03PS1) 10AalekhN: SpecialContributions.php : made Special:Contributions includable [core] - 10https://gerrit.wikimedia.org/r/106320 
[20:15:15] <MatmaRex>	 Reedy: nah, i'm just rewiring watchlist and RC
[20:15:29] <grrrit-wm>	 (03CR) 10AalekhN: "Sibrand:You can re-review my patch here:" [core] - 10https://gerrit.wikimedia.org/r/106001 (owner: 10AalekhN)
[20:17:26] <MatmaRex>	 Reedy: although my hooks were kinda similar
[20:18:11] <MatmaRex>	 we could come up with some conventions for this kinda stuff i guess
[20:19:27] <MatmaRex>	 but meh, there are like five of such hooks total
[20:22:21] <grrrit-wm>	 (03CR) 10AalekhN: "Bawolff:Three Things" [core] - 10https://gerrit.wikimedia.org/r/105991 (owner: 10AalekhN)
[20:23:24] <grrrit-wm>	 (03PS2) 10Bsitu: Tweak and bug fix to modified tipsy and diff link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105421 
[20:30:05] <grrrit-wm>	 (03PS1) 10Jackmcbarn: Improve clarity of diff-multi message [core] - 10https://gerrit.wikimedia.org/r/106322 
[20:31:35] <grrrit-wm>	 (03PS6) 10Nullzero: make MOVED_TO* working [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104706 
[20:34:23] <grrrit-wm>	 (03CR) 10Mattflaschen: "Do you think it might be better to always use wfExpandUrl and plainlinks? wfExpandUrl seems to return the same URL if it's already expand" [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis)
[20:41:33] <AaronSchulz>	 kaldari: can that heater cure colds?
[20:41:56] <grrrit-wm>	 (03PS5) 10Bsitu: Fix issues on clicking "x comments" link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105123 
[20:45:54] <grrrit-wm>	 (03PS5) 10Nullzero: always show diff link if available [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105637 
[20:45:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] always show diff link if available [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105637 (owner: 10Nullzero)
[20:46:48] <grrrit-wm>	 (03CR) 10Bsitu: "Looks like we have the wrong scrollToElement. This seems to be the cause: In FF, the focus behavior overwrites the scrollToElement and pag" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105123 (owner: 10Bsitu)
[20:48:11] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement two new hooks superseding 4 old ones [core] - 10https://gerrit.wikimedia.org/r/106279 
[20:48:12] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement webOutput() [core] - 10https://gerrit.wikimedia.org/r/105195 
[20:48:13] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: ChangesListSpecialPage: Stop mutating $opts in buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/105196 
[20:49:42] <^d>	 AaronSchulz: https://gerrit.wikimedia.org/r/#/c/103742/ :)
[20:49:54] <MatmaRex>	 ^d: care to grep something else?
[20:50:07] <MatmaRex>	 SpecialRecentChanges|SpecialRecentChangesLinked|SpecialWatchlist, case-insensitive
[20:50:28] <MatmaRex>	 (or i guess without the Special)
[20:50:50] <MatmaRex>	 i want to know if i can fool with method/field visibility or not
[20:51:31] <kaldari>	 AaronSchulz: it's probably better at preventing colds than curing them :)
[20:52:27] <grrrit-wm>	 (03CR) 10Jackmcbarn: [C: 04-1] "20:45:57 PHP Parse error: syntax error, unexpected '}' in special/SpecialAbuseLog.php on line 543" (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105637 (owner: 10Nullzero)
[20:53:54] <^d>	 MatmaRex: You sure about that? Getting tons of noise...
[20:54:27] <grrrit-wm>	 (03PS11) 10Mayankmadan: Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 
[20:54:30] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan)
[20:56:31] <grrrit-wm>	 (03CR) 10Chad: "We're going to be adding hooks here anyway, why not just do it with a hook and push the burden of checking to FlaggedRevs?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104675 (owner: 10Chad)
[20:58:15] <MatmaRex>	 ^d: hm
[20:58:34] <MatmaRex>	 ^d: do we have a better way of figuring out if something is calling methods on these special pages?
[20:58:44] <MatmaRex>	 i don't wanna cause fatals, y'know
[20:59:03] <MatmaRex>	 (or accessing their fields, since obviously they're all public too)
[20:59:31] <Reedy>	 IDE?
[20:59:46] <^d>	 MatmaRex: What are you looking for SpecialWatchlist?
[20:59:50] <^d>	 I don't see any public properties.
[21:00:44] <grrrit-wm>	 (03PS5) 10Aude: Add QuickTemplateAfterPortlet hook to add html after portlets [core] - 10https://gerrit.wikimedia.org/r/101895 
[21:00:56] <MatmaRex>	 ^d: SpecialRecentChanges has a bunch
[21:01:04] <MatmaRex>	 and SpecialRecentChangesLinked too
[21:01:12] <MatmaRex>	 i guess watchlist accidentally doesn't have any, heh
[21:01:34] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] ChangesListSpecialPage: Stop mutating $opts in buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/105196 (owner: 10Bartosz Dziewoński)
[21:01:42] <MatmaRex>	 Reedy: do you want me to import a gigabyte of repositories into an ide?
[21:01:50] <MatmaRex>	 (and most of all, download them first?)
[21:01:50] <Reedy>	 only a gb?
[21:02:00] <Reedy>	 I've got them all cloned
[21:02:11] <MatmaRex>	 i have a 1 mbps connection, on a good day
[21:02:24] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Eat a dick, jenkins." [core] - 10https://gerrit.wikimedia.org/r/105196 (owner: 10Bartosz Dziewoński)
[21:02:29] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "recheck" [core] - 10https://gerrit.wikimedia.org/r/105196 (owner: 10Bartosz Dziewoński)
[21:02:30] <grrrit-wm>	 (03Abandoned) 10Reedy: Add validation of the content model edited by EditPage [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99518 (owner: 10Tpt)
[21:02:31] <grrrit-wm>	 (03Abandoned) 10Reedy: Add validation of the content model edited by EditPage [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/99519 (owner: 10Tpt)
[21:05:22] <grrrit-wm>	 (03PS6) 10Aude: Add QuickTemplateAfterPortlet hook to add html after portlets [core] - 10https://gerrit.wikimedia.org/r/101895 
[21:07:45] <aude>	 MatmaRex: you have to edit the commit message or something to retrigger jenkins
[21:09:01] <MatmaRex>	 aude: i know it passes tests, i just wanted to kill the V-1
[21:09:10] <MatmaRex>	 aude: if i edit that, i'll have to rebase a few patches on top of it
[21:09:44] <aude>	 true true
[21:09:45] <MatmaRex>	 i get enough mail already
[21:09:47] <MatmaRex>	 :D
[21:10:22] <hoo>	 +1
[21:15:47] <csteipp>	 AaronSchulz: definitely should use oauth if there are api's for what they are doing..
[21:19:55] <grrrit-wm>	 (03CR) 10Legoktm: "Please add documentation to docs/hooks.txt :)" [core] - 10https://gerrit.wikimedia.org/r/106318 (owner: 10Kaldari)
[21:21:37] <kaldari>	 legoktm: every time I remember to update release notes, I forget to update hooks.txt, and vice versa :P
[21:21:38] <grrrit-wm>	 (03PS12) 10Mayankmadan: Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 
[21:21:40] <grrrit-wm>	 (03PS1) 10BryanDavis: Make "application agreement" questions required [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106428 
[21:25:17] <grrrit-wm>	 (03PS2) 10Kaldari: Add hook to allow extensions to modify the LonelyPages query [core] - 10https://gerrit.wikimedia.org/r/106318 
[21:26:52] <grrrit-wm>	 (03PS3) 10Kaldari: Add hook to allow extensions to modify the LonelyPages query [core] - 10https://gerrit.wikimedia.org/r/106318 
[21:27:27] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Remove "or other" option for stubtreshold [core] - 10https://gerrit.wikimedia.org/r/103742 (owner: 10Chad)
[21:27:45] <grrrit-wm>	 (03PS1) 10Manybubbles: Add the user to Cirrus logs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106430 
[21:31:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove "or other" option for stubtreshold [core] - 10https://gerrit.wikimedia.org/r/103742 (owner: 10Chad)
[21:32:05] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Breaking Change: All lower case excludedtitle for consistency [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103734 (owner: 10Mattflaschen)
[21:32:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Breaking Change: All lower case excludedtitle for consistency [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103734 (owner: 10Mattflaschen)
[21:34:55] <grrrit-wm>	 (03CR) 10Parent5446: [C: 04-2] "@Anomie, you're absolutely right. This is a major WIP that I just put together over the past couple of days. Most likely the two other CSR" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/106187 (owner: 10Parent5446)
[21:36:02] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Make "application agreement" questions required [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106428 (owner: 10BryanDavis)
[21:36:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make "application agreement" questions required [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106428 (owner: 10BryanDavis)
[21:39:04] <grrrit-wm>	 (03CR) 10Parent5446: Do not suggest to use unused local vars (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106297 (owner: 10Siebrand)
[21:39:28] <grrrit-wm>	 (03CR) 10Anomie: "No problem. I just wanted to note this would need more manual testing that might be usual." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106187 (owner: 10Parent5446)
[21:40:04] <grrrit-wm>	 (03PS10) 10Aaron Schulz: filebackend: Added supported for retrieving file metadata/headers [core] - 10https://gerrit.wikimedia.org/r/86642 
[21:41:28] <grrrit-wm>	 (03CR) 10Aaron Schulz: "Pass all but some describe() tests with Dumpling Ceph...need to try Emperor (which should have the http://tracker.ceph.com/issues/6462 fix" [core] - 10https://gerrit.wikimedia.org/r/86642 (owner: 10Aaron Schulz)
[21:50:56] <grrrit-wm>	 (03CR) 10Nikerabbit: Do not suggest to use unused local vars (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106297 (owner: 10Siebrand)
[21:52:23] <grrrit-wm>	 (03CR) 10Parent5446: Improve clarity of diff-multi message (033 comments) [core] - 10https://gerrit.wikimedia.org/r/106322 (owner: 10Jackmcbarn)
[21:54:35] <grrrit-wm>	 (03PS1) 10Kaldari: Modify the Special:LonelyPages query to ignore disambiguation pages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/106435 
[21:54:53] <grrrit-wm>	 (03PS1) 10Aude: Add ability to mark hooks as deprecated [core] - 10https://gerrit.wikimedia.org/r/106436 
[21:55:14] <aude>	 MatmaRex: hoo ^ see if that is sane way
[21:55:32] <aude>	 ^d also 
[21:55:42] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-2] "Don't merge until dependency in core is merged." [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/106435 (owner: 10Kaldari)
[21:56:04] <grrrit-wm>	 (03CR) 10Parent5446: Add hook to allow extensions to modify the LonelyPages query (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106318 (owner: 10Kaldari)
[21:56:10] <grrrit-wm>	 (03CR) 10Parent5446: [C: 031] Add hook to allow extensions to modify the LonelyPages query [core] - 10https://gerrit.wikimedia.org/r/106318 (owner: 10Kaldari)
[21:56:10] <MatmaRex>	 aude: i think contenthandler has something related too, no?
[21:56:28] <aude>	 no idea
[21:56:37] <grrrit-wm>	 (03PS2) 10Kaldari: Modify the Special:LonelyPages query to ignore disambiguation pages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/106435 
[21:57:00] <grrrit-wm>	 (03CR) 10Chad: [C: 031] Add ability to mark hooks as deprecated [core] - 10https://gerrit.wikimedia.org/r/106436 (owner: 10Aude)
[21:57:02] <MatmaRex>	 aude: ContentHandler::runLegacyHooks
[21:57:15] <hoo>	 yeah
[21:57:22] <hoo>	 but that's only for content stuff
[21:57:25] <aude>	 huh
[21:57:35] <hoo>	 it does some text transform and whatever for the legacy hook
[21:57:36] <hoo>	 s
[21:57:43] * aude  would like to mark hooks before removing them

[21:57:47] <hoo>	 so only for content stuff
[21:57:55] <grrrit-wm>	 (03PS4) 10Kaldari: Add hook to allow extensions to modify the LonelyPages query [core] - 10https://gerrit.wikimedia.org/r/106318 
[21:58:10] <MatmaRex>	 it also has a big fat (optional) wfWarn call in there
[21:58:33] <MatmaRex>	 and like 50 lines of code to build the warning message
[21:58:42] <hoo>	 really? :P
[21:58:49] <hoo>	 Haven't looked at that for quite some time
[21:59:17] <aude>	 warning?
[21:59:23] <MatmaRex>	 if ( $warn ) {
[21:59:23] <MatmaRex>	 …
[21:59:24] <MatmaRex>	 wfWarn( "Using obsolete hook $event via ContentHandler::runLegacyHooks()! Handlers: " .
[21:59:24] <MatmaRex>	 implode( ', ', $handlerInfo ), 2 );
[21:59:36] <MatmaRex>	 dunno why it uses that function in particular, though
[21:59:50] <hoo>	 Daniel or JeroenDeDauw wrote taht
[22:00:00] <aude>	 wfDeprecated does E_USER_DEPRECATED
[22:00:02] <aude>	 i think
[22:00:16] <aude>	 suppose warning is deserved for content
[22:01:00] <hoo>	 we're (sadly) still quite a bit away of removing the legacy content hooks
[22:01:10] <aude>	 true
[22:01:56] <MatmaRex>	 we actually have quite a lot of hooks marked as "deprecated" in hooks.txt
[22:02:03] <MatmaRex>	 and not just contenthandler-related ones
[22:02:18] * aude  sure

[22:02:35] * aude  doubts many people look at hooks.txt

[22:02:49] <hoo>	 Yeah, that wont really work
[22:02:50] <MatmaRex>	 i do, it's faster than loading mw.org
[22:02:57] <MatmaRex>	 usually less outdated too :P
[22:03:06] <MatmaRex>	 but yeah, these should be actual in-code warnings
[22:03:08] <hoo>	 True, but only for new stuff
[22:03:40] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Add ability to mark hooks as deprecated (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106436 (owner: 10Aude)
[22:04:11] <hoo>	 MatmaRex: Already thought about that exact thing
[22:04:19] <hoo>	 PHP should allow use more type hint
[22:04:20] <hoo>	 s
[22:04:45] <aude>	 good idea
[22:06:02] <grrrit-wm>	 (03PS6) 10Nullzero: always show diff link if available [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105637 
[22:06:21] <aude>	 i could also make it null instead of false
[22:06:47] <grrrit-wm>	 (03CR) 10Parent5446: [C: 04-1] "Inline comment. Also, not sure if this was intentional, but it might not be the best idea to have the deprecation warning in the wfRunHook" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106436 (owner: 10Aude)
[22:07:02] <grrrit-wm>	 (03CR) 10Kaldari: "Swalling: Compare https://www.mediawiki.org/wiki/User:Kaldari/Sandbox with and without the Typography refresh. With the typography refresh" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106148 (owner: 10Kaldari)
[22:08:30] <grrrit-wm>	 (03PS3) 10Parent5446: More 1.19 backwards compatibility fixes [extensions/Persona] - 10https://gerrit.wikimedia.org/r/105242 
[22:08:34] <grrrit-wm>	 (03PS2) 10Jackmcbarn: Improve clarity of diff-multi message [core] - 10https://gerrit.wikimedia.org/r/106322 
[22:08:49] <grrrit-wm>	 (03CR) 10Parent5446: [C: 032 V: 032] More 1.19 backwards compatibility fixes [extensions/Persona] - 10https://gerrit.wikimedia.org/r/105242 (owner: 10Parent5446)
[22:09:03] <grrrit-wm>	 (03PS2) 10Kaldari: Removing italic override for blockquotes [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106148 
[22:09:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Removing italic override for blockquotes [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106148 (owner: 10Kaldari)
[22:09:21] <grrrit-wm>	 (03PS3) 10Kaldari: Removing italic override for blockquotes [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106148 
[22:09:22] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Removing italic override for blockquotes [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106148 (owner: 10Kaldari)
[22:10:53] <grrrit-wm>	 (03CR) 10Jackmcbarn: "UserArray doesn't seem usable in this case. I can't pre-populate it in the case where the db query can be skipped, since it only takes use" [core] - 10https://gerrit.wikimedia.org/r/106322 (owner: 10Jackmcbarn)
[22:11:19] <grrrit-wm>	 (03CR) 10Parent5446: [C: 032] Add hook to allow extensions to modify the LonelyPages query [core] - 10https://gerrit.wikimedia.org/r/106318 (owner: 10Kaldari)
[22:12:11] <grrrit-wm>	 (03PS4) 10Kaldari: Removing italic override for blockquotes [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106148 
[22:13:42] <grrrit-wm>	 (03PS2) 10Aude: Add ability to mark hooks as deprecated [core] - 10https://gerrit.wikimedia.org/r/106436 
[22:14:24] <grrrit-wm>	 (03CR) 10Jackmcbarn: [C: 031] always show diff link if available [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105637 (owner: 10Nullzero)
[22:14:25] <grrrit-wm>	 (03PS1) 10EBernhardson: update wmf/1.23wmf9 -> master [extensions/Flow] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106441 
[22:14:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add hook to allow extensions to modify the LonelyPages query [core] - 10https://gerrit.wikimedia.org/r/106318 (owner: 10Kaldari)
[22:14:46] <grrrit-wm>	 (03CR) 10Aude: Add ability to mark hooks as deprecated (032 comments) [core] - 10https://gerrit.wikimedia.org/r/106436 (owner: 10Aude)
[22:14:48] <grrrit-wm>	 (03CR) 10Kaldari: Modify the Special:LonelyPages query to ignore disambiguation pages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/106435 (owner: 10Kaldari)
[22:16:51] <grrrit-wm>	 (03Abandoned) 10EBernhardson: update wmf/1.23wmf9 -> master [extensions/Flow] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106441 (owner: 10EBernhardson)
[22:18:45] <grrrit-wm>	 (03PS1) 10Chad: Declare visibility on all properties in ForkController [core] - 10https://gerrit.wikimedia.org/r/106442 
[22:18:46] <grrrit-wm>	 (03PS1) 10Chad: Make it easy to get the number of the currently running child [core] - 10https://gerrit.wikimedia.org/r/106443 
[22:19:11] <grrrit-wm>	 (03PS3) 10Kaldari: Modify the Special:LonelyPages query to ignore disambiguation pages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/106435 
[22:20:25] <grrrit-wm>	 (03PS1) 10BryanDavis: Fix target of Frequently asked questions link [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106444 
[22:20:26] <grrrit-wm>	 (03PS1) 10Chad: Remove ugly code duplication in ReindexForkController [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106445 
[22:21:02] <grrrit-wm>	 (03PS1) 10Cscott: Automatically open/close inline decorations around bidi runs. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/106446 
[22:21:03] <grrrit-wm>	 (03PS1) 10Cscott: Allow env/line/paragraph breaks in the middle of 'inline' decorations. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/106447 
[22:21:32] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Automatically open/close inline decorations around bidi runs. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/106446 (owner: 10Cscott)
[22:21:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Allow env/line/paragraph breaks in the middle of 'inline' decorations. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/106447 (owner: 10Cscott)
[22:21:56] <cscott>	 jenkins, why are you such a hater?
[22:22:56] <grrrit-wm>	 (03PS2) 10BryanDavis: Fix text errors [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106444 
[22:24:24] <grrrit-wm>	 (03PS2) 10Cscott: Allow env/line/paragraph breaks in the middle of 'inline' decorations. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/106447 
[22:24:25] <grrrit-wm>	 (03PS2) 10Cscott: Automatically open/close inline decorations around bidi runs. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/106446 
[22:24:40] <grrrit-wm>	 (03PS4) 10Kaldari: Modify the Special:LonelyPages query to ignore disambiguation pages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/106435 
[22:29:44] <grrrit-wm>	 (03CR) 10Aude: [C: 031] "would merge if i could ;)" [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106444 (owner: 10BryanDavis)
[22:30:04] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 031] Make it easy to get the number of the currently running child [core] - 10https://gerrit.wikimedia.org/r/106443 (owner: 10Chad)
[22:30:41] <bd808>	 ^d: https://www.mediawiki.org/wiki/Gerrit/Project_ownership#Aude_.2B2_for_wikimedia.2Fwikimania-scholarships
[22:30:49] <aude>	 yeah, thanks
[22:30:52] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 031] "Looks good. Waiting on merge to core." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106445 (owner: 10Chad)
[22:31:07] <bd808>	 aude: yw :)
[22:31:13] <aude>	 my +1's are not too helpful
[22:31:25] <bd808>	 Moral support is always nice
[22:31:36] <aude>	 true
[22:33:41] <^d>	 Ugh, I'll have to make a new group :p
[22:33:55] <^d>	 Right now I think it's owned by ldap/wmf because I'm lazy.
[22:35:12] <grrrit-wm>	 (03PS2) 10Chad: Remove ugly code duplication in ReindexForkController [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/106445 
[22:39:39] <awight>	 marktraceur: you have a minute to get me into #-staff?
[22:40:33] <awight>	 marktraceur: thanks!
[22:44:21] <grrrit-wm>	 (03PS4) 10Chad: Allow SearchResults to specify that they matched file content [core] - 10https://gerrit.wikimedia.org/r/105234 
[22:46:46] <grrrit-wm>	 (03CR) 10BryanDavis: "KTC looked through the rest of the UI text for me and didn't find any more issues." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106444 (owner: 10BryanDavis)
[22:47:14] <grrrit-wm>	 (03CR) 10Manybubbles: "I think this still needs a qqq message." [core] - 10https://gerrit.wikimedia.org/r/105234 (owner: 10Chad)
[22:54:55] <grrrit-wm>	 (03PS2) 10Alex Monk: Fix logging [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/105444 
[22:56:38] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Fix text errors [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106444 (owner: 10BryanDavis)
[22:56:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix text errors [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106444 (owner: 10BryanDavis)
[22:57:35] <grrrit-wm>	 (03PS1) 10EBernhardson: Track the root of a post tree explicitly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106449 
[23:00:53] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "The entire stack looks nice at a glance; I'll test it a bit, go through it to spot typos or something, and probably merge tomorrow-ish." [core] - 10https://gerrit.wikimedia.org/r/106298 (owner: 10Jdlrobson)
[23:02:55] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "(This will make it somewhat harder to grep for stuff, but oh well. Jon, do you happen to know any tools which would make it easier?)" [core] - 10https://gerrit.wikimedia.org/r/106298 (owner: 10Jdlrobson)
[23:02:56] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Added sanity check for doGetLocalCopyMulti() in Swift [core] - 10https://gerrit.wikimedia.org/r/106450 
[23:05:23] <AaronSchulz>	 ^d: ^
[23:06:10] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Added sanity check for doGetLocalCopyMulti() in Swift [core] - 10https://gerrit.wikimedia.org/r/106450 (owner: 10Aaron Schulz)
[23:09:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Added sanity check for doGetLocalCopyMulti() in Swift [core] - 10https://gerrit.wikimedia.org/r/106450 (owner: 10Aaron Schulz)
[23:11:48] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] "I'll be bold and merge this before it gets caught up in some discussion. :) Italics should never be applied to large swaths of text like t" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106148 (owner: 10Kaldari)
[23:11:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Removing italic override for blockquotes [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106148 (owner: 10Kaldari)
[23:14:40] <grrrit-wm>	 (03CR) 10Mattflaschen: "How about:" [core] - 10https://gerrit.wikimedia.org/r/106298 (owner: 10Jdlrobson)
[23:17:23] <grrrit-wm>	 (03CR) 10CSteipp: [C: 032] Guard against no valid IPs being provided to GlobalBlocking::checkIpsForBlock [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/105636 (owner: 10Legoktm)
[23:17:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Guard against no valid IPs being provided to GlobalBlocking::checkIpsForBlock [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/105636 (owner: 10Legoktm)
[23:17:45] <grrrit-wm>	 (03PS1) 10Bsitu: update branch to master [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106453 
[23:17:48] <grrrit-wm>	 (03PS2) 10EBernhardson: Track the root of a post tree explicitly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106449 
[23:19:47] <grrrit-wm>	 (03Abandoned) 10Bsitu: update branch to master [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106453 (owner: 10Bsitu)
[23:25:59] <grrrit-wm>	 (03CR) 10Awjrichards: [C: 032 V: 032] Split JS to several files for improved modularity [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/103721 (owner: 10MaxSem)
[23:26:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Split JS to several files for improved modularity [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/103721 (owner: 10MaxSem)
[23:30:58] <grrrit-wm>	 (03PS3) 10Alex Monk: Fix logging [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/105444 
[23:32:44] <grrrit-wm>	 (03PS6) 10Bsitu: Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 
[23:33:22] <grrrit-wm>	 (03CR) 10Bsitu: [C: 04-1] "Not ready yet, more tweaks need to be made for both topic and post" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu)
[23:33:54] <grrrit-wm>	 (03CR) 10Awjrichards: [C: 032 V: 032] Check whether history.pushState is supported [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/103722 (owner: 10MaxSem)
[23:33:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Check whether history.pushState is supported [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/103722 (owner: 10MaxSem)
[23:34:11] <grrrit-wm>	 (03CR) 10Brian Wolff: "On the includable thing, I meant don't do $this->mIncludable = true;, instead change the line:" [core] - 10https://gerrit.wikimedia.org/r/105991 (owner: 10AalekhN)
[23:36:36] <grrrit-wm>	 (03CR) 10Brian Wolff: [C: 04-1] "My same comments as on gerrit change 105991 apply here (Enable transclusion via the class hierarchy, and controls should not be transclude" [core] - 10https://gerrit.wikimedia.org/r/106320 (owner: 10AalekhN)
[23:37:24] <grrrit-wm>	 (03PS3) 10Brian Wolff: Made Changes as per Bug 34999 <ref>{{{foo}}}</ref> is working on the local machine....also added some changes after review by Bawolff [extensions/Cite] - 10https://gerrit.wikimedia.org/r/104794 (owner: 10AalekhN)
[23:41:15] <grrrit-wm>	 (03PS1) 10MaxSem: Update Collection to master tip [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/106456 
[23:44:41] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Made use of proper backend-fail-store message [core] - 10https://gerrit.wikimedia.org/r/106457 
[23:44:45] <AaronSchulz>	 ^d: trivial
[23:49:09] <grrrit-wm>	 (03PS1) 10Mattflaschen: Remove Special:GettingStarted and notifications [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/106458 
[23:51:32] <grrrit-wm>	 (03PS1) 10MaxSem: Update Collection to master tip [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106459 
[23:52:18] <grrrit-wm>	 (03CR) 10Brian Wolff: [C: 04-1] "I tested this now, it doesn't seem to work. This only replaces variables in <references> tags, not including any <ref> tags inside that <" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/104794 (owner: 10AalekhN)
[23:53:56] <grrrit-wm>	 (03CR) 10Awjrichards: [C: 032 V: 032] Don't use bogus nonefm format [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/103723 (owner: 10MaxSem)
[23:54:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't use bogus nonefm format [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/103723 (owner: 10MaxSem)
[23:56:11] <grrrit-wm>	 (03PS1) 10BryanDavis: Add missing i18n for search region [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/106460