[00:04:02] (03PS10) 10Gergő Tisza: Create jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [00:05:14] (03CR) 10Gergő Tisza: "Rebased so that we have jquery.fullscreen and oojs )both MultimediaViewer dependencies) in the same tree." [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [00:06:04] (03CR) 10Parent5446: ":/ It worked just fine before. Somebody must have changed something in LocalizationCache." [core] - 10https://gerrit.wikimedia.org/r/72867 (owner: 10Parent5446) [00:17:37] (03CR) 10Parent5446: "Found out why it broke." [core] - 10https://gerrit.wikimedia.org/r/72867 (owner: 10Parent5446) [00:20:25] (03CR) 10Gergő Tisza: "We use lots of MIT libraries already (OOJS is MIT, for example). GPL allows including code with compatible separate license as long as the" [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [00:22:13] (03PS1) 10Chad: Remove searchlimit preference [core] - 10https://gerrit.wikimedia.org/r/105871 [00:22:48] (03PS4) 10Parent5446: Added fallback information to LocalisationCache [core] - 10https://gerrit.wikimedia.org/r/72866 [00:24:17] (03PS6) 10Parent5446: Complete usage of message fallback chain [core] - 10https://gerrit.wikimedia.org/r/72867 [00:24:28] doing a fresh install from the vagrant setup with parsoid i'm getting 'notice: /Stage[main]/Mediawiki::Parsoid/Exec[install parsoid]/returns: npm ERR! message SSL Error: CERT_UNTRUSTED' [00:24:39] i can override manually of course, but curious if there is a better fix [00:25:01] (03PS7) 10Parent5446: Complete usage of message fallback chain [core] - 10https://gerrit.wikimedia.org/r/72867 [00:25:16] (03PS4) 10Nullzero: always show diff link if available [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105637 [00:26:00] ebernhardson: what server is that hitting? i forget if the npm invocation specifies a url [00:26:26] ori: it just says https://registry.npmjs.org/ [00:26:34] ori: i can pastie the debug log somewhere if it helps [00:27:38] (03CR) 10Jackmcbarn: [C: 031] always show diff link if available [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105637 (owner: 10Nullzero) [00:28:57] (03PS1) 10Bsitu: Add 'Terms of use' below all user input box [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105873 [00:32:58] ebernhardson: let me try to reproduce first [00:35:08] (03CR) 10Mattflaschen: "Is this still needed? Bug 44718 is marked fixed." [core] - 10https://gerrit.wikimedia.org/r/64645 (owner: 10Ori.livneh) [00:37:50] (03CR) 10Nullzero: Restore the Details link in Special:AbuseLog (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105819 (owner: 10Jackmcbarn) [00:43:09] ebernhardson: hm, it succeeded for me [00:46:06] can you reproduce it yourself? [00:47:17] ebernhardson, we are normally using our deploy repo now [00:47:28] mediawiki/services/parsoid/deploy [00:47:56] it has the parsoid repo as a submodule and includes node_modules [00:48:02] so no need for npm install [00:48:05] ori: hmm, i'll destroy and pring it up again [00:48:13] gwicke: hmm, so sounds like can change the puppet module arround? [00:48:37] yes, that would be nice [00:48:51] Antoine has a new puppet module that he uses in betalabs [00:49:05] we'll likely adapt that to prod this week [00:49:13] gwicke: any idea what that gerrit repo is called? [00:49:26] mediawiki/services/parsoid/deploy [00:49:48] gwicke: excellent, thanks [00:49:51] git clone ssh://USERNAME@gerrit.wikimedia.org:29418/mediawiki/services/parsoid/deploy [00:50:01] git submodule init; git submodule update [00:50:11] gwicke: should we switch mediawiki-vagrant over to that? [00:50:35] ori: that would be ideal [00:50:53] gwicke: any chance you could file a bug? [00:51:11] will you get the prod puppet automatically? [00:51:28] I have no clue how close vagrant is to prod [00:53:52] not very [00:57:21] ori, it might be worth waiting for our deb [00:57:31] ori: same error still, i wonder if perhaps my precise image is old or some such. vagrant provision output: http://pastie.org/8608359 npm-debug.log: http://pastie.org/8608360 [00:57:32] that should be really easy to install in vagrant as well [00:57:38] but if switching to the other one, probably not worth debugging [00:58:12] gwicke: we've had a working puppet module since may [00:58:26] and it still works, at least for me. and i know a number of people are using it. [00:58:47] hashar should have at least pinged me to let me know, but oh well [00:58:48] which is great [00:59:02] we have had puppet for a long time in prod as well [00:59:48] well, i guess you're right. if it works, etc. we'll wait for the deb. [00:59:57] so far it seems that people want us to use git-deploy instead of debs for deployment, so we'll probably continue to do that in prod for a while [00:59:59] ebernhardson: worth debugging, i'll check the logs [01:00:12] but for anybody else debs should be easier [01:00:35] (03PS7) 10EBernhardson: Display nested exception backtrace's [core] - 10https://gerrit.wikimedia.org/r/91073 [01:01:00] so it might be worth waiting for those to avoid changing the vagrant puppetization twice [01:01:00] (03CR) 10EBernhardson: [C: 04-1] "still need to address some of the comments in prev review" [core] - 10https://gerrit.wikimedia.org/r/91073 (owner: 10EBernhardson) [01:02:23] ebernhardson: pip recently started verifying SSL certs by default, so maybe NPM underwent a similar change [01:03:01] perhaps it needs to depend on update-ca-certificates [01:03:11] (03PS2) 10Andrew Bogott: Allow for creation of service group w/out initial user. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105845 [01:03:12] (03PS3) 10Andrew Bogott: Switch reading to the new service group schema. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105847 [01:03:13] (03PS3) 10Andrew Bogott: Transition to a new servicegroup schema [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 [01:03:14] (03PS3) 10Andrew Bogott: Add maintenance tool to clean up the old service-group schema. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105848 [01:03:21] can you run 'sudo update-ca-certificates'? [01:03:46] (03CR) 10Andrew Bogott: [C: 04-1] "Please don't merge -- Andrew needs to do some by-hand stuff while merging." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105846 (owner: 10Andrew Bogott) [01:06:03] ori: sure, sec [01:06:19] (03CR) 10Gergő Tisza: "Sorry, that was careless of me :(" [core] - 10https://gerrit.wikimedia.org/r/72867 (owner: 10Parent5446) [01:07:33] ori: still fails after running update-ca-certificates [01:08:06] oddly, curl and wget seem to accept their cert [01:09:15] hrm [01:09:24] ebernhardson: what about https://github.com/npm/npm/issues/1580#issuecomment-2486457 ? [01:09:55] maybe we could set strict-ssl to false [01:10:59] are you sure you are connecting to the right host? [01:11:08] ori: i used strict-ssl to false earlier, works ok. The ssl cert shown by `npm config get ca` matches the one in the issue [01:11:11] I installed something earlier on a debian machine without issues [01:11:38] gwicke: we're simply running 'npm install' in the parsoid checkout [01:12:04] in an Ubuntu Vagrant instance? [01:12:09] so it's getting the requirements from package.json and using npm to resolve them [01:12:13] yeah [01:12:24] not sure how the nat works there [01:12:30] and/or proxying [01:13:16] can you see anything that indicates the IP it is connecting to is correct? [01:13:30] hmm [01:14:13] registry.npmjs.org -> a.sni.fastly.net -> 199.27.77.162 [01:14:24] same from the auto-assigned dns at wmf and from 8.8.8.8 (goog) [01:14:53] although thats just from nslookup, npm should be using the same [01:15:02] interesting, I'm getting 199.27.79.162 [01:15:25] could be simple multi-A DNS RR [01:16:08] same from 8.8.8.8 [01:16:18] dig @8.8.8.8 registry.npmjs.org [01:16:56] probably is, running a few times now i get the .79. number [01:17:12] yeah, I'm getting the 77 now too [01:17:18] that might not be the issue [01:17:36] (03CR) 10MarkTraceur: [C: 04-2] "You don't understand - Theo committed a violation of the GPL (which this code was licensed under) by licensing his plugin under MIT. He ne" [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [01:17:45] odd to me is that wget and curl, which should be using same CA's, accept the connection [01:18:03] on my debian machine npm install works just fine [01:18:09] just tested that again [01:18:23] npm --version [01:18:24] 1.3.10 [01:18:35] nodejs --version [01:18:35] v0.10.24 [01:18:41] (03PS3) 10Bsitu: Batch loading workflows for history links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105144 [01:21:55] (03PS5) 10Parent5446: Changed logged out tokens to use session if already there [core] - 10https://gerrit.wikimedia.org/r/76458 [01:22:30] (03CR) 10Bsitu: Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu) [01:22:49] (03CR) 10Parent5446: "Nice! Another bug fixed (once this merges of course)." [core] - 10https://gerrit.wikimedia.org/r/72867 (owner: 10Parent5446) [01:27:12] gwicke: hmm, i'm on 1.1.39 and 0.8.2, i suppose that could be the issue as well? [01:27:53] (03CR) 10Chad: [C: 031] Don't suggest if the search term is a known title [core] - 10https://gerrit.wikimedia.org/r/105705 (owner: 10Manybubbles) [01:28:19] ebernhardson: possibly- I guess the node devs are not testing such old releases much any more [01:28:32] I had problems with npm before that were also fixed by upgrading [01:28:47] ok i'll check that out as well [01:29:03] but you could also just use the deploy repo [01:29:14] it has node_modules inside it [01:29:38] as a dirty hack you could just copy that into your install dir [01:29:50] if you don't want to use the submodule mechanism [01:30:19] for the moment i've just used strict-ssl=false, but yea sounds best [01:36:55] (03PS1) 10Jdlrobson: Typograph tweaks [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105879 [01:36:56] (03PS1) 10Jdlrobson: Thumbnail styling [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105880 [01:36:57] (03PS1) 10Jdlrobson: Blockquote styling [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105881 [01:37:10] (03PS1) 10Spage: Only make the last paragraph of a post inline [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105882 [01:41:43] (03CR) 10Spage: "This fixes the glitch. But perhaps we really want, in regular expression terminology, a zero-width positive lookahead assertion "If this " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105882 (owner: 10Spage) [01:46:56] (03PS2) 10EBernhardson: Hack together apache -> hhvm [vagrant] - 10https://gerrit.wikimedia.org/r/105834 [02:00:09] (03PS3) 10Bsitu: Fix issues on clicking "x comments" link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105123 [02:02:32] (03CR) 10Bsitu: "The editor gets the outerheight of the textarea as it loads, but the css sets it to 34px height if textarea not focused." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105123 (owner: 10Bsitu) [02:09:28] (03CR) 10Swalling: "Can a brother get a +2?" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/100934 (owner: 10Mattflaschen) [02:12:36] (03PS4) 10Bsitu: Fix issues on clicking "x comments" link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105123 [02:16:04] gwicke: so I guess https://gerrit.wikimedia.org/r/#/c/101226/ can be merged? [02:16:49] AaronSchulz, if you think that the testing is good enough without me having tested it, then yes [02:17:19] how good is the test coverage for this code? [02:17:56] fairly good (see @group FileBackend in /tests) [02:19:01] the code I have seen looks all reasonable to me, but I might well have overlooked something [02:19:46] if we monitor things after the first phase of deploy then we should be fine I guess [02:20:19] Is there a swift setup in betalabs? [02:40:07] (03PS3) 10TTO: Add namespace-wide page notice functionality [core] - 10https://gerrit.wikimedia.org/r/105434 [02:40:49] (03CR) 10jenkins-bot: [V: 04-1] Add namespace-wide page notice functionality [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO) [02:46:27] (03CR) 10GWicke: [C: 032] "Lets merge per IRC discussion, but keep an eye on the first deploy phase." [core] - 10https://gerrit.wikimedia.org/r/101226 (owner: 10Aaron Schulz) [02:47:00] (03CR) 10jenkins-bot: [V: 04-1] Removed cloudfiles dependency in SwiftFileBackend [core] - 10https://gerrit.wikimedia.org/r/101226 (owner: 10Aaron Schulz) [02:51:13] AaronSchulz, https://gerrit.wikimedia.org/r/101226 needs a rebase [03:02:47] (03PS3) 10MZMcBride: Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [03:04:32] (03CR) 10MZMcBride: "Per private e-mail, Maryana and Fabrice have no problem with this being merged." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [03:04:45] legoktm: About? [03:14:50] (03CR) 10Parent5446: Add ProfilerMwprof (032 comments) [core] - 10https://gerrit.wikimedia.org/r/105833 (owner: 10Ori.livneh) [03:31:39] (03PS1) 10Chad: Clean up AnalysisConfigBuilder/MappingConfigBuilder [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105888 [03:33:50] (03CR) 10Mattflaschen: "Can you link to some wikitext that would be good to test this with?" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105881 (owner: 10Jdlrobson) [03:35:05] (03PS1) 10Tim Starling: Title::makeTitleSafe can return null [extensions/GlobalBlocking] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/105889 [03:35:39] (03CR) 10Tim Starling: [C: 032] Title::makeTitleSafe can return null [extensions/GlobalBlocking] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/105889 (owner: 10Tim Starling) [03:35:41] (03Merged) 10jenkins-bot: Title::makeTitleSafe can return null [extensions/GlobalBlocking] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/105889 (owner: 10Tim Starling) [03:40:25] Patches uploaded with Gerrit Patch Uploader have "Gerrit Patch Uploader" as author? [03:40:44] Yes. [03:40:48] But the Author is correct. [03:42:11] The field that's largely invisible in Gerrit, you mean? [03:42:26] (03CR) 10Ori.livneh: [C: 032] Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [03:42:35] (03CR) 10jenkins-bot: [V: 04-1] Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [03:43:04] a test failed [03:48:39] (03PS2) 10Chad: Clean up AnalysisConfigBuilder/MappingConfigBuilder [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105888 [03:52:07] (03PS1) 10Tim Starling: Update GlobalBlocking to dd3fe6734e436fa216e5c9ad2c6418c8ea064e77 [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/105890 [03:52:09] why is #ifexist expensive? isn't it just doing the same check that needs to be done for every link to see if it's going to be blue or red? [03:54:37] (03PS2) 10Chad: Combine highlighting from plain and text analyzer [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105452 (owner: 10Manybubbles) [03:54:54] jackmcbarn: (Don't quote me on this, might be wrong): I believe there is a bit of a difference in that normal link existence checks are done all at once, where #ifexist's are done one at a time [03:55:43] i wonder if there's any sort of hackery that can make ifexist be fast [03:55:51] (03CR) 10Chad: [C: 032] "PS2 was just a rebase." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105452 (owner: 10Manybubbles) [03:56:02] (03Merged) 10jenkins-bot: Combine highlighting from plain and text analyzer [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105452 (owner: 10Manybubbles) [03:56:10] jackmcbarn: In any case, the expensive parser function limit is something like 500. The expensive parser functions aren't all that expensive, its just something that you wouldn't want to do a million times on a single page [03:56:24] You can batch the lookups. [03:59:05] Hmm, some sort of {{#preloadExistenceChecks:page1|page2|page3|...}} I guess [04:00:58] Hmm, as it stands, the expensive parser function count appears to be incremented even if the link id is already cached [04:01:29] I guess that way the page rendering always happens in the same way [04:01:42] (03PS1) 10Chad: No need to be static here [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105892 [04:02:33] (03CR) 10Tim Starling: [C: 032] Update GlobalBlocking to dd3fe6734e436fa216e5c9ad2c6418c8ea064e77 [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/105890 (owner: 10Tim Starling) [04:02:41] springle: Did you have a chance to look at https://gerrit.wikimedia.org/r/#/c/95633/ yet? [04:02:42] could it do the same thing Extension:Variables does to make var_final work? [04:05:44] (03Merged) 10jenkins-bot: Update GlobalBlocking to dd3fe6734e436fa216e5c9ad2c6418c8ea064e77 [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/105890 (owner: 10Tim Starling) [04:09:48] (03PS8) 10Springle: API: Add prop=contributors [core] - 10https://gerrit.wikimedia.org/r/95633 (owner: 10Anomie) [04:10:09] (03CR) 10Springle: [C: 032] API: Add prop=contributors [core] - 10https://gerrit.wikimedia.org/r/95633 (owner: 10Anomie) [04:10:34] jackmcbarn: I'm not familiar with that extension [04:10:53] it lets you set variables, and then use them higher in the page than you set them [04:11:00] (with some restrictions) [04:12:00] * bawolff looks [04:13:05] mostly no. Doing that would work for some usecases of #ifexist but not others [04:13:21] e.g. if you wanted to use the output of #ifexist in another parser function [04:13:38] could any variant on it be done, or would you need to stick a preload to gain any benefits? [04:13:56] (03Merged) 10jenkins-bot: API: Add prop=contributors [core] - 10https://gerrit.wikimedia.org/r/95633 (owner: 10Anomie) [04:14:22] If you never test the value #ifexist, then you could do something like [04:14:25] that [04:14:26] jackmcbarn: Instead of Extension:Variables, you'd probably use a Scribunto (Lua) module. [04:14:44] i know, i was just using its one feature as an example [04:15:11] having a method in lua that can do multiple page exists at once would probably be the prettiest solution [04:16:01] i'm looking at https://en.wikipedia.org/wiki/Red_Coat_Trail#Major_intersections_from_west_to_east [04:16:13] every shield picture is a call to #ifexist [04:16:47] (and that page does exceed 500) [04:17:17] anomie|away: sorry about the delay since Nov. didn't realise that one was waiting on me [04:18:01] am never sure which sets I'm supposed to +2 on core [04:18:12] springle: No problem, thanks for looking at it today. [04:18:13] jackmcbarn: One could work around it by instead of dynamically checking image existence (I'm assuming that's what your doing) have a lua data table that lists all the available shield images [04:18:51] that'd be quite the data table [04:20:48] I guess on the php side, the easiest optimization would be to check if the page has already been #ifexisted, and only increment expensive counter if its a new page (Most of those shield images seem to be repeats) [04:21:22] springle: I think that one was just in the situation where others had said "looks good to me if springle is happy with the database queries" [04:21:28] bawolff: That gives you weird behavior for pages where the number is near the threshold and the input to #ifexist is variable, thugh [04:21:32] *though [04:23:03] hmm, I guess it would. Perhaps people should just not do that ;) [04:23:28] can data be passed between separate calls to #invoke on the same page? [04:24:02] I'm pretty sure not [04:24:07] jackmcbarn: No. And if you find a way then it's a bug. [04:24:20] would it be desirable to make that a possibility? [04:24:40] RoanKattouw: On the other hand, people can already get similar weird behaviour if they have a variable number of #ifexists on a page [04:25:10] One of the design criteria was that that would not be a possibility, so things like parsoid could parse just the one #invoke and not the whole page. [04:26:47] is that also why extension:variables isn't deployed? [04:26:59] That's true [04:26:59] yes [04:29:25] could an exception be made for things that strictly don't change page appearance if they were missing, like ifexist caches, and then just have parsoid not worry about them? [04:30:39] #ifexist caches can change page appearence, but even ignoring that, that sounds very complicated and hacky [04:36:36] going for lunch [04:41:13] (03PS4) 10Catrope: Add VisualEditor support [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 [05:18:29] Gloria: hi [05:18:46] legoktm: I tried to rebase that change. [05:18:49] And it got +2'd. [05:18:51] And yet. [05:18:55] Oh well. [05:19:00] Hold on, I'm trying to figure out how to stop all the Flow spam [05:19:12] Flow, flow, flow your boat. [05:19:20] https://www.mediawiki.org/wiki/Special:RecentChanges [05:19:24] I wanted a script to do vandalism like that. [05:19:29] apparently blocks don't work. [05:19:30] I'm happy to see someone beat me to it. [05:19:34] Nor the spam blacklist? [05:19:38] Herp derp. [05:19:46] It shouldn't have gone live on the production wikis, but shrug. [05:23:29] (03CR) 10Ori.livneh: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [05:23:58] (03CR) 10MarkAHershberger: [C: 032] "merging based on Freakolowsky's review." [core] - 10https://gerrit.wikimedia.org/r/105243 (owner: 10Umherirrender) [05:24:03] ebernhardson: hey [05:24:31] apparently there are reports of flow funkiness on https://www.mediawiki.org/wiki/Special:RecentChanges [05:27:26] (03Merged) 10jenkins-bot: Add sequence support for externallinks table [core] - 10https://gerrit.wikimedia.org/r/105243 (owner: 10Umherirrender) [05:27:49] ori: It doesn't run the other tests until trying to submit/merge? [05:28:10] Gloria: you're not trusted, so it doesn't [05:28:14] you need to ask hashar to add you [05:28:30] To run tests? [05:28:35] otherwise you can write code that does funny things to the cluster and submit it to be "tested" [05:28:47] well, we don't sandbox tests in a virtualized environment [05:29:09] Is there a bug about that? [05:29:11] That seems stupid. [05:29:12] so you can push arbitrary code for review and off it runs [05:29:18] Where? [05:29:23] On some isolated host? [05:29:29] it's not terribly isolated [05:29:36] it should be a VM [05:29:44] Not tin? [05:29:48] no [05:29:52] i think it's on the roadmap for CI [05:29:56] krinkle would know [05:29:58] or hashar [05:30:08] Anyway, I looked at that test. [05:30:12] For a minute or two. [05:30:22] Then got annoyed and went to do something else. [05:30:45] hi [05:30:45] let me see what's failing [05:30:45] (03CR) 10Ori.livneh: [C: 032] Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [05:30:58] (03CR) 10jenkins-bot: [V: 04-1] Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [05:31:20] oh [05:31:24] I don't think that should be merged yet [05:31:24] it doesn't fail for me [05:31:27] > Some mention messages are hardcoded with 'talk page', for example, 'blah mentioned you on $5 talk page', we may want to remove it. I did not notice mention includes project namespace as well, the message is probably already incorrect for NS_PROJECT. [05:31:40] I don't recall ever fixing that since I was waiting for Fabrice. [05:31:48] Isn't a page with signatures always a talk page? [05:31:59] It wouldn't be wrong to call "Wikimedia Forum" a talk page. [05:32:05] Though perhaps coy. [05:32:16] That's the only use-case for this, isn't it? [05:32:42] and some other random pages like Template:DYK nominations/Blah [05:32:50] Is Project:Support_desk a talk page (assuming in some future that we use flow on that) [05:33:07] I believe it currently uses the "talk page" language with project-space pages. [05:33:11] yeah [05:33:12] it --> Echo [05:33:25] If the language is bad enough, someone else will fix it. [05:33:31] The underlying change is fine. [05:33:43] spagewmf_ I just sysopped you on mw.org [05:33:54] Oh, right. Flow bugs. [05:34:20] so you can now delete it [05:34:33] ok then [05:34:33] * legoktm waits for his VM to boot [05:38:50] (03PS9) 10Brian Wolff: Allow hiding patrol entries from Special:Log for all users [core] - 10https://gerrit.wikimedia.org/r/42279 [05:40:47] Jasper_Deng: Does the spam blacklist work? [05:43:43] No, it does not. [05:43:45] gj flow [05:44:36] I think I might have found the issue [05:44:36] no [05:44:49] nope [05:46:02] Gloria: Hmm, and Special:LinkSearch doesn't seem to work on flow either. Which probably implies it doesn't get purged when people edit other pages... [05:47:57] (03PS4) 10Legoktm: Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [05:48:04] (03CR) 10jenkins-bot: [V: 04-1] Remove namespace restriction for mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [05:48:07] And the answer is no, imagelinks aren't recorded in the linkstables [05:48:11] for flow posts [05:48:30] :| [05:49:43] (03PS1) 10Ori.livneh: Hack Flow to be read-only due to spam crisis [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105894 [05:49:57] * Jasper_Deng cheers ori [05:50:53] oh wow, the spam crisis has hit already? [05:51:12] ori: make sure we can still delete [05:51:26] (03CR) 10OliverKeyes: [C: 031] "As the only product meatbag not on a plane, a train or spain, consider this approval." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105894 (owner: 10Ori.livneh) [05:52:14] (03PS2) 10Ori.livneh: Hack Flow to be read-only due to spam crisis [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105894 [05:52:54] (03CR) 10OliverKeyes: [C: 031] Hack Flow to be read-only due to spam crisis [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105894 (owner: 10Ori.livneh) [05:53:48] (03CR) 10PiRSquared17: [C: 031] "Good for now, but obviously we need a permanent solution." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105894 (owner: 10Ori.livneh) [05:53:56] (03PS1) 10Legoktm: Test jenkins failure [extensions/Echo] - 10https://gerrit.wikimedia.org/r/105895 [05:54:24] ori: Modifying the extension seems like more pain than simply disabling it. [05:54:30] (03PS1) 10EBernhardson: emergency spam prevention, disable reply and new-topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105896 [05:54:35] (03CR) 10OliverKeyes: "Indeed; AF integration is in code review now, and spam blacklist will be following it." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105894 (owner: 10Ori.livneh) [05:54:37] (03Abandoned) 10Legoktm: Test jenkins failure [extensions/Echo] - 10https://gerrit.wikimedia.org/r/105895 (owner: 10Legoktm) [05:54:50] two netsplits in the last 10 minutes and getting kciked off [05:55:04] ebernhardson: I'll check 'em out. [05:55:30] (03PS3) 10Ori.livneh: Hack Flow to be read-only due to spam crisis [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105894 [05:55:42] (03Abandoned) 10Ori.livneh: Hack Flow to be read-only due to spam crisis [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105894 (owner: 10Ori.livneh) [05:55:44] (03PS2) 10EBernhardson: emergency spam prevention [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105896 [05:55:48] ori: see ^ebernhardson above [05:56:08] (03CR) 10PiRSquared17: [C: 031] "Good solution for now, but we obviously need a permanent solution." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105896 (owner: 10EBernhardson) [05:57:14] (03CR) 10Ori.livneh: [C: 032] emergency spam prevention [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105896 (owner: 10EBernhardson) [05:57:20] (03Merged) 10jenkins-bot: emergency spam prevention [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105896 (owner: 10EBernhardson) [05:57:55] ebernhardson: you realize we have to backport that to 1.23wmf9 ? [05:58:12] TimStarling has to deploy it either way [05:58:42] no, he doesn't [05:58:52] TimStarling: everything under control :) [05:59:09] (03PS1) 10Ori.livneh: emergency spam prevention [extensions/Flow] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105897 [05:59:20] (03CR) 10Ori.livneh: [C: 032 V: 032] emergency spam prevention [extensions/Flow] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105897 (owner: 10Ori.livneh) [06:00:34] (03CR) 10Legoktm: "I have no clue why the test is failing and can't reproduce it locally." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [06:01:39] (03PS1) 10Ori.livneh: Update Flow to master for emergency spam prevention [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105898 [06:02:10] (03CR) 10Ori.livneh: [C: 032 V: 032] Update Flow to master for emergency spam prevention [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105898 (owner: 10Ori.livneh) [06:07:20] (03PS1) 10Ori.livneh: Use container namespace [extensions/Flow] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105899 [06:07:53] (03CR) 10Ori.livneh: [C: 032] Use container namespace [extensions/Flow] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105899 (owner: 10Ori.livneh) [06:09:23] (03PS1) 10Ori.livneh: Update Flow to master [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105900 [06:09:43] (03CR) 10Ori.livneh: [C: 032 V: 032] Update Flow to master [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105900 (owner: 10Ori.livneh) [06:15:49] btw spagewmf [06:15:52] it's reply, edit, edit-title, and new-topic disabled [06:15:55] not everything [06:16:02] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 (owner: 10Catrope) [06:17:11] https://www.mediawiki.org/w/index.php?title=Talk:Sandbox&action=board-history now shows an error [06:17:14] but we can fix that later [07:38:06] (03CR) 10Physikerwelt: "Can we add some documentation?" (032 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 (owner: 10Catrope) [07:38:21] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu) [07:46:32] (03PS3) 10Nemo bis: Complete initial FirstSteps import [extensions/FirstSteps] - 10https://gerrit.wikimedia.org/r/104918 [07:49:54] (03PS4) 10Nemo bis: Complete initial FirstSteps import [extensions/FirstSteps] - 10https://gerrit.wikimedia.org/r/104918 [07:54:04] (03CR) 10Siebrand: Add 'Terms of use' below all user input box (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105873 (owner: 10Bsitu) [07:57:43] (03PS5) 10Nemo bis: Complete initial FirstSteps import [extensions/FirstSteps] - 10https://gerrit.wikimedia.org/r/104918 [07:59:32] (03PS6) 10Nemo bis: Complete initial FirstSteps import [extensions/FirstSteps] - 10https://gerrit.wikimedia.org/r/104918 [08:01:13] (03CR) 10Legoktm: [C: 04-1] Add VisualEditor support (032 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 (owner: 10Catrope) [08:06:33] (03PS1) 10Nemo bis: Some after-import tweaks [extensions/FirstSteps] - 10https://gerrit.wikimedia.org/r/105906 [08:08:57] (03CR) 10Nemo bis: [C: 032 V: 032] "Split the actual changes to their own commit as requested, now want to forget this one." [extensions/FirstSteps] - 10https://gerrit.wikimedia.org/r/104918 (owner: 10Nemo bis) [08:18:14] (03PS1) 10Nikerabbit: ULS backported bug fixes [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105907 [08:18:41] (03CR) 10Nikerabbit: [C: 032] ULS backported bug fixes [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105907 (owner: 10Nikerabbit) [08:22:15] (03Merged) 10jenkins-bot: ULS backported bug fixes [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105907 (owner: 10Nikerabbit) [08:32:12] (03CR) 10Nikerabbit: [C: 032] Backport update plural rules to CLDR 24 [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105438 (owner: 10Amire80) [08:32:30] Guten Tag. I am going to upgrade Zuul this morning so jobs will be disrupted a bit. Will ping whenever I start. [08:35:31] (03Merged) 10jenkins-bot: Backport update plural rules to CLDR 24 [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105438 (owner: 10Amire80) [08:41:19] (03CR) 10Theopolisme: "Commented at the issue on GitHub." [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [08:47:21] (03CR) 10Catrope: Add VisualEditor support (034 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 (owner: 10Catrope) [08:49:27] (03CR) 10Catrope: "Re Physikerwelt: there is nothing special about installing this. If you have both the VisualEditor and Math extensions installed (and, bec" [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 (owner: 10Catrope) [08:50:29] (03PS5) 10Catrope: Add VisualEditor support [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 [08:51:06] (03PS1) 10Legoktm: Documentation cleanup [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/105908 [08:51:33] (03CR) 10Catrope: Add VisualEditor support (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 (owner: 10Catrope) [08:52:35] (03CR) 10Legoktm: [C: 032] Documentation cleanup [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/105908 (owner: 10Legoktm) [08:52:41] (03Merged) 10jenkins-bot: Documentation cleanup [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/105908 (owner: 10Legoktm) [08:55:31] (03PS1) 10Hashar: register OpenBadges [extensions] - 10https://gerrit.wikimedia.org/r/105909 [08:55:44] (03CR) 10Hashar: [C: 032 V: 032] register OpenBadges [extensions] - 10https://gerrit.wikimedia.org/r/105909 (owner: 10Hashar) [09:12:57] (03PS1) 10Legoktm: Initial commit [extensions/GlobalContributions] - 10https://gerrit.wikimedia.org/r/105911 [09:20:35] (03CR) 10Ori.livneh: Add ProfilerMwprof (032 comments) [core] - 10https://gerrit.wikimedia.org/r/105833 (owner: 10Ori.livneh) [09:23:59] (03PS1) 10Hashar: update layout for next Zuul version [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105913 [09:24:43] (03CR) 10Hashar: [C: 032] update layout for next Zuul version [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105913 (owner: 10Hashar) [09:24:49] (03Merged) 10jenkins-bot: update layout for next Zuul version [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105913 (owner: 10Hashar) [09:26:34] (03PS3) 10Ori.livneh: Add ProfilerMwprof [core] - 10https://gerrit.wikimedia.org/r/105833 [09:32:37] (03PS1) 10Amire80: Starting browser tests for ContentTranslation [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/105918 [09:34:16] I have upgraded Zuul, if you see any Jenkins jobs issue let me know please. [09:34:17] (03CR) 10Zfilipin: [C: 032] Starting browser tests for ContentTranslation [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/105918 (owner: 10Amire80) [09:35:33] (03PS1) 10Adrian Lang: Update PHPUnit version check to 3.7.0 [core] - 10https://gerrit.wikimedia.org/r/105920 [09:35:41] (03CR) 10Zfilipin: [V: 032] Starting browser tests for ContentTranslation [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/105918 (owner: 10Amire80) [09:43:09] (03PS1) 10TTO: Fix double-bolding of bug field labels with Arial font [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/105921 [09:46:48] (03PS2) 10Hashar: Update PHPUnit version check to 3.7.0 [core] - 10https://gerrit.wikimedia.org/r/105920 (owner: 10Adrian Lang) [09:48:54] (03PS4) 10TTO: Add namespace-wide page notice functionality [core] - 10https://gerrit.wikimedia.org/r/105434 [09:50:00] (03CR) 10jenkins-bot: [V: 04-1] Update PHPUnit version check to 3.7.0 [core] - 10https://gerrit.wikimedia.org/r/105920 (owner: 10Adrian Lang) [09:50:17] (03CR) 10Hashar: [C: 032] "Thank you" [core] - 10https://gerrit.wikimedia.org/r/105920 (owner: 10Adrian Lang) [09:59:38] (03CR) 10jenkins-bot: [V: 04-1] Add namespace-wide page notice functionality [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO) [10:04:12] (03CR) 10Santhosh: [C: 032] Update docs for CLDRPluralRuleEvaluator.php [core] - 10https://gerrit.wikimedia.org/r/105702 (owner: 10Siebrand) [10:11:43] oh my god [10:14:13] (03CR) 10jenkins-bot: [V: 04-1] Update docs for CLDRPluralRuleEvaluator.php [core] - 10https://gerrit.wikimedia.org/r/105702 (owner: 10Siebrand) [10:14:54] hashar: Something broken in Jenkins? https://gerrit.wikimedia.org/r/#/c/105702/ : https://integration.wikimedia.org/ci/job/mediawiki-core-lint/32584/console : ABORTED in 9m 39s [10:15:07] siebrand: yeah looking at it [10:15:12] somehow git can't fetch the repository :( [10:15:15] hashar: okidoki. Good luck. [10:23:36] (03CR) 10Hashar: [C: 032] Update docs for CLDRPluralRuleEvaluator.php [core] - 10https://gerrit.wikimedia.org/r/105702 (owner: 10Siebrand) [10:26:32] (03CR) 10Hashar: [C: 032] Update PHPUnit version check to 3.7.0 [core] - 10https://gerrit.wikimedia.org/r/105920 (owner: 10Adrian Lang) [10:28:33] siebrand: might be fixed [10:32:48] hashar: Thanks. [10:34:20] (03PS1) 10Santhosh: Make .jshintrc a valid json file [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/105929 [10:35:41] (03CR) 10jenkins-bot: [V: 04-1] Update docs for CLDRPluralRuleEvaluator.php [core] - 10https://gerrit.wikimedia.org/r/105702 (owner: 10Siebrand) [10:36:24] hashar: Almost. https://integration.wikimedia.org/ci/job/mediawiki-core-phpunit-parser/17845/console was the party pooper. [10:36:49] siebrand: yeah I was debugging that one [10:37:02] for some reason git hangs trying to fetch the Zuul commits :5 [10:37:37] and I have no clue where the log are :( [10:38:56] (03Merged) 10jenkins-bot: Update PHPUnit version check to 3.7.0 [core] - 10https://gerrit.wikimedia.org/r/105920 (owner: 10Adrian Lang) [10:41:11] (03CR) 10Hashar: [C: 032] Update docs for CLDRPluralRuleEvaluator.php [core] - 10https://gerrit.wikimedia.org/r/105702 (owner: 10Siebrand) [10:41:15] :( [10:41:38] (03PS1) 10Siebrand: Remove superfluous spaces and doc tweak [core] - 10https://gerrit.wikimedia.org/r/105931 [10:42:02] (03CR) 10Siebrand: "I've submitted https://gerrit.wikimedia.org/r/105931 to address the comments. Also see inline replies." (037 comments) [core] - 10https://gerrit.wikimedia.org/r/103890 (owner: 10Siebrand) [10:43:29] (03Abandoned) 10Santhosh: LanguageGvTest::testGetPluralRuleType() has never worked [core] - 10https://gerrit.wikimedia.org/r/97337 (owner: 10Platonides) [10:45:54] (03Merged) 10jenkins-bot: Update docs for CLDRPluralRuleEvaluator.php [core] - 10https://gerrit.wikimedia.org/r/105702 (owner: 10Siebrand) [10:46:18] (03CR) 10Dereckson: "Okay, abandon the new changeset and use git review so." [core] - 10https://gerrit.wikimedia.org/r/105621 (owner: 10Gerrit Patch Uploader) [11:04:39] (03CR) 10Dereckson: "NTLM authentication would be preferrable" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz) [11:10:51] (03PS1) 10Aude: enable tests for Capiunto [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/105934 [11:12:24] (03CR) 10Hoo man: enable tests for Capiunto (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/105934 (owner: 10Aude) [11:15:06] (03PS2) 10Aude: enable tests for Capiunto [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/105934 [11:16:51] (03PS1) 10Hoo man: Add Capiunto [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105935 [11:17:10] (03CR) 10KartikMistry: [C: 032] "LGTM." [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/105929 (owner: 10Santhosh) [11:23:08] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/105852 (owner: 10Hashar) [11:29:16] (03PS1) 10Aklapper: duplicates.cgi: Add "Resolution" and "Priority" columns [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/105938 [11:31:03] (03CR) 10Helder.wiki: "Which bug?" [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105864 (owner: 10Ori.livneh) [11:43:21] (03CR) 10Aklapper: [C: 04-1] "Bleh, Template language stinks:" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/105938 (owner: 10Aklapper) [11:45:37] (03PS2) 10Aklapper: duplicates.cgi: Add "Resolution" and "Priority" columns [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/105938 [11:47:03] (03CR) 10Aklapper: [C: 031] "Patchset 2 works as expected on Labs: http://boogs.wmflabs.org/duplicates.cgi?sortby=count&reverse=1&bug_id=&sortvisible=0&maxrows=25&chan" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/105938 (owner: 10Aklapper) [11:52:25] (03PS3) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/104362 [11:53:33] (03PS2) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/104365 [11:57:25] (03CR) 10Siebrand: "Replied to comment." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105722 (owner: 10Siebrand) [12:05:23] (03CR) 10Addshore: "okay :<" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/95654 (owner: 10Addshore) [12:06:51] (03CR) 10Hashar: "if you find out what ParamValidator is and whether we could get in Gerrit, that would solve the issue :-]" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/95654 (owner: 10Addshore) [12:09:26] (03CR) 10Addshore: "I believe it should be https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/Validator !" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/95654 (owner: 10Addshore) [12:23:26] (03CR) 10Kipcool: [C: 032 V: 032] Replace usage of deprecated Title::escapeLocalURL() [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/104365 (owner: 10Siebrand) [12:25:59] (03CR) 10Siebrand: [V: 032] "Will make a request for Jenkins jobs." [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/105929 (owner: 10Santhosh) [12:29:32] (03PS1) 10Siebrand: Set up jobs for ContentTranslation repo [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/105940 [12:32:15] (03PS1) 10Siebrand: Set up jobs for ContentTranslation repo [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105941 [12:35:12] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 (owner: 10Catrope) [12:35:21] (03CR) 10Siebrand: Add VisualEditor support (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 (owner: 10Catrope) [12:38:33] (03PS1) 10Jack Phoenix: Remove #mw_trackbacks CSS from shared.css. [core] - 10https://gerrit.wikimedia.org/r/105942 [12:55:04] (03PS1) 10Siebrand: Update documentation for Sanitizer [core] - 10https://gerrit.wikimedia.org/r/105943 [12:55:20] (03CR) 10Siebrand: [C: 032] Remove cases of double escaping [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/105448 (owner: 10Grunny) [12:55:47] (03Merged) 10jenkins-bot: Remove cases of double escaping [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/105448 (owner: 10Grunny) [13:04:24] (03CR) 10Siebrand: [C: 04-1] "Bit of review. You may request Jenkins jobs to be set up. See more comments inline." (036 comments) [extensions/GlobalContributions] - 10https://gerrit.wikimedia.org/r/105911 (owner: 10Legoktm) [13:05:45] (03CR) 10Siebrand: Documentation cleanup (031 comment) [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/105908 (owner: 10Legoktm) [13:08:08] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed. Trivial changes." [core] - 10https://gerrit.wikimedia.org/r/105871 (owner: 10Chad) [13:10:51] (03CR) 10Jack Phoenix: [C: 032 V: 032] grabText: Don't store entire list of pages in memory [tools/grabbers] - 10https://gerrit.wikimedia.org/r/105153 (owner: 10Legoktm) [13:11:45] (03CR) 10Siebrand: "This is a Wikimedia specific change, right? Would it be possible to make this change in 1.23wmfX instead?" [core] - 10https://gerrit.wikimedia.org/r/105857 (owner: 10Ori.livneh) [13:12:23] Hello [13:18:11] (03PS3) 10Manybubbles: Clean up AnalysisConfigBuilder/MappingConfigBuilder [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105888 (owner: 10Chad) [13:18:35] (03CR) 10Manybubbles: [C: 032] "Rebased, reviewed, and verified." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105888 (owner: 10Chad) [13:18:40] (03Merged) 10jenkins-bot: Clean up AnalysisConfigBuilder/MappingConfigBuilder [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105888 (owner: 10Chad) [13:21:27] (03PS2) 10Manybubbles: No need to be static here [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105892 (owner: 10Chad) [13:22:07] (03CR) 10Manybubbles: [C: 032] "Rebased, reviewed, and verified. Also, this is totally something that we'd write as static in java." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105892 (owner: 10Chad) [13:22:11] (03Merged) 10jenkins-bot: No need to be static here [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105892 (owner: 10Chad) [13:27:03] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/105233 (owner: 10CSteipp) [13:31:26] how is jenkins behaving ? :D [13:32:24] (03CR) 10Siebrand: [C: 031] Restore the Details link in Special:AbuseLog (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105819 (owner: 10Jackmcbarn) [13:32:32] (03CR) 10Siebrand: Restore the Details link in Special:AbuseLog [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105819 (owner: 10Jackmcbarn) [13:33:01] hashar: I haven't noticed new issues, but I also think I haven't +2-ed. [13:33:27] hashar: I have https://gerrit.wikimedia.org/r/#/c/105940/ and https://gerrit.wikimedia.org/r/#/c/105941/ for you. [13:34:32] siebrand: deploying :) [13:35:12] (03CR) 10Hashar: [C: 032] Set up jobs for ContentTranslation repo [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/105940 (owner: 10Siebrand) [13:35:54] (03PS2) 10Hashar: Set up jobs for ContentTranslation repo [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/105940 (owner: 10Siebrand) [13:36:20] (03CR) 10Hashar: [C: 032] Set up jobs for ContentTranslation repo [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/105940 (owner: 10Siebrand) [13:36:28] hashar: ty. [13:36:36] (03Merged) 10jenkins-bot: Set up jobs for ContentTranslation repo [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/105940 (owner: 10Siebrand) [13:36:47] siebrand: isn't there any unit tests on that repo ? [13:37:21] ah just browser tests [13:37:31] hashar: Not yet. There will probably be PHPUnit and QUnit, as well as browser tests, but there's no code yet. [13:37:47] hashar: I don't know if I can configure the jobs while there's nothing yet. [13:37:51] should have added a ruby linter as well :D [13:38:13] hashar: And test extensions, but I thought I'd wait until those actually exist. [13:40:03] hashar: I see browser test scaffolding was just added. I missed that. [13:40:11] hashar: So it should indeed have a ruby linter. [13:41:27] siebrand: I am adding them [13:42:25] (03PS1) 10Hashar: yaml/ruby linters for ContentTranslation [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/105948 [13:42:30] siebrand: ^^^ [13:43:12] (03CR) 10Hashar: "since that repos has browser tests, you want to add ruby and yaml linter as created in Jenkins with https://gerrit.wikimedia.org/r/105948" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105941 (owner: 10Siebrand) [13:43:21] I really need to write a universal linter that will take of everything [14:00:32] (03CR) 10Bartosz Dziewoński: [C: 032] Remove #mw_trackbacks CSS from shared.css. [core] - 10https://gerrit.wikimedia.org/r/105942 (owner: 10Jack Phoenix) [14:03:36] (03Merged) 10jenkins-bot: Remove #mw_trackbacks CSS from shared.css. [core] - 10https://gerrit.wikimedia.org/r/105942 (owner: 10Jack Phoenix) [14:07:42] hoo: Regarding the mw.html change, have you written documentation to go in [[mw:Extension:Scribunto/Lua reference manual]] yet? [14:07:57] anomie: Nope, but I planned to do that once it's in [14:08:21] can do that now if you want to merge it later [14:08:30] (03CR) 10Anomie: [C: 032] Add mw.html to Scribunto [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man) [14:08:37] hoo: ^ [14:08:50] \o/ [14:09:30] (03PS3) 10Hoo man: enable tests for Capiunto [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/105934 (owner: 10Aude) [14:09:47] (03Merged) 10jenkins-bot: Add mw.html to Scribunto [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man) [14:09:56] (03CR) 10Hoo man: "Rebased" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/105934 (owner: 10Aude) [14:10:00] hashar: ^ [14:10:30] anomie: Any other places where documentation can be found? [14:12:11] (03CR) 10Hashar: [C: 032] yaml/ruby linters for ContentTranslation [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/105948 (owner: 10Hashar) [14:12:15] hoo: That's the only official place. I don't know what people on e.g. enwiki might want to do about documenting it / replacing the module. [14:12:26] (03Merged) 10jenkins-bot: yaml/ruby linters for ContentTranslation [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/105948 (owner: 10Hashar) [14:12:38] anomie: We'll see, going to update the doc. today ;) [14:12:54] hoo: deploying :D [14:13:11] (03PS4) 10Hashar: enable tests for Capiunto [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/105934 (owner: 10Aude) [14:13:17] anomie: posting that to some enwiki noticeboard/ village pump/ whatever might make sense [14:14:02] hoo: you will need to add jobs in Zuul configuration file as well :-] [14:14:10] hashar: https://gerrit.wikimedia.org/r/#/c/105935/ [14:14:48] I hope that's good enough [14:14:51] (03CR) 10Hashar: [C: 032] "Jobs deployed:" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/105934 (owner: 10Aude) [14:15:06] (03Merged) 10jenkins-bot: enable tests for Capiunto [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/105934 (owner: 10Aude) [14:16:23] (03CR) 10Hashar: [C: 032] Add Capiunto [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105935 (owner: 10Hoo man) [14:16:28] (03Merged) 10jenkins-bot: Add Capiunto [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105935 (owner: 10Hoo man) [14:16:50] hashar: Does it work now? Shall I test it? [14:17:05] hoo: yup you can try it [14:17:17] (03CR) 10Hashar: "deployed" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105935 (owner: 10Hoo man) [14:17:27] we should get a job that test both Scribunto and Capiunto :-D [14:17:57] !g 105157,3 [14:17:57] https://gerrit.wikimedia.org/r/#q,105157,3,n,z [14:18:37] hoo: Fatal error: Class 'Capiunto\RecursiveDirectoryIterator' not found in extensions/Capiunto/Capiunto.hooks.php on line 25 [14:18:39] :( [14:19:25] ehm... that's someone else's fault... for sure!!11 [14:20:53] (03PS3) 10Anomie: Move redirect rendering into WikitextContent [core] - 10https://gerrit.wikimedia.org/r/105829 [14:20:54] (03PS3) 10Anomie: Make imagelinks work like templatelinks [core] - 10https://gerrit.wikimedia.org/r/105830 [14:31:04] hashar: Thanks, [14:31:33] siebrand: still need Zuul triggers to be updated though [14:32:11] (03CR) 10Aklapper: "Upstream changes that require this patch are http://bzr.mozilla.org/bugzilla/4.4/revision/8501 and http://bzr.mozilla.org/bugzilla/4.4/rev" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98005 (owner: 10Aklapper) [14:37:09] (03CR) 10Siebrand: [C: 04-1] "Conflict with Special:History of MobileFrontend extension is still there." [core] - 10https://gerrit.wikimedia.org/r/96170 (owner: 10Legoktm) [14:38:28] (03CR) 10Manybubbles: [C: 032] Doesn't need to be static [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105863 (owner: 10Chad) [14:39:48] (03Merged) 10jenkins-bot: Doesn't need to be static [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105861 (owner: 10Chad) [14:39:51] (03Merged) 10jenkins-bot: Doesn't need to be static [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105863 (owner: 10Chad) [14:42:44] (03PS2) 10Hashar: Enable unit tests for UploadWizard [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/103881 (owner: 10Gergő Tisza) [14:43:25] (03CR) 10Hashar: [C: 032] Enable unit tests for UploadWizard [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/103881 (owner: 10Gergő Tisza) [14:43:30] (03Merged) 10jenkins-bot: Enable unit tests for UploadWizard [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/103881 (owner: 10Gergő Tisza) [14:43:48] (03CR) 10Siebrand: [C: 032] Pass context to HTMLForm, don't use HTMLForm::setTitle [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/100331 (owner: 10Legoktm) [14:43:50] (03Merged) 10jenkins-bot: Pass context to HTMLForm, don't use HTMLForm::setTitle [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/100331 (owner: 10Legoktm) [14:47:18] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105954 [14:47:23] (03PS1) 10Siebrand: Pass context to HTMLForm, don't use HTMLForm::setTitle [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/105955 [14:48:06] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105954 (owner: 10Hashar) [14:48:37] (03CR) 10Manybubbles: "Yeah four hooks would be annoying to work with but harder to screw up. Can we add the parserOutput to this hook? Null if we skipParsed. " [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105224 (owner: 10Chad) [14:49:47] (03PS2) 10Siebrand: Pass context to HTMLForm, don't use HTMLForm::setTitle [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/105955 [14:50:46] (03PS1) 10Siebrand: Pass context to HTMLForm, don't use HTMLForm::setTitle [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/105956 [14:52:32] (03PS1) 10Siebrand: Pass context to HTMLForm, don't use HTMLForm::setTitle [extensions/CommunityHiring] - 10https://gerrit.wikimedia.org/r/105957 [15:04:10] (03PS4) 10Matthias Mullie: AbuseFilter integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103109 [15:10:13] (03PS1) 10Siebrand: Pass context to HTMLForm, don't use HTMLForm::setTitle [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105961 [15:17:31] (03CR) 10Chad: "My motivation is the same as always: less preferences :)" [core] - 10https://gerrit.wikimedia.org/r/105871 (owner: 10Chad) [15:17:56] (03PS5) 10Matthias Mullie: AbuseFilter integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103109 [15:26:34] (03PS1) 10Matthias Mullie: Make general SpamFilter controller, allowing more than just AbuseFilter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105963 [15:27:21] (03PS2) 10Matthias Mullie: Make general SpamFilter controller, allowing more than just AbuseFilter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105963 [15:29:23] (03PS1) 10Siebrand: Pass context to HTMLForm, don't use HTMLForm::setTitle [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/105964 [15:47:49] (03PS1) 10Matthias Mullie: SpamRegex implementation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105965 [15:51:49] (03CR) 10Aarcos: "This looks reasonable to me but I don't think I have the domain knowledge to actually have a vote on this review." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [15:55:26] (03CR) 10Andrew Bogott: [C: 04-1] "Thanks for the cleanup! A few comments inline." (032 comments) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105961 (owner: 10Siebrand) [16:01:34] (03CR) 10Nemo bis: "MatmaRex, wanna do https://translatewiki.net/wiki/Thread:Support/Module_namespace_-_translation_on_Serbian_and_Serbo_Croatian too? :)" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/105175 (owner: 10Bartosz Dziewoński) [16:08:08] hi guillom , are you aware of http://www.google-melange.com/gci/task/view/google/gci2013/6371147037802496 still pending review? Please resolve it in one way or another, thank you. [16:08:49] qgil: will do [16:09:55] guillom, thank you! [16:10:15] guillom: let me help [16:10:32] qgil: sure :) sorry I didn't get to it sooner. It's been a busy couple of days. [16:11:02] guillom, I can imagine. No worries, as long as you resolve it in the next 24h it's fine [16:11:02] Nemo_bis: We don't have to get an accurate count, if we see it's over 120 I'm fine with closing it. [16:11:08] sure [16:12:57] (03PS1) 10Matthias Mullie: SpamBlacklist integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105966 [16:13:09] guillom: I do! :) 326 just for parserfunctions https://www.mediawiki.org/w/index.php?limit=1000&tagfilter=&title=Special%3AContributions&contribs=user&target=Vldandrew&namespace=1198&tagfilter=&year=2014&month=-1 [16:13:41] Nemo_bis: he said that wasn't the right link, I think [16:13:46] bbl, meeting [16:14:33] (03CR) 10Siebrand: "It's per 1.18." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105961 (owner: 10Siebrand) [16:14:47] He did https://www.mediawiki.org/w/index.php?title=Help:Templates/ro&action=history at least [16:15:09] * 316 [16:15:36] logged out? [16:15:57] (03CR) 10Matthias Mullie: "Note: we already have code elsewhere to fetch links from within content that has been fed to Parsoid." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105966 (owner: 10Matthias Mullie) [16:16:08] yes [16:16:14] anomie: https://www.mediawiki.org/wiki/Extension:Scribunto/Lua_reference_manual#Html_library should we spread the word in some way? ;) [16:16:32] qgil: getting issues with the hangout servers; retrying [16:16:38] 131 https://www.mediawiki.org/w/index.php?limit=500&tagfilter=&title=Special%3AContributions&contribs=user&target=86.126.103.231&namespace=1198&tagfilter=&topOnly=1&year=2014&month=-1 [16:17:01] Nemo_bis: Thanks! [16:17:22] I recognise that as one of his IPs [16:18:21] qgil: still getting 500-errors [16:18:35] guillom, weird, we are there... [16:19:04] bleh [16:20:59] nothing on http://www.google.com/appsstatus#hl=en&v=status&ts=1389111616384 ; I don't think it's on my end but I'll reboot anyway just in case [16:21:03] brb [16:21:05] (03PS1) 10Hashar: Zuul status page: support for progress bar [integration/docroot] - 10https://gerrit.wikimedia.org/r/105967 [16:21:16] (03PS1) 10Alexandros Kosiaris: Satisfy lintian [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/105968 [16:21:28] hey marktraceur, I'm totally happy to relicense it -- have you by any chance spoken to the legal folks to make sure that will be okay? [16:21:42] (03CR) 10Siebrand: [C: 04-1] "Inline replies." (033 comments) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105961 (owner: 10Siebrand) [16:22:11] hoo: mw.html.create should document 'args'. mw.html:tag too, but could by reference to mw.html.create. [16:24:13] anomie: mh, thought about that although they are mostly only needed by the internal function [16:24:17] can add though [16:26:38] theopolisme: About licensing the library GPLv2? Why would it not be? [16:27:39] marktraceur: MIT isn't revokable so could someone just "use" the current version under MIT? Is there any specific way to specify that an earlier license was invalid? Etc [16:29:06] theopolisme: If someone has recieved the MIT license I wouldn't worry about it, I don't think enough people have had the opportunity to get the code [16:29:24] Okay, cool. I just don't want to run afoul of anything :) [16:29:40] (03PS2) 10Alexandros Kosiaris: Satisfy lintian [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/105968 [16:29:44] No, I think my initial issue was overblown in the context of you writing from mostly-scratch [16:32:11] marktraceur, how do I indicate that it is derivative of multilightbox? [16:32:30] (03PS1) 10Aude: Fix mapsources i18n alias include [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/105969 [16:33:51] (03PS3) 10Jackmcbarn: Restore the Details link in Special:AbuseLog [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105819 [16:33:52] anomie: Added that [16:34:02] * aude would appreciate that merged ^ [16:34:08] quite trivial [16:34:12] * hoo looks [16:34:23] (03CR) 10Siebrand: "Replied more inline. Will submit a follow-up." (031 comment) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105961 (owner: 10Siebrand) [16:34:24] * aude making test wikisource work [16:34:28] (03CR) 10Hoo man: [C: 032] Fix mapsources i18n alias include [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/105969 (owner: 10Aude) [16:34:29] (03Merged) 10jenkins-bot: Fix mapsources i18n alias include [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/105969 (owner: 10Aude) [16:34:29] and wikivoyage [16:34:36] aude: there you go ;) [16:34:40] yay [16:40:14] (03PS1) 10Chad: Refactor Connection::getPageType() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105971 [16:42:18] (03PS2) 10Siebrand: Pass context to HTMLForm, don't use HTMLForm::setTitle [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105961 [16:42:21] (03CR) 10Siebrand: "Updating status based on follow-up." (032 comments) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105961 (owner: 10Siebrand) [16:44:10] (03CR) 1001tonythomas: [C: 031] Changed the red Email box [core] - 10https://gerrit.wikimedia.org/r/94117 (owner: 10Gerrit Patch Uploader) [16:47:18] (03CR) 10Siebrand: "Thanks, Chad. It was more a request to update the commit summary :). I completely agree and support the goal." [core] - 10https://gerrit.wikimedia.org/r/105871 (owner: 10Chad) [16:51:14] (03CR) 10Matthias Mullie: [C: 032] Only make the last paragraph of a post inline [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105882 (owner: 10Spage) [16:51:19] (03Merged) 10jenkins-bot: Only make the last paragraph of a post inline [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105882 (owner: 10Spage) [17:09:21] theopolisme: If it is (I don't think we've determined that definitely, but I have an inkling) then you should preserve my copyright statement and the license. The name can change, that doesn't really matter. You can point out that the code came from MLB in your README maybe. [17:09:45] ^d: if around, jamesF filled a bug about mediawiki/extensions.git being out of sync since Jan 2nd https://bugzilla.wikimedia.org/59758 [17:09:52] ^d: that breaks self update of extensions on beta cluster [17:10:44] (03CR) 10TMg: [C: 031] Send cache purges for action=raw after editing user css/js [core] - 10https://gerrit.wikimedia.org/r/95095 (owner: 10Brian Wolff) [17:13:21] <^d> hashar: Ugh [17:14:38] marktraceur, i think we need to ask krinkle [17:15:01] but I'm not sure :/ [17:15:26] He added test functionality (didnt modify the actual code but did modify the project...) [17:15:30] Ahhh. [17:15:33] -FFS [17:16:12] Licenses are so annoying [17:22:51] Indeed they are [17:24:06] marktraceur, do you have a means to talk to Krinkle|detached? [17:24:20] Not immediately [17:24:29] I suspect he's with RoanKattouw_away and James_F|Away in Perth [17:24:54] I'll write him an email, as I know their bouncer method is a little shoddy [17:24:54] ^d: and I have no clue how to fix mw/ext.git :( [17:25:05] <^d> hashar: I responded on the bug. [17:25:11] <^d> It'll have to be worked around. [17:25:46] ^d: ah same bug again :D [17:27:02] <^d> Yep [17:39:28] (03PS9) 10MegaAlex: Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [17:39:46] (03PS2) 10Anomie: Add PPFrame::isVolatile and PPFrame::setVolatile [core] - 10https://gerrit.wikimedia.org/r/99792 [17:39:58] (03CR) 10Anomie: "PS2: Rebase" [core] - 10https://gerrit.wikimedia.org/r/99792 (owner: 10Anomie) [17:41:00] gwicke, subbu, cscott, or any other parsoid people: Any chance of getting https://gerrit.wikimedia.org/r/#/c/99792/ reviewed? Tim wants one of you to look it over. [17:41:51] looks like something gwicke should review, he's more on top of the overall architecture [17:42:03] i assume you're not looking for a code style review ;) [17:42:38] I think Tim's concerned it would need an equivalent change in Parsoid [17:43:35] anomie: yes, tim's definitely right it needs a parsoid-side review. i'm just punting that over to gwicke. ;) [17:44:17] anomie, gwicke and i will talk about it this week. [17:44:27] i mean, it looks roughly correct to me, in that it seems like fine-grained marking of non-idempotent parser functions/extensions is definitely necessary. [17:44:58] i just can't authoritatively say whether this particular patch is the right way to do it etc [17:48:00] subbu: ok, thanks [17:54:10] (03CR) 10MarkTraceur: "It looks fine to me - there's a few issues with var statement order, but whatever." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103624 (owner: 10Aarcos) [17:54:19] (03CR) 10MarkTraceur: [C: 032] Add basic UI tests to LicenseInput class. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103624 (owner: 10Aarcos) [17:54:25] (03Merged) 10jenkins-bot: Add basic UI tests to LicenseInput class. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103624 (owner: 10Aarcos) [17:56:30] where can I find a list of small bugs to work on ? [17:57:28] VladAndrew: https://bugzilla.wikimedia.org/buglist.cgi?keywords=easy&resolution=---&list_id=265436 [17:57:36] thanks [18:00:12] https://gerrit.wikimedia.org/r/#/c/105459/7/resources/multilightbox/lightboxinterface.js, i'm thinking they should just do that in ext.multimediaViewer then? [18:00:19] marktraceur: ^ [18:04:14] VladAndrew: you can also add it to your saved searches, check "Easy" https://bugzilla.wikimedia.org/userprefs.cgi?tab=saved-searches [18:05:17] (03CR) 10EBernhardson: [C: 04-1] "a few inconsistencies, will update the patch" (0313 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103109 (owner: 10Matthias Mullie) [18:05:43] thanks nemo [18:08:08] (03PS1) 10Jackmcbarn: Add TITLEBLACKLIST magic word [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/105979 [18:10:41] Hm, yes theopolisme [18:10:50] Probably easy enough to fix [18:21:11] guillom: I was told that I should speak with someone from te french wikisource regardin this bug https://bugzilla.wikimedia.org/show_bug.cgi?id=56461 [18:22:52] In https://gerrit.wikimedia.org/r/#/c/105819/ , the patch was for the Details link being missed from log page as well as the details page as the commit message shows. I got the log pages, but where exactly is this 'details page' mentioned in the commit message ? [18:23:12] VladAndrew: I'm not active there, but you can ping phe, Pyb, yannf or zeph5 in #wikisource [18:23:22] tonythomas01: https://en.wikipedia.org/wiki/Special:AbuseLog/9787243 [18:23:23] that? [18:23:52] #join #wikisource [18:23:56] (03CR) 10Mattflaschen: [C: 04-1] "Edit intro doesn't work with custom local pages. When MediaWiki:helppage has Devwiki:The help page, it displays as "(see the [/wiki/Devwi" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen) [18:24:15] (03CR) 10Mattflaschen: "Doh, wrong changeset." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen) [18:24:32] VladAndrew: That shouldn't be a bug in bugzilla [18:24:50] (03CR) 10Mattflaschen: [C: 04-1] "Edit intro doesn't work with custom local pages. When MediaWiki:helppage has Devwiki:The help page, it displays as "(see the [/wiki/Devwik" [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [18:25:48] Reedy: it was meant for GCI [18:27:10] any idea where SoS is today? [18:27:20] from a sinking ship? [18:27:22] :P [18:27:39] Nikerabbit: it has a red wall against the door [18:27:43] i'm not sure i recognize it [18:27:58] did they repaint r37? or ... [18:27:59] i'll just ask [18:28:16] brion: for remotes like me [18:29:16] Nikerabbit: toby says it's chambers [18:29:20] r37 [18:29:31] i must not be used to that room on the remote side ;) [18:29:39] brion: hmm rooms have permanent calls now? [18:30:11] well permanent setups [18:30:27] brion: ah I see it nw [18:35:46] (03CR) 10Swalling: [C: 031] "Have tested this out, and all seems working. (This was given a design review by Vibha, Kaity, and Moiz in meatspace.)" (031 comment) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105879 (owner: 10Jdlrobson) [18:37:26] jackmcbarn: Thanks ! I got confused. But the bug report says it needs to be removed from the 'Details' page, and gives https://en.wikipedia.org/wiki/Special:AbuseLog/9999 ? [18:37:52] jackmcbarn: actually is that the Details page or the Log page ? [18:37:57] that's another details page [18:38:02] the patch is already submitted though [18:38:20] (03CR) 10Swalling: [C: 031] "Have tested this out, and all seems working. (This was given a design review by Vibha, Kaity, and Moiz in meatspace.)" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105880 (owner: 10Jdlrobson) [18:38:43] (03CR) 10Swalling: [C: 031] "@Mattflaschen: see https://en.wikipedia.org/wiki/Rumi or the test page https://www.mediawiki.org/wiki/User:Jaredzimmerman_(WMF)/test/47" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105881 (owner: 10Jdlrobson) [18:46:08] (03CR) 10GWicke: "In Parsoid we are avoiding the Cite issue by collecting citations and rendering references in a DOM post-processing pass. This also works " [core] - 10https://gerrit.wikimedia.org/r/99792 (owner: 10Anomie) [18:46:10] (03PS6) 10EBernhardson: AbuseFilter integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103109 (owner: 10Matthias Mullie) [18:47:09] (03CR) 10Umherirrender: "maybe caused bug 58434" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/88466 (owner: 10Siebrand) [18:47:18] (03CR) 10EBernhardson: "leaving the problem with multiple abuse filter errors being truncated into a single error, better solution is going to involve adjusting t" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103109 (owner: 10Matthias Mullie) [18:47:34] anomie, subbu, cscott: replied at https://gerrit.wikimedia.org/r/#/c/99792/ [18:48:04] k [18:51:45] (03CR) 10Anomie: "> I would strongly prefer to avoid introducing server-side global parsing state" [core] - 10https://gerrit.wikimedia.org/r/99792 (owner: 10Anomie) [18:55:35] (03CR) 10Matthias Mullie: [C: 032] AbuseFilter integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103109 (owner: 10Matthias Mullie) [18:55:40] (03Merged) 10jenkins-bot: AbuseFilter integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103109 (owner: 10Matthias Mullie) [18:56:48] (03PS1) 10Umherirrender: DatabaseInstaller::setVarsFromRequest needs array [core] - 10https://gerrit.wikimedia.org/r/105980 [18:56:53] (03PS1) 10Matthias Mullie: Fix multi-error message:
    wasn't output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105981 [18:57:59] anomie: are there other use cases for extension tags that can't be handled on the DOM? [18:58:28] extension tags with side effects, that is [18:58:43] (03CR) 10Brion VIBBER: "Re: doing this as an HTTP header instead; I kinda prefer the meta tag as it's more visible -- headers are black magic you have to dig for " [core] - 10https://gerrit.wikimedia.org/r/103387 (owner: 10Yaron Koren) [18:58:49] (03CR) 10Brion VIBBER: [C: 031] Fix to avoid IE "compatibility view" [core] - 10https://gerrit.wikimedia.org/r/103387 (owner: 10Yaron Koren) [18:58:50] gwicke: Not that I know of offhand, but it's possible. Note that besides the parsing, Scribunto is also needing to know when to not cache the results of an expansion. [18:59:54] you mean if the data changes with time? [19:00:39] we were thinking about tracking such dependencies per DOM fragment, but that is a separate issue as it does not involve global state [19:01:13] the idea is that you can re-render only the fragment when necessary without touching any of the other DOM [19:01:36] modulo the global DOM post-processing like re-rendering [19:02:04] gwicke: See bug 46815 [19:03:04] the PHP Cite extension breaks the normal caching contract by depending on side-effects [19:03:12] IMO that is a bug that we should fix [19:04:10] we don't use the PHP Cite extension for that reason [19:06:37] if it only emitted the HTML for each ref and left the references rendering to a DOM pass then caching works just fine [19:08:22] (03CR) 10jenkins-bot: [V: 04-1] DatabaseInstaller::setVarsFromRequest needs array [core] - 10https://gerrit.wikimedia.org/r/105980 (owner: 10Umherirrender) [19:11:46] (03CR) 10Siebrand: [C: 032] DatabaseInstaller::setVarsFromRequest needs array [core] - 10https://gerrit.wikimedia.org/r/105980 (owner: 10Umherirrender) [19:12:03] (03PS1) 10JGonera: Remove styles for #mw-createaccount-join [core] - 10https://gerrit.wikimedia.org/r/105982 [19:13:17] (03PS1) 10Spage: Revert "emergency spam prevention" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105984 [19:13:48] (03PS1) 10Siebrand: DatabaseInstaller::setVarsFromRequest needs array [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/105985 [19:14:28] (03CR) 10Siebrand: [C: 04-1] "Needs release notes" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/105985 (owner: 10Siebrand) [19:14:44] (03CR) 10Bartosz Dziewoński: [C: 031] "I say let's do this. Will merge later this week if no one objects." [core] - 10https://gerrit.wikimedia.org/r/103387 (owner: 10Yaron Koren) [19:14:59] (03CR) 1001tonythomas: [C: 031] Restore the Details link in Special:AbuseLog [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105819 (owner: 10Jackmcbarn) [19:15:54] (03CR) 10Spage: [C: 032] "Needed to test filtering on ee-flow" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105984 (owner: 10Spage) [19:15:59] (03Merged) 10jenkins-bot: Revert "emergency spam prevention" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105984 (owner: 10Spage) [19:16:26] (03PS3) 10Matthias Mullie: Make general SpamFilter controller, allowing more than just AbuseFilter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105963 [19:17:23] (03CR) 10Bartosz Dziewoński: Remove styles for #mw-createaccount-join (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105982 (owner: 10JGonera) [19:18:16] (03PS1) 10Chad: WIP: Implement interwiki searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105986 [19:18:48] (03PS4) 10Matthias Mullie: Make general SpamFilter controller, allowing more than just AbuseFilter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105963 [19:19:26] (03PS2) 10Chad: WIP: Implement interwiki searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105986 [19:20:38] (03PS2) 10Matthias Mullie: SpamRegex implementation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105965 [19:21:09] (03PS1) 10Odder: Namespace translations for Serbian, Serbo-Croatian [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/105989 [19:21:32] (03CR) 10Odder: "Done at https://gerrit.wikimedia.org/r/#/c/105989/" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/105175 (owner: 10Bartosz Dziewoński) [19:22:02] (03CR) 10Odder: "See https://translatewiki.net/wiki/Thread:Support/Module_namespace_-_translation_on_Serbian_and_Serbo_Croatian" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/105989 (owner: 10Odder) [19:22:05] (03CR) 10Swalling: "Should be fine to merge with 103494 but not before." [core] - 10https://gerrit.wikimedia.org/r/105982 (owner: 10JGonera) [19:22:15] (03PS2) 10Matthias Mullie: SpamBlacklist integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105966 [19:24:35] (03CR) 10jenkins-bot: [V: 04-1] DatabaseInstaller::setVarsFromRequest needs array [core] - 10https://gerrit.wikimedia.org/r/105980 (owner: 10Umherirrender) [19:25:49] (03CR) 10Hashar: [C: 032] "some git related issue on jenkins slave :(" [core] - 10https://gerrit.wikimedia.org/r/105980 (owner: 10Umherirrender) [19:28:38] (03CR) 10EBernhardson: [C: 032] Removing AbuseFilter::checkConditions' param [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104496 (owner: 10Matthias Mullie) [19:28:47] (03Merged) 10jenkins-bot: Removing AbuseFilter::checkConditions' param [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104496 (owner: 10Matthias Mullie) [19:29:01] (03Merged) 10jenkins-bot: DatabaseInstaller::setVarsFromRequest needs array [core] - 10https://gerrit.wikimedia.org/r/105980 (owner: 10Umherirrender) [19:31:01] (03CR) 10EBernhardson: [C: 032] Make general SpamFilter controller, allowing more than just AbuseFilter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105963 (owner: 10Matthias Mullie) [19:31:03] (03CR) 10jenkins-bot: [V: 04-1] Make general SpamFilter controller, allowing more than just AbuseFilter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105963 (owner: 10Matthias Mullie) [19:31:35] (03CR) 10Umherirrender: "I am not able to work on branches except master. For normally release notes are added with the patch to master and than cherry-picked, tha" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/105985 (owner: 10Siebrand) [19:31:52] (03PS5) 10Matthias Mullie: Make general SpamFilter controller, allowing more than just AbuseFilter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105963 [19:31:54] (03PS3) 10Chad: WIP: Implement interwiki searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105986 [19:32:30] (03CR) 10EBernhardson: [C: 032] Make general SpamFilter controller, allowing more than just AbuseFilter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105963 (owner: 10Matthias Mullie) [19:32:34] (03Merged) 10jenkins-bot: Make general SpamFilter controller, allowing more than just AbuseFilter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105963 (owner: 10Matthias Mullie) [19:33:14] (03CR) 10JGonera: Remove styles for #mw-createaccount-join (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105982 (owner: 10JGonera) [19:33:52] (03PS4) 10Chad: WIP: Implement interwiki searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105986 [19:35:17] (03CR) 10Hoo man: "Is there any real need for this? Sounds rather horrible, tbh" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/105979 (owner: 10Jackmcbarn) [19:35:23] (03PS2) 10Matthias Mullie: Fix multi-error message:
      wasn't output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105981 [19:35:53] (03CR) 10Jackmcbarn: "It's so that https://en.wikipedia.org/wiki/Module:Protected_edit_request can detect whether pages with requested edits have titleblacklist" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/105979 (owner: 10Jackmcbarn) [19:35:57] (03CR) 10Yaron Koren: "I should note (which I probably should have done before) that there's a chance that this patch won't work - I haven't tested this exact co" [core] - 10https://gerrit.wikimedia.org/r/103387 (owner: 10Yaron Koren) [19:36:41] (03PS3) 10EBernhardson: SpamRegex implementation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105965 (owner: 10Matthias Mullie) [19:36:48] (03CR) 10EBernhardson: [C: 032] SpamRegex implementation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105965 (owner: 10Matthias Mullie) [19:36:54] (03Merged) 10jenkins-bot: SpamRegex implementation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105965 (owner: 10Matthias Mullie) [19:37:49] (03CR) 10Hoo man: "Why don't you create a lua lib then?" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/105979 (owner: 10Jackmcbarn) [19:39:17] (03CR) 10Jackmcbarn: "What's the advantage in doing that over using a parser function?" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/105979 (owner: 10Jackmcbarn) [19:40:49] (03CR) 10Hoo man: "It's nicer to access from lua" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/105979 (owner: 10Jackmcbarn) [19:50:08] (03PS1) 10AalekhN: A possible Solution to Bug 35486 [core] - 10https://gerrit.wikimedia.org/r/105991 [19:50:21] <^d> brion: Took a few years, but the little box on the right is coming back. https://www.mediawiki.org/wiki/File:New_search_interwiki.png :D [19:50:30] <^d> I wonder if anyone else even remembers that. [19:50:36] ! [19:50:36] https://bugzilla.wikimedia.org/show_bug.cgi?id=56740 Typing "!" into a channel shouldn't cause the bot to print the list of all bangcodes it knows [19:50:49] lol [19:51:17] <^d> silly bot [19:51:23] we should cross-advertise with kayak [19:51:25] "search one and done" [19:52:46] <^d> brion: Also, I want to go back to 2005 or so and *stab* you for SearchResult(s) classes. [19:52:57] <^d> :p [19:54:22] ^d: I think it was a bit different? [19:54:23] hey could be worse [19:54:28] (03CR) 10EBernhardson: [C: 032] Fix multi-error message:
        wasn't output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105981 (owner: 10Matthias Mullie) [19:54:28] could be RecentChange class [19:54:33] (03Merged) 10jenkins-bot: Fix multi-error message:
          wasn't output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105981 (owner: 10Matthias Mullie) [19:54:33] I remember horizonal lines [19:54:42] (03PS3) 10EBernhardson: SpamBlacklist integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105966 (owner: 10Matthias Mullie) [19:54:50] +t [19:54:58] <^d> Nemo_bis: I dunno? It's been so long since this code's been used by anyone :p [19:54:59] anyway, fantastic \o/ \o/ [19:55:04] yep [19:55:30] Is dvanliere on IRC? [19:55:37] drdee [19:56:22] -NickServ- Last seen : Jan 07 10:46:42 2014 (9 hours, 9 minutes, 28 seconds ago) [19:56:22] :/ [19:56:34] yep [19:57:26] What exactly does "take an action item on" in https://www.mediawiki.org/wiki/Architecture_Summit_2014/Straw_poll mean? [19:57:52] <^d> It means vote, if you haven't. [19:57:56] lol [19:58:03] <^d> But in product-manager-speak :) [19:58:30] So I read that as "don't vote for anything that you wouldn't agree to vote on at the Architecture Summit"? [19:58:30] it means that you want to help doing something which the RfC/meeting decides needs doing [19:58:44] I doubt it :) [20:00:47] aww two poor clusters are completely orphan of votes [20:02:28] so, for instance, with their votes parent5446 and MaxSem have "promised" working on about half of the MediaWiki codebase :D [20:04:55] (03PS1) 10Reedy: Call to a member function getCommonMetaArray() on a non-object at File.php on line 586 [core] - 10https://gerrit.wikimedia.org/r/105998 [20:05:03] (03PS1) 10EBernhardson: Check User::isBlocked for write actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105999 [20:05:09] Nemo_bis, I actually like the look of the task management stuff - specifically Tickets - but can't commit myself to working on it [20:05:28] (03PS1) 10Gergő Tisza: Fix File::getCommonMetaArray() for files without a handler [core] - 10https://gerrit.wikimedia.org/r/106000 [20:05:50] (03PS1) 10AalekhN: A Possible Solution to Bug 4365 [core] - 10https://gerrit.wikimedia.org/r/106001 [20:06:51] (03CR) 10Umherirrender: "Maybe caused bug 58167" [core] - 10https://gerrit.wikimedia.org/r/90278 (owner: 10Tim Starling) [20:07:59] (03CR) 10Reedy: "I already made https://gerrit.wikimedia.org/r/105998 2 revisions before..." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/106000 (owner: 10Gergő Tisza) [20:10:11] (03Abandoned) 10Gergő Tisza: Fix File::getCommonMetaArray() for files without a handler [core] - 10https://gerrit.wikimedia.org/r/106000 (owner: 10Gergő Tisza) [20:10:54] Krenair: well, I don't think that's meant to be *so* restrictive, an action item can just be CR of a patch or testing the performance of two lines of code or whatever :) it depends on what you find likely to come out of the RfC I suppose [20:11:46] (03CR) 10Aaron Schulz: [C: 04-1] "What about DefaultSettings?" [core] - 10https://gerrit.wikimedia.org/r/105871 (owner: 10Chad) [20:16:53] (03CR) 10Siebrand: [C: 04-1] "Can you please add URLs to threads in the commit summary for verification?" (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/105989 (owner: 10Odder) [20:22:49] (03CR) 10Gergő Tisza: [C: 031] "Tested, fixes the bug." [core] - 10https://gerrit.wikimedia.org/r/105998 (owner: 10Reedy) [20:23:25] (03CR) 10Andrew Bogott: [C: 032] "Reviewed and tested on wikitech-test." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105961 (owner: 10Siebrand) [20:23:28] (03Merged) 10jenkins-bot: Pass context to HTMLForm, don't use HTMLForm::setTitle [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/105961 (owner: 10Siebrand) [20:25:02] (03PS2) 10Odder: Namespace translations for Serbian, Serbo-Croatian [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/105989 [20:26:06] (03CR) 10Odder: "And no, I can't include the links in the commit message — they do not fit." (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/105989 (owner: 10Odder) [20:26:30] (03CR) 10Aaron Schulz: [C: 04-1] "Looks good" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/105833 (owner: 10Ori.livneh) [20:27:36] (03PS5) 10Chad: WIP: Implement interwiki searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105986 [20:28:52] ori: ping [20:29:38] (03CR) 10Spage: "cherry-picked on ee-flow, trying to reply on a Flow board with a link to an item in local SpamBlacklist gives" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105966 (owner: 10Matthias Mullie) [20:31:21] (03PS1) 10Reedy: Call to a member function getCommonMetaArray() on a non-object at File.php on line 586 [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106007 [20:31:22] (03PS1) 10Physikerwelt: bug: parsoid server failed to start [vagrant] - 10https://gerrit.wikimedia.org/r/106008 [20:31:40] (03PS1) 10Reedy: Call to a member function getCommonMetaArray() on a non-object at File.php on line 586 [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/106009 [20:31:50] (03CR) 10Reedy: [C: 032] Call to a member function getCommonMetaArray() on a non-object at File.php on line 586 [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/106009 (owner: 10Reedy) [20:33:01] gwicke: hey [20:34:28] (03PS2) 10Physikerwelt: bug: parsoid server failed to start [vagrant] - 10https://gerrit.wikimedia.org/r/106008 [20:34:36] Who's best to poke about getting Flow bug https://bugzilla.wikimedia.org/show_bug.cgi?id=59786 fixed? [20:34:59] Reedy: ebernhardson [20:35:19] ori: created https://bugzilla.wikimedia.org/show_bug.cgi?id=59792 for the npm / nodejs issue [20:35:55] ebernhardson: https://bugzilla.wikimedia.org/show_bug.cgi?id=59786 [20:35:59] (03CR) 10jenkins-bot: [V: 04-1] Call to a member function getCommonMetaArray() on a non-object at File.php on line 586 [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/106009 (owner: 10Reedy) [20:36:05] gwicke: much obliged, i'll look into it [20:36:27] (03CR) 10Reedy: [V: 032] Call to a member function getCommonMetaArray() on a non-object at File.php on line 586 [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/106009 (owner: 10Reedy) [20:36:43] gwicke: vagrant uses apt.wikimedia.org so as soon as that's in vagrant should pick it up [20:37:30] IIRC we are running reprepo which only supports a single version of each package [20:37:43] (03CR) 10Mattflaschen: [C: 032] "Thanks. In comparing VectorBeta master (http://imgur.com/A55gtrP) and this, the new well-spaced blockquote seems nice and readable (http:" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105881 (owner: 10Jdlrobson) [20:38:28] ori: let me ask paravoid if his backport is available elsewhere [20:39:10] (03CR) 10Reedy: [C: 032] Call to a member function getCommonMetaArray() on a non-object at File.php on line 586 [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106007 (owner: 10Reedy) [20:39:31] (03PS3) 10Physikerwelt: bug: parsoid server failed to start [vagrant] - 10https://gerrit.wikimedia.org/r/106008 [20:42:16] (03Merged) 10jenkins-bot: Call to a member function getCommonMetaArray() on a non-object at File.php on line 586 [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106007 (owner: 10Reedy) [20:43:27] (03CR) 10Physikerwelt: [C: 04-1] "I'm not convinced that this is a good solution but the only way for me to test the math feature of the visual editor see" [vagrant] - 10https://gerrit.wikimedia.org/r/106008 (owner: 10Physikerwelt) [20:46:28] (03PS6) 10Physikerwelt: Add VisualEditor support [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 (owner: 10Catrope) [20:58:19] (03CR) 10Physikerwelt: [C: 031] "In principal it works. But the formula editing feature is listed twice at the betafeatures specialpage." [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 (owner: 10Catrope) [21:00:53] (03CR) 10Umherirrender: [C: 031] Add associated namespace option to Special:NewPages [core] - 10https://gerrit.wikimedia.org/r/52676 (owner: 10MrBlueSky) [21:01:25] https://github.com/leucosticte/UndeleteBatch [21:01:37] Let's create an extension by essentially copy pasting a whole other one, and change a few things [21:04:20] (03CR) 10Ori.livneh: Add ProfilerMwprof (033 comments) [core] - 10https://gerrit.wikimedia.org/r/105833 (owner: 10Ori.livneh) [21:04:20] i hate to ask to jump the queue, but can someone look at https://gerrit.wikimedia.org/r/#/c/105819/ so a regression doesn't end up in enwiki? [21:04:38] (03PS4) 10Ori.livneh: Add ProfilerMwprof [core] - 10https://gerrit.wikimedia.org/r/105833 [21:04:59] jackmcbarn: Just being reviewed doesn't mean it won't end up on enwiki [21:05:01] ^ Aaron|home [21:05:03] it'll need backporting etc [21:05:12] it'll make it into wmf10 with the change that broke it [21:05:22] Rigth [21:05:29] Reedy: patch will go out to fix that one (59786) in an hour [21:05:42] if it gets in the same cycle as the breaking change, won't it keep the break from ever happening in production? [21:05:52] It should do [21:06:02] i was presuming you were meaning with wmf9 on thursday [21:06:09] Also, for UndeleteBatch... Original was GPL 2. But the author of the derivative extension gives no credit... That can't be right, can it? [21:07:07] (03PS1) 10Matthias Mullie: Don't toss in parent post as old revision when validating reply [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106111 [21:07:23] (03PS2) 10Mattflaschen: Typograph tweaks [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105879 (owner: 10Jdlrobson) [21:07:57] (03CR) 10Aaron Schulz: [C: 032] Add ProfilerMwprof [core] - 10https://gerrit.wikimedia.org/r/105833 (owner: 10Ori.livneh) [21:08:24] thanks! [21:09:32] (03PS4) 10Reedy: Restore the Details link in Special:AbuseLog [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105819 (owner: 10Jackmcbarn) [21:09:36] (03CR) 10Reedy: [C: 032] Restore the Details link in Special:AbuseLog [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105819 (owner: 10Jackmcbarn) [21:09:41] (03Merged) 10jenkins-bot: Restore the Details link in Special:AbuseLog [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105819 (owner: 10Jackmcbarn) [21:09:42] (03PS1) 10Umherirrender: Call Installer::getDBTypes() static [core] - 10https://gerrit.wikimedia.org/r/106112 [21:09:56] Reedy: thanks [21:10:23] jdlrobson, do you know why it mixes em and pt? [21:10:29] I'm not a typography expert, but it seems a little odd. [21:11:13] (03Merged) 10jenkins-bot: Add ProfilerMwprof [core] - 10https://gerrit.wikimedia.org/r/105833 (owner: 10Ori.livneh) [21:11:19] (03CR) 10Ori.livneh: [C: 04-1] "Should move tests/phpunit/includes/utils/HashRingTest.php to ../libs as well" [core] - 10https://gerrit.wikimedia.org/r/104778 (owner: 10Aaron Schulz) [21:11:33] (03CR) 10Jdlrobson: [C: 032] Migrate redirectToFragment() from wikibits.js to own module [core] - 10https://gerrit.wikimedia.org/r/94412 (owner: 10Umherirrender) [21:11:57] (03CR) 10EBernhardson: [C: 032] SpamBlacklist integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105966 (owner: 10Matthias Mullie) [21:12:02] (03CR) 10Matthias Mullie: [C: 032] Check User::isBlocked for write actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105999 (owner: 10EBernhardson) [21:12:38] (03Merged) 10jenkins-bot: SpamBlacklist integration [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105966 (owner: 10Matthias Mullie) [21:12:40] (03PS3) 10Ori.livneh: Moved MappedIterator to /libs [core] - 10https://gerrit.wikimedia.org/r/104779 (owner: 10Aaron Schulz) [21:12:44] (03PS4) 10Ori.livneh: Moved MappedIterator to /libs and changed exception type [core] - 10https://gerrit.wikimedia.org/r/104779 (owner: 10Aaron Schulz) [21:12:45] (03CR) 10EBernhardson: [C: 032] Don't toss in parent post as old revision when validating reply [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106111 (owner: 10Matthias Mullie) [21:12:49] (03CR) 10Ori.livneh: [C: 032] Moved MappedIterator to /libs and changed exception type [core] - 10https://gerrit.wikimedia.org/r/104779 (owner: 10Aaron Schulz) [21:13:22] (03Merged) 10jenkins-bot: Check User::isBlocked for write actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105999 (owner: 10EBernhardson) [21:13:31] hey superm401 yeh at some point we should move over to using exclusively em's - just the nature of how this experiment is being run [21:13:52] (easier to talk in terms of pts than ems) [21:14:05] jdlrobson, okay, I'll note it as a future item. [21:14:27] (03Merged) 10jenkins-bot: Don't toss in parent post as old revision when validating reply [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106111 (owner: 10Matthias Mullie) [21:15:20] (03PS3) 10Mattflaschen: Typography tweaks [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105879 (owner: 10Jdlrobson) [21:16:11] jdlrobson, do you know where I can test mw-warning and the related links? [21:16:17] (03Merged) 10jenkins-bot: Migrate redirectToFragment() from wikibits.js to own module [core] - 10https://gerrit.wikimedia.org/r/94412 (owner: 10Umherirrender) [21:17:13] (03Merged) 10jenkins-bot: Moved MappedIterator to /libs and changed exception type [core] - 10https://gerrit.wikimedia.org/r/104779 (owner: 10Aaron Schulz) [21:18:29] (03CR) 10Physikerwelt: [C: 04-1] "now I switched to the vi version Iab0c56246626de1e0f and observed the following behaiviour." [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 (owner: 10Catrope) [21:25:11] chrismcmahon: is https://bugzilla.wikimedia.org/show_bug.cgi?id=59738 still happening? [21:25:20] superm401: i forget the page [21:25:31] jdlrobson, I think it's enwiki-specific. I'll comment. [21:26:16] superm401: $outputPage->wrapWikiMsg( "
          \n$1 [21:26:22] in includes/Article.php [21:26:31] jdlrobson, I meant the related links. [21:26:35] Thanks for the pointer for that. [21:26:45] superm401: specifically which classs? [21:26:52] dablink and rellink [21:27:28] mm are they provided by templates? [21:27:32] Yeah [21:27:37] https://en.wikipedia.org/w/index.php?title=Template:Hatnote&action=edit [21:27:39] https://en.wikipedia.org/w/index.php?title=Template:Rellink&action=edit [21:27:54] I'm fine with it here in a Beta, but if/when it's productized, it doesn't belong in core. [21:27:58] superm401: ok. Yeh I guess I should document that then [21:28:07] superm401: i'll do a follow up now if that's okay? [21:28:12] Yeah, you can update the patch. [21:28:25] templates make things so confusing :( [21:28:42] (03PS2) 10Aaron Schulz: Moved HashRing to /libs [core] - 10https://gerrit.wikimedia.org/r/104778 [21:28:44] With great power, comes great responsibility. [21:28:59] Imagine Wikipedia without infoboxes or disambiguation... [21:29:22] superm401: not so important now that all infoboxes can be read directly on Google :P [21:31:39] (03CR) 10Jdlrobson: [C: 031] "Does listing this hook here encourage it's use?" [core] - 10https://gerrit.wikimedia.org/r/101663 (owner: 10IAlex) [21:34:02] (03CR) 10Hoo man: "This caused https://bugzilla.wikimedia.org/show_bug.cgi?id=59788" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/101490 (owner: 10Anomie) [21:34:15] (03PS4) 10Jdlrobson: Typography tweaks [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105879 [21:35:52] (03PS1) 10Hashar: switch git URL of parsoid/integration to git proto [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/106115 [21:35:54] (03PS1) 10Hashar: point git://integration.wm.o to zuul.eqiad.wmnet [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/106116 [21:35:56] (03CR) 10jenkins-bot: [V: 04-1] point git://integration.wm.o to zuul.eqiad.wmnet [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/106116 (owner: 10Hashar) [21:36:47] greg-g, requesting an LD for Flow, now with anti-spam provisions [21:37:50] spagewmf: are you and ebernhardson still good for 2pm? [21:38:18] greg-g: I didn't know we had a slot, should be fine, thanks [21:38:34] greg-g: yes [21:38:50] cool [21:39:00] 2 or 3 patches now? [21:39:18] if 3, please add to calendar, we're diagnosing a broken wmf9 right now (we reverted the deploy to non-wikipedias, btw) [21:39:48] (03PS4) 10Umherirrender: Add Title::hasFragment and use it [core] - 10https://gerrit.wikimedia.org/r/104750 [21:40:00] greg-g: i'll add to calendar, its 2 patches but the second was split into a few patches for ease of review [21:40:03] greg-g: i'll add to calendar [21:40:15] * greg-g nods [21:40:16] thanks [21:40:25] (03CR) 10Umherirrender: "Patch Set 4: Rebased and resolve conflict" [core] - 10https://gerrit.wikimedia.org/r/104750 (owner: 10Umherirrender) [21:41:14] (03PS2) 10Hashar: switch git URL of parsoid/integration to git proto [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/106115 [21:41:20] (03CR) 10Hashar: [C: 032] switch git URL of parsoid/integration to git proto [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/106115 (owner: 10Hashar) [21:41:47] (03Merged) 10jenkins-bot: switch git URL of parsoid/integration to git proto [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/106115 (owner: 10Hashar) [21:41:56] (03PS2) 10Hashar: point git://integration.wm.o to zuul.eqiad.wmnet [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/106116 [21:44:39] (03PS1) 10Physikerwelt: add type hinting and error handing to workload generator [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/106117 [21:45:53] (03CR) 10Physikerwelt: [C: 032 V: 032] add type hinting and error handing to workload generator [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/106117 (owner: 10Physikerwelt) [21:47:09] (03PS1) 10Chad: Delete submodule Elastica/adding Elastic library [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/106118 [21:47:11] greg-g: well of course, submitting save to wikitech to update the calendar 500'd :P [21:47:19] sweet [21:47:32] they're updating wikitech right now, I guess, no idea the backstory there [21:47:36] they == opsen [21:48:21] <^d> manybubbles: 106118 ^ [21:49:13] ^d: k. I'll do some code reviews when I tracked down this thing..... it is eluding me [21:49:35] <^d> I can do it myself then. [21:49:39] <^d> Need it for wikitech. [21:50:22] (03CR) 10Chad: [C: 032 V: 032] Delete submodule Elastica/adding Elastic library [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/106118 (owner: 10Chad) [21:50:39] jdlrobson, so I ended up testing mw-warning by enabling oversight on my dev wiki. [21:50:53] Don't know if I've ever seen that particular class before. [21:51:22] (03PS1) 10Chad: Updating Elastica to master [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106121 [21:51:35] (03CR) 10Chad: [C: 032 V: 032] Updating Elastica to master [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106121 (owner: 10Chad) [21:51:56] I might have. I think there's something similar for admins somewhere. [21:54:52] oh, sorry [21:55:25] ^d: error: The following untracked working tree files would be overwritten by checkout: [21:55:33] git doens't like that [21:55:37] <^d> Yeah, you have to futz with it. [21:55:43] <^d> Go into extensions/Elastica [21:55:55] (03CR) 10Brian Wolff: [C: 04-1] "Commit message should be descriptive (e.g. make special:whatlinkshere transcludable). Bug number should be on its own line, formated as "" [core] - 10https://gerrit.wikimedia.org/r/105991 (owner: 10AalekhN) [21:56:33] <^d> rm -R Elastica; git reset --hard [21:56:50] (03PS1) 10Aude: Revert "Use WikiPage::prepareContentForEdit in SpamBlacklistHooks::filterMergedContent" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/106123 [21:57:24] jdlrobson: I think so, stale cache [21:57:48] (03PS2) 10Aude: Revert "Use WikiPage::prepareContentForEdit in SpamBlacklistHooks::filterMergedContent" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/106123 [21:58:49] (03CR) 10Hoo man: [C: 032] "Best solution for now" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/106123 (owner: 10Aude) [21:58:50] (03Merged) 10jenkins-bot: Revert "Use WikiPage::prepareContentForEdit in SpamBlacklistHooks::filterMergedContent" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/106123 (owner: 10Aude) [21:59:09] does returning null from php into lua turn into a nil? [21:59:53] (03CR) 10Anomie: "Boo. Wikibase shouldn't be passing a non-editable page as context to the EditFilterMergedContent hook in the first place." [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/106123 (owner: 10Aude) [22:00:31] (03PS1) 10Anomie: Revert "Revert "Use WikiPage::prepareContentForEdit in SpamBlacklistHooks::filterMergedContent"" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/106126 [22:00:56] heh [22:01:05] heh [22:01:07] (03CR) 10Anomie: [C: 04-2] "Procedural -2 for now, once bug 59788 in Wikibase is fixed this should be merged." [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/106126 (owner: 10Anomie) [22:01:58] (03PS1) 10Hashar: get rid of old parsoid jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/106127 [22:03:39] (03CR) 10Hashar: [C: 032] get rid of old parsoid jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/106127 (owner: 10Hashar) [22:03:42] (03CR) 10GWicke: [C: 032] get rid of old parsoid jobs (031 comment) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/106127 (owner: 10Hashar) [22:03:45] (03Merged) 10jenkins-bot: get rid of old parsoid jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/106127 (owner: 10Hashar) [22:12:10] (03CR) 10TTO: "recheck" [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO) [22:12:12] (03PS1) 10Gerrit Patch Uploader: Move toctoggle from mediawiki.util.js to separate file mediawiki.toc.js [core] - 10https://gerrit.wikimedia.org/r/106132 [22:12:13] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/106132 (owner: 10Gerrit Patch Uploader) [22:16:49] (03PS1) 10Spage: Update Flow to master (with anti-spam) [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106133 [22:17:48] (03PS1) 10Reedy: Hack to fix bug 59780 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/106134 [22:18:01] greg-g: ^ That'd be the hack fix to stop it blocking deployment [22:18:11] (03PS3) 10Ori.livneh: Moved HashRing to /libs [core] - 10https://gerrit.wikimedia.org/r/104778 (owner: 10Aaron Schulz) [22:18:15] (03CR) 10Ori.livneh: [C: 032] Moved HashRing to /libs [core] - 10https://gerrit.wikimedia.org/r/104778 (owner: 10Aaron Schulz) [22:19:17] Reedy: great [22:19:23] Reedy: we have another issue though now :/ [22:19:28] with CategoryTree [22:20:03] (03CR) 10Mattflaschen: [C: 032] "For reference, the English Wikipedia pages where the on-wiki classes are added are https://en.wikipedia.org/w/index.php?title=Template:Hat" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105879 (owner: 10Jdlrobson) [22:20:07] If it was an issue with wmf9... reverting back to wmf8 should've fixed it [22:20:08] (03Merged) 10jenkins-bot: Typography tweaks [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105879 (owner: 10Jdlrobson) [22:20:15] (03CR) 10MarkTraceur: "Trusting tgr on this" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [22:20:23] Possibly bits related fail [22:20:28] we can kick some caches [22:22:14] (03Merged) 10jenkins-bot: Moved HashRing to /libs [core] - 10https://gerrit.wikimedia.org/r/104778 (owner: 10Aaron Schulz) [22:22:31] (03PS2) 10Mattflaschen: Thumbnail styling [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105880 (owner: 10Jdlrobson) [22:23:14] Reedy: yeah, that could be, waiting on a bug report [22:23:17] (03PS1) 10Reedy: Hack to fix bug 59780 [extensions/TimedMediaHandler] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106135 [22:23:43] it's affecting Grants on meta, so, yeah, real annoying [22:23:46] (03CR) 10Reedy: [C: 032] Hack to fix bug 59780 [extensions/TimedMediaHandler] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106135 (owner: 10Reedy) [22:23:48] (03Merged) 10jenkins-bot: Hack to fix bug 59780 [extensions/TimedMediaHandler] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106135 (owner: 10Reedy) [22:25:04] (03PS1) 10Bsitu: Removing AbuseFilter::checkConditions' param [extensions/AbuseFilter] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106136 [22:25:21] (03PS1) 10Physikerwelt: little fixes to the workload generator [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/106137 [22:25:55] anomie|away: https://gerrit.wikimedia.org/r/#/c/105829/3 mentions bug 27621, but shouldn't it be the follow-up commit that mentions that? [22:25:57] (03PS1) 10Reedy: Update TMH to head of 1.23wmf9 deployment branch [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106138 [22:26:05] (03CR) 10Bsitu: [C: 032] Removing AbuseFilter::checkConditions' param [extensions/AbuseFilter] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106136 (owner: 10Bsitu) [22:26:09] (03CR) 10Physikerwelt: [C: 032 V: 032] little fixes to the workload generator [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/106137 (owner: 10Physikerwelt) [22:26:46] (03Merged) 10jenkins-bot: Removing AbuseFilter::checkConditions' param [extensions/AbuseFilter] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106136 (owner: 10Bsitu) [22:26:48] (03CR) 10Reedy: [C: 032 V: 032] Update TMH to head of 1.23wmf9 deployment branch [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106138 (owner: 10Reedy) [22:27:08] (03CR) 10Bsitu: [C: 032] Update Flow to master (with anti-spam) [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106133 (owner: 10Spage) [22:29:49] (03CR) 10Aaron Schulz: "https://gerrit.wikimedia.org/r/#/c/105829/3 mentions bug 27621, but shouldn't it be the follow-up commit that mentions that?" [core] - 10https://gerrit.wikimedia.org/r/105829 (owner: 10Anomie) [22:33:26] (03Merged) 10jenkins-bot: Update Flow to master (with anti-spam) [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106133 (owner: 10Spage) [22:35:26] (03CR) 10Aaron Schulz: Make imagelinks work like templatelinks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105830 (owner: 10Anomie) [22:36:54] Aaron|home: 105829 will fix it by putting the file redirect link into pagelinks (WikitextContent.php line 323). Although the real fix for that sort of issue is 104764. [22:38:46] (03PS2) 10Jackmcbarn: Add mw.ext.TitleBlacklist.test [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/105979 [22:40:10] (03PS1) 10Bsitu: Update AbuseFilter [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106140 [22:40:32] (03CR) 10Bsitu: [C: 032] Update AbuseFilter [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106140 (owner: 10Bsitu) [22:41:04] (03PS1) 10Reedy: Revert "Use WikiPage::prepareContentForEdit in SpamBlacklistHooks::filterMergedContent" [extensions/SpamBlacklist] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106141 [22:41:09] (03CR) 10Reedy: [C: 032] Revert "Use WikiPage::prepareContentForEdit in SpamBlacklistHooks::filterMergedContent" [extensions/SpamBlacklist] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106141 (owner: 10Reedy) [22:41:17] (03CR) 10Aaron Schulz: [C: 032] Move redirect rendering into WikitextContent [core] - 10https://gerrit.wikimedia.org/r/105829 (owner: 10Anomie) [22:41:49] faster! [22:41:58] (03Merged) 10jenkins-bot: Revert "Use WikiPage::prepareContentForEdit in SpamBlacklistHooks::filterMergedContent" [extensions/SpamBlacklist] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106141 (owner: 10Reedy) [22:42:02] (03CR) 10Aaron Schulz: [C: 032] "Extra $dbr can be cleaned up later" [core] - 10https://gerrit.wikimedia.org/r/105830 (owner: 10Anomie) [22:44:18] (03PS1) 10Reedy: Update SpamBlacklist to head of wmf/1.23wmf9 deployment branch [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106143 [22:44:52] * anomie|away adds Aaron|home as a reviewer on https://gerrit.wikimedia.org/r/#/c/105831/ and https://gerrit.wikimedia.org/r/#/c/105832/, since he merged https://gerrit.wikimedia.org/r/#/c/105829/ [22:44:53] (03PS2) 10Reedy: Update SpamBlacklist to head of wmf/1.23wmf9 deployment branch [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106143 [22:44:57] (03CR) 10Aaron Schulz: [C: 032] Send cache purges for action=raw after editing user css/js [core] - 10https://gerrit.wikimedia.org/r/95095 (owner: 10Brian Wolff) [22:44:59] (03CR) 10Reedy: [C: 032 V: 032] Update SpamBlacklist to head of wmf/1.23wmf9 deployment branch [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106143 (owner: 10Reedy) [22:45:02] (03Merged) 10jenkins-bot: Update AbuseFilter [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106140 (owner: 10Bsitu) [22:45:04] (03Merged) 10jenkins-bot: Move redirect rendering into WikitextContent [core] - 10https://gerrit.wikimedia.org/r/105829 (owner: 10Anomie) [22:46:01] anomie|away: yeah I was thinking of those, didn't know there were commits already [22:46:20] (03CR) 10Mattflaschen: [C: 04-1] "Please add a note on the plans for magnify. Is it intended to remove it, or keep it for non-visual users (e.g. screen readers)?" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105880 (owner: 10Jdlrobson) [22:49:06] (03CR) 10Aaron Schulz: [C: 032 V: 032] Use WikitextContent to render redirects [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/105832 (owner: 10Anomie) [22:50:15] (03PS3) 10Jdlrobson: Thumbnail styling [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105880 [22:52:32] (03PS1) 10SG: Merge "Move redirect rendering into WikitextContent" [core] - 10https://gerrit.wikimedia.org/r/106144 [22:53:17] (03CR) 10jenkins-bot: [V: 04-1] Make imagelinks work like templatelinks [core] - 10https://gerrit.wikimedia.org/r/105830 (owner: 10Anomie) [22:53:30] (03PS3) 10Jackmcbarn: Add mw.ext.TitleBlacklist.test [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/105979 [22:54:03] (03PS1) 10Ori.livneh: Update EventLogging to master [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/106145 [22:54:54] * Aaron|home debugs <> [22:56:59] do any extensions other than Scribunto itself currently implement anything in lua? [22:57:13] (03Merged) 10jenkins-bot: Send cache purges for action=raw after editing user css/js [core] - 10https://gerrit.wikimedia.org/r/95095 (owner: 10Brian Wolff) [22:59:58] (03PS1) 10Reedy: Make WikiPage::$mPreparedEdit public [core] - 10https://gerrit.wikimedia.org/r/106146 [23:00:29] (03PS1) 10Reedy: Make WikiPage::$mPreparedEdit public [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106147 [23:00:49] (03CR) 10Chad: [C: 032 V: 032] Make WikiPage::$mPreparedEdit public [core] - 10https://gerrit.wikimedia.org/r/106146 (owner: 10Reedy) [23:01:01] (03CR) 10Chad: [C: 032 V: 032] Make WikiPage::$mPreparedEdit public [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106147 (owner: 10Reedy) [23:01:25] (03PS1) 10Kaldari: Removing italic override for blockquotes [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106148 [23:07:34] (03PS1) 10Bsitu: Update Flow to master [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106150 [23:08:30] (03CR) 10Bsitu: [C: 032] Update Flow to master [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106150 (owner: 10Bsitu) [23:09:31] (03PS1) 10Spage: Correct update Flow to master (with anti-spam) [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106151 [23:10:13] (03PS1) 10Aaron Schulz: Handle missing revisions a bit better [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/106152 [23:11:51] (03CR) 10Mattflaschen: [C: 032] "Looks good. See prior comment." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105880 (owner: 10Jdlrobson) [23:11:56] (03Merged) 10jenkins-bot: Thumbnail styling [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105880 (owner: 10Jdlrobson) [23:12:00] (03PS2) 10Mattflaschen: Blockquote styling [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105881 (owner: 10Jdlrobson) [23:12:05] (03Merged) 10jenkins-bot: Update Flow to master [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106150 (owner: 10Bsitu) [23:12:09] jackmcbarn: As in adding mw.* libraries? Wikibase does. And SMW was going to at one point, but I think they wound up abandoning it. And then there's hoo's new Capiunto extension. [23:12:12] (03CR) 10Mattflaschen: [C: 032] "See prior review." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105881 (owner: 10Jdlrobson) [23:12:38] thanks superm401 [23:12:47] jdlrobson, no problem. [23:12:55] (03Merged) 10jenkins-bot: Blockquote styling [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105881 (owner: 10Jdlrobson) [23:13:46] (03PS4) 10Aaron Schulz: Make imagelinks work like templatelinks [core] - 10https://gerrit.wikimedia.org/r/105830 (owner: 10Anomie) [23:13:53] (03CR) 10Aaron Schulz: [C: 032] Make imagelinks work like templatelinks [core] - 10https://gerrit.wikimedia.org/r/105830 (owner: 10Anomie) [23:15:02] (03Abandoned) 10Spage: Correct update Flow to master (with anti-spam) [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106151 (owner: 10Spage) [23:17:41] (03Merged) 10jenkins-bot: Make imagelinks work like templatelinks [core] - 10https://gerrit.wikimedia.org/r/105830 (owner: 10Anomie) [23:17:59] (03CR) 10Anomie: Make imagelinks work like templatelinks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105830 (owner: 10Anomie) [23:18:04] spagewmf: i was just looking into a bingle issue for the analytics team and noticed your bingle conrjob is commented out [23:18:14] (03CR) 10Aaron Schulz: [C: 032] Use WikitextContent to render redirects [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/105831 (owner: 10Anomie) [23:18:30] (03Merged) 10jenkins-bot: Use WikitextContent to render redirects [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/105831 (owner: 10Anomie) [23:23:28] (03CR) 10Swalling: "Can you give me a screenshot or a link which illustrates the problem? I don't understand what you're trying to say here." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106148 (owner: 10Kaldari) [23:24:33] (03PS1) 10Kaldari: Removing 3 lines that are identical to those already in Vector [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106153 [23:26:06] Swalling: would probably be easier if I show you [23:26:36] Yeah I mostly commented for the benefit of everyone [23:28:02] StevenW: I'll discuss with the designers as well [23:32:48] (03CR) 10Mattflaschen: [C: 04-1] "-1, just because I would like to remove the remaining rule too if possible. The only difference is that the VectorBeta does not support S" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106153 (owner: 10Kaldari) [23:34:41] (03PS1) 10Cmcmahon: Make the check for talk/contribs empty because IE10 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106155 [23:38:11] (03CR) 10Mattflaschen: "Never mind. I thought VectorBeta was on top of Vector. Now that I looked into it, I see it replaces the core module entirely. That mean" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106153 (owner: 10Kaldari) [23:41:24] (03CR) 10Mattflaschen: "The SVG discrepancy is presumably because the change introducing the SVG versions (f188e9f79cfe21cbf84559752e4451cd26639e9f) was only merg" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/106153 (owner: 10Kaldari) [23:49:19] (03PS1) 10EBernhardson: Revert "Utilize BufferedCache in TreeRepository" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/106159 [23:50:05] (03PS1) 10GWicke: Add Reference to relevant bug in new MSIE 6 CSS sanitization tests [core] - 10https://gerrit.wikimedia.org/r/106160 [23:54:59] (03PS1) 10Reedy: Make SELECT queries against slaves in updateCollation.php [core] - 10https://gerrit.wikimedia.org/r/106162 [23:58:56] (03CR) 10Subramanya Sastry: [C: 031] Add Reference to relevant bug in new MSIE 6 CSS sanitization tests [core] - 10https://gerrit.wikimedia.org/r/106160 (owner: 10GWicke)