[00:19:50] (03PS1) 10Aude: Fix php notice for special page in Special:Version [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/105625 [00:23:53] (03PS1) 10Aude: Add alias file for MapSources special page [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/105626 [00:30:08] (03PS2) 10Aude: Add alias file for MapSources special page [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/105625 [00:30:50] (03Abandoned) 10Aude: Add alias file for MapSources special page [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/105626 (owner: 10Aude) [00:34:20] (03CR) 10Ori.livneh: [C: 031] "I am personally in favor of renaming the parameters outright or committing to remove them by some specific release. People don't expect to" [core] - 10https://gerrit.wikimedia.org/r/89380 (owner: 10Bartosz Dziewoński) [00:48:55] (03PS1) 10Jackmcbarn: Add Special:Purge [core] - 10https://gerrit.wikimedia.org/r/105629 [00:52:56] (03PS1) 10Aude: Add special page aliases [extensions/RandomRootPage] - 10https://gerrit.wikimedia.org/r/105631 [00:58:38] (03PS2) 10Jackmcbarn: Add Special:Purge [core] - 10https://gerrit.wikimedia.org/r/105629 [01:01:58] MatmaRex: ^^ [01:02:00] !? [01:02:01] There is no such key, you probably want to try: !?>, !anglebrackets, !bom, !bugsearch, !bzsource, !cookies, !core, !damneditcount, !defaultsettings, !developer, !doesntwork, !dpl, !easy, !evilglobals, !externaleditor, !f5, !file, !google, !googleit, !iis, !info, !lazy, !line, !passthru, !phpinfo, !purge, !reportbug, !rt, !search, !smw, !tables.sql, !test, !ts, !unicode_test, !viewvc, !votes, !wf, !wikipmediawiki, !wp, !5.4, !unicorn, !seen, !bzqs, !vebug, !tea, !logs, !codesearch, !gitblit, !lmgtfy, !, !dontdothat, [01:02:02] ?!?!?! [01:02:13] !unicorn [01:02:13] Need more magic in your life? See https://wikitech.wikimedia.org to create your own! [01:02:20] !?> [01:02:20] The PHP closing tag "?>" is never required at the end of a pure-code php file, and mediawiki developers actively remove it, as it often causes problems related to trailing whitespace, and "headers already sent" errors. See also http://news.php.net/php.general/280796 and !bom as well as https://bugzilla.wikimedia.org/show_bug.cgi?id=17642 [01:02:23] Reedy: wat? [01:02:32] Isn't that a dupe? [01:02:43] what? [01:03:02] [00:58:35] (PS2) Jackmcbarn: Add Special:Purge [core] - https://gerrit.wikimedia.org/r/105629 [01:03:07] um, dunno [01:04:07] Weren't you working on a revision for that too? [01:04:47] I can't be imagining this.. [01:04:52] umm [01:05:11] wouldn't it have shown up in the tracker if there were? [01:06:03] Reedy: i was doing special:diff [01:06:10] Oh [01:06:13] I seee [01:06:16] i guess y'all can search gerrit for "message:purge" [01:13:38] hey guys, I'm having some problems with doing match and/or replaces on the output string of $parser->recursiveTagParse($input) [01:14:37] I need to make a certain tag behave differently when nested within another tag, but it looks like it is impossible to find/replace things within the nested tags [01:15:10] I've made a SO question page where I also posted some code, which is at http://stackoverflow.com/questions/20941204/unable-to-match-or-replace-in-recursivetagparse-return-string [01:16:05] but does anyone here know how to make the nested tag behave differently when it's nested within another certain tag? [01:23:32] legoktm: around? [01:23:40] hi [01:23:42] ish [01:24:25] i submitted my own patch to https://bugzilla.wikimedia.org/show_bug.cgi?id=59622 but i think your solution at https://gerrit.wikimedia.org/r/#/c/96170/ is better and should just have another class added [01:24:28] what do you think? [01:25:02] oh man [01:25:06] that's going to be a nasty rebase [01:25:09] I forgot about that [01:25:15] lemme look at your patch [01:26:01] I'm a favor of doing it my way :P [01:26:05] I'm in* [01:26:30] can you update your patch to include purge then? [01:27:23] (03Abandoned) 10Jackmcbarn: Add Special:Purge [core] - 10https://gerrit.wikimedia.org/r/105629 (owner: 10Jackmcbarn) [01:29:54] yeah sure [01:31:13] Does anyone know what the Mediawiki: page is for the links on the bottom of the user contribution page? [01:31:26] MediaWiki:Sp-contributions-footer ? [01:31:51] That's it, thank you jackmcbarn. [01:32:16] np [01:33:37] techman224, uselang=qqx is useful for this sort of thing [01:34:11] (03CR) 10Deskana: [C: 031] Remove grant management sister-project warning [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/105411 (owner: 10CSteipp) [01:34:28] Krenair, thank you for the tip [01:37:45] (03CR) 10Bartosz Dziewoński: "If we decide we want to remove this, then it's just a matter of killing this one method." [core] - 10https://gerrit.wikimedia.org/r/89380 (owner: 10Bartosz Dziewoński) [01:37:54] Hey everybody [01:38:06] Is there a GCI mentor online at the moment? [01:38:22] (03CR) 10Deskana: [C: 04-1] "Good, but the mention of the API is a bit more technical than is necessary considering this is aimed at the non-technical end user. Sugges" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/105233 (owner: 10CSteipp) [01:38:44] Ahmad96: what;s the question? [01:39:36] I would really appriciate, if it would be possible to open up a "write a discovery report" task. I thought there were some left, but it seems like all are done [01:40:09] Ahmad96: i think it's no longer possible to claim tasks right now, actually? [01:40:09] I was hoping to write that essay at the end of the GCI [01:40:15] really? [01:40:17] oh okay then [01:41:04] Because it made no sense to write such an essay in the first week, so I was oping to do it at the end, but whatever :) [01:41:09] Was really fun [01:41:35] Ahmad96: i'm not sure, actually [01:41:44] i've heard some other student complain about it :) [01:42:01] Ahmad96: we can test it - can you try claiming some task, like https://www.google-melange.com/gci/task/view/google/gci2013/5786720972832768 ? (you'll just unclaim it afterwards) [01:42:02] MatmaRex, I can't see this task, sorry. [01:42:25] (gcibot broke today, it seems) [01:42:57] Hmm I've currently got a task claimed, I hoped to start the essay task in a couple of hours or so [01:43:14] I'll try that a bit later then :) [01:43:23] ah, sure [01:43:48] i could probably create another task like that, i guess [01:43:58] basile: you're not around, i guess? [01:44:11] okay thanks [01:44:21] (basile is Guillaume Paumier) [01:44:32] (who's mentoring these tasks) [01:46:03] Ahmad96: oh, whoops. turns out i can't create a task [01:46:12] apparently this has been actually disabled [01:46:22] Okay no worries then :) [01:46:35] It's not like I'm getting into the top 5 either way haha [01:46:58] if you feel like writing one, by all means go ahead, but it seems like we won't be able do do it via GCI :) [01:47:01] heh [01:47:23] yeah, several people dominated the leaderboard [01:47:58] The one thing I don't like about this competition is, that It's a bit too focused on quantity. [01:48:10] Other than that, it was great [01:48:18] Got to learn a lot of new stuff [01:48:30] and I'm going to stick around on the kiwix project [01:48:37] yeah, i'm a little uneasy about this myself [01:49:30] organizations get to choose their 2 "winners", but only among the 5 students with most tasks completed for given org [01:49:31] I don't like to name somebody, but there were just too many students, that picked the localisation and template tasks and no code tasks [01:49:34] (i guess you know that) [01:49:36] Hello. [01:50:18] we really didn't have enough code tasks :/ but i was pretty much the only person creating/mentoring those [01:50:32] and we ran out of the ones i had prepared in like a week [01:51:01] well, food for thought for next year's edition :) Ahmad96, will you still be eligible then? (age limits) [01:51:21] Nope, unfortunatley not :/ [01:51:34] :( [01:51:35] I'm 17, was my first and last time [01:51:47] Well, but i'll stick around in the community [01:51:47] well, you can always mentor then :P i was a contestant two years ago [01:51:51] I love it here [01:52:05] Yeah I was thinking about that as well :) [01:53:26] :D [02:12:55] (03CR) 10Jack Phoenix: [C: 032 V: 032] Support the older video ID syntax. [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/105382 (owner: 10Jack Phoenix) [02:15:04] (03PS1) 10Jack Phoenix: Support the pixel unit (px) in height/width parameters, because apparently a lot of people use it there. [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/105633 [02:17:00] (03CR) 10Jack Phoenix: [C: 032 V: 032] Support the pixel unit (px) in height/width parameters, because apparently a lot of people use it there. [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/105633 (owner: 10Jack Phoenix) [02:22:36] Hey I am new to mediawiki development. I have been trying to setup mediawiki and understand the development part. Can someone guide me to solve some simple bug so that I can get started? I don't have much experience in open source. [02:24:36] legoktm could possibly help you [02:25:20] have you tried searching bugzilla? [02:26:17] Yes I am new to OSS [02:27:13] I was trying to figure out how to start but couldn't [02:30:53] !easy [02:30:53] Bugzilla maintains a list of easy bugs for us, that are considered a good first step for new MediaWiki developers. See https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=keyword%3Aeasy for the list. [02:31:11] unknownguy10: sorry, i'm just leaving - try with one of the bugs listed there :) [02:31:51] Thank you for your reply. I will check out the bugs. [02:58:08] (03PS1) 10Jack Phoenix: Version 3.1 - fixed color picker and moved it to its own file. [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/105634 [02:59:39] (03CR) 10Jack Phoenix: [C: 032 V: 032] Version 3.1 - fixed color picker and moved it to its own file. [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/105634 (owner: 10Jack Phoenix) [02:59:50] (03PS1) 10PleaseStand: No need to return true/false from AutoLoader [core] - 10https://gerrit.wikimedia.org/r/105635 [03:01:56] (03CR) 10PleaseStand: "This is split from I1d3fb04a." [core] - 10https://gerrit.wikimedia.org/r/105635 (owner: 10PleaseStand) [03:40:23] (03PS1) 10Legoktm: Guard against no valid IPs being provided to GlobalBlocking::checkIpsForBlock [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/105636 [03:42:34] (03CR) 10Jeroen De Dauw: "Oh the nitpicking. Removing myself as reviewer." [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/105514 (owner: 10Nemo bis) [03:55:39] (03CR) 10Parent5446: [C: 032] "One step closer to being PSR-4 compliant." [core] - 10https://gerrit.wikimedia.org/r/105635 (owner: 10PleaseStand) [03:58:58] (03Merged) 10jenkins-bot: No need to return true/false from AutoLoader [core] - 10https://gerrit.wikimedia.org/r/105635 (owner: 10PleaseStand) [03:59:13] (03CR) 10Aaron Schulz: [C: 032] Cleanup of includes/rcfeed [core] - 10https://gerrit.wikimedia.org/r/105480 (owner: 10Legoktm) [04:03:03] (03Merged) 10jenkins-bot: Cleanup of includes/rcfeed [core] - 10https://gerrit.wikimedia.org/r/105480 (owner: 10Legoktm) [04:23:45] (03PS1) 10Nullzero: always show diff link if available [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105637 [04:25:29] (03PS2) 10Nullzero: always show diff link if available [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105637 [04:39:44] (03PS1) 10Gnosygnu: v1.1.1.1 [xowa] - 10https://gerrit.wikimedia.org/r/105638 [04:40:16] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/105638 (owner: 10Gnosygnu) [04:45:35] hello yurik Did u get the question i asked yesterday? [06:28:11] (03CR) 10Legoktm: Split user rights changes into their own category (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91817 (owner: 10Legoktm) [06:38:37] (03CR) 10MZMcBride: Show an error to the user if the spamlist has no targets on it (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 (owner: 10Legoktm) [06:38:41] legoktm: ^ [06:38:44] :P [06:40:47] I think lego was pinged by that already [06:43:54] (03CR) 10Legoktm: Show an error to the user if the spamlist has no targets on it (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 (owner: 10Legoktm) [06:45:56] how nice, I forgot my gerrit credentials [06:46:27] legoktm: https://gerrit.wikimedia.org/r/#/c/78946/ [06:46:37] legoktm: Is that abandoned or is it a good starting point for something? [06:46:39] Or? [06:48:42] It probably just needs a rebase on top of https://gerrit.wikimedia.org/r/#/c/94706/ [06:52:17] (03CR) 10Legoktm: Add API module to send MassMessages (033 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 (owner: 10Legoktm) [06:53:44] (03PS13) 10Legoktm: Add API module to send MassMessages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 [06:53:45] (03CR) 10jenkins-bot: [V: 04-1] Add API module to send MassMessages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 (owner: 10Legoktm) [06:53:50] :| [06:53:57] (03PS14) 10Legoktm: Add API module to send MassMessages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 [06:54:25] silly jenkins-bot [07:01:47] (03PS1) 10Catrope: Failing test case for attribute selector bug in CSSJanus [core] - 10https://gerrit.wikimedia.org/r/105639 [07:03:38] (03CR) 10jenkins-bot: [V: 04-1] Failing test case for attribute selector bug in CSSJanus [core] - 10https://gerrit.wikimedia.org/r/105639 (owner: 10Catrope) [07:36:27] (03PS2) 10Catrope: Support attribute selectors in CSSJanus [core] - 10https://gerrit.wikimedia.org/r/105639 [07:37:49] Gotta love our testing infrastructure [07:37:59] (03PS3) 10Catrope: Support attribute selectors in CSSJanus [core] - 10https://gerrit.wikimedia.org/r/105639 [07:38:07] CSSJanusTest.php has the actual and expected values flipped, which led to a fair amount of head-scratching when debugging a failing test [07:38:41] And after submitting a fix for it, phpcs complains about a line that's too long that I didn't even touch it's just because it's in a file that I touched [07:45:12] (03PS4) 10Catrope: Support attribute selectors in CSSJanus [core] - 10https://gerrit.wikimedia.org/r/105639 [07:46:40] Hi RoanKattouw. [07:47:01] Howdy [07:47:02] https://www.mediawiki.org/wiki/Gerrit/Reports/Open_changesets_by_owner [07:47:14] Lego has 122 open changesets. [07:47:23] Ouch [07:47:31] Bartosz has 40. [07:47:34] Yeah I saw that dashboard a little while ago but I didn't realize it had ballooned that badly [07:47:42] most of them are https://gerrit.wikimedia.org/r/#/q/status:open+topic:getPageTitle,n,z [07:47:43] Wasn't Bartosz at 80ish before? [07:47:50] Dunno. [07:47:54] Platonides was high for a while. [07:48:03] He seems to have fallen to 17. [07:48:50] Holy crap [07:49:03] That's a lot of getPageTitle changes [07:49:04] legoktm: 46, it looks like. [07:49:07] Even minus 46, you're at... [07:49:12] 76. [07:49:12] Still leading. [07:50:25] (03CR) 10Siebrand: Split user rights changes into their own category (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91817 (owner: 10Legoktm) [07:52:16] * RoanKattouw is trying to cook up a query that drops changes with CR-1 [07:52:24] I tried owner:"Legoktm" status:open -topic:getPageTitle -CodeReview<=-1 but that doesn't work [07:52:37] (03CR) 10Legoktm: "I'm not sure how to write tests for this, the function is dependent on a lot of global state making it extremely difficult to write a PHPU" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/102383 (owner: 10Legoktm) [07:53:04] I can get a list of ones that are ready for merging [07:53:23] https://gerrit.wikimedia.org/r/#/c/87183/ [07:54:14] https://gerrit.wikimedia.org/r/#/c/88683/ [07:54:25] (03CR) 10Siebrand: [C: 032] Add special page aliases [extensions/RandomRootPage] - 10https://gerrit.wikimedia.org/r/105631 (owner: 10Aude) [07:54:27] (03Merged) 10jenkins-bot: Add special page aliases [extensions/RandomRootPage] - 10https://gerrit.wikimedia.org/r/105631 (owner: 10Aude) [07:54:35] https://gerrit.wikimedia.org/r/#/c/90263/ has basically a +2, it just needs someone to coordinate the deployment [07:54:52] RoanKattouw: ^ is an API one too [07:55:51] Gloria: what did you think of https://gerrit.wikimedia.org/r/#/c/94696 ? [07:56:05] (03CR) 10Siebrand: [C: 032] Add alias file for MapSources special page [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/105625 (owner: 10Aude) [07:56:07] (03Merged) 10jenkins-bot: Add alias file for MapSources special page [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/105625 (owner: 10Aude) [07:56:15] (03PS2) 10Legoktm: Don't parse custom footer [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97366 [07:56:35] legoktm: Re AssertEdit, what is the order in which these things should be deployed? [07:56:47] (03CR) 10Siebrand: [C: 031] Add test to validate special page aliases [core] - 10https://gerrit.wikimedia.org/r/97118 (owner: 10Aude) [07:56:51] Is it reasonable to deploy your API change first before disabling AssertEdit? Will that result in reasonable behavior? [07:57:23] (03CR) 10MZMcBride: "Is "More information." really a sentence?" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94696 (owner: 10Legoktm) [07:58:00] iirc you had to remove the extension as the change went out (which was weird because of different mw versions running), but let me check if that was the case [07:58:10] (03CR) 10Siebrand: [C: 032] "Thanks, Bryan." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/105620 (owner: 10BryanDavis) [07:58:15] (03Merged) 10jenkins-bot: Add missing qqq for csrf page [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/105620 (owner: 10BryanDavis) [08:00:37] legoktm: Also, AssertEdit hijacks the UI edit as well as the API edit [08:00:50] that's....stupid [08:00:59] Arguably there's no use case for that but it should probably be mentioned that that's getting dropped [08:01:11] ok [08:02:10] So, from a quick glance [08:02:22] It looks like deploying your code without removing the AssertEdit extension will be a no-op [08:03:41] yeah, so if you set assert=false, which should be valid according to the AssertEdit auto docs, it throws an error [08:04:24] * legoktm rebases [08:04:50] Really? How? [08:05:04] Oh! [08:05:07] You put it in ApiMAIN [08:05:10] yeah [08:05:12] Rather than ApiEditPage [08:05:13] so it affects all modules [08:05:19] Riiiight [08:05:54] aww, matmarex's rebase tool can't handle it :( [08:06:09] What's his rebase tool? [08:07:01] https://github.com/MatmaRex/mediawikireleasenotes-driver you mean? [08:07:23] yeah [08:08:30] RoanKattouw: are you sure about it working for UI edits too? it only hooks into APIEditBeforeSave and AlternateEdit afais [08:08:52] AlternateEdit is for hijacking ?action=edit [08:08:57] !hook AlternateEdit [08:08:57] https://www.mediawiki.org/wiki/Manual:Hooks/AlternateEdit [08:09:11] ah [08:09:47] (03PS8) 10Legoktm: Merge AssertEdit extension into core [core] - 10https://gerrit.wikimedia.org/r/90263 [08:10:19] fwiw lego was this the extension you suggested to be merged into the core? [08:10:40] Reedy suggested it https://bugzilla.wikimedia.org/show_bug.cgi?id=27841 [08:11:24] (03PS9) 10Legoktm: Merge AssertEdit extension into core [core] - 10https://gerrit.wikimedia.org/r/90263 [08:12:47] (03CR) 10Legoktm: "PS8 was a rebase." [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [08:18:29] good night [08:18:42] 'night lego [08:21:59] (03CR) 10Siebrand: Link to [[mw:Help:Extension:MassMessage]] at top of the special page (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94696 (owner: 10Legoktm) [08:24:11] (03CR) 10MZMcBride: Link to [[mw:Help:Extension:MassMessage]] at top of the special page (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94696 (owner: 10Legoktm) [08:26:04] (03PS3) 10Amire80: Backport update plural rules to CLDR 24 [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105438 [08:36:49] (03PS4) 10Amire80: Backport update plural rules to CLDR 24 [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105438 [08:39:58] (03PS5) 10Amire80: Backport update plural rules to CLDR 24 [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105438 [08:52:02] (03CR) 10Siebrand: [C: 04-1] "L10n needs improvement per inline comment." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94696 (owner: 10Legoktm) [08:53:14] (03CR) 10Siebrand: "Add a getter and setter?" [core] - 10https://gerrit.wikimedia.org/r/95951 (owner: 10Siebrand) [08:56:06] (03CR) 10Siebrand: [C: 04-1] "Please address items mentioned in https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs-strict-HEAD/6076/console" [core] - 10https://gerrit.wikimedia.org/r/105430 (owner: 10Legoktm) [09:02:39] (03PS1) 10Physikerwelt: Support of presentation MathML by the query generator [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/105645 [09:05:02] (03PS1) 10Physikerwelt: new option setXMLValidate to skip xml validation [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/105646 [09:08:11] (03PS1) 10Catrope: Add VisualEditor support [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 [09:08:21] (03CR) 10jenkins-bot: [V: 04-1] Add VisualEditor support [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 (owner: 10Catrope) [09:09:05] (03PS2) 10Physikerwelt: new option setXMLValidate to skip xml validation [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/105646 [09:09:25] (03PS2) 10Catrope: Add VisualEditor support [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 [09:09:35] (03CR) 10jenkins-bot: [V: 04-1] Add VisualEditor support [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 (owner: 10Catrope) [09:09:37] (03CR) 10Physikerwelt: [V: 032] new option to skip xml validation: setXMLValidaton [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/105646 (owner: 10Physikerwelt) [09:09:47] (03CR) 10Physikerwelt: [C: 032] new option to skip xml validation: setXMLValidaton [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/105646 (owner: 10Physikerwelt) [09:11:11] (03PS3) 10Catrope: Add VisualEditor support [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 [09:12:30] (03CR) 10Siebrand: [C: 04-1] Fix logging (031 comment) [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/105444 (owner: 10Alex Monk) [09:13:01] (03CR) 10Physikerwelt: "I think this should go to the dev branch?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 (owner: 10Catrope) [09:15:33] (03CR) 10Siebrand: "You have just sent this for the following languages, too:" [core] - 10https://gerrit.wikimedia.org/r/105455 (owner: 10Dereckson) [09:15:56] (03CR) 10Nikerabbit: [C: 032 V: 032] Replace usage of deprecated Title::escapeLocalURL() [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/104351 (owner: 10Siebrand) [09:16:22] (03CR) 10Nikerabbit: [C: 032 V: 032] Replace usage of deprecated Title::escapeLocalURL() [extensions/ThemeDesigner] - 10https://gerrit.wikimedia.org/r/104353 (owner: 10Siebrand) [09:16:37] (03CR) 10Nikerabbit: [C: 032 V: 032] Replace usage of deprecated Title::escapeLocalURL() [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/104358 (owner: 10Siebrand) [09:17:29] RoanKattouw: ping [09:18:27] Pong? [09:18:48] You just moved visualEditorMath to Math? [09:20:23] Well pending those changes getting merged, yes [09:20:30] (03PS1) 10Siebrand: Revert "L10n: gender aliases for user namespaces in French" [core] - 10https://gerrit.wikimedia.org/r/105649 [09:20:37] (03CR) 10Siebrand: [C: 032] Revert "L10n: gender aliases for user namespaces in French" [core] - 10https://gerrit.wikimedia.org/r/105649 (owner: 10Siebrand) [09:20:40] I've been meaning to do this for a while, and I've had it sitting in an almost-done state on my computer for like a month [09:21:01] ok [09:21:19] (03CR) 10Siebrand: "I reverted this in https://gerrit.wikimedia.org/r/#/c/105649/" [core] - 10https://gerrit.wikimedia.org/r/105455 (owner: 10Dereckson) [09:21:29] hi andre__ [09:21:32] in pricipal that's ok, but I'm not sure if this should go to master or dev [09:21:46] since visual editor is not enabled [09:21:50] heya mayankmadan_! [09:22:49] andre__, i am almost done with the other(fix night mode kiwix task) and will submit it. will it increase my chances cause this was a really hard task and i have almost finished it before gci ended [09:23:23] (03CR) 10Siebrand: [C: 04-1] "Please add message documentation for newly added messages. See https://www.mediawiki.org/wiki/I18n#Message_documentation for details." [extensions/Math] - 10https://gerrit.wikimedia.org/r/105647 (owner: 10Catrope) [09:24:20] mayankmadan_, this is explained in http://www.google-melange.com/gci/document/show/gci_program/google/gci2013/help_page#comprehensive [09:25:00] RoanKattouw: Are there plans to allocate resources from WMF side to review the changes in the math extension [09:25:05] physikerwelt: It doesn't do anything if VE is not enabled [09:25:17] (03Merged) 10jenkins-bot: Revert "L10n: gender aliases for user namespaces in French" [core] - 10https://gerrit.wikimedia.org/r/105649 (owner: 10Siebrand) [09:25:19] andre__, so it will improve the chances? [09:25:23] There's an if ( class_exists( .. ) ) in there [09:25:47] physikerwelt: Re review for the Math extension, I don't know [09:26:10] mayankmadan_, this is explained in http://www.google-melange.com/gci/document/show/gci_program/google/gci2013/help_page#comprehensive [09:26:39] i get that it will increase my chances from that page [09:26:43] am i wrong [09:27:54] I cannot read for you. :) [09:28:16] okay :) [09:31:02] RoanKattouw: I think that's a problem. There are changes with caching and the database layout. I have doubts that this will cause problem if it's not reviewd by someone who is really experienced in that field [09:31:20] I agree that there should be review resources allocated [09:31:38] But I don [09:31:57] * Jasper_Deng remembers that gerrit isn't universally liked [09:31:59] 't manage people (other than VE developers in a limited sense), so I personally can't allocate people [09:32:58] who would be the person to talk to? [09:33:18] I'm not entirely sure [09:33:39] Review of changes in caching and DB layout should probably be done by Aaron or someone on that team [09:33:52] Which implies you might want to talk to RobLa [09:34:01] Who have you talked to this about, other than me and Gabriel? [09:34:07] Terry Chay might be able to help you along too [09:34:29] He's my boss and Gabriel's boss, but he doesn't really have any people in his team who would be well-suited to reviewing infrastructure changes like that [09:34:42] OTOH I hear there's nodejs code involved and we do have that expertise in our group [09:35:45] I had the impression that the new version of the math extension changes too much at once [09:36:08] therefore I broke it down to atomic changes... at least I started with that [09:37:27] That should be good [09:37:33] one task is to seperate the math extension from core [09:37:44] How is that not already separated? [09:38:47] In a first step I wanted to get rid of the caching issues, and resolve the security problems [09:39:15] in a second step I plan to introduce MathJax2.3 [09:39:28] and as a last step introduce the node changes [09:40:40] This change https://gerrit.wikimedia.org/r/#/c/104991/ is about the new cache keys [09:41:45] if I missed to assign a reviewer who knows about those aspects it would be very helpful if you could add her/him to the list [09:43:38] That looks like a good reviewer list [09:44:05] can't anyone review anything? [09:46:49] If this change would invalidate the caches of all pages this would be a problem to my mind [09:48:42] Yeah, that's the kind of thing people like Aaron and Platonides will be on the lookout for [09:50:30] (03PS2) 10Physikerwelt: Support of presentation MathML by the query generator [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/105645 [09:51:15] (03CR) 10Dzahn: [C: 032] Fix bugzilla template "Show other bugs" link to show only open bugs instead of all bugs [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/105197 (owner: 10Sn1per) [09:51:25] (03CR) 10Dzahn: [V: 032] Fix bugzilla template "Show other bugs" link to show only open bugs instead of all bugs [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/105197 (owner: 10Sn1per) [09:52:10] (03CR) 10Physikerwelt: [C: 032 V: 032] Support of presentation MathML by the query generator [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/105645 (owner: 10Physikerwelt) [09:52:49] (03PS1) 10Nemo bis: Set italiano (it) fallback for corsu (co) [core] - 10https://gerrit.wikimedia.org/r/105650 [09:57:15] (03CR) 10Dzahn: [C: 032 V: 032] Fix unsightly white bar in Bugzilla UI header [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/105223 (owner: 10Aklapper) [09:59:54] (03CR) 10Dzahn: [C: 032 V: 032] Add 'Browse projects' link to sidebar [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/104342 (owner: 10Merlijn van Deen) [10:01:17] (03CR) 10Dzahn: "deployed and works. We have a new "Browse projects" links in the main menu now." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/104342 (owner: 10Merlijn van Deen) [10:03:24] (03CR) 10Nikerabbit: [C: 032] Replace usage of deprecated Title::escapeLocalURL() [extensions/UnicodeConverter] - 10https://gerrit.wikimedia.org/r/104370 (owner: 10Siebrand) [10:03:25] (03CR) 10jenkins-bot: [V: 04-1] Replace usage of deprecated Title::escapeLocalURL() [extensions/UnicodeConverter] - 10https://gerrit.wikimedia.org/r/104370 (owner: 10Siebrand) [10:12:53] (03PS2) 10Nemo bis: Prepare for composer [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/105514 [10:16:11] (03CR) 10Siebrand: [C: 031] "Niklas is requesting a lightning deployment window." [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105438 (owner: 10Amire80) [10:27:30] (03CR) 10Dzahn: [C: 031] "so +1 from Chris because it's his own patch?" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/90546 (owner: 10Aklapper) [10:40:20] (03PS2) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/UnicodeConverter] - 10https://gerrit.wikimedia.org/r/104370 [10:41:13] (03PS3) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/UnicodeConverter] - 10https://gerrit.wikimedia.org/r/104370 [10:41:35] (03CR) 10Siebrand: [C: 032] "Per earlier +2 of Niklas, after rebase." [extensions/UnicodeConverter] - 10https://gerrit.wikimedia.org/r/104370 (owner: 10Siebrand) [10:41:38] (03Merged) 10jenkins-bot: Replace usage of deprecated Title::escapeLocalURL() [extensions/UnicodeConverter] - 10https://gerrit.wikimedia.org/r/104370 (owner: 10Siebrand) [10:45:03] (03PS2) 10Siebrand: Set italiano (it) fallback for corsu (co) [core] - 10https://gerrit.wikimedia.org/r/105650 (owner: 10Nemo bis) [10:46:21] andre__: i tried OpenID on Bugzilla (non-wmf, on the weekend) :P .. mixed success [10:47:07] https://github.com/jalcine/bugzilla-openid re: https://bugzilla.mozilla.org/show_bug.cgi?id=294608 [10:47:56] (03PS2) 10Hashar: (WIP) mediawiki-core-phpunit-* made concurrent (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102152 [10:49:15] (03PS4) 10Hashar: (WIP) mediawiki-core-phpunit-* made concurrent (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102152 [10:50:36] (03CR) 10Siebrand: [C: 032] "I was wondering why those translators are not mentioned in MessagesCo.php. Turns out the reason is not that they are not active, but that " [core] - 10https://gerrit.wikimedia.org/r/105650 (owner: 10Nemo bis) [10:51:27] (03PS5) 10Hashar: (WIP) mediawiki-core-phpunit-* made concurrent (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102152 [10:54:07] (03Merged) 10jenkins-bot: Set Italian (it) as fallback for Corsican (co) [core] - 10https://gerrit.wikimedia.org/r/105650 (owner: 10Nemo bis) [10:58:26] (03CR) 10Nemo bis: "Yes, I had noted that too. It's nice of them to translate on translatewiki.net even though we don't update co.wiki. :)" [core] - 10https://gerrit.wikimedia.org/r/105650 (owner: 10Nemo bis) [11:14:45] (03CR) 10Krinkle: [C: 032] document.selection is undefined in IE11 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/105517 (owner: 10Umherirrender) [11:14:51] (03Merged) 10jenkins-bot: document.selection is undefined in IE11 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/105517 (owner: 10Umherirrender) [11:18:00] (03CR) 10Krinkle: Escape messages in feedback.js (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [11:20:37] (03CR) 10Krinkle: Escape messages in feedback.js (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [11:24:37] (03PS1) 10Aude: Replace usage of deprecated SpecialPage::getTitle() function [core] - 10https://gerrit.wikimedia.org/r/105660 [11:27:27] (03CR) 10Siebrand: [C: 032] Replace usage of deprecated SpecialPage::getTitle() function [core] - 10https://gerrit.wikimedia.org/r/105660 (owner: 10Aude) [11:31:03] (03Merged) 10jenkins-bot: Replace usage of deprecated SpecialPage::getTitle() function [core] - 10https://gerrit.wikimedia.org/r/105660 (owner: 10Aude) [11:36:45] (03CR) 10Siebrand: [C: 032] Remove grant management sister-project warning [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/105411 (owner: 10CSteipp) [11:37:06] (03Merged) 10jenkins-bot: Remove grant management sister-project warning [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/105411 (owner: 10CSteipp) [11:40:33] (03PS1) 10Hashar: multigit: branch existence test now a function [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105665 [11:40:41] (03CR) 10Hashar: [C: 032] multigit: branch existence test now a function [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105665 (owner: 10Hashar) [11:40:44] (03Merged) 10jenkins-bot: multigit: branch existence test now a function [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105665 (owner: 10Hashar) [11:42:17] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx) [11:51:21] (03PS10) 10Siebrand: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [11:51:30] (03CR) 10Addshore: [C: 04-1] "Needs manual rebase" [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [11:52:47] (03PS2) 10Addshore: General fixes, style and comments / phpdoc [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/95768 [11:53:41] (03CR) 10jenkins-bot: [V: 04-1] Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [11:54:03] (03CR) 10Addshore: [C: 04-1] "needs manual rebase" [core] - 10https://gerrit.wikimedia.org/r/95772 (owner: 10Addshore) [11:54:25] (03CR) 10Addshore: [C: 04-1] "needs manual rebase" [core] - 10https://gerrit.wikimedia.org/r/95773 (owner: 10Addshore) [11:55:34] (03CR) 10Siebrand: "PS10 is a rebase to master/HEAD, resolving conflicts in User.php and release notes." [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [11:56:49] (03PS2) 10Addshore: Add zuul trigger for SideBarMenu [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/95654 [11:57:14] (03CR) 10Addshore: [C: 031] "Tests have now been merged into the repo so this should be ready to merge :)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/95654 (owner: 10Addshore) [11:58:59] (03CR) 10Siebrand: [C: 032] Localisation updates from https://translatewiki.net. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/105664 (owner: 10L10n-bot) [11:59:03] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/105664 (owner: 10L10n-bot) [12:07:59] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Persona] - 10https://gerrit.wikimedia.org/r/105242 (owner: 10Parent5446) [12:10:06] (03CR) 10Siebrand: [C: 04-1] "Please add mesasge documentation when adding new messages. See https://www.mediawiki.org/wiki/I18n#Message_documentation for details." [core] - 10https://gerrit.wikimedia.org/r/105234 (owner: 10Chad) [12:11:10] (03CR) 10Siebrand: [C: 04-2] "Blocking for accidental merge. This depends on a core change." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105235 (owner: 10Chad) [12:11:28] (03PS2) 10Matthias Mullie: Refactor title JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101903 [12:12:05] (03PS1) 10Dereckson: L10n: gender aliases for user namespaces in French [core] - 10https://gerrit.wikimedia.org/r/105669 [12:12:57] (03CR) 10Dereckson: "Follow-up: Icb8c787ebfa0e7dfd8289260225fef045fc1b0cb" [core] - 10https://gerrit.wikimedia.org/r/105649 (owner: 10Siebrand) [12:12:58] (03CR) 10Matthias Mullie: "Rebased, fixed Andrew's first feedback & removed "use strict" (so Jenkins approves) until code is actually strict" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101903 (owner: 10Matthias Mullie) [12:13:03] (03CR) 10Siebrand: [C: 04-1] "L10n reviewed." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/105233 (owner: 10CSteipp) [12:14:09] (03CR) 10Daniel Kinzler: [C: 031] "Seems good conceptually, but my Lua Foo is weak, so I haven't tested it. A quick howto would be nice." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man) [12:16:23] (03CR) 10Parent5446: "Umherirrender: With the config patch in gerrit and bug filed, can this be merged?" [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [12:16:26] (03PS2) 10Siebrand: L10n: gender aliases for user namespaces in French [core] - 10https://gerrit.wikimedia.org/r/105669 (owner: 10Dereckson) [12:16:50] (03PS3) 10Siebrand: Gender aliases for user namespaces in French and Cajun French [core] - 10https://gerrit.wikimedia.org/r/105669 (owner: 10Dereckson) [12:16:59] (03CR) 10Siebrand: [C: 032] "Thanks." [core] - 10https://gerrit.wikimedia.org/r/105669 (owner: 10Dereckson) [12:19:18] (03CR) 10Parent5446: "I'll try and see this week why the layered password test is failing." [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [12:21:08] (03Merged) 10jenkins-bot: Gender aliases for user namespaces in French and Cajun French [core] - 10https://gerrit.wikimedia.org/r/105669 (owner: 10Dereckson) [12:21:54] (03CR) 10Siebrand: Search links (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105202 (owner: 10Manybubbles) [12:25:49] (03CR) 10Siebrand: Notifications for course talk page edits (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/105147 (owner: 10AndyRussG) [12:41:31] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz) [12:42:24] (03PS2) 10Aarcos: Add basic UI tests to LicenseInput class. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103624 [12:42:26] (03PS6) 10Hashar: mediawiki-core-phpunit-* made concurrent [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102152 [12:43:12] (03CR) 10Hashar: [C: 032] "jobs deployed:" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102152 (owner: 10Hashar) [12:43:28] (03Merged) 10jenkins-bot: mediawiki-core-phpunit-* made concurrent [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102152 (owner: 10Hashar) [12:48:25] (03CR) 10Aarcos: "PTAL. Also, these tests have to be run on each commit, do you know how to do that? Thanx !" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103624 (owner: 10Aarcos) [12:58:11] (03PS1) 10Matthias Mullie: Refactor edit-post JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105674 [13:00:53] (03PS2) 10Matthias Mullie: Refactor edit-post JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105674 [13:08:59] (03CR) 10Siebrand: "Plural forms were recently updated to CLDR 24, and need to be updated." [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger) [13:23:30] (03CR) 10Bartosz Dziewoński: [C: 04-1] "OK, I guess ops will rain fire on you if this is not okay or something." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 (owner: 10Legoktm) [13:23:45] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Needs rebase." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97628 (owner: 10Legoktm) [13:24:26] (03CR) 10Bartosz Dziewoński: [C: 032] Don't parse custom footer [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97366 (owner: 10Legoktm) [13:25:41] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This shouldn't go into shared.css, but rather the styles for jquery.makeCollapsible themselves, I think." [core] - 10https://gerrit.wikimedia.org/r/105621 (owner: 10Gerrit Patch Uploader) [13:32:40] (03CR) 10Bartosz Dziewoński: "Funnily, my local git rebase this automatically. The file was moved to a different directory and apparently gerrit is too stupid to grok t" [core] - 10https://gerrit.wikimedia.org/r/95773 (owner: 10Addshore) [13:33:12] (03PS5) 10Bartosz Dziewoński: Cleanup HTMLCheckMatrixTest. [core] - 10https://gerrit.wikimedia.org/r/95773 (owner: 10Addshore) [13:33:56] (03CR) 10Bartosz Dziewoński: [C: 032] Cleanup HTMLCheckMatrixTest. [core] - 10https://gerrit.wikimedia.org/r/95773 (owner: 10Addshore) [13:36:03] hi ! while working with bug https://bugzilla.wikimedia.org/show_bug.cgi?id=59663 , I included a test for emptyness of wgDBprefix, and the error message shows up correctly and everything is fine, but once I give a test for checking emptyness of wgDBUser the error message shows up alright, but even after entering the correct details, the error message still presists, forbidding the installer to go further [13:37:14] (03Merged) 10jenkins-bot: Cleanup HTMLCheckMatrixTest. [core] - 10https://gerrit.wikimedia.org/r/95773 (owner: 10Addshore) [13:41:34] if you want to see the diff [13:41:35] http://pastebin.com/L8A0ENgc [13:52:09] (03PS1) 10Hashar: ext loader now in mediawiki/conf.d [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105680 [13:52:31] (03CR) 10Hashar: [C: 032] ext loader now in mediawiki/conf.d [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105680 (owner: 10Hashar) [13:52:35] (03Merged) 10jenkins-bot: ext loader now in mediawiki/conf.d [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105680 (owner: 10Hashar) [13:54:36] (03CR) 10Krinkle: Load ext.wikiLove.local from PHP (031 comment) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/100338 (owner: 10Legoktm) [13:55:06] (03PS4) 10Krinkle: Load ext.wikiLove.local from PHP [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/100338 (owner: 10Legoktm) [13:55:32] (03CR) 10Raimond Spekking: "i18n review" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/65299 (owner: 10Mwalker) [13:58:24] (03PS1) 10Raimond Spekking: Make message key optional [core] - 10https://gerrit.wikimedia.org/r/105681 [13:58:51] (03CR) 10Raimond Spekking: [C: 032] Make message key optional [core] - 10https://gerrit.wikimedia.org/r/105681 (owner: 10Raimond Spekking) [14:00:59] (03CR) 10Siebrand: [C: 032] Make message key optional [core] - 10https://gerrit.wikimedia.org/r/105681 (owner: 10Raimond Spekking) [14:02:19] (03Merged) 10jenkins-bot: Make message key optional [core] - 10https://gerrit.wikimedia.org/r/105681 (owner: 10Raimond Spekking) [14:06:40] (03CR) 10Fomafix: "Ok, but then the definition -moz-user-select: none; -webkit-user-select: none; -ms-user-select: none; user-select: none; has to be duplica" [core] - 10https://gerrit.wikimedia.org/r/105621 (owner: 10Gerrit Patch Uploader) [14:19:06] (03PS3) 10Matthias Mullie: Refactor title JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101903 [14:20:43] (03PS1) 10Hashar: support mediawiki/core under $WORKSPACE/src/mediawiki/core [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105683 [14:21:02] (03CR) 10Hashar: [C: 04-2] "wip" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105683 (owner: 10Hashar) [14:27:29] (03PS3) 10Matthias Mullie: Refactor edit-post JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105674 [14:39:22] (03CR) 10Manybubbles: Search links (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105202 (owner: 10Manybubbles) [14:39:34] (03PS2) 10Manybubbles: Search links [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105202 [14:40:57] damn... [14:41:11] http://tjvantoll.com/2012/07/19/dom-element-references-as-global-variables/ [14:41:14] http://dertompson.com/2013/08/07/named-access-on-the-window-object-in-safari/ [14:41:19] (03CR) 10Manybubbles: Allow SearchResults to specify that they matched file content (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105234 (owner: 10Chad) [14:41:42] that makes you reconsider every line of JS code you ever wrote... [14:44:17] thedj: Be sure to verify that for yourself, last I checked it was only old Presto-based Opera and IE < 11 that do that, and they exposed them as window properties only that are not affected by local scope. [14:44:33] nope safari does it for me [14:45:09] thedj: Besides, even if a browser does do that, it's still a non-issue if you're not using global variables [14:45:20] and if you use global variables, you lose all rights to be taken seriously anyway :P [14:45:32] (function () { var bar; console.log(bar); }()); [14:45:37] works everywhere I'm pretty sure [14:45:44] undefined, not
[14:46:26] so the only variable you need to be sure of is your globals, which you need to be certain about anyway because of the way IE exposes globals. [14:46:39] Krinkle: yup, that works [14:46:42] (03CR) 10Siebrand: Allow SearchResults to specify that they matched file content (032 comments) [core] - 10https://gerrit.wikimedia.org/r/105234 (owner: 10Chad) [14:46:43] But in all cases, JS land can override it, so window.mw = {}, is still safe and later mw references as well. [14:46:46] still, freaking scary. [14:46:54] yeah, sure thing :) [14:47:08] and i just ran into it with ace, where they tried to define a property on window that just happened to match an input name field [14:47:22] throws a typeerror in your face. [14:48:08] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105202 (owner: 10Manybubbles) [14:48:16] ff and chrome do this nicer. they don't have them as 'regular' properties. [14:48:27] (03CR) 10Dereckson: "I'm not sure this is possible." [core] - 10https://gerrit.wikimedia.org/r/105621 (owner: 10Gerrit Patch Uploader) [14:49:18] they don't even show up using getOwnPropertyDescriptor in those browsers. [14:50:22] (03CR) 10Manybubbles: Allow SearchResults to specify that they matched file content (032 comments) [core] - 10https://gerrit.wikimedia.org/r/105234 (owner: 10Chad) [14:51:03] (03PS2) 10Hashar: support mediawiki/core under $WORKSPACE/src/mediawiki/core [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105683 [14:51:18] (03CR) 10Hashar: [C: 032] support mediawiki/core under $WORKSPACE/src/mediawiki/core [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105683 (owner: 10Hashar) [14:51:21] (03Merged) 10jenkins-bot: support mediawiki/core under $WORKSPACE/src/mediawiki/core [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105683 (owner: 10Hashar) [14:52:07] (03CR) 10Krinkle: [C: 04-1] "local should have a dependency on startup, otherwise code in MediaWiki:WikiLove.js will break as $.wikiLove won't exist yet." [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/100338 (owner: 10Legoktm) [14:52:09] Krinkle: http://jsfiddle.net/TheDJ/abfFx/1/ [14:52:12] blegh [14:52:13] (03CR) 10Siebrand: Allow SearchResults to specify that they matched file content (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105234 (owner: 10Chad) [14:52:39] * hashar is breaking jenkins, sorry [14:53:36] (03CR) 10Krinkle: "Getting rid of this extra request is fine, and that should work now that the bug associated with that is fixed, but it still needs to be e" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/100338 (owner: 10Legoktm) [14:54:12] (03CR) 10Bartosz Dziewoński: "Fomafix, just submit as if you were submitting a new patch, but keep the "Change-Id: I4ee597aec10bfee4104efde92a9f6b03d1825408" line in th" [core] - 10https://gerrit.wikimedia.org/r/105621 (owner: 10Gerrit Patch Uploader) [14:54:33] thedj: ? [14:55:08] Krinkle: writable false, configurable false... [14:55:34] ergo you get a 'randomly' defined property on Safari that might break your code [14:55:51] No, I don't think so [14:55:56] (03PS9) 10Physikerwelt: Add reference to the current user to the PageRenderingHash hook [core] - 10https://gerrit.wikimedia.org/r/105213 [14:55:59] They are in a different scope [14:56:07] if you define a js-land global variable it will shadow it [14:56:30] yeah, but if you mess with properties than you are screwed. [14:56:58] https://github.com/ajaxorg/ace/issues/1741 [14:57:08] (03CR) 10jenkins-bot: [V: 04-1] Add reference to the current user to the PageRenderingHash hook [core] - 10https://gerrit.wikimedia.org/r/105213 (owner: 10Physikerwelt) [14:57:33] Hm... [14:57:35] that's odd indeed [14:57:36] ok, it's stupid what he does there, but you can see why you wouldn't expect a breakage on Safari [14:57:52] It's unusual to configure global properties though [14:58:15] you should only have a handful of globals, which for linking purposes only need to be defined as a plain object, anything else can be nested below that. [14:58:45] (03PS1) 10Hashar: mw-set-env: typo in MW_INSTALL_PATH [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105688 [14:58:45] Surprising, but not affecting us I suppose since one should alreayd not do that for various other reasons. [14:58:48] (03CR) 10Dereckson: Add in preliminary MS SQL support (032 comments) [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz) [14:58:50] I think this is handled better in IE. [14:59:02] (03CR) 10Hashar: [C: 032] mw-set-env: typo in MW_INSTALL_PATH [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105688 (owner: 10Hashar) [14:59:06] (03Merged) 10jenkins-bot: mw-set-env: typo in MW_INSTALL_PATH [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105688 (owner: 10Hashar) [14:59:36] (03CR) 10Krinkle: [C: 031] Send cache purges for action=raw after editing user css/js [core] - 10https://gerrit.wikimedia.org/r/95095 (owner: 10Brian Wolff) [15:00:28] Krinkle: i filed a webkit report to at least make those properties configurable and preferably not 'real' properties at all as Chrome and Firefox have it. [15:02:20] yeah [15:02:33] (03CR) 10Hashar: "caused by me while hacking jenkins." [core] - 10https://gerrit.wikimedia.org/r/105213 (owner: 10Physikerwelt) [15:02:41] (03PS10) 10Hashar: Add reference to the current user to the PageRenderingHash hook [core] - 10https://gerrit.wikimedia.org/r/105213 (owner: 10Physikerwelt) [15:02:42] thedj: I guess the reason WebKit did it this way is to have them be unenumerable [15:02:49] though that can be done without making them unconfigurable [15:03:11] exactly [15:05:47] (03PS1) 10Gerrit Patch Uploader: Exclude toggle button of collapsible elements from user selection [core] - 10https://gerrit.wikimedia.org/r/105689 [15:05:51] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/105689 (owner: 10Gerrit Patch Uploader) [15:06:20] (03CR) 10Fomafix: "I tried to push a second patch set after changing with amend, but it generates the new change id 105689." [core] - 10https://gerrit.wikimedia.org/r/105621 (owner: 10Gerrit Patch Uploader) [15:08:05] (03PS1) 10Manybubbles: Update cirrus to master [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105690 [15:09:49] (03CR) 10AndyRussG: Notifications for course talk page edits (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/105147 (owner: 10AndyRussG) [15:12:21] (03PS1) 10Manybubbles: Update Cirrus to master [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/105691 [15:13:58] (03CR) 10MarkAHershberger: "I'd be happy with just a getter." [core] - 10https://gerrit.wikimedia.org/r/95951 (owner: 10Siebrand) [15:16:31] (03PS12) 10Siebrand: Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [15:21:42] (03CR) 10MarkAHershberger: "I'll test this tonight, but, assuming it works, is there a reason not to include this in 1.22.1?" [core] - 10https://gerrit.wikimedia.org/r/105092 (owner: 10Jeroen De Dauw) [15:22:42] (03CR) 10Aarcos: [C: 031] "I think this is ready to be merged with HEAD, don't have the powers though, Mark?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103388 (owner: 10Gergő Tisza) [15:23:45] (03PS13) 10Siebrand: Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [15:23:54] (03CR) 10Siebrand: "@mark PS13 is untested. Does it do what you need it to do?" [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [15:24:13] (03CR) 10Skizzerz: Add in preliminary MS SQL support (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz) [15:28:56] ohhh why are we using PHP [15:30:28] hashar: Ask Tim and Brion when in SF [15:30:29] ;) [15:30:42] it's magnus's fault [15:30:49] he volunteered to rewrite the perl wiki in php [15:30:54] and nobody said no :) [15:33:10] php -r 'die("Do NOT proceed any further\n");' [15:33:11] [ $? -eq 0 ] && echo "Ok proceeding" [15:33:19] yields: [15:33:20] Do NOT proceed any further [15:33:21] Ok proceeding [15:33:24] cause stupid die() exists 0 [15:33:25] \O/ [15:33:30] (03CR) 10Krinkle: "* resources/mediawiki.language/mediawiki.language.init.js:42: Unknown type mixed" [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [15:33:38] * hashar blames magnus [15:34:21] I need to write a php wtf presentation [15:34:30] got 35 worthwhile code snippets so far [15:34:40] oh we can blame rasmus for the weirdnesses in php itself :) [15:36:05] (03PS9) 10Krinkle: JSDuck-ify /resources/mediawiki.language/* [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [15:38:43] hashar: reply to that support request from #mediawiki, somebody was all concerned about "WHY does the wiki try to access /usr/bin/php ???" wasn't sure if that was valid:) [15:38:56] (03CR) 10Siebrand: "Pointed out code sniffer errors and warnings introduced in this patch set." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [15:39:05] (03CR) 10Siebrand: [C: 04-1] Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [15:39:20] die( 1 ); // silent death [15:39:29] should be replaced by // make sure nobody ever figure out what went wrong [15:39:50] hmmm wouldn't die( 0 ); be even more silent? [15:40:29] hashar: // if anyone asks, nothing went wrong [15:42:21] exec("echo dying | wall"); [15:42:22] laters [15:45:11] Does anyone remember how to use ~~~ as default in an ? [15:46:18] ~~~ ? [15:46:21] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/105147 (owner: 10AndyRussG) [15:46:31] (03CR) 10Aarcos: [C: 04-1] "I still see most of the logic duplicated, you don't write software like that, it is the source of errors. Not sure if I am explaining myse" (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [15:46:52] (03PS3) 10PleaseStand: Mechanism for renaming/aliasing classes [core] - 10https://gerrit.wikimedia.org/r/96945 [15:47:03] Nemo_bis: I love you. [15:47:07] (03PS4) 10PleaseStand: Mechanism for renaming/aliasing classes [core] - 10https://gerrit.wikimedia.org/r/96945 [15:47:08] Thank you! [15:47:29] you're reciprocated :D [15:47:32] For some reason I thought the noinclude trick wouldn't work with inputbox [15:48:20] (03CR) 10Daniel Kinzler: assertValidHtml for checking html in test cases. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98853 (owner: 10Daniel Kinzler) [15:48:27] https://www.mediawiki.org/wiki/Talk:Project_management_tools/Review \o/ [15:50:30] andre__: around? [15:50:34] ^ [15:50:38] guillom, yay. Thanks! [15:51:24] andre__: time to remove the draft banner? [15:51:53] guillom: text looks good! [15:52:32] alright [15:53:45] (03CR) 10MarkTraceur: [C: 032] "There are a bunch of style issues in the test file, but I don't really feel like being picky about that right now, because I'm going to ha" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103388 (owner: 10Gergő Tisza) [15:53:51] (03Merged) 10jenkins-bot: Handle multiple Flickr uploads with identical title [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103388 (owner: 10Gergő Tisza) [15:54:58] (03CR) 10Reedy: [C: 032] Add reference to the current user to the PageRenderingHash hook [core] - 10https://gerrit.wikimedia.org/r/105213 (owner: 10Physikerwelt) [15:57:56] andre__: I've rewritten it a bit. Can you refresh and take a look? [15:58:08] (03Merged) 10jenkins-bot: Add reference to the current user to the PageRenderingHash hook [core] - 10https://gerrit.wikimedia.org/r/105213 (owner: 10Physikerwelt) [15:59:39] (03PS1) 10Gilles: Solves visibility issue on the progress bar [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105694 [16:02:15] (03CR) 10Gilles: "I didn't know the correct format to link to the bug from the commit message, here's the bug this commit tries to fix: https://bugzilla.wik" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105694 (owner: 10Gilles) [16:02:19] guillom, I fixed a typo. Looks great, thanks! [16:02:28] Great. [16:04:18] (03CR) 10Krinkle: [C: 04-1] "Per https://bugzilla.wikimedia.org/show_bug.cgi?id=38365#c7" [core] - 10https://gerrit.wikimedia.org/r/105103 (owner: 10Jackmcbarn) [16:12:12] (03PS2) 10Daniel Kinzler: assertValidHtml for checking html in test cases. [core] - 10https://gerrit.wikimedia.org/r/98853 [16:12:26] hashar: --^ [16:17:26] (03CR) 10Hoo man: [C: 031] "Looks good at first glance" [core] - 10https://gerrit.wikimedia.org/r/98853 (owner: 10Daniel Kinzler) [16:20:47] (03CR) 10Jackmcbarn: [C: 04-1] "You should make a new message that's used when there's a diff. Just injecting the diff link into the comments field messes up internationa" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105637 (owner: 10Nullzero) [16:21:40] greg-g: Where's that git repo repair work? I can't even remember the guys name [16:21:55] Reedy: joey hess [16:22:14] ty [16:25:34] (03CR) 10Jackmcbarn: "Replied there." [core] - 10https://gerrit.wikimedia.org/r/105103 (owner: 10Jackmcbarn) [16:26:10] (03CR) 10Krinkle: Load scripts and styles via ResourceLoader (033 comments) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 (owner: 10Legoktm) [16:26:52] Reedy: http://git-annex.branchable.com/devblog/day_60__damage_driven_development/ and http://git-annex.branchable.com/devblog/day_61__damage_driven_development__II/ [16:27:11] I found http://hackage.haskell.org/package/git-repair [16:33:55] (03CR) 10UltrasonicNXT: [C: 032 V: 032] The kick button was being shown to non-mods [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/105516 (owner: 10UltrasonicNXT) [16:35:26] (03CR) 10Qgil: "Sorry for adding so many reviewers. This is the very last Google Code-in related patch and we need to know asap whether the code is at lea" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx) [16:36:21] ^^^^ your help reviewing this patch is welcome. [16:46:14] (03PS1) 10Matthias Mullie: Refactor post-reply JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105699 [16:47:26] DanielK_WMDE: will look at it tomorrow [16:47:27] (03PS1) 10Manybubbles: Clean up tests a bit [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105700 [16:47:51] (03PS2) 10Matthias Mullie: Refactor post-reply JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105699 [16:48:38] (03PS1) 10Matthias Mullie: Fix typo: convetedContent -> convertedContent [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105701 [16:50:34] (03PS1) 10Siebrand: Update docs for CLDRPluralRuleEvaluator.php [core] - 10https://gerrit.wikimedia.org/r/105702 [16:52:18] (03PS1) 10Matthias Mullie: Get rid of unused var causing E_NOTICE [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105704 [16:54:14] (03CR) 10Krinkle: [C: 031] JSDuck-ify /resources/mediawiki.language/* [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [16:58:27] (03PS1) 10Manybubbles: Don't suggest if the search tem is a known title [core] - 10https://gerrit.wikimedia.org/r/105705 [16:58:47] (03CR) 10Reedy: [C: 032] Deoptimize SVG versions of enhanced recent changes collapse/show arrows [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105477 (owner: 10Legoktm) [16:59:02] (03CR) 10Manybubbles: "Chad, I'm not sure who else to add to this review so please add people you think make sense." [core] - 10https://gerrit.wikimedia.org/r/105705 (owner: 10Manybubbles) [16:59:11] (03CR) 10Matthias Mullie: [C: 032] No longer pass $permissionsUser in Templating [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102491 (owner: 10EBernhardson) [16:59:55] (03Merged) 10jenkins-bot: No longer pass $permissionsUser in Templating [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102491 (owner: 10EBernhardson) [17:00:31] (03CR) 10Matthias Mullie: [C: 032] No longer pass $user arround to action message callbacks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105246 (owner: 10EBernhardson) [17:00:33] (03CR) 10jenkins-bot: [V: 04-1] No longer pass $user arround to action message callbacks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105246 (owner: 10EBernhardson) [17:01:16] (03CR) 10Chad: [C: 032] Update Cirrus to master [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/105691 (owner: 10Manybubbles) [17:01:17] (03CR) 10Chad: [C: 032] Update cirrus to master [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105690 (owner: 10Manybubbles) [17:01:46] (03CR) 10Chad: [C: 032] Clean up tests a bit [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105700 (owner: 10Manybubbles) [17:02:00] (03Merged) 10jenkins-bot: Clean up tests a bit [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105700 (owner: 10Manybubbles) [17:02:25] (03Merged) 10jenkins-bot: Deoptimize SVG versions of enhanced recent changes collapse/show arrows [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105477 (owner: 10Legoktm) [17:02:34] (03CR) 10jenkins-bot: [V: 04-1] Don't suggest if the search tem is a known title [core] - 10https://gerrit.wikimedia.org/r/105705 (owner: 10Manybubbles) [17:02:54] (03PS2) 10Matthias Mullie: No longer pass $user arround to action message callbacks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105246 (owner: 10EBernhardson) [17:03:01] (03CR) 10Matthias Mullie: [C: 032] No longer pass $user arround to action message callbacks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105246 (owner: 10EBernhardson) [17:03:08] (03Merged) 10jenkins-bot: No longer pass $user arround to action message callbacks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105246 (owner: 10EBernhardson) [17:04:24] (03Merged) 10jenkins-bot: Update Cirrus to master [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/105691 (owner: 10Manybubbles) [17:04:48] (03Merged) 10jenkins-bot: Update cirrus to master [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105690 (owner: 10Manybubbles) [17:06:44] (03CR) 10Bartosz Dziewoński: "It looks reasonable at a glance, but this is quite a lot of code in areas I have never touched." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx) [17:09:46] (03CR) 10Chad: "Don't know. This came up as a result of a discussion on IRC about deprecated code and it was suggested to do the same here like was done w" [extensions/Narayam] - 10https://gerrit.wikimedia.org/r/105002 (owner: 10Chad) [17:11:21] (03CR) 10Mattflaschen: "See inline." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender) [17:12:39] (03CR) 10Krinkle: mediawiki.inspect: add method for grepping loaded modules (032 comments) [core] - 10https://gerrit.wikimedia.org/r/97856 (owner: 10Ori.livneh) [17:13:08] (03CR) 10Chad: "I don't think this repo has jenkins. I think it'll need a manual V+2 + Submit :)" [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/105201 (owner: 10Chad) [17:13:31] (03CR) 10Chad: "Don't think this repo has Jenkins, will need a manual V+2 + Submit" [extensions/UserFunctions] - 10https://gerrit.wikimedia.org/r/104995 (owner: 10Chad) [17:13:41] (03PS1) 10Manybubbles: import! [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105707 [17:14:06] (03CR) 10Chad: [C: 032] import! [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105707 (owner: 10Manybubbles) [17:14:11] (03Merged) 10jenkins-bot: import! [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105707 (owner: 10Manybubbles) [17:14:29] (03CR) 10Krinkle: "Why would it be a problem if it could find css files? Those shouldn't contain /** blocks (headers are /*!, inline /* )" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen) [17:14:44] (03CR) 10Krinkle: "Anyway, no worries either way. Just seems a bit overkill." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen) [17:15:15] (03PS1) 10Manybubbles: Update cirrus to master again [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/105708 [17:15:27] (03CR) 10Manybubbles: [C: 032] Update cirrus to master again [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/105708 (owner: 10Manybubbles) [17:16:39] (03PS1) 10BryanDavis: Fix log level settings [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/105709 [17:16:51] (03CR) 10Chad: [V: 032] Update cirrus to master again [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/105708 (owner: 10Manybubbles) [17:21:54] (03PS1) 10Manybubbles: Update cirrus to master again [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105710 [17:22:29] (03CR) 10Manybubbles: [C: 032] "This one is less important than the wmf8 one because I'm not seeing errors for it. We should still sync during this window though." [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105710 (owner: 10Manybubbles) [17:22:41] (03CR) 10Siebrand: [V: 032] "Ugh." [extensions/UserFunctions] - 10https://gerrit.wikimedia.org/r/104995 (owner: 10Chad) [17:23:09] (03CR) 10Siebrand: [V: 032] "Ugh!" [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/105201 (owner: 10Chad) [17:26:04] (03Merged) 10jenkins-bot: Update cirrus to master again [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105710 (owner: 10Manybubbles) [17:26:07] qgil_, hi [17:26:21] hi mayankmadan_ [17:26:25] (03CR) 10Matthias Mullie: [C: 04-1] "I disagree with setting it to 85%, which is an arbitrary number; I'd prefer either limited size, or 100%. Replied in mailing list - I'll h" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105390 (owner: 10EBernhardson) [17:28:39] (03CR) 10Umherirrender: "No objections from my side" [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [17:30:04] qgil_, https://gerrit.wikimedia.org/r/103596 the task related to this patch was marked completed, but aarcos pointed out there were some issues with duplication [17:30:37] i solved them yesterday, but he pointed out that there are still some left, what if i solve them tomorrow, will it be ok? [17:32:16] mayankmadan_, sorry, in a meeting with andre__ [17:32:32] okay [17:32:36] please say its ok [17:34:58] (03CR) 10Chad: [C: 032] Fix log level settings (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/105709 (owner: 10BryanDavis) [17:35:01] (03Merged) 10jenkins-bot: Fix log level settings [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/105709 (owner: 10BryanDavis) [17:38:29] yurik u der? wanted to discuss about codecademy [17:41:38] (03CR) 10MarkTraceur: [C: 04-1] "Wow, that seems like a really obvious bug and now I'm curious about the reason. Let me look into how this works now. Small issue with the " (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105694 (owner: 10Gilles) [17:47:02] (03CR) 10EBernhardson: [C: 032] Fix typo: convetedContent -> convertedContent [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105701 (owner: 10Matthias Mullie) [17:47:05] (03Merged) 10jenkins-bot: Fix typo: convetedContent -> convertedContent [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105701 (owner: 10Matthias Mullie) [17:47:28] (03CR) 10EBernhardson: [C: 032] Get rid of unused var causing E_NOTICE [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105704 (owner: 10Matthias Mullie) [17:47:34] (03Merged) 10jenkins-bot: Get rid of unused var causing E_NOTICE [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105704 (owner: 10Matthias Mullie) [17:47:56] (03PS2) 10Jdlrobson: Only set the max width on namespace 0 pages in view mode [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105408 [17:47:57] (03PS1) 10Manybubbles: Import Title for OtherIndexJob [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105712 [17:48:19] (03CR) 10Jdlrobson: "Good thinking Matt! Thanks. Amended and it should now be +2able" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105408 (owner: 10Jdlrobson) [17:48:55] (03CR) 10Chad: [C: 032] Import Title for OtherIndexJob [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105712 (owner: 10Manybubbles) [17:49:01] (03Merged) 10jenkins-bot: Import Title for OtherIndexJob [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105712 (owner: 10Manybubbles) [17:49:11] (03CR) 10Mattflaschen: [C: 04-1] "The QUnit test works. However, the edit intros do not; see inline." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [17:50:11] (03PS1) 10Manybubbles: One more cirrus to master update [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105713 [17:50:23] (03CR) 10Manybubbles: [C: 032] One more cirrus to master update [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105713 (owner: 10Manybubbles) [17:51:29] (03CR) 10Chad: [C: 032] One more cirrus to master update [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105713 (owner: 10Manybubbles) [17:52:52] (03CR) 10Gilles: "Is the issue with the commit message that I need to add the bug reference? Or do you mean that I should also get rid of my remark about th" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105694 (owner: 10Gilles) [17:53:50] (03PS1) 10Manybubbles: One more update to cirrussearch's master [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/105714 [17:54:21] (03CR) 10Manybubbles: [C: 032] One more update to cirrussearch's master [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/105714 (owner: 10Manybubbles) [17:54:44] (03Merged) 10jenkins-bot: One more cirrus to master update [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105713 (owner: 10Manybubbles) [17:54:50] (03CR) 10MarkTraceur: "The body of the message should be split into multiple lines." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105694 (owner: 10Gilles) [17:55:29] (03PS3) 10Reedy: Update CentralAuth recent change notification code [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92461 [17:55:55] mayankmadan_, no problem, your GCI duties are over and now you are a regular contributor. :) [17:56:17] qgil_, ok, but would it effect the final evaluation? [17:56:21] mayankmadan_, meaning that an open change in Gerrit is an open change in Gerrit [17:56:38] mayankmadan_, as said many times, the evaluation doesn't depend on a task up or down [17:57:25] (03CR) 10jenkins-bot: [V: 04-1] One more update to cirrussearch's master [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/105714 (owner: 10Manybubbles) [17:57:57] qgil_, yes, but if i solve the duplication problems tomorrow, will it lower my chances? because the change was not merged? [17:58:07] ^d: do you think that last jenkins job just needs a recheck? [17:58:50] (03CR) 10Manybubbles: "recheck" [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/105714 (owner: 10Manybubbles) [17:59:00] (03CR) 10Chad: [V: 032] One more update to cirrussearch's master [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/105714 (owner: 10Manybubbles) [17:59:06] <^d> Yes but I'm not waiting. [17:59:12] mayankmadan_, as said many times, the evaluation doesn't depend on a task up or down [17:59:20] (03CR) 10Siebrand: Update CentralAuth recent change notification code (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92461 (owner: 10Reedy) [17:59:24] oh [17:59:32] mayankmadan_, how many times do I need to repeat the same. :) Just relax, and enjoy contributing to Wikimedia :) [18:00:06] qgil_, :) i just want the grand prize so bad [18:00:45] (03Abandoned) 10Reedy: Add sleep call to HTMLCacheUpdateJob update loop [core] - 10https://gerrit.wikimedia.org/r/91858 (owner: 10Reedy) [18:01:03] (03CR) 10Anomie: "The only holdup for merging is that someone (Reedy?) needs to coordinate undeploying AssertEdit concurrently with the deployment of this p" [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [18:03:19] (03CR) 10Anomie: "I don't think Ifad0cad2 is sufficient, as that doesn't take into account the fact that we will have some wikis with this and some still wi" [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [18:05:08] (03CR) 10MaxSem: [C: 032] i18n: Native digits on '#renderingProgress' [extensions/Collection] - 10https://gerrit.wikimedia.org/r/104767 (owner: 10Reza) [18:05:13] (03Merged) 10jenkins-bot: i18n: Native digits on '#renderingProgress' [extensions/Collection] - 10https://gerrit.wikimedia.org/r/104767 (owner: 10Reza) [18:07:08] (03PS1) 10Chad: Add maintenance script to autoloader [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105717 [18:07:12] (03PS2) 10Reedy: Retry commands if failed [tools/release] - 10https://gerrit.wikimedia.org/r/104970 [18:07:33] (03PS2) 10Chad: Add maintenance script to autoloader [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105717 [18:11:04] (03PS3) 10Reedy: Retry commands if failed [tools/release] - 10https://gerrit.wikimedia.org/r/104970 [18:12:55] (03PS4) 10Reedy: Retry commands if failed [tools/release] - 10https://gerrit.wikimedia.org/r/104970 [18:22:43] mayankmadan_, all GCI student in your situation want the prize so bad. [18:22:52] :) [18:23:04] i was just confirming [18:23:55] mayankmadan_, a post GCI advice: you need to understand what is useful to achieve your goals. Sometimes being pushy is helpful, sometimes it isn't. [18:24:20] okay, will keep that in mind [18:25:05] mayankmadan_, I really mean this: just relax and enjoy squashing bugs for the pleasure of contributing good work. [18:25:26] qgil_, it does feel nice to be a part of something [18:25:40] superm401: https://gerrit.wikimedia.org/r/105408 can you merge plz? :) [18:25:44] mayankmadan_, exactly, well said. [18:25:49] superm401: trying to setup a lightning deploy for later today [18:28:58] (03PS2) 10CSteipp: Add tooltip by disabled Basic rights checkbox [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/105233 [18:29:10] (03CR) 10Legoktm: [C: 031] General fixes, style and comments / phpdoc (031 comment) [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/95768 (owner: 10Addshore) [18:29:12] (03CR) 10Gergő Tisza: "Some good advice about commit message formatting: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105694 (owner: 10Gilles) [18:30:12] (03CR) 10MarkTraceur: "Closer to home: https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105694 (owner: 10Gilles) [18:30:21] (03CR) 10CSteipp: "PS2 updates the wording that Dan suggested. Hopefully no one asks why those ones are required but not other ones.. :)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/105233 (owner: 10CSteipp) [18:33:51] (03CR) 10CSteipp: [C: 031] Remove cases of double escaping [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/105448 (owner: 10Grunny) [18:43:50] (03PS8) 10Siebrand: Update documentation for database related classes [core] - 10https://gerrit.wikimedia.org/r/103890 [18:43:51] (03PS1) 10Siebrand: Ensure variables in database classes are defined, used and correctly cased [core] - 10https://gerrit.wikimedia.org/r/105722 [18:43:52] (03PS1) 10Siebrand: Rename $desired_schema to $desiredSchema [core] - 10https://gerrit.wikimedia.org/r/105723 [18:43:53] (03PS1) 10Siebrand: Make tableNamesWithUseIndexOrJOIN() and makeUpdateOptions() protected [core] - 10https://gerrit.wikimedia.org/r/105724 [18:43:54] (03PS1) 10Siebrand: Return correct values and types [core] - 10https://gerrit.wikimedia.org/r/105725 [18:43:55] (03PS1) 10Siebrand: $serverIndex can be an array, so print_r() it [core] - 10https://gerrit.wikimedia.org/r/105726 [18:43:56] (03PS1) 10Siebrand: Specify DBMasterPos::getMasterPos() [core] - 10https://gerrit.wikimedia.org/r/105727 [18:43:57] (03PS1) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/105728 [18:45:18] (03PS10) 10Reedy: Merge AssertEdit extension into core [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [18:45:33] (03CR) 10Reedy: [C: 032] "Will go out in 1.23wmf10 on Thursday" [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [18:46:29] (03PS9) 10Siebrand: Update documentation for database related classes [core] - 10https://gerrit.wikimedia.org/r/103890 [18:46:29] (03CR) 10jenkins-bot: [V: 04-1] Update documentation for database related classes [core] - 10https://gerrit.wikimedia.org/r/103890 (owner: 10Siebrand) [18:46:50] (03PS2) 10Siebrand: Ensure variables in database classes are defined, used and correctly cased [core] - 10https://gerrit.wikimedia.org/r/105722 [18:47:01] (03CR) 10jenkins-bot: [V: 04-1] Ensure variables in database classes are defined, used and correctly cased [core] - 10https://gerrit.wikimedia.org/r/105722 (owner: 10Siebrand) [18:47:04] (03CR) 10jenkins-bot: [V: 04-1] Rename $desired_schema to $desiredSchema [core] - 10https://gerrit.wikimedia.org/r/105723 (owner: 10Siebrand) [18:47:26] (03PS2) 10Siebrand: Rename $desired_schema to $desiredSchema [core] - 10https://gerrit.wikimedia.org/r/105723 [18:47:44] (03PS2) 10Siebrand: Make tableNamesWithUseIndexOrJOIN() and makeUpdateOptions() protected [core] - 10https://gerrit.wikimedia.org/r/105724 [18:47:52] (03CR) 10jenkins-bot: [V: 04-1] Make tableNamesWithUseIndexOrJOIN() and makeUpdateOptions() protected [core] - 10https://gerrit.wikimedia.org/r/105724 (owner: 10Siebrand) [18:48:00] (03PS2) 10Siebrand: Return correct values and types [core] - 10https://gerrit.wikimedia.org/r/105725 [18:48:14] (03PS2) 10Siebrand: $serverIndex can be an array, so print_r() it [core] - 10https://gerrit.wikimedia.org/r/105726 [18:48:38] (03PS2) 10Siebrand: Specify DBMasterPos::getMasterPos() [core] - 10https://gerrit.wikimedia.org/r/105727 [18:48:41] (03CR) 10jenkins-bot: [V: 04-1] Return correct values and types [core] - 10https://gerrit.wikimedia.org/r/105725 (owner: 10Siebrand) [18:49:30] (03CR) 10jenkins-bot: [V: 04-1] $serverIndex can be an array, so print_r() it [core] - 10https://gerrit.wikimedia.org/r/105726 (owner: 10Siebrand) [18:50:01] (03PS2) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/105728 [18:55:34] (03Merged) 10jenkins-bot: Merge AssertEdit extension into core [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [18:55:58] (03CR) 10Anomie: [C: 032] Add CASCADINGSOURCES parser function [core] - 10https://gerrit.wikimedia.org/r/104999 (owner: 10Jackmcbarn) [18:56:23] (03CR) 10Deskana: [C: 031] "Thanks Chris!" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/105233 (owner: 10CSteipp) [19:01:04] (03CR) 10Siebrand: [C: 04-1] "This needs some changes that I have locally, but that I cannot push at the moment for some reason. Waiting for the chain to catch up, and " [core] - 10https://gerrit.wikimedia.org/r/105727 (owner: 10Siebrand) [19:01:22] (03CR) 10Siebrand: [C: 04-1] "This needs some changes that I have locally, but that I cannot push at the moment for some reason. Waiting for the chain to catch up, and " [core] - 10https://gerrit.wikimedia.org/r/105728 (owner: 10Siebrand) [19:03:34] (03PS3) 10Siebrand: Specify DBMasterPos::getMasterPos() [core] - 10https://gerrit.wikimedia.org/r/105727 [19:06:05] (03Merged) 10jenkins-bot: Add CASCADINGSOURCES parser function [core] - 10https://gerrit.wikimedia.org/r/104999 (owner: 10Jackmcbarn) [19:07:55] (03CR) 10Calak: [C: 031] Make tableNamesWithUseIndexOrJOIN() and makeUpdateOptions() protected [core] - 10https://gerrit.wikimedia.org/r/105724 (owner: 10Siebrand) [19:12:19] (03PS3) 10Bsitu: Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 [19:13:01] (03PS4) 10Bsitu: Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 [19:21:58] (03CR) 10Gergő Tisza: "Very nice! I think this was a bit more complex than the average GCI task, and the patch works perfectly for all URL types, includes some r" (034 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx) [19:22:06] (03CR) 10Gergő Tisza: [C: 031] Add support for more Flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx) [19:26:33] (03CR) 10CSteipp: Add an API module for querying AntiSpoof results. (031 comment) [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/87546 (owner: 10Stwalkerster) [19:35:31] (03CR) 10GWicke: [C: 031] "Looks good to me on a first cursory pass. I have not attempted to test this. IIRC you mentioned that the test coverage is pretty good for " (031 comment) [core] - 10https://gerrit.wikimedia.org/r/101226 (owner: 10Aaron Schulz) [19:38:28] (03CR) 10PleaseStand: "This has the potential to break bots that add &assert=bot even when logging in. Was this considered?" [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [19:39:53] hello [19:40:50] (03CR) 10Hashar: [C: 04-1] Don't suggest if the search tem is a known title (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105705 (owner: 10Manybubbles) [19:41:34] (03CR) 10Manybubbles: Don't suggest if the search tem is a known title (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105705 (owner: 10Manybubbles) [19:46:29] (03PS2) 10Manybubbles: Don't suggest if the search term is a known title [core] - 10https://gerrit.wikimedia.org/r/105705 [19:46:53] (03CR) 10CSteipp: [C: 04-1] Refactor Special:Upload for extensibility (031 comment) [core] - 10https://gerrit.wikimedia.org/r/67173 (owner: 10Worden.lee) [19:51:08] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu) [19:53:57] (03CR) 10Siebrand: "i18n/L10n reviewed." (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/105233 (owner: 10CSteipp) [20:00:54] (03CR) 10CSteipp: [C: 031] "I'd like to get a few more people to comment on this, but I think this is a direction we want to go." [core] - 10https://gerrit.wikimedia.org/r/76458 (owner: 10Parent5446) [20:03:53] (03PS1) 10Manybubbles: Try to perform fewer corrections [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105752 [20:04:47] jdlrobson, was away, reviewing now. [20:06:13] (03PS1) 10Manybubbles: Remove errant print [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105780 [20:13:26] (03CR) 10Mattflaschen: [C: 04-1] "As I said, I think reading any ordinary wikitext page (whether it's an article, a policy page, or a help page) is pretty similar, other th" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105408 (owner: 10Jdlrobson) [20:14:01] (03PS7) 10Anomie: API: Add prop=contributors [core] - 10https://gerrit.wikimedia.org/r/95633 [20:14:56] springle: If you have a minute, https://gerrit.wikimedia.org/r/#/c/95633/ could use a look. PS5 added the limit to max 100 page ids per query. [20:16:08] (03PS1) 10Jackmcbarn: Restore the Details link in Special:AbuseLog [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105819 [20:17:11] anomie: ok [20:18:37] (03CR) 10Chad: [C: 032] Try to perform fewer corrections [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105752 (owner: 10Manybubbles) [20:21:10] damn poor me [20:22:58] (03CR) 10Chad: [C: 031] Don't suggest if the search term is a known title [core] - 10https://gerrit.wikimedia.org/r/105705 (owner: 10Manybubbles) [20:23:12] <^d> ^ That change could use another set of eyes. [20:23:26] (03PS2) 10Hashar: blacklist l10n-bot [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102636 [20:23:48] (03CR) 10Hashar: [C: 032 V: 032] blacklist l10n-bot [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102636 (owner: 10Hashar) [20:24:51] Is Jenkins stalled for anyone else? Submitted a patch to an extension about 10 minutes ago and Jenkins-bot still hasn't returned a result: https://gerrit.wikimedia.org/r/#/c/104790/ [20:26:38] kaldari: yup it is [20:27:12] hashar: Looks like there maight be problem with qunit as well (not sure if it's related) [20:27:34] kaldari: jenkins is stalled everyday around that hour due to some bug in Zuul [20:27:46] hashar: can you take a look at the beta global requests if you have time? nobody's processed any since 2012 [20:28:53] jackmcbarn: what do you mean ? [20:29:01] to give admin, etc. on beta cluster [20:29:02] (03Merged) 10jenkins-bot: Try to perform fewer corrections [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105752 (owner: 10Manybubbles) [20:29:06] http://deployment.wikimedia.beta.wmflabs.org/wiki/Global_requests [20:31:49] (03CR) 10Anomie: "*Are* there any such bots? I don't see any instances in the past few days' api logs." [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [20:32:08] jackmcbarn: that is the first time i see that page :/ [20:33:54] jackmcbarn: I guess we should get rid of that page and ask people to fill in bugs [20:34:04] (03CR) 10Manybubbles: [C: 032] Add maintenance script to autoloader [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105717 (owner: 10Chad) [20:34:24] (03PS3) 10CSteipp: Add tooltip by disabled Basic rights checkbox [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/105233 [20:35:04] (03CR) 10Swalling: "TL;DR: let's just go with patchset 1. Sorry to jerk you around Jon." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105408 (owner: 10Jdlrobson) [20:35:10] (03CR) 10CSteipp: Add tooltip by disabled Basic rights checkbox (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/105233 (owner: 10CSteipp) [20:35:12] (03Merged) 10jenkins-bot: Add maintenance script to autoloader [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105717 (owner: 10Chad) [20:40:56] (03CR) 10Mattflaschen: "It's easy to add .action-view to the first patch set. That will solve the issue with special and history pages, without singling out NS 0" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105408 (owner: 10Jdlrobson) [20:45:02] hey guys, how am I supposed to add stylesheets when creating an extension? Should it be a