[00:03:27] <HectorAE>	 Whew.
[00:04:16] <HectorAE>	 Just finished a 1200 line TemplateData edit for Template:Infobox language
[00:04:31] <James_F>	 HectorAE: Wow!
[00:06:12] <HectorAE>	 Now for Infobox Australian place :3
[00:07:43] <grrrit-wm>	 (03PS1) 10Physikerwelt: Math 2.0 [extensions/Math] (math2.0) - 10https://gerrit.wikimedia.org/r/105468 
[00:07:46] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Math 2.0 [extensions/Math] (math2.0) - 10https://gerrit.wikimedia.org/r/105468 (owner: 10Physikerwelt)
[00:10:44] <grrrit-wm>	 (03Abandoned) 10Physikerwelt: Math 2.0 [extensions/Math] (math2.0) - 10https://gerrit.wikimedia.org/r/105468 (owner: 10Physikerwelt)
[00:18:59] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Add Special:Diff as an internally-linkable redirect to diff pages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/63395 (owner: 10Jérémie Roquet)
[00:21:25] <grrrit-wm>	 (03PS8) 10Bartosz Dziewoński: Add Special:Diff as an internally-linkable redirect to diff pages [core] - 10https://gerrit.wikimedia.org/r/63395 (owner: 10Jérémie Roquet)
[00:36:25] <grrrit-wm>	 (03CR) 10Legoktm: Add ZeroMQFeedEngine (033 comments) [core] - 10https://gerrit.wikimedia.org/r/105117 (owner: 10Legoktm)
[00:36:34] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Deoptimize SVG versions of enhanced recent changes collapse/show arrows [core] - 10https://gerrit.wikimedia.org/r/105469 
[00:36:43] <grrrit-wm>	 (03PS7) 10Legoktm: Add ZeroMQFeedEngine [core] - 10https://gerrit.wikimedia.org/r/105117 
[00:38:28] <mayankmadan_>	 gcibot: :)
[00:50:50] <grrrit-wm>	 (03CR) 10Physikerwelt: [C: 032 V: 032] allow to maintain a development branch wihtout to review all the translation bot commits [extensions/Math] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/105470 (owner: 10Physikerwelt)
[00:57:38] <grrrit-wm>	 (03PS1) 10Reedy: Update code, add function levle type hints [extensions/UserDailyContribs] - 10https://gerrit.wikimedia.org/r/105472 
[00:59:17] <grrrit-wm>	 (03PS2) 10Reedy: Update code, add function levle type hints [extensions/UserDailyContribs] - 10https://gerrit.wikimedia.org/r/105472 
[01:01:46] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Properly peform deletion updates when moving over a redirect [core] - 10https://gerrit.wikimedia.org/r/105467 (owner: 10Anomie)
[01:05:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Properly peform deletion updates when moving over a redirect [core] - 10https://gerrit.wikimedia.org/r/105467 (owner: 10Anomie)
[01:09:10] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Typo, +some nitpicking. Sorry, accidentally posted the comments on previous patchset, but they're still relevant." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender)
[01:11:16] <Gloria>	 Really, three in a row?
[01:11:18] <Gloria>	 I'm being taunted.
[01:12:00] <grrrit-wm>	 (03CR) 10MZMcBride: Properly peform deletion updates when moving over a redirect (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105467 (owner: 10Anomie)
[01:12:14] <grrrit-wm>	 (03PS3) 10MZMcBride: Update code, add function levle type hints [extensions/UserDailyContribs] - 10https://gerrit.wikimedia.org/r/105472 (owner: 10Reedy)
[01:12:50] <grrrit-wm>	 (03CR) 10MZMcBride: allow to maintain a development branch wihtout to review all the translation bot commits (031 comment) [extensions/Math] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/105470 (owner: 10Physikerwelt)
[01:13:15] <Gloria>	 I fixed "levle", the stream just has a bug.
[01:15:00] <grrrit-wm>	 (03Abandoned) 10Physikerwelt: latexml rendering setting are overwritten by default values [extensions/Math] (LaTeXML) - 10https://gerrit.wikimedia.org/r/105466 (owner: 10Physikerwelt)
[01:15:43] <grrrit-wm>	 (03CR) 10TMg: "Why not simply pass the one or two parameters to an ...?diff=...&oldid=... URL (in that switched order because that order is used everywhe" [core] - 10https://gerrit.wikimedia.org/r/63395 (owner: 10Jérémie Roquet)
[01:20:38] <grrrit-wm>	 (03CR) 10MZMcBride: "Is there a related bug report for this change? The topic is set to "bug/14892" and bug 14892 is mentioned in the commit message, but if yo" [core] - 10https://gerrit.wikimedia.org/r/63395 (owner: 10Jérémie Roquet)
[01:24:17] <grrrit-wm>	 (03CR) 10Anomie: Properly peform deletion updates when moving over a redirect (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105467 (owner: 10Anomie)
[01:32:28] <grrrit-wm>	 (03PS6) 10Physikerwelt: Add reference to the current user to the PageRenderingHash hook [core] - 10https://gerrit.wikimedia.org/r/105213 
[01:53:28] <grrrit-wm>	 (03PS1) 10Physikerwelt: Fix merge problems [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/105474 
[01:54:04] <grrrit-wm>	 (03CR) 10Physikerwelt: [C: 032 V: 032] Fix merge problems [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/105474 (owner: 10Physikerwelt)
[02:09:48] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Deoptimize SVG versions of enhanced recent changes collapse/show arrows [core] - 10https://gerrit.wikimedia.org/r/105469 (owner: 10Bartosz Dziewoński)
[02:13:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Deoptimize SVG versions of enhanced recent changes collapse/show arrows [core] - 10https://gerrit.wikimedia.org/r/105469 (owner: 10Bartosz Dziewoński)
[02:14:13] <grrrit-wm>	 (03PS1) 10Legoktm: Deoptimize SVG versions of enhanced recent changes collapse/show arrows [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105477 
[02:37:33] <HectorAE>	 Alright finished my last task.
[02:40:05] <HectorAE>	 I forget what Guillaume Paumier's or Andre's nicks are so if either of them are here they probably want to know...
[02:40:15] <legoktm>	 andre__
[02:40:25] <legoktm>	 and basile
[02:40:51] <HectorAE>	 Right, thanks.
[02:46:38] <grrrit-wm>	 (03CR) 10Mattflaschen: "S, I'm not actively working on this, so you can take it." [core] - 10https://gerrit.wikimedia.org/r/52169 (owner: 10Mattflaschen)
[02:52:34] <grrrit-wm>	 (03CR) 10Mattflaschen: "It is now correctly a warning." [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender)
[03:00:22] <grrrit-wm>	 (03CR) 10MZMcBride: "Related: bug 59234" [core] - 10https://gerrit.wikimedia.org/r/103894 (owner: 10Bartosz Dziewoński)
[03:00:42] <grrrit-wm>	 (03CR) 10MZMcBride: "Related: bug 59234" [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105415 (owner: 10Ori.livneh)
[03:00:51] <grrrit-wm>	 (03CR) 10MZMcBride: "Related: bug 59234" [core] - 10https://gerrit.wikimedia.org/r/105413 (owner: 10Ori.livneh)
[03:04:18] <grrrit-wm>	 (03CR) 10Jforrester: "This seems to go against our standard practice for these files of listing one contributor per line, without wikitext/markdown/etc." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/105432 (owner: 10Legoktm)
[03:07:58] <grrrit-wm>	 (03CR) 10Legoktm: "Because right now Special:Version/Credits/BetaFeatures looks terrible." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/105432 (owner: 10Legoktm)
[03:08:13] <James_F>	 legoktm: So fix the broken code that makes it look terrible?
[03:08:23] <legoktm>	 it's not broken though
[03:08:29] <James_F>	 legoktm: Rather than trying to fix the AUTHORS.txt file in 300 extensions?
[03:08:38] <James_F>	 It seems to be assuming it's wikitext.
[03:08:41] <legoktm>	 yes
[03:08:50] <legoktm>	 very few extensions have an AUTHORS.txt file.
[03:08:53] <James_F>	 Whereas it assumes that LICENSE.txt is text and should go in a <pre>
[03:09:00] <James_F>	 Really?
[03:09:08] <legoktm>	 yes
[03:09:08] * James_F  only works on extensions that have them. :-)

[03:09:19] <James_F>	 Why does LICENSE.txt get different treatment?
[03:09:38] <legoktm>	 lets ask mwalker|away :)
[03:09:48] <Gloria>	 Where is mediawiki.org on beta labs?
[03:09:49] <Gloria>	 Grrrr.
[03:10:28] <Gloria>	 Doesn't exist, bleh.
[03:10:49] <legoktm>	 James_F: for the record: https://dpaste.de/CIYt/raw
[03:11:04] <grrrit-wm>	 (03CR) 10MZMcBride: "http://en.wikipedia.beta.wmflabs.org/wiki/Special:Version/Credits/BetaFeatures" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/105432 (owner: 10Legoktm)
[03:11:06] <James_F>	 legoktm: Huh.
[03:11:08] <legoktm>	 (that's all extensions in gerrit, looking for any file named "AUTHORS")
[03:11:27] <James_F>	 Where's Matt's offending commit?
[03:12:07] <legoktm>	 https://gerrit.wikimedia.org/r/#/c/65299/
[03:12:12] <Gloria>	 http://en.wikipedia.beta.wmflabs.org/wiki/Special:Version/Credits/EventLogging
[03:12:15] <legoktm>	 oh, its looking for CREDITS too, lemme check those
[03:12:16] <Gloria>	 Interesting.
[03:12:47] <legoktm>	 https://dpaste.de/aeIf/raw is "CREDITS"
[03:13:21] <Gloria>	 http://en.wikipedia.beta.wmflabs.org/wiki/Special:Version/Credits/CentralNotice
[03:13:25] <Gloria>	 Nice.
[03:13:37] <grrrit-wm>	 (03CR) 10Jforrester: "FIXME: Formatting of {CREDITS|AUTHORS}.* files assumes that it's wikitext(!) whereas the licence file more sanely assumes it should get pu" [core] - 10https://gerrit.wikimedia.org/r/65299 (owner: 10Mwalker)
[03:13:53] <Gloria>	 > CentralNotice would not have been possible were it not from the contributions of the following developers.
[03:14:00] <legoktm>	 James_F: I don't think that's a valid FIXME.
[03:14:06] <legoktm>	 There is no standard format for these files
[03:14:30] <James_F>	 legoktm: There isn't?
[03:14:36] <Gloria>	 Does anyone else think that's stilted language?
[03:14:45] <legoktm>	 James_F: did you click on Gloria's examples?
[03:14:48] <James_F>	 legoktm: There are only about 10 of them.
[03:14:50] <legoktm>	 they're all totally different.
[03:15:42] <James_F>	 I think it's not sane to expect a foo.txt file to contain wikitext, and break if it doesn't.
[03:16:09] <James_F>	 Wikitext is not designed like MarkDown.
[03:16:17] <James_F>	 And even then, those are meant to be foo.md
[03:16:38] <Gloria>	 I'm not sure you've explained what the issue is.
[03:16:51] <James_F>	 New code.
[03:16:53] <James_F>	 Does two things.
[03:16:56] <James_F>	 Differently.
[03:16:59] <James_F>	 Without explanation,.
[03:17:04] <James_F>	 And in a way that breaks things.
[03:17:14] <James_F>	 What more is there to explain? :-)
[03:17:16] <legoktm>	 James_F: only 3 out of 10 of the files even have a .txt extension.
[03:17:24] <James_F>	 legoktm: And each of those three are broken?
[03:17:38] <Gloria>	 Sorry, I mean I'm not sure I understand what treating the text as wikitext breaks.
[03:17:54] <legoktm>	 Given that they weren't even displayed anywhere in the interface before Matt's change, I don't see this as breakage.
[03:18:30] <James_F>	 legoktm: It shouldn't have been merged in this form.
[03:19:27] <legoktm>	 I disagree. The majority of the change was fine, and this affects 10 out of 600 extensions, which can be fixed extremely trivially as I have demonstrated.
[03:19:38] <legoktm>	 9 actually, since CN is fine.
[03:22:20] <grrrit-wm>	 (03CR) 10MZMcBride: "If there's a FIXME, please file a bug report at <https://bugzilla.wikimedia.org>. Gerrit comments are easily lost/forgotten." [core] - 10https://gerrit.wikimedia.org/r/65299 (owner: 10Mwalker)
[03:22:33] <legoktm>	 bbl, dinner.
[03:26:43] <grrrit-wm>	 (03CR) 10MZMcBride: "> This seems to go against our standard practice for these files of listing one contributor per line, without wikitext/markdown/etc." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/105432 (owner: 10Legoktm)
[03:27:27] <James_F>	 legoktm: Broken functionality shouldn't be merged even if it's only 1% of the overall commit.
[03:27:40] <James_F>	 legoktm: That's how +2 works, and it's why multiple smaller commits are better. :-)
[03:30:02] <Gloria>	 "Broken functionality" isn't an appropriate label, as far as I can tell.
[03:30:09] <Gloria>	 Backwards-incompatible, maybe?
[03:30:22] <James_F>	 Backwards?
[03:30:24] <Gloria>	 The S may be optional.
[03:30:26] * James_F  is confused.

[03:30:49] <Gloria>	 What are you describing as broken?
[03:31:10] <James_F>	 This is a brand new feature that adds a cool new feature (yay) in a broken way (boo) because it assumes something it shouldn't.
[03:31:26] <James_F>	 I don't see anything about compatibility.
[03:31:49] <Gloria>	 I guess I don't see it that way.
[03:32:08] <James_F>	 You think http://en.wikipedia.beta.wmflabs.org/wiki/Special:Version/Credits/BetaFeatures looks OK?
[03:32:27] <Gloria>	 I think it looks quite silly.
[03:32:35] <Gloria>	 The feature (listing the extension credits) already existed. It previously used a particular format. Now it's using a different format.
[03:32:39] <legoktm>	 Hence why I'm trying to fix it.
[03:32:47] <Gloria>	 The bug there is that the format is wrong, in my opinion.
[03:32:56] <Gloria>	 Following a backward[s]-incompatible change.
[03:33:10] <legoktm>	 (AUTHORS|CREDITS)(|.txt)? files were never recognized by MediaWiki before this change, so I'm not sure how it's breaking.
[03:33:11] <Gloria>	 Given the apparently small effect of changing the assumption, I don't really see an issue.
[03:33:14] <James_F>	 You think a file with a .txt extension should contain wikitext, and that our coding standards have been wrong?
[03:33:27] <legoktm>	 James_F: Did you miss where only 3 extensions have files with .txt extensions?
[03:33:34] <Gloria>	 I think if you find an actual bug, you should file one in Bugzilla. :-)
[03:33:59] <James_F>	 Gloria: Or, you know, you two could chill out and wait for Matt to respond. :-)
[03:34:12] <Gloria>	 I'm so tense right now.
[03:34:23] * James_F  gives Gloria a massage to relax.

[03:34:33] <legoktm>	 massmassage to the rescue.
[03:34:39] <Gloria>	 Heh.
[03:37:26] <Gloria>	 James_F: README uses wikitext, though that doesn't mean CREDITS, AUTHORS, or LICENSE should.
[03:37:31] <Gloria>	 Not sure how long README has been that way.
[03:37:49] <James_F>	 Gloria: Which extension has a "README.txt" file that is actually "README.wikitext"?
[03:38:02] <Gloria>	 RELEASE-NOTES also uses wikitext, I think.
[03:38:15] <Gloria>	 Would limiting the scope to exclude .txt files be sufficient?
[03:38:19] <James_F>	 Oh, you mean for MW core?
[03:38:34] <Gloria>	 I was just thinking of other examples of interpreting files as wikitext.
[03:39:10] <James_F>	 In general I don't think we should ever assume that text is wikitext. There's a reason .MD exists. :-)
[03:39:37] <Gloria>	 UPGRADE is also using wikitext. Perhaps we should be more explicit.
[03:40:39] <Gloria>	 We could create symlinks like foo.mediawiki.
[03:40:51] <James_F>	 Well, FOO might be anything; FOO.txt however shouldn't be assumed to be wikitext.
[03:40:55] <James_F>	 But yeah.
[03:41:18] <Gloria>	 Amusingly, files such as HISTORY use something that resembles wikitext, but the leading spaces fuck bullets up.
[03:41:22] <Gloria>	 https://github.com/wikimedia/mediawiki-core/blob/master/HISTORY
[03:42:08] <James_F>	 I think that's fine.
[03:56:10] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] "Exciting! Should also have RELEASE-NOTES :)" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO)
[04:07:15] <legoktm>	 I was going to suggest wrapping the .txt files in <poem> and then I realized that wasn't a core feature :(
[04:08:31] <Aaron|home>	 James_F: hmm, now what to do with my firewire ports (https://en.wikipedia.org/wiki/IEEE_1394#Security_issues)? :)
[04:08:51] <James_F>	 legoktm: But <pre> is.
[04:09:01] <James_F>	 Aaron|home: Oh dear.
[04:09:21] * Aaron|home  thinks about encryption phrases

[04:09:59] <legoktm>	 "newer machine...Power Mac G5"
[04:10:49] <grrrit-wm>	 (03CR) 10TTO: "I'll slip a release note in there as well." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO)
[04:11:27] <grrrit-wm>	 (03CR) 10MZMcBride: "Is this tied to a particular bug report?" [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO)
[04:12:21] <dshgna>	 Hi, I'm new to Mediawiki. Just finished setting up my environment. Would there be any best project to get started?
[04:13:48] <Gloria>	 Hi dshgna.
[04:13:59] <Gloria>	 dshgna: https://www.mediawiki.org/wiki/Annoying_little_bugs :-)
[04:14:47] <grrrit-wm>	 (03CR) 10Legoktm: Add namespace-wide page notice functionality (033 comments) [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO)
[04:18:28] <grrrit-wm>	 (03CR) 10MZMcBride: "I think you forgot a verb?" [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender)
[04:19:16] <dshgna>	 Gloria: Thank you :) 
[04:23:42] <grrrit-wm>	 (03CR) 10Zhuyifei1999: Output language-converted-title in output (031 comment) [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 (owner: 10Mayankmadan)
[04:26:56] <grrrit-wm>	 (03CR) 10MZMcBride: "Bump." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader)
[04:38:12] <grrrit-wm>	 (03CR) 10TTO: "MZM: It's true, but I really don't see a better solution without going to a great deal of hassle. Yes, the naming scheme is funky, and I'm" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO)
[04:39:46] <grrrit-wm>	 (03CR) 10TTO: "Also, it's related to (although not strictly tied to) bug 59245. I cross-posted at that bug report." [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO)
[04:43:12] <Niharika>	 Hullo. 
[04:43:58] <YuviPanda>	 hello Niharika
[04:45:07] <grrrit-wm>	 (03CR) 10Parent5446: [C: 031] Add ZeroMQFeedEngine [core] - 10https://gerrit.wikimedia.org/r/105117 (owner: 10Legoktm)
[04:47:13] <grrrit-wm>	 (03CR) 10Grunny: Replace usage of deprecated Title::escapeLocalURL() (031 comment) [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/104352 (owner: 10Siebrand)
[04:49:45] <grrrit-wm>	 (03CR) 10Parent5446: [C: 032] Remove methods from SpecialPage deprecated in 1.17 and 1.18 [core] - 10https://gerrit.wikimedia.org/r/104396 (owner: 10Siebrand)
[04:51:28] <grrrit-wm>	 (03PS2) 10TTO: Add namespace-wide page notice functionality [core] - 10https://gerrit.wikimedia.org/r/105434 
[04:53:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove methods from SpecialPage deprecated in 1.17 and 1.18 [core] - 10https://gerrit.wikimedia.org/r/104396 (owner: 10Siebrand)
[04:57:06] <grrrit-wm>	 (03PS4) 10AndyRussG: Notifications for course talk page edits [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/105147 
[04:57:36] <grrrit-wm>	 (03CR) 10MZMcBride: "Related: bug 4469" [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO)
[05:14:21] <grrrit-wm>	 (03CR) 10MZMcBride: "Also related: bug 15102 --> https://www.mediawiki.org/wiki/Special:Code/MediaWiki/48276 --> https://www.mediawiki.org/wiki/Special:Code/Me" [core] - 10https://gerrit.wikimedia.org/r/105434 (owner: 10TTO)
[05:15:00] <grrrit-wm>	 (03PS1) 10Legoktm: Cleanup of includes/rcfeed [core] - 10https://gerrit.wikimedia.org/r/105480 
[05:16:28] <grrrit-wm>	 (03Draft2) 10Legoktm: Add XMLRCFeedFormatter [core] - 10https://gerrit.wikimedia.org/r/105430 
[05:43:01] <theopolisme>	 marktraceur, you there? :)
[06:01:16] <marktraceur>	 theopolisme: Yes!
[06:01:17] <marktraceur>	 What's up?
[06:02:02] <theopolisme>	 marktraceur, hi! so -- fullscreen, i couldn't figure out that silly rendering stuff. it doesn't appear all the time, only sporadically, and disappears when resized
[06:02:04] <theopolisme>	 weird though
[06:02:29] <marktraceur>	 Yeah, this is why we disabled it in the first place
[06:02:47] <marktraceur>	 theopolisme: You don't need to fix the bug for the modularization to make sense; just enough so we can test that the module works
[06:03:05] <grrrit-wm>	 (03PS10) 10MarkAHershberger: Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/89340 
[06:03:26] <theopolisme>	 marktraceur, https://gerrit.wikimedia.org/r/#/c/105124/ 
[06:03:34] <grrrit-wm>	 (03CR) 10MarkAHershberger: "See I5335225683ec8f1c163bb67f478787ebc52ee3a9 which depends on one of these for installing extensions. Ideas?" [core] - 10https://gerrit.wikimedia.org/r/95951 (owner: 10Siebrand)
[06:05:04] <marktraceur>	 'kay!
[06:05:12] <grrrit-wm>	 (03CR) 10MarkAHershberger: "Doesn't work now because of If73d65ca094ff56deb19d3b6f3ef99892654726d but once that is resolved, I think this will do it." [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger)
[06:05:18] <marktraceur>	 theopolisme: I'm sure we'll get to reviewing it soon
[06:05:24] <marktraceur>	 Not *now*, but probably/maybe tomorrow!
[06:05:52] <theopolisme>	 Sure, totally cool. No hurry :)
[06:06:03] <marktraceur>	 Mmhmm
[06:23:28] <tonythomas01>	 Hi. I was trying to add an Error message in mysqlinstaller.php so that, an error gets shown when the user tries to install MW without providing a DB username. I added it to the submitConnectForm(), copying exactly the way the DBname was checked for null, and I got the result alright. But the problem is, the error still shows when the user enters a username in the column now 
[06:23:31] <tonythomas01>	 please help
[06:28:30] <marktraceur>	 tonythomas01: Can you show us the code for it?
[06:28:55] <tonythomas01>	 marktraceur: should I pastebin it ?
[06:29:07] <marktraceur>	 Yes
[06:31:24] <tonythomas01>	 marktraceur: http://pastebin.com/rDKyBKr2
[06:38:13] <marktraceur>	 tonythomas01: Do you maybe need to add the wgDBuser field to the form in getConnectForm also?
[06:39:10] <marktraceur>	 Actually no.
[06:39:18] <marktraceur>	 It exists, but under a different name I think.
[06:39:34] <marktraceur>	 You get _InstallUser and _InstallPassword, not wgDBuser
[06:39:47] <marktraceur>	 And changing that may wind up not being helpfule
[06:39:50] <marktraceur>	 helpful.*
[06:40:20] <tonythomas01>	 marktraceur: ok. you mean to get the _InstallUser as a variable and doing that strval === '' " ?
[06:40:34] <marktraceur>	 You can do that as an example, yes.
[06:40:49] <marktraceur>	 You can also check the strlen, that's a fine way to do it
[06:41:18] <mayankmadan>	 mwalker, hi
[06:41:46] <tonythomas01>	 marktraceur: Ok. should I be adding something to the getConnectForm ?
[06:41:53] <marktraceur>	 Eh, no
[06:42:03] <tonythomas01>	 ok. I will tell the results 
[06:42:19] <marktraceur>	 Because getWebUserBox should do the needful
[06:42:35] <marktraceur>	 Er sorry
[06:42:38] <marktraceur>	 getInstallUserBox
[06:42:55] * marktraceur  waves at YuviPanda

[06:44:41] <mwalker>	 mayankmadan: *waves*
[06:44:59] <mwalker>	 marktraceur: ice skating tomorrow?
[06:45:32] <mayankmadan>	 mwalker, can you have a look at my last comment https://bugzilla.wikimedia.org/show_bug.cgi?id=52343
[06:45:54] <mayankmadan>	 mwalker, and i have implemented the solution you had https://gerrit.wikimedia.org/r/#/c/105441/
[06:47:21] <marktraceur>	 mwalker: Hm, no, I have things
[06:47:35] <marktraceur>	 Maybe later in the week? Or maybe they're closing the rink soon?
[06:47:37] <mwalker>	 mayankmadan: I'm not sure we have the page IDs to query on; I think we just have the page titles
[06:47:47] <marktraceur>	 Agh, they are.
[06:47:53] <mwalker>	 marktraceur: maybe; I'll go during the week though
[06:48:44] <mayankmadan>	 mwalker, so is the current solution good to go?
[06:48:54] <marktraceur>	 mwalker: Union Square is open 'til the 20th!
[06:49:03] <marktraceur>	 Because eff Yerba Buena
[06:49:03] <tonythomas01>	 marktraceur: made the new variable and did the test, yet same thing happening http://pastebin.com/nFTCqb28
[06:49:04] <mwalker>	 mayankmadan: taking a gander at it now
[06:49:09] <marktraceur>	 Hm, weird
[06:49:09] <mayankmadan>	 okay
[06:49:45] <marktraceur>	 tonythomas01: Why are you doing "$wgDBuser = $wgDBuser =" ?
[06:50:14] <marktraceur>	 Also, the later examples for wgDBuser are different - they use $this->setVar
[06:50:39] <marktraceur>	 OH
[06:50:55] <marktraceur>	 tonythomas01: The value of the mysql user used for installation !== wgDBuser
[06:51:01] <marktraceur>	 It should be different
[06:51:05] <marktraceur>	 'cause securrity
[06:51:37] <marktraceur>	 tonythomas01: You should have a temporary local variable, IMO, that checks the value.
[06:56:02] <tonythomas01>	 marktraceur: Oh. That was a mistake. I actually meant it to be $wgDBuser = $this->getVar( '_InstallUser' );
[06:56:10] <tonythomas01>	 marktraceur: ok. I will try with another variable 
[07:01:00] <marktraceur>	 tonythomas01: I think you should use $this->setVar( '_InstallUser' ), I'm just not sure how you access it after that
[07:01:14] <marktraceur>	 Actually
[07:01:15] <marktraceur>	 Sec.
[07:02:06] <marktraceur>	 tonythomas01: Instead, put your check in submitInstallUserBox, I think.
[07:02:16] <tonythomas01>	 marktraceur: ok 
[07:02:17] <marktraceur>	 Not in the DatabaseInstaller version
[07:02:39] <tonythomas01>	 marktraceur: in a minute 
[07:02:53] <marktraceur>	 Extend it in the Mysql subclass to check for existence of the two variables, for user and password, and return an error status if they're not present
[07:03:07] <marktraceur>	 The rest should be nearly automatic
[07:05:11] <grrrit-wm>	 (03PS11) 10MarkAHershberger: Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/89340 
[07:10:12] <tonythomas01>	 marktraceur: wait. extending in the MySql subclass means ? sorry I am new to it 
[07:10:22] <tonythomas01>	 marktraceur: you mean like extending a class ?
[07:10:49] <marktraceur>	 Like extending the function
[07:10:58] <marktraceur>	 Declare the function in the subclass, and call the parent's version
[07:12:28] <tonythomas01>	 marktraceur: I need to make a new subclass in the file MySqlinstaller.php which extends from MysqlInstaller  ?
[07:18:24] <marktraceur>	 No no
[07:18:33] <marktraceur>	 tonythomas01: MysqlInstaller *is* the subclass
[07:19:06] <tonythomas01>	 marktraceur: ok. So, just need to define a function in the subclass itself right ?
[07:23:58] <marktraceur>	 Yeah
[07:48:48] <mwalker>	 mayankmadan: hmm; so your patch will invalidate the json page itself; but not the pages included in the json object. I'm not exactly cogent enough right now to give you good guidance on what you'll actually need to do; but I hope you can wait 8 hours for good feedback in my morning
[07:49:36] <mwalker>	 or maybe you can figure it out -- your looking for an onEditSave hook (I don't recall exactly what it's called); and you'll need to loop over the pages in the parsed JSON structure
[07:50:07] <mwalker>	 you need to use the hook so that both page and API edits will purge
[07:50:34] <mwalker>	 *but you may not be able to do the purge in the hook depending on what data is available -- you may have to set a flag and deal with it later somehow
[07:51:09] <mwalker>	 but I suspect you can get enough data in the hook to do it
[07:51:16] <mwalker>	 ** you may also be in the correct hook
[07:51:21] <mwalker>	 ** with the patch you just wrote
[08:10:04] <mwalker>	 James_F: *waves*
[08:10:14] <James_F>	 mwalker: Heya. How are you?
[08:10:29] <James_F>	 mwalker: Also, tsk, it's midnight on Saturday for you. :-)
[08:10:45] <mwalker>	 goood; and yep -- sleep is coming soon
[08:10:54] <mwalker>	 I was just going to be sad at you for not liking my new patch :'(
[08:11:24] <James_F>	 mwalker: I love your new patch. I just don't like the assumption that a foo.txt file will look good when rendered as wikitext. :-P
[08:11:24] <mwalker>	 *"new"
[08:11:33] <James_F>	 Yeah, that too. :-)
[08:13:05] <mwalker>	 I was trying to come up with a good way of determining what method to display it as -- I didn't really want to use file extension; and some of the already existing files are written as wikitext
[08:13:10] <mwalker>	 just as some are written as plain text
[08:14:45] <James_F>	 mwalker: Just show it as plain text (like the licences), unless it's called FOO.wikitext?
[08:14:57] <James_F>	 mwalker: This is maximally useful.
[08:15:22] <James_F>	 mwalker: And later add support for MarkDown in FOO.md? ;-)
[08:16:28] <James_F>	 mwalker: What do you think?
[08:16:51] <mwalker>	 I'm trying to find the conditions in which I actually render things as plain vs wikitext
[08:18:50] <mwalker>	 ah; so for the license file if they didn't set a parameter I make an assumption that it's plain text
[08:19:12] <mwalker>	 maybe I will just look at the file extension
[08:19:21] <mwalker>	 if it's *.md I'll treat it as wikitext
[08:19:29] <mwalker>	 because md ~ wikitext
[08:22:48] <mwalker>	 however; you seemed to indicate that you're not in SF?
[08:23:01] <mwalker>	 which is sad; because I was hoping I could rope you into going skiing next week
[08:23:09] <RoanKattouw>	 We are in Perth, WA, Australia
[08:23:13] <RoanKattouw>	 For linux.conf.au
[08:23:27] <RoanKattouw>	 Until the 11th
[08:23:48] <mwalker>	 *snuff*
[08:25:54] <James_F>	 mwalker: Sorry.
[08:26:01] <James_F>	 mwalker: Skiing sounds very fun, though.
[08:26:03] <mwalker>	 well; I'll be going again
[08:26:13] <James_F>	 mwalker: I'm back from .AU for a couple of weeks before returning here for a wedding.
[08:26:15] <mwalker>	 I have to go at least 6 times to break even on my pass
[08:26:19] <James_F>	 mwalker: Maybe skiing inbetwixt that? :-)
[08:26:24] <mwalker>	 yep yep
[08:26:29] <James_F>	 Cool.
[08:26:30] <James_F>	 Sleep well.
[08:26:44] <mwalker>	 marktraceur: btw; you're also invited to my skiing shenanigan next weekend
[08:27:29] * Jasper_Deng  mutters something about "California's ski resorts desperately need snow, we're at about 1/5 of our normal snowpack for this year"

[08:27:59] <Jasper_Deng>	 mwalker: you're going to Lake Tahoe?
[08:28:12] <mwalker>	 *nods*
[08:28:20] <mwalker>	 so it wont be awesome
[08:28:44] <mwalker>	 but I have at least one person coming along who's not too amazing at skiing; so I'll be on trails with snow machines
[08:30:00] <mwalker>	 eek though; 20" of snow on kirkwood's summit; 19" on the base
[08:30:02] <mwalker>	 that does suck
[08:30:07] * mwalker  hadn't looked before now

[08:30:34] <Jasper_Deng>	 mwalker: however there is good news, there's supposed to be light snow in the middle of next week, and heavier snow the following Saturday
[08:30:58] * Jasper_Deng  is more concerned about the possible water rationing next summer >.<

[08:31:29] * mwalker  mutters about SF's rather cavalier water usage

[08:33:25] <James_F>	 mwalker: We just need to secede from the rest of CA and take our water with us.
[08:33:45] <James_F>	 mwalker: Then we can do what we like with it, and sell it to LA at cost+100% (rather than cost-50% or whatever).
[08:33:56] <James_F>	 mwalker: It's the capitalist dream. ;-)
[08:35:33] <Jasper_Deng>	 heh James_F that'll happen if we end up owning Hetch Hetchy and the delta
[08:36:49] <James_F>	 Jasper_Deng: Yeah.
[08:38:37] <p858snake|l>	 <RoanKattouw> We are in Perth, WA, Australia <so the drop bears haven't got you yet?
[08:38:46] <p858snake|l>	 or our weather conditions?
[08:39:41] <RoanKattouw>	 We've only been here a day ...
[08:39:43] <RoanKattouw>	 And I am indeed already lamenting the weather
[08:39:44] <RoanKattouw>	 But that's part of the deal when you go to Australia in January
[08:44:08] <Jasper_Deng>	 mwalker: at least I-80 won't have too much snow
[08:44:20] <mwalker>	 truth
[08:44:29] <mwalker>	 though I've been itching to try out my chains on my car
[08:44:45] <Jasper_Deng>	 wait mwalker you're going on Saturday, right?
[08:44:54] <mwalker>	 maybe sunday
[08:44:55] <mwalker>	 dunno yet
[08:45:08] <Jasper_Deng>	 Saturday will have like half a foot of snow if you need to try them on
[08:45:15] <mwalker>	 heh
[08:45:19] * mwalker  plots

[10:08:34] <Nikerabbit>	 plop
[10:11:25] <Niharika>	 Hi Nikerabbit. 
[10:21:21] <James_F>	 Nikerabbit: You feel like a quick bit of i18n-JS related mergery? ;-) https://gerrit.wikimedia.org/r/#/c/102100/ would love to be merged, and it makes sense that it's you that does it…
[10:21:52] * James_F  bats his eyes. :-)

[10:26:58] <Nemo_bis>	 mergery :)
[10:27:33] <James_F>	 Nemo_bis: It's like magery, but more fun. :-)
[10:27:43] <grrrit-wm>	 (03CR) 10Umherirrender: API: Add prop=redirects and list=allredirects (037 comments) [core] - 10https://gerrit.wikimedia.org/r/104764 (owner: 10Anomie)
[10:32:30] <Nikerabbit>	 James_F: sure
[10:32:54] <James_F>	 Nikerabbit: Also, congrats. :-)
[10:34:53] <Nikerabbit>	 James_F: thanks
[10:35:07] <James_F>	 s/congrats/boo for having less of your time/ ;-)
[10:36:00] <Nikerabbit>	 James_F: one issue in the patch left, can you/Roan fix it?
[10:37:19] <James_F>	 Nikerabbit: Ah, whoops, yes, my fault - fixed.
[10:37:23] * James_F  missed that one.

[10:38:43] * Nemo_bis  wonders when we'll get used to Nikerabbit not being available 24/7 for MediaWiki stuff any longer

[10:38:53] * James_F  grins.

[10:39:29] <Nikerabbit>	 Nemo_bis: you already did when WMF hired me
[10:39:54] <grrrit-wm>	 (03PS1) 10UltrasonicNXT: Fix day not showing on timestamps when thursday [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/105490 
[10:40:04] <Nemo_bis>	 Nikerabbit: yes but the definition of "we" varies
[10:41:00] <Nikerabbit>	 James_F: there is two instances of the global, you forgot one
[10:41:18] * James_F  sighs.

[10:41:18] <grrrit-wm>	 (03PS2) 10UltrasonicNXT: Fix day not showing on timestamps when thursday [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/105490 
[10:41:48] <grrrit-wm>	 (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix day not showing on timestamps when thursday [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/105490 (owner: 10UltrasonicNXT)
[10:41:51] * James_F  coughs.

[10:41:52] <James_F>	 Done.
[10:43:46] <Nikerabbit>	 let's see if gerrit stops whining
[10:45:31] <James_F>	 Never. :-)
[10:47:04] <James_F>	 Nikerabbit: Thanks!
[10:47:50] <Nemo_bis>	 advantages of the i18n.php files being executables...
[10:50:37] <James_F>	 Nemo_bis: And disadvantages, which is why we don't want to do it any more. :-)
[10:54:21] <grrrit-wm>	 (03PS7) 10Physikerwelt: Add reference to the current user to the PageRenderingHash hook [core] - 10https://gerrit.wikimedia.org/r/105213 
[11:01:45] <mayankmadan_>	 Nemo_bis, can you help me with errors while running git review?
[11:06:10] <mayankmadan_>	 Nemo_bis, there are errors with merging a file
[11:06:46] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] Call Language::getLocalisationCache() static [core] - 10https://gerrit.wikimedia.org/r/105456 (owner: 10Umherirrender)
[11:10:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Call Language::getLocalisationCache() static [core] - 10https://gerrit.wikimedia.org/r/105456 (owner: 10Umherirrender)
[11:16:22] <Nemo_bis>	 mayankmadan_: better ask the channel :) I'm not so good with git
[11:16:38] <mayankmadan_>	 alright
[11:30:04] <mayankmadan_>	 can anyone help me with git review? https://dpaste.de/p1Oa
[11:30:15] <mayankmadan_>	 marktraceur, ^
[11:37:51] <grrrit-wm>	 (03CR) 10Umherirrender: Give warning on account creation when user name is adjusted silently (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender)
[11:53:44] <YuviPanda>	 RoanKattouw: seen any large venomous spiders under the toilet seat yet? :)
[11:55:38] <RoanKattouw>	 Nope, only seen one bug in the bathroom so far and it was small :)
[11:56:05] <RoanKattouw>	 The 2012 venue was much more rural, to the point where Trevor photographed a kangaroo through his bedroom window
[11:56:43] <YuviPanda>	 RoanKattouw: hah!
[11:56:55] <RoanKattouw>	 That place really was in the middle of nowhere
[11:57:00] <YuviPanda>	 RoanKattouw: where was it?
[11:57:18] * YuviPanda  would've liked to be in Australia now, a big/awesome cricket series was just completed

[11:59:23] <Nemo_bis>	 MegaAlex: do you lack tasks to claim?
[11:59:24] <RoanKattouw>	 YuviPanda: It was at the University of Ballarat campus in Mount Clear, VIC
[11:59:31] <RoanKattouw>	 ~9km outside of the actual town of Ballarat
[11:59:33] <RoanKattouw>	 Which itself is an hour and change inland from Melbourne
[11:59:35] <YuviPanda>	 hah
[11:59:36] <RoanKattouw>	 which was a 1h30m flight from Sydney, which was a 22h flight from London
[11:59:45] <YuviPanda>	 sounds like a fun conference spot
[12:01:25] <RoanKattouw>	 It was actually
[12:01:35] <RoanKattouw>	 I complained about it being in the middle of frigging nowhere, but it was pretty fun
[12:01:54] <Nemo_bis>	 RoanKattouw: maybe *because* it was in the middle of nowhere? :)
[12:02:47] <Nemo_bis>	 btw WMIT is proposing to renew the concept of Wikimania, on the basis that the more crowded is not the better https://meta.wikimedia.org/wiki/Wikimania_2015_bids/Esino_Lario
[12:03:26] <grrrit-wm>	 (03PS1) 10Nikerabbit: Prepare for composer [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/105501 
[12:05:09] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032 V: 032] Prepare for composer [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/105501 (owner: 10Nikerabbit)
[12:07:01] <YuviPanda>	 RoanKattouw: :)
[12:07:14] <Nemo_bis>	 Nikerabbit: thought we had a bug for that but it was for some other extension
[12:07:50] <tonythomas01>	 marktraceur: You there ?
[12:11:10] <Nikerabbit>	 who what when
[12:11:45] <Nikerabbit>	 Nemo_bis: ah for composer stuff
[12:12:01] <Nemo_bis>	 yes
[12:17:34] <p858snake|l>	 <YuviPanda> RoanKattouw: seen any large venomous spiders under the toilet seat yet? :) <it's generally other native wildlife in the toilet blocks such as frogs (due to the moisture)
[12:17:47] <p858snake|l>	 unless its a scout den, then for some reason there is spiders
[12:17:51] <YuviPanda>	 or crocodiles, maybe? :)
[12:18:15] <YuviPanda>	 heh http://en.wikipedia.org/wiki/Sewer_alligator
[12:18:21] <YuviPanda>	 (not crocodile but still)
[12:18:30] <p858snake|l>	 maybe if you did the cape york run, or went to the croc farms
[12:19:52] <YuviPanda>	 p858snake|l: are you from Australia?
[12:20:03] <p858snake|l>	 yeap
[12:20:52] * YuviPanda  makes joke about snake in p858snake|l's nick

[12:21:28] <p858snake|l>	 that was completely unrelated, but yes
[12:28:30] <tonythomas01>	 Hi! I was working on https://bugzilla.wikimedia.org/show_bug.cgi?id=59663 ,to add a check for NULL in the installer for Database username and password. I wrote a new function in the MySqlInstaller.php, but I am getting doubtful where and how to call it. Please help 
[12:49:01] <grrrit-wm>	 (03PS1) 10Nikerabbit: Composer: suggest does not take version, but description [core] - 10https://gerrit.wikimedia.org/r/105504 
[12:51:35] <grrrit-wm>	 (03CR) 10Nemo bis: [C: 031] "So [[mw:Composer]] says" [core] - 10https://gerrit.wikimedia.org/r/105504 (owner: 10Nikerabbit)
[12:52:23] <Niharika>	 YuviPanda: Around? 
[12:59:58] <grrrit-wm>	 (03PS1) 10Nikerabbit: Convert to json i18n [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/105506 
[13:31:28] <YuviPanda>	 Niharika: hey.
[13:31:29] <YuviPanda>	 Niharika: yeah
[13:31:30] <YuviPanda>	 tell me
[13:32:37] <Niharika>	 YuviPanda: I submitted this patch: https://gerrit.wikimedia.org/r/#/c/104793/5/resources/js/ext.uls.compactlinks.js and Santhosh made some comments on it. Could you have a look and tell me how am I using i18n as the last comment says?
[13:32:48] <YuviPanda>	 loking
[13:32:49] <YuviPanda>	 *looking
[13:33:10] <YuviPanda>	 Niharika: ah
[13:33:20] <YuviPanda>	 Niharika: so you are hardcoding the string 'More Languages' there, right?
[13:33:33] <Niharika>	 YuviPanda: Um, yeah. 
[13:33:36] <YuviPanda>	 Niharika: so what he means is that if the user is using the UI in some non-english language (German, french, whatever)
[13:33:46] <YuviPanda>	 Niharika: they will still see the text 'More Languages' rather than the translated text
[13:33:56] <Niharika>	 YuviPanda: :O Oh, okay. Got it. Thanks! 
[13:34:00] <Niharika>	 Iĺl fix it asap.
[13:34:04] <YuviPanda>	 Niharika: so you need to use a language key there
[13:34:12] <YuviPanda>	 and register it in the appropriate place
[13:34:23] <Niharika>	 Okay. Any helpful docs?
[13:34:38] <YuviPanda>	 Niharika: yeah, am looking for some now. moment
[13:36:27] <YuviPanda>	 Niharika: https://www.mediawiki.org/wiki/Manual:Messages_API
[13:36:32] <YuviPanda>	 Niharika: has PHP and JS parts
[13:36:55] <YuviPanda>	 Niharika: you will first have to make an entry for it in https://github.com/wikimedia/mediawiki-extensions-UniversalLanguageSelector/blob/master/UniversalLanguageSelector.i18n.php, under $messages['en']
[13:37:06] <YuviPanda>	 Niharika: then other people will magically translate it for other languages (via translatewiki.net)
[13:37:36] <Niharika>	 YuviPanda: Okay. 
[14:01:40] <tonythomas01>	 when no Databaseusername is given in the Installer, MW outputs an error "MySQL 5.0.2 or later is required. You have ." even though there is no actual check for that in DatabaseInstaller or anyother php files. Any idea why ?
[14:15:14] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "Per previous tests (also by Chris)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98568 (owner: 10Anomie)
[14:15:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Correct failure message when account is locked [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98568 (owner: 10Anomie)
[14:39:06] <grrrit-wm>	 (03PS4) 10Stwalkerster: Add an API module for querying AntiSpoof results. [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/87546 
[14:40:24] <grrrit-wm>	 (03PS5) 10Stwalkerster: Add an API module for querying AntiSpoof results. [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/87546 
[14:42:20] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] Removed the "details" link if the user is already in details page [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105164 (owner: 1001tonythomas)
[14:42:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Removed the "details" link if the user is already in details page [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105164 (owner: 1001tonythomas)
[14:45:53] <grrrit-wm>	 (03PS1) 10UltrasonicNXT: Simlify prettyTimestamps [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/105510 
[14:47:55] <grrrit-wm>	 (03CR) 10UltrasonicNXT: [C: 032 V: 032] Simlify prettyTimestamps [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/105510 (owner: 10UltrasonicNXT)
[14:54:20] <MegaAlex>	 Nemo_bis: I claimed a "fix i18n task". Will see if I can find a bug to work on. :)
[14:59:21] <Nemo_bis>	 MegaAlex: there is no lack of choice, is there :P
[15:13:51] <grrrit-wm>	 (03PS1) 10UltrasonicNXT: Try to fix users not appearing [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/105512 
[15:18:36] <grrrit-wm>	 (03CR) 10UltrasonicNXT: [C: 032 V: 032] Try to fix users not appearing [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/105512 (owner: 10UltrasonicNXT)
[15:23:03] <grrrit-wm>	 (03PS1) 10Nemo bis: Prepare for composer [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/105514 
[15:28:59] <grrrit-wm>	 (03CR) 10Nemo bis: Prepare for composer (034 comments) [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/105514 (owner: 10Nemo bis)
[15:30:17] <Nemo_bis>	 MegaAlex: let me know, if you really can't find anything
[15:33:33] <Nemo_bis>	 beware the multiplying Raymond___'s
[15:39:01] <mayankmadan__>	 hi MatmaRex 
[15:41:56] <mayankmadan__>	 Can mentors who are not a mentor in a particular task, close that task?
[15:45:42] <MatmaRex>	 mayankmadan__: no idea. what d oyou have in mind?
[15:47:15] <mayankmadan__>	 MatmaRex, i have completed http://www.google-melange.com/gci/task/view/google/gci2013/5771630336802816 and Im halfway through another(android) task but if this task isnt closed even after the next 1.5 hrs, i wont be able to claim the other one
[15:47:16] <gcibot>	 mayankmadan__, I can't see this task, sorry.
[15:52:18] <mayankmadan__>	 MatmaRex, 1 hr 8 mins left
[15:59:34] <MegaAlex>	 Nemo_bis: mhm, do you have any suggestions on what bug I can work on? :)
[16:08:17] <Nemo_bis>	 MegaAlex: some rewordings/copyediting: https://bugzilla.wikimedia.org/show_bug.cgi?id=37670 https://bugzilla.wikimedia.org/show_bug.cgi?id=38349 https://bugzilla.wikimedia.org/show_bug.cgi?id=45469 https://bugzilla.wikimedia.org/show_bug.cgi?id=53098
[16:09:00] <Nemo_bis>	 MegaAlex: this is a nice one but needs some logic behind it https://bugzilla.wikimedia.org/show_bug.cgi?id=43283
[16:09:10] <MatmaRex>	 mayankmadan__: does this actually matter for you? don't you have, like, a lot of tasks done?
[16:09:35] <Nemo_bis>	 MatmaRex: does the assign button work for you? spectie gets an error (apertium)
[16:09:49] <MatmaRex>	 mayankmadan__: sorry, i don't know anything about the stuff that task is about
[16:09:49] <mayankmadan__>	 MatmaRex, ive got only 30
[16:09:58] <grrrit-wm>	 (03PS1) 10UltrasonicNXT: The kick button was being shown to non-mods [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/105516 
[16:10:27] <MatmaRex>	 Nemo_bis: there are not tasks i could test this on right now :)
[16:10:30] <MatmaRex>	 no tasks*
[16:10:41] <MatmaRex>	 "only"
[16:10:51] <theopolisme>	 hey guys :)
[16:10:59] <MatmaRex>	 hi
[16:11:08] <Nemo_bis>	 MegaAlex: or you could take over this bug by amending https://gerrit.wikimedia.org/r/83221 , you could learn a bit about unit tests too, showing some variety; last comment says how to amend tests/qunit/suites/resources/mediawiki/mediawiki.jqueryMsg.test.js
[16:11:25] <Nemo_bis>	 hi theopolisme, do you have a task assigned to you right now?
[16:11:44] <MatmaRex>	 ugh, i had a  nice script to check who solved how many tasks mentored by whom, but it seems i lost it somewhere :/
[16:11:47] <theopolisme>	 No, I wrapped things up yesterday because I was under the impression that everything ended today
[16:11:54] <Nemo_bis>	 MatmaRex: :(
[16:12:03] <Nemo_bis>	 MatmaRex: you used the CSV export or something didn't you
[16:12:10] <Nemo_bis>	 theopolisme: can you pick a random one just for testing?
[16:12:18] <Nemo_bis>	 someone is having problems assigning tasks
[16:12:19] <theopolisme>	 There are still several things I'm working on but not as part of GCI of course :p
[16:12:20] <theopolisme>	 sure
[16:12:25] <theopolisme>	 Just tell me what to do
[16:12:28] <theopolisme>	 Oh wait
[16:12:39] <theopolisme>	 I read in the docs that tasks couldn't be assigned after 10 am pst today
[16:12:43] <Nemo_bis>	 pick one MatmaRex is mentor of (there must be one?)
[16:12:54] <Nemo_bis>	 the calendar says 17 UTC
[16:13:48] <theopolisme>	 9 am then :/
[16:13:53] <theopolisme>	 *Claim final task* The deadline to claim tasks for Google Code-in is Sunday, January 5th at 17:00 UTC (9am PT).  
[16:14:03] <theopolisme>	 hm
[16:14:04] <theopolisme>	 okay
[16:15:19] <theopolisme>	 MatmaRex, which tasks _are_ you a mentor of? :)
[16:16:17] <MatmaRex>	 the "localisation" ones
[16:16:45] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 04-1] Prepare for composer (035 comments) [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/105514 (owner: 10Nemo bis)
[16:17:02] <MatmaRex>	 i;ve ran out of more fascinating ones ;)
[16:17:21] <theopolisme>	 gotcha, https://google-melange.appspot.com/gci/task/view/google/gci2013/5786720972832768
[16:17:22] <gcibot>	 theopolisme, I can't see this task, sorry.
[16:17:46] <theopolisme>	 MatmaRex ^
[16:18:17] <MatmaRex>	 assigned
[16:18:25] <MatmaRex>	 so it works for me still
[16:18:39] <MatmaRex>	 also, whats up ith gcibot :/
[16:21:00] <grrrit-wm>	 (03CR) 10Nemo bis: Prepare for composer (034 comments) [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/105514 (owner: 10Nemo bis)
[16:23:07] <grrrit-wm>	 (03CR) 10Nikerabbit: Prepare for composer (031 comment) [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/105514 (owner: 10Nemo bis)
[16:24:14] <grrrit-wm>	 (03CR) 10Nemo bis: Prepare for composer (031 comment) [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/105514 (owner: 10Nemo bis)
[16:25:17] <grrrit-wm>	 (03CR) 10Nikerabbit: Prepare for composer (033 comments) [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/105514 (owner: 10Nemo bis)
[16:29:23] <grrrit-wm>	 (03CR) 10Nemo bis: Prepare for composer (033 comments) [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/105514 (owner: 10Nemo bis)
[16:41:46] <mayankmadan__>	 MatmaRex, can you please close the task, i promise that i will address to all the comments on the review request
[16:43:37] <MatmaRex>	 mayankmadan__: i can assure you the number of tasks solved doesn't matter, as long as you are in the top 5 of the organization (which is a Google's requirement to be eligible for the grand prize_
[16:44:15] <mayankmadan__>	 MatmaRex, i know that but the one  that i was doing was a really complex one which would increase my chances
[16:44:31] <mayankmadan__>	 the other android one
[16:46:49] <mayankmadan__>	 MatmaRex, http://www.google-melange.com/gci/task/view/google/gci2013/5771630336802816
[16:46:50] <gcibot>	 mayankmadan__, I can't see this task, sorry.
[16:50:59] <grrrit-wm>	 (03PS1) 10Umherirrender: document.selection is undefined in IE11 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/105517 
[16:52:14] <mayankmadan__>	 MatmaRex, would it count if i do the task and i dont claim it?
[16:52:25] <grrrit-wm>	 (03CR) 10Umherirrender: "Works with IE11, IE8 and FF26" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/105517 (owner: 10Umherirrender)
[16:52:28] <mayankmadan__>	 would it increase my  chances?
[16:53:04] <MatmaRex>	 mayankmadan__: probably. no idea
[17:31:30] <grrrit-wm>	 (03PS7) 10MegaAlex: Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis)
[17:32:15] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis)
[17:35:44] <diwanship>	 hello yurik i am finding some problems with codecademy
[17:39:59] <diwanship>	 yurik to preview or view the later exercises of 2nd section i have to zoom in the screen otherwise i cant preview/view them. Can u check if its happening with you too?
[17:44:16] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 031] "Change of format for translatewiki.net prepared with I8bedcb540a2893acdcb2510ed2dbe99e33b7cfb9" [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/105506 (owner: 10Nikerabbit)
[17:48:27] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032 V: 032] Convert to json i18n [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/105506 (owner: 10Nikerabbit)
[17:48:28] <grrrit-wm>	 (03PS8) 10MegaAlex: Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis)
[17:55:13] <grrrit-wm>	 (03PS3) 10Siebrand: Remove classes and functions deprecated in MediaWiki 1.17 [core] - 10https://gerrit.wikimedia.org/r/104156 
[17:55:15] <grrrit-wm>	 (03PS1) 10Amire80: Add dummy GENDER to the logentry message [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/105520 
[17:56:17] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-2] "https://gerrit.wikimedia.org/r/#/c/105444/ works on the proper fix for this." [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/105520 (owner: 10Amire80)
[17:59:21] <grrrit-wm>	 (03Abandoned) 10Amire80: Add dummy GENDER to the logentry message [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/105520 (owner: 10Amire80)
[17:59:26] <grrrit-wm>	 (03PS2) 10Roopak: Changed the red Email box [core] - 10https://gerrit.wikimedia.org/r/94117 (owner: 10Gerrit Patch Uploader)
[18:00:35] <grrrit-wm>	 (03PS10) 10Siebrand: Replace <i> and <b> by <em> and <strong> in i18n [core] - 10https://gerrit.wikimedia.org/r/99195 
[18:04:46] <grrrit-wm>	 (03PS6) 10Siebrand: [WIP] Update documentation for database related classes [core] - 10https://gerrit.wikimedia.org/r/103890 
[18:41:26] <VladAndrew>	 guillom: are you here?
[18:42:49] <VladAndrew>	 guillom: I would like to ask ou something regarding a task when you have time 
[18:43:35] <Nemo_bis>	 MatmaRex: you found your script? :)
[18:47:46] <Nemo_bis>	 ah no the edit says the opposite, *cough*
[18:56:33] <grrrit-wm>	 (03CR) 10Parent5446: Composer: suggest does not take version, but description (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105504 (owner: 10Nikerabbit)
[19:02:45] <Nemo_bis>	 MegaAlex: hah, this is definitely a more straightforward approach than what I had in mind of trying :) https://gerrit.wikimedia.org/r/#/c/83221/8/tests/qunit/suites/resources/mediawiki/mediawiki.jqueryMsg.test.js
[19:03:01] <Nemo_bis>	 let's hope the devs are content with it
[19:16:58] <grrrit-wm>	 (03CR) 10Aklapper: [C: 031] "https://gerrit.wikimedia.org/r/#/c/90546/4/ looks good to me and works as expected on Labs (tested with an IE8 in compatibility mode on Wi" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/90546 (owner: 10Aklapper)
[19:21:52] <grrrit-wm>	 (03PS1) 10Nikerabbit: Fix fatal syntax error [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/105525 
[19:22:11] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032 V: 032] Fix fatal syntax error [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/105525 (owner: 10Nikerabbit)
[19:53:39] <grrrit-wm>	 (03PS7) 10Siebrand: [WIP] Update documentation for database related classes [core] - 10https://gerrit.wikimedia.org/r/103890 
[20:08:57] <grrrit-wm>	 (03CR) 10Anomie: API: Add prop=redirects and list=allredirects (032 comments) [core] - 10https://gerrit.wikimedia.org/r/104764 (owner: 10Anomie)
[20:09:22] <grrrit-wm>	 (03PS2) 10Anomie: API: Add prop=redirects and list=allredirects [core] - 10https://gerrit.wikimedia.org/r/104764 
[20:10:51] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] API: Add prop=redirects and list=allredirects [core] - 10https://gerrit.wikimedia.org/r/104764 (owner: 10Anomie)
[20:11:41] <grrrit-wm>	 (03CR) 10Anomie: Prepare for composer (031 comment) [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/105514 (owner: 10Nemo bis)
[20:13:04] <grrrit-wm>	 (03PS3) 10Anomie: API: Add prop=redirects and list=allredirects [core] - 10https://gerrit.wikimedia.org/r/104764 
[20:23:09] <grrrit-wm>	 (03CR) 10Nemo bis: Prepare for composer (031 comment) [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/105514 (owner: 10Nemo bis)
[20:23:54] <grrrit-wm>	 (03CR) 10TMg: [C: 031] "I love simple solutions." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/105517 (owner: 10Umherirrender)
[21:00:39] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "People want to use that in the projects, so I'm fine" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/71291 (owner: 10Se4598)
[21:02:35] <hoo>	 where's jenkins -.-
[21:04:09] <grrrit-wm>	 (03CR) 10Hoo man: [V: 032] Add triggered filter id as parameter to messages [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/71291 (owner: 10Se4598)
[21:08:26] <grrrit-wm>	 (03PS1) 10Jackmcbarn: Support searching for multiple filter IDs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105617 
[21:20:34] <grrrit-wm>	 (03CR) 10Nikerabbit: Composer: suggest does not take version, but description (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105504 (owner: 10Nikerabbit)
[21:24:49] <grrrit-wm>	 (03PS9) 10MrBlueSky: Add associated namespace option to Special:NewPages [core] - 10https://gerrit.wikimedia.org/r/52676 
[21:39:06] <grrrit-wm>	 (03CR) 10Parent5446: Composer: suggest does not take version, but description (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105504 (owner: 10Nikerabbit)
[21:53:13] <grrrit-wm>	 (03PS8) 10Physikerwelt: Add reference to the current user to the PageRenderingHash hook [core] - 10https://gerrit.wikimedia.org/r/105213 
[22:12:05] <grrrit-wm>	 (03PS1) 10Merlijn van Deen: +sidebar userscript [wikimedia/bugzilla/triagescripts] - 10https://gerrit.wikimedia.org/r/105618 
[22:41:11] <grrrit-wm>	 (03PS1) 10BryanDavis: Add missing qqq for csrf page [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/105620 
[23:16:07] <grrrit-wm>	 (03PS8) 10Mayankmadan: Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 
[23:16:12] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan)
[23:17:56] <grrrit-wm>	 (03PS9) 10Mayankmadan: Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 
[23:17:59] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan)
[23:22:05] <grrrit-wm>	 (03PS1) 10Gerrit Patch Uploader: Exclude toggle button of collapsible elements from user selection [core] - 10https://gerrit.wikimedia.org/r/105621 
[23:22:10] <grrrit-wm>	 (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/105621 (owner: 10Gerrit Patch Uploader)
[23:23:38] <grrrit-wm>	 (03PS10) 10Mayankmadan: Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596