[00:00:13] the code used for this has like 5 different code paths depending on what happens to be installed on the server [00:00:24] instead of just looking at the file extension, since this is all trusted data [00:01:19] MatmaRex: i thought about that too [00:01:36] if you want to treat the file extension as trustworthy, +1 [00:01:47] and only defer to mime-type sniffing if the extension is unknown [00:02:28] if we're working with local files in the repo, then just looking at the extensions seems like the sanest thing to do [00:02:34] though "this is all trusted data" should be verified [00:02:44] by thinking of all the ways of getting css into cssmin [00:02:51] mime detection is bound to fail, as we've seen, being, well, detection [00:03:33] (03CR) 10Aaron Schulz: [C: 032] Do not reveal RevDeled file title [core] - 10https://gerrit.wikimedia.org/r/105215 (owner: 10Anomie) [00:03:44] brb [00:03:50] ori: we're not embedding anything that is not a local file on the filesystem [00:04:34] we'd have to double-check that you can't refers to, say, the /images directory, but i think RLWikiModules etc. don't have their CSS processed [00:05:22] (03CR) 10Aaron Schulz: [C: 032] Don't convert bad curids to the Main Page [core] - 10https://gerrit.wikimedia.org/r/105122 (owner: 10Jackmcbarn) [00:05:57] (03CR) 10Zbynek: [C: 031] Add license info file for GPL2+ [extensions/GeoGebra] - 10https://gerrit.wikimedia.org/r/104481 (owner: 10Rudolf.grossmann) [00:10:31] (03Merged) 10jenkins-bot: Do not reveal RevDeled file title [core] - 10https://gerrit.wikimedia.org/r/105215 (owner: 10Anomie) [00:12:14] (03Merged) 10jenkins-bot: Don't convert bad curids to the Main Page [core] - 10https://gerrit.wikimedia.org/r/105122 (owner: 10Jackmcbarn) [00:13:59] (03CR) 10Mattflaschen: "JavaScript username validation is certainly desired. I agree it will require some work to handle hooks properly (this is something we've " [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender) [00:17:39] (03CR) 10Swalling: [C: 031] "The ideal solution IMO is to restrict the max width change to just articles, but we should do this at the very least. Looking at this vers" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105408 (owner: 10Jdlrobson) [00:20:17] (03CR) 10Swalling: ""I still think this should not be an error; I consider that a blocker." [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender) [00:21:18] (03CR) 10Bsitu: [C: 032] Fix undefined variable in recentchanges formatter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105245 (owner: 10EBernhardson) [00:21:24] (03Merged) 10jenkins-bot: Fix undefined variable in recentchanges formatter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105245 (owner: 10EBernhardson) [00:35:13] Nemo_bis: I polished up the text a little, i think its OK now [00:35:34] valhallasw from pwb approved it [00:37:26] (03CR) 10Parent5446: "If it is a warning, I would be in favor of adding this feature. I can understand how it would be a problem if a user registers an account " [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender) [00:37:40] (03PS1) 10Mattflaschen: Remove Extension:Vector [vagrant] - 10https://gerrit.wikimedia.org/r/105417 [00:39:13] (03CR) 10Parent5446: [C: 032] Add licensing for extensions to Special:Version [core] - 10https://gerrit.wikimedia.org/r/65299 (owner: 10Mwalker) [00:42:29] (03Merged) 10jenkins-bot: Add licensing for extensions to Special:Version [core] - 10https://gerrit.wikimedia.org/r/65299 (owner: 10Mwalker) [00:42:41] whoooo! [00:42:43] *dances* [00:45:45] * greg-g loads betalabs special:version [00:46:03] .... not responding.... (don't worry, it wasn't yesterday either :/ ) [00:47:10] <^demon|away> special:version never loads on beta. [00:47:14] <^demon|away> because nfs + git [00:47:25] it just loaded [00:47:30] mwalker: I see a lot of "" [00:47:39] <^demon|away> s/loads/loads quickly/ [00:47:41] :) [00:48:02] ya; it'll need a scap -- does beta do that? [00:48:13] <^demon|away> It needs a l10n cache rebuild. [00:48:17] <^demon|away> Which it should do automagically. [00:48:19] oh, uh, those happen every uh, time [00:48:22] $time [00:48:30] hmm [00:48:42] ie: not sure how often, but yeah, automatic [00:48:56] obviously not every 3 minutes like the code pulls [00:49:15] <^demon|away> Well l10n cache rebuild on beta usually takes > 3 minutes ;-) [00:49:20] <^demon|away> Again, nfs [00:49:30] wth, time to first bit on special:version is 32seconds! [00:49:42] byte, whatever [00:50:32] greg-g: yeah, Special:Version blows on beta. I hear NFS is the culprit [00:51:02] so says ^demon|away [00:51:03] <^demon|away> Where'd you hear that?!? [00:51:07] :) [00:51:26] it didn't always take so long! [00:51:42] * chrismcmahon reads the scroll and STFUs [00:51:48] :) :) [00:52:01] <^demon|away> Which came first? Beta? NFS on beta? Or shelling out to git for every extension for each Special:Version load? :) [00:52:05] greg-g: S:V has been messed up on beta since git I think [00:52:26] (03PS1) 10CSteipp: Fix typo in Release Notes [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/105418 [00:52:37] oh right... [00:52:44] well then [00:53:08] mwalker: now to submit a whole ton of patches to fix up the extensions license info? :) [00:53:13] sounds fun :) [00:53:20] but, I have to run home now, so tah tah! [00:54:34] (03CR) 10Chad: [C: 032] Remove forceReindex [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105386 (owner: 10Manybubbles) [00:54:40] (03Merged) 10jenkins-bot: Remove forceReindex [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105386 (owner: 10Manybubbles) [00:55:45] (03CR) 10Ori.livneh: [C: 032] Remove Extension:Vector [vagrant] - 10https://gerrit.wikimedia.org/r/105417 (owner: 10Mattflaschen) [00:55:48] (03Merged) 10jenkins-bot: Remove Extension:Vector [vagrant] - 10https://gerrit.wikimedia.org/r/105417 (owner: 10Mattflaschen) [01:01:00] (03CR) 10Mattflaschen: "Also, it should be consistent. Currently, it uses SVG for info (with PNG fallback, whichi is fine), PNG for error, and no icon for warnin" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105104 (owner: 10Gerrit Patch Uploader) [01:01:02] (03CR) 10Legoktm: "Looks fine to me, just the doc needs updating." (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/105387 (owner: 10Jackmcbarn) [01:02:49] (03CR) 10Parent5446: Further cleanup to Special:Version (035 comments) [core] - 10https://gerrit.wikimedia.org/r/65868 (owner: 10Mwalker) [01:03:30] (03PS2) 10Jackmcbarn: Remove misleading Thank button from some diffs [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/105387 [01:05:44] (03CR) 10Parent5446: [C: 04-1] "Merge conflict, and @since needs updating." [core] - 10https://gerrit.wikimedia.org/r/66054 (owner: 10Mwalker) [01:08:10] (03CR) 10Parent5446: [C: 04-1] Cache VCS commit id/date text on Special:Version (033 comments) [core] - 10https://gerrit.wikimedia.org/r/95878 (owner: 10Alex Monk) [01:08:42] 82 files changed, 3969 insertions(+), 1337 deletions(-) [01:08:43] heh [01:24:29] (03PS1) 10Mattflaschen: BetaFeatures needs update.php [vagrant] - 10https://gerrit.wikimedia.org/r/105420 [01:28:20] marktraceur: for https://gerrit.wikimedia.org/r/#/c/102383/, what kind of tests were you thinking of? [01:28:28] I'm not really sure how to test that [01:28:30] legoktm: all of them [01:28:44] Reedy: I added a license header!!! [01:28:54] gj legoktm [01:32:58] (03CR) 10Mwalker: Further cleanup to Special:Version (035 comments) [core] - 10https://gerrit.wikimedia.org/r/65868 (owner: 10Mwalker) [01:33:15] (03PS17) 10Mwalker: Further cleanup to Special:Version [core] - 10https://gerrit.wikimedia.org/r/65868 [01:33:23] (03PS1) 10Bsitu: Tweak and bug fix to modified tipsy and diff link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105421 [01:38:59] Reedy: 1337 deletions(-) haha nice [01:41:53] i'm looking at https://bugzilla.wikimedia.org/show_bug.cgi?id=56604 and can't figure out what a page summary is [01:42:38] jackmcbarn: ask? :P [01:44:13] wanted to make sure it's not me being stupid first [01:59:29] (03PS9) 10Parent5446: Moved account creation throttle to ping limiter [core] - 10https://gerrit.wikimedia.org/r/65867 [02:02:33] Ahmad96: I thought so :D [02:02:34] (03PS4) 10Alex Monk: Cache VCS commit id/date text on Special:Version [core] - 10https://gerrit.wikimedia.org/r/95878 [02:02:52] :D [02:03:16] (03CR) 10jenkins-bot: [V: 04-1] Cache VCS commit id/date text on Special:Version [core] - 10https://gerrit.wikimedia.org/r/95878 (owner: 10Alex Monk) [02:05:35] (03CR) 10Parent5446: [C: 032] Further cleanup to Special:Version [core] - 10https://gerrit.wikimedia.org/r/65868 (owner: 10Mwalker) [02:08:52] (03Merged) 10jenkins-bot: Further cleanup to Special:Version [core] - 10https://gerrit.wikimedia.org/r/65868 (owner: 10Mwalker) [02:09:53] (03CR) 10Legoktm: Log use of DisableAccount (031 comment) [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/32577 (owner: 10Alex Monk) [02:15:39] (03PS1) 10Adamw: Enable STOMP; add some helpful gateway default config [vagrant] - 10https://gerrit.wikimedia.org/r/105423 [02:15:41] (03CR) 10jenkins-bot: [V: 04-1] Enable STOMP; add some helpful gateway default config [vagrant] - 10https://gerrit.wikimedia.org/r/105423 (owner: 10Adamw) [02:20:48] 5.3G /var/www/wiki/mediawiki/extensions [02:20:50] Seriously? [02:21:56] (03PS4) 10Parent5446: Changed logged out tokens to use session if already there [core] - 10https://gerrit.wikimedia.org/r/76458 [02:22:51] 2.5G /home/reedy/git/mediawiki/core/.git/modules/extensions [02:22:59] That's WMF used extensons... [02:25:20] (03CR) 10jenkins-bot: [V: 04-1] Changed logged out tokens to use session if already there [core] - 10https://gerrit.wikimedia.org/r/76458 (owner: 10Parent5446) [02:26:15] (03PS5) 10Alex Monk: Cache VCS commit id/date text on Special:Version [core] - 10https://gerrit.wikimedia.org/r/95878 [02:40:36] (03PS8) 10Worden.lee: Refactor Special:Upload for extensibility [core] - 10https://gerrit.wikimedia.org/r/67173 [02:41:49] (03CR) 10jenkins-bot: [V: 04-1] Refactor Special:Upload for extensibility [core] - 10https://gerrit.wikimedia.org/r/67173 (owner: 10Worden.lee) [03:03:13] (03PS1) 10Jackmcbarn: Prevent fatal error in Special:AbuseFilter/test [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105424 [03:07:45] (03CR) 10Ori.livneh: [C: 032] Add new dependencies to education role: echo and parserfunctions [vagrant] - 10https://gerrit.wikimedia.org/r/105217 (owner: 10Ragesoss) [03:07:48] (03Merged) 10jenkins-bot: Add new dependencies to education role: echo and parserfunctions [vagrant] - 10https://gerrit.wikimedia.org/r/105217 (owner: 10Ragesoss) [03:09:55] (03PS7) 10Alex Monk: Log use of DisableAccount [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/32577 [03:10:18] (03PS2) 10Ori.livneh: BetaFeatures needs update.php [vagrant] - 10https://gerrit.wikimedia.org/r/105420 (owner: 10Mattflaschen) [03:10:26] (03CR) 10Ori.livneh: [C: 032] BetaFeatures needs update.php [vagrant] - 10https://gerrit.wikimedia.org/r/105420 (owner: 10Mattflaschen) [03:10:28] (03Merged) 10jenkins-bot: BetaFeatures needs update.php [vagrant] - 10https://gerrit.wikimedia.org/r/105420 (owner: 10Mattflaschen) [03:22:21] (03CR) 10Mattflaschen: [C: 031] "I haven't given much thought to the typography refresh recently, including the max-width. I think I understand the width idea, but I have" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105408 (owner: 10Jdlrobson) [03:28:43] (03PS9) 10Alex Monk: Special:ListGroupRights: Add per-namespace restrictions and rights [core] - 10https://gerrit.wikimedia.org/r/40096 [03:35:56] (03PS1) 10Ori.livneh: Provide human-readable consts representing load priority [vagrant] - 10https://gerrit.wikimedia.org/r/105425 [04:15:17] (03CR) 10Parent5446: [C: 031] "Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/95878 (owner: 10Alex Monk) [04:49:52] (03PS1) 10Spage: Don't globally style h1 and h2 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105426 [05:01:55] (03PS9) 10Worden.lee: Refactor Special:Upload for extensibility [core] - 10https://gerrit.wikimedia.org/r/67173 [05:03:11] (03CR) 10jenkins-bot: [V: 04-1] Refactor Special:Upload for extensibility [core] - 10https://gerrit.wikimedia.org/r/67173 (owner: 10Worden.lee) [05:06:05] (03PS10) 10Worden.lee: Refactor Special:Upload for extensibility [core] - 10https://gerrit.wikimedia.org/r/67173 [06:22:14] (03CR) 10Legoktm: [C: 04-1] "While this works, I think we should give the user an error instead of silently failing." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105424 (owner: 10Jackmcbarn) [06:23:45] hhm lego, didn't know that simply changing the scope of $title could change so many things [06:23:55] (making it exist outside that method) [06:23:57] huh? [06:24:16] no [06:24:36] Title::newFromText will return false or null (I forget) if an invalid title is given [06:30:29] yurik online? [06:32:30] Appears to be. [06:32:36] !ask [06:32:36] Please feel free to ask your question: if anybody who knows the answer is around, they will surely reply. Don't ask for help or for attention before actually asking your question, that's just a waste of time – both yours and everybody else's. :) [06:32:47] Hm, that's not super friendly [06:32:55] I thought we had a Nicer Message for that [06:33:48] (03PS2) 10AndyRussG: Notifications for course talk page edits [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/105147 [06:39:31] (03CR) 10AndyRussG: "Cool, thanks!!" (035 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/105147 (owner: 10AndyRussG) [06:41:05] hello i am opw intern and yurik is my mentor so i wanted his advice that's why i pingd him only. i had some queries regarding my project [06:45:52] (03Abandoned) 10TTO: Allow per-page notice functionality to be disabled [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105143 (owner: 10TTO) [06:45:55] (03Abandoned) 10TTO: Add CSS file to provide a margin below/above each notice [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105142 (owner: 10TTO) [06:46:14] (03Abandoned) 10TTO: Bring PageNotice extension into the modern era [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105141 (owner: 10TTO) [06:48:54] yurik i wanted to know if it would b okay to have loops in our tutorials or not because i have added them in some tutorials to show the result of action=query in HTML? [06:50:16] diwanship, hi, sure, any short code snippets are ok [06:50:23] ok thanks [06:50:33] (03PS8) 10Legoktm: Log use of DisableAccount [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/32577 (owner: 10Alex Monk) [06:52:12] (03CR) 10Legoktm: [C: 032] "Tested, works great." [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/32577 (owner: 10Alex Monk) [06:52:14] (03Merged) 10jenkins-bot: Log use of DisableAccount [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/32577 (owner: 10Alex Monk) [07:02:53] (03PS1) 10Legoktm: Override SpecialPage::execute instead of setting a callback function [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/105427 [07:12:03] (03PS1) 1001tonythomas: Result shown if username and password are same on same page of installer [core] - 10https://gerrit.wikimedia.org/r/105428 [07:50:36] (03CR) 10Parent5446: [C: 04-1] Add CASCADINGSOURCES parser function (032 comments) [core] - 10https://gerrit.wikimedia.org/r/104999 (owner: 10Jackmcbarn) [07:53:05] (03CR) 10Parent5446: [C: 04-1] "Needs rebase, then I'll merge." [core] - 10https://gerrit.wikimedia.org/r/104396 (owner: 10Siebrand) [07:56:14] (03CR) 10Ori.livneh: [C: 032] Provide human-readable consts representing load priority [vagrant] - 10https://gerrit.wikimedia.org/r/105425 (owner: 10Ori.livneh) [07:56:18] (03Merged) 10jenkins-bot: Provide human-readable consts representing load priority [vagrant] - 10https://gerrit.wikimedia.org/r/105425 (owner: 10Ori.livneh) [08:42:02] where is the MWNamespace class defined in mediawiki core? [08:55:18] mayankmadan: includes/Namespace.php [08:55:24] thanks [08:56:21] tto: if it's just action=view, I think Article would be the right place, but I'm not very familiar with that class or skins [08:56:52] OK, I'll re-ask my question here and see if others are more familiar with the code: [08:56:59] hello all, I'm taking a look at merging PageNotice into core, but not entirely sure how to go about it [08:57:01] I could add it around line 639 of Article.php - it would do what is wanted, I think, but it feels very very hackish [08:57:05] it could also go in the skin, but since I think we only really want it to display on action=view, that seems a bit excessive [09:05:53] ooh, exciting, I just found an existing function Article::showNamespaceHeader, which I think is a good place for this [09:38:18] in Upload Wizard, the mw.config.get( 'wgServer' )+ new mw.Title( existingFile, 6 ).getUrl(); returns the File url. But what if I want the original url ? like www.wiki.com/... ? [09:39:28] tonythomas01: What do you mean with original URL? [09:39:37] Thanks for your AbuseFilter patches, btw ;) [09:40:16] hoo: You are welcome. The bug requires to get the full url. and not something like wiki/File:pic1.png [09:40:23] https://bugzilla.wikimedia.org/show_bug.cgi?id=56267 [09:41:53] mw.config.get( 'wgServer' )+ new mw.Title( existingFile, 6 ).getUrl(); should actually give you what you want if I understand the question correctly [09:42:13] you want commos.wikimedia.org/wiki/File:Foo.bar [09:42:53] no. According to the bug, the correct link is expected right? like commos.wikimedia.org/wiki/images/Foo.bar ? [09:43:31] tonythomas01: The problem in the bug is/was that the url was relative like /wiki/File:foo.bar [09:43:40] but it needs wgServer prepended, so it becomes yourwiki.com/wiki... [09:45:38] hoo: but the argument passed along with mwe-upwiz-api-warning-exists is existingFileUrl which is mw.config.get( 'wgServer' )+ new mw.Title( existingFile, 6 ).getUrl(); right ? [09:45:40] hoo: and it gives this result ? [09:46:57] tonythomas01: Can't tell right now, as I don't have UploadWizard in front of me, give me a minute ;) [09:47:02] hoo: as far as the bug says. I think so [09:47:11] hoo: Ok [09:47:28] hoo: :) [09:48:20] tonythomas01: You're right [09:48:58] hoo: that means .. either the eexistingFileUrl is not giving proper output ? [09:49:36] tonythomas01: No... https://gerrit.wikimedia.org/r/77491 already fixed this [09:49:49] He just forgot to close the bug or wasn't aware of it [09:50:08] hoo: was wondering :) Thanks [09:50:14] ;) [10:01:50] hoo: similar one in abusefilter here https://bugzilla.wikimedia.org/show_bug.cgi?id=51382. in the Views/AbuseFilterterViewLists.php , 5 parameters are given as rawParams, and in the abusefilter-edit-lastmod-text, its just $1 by $2. why is 5 parameteres passed anyway ? [10:03:25] will have a look [10:03:39] hoo: :) [10:05:43] tonythomas01: Some languages use the additional parameters [10:05:45] eg. ast [10:06:50] hoo: Oh! never found that. so, the argument 1 takes $1 and argument 2 takes $2 and so on right ? [10:07:02] tonythomas01: Yep [10:07:17] hoo: I will try to figure a way. Thanks [10:12:18] hoo: Can you help me with that one ? The rawParams is just the name of the array right ? Nothing to do with parsing ? [10:14:33] tonythomas01: It just passes message parameters into the message [10:14:42] nothing to do with parsing or anything, yes [10:16:03] (03PS1) 10Umherirrender: Add handler for GetLogTypesOnUser hook [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/105433 [10:16:36] hoo: Ok. now the bug wants it to change like AbuseFilter/history//diff/... I should get the filterid too to get replaced right ? [10:16:47] (03CR) 10Umherirrender: "See I2db58b81c40eec1ac0d858efad23001762269a6d for a similar change to the Thanks extensions." [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/105433 (owner: 10Umherirrender) [10:18:21] tonythomas01: You have to add that as parameter yes [10:19:24] hoo: so in the in18, the filter id part will be some $3 ? [10:19:46] tonythomas01: You have to add that, so it will be $6 [10:19:48] AFAIS [10:20:19] hoo: ok. That was what I was looking. so, $6 will take the 6th argument. I will try [10:20:40] hoo: now need to find the variable filterid [10:31:06] how can I produce this abusefilter-edit-lastmod-text in my local install ? [10:31:39] tonythomas01: Do you have AbuseFilter isntalled and running? [10:31:53] hoo: ofcourse. [10:32:28] hoo: I couldnt reproduce it yet [10:32:35] tonythomas01: Just go to Special:AbuseFilter [10:32:49] it's the "Last modified" column in that table [10:33:21] hoo: seen that. I should add some filter right ? as mine is empty [10:33:42] tonythomas01: heh, you will need at least one to see that, yes [10:34:01] hoo: in a minute [10:38:55] hoo: Thanks saw it [10:45:04] (03CR) 10Nemo bis: "Thanks. Documented in , please improv" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/65299 (owner: 10Mwalker) [10:53:09] !easy [10:53:09] Bugzilla maintains a list of easy bugs for us, that are considered a good first step for new MediaWiki developers. See https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=keyword%3Aeasy for the list. [11:04:53] (03PS5) 10Siebrand: Remove methods from SpecialPage deprecated in 1.17 and 1.18 [core] - 10https://gerrit.wikimedia.org/r/104396 [11:06:31] (03CR) 10Siebrand: "Logging was implemented incorrectly." (032 comments) [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/32577 (owner: 10Alex Monk) [11:08:24] (03CR) 10Siebrand: [C: 032] Fix typo in Release Notes [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/105418 (owner: 10CSteipp) [11:09:45] (03CR) 10Siebrand: [C: 032] "Try #3." [core] - 10https://gerrit.wikimedia.org/r/103874 (owner: 10Siebrand) [11:13:18] (03Merged) 10jenkins-bot: Fix typo in Release Notes [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/105418 (owner: 10CSteipp) [11:15:06] (03Merged) 10jenkins-bot: Declare visibility for class properties in DatabaseSqlite [core] - 10https://gerrit.wikimedia.org/r/103874 (owner: 10Siebrand) [11:16:16] (03CR) 10Siebrand: [C: 032] "Try #3." [core] - 10https://gerrit.wikimedia.org/r/96244 (owner: 10Siebrand) [11:17:33] (03CR) 10Siebrand: "Please add qqq when adding new UI strings." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/105414 (owner: 10BryanDavis) [11:19:37] (03Merged) 10jenkins-bot: Various fixes for EnhancedChangesList [core] - 10https://gerrit.wikimedia.org/r/96244 (owner: 10Siebrand) [11:24:58] (03PS1) 10TTO: Add namespace-wide page notice functionality [core] - 10https://gerrit.wikimedia.org/r/105434 [11:48:10] (03PS1) 10Spage: Call msg ->text() or escaped() instead of parse() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105435 [11:54:27] (03CR) 10Spage: "I think I called text() and escaped() correctly, I tried with <" added to the messages. I didn't test 'flow-topic-participants' in a langu" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105435 (owner: 10Spage) [11:59:12] in Views/abuseFilterViewLists.php, how can I pass the filter id as an argument, so that it will get into abusefilter-edit-lastmod-text according to https://bugzilla.wikimedia.org/show_bug.cgi?id=51382 [12:00:31] (03CR) 10btongminh: "I have a test now that reproduces the bug. Still not sure why we have chosen to not verify in the async+filekey case." [core] - 10https://gerrit.wikimedia.org/r/105111 (owner: 10Mayankmadan) [12:19:03] (03CR) 10Spage: "See bug for more rationale." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105426 (owner: 10Spage) [12:32:45] (03CR) 10Ragesoss: "(whoops, I see that I never actually published the commment I tried to make yesterday with a suggested message)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/105147 (owner: 10AndyRussG) [12:49:56] (03CR) 10Spage: [C: 04-1] "Patch could use improvement but I like the approach." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105222 (owner: 10EBernhardson) [12:54:01] (03CR) 10Spage: "Removing my sticky -2, this is progress. I'll try to compare the HTMLForm changes here with those in I90954ea8e69bead335fee38ac7ec95b92bb9" [core] - 10https://gerrit.wikimedia.org/r/52169 (owner: 10Mattflaschen) [12:55:07] (03PS9) 10Spage: [WIP] Add Agora mw-ui-button classes to various buttons [core] - 10https://gerrit.wikimedia.org/r/52169 (owner: 10Mattflaschen) [13:05:02] (03PS1) 10Amire80: Backport update plural rules to CLDR 24 [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105438 [13:05:34] (03PS2) 10Amire80: Backport update plural rules to CLDR 24 [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105438 [13:10:03] (03PS4) 10M4tx: Fix user-friendlyness of block confirmation screen [core] - 10https://gerrit.wikimedia.org/r/103351 [13:22:11] (03PS5) 10Bartosz Dziewoński: Fix user-friendlyness of block confirmation screen [core] - 10https://gerrit.wikimedia.org/r/103351 (owner: 10M4tx) [13:22:31] (03CR) 10Bartosz Dziewoński: "I expanded the qqq a little." [core] - 10https://gerrit.wikimedia.org/r/103351 (owner: 10M4tx) [13:22:37] (03CR) 10Bartosz Dziewoński: [C: 032] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/103351 (owner: 10M4tx) [13:27:39] (03CR) 10Spage: [C: 04-1] "All the mw-ui-primary in this patch need to be switched to something else, mostly mw-ui-constructive (green). If any form has more than on" [core] - 10https://gerrit.wikimedia.org/r/52169 (owner: 10Mattflaschen) [13:27:53] (03Merged) 10jenkins-bot: Fix user-friendlyness of block confirmation screen [core] - 10https://gerrit.wikimedia.org/r/103351 (owner: 10M4tx) [13:37:55] (03CR) 10Bartosz Dziewoński: "Rillke, I'm afraid I don't understand." [core] - 10https://gerrit.wikimedia.org/r/74391 (owner: 10TheDJ) [13:48:51] (03PS1) 10Hashar: whitelist Markus Glaser [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105439 [13:49:00] (03CR) 10Hashar: [C: 032] whitelist Markus Glaser [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105439 (owner: 10Hashar) [13:49:07] (03Merged) 10jenkins-bot: whitelist Markus Glaser [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105439 (owner: 10Hashar) [13:49:47] (03PS2) 10Hashar: Adapted unittest to fit new wrapper [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/105168 (owner: 10Mglaser) [13:51:03] (03CR) 10Hashar: "I made Zuul to run tests for you. The extensions tests are still failing but that is a good start." [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/105168 (owner: 10Mglaser) [13:56:03] (03PS1) 10Mayankmadan: BookManagerv2: Invalidate navbar cache when JSON file changes Invalidate all constituent pages in a book when the JSON file changes. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/105441 [13:56:51] Nemo_bis, around? [14:03:35] hi siebrand [14:24:10] YuviPanda: Hi, there? [14:25:02] can anyone have a look at this? https://gerrit.wikimedia.org/r/#/c/105441/ [14:26:27] (03PS1) 10Umherirrender: Use TablePager on Special:ProtectedPages (using log_search) [core] - 10https://gerrit.wikimedia.org/r/105443 [14:27:32] (03PS3) 10Physikerwelt: Add reference to the current user to the PageRenderingHash hook [core] - 10https://gerrit.wikimedia.org/r/105213 [14:27:35] (03Abandoned) 10MaxSem: Extract variant-related code into a separate function [core] - 10https://gerrit.wikimedia.org/r/87486 (owner: 10MaxSem) [14:27:52] (03PS5) 10Physikerwelt: Validate TeX input for all renderers, not just texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/105187 [14:28:05] (03PS8) 10Physikerwelt: Remove call to deprecated ParserOptions::getMath [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 [14:29:53] (03CR) 10Umherirrender: "In my opinion this patch is more hacky than Iade82653999ca770586762b3c1383f73dfe3a5ee, because the logging table is at the moment never us" [core] - 10https://gerrit.wikimedia.org/r/105443 (owner: 10Umherirrender) [14:30:52] (03CR) 10Umherirrender: "A patch for using log_search can be found under Ia0dc5895ec672896fe4b75c2e0f76da2474bd6e4, I prefer this patch." [core] - 10https://gerrit.wikimedia.org/r/98175 (owner: 10Umherirrender) [14:31:36] (03PS4) 10TheDJ: All toggles for makeCollapsible should use the pointer cursor. [core] - 10https://gerrit.wikimedia.org/r/74391 [14:32:24] (03CR) 10jenkins-bot: [V: 04-1] All toggles for makeCollapsible should use the pointer cursor. [core] - 10https://gerrit.wikimedia.org/r/74391 (owner: 10TheDJ) [14:32:50] (03CR) 10Umherirrender: "For info: Revision delete of the user or comment field on the page_restrictions table is not possible, because it is easier to change the " [core] - 10https://gerrit.wikimedia.org/r/98175 (owner: 10Umherirrender) [14:34:58] (03CR) 10Umherirrender: "Needs adjust of the documentation under docs/hooks.txt" [core] - 10https://gerrit.wikimedia.org/r/105213 (owner: 10Physikerwelt) [14:38:03] (03CR) 10Umherirrender: "Alternative patch (same table code but other query) exists under Ia0dc5895ec672896fe4b75c2e0f76da2474bd6e4" [core] - 10https://gerrit.wikimedia.org/r/98573 (owner: 10Umherirrender) [14:38:56] (03PS5) 10TheDJ: All toggles for makeCollapsible should use the pointer cursor. [core] - 10https://gerrit.wikimedia.org/r/74391 [14:39:40] (03CR) 10TheDJ: "So I added a new mw-customtoggle class to also add the cursor to any custom toggle." [core] - 10https://gerrit.wikimedia.org/r/74391 (owner: 10TheDJ) [15:08:56] can anyone tell me what is the difference between Lists and Generator ? for eg: list=geosearch and generator=geosearch [15:17:46] diwanship: "Use generator if you want to get data about pages that are result of another api call. For example, if you want to get data about pages in a certain category (list=categorymembers), and then call api with pageids set to all the returned results, you should combine two calls into one by setting generator=categorymembers instead of the list parameter." [15:18:51] (03PS4) 10Physikerwelt: Add reference to the current user to the PageRenderingHash hook [core] - 10https://gerrit.wikimedia.org/r/105213 [15:19:38] some call it a pipe. [15:20:12] use this list as input, then use to to generate that output. [15:22:59] so http://en.wikipedia.org/w/api.php?action=query&list=allcategories&acprefix=List creates a list of all categories starting with "List" [15:23:33] and http://en.wikipedia.org/w/api.php?action=query&generator=allcategories&gacprefix=List&prop=info uses that same list as input to query for the pageinfo of that list. [15:26:31] Nemo_bis: Could you check https://www.mediawiki.org/wiki/Manual:Pywikibot/Installation and see if I left something out? [15:26:52] (03PS2) 10Anomie: Correct failure message when account is locked [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98568 [15:27:26] GEOFBOT: ah sorry, I had understood that it had already been marked by valhalla [15:27:46] Nemo_bis: I meant like checking the syntax, just in case ;) [15:28:01] anomie, can you have a look at https://gerrit.wikimedia.org/r/#/c/105441/ [15:28:43] (03CR) 10Hoo man: [C: 04-1] "per PS1" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98568 (owner: 10Anomie) [15:28:49] GEOFBOT: can "git submodule" really be translated? [15:28:53] (03CR) 10Physikerwelt: "I would really like to modify the php unit test for that. However I could not find the related tests at" [core] - 10https://gerrit.wikimedia.org/r/105213 (owner: 10Physikerwelt) [15:28:54] (03PS3) 10Anomie: Correct failure message when account is locked [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98568 [15:29:08] maybe submodule can be trasnlated? [15:29:16] or "compat" [15:29:31] it's a git command, do they have translations? [15:29:39] (03CR) 10Anomie: "PS3: Throw an error for unexpected return values from CentralAuthUser::canAuthenticate, and adjust switch indenting." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98568 (owner: 10Anomie) [15:29:44] git submodule isn't a command [15:29:56] its saying that that part of the repo is a submodule of the git repo [15:30:32] well but it's also a command [15:30:58] stuff like https://github.com/wikimedia/pywikibot-i18n/trunk should be in a tvar [15:32:44] mayankmadan_: I know nothing about BookManagerv2, or about squid purging. Sorry. [15:33:08] squids are innocent! [15:33:09] jk [15:33:44] only after reaching the stomach [15:34:41] thedj thanks [15:35:57] om nom nom calamari [15:41:23] ok Nemo_bis, I fixed the git submodule stuff and added all the URLs i could find to tvars [15:42:39] (03PS1) 10Alex Monk: Fix logging [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/105444 [15:43:31] (03CR) 10Alex Monk: "Fixed in I3c118679" [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/32577 (owner: 10Alex Monk) [15:56:58] oki GEOFBOT, let's call it good enough [15:57:45] NOT as part of the GCI task, i.e. after it's closed, I suggest you to also translate one such page, just to see what the translator experiences and what makes a page better [15:59:47] is someone arround, who want's to review https://gerrit.wikimedia.org/r/#/c/105213 (Add reference to the current user to the PageRenderingHash hook) it could be easier if IRC can be used for discussions? [16:02:01] Nemo_bis: ok, coolio [16:02:07] i will start matching up indonesian to english [16:13:03] marktraceur, hey :) [16:31:14] does anyone know if there's a way to get image original size from the api? can't find it in the docs [16:34:03] Nemo_bis: Could you please remark UNC links for translations if you are free? :) [16:36:01] MegaAlex: unc is unbalanced now [16:37:31] what's that? [16:38:42] MegaAlex: look https://www.mediawiki.org/wiki/UNC_links#How_to_link [16:38:49] {{unc | \\ComputerName\Shared Folder\Resource Name}} [16:39:02] ah, found it "&prop=imageinfo&iiprop=size" [16:39:32] mooeypoo: be sure to handle the case in which it's missing; there are mny [16:40:32] yeah, I saw that too [16:41:02] Nemo_bis, thanks :) I wanted to see if I can get it in case it's there, without going into checking the file. Might have to do that too, eventually, though, on files that have that properties missing in the api [16:42:05] (03PS4) 10Umherirrender: Give warning on account creation when user name is adjusted silently [core] - 10https://gerrit.wikimedia.org/r/104926 [16:43:09] (03CR) 10Umherirrender: "Patch Set 4: Changed from error to warning." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender) [16:45:07] Nemo_bis: I have fixed UNC links. It seems that I have missed the header in Development... derp... [16:53:22] Nemo_bis, the "&prop=imageinfo&iiprop=size" is manually configured? so, it will be missing if users didn't set it up, or is it done automatically upon upload? [16:53:35] the metadata of the image, I mean [16:56:41] mooeypoo: automatically [16:57:17] MatmaRex, so I know that these might be missing -- but if it's done automatically, why would they be? what type of images would be missing the size metadata info? shouldn't it be globally available? [16:57:22] hey Nemo_bis, here's a really simple paeg I found, ready to be marked [16:57:23] https://www.mediawiki.org/wiki/Squid [17:01:51] mooeypoo: invalid files, i guess, or files which are not images [17:01:53] om nom nom nom [17:03:05] mooeypoo: do you have any examples of such files? [17:03:16] nope, I'm trying to figure out how common it is for specifically images [17:03:32] MatmaRex, I'm working on the media edit dialog in VE, specifiically the ability to manually change image sizes [17:04:07] so I already have aspect-ratio limits set (width/height change accordingly) but now I'm trying to see if I can have a "reset to default" button that sets the image back to its original size [17:04:42] later I can also add something using the preset sizes in the wiki settings. [17:06:33] mooeypoo: (in wikitext, you can display image in original size by using |frame, btw) [17:06:42] (03PS3) 10Jackmcbarn: Add CASCADINGSOURCES parser function [core] - 10https://gerrit.wikimedia.org/r/104999 [17:07:10] mooeypoo: i'm pretty sure all or almost all images have this metadata [17:07:17] MatmaRex, aye, but in VE edit mode I need to set up an actual size [17:07:57] MatmaRex, I need size mostly for the overlay image and the size handles that are overlayed when the user wants to manually resize with the mouse, etc. So I have to get actual numbers. [17:08:36] MatmaRex, well, I'll set something up for a case where it doesn't exist,but I will have to see how common it is. It might be the wrong strategy to use if the metadata is missing from many images [17:15:43] MatmaRex, can you have a look at https://gerrit.wikimedia.org/r/#/c/105441/ [17:15:51] (03CR) 10Bartosz Dziewoński: All toggles for makeCollapsible should use the pointer cursor. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/74391 (owner: 10TheDJ) [17:19:06] mooeypoo: i am positive it's only missing if the image itself is broken [17:19:37] mayankmadan_: "request" is not spelled the way you spelled it. have you tested that code? [17:20:02] actually, the syntax there doesn't even look right [17:22:00] MatmaRex, hm, that seems pretty acceptable, then. [17:22:11] MatmaRex, thanks :) [17:28:34] (03PS2) 10Mayankmadan: BookManagerv2: Invalidate navbar cache when JSON file changes Invalidate all constituent pages in a book when the JSON file changes. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/105441 [17:29:10] MatmaRex, can you guide me a little through this task, how am i supposed to test the code? [17:30:38] mayankmadan_: i have never used that extension myself and i have no idea waht it does, so not really [17:30:56] its the last day of gci so i wanted to get as much tasks that i can get [17:36:29] Niharika: hey! Just popped in today, but will be leaving again :( [17:36:29] (03PS3) 10Mayankmadan: BookManagerv2: Invalidate navbar cache when JSON file changes Invalidate all constituent pages in a book when the JSON file changes. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/105441 [17:37:02] YuviPanda: No problem. I solved the issue I was facing. :) [17:37:06] Niharika: ah ok [17:37:11] Any idea when Sucheta might pop in? [17:38:05] YuviPanda: ^ [17:38:12] Niharika: not sure, she was having some issues. fel free to poke me until she turns up [17:38:13] *feel [17:38:54] YuviPanda: Ah. Okay. No, I wanted her to review my code and I had some doubts about it. I´ll wait for her. :) [17:41:32] hey YuviPanda, bored? [17:41:42] MatmaRex: no :P [17:41:43] https://gerrit.wikimedia.org/r/#/c/63395/ wants reviews, it's a pretty old patch :( [17:42:19] MatmaRex: sorry :( [17:47:06] MatmaRex, can you help me out with https://dpaste.de/30Hz [17:47:21] getting this when trying to go to my local setup of mediawiki [17:48:56] (03CR) 10Reedy: Add Special:Diff as an internally-linkable redirect to diff pages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/63395 (owner: 10Jérémie Roquet) [17:49:34] mayankmadan_: run update.php [17:49:35] !update [17:49:35] update.php is a script that updates the database tables. You usually need to run it after upgrading MediaWiki or installing certain extensions. For details, see [17:49:58] MatmaRex, why does that happen? [17:50:23] mayankmadan_: because a new column has been added to the 'page' table [17:50:30] !g b57e4570 [17:50:30] okay [17:50:30] https://gerrit.wikimedia.org/r/#q,b57e4570,n,z [17:50:43] it's as if you updated mediawiki to a new version [17:51:53] MatmaRex, getting DB connection error: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) (localhost) [17:51:59] on update,php [17:52:19] don't use sockets [17:52:49] mayankmadan_: is your mysql service running? [17:53:02] yes [17:53:14] then i have no idea what could be wrong, sorry [17:54:25] MatmaRex, i figured the error [17:54:30] was using the wrong php [17:54:36] had to use the one with lampp [17:54:58] MatmaRex: Swap localhost to 127.0.0.1 in LocalSettings ;) [18:01:01] (03PS6) 10Bartosz Dziewoński: Add Special:Diff as an internally-linkable redirect to diff pages [core] - 10https://gerrit.wikimedia.org/r/63395 (owner: 10Jérémie Roquet) [18:01:44] (03CR) 10Bartosz Dziewoński: Add Special:Diff as an internally-linkable redirect to diff pages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/63395 (owner: 10Jérémie Roquet) [18:02:49] (03PS7) 10Bartosz Dziewoński: Add Special:Diff as an internally-linkable redirect to diff pages [core] - 10https://gerrit.wikimedia.org/r/63395 (owner: 10Jérémie Roquet) [18:02:54] thanks Reedy, wanna merge? :D [18:08:38] Uhh [18:08:39] ;) [18:11:59] (03PS1) 10Grunny: Remove cases of double escaping [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/105448 [18:43:04] (03CR) 10Aaron Schulz: [C: 04-1] Add BagOStuff::setMulti for batch insertions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/101617 (owner: 10Legoktm) [19:01:46] (03PS3) 10AndyRussG: Notifications for course talk page edits [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/105147 [19:12:31] MatmaRex, any idea where i can get Raylton P Sousa? [19:12:35] (03PS1) 10Manybubbles: Combine highlighting from plain and text analyzer [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105452 [19:25:49] how was the steps in order to make an ammend to this commit https://gerrit.wikimedia.org/r/#/c/103355/ ? [19:26:27] git review -R 103355 doesnt work [19:26:48] git review -d 103355 [19:27:57] https://git.wikimedia.org/git/operations/mediawiki-config.git [19:28:01] ops [19:33:01] qgil: I'll make an ammend commit for the icon task right away [19:34:06] hi VladAndrew good, but if you don't mind go to the task / Gerrit patch and comment there to avoid duplicated work. Thank you! [19:35:30] qgil: so I should comment that I am working on the task es ? [19:35:48] VladAndrew, yes, please [19:38:01] qgil, can you have a look at http://www.google-melange.com/gci/task/view/google/gci2013/5890126337015808 [19:38:03] BookManager v2: Invalidate navbar cache when JSON is edited [19:38:03] Status: Claimed (2 days, 12 hours left) [19:38:04] Mentor(s): Andre Klapper, Quim Gil, Raylton P. Sousa [19:38:12] qgil, i would not bug you if it werent the last day of gci [19:41:40] mayankmadan, I'm sorry but I'm a proxy mentor there, not capable of assessing the task myself. [19:41:54] mayankmadan, For what is worth your direct "competitors" are also waiting to get their patches reviewed. One task more or less won't make a difference at this point. You have done a great job! [19:42:17] qgil, thank you [19:43:29] qgil, would it help if i work on something(like remaining tasks) later(after gci) unofficially? [19:43:55] i mean would it help my chances [19:44:46] mayankmadan: I do not think so but you would help the communit [19:45:27] ok [19:45:36] (03CR) 10Umherirrender: "Needs rebase to test" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/52676 (owner: 10MrBlueSky) [19:45:56] hey Nemo_bis, ya there? [19:49:40] qgil: I have added the 48x48 [19:49:44] hope you like it [19:51:07] could any trans admins review https://www.mediawiki.org/wiki/Squid (om nom nom) and https://www.mediawiki.org/wiki/MediaWiki_1.18 ? [19:52:56] qgil, any ideas who can review my review request? [19:53:54] VladAndrew, thank you for the patch. Please claim that task in order to get back to GCI business as usual. I will review the patch now. [19:54:43] qgil: I cant actually claim it, Im waitting for more than a day for someone to accept my task https://www.google-melange.com/gci/task/view/google/gci2013/5897656958189568 [19:54:44] Make MediaWiki documentation translatable #39 [19:54:44] Status: NeedsReview (2 days, 22 hours left) [19:54:44] Mentor(s): Guillaume Paumier [19:56:50] qgil: have you got my message ? [19:56:53] cool ipv6 ip [19:56:56] :P [19:57:32] VladAndrew, probably not since I'm on the move and my connection comes and goes [19:57:56] VladAndrew, please claim the favicon task [19:58:23] Guys, be patient; don't you think us students get annoying to the mentors sometimes? LOL [19:58:23] qgil: I am waitting for more than a day for someone to accept this task https://www.google-melange.com/gci/task/view/google/gci2013/5897656958189568 so I can't claim the task [19:58:24] Make MediaWiki documentation translatable #39 [19:58:24] Status: NeedsReview (2 days, 22 hours left) [19:58:24] Mentor(s): Guillaume Paumier [19:58:27] (03PS2) 10Hashar: Improve TestUser group handling [core] - 10https://gerrit.wikimedia.org/r/99432 (owner: 10Anomie) [19:58:50] VladAndrew, ok, let me go step by step [19:59:40] (03CR) 10jenkins-bot: [V: 04-1] Improve TestUser group handling [core] - 10https://gerrit.wikimedia.org/r/99432 (owner: 10Anomie) [20:00:30] (03CR) 10Hashar: [C: 032] Improve TestUser group handling [core] - 10https://gerrit.wikimedia.org/r/99432 (owner: 10Anomie) [20:03:37] (03Merged) 10jenkins-bot: Improve TestUser group handling [core] - 10https://gerrit.wikimedia.org/r/99432 (owner: 10Anomie) [20:05:10] hi Bryan [20:05:14] ok mayankmadan VladAndrew , considering the exceptional situation and the good track that you both have shown resolving bugs beyond the strict GCI duties... I will consider your tasks closed because I'm not sure we can get them reviewed on time today. [20:05:35] qgil, thanks [20:05:39] VladAndrew, do you mind sharing the URL of the GCI task here, please? [20:05:49] oh, you did [20:05:51] qgil, i will definitely follow up on my review request [20:06:01] https://www.google-melange.com/gci/task/view/google/gci2013/5897656958189568 yes [20:06:02] Make MediaWiki documentation translatable #39 [20:06:02] Status: NeedsReview (2 days, 22 hours left) [20:06:02] Mentor(s): Guillaume Paumier [20:07:16] qgil, marked it complete [20:08:29] qgil: the icon task is alread claimed [20:09:09] i marked it complete [20:11:32] thank you very much [20:12:16] claimed this one http://www.google-melange.com/gci/task/view/google/gci2013/5804648166326272 [20:12:17] Add template data to two popular Wikipedia templates #18 [20:12:17] Status: ClaimRequested [20:12:17] Mentor(s): Guillaume Paumier [20:13:15] qgil: "I'm not sure we can get them reviewed on time today." does this mean that no task will be reviewed in the next 24 hours? I am asking mainly for the page migration tasks. [20:13:43] (03PS5) 10Physikerwelt: Add reference to the current user to the PageRenderingHash hook [core] - 10https://gerrit.wikimedia.org/r/105213 [20:13:58] (03CR) 10Siebrand: Fix logging (031 comment) [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/105444 (owner: 10Alex Monk) [20:15:08] (03PS1) 10Dereckson: L10n: gender aliases for user namespaces in French [core] - 10https://gerrit.wikimedia.org/r/105455 [20:16:07] (03CR) 10Dereckson: [C: 04-1] "Not the correct version." [core] - 10https://gerrit.wikimedia.org/r/105455 (owner: 10Dereckson) [20:18:33] (03PS2) 10Dereckson: L10n: gender aliases for user namespaces in French [core] - 10https://gerrit.wikimedia.org/r/105455 [20:19:39] qgil: the task is claimed [20:20:34] im aiming for 31 tasks, i have 29 closed task in melange another one just claimed(non coding) which i have completed and then im looking at another coding task [20:21:05] (03Abandoned) 10Hashar: Misc fixes for build/test scripts [tools/release] - 10https://gerrit.wikimedia.org/r/95575 (owner: 10MarkAHershberger) [20:21:28] VladAndrew, not anymore. The deadline had passed again. [20:21:49] (03CR) 10IAlex: [C: 032] L10n: gender aliases for user namespaces in French [core] - 10https://gerrit.wikimedia.org/r/105455 (owner: 10Dereckson) [20:21:58] claimed [20:22:24] VladAndrew, assigned [20:22:55] qgil, can you assign this one too :) http://www.google-melange.com/gci/task/view/google/gci2013/5804648166326272 [20:22:56] Add template data to two popular Wikipedia templates #18 [20:22:56] Status: ClaimRequested [20:22:56] Mentor(s): Guillaume Paumier [20:24:14] (03CR) 10Parent5446: Add CASCADINGSOURCES parser function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104999 (owner: 10Jackmcbarn) [20:25:12] (03Merged) 10jenkins-bot: L10n: gender aliases for user namespaces in French [core] - 10https://gerrit.wikimedia.org/r/105455 (owner: 10Dereckson) [20:25:38] (03CR) 10Jackmcbarn: Add CASCADINGSOURCES parser function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104999 (owner: 10Jackmcbarn) [20:26:14] qgil: could you assign this one to me too https://www.google-melange.com/gci/task/view/google/gci2013/5842071491444736 I have alread worked on it [20:26:14] Make MediaWiki documentation translatable #31 [20:26:14] Status: ClaimRequested [20:26:14] Mentor(s): Guillaume Paumier [20:28:06] (03PS2) 10Jackmcbarn: Prevent fatal error in Special:AbuseFilter/test [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105424 [20:28:19] Alright, and now I must leave. Good luck GCI students. :) [20:28:36] good bye and thanks [20:28:46] (03CR) 10Parent5446: Add Special:Diff as an internally-linkable redirect to diff pages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/63395 (owner: 10Jérémie Roquet) [20:29:40] (03CR) 10Parent5446: [C: 031] Add CASCADINGSOURCES parser function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104999 (owner: 10Jackmcbarn) [20:30:14] (03CR) 10Raylton P. Sousa: [C: 031] BookManagerv2: Invalidate navbar cache when JSON file changes Invalidate all constituent pages in a book when the JSON file changes. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/105441 (owner: 10Mayankmadan) [20:32:48] (03CR) 10Theopolisme: [C: 04-1] "This patch doesn't do what you say it does." [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/105441 (owner: 10Mayankmadan) [20:33:32] (03PS1) 10Umherirrender: Call Language::getLocalisationCache() static [core] - 10https://gerrit.wikimedia.org/r/105456 [20:34:29] (03CR) 10Legoktm: Add BagOStuff::setMulti for batch insertions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/101617 (owner: 10Legoktm) [20:35:47] (03CR) 10Legoktm: Prevent fatal error in Special:AbuseFilter/test (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105424 (owner: 10Jackmcbarn) [20:37:51] (03CR) 10Parent5446: Give warning on account creation when user name is adjusted silently (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender) [20:39:18] (03PS1) 10Gerrit Patch Uploader: Escape messages in feedback.js [core] - 10https://gerrit.wikimedia.org/r/105457 [20:39:19] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/105457 (owner: 10Gerrit Patch Uploader) [20:45:37] (03CR) 10Legoktm: Fix logging (031 comment) [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/105444 (owner: 10Alex Monk) [20:50:42] (03PS5) 10Umherirrender: Give warning on account creation when user name is adjusted silently [core] - 10https://gerrit.wikimedia.org/r/104926 [20:52:04] (03CR) 10Umherirrender: "Patch Set 5: Use Status::isOk()" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender) [20:57:47] Nemo_bis, please mark https://www.mediawiki.org/wiki/MediaWiki_1.18 for translation ;) [21:00:39] GEOFBOT: [[/FAQ relative link is no good, please make it explicit [21:03:23] (03PS1) 10Umherirrender: Remove extra parenthesis on where conditions [core] - 10https://gerrit.wikimedia.org/r/105458 [21:09:18] Nemo_bis: like this? [21:09:19] MediaWiki 1.18/FAQ [21:10:10] GEOFBOT: yes, next time better with a special:Mylanguage/TITLE syntax [21:10:52] Nemo_bis: ok, fixed it [21:11:46] GEOFBOT: yep, saw; remember the templates https://www.mediawiki.org/w/index.php?title=MediaWiki_1.18&diff=875836&oldid=875834 [21:25:34] Nemo_bis: I accidentally included an image syntax in the translate tags, i changed it to only include the caption [21:25:40] could you mark the new rev? ty [21:34:26] GEOFBOT: well that's not necessarily incorrect, you may want to let translators pick a localised image etc.; but ok [22:12:34] Oh noes. My Toolserver account expires in seven days. [22:12:35] ;) [22:26:53] (03CR) 10Parent5446: Give warning on account creation when user name is adjusted silently (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender) [22:27:23] (03CR) 10Parent5446: [C: 031] "Haven't tested" [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender) [22:28:21] (03CR) 10Parent5446: [C: 032] Remove extra parenthesis on where conditions [core] - 10https://gerrit.wikimedia.org/r/105458 (owner: 10Umherirrender) [22:31:38] (03Merged) 10jenkins-bot: Remove extra parenthesis on where conditions [core] - 10https://gerrit.wikimedia.org/r/105458 (owner: 10Umherirrender) [22:41:35] (03PS1) 10Physikerwelt: Workload generator for MathQueryCompetition [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/105464 [22:55:41] (03Abandoned) 10Mayankmadan: Adding Gender support to Mediawiki:Blockip [core] - 10https://gerrit.wikimedia.org/r/103353 (owner: 10Mayankmadan) [23:04:14] (03PS2) 10Physikerwelt: Workload generator for MathQueryCompetition [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/105464 [23:04:52] (03CR) 10Physikerwelt: [C: 032 V: 032] Workload generator for MathQueryCompetition [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/105464 (owner: 10Physikerwelt) [23:23:35] Nemo_bis: is this enough translation units to be eligible? [23:23:35] http://www.google-melange.com/gci/task/view/google/gci2013/5880044371050496 [23:23:36] Make MediaWiki documentation translatable #29 [23:23:36] Status: Claimed (3 days, 1 hours left) [23:23:36] Mentor(s): Guillaume Paumier [23:28:47] GEOFBOT: yes, looks so [23:29:06] you can already start working on the next page(s), we're not going to run out of tasks to assign you [23:29:42] if you want, that is, of course :) [23:31:06] or if you'd like to learn something new http://www.google-melange.com/gci/task/view/google/gci2013/5831472116137984 :) [23:31:07] Nemo_bis, I can't review this task, sorry. [23:31:22] don't be sorry my dear [23:37:33] (03PS1) 10Physikerwelt: latexml rendering setting are overwritten by default values [extensions/Math] (LaTeXML) - 10https://gerrit.wikimedia.org/r/105466 [23:37:42] (03CR) 10jenkins-bot: [V: 04-1] latexml rendering setting are overwritten by default values [extensions/Math] (LaTeXML) - 10https://gerrit.wikimedia.org/r/105466 (owner: 10Physikerwelt) [23:41:48] gcibot can review? [23:41:52] what is this madness! [23:46:18] (03PS1) 10Anomie: Properly peform deletion updates when moving over a redirect [core] - 10https://gerrit.wikimedia.org/r/105467