[00:01:41] (03Merged) 10jenkins-bot: Declare visibility for class properties in MySQLMasterPos [core] - 10https://gerrit.wikimedia.org/r/103878 (owner: 10Siebrand) [00:03:42] (03CR) 10Anomie: [C: 04-1] "I think this needs more investigation, chances are that someone thought there was a reason to avoid calling verifyUpload since they specif" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/105111 (owner: 10Mayankmadan) [00:03:48] (03PS1) 10EBernhardson: Utilize BufferedCache in TreeRepository [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105118 [00:07:22] (03CR) 10Tychay: [C: 032 V: 032] "It just adds a hook. It should be clean since hooks are out of band and can be overridden if downstream." [wikimedia/communications/WP-Victor] - 10https://gerrit.wikimedia.org/r/29831 (owner: 10Guillom) [00:07:57] (03CR) 10Mayankmadan: getApiWarnings() throws an exception if upload is invalid (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105111 (owner: 10Mayankmadan) [00:08:09] We really need to get purges for templates working again [00:08:40] HectorAE: what's not working about them? [00:13:42] (03CR) 10Mattflaschen: [C: 04-1] "It looks mostly good. I have a couple suggestions inline." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/105104 (owner: 10Gerrit Patch Uploader) [00:24:32] (03CR) 10Mattflaschen: [C: 04-1] "Thanks for getting the ball rolling on this. It looks generally good. I think the button classes need to be configurable for HTMLForm. B" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/104011 (owner: 10Spage) [00:26:05] (03CR) 10EBernhardson: [C: 032] Improve code to update related revision tables (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104939 (owner: 10Matthias Mullie) [00:26:42] (03Merged) 10jenkins-bot: Improve code to update related revision tables [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104939 (owner: 10Matthias Mullie) [00:27:05] (03CR) 10EBernhardson: [C: 032] When executing an action on a post, just replace the .flow-post, not the whole .flow-post-container. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104910 (owner: 10Werdna) [00:27:46] (03Merged) 10jenkins-bot: When executing an action on a post, just replace the .flow-post, not the whole .flow-post-container. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104910 (owner: 10Werdna) [00:36:33] (03CR) 10Parent5446: getApiWarnings() throws an exception if upload is invalid (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105111 (owner: 10Mayankmadan) [00:37:13] "This change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset." [00:37:20] How would I go about doing this? [00:37:39] !rebase [00:37:39] http://learn.github.com/p/rebasing.html [00:37:57] (hey, i didn't even know we have a bang-coide for that. :) ) [00:38:07] (03CR) 10Fomafix: mw.notify() with message type and predefined styles (034 comments) [core] - 10https://gerrit.wikimedia.org/r/105104 (owner: 10Gerrit Patch Uploader) [00:38:08] jcf2000: there's also a little guide somewhere on mw.org [00:38:23] hmph, that link is actually dead. :/ [00:39:15] (03CR) 10Swalling: [C: 04-1] "Agree with Bartosz. This should be a warning, not an error, since the user is not prevented from signing up." [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender) [00:39:21] jcf2000: https://www.mediawiki.org/wiki/Gerrit/Advanced_usage#Build_failed_due_to_merge_conflict [00:39:26] !rebase del [00:39:26] Successfully removed rebase [00:39:55] !rebase is Rebase to fix merge conflicts: https://www.mediawiki.org/wiki/Gerrit/Advanced_usage#Build_failed_due_to_merge_conflict / Interactive rebase: https://www.mediawiki.org/wiki/Git/Rebase [00:39:56] Key was added [00:40:36] jcf2000: poke me if you run into any troubles. what changeset is this about? [00:41:03] jcf2000: (also, this is unlikely, but we have a bug where changes are sometimes mistakenly marked as causing conflicts when in fact they merge just fine.) [00:41:34] (03PS7) 10Ori.livneh: Added per-node sequential ID method and made SquidUpdate use it [core] - 10https://gerrit.wikimedia.org/r/103619 (owner: 10Aaron Schulz) [00:41:35] MatmaRex: Thanks :) [00:45:14] (03PS3) 10EBernhardson: Simplify edit-title template [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103069 [00:45:16] (03CR) 10jenkins-bot: [V: 04-1] Simplify edit-title template [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103069 (owner: 10EBernhardson) [00:46:34] AaronSchulz: any reason I shouldn't merge https://gerrit.wikimedia.org/r/#/c/103619/ ? [00:46:34] (03CR) 10Parent5446: [C: 032] Random documentation tweaks [core] - 10https://gerrit.wikimedia.org/r/104527 (owner: 10Siebrand) [00:46:58] (03PS7) 10EBernhardson: [WIP] Auto-wrapping escaper for templates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103317 [00:47:02] ori: you just rebased it? Go ahead [00:47:18] (03PS4) 10EBernhardson: Simplify edit-title template [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103069 [00:47:19] git show HEAD [00:47:22] oops :p [00:48:07] MatmaRex: Sorry, I'm still learning how to use Git. I just got this message: [00:48:07] The copy of the patch that failed is found in: "c:/wamp/www/core/extensions/MobileFrontend/.git/rebase-apply/patch" When you have resolved this problem, run "git rebase --continue". [00:48:59] (03PS3) 10EBernhardson: Simplify edit-post template [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103071 [00:49:04] (03PS1) 10Aaron Schulz: Removed the live hack patch; unneeded [tools/release] - 10https://gerrit.wikimedia.org/r/105121 [00:49:07] jcf2000: yeah, this is okay. what does `git status` output? it should tell you which files need conflict resolution [00:49:46] jcf2000: when you open these files, you'll see markers like <<<<<, =====, >>>>> – these mark parts of code which were in your patch and which are on current master version [00:50:31] (03Merged) 10jenkins-bot: Random documentation tweaks [core] - 10https://gerrit.wikimedia.org/r/104527 (owner: 10Siebrand) [00:50:34] Okay. This is my output http://pastebin.com/RNtkeqsT [00:50:54] So I just look in those files? [00:50:55] (03PS4) 10EBernhardson: Simplify header and edit-header templates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103064 [00:50:59] jcf2000: you can also use a "merge tool" to resolve them if it's not obvious what to do – it will show your version, master version and "base version" (the latest commit that looked the same in both versions) [00:51:26] `git mergetool`, but you'll probably need to install some tools for this, and it's probably easier to do it by hand [00:51:40] jcf2000: yeah, look at the files under "Unmerged paths" [00:52:14] MatmaRex: For future reference, where can I find a merge tool? [00:52:18] jcf2000: (i'm downloading the mobilefrontend repo myself now, i'll see what happened in these files myself too :) ) [00:53:11] jcf2000: git supports like 20 different ones :) personally i recommend meld [00:53:32] http://meldmerge.org/ [00:53:35] MatmaRex: Okay thanks, I'll look that up :) [00:53:58] (03CR) 10Ori.livneh: [C: 032] Added per-node sequential ID method and made SquidUpdate use it [core] - 10https://gerrit.wikimedia.org/r/103619 (owner: 10Aaron Schulz) [00:54:08] once you have it installed, run `git config --global merge.tool meld` to tell git to use it, and that should be it - `git mergetool` should launch meld the next time you use it [00:55:47] (if it doesn't work, you might need to provide the path to the meld executable – `git config --global mergetool.meld.path '/whatever/path/to/meld'`) [00:56:37] (03PS1) 10Jackmcbarn: Don't convert bad curids to the Main Page [core] - 10https://gerrit.wikimedia.org/r/105122 [00:57:37] (03PS1) 10Bsitu: Fix issues on clicking "x comments" link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105123 [00:57:41] (03Merged) 10jenkins-bot: Added per-node sequential ID method and made SquidUpdate use it [core] - 10https://gerrit.wikimedia.org/r/103619 (owner: 10Aaron Schulz) [00:59:15] (03PS2) 10Bsitu: Fix issues on clicking "x comments" link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105123 [00:59:44] (03CR) 10Aaron Schulz: [C: 032] Removed the live hack patch; unneeded [tools/release] - 10https://gerrit.wikimedia.org/r/105121 (owner: 10Aaron Schulz) [00:59:48] (03Merged) 10jenkins-bot: Removed the live hack patch; unneeded [tools/release] - 10https://gerrit.wikimedia.org/r/105121 (owner: 10Aaron Schulz) [01:05:08] MatmaRex: Just ran git mergetool, and got this message "The merge tool meld is not available as 'meld'" [01:05:16] I'm running it from cmd in Windows [01:07:16] Oh I just saw your latter message, I'll try that first [01:09:01] (03PS1) 10Reedy: Fix Hebrew magic words, missing leading and trailing __ [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/105125 [01:09:27] oh, on windows too. then we might need to fiddle with it a bit, but i'm on windows myself and managed to get it to worrk [01:10:29] (03CR) 10Parent5446: Don't convert bad curids to the Main Page (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105122 (owner: 10Jackmcbarn) [01:10:42] jcf2000: my own 'mergetool.meld.path' config is '/f/Tools/meld-1.6.0/bin/meld' – you'll probably need to use "/f/" instead of "F:" and forward-slashes too for it to work [01:10:54] (03PS1) 10Ori.livneh: Add global function to serialize a value to MessagePack [core] - 10https://gerrit.wikimedia.org/r/105126 [01:11:07] (of course the path will probably be different) [01:12:06] ^ AaronSchulz that one's for you [01:12:35] (03CR) 10Reedy: [C: 032] Fix Hebrew magic words, missing leading and trailing __ [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/105125 (owner: 10Reedy) [01:12:36] (03CR) 10Jackmcbarn: Don't convert bad curids to the Main Page (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105122 (owner: 10Jackmcbarn) [01:12:40] (03PS1) 10Reedy: Fix Hebrew magic words, missing leading and trailing __ [extensions/Disambiguator] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/105127 [01:12:46] (03PS1) 10Reedy: Fix Hebrew magic words, missing leading and trailing __ [extensions/Disambiguator] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105128 [01:12:47] (03Merged) 10jenkins-bot: Fix Hebrew magic words, missing leading and trailing __ [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/105125 (owner: 10Reedy) [01:13:42] (03CR) 10Reedy: [C: 032] Fix Hebrew magic words, missing leading and trailing __ [extensions/Disambiguator] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/105127 (owner: 10Reedy) [01:13:44] (03Merged) 10jenkins-bot: Fix Hebrew magic words, missing leading and trailing __ [extensions/Disambiguator] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/105127 (owner: 10Reedy) [01:13:49] (03CR) 10Reedy: [C: 032] Fix Hebrew magic words, missing leading and trailing __ [extensions/Disambiguator] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105128 (owner: 10Reedy) [01:13:50] (03CR) 10TTO: [C: 031] "I would have liked something better than the pithy "Bad title" error, but I can't think of anything better to show..." [core] - 10https://gerrit.wikimedia.org/r/105122 (owner: 10Jackmcbarn) [01:13:51] (03Merged) 10jenkins-bot: Fix Hebrew magic words, missing leading and trailing __ [extensions/Disambiguator] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105128 (owner: 10Reedy) [01:14:36] (03PS2) 10Aaron Schulz: Add global function to serialize a value to MessagePack [core] - 10https://gerrit.wikimedia.org/r/105126 (owner: 10Ori.livneh) [01:14:47] MatmaRex: I've gotten meld to run... But unfortunately there is another problem now. [01:14:50] Here's my log [01:14:52] http://pastebin.com/YahLDUKZ [01:15:04] ori: can you put that in a utils/ or libs/ class? [01:15:35] AaronSchulz: sure [01:15:47] (03CR) 10Ori.livneh: [C: 04-1] " ori: can you put that in a utils/ or libs/ class? (yes)" [core] - 10https://gerrit.wikimedia.org/r/105126 (owner: 10Ori.livneh) [01:16:34] jcf2000: huh, i've never encountered this. interesting [01:17:21] MatmaRex: I'm also running python27. Might their be an issue there? [01:17:25] there* [01:17:29] (03PS1) 10Reedy: Update Disambiguator to deployment branch head [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/105129 [01:17:36] jcf2000: i'm on 2.7,3 myself and it works [01:18:24] (03CR) 10Swalling: [C: 04-1] "I would really recommend against using these Crystal icons. They're free/open which is great, but this large, glossy style is out of sync " [core] - 10https://gerrit.wikimedia.org/r/105104 (owner: 10Gerrit Patch Uploader) [01:18:24] jcf2000: hmm, i assume you downloaded the latest meld, 1.8.3? mine is actually 1.6.0 [01:18:30] (03PS1) 10Reedy: Update Disambiguator to deployment branch head [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105130 [01:18:37] jcf2000: let me see if i can reproduce this error on meld 1.8.3 [01:18:37] Yeah [01:18:59] (03CR) 10Reedy: [C: 032 V: 032] Update Disambiguator to deployment branch head [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105130 (owner: 10Reedy) [01:19:06] (03CR) 10Reedy: [C: 032 V: 032] Update Disambiguator to deployment branch head [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/105129 (owner: 10Reedy) [01:21:48] jcf2000: hmm, 1.8.3 works for me as well :/ [01:22:20] jcf2000: what is your path to meld, again? `git config --global mergetool.meld.path` [01:22:48] i've found http://stackoverflow.com/questions/1940578/windowserror-error-126-the-specified-module-could-not-be-found which suggests that this might be caused by backslashes instead of slashes in paths… doesn't look very relevant, but worth checking [01:25:26] jcf2000: and if this fails, then i guess we can just fix the code not to throw errors, since it looks that (luckily) the code that causes the exception can be safely not ran instead :) [01:27:46] (03PS1) 10Aude: Fix SearchEngineTest when $wgSearchType is set to non-default [core] - 10https://gerrit.wikimedia.org/r/105131 [01:36:49] jcf2000: you still there? [01:44:29] jcf2000: if you are still there, i submitted a meld bug about this (and a patch): https://bugzilla.gnome.org/show_bug.cgi?id=721370 [01:44:40] MatmaRex: Yeah sorry, had to take a little break [01:45:54] MatmaRex: I believe the backslash is very relevant in my case, thank you [01:46:15] (03CR) 10Bsitu: [C: 032] Utilize BufferedCache in TreeRepository [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105118 (owner: 10EBernhardson) [01:46:29] MatmaRex: This was my path C:\Program Files (x86)\Meld\meld\bin, changing to /c/Program Files (x86)/Meld/meld/bin/meld [01:46:48] (03Merged) 10jenkins-bot: Utilize BufferedCache in TreeRepository [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105118 (owner: 10EBernhardson) [01:48:52] MatmaRex: Tried changing the path, still no luck [01:49:16] MatmaRex: I'll go ahead and apply the patch to my installation [01:50:54] (03PS3) 10Ori.livneh: Add class implementing MessagePack serialization [core] - 10https://gerrit.wikimedia.org/r/105126 [01:52:12] ^ AaronSchulz [01:53:57] so why not /libs, just curious? [01:56:16] AaronSchulz: it's not exactly an external lib, since I modified it extensively [01:56:24] but I don't mind putting it there if you think it's more appropriate [01:57:02] /libs can be things we want to be "out there for use" afaik [01:57:09] also you can add @since while at it [01:59:50] ori: utils is fine though [02:02:00] MatmaRex: Still throwing an error http://pastebin.com/8a2ibpjn [02:02:03] (03PS4) 10Ori.livneh: Add class implementing MessagePack serialization [core] - 10https://gerrit.wikimedia.org/r/105126 [02:02:10] (03PS2) 10Aude: Fix SearchEngineTest when $wgSearchType is set to non-default [core] - 10https://gerrit.wikimedia.org/r/105131 [02:02:32] AaronSchulz: moved it to libs and renamed it MWMessagePack to avoid conflicts with other implementations [02:03:03] https://gerrit.wikimedia.org/r/#/c/105126/4/includes/AutoLoader.php [02:03:07] jcf2000: oh. that would look like you don't have pygtk installed [02:03:08] that's in the wrong section [02:03:18] though it won't cause any errors [02:03:19] but this can be easily solved at least :) run `pip install pygtk` [02:03:28] AaronSchulz: d'oh. sec. [02:04:06] jcf2000: or if you don't have pip installed, either, install it first: https://sites.google.com/site/pydatalog/python/pip-for-windows [02:04:17] (pip is a package installer for python) [02:04:39] (03PS5) 10Ori.livneh: Add class implementing MessagePack serialization [core] - 10https://gerrit.wikimedia.org/r/105126 [02:04:48] AaronSchulz: I noticed I put RunningStat in the wrong section too, so I piggy-backed that onto this change [02:06:22] (03CR) 10Aaron Schulz: [C: 032] Add class implementing MessagePack serialization [core] - 10https://gerrit.wikimedia.org/r/105126 (owner: 10Ori.livneh) [02:06:28] MatmaRex: Thanks :) Luckily I do have pip installed already [02:06:56] (03PS7) 10Bartosz Dziewoński: Create ChangesListSpecialPage as a base class for Watchlist and RC [core] - 10https://gerrit.wikimedia.org/r/102458 [02:06:57] (03PS4) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement execute() [core] - 10https://gerrit.wikimedia.org/r/103240 [02:06:58] (03PS7) 10Bartosz Dziewoński: SpecialWatchlist: Don't overwrite context now that we don't have to [core] - 10https://gerrit.wikimedia.org/r/94289 [02:06:59] (03PS9) 10Bartosz Dziewoński: SpecialWatchlist: Use FormOptions for parameter handling [core] - 10https://gerrit.wikimedia.org/r/94288 [02:07:00] (03PS7) 10Bartosz Dziewoński: SpecialWatchlist: Synchronise some code with newer versions from RC [core] - 10https://gerrit.wikimedia.org/r/94628 [02:07:01] (03PS3) 10Bartosz Dziewoński: Change behavior of Special:Watchlist when user's watchlist is empty [core] - 10https://gerrit.wikimedia.org/r/103233 [02:07:02] (03PS7) 10Bartosz Dziewoński: SpecialWatchlist: Reorder some stuff in #execute [core] - 10https://gerrit.wikimedia.org/r/94627 [02:07:03] (03PS3) 10Bartosz Dziewoński: ChangesListSpecialPage and subclasses: Reorder functions [core] - 10https://gerrit.wikimedia.org/r/103200 [02:07:04] (03PS2) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/103546 [02:07:05] (03PS3) 10Bartosz Dziewoński: No longer display the number of rows shown on Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/103239 [02:07:06] (03PS6) 10Bartosz Dziewoński: Always load 'mediawiki.special.changeslist' on SpecialRecentChanges and subclasses [core] - 10https://gerrit.wikimedia.org/r/97451 [02:07:07] (03PS4) 10Bartosz Dziewoński: Changes list legend modules cleanup [core] - 10https://gerrit.wikimedia.org/r/103197 [02:07:08] (03PS8) 10Bartosz Dziewoński: SpecialWatchlist: JS enhancements to namespace selector (like RC) [core] - 10https://gerrit.wikimedia.org/r/94617 [02:07:09] (03PS13) 10Bartosz Dziewoński: Rename Watchlist request parameters for consistency with RC's ones [core] - 10https://gerrit.wikimedia.org/r/89380 [02:07:10] (03PS7) 10Bartosz Dziewoński: SpecialWatchlist: Split #execute into subfunctions like SpecialRecentChanges [core] - 10https://gerrit.wikimedia.org/r/94677 [02:07:11] (03PS1) 10Jackmcbarn: Prevent selection of "Jump to" text [core] - 10https://gerrit.wikimedia.org/r/105133 [02:07:17] sorry about the spam, everyone. that was a big rebase. [02:07:36] :Q [02:07:39] (03CR) 10Bartosz Dziewoński: "Siebrand, can you reply and possibly reconsider/confirm the -1?" [core] - 10https://gerrit.wikimedia.org/r/103239 (owner: 10Bartosz Dziewoński) [02:08:31] (03CR) 10Bartosz Dziewoński: "Rebased." [core] - 10https://gerrit.wikimedia.org/r/103546 (owner: 10Bartosz Dziewoński) [02:13:42] (03Merged) 10jenkins-bot: Add class implementing MessagePack serialization [core] - 10https://gerrit.wikimedia.org/r/105126 (owner: 10Ori.livneh) [02:14:18] jcf2000: i will be leaving in a few minutes, if you need anything else, please tell me now :) [02:14:47] jcf2000: i can rebase that patch for you if you need it now (i assume it's GCI stuff), unless of course you want to play with it yourself :) [02:16:25] MatmaRex: Thanks for the offer :) I'd like to play with it for a bit though [02:17:15] (03CR) 10Ori.livneh: [C: 032] Add user-agent logging for server-side events [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/104040 (owner: 10Nuria) [02:25:11] (03Draft1) 10Legoktm: Add ZeroMQFeedEngine [core] - 10https://gerrit.wikimedia.org/r/105117 [02:25:16] ori: ^ [02:25:18] (03Merged) 10jenkins-bot: Add user-agent logging for server-side events [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/104040 (owner: 10Nuria) [02:25:47] MatmaRex: I [02:26:22] I've tried installing pygtk with pip install pygtk, but it's throwing this error [02:26:26] ERROR: Could not import dsextras module: Make sure you have installed pygobject [02:27:10] well, maybe you need more pip modules? [02:27:19] legoktm: GPL header [02:27:34] :| [02:27:45] (03CR) 10jenkins-bot: [V: 04-1] ChangesListSpecialPage: Implement buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/103546 (owner: 10Bartosz Dziewoński) [02:27:50] well, I tried installing the pygtk module it's missing, and it also throws an error [02:28:07] Reedy: nothing else in that directory has headers, so they can be added in a follow-up commit if someone really cares [02:28:27] jcf2000: here's a list of modules i have installed: http://pastebin.com/XnKCKP6q - not all are necessary for meld [02:28:28] Doesn't make it right ;) [02:28:45] jcf2000: do you have several python versions installed? [02:29:02] jcf2000: `pip` and `python` could refer to different ones if you do [02:29:40] jcf2000: (also, it really might be easier to resolve the conflict by hand, in a regular text editor - just look for the markers i mentioned earlier) [02:30:26] jcf2000, you can use the command 'which python' to disambiguate if you're on a Unixoid system [02:38:59] (03PS2) 10Legoktm: Add ZeroMQFeedEngine [core] - 10https://gerrit.wikimedia.org/r/105117 [02:39:41] (03CR) 10jenkins-bot: [V: 04-1] Add ZeroMQFeedEngine [core] - 10https://gerrit.wikimedia.org/r/105117 (owner: 10Legoktm) [02:39:43] (03PS2) 10Spage: Clean up meaningless "post body" language [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102594 [02:40:31] ok, i'm disappearing. good night [02:43:18] (03CR) 10Mattflaschen: [C: 04-1] "After thinking about this, I'm more hesitant." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender) [02:46:00] (03PS3) 10Legoktm: Add ZeroMQFeedEngine [core] - 10https://gerrit.wikimedia.org/r/105117 [02:46:05] I've finally managed to rebase the changes, but the second test ran by the jenkins bot failed https://gerrit.wikimedia.org/r/#/c/104324/ [02:49:10] (03PS3) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/103546 [03:04:33] (03CR) 10Mattflaschen: "Yeah, the Beta feature format (particularly the screenshot) could be useful to certain core preferences (e.g. skin, maybe thumbnail sizes)" [core] - 10https://gerrit.wikimedia.org/r/75143 (owner: 10MarkTraceur) [03:15:07] On my patchset https://gerrit.wikimedia.org/r/#/c/104324/, the Jenkins bot is failing the build because of this error http://pastebin.com/TLTNsSee [03:15:55] I would remove the unused variables mentioned in the console log, but I'm afraid I might remove something used in other files when it's imported [03:36:19] (03PS1) 10Skizzerz: Add in preliminary MS SQL support [core] - 10https://gerrit.wikimedia.org/r/105138 [03:38:28] (03CR) 10Skizzerz: "Looking for initial feedback, there are a couple of things missing from patch set 1 that I'll still need to do before this can really be m" [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz) [03:38:54] (03CR) 10jenkins-bot: [V: 04-1] Add in preliminary MS SQL support [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz) [03:45:09] (03PS2) 10Skizzerz: Add in preliminary MS SQL support [core] - 10https://gerrit.wikimedia.org/r/105138 [03:58:56] (03CR) 10Parent5446: Add in preliminary MS SQL support (034 comments) [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz) [04:13:50] (03CR) 10Parent5446: Don't convert bad curids to the Main Page (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105122 (owner: 10Jackmcbarn) [04:14:52] Hello. [04:16:19] (03CR) 10Parent5446: Fix SearchEngineTest when $wgSearchType is set to non-default (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105131 (owner: 10Aude) [04:16:35] (03CR) 10Skizzerz: Add in preliminary MS SQL support (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105138 (owner: 10Skizzerz) [04:18:55] (03CR) 10Parent5446: [C: 031] Prevent selection of "Jump to" text [core] - 10https://gerrit.wikimedia.org/r/105133 (owner: 10Jackmcbarn) [04:22:10] (03CR) 10Jackmcbarn: Don't convert bad curids to the Main Page (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105122 (owner: 10Jackmcbarn) [04:29:05] (03CR) 10Parent5446: "Yay! Finally a ZeroMQ client." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/105117 (owner: 10Legoktm) [04:30:33] (03CR) 10Parent5446: [C: 031] Don't convert bad curids to the Main Page (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105122 (owner: 10Jackmcbarn) [04:36:06] hello yurik online? [04:43:05] (03CR) 10Parent5446: Add class implementing MessagePack serialization (034 comments) [core] - 10https://gerrit.wikimedia.org/r/105126 (owner: 10Ori.livneh) [04:46:03] (03CR) 10Legoktm: Add ZeroMQFeedEngine (034 comments) [core] - 10https://gerrit.wikimedia.org/r/105117 (owner: 10Legoktm) [04:47:00] (03PS4) 10Legoktm: Add ZeroMQFeedEngine [core] - 10https://gerrit.wikimedia.org/r/105117 [04:50:14] (03PS1) 10Aaron Schulz: Removed unused postConnectionBackoff() from LoadMonitor [core] - 10https://gerrit.wikimedia.org/r/105140 [04:50:40] (03CR) 10Legoktm: Add ZeroMQFeedEngine (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105117 (owner: 10Legoktm) [04:50:46] (03CR) 10Parent5446: Add ZeroMQFeedEngine (033 comments) [core] - 10https://gerrit.wikimedia.org/r/105117 (owner: 10Legoktm) [04:53:19] (03PS1) 10TTO: Bring PageNotice extension into the modern era [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105141 [04:53:20] (03PS1) 10TTO: Add CSS file to provide a margin below/above each notice [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105142 [04:53:21] (03PS1) 10TTO: Allow per-page notice functionality to be disabled [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105143 [04:55:22] (03CR) 10TTO: "Anyone?" [core] - 10https://gerrit.wikimedia.org/r/84197 (owner: 10TTO) [04:58:17] (03CR) 10Legoktm: [C: 04-1] Bring PageNotice extension into the modern era (035 comments) [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105141 (owner: 10TTO) [04:59:50] (03CR) 10Legoktm: [C: 04-1] "The stylesheet only needs to be loaded if a pagenotice exists, so you can just do it in the existing hook function where you already have " [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105142 (owner: 10TTO) [05:01:46] diwanship, hi! happy new year! [05:01:52] i'm back :) [05:02:20] yurik Happy New year to u too!!!! [05:02:33] thanks :) [05:03:35] yurik Did you see the my monthly report? [05:04:01] looking through the codeacademy now, will take a look at the report in a sec [05:04:24] ya sure also pls review the lesson plan [05:05:47] (03CR) 10Legoktm: [C: 032 V: 032] Replace usage of deprecated Title::escapeLocalURL() [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/104360 (owner: 10Siebrand) [05:06:00] (03CR) 10Legoktm: [C: 032 V: 032] Replace deprecated SpecialPage::getPage() [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/104387 (owner: 10Siebrand) [05:09:38] diwanship, i see the internship report, but do you have a lesson plan anywhere? [05:09:56] oh, its not on the wiki [05:09:58] i see [05:10:29] https://docs.google.com/document/d/1vLsowCkFqROERAluweKDji0TSM2KJmCm2FwbEZPNpHE/edit this is d link [05:10:46] yes, already found it as part of your report [05:11:57] (03PS2) 1001tonythomas: Removed visibility status of "Notes" section to 'publicly viewable' [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104761 [05:12:02] (03CR) 10Legoktm: [C: 032] Replace usage of deprecated Title::escapeLocalURL() [extensions/skins] - 10https://gerrit.wikimedia.org/r/104356 (owner: 10Siebrand) [05:12:04] (03Merged) 10jenkins-bot: Replace usage of deprecated Title::escapeLocalURL() [extensions/skins] - 10https://gerrit.wikimedia.org/r/104356 (owner: 10Siebrand) [05:14:02] (03PS2) 10TTO: Add CSS file to provide a margin below/above each notice [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105142 [05:14:03] (03PS2) 10TTO: Allow per-page notice functionality to be disabled [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105143 [05:14:04] (03PS2) 10TTO: Bring PageNotice extension into the modern era [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105141 [05:14:32] (03CR) 10Legoktm: [C: 032 V: 032] "I don't think this extension even works, but does no harm." [extensions/LogEntry] - 10https://gerrit.wikimedia.org/r/104354 (owner: 10Siebrand) [05:15:54] (03CR) 10TTO: "By the way, I did actually mean to add you, Legoktm, as a reviewer. But I added Krinkle instead! I must have got confused by Alex's IRC ni" [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105142 (owner: 10TTO) [05:18:24] (03CR) 10Legoktm: [C: 032 V: 032] Replace usage of deprecated Title::escapeLocalURL() [extensions/Comments] - 10https://gerrit.wikimedia.org/r/104347 (owner: 10Siebrand) [05:19:01] (03CR) 10Legoktm: [C: 032] Replace usage of deprecated Title::escapeLocalURL() [extensions/Editcount] - 10https://gerrit.wikimedia.org/r/104350 (owner: 10Siebrand) [05:19:04] (03Merged) 10jenkins-bot: Replace usage of deprecated Title::escapeLocalURL() [extensions/Editcount] - 10https://gerrit.wikimedia.org/r/104350 (owner: 10Siebrand) [05:22:11] (03PS1) 10Bsitu: Bathc loading workflows for history link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105144 [05:23:50] (03PS2) 10Bsitu: Batch loading workflows for history links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105144 [05:24:42] (03PS3) 10Legoktm: Give links to a user's suppressed edits on Special:Contribs [core] - 10https://gerrit.wikimedia.org/r/104711 [05:25:27] (03CR) 10Legoktm: "Changed link text to 'suppressed user contributions' per Siebrand's comment." [core] - 10https://gerrit.wikimedia.org/r/104711 (owner: 10Legoktm) [05:38:02] yurik while querying do we need to show the result in HTML? [05:43:51] marktraceur: Hi! working on https://bugzilla.wikimedia.org/show_bug.cgi?id=56402 ,is the blackdrop created by the class mlb-overlay ? [05:44:17] marktraceur: I tried adding the click handler to the mlb-overlay, but it didn't work out [05:51:45] (03CR) 10Krinkle: "Question remains ted same: How would a non-int ctypedigit-like value end up in our cache? And how does that make RL more forgiving for env" [core] - 10https://gerrit.wikimedia.org/r/103407 (owner: 10Dr0ptp4kt) [05:53:53] (03CR) 10Ori.livneh: Add class implementing MessagePack serialization (033 comments) [core] - 10https://gerrit.wikimedia.org/r/105126 (owner: 10Ori.livneh) [05:55:51] tonythomas01: No, use ui.$imageDiv instea [05:55:52] d [05:59:26] (03PS1) 10Ori.livneh: MWMessagePack: throw MWExceptions; detect associative arrays without copying [core] - 10https://gerrit.wikimedia.org/r/105145 [06:00:35] (03CR) 10jenkins-bot: [V: 04-1] MWMessagePack: throw MWExceptions; detect associative arrays without copying [core] - 10https://gerrit.wikimedia.org/r/105145 (owner: 10Ori.livneh) [06:01:18] (03CR) 10Krinkle: "I'd keep the array in the function, if code needs to read or write this array, it should use the hook. I'd rather not have this array acce" [core] - 10https://gerrit.wikimedia.org/r/102344 (owner: 10Dr0ptp4kt) [06:04:33] (03CR) 10Krinkle: "Also, the new method allows one to provide a the version parameter. W of the new method, when would that be used and why? Can you add @pa" [core] - 10https://gerrit.wikimedia.org/r/102344 (owner: 10Dr0ptp4kt) [06:05:51] (03CR) 10Parent5446: Add class implementing MessagePack serialization (032 comments) [core] - 10https://gerrit.wikimedia.org/r/105126 (owner: 10Ori.livneh) [06:07:14] marktraceur: but, when I add the click handler to the $imageDiv, as I have uploaded in the https://gerrit.wikimedia.org/r/#/c/103902/ ,you would've seen the interface close, even if the click in on the image [06:07:15] (03PS1) 10Ori.livneh: Move RunningStat from profiler/ to utils/ [core] - 10https://gerrit.wikimedia.org/r/105146 [06:07:46] (03CR) 10Parent5446: MWMessagePack: throw MWExceptions; detect associative arrays without copying (032 comments) [core] - 10https://gerrit.wikimedia.org/r/105145 (owner: 10Ori.livneh) [06:09:31] (03CR) 10Parent5446: "You may want to move it to includes/libs instead, since RunningStat does not have any dependency on MediaWiki and can be taken out and use" [core] - 10https://gerrit.wikimedia.org/r/105146 (owner: 10Ori.livneh) [06:20:38] tonythomas01: You can also add a click handler to the image that stops propagation [06:21:11] marktraceur: image that stops propogation ? I didn''t get you [06:23:40] (03PS16) 10Santhosh: Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 [06:53:44] (03PS2) 10Ori.livneh: Move RunningStat from profiler/ to libs/ [core] - 10https://gerrit.wikimedia.org/r/105146 [06:58:13] (03CR) 10Siebrand: [C: 031] "We sought input form the translators for Russian on if this will be an issue as there is some work involved. About 1000 translations for R" [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh) [07:12:57] (03CR) 10Aaron Schulz: Add class implementing MessagePack serialization (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105126 (owner: 10Ori.livneh) [07:14:20] (03CR) 10Amire80: [C: 032] "Merging, and going to do fixes in the translations." [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh) [07:15:08] (03CR) 10Aaron Schulz: [C: 032] Move RunningStat from profiler/ to libs/ [core] - 10https://gerrit.wikimedia.org/r/105146 (owner: 10Ori.livneh) [07:17:37] (03Merged) 10jenkins-bot: Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh) [07:19:20] (03Merged) 10jenkins-bot: Move RunningStat from profiler/ to libs/ [core] - 10https://gerrit.wikimedia.org/r/105146 (owner: 10Ori.livneh) [07:29:39] (03PS3) 10Mayankmadan: getApiWarnings() throws an exception if upload is invalid [core] - 10https://gerrit.wikimedia.org/r/105111 [07:54:11] (03PS1) 10AndyRussG: Notifications for course talk page edits [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/105147 [08:02:19] (03PS2) 10Ori.livneh: MWMessagePack: improvements to test suite, exception handling, array detection [core] - 10https://gerrit.wikimedia.org/r/105145 [08:02:47] (03CR) 10Bsitu: "This does not seem to fix the error that occurred in beta server. I tried to create a new topic but purposely put some error in the post " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105118 (owner: 10EBernhardson) [08:18:36] (03PS1) 10Santhosh: Update Russian(ru) plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/105148 [08:23:04] (03CR) 10Legoktm: [C: 04-1] "Just took a quick look." (035 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/105147 (owner: 10AndyRussG) [08:34:42] TimStarling: http://www.stealth-x.com/articles/the-problems-with-full-disk-encryption.php [08:34:47] that firewire bit is amusing [08:35:50] (03CR) 10Siebrand: [C: 032] Update Russian(ru) plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/105148 (owner: 10Santhosh) [08:36:21] (03PS1) 10Siebrand: Update plural rules to CLDR 24 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/105150 [08:37:16] requires physical access to an unattended running system...similar to cold boot in that sense I suppose [08:38:15] (03CR) 10jenkins-bot: [V: 04-1] Update plural rules to CLDR 24 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/105150 (owner: 10Siebrand) [08:39:45] (03Merged) 10jenkins-bot: Update Russian(ru) plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/105148 (owner: 10Santhosh) [08:40:07] (03PS1) 10Hashar: fix parsoidsvc-jslint was not voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105151 [08:41:49] (03CR) 10Hashar: [C: 032] "tested locally this time jslint job should vote =)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105151 (owner: 10Hashar) [08:41:59] (03Merged) 10jenkins-bot: fix parsoidsvc-jslint was not voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105151 (owner: 10Hashar) [08:52:31] (03PS2) 10Physikerwelt: Remove call to deprecated ParserOptions::getMath [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 [08:52:58] (03CR) 10jenkins-bot: [V: 04-1] Remove call to deprecated ParserOptions::getMath [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 (owner: 10Physikerwelt) [08:57:36] (03PS3) 10Parent5446: MWMessagePack: improvements to test suite, exception handling, array detection [core] - 10https://gerrit.wikimedia.org/r/105145 (owner: 10Ori.livneh) [08:57:50] (03CR) 10Parent5446: "PS3: Code style fixes." [core] - 10https://gerrit.wikimedia.org/r/105145 (owner: 10Ori.livneh) [08:57:53] (03CR) 10Hashar: [C: 04-1] "Can you fill a bug about Jenkins lost of functionality ? It should be fixed on Jenkins side, not by hiding / disabling tests." [extensions/Math] - 10https://gerrit.wikimedia.org/r/104994 (owner: 10Physikerwelt) [08:59:47] (03CR) 10Parent5446: [C: 031] Give links to a user's suppressed edits on Special:Contribs [core] - 10https://gerrit.wikimedia.org/r/104711 (owner: 10Legoktm) [09:01:11] (03PS4) 10Parent5446: Fixed stream wrapper in PhpHttpRequest [core] - 10https://gerrit.wikimedia.org/r/91393 [09:01:26] (03CR) 10Parent5446: [C: 032] MWMessagePack: improvements to test suite, exception handling, array detection [core] - 10https://gerrit.wikimedia.org/r/105145 (owner: 10Ori.livneh) [09:01:43] (03PS5) 10Parent5446: Fixed stream wrapper in PhpHttpRequest [core] - 10https://gerrit.wikimedia.org/r/91393 [09:03:04] (03PS2) 10Parent5446: Add fastcgi_finish_request where appropriate [core] - 10https://gerrit.wikimedia.org/r/96904 [09:06:11] (03Merged) 10jenkins-bot: MWMessagePack: improvements to test suite, exception handling, array detection [core] - 10https://gerrit.wikimedia.org/r/105145 (owner: 10Ori.livneh) [09:06:22] (03CR) 10Ori.livneh: "Thanks! :)" [core] - 10https://gerrit.wikimedia.org/r/105145 (owner: 10Ori.livneh) [09:07:03] (03PS4) 10Parent5446: Make autoblocks update with the parent block [core] - 10https://gerrit.wikimedia.org/r/66366 [09:10:57] (03PS1) 10Legoktm: grabText: Don't store entire list of pages in memory [tools/grabbers] - 10https://gerrit.wikimedia.org/r/105153 [09:16:12] (03CR) 10Hashar: [C: 031] Throw exception on invalid RecentChange types [core] - 10https://gerrit.wikimedia.org/r/104528 (owner: 10Siebrand) [09:17:22] (03PS25) 10Parent5446: Add Uri class and Uri Query classes [core] - 10https://gerrit.wikimedia.org/r/22167 [09:20:42] (03CR) 10jenkins-bot: [V: 04-1] Add Uri class and Uri Query classes [core] - 10https://gerrit.wikimedia.org/r/22167 (owner: 10Parent5446) [09:36:24] (03CR) 10Physikerwelt: "I was thinking it was a feature to improve security and not a bug. Executing arbitrary user code that fetches data from external resources" [extensions/Math] - 10https://gerrit.wikimedia.org/r/104994 (owner: 10Physikerwelt) [09:40:51] (03PS1) 10Legoktm: Turn HTMLBlockedUsersItemSelect into HTMLSelectLimitField [core] - 10https://gerrit.wikimedia.org/r/105156 [09:44:55] any parsoid devs in the house? [09:45:09] Error: Can't set headers after they are sent. [09:45:09] at ServerResponse.OutgoingMessage.setHeader (http.js:644:11) [09:45:09] at ServerResponse.res.setHeader (/srv/deployment/parsoid/config/node_modules/express/node_modules/connect/lib/patch.js:62:20) [09:45:09] at next (/srv/deployment/parsoid/config/node_modules/express/node_modules/connect/lib/http.js:166:13) [09:47:43] one simply doesn't parsoid [09:49:13] (03PS26) 10Parent5446: Add Uri class and Uri Query classes [core] - 10https://gerrit.wikimedia.org/r/22167 [09:52:35] (03CR) 10jenkins-bot: [V: 04-1] Add Uri class and Uri Query classes [core] - 10https://gerrit.wikimedia.org/r/22167 (owner: 10Parent5446) [10:14:14] (03PS27) 10Parent5446: Add Uri class and Uri Query classes [core] - 10https://gerrit.wikimedia.org/r/22167 [10:18:31] (03PS1) 10Cargan: bug 17630 fix; added aditional check if anonymous user can create/edit none existing page, if not display permission error [core] - 10https://gerrit.wikimedia.org/r/105158 [10:20:34] (03CR) 10Legoktm: "I always viewed the 'move' permission as an extension of the 'edit' permission and saw this as a feature instead of a bug." [core] - 10https://gerrit.wikimedia.org/r/105103 (owner: 10Jackmcbarn) [10:29:03] (03PS3) 10Aude: Fix SearchEngineTest when $wgSearchType is set to non-default [core] - 10https://gerrit.wikimedia.org/r/105131 [10:29:09] (03CR) 10Aude: Fix SearchEngineTest when $wgSearchType is set to non-default (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105131 (owner: 10Aude) [10:29:28] (03PS13) 10Parent5446: Add referer and origin check to edit token checking [core] - 10https://gerrit.wikimedia.org/r/65418 [10:32:35] (03CR) 10Parent5446: [C: 04-1] bug 17630 fix; added aditional check if anonymous user can create/edit none existing page, if not display permission error (032 comments) [core] - 10https://gerrit.wikimedia.org/r/105158 (owner: 10Cargan) [10:40:08] (03PS3) 10Parent5446: Changed logged out tokens to use session if already there [core] - 10https://gerrit.wikimedia.org/r/76458 [10:40:13] (03Abandoned) 10Ori.livneh: Reverting changes to python schema.Adding test. Removing whitespace again. Adding isset check for user agent for times in which this code is called outside a web context. Removing user agent from publisher before publishing event Change-Id: I0a95768fae7da [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/104509 (owner: 10Nuria) [10:47:01] i get redirected to https://en.m.wikipedia.org/wiki/Main_Page when i go to zero.wikipedia.org [10:50:32] (03PS1) 10Hashar: multigit: GERRIT_URL -> GERRIT_CHANGE [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105160 [10:50:34] (03PS1) 10Hashar: multigit: fetch branches from Gerrit, not Zuul [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105161 [10:50:40] (03CR) 10Hashar: [C: 032] multigit: GERRIT_URL -> GERRIT_CHANGE [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105160 (owner: 10Hashar) [10:50:43] (03Merged) 10jenkins-bot: multigit: GERRIT_URL -> GERRIT_CHANGE [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105160 (owner: 10Hashar) [10:50:46] (03PS7) 10Parent5446: Moved account creation throttle to ping limiter [core] - 10https://gerrit.wikimedia.org/r/65867 [10:51:32] (03CR) 10jenkins-bot: [V: 04-1] Moved account creation throttle to ping limiter [core] - 10https://gerrit.wikimedia.org/r/65867 (owner: 10Parent5446) [10:51:50] mayankmadan: zero is only for some carriers [10:51:59] (and even for those it's being phased out) [10:52:02] Nemo_bis, im faking headers [10:52:14] maybe not well enough? :) [10:52:26] Nemo_bis, it was working earlier [10:52:44] (03CR) 10Hashar: [C: 032] multigit: fetch branches from Gerrit, not Zuul [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105161 (owner: 10Hashar) [10:52:48] (03Merged) 10jenkins-bot: multigit: fetch branches from Gerrit, not Zuul [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105161 (owner: 10Hashar) [10:53:09] (03Abandoned) 10Parent5446: Fixed permissions check for showing rollback link in RC [core] - 10https://gerrit.wikimedia.org/r/66191 (owner: 10Parent5446) [10:57:09] (03PS1) 10Santhosh: CLDR 24 update - release notes [core] - 10https://gerrit.wikimedia.org/r/105162 [11:00:54] (03PS4) 10Parent5446: Cleaned up extension and refactored Special Page. [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/53860 [11:00:55] (03PS2) 10Santhosh: CLDR 24 update - release notes [core] - 10https://gerrit.wikimedia.org/r/105162 [11:04:05] (03CR) 10Nemo bis: "ashley> includes/upload/UploadBase.php tells to "See also includes/docs/upload.txt"" [core] - 10https://gerrit.wikimedia.org/r/82090 (owner: 10Bartosz Dziewoński) [11:04:08] (03PS8) 10Parent5446: Moved account creation throttle to ping limiter [core] - 10https://gerrit.wikimedia.org/r/65867 [11:07:41] (03CR) 10Legoktm: Add ZeroMQFeedEngine (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105117 (owner: 10Legoktm) [11:08:00] (03PS5) 10Legoktm: Add ZeroMQFeedEngine [core] - 10https://gerrit.wikimedia.org/r/105117 [11:10:04] (03CR) 10Physikerwelt: "By the way the test failed due to" [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 (owner: 10Physikerwelt) [11:12:42] (03PS1) 1001tonythomas: Removed the "details" link if the user is already in details page [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105164 [11:18:17] (03CR) 10Hoo man: [C: 04-1] Removed the "details" link if the user is already in details page (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105164 (owner: 1001tonythomas) [11:22:23] Nemo_bis: what should I change on this page https://www.mediawiki.org/wiki/Help:Mass_account_creation ? [11:22:37] check the links better [11:23:57] (03CR) 10Pginer: "I agree that line length becomes too long on some big screens and a better use of space can be done. However, the solution proposed result" [core] - 10https://gerrit.wikimedia.org/r/103744 (owner: 10Hatul) [11:25:12] Nemo_bis: [[Special:ListGroupRights]] should be [[Special:MyLanguage/ListGroupRights]] ? [11:26:45] (03CR) 10Aklapper: "Please see https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines ; minor typos ("aditional", "none existing") could also be fixe" [core] - 10https://gerrit.wikimedia.org/r/105158 (owner: 10Cargan) [11:26:59] Nemo_bis, would you like to have a look at https://gerrit.wikimedia.org/r/#/c/105111/ [11:27:09] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/104711 (owner: 10Legoktm) [11:27:27] (03PS3) 10Santhosh: CLDR 24 update - release notes [core] - 10https://gerrit.wikimedia.org/r/105162 [11:27:36] VladAndrew: no, Special pages are automatically localized [11:28:45] done then [11:29:06] (03CR) 10MaxSem: Add ZeroMQFeedEngine (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105117 (owner: 10Legoktm) [11:30:38] MaxSem: is sticking a $profile = new ProfileSection( __METHOD__ ); at the top of the section good enough? [11:31:55] I guess [11:32:04] also, does it have to be in core? [11:33:51] Given that there already are UDP and Redis pub sub implementations in core, I thought it made sense to include it core [11:35:16] (03CR) 10Legoktm: Add ZeroMQFeedEngine (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105117 (owner: 10Legoktm) [11:35:34] (03PS6) 10Legoktm: Add ZeroMQFeedEngine [core] - 10https://gerrit.wikimedia.org/r/105117 [11:35:42] why do you think it shouldnt? :P [11:37:46] are there real plans of using it? [11:38:36] yes [11:38:45] well, I hope. [11:38:49] https://www.mediawiki.org/wiki/Requests_for_comment/Publishing_the_RecentChanges_feed [11:48:49] Nemo_bis: I think the links are working this time [11:51:29] wow, https://meta.wikimedia.org/wiki/Special:MyLanguage/outreach:Editing_workshops works for real [11:52:32] improved that link and marked [11:53:54] (03CR) 10Siebrand: [C: 032] CLDR 24 update - release notes [core] - 10https://gerrit.wikimedia.org/r/105162 (owner: 10Santhosh) [11:56:24] (03PS1) 10Cargan: (bug 17630) Add edit page permission check [core] - 10https://gerrit.wikimedia.org/r/105167 [11:57:09] (03Merged) 10jenkins-bot: CLDR 24 update - release notes [core] - 10https://gerrit.wikimedia.org/r/105162 (owner: 10Santhosh) [12:01:05] (03PS1) 10Mglaser: Adapted unittest to fit new wrapper [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/105168 [12:01:56] (03CR) 10Bartosz Dziewoński: "It doesn't even point to the right location… I7f909873035b9176ba9b7c2bf41b05d9eede3cc4" [core] - 10https://gerrit.wikimedia.org/r/82090 (owner: 10Bartosz Dziewoński) [12:02:35] (03PS1) 10Bartosz Dziewoński: Remove reference to deleted file [core] - 10https://gerrit.wikimedia.org/r/105169 [12:02:53] (03CR) 10Legoktm: [C: 032] Remove reference to deleted file [core] - 10https://gerrit.wikimedia.org/r/105169 (owner: 10Bartosz Dziewoński) [12:04:39] (03PS1) 10Jack Phoenix: Code hygiene for the API modules: * swapped global $wgUser to the context-sensitive ->getUser() method * removed getVersion() functions from all modules, because, quoth core, "since 1.21, version string is no longer supported" [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/105170 [12:08:16] (03Merged) 10jenkins-bot: Remove reference to deleted file [core] - 10https://gerrit.wikimedia.org/r/105169 (owner: 10Bartosz Dziewoński) [12:09:10] (03CR) 10Nikerabbit: Add ZeroMQFeedEngine (033 comments) [core] - 10https://gerrit.wikimedia.org/r/105117 (owner: 10Legoktm) [12:10:43] (03CR) 10Legoktm: [C: 032] Code hygiene for the API modules: * swapped global $wgUser to the context-sensitive ->getUser() method * removed getVersion() functions from [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/105170 (owner: 10Jack Phoenix) [12:10:51] (03Merged) 10jenkins-bot: Code hygiene for the API modules: * swapped global $wgUser to the context-sensitive ->getUser() method * removed getVersion() functions from all modules, because, quoth core, "since 1.21, version string is no longer supported" [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/105170 (owner: 10Jack Phoenix) [12:16:24] Nemo_bis: I should apply the thing with the links for Blocking_users too ? [12:17:11] yes please [12:20:30] Nemo_bis: and for the links enclosed by {{...}} do they require the same thing ? [12:33:44] andre__, around? [12:33:50] hi mayankmadan [12:34:02] hi [12:34:14] andre__, i was working on this http://www.google-melange.com/gci/task/view/google/gci2013/5817413010456576 [12:34:15] MediaWiki: UploadBase::checkWarnings could throw exception on null object access [12:34:15] Status: Reopened [12:34:15] Mentor(s): Quim Gil [12:34:47] andre__, but there is little time left in this contest that i completed another kiwix task and kelson created that task too so i unclaimed this and claimed that [12:34:55] it will be hopefully quickly reviewed [12:35:11] is it possible that you can add a comment on melange that im still working on it [12:35:34] working on which one? [12:36:50] andre__, http://www.google-melange.com/gci/task/view/google/gci2013/5322719751045120 [12:36:51] Load ICU icudt49l.dat file dynamically in Kiwix for Android [12:36:51] Status: NeedsReview (47 hours, 55 minutes left) [12:36:51] Mentor(s): Kelson [12:37:31] mayankmadan, so if you are still working on that one, why did you set "Ready to review"? Maybe I misunderstand? [12:37:47] andre__, im not working on that one, i have done that one [12:37:56] It is done when it is reviewed. [12:38:01] (in terms of GCI) [12:38:15] ok [12:38:21] that does not stop you from working on something else, but it stops you from claiming a different task in GCI. [12:38:30] (and if a task is not claimed and assigned to you in GCI, then anybody else can claim it and work on it. You can only work on one task at a time in GCI (which does not mean that you are not free to work on more than one task outside of GCI). That's the contest rules.) [12:39:11] andre__, just out of curiosity, who will be doing the final judging of tasks? [12:39:35] mayankmadan, how do you mean judging? the mentors of each task [12:39:42] (or do you mean the Grand Prize Winners?) [12:39:47] andre__, grand prize winner [12:39:49] andre__, grand prize winners [12:40:19] Nemo_bis: done [12:41:03] mayankmadan, We haven't talked about this yet among the admins and organizers of GCI in Wikimedia (as this was the first time that Wikimedia took part in GCI) - I guess organizers just meet and chat at some point in the next two weeks, but no idea about the process and involved people yet [12:41:25] okay [12:44:38] Nemo_bis: what do you think ? [12:45:17] lunchtime now, sorry [12:56:10] Nemo_bis: enjoy your launch [12:57:00] Hello! :) [13:01:10] hi AaronSchulz [13:12:52] (03PS1) 10Bartosz Dziewoński: Namespace translation updates [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/105175 [13:15:45] (03CR) 10Nikerabbit: "For future please make sure the commit message is correctly formatted (blank line after summary)." [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/105170 (owner: 10Jack Phoenix) [13:17:37] (03PS2) 10Bartosz Dziewoński: Namespace translation updates [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/105175 [13:18:23] (03CR) 10Siebrand: [C: 032] Namespace translation updates [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/105175 (owner: 10Bartosz Dziewoński) [13:21:07] (03Merged) 10jenkins-bot: Namespace translation updates [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/105175 (owner: 10Bartosz Dziewoński) [13:26:56] VladAndrew: you're linking the wrong wiki... m: means meta.wikimedia.org [13:27:31] and you can't leave the whole page in a single translation unit :) this time you're forced to use translate tags for each unless you abandon the list format [13:28:35] Nemo_bis: so in place of m: it should be ?? [13:29:48] VladAndrew: nothing if the page is on the local wiki [13:30:05] ok [13:30:11] look https://www.mediawiki.org/wiki/Help:Links#Interwiki_links [13:32:43] (03CR) 10Bartosz Dziewoński: [C: 032] "Tested, works as advertised." [core] - 10https://gerrit.wikimedia.org/r/105133 (owner: 10Jackmcbarn) [13:33:33] (03PS1) 10Amire80: Backport the CLDR 24 changes from 1.23 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/105177 [13:36:17] Nemo_bis: I think I've got it this time [13:36:21] (03Merged) 10jenkins-bot: Prevent selection of "Jump to" text [core] - 10https://gerrit.wikimedia.org/r/105133 (owner: 10Jackmcbarn) [13:41:44] VladAndrew: {{mediawiki|Manual:Block and unblock}} makes no sense for translation [13:41:45] (03CR) 10Siebrand: [C: 04-1] Bring PageNotice extension into the modern era (033 comments) [extensions/PageNotice] - 10https://gerrit.wikimedia.org/r/105141 (owner: 10TTO) [13:42:26] (03PS8) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 [13:43:06] (03CR) 10Siebrand: [C: 04-1] "This needs release notes." [core] - 10https://gerrit.wikimedia.org/r/105140 (owner: 10Aaron Schulz) [13:45:21] MatmaRex: [13:45:26] done [13:45:28] http://reportcard.wmflabs.org/graphs/very_active_editors [13:45:29] thedj: sup? [13:45:43] MatmaRex: didn't know polish active editors collopased THAT much this year.. :( [13:45:44] (03PS2) 10Siebrand: Backport the CLDR 24 changes from 1.23 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/105177 (owner: 10Amire80) [13:45:54] (03CR) 10Siebrand: [C: 032] Backport the CLDR 24 changes from 1.23 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/105177 (owner: 10Amire80) [13:45:57] (03PS1) 10Nikerabbit: Typofix: less bunny hoppers [core] - 10https://gerrit.wikimedia.org/r/105178 [13:46:23] (03PS9) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 [13:47:01] can't wait to see last quarter of the year, cause that is usually a bit up, but it's a big difference [13:47:34] thedj: hmm, not sure what's up with that, i didn't notice much of a difference myself… maybe i'm not that perceptive [13:48:06] (this also includes all of the projects, i think, and i'm only really active on one) [13:48:16] good point [13:48:52] i think just about every Wikimedia project is available in Polish, n [13:49:04] and most of them have already been rather stagnant [13:49:44] !change 105165 siebrand [13:49:44] https://gerrit.wikimedia.org/r/#q,105165,n,z [13:49:51] !change 105165 | siebrand [13:49:51] siebrand: https://gerrit.wikimedia.org/r/#q,105165,n,z [13:50:30] (i'm being told it needs a follow-up fix on translatewiki.net or it will overwrite it again, and one little % character in a translatio breaks building the android app) [13:51:19] (03Merged) 10jenkins-bot: Backport the CLDR 24 changes from 1.23 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/105177 (owner: 10Amire80) [13:52:47] (03CR) 10Bartosz Dziewoński: [C: 032] Typofix: less bunny hoppers [core] - 10https://gerrit.wikimedia.org/r/105178 (owner: 10Nikerabbit) [13:56:11] (03Merged) 10jenkins-bot: Typofix: less bunny hoppers [core] - 10https://gerrit.wikimedia.org/r/105178 (owner: 10Nikerabbit) [13:59:30] hashar: ping [14:00:23] https://wikitech.wikimedia.org/w/index.php?title=Server_Admin_Log&diff=cur&oldid=93754 [14:04:22] (03PS4) 10Krinkle: Provide direction hinting in the personal toolbar [core] - 10https://gerrit.wikimedia.org/r/78477 (owner: 10Mwalker) [14:05:46] (03PS1) 10Hashar: bump to bundler 1.5.1 [integration/bundler] - 10https://gerrit.wikimedia.org/r/105180 [14:06:48] (03CR) 10Hashar: [C: 032] "being used the integration-selenium-driver.pmtpa.wmflabs instance to run the browser tests :-D" [integration/bundler] - 10https://gerrit.wikimedia.org/r/105180 (owner: 10Hashar) [14:07:11] (03CR) 10Hashar: [V: 032] bump to bundler 1.5.1 [integration/bundler] - 10https://gerrit.wikimedia.org/r/105180 (owner: 10Hashar) [14:08:47] (03PS1) 10Hashar: bump bundler to 1.5.1 [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105181 [14:08:49] (03CR) 10Krinkle: Refactor Special:Upload for extensibility (031 comment) [core] - 10https://gerrit.wikimedia.org/r/67173 (owner: 10Worden.lee) [14:08:56] (03CR) 10Hashar: [C: 032] bump bundler to 1.5.1 [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105181 (owner: 10Hashar) [14:08:59] (03Merged) 10jenkins-bot: bump bundler to 1.5.1 [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105181 (owner: 10Hashar) [14:12:27] (03CR) 10Krinkle: [C: 04-1] Refactor Special:Upload for extensibility (033 comments) [core] - 10https://gerrit.wikimedia.org/r/67173 (owner: 10Worden.lee) [14:14:39] (03PS1) 10Hashar: some more extensions [extensions] - 10https://gerrit.wikimedia.org/r/105182 [14:14:54] (03CR) 10Hashar: [C: 032 V: 032] some more extensions [extensions] - 10https://gerrit.wikimedia.org/r/105182 (owner: 10Hashar) [14:22:21] (03PS3) 10Krinkle: Added highlighting after clicking "Drag to new location" button of Liquid Threads. [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/93740 (owner: 1001tonythomas) [14:23:20] rebooting jenkins [14:27:56] (03CR) 10Krinkle: "I don't have review capacity for this at the moment." (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/97454 (owner: 10M4tx) [14:29:48] (03CR) 10Krinkle: "What is "poc"?" [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [14:30:06] (03CR) 10Cmcmahon: [C: 032] Clean up meaningless "post body" language [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102594 (owner: 10Spage) [14:33:17] (03PS19) 10Krinkle: Update Special:Version licensing for extensions [core] - 10https://gerrit.wikimedia.org/r/65299 (owner: 10Mwalker) [14:35:32] (03CR) 10jenkins-bot: [V: 04-1] Add licensing for extensions to Special:Version [core] - 10https://gerrit.wikimedia.org/r/65299 (owner: 10Mwalker) [14:43:32] (03PS1) 10Physikerwelt: Validate TeX input for all renderers, not just texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/105187 [14:44:02] (03CR) 10Krinkle: [C: 031] Migrate redirectToFragment() from wikibits.js to own module [core] - 10https://gerrit.wikimedia.org/r/94412 (owner: 10Umherirrender) [14:44:24] (03CR) 10jenkins-bot: [V: 04-1] Validate TeX input for all renderers, not just texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/105187 (owner: 10Physikerwelt) [14:50:50] hashar: sorry I clicked on the lost connection link [14:51:53] hashar: I did not see that you were rebooting jenkins [14:55:54] Krinkle: the -npm job is fixed apparently https://integration.wikimedia.org/ci/job/mwext-VisualEditor-npm/151/console [14:57:50] hello yurik there? [14:58:03] (03PS2) 10Hashar: Validate TeX input for all renderers, not just texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/105187 (owner: 10Physikerwelt) [14:58:06] diwanship, yep [14:58:37] (03CR) 10jenkins-bot: [V: 04-1] Validate TeX input for all renderers, not just texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/105187 (owner: 10Physikerwelt) [14:59:04] diwanship, re your question - no need to show any html for the responses that don't have html [14:59:40] (03CR) 10Bartosz Dziewoński: "I think it is "proof of concept"." [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [15:00:35] yurik can we have some page id related tutorials for ex getting pageids of multiple pages ? [15:00:59] (03Abandoned) 10Siebrand: Update plural rules to CLDR 24 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/105150 (owner: 10Siebrand) [15:01:18] diwanship, you could mention it, but i don't think its needed - we don't want to overload people with information [15:01:23] hashar: I think it's ok to skip the latexml integration test... maybe it was a bug that jenkins could access the external url before [15:01:28] up to you really [15:01:39] if you want, grab some article and check its id [15:01:48] use api to find out what the id is :) [15:02:07] physikerwelt: ahh yeah https://integration.wikimedia.org/ci/job/mwext-Math-testextensions-master/458/testReport/(root)/MathLaTeXMLTest/testIntegration/ [15:02:10] let me fix it up :d [15:02:16] hashar: https://integration.wikimedia.org/ci/job/VisualEditor-npm/34/console is restored indeed [15:02:27] hashar: looks like the mwext- one is still failing, caused by lack of submodule initialisation [15:02:30] Did something change? [15:02:32] Krinkle: must have been some issue with a git plugin, I have upgraded Jenkins this week. [15:02:48] the submodules might not be fetched by default [15:03:04] It used to work [15:03:28] I imagine this'll affect other projects as well if submodules is now absent by default everywhere [15:03:50] - defaults: [15:03:50] name: use-zuul [15:03:50] scm: [15:03:52] - git: [15:03:54] recursive-submodules: true [15:04:00] physikerwelt: we would need to download $wgLateXMLUrl via a web proxy, not sure how to set that up though [15:04:10] Though we use "use-zuul" (we don't have a "use-zuul-with-submodules"), but we do set it to true explicitly. [15:04:16] So it should be working? WE're not relying on any default. [15:04:55] yurik ok also how was the december report? [15:05:11] diwanship, looked good [15:05:37] diwanship, any problems with the editing? or you haven't started on that? [15:05:38] physikerwelt: ahh we want to set $wgHTTPProxy probably [15:06:37] yurik, yes i haven't started yet working on querying right now. [15:06:49] hashar: I have no experiences with proxies at all [15:07:23] physikerwelt: will try :D [15:07:31] but maybe the npm module fetching problem has the same reason [15:08:19] yurik did u see the slides? i wanted to know if i am going in too details [15:08:44] (03PS1) 10Hashar: wgHTTPProxy test (DO NOT SUBMIT) [extensions/Math] - 10https://gerrit.wikimedia.org/r/105188 [15:09:00] physikerwelt: I have hacked up Math.php to set $wgHTTPProxy, will see how it goes [15:10:09] ok is there some is_jenkins function in the test unit tests [15:10:16] diwanship, it looked ok, but i am not the best person to ask - because i already know it. Try to find a person who doesn't know API, and ask them to go through the slides - and write down all the issues they strugle with - I think the feedback would be much better in that [15:11:22] (03Abandoned) 10Hashar: wgHTTPProxy test (DO NOT SUBMIT) [extensions/Math] - 10https://gerrit.wikimedia.org/r/105188 (owner: 10Hashar) [15:12:48] physikerwelt: I will add it to the MediaWiki configuration files being used [15:13:29] hashar: that sounds like a better solution [15:14:07] physikerwelt: for npm there is no real solution unfortunately :( they are using a self signed certificate so the web proxy would reject connections to https://npmjs.org/ [15:16:34] hashar: I think for npm a wikimedia specific solution would be good. I would apprechiate it there would be a mirror with a set of current (compatibles) node moules hosted by the foundation [15:18:08] hi everyone, I start on monday working for wmf, how do I get a wikipedia/ irc cloak? [15:18:47] wikimedia/ rather [15:19:13] yurik that sounds good. i'll keep my work going and pls tell me if m going in too much detail. but before that i wanted to ask you 1 thing please tell me what do you expect from me to make it look GOOD instead of OK. :) :P [15:19:41] nevermind, just found the appropriate wiki page [15:20:19] diwanship, your students will be the ones to judge that :))) [15:21:37] yurik also in codecademy our course is showing 9 users started. I dint understand that do u have any idea about those users. it would be easy to get the feedback from them [15:22:06] diwanship, it probably means all the times i tried some of it via privacy mode [15:22:41] (03CR) 10Nikerabbit: [C: 032] "Wow 4 months for this change?" [core] - 10https://gerrit.wikimedia.org/r/78477 (owner: 10Mwalker) [15:22:44] yurik ohhk [15:23:51] physikerwelt: i filled a bug for it : https://bugzilla.wikimedia.org/show_bug.cgi?id=59253 [15:26:00] hashar: oh this was merged fast [15:26:11] (03CR) 10Bartosz Dziewoński: [C: 04-2] Provide direction hinting in the personal toolbar [core] - 10https://gerrit.wikimedia.org/r/78477 (owner: 10Mwalker) [15:26:18] physikerwelt: yup mark is usually very reactive :-] [15:26:22] (03CR) 10Bartosz Dziewoński: "There are unresolved comments on patchset 3." [core] - 10https://gerrit.wikimedia.org/r/78477 (owner: 10Mwalker) [15:26:28] when I don't make mistakes hehe [15:26:34] Nikerabbit: ^^^ [15:27:24] Nikerabbit: i'm not going to block merging if you really meant to, but i'd like you to acknowledge you've seen them first :) [15:27:55] Krinkle has a nasty habit of creating useless drive-by new patchsets and thus removing all -1s… :/ [15:28:35] (03CR) 10Ragesoss: "Not sure if this is an actual problem or just something I had to work around in my vagrant setup..." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/105147 (owner: 10AndyRussG) [15:29:34] (03PS1) 10Umherirrender: Call Database::makeInsertOptions from Database::insertSelect [core] - 10https://gerrit.wikimedia.org/r/105190 [15:29:56] It is the responsibility of the patch set author to process incoming feedback, the feedback doesn't disappear. It just resets the score overview. The comment thread is still there, plus the owner still gets e-mail notifications for each that he/she can process. [15:30:26] Krinkle: yeah, but other reviewers don't notice and merge the patches [15:30:28] If someone misses it, one could point it out again, but I've never seen that become a problem. [15:30:42] Krinkle: can you add a brief comment "-1 Outstanding comments on previous PS" when you do this? [15:30:53] Unlikely. [15:31:19] If the owner misses it, a reviewer could remind them at some point. [15:31:40] But if a reviewer misses it, they are sloppy. And that is not a process problem but a miss on the reviewers end. [15:31:46] (03CR) 10Bartosz Dziewoński: "[16:27] Nikerabbit: i'm not going to block merging if you really meant to, but i'd like you to acknowledge you've seen them fir" [core] - 10https://gerrit.wikimedia.org/r/78477 (owner: 10Mwalker) [15:32:30] Krinkle: you could make it easier for people [15:32:37] I dont have time to spoonfeed other reviewers. And if something simple as understanding the feedback thread is a problem, I'd love to hear some names and I'll gladly invest time in educating or documenting things better. [15:32:42] Krinkle: for the same reason we don't rebase and modify the code in one patchset [15:32:56] If you look only at the review card that is unacceptable to me. Not everything reflects in scores. [15:33:13] Besides, the owner himself might do rebases and revisions that address some or all concerns. [15:33:36] Your solution seems insufficient and not addressing the real problem, and I don't feel like adding this to my list is productive. [15:33:48] for me it is unaceptable that people are unable to sanely diff two commits with differing parents, but apparently not everyone is a git expert [15:34:23] (03PS2) 10Umherirrender: Call Database::makeInsertOptions from Database::insertSelect [core] - 10https://gerrit.wikimedia.org/r/105190 [15:34:29] We use Gerrit, I think it is reasonable to set conventions such as not rebasing and changing in the same patch set to account for this lacking. [15:35:40] (03Abandoned) 10Jeroen De Dauw: wtf jenkins [core] - 10https://gerrit.wikimedia.org/r/105107 (owner: 10Jeroen De Dauw) [15:35:47] However having a feedback thread and not looking at it, that is not in need of expertise. The score card is not and never was an accurate summary of all past feedback. [15:35:58] and can't be, in its current form. [15:36:20] yeah. that's why a convention to retain -1s when you're not the owner and you add a new patchset is reasonable as well. [15:37:01] (03CR) 10Umherirrender: "Patch Set 2: Database::makeInsertOptions needs a array as input" [core] - 10https://gerrit.wikimedia.org/r/105190 (owner: 10Umherirrender) [15:37:02] MatmaRex: yes I saw them but didn't find them relevant for blocking the merge [15:37:34] maybe, feel free to propose it. But at this time I don't think that's productive, and encourages sloppy review (it feeds the assumption that looking at the score card and the last comment is sufficient, which is not true) [15:37:57] Nikerabbit: alright [15:39:53] I will check again in four months [15:40:43] you could also check now [15:41:26] Nikerabbit: if you're looking to merge some old changesets, there's a nice list at https://www.mediawiki.org/wiki/Gerrit/Reports/Oldest_open_changesets , some are almost two years old [15:42:38] MatmaRex: thanks but I was just processing email backlog [15:49:30] ah if only I knew how to use PHP :( [15:49:38] $var = function() { return "ok"; }(); [15:49:39] > parse error :( [15:50:15] (03CR) 10Nikerabbit: "Did a quick benchmark:" [core] - 10https://gerrit.wikimedia.org/r/96904 (owner: 10Parent5446) [15:50:32] hashar: why are there 2 parenthesis at the end [15:50:40] * hoo donates a bit of JavaScript to hashar [15:50:43] hashar: you need to use call_user_func( anon_func ); [15:50:54] ahhh verbosity [15:51:12] hashar: Btw, does it take long for you to add a dependency and enable phpunit tests on jenkins for an extension? :P [15:51:47] Nikerabbit: thank you :-] [15:51:59] hoo: mayankmadan: yeah I got confused by Javascript [15:52:22] hoo: should be fast, got to fix up something else right now though [15:52:37] hashar: k... will ping oyu later [15:52:54] 16 Free eBooks On Databases ow.ly/rQ3U5 [15:53:21] I don't know what it is... also I don't care... but it's FREEEE! [15:55:34] (03CR) 10Nikerabbit: [C: 032] "Let's give this a go. We can make changes to the docs in a followup." [core] - 10https://gerrit.wikimedia.org/r/96904 (owner: 10Parent5446) [15:56:16] (03CR) 10Chad: [C: 032] Replace usage of deprecated Title::escapeLocalURL() [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/104349 (owner: 10Siebrand) [15:56:18] (03Merged) 10jenkins-bot: Replace usage of deprecated Title::escapeLocalURL() [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/104349 (owner: 10Siebrand) [15:56:35] (03CR) 10Chad: [C: 032 V: 032] Replace usage of deprecated Title::escapeLocalURL() [extensions/ProtectSite] - 10https://gerrit.wikimedia.org/r/104359 (owner: 10Siebrand) [15:56:45] (03PS1) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement doMainQuery() [core] - 10https://gerrit.wikimedia.org/r/105194 [15:56:46] (03PS1) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement webOutput() [core] - 10https://gerrit.wikimedia.org/r/105195 [15:56:47] (03PS1) 10Bartosz Dziewoński: ChangesListSpecialPage: Stop mutating $opts in buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/105196 [15:58:34] (03CR) 10Chad: [C: 032] Fix SearchEngineTest when $wgSearchType is set to non-default [core] - 10https://gerrit.wikimedia.org/r/105131 (owner: 10Aude) [15:58:51] (03PS1) 10Sn1per: Fix bugzilla template "Show other bugs" link to show only open bugs instead of all bugs [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/105197 [15:58:55] (03CR) 10Chad: [C: 032] Replace deprecated SpecialPage::executePath() [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/104389 (owner: 10Siebrand) [15:59:25] (03CR) 10Chad: [C: 032] Various fixes for EnhancedChangesList [core] - 10https://gerrit.wikimedia.org/r/96244 (owner: 10Siebrand) [15:59:30] yurik can i publish the course and keep updating it that way i can get the feedback and review? [15:59:43] sure [16:00:32] (03Merged) 10jenkins-bot: Replace deprecated SpecialPage::executePath() [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/104389 (owner: 10Siebrand) [16:01:35] (03PS2) 10Sn1per: Fix bugzilla template "Show other bugs" link to show only open bugs instead of all bugs [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/105197 [16:01:36] (03PS1) 10Hashar: mwconf: set $wgHTTPProxy based on wmf site [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105198 [16:01:40] (03CR) 10Chad: [C: 032] Update documentation for ParserCache::save() [core] - 10https://gerrit.wikimedia.org/r/104518 (owner: 10Siebrand) [16:01:53] (03CR) 10Hashar: [C: 032] mwconf: set $wgHTTPProxy based on wmf site [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105198 (owner: 10Hashar) [16:02:03] (03CR) 10Chad: [C: 032] Declare visibility for class properties in DatabasePostgres.php [core] - 10https://gerrit.wikimedia.org/r/103875 (owner: 10Siebrand) [16:02:31] (03CR) 10Chad: [C: 032] Declare visibility for class properties in DatabaseSqlite [core] - 10https://gerrit.wikimedia.org/r/103874 (owner: 10Siebrand) [16:02:41] yurik actuaaly you can only publish it i dnt hav right [16:02:47] ^d: nice spam :-D [16:02:57] <^d> :) [16:03:20] (03CR) 10Nikerabbit: [C: 032] Change Title::isExternal to use strict comparsion [core] - 10https://gerrit.wikimedia.org/r/104936 (owner: 10Umherirrender) [16:03:40] (03CR) 10Chad: "Right, I knew it'd need the wiki to have it, but we almost always use aawiki for this and we're quickly becoming the default everywhere el" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/104774 (owner: 10Chad) [16:03:45] diwanship, submitted [16:03:54] ohh tahnks [16:03:59] thanks* [16:04:29] (03CR) 10Chad: [C: 032] Declare visibility for class properties of LBFactoryMulti [core] - 10https://gerrit.wikimedia.org/r/103864 (owner: 10Siebrand) [16:06:08] (03Merged) 10jenkins-bot: mwconf: set $wgHTTPProxy based on wmf site [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105198 (owner: 10Hashar) [16:06:49] (03Merged) 10jenkins-bot: Add fastcgi_finish_request where appropriate [core] - 10https://gerrit.wikimedia.org/r/96904 (owner: 10Parent5446) [16:06:53] (03CR) 10Anomie: [C: 031] "Looks good to me now. I pinged Mr. Stradivarius and Toohool on enwiki to see if they have any comments before we merge this." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man) [16:08:16] anomie: \o/ Thanks :) [16:09:36] (03PS1) 10Gomoko: Corrections for PHP 5.4 and FF 26 [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/105200 [16:10:21] (03PS6) 10JGonera: [WIP] Update mediawiki.ui button styles [core] - 10https://gerrit.wikimedia.org/r/103494 [16:12:45] (03PS3) 10Physikerwelt: Validate TeX input for all renderers, not just texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/105187 [16:13:02] (03CR) 10jenkins-bot: [V: 04-1] Validate TeX input for all renderers, not just texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/105187 (owner: 10Physikerwelt) [16:13:20] (03CR) 10Umherirrender: "Thanks for the responses." [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender) [16:13:47] (03CR) 10Anomie: [C: 04-1] "It's clear that PS3 will cause a PHP fatal error. Please test your changes before submitting a patchset; you may find the instructions at " [core] - 10https://gerrit.wikimedia.org/r/105111 (owner: 10Mayankmadan) [16:14:08] (03CR) 10Hashar: "deployed" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/105198 (owner: 10Hashar) [16:16:22] (03PS4) 10Physikerwelt: Validate TeX input for all renderers, not just texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/105187 [16:16:47] (03Restored) 10Hashar: wgHTTPProxy test (DO NOT SUBMIT) [extensions/Math] - 10https://gerrit.wikimedia.org/r/105188 (owner: 10Hashar) [16:16:50] (03PS1) 10Chad: Remove commented calls to transformMsg() [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/105201 [16:17:21] hashar: great job [16:17:32] physikerwelt: will see how it goes [16:17:37] (03PS2) 10Hashar: wgHTTPProxy test (DO NOT SUBMIT) [extensions/Math] - 10https://gerrit.wikimedia.org/r/105188 [16:17:37] (03CR) 10jenkins-bot: [V: 04-1] ChangesListSpecialPage: Implement webOutput() [core] - 10https://gerrit.wikimedia.org/r/105195 (owner: 10Bartosz Dziewoński) [16:18:27] (03PS1) 10Manybubbles: Search links [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105202 [16:18:48] physikerwelt: apparently it is fixed :-] https://gerrit.wikimedia.org/r/#/c/105188/ [16:19:02] (03Abandoned) 10Physikerwelt: Skip LaTeXML integration tests [extensions/Math] - 10https://gerrit.wikimedia.org/r/104994 (owner: 10Physikerwelt) [16:19:04] (03CR) 10Manybubbles: "I'm not very happy with the way this looks on the screen but it does work." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105202 (owner: 10Manybubbles) [16:19:20] ^d: The link you added in the commit summary of https://gerrit.wikimedia.org/r/#/c/105201/ doesn't work for me. Is it supposed to work? [16:19:31] hashar: you there? are mw core's master's tests broken? :/ https://gerrit.wikimedia.org/r/105195 [16:19:31] hashar: Yes. Thank you very much [16:19:52] <^d> siebrand: It wasn't a link, it was just a sha1 pointing to a point in the repo's history. [16:19:57] (03CR) 10Hashar: "Test change https://gerrit.wikimedia.org/r/#/c/105188/" [extensions/Math] - 10https://gerrit.wikimedia.org/r/104994 (owner: 10Physikerwelt) [16:20:09] <^d> siebrand: Gerrit tries to link all sha1s, even if it doesn't know about them. [16:20:17] ^d: ah. [16:20:18] physikerwelt: and thank you to have reported the issue, now everyone benefits from having $wgHTTPProxy set \O/ [16:20:46] MatmaRex: ahh yeah was looking at it [16:21:03] (03Merged) 10jenkins-bot: Fix SearchEngineTest when $wgSearchType is set to non-default [core] - 10https://gerrit.wikimedia.org/r/105131 (owner: 10Aude) [16:21:05] yes I had already reported it a while ago but the info got lost in the math 2.0 commit that became to large [16:21:08] (03PS2) 10Bartosz Dziewoński: Remove commented calls to transformMsg() [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/105201 (owner: 10Chad) [16:21:08] <^d> siebrand: I'm trying to find usages of Parser::transformMsg() that don't pass a Title. [16:21:12] <^d> It's annoying :) [16:21:36] ^d: Yay for replacing old stuff... [16:21:36] MatmaRex: the git daemon which is serving the git repositories to tests got overloaded :-( [16:22:07] (03PS3) 10Physikerwelt: Remove call to deprecated ParserOptions::getMath [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 [16:22:11] brb [16:22:27] (03Abandoned) 10Hashar: wgHTTPProxy test (DO NOT SUBMIT) [extensions/Math] - 10https://gerrit.wikimedia.org/r/105188 (owner: 10Hashar) [16:22:47] (03CR) 10jenkins-bot: [V: 04-1] Various fixes for EnhancedChangesList [core] - 10https://gerrit.wikimedia.org/r/96244 (owner: 10Siebrand) [16:22:55] ahah [16:23:07] (03CR) 10Bartosz Dziewoński: "recheck" [core] - 10https://gerrit.wikimedia.org/r/105195 (owner: 10Bartosz Dziewoński) [16:23:14] Zuul is happily requeueing all changes apparently [16:23:14] (03CR) 10Bartosz Dziewoński: "Unrelated failure." [core] - 10https://gerrit.wikimedia.org/r/105195 (owner: 10Bartosz Dziewoński) [16:25:06] (03CR) 10Siebrand: [C: 032] Remove commented calls to transformMsg() [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/105201 (owner: 10Chad) [16:25:32] <^d> siebrand: Core is all dandy. http://p.defau.lt/?FROmVRq_aU2C_UEA0pdG2Q just these 3 extensions need fixing. [16:25:40] <^d> Then we could make the param mandatory. [16:25:59] (03CR) 10Siebrand: "recheck" [core] - 10https://gerrit.wikimedia.org/r/96244 (owner: 10Siebrand) [16:26:02] (03PS1) 10Hashar: remove phpcs jobs from mw/core gating [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105204 [16:26:15] (03CR) 10Hashar: [C: 032] remove phpcs jobs from mw/core gating [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105204 (owner: 10Hashar) [16:27:25] (03PS1) 10Chad: Move $titleForParse setting up earlier and use it in remaining transformMsg() call [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/105205 [16:27:41] (03Merged) 10jenkins-bot: remove phpcs jobs from mw/core gating [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105204 (owner: 10Hashar) [16:28:00] <^d> Heh, all 3 of those extensions are used in wmf branches. [16:29:05] (03Merged) 10jenkins-bot: Update documentation for ParserCache::save() [core] - 10https://gerrit.wikimedia.org/r/104518 (owner: 10Siebrand) [16:31:04] (03Merged) 10jenkins-bot: Declare visibility for class properties in DatabasePostgres.php [core] - 10https://gerrit.wikimedia.org/r/103875 (owner: 10Siebrand) [16:31:52] ^d: gating multiple changes is a funny mess http://paste.debian.net/74037/ [16:32:02] ^d: still have to make the parser test runnable in parallel :/ [16:32:17] <^d> :( [16:32:30] <^d> I think the parser isn't designed to run more than once :p [16:32:31] and fix them in the release branches as well [16:32:41] some folks looked at it, can't remember who [16:32:51] AaronSchulz definitely fixed a few race conditions in parser tests :D [16:32:55] so there is some hope [16:33:19] (03PS3) 10Cmcmahon: Test navigation to watchlist and Flow change exists [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105044 [16:37:30] (03CR) 10Subramanya Sastry: "Thanks!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/105151 (owner: 10Hashar) [16:37:36] (03PS4) 10Cmcmahon: Test navigation to watchlist and Flow change exists [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105044 [16:37:38] (03CR) 10jenkins-bot: [V: 04-1] Declare visibility for class properties in DatabaseSqlite [core] - 10https://gerrit.wikimedia.org/r/103874 (owner: 10Siebrand) [16:38:33] (03CR) 10Krinkle: "I think I got the same Cache-Control private max-age=0 headers when testing locally (straight up Apache/PHP, no Varnish or Squid set up)." [core] - 10https://gerrit.wikimedia.org/r/95095 (owner: 10Brian Wolff) [16:38:49] (03PS1) 10Gerrit Patch Uploader: Use box-sizing:border-box for textarea [core] - 10https://gerrit.wikimedia.org/r/105207 [16:38:54] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/105207 (owner: 10Gerrit Patch Uploader) [16:39:12] I have a question on $wgUser: Is it deprecated? [16:39:27] Yes! [16:39:42] in most cases you should be able to get a user from your nearest context object [16:40:05] What would be the nearest context object here https://gerrit.wikimedia.org/r/#/c/104991/3/Math.hooks.php [16:40:52] or how could I find that out [16:41:14] (03Merged) 10jenkins-bot: Change Title::isExternal to use strict comparsion [core] - 10https://gerrit.wikimedia.org/r/104936 (owner: 10Umherirrender) [16:42:15] 'PageRenderingHash': Alter the parser cache option hash key. A parser extension [16:42:15] which depends on user options should install this hook and append its values to [16:42:15] the key. [16:42:15] $hash: reference to a hash key string which can be modified [16:42:20] ... [16:42:28] Shouldn't it probably pass a user object too? [16:42:55] (03Merged) 10jenkins-bot: Declare visibility for class properties of LBFactoryMulti [core] - 10https://gerrit.wikimedia.org/r/103864 (owner: 10Siebrand) [16:43:08] physikerwelt: I'd be tempted to update the hook in core [16:43:09] wfRunHooks( 'PageRenderingHash', array( &$confstr, $this->getUser() ) ); [16:43:22] (03PS3) 10Krinkle: Purge user css/js. [core] - 10https://gerrit.wikimedia.org/r/95095 (owner: 10Brian Wolff) [16:43:56] ok. That was not obvious:-) Let me try... [16:43:56] Passing a title too might not be the worst idea in the world.. [16:48:22] (03CR) 10Reedy: Remove call to deprecated ParserOptions::getMath (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 (owner: 10Physikerwelt) [16:48:29] (03PS4) 10Krinkle: Send cache purges for action=raw after editing user css/js [core] - 10https://gerrit.wikimedia.org/r/95095 (owner: 10Brian Wolff) [16:48:47] (03CR) 10Krinkle: "Improved commit message, and added rationale for changing importScript." [core] - 10https://gerrit.wikimedia.org/r/95095 (owner: 10Brian Wolff) [16:48:54] (03CR) 10Krinkle: [C: 031] "Untested, LGTM." [core] - 10https://gerrit.wikimedia.org/r/95095 (owner: 10Brian Wolff) [16:53:54] (03CR) 10Jackmcbarn: "If you didn't want a page to be moved, you'd just move-protect it along with it (which happens by default). If we don't want this to work," [core] - 10https://gerrit.wikimedia.org/r/105103 (owner: 10Jackmcbarn) [16:54:56] (03CR) 10jenkins-bot: [V: 04-1] Use box-sizing:border-box for textarea [core] - 10https://gerrit.wikimedia.org/r/105207 (owner: 10Gerrit Patch Uploader) [16:57:48] (03PS3) 10Umherirrender: Add Title::hasFragment and use it [core] - 10https://gerrit.wikimedia.org/r/104750 [16:59:00] (03CR) 10Umherirrender: "Patch Set 3: Rebased and resolve conflict" [core] - 10https://gerrit.wikimedia.org/r/104750 (owner: 10Umherirrender) [17:00:34] (03CR) 10jenkins-bot: [V: 04-1] Send cache purges for action=raw after editing user css/js [core] - 10https://gerrit.wikimedia.org/r/95095 (owner: 10Brian Wolff) [17:00:53] (03PS8) 10Jeroen De Dauw: Make it possible for extensions to specify which version of MediaWiki they support via Composer. [core] - 10https://gerrit.wikimedia.org/r/105092 [17:03:32] (03PS4) 10Physikerwelt: Remove call to deprecated ParserOptions::getMath [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 [17:03:45] (03CR) 10jenkins-bot: [V: 04-1] Remove call to deprecated ParserOptions::getMath [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 (owner: 10Physikerwelt) [17:07:44] (03CR) 10Krinkle: "nvm, it's fine locally. Seems to be a pre-existing bug in production." [core] - 10https://gerrit.wikimedia.org/r/95095 (owner: 10Brian Wolff) [17:11:20] (03PS1) 10Physikerwelt: Add reference to the current user to the PageRenderingHash hook [core] - 10https://gerrit.wikimedia.org/r/105213 [17:12:06] (03CR) 10jenkins-bot: [V: 04-1] Make it possible for extensions to specify which version of MediaWiki they support via Composer. [core] - 10https://gerrit.wikimedia.org/r/105092 (owner: 10Jeroen De Dauw) [17:15:14] (03PS9) 10Jeroen De Dauw: Make it possible for extensions to specify which version of MediaWiki they support via Composer. [core] - 10https://gerrit.wikimedia.org/r/105092 [17:16:02] do I need to do something special to trigger jeninks for core changes`? [17:16:26] Not usually [17:17:22] (03PS2) 10Physikerwelt: Add reference to the current user to the PageRenderingHash hook [core] - 10https://gerrit.wikimedia.org/r/105213 [17:18:21] (03PS1) 10Anomie: Revert "Declare visibility for class properties in MySQLMasterPos" [core] - 10https://gerrit.wikimedia.org/r/105214 [17:18:36] oh probably I'm not in the list to trigger jenkins for core [17:18:56] (03PS2) 10Anomie: Revert "Declare visibility for class properties in MySQLMasterPos" [core] - 10https://gerrit.wikimedia.org/r/105214 [17:19:53] <^d> siebrand: You were mentioning gerrit being a tad slow yesterday, but working. Ryan noticed some LDAP problems causing general slowness, which could have been the cause. [17:20:03] <^d> LDAP being slow to respond -> slow to auth your user, etc. [17:22:03] (03CR) 10Daniel Friesen: [C: 04-1] "Again? Do I have to dig the explanation of why blindly adding box-sizing: border-box; to every single textarea is a bad idea that breaks t" [core] - 10https://gerrit.wikimedia.org/r/105207 (owner: 10Gerrit Patch Uploader) [17:24:18] (03CR) 10Mglaser: [C: 031] "Thanks for working on this!" [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/61186 (owner: 10Timboven) [17:25:00] (03CR) 10Bartosz Dziewoński: "I would actually enjoy reading one :)" [core] - 10https://gerrit.wikimedia.org/r/105207 (owner: 10Gerrit Patch Uploader) [17:26:00] (03CR) 10jenkins-bot: [V: 04-1] Make it possible for extensions to specify which version of MediaWiki they support via Composer. [core] - 10https://gerrit.wikimedia.org/r/105092 (owner: 10Jeroen De Dauw) [17:26:22] (03PS7) 10Krinkle: JSDuck-ify /resources/mediawiki.language/* [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [17:26:59] marktraceur: Mh I looked it up... https://gerrit.wikimedia.org/r/#/q/core+owner:physikerwelt,n,z and in the past jenkins was triggered automatically [17:27:46] physikerwelt: Yeah, it should be automatic [17:28:22] (03CR) 10Bartosz Dziewoński: [C: 032] Leading semicolon line-bolding made visible in printable version [core] - 10https://gerrit.wikimedia.org/r/104913 (owner: 1001tonythomas) [17:30:34] marktraceur: yes. you are right it took just longer than expected... I think phpcs-lenient phpcs-strict timed out [17:32:12] (03Merged) 10jenkins-bot: Leading semicolon line-bolding made visible in printable version [core] - 10https://gerrit.wikimedia.org/r/104913 (owner: 1001tonythomas) [17:32:54] (03PS5) 10Physikerwelt: Remove call to deprecated ParserOptions::getMath [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 [17:37:15] (03CR) 10jenkins-bot: [V: 04-1] JSDuck-ify /resources/mediawiki.language/* [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [17:37:19] (03CR) 10Physikerwelt: "So I think this looks better now." [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 (owner: 10Physikerwelt) [17:38:11] (03CR) 10Bartosz Dziewoński: "I would appreciate not going on a rebase spree when jenkins is clearly broken." [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [17:38:43] (03CR) 10Bartosz Dziewoński: "recheck" [core] - 10https://gerrit.wikimedia.org/r/65299 (owner: 10Mwalker) [17:38:48] (03CR) 10Bartosz Dziewoński: "recheck" [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [17:38:57] (03CR) 10Bartosz Dziewoński: "recheck" [core] - 10https://gerrit.wikimedia.org/r/95095 (owner: 10Brian Wolff) [17:39:48] (03CR) 10MaxSem: [C: 032] Move $titleForParse setting up earlier and use it in remaining transformMsg() call [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/105205 (owner: 10Chad) [17:39:49] (03CR) 10Mglaser: "The change itself looks good to me. However, I doubt this will be set by many of the third party instances. I'd prefer to have a small Loc" [core] - 10https://gerrit.wikimedia.org/r/89498 (owner: 10PleaseStand) [17:40:21] (03PS7) 10JGonera: [WIP] Update mediawiki.ui button styles [core] - 10https://gerrit.wikimedia.org/r/103494 [17:41:02] (03PS1) 10Anomie: Do not reveal RevDeled file title [core] - 10https://gerrit.wikimedia.org/r/105215 [17:41:18] (03CR) 10JGonera: "Added quiet buttons and transitions but I would like to double check a few things with designers before merging." [core] - 10https://gerrit.wikimedia.org/r/103494 (owner: 10JGonera) [17:41:29] (03Merged) 10jenkins-bot: Move $titleForParse setting up earlier and use it in remaining transformMsg() call [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/105205 (owner: 10Chad) [17:42:57] (03PS20) 10Mwalker: Add licensing for extensions to Special:Version [core] - 10https://gerrit.wikimedia.org/r/65299 [17:44:48] (03CR) 10Mglaser: [C: 04-1] "As Siebrand pointed out, we need some text on the MediaWiki page first" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102081 (owner: 10PleaseStand) [17:47:14] <^d> Ugh, I hate LQT. [17:50:58] (03CR) 10CSteipp: [C: 031] Do not reveal RevDeled file title [core] - 10https://gerrit.wikimedia.org/r/105215 (owner: 10Anomie) [17:51:30] (03CR) 10Bartosz Dziewoński: "The page is empty because it's a draft, as PleaseStand explained in the comments here (which you should always totally read): "Note that t" [core] - 10https://gerrit.wikimedia.org/r/102081 (owner: 10PleaseStand) [17:52:49] I feel you [17:53:21] wait till you see Flow [17:54:19] * Nemo_bis closes eyes and ears [17:54:38] (it's actually live on https://www.mediawiki.org/wiki/Talk:Flow ) [17:56:21] (03CR) 10Jackmcbarn: [C: 031] "I can confirm that this fixes the problem I encountered." [core] - 10https://gerrit.wikimedia.org/r/105190 (owner: 10Umherirrender) [17:56:53] (03PS1) 10Ragesoss: Add new dependencies to education role: echo and parserfunctions [vagrant] - 10https://gerrit.wikimedia.org/r/105217 [18:00:16] (03CR) 10Martineznovo: [C: 031] Removed visibility status of "Notes" section to 'publicly viewable' [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104761 (owner: 1001tonythomas) [18:01:16] (03PS1) 10Reedy: $res is a bool, not a resultwrapper.. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105218 [18:01:43] Reedy: Did you test it? [18:02:44] hoo: That's how I know it was broken [18:03:02] (03PS3) 10Hoo man: Removed visibility status of "Notes" section to 'publicly viewable' [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104761 (owner: 1001tonythomas) [18:03:24] (03CR) 10Hoo man: [C: 032] "Thanks for noticing" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104761 (owner: 1001tonythomas) [18:03:57] hoo: It's currently running on the cluster [18:04:08] heh, ok :) [18:04:15] (03CR) 10jenkins-bot: [V: 04-1] Removed visibility status of "Notes" section [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104761 (owner: 1001tonythomas) [18:04:19] i think nearly 10,000,000 rows on enwiki [18:04:40] (03CR) 10Hoo man: [C: 032] "What doesn't kill the cluster, makes it stronger" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105218 (owner: 10Reedy) [18:04:45] enwiktionary: Purging old IP Address data from abuse_filter_log...83891 rows. [18:04:52] (03Merged) 10jenkins-bot: Removed visibility status of "Notes" section [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104761 (owner: 1001tonythomas) [18:05:02] (03PS1) 10Chad: Expand CirrusSearchMappingConfig hook a bit to make it useful [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105219 [18:05:16] (03CR) 10jenkins-bot: [V: 04-1] $res is a bool, not a resultwrapper.. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105218 (owner: 10Reedy) [18:05:51] failures are jenkins related an can be ignored, btw [18:06:31] (03PS1) 10Chad: Begin extending CirrusSearch schema [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/105220 [18:06:32] hashar: Do you ahve time now? [18:06:48] (03CR) 10Reedy: "recheck" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105218 (owner: 10Reedy) [18:06:50] (03PS2) 10Reedy: $res is a bool, not a resultwrapper.. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105218 [18:07:17] (03CR) 10Chad: Begin extending CirrusSearch schema (031 comment) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/105220 (owner: 10Chad) [18:07:37] (03CR) 10Hoo man: [C: 032 V: 032] "What doesn't kill the cluster, makes it stronger" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105218 (owner: 10Reedy) [18:07:49] (03CR) 10Aaron Schulz: [C: 032] Revert "Declare visibility for class properties in MySQLMasterPos" [core] - 10https://gerrit.wikimedia.org/r/105214 (owner: 10Anomie) [18:08:24] (03CR) 10Siebrand: [C: 032] "Per Chad's +2 after a broken Jenkins." [core] - 10https://gerrit.wikimedia.org/r/96244 (owner: 10Siebrand) [18:08:58] (03CR) 10Aklapper: [C: 031] "I applied the patch on boogs.wmflabs.org and it works like a charm! Thanks!" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/105197 (owner: 10Sn1per) [18:09:53] (03CR) 10Siebrand: [C: 032] "Per Chad after a broken Jenkins." [core] - 10https://gerrit.wikimedia.org/r/103874 (owner: 10Siebrand) [18:11:12] (03PS2) 1001tonythomas: Removed the "details" link if the user is already in details page [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/105164 [18:11:31] (03PS1) 10EBernhardson: Topic headers smaller and less saturated [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105222 [18:11:38] restarting jenkins to fix up visual editor jobs [18:12:04] (03Merged) 10jenkins-bot: Revert "Declare visibility for class properties in MySQLMasterPos" [core] - 10https://gerrit.wikimedia.org/r/105214 (owner: 10Anomie) [18:16:51] Jenkins is restarting :( [18:18:37] (03CR) 10Aaron Schulz: [C: 032] Call Database::makeInsertOptions from Database::insertSelect [core] - 10https://gerrit.wikimedia.org/r/105190 (owner: 10Umherirrender) [18:18:38] (03PS1) 10Aklapper: Fix unsightly white bar in Bugzilla UI header [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/105223 [18:19:13] (03PS2) 10Chad: Expand CirrusSearchMappingConfig hook a bit to make it useful [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105219 [18:19:14] (03PS1) 10Chad: Allow other extensions to modify documents to be updated [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105224 [18:19:43] (03CR) 10jenkins-bot: [V: 04-1] Call Database::makeInsertOptions from Database::insertSelect [core] - 10https://gerrit.wikimedia.org/r/105190 (owner: 10Umherirrender) [18:20:06] (03CR) 10Aklapper: [C: 031] "Quick'n'dirty tested in the browser via "Inspect Element"'s CSS on-the-fly editing skills, hence +1. See https://bugzilla.wikimedia.org/sh" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/105223 (owner: 10Aklapper) [18:20:48] (03CR) 10jenkins-bot: [V: 04-1] Expand CirrusSearchMappingConfig hook a bit to make it useful [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105219 (owner: 10Chad) [18:21:58] (03CR) 10jenkins-bot: [V: 04-1] Allow other extensions to modify documents to be updated [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105224 (owner: 10Chad) [18:24:00] haha, our search appeared on TDWTF. http://thedailywtf.com/Articles/Lightspeed-is-Too-Slow-for-MY-Luggage.aspx [18:24:04] manybubbles: ^ :D [18:25:06] what's with jenkins-bot's last comment to https://gerrit.wikimedia.org/r/#/c/105190/ ? [18:26:10] AaronSchulz: ^ [18:26:20] jackmcbarn: Jenkins has been restarted [18:26:32] "Please wait while Jenkins is getting ready to work.." [18:26:37] Need to wait for it to finish and submit again [18:30:23] (03PS4) 10Mayankmadan: getApiWarnings() throws an exception if upload is invalid [core] - 10https://gerrit.wikimedia.org/r/105111 [18:32:47] (03PS1) 10EBernhardson: Remove unused variable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105226 [18:33:29] (03CR) 10Mglaser: [C: 04-1] "I think there is an issue with a regex in ComposerVersionNormalizer. See inline comment. Other than that, the code looks fine to me." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105092 (owner: 10Jeroen De Dauw) [18:33:56] (03CR) 10jenkins-bot: [V: 04-1] getApiWarnings() throws an exception if upload is invalid [core] - 10https://gerrit.wikimedia.org/r/105111 (owner: 10Mayankmadan) [18:34:16] (03PS1) 10Chad: Index necessary data in CirrusSearch [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/105227 [18:34:58] (03CR) 10jenkins-bot: [V: 04-1] Remove unused variable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105226 (owner: 10EBernhardson) [18:35:32] (03CR) 10jenkins-bot: [V: 04-1] Index necessary data in CirrusSearch [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/105227 (owner: 10Chad) [18:35:42] (03CR) 10Chad: "recheck" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105219 (owner: 10Chad) [18:36:14] (03PS6) 10Physikerwelt: Remove call to deprecated ParserOptions::getMath [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 [18:39:01] (03CR) 10jenkins-bot: [V: 04-1] Remove call to deprecated ParserOptions::getMath [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 (owner: 10Physikerwelt) [18:39:02] MatmaRex: neat! Cirrus is a little more aggressive with suggestions though I don't think it'll suggest the same word. I think the posessive is messing up the old on though I dunno. [18:40:21] manybubbles: i think the difference between the original and the suggestion is pretty apostrophe ’ vs typewriter/ascii apostrophe ' [18:40:32] oh crap [18:40:39] well we will fix that one day too [18:40:45] haha :D [18:41:08] we're going to try to use an Elasticsearch plugin for unicode normalization. and we'll make sure that covers it [18:41:25] (03CR) 10MarkTraceur: [C: 04-1] getApiWarnings() throws an exception if upload is invalid (036 comments) [core] - 10https://gerrit.wikimedia.org/r/105111 (owner: 10Mayankmadan) [18:42:28] (03CR) 10Anomie: [C: 04-1] "{{CASCADINGSOURCES:Foo}} works, but {{CASCADINGSOURCES}} (which should return the sources for the current page) doesn't. To fix that, look" [core] - 10https://gerrit.wikimedia.org/r/104999 (owner: 10Jackmcbarn) [18:42:49] (03PS8) 10Krinkle: JSDuck-ify /resources/mediawiki.language/* [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [18:43:08] <^d> (I'll note, the screenshot must've been awhile ago...anon users should be seeing the updated search button :)) [18:43:25] (03PS5) 10Krinkle: Send cache purges for action=raw after editing user css/js [core] - 10https://gerrit.wikimedia.org/r/95095 (owner: 10Brian Wolff) [18:46:49] (03CR) 10Anomie: [C: 04-1] "Why are you now bypassing the API module's verification method entirely in favor of an entirely unhelpful error message?" [core] - 10https://gerrit.wikimedia.org/r/105111 (owner: 10Mayankmadan) [18:49:48] anomie: i can't figure out how {{PROTECTIONLEVEL}} is working if my code isn't. i grepped the whole codebase for it [18:50:05] jackmcbarn: PROTECTIONLEVEL has a mandatory parameter, doesn't it? [18:50:57] jackmcbarn: Just {{PROTECTIONLEVEL}} doesn't work for me either. [18:51:19] jackmcbarn: Note if you're trying it on enwiki that Template:PROTECTIONLEVEL exists. [18:51:30] (03PS7) 10Physikerwelt: Remove call to deprecated ParserOptions::getMath [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 [18:51:35] im on my own test wiki. should it work? i don't see much of a point in having one work but not the other [18:51:43] and it doesnt work either for me [18:52:07] (03CR) 10Manybubbles: [C: 032 V: 032] Expand CirrusSearchMappingConfig hook a bit to make it useful [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105219 (owner: 10Chad) [18:52:11] If {{PROTECTIONLEVEL}} should default to {{PROTECTIONLEVEL:edit}}, then yeah, that should probably be fixed. [18:52:27] (03Merged) 10jenkins-bot: Expand CirrusSearchMappingConfig hook a bit to make it useful [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105219 (owner: 10Chad) [18:52:50] should it, though? [18:53:35] I don't know. Personally I'd lean towards "no", if you don't specify a level then you're using it wrong. [18:54:24] (03CR) 10Manybubbles: "I was wondering if we should start with a hook that is just in the parse section. It can send the parser output as a parameter and we don" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105224 (owner: 10Chad) [18:57:24] (03PS3) 10Reedy: Call Database::makeInsertOptions from Database::insertSelect [core] - 10https://gerrit.wikimedia.org/r/105190 (owner: 10Umherirrender) [18:57:30] (03CR) 10Reedy: [C: 032] Call Database::makeInsertOptions from Database::insertSelect [core] - 10https://gerrit.wikimedia.org/r/105190 (owner: 10Umherirrender) [18:58:14] (03CR) 10Parent5446: [C: 04-1] "Doc issues. Almost ready" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/65299 (owner: 10Mwalker) [18:59:28] Krinkle: back sorry [18:59:29] Krinkle: seems the jobs are runnable again at least mwext-VisualEditor-qunit [18:59:37] (03PS1) 10CSteipp: Add tooltip by disabled Basic rights checkbox [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/105233 [19:00:43] (03CR) 10Manybubbles: "squash with Ic85061bb611648b4fa4d41031bc0713f8e7f4b01?" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/105227 (owner: 10Chad) [19:00:54] anomie: how do i deal with the fact that the call is expensive? i don't think we have precedent for expensive magic words [19:01:22] (03Merged) 10jenkins-bot: Call Database::makeInsertOptions from Database::insertSelect [core] - 10https://gerrit.wikimedia.org/r/105190 (owner: 10Umherirrender) [19:01:45] (03PS1) 10Chad: Allow SearchResults to specify that they matched file content [core] - 10https://gerrit.wikimedia.org/r/105234 [19:02:41] (03PS1) 10Chad: Use I21440625's indication of file content matches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105235 [19:02:47] (03PS1) 10Bsitu: Explicitly specify db transaction [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105236 [19:03:10] (03PS21) 10Mwalker: Add licensing for extensions to Special:Version [core] - 10https://gerrit.wikimedia.org/r/65299 [19:03:39] (03PS16) 10Mwalker: Further cleanup to Special:Version [core] - 10https://gerrit.wikimedia.org/r/65868 [19:03:53] (03PS2) 10Bsitu: Explicitly specify db transaction [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105236 [19:04:02] jackmcbarn: Is there any reason the handling for the magic word couldn't call incrementExpensiveFunctionCount(), though? [19:04:09] Krinkle: at least the git plugin is working again https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/ still fails though, can't investigate tonight: -( [19:04:37] i guess it could [19:05:56] (03PS2) 10Jackmcbarn: Add CASCADINGSOURCES parser function [core] - 10https://gerrit.wikimedia.org/r/104999 [19:11:03] (03CR) 10Jackmcbarn: Add CASCADINGSOURCES parser function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104999 (owner: 10Jackmcbarn) [19:18:26] (03PS2) 10EBernhardson: Remove unused variable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105226 [19:21:51] (03PS1) 10EBernhardson: Test to try instantiating all objects from container [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105240 [19:21:55] (03CR) 10Bsitu: [C: 032] Remove unused variable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105226 (owner: 10EBernhardson) [19:22:01] (03Merged) 10jenkins-bot: Remove unused variable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105226 (owner: 10EBernhardson) [19:27:56] YuviPanda, bd808|LUNCH : I'm using labs-vagrant and want to issue git commands in /vagrant/mediawiki, how do I do it? I'd rather not do everything sudo root, but sudo -u vagrant prompts for a password [19:28:52] (03PS1) 10Aaron Schulz: Use file handle caching in newSequentialPerNodeIDs() [core] - 10https://gerrit.wikimedia.org/r/105241 [19:29:18] (03CR) 10Nikerabbit: "If we do this, should do the same for WebFonts - or is that done already?" [extensions/Narayam] - 10https://gerrit.wikimedia.org/r/105002 (owner: 10Chad) [19:30:07] (03CR) 10EBernhardson: [C: 032] Explicitly specify db transaction [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105236 (owner: 10Bsitu) [19:30:15] (03Merged) 10jenkins-bot: Explicitly specify db transaction [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105236 (owner: 10Bsitu) [19:31:09] YuviPanda, bd808|LUNCH : `sudo su - vagrant` doesn't work so well because /home/vagrant is owned by root. [19:33:38] (03PS1) 10Parent5446: More 1.19 backwards compatibility fixes [extensions/Persona] - 10https://gerrit.wikimedia.org/r/105242 [19:34:26] (03PS2) 10Parent5446: More 1.19 backwards compatibility fixes [extensions/Persona] - 10https://gerrit.wikimedia.org/r/105242 [19:34:33] (03CR) 10Anomie: [C: 031] Add CASCADINGSOURCES parser function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104999 (owner: 10Jackmcbarn) [19:35:19] ^d: thoughts on why I cannot submit https://gerrit.wikimedia.org/r/#/c/104760/ ? [19:36:36] <^d> It is merged, see https://git.wikimedia.org/summary/wikimedia%2Ffundraising%2Ftools [19:36:43] <^d> UI's stuck. Dumb race condition. [19:36:45] <^d> I'll fix. [19:37:21] (03PS2) 10Manybubbles: Allow SearchResults to specify that they matched file content [core] - 10https://gerrit.wikimedia.org/r/105234 (owner: 10Chad) [19:37:24] (03PS1) 10Umherirrender: Add sequence support for externallinks table [core] - 10https://gerrit.wikimedia.org/r/105243 [19:37:33] (03PS2) 10Spage: [WIP] Update login and HTMLForm to new design [core] - 10https://gerrit.wikimedia.org/r/104011 [19:38:24] <^d> mwalker: Fixed. [19:38:39] greg-g, there are significant UX regressions in wmf9 that should be blockers for wider release on tuesday [19:38:40] ah; thanks :) [19:38:55] Eloquence: the svg not showing up one... what else? [19:38:57] (03CR) 10Umherirrender: "Just for reference: I have no oracle to test this, so I assume that this will help on oracle, but cannot confirm. Tested with mysql." [core] - 10https://gerrit.wikimedia.org/r/105243 (owner: 10Umherirrender) [19:39:00] ^d if that happens again; is it something I can fix; or is it on the backend? [19:39:02] (03PS1) 10Krinkle: Use use-remote-zuul-no-submodules for lint jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/105244 [19:39:37] greg-g, that's lots of icons not showing up - all the same bug, I'm guessing. plus a layout bug with ULS [19:39:40] https://bugzilla.wikimedia.org/show_bug.cgi?id=59234 is what I'm thinking of [19:39:48] * greg-g nods [19:40:08] link for the ULS one? [19:40:15] https://bugzilla.wikimedia.org/show_bug.cgi?id=59239 [19:40:19] ty [19:40:28] <^d> mwalker: Needs database access to fix, I'm afraid. [19:42:23] (03CR) 10Jeroen De Dauw: Make it possible for extensions to specify which version of MediaWiki they support via Composer. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105092 (owner: 10Jeroen De Dauw) [19:43:37] (03PS3) 10Chad: Allow SearchResults to specify that they matched file content [core] - 10https://gerrit.wikimedia.org/r/105234 [19:44:44] (03CR) 10Chad: "This is the easy part. Want to make sure the core change is live everywhere first." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105235 (owner: 10Chad) [19:47:32] (03PS3) 10EBernhardson: No longer pass $permissionsUser in Templating [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102491 [19:47:58] (03PS1) 10EBernhardson: Fix undefined variable in recentchanges formatter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105245 [19:48:22] (03PS2) 10EBernhardson: Fix undefined variable in recentchanges formatter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105245 [19:49:11] (03CR) 10EBernhardson: "Thanks for catching the merge error. Checked out FlowActions.php from master and re-converted everything over." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102491 (owner: 10EBernhardson) [19:53:22] (03PS2) 10Manybubbles: Use I21440625's indication of file content matches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105235 (owner: 10Chad) [19:54:35] (03PS10) 10Jeroen De Dauw: Make it possible for extensions to specify which version of MediaWiki they support via Composer. [core] - 10https://gerrit.wikimedia.org/r/105092 [19:56:01] (03CR) 10Jeroen De Dauw: Make it possible for extensions to specify which version of MediaWiki they support via Composer. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105092 (owner: 10Jeroen De Dauw) [19:57:34] (03PS1) 10EBernhardson: No longer pass $user arround to action message callbacks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105246 [19:59:59] (03Abandoned) 10Chad: Make SpecialPage::execute() abstract, deprecate $function and $file params [core] - 10https://gerrit.wikimedia.org/r/97669 (owner: 10Chad) [20:01:40] (03CR) 10Manybubbles: [C: 032] Allow SearchResults to specify that they matched file content [core] - 10https://gerrit.wikimedia.org/r/105234 (owner: 10Chad) [20:04:02] (03CR) 10Chad: [C: 04-2] "I like it, but I want someone other than me & Nik to review since it's core :)" [core] - 10https://gerrit.wikimedia.org/r/105234 (owner: 10Chad) [20:14:31] (03CR) 10Manybubbles: [C: 031] "In that case, +1 then." [core] - 10https://gerrit.wikimedia.org/r/105234 (owner: 10Chad) [20:14:43] siebrand: still on? just a quick request for a link or something about the "cldr plurals" that is planned to go out next week [20:14:59] (03PS8) 10Dr0ptp4kt: Add support to get just the startup module URL with version. [core] - 10https://gerrit.wikimedia.org/r/102344 [20:17:21] siebrand: search isn't helping on mw.org [20:21:42] i'm looking through the codebase and seeing a lot of places that stuff will break if multiple edits have the same timestamp [20:21:51] is there a reason they don't compare based on revision id instead? [20:22:07] (multiple edits to the same page, that is) [20:22:12] jackmcbarn: In core? [20:22:15] yes [20:22:19] Uh [20:22:28] I'm not sure, but that does sounds like a bug [20:22:33] jackmcbarn: Can you give an example? [20:22:52] countRevisionsBetween in title.php [20:23:55] jackmcbarn: Hm, I'm not totally sure [20:24:03] It seems like revision ID would be fine for that [20:24:23] jackmcbarn: I also suspect you could reasonably say that the difference would be nearly negligible [20:26:17] (03CR) 10Freakolowsky: [C: 031] "looks legit ... not much to test if the seq exists it will work" [core] - 10https://gerrit.wikimedia.org/r/105243 (owner: 10Umherirrender) [20:27:09] hey Nemo_bis, could ya approve my edit that adds translation tags? :P [20:27:33] https://www.mediawiki.org/wiki/Manual:Pywikibot/Installation [20:30:02] spagewmf: I think that labs-vagrant assumes that root/sudo is being used for everything it does [20:31:03] The vagrant user is just a side effect of borrowing from the vagrant codebase [20:31:26] marktraceur: i opened https://bugzilla.wikimedia.org/show_bug.cgi?id=59609 [20:31:33] Cool cool [20:33:06] jackmcbarn: Not interested in working on it? [20:34:25] i want a few more eyes on it first to make sure i'm not missing something obvious [20:34:32] but then i might [20:34:36] GEOFBOT: sorry but the tagging is completely wrong: commandline examples must not be translated, you need an empty line after each header, all that tortoiseSVN section is highly suspicious [20:34:53] please check the docs and other marked pages to see how that needs to be done [20:36:24] (03PS1) 10Umherirrender: Fix doc for Database::upsert [core] - 10https://gerrit.wikimedia.org/r/105266 [20:37:00] basile: are you here ? [20:37:52] oh lol [20:39:02] Nemo_bis: how do you exclude commadlines from translate? [20:39:06] just end the tag before it? [20:41:30] (03CR) 10Aaron Schulz: [C: 032] Fix doc for Database::upsert [core] - 10https://gerrit.wikimedia.org/r/105266 (owner: 10Umherirrender) [20:43:26] GEOFBOT: yep [20:47:12] (03Merged) 10jenkins-bot: Fix doc for Database::upsert [core] - 10https://gerrit.wikimedia.org/r/105266 (owner: 10Umherirrender) [20:51:49] (03CR) 10Legoktm: Allow SearchResults to specify that they matched file content (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105234 (owner: 10Chad) [20:52:30] VladAndrew: coolio, thanks [20:52:37] Nemo_bis: did I do it right now ? https://www.mediawiki.org/w/index.php?title=Manual:Pywikibot/Installation&stable=0&redirect=no [20:52:38] :P [20:55:18] (03CR) 10CSteipp: [C: 04-1] Autocreate global account after rename (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/102635 (owner: 10Legoktm) [20:56:06] GEOFBOT: no [20:56:20] check better, there are things like {{Main|Manual:Pywikipediabot/Gerrit}} [20:56:23] when changing a hook's parameters, what do i need to do to avoid breaking compatibility? [20:57:26] and what's all that stuff after: Patch for Windows - Patch: apply a diff file to an original [20:57:38] + all the packages names [20:58:05] long links which need tvar https://wikitech.wikimedia.org/w/index.php?title=Help:Move_your_bot_to_Labs&direction=prev&oldid=69904 [21:01:04] (03PS1) 10Jack Phoenix: Support the older video ID syntax. [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/105382 [21:04:37] (03PS5) 10Mayankmadan: getApiWarnings() throws an exception if upload is invalid [core] - 10https://gerrit.wikimedia.org/r/105111 [21:06:24] Nemo_bis: So exclude templates and code, and make long urls [21:06:26] OK [21:09:41] (03PS1) 10Jackmcbarn: Add oldRev parameter to DiffRevisionTools hook [core] - 10https://gerrit.wikimedia.org/r/105384 [21:10:09] (03CR) 10MarkTraceur: [C: 04-1] getApiWarnings() throws an exception if upload is invalid (032 comments) [core] - 10https://gerrit.wikimedia.org/r/105111 (owner: 10Mayankmadan) [21:11:25] (03CR) 10CSteipp: [C: 04-1] Moved account creation throttle to ping limiter (032 comments) [core] - 10https://gerrit.wikimedia.org/r/65867 (owner: 10Parent5446) [21:14:21] Nemo_bis: could you check it now? I think I got everything (I'm new to this kind of task :P) [21:20:00] (03CR) 10Anomie: [C: 04-1] "Main issue from PS2 still unaddressed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105111 (owner: 10Mayankmadan) [21:20:12] (03PS1) 10Manybubbles: Remove forceReindex [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105386 [21:21:56] typo needed)p [21:24:46] and still all those packages names [21:25:21] are you sure that the tortoisesvn part will be understandable, in what languages is that software available and how does it translate those ites [21:28:17] Nemo_bis: a lot of languages [21:28:18] http://tortoisesvn.net/translator_credits.html [21:29:37] hi anomie [21:30:17] anomie, what are the API modules that you are talking about? [21:32:03] GEOFBOT: also, I'd like someone from pwb to press the button, that's an important page for them and I don't want to mess with it if they don't agree; legoktm, maybe you could check the tagging of https://www.mediawiki.org/wiki/Manual:Pywikibot/Installation when it's ready? [21:33:30] (03CR) 10Dr0ptp4kt: "Moved array back into extracted function. Added documentation." [core] - 10https://gerrit.wikimedia.org/r/102344 (owner: 10Dr0ptp4kt) [21:35:04] (03PS1) 10Jackmcbarn: Remove misleading Thank button from some diffs [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/105387 [21:35:13] (03PS9) 10Dr0ptp4kt: Add support to get just the startup module URL with version. [core] - 10https://gerrit.wikimedia.org/r/102344 [21:38:29] (03PS6) 10Mayankmadan: getApiWarnings() throws an exception if upload is invalid [core] - 10https://gerrit.wikimedia.org/r/105111 [21:53:20] (03CR) 10CSteipp: [C: 04-1] "Tested and working, but I think I would like to see an error/exception if the return wasn't expected. Then I'm happy to merge this." (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98568 (owner: 10Anomie) [21:56:27] (03Abandoned) 10Mayankmadan: verifyUpload should be called before checkWarnings [core] - 10https://gerrit.wikimedia.org/r/104012 (owner: 10Mayankmadan) [21:57:34] (03PS3) 10Manybubbles: Support FlaggedRevs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104675 (owner: 10Chad) [22:00:25] (03CR) 10Manybubbles: [C: 04-1] "Amended to rebase, properly import FlaggableWikiPage, and start describing how to test it." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104675 (owner: 10Chad) [22:00:37] (03PS1) 10EBernhardson: Use 85% width for browsers > 1000px [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105390 [22:10:53] (03PS7) 10Mayankmadan: getApiWarnings() throws an exception if upload is invalid [core] - 10https://gerrit.wikimedia.org/r/105111 [22:12:00] (03CR) 10btongminh: "I agree with Anomie's main comments in PS2 about there being a reason that verifyUpload() is not called, but it is really complicated and " [core] - 10https://gerrit.wikimedia.org/r/105111 (owner: 10Mayankmadan) [22:12:45] oh hell why did we never make a flow chart of uploading [22:13:05] Bryan, how about the ps7 [22:13:41] mayankmadan_: well, like I said in the comment, it is complicated and I do not yet fully understand why we don't call verifyUpload() [22:13:55] when you tested this patch set, was the bug solved? [22:14:29] Bryan, ive become so confused that i dont think i even understand the bug anymore [22:14:54] mayankmadan_: were you able to reproduce the bug? [22:15:39] i.e., where you able to obtain the fatal exception that occurred in the bug report? [22:17:26] (03PS7) 10Worden.lee: Refactor Special:Upload for extensibility [core] - 10https://gerrit.wikimedia.org/r/67173 [22:18:04] oh how I hate debugging API write modules [22:19:46] is Michael stiff working with Kaltura/WMF? [22:19:50] *still [22:20:13] He is, Bryan! [22:20:22] Bryan, i cant [22:20:27] We've been in contact with him about it pretty recently [22:20:41] (03PS1) 10M4tx: Add support for more Flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 [22:20:58] oh nice, he might know more about the async uploading stuff [22:21:23] mayankmadan_: ok [22:21:37] Hm, maybe, he's not really active around here anymore though [22:21:40] it's good practice in general to test the bug first and see if you can reproduce it [22:21:56] and then test your patch to see if it solved the bug [22:24:24] (03CR) 10Mayankmadan: [C: 04-1] "There are some whitespace errors" (035 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx) [22:24:54] i need to get this task done asap [22:25:04] any ideas [22:26:18] marktraceur, Bryan ^ [22:26:22] well, first try to reproduce the bug [22:26:40] (03PS2) 10M4tx: Add support for more Flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 [22:26:44] because if you can't reproduce it, you can't be sure you fixed it [22:27:09] Bryan, when i try to select a file with blacklisted extension, it just wont select [22:27:33] this has nothing to do with blacklisting [22:28:29] Bryan, the bug says [22:28:29] if the title of the upload is invalid for [22:28:29] some reason (like it contains a blacklisted extension) [22:29:37] the bug says "UploadBase::checkWarnings could throw exception on null object access" [22:30:18] the blacklist thing is a reason that checkWarnings could throw an exception [22:30:29] but it will only happen in very unique circumstances [22:30:52] when you are doing an async upload with filekey and you hit the e.g. the blacklist [22:31:14] (03CR) 10Kaldari: "Haven't had a chance to test, but this looks like a heroic effort. It looks like this should cover just about any URL that anyone could po" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx) [22:31:20] but that is my presumption from analyzing the code [22:31:46] I haven't been able to test it yet, because debugging this is quite a pain [22:32:30] a phpunit should probably be written [22:33:13] hm [22:33:28] looks like it could also be thrown in chunked upload mode [22:36:20] (03CR) 10M4tx: "Hm... is it bad? I think that was the point of the bug report..." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 (owner: 10M4tx) [22:36:22] Bryan, i still dont get the bug now [22:38:26] I'm not sure how I can explain otherwise [22:38:30] it's a very complicated bug [22:40:17] (03CR) 10jenkins-bot: [V: 04-1] Refactor Special:Upload for extensibility [core] - 10https://gerrit.wikimedia.org/r/67173 (owner: 10Worden.lee) [22:41:27] (03Abandoned) 10CSteipp: Split password hasing and comparison out into a pluggable interface. [core] - 10https://gerrit.wikimedia.org/r/89031 (owner: 10CSteipp) [22:43:20] Bryan, i can reproduce the bug [22:43:31] Bryan, the bug says that the localfile is null [22:43:33] which is [22:44:08] when a file with a non supported extension is uploaded [22:45:44] ok [22:45:55] I'll try [22:46:20] Bryan, and to avoid that, verifyUpload function should be called before checkWarnings() is even executed, so that localFile cant be null [22:46:55] are you using Special:Upload or the API? [22:47:21] Bryan, special:upload [22:48:26] (03PS1) 10Manybubbles: Use Elasticsearch's new word counter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105394 [22:48:33] (03PS3) 10M4tx: Add support for more Flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105393 [22:48:52] hm. it just gives me the error about permitted file types, not fatal [22:48:58] perhaps if I disable JS [22:49:29] (03PS2) 10Manybubbles: Use Elasticsearch's new word counter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105394 [22:50:38] Bryan, how do you get the error? [22:51:18] ".gpx" is not a permitted file type. Permitted file types are png, gif, jpg, jpeg, webp. [22:51:38] File extension ".png" does not match the detected MIME type of the file (unknown/unknown). [22:51:55] Bryan, i dont get any error like that [22:52:17] so what kind of file are you uploading? [22:52:31] Bryan, exe [22:53:31] "Cannot upload this file because Internet Explorer would detect it as "application/x-msdownload", which is a disallowed and potentially dangerous file type." [22:53:50] well, I'm lost [22:55:58] Bryan, lets forget the bug for a moment here, the verifyUpload method should still always be called before checkWarnings because there will be warnings only if the file is valid [22:57:01] yes, but what I want to know is why checkWarnings() is called without verifyUpload() [22:57:43] Bryan, maybe its just a mistake [22:59:00] it is. but I want to know where in the call stack it is [22:59:10] *which callstack [23:01:58] oh damn [23:02:06] (03PS6) 10Alex Monk: Log use of DisableAccount [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/32577 [23:02:35] if filekey is set, ApiUpload:selectUploadModule() will always return false [23:02:46] so it's not the API apparently [23:02:50] fucking hell [23:03:21] (03PS2) 10Alex Monk: Cache VCS commit id/date text on Special:Version [core] - 10https://gerrit.wikimedia.org/r/95878 [23:03:58] so, wrong trail all along [23:04:49] (03PS1) 10Zfilipin: Updated Ruby, RubyGems and Firefox [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105400 [23:06:26] Bryan, so what could possibly be done? [23:08:15] sleeping [23:08:17] I'm not sufficiently awake for this anymore [23:08:25] what I said three lines up is wrong [23:08:32] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105400 (owner: 10Zfilipin) [23:09:43] (03PS1) 10Zfilipin: Updated Ruby, RubyGems and Firefox [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105401 [23:09:45] I shouldn't do this past midnight apparently [23:09:47] good night [23:09:53] good night [23:10:28] (03CR) 10Dr0ptp4kt: "Bug 59623 (https://bugzilla.wikimedia.org/show_bug.cgi?id=59623) submitted." [core] - 10https://gerrit.wikimedia.org/r/103407 (owner: 10Dr0ptp4kt) [23:23:15] (03PS3) 10Alex Monk: Cache VCS commit id/date text on Special:Version [core] - 10https://gerrit.wikimedia.org/r/95878 [23:26:32] (03PS1) 10Jdlrobson: Do not set the max width for special pages [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/105408 [23:30:15] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105401 (owner: 10Zfilipin) [23:30:17] (03PS1) 10CSteipp: Remove grant management sister-project warning [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/105411 [23:47:25] (03PS8) 10Nemo bis: Allow hiding patrol entries from Special:log for all users [core] - 10https://gerrit.wikimedia.org/r/42279 (owner: 10Brian Wolff) [23:48:11] (03CR) 10jenkins-bot: [V: 04-1] Allow hiding patrol entries from Special:Log for all users [core] - 10https://gerrit.wikimedia.org/r/42279 (owner: 10Brian Wolff) [23:53:13] (03PS1) 10Ori.livneh: Revert "Optimize all SVGs" [core] - 10https://gerrit.wikimedia.org/r/105413 [23:54:06] (03PS1) 10BryanDavis: Add CSRF protection [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/105414 [23:54:12] (03CR) 10Mglaser: [C: 031] "Looks fine. Thanks!" [core] - 10https://gerrit.wikimedia.org/r/105092 (owner: 10Jeroen De Dauw) [23:54:18] csteipp: ^^ [23:54:19] (03PS1) 10Ori.livneh: Revert "Optimize all SVGs" [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105415 [23:54:38] (03CR) 10CSteipp: [C: 032] Add CSRF protection [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/105414 (owner: 10BryanDavis) [23:55:07] (03Merged) 10jenkins-bot: Add CSRF protection [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/105414 (owner: 10BryanDavis) [23:56:23] (03CR) 10Ori.livneh: [C: 032 V: 032] Revert "Optimize all SVGs" [core] - 10https://gerrit.wikimedia.org/r/105413 (owner: 10Ori.livneh) [23:56:26] ori: you aware of the bug about that? [23:56:46] https://bugzilla.wikimedia.org/show_bug.cgi?id=59234 [23:56:47] MatmaRex: yeah, I am reverting to unbreak prod [23:56:54] the commit message explains the issue [23:57:02] and also why i didn't catch it during review [23:57:20] it works for everyone locally. but not in prod [23:57:26] crappy-ass servers we have [23:57:41] well, my first thought was also: let's update [23:57:50] but even if the WMF updates, that doesn't encompass the rest of the world [23:58:28] you can resubmit with a tweak to the root node or whatever to get it to be detected correctly [23:58:47] (03CR) 10Ori.livneh: [C: 032 V: 032] Revert "Optimize all SVGs" [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105415 (owner: 10Ori.livneh) [23:58:48] i have no idea what to do to get it to be detected [23:59:00] and frankly i have more interesting things to do [23:59:15] MatmaRex: that's fine, I'll try to look into it myself at some point [23:59:23] wmf has other people to worry about performance and lowering data transfer (/me looks at ori) [23:59:27] :D