[00:06:18] <theopolisme>	 Nemo_bis: swiftmailer does look quite interesting. I suppose it would be a _bit_ out of scope of the GCI task to look into adding it to mediawiki but would you have any problems with me doing so?
[00:07:14] <Nemo_bis>	 doesn't sound wise, or not in the same patch at least
[00:07:27] <Nemo_bis>	 could be a followup if it feels fun for you
[00:07:39] <theopolisme>	 Well yeah, I didn't mean in the same patch of course :p
[00:09:04] <theopolisme>	 Nemo_bis, I guess my point is, if we would open up vulnerabilities with the current patch and it wouldn't make sense to reinvent the wheel
[00:11:41] <Nemo_bis>	 well, it's probably enough to just apply a very strict escaping as they do
[00:12:11] <Nemo_bis>	 to get the patch approved without too much worries I mean
[00:12:28] <theopolisme>	 Make sense :) I suppose I'll just wait for PleaseStand's comments
[00:21:28] <grrrit-wm>	 (03PS1) 10TTO: Change "Massmessage" to "Mass message" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/104908 
[00:53:30] <grrrit-wm>	 (03PS1) 10Werdna: Fix issue with change 102154, one call to isAllowed was left. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104909 
[00:55:30] <ori>	 werdna: i'll merge https://gerrit.wikimedia.org/r/#/c/96949/ if you add a comment, per tto's request
[00:55:46] <werdna>	 oh cheers ori
[00:55:50] <werdna>	 I'll do that soon
[00:55:58] <werdna>	 currently trying to unbreak Flow before it rides the deployment train
[00:58:38] <ori>	 np, good luck
[01:01:37] <grrrit-wm>	 (03CR) 10Spage: [C: 04-1] "An improvement" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104909 (owner: 10Werdna)
[01:02:56] <grrrit-wm>	 (03CR) 10Werdna: Fix issue with change 102154, one call to isAllowed was left. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104909 (owner: 10Werdna)
[01:48:40] <grrrit-wm>	 (03PS2) 10Werdna: Fix issue with change 102154, one call to isAllowed was left. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104909 
[01:48:42] <grrrit-wm>	 (03PS1) 10Werdna: When executing an action on a post, just replace the .flow-post, not the whole .flow-post-container. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104910 
[01:59:25] <grrrit-wm>	 (03PS1) 10Werdna: Fix fatal error comparing revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104911 
[02:13:29] <grrrit-wm>	 (03PS2) 10Werdna: Post content with more than 5 lines is showing a scrollbar [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104758 (owner: 10Bsitu)
[02:13:52] <grrrit-wm>	 (03CR) 10Werdna: [C: 032] "PS2: Rebase and added comment." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104758 (owner: 10Bsitu)
[02:13:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Post content with more than 5 lines is showing a scrollbar [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104758 (owner: 10Bsitu)
[02:23:02] <grrrit-wm>	 (03CR) 10Spage: [C: 032] "A style issue, but ship it!" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104909 (owner: 10Werdna)
[02:23:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix issue with change 102154, one call to isAllowed was left. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104909 (owner: 10Werdna)
[04:29:49] <ori>	 do we support big-endian systems?
[04:40:18] <grrrit-wm>	 (03PS7) 10Santhosh: Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 
[04:50:00] <grrrit-wm>	 (03CR) 10Santhosh: "All tests pass now." [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh)
[05:56:59] <grrrit-wm>	 (03PS1) 1001tonythomas: Leading semicolon line-bolding made visible in printable version [core] - 10https://gerrit.wikimedia.org/r/104913 
[06:09:30] <grrrit-wm>	 (03PS1) 10Spage: Improve fix comment. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104914 
[07:00:02] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Change "Massmessage" to "Mass message" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/104908 (owner: 10TTO)
[07:00:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Change "Massmessage" to "Mass message" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/104908 (owner: 10TTO)
[07:02:21] <grrrit-wm>	 (03CR) 10Parent5446: [C: 04-1] "Note that this patch does not actually enable [[Category:Cat|Key|Label]] syntax. The parser still needs to be adjusted to enable that." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/104905 (owner: 10Gomoko)
[07:04:59] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "Inconsistency in protocol for links and link targets for the same concept." (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/104907 (owner: 10M4tx)
[07:08:03] <grrrit-wm>	 (03CR) 10Parent5446: Visualize profile output in debug toolbar (032 comments) [core] - 10https://gerrit.wikimedia.org/r/104318 (owner: 10EBernhardson)
[07:09:07] <grrrit-wm>	 (03CR) 10Siebrand: Update plural rules to CLDR 24 (032 comments) [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh)
[07:10:13] <grrrit-wm>	 (03CR) 10Parent5446: [C: 031] "Looks good except for Siebrand's comment. Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/104711 (owner: 10Legoktm)
[07:11:37] <grrrit-wm>	 (03CR) 10MZMcBride: "Does this have an associated bug report?" [core] - 10https://gerrit.wikimedia.org/r/104905 (owner: 10Gomoko)
[07:35:13] <mayankmadan>	 hi  Nemo_bis 
[07:44:56] <grrrit-wm>	 (03PS3) 10Nullzero: make MOVED_TO* working [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104706 
[07:50:35] <mayankmadan>	 wm-bot, what is the answer to everything
[07:50:44] <mayankmadan>	 :)
[07:53:32] <grrrit-wm>	 (03PS4) 10Nullzero: make MOVED_TO* working [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104706 
[07:58:13] <grrrit-wm>	 (03PS5) 10Nullzero: make MOVED_TO* working [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104706 
[08:07:49] <grrrit-wm>	 (03PS1) 10Physikerwelt: Connect to db2 and import the math table there [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/104916 
[08:08:38] <Nemo_bis>	 42
[08:17:23] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "Created job labs-toollabs-debian-glue" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/104748 (owner: 10Tim Landscheidt)
[08:19:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add job for labs/toollabs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104747 (owner: 10Tim Landscheidt)
[08:39:03] <grrrit-wm>	 (03PS1) 10Nemo bis: Complete initial FirstSteps import [extensions/FirstSteps] - 10https://gerrit.wikimedia.org/r/104918 
[08:40:21] <grrrit-wm>	 (03PS2) 10Nemo bis: Complete initial FirstSteps import [extensions/FirstSteps] - 10https://gerrit.wikimedia.org/r/104918 
[08:40:46] <hashar>	 Nemo_bis: jenkins is restarting
[08:48:01] <Nemo_bis>	 :)
[08:48:36] <grrrit-wm>	 (03PS8) 10Santhosh: Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 
[08:49:12] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] translatewiki-issues [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/104801 (owner: 10Dan-nl)
[08:51:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh)
[08:52:29] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] translatewiki-issues [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/104801 (owner: 10Dan-nl)
[08:57:16] <grrrit-wm>	 (03PS2) 10M4tx: Add support for new MobileFrontend copyright warnings [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/104907 
[08:57:47] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add support for new MobileFrontend copyright warnings [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/104907 (owner: 10M4tx)
[09:00:44] <grrrit-wm>	 (03PS8) 10Siebrand: Throw exception for unknown field in SpecialListfiles::formatValue() [core] - 10https://gerrit.wikimedia.org/r/104058 
[09:02:56] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Throw exception for unknown field in SpecialListfiles::formatValue() [core] - 10https://gerrit.wikimedia.org/r/104058 (owner: 10Siebrand)
[09:03:45] <grrrit-wm>	 (03CR) 10Siebrand: "Jenkins is down at the moment, so can't be verified." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104058 (owner: 10Siebrand)
[09:05:04] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/104907 (owner: 10M4tx)
[09:06:35] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh)
[09:08:44] <grrrit-wm>	 (03CR) 10Siebrand: "Nemo: Just for clarity, I'd make this two patch sets. One with what was removed from Translate, and one with the changes you specified. Yo" [extensions/FirstSteps] - 10https://gerrit.wikimedia.org/r/104918 (owner: 10Nemo bis)
[09:11:15] <grrrit-wm>	 (03PS9) 10Santhosh: Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 
[09:13:00] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] "After https://gerrit.wikimedia.org/r/#/c/102491/, we can remove $user in there completely." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104911 (owner: 10Werdna)
[09:13:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix fatal error comparing revisions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104911 (owner: 10Werdna)
[09:15:08] <mayankmadan>	 Nemo_bis, around?
[09:42:29] <grrrit-wm>	 (03CR) 10Santhosh: "Please abandon this change since I46ab3dadc7fe08c1e60bbd81a1ee841e166e9608 changed the plural rules and no tests are skipped now." [core] - 10https://gerrit.wikimedia.org/r/97337 (owner: 10Platonides)
[09:43:37] <grrrit-wm>	 (03PS3) 10Umherirrender: No variable assignment on return statement [core] - 10https://gerrit.wikimedia.org/r/104815 
[09:49:23] <grrrit-wm>	 (03PS9) 10Hashar: Throw exception for unknown field in SpecialListfiles::formatValue() [core] - 10https://gerrit.wikimedia.org/r/104058 (owner: 10Siebrand)
[10:08:07] <grrrit-wm>	 (03PS8) 10TheDJ: CodeEditor: Update to package 12.02.2013 (December 2013) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104510 
[10:08:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] CodeEditor: Update to package 12.02.2013 (December 2013) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104510 (owner: 10TheDJ)
[10:11:48] <grrrit-wm>	 (03PS9) 10TheDJ: CodeEditor: Update to package 12.02.2013 (December 2013) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104510 
[10:14:36] <grrrit-wm>	 (03PS10) 10Santhosh: Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 
[10:16:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh)
[10:19:01] <grrrit-wm>	 (03PS1) 10Umherirrender: Give error on account creation when user name is adjust silence [core] - 10https://gerrit.wikimedia.org/r/104926 
[10:27:23] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Fix FlowSetUserIp to run against larger-than-mBatchSize revision sets [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104927 
[10:27:46] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 04-1] Update plural rules to CLDR 24 (037 comments) [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh)
[10:29:30] <grrrit-wm>	 (03CR) 10Nikerabbit: Give error on account creation when user name is adjust silence (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender)
[10:34:53] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 04-1] Add Title::hasFragment and use it (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104750 (owner: 10Umherirrender)
[10:45:51] <grrrit-wm>	 (03PS1) 10Umherirrender: Add JobQueueDB::selectFields and use it [core] - 10https://gerrit.wikimedia.org/r/104928 
[10:49:14] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Automatically run FlowSetUserIp on update.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104930 
[10:49:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Automatically run FlowSetUserIp on update.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104930 (owner: 10Matthias Mullie)
[10:51:13] <grrrit-wm>	 (03CR) 10Umherirrender: Add Title::hasFragment and use it (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104750 (owner: 10Umherirrender)
[10:56:01] <grrrit-wm>	 (03PS2) 10Matthias Mullie: Automatically run FlowSetUserIp on update.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104930 
[10:57:59] <grrrit-wm>	 (03PS1) 10Matthias Mullie: [Untested] Drop sqlite-specific script to add *_user_ip columns [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104931 
[10:58:27] <grrrit-wm>	 (03CR) 10Nikerabbit: Add Title::hasFragment and use it (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104750 (owner: 10Umherirrender)
[11:00:20] <grrrit-wm>	 (03PS2) 10Umherirrender: Change Title::getInterwiki() in conditions to Title::isExternal() [core] - 10https://gerrit.wikimedia.org/r/104753 
[11:02:06] <grrrit-wm>	 (03CR) 10Umherirrender: "Patch Set 2: Found also some checks in Title.php self." [core] - 10https://gerrit.wikimedia.org/r/104753 (owner: 10Umherirrender)
[11:06:13] <grrrit-wm>	 (03CR) 10Umherirrender: Add Title::hasFragment and use it (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104750 (owner: 10Umherirrender)
[11:08:32] <grrrit-wm>	 (03CR) 10Nikerabbit: Return void for LogPager::limitPerformer and limitTitle (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104022 (owner: 10Siebrand)
[11:10:32] <grrrit-wm>	 (03CR) 10Nikerabbit: Add Title::hasFragment and use it (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104750 (owner: 10Umherirrender)
[11:11:39] <grrrit-wm>	 (03PS1) 10Hashar: beta-parsoid-update job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/104933 
[11:11:48] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] beta-parsoid-update job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/104933 (owner: 10Hashar)
[11:13:30] <grrrit-wm>	 (03PS2) 10Hashar: beta-parsoid-update job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/104933 
[11:17:08] <grrrit-wm>	 (03PS2) 10Umherirrender: Add Title::hasFragment and use it [core] - 10https://gerrit.wikimedia.org/r/104750 
[11:17:59] <grrrit-wm>	 (03CR) 10Umherirrender: "Patch Set 2: Set default value for mFragment and changed comparsion" [core] - 10https://gerrit.wikimedia.org/r/104750 (owner: 10Umherirrender)
[11:25:30] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Use AbstractRevision::getRevisionType instead of array['rev_type'] [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104935 
[11:29:29] <grrrit-wm>	 (03PS1) 10Umherirrender: Change Title::isExternal to use strict comparsion [core] - 10https://gerrit.wikimedia.org/r/104936 
[11:37:09] <grrrit-wm>	 (03PS3) 10Hashar: beta-parsoid-update job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/104933 
[11:38:20] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Improve code to update related revision tables [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104939 
[12:05:55] <grrrit-wm>	 (03PS2) 10IAlex: Fix bad usage of empty() function [core] - 10https://gerrit.wikimedia.org/r/104810 
[12:07:27] <grrrit-wm>	 (03CR) 10IAlex: Fix bad usage of empty() function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104810 (owner: 10IAlex)
[12:11:47] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Fix small errors in board history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104942 
[12:13:33] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Use container namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104943 
[12:15:24] <grrrit-wm>	 (03PS1) 10IAlex: Misc fixes to UploadSourceField [core] - 10https://gerrit.wikimedia.org/r/104944 
[12:27:13] <grrrit-wm>	 (03PS3) 10Matthias Mullie: Automatically run FlowSetUserIp on update.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104930 
[12:33:03] <grrrit-wm>	 (03PS2) 10Dan-nl: translatewiki-issues [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/104801 
[12:34:40] <grrrit-wm>	 (03CR) 10Dan-nl: [C: 032 V: 032] "attempting to run this through integration again." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/104801 (owner: 10Dan-nl)
[12:40:42] <mayankmadan__>	 Nemo_bis, around?
[12:55:10] <grrrit-wm>	 (03CR) 10Amire80: [C: 04-2] "Crashes if wgLanguageCode = "sr";" [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh)
[13:04:16] <grrrit-wm>	 (03PS11) 10Nikerabbit: Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh)
[13:06:18] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh)
[13:26:18] <Nemo_bis>	 mayankmadan__: only partly
[13:27:01] <mayankmadan__>	 Nemo_bis, i still cant figure out how to return the values of result.upload.stage
[13:27:06] <mayankmadan__>	 btw what type is result
[13:27:42] <grrrit-wm>	 (03PS6) 10Aude: Avoid interacting with LBFactory singleton in tests [core] - 10https://gerrit.wikimedia.org/r/104473 
[13:28:29] <grrrit-wm>	 (03CR) 10Aude: Avoid interacting with LBFactory singleton in tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104473 (owner: 10Aude)
[13:31:33] <Tuxedo_>	 Yesterday I wrote:
[13:31:36] <Tuxedo_>	 After installing a current stable MW 1.22 (with PHP 5.3.18/MySQL 5.1.50 on a Unix) I get a warning at at the
[13:31:37] <Tuxedo_>	 "Generating secret keys..." stage:
[13:31:38] <Tuxedo_>	 "Warning: mcrypt_create_iv() [function.mcrypt-create-iv]: Cannot open source device in /htdocs/wiki/includes/MWCryptRand.php on line 313
[13:31:39] <Tuxedo_>	 Secure keys ($wgSecretKey and $wgUpgradeKey) generated during installation are not completely safe. Consider changing them manually." ...
[13:31:41] <Tuxedo_>	 The MW installation completes successfully, however, the same errors reappears while browsing the wiki at for example a Log in page.
[13:31:42] <Tuxedo_>	 By the way, line 313 in MWCryptRand.php is this:
[13:31:44] <Tuxedo_>	 $iv = mcrypt_create_iv( $rem, MCRYPT_DEV_URANDOM );
[13:31:45] <Tuxedo_>	 After looking into my notes from earlier installations, I dicsovered had the same issue on a 1.20.3 installation last year. The workaround was then and still is to replace 'MCRYPT_DEV_URANDOM' with 'MCRYPT_RAND' at line 313 in CryptRandom.php (or now in MWCryptRandom.php) as suggested at the end of the follwing thread:
[13:31:47] <Tuxedo_>	 http://www.mediawiki.org/wiki/Thread:Project:Support_desk/mcrypt_create_iv()_function.mcrypt-create-iv_:_Cannot_open_source_device
[13:31:48] <Tuxedo_>	 I guess it's a bug, at least when installing MW on certain systems, or it's something related to PHP 5.3.18 maybe getting a bit too outdated for current MW versions. I wouldn't know.
[13:31:50] <Tuxedo_>	 Tuxedo
[13:36:16] <grrrit-wm>	 (03PS7) 10UltrasonicNXT: Consistency tweaks in preparatation for adding extension to translatewiki.net [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/102679 (owner: 10Raimond Spekking)
[13:36:46] <grrrit-wm>	 (03CR) 10UltrasonicNXT: "(That was just a rebase)" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/102679 (owner: 10Raimond Spekking)
[13:46:46] <grrrit-wm>	 (03PS12) 10Nikerabbit: Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh)
[13:51:23] <Nemo_bis>	 mayankmadan__: I know nothing of types, you'd better ask on the patch
[13:56:28] <grrrit-wm>	 (03CR) 10Mayankmadan: Adding code comments of resulting keys (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/104782 (owner: 10Mayankmadan)
[13:59:44] <grrrit-wm>	 (03PS1) 10Physikerwelt: use transactions for faster import [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/104952 
[14:00:08] <grrrit-wm>	 (03CR) 10Nemo bis: "Right, stupid rename diffs. I'll see, in the meanwhile I noted what I changed." (035 comments) [extensions/FirstSteps] - 10https://gerrit.wikimedia.org/r/104918 (owner: 10Nemo bis)
[14:01:30] <siebrand>	 Reedy: I created https://www.mediawiki.org/wiki/PhpStorm
[14:01:49] <siebrand>	 Reedy: From what I could(n't) find, there was no information on this yet.
[14:02:27] <grrrit-wm>	 (03CR) 10Amire80: [C: 04-1] "The fatal with 'sr' is fixed." [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh)
[14:05:07] <grrrit-wm>	 (03CR) 10Siebrand: Return void for LogPager::limitPerformer and limitTitle (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104022 (owner: 10Siebrand)
[14:09:22] <grrrit-wm>	 (03CR) 10Tim Landscheidt: "The "experimental" side to this is very much understood :-). Bad at the moment: tests/testsuite.log isn't preserved so fixing tests is ha" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/104748 (owner: 10Tim Landscheidt)
[14:10:39] <grrrit-wm>	 (03CR) 10Santhosh: "Ok, that is the impact of the patch.(also noted in commit message)." [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh)
[14:11:10] <grrrit-wm>	 (03PS4) 10Siebrand: Update RELEASE-NOTES [core] - 10https://gerrit.wikimedia.org/r/104718 
[14:13:25] <grrrit-wm>	 (03PS2) 10Siebrand: Update documentation for ParserCache::save() [core] - 10https://gerrit.wikimedia.org/r/104518 
[14:15:08] <grrrit-wm>	 (03CR) 10Physikerwelt: [C: 032 V: 032] Connect to db2 and import the math table there [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/104916 (owner: 10Physikerwelt)
[14:15:42] <grrrit-wm>	 (03CR) 10Physikerwelt: [C: 032 V: 032] use transactions for faster import [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/104952 (owner: 10Physikerwelt)
[14:16:17] <grrrit-wm>	 (03PS4) 10Siebrand: Update documentation for SpecialPage and SpecialPageFactory [core] - 10https://gerrit.wikimedia.org/r/104404 
[14:18:05] <grrrit-wm>	 (03PS3) 10Siebrand: Remove methods from SpecialPage deprecated in 1.17 and 1.18 [core] - 10https://gerrit.wikimedia.org/r/104396 
[14:20:45] <grrrit-wm>	 (03PS4) 10Siebrand: Remove methods from SpecialPage deprecated in 1.17 and 1.18 [core] - 10https://gerrit.wikimedia.org/r/104396 
[14:23:51] <grrrit-wm>	 (03PS2) 10TheDJ: [WIP] tablesorter: testcases for the parsers [core] - 10https://gerrit.wikimedia.org/r/99407 
[14:29:45] <mayankmadan__>	 hi MatmaRex 
[14:35:54] <hashar>	 does anyone know how to clear the resource loader cache by any chance ?
[14:36:33] <grrrit-wm>	 (03PS13) 10Santhosh: Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 
[14:40:05] <grrrit-wm>	 (03CR) 10Santhosh: Update plural rules to CLDR 24 (037 comments) [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh)
[14:40:45] <grrrit-wm>	 (03PS14) 10Santhosh: Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 
[14:41:58] <grrrit-wm>	 (03PS15) 10Santhosh: Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 
[14:53:07] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "here we go" [core] - 10https://gerrit.wikimedia.org/r/104058 (owner: 10Siebrand)
[14:56:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Throw exception for unknown field in SpecialListfiles::formatValue() [core] - 10https://gerrit.wikimedia.org/r/104058 (owner: 10Siebrand)
[14:58:58] <grrrit-wm>	 (03PS3) 10TheDJ: add max-width to vector skin [core] - 10https://gerrit.wikimedia.org/r/103744 (owner: 10Hatul)
[15:01:58] <MatmaRex>	 hashar: php maintenance/update.php (if you still need an answer)
[15:02:33] <MatmaRex>	 unless you mean in Wikimedia environment, then you could clear object cache entries whose keys match the ones used by resourceloader
[15:03:56] <hashar>	 MatmaRex: ahhhh
[15:04:09] <hashar>	 i would delegate with people having actual clues about RL so :-D
[15:04:15] <hashar>	 i am getting old
[15:04:52] <MatmaRex>	 hashar: at least, i think update.php will clear it :) it's supposed to clear all caches
[15:05:17] <MatmaRex>	 but i can't with absolute certainty say it works with every kind of cache mediawiki might use, it certainly wotks for db cache
[15:05:35] <hashar>	 should not clear redis/ memcached though
[15:11:06] <Joeytje50>	 hey guys, I'm looking at https://www.mediawiki.org/wiki/Manual:Tag_extensions#Attributes
[15:11:45] <Joeytje50>	 and I'm wondering, where can I find information about the Parser and PPFrame objects?
[15:12:57] <Joeytje50>	 because I want to make an extension that works like <tag1> <tag2></tag2> <tag2></tag2> </tag1>
[15:13:30] <Joeytje50>	 so I was wondering if either of those objects would be useful in helping me get those tag2s only to do something when they're inside <tag1>
[15:14:07] <grrrit-wm>	 (03PS1) 10Reedy: Remove db2 support, core MW did this a while ago [extensions/Math] - 10https://gerrit.wikimedia.org/r/104960 
[15:14:26] <MatmaRex>	 Joeytje50: you could look at how the Cite extension works
[15:14:43] <MatmaRex>	 Joeytje50: it changes the meaning of the <ref> tag depending on whether it's "free" or inside a <references> tag
[15:14:54] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] Remove db2 support, core MW did this a while ago [extensions/Math] - 10https://gerrit.wikimedia.org/r/104960 (owner: 10Reedy)
[15:14:56] <MatmaRex>	 it also prevents nesting <ref>s
[15:15:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove db2 support, core MW did this a while ago [extensions/Math] - 10https://gerrit.wikimedia.org/r/104960 (owner: 10Reedy)
[15:15:04] <Joeytje50>	 ah okay thanks, I'll check that out
[15:15:18] <Joeytje50>	 usually an example is more useful anyway
[15:15:41] <hoo>	 yay for unrelated failure
[15:15:42] <hoo>	 s
[15:16:08] <hoo>	 Reedy: ^
[15:16:42] <Reedy>	 hoo: It's not related...
[15:16:50] <Reedy>	 15:15:09 1) MathLaTeXMLTest::testIntegration
[15:16:50] <Reedy>	 15:15:09 Rendering of a+b in plain Text mode
[15:16:50] <Reedy>	 15:15:09 Failed asserting that two strings are equal.
[15:16:59] <hoo>	 Reedy: I know
[15:17:06] <hoo>	 (04:15:41 PM) hoo: yay for unrelated failure
[15:17:11] <Reedy>	 heh
[15:17:26] <hoo>	 shall I force merge?
[15:19:20] <Reedy>	 I would do
[15:19:30] <Reedy>	 I guess one of us should open a bug for the test failure though
[15:19:51] <Reedy>	 I'll do the latter ;)
[15:20:08] <grrrit-wm>	 (03CR) 10Hoo man: [V: 032] "Forcing merge, due to (unrelated) test failures" [extensions/Math] - 10https://gerrit.wikimedia.org/r/104960 (owner: 10Reedy)
[15:20:12] <hoo>	 Fine :)
[15:21:40] <Joeytje50>	 MatmaRex: do you perhaps know a shorter tag that does the same-ish thing with nested tags? Cite is huge
[15:21:59] <MatmaRex>	 Joeytje50: i'm not aware of any off the top of my head, sorry :(
[15:22:15] <Joeytje50>	 okay, thanks anywat
[15:22:17] <Joeytje50>	 anyway*
[15:23:54] <grrrit-wm>	 (03CR) 10Reedy: [C: 04-1] Moved MappedIterator to /libs (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104779 (owner: 10Aaron Schulz)
[15:29:50] <Reedy>	 hoo: There's already a patch for the broken test! ;)
[15:30:53] <Reedy>	 Oh
[15:30:53] <Reedy>	 https://gerrit.wikimedia.org/r/#/c/85801/
[15:30:55] <Reedy>	 Scary revision ;)
[15:32:01] <hoo>	 +61243, -10950
[15:32:05] <hoo>	 a little big, actually
[15:34:49] <grrrit-wm>	 (03PS1) 10Tim Landscheidt: Define labs-toollabs-debbuild and dump tests/testsuite.log on failure [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/104964 
[15:35:28] <grrrit-wm>	 (03PS2) 10Tim Landscheidt: Define labs-toollabs-debbuild and dump tests/testsuite.log on failure [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/104964 
[15:38:44] <grrrit-wm>	 (03Abandoned) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt)
[15:44:45] <grrrit-wm>	 (03PS4) 10Hashar: beta-parsoid-update job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/104933 
[15:45:33] <grrrit-wm>	 (03PS1) 10Hashar: update Parsoid service on beta cluster [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104967 
[15:47:07] <grrrit-wm>	 (03PS1) 10Hashar: dashboard: add beta-parsoid-update [integration/docroot] - 10https://gerrit.wikimedia.org/r/104968 
[15:47:22] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] beta-parsoid-update job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/104933 (owner: 10Hashar)
[15:47:34] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] update Parsoid service on beta cluster [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104967 (owner: 10Hashar)
[15:47:44] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] dashboard: add beta-parsoid-update [integration/docroot] - 10https://gerrit.wikimedia.org/r/104968 (owner: 10Hashar)
[15:47:57] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] dashboard: add beta-parsoid-update [integration/docroot] - 10https://gerrit.wikimedia.org/r/104968 (owner: 10Hashar)
[15:48:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: update Parsoid service on beta cluster [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104967 (owner: 10Hashar)
[15:48:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: beta-parsoid-update job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/104933 (owner: 10Hashar)
[15:49:36] <grrrit-wm>	 (03PS3) 10Tim Landscheidt: Define labs-toollabs-debbuild separately [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/104964 
[15:50:39] <grrrit-wm>	 (03PS4) 10Tim Landscheidt: Define labs-toollabs-debbuild separately [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/104964 
[15:51:23] <mayankmadan__>	 MatmaRex, around?
[15:51:40] <grrrit-wm>	 (03CR) 10Hashar: "again" [integration/docroot] - 10https://gerrit.wikimedia.org/r/104968 (owner: 10Hashar)
[15:52:17] <grrrit-wm>	 (03CR) 10Hashar: [V: 032] dashboard: add beta-parsoid-update [integration/docroot] - 10https://gerrit.wikimedia.org/r/104968 (owner: 10Hashar)
[15:52:27] <MatmaRex>	 mayankmadan_: hi. yeah, but a little busy :) what's up?
[15:52:58] <mayankmadan__>	 MatmaRex, nothing much, but please ping me when you are free
[15:53:52] <MatmaRex>	 mayankmadan_: go ahead :)
[15:54:45] <mayankmadan__>	 MatmaRex, can you have a look at https://gerrit.wikimedia.org/r/#/c/104782/1/resources/mw.UploadWizardDetails.js
[15:55:17] <mayankmadan__>	 MatmaRex, i need to know what values can be returned by mw.message( 'mwe-upwiz-' + result.upload.stage ).text() 
[15:57:09] <MatmaRex>	 mayankmadan_: strings, generally?
[15:57:25] <MatmaRex>	 or do you mean the possible messages?
[15:57:53] <MatmaRex>	 i have no idea off-hand, you should check what values result.upload.stage might have
[15:58:22] <mayankmadan__>	 MatmaRex, thats what im trying to check
[15:58:37] <mayankmadan__>	 MatmaRex, but i find no way of doing that
[15:59:13] <MatmaRex>	 well, there's usually no obvious, easy way, apart from figuring out the code :(
[15:59:16] <grrrit-wm>	 (03PS1) 10Reedy: WIP Retry commands if failed [tools/release] - 10https://gerrit.wikimedia.org/r/104970 
[15:59:37] <MatmaRex>	 hmm, in this case you could try to
[16:00:05] <MatmaRex>	 (wait, i need to download the repository)
[16:00:21] <grrrit-wm>	 (03PS1) 10Hashar: update parsoid on beta when deploy is updated [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104971 
[16:00:40] <MatmaRex>	 mayankmadan_: basically, the messages used in JavaScript should be listed in the ResourceLoader module definitions
[16:00:53] <MatmaRex>	 somewhere in UploadWizard.php
[16:01:15] <MatmaRex>	 so that should at least limit the possibilities :)
[16:02:48] <mayankmadan__>	 MatmaRex, this was the bug https://bugzilla.wikimedia.org/show_bug.cgi?id=54524
[16:03:14] <mayankmadan__>	 MatmaRex, what i have to do is find all the possible values of that and add it in code comments
[16:03:53] <grrrit-wm>	 (03CR) 10Tim Landscheidt: [C: 04-1] "I think I got the wrong job hook." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/104964 (owner: 10Tim Landscheidt)
[16:04:24] <grrrit-wm>	 (03CR) 10Aklapper: [C: 04-1] "I had a chat with Geek400 on IRC, linked to https://en.wikipedia.org/wiki/Foobar (as "1, foo" was mentioned in the Google task description" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/104208 (owner: 10Geek400)
[16:05:04] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] update parsoid on beta when deploy is updated [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104971 (owner: 10Hashar)
[16:05:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: update parsoid on beta when deploy is updated [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104971 (owner: 10Hashar)
[16:07:27] <grrrit-wm>	 (03PS2) 10TheDJ: Add .gitignore to the /skins directory [core] - 10https://gerrit.wikimedia.org/r/104784 (owner: 10Huji)
[16:10:31] <MatmaRex>	 mayankmadan_: i'm afraid there's no trivial way to do this, you;ll have to understand the code that generates this :) (if it were trivial, we'd have automated it already ;) )
[16:10:44] <Tuxedo_>	 In doing a fresh MW 1.22 install I'm trying to enable copy uploads but for some odd reason I don't seem to be able to get the 'Source URL' input field to appear after adding this in LocalSettings.php:
[16:10:46] <Tuxedo_>	 $wgGroupPermissions['*']['upload_by_url'] = true;
[16:10:47] <Tuxedo_>	 $wgAllowCopyUploads = true;
[16:12:33] <Tuxedo_>	 Did something change with this since 1.20.x?
[16:14:47] <Reedy>	 From ssh://gerrit.wikimedia.org:29418/mediawiki/core
[16:14:47] <Reedy>	  * branch            refs/changes/66/22466/13 -> FETCH_HEAD
[16:14:47] <Reedy>	 'git' 'cherry-pick' 'FETCH_HEAD'
[16:14:47] <Reedy>	 error: could not apply 263e016... Commit of various wmf-branch live hacks
[16:14:49] <Reedy>	 hint: after resolving the conflicts, mark the corrected paths
[16:14:51] <Reedy>	 hint: with 'git add <paths>' or 'git rm <paths>'
[16:14:53] <Reedy>	 hint: and commit the result with 'git commit'
[16:14:55] <Reedy>	 git exit with status 1
[16:14:57] <Reedy>	 grumble
[16:15:45] <grrrit-wm>	 (03Restored) 10Reedy: Commit of various wmf-branch live hacks [core] - 10https://gerrit.wikimedia.org/r/22466 (owner: 10Reedy)
[16:19:22] * Reedy  glares at AaronSchulz

[16:19:47] <grrrit-wm>	 (03PS14) 10Reedy: Commit of various wmf-branch live hacks [core] - 10https://gerrit.wikimedia.org/r/22466 
[16:20:00] <grrrit-wm>	 (03PS1) 10Subramanya Sastry: Added Maria Pacana to trusted users for check/test pipeline [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104973 
[16:21:42] <grrrit-wm>	 (03PS1) 10Subramanya Sastry: Make parsoidsvc Jenkins jobs voting. [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104974 
[16:21:54] <grrrit-wm>	 (03Abandoned) 10Reedy: Commit of various wmf-branch live hacks [core] - 10https://gerrit.wikimedia.org/r/22466 (owner: 10Reedy)
[16:22:53] <grrrit-wm>	 (03PS1) 10Reedy: void methods don't return anything. Especially when they always throw an exception [core] - 10https://gerrit.wikimedia.org/r/104975 
[16:22:57] <grrrit-wm>	 (03CR) 10Subramanya Sastry: "gwicke fyi." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104974 (owner: 10Subramanya Sastry)
[16:24:01] <grrrit-wm>	 (03PS1) 10Reedy: Live hacks to patch set 14 [tools/release] - 10https://gerrit.wikimedia.org/r/104977 
[16:24:15] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Live hacks to patch set 14 [tools/release] - 10https://gerrit.wikimedia.org/r/104977 (owner: 10Reedy)
[16:24:36] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] void methods don't return anything. Especially when they always throw an exception [core] - 10https://gerrit.wikimedia.org/r/104975 (owner: 10Reedy)
[16:24:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Live hacks to patch set 14 [tools/release] - 10https://gerrit.wikimedia.org/r/104977 (owner: 10Reedy)
[16:28:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: void methods don't return anything. Especially when they always throw an exception [core] - 10https://gerrit.wikimedia.org/r/104975 (owner: 10Reedy)
[16:34:10] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] "Okay, you don't need to deprecate it for now." [core] - 10https://gerrit.wikimedia.org/r/95962 (owner: 10Bartosz Dziewoński)
[16:37:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: jquery.client: Component-wise version comparison in #test with strings [core] - 10https://gerrit.wikimedia.org/r/95962 (owner: 10Bartosz Dziewoński)
[16:38:45] <grrrit-wm>	 (03CR) 10Chad: "Yeah, but I figured we can at least get the index *created* so any updates people make would immediately start going into effect (and won'" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/104774 (owner: 10Chad)
[16:42:15] <grrrit-wm>	 (03CR) 10Reedy: "1 step done automatically at new wiki creation time too is nice rather than poking ops/rt ticket :)" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/104774 (owner: 10Chad)
[16:43:44] <udayan>	 can anyone suggest me with any simple bugs to start with?
[16:44:00] <marktraceur>	 !easy
[16:44:00] <wm-bot>	 Bugzilla maintains a list of easy bugs for us, that are considered a good first step for new MediaWiki developers. See https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=keyword%3Aeasy for the list.
[16:44:07] <marktraceur>	 udayan: ^^
[16:45:19] <udayan>	 thank you sir.Will look into it
[16:45:39] <marktraceur>	 Yup yup
[16:53:47] <grrrit-wm>	 (03PS1) 10UltrasonicNXT: Prevent the div.comments-body being overwritten [extensions/Comments] - 10https://gerrit.wikimedia.org/r/104980 
[16:54:50] <grrrit-wm>	 (03PS7) 10Mattflaschen: [WIP] Add Agora mw-ui-button classes to various buttons [core] - 10https://gerrit.wikimedia.org/r/52169 
[16:55:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add Agora mw-ui-button classes to various buttons [core] - 10https://gerrit.wikimedia.org/r/52169 (owner: 10Mattflaschen)
[16:55:53] <grrrit-wm>	 (03CR) 10Siebrand: "I replied to the inline comment. Since there is no score, I have no idea what to do. I'll add more reviewers." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104528 (owner: 10Siebrand)
[16:56:48] <grrrit-wm>	 (03PS1) 10Reedy: Convert global function comments to blocks with param types [extensions/UnicodeConverter] - 10https://gerrit.wikimedia.org/r/104981 
[16:56:51] <^d>	 Reedy: https://gerrit.wikimedia.org/r/#/c/104774/ should be easy :)
[16:56:52] <^d>	 And helpful.
[16:56:53] <grrrit-wm>	 (03PS8) 10Mattflaschen: [WIP] Add Agora mw-ui-button classes to various buttons [core] - 10https://gerrit.wikimedia.org/r/52169 
[16:57:19] <Joeytje50>	 hey guys, is it possible to get the index of the tag on the page? so, for the first time on the page that the tag is being used, it'll be 0, the second usage it will be 1, etc
[16:57:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add Agora mw-ui-button classes to various buttons [core] - 10https://gerrit.wikimedia.org/r/52169 (owner: 10Mattflaschen)
[16:59:05] <grrrit-wm>	 (03CR) 10Mattflaschen: "Rebased due to HTMLForm changes and changed to unconditionally add the mw.ui CSS (per comments here with S)." [core] - 10https://gerrit.wikimedia.org/r/52169 (owner: 10Mattflaschen)
[16:59:56] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Convert global function comments to blocks with param types [extensions/UnicodeConverter] - 10https://gerrit.wikimedia.org/r/104981 (owner: 10Reedy)
[16:59:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Convert global function comments to blocks with param types [extensions/UnicodeConverter] - 10https://gerrit.wikimedia.org/r/104981 (owner: 10Reedy)
[17:01:17] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Add Arabic namespace names [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/104759 (owner: 10Reedy)
[17:01:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add Arabic namespace names [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/104759 (owner: 10Reedy)
[17:02:32] <grrrit-wm>	 (03PS1) 10Reedy: Add Arabic namespace names [extensions/EducationProgram] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/104982 
[17:02:56] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Add Arabic namespace names [extensions/EducationProgram] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/104982 (owner: 10Reedy)
[17:03:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add Arabic namespace names [extensions/EducationProgram] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/104982 (owner: 10Reedy)
[17:07:14] <grrrit-wm>	 (03PS1) 10Subramanya Sastry: Added Be Birchall to trusted users for check/test pipeline [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104983 
[17:17:11] <grrrit-wm>	 (03PS1) 10Chad: Index external links [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104986 
[17:17:23] <^d>	 manybubbles: That was too easy ^ :p
[17:20:01] <grrrit-wm>	 (03PS1) 10Reedy: Update EducationProgram to wmf/1.23wmf9 head [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/104987 
[17:20:47] <grrrit-wm>	 (03CR) 10Reedy: [C: 032 V: 032] Update EducationProgram to wmf/1.23wmf9 head [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/104987 (owner: 10Reedy)
[17:22:41] <manybubbles>	 ^d: I'll look soon
[17:24:45] <grrrit-wm>	 (03CR) 10Anomie: "I gave it no score because there isn't a problem with the change (being useless but otherwise harmless doesn't seem enough to -1 over), bu" [core] - 10https://gerrit.wikimedia.org/r/104528 (owner: 10Siebrand)
[17:28:30] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] No variable assignment on return statement [core] - 10https://gerrit.wikimedia.org/r/104815 (owner: 10Umherirrender)
[17:30:10] <grrrit-wm>	 (03PS2) 10Aaron Schulz: Moved MappedIterator to /libs [core] - 10https://gerrit.wikimedia.org/r/104779 
[17:32:04] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Declare visibility for class properties of LBFactory and LBFactorySimple [core] - 10https://gerrit.wikimedia.org/r/103865 (owner: 10Siebrand)
[17:33:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: No variable assignment on return statement [core] - 10https://gerrit.wikimedia.org/r/104815 (owner: 10Umherirrender)
[17:35:12] <grrrit-wm>	 (03CR) 10Mattflaschen: "Looks good." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103494 (owner: 10JGonera)
[17:37:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Declare visibility for class properties of LBFactory and LBFactorySimple [core] - 10https://gerrit.wikimedia.org/r/103865 (owner: 10Siebrand)
[17:38:36] <grrrit-wm>	 (03PS4) 10Mattflaschen: [WIP] Update mediawiki.ui button styles [core] - 10https://gerrit.wikimedia.org/r/103494 (owner: 10JGonera)
[17:39:08] <grrrit-wm>	 (03CR) 10Mattflaschen: "I made a minor message change to link to the file description page." [core] - 10https://gerrit.wikimedia.org/r/103494 (owner: 10JGonera)
[17:41:34] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Update mediawiki.ui button styles [core] - 10https://gerrit.wikimedia.org/r/103494 (owner: 10JGonera)
[17:41:42] <grrrit-wm>	 (03CR) 10JGonera: [WIP] Update mediawiki.ui button styles (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103494 (owner: 10JGonera)
[17:41:53] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-1] "From a general perspective, it seems user-unfriendly to me to throw an error and make the user resubmit just because they entered the name" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender)
[17:43:51] <grrrit-wm>	 (03PS1) 10Physikerwelt: Remove call to deprecated ParserOptions::getMath [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 
[17:44:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove call to deprecated ParserOptions::getMath [extensions/Math] - 10https://gerrit.wikimedia.org/r/104991 (owner: 10Physikerwelt)
[17:45:42] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Add JobQueueDB::selectFields and use it [core] - 10https://gerrit.wikimedia.org/r/104928 (owner: 10Umherirrender)
[17:46:07] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] Index external links [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104986 (owner: 10Chad)
[17:46:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Index external links [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104986 (owner: 10Chad)
[17:46:45] <grrrit-wm>	 (03PS1) 10Chad: Remove unused globals [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/104992 
[17:48:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add JobQueueDB::selectFields and use it [core] - 10https://gerrit.wikimedia.org/r/104928 (owner: 10Umherirrender)
[17:49:31] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Update documentation for SpecialPage and SpecialPageFactory [core] - 10https://gerrit.wikimedia.org/r/104404 (owner: 10Siebrand)
[17:50:16] <grrrit-wm>	 (03CR) 10Jack Phoenix: [C: 031] Remove unused globals [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/104992 (owner: 10Chad)
[17:51:03] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Return void for LogPager::limitPerformer and limitTitle [core] - 10https://gerrit.wikimedia.org/r/104022 (owner: 10Siebrand)
[17:51:55] <grrrit-wm>	 (03CR) 10Anomie: ContentModel: Use CM to choose CE language (031 comment) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104721 (owner: 10TheDJ)
[17:52:36] <grrrit-wm>	 (03CR) 10Anomie: ContentModel: Use CM to choose CE language (031 comment) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104721 (owner: 10TheDJ)
[17:53:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update documentation for SpecialPage and SpecialPageFactory [core] - 10https://gerrit.wikimedia.org/r/104404 (owner: 10Siebrand)
[17:53:49] <grrrit-wm>	 (03PS1) 10Chad: Remove unused $wgRequest [extensions/AddThis] - 10https://gerrit.wikimedia.org/r/104993 
[17:55:00] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 031] "And I like the idea. It's not obvious that the first letter of the username can't be lowercase, and we've been looking for a good UI solut" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender)
[17:55:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Return void for LogPager::limitPerformer and limitTitle [core] - 10https://gerrit.wikimedia.org/r/104022 (owner: 10Siebrand)
[17:56:56] <grrrit-wm>	 (03PS1) 10Physikerwelt: Skip LaTeXML integration tests [extensions/Math] - 10https://gerrit.wikimedia.org/r/104994 
[17:58:10] <grrrit-wm>	 (03CR) 10Nemo bis: Give error on account creation when user name is adjust silence (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender)
[18:00:16] <physikerwelt>	 Hi is someone around who might want to review https://gerrit.wikimedia.org/r/#/c/104994/ ?
[18:01:20] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032 V: 032] Remove unused $wgRequest [extensions/AddThis] - 10https://gerrit.wikimedia.org/r/104993 (owner: 10Chad)
[18:02:31] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032 V: 032] Remove unused globals [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/104992 (owner: 10Chad)
[18:04:12] <grrrit-wm>	 (03CR) 10EBernhardson: Visualize profile output in debug toolbar (032 comments) [core] - 10https://gerrit.wikimedia.org/r/104318 (owner: 10EBernhardson)
[18:04:43] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu)
[18:05:27] <grrrit-wm>	 (03CR) 10Siebrand: Post appearance tweaks (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu)
[18:06:25] <grrrit-wm>	 (03PS2) 10Physikerwelt: Skip LaTeXML integration tests [extensions/Math] - 10https://gerrit.wikimedia.org/r/104994 
[18:08:20] <grrrit-wm>	 (03PS5) 10JGonera: [WIP] Update mediawiki.ui button styles [core] - 10https://gerrit.wikimedia.org/r/103494 
[18:08:40] <grrrit-wm>	 (03CR) 10JGonera: "Patchset 5 is just a rebase." [core] - 10https://gerrit.wikimedia.org/r/103494 (owner: 10JGonera)
[18:09:27] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] "I've considered if what PleaseStand wrote might be a reason to not merge this yet. This patch doesn't change the current behaviour. Invali" [core] - 10https://gerrit.wikimedia.org/r/104707 (owner: 10Theopolisme)
[18:11:26] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Fix FlowSetUserIp to run against larger-than-mBatchSize revision sets [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104927 (owner: 10Matthias Mullie)
[18:11:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix FlowSetUserIp to run against larger-than-mBatchSize revision sets [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104927 (owner: 10Matthias Mullie)
[18:14:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Deprecate $wgPasswordSenderName [core] - 10https://gerrit.wikimedia.org/r/104707 (owner: 10Theopolisme)
[18:15:01] <siebrand>	 ^d: I think Gerrit may have been particularly slow for the past hours. Possible?
[18:15:28] <^d>	 Been fine for me, but I haven't been using it heavily.
[18:16:48] <theopolisme>	 siebrand: "Change has been successfully merged into the git repository"..."This change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset." what does this mean? does it need a rebase or not? ;)
[18:17:22] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Use container namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104943 (owner: 10Matthias Mullie)
[18:17:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use container namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104943 (owner: 10Matthias Mullie)
[18:18:37] <siebrand>	 theopolisme: I agree that's pretty confusing. If you want to check, you should pull master :)
[18:18:43] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-1] Add mw.html to Scribunto (036 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man)
[18:18:49] <siebrand>	 theopolisme: As it is in master for me, I'm pretty sure it was merged :)
[18:19:18] <theopolisme>	 Looks like it merged successfully, yep
[18:19:46] <theopolisme>	 Jenkins seems to be a bit confused though ;)
[18:23:05] <grrrit-wm>	 (03PS1) 10Chad: RequestContext has existed since 1.18, and getNamespace() since forever [extensions/UserFunctions] - 10https://gerrit.wikimedia.org/r/104995 
[18:25:25] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Automatically run FlowSetUserIp on update.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104930 (owner: 10Matthias Mullie)
[18:25:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Automatically run FlowSetUserIp on update.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104930 (owner: 10Matthias Mullie)
[18:27:29] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Fix double moderation dialog [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104998 
[18:27:31] <grrrit-wm>	 (03PS1) 10Jackmcbarn: Add CASCADINGSOURCES parser function [core] - 10https://gerrit.wikimedia.org/r/104999 
[18:28:57] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032] Improve fix comment. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104914 (owner: 10Spage)
[18:29:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Improve fix comment. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104914 (owner: 10Spage)
[18:29:06] <grrrit-wm>	 (03PS1) 10Chad: Stop using the unholy trinity in DatabaseError [core] - 10https://gerrit.wikimedia.org/r/105000 
[18:30:06] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] RequestContext has existed since 1.18, and getNamespace() since forever (031 comment) [extensions/UserFunctions] - 10https://gerrit.wikimedia.org/r/104995 (owner: 10Chad)
[18:32:09] <grrrit-wm>	 (03PS2) 10Chad: RequestContext has existed since 1.18, and getNamespace() since forever [extensions/UserFunctions] - 10https://gerrit.wikimedia.org/r/104995 
[18:32:58] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] RequestContext has existed since 1.18, and getNamespace() since forever [extensions/UserFunctions] - 10https://gerrit.wikimedia.org/r/104995 (owner: 10Chad)
[18:36:38] <Tuxedo_>	 I wrote: "In doing a fresh MW 1.22 install I'm trying to enable copy uploads but for some odd reason I don't seem to be able to get the 'Source URL' input field to appear" ... Did something change with this since 1.20.x?
[18:36:41] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. Looks fine." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104395 (owner: 10Jackmcbarn)
[18:37:12] <Tuxedo_>	 Found it :) $wgCopyUploadsFromSpecialUpload = true;
[18:37:28] <Tuxedo_>	 New since my last installation.
[18:39:28] <grrrit-wm>	 (03PS3) 10Jackmcbarn: Allow hiding redirects in Special:ProtectedPages [core] - 10https://gerrit.wikimedia.org/r/104395 
[18:40:09] <Kourio>	 irc://irc.freenode.net/#wikimedia-dev
[18:41:42] <Technical_13>	 https://www.mediawiki.org/wiki/Manual:Parameters_to_index.php#Special_pages says "Most special pages have additional parameters, specific to the function they perform. As an example, the parameters for Special:Export are outlined in Manual:Parameters to Special:Export"
[18:42:26] <Technical_13>	 Where can I find the page for the parameters to Special:UserLogin because https://www.mediawiki.org/wiki/Manual:Parameters_to_Special:UserLogin doesn't exist.
[18:43:46] <Technical_13>	 so I can see the list of parameters for https://en.wikipedia.org/w/index.php?title=Special:UserLogin/signup
[18:44:49] <^d>	 siebrand: My todo list: http://p.defau.lt/?_HN4c2t1nShCbJIn9q2xHQ :p
[18:44:49] <Technical_13>	 jorm: I know you worked on the login page for a bit, you wouldn't happen to know, would you?
[18:45:00] <^d>	 The remainders are just setting $wgTitle, which aren't as evil and easily cleaned up.
[18:45:09] <^d>	 The *usages* in those lists are the bad ones.
[18:45:33] <grrrit-wm>	 (03PS4) 10Jackmcbarn: Allow hiding redirects in Special:ProtectedPages [core] - 10https://gerrit.wikimedia.org/r/104395 
[18:45:41] <siebrand>	 ^d: SemanticPageMaker is a real ugly duckling.
[18:45:53] <siebrand>	 ^d: That was a repo dump of something huge, and it's unmaintained.
[18:45:58] <^d>	 Yeah
[18:46:27] <siebrand>	 ^d: Narayam is superseded by ULS.
[18:46:51] <siebrand>	 ^d: Nice todo list :)
[18:47:03] <^d>	 Maybe delete all the code and just leave a single file pointing to ULS?
[18:47:14] <siebrand>	 ^d: Ive got 60 patch sets waiting for review, so I'm not producing too much...
[18:47:23] <^d>	 (Then nothing's gone if people want the history, but cleans up code review metrics and so forth)
[18:47:41] <siebrand>	 ^d: Probably something that should be RFC-ed.
[18:47:54] <siebrand>	 ^d: And then do include what we do with code that is obviously rotting....
[18:48:03] <hoo>	 Same was done with the old Vector extension 
[18:48:22] <^d>	 I like.
[18:48:25] <^d>	 I'll write a patch
[18:48:38] <siebrand>	 It's the exception that proves the rule that abandoned code is left to rot, and that occasional maintenance is done on it.
[18:48:52] <siebrand>	 I think it would be better if we had an accepted guideline.
[18:49:00] <siebrand>	 Some extensions also have a DEPRECATED file.
[18:49:36] <siebrand>	 AFAIK this wasn't done for EXpandTemplates when it was merged into core.
[18:49:55] <siebrand>	 There are a few regular use cases we could cover in a policy.
[18:50:11] <grrrit-wm>	 (03PS5) 10Jackmcbarn: Allow hiding redirects in Special:ProtectedPages [core] - 10https://gerrit.wikimedia.org/r/104395 
[18:50:29] <siebrand>	 jackmcbarn: Thanks.
[18:50:33] <jackmcbarn>	 np
[18:50:41] <grrrit-wm>	 (03CR) 10Hashar: [C: 04-1] Make parsoidsvc Jenkins jobs voting. (031 comment) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104974 (owner: 10Subramanya Sastry)
[18:50:59] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/104395 (owner: 10Jackmcbarn)
[18:51:00] <grrrit-wm>	 (03PS1) 10Chad: Narayam extension is deprecated, use ULS instead [extensions/Narayam] - 10https://gerrit.wikimedia.org/r/105002 
[18:51:07] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Added Maria Pacana to trusted users for check/test pipeline [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104973 (owner: 10Subramanya Sastry)
[18:51:31] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Any user can hide, not just autoconfirmed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105003 
[18:51:40] <siebrand>	 ^d: I've added Nikerabbit and santhosh as reviewers.
[18:51:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Added Maria Pacana to trusted users for check/test pipeline [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104973 (owner: 10Subramanya Sastry)
[18:52:18] <^d>	 :)
[18:53:14] <grrrit-wm>	 (03PS2) 10Hashar: Added Be Birchall to trusted users for check/test pipeline [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104983 (owner: 10Subramanya Sastry)
[18:53:36] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "cherry picked on master" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104983 (owner: 10Subramanya Sastry)
[18:54:28] <grrrit-wm>	 (03CR) 10Subramanya Sastry: "I am happy to fix it, but I see a lot of 'voting: true' blocks in there as well ;-) ..." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104974 (owner: 10Subramanya Sastry)
[18:54:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Added Be Birchall to trusted users for check/test pipeline [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104983 (owner: 10Subramanya Sastry)
[18:55:28] <grrrit-wm>	 (03CR) 10Hashar: "yup, the jslint jobs for examples are non voting by default, there is a block similar to:" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104974 (owner: 10Subramanya Sastry)
[18:55:28] <^d>	 ashley: Could I beg you to remove $wgTitle from the Nimbus skin?
[18:55:34] <^d>	 It's making my eyes bleed.
[18:56:00] <grrrit-wm>	 (03CR) 10Subramanya Sastry: "[subbu@earth zuul-config] grep "voting: true" layout.yaml | wc" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104974 (owner: 10Subramanya Sastry)
[18:56:29] <ashley>	 I can look into it but I can't promise that it'll be done right away :) Nimbus has needed some refactoring anyway (to support some extensions, etc.) and we'd need to push the latest Nimbus changes to git.wm.o anyway, so I might as well take a look at that
[18:56:53] <grrrit-wm>	 (03CR) 10Subramanya Sastry: "aha .. reg. jslint .. ok. i dont understand all the details yet, but will follow the guidelines for now. :-)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104974 (owner: 10Subramanya Sastry)
[18:58:05] <MJ94>	 I'm assuming the devs know Commons is down?
[18:58:20] <Reedy>	 Yup
[18:58:30] <Reedy>	 You're 70 minutes late to the party ;)
[18:59:53] <MJ94>	 Reedy: dang it
[18:59:57] <^d>	 ashley: Thanks :)
[18:59:59] * MJ94  puts the cake away

[19:00:12] <^d>	 I wonder if the authors of the BlueSpice extensions realize their extensions don't work on MW 1.18 or above.
[19:00:19] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Fix small errors in board history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104942 (owner: 10Matthias Mullie)
[19:00:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix small errors in board history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104942 (owner: 10Matthias Mullie)
[19:01:28] <grrrit-wm>	 (03CR) 10Hoo man: [C: 031] "Any way to feature detect whether external services will be around? If not, I'm ok with this (although it's not especially nice)" [extensions/Math] - 10https://gerrit.wikimedia.org/r/104994 (owner: 10Physikerwelt)
[19:01:43] <ashley>	 ^d: the last time I looked at BlueSpice stuff, it felt as if the authors were reinventing the wheel a couple times...
[19:01:57] <^d>	 s/couple/couple dozen/
[19:02:15] <ashley>	 at least they're publishing code and, I guess, trying to collaborate with upstream
[19:02:38] <ashley>	 it makes me sad when third parties wind up doing all sorts of [[uncyclopedia:Bat Fuck Insane]] hacks and whatnot
[19:03:09] <ashley>	 or "better" yet, being stuck on MW 1.12 due to all sorts of insane local customizations (and not accepting help for modernizing the codebase)
[19:03:49] <grrrit-wm>	 (03PS1) 10Chad: Don't use $wgTitle [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/105004 
[19:03:52] <grrrit-wm>	 (03PS2) 10Subramanya Sastry: Make parsoidsvc Jenkins jobs voting. [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104974 
[19:05:11] <^d>	 New years resolution: fix bug 23307
[19:06:44] <Nemo_bis>	 ^d: according to https://www.mediawiki.org/wiki/Extension:BlueSpice , no they don't
[19:06:44] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Fix double moderation dialog [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104998 (owner: 10Matthias Mullie)
[19:06:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix double moderation dialog [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104998 (owner: 10Matthias Mullie)
[19:06:44] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] "Good from a Product perspective." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/102383 (owner: 10Legoktm)
[19:07:39] <^d>	 Nemo_bis: They're using at least one hook that was removed entirely in 1.18.
[19:10:02] <jackmcbarn>	 from a performance standpoint, would it be practical to have an interface to mass-purge/null-edit of batches of pages (such as everything transcluding a given page)?
[19:10:38] <Reedy>	 If you edit a template...
[19:11:17] <jackmcbarn>	 to make it skip the job queue is the point
[19:12:15] <Reedy>	 lol
[19:12:21] <Reedy>	 On Wikipedia that's not going to happen
[19:12:36] <Reedy>	 I know people have ways of doing it...
[19:12:43] <jackmcbarn>	 any suggestions for how to deal with enwp's template vandalism problem over the last few days/weeks then?
[19:12:43] <Reedy>	 But as they've found out before, they break stuff
[19:13:21] <jackmcbarn>	 the pattern is someone vandalizes a relatively low-visibility template, gets their stuff everywhere, then when we put it back, we have to manually purge all affected pages
[19:13:34] <grrrit-wm>	 (03CR) 10Anomie: [C: 032] Allow hiding redirects in Special:ProtectedPages [core] - 10https://gerrit.wikimedia.org/r/104395 (owner: 10Jackmcbarn)
[19:13:35] <grrrit-wm>	 (03PS2) 10Gomoko: Added custom label for links in category pages [core] - 10https://gerrit.wikimedia.org/r/104905 
[19:15:16] <jackmcbarn>	 what about if there were some way to flag an edit to make its jobs be higher priority in the job queue?
[19:19:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Allow hiding redirects in Special:ProtectedPages [core] - 10https://gerrit.wikimedia.org/r/104395 (owner: 10Jackmcbarn)
[19:20:37] <grrrit-wm>	 (03CR) 10Gomoko: "Comments taken into consideration." [core] - 10https://gerrit.wikimedia.org/r/104905 (owner: 10Gomoko)
[19:22:29] <grrrit-wm>	 (03PS3) 10Gomoko: Added custom label for links in category pages [core] - 10https://gerrit.wikimedia.org/r/104905 
[19:24:03] <grrrit-wm>	 (03CR) 10Parent5446: [C: 032] Fix bad usage of empty() function [core] - 10https://gerrit.wikimedia.org/r/104810 (owner: 10IAlex)
[19:28:51] <grrrit-wm>	 (03PS2) 10Jackmcbarn: Allow transcluding Special:Gadgets [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/97787 
[19:31:02] <grrrit-wm>	 (03CR) 10Reedy: WIP Retry commands if failed (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/104970 (owner: 10Reedy)
[19:33:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix bad usage of empty() function [core] - 10https://gerrit.wikimedia.org/r/104810 (owner: 10IAlex)
[19:33:52] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "And a diff of Zuul conf before : https://integration.wikimedia.org/ci/job/integration-zuul-layoutdiff/747/console shows up that all parsoi" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104974 (owner: 10Subramanya Sastry)
[19:35:05] <grrrit-wm>	 (03CR) 10MarkTraceur: "I'd also love it if you'd add tests :)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/102383 (owner: 10Legoktm)
[19:35:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make parsoidsvc Jenkins jobs voting. [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104974 (owner: 10Subramanya Sastry)
[19:36:29] <grrrit-wm>	 (03PS1) 10Chad: Remove deprecated convertLinkToAllVariants() [core] - 10https://gerrit.wikimedia.org/r/105010 
[19:40:35] <jackmcbarn>	 interesting bug. https://en.wikipedia.org/wiki/Special:Search/Template:CASCADINGSOURCES asks if you mean Template:CASCADPROTECTED. when you say yes, it asks if you mean Template:CASCADEPROTECTED. when you say yes again, it says nothing by that name exists and shows a whole bunch of barely-relevant results. what algorithm does it use to come up with those suggestions?
[19:42:03] <Reedy>	 http://book.mixu.net/distsys/
[19:43:16] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032] Use AbstractRevision::getRevisionType instead of array['rev_type'] [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104935 (owner: 10Matthias Mullie)
[19:43:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use AbstractRevision::getRevisionType instead of array['rev_type'] [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104935 (owner: 10Matthias Mullie)
[19:45:05] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 04-1] Reverting changes to python schema.Adding test. Removing whitespace again. Adding isset check for user agent for times in which this code is (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/104509 (owner: 10Nuria)
[19:46:50] <thedj>	 jackmcbarn: in my opinion, PC...
[19:47:07] <jackmcbarn>	 thedj: huh?
[19:47:12] <thedj>	 jackmcbarn: i seriously don't get all the relegious bullshit around it.
[19:47:22] <jackmcbarn>	 what?
[19:47:27] <jackmcbarn>	 what are you talking about?
[19:47:30] <thedj>	 if we want to pretect our templates, we should use protection
[19:47:45] <jackmcbarn>	 oh
[19:48:06] <jackmcbarn>	 the idea of PC is that we let helpful IP's submit their edits without having to write them up on a talk page, while still keeping the vandals out
[19:48:50] <thedj>	 The idea is that you introduce review, so that you don't make accidental changes that F stuff up.
[19:49:02] <thedj>	 be them admin accidents of vandal edits
[19:49:07] <thedj>	 s/of/or
[19:49:18] <grrrit-wm>	 (03PS2) 10Mayankmadan: Adding code comments of resulting keys [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/104782 
[19:49:36] <mayankmadan>	 Nemo_bis, hi
[19:49:38] <mayankmadan>	 around?
[19:49:54] <thedj>	 the problem is that pc2 has just become a dirty word. which is bull. it's a technical measure and should be used as is appropriate.
[19:49:57] <grrrit-wm>	 (03CR) 10Parent5446: [C: 031] Update documentation for ParserCache::save() [core] - 10https://gerrit.wikimedia.org/r/104518 (owner: 10Siebrand)
[19:50:07] <grrrit-wm>	 (03CR) 10Parent5446: Random documentation tweaks (033 comments) [core] - 10https://gerrit.wikimedia.org/r/104527 (owner: 10Siebrand)
[19:50:18] <thedj>	 semi and full protection should be the dirty word when it comes to template protection.
[19:50:30] <jackmcbarn>	 right. no consensus for use means we need consensus before we can use it, not we can never ever use it
[19:50:57] <thedj>	 yeah and the consensus is never gonna happen, because the tech crowd isn't gonna wiki laywer for it.
[19:51:06] <grrrit-wm>	 (03CR) 10Parent5446: [C: 032] Avoid interacting with LBFactory singleton in tests [core] - 10https://gerrit.wikimedia.org/r/104473 (owner: 10Aude)
[19:51:46] <grrrit-wm>	 (03CR) 10Parent5446: [C: 031] Stop using the unholy trinity in DatabaseError [core] - 10https://gerrit.wikimedia.org/r/105000 (owner: 10Chad)
[19:52:10] <thedj>	 the job queue is there for a reason. if en.wp can't accept that, it's their problem when their pages get vandalized 
[19:54:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Avoid interacting with LBFactory singleton in tests [core] - 10https://gerrit.wikimedia.org/r/104473 (owner: 10Aude)
[19:55:10] <Technical_13>	 thedj: I'd support use of PC2 where appropriate.
[19:55:14] <^d>	 thedj: moar job runners!
[19:55:49] <Nemo_bis>	 ^d: or moar hhvm?
[19:56:11] <^d>	 more everything, duh :)
[19:57:13] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "Please update RELEASE NOTES." [core] - 10https://gerrit.wikimedia.org/r/105010 (owner: 10Chad)
[19:58:23] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Any user can hide, not just autoconfirmed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105003 (owner: 10Matthias Mullie)
[19:58:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Any user can hide, not just autoconfirmed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105003 (owner: 10Matthias Mullie)
[20:00:10] <grrrit-wm>	 (03PS2) 10Andrew Bogott: Start using full-qualified ec2 id for the page url. [openstack-wikistatus] - 10https://gerrit.wikimedia.org/r/104484 
[20:00:37] <mayankmadan>	 Nemo_bis, is this what is required? https://gerrit.wikimedia.org/r/104782
[20:01:08] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032 V: 032] Don't use $wgTitle [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/105004 (owner: 10Chad)
[20:01:09] <grrrit-wm>	 (03PS1) 10Chad: MWException doesn't care about $wgTitle anymore [core] - 10https://gerrit.wikimedia.org/r/105017 
[20:01:56] <grrrit-wm>	 (03PS2) 10Chad: Remove deprecated convertLinkToAllVariants() [core] - 10https://gerrit.wikimedia.org/r/105010 
[20:02:14] <VladAndrew>	 Nemo_bis: when do I use the tvar tag ?
[20:04:41] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Remove deprecated convertLinkToAllVariants() [core] - 10https://gerrit.wikimedia.org/r/105010 (owner: 10Chad)
[20:05:03] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] Adding code comments of resulting keys (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/104782 (owner: 10Mayankmadan)
[20:05:25] <grrrit-wm>	 (03CR) 10Siebrand: "Verified that methods were not used in core and Gerrit extensions." [core] - 10https://gerrit.wikimedia.org/r/105010 (owner: 10Chad)
[20:07:21] <grrrit-wm>	 (03CR) 10Aaron Schulz: WIP Retry commands if failed (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/104970 (owner: 10Reedy)
[20:08:26] <grrrit-wm>	 (03CR) 10Reedy: WIP Retry commands if failed (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/104970 (owner: 10Reedy)
[20:08:39] <thedj>	 Technical_13: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(policy)#REVIEW
[20:09:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove deprecated convertLinkToAllVariants() [core] - 10https://gerrit.wikimedia.org/r/105010 (owner: 10Chad)
[20:10:28] <Technical_13>	 thedj: I support the use of PC in the Template namespace but don't think it should be applied to everything en masse.
[20:10:54] <jackmcbarn>	 Technical_13: this vandal doesn't care what he hits. if we only PC some things, he'll just vandalize the ones we don't.
[20:11:02] <thedj>	 exactly
[20:11:32] <Technical_13>	 We have levels of protection, we should have levels of of what contrues an "at-risk" template.
[20:11:36] <thedj>	 that's why this only works with PC. you want people to contribute, you jsut don't want it live immediatly. 
[20:11:40] <grrrit-wm>	 (03CR) 10Jack Phoenix: [C: 032 V: 032] "Good catch :D" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/104980 (owner: 10UltrasonicNXT)
[20:11:51] <thedj>	 and we have template editor group to deal with all of it.
[20:14:30] <thedj>	 i'm also fine with patrolled pages. it's the same as pc, but limited to anon.
[20:14:35] <Technical_13>	 < 50 transclusions, no risk.  50 > 200 transclusions, low risk = PC1. 200 > 500 transclusions, medium risk = PC2 or semi. 500 > 2,500 transclusions, high-risk = PC2 or TE. > 2,500, severe-risk = full
[20:14:45] <Technical_13>	 something like that would be great..
[20:14:47] <thedj>	 (visibility limited to anon) that is
[20:15:04] <jackmcbarn>	 Technical_13: if we do that, the <50 templates will be the vandalized ones
[20:15:05] <thedj>	 if <50 has 1 in barack obama, then no
[20:15:17] <thedj>	 it jsut wouldn't work
[20:16:00] <grrrit-wm>	 (03PS3) 10Mayankmadan: Adding code comments of resulting keys [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/104782 
[20:16:04] <Technical_13>	 But, if it is < 50 transclusions that it would be quick to detect and determine the source... That is the whole point.  
[20:16:35] <jackmcbarn>	 that's not the concern
[20:16:47] <jackmcbarn>	 we still need to manually purge all 49 pages after that happens
[20:16:48] <Technical_13>	 You're not going to stop vandals, if they want to make a mess of something they will, but we can't just lock down the whole wiki to registered users.
[20:17:04] <Technical_13>	 really?  takes me less than 2 minutes to do that..
[20:17:59] <Technical_13>	 I can open 99 tabs in FF no problem and using my macro keyboard click the purge button and close the tab...
[20:18:23] <grrrit-wm>	 (03PS4) 10Mayankmadan: Adding code comments of resulting keys [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/104782 
[20:18:23] <Technical_13>	 click, wait 2 seconds, close, click...
[20:18:32] <Technical_13>	 no risk there.
[20:18:49] <Technical_13>	 takes a total of 5-10 minutes to determine the cause and completely repair..
[20:19:07] <jackmcbarn>	 right
[20:19:11] <jackmcbarn>	 but 2 seconds to do the damage
[20:19:20] <thedj>	 i doubt that will satisfy the crowd but you are welcome to give it a go.
[20:19:38] <thedj>	 i support anything that is more senseless than (bypass the jobqueue)
[20:19:45] <thedj>	 eh sensible
[20:20:20] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "'kay, I assent!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/104782 (owner: 10Mayankmadan)
[20:20:38] <Technical_13>	 Are you going to completely lock down Wikipedia, Wikipedia_talk, Module, Portal, User, and User_talk as well?  They all contain templates that are potentially used on thousands of pages...
[20:20:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Adding code comments of resulting keys [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/104782 (owner: 10Mayankmadan)
[20:20:54] <jackmcbarn>	 Module maybe, no to the rest
[20:21:02] <thedj>	 i don't see review as lockdown
[20:22:46] <thedj>	 i even see it as a sensible part of any scripting language deployment that is available to large groups of untrusted users....
[20:23:47] <Technical_13>	 jobs="1067648"
[20:24:15] <grrrit-wm>	 (03PS2) 10Chad: Support FlaggedRevs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104675 
[20:24:25] <Technical_13>	 When the job queue is over a million, it will take a while for it to process a little change like a template with 8 transclusions...
[20:24:57] <grrrit-wm>	 (03PS2) 10AalekhN: Made Changes as per Bug 34999 <ref>{{{foo}}}</ref> is working on the local machine....also added some changes after review by Bawolff [extensions/Cite] - 10https://gerrit.wikimedia.org/r/104794 
[20:24:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Made Changes as per Bug 34999 <ref>{{{foo}}}</ref> is working on the local machine....also added some changes after review by Bawolff [extensions/Cite] - 10https://gerrit.wikimedia.org/r/104794 (owner: 10AalekhN)
[20:25:04] <Reedy>	 That's not to say the current hardware is sufficient for the size of the queue etc
[20:25:20] <^d>	 Job queue's rather large on commons at the moment because we're indexing for CirrusSearch.
[20:25:20] <Reedy>	 If it's consistently big, and the jobs are rightly there, more power might be needed to clear it
[20:25:25] <^d>	 But that number should be going back down.
[20:25:31] <^d>	 (We should also increase the # of runners)
[20:25:32] <thedj>	 the job queue is not ideal, but it's simply not the problem here
[20:25:57] <thedj>	 it's a symptom
[20:26:03] <jackmcbarn>	 Technical_13: but we won't notice the change until it does
[20:26:08] <^d>	 thedj: What's not ideal about it? It works wonderfully :)
[20:26:16] <^d>	 Does exactly what it's designed to
[20:27:08] <jackmcbarn>	 ^d: takes forever to get anything done
[20:27:24] <jackmcbarn>	 i added a category to a template back in november, and pages are still getting added to it now
[20:28:22] <thedj>	 well we probably could make it a bit smarter if we wanted to. i'm sure. but it's there for a reason.
[20:30:13] <Technical_13>	 Reedy: Who creates the Wikipedia:Database reports?
[20:30:27] <Reedy>	 Look at the history?
[20:30:29] <^d>	 It gets things done plenty quick :)
[20:30:32] <^d>	 It's all about priority.
[20:30:49] <Technical_13>	 Who is BernsteinBot
[20:30:58] <grrrit-wm>	 (03PS2) 10Umherirrender: Give error on account creation when user name is adjust silently [core] - 10https://gerrit.wikimedia.org/r/104926 
[20:31:09] <Technical_13>	 Who is MZMcBride
[20:31:24] <Reedy>	 Gloria ^
[20:31:25] <grrrit-wm>	 (03CR) 10Umherirrender: "Patch Set 2: Addressed comments" (035 comments) [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender)
[20:31:30] <^d>	 MZMcBride's just zis guy.
[20:31:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Give error on account creation when user name is adjust silently [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender)
[20:32:11] <Technical_13>	 I'm asking because that bot doesn't recognize TE protection according to the reports https://en.wikipedia.org/wiki/Wikipedia:Database_reports/Unprotected_templates_with_many_transclusions/1 it is producing...
[20:36:13] <grrrit-wm>	 (03PS3) 10Umherirrender: Give error on account creation when user name is adjust silently [core] - 10https://gerrit.wikimedia.org/r/104926 
[20:38:01] <grrrit-wm>	 (03CR) 10Umherirrender: "Patch Set 3: Rebased" [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender)
[20:46:08] <grrrit-wm>	 (03PS1) 10Mayankmadan: Adding a message for api-error-stasherror [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105040 
[20:46:31] <grrrit-wm>	 (03PS1) 10Cmcmahon: Test navigation to watchlist and Flow change exists [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105044 
[20:47:56] <grrrit-wm>	 (03PS2) 10Cmcmahon: Test navigation to watchlist and Flow change exists [extensions/Flow] - 10https://gerrit.wikimedia.org/r/105044 
[20:50:45] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/105070 (owner: 10L10n-bot)
[20:55:24] <marktraceur>	 yurik: Hey, I'm looking at a UW bug that has to do with API error i18n messages
[20:55:40] <marktraceur>	 mayankmadan and I have found that there are api-error-* messages for most things, but not for stasherror
[20:55:42] <Nemo_bis>	 (thanks for doing so)
[20:56:05] <marktraceur>	 Should we add it as a message in core or as a message in UW? The latter would fix it more quickly, but it may not be "right
[20:56:07] <marktraceur>	 "
[20:56:13] <marktraceur>	 Nemo_bis: If you have thoughts, fire away
[20:56:39] <Nemo_bis>	 I don't, that's the problem :)
[20:57:11] <mayankmadan>	 Nemo_bis, then what is the problem
[20:58:17] <grrrit-wm>	 (03PS1) 10Bsitu: Update Flow to master [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105089 
[20:59:33] <yurik>	 marktraceur, UW?
[20:59:49] <mayankmadan>	 UploadWizard
[21:00:13] <abailiss>	 is there a good task for a beginner with the mediawiki codebase that needs working on now?
[21:00:30] <hoo>	 !easy
[21:00:30] <wm-bot>	 Bugzilla maintains a list of easy bugs for us, that are considered a good first step for new MediaWiki developers. See https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=keyword%3Aeasy for the list.
[21:00:38] <abailiss>	 thanks :)
[21:00:45] <hoo>	 You're welcome ;)
[21:00:56] <marktraceur>	 mayankmadan, yurik, I'll be back in twenty or so
[21:02:54] <Reedy>	 Who's running a schema change?
[21:03:01] <grrrit-wm>	 (03CR) 10Spage: [C: 032] "Has some i18n we don't care about, but OK" [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105089 (owner: 10Bsitu)
[21:04:21] <grrrit-wm>	 (03PS1) 10Subramanya Sastry: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/105090 
[21:12:06] <grrrit-wm>	 (03CR) 10Chad: "Functionally ok, but while we're here I don't like the limit of only 5 pages. It feels far too low. I'd rather just pick a sane cutoff val" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104773 (owner: 10Manybubbles)
[21:18:37] <grrrit-wm>	 (03PS1) 10Manybubbles: Build fixed size chunks when indexing [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105091 
[21:21:04] <grrrit-wm>	 (03CR) 10Nullzero: make MOVED_TO* working (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104706 (owner: 10Nullzero)
[21:21:24] <grrrit-wm>	 (03PS2) 10Manybubbles: Shrink the LinksUpdateJob a bit [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104773 
[21:21:53] <mayankmadan>	 marktraceur, back
[21:21:59] <marktraceur>	 'kay
[21:22:11] <grrrit-wm>	 (03CR) 10Spage: [V: 032] "adding verified +2 maybe will wake up Jenkins" [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105089 (owner: 10Bsitu)
[21:22:21] <marktraceur>	 mayankmadan: I think this is supposed to be a core thing
[21:22:33] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Build fixed size chunks when indexing [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105091 (owner: 10Manybubbles)
[21:23:06] <mayankmadan>	 marktraceur, core thing?
[21:23:15] <grrrit-wm>	 (03CR) 10Chad: [C: 032] "Ok, 25 is 5x more than what we had, that's better :)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104773 (owner: 10Manybubbles)
[21:23:18] <marktraceur>	 But I'm not sure why it wasn't added, and I don't know how to make sure people add them in the future
[21:23:31] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Make it possible for extensions to specify which version of MediaWiki they support via Composer. [core] - 10https://gerrit.wikimedia.org/r/105092 
[21:23:31] <manybubbles>	 5x is always better!
[21:23:33] <marktraceur>	 mayankmadan: If you grep for api-error- in core, you get loads of messages
[21:23:38] <marktraceur>	 But not stasherror
[21:23:50] <marktraceur>	 UploadWizard doesn't implement stasherror, core does, so having the message in core makes sense
[21:23:51] <^d>	 manybubbles: It's 5 times as good!
[21:23:52] <^d>	 :)
[21:23:56] <manybubbles>	 of course!
[21:24:07] <grrrit-wm>	 (03PS2) 10Jeroen De Dauw: Make it possible for extensions to specify which version of MediaWiki they support via Composer. [core] - 10https://gerrit.wikimedia.org/r/105092 
[21:24:19] <manybubbles>	 those arrays normally contain about 2 entries
[21:24:21] <mayankmadan>	 marktraceur, but there is a stasherror so it should have a message
[21:24:27] <^d>	 Where's jenkins?
[21:24:27] <manybubbles>	 normally 0, actually.  sometimes 2.
[21:24:28] <marktraceur>	 mayankmadan: If you can put the message in core instead, I'd be very happy. You also need to add it to the list of messages UW loads on the frontend, in UploadWizardHooks.php
[21:24:42] <mayankmadan>	 marktraceur, okay
[21:24:44] <marktraceur>	 Two patches, but they should be really fast patches.
[21:24:46] <grrrit-wm>	 (03PS3) 10Jeroen De Dauw: Make it possible for extensions to specify which version of MediaWiki they support via Composer. [core] - 10https://gerrit.wikimedia.org/r/105092 
[21:24:48] <^d>	 manybubbles: 25 will get almost all of them always then.
[21:24:54] <mayankmadan>	 im gonna abandon the previous patch
[21:25:01] <marktraceur>	 Makes sense
[21:25:29] <^d>	 manybubbles: I amended https://gerrit.wikimedia.org/r/#/c/104675/, by the way. It's much more binary of a feature.
[21:25:35] <^d>	 :)
[21:25:59] <manybubbles>	 I still have to read it and learn flagged revs:(
[21:26:34] <^d>	 That's a rabbit hole, what do you want to know about it?
[21:27:08] <grrrit-wm>	 (03CR) 10Chad: [V: 032] Shrink the LinksUpdateJob a bit [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104773 (owner: 10Manybubbles)
[21:27:19] <grrrit-wm>	 (03CR) 10Chad: [V: 032] Build fixed size chunks when indexing [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/105091 (owner: 10Manybubbles)
[21:27:45] <grrrit-wm>	 (03Abandoned) 10Mayankmadan: Adding a message for api-error-stasherror [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105040 (owner: 10Mayankmadan)
[21:29:33] <VladAndrew>	 Nemo_bis: are you here ?
[21:30:38] <grrrit-wm>	 (03PS4) 10Jeroen De Dauw: Make it possible for extensions to specify which version of MediaWiki they support via Composer. [core] - 10https://gerrit.wikimedia.org/r/105092 
[21:30:55] <Nemo_bis>	 VladAndrew: tell me
[21:31:41] <VladAndrew>	 Nemo_bis: where can I find an example of tvar tag usage ?
[21:32:23] <Nemo_bis>	 VladAndrew: https://meta.wikimedia.org/wiki/Tech/News/2014/02 for a fresh one
[21:32:35] <VladAndrew>	 Thanks!
[21:32:57] <grrrit-wm>	 (03PS1) 10Mayankmadan: Adding a message for api-error-stasherror [core] - 10https://gerrit.wikimedia.org/r/105094 
[21:33:18] <Nemo_bis>	 or the last point of https://www.mediawiki.org/wiki/Help:Extension:Translate/Page_translation_administration#Segmentation ofcourse
[21:34:46] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Stop using the unholy trinity in DatabaseError (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105000 (owner: 10Chad)
[21:35:58] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "I updated the docs at https://www.mediawiki.org/wiki/Manual:$wgPasswordSenderName , but someone involved with the patch shoul have done th" [core] - 10https://gerrit.wikimedia.org/r/104707 (owner: 10Theopolisme)
[21:36:54] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Use-case?" [core] - 10https://gerrit.wikimedia.org/r/104999 (owner: 10Jackmcbarn)
[21:37:29] <grrrit-wm>	 (03PS1) 10Mayankmadan: Including api-error-stasherror from core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105097 
[21:37:31] <grrrit-wm>	 (03CR) 10Jackmcbarn: "https://en.wikipedia.org/wiki/MediaWiki_talk:Cascadeprotected#Interface_edit_request_on_29_December_2013" [core] - 10https://gerrit.wikimedia.org/r/104999 (owner: 10Jackmcbarn)
[21:38:19] <VladAndrew>	 Nemo_bis: and for example in Downloads where is one place where I should use it 
[21:38:39] <mayankmadan>	 marktraceur, https://gerrit.wikimedia.org/r/#/c/105094/   ,   https://gerrit.wikimedia.org/r/#/c/105097/
[21:39:54] <Nemo_bis>	 VladAndrew: the stuff that doesn't need to be translated and/or is updated frequently
[21:40:15] <Nemo_bis>	 VladAndrew: check your syntax better please https://www.mediawiki.org/wiki/Help:External_searches
[21:40:51] <mayankmadan>	 marktraceur, whats wrong with jenkins
[21:41:11] <grrrit-wm>	 (03PS2) 10Chad: Stop using the unholy trinity in DatabaseError [core] - 10https://gerrit.wikimedia.org/r/105000 
[21:41:18] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Annnd guess what, this doesn't merge already :) I'll take care of that and merge." [core] - 10https://gerrit.wikimedia.org/r/104718 (owner: 10Siebrand)
[21:41:47] <MatmaRex>	 ^d: i chuckled at "the unholy trinity". just though you should know.
[21:42:15] <MatmaRex>	 ^d: "context title's"? oh come on
[21:42:48] <^d>	 :p
[21:43:24] <grrrit-wm>	 (03CR) 10Mattflaschen: "I prefer the contractions as well. It supports the tone we're going for here." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103640 (owner: 10Shirayuki)
[21:46:08] <Technical_13>	 How can I find which pages use a specific system message... For example, [[MediaWiki:Group-sysop-member]] is nothing links to it on the WLH page, but it is used on [[Special:UserRights]]
[21:46:28] <jackmcbarn>	 Technical_13: grep is probably your best bet
[21:48:08] <marktraceur>	 mayankmadan: I dunno yet
[21:48:08] <marktraceur>	 It may be having issues, but not clear
[21:48:14] <mayankmadan>	 did you have a look at the changes?
[21:48:18] <grrrit-wm>	 (03PS2) 10MarkTraceur: Including api-error-stasherror from core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105097 (owner: 10Mayankmadan)
[21:48:29] <marktraceur>	 I'm looking briefly
[21:48:56] <VladAndrew>	 Nemo_bis: so for example I should apply tvar tag to PHP 5 support has been required since MediaWiki 1.7[...] ??
[21:48:57] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] Adding a message for api-error-stasherror (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105094 (owner: 10Mayankmadan)
[21:49:11] <marktraceur>	 mayankmadan: You may want to note the dependency that they have
[21:49:37] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] Including api-error-stasherror in frontend messages (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105097 (owner: 10Mayankmadan)
[21:50:36] <mayankmadan>	 marktraceur, what dependencies?
[21:51:09] <grrrit-wm>	 (03PS3) 10Mayankmadan: Including api-error-stasherror from core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105097 
[21:53:54] <grrrit-wm>	 (03CR) 10GWicke: [C: 031] "One minor thing to possibly check (see inline comment), otherwise looks good to me." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105090 (owner: 10Subramanya Sastry)
[21:53:55] <grrrit-wm>	 (03PS5) 10Bartosz Dziewoński: Update RELEASE-NOTES [core] - 10https://gerrit.wikimedia.org/r/104718 (owner: 10Siebrand)
[21:54:11] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Update RELEASE-NOTES [core] - 10https://gerrit.wikimedia.org/r/104718 (owner: 10Siebrand)
[21:54:17] <grrrit-wm>	 (03CR) 10Theopolisme: "Oops, thanks!" [core] - 10https://gerrit.wikimedia.org/r/104707 (owner: 10Theopolisme)
[21:54:31] <grrrit-wm>	 (03CR) 10GWicke: "Also, what's up with Jenkins?" [core] - 10https://gerrit.wikimedia.org/r/105090 (owner: 10Subramanya Sastry)
[21:55:15] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "https://integration.wikimedia.org/zuul/ : "Queue lengths: 101 events, 9 results.". Probably localisation update happened." [core] - 10https://gerrit.wikimedia.org/r/105090 (owner: 10Subramanya Sastry)
[21:55:31] <VladAndrew>	 Nemo_bis, could you help me with an example on the Download page https://www.mediawiki.org/wiki/Download ?
[21:55:58] <grrrit-wm>	 (03CR) 10Subramanya Sastry: Sync up with Parsoid parserTests. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/105090 (owner: 10Subramanya Sastry)
[21:56:12] <MatmaRex>	 Nikerabbit: around?
[21:56:13] <VladAndrew>	 I should add these tags to the download links and notes like dimensions
[21:56:18] <MatmaRex>	 Nikerabbit: who controls l10n-bot?
[21:56:45] <MatmaRex>	 Nikerabbit: and could they make it run its localisation update on all repos at some time where normal people are not pushing patches? :)
[21:56:45] <grrrit-wm>	 (03CR) 10Subramanya Sastry: "Jenkins heard you complaining ..." [core] - 10https://gerrit.wikimedia.org/r/105090 (owner: 10Subramanya Sastry)
[21:59:20] <mayankmadan>	 MatmaRex, around?
[21:59:38] <MatmaRex>	 yeah
[22:00:57] <Nemo_bis>	 MatmaRex: raymond does, and what's such a time when he also is not working or sleeping?
[22:01:28] <MatmaRex>	 Nemo_bis: around four hours from now should be saner than the current
[22:01:53] <MatmaRex>	 actually, around 8
[22:02:07] <MatmaRex>	 it's night/late evening in both the Europe and the US
[22:02:27] <MatmaRex>	 while now is evening here and lunchtime in the US
[22:02:43] <MatmaRex>	 or make it continuously submit changes throughout a day as to not overwhelm jenkins, i guess
[22:02:57] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Including api-error-stasherror from core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105097 (owner: 10Mayankmadan)
[22:03:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Adding a message for api-error-stasherror [core] - 10https://gerrit.wikimedia.org/r/105094 (owner: 10Mayankmadan)
[22:03:07] <Nemo_bis>	 do you have any idea how the bot works?
[22:03:20] <Nemo_bis>	 it's not automated, Raymond has to check what it does
[22:03:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make it possible for extensions to specify which version of MediaWiki they support via Composer. [core] - 10https://gerrit.wikimedia.org/r/105092 (owner: 10Jeroen De Dauw)
[22:03:59] <Nemo_bis>	 and he's done so every day for many years now (also when it wasn't as semi-automated as it is currently)
[22:04:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Including api-error-stasherror from core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105097 (owner: 10Mayankmadan)
[22:05:17] <grrrit-wm>	 (03PS5) 10Jeroen De Dauw: Make it possible for extensions to specify which version of MediaWiki they support via Composer. [core] - 10https://gerrit.wikimedia.org/r/105092 
[22:05:21] <grrrit-wm>	 (03PS2) 10Mayankmadan: Adding a message for api-error-stasherror [core] - 10https://gerrit.wikimedia.org/r/105094 
[22:05:21] <MatmaRex>	 Nemo_bis: i haven't had any idea D: why is it not automated? that's awful
[22:06:10] <Nemo_bis>	 MatmaRex: because people can still edit localisation files on the repo :) not all conflicts can be handled automatically
[22:06:19] <Nemo_bis>	 that's the main reason I believe
[22:06:57] <VladAndrew>	 Nemo_bis: also what kind of problems does this page has https://www.mediawiki.org/wiki/Help:Mass_account_creation?
[22:07:10] <Nemo_bis>	 maybe the +2'ing script might be triggered later, dunno; but I've no idea if it's a good idea to let all those patches rot
[22:08:05] <Nemo_bis>	 VladAndrew: the splitting is not logical
[22:08:25] <VladAndrew>	 Nemo_bis: and here https://www.mediawiki.org/wiki/Help:External_searches should I make a wikitable ?
[22:08:41] <Nemo_bis>	 it would also be nice to have Special:MyLanguage used
[22:09:26] <Nemo_bis>	 I doubt a table would help, I'm unsure about that page...
[22:10:02] <VladAndrew>	 Nemo_bis: I haven't marked that table for translation, the rest of tesk is marked
[22:10:39] <grrrit-wm>	 (03PS3) 10Mayankmadan: Adding a message for api-error-stasherror [core] - 10https://gerrit.wikimedia.org/r/105094 
[22:10:51] <mayankmadan>	 marktraceur, now?
[22:11:12] <Nemo_bis>	 VladAndrew: that page might need to be deleted even, could you perhaps work on another one like https://www.mediawiki.org/wiki/Help:Blocking_users ?
[22:11:53] <VladAndrew>	 Nemo_bis: yep, no problem
[22:12:14] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 031] "I'll have Nemo_bis double check, because it's i18n - or siebrand if he's faster." [core] - 10https://gerrit.wikimedia.org/r/105094 (owner: 10Mayankmadan)
[22:12:16] <VladAndrew>	 When you say it is not logical splitted you mean that ?
[22:12:36] <mayankmadan>	 marktraceur, what about the other one :)
[22:12:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update RELEASE-NOTES [core] - 10https://gerrit.wikimedia.org/r/104718 (owner: 10Siebrand)
[22:12:47] <legoktm>	  wmfgerrit created branch wmf/1.23wmf9 at wikimedia/mediawiki-extensions-MassMessage
[22:12:48] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make it possible for extensions to specify which version of MediaWiki they support via Composer. [core] - 10https://gerrit.wikimedia.org/r/105092 (owner: 10Jeroen De Dauw)
[22:12:53] <legoktm>	 do extensions now automatically get branches?
[22:13:11] <AaronSchulz>	 From wmf9 on afaik
[22:13:34] <marktraceur>	 mayankmadan: Don't want to merge it 'til the core patch is merged
[22:13:50] <Nemo_bis>	 VladAndrew: no, I mean that you split a sentence across two units and put two half sentences in the same unit
[22:14:09] <VladAndrew>	 oh
[22:14:16] <mayankmadan>	 marktraceur, how about just a +1 so the task can be closed
[22:14:38] <marktraceur>	 Sigh, sure
[22:14:44] <mayankmadan>	 Nemo_bis, https://gerrit.wikimedia.org/r/#/c/105094/ how is this for the solution to api-error-stasherror
[22:15:05] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 031] "Once I2895fe77d147a9065710912b5c2673ab833dd29f is merged this is good to go." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105097 (owner: 10Mayankmadan)
[22:15:12] <marktraceur>	 mayankmadan: Done
[22:15:23] <mayankmadan>	 marktraceur, thank you
[22:15:33] <Nemo_bis>	 mayankmadan: you have better judges for that :)
[22:15:46] <grrrit-wm>	 (03PS6) 10Ori.livneh: Add user-agent logging for server-side events [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/104040 (owner: 10Nuria)
[22:15:59] <mayankmadan>	 Nemo_bis, so marktraceur said yes, so the task can be considered complete?
[22:16:26] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: Stop using the unholy trinity in DatabaseError [core] - 10https://gerrit.wikimedia.org/r/105000 (owner: 10Chad)
[22:17:43] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "Please add message documentation when adding messages. See https://www.mediawiki.org/wiki/I18n#Message_documentation for details." [core] - 10https://gerrit.wikimedia.org/r/105094 (owner: 10Mayankmadan)
[22:19:05] <grrrit-wm>	 (03CR) 10Siebrand: "Thanks, Bartosz." [core] - 10https://gerrit.wikimedia.org/r/104718 (owner: 10Siebrand)
[22:19:25] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] "I fixed a comment because Chad cannot grammar." [core] - 10https://gerrit.wikimedia.org/r/105000 (owner: 10Chad)
[22:19:30] <VladAndrew>	 Nemo_bis:  https://www.mediawiki.org/wiki/Help:Mass_account_creation what do you think ?
[22:19:39] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] Replace usage of SpecialPage::getTitle with getPageTitle [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/103972 (owner: 10Legoktm)
[22:19:46] <grrrit-wm>	 (03CR) 10Mattflaschen: [V: 032] Replace usage of SpecialPage::getTitle with getPageTitle [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/103972 (owner: 10Legoktm)
[22:20:15] <theopolisme>	 marktraceur, did you see my message from a while ago re: design of the fullscreen button?
[22:20:20] <theopolisme>	 Sorry that I had to run
[22:20:44] <marktraceur>	 theopolisme: Oh, hm, I guess I didn't
[22:21:05] <theopolisme>	 Short version is that it's currently black
[22:21:11] <Nemo_bis>	 VladAndrew: [[m:Help:Logging in|Logging in]] should be [[m:Special:MyLanguage/Help:Logging in|Logging in]] please; the splitting others could do differently but it's a matter of taste
[22:21:13] <theopolisme>	 But should it be made to match the X?
[22:21:28] <marktraceur>	 theopolisme: Actually, master has an updated version
[22:22:22] <theopolisme>	 Ooh, did not see updated version
[22:22:27] <HectorAE>	 Hello people, haven't checked in for a while.
[22:22:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Stop using the unholy trinity in DatabaseError [core] - 10https://gerrit.wikimedia.org/r/105000 (owner: 10Chad)
[22:22:39] <marktraceur>	 They're way prettier
[22:22:53] <Nemo_bis>	 how are things in pt.wiki
[22:23:37] <VladAndrew>	 done
[22:24:44] <grrrit-wm>	 (03PS4) 10Mayankmadan: Adding a message for api-error-stasherror [core] - 10https://gerrit.wikimedia.org/r/105094 
[22:24:51] <ori>	 ebernhardson: profiling RFC discussion on #wikimedia-meetbot
[22:24:56] <mayankmadan>	 siebrand, how is it looking now?
[22:25:44] <mooey>	 siebrand, No Matter How Many Times I Try To Remember, Title Text Keeps Creeping Back Into My i18n Files.
[22:26:01] <mooey>	 siebrand, I Think University Essays Ruined Me.
[22:26:03] <siebrand>	 mooey: Sure, No Problem.
[22:26:04] <mooey>	 ;)
[22:26:41] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "Message also needs to be added to messages.inc. See https://www.mediawiki.org/wiki/I18n#Adding_new_messages" [core] - 10https://gerrit.wikimedia.org/r/105094 (owner: 10Mayankmadan)
[22:29:50] <theopolisme>	 marktraceur, is the image supposed to look like tiled arrows?
[22:30:10] <marktraceur>	 theopolisme: It's supposed to look like two arrows facing away from each other, I guess
[22:30:18] <grrrit-wm>	 (03PS5) 10Mayankmadan: Adding a message for api-error-stasherror [core] - 10https://gerrit.wikimedia.org/r/105094 
[22:30:48] <mayankmadan>	 siebrand, how about now?
[22:31:30] <Nemo_bis>	 VladAndrew: not only the first one, all the links to wikis with Translate...
[22:31:36] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Adding a message for api-error-stasherror [core] - 10https://gerrit.wikimedia.org/r/105094 (owner: 10Mayankmadan)
[22:32:18] <theopolisme>	 marktraceur, that's what i thought... but right now i'm seeing http://i.imgur.com/XgWiiJm.png
[22:32:42] <marktraceur>	 Oh, weird
[22:32:45] <VladAndrew>	 sure thing
[22:33:14] <marktraceur>	 theopolisme: The other images have background: no-repeat, I think, and various background positioning rules
[22:33:25] <marktraceur>	 You should look at the CSS file for the examples
[22:33:33] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "Now looking at the actual behavior, I still like it, but the message should be a warning instead of an error (thus yellow of red) and the " [core] - 10https://gerrit.wikimedia.org/r/104926 (owner: 10Umherirrender)
[22:35:01] <MatmaRex>	 marktraceur: woot, are we still using css sprites? :(
[22:35:15] <marktraceur>	 MatmaRex: No, not allowed
[22:35:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Adding a message for api-error-stasherror [core] - 10https://gerrit.wikimedia.org/r/105094 (owner: 10Mayankmadan)
[22:35:28] <marktraceur>	 But pginer gave me images of weird sizes, so we're using CSS to fix it
[22:35:50] <MatmaRex>	 wut
[22:36:16] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] Including api-error-stasherror from core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105097 (owner: 10Mayankmadan)
[22:36:24] <grrrit-wm>	 (03PS2) 10Siebrand: Random documentation tweaks [core] - 10https://gerrit.wikimedia.org/r/104527 
[22:36:27] <mayankmadan>	 thank you
[22:36:47] <grrrit-wm>	 (03PS2) 10Siebrand: Throw exception on invalid RecentChange types [core] - 10https://gerrit.wikimedia.org/r/104528 
[22:36:53] <Nikerabbit>	 MatmaRex: it's good stress test for the system
[22:37:29] <grrrit-wm>	 (03PS1) 10Jackmcbarn: Allow moving pages with edit-protection [core] - 10https://gerrit.wikimedia.org/r/105103 
[22:37:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Including api-error-stasherror from core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/105097 (owner: 10Mayankmadan)
[22:38:38] <MatmaRex>	 Nikerabbit: it's also good stress test for developers, yknow ;)
[22:39:51] <MatmaRex>	 Nikerabbit: or you could have jenkins not check these commits, since last time i checked they were being auto-merged regardless of test results
[22:40:11] <Nikerabbit>	 MatmaRex: it could
[22:40:13] <MatmaRex>	 hashar will certainly be able to cook that up
[22:40:51] <grrrit-wm>	 (03PS1) 10Gerrit Patch Uploader: mw.notify() with message type and predefined styles [core] - 10https://gerrit.wikimedia.org/r/105104 
[22:40:56] <grrrit-wm>	 (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/105104 (owner: 10Gerrit Patch Uploader)
[22:41:34] <theopolisme>	 so marktraceur, i've got all the fullscreening stuff set up but haven't figured out the redraw/rendering issues. want me to upload a patch anyway?
[22:41:41] <VladAndrew>	 Nemo_bis: should I do that on this type of links [[Special:ListGroupRights]]?
[22:42:42] <Nemo_bis>	 VladAndrew: no
[22:42:46] <grrrit-wm>	 (03PS6) 10Jeroen De Dauw: Make it possible for extensions to specify which version of MediaWiki they support via Composer. [core] - 10https://gerrit.wikimedia.org/r/105092 
[22:43:23] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "Is the build failing because some tests are skipped? I hope not, that'd be silly..." [core] - 10https://gerrit.wikimedia.org/r/105092 (owner: 10Jeroen De Dauw)
[22:44:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make it possible for extensions to specify which version of MediaWiki they support via Composer. [core] - 10https://gerrit.wikimedia.org/r/105092 (owner: 10Jeroen De Dauw)
[22:44:58] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "It's probably failing because "22:12:25 [xUnit] [ERROR] - The result file '/srv/ssd/jenkins-slave/workspace/mediawiki-core-phpunit-databas" [core] - 10https://gerrit.wikimedia.org/r/105092 (owner: 10Jeroen De Dauw)
[22:45:04] <grrrit-wm>	 (03CR) 10Siebrand: "Thanks for the review. Updates in soon to be uploaded PS." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/104527 (owner: 10Siebrand)
[22:45:11] <VladAndrew>	 done
[22:45:17] <MatmaRex>	 who broke jenkins? :(
[22:45:38] <grrrit-wm>	 (03PS3) 10Siebrand: Random documentation tweaks [core] - 10https://gerrit.wikimedia.org/r/104527 
[22:46:23] <grrrit-wm>	 (03CR) 10Jackmcbarn: "Catrope: you originally added this behavior with https://www.mediawiki.org/wiki/Special:Code/MediaWiki/29922 back in 2008. Is there a reas" [core] - 10https://gerrit.wikimedia.org/r/105103 (owner: 10Jackmcbarn)
[22:46:49] <marktraceur>	 Not it
[22:47:28] <grrrit-wm>	 (03CR) 10Physikerwelt: "The situation is as follow:" [extensions/Math] - 10https://gerrit.wikimedia.org/r/104994 (owner: 10Physikerwelt)
[22:51:59] <grrrit-wm>	 (03PS2) 10Siebrand: Remove classes and functions deprecated in MediaWiki 1.17 [core] - 10https://gerrit.wikimedia.org/r/104156 
[22:54:33] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 031] "I was going to comment on two things which seemed incredibly silly, then I looked at a diff with more context and guess what, they were al" [core] - 10https://gerrit.wikimedia.org/r/105104 (owner: 10Gerrit Patch Uploader)
[22:57:51] <gwicke>	 TimStarling, would you like to discuss the RFC on IRC or the talk page?
[22:58:03] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: wtf jenkins [core] - 10https://gerrit.wikimedia.org/r/105107 
[22:58:51] <TimStarling>	 I think the talk page is best
[22:59:06] <gwicke>	 okay
[23:03:55] <mayankmadan>	 hi Bryan 
[23:04:15] <TimStarling>	 wtf is ULS doing aborting client requests?
[23:04:53] <grrrit-wm>	 (03PS11) 10Hoo man: Add mw.html to Scribunto [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 
[23:05:17] <grrrit-wm>	 (03CR) 10Hoo man: Add mw.html to Scribunto (036 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man)
[23:05:40] <grrrit-wm>	 (03CR) 10Hoo man: "Addressed Anomie's comments about input validation" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man)
[23:05:50] <ori>	 TimStarling: ?
[23:06:20] <TimStarling>	 firebug timeline shows me two requests for https://bits.wikimedia.org/static-current/extensions/UniversalLanguageSelector/data/fontrepo/fonts/Autonym/Autonym.woff?version=20131205
[23:06:38] <TimStarling>	 the first is aborted after 1.63 seconds, the second runs for 0.937 seconds
[23:07:42] <ori>	 which page?
[23:08:07] <TimStarling>	 https://www.mediawiki.org/wiki/Talk:Requests_for_comment/Services_and_narrow_interfaces
[23:08:49] * ori  looks, but also: ping Nikerabbit, santhosh, siebrand

[23:10:46] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "The icons are not very pretty, though… maybe they're just too large." [core] - 10https://gerrit.wikimedia.org/r/105104 (owner: 10Gerrit Patch Uploader)
[23:12:53] <VladAndrew>	 Nemo_bis: are the links ok ?
[23:12:59] <VladAndrew>	 I have made my changes
[23:13:45] <Nikerabbit>	 ori: beats me
[23:13:47] <TimStarling>	 it's reproducible
[23:13:56] <Nikerabbit>	 I don't get any requests for the font
[23:16:22] <Nikerabbit>	 in firefox, in chrome I get one
[23:17:13] <TimStarling>	 you need to force a reload
[23:17:18] <TimStarling>	 shift-reload
[23:17:51] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: [DNM] Remove ComposerPackageModifierTest to see if Jenkins is simply being fail [core] - 10https://gerrit.wikimedia.org/r/105109 
[23:18:11] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "Its just for this commit, and locally I can generate code coverage just fine." [core] - 10https://gerrit.wikimedia.org/r/105092 (owner: 10Jeroen De Dauw)
[23:22:26] <Nikerabbit>	 then I see one in firefox 26
[23:23:39] <Nikerabbit>	 night
[23:24:14] <ori>	 TimStarling: can you reproduce it using the native browser network debug pane, with firebug disabled?
[23:24:33] <ori>	 if not, it could be <https://support.mozilla.org/en-US/questions/950680>
[23:28:06] <TimStarling>	 could be
[23:28:19] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Change Title::getInterwiki() in conditions to Title::isExternal() [core] - 10https://gerrit.wikimedia.org/r/104753 (owner: 10Umherirrender)
[23:28:48] <TimStarling>	 I've found the caller, mw.util.addCSS() adds an @font-face directive to the <head>
[23:31:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Change Title::getInterwiki() in conditions to Title::isExternal() [core] - 10https://gerrit.wikimedia.org/r/104753 (owner: 10Umherirrender)
[23:32:54] <AaronSchulz>	 gwicke: I noticed that the math patches were abandoned, any idea what's going on there?
[23:33:18] <AaronSchulz>	 maybe that frees you up for https://gerrit.wikimedia.org/r/#/c/101226/ ;)
[23:35:01] <TimStarling>	 with firebug disabled, I still see two requests for the same font
[23:35:38] <grrrit-wm>	 (03PS1) 10Mayankmadan: getApiWarnings() throws an exception if upload is invalid [core] - 10https://gerrit.wikimedia.org/r/105111 
[23:36:12] <TimStarling>	 and one is smaller than the other, so it may be that the first request was aborted but firefox is not interpreting that situation correctly
[23:38:49] <grrrit-wm>	 (03PS1) 10MaxSem: Update MobileFrontend to wmf9 tip [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105113 
[23:40:45] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] "No idea on whether this is the right way to fix the bug, but code comments." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/105111 (owner: 10Mayankmadan)
[23:41:21] <grrrit-wm>	 (03PS7) 10Jeroen De Dauw: Make it possible for extensions to specify which version of MediaWiki they support via Composer. [core] - 10https://gerrit.wikimedia.org/r/105092 
[23:42:11] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Add ComposerPackageModifierTest integration test [core] - 10https://gerrit.wikimedia.org/r/105114 
[23:42:25] <grrrit-wm>	 (03Abandoned) 10Jeroen De Dauw: [DNM] Remove ComposerPackageModifierTest to see if Jenkins is simply being fail [core] - 10https://gerrit.wikimedia.org/r/105109 (owner: 10Jeroen De Dauw)
[23:42:42] <TimStarling>	 why does it do the request via HTTPS even when I'm on HTTP?
[23:43:30] <grrrit-wm>	 (03PS2) 10Mayankmadan: getApiWarnings() throws an exception if upload is invalid [core] - 10https://gerrit.wikimedia.org/r/105111 
[23:44:40] <ori>	 TimStarling: because $wgULSFontRepositoryBasePath hard-codes the protocol
[23:44:43] <ori>	 in CommonSettings.php
[23:45:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add ComposerPackageModifierTest integration test [core] - 10https://gerrit.wikimedia.org/r/105114 (owner: 10Jeroen De Dauw)
[23:46:20] <ori>	 TimStarling: http://www.webpagetest.org/result/140102_3N_WGP/1/details/ <-- one request for Autonym.woff using FF
[23:48:47] <TimStarling>	 right, I was looking at an old version of ULS
[23:50:07] <TimStarling>	 you did this?
[23:50:20] <ori>	 i just ran the test, yes
[23:50:33] <TimStarling>	 no, I mean you introduced $wgULSFontRepositoryBasePath and made it HTTPS only
[23:52:03] <ori>	 hah, I did
[23:52:30] <TimStarling>	 why?
[23:52:40] <ori>	 stupid mistake, it should be proto-relative
[23:52:43] <ori>	 i'll fix
[23:52:51] <ori>	 i forgot i set it
[23:55:13] * AaronSchulz  never noticed MelBee here before

[23:56:26] <TimStarling>	 well, the client-side abort is visible in tcpdump, even with HTTPS, if you use some imagination
[23:57:30] <TimStarling>	 since it's the only object that uses HTTPS, it's not too hard
[23:57:47] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Declare visibility for class properties in MySQLMasterPos [core] - 10https://gerrit.wikimedia.org/r/103878 (owner: 10Siebrand)
[23:58:19] <TimStarling>	 you can see that it sends a FIN, then opens a new connection, then sends a load of RST packets after 100ms or so as the rest of the data on the old connection comes in
[23:59:08] <TimStarling>	 11 RST packets in this trace
[23:59:54] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to wmf9 tip [core] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/105113 (owner: 10MaxSem)