[00:02:14] (03Merged) 10jenkins-bot: Refactor ProfilerSimple [core] - 10https://gerrit.wikimedia.org/r/104780 (owner: 10Ori.livneh) [00:03:17] AaronSchulz: looks ok, but have you considered making the class implement the Iterator interface instead? [00:03:59] this would absolve the user from having to specify in advance the number of values that will be required [00:04:40] I don't want to hold the lock for too long [00:05:23] good reason [00:05:24] you have to lock,incr,unlock AFAP [00:05:31] * AaronSchulz actually thought about having a preallocate function but thought it overkill [00:05:59] its useful for things like FileBackend, where you can do primeCache() on a list of files you probably will getFileStat() on soon [00:06:10] it could be here, but there is only 1 use case atm [00:06:22] yeah, might be nice to do at some point [00:07:01] reminds, I need to add concurrent file stat support (beyond concurrently loading from cache) [00:07:03] i presume you mean something like this -- calling next() first checks if there are values ready at hand in an internal array [00:07:31] if not, it generates the next batch, returning the first and stuffing the remainder into the internal array buffer [00:07:33] of course that would be after that scary https://gerrit.wikimedia.org/r/#/c/101226/ commit is merged [00:07:58] ori: right [00:08:17] makes sense; it's how line-based buffer iterators work in many cases [00:08:22] (03PS9) 10Gergő Tisza: Add blacklisting feature for flickr in backend [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [00:08:25] same with the UID methods, that Flow uses [00:08:36] I don't know if they insert anything in batch though [00:08:49] and the overhead is low for now [00:08:58] you need to scan for a newline but it's inefficient to get one character at a time, so you recv a chunk and if it goes beyond the newline you put the remainder in an internal buffer [00:08:59] (03CR) 10Gergő Tisza: "Improvements per Anomie's comments." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [00:09:06] yeah, not critical for this patch at all [00:10:53] AaronSchulz: do you mind if i take a bit longer to review this? (<24h) [00:11:16] it looks right, the tests pass, and I'm pretty sure it's not hiding any nasty bugs [00:11:27] still, it looks like a code path that someone else should walk through in detail [00:11:55] ori: haha, it's not a super rush [00:12:07] but it would replace the last live hack not in master [00:13:11] ok, will look at it in detail tomorrow morning [00:14:22] (03CR) 10Huji: "Agreed, something had gone wrong. I will abandon this and recreate the patch." [core] - 10https://gerrit.wikimedia.org/r/104165 (owner: 10Huji) [00:14:43] (03Abandoned) 10Huji: Merge "Replace use of deprecated SpecialPageFactory::getGroup()" [core] - 10https://gerrit.wikimedia.org/r/104165 (owner: 10Huji) [00:14:48] * AaronSchulz is almost tempted to buy stuff at http://www.istorage-uk.com/datashur.php [00:14:55] what is this about? [00:14:57] 00:04:25 .....S....................A database query error has occurred. [00:14:57] 00:04:25 Query: SELECT user_id FROM unittest_user WHERE user_name = 'UTSysop' LIMIT 1 [00:14:57] 00:04:25 Function: User::idForName [00:14:59] 00:04:25 Error: 1 no such table: unittest_user [00:15:11] i noticed the HHVM tests failing on that, figured it was an HHVM bug, but now i see it in jenkins too [00:15:14] https://integration.wikimedia.org/ci/job/mediawiki-core-regression-master/4005/console [00:21:00] (03PS2) 10Bsitu: Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 [00:21:45] AaronSchulz: that looks pretty good [00:25:52] ori: https://bugzilla.wikimedia.org/show_bug.cgi?id=59105 [00:27:06] PleaseStand: ah, thanks. https://bugzilla.wikimedia.org/show_bug.cgi?id=42529 seems related too [00:28:25] (03PS1) 10Cmcmahon: Revert "add BROWSER_LABEL to edit string per Bug 59011" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104783 [00:28:36] (03PS1) 10Huji: Add .gitignore to the /skins directory [core] - 10https://gerrit.wikimedia.org/r/104784 [00:33:39] (03CR) 10TTO: [C: 031] Change Title::getInterwiki() in conditions to Title::isExternal() [core] - 10https://gerrit.wikimedia.org/r/104753 (owner: 10Umherirrender) [00:36:12] (03CR) 10Huji: "This does the job; I intentionally reorganized the .gitignore file so it is more obvious how it is done. It ignores all .php files except " [core] - 10https://gerrit.wikimedia.org/r/104784 (owner: 10Huji) [00:47:43] (03PS1) 10Spage: Add some comments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104785 [00:48:39] (03CR) 10Cmcmahon: [C: 032] Add some comments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104785 (owner: 10Spage) [00:48:46] (03Merged) 10jenkins-bot: Add some comments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104785 (owner: 10Spage) [00:51:35] would it be viable from a performance standpoint to add an interface to purge or null-edit batches of pages? (e.g. everything transcluding a given template) [00:57:07] Happy new year everybody! [00:58:29] Dec 31 [19:59:14] Happy new year everybody! [00:58:32] just saying [00:59:00] Timezones. [00:59:38] at least nobody can grumble about NA bias now ;) [01:03:48] (03CR) 10Legoktm: [V: 032] Fix bug with getDupeWarning [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/103384 (owner: 10UltrasonicNXT) [01:11:13] (03CR) 10PleaseStand: "MailAddress::toString() currently calls UserMailer::quotedPrintable() and then adds double quotes under very limited conditions, which as " [core] - 10https://gerrit.wikimedia.org/r/104707 (owner: 10Theopolisme) [01:16:50] (03PS1) 10Cmcmahon: Edit title and body with weird stuff [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104786 [01:17:39] (03PS2) 10Cmcmahon: Revert "add BROWSER_LABEL to edit string per Bug 59011" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104783 [01:18:08] (03CR) 10Cmcmahon: [C: 032] "reverting for Bug 59176" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104783 (owner: 10Cmcmahon) [01:43:03] (03PS1) 10Legoktm: Allow sending a message to every single user on all wikis [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/104789 [01:45:02] (03CR) 10Odder: [C: 04-1] "Patch does not include any magic to check if the username of the sender == 'Sue Gardner'. Please improve." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/104789 (owner: 10Legoktm) [01:45:33] "Patch does not include any magic" [01:45:37] :D [01:52:12] (03PS2) 10Legoktm: Allow sending a message to every single user on all wikis [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/104789 [01:53:00] (03CR) 10Legoktm: "Now requires the user to have the "emperor-of-the-universe" userright. Someone will need to give Sue that right on meta." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/104789 (owner: 10Legoktm) [01:54:06] (03CR) 10Odder: "Yes, please." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/104789 (owner: 10Legoktm) [02:13:15] emperor-of-the-universe? [02:32:08] (03CR) 10Peachey88: [C: 04-1] "Unless i've missed some news about Sue, it should be "Empress" compared to Emperor (even then it could be classed as incorrect)." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/104789 (owner: 10Legoktm) [02:54:47] PleaseStand, hi -- I'm at a bit of a loss for next steps for https://gerrit.wikimedia.org/r/#/c/104707/ . Are you saying that simply stripping newlines/returns is inadequate, and, if so, is merging that commit not possible until some more serious improvement to the underlying functions? [03:11:23] csteipp-ish: what does -ish mean? That you are not quite the read cstiepp? [03:12:01] (03CR) 10Santhosh: [C: 031] i18n: Native digits on '#renderingProgress' [extensions/Collection] - 10https://gerrit.wikimedia.org/r/104767 (owner: 10Reza) [03:15:33] (03CR) 10Theopolisme: "Are you saying that simply stripping newlines/returns is inadequate, and, if so, is merging this commit not possible until some more serio" [core] - 10https://gerrit.wikimedia.org/r/104707 (owner: 10Theopolisme) [03:16:07] (03PS5) 10Theopolisme: Deprecate $wgPasswordSenderName [core] - 10https://gerrit.wikimedia.org/r/104707 [03:43:49] marktraceur, got a sec? right now the fullscreen link is black and can't really be seen when not in fullscreen mode -- to be consistent with the "X" should it be made white as well? [03:51:12] (03CR) 10Ori.livneh: "Thanks for this patch! Do you have any benchmarks you can share? I think we might want to try this setup out in Wikimedia's production clu" [core] - 10https://gerrit.wikimedia.org/r/104663 (owner: 10Jqnatividad) [04:46:17] (03CR) 10Nullzero: "Wait. Just update commit message makes the patch need code review again? It totally doesn't make sense." [core] - 10https://gerrit.wikimedia.org/r/104708 (owner: 10Nullzero) [05:15:57] hi Nemo_bis [05:39:20] Nemo_bis, around [06:00:04] (03CR) 10Spage: [C: 04-1] "The .LESS source needs a comment explaining the change." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104758 (owner: 10Bsitu) [07:35:08] (03PS1) 10EBernhardson: prevent fatal when passing null to getInnerHtml [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104791 [07:35:10] (03PS1) 10EBernhardson: Update constructor arguments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104792 [07:43:53] Nemo_bis, ping me when you get this [08:00:03] (03PS2) 10Nullzero: make MOVED_TO* working [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104706 [08:02:19] (03CR) 10Nullzero: [C: 04-1] "Can be merged if https://gerrit.wikimedia.org/r/#/c/104708/ is merged before." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104706 (owner: 10Nullzero) [08:45:33] mayankmadan: pong [08:48:14] (03CR) 10Nemo bis: [C: 04-1] "Doesn't match stated purpose: the title is already taken by a different person. https://meta.wikimedia.org/wiki/File:Tomersnewrole.ogg" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/104789 (owner: 10Legoktm) [08:49:07] (03CR) 10Legoktm: [C: 032] Replace deprecated SpecialPage::getLang() [extensions/Configure] - 10https://gerrit.wikimedia.org/r/104393 (owner: 10Siebrand) [08:49:43] (03PS1) 10AalekhN: Made Changes as per Bug 34999 {{{foo}}} is working on the local machine [extensions/Cite] - 10https://gerrit.wikimedia.org/r/104794 [08:49:44] (03Merged) 10jenkins-bot: Replace deprecated SpecialPage::getLang() [extensions/Configure] - 10https://gerrit.wikimedia.org/r/104393 (owner: 10Siebrand) [09:02:50] Nemo_bis, did you have a look at this? https://gerrit.wikimedia.org/r/104782 [09:08:16] (03PS1) 10Santhosh: Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 [09:10:39] (03CR) 10jenkins-bot: [V: 04-1] Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh) [09:18:48] Nemo_bis, around? [09:19:31] seen it now [09:21:09] (03CR) 10Nemo bis: Adding code comments of resulting keys (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/104782 (owner: 10Mayankmadan) [09:22:14] Nemo_bis, im not sure what it can give, how can i find out? [09:22:22] but the aim of the task is this, right? [09:24:26] you have to check that function [09:24:27] yes [09:49:17] (03CR) 10Nemo bis: "Hi, thanks for your patch. The future reviewers can see the previous +1 in the comments anyway, don't worry." [core] - 10https://gerrit.wikimedia.org/r/104708 (owner: 10Nullzero) [09:49:45] Nemo_bis, by check you mean i call the function in js console in the browser? [09:50:04] 185k lines :O https://gerrit.wikimedia.org/r/#/c/104677/ [09:50:16] mayankmadan: no idea [09:50:32] isn't that code defined in UW itself? [09:51:35] Nemo_bis, the code to check is in a js file in UW extension [09:57:11] Nemo_bis, and i cant reproduce the bug [10:01:24] mayankmadan: I know, that's why I suggested to instead look at all the keys that can be generated anywhere [10:02:06] Nemo_bis, i looked at all the keys that could possibly return mwe-upwiz-undefined [10:02:29] and there were only those 2 [10:02:47] the problem is i cant call that function from console [10:20:32] Nemo_bis, i dont understand what you are trying to say [10:21:26] ok, you can also do it your way [10:21:53] then you need to catch that case and emit another (existing) message, or add a message for that case [10:22:29] (03PS2) 10Santhosh: Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 [10:22:55] Nemo_bis, what was your way? [10:24:27] (03CR) 10jenkins-bot: [V: 04-1] Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh) [10:25:42] (03CR) 10Nemo bis: "There's also a proposal to replace UserMailer but I very much hope it's not needed for this small change: https://www.mediawiki.org/wiki/R" [core] - 10https://gerrit.wikimedia.org/r/104707 (owner: 10Theopolisme) [10:27:50] (03CR) 10Nemo bis: Deprecate $wgPasswordSenderName (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104707 (owner: 10Theopolisme) [10:39:09] Nemo_bis, what was your way? [10:54:35] Nemo_bis, around? [11:20:58] Nemo_bis, any help in calling the mw.UploadWizardDetails function? [11:26:37] (03PS1) 10Umherirrender: Add message wrongpassword as html on Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/104797 [11:28:23] (03CR) 10Se4598: [C: 04-1] "The message doesn't match the actual behavior. It's publicly viewable if the filter is, but also private if the filter is (see bugreport)." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104761 (owner: 1001tonythomas) [11:37:07] (03PS3) 10Santhosh: Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 [11:40:32] (03CR) 10jenkins-bot: [V: 04-1] Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh) [11:46:39] (03CR) 10TTO: "See also Iac16d4fb68e3742d2d2adb9363a4052ab194b338. This patch is better because it only switches to HTML when necessary." [core] - 10https://gerrit.wikimedia.org/r/104797 (owner: 10Umherirrender) [11:52:28] (03CR) 10jenkins-bot: [V: 04-1] Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh) [11:54:17] yurik: I just noticed that there's a new page for new developers... It looks great and is much more easier to grasp. Thanks so much :) [11:54:21] (03CR) 10Santhosh: "Qunit tests will fail till we update the CLDR parser(javascript version) to use the new data format." [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh) [12:11:10] (03CR) 10Dan-nl: "gergő, are you okay with +2’ing this or would you rather have someone else, e.g., bryan, do it?" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/104319 (owner: 10Dan-nl) [12:11:14] (03CR) 10Jforrester: "Agreed with Mark – if no matching skins are installed, we should quietly bail and not display the particular Beta Feature preference at al" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/102383 (owner: 10Legoktm) [12:18:20] Nemo_bis, around? [12:29:36] perhaps [12:29:54] (as I said, best chances are on bugzilla) [12:30:27] (03PS5) 10Amire80: Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh) [12:34:30] (03CR) 10jenkins-bot: [V: 04-1] Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh) [12:35:02] Nemo_bis, but i cant use the function mw.UploadWizardDetails to get the message in browser's js console [12:47:02] guillom, its done now [12:47:35] mayankmadan_: yes, I got the e-mail notification [12:47:50] by the way, Happy New Year [12:48:29] I don't celebrate the new year, but happy new year to you if you do [12:58:48] guillom, thanks for closing the task [12:59:01] sure [13:06:55] Nemo_bis, forget about the other task, i am sure i can do it later myself. Lets move on to the flickr task [13:07:43] (03CR) 10Gergő Tisza: [C: 032] "Haven't tested, but should not affect Commons since it has TemplateData installed." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/104319 (owner: 10Dan-nl) [13:07:49] (03Merged) 10jenkins-bot: add templatedata api check [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/104319 (owner: 10Dan-nl) [13:12:37] I understand, that's more interesting [13:13:18] Nemo_bis, oh yeah [13:24:38] (03CR) 10Hoo man: [C: 032] "Wont harm" [core] - 10https://gerrit.wikimedia.org/r/104708 (owner: 10Nullzero) [13:28:37] (03Merged) 10jenkins-bot: LogEntry: Make newFromRow work with RC object [core] - 10https://gerrit.wikimedia.org/r/104708 (owner: 10Nullzero) [13:37:49] (03PS1) 10Dan-nl: translatewiki-issues [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/104801 [13:39:02] Nemo_bis, have a look at this https://gerrit.wikimedia.org/r/#/c/103967/ [13:39:15] i know i need to use getphotoset func [13:54:15] mayankmadan_: perhaps you should focus on just one URL type at a time [13:54:41] Nemo_bis, so i should start with just one type [13:55:20] or similar types [13:55:25] okay [14:02:38] (03CR) 10Nullzero: "https://gerrit.wikimedia.org/r/#/c/104708/ was merged, so LogEntry::newFromRow works now!" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104706 (owner: 10Nullzero) [14:18:52] (03CR) 10Hoo man: "I'm a little concerned about backwards compatibility here (AbuseFilter is supposed to work with MediaWiki 1.19 an newer). This needs to be" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104706 (owner: 10Nullzero) [14:28:46] (03PS6) 10Theopolisme: Deprecate $wgPasswordSenderName [core] - 10https://gerrit.wikimedia.org/r/104707 [14:29:52] marktraceur, hi [14:39:43] (03CR) 10btongminh: "My comments earlier in #wikimedia-dev:" [core] - 10https://gerrit.wikimedia.org/r/104012 (owner: 10Mayankmadan) [14:45:01] hi Bryan [14:47:37] (03PS6) 10Amire80: Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh) [14:51:34] (03CR) 10jenkins-bot: [V: 04-1] Update plural rules to CLDR 24 [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh) [15:25:41] (03PS3) 10IAlex: Update comment for wfMsgExt() [core] - 10https://gerrit.wikimedia.org/r/100981 (owner: 10Siebrand) [15:25:48] (03CR) 10IAlex: [C: 032] Update comment for wfMsgExt() [core] - 10https://gerrit.wikimedia.org/r/100981 (owner: 10Siebrand) [15:30:34] (03Merged) 10jenkins-bot: Update comment for wfMsgExt() [core] - 10https://gerrit.wikimedia.org/r/100981 (owner: 10Siebrand) [15:32:50] (03PS2) 10IAlex: Update docs for Revision::getRevisionText() [core] - 10https://gerrit.wikimedia.org/r/102655 (owner: 10Siebrand) [15:32:57] (03CR) 10IAlex: [C: 032] Update docs for Revision::getRevisionText() [core] - 10https://gerrit.wikimedia.org/r/102655 (owner: 10Siebrand) [15:39:14] (03Merged) 10jenkins-bot: Update docs for Revision::getRevisionText() [core] - 10https://gerrit.wikimedia.org/r/102655 (owner: 10Siebrand) [15:46:54] Hello everyone. Is it possible to filter some categories out of the “Random page”-thingy? [15:52:59] sjoerddebruin: No, not in core Mediawiki [15:53:24] Okay, is it very difficult to make a extension for it? [15:56:57] (03PS1) 10IAlex: Use SpecialPage::getPageTitle() instead of SpecialPage::getTitle() [core] - 10https://gerrit.wikimedia.org/r/104805 [16:05:21] sjoerddebruin: have you tried https://www.mediawiki.org/w/index.php?title=Special%3ASearch&profile=advanced&search=random&fulltext=Search&ns102=1&redirs=1&profile=advanced ? [16:05:47] I saw one, but I think its outdated Nemo_bis [16:06:01] https://www.mediawiki.org/wiki/Extension:ExcludeRandom [16:06:33] But I need one that looks for categories or templates. [16:06:37] one more reason to test it :) [16:06:42] I want to exclude the stubs. [16:06:48] never trust mediawiki docs (bug 1) [16:07:11] maybe that extension has that feature already but undocumented (and broken) [16:07:28] always better look a bit at what exists before trying to do from scratch IMHO [16:19:10] (03PS1) 10IAlex: Fix bad usage of empty() function [core] - 10https://gerrit.wikimedia.org/r/104810 [16:27:58] (03PS3) 10Umherirrender: Avoid Generic accessor in Category.php [core] - 10https://gerrit.wikimedia.org/r/62986 [16:30:06] Is there a difference between and ? ... [16:53:41] MegaAlex: no [16:54:16] the former follows the style of html tags, the latter uh [17:00:23] Nemo_bis: hm.. do you have an idea why the language block is not being included in the translated Help:Magic words pages? .. [17:10:30] MegaAlex: because you had not added it and I forgot to remark after adding it [17:11:41] Nemo_bis: oh I see.. [17:15:38] :) [17:16:37] (03PS3) 10Gergő Tisza: A way to blacklist flickr users. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [17:18:22] very nice work you're doing [17:20:50] (03CR) 10Qgil: "Adding more reviewers with the hope that someone can look at this change today. I know, being New Yearś day it's not easy." [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/104208 (owner: 10Geek400) [17:23:01] (03CR) 10Parent5446: [C: 04-1] Fix bad usage of empty() function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104810 (owner: 10IAlex) [17:23:49] (03CR) 10Parent5446: [C: 032] Use SpecialPage::getPageTitle() instead of SpecialPage::getTitle() [core] - 10https://gerrit.wikimedia.org/r/104805 (owner: 10IAlex) [17:25:02] (03CR) 10Gergő Tisza: "* rebased on top of I97f8be, use flickrblacklist API instead of parsing the blacklist page by hand" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [17:25:53] (03CR) 10Gergő Tisza: "I97f8be also takes care of server-side checks." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/42770 (owner: 10Nischayn22) [17:27:35] (03Merged) 10jenkins-bot: Use SpecialPage::getPageTitle() instead of SpecialPage::getTitle() [core] - 10https://gerrit.wikimedia.org/r/104805 (owner: 10IAlex) [17:27:45] (03CR) 10Parent5446: Add message wrongpassword as html on Special:ChangeEmail (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104797 (owner: 10Umherirrender) [17:37:08] (03CR) 10Umherirrender: Add message wrongpassword as html on Special:ChangeEmail (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104797 (owner: 10Umherirrender) [17:41:37] (03CR) 10EBernhardson: [C: 032] prevent fatal when passing null to getInnerHtml [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104791 (owner: 10EBernhardson) [17:41:49] (03Merged) 10jenkins-bot: prevent fatal when passing null to getInnerHtml [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104791 (owner: 10EBernhardson) [17:42:03] (03CR) 10EBernhardson: [C: 032] Update constructor arguments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104792 (owner: 10EBernhardson) [17:42:46] (03Merged) 10jenkins-bot: Update constructor arguments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104792 (owner: 10EBernhardson) [17:44:07] (03CR) 10Parent5446: Refactor ProfilerSimple (033 comments) [core] - 10https://gerrit.wikimedia.org/r/104780 (owner: 10Ori.livneh) [17:44:22] (03CR) 10IAlex: Fix bad usage of empty() function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104810 (owner: 10IAlex) [17:46:05] (03CR) 10Parent5446: [C: 031] Moved HashRing to /libs [core] - 10https://gerrit.wikimedia.org/r/104778 (owner: 10Aaron Schulz) [18:05:06] (03CR) 10Parent5446: Fix bad usage of empty() function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104810 (owner: 10IAlex) [18:10:45] (03CR) 10Parent5446: [C: 031] Add message wrongpassword as html on Special:ChangeEmail (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104797 (owner: 10Umherirrender) [18:24:10] (03CR) 10Brian Wolff: [C: 04-1] "Thankyou for the patch. 2 things" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/104794 (owner: 10AalekhN) [18:27:55] (03CR) 10Nikerabbit: "Wouldn't it be better to not reuse messages and create new messages which do not accept html?" [core] - 10https://gerrit.wikimedia.org/r/104797 (owner: 10Umherirrender) [18:34:30] (03PS1) 10Ebe123: Require Module: to be prefixed [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/104814 [18:34:42] (03CR) 10Nikerabbit: Fix bad usage of empty() function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104810 (owner: 10IAlex) [18:43:55] (03CR) 10Umherirrender: "New messages will make local customization more difficult because the local sysop will not find all messages with the same meaning, but di" [core] - 10https://gerrit.wikimedia.org/r/104797 (owner: 10Umherirrender) [18:52:50] (03PS1) 10Umherirrender: No variable assignment on return statement [core] - 10https://gerrit.wikimedia.org/r/104815 [18:54:35] (03CR) 10jenkins-bot: [V: 04-1] No variable assignment on return statement [core] - 10https://gerrit.wikimedia.org/r/104815 (owner: 10Umherirrender) [18:57:28] (03PS2) 10Umherirrender: No variable assignment on return statement [core] - 10https://gerrit.wikimedia.org/r/104815 [18:58:11] (03CR) 10Umherirrender: "Patch Set 2: Fixed missing semicolon" [core] - 10https://gerrit.wikimedia.org/r/104815 (owner: 10Umherirrender) [19:01:30] I'm having trouble with vagrant, I can't update the virtual machine additions [19:01:31] (03CR) 10jenkins-bot: [V: 04-1] No variable assignment on return statement [core] - 10https://gerrit.wikimedia.org/r/104815 (owner: 10Umherirrender) [19:02:59] I can't use the "update-guest-additions" command, and it doesn't recognize the additions cd [19:03:22] And there's no colourful banner :( [19:07:45] (03PS1) 10EBernhardson: Repair missed conversion to new username lookup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104816 [19:08:49] (03CR) 10Umherirrender: "recheck" [core] - 10https://gerrit.wikimedia.org/r/104815 (owner: 10Umherirrender) [19:09:25] techman224: sounds like provisioning didnt run, any errors from `vagrant provision` [19:09:59] ebernhardson, I didn't run it, just "vagrant up" as in the instructions [19:10:15] techman224: provision would have run on its own, i mean run it now and see what errors it outputs :) [19:13:21] ebernhardson, something about shared folders is missing, also my guest additions are out of date [19:13:31] techman224: could you pastie the output? [19:13:33] It's preventing puppet from running [19:14:26] ebernhardson, http://etherpad.wikimedia.org/p/8r8ihQ7GpX [19:15:41] hmm [19:17:17] is the machine up? i suppose the easiest way might be to just paste a copy of the update-guest-additions script and run i [19:17:43] not sure what the proper solution is, but can probably get it running at least [19:18:01] update-guest-additions: command not found [19:18:19] heres the script from my mw vagrant instance: http://etherpad.wikimedia.org/p/INGLW4jCQk [19:19:04] and it looks like needs an `echo 4.2.10 > /etc/virtualbox-version` [19:19:09] replace 4.2.10 with your version [19:25:49] ebernhardson, the script has a --virtualbox-version argument [19:27:09] It's working [19:27:33] puppet is now running! [19:27:38] awsome [19:28:38] Someone should update virtual machine additions for the image [19:29:17] yeah, we should [19:29:48] i've resisted that because there's something to be said for using the images provided by canonical [19:30:11] guillom, http://www.google-melange.com/gci/task/view/google/gci2013/5804648166326272 [19:30:11] Add template data to two popular Wikipedia templates #18 [19:30:12] Status: ClaimRequested [19:30:12] Mentor(s): Guillaume Paumier [19:30:15] can you please assign [19:36:27] (03PS8) 10EBernhardson: Visualize profile output in debug toolbar [core] - 10https://gerrit.wikimedia.org/r/104318 [19:42:31] (03CR) 10Nullzero: "I can't figure out when rc_param changed its format. According to https://www.mediawiki.org/wiki/Manual:Logging_table#log_params, it's the" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104706 (owner: 10Nullzero) [19:57:58] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/Configure] - 10https://gerrit.wikimedia.org/r/104834 (owner: 10L10n-bot) [19:59:48] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/104841 (owner: 10L10n-bot) [20:03:59] (03CR) 10Reedy: [C: 032] Localisation updates from https://translatewiki.net. [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/104841 (owner: 10L10n-bot) [20:04:17] (03CR) 10Reedy: [V: 032] Localisation updates from https://translatewiki.net. [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/104841 (owner: 10L10n-bot) [20:04:26] Silly thing [20:04:44] (03CR) 10Reedy: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [extensions/Configure] - 10https://gerrit.wikimedia.org/r/104834 (owner: 10L10n-bot) [20:23:52] (03CR) 10EBernhardson: [C: 032] Repair missed conversion to new username lookup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104816 (owner: 10EBernhardson) [21:19:32] (03PS1) 10Gomoko: Added custom label for links in category pages [core] - 10https://gerrit.wikimedia.org/r/104905 [21:27:57] (03Merged) 10jenkins-bot: Repair missed conversion to new username lookup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104816 (owner: 10EBernhardson) [21:53:25] (03CR) 10MZMcBride: "Thanks. :-)" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/104752 (owner: 10Eranroz) [22:04:02] (03CR) 10Bartosz Dziewoński: [C: 04-1] BookManagerv2: Invalidate navbar cache when JSON file changes (031 comment) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/104208 (owner: 10Geek400) [22:06:52] hey guys, how do I use https://www.mediawiki.org/wiki/Manual:CreateAndPromote.php ? [22:09:10] Joeytje50: do you know how maintenance scripts work in general? [22:09:11] !maintenance [22:09:12] https://www.mediawiki.org/wiki/Manual:Maintenance_scripts [22:09:27] I'll read that [22:09:37] I only just set up mediawiki on XAMPP [22:09:43] Joeytje50: basically, the gist of that is: [22:10:21] Joeytje50: basically, the gist of that is running a shell command, `php maintenance/createAndPromote.php` (or similar one for every other script) [22:10:29] (you must have shell access to do this) [22:10:42] I do [22:10:47] I'll try that [22:12:26] hello [22:12:28] After installing a current stable MW 1.22 (with PHP 5.3.18/MySQL 5.1.50 on a Unix) I get a warning at at the [22:12:29] "Generating secret keys..." stage: [22:12:31] "Warning: mcrypt_create_iv() [function.mcrypt-create-iv]: Cannot open source device in /htdocs/wiki/includes/MWCryptRand.php on line 313 [22:12:32] Secure keys ($wgSecretKey and $wgUpgradeKey) generated during installation are not completely safe. Consider changing them manually." [22:12:34] (some more lines of the same type error which I've omitted here to keep it short). [22:12:35] The MW installation completes succesfully, however, the same errors reappears while browsing the wiki at for example a Log in page. [22:12:37] By the way, line 313 in MWCryptRand.php is this: [22:12:38] $iv = mcrypt_create_iv( $rem, MCRYPT_DEV_URANDOM ); [22:12:40] The installer suggest I change $wgSecretKey and $wgUpgradeKey manually. Could this fix the probelm. If so, how is it done? [22:12:41] Thanks, [22:12:43] Tuxedo [22:15:00] (03CR) 10Parent5446: Fix bad usage of empty() function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104810 (owner: 10IAlex) [22:15:39] Tuxedo_: does your system have /dev/urandom and are you sure it's accessible to the PHP processes running MediaWiki? [22:15:56] no idea why it wouldn't be, but the error seems to suggest that, so let's try to obvious thing :) [22:16:15] it worked, thanks MatmaRex [22:16:29] Joeytje50: :) [22:25:13] MatmaRex: /dev/urandom is a symlink to 'random' which is a library on the FreeBSD system. At least 'man random' returns some old manual, but I'm not sure if the 'random' program is anywhere. I can't find it. [22:25:58] This didn't happen on much earlier MW installations I've successfully made on the exact same type of systems. [22:26:41] Tuxedo_: /dev/random and urandom are device files [22:26:45] !wp device file [22:26:45] https://en.wikipedia.org/?title=device+file [22:27:01] that's weird, though. no idea what might be causing that :( [22:27:25] Tuxedo_: if i were you, i'd mail the wikitech-l list or file a bug [22:27:26] hey guys I'm wondering, is it possible to make my test wiki automatically get a tag for the base directory? [22:27:27] !lists [22:27:27] mediawiki-l and wikitech-l are the primary mailing lists for MediaWiki-related issues. See https://www.mediawiki.org/wiki/Mailing_lists for details. [22:29:41] I would like something that would make links that are /index.php?title=FooBar to go to /currentpath/w/index.php?title=FooBar, but would I have to add the tag to the manually, or is there something else I can do? [22:30:26] MatmaRex: Thanks for the /dev/random insight. I will try another earlier MW version, or wait for the next. [22:38:14] (03CR) 10Amire80: "Hebrew is good." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/104795 (owner: 10Santhosh) [22:55:37] Nemo_bis, hi :) re http://gerrit.wikimedia.org/r/#/c/104707/ -- is there anything else that I need to do? Or just wait at this point? [22:55:58] (03PS1) 10M4tx: Add support for new MobileFrontend copyright warnings [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/104907 [22:56:23] Joeytje50: change wgScriptPath? [22:56:26] !wg ScriptPath | Joeytje50 [22:56:26] Joeytje50: https://www.mediawiki.org/wiki/Manual:%24wgScriptPath [22:57:07] ah okay, thanks [23:11:04] (03CR) 10Ori.livneh: Refactor ProfilerSimple (032 comments) [core] - 10https://gerrit.wikimedia.org/r/104780 (owner: 10Ori.livneh) [23:15:21] (03CR) 10Werdna: "In general I like this approach." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101903 (owner: 10Matthias Mullie) [23:20:52] (03PS2) 10Legoktm: Don't show skin names if the user can't enable them [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/102383 [23:21:01] (03CR) 10SPQRobin: [C: 032 V: 032] Require Module: to be prefixed [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/104814 (owner: 10Ebe123) [23:21:08] (03Merged) 10jenkins-bot: Require Module: to be prefixed [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/104814 (owner: 10Ebe123) [23:25:09] (03CR) 10Parent5446: Refactor ProfilerSimple (032 comments) [core] - 10https://gerrit.wikimedia.org/r/104780 (owner: 10Ori.livneh) [23:30:21] theopolisme: it may help to test your code [23:30:48] (in case you've not yet) [23:31:08] especially trying particularly evil injections in the message [23:32:47] Nemo_bis: Hmm, yeah. I'm afraid I'm not an expert on mail header injection (in fact, I'm so ignorant in that respect I didn't even know it was a thing until that code review!). I tried a few stock examples, but for more complex cases I don't really know what to do... [23:37:23] Hm. "Swift Mailer breaks any attempt at header injection by encoding the dangerous data into a non-dangerous form" http://swiftmailer.org/docs/headers.html [23:52:15] (03CR) 10Reedy: [C: 032] Make branch versions of *all* extensions on internal release [tools/release] - 10https://gerrit.wikimedia.org/r/104776 (owner: 10Aaron Schulz) [23:52:43] (03Merged) 10jenkins-bot: Make branch versions of *all* extensions on internal release [tools/release] - 10https://gerrit.wikimedia.org/r/104776 (owner: 10Aaron Schulz) [23:56:56] (03CR) 10Werdna: "Looking like a good start. A few comments." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103109 (owner: 10Matthias Mullie) [23:57:40] (03CR) 10Werdna: [C: 031] "Looks fine, but untested." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104496 (owner: 10Matthias Mullie)