[00:01:24] Aaron|home: There's resistance to removing the hit counters on the talk page. [00:01:38] I saw that [00:02:04] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to wmf8 tip [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/104685 (owner: 10MaxSem) [00:02:07] People clinging to bad stats. Sigh. [00:02:14] Reedy: if that gets merged that can remove the last live hack \o/ [00:02:41] Gloria, ever herd what comrade Stalin did to opposition? [00:02:43] though the timing for that config hook one might be tricky...maybe I should make some conditional in there to avoid notices [00:02:54] MaxSem: ?action=purge [00:02:57] Haha [00:03:01] well, if there was a replacement for it... [00:03:24] Extension:CrappyHitCounter? [00:03:26] it's there because it's better than nothing, and it probably still is better than nothing for some people [00:03:35] the best code is... [00:04:22] I know that in 2002 and 2003, seeing those hit counters rise on articles I had just created was a significant incentive to continue contributing [00:04:24] You could split it out to an extension, but it'd still need to be rewritten. The DB part, at least. [00:04:32] I wish we had something like that on wikipedia now [00:04:45] TimStarling: I think everyone wants proper stats. There's allegedly an analytics team. [00:04:52] What they do, I've no idea. [00:05:21] they just produce stats for internal consumption, afaict [00:05:32] internal to staff, that is [00:05:46] Stare at UDP streams and hope for more of Domas' Good Samaritanism. [00:05:51] Oh, your answer was better. [00:06:50] (03CR) 10AndyRussG: "Thanks, Siebrand, all set!" (033 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [00:06:51] Any wiki serious about analytics just installs Google Analytics. [00:07:02] There's a working extension, I'm told. [00:11:03] Gloria: but we don't want to rely on 3rd parties, right? [00:11:10] that's the reason recaptcha was not considered [00:11:29] "We" is ambiguous. :-) [00:11:48] Wikimedia can't use Google Analytics for many reasons. [00:12:02] But the vast majority of MediaWiki installations aren't for Wikimedia. [00:13:27] Gloria: oh I think I've been on third-party wikis that do [00:14:43] (03CR) 10Aaron Schulz: Maintenance script for benchmarking parse operations (038 comments) [core] - 10https://gerrit.wikimedia.org/r/102596 (owner: 10Tim Starling) [00:14:47] (03CR) 10Jdlrobson: "You rock Bartosz! So glad this is happening. :D" [core] - 10https://gerrit.wikimedia.org/r/89379 (owner: 10Bartosz Dziewoński) [00:14:54] (03PS3) 10Nuria: Reverting changes to python schema.Adding test. Removing whitespace again. Adding isset check for user agent for times in which this code is called outside a web context. Removing user agent from publisher before publishing event Change-Id: I0a95768fae7da [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/104509 [00:16:26] TimStarling: ^ a few comments there...assuming you haven't lost all hope in life [00:17:16] springle: ping [00:17:32] ebernhardson: pong [00:18:11] you know I just scp'd it up to tin and ran it there as soon as I wrote it, the project is pretty much done now [00:18:16] springle: good morning :) I'm trying to track down an issue related to a db query in production, is there anyway to collect an unredacted sql trace? Found the related querys in ishmael and everything looks correct, but the right answers arn't coming out [00:18:33] so getting it merged is mostly an intellectual exercise [00:18:49] you probably saw the boxplots I made from it [00:19:16] springle: hoping to find unredacted so i can run the actual queries and look at the output, rather than plugging in what i think is the data that should have been there [00:24:01] ebernhardson: yes, but it's a manual process. unredacted samples can be found in query_digests db on db1001. use ishamel's checksum= to get an unredacted sample from the relevant host's table [00:24:49] (03CR) 10Gergő Tisza: [C: 032] Replacing 'show on map' button with a link [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/101029 (owner: 10Inchikutty) [00:25:01] (03Merged) 10jenkins-bot: Replacing 'show on map' button with a link [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/101029 (owner: 10Inchikutty) [00:25:50] TimStarling, any chance you can review https://gerrit.wikimedia.org/r/#/c/99541/ ? I'm afraid there's not many people around who aren't afraid of wikidiff2:) [00:25:51] TimStarling: no, where are they? [00:26:25] Aaron|home: http://tstarling.com/stuff/featured-parse-boxplot.png [00:26:43] ah, nice [00:30:59] I think I'll write a blog post to present these Lua graphs properly, prior to my LCA talk [00:31:06] springle: one question, how do i connect to db1001? :) tried from tin but no luck [00:31:26] ah [00:32:47] MaxSem: actually the wikidiff2.(h|cpp) thing was the previous author, and he used a non-OOP style [00:32:58] I moved his functions into a class and introduced Word.h etc. [00:33:25] ebernhardson: which host and checksum are you after? i'll just dump a bunch of samples [00:33:32] yeah, so I renamed them to Wikidiff2.* for consistency [00:39:03] springle: actually i found it, turns out there are a bunch of hints in /usr/local/bin . Found what we were looking for, much appreciated. [00:39:31] ebernhardson: great :) [00:44:54] (03CR) 10Bartosz Dziewoński: "Yeah, I think completing this (which I'm not done with yet, feel free to help :D) will probably make several WMF teams very happy." [core] - 10https://gerrit.wikimedia.org/r/89379 (owner: 10Bartosz Dziewoński) [00:45:03] (03CR) 10Bartosz Dziewoński: "recheck" [core] - 10https://gerrit.wikimedia.org/r/89379 (owner: 10Bartosz Dziewoński) [00:46:52] is there something like 'recheck' that will also run unit tests and give +2 instead of +1? [00:46:59] bah, where's hashar when i need him. [00:56:16] (03CR) 10Spage: "Tests fail if BROWSER_LABEL not defined." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104511 (owner: 10Cmcmahon) [00:58:26] (03PS1) 10Jack Phoenix: Revert "Replace usage of SpecialPage::getTitle with getPageTitle" [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/104700 [00:58:42] (03CR) 10Jack Phoenix: [C: 032 V: 032] Revert "Replace usage of SpecialPage::getTitle with getPageTitle" [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/104700 (owner: 10Jack Phoenix) [01:01:33] (03CR) 10Jack Phoenix: "This change is otherwise OK, except to my knowledge 1.23 isn't anywhere near being released and 1.22 is the latest stable, so this should " [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/103914 (owner: 10Legoktm) [01:03:55] (03CR) 10Jack Phoenix: [C: 032 V: 032] Default to HTML5 player instead of Flash Player. [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/101672 (owner: 10Jack Phoenix) [01:05:30] (03PS1) 10Ori.livneh: Add stub HHVM role [vagrant] - 10https://gerrit.wikimedia.org/r/104701 [01:06:15] ebernhardson: ^ [01:06:30] ptarajan got the packages signed, i don't know if he updated the github issue you opened [01:07:14] (03CR) 10Bartosz Dziewoński: "(Note that the stack currently needs rebasing and conflict fixing :( )" [core] - 10https://gerrit.wikimedia.org/r/89379 (owner: 10Bartosz Dziewoński) [01:08:49] MatmaRex: i don't want your patches to fester, but i'm also not a particularly heavy user of watchlists, so it'd be good to have some folks chime in to confirm that the changes you implemented are the right idea [01:08:58] i am aware of the bugzilla bug it's not adequate IMO [01:09:17] maybe poke dan garry? he is growing into the role of a platform product person and this seems like a good task for him [01:09:28] and maybe mz for the loyal opposition [01:10:17] ori: i'm basically not changing any user-facing features for now [01:10:46] ori: i am changing some hooks in a possibly backwards-incompatible way, the only problem in that stack so far has been already resolved (in Wikibase) [01:11:26] what's the overall arc of the set of commits? just code cleanup, then? [01:11:42] (03CR) 10Tim Starling: [C: 032] Add new one-column diff mode [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/99541 (owner: 10MaxSem) [01:11:50] yes, basically the aim is to make watchlist and recentchanges reuse code [01:11:59] The idea is sound. [01:12:03] oh, ok [01:12:03] thanks TimStarling!:) [01:12:10] (03Merged) 10jenkins-bot: Add new one-column diff mode [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/99541 (owner: 10MaxSem) [01:12:15] np [01:12:19] I didn't think any user functionality was being affected. If I did, I would've investigated further. [01:12:29] I think it's just code refacdtoring. [01:12:34] With or without the D. [01:12:35] MatmaRex: is there a high-level summary of all patches somewhere? [01:12:39] i am in fact planning some cleanups and redesigns later (i have some broken rotting patches in gerrit), but that's for later [01:12:50] ori: no, but let me summarize [01:12:57] nice work [01:13:10] ori: there is now SpecialWatchlist, SpecialRecentChanges and SpecialRecentChangesLinked inheriting from SpecialRecentChanges [01:13:39] ori: after the stack is merged, there will be abstract class ChangesListSpecialPage, SpecialRecentChanges and SpecialWatchlist inheriting from that one, and SpecialRecentChangesLinked still inheriting from SpecialRecentChanges [01:13:58] ori: i haven't fully finished implementing (and designing, tbh) that base class yet [01:14:16] but the code works (it needs a rebase though) [01:14:43] OK, clearing up some accumulated detritus first sounds like the right idea [01:15:04] the latest patch is https://gerrit.wikimedia.org/r/#/c/103546/ , you might want to diff that with master instead of each patch separately [01:15:14] I'll review this week, hopefully sooner rather than later [01:15:32] there's ~10 todos left in ChangesListSpecialPage.php after it [01:15:40] (03PS2) 10Aaron Schulz: changed memcached server parsing to allow for local unix domain socket connections to local memcached (e.g. unix:///var/run/memcached/memcached.sock:0 ) noticeably increases memcached mediawiki performance [core] - 10https://gerrit.wikimedia.org/r/104663 (owner: 10Jqnatividad) [01:15:51] (03PS3) 10Aaron Schulz: changed memcached server parsing to allow for local unix domain socket connections to memcached [core] - 10https://gerrit.wikimedia.org/r/104663 (owner: 10Jqnatividad) [01:15:53] MatmaRex: -2? [01:16:04] Gloria: does not merge, yeah [01:16:06] Oh, -1 from jenkins-bot. [01:16:17] Red X means -2, except when it doesn't. [01:16:19] Thanks, Gerrit. [01:16:19] because SpecialPage#getTitle was renamed to #getPageTitle and CONFLICTS EVERYWHER [01:16:20] E [01:16:22] (03CR) 10Aaron Schulz: "Broke up long summary lines" [core] - 10https://gerrit.wikimedia.org/r/104663 (owner: 10Jqnatividad) [01:16:43] i'll need to do some search&replacing when i'm deathly bored sometime [01:16:55] GCI tasks. ;-) [01:17:00] heh [01:17:54] i could probably run some fancy git commands to undo the changes to "my" files first, reapply everything cleanly, then redo the original changes, but htat's boring as well [01:18:22] git pull --rebase, isn't it? [01:18:26] Who knows. [01:18:41] yeah, but CONFLICTS EVERYWHERE [01:18:59] i usually resort to file system tricks at that point [01:19:06] copy files over, etc. [01:19:21] i generally use meld ;) [01:19:36] it makes resolving comflicts almost pleasant [01:19:57] well, unless you have to do stupid mechanical works on five different commits, then it's still awful [01:20:00] of course there is always a helpful gremlin who points out that the last hour or so of work could have been obviated by some obscure git subcommand [01:20:02] work* [01:20:58] i wonder what using --ours (or is it --theirs?) would do in this case, and whether in fact rebase supports these options [01:21:11] but i haven't been bored enough yet to investigate that [01:21:31] bored on the internet = doing it wrong. [01:21:31] you can cherry-pick each change on top of head, no? [01:21:47] (I really should take that word out of my alert-list...) [01:21:51] quiddity: True. Though I often get stuck. [01:23:28] ori: that's still conflicts [01:23:39] ori: i am moving tons of code around and between files [01:24:01] which creates totally bullshit conflicts [01:24:30] i have yet to find some software to detect such things automatically and resolve the conflicts for me :) meld helps a lot, but it can't do this [01:26:19] the ;east painful way will probably be to, on each conflicted commit, run search&replace on ours and base files (same as the one that was applied to master), then rerun the merge [01:26:23] but BORIIING [01:31:31] (03CR) 10Aaron Schulz: [C: 04-1] changed memcached server parsing to allow for local unix domain socket connections to memcached (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104663 (owner: 10Jqnatividad) [01:33:23] (03CR) 10Bartosz Dziewoński: Add Special:Diff as an internally-linkable redirect to diff pages (032 comments) [core] - 10https://gerrit.wikimedia.org/r/63395 (owner: 10Jérémie Roquet) [01:42:27] (03PS1) 10Bsitu: Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 [01:43:38] (03CR) 10Bsitu: [C: 04-2] Post appearance tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu) [02:14:22] (03CR) 10Parent5446: Maintenance script for benchmarking parse operations (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102596 (owner: 10Tim Starling) [02:17:36] (03CR) 10Qgil: "Hi Matt, considering that Geek40 is a Google Code-in student, could you please explain the reasons of you -1?" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/104208 (owner: 10Geek400) [02:33:33] (03PS1) 10Shirayuki: i18n: capitalize "GWToolset" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/104705 [02:49:19] (03PS2) 10Shirayuki: i18n: consistency tweaks [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/104705 [02:50:07] (03CR) 10Tim Starling: Maintenance script for benchmarking parse operations (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102596 (owner: 10Tim Starling) [02:54:00] (03CR) 10Swalling: "In this case, I think both changes are undesirable." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103640 (owner: 10Shirayuki) [02:58:11] (03CR) 10Aaron Schulz: Maintenance script for benchmarking parse operations (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102596 (owner: 10Tim Starling) [03:05:05] (03CR) 10MZMcBride: "A full revert doesn't seem appropriate. We can see that {{SITENAME}} and such are used instead of "Wikipedia". Obviously there's the capab" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103640 (owner: 10Shirayuki) [03:06:19] (03CR) 10Swalling: "You're right about the quote changes for sure." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103640 (owner: 10Shirayuki) [03:25:46] (03CR) 10Ori.livneh: [C: 032] Add stub HHVM role [vagrant] - 10https://gerrit.wikimedia.org/r/104701 (owner: 10Ori.livneh) [03:25:58] ^ ^d [03:27:12] <^d> Sweet [03:36:09] (03CR) 10Vishnunk90: "This patch was updated as per the advice." [core] - 10https://gerrit.wikimedia.org/r/104203 (owner: 10Vishnunk90) [03:37:42] (03PS1) 10Nullzero: make MOVED_TO* working [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104706 [03:56:53] (03CR) 10Hoo man: [C: 04-1] make MOVED_TO* working (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104706 (owner: 10Nullzero) [04:27:39] (03CR) 10Nullzero: "I agree that we should use defined function rather than replicating logic. However, there is a problem. While newFromRow() uses getRawPara" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104706 (owner: 10Nullzero) [04:43:09] (03CR) 10Nullzero: "OK. I just found that actually your method will be perfectly working if $row is an array. Therefore, we have two ways. The first way is to" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104706 (owner: 10Nullzero) [05:21:56] (03PS3) 10Parent5446: default entry point for extension [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/104508 (owner: 10Hashar) [05:22:00] (03CR) 10jenkins-bot: [V: 04-1] default entry point for extension [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/104508 (owner: 10Hashar) [05:23:28] hello yurik online? [05:25:29] (03CR) 10Parent5446: "Any idea why this is failing? It seems to not be creating the database tables, but I definitely add them to the ExtensionSchemaUpdate hook" [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/104508 (owner: 10Hashar) [05:28:26] (03PS3) 10Tim Starling: Make MagicWordArray compatible with PCRE 8.34+ [core] - 10https://gerrit.wikimedia.org/r/103215 (owner: 10PleaseStand) [05:28:32] (03CR) 10Tim Starling: [C: 032] Make MagicWordArray compatible with PCRE 8.34+ [core] - 10https://gerrit.wikimedia.org/r/103215 (owner: 10PleaseStand) [05:32:11] (03Merged) 10jenkins-bot: Make MagicWordArray compatible with PCRE 8.34+ [core] - 10https://gerrit.wikimedia.org/r/103215 (owner: 10PleaseStand) [06:09:16] siebrand: my review queue is now like 3 pages long :P [06:21:29] (03PS1) 10Theopolisme: Replace $wgPasswordSenderName with a system message [core] - 10https://gerrit.wikimedia.org/r/104707 [06:26:29] If I write a code in a file B and list another file A as a dependency, that would be equivalent to writing the same code in file A, right? [06:26:37] (03CR) 10Legoktm: Maintenance script to salt existing unsalted passwords (034 comments) [core] - 10https://gerrit.wikimedia.org/r/104487 (owner: 10Legoktm) [06:27:07] (03PS2) 10Legoktm: Maintenance script to salt existing unsalted passwords [core] - 10https://gerrit.wikimedia.org/r/104487 [06:30:49] (03CR) 10Legoktm: [C: 04-1] "Needs rebase :/" [extensions/Configure] - 10https://gerrit.wikimedia.org/r/104393 (owner: 10Siebrand) [06:31:21] (03CR) 10Legoktm: [C: 032 V: 032] Replace deprecated SpecialPage::getLang() [extensions/Video] - 10https://gerrit.wikimedia.org/r/104394 (owner: 10Siebrand) [06:31:37] marktraceur: you there? [06:36:38] (03CR) 10Legoktm: [C: 031] "Would be really nice if this didn't have to use $wgTitle and the other globals..." [extensions/ShoutWikiAds] - 10https://gerrit.wikimedia.org/r/104380 (owner: 10Siebrand) [06:37:32] (03CR) 10Legoktm: [C: 032 V: 032] Replace deprecated SpecialPage::resolveAlias() [extensions/URNames] - 10https://gerrit.wikimedia.org/r/104379 (owner: 10Siebrand) [06:41:12] (03Abandoned) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/ExpandTemplates] - 10https://gerrit.wikimedia.org/r/103932 (owner: 10Legoktm) [06:45:10] Niharika: what? [06:45:57] Um, in the Resource Loader, if I list a file as a dependency, does that mean itś equivalent to writing the code in that file? [06:47:03] thepolisme:^ [06:48:21] theopolisme: Sorry. I might not be making much sense. In the Resource Loader, if I list a file as a dependency, does that mean itś equivalent to writing the code in that file? [06:48:37] (03CR) 10Legoktm: [C: 032] Replace usage of deprecated Title::escapeLocalURL() [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/104372 (owner: 10Siebrand) [06:48:40] (03Merged) 10jenkins-bot: Replace usage of deprecated Title::escapeLocalURL() [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/104372 (owner: 10Siebrand) [06:49:05] Niharika: no. it means the code in the dependency will be run before the main code is run [06:49:21] File A has a dependency on file B, this means that file B will run before file A [06:49:43] (03CR) 10Legoktm: [C: 032 V: 032] Replace usage of deprecated Title::escapeLocalURL() [extensions/UploadLocal] - 10https://gerrit.wikimedia.org/r/104371 (owner: 10Siebrand) [06:50:23] theopolisme: Does that also mean that I can access all the variables, functions from that file? [06:50:39] Depends on if the file makes those variables available [06:50:44] (03PS1) 10Nullzero: LogEntry: Make newFromRow works with object [core] - 10https://gerrit.wikimedia.org/r/104708 [06:51:12] Okay. How do I make the variables available for use by files dependent on it? [06:51:17] What exactly are you working on, Niharika? [06:51:22] The ULS. [06:51:25] A part of it. [06:51:43] My code works file in ext.uls.init, which is the main file. [06:52:00] But I needed to do my work in a new separate file. [06:52:15] theopolisme: So, I made the ext.uls.init as a dependency. [06:52:24] But some things don´t work now. [06:52:40] Which were dependent on some parts on the ext.uls.init. [06:54:11] I'm not really familiar with the ULS code, sorry.. [06:54:31] theopolisme: Okay, no problem. Thanks for the help. :) [06:55:11] Sure! Sorry I couldn't be of more assistance. If there's a bug report on bugzilla, I would definitely ask there :) [06:55:43] Niharika ^ [06:55:45] No, no, itś not a bug. I´m working on a feature. [06:57:36] Hmm, okay. Then in that case I would wait until working hours in the states tomorrow and then ask in here again [06:57:47] You may have some more luck then [06:59:59] (03CR) 10Nullzero: "This *patch* will fix the problem by converting..." [core] - 10https://gerrit.wikimedia.org/r/104708 (owner: 10Nullzero) [07:03:56] (03PS1) 10Legoktm: Add @since tag to SpecialPage::getPageTitle [core] - 10https://gerrit.wikimedia.org/r/104709 [07:05:04] (03CR) 10Legoktm: "@Nemo: I looked through https://www.mediawiki.org/wiki/Manual:Special_pages and didn't see anything that needed updating." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103587 (owner: 10Legoktm) [07:05:06] theopolisme: Yeah, good idea. [07:08:57] (03PS1) 10Ori.livneh: Add RunningStat class, tests [core] - 10https://gerrit.wikimedia.org/r/104710 [07:09:48] (03PS2) 10Ori.livneh: Add RunningStat class, tests [core] - 10https://gerrit.wikimedia.org/r/104710 [07:24:47] (03PS3) 10Ori.livneh: Add RunningStat class, tests [core] - 10https://gerrit.wikimedia.org/r/104710 [07:25:00] (03CR) 10Parent5446: Maintenance script to salt existing unsalted passwords (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104487 (owner: 10Legoktm) [07:42:43] (03CR) 10Parent5446: Add RunningStat class, tests (0312 comments) [core] - 10https://gerrit.wikimedia.org/r/104710 (owner: 10Ori.livneh) [07:42:56] (03CR) 10Parent5446: [C: 032] Add @since tag to SpecialPage::getPageTitle [core] - 10https://gerrit.wikimedia.org/r/104709 (owner: 10Legoktm) [07:45:59] (03Merged) 10jenkins-bot: Add @since tag to SpecialPage::getPageTitle [core] - 10https://gerrit.wikimedia.org/r/104709 (owner: 10Legoktm) [07:46:03] wikidiff2 improvements, nice [07:46:25] (03PS2) 10Parent5446: LogEntry: Make newFromRow works with object [core] - 10https://gerrit.wikimedia.org/r/104708 (owner: 10Nullzero) [07:47:00] (03CR) 10Parent5446: [C: 031] LogEntry: Make newFromRow works with RC object [core] - 10https://gerrit.wikimedia.org/r/104708 (owner: 10Nullzero) [07:49:37] * Nemo_bis eagerly waits for Tim-away's blog post [07:52:12] (03CR) 10Nemo bis: "Just submit a followup patch... The contractions were not mentioned in the commit message, so they're clearly not considered important by " [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103640 (owner: 10Shirayuki) [07:54:00] (03CR) 10Nemo bis: "Thanks Lego." [core] - 10https://gerrit.wikimedia.org/r/103587 (owner: 10Legoktm) [07:57:07] (03PS1) 10Legoktm: Give links to a user's suppressed edits on Special:Contribs [core] - 10https://gerrit.wikimedia.org/r/104711 [07:58:15] (03CR) 10jenkins-bot: [V: 04-1] Give links to a user's suppressed edits on Special:Contribs [core] - 10https://gerrit.wikimedia.org/r/104711 (owner: 10Legoktm) [07:58:46] sigh... [07:59:52] (03PS2) 10Legoktm: Give links to a user's suppressed edits on Special:Contribs [core] - 10https://gerrit.wikimedia.org/r/104711 [08:03:12] (03CR) 10Nemo bis: [C: 04-1] "Thanks! Hm, you sure about ->parse()?" [core] - 10https://gerrit.wikimedia.org/r/104707 (owner: 10Theopolisme) [08:11:28] (03CR) 10Theopolisme: "Oh, whoops! I always forget about that..." [core] - 10https://gerrit.wikimedia.org/r/104707 (owner: 10Theopolisme) [08:11:50] (03PS2) 10Theopolisme: Replace $wgPasswordSenderName with a system message [core] - 10https://gerrit.wikimedia.org/r/104707 [08:12:19] Nemo_bis: I always forget about that, I guess that's a problem with bouncing between extensions and core :) [08:15:26] (03PS1) 10Ori.livneh: Specify version for git-review package resource [vagrant] - 10https://gerrit.wikimedia.org/r/104712 [08:16:08] legoktm: can you review? [08:16:32] sure, let me test [08:17:18] sweet, thanks [08:17:54] theopolisme: it's also rather mysterious why we even need maintenance/language/messages.inc... if you look at its first revision, it's clearly false [08:19:48] woo notice: /Stage[main]/Git/Package[git-review]/ensure: ensure changed '1.12' to '1.23' [08:19:54] ori: want me to +2? [08:20:09] that'd be cool, thanks again [08:20:23] also, !#$!@#! puppet [08:20:35] (03CR) 10Legoktm: [C: 032] "Works great :D" [vagrant] - 10https://gerrit.wikimedia.org/r/104712 (owner: 10Ori.livneh) [08:20:37] (03Merged) 10jenkins-bot: Specify version for git-review package resource [vagrant] - 10https://gerrit.wikimedia.org/r/104712 (owner: 10Ori.livneh) [08:20:52] i don't know if what you ran into is the same as http://projects.puppetlabs.com/issues/15644 [08:21:55] theopolisme: Sorry, yes [08:21:59] ensure => latest with pip requires a call to the pypi api, which is bad even when it works [08:22:13] marktraceur: Just letting you know I was working on the jquery.fullscreen deal [08:22:14] because it'll fail if you try to run puppet when you don't have an internet connection [08:22:40] so it was probably the right change for that reason, too [08:26:46] Oh, fantastic [08:26:52] theopolisme: Let me know if you need help [08:27:09] I'll be asleep for the next 7 hours or so, but I'll pick it up when I awake [08:31:33] marktraceur: that's a good idea, I should go to sleep too :/ [08:36:51] While using git review, I see multiple commits. I did git fetch --all and git remote update but, still shows the same result. How to push only the HEAD ? [08:40:53] (03CR) 10Legoktm: (bug 18598) Maintenance script to migrate legacy Oversight data (035 comments) [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/18229 (owner: 10Alex Monk) [08:41:08] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104711 (owner: 10Legoktm) [08:43:08] tonythomas01: Are you currently working on a branch that has two commits that are not merged into master? [08:43:44] If the commits are both unmerged, it's totally cool to push more than one commit for review [08:43:54] Unless they're both meant to be the same commit [08:43:54] marktraceur: actually, the commit (HEAD) is my work and the other is some else commit [08:44:04] tonythomas01: Someone else's unmerged commit? [08:45:02] marktraceur: yeah. Looks like it. [08:45:14] tonythomas01: Does your change make sense without their change? [08:45:28] it shows 258ac9a Added streamFile() unit test [08:45:41] as an outstanding commit [08:45:52] along with my commit on top of it as HEAD [08:46:05] tonythomas01: Are you depending on changes made in the unit test change? [08:46:21] Like, adding another unit test in the same file, or changing the unit test they created? [08:47:01] marktraceur: Actually, how can I explore what all changes that commit is making ? My commit was to Remove version check for mysql 4.1 from Maintenance scripts [08:47:23] tonythomas01: git diff HEAD^ [08:48:59] marktraceur: git diff HEAD^ shows my diff alright [08:50:08] tonythomas01: If your change is independent, do git rebase -i origin/master [08:50:18] Then delete the line that refers to the other commit [08:50:20] marktraceur: it looks independant [08:50:28] Then save the file and quit the editor [08:50:37] Hopefully it'll be easy as that, then do git review again [08:51:26] (03CR) 10Siebrand: [C: 04-1] "Please have a look at https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs-strict-HEAD/5790/console for coding style related issu" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104710 (owner: 10Ori.livneh) [08:51:43] (03PS1) 1001tonythomas: Remove version check for mysql 4.1 from Maintenance scripts [core] - 10https://gerrit.wikimedia.org/r/104713 [08:51:46] Woooo [08:52:11] marktraceur: Thanks! That helped :) [08:52:19] Glad I could be marginally useful [08:52:36] Now, I should go sleep [08:52:55] marktraceur: good night [08:57:16] (03PS3) 10Siebrand: Replace deprecated SpecialPage::getLang() [extensions/Configure] - 10https://gerrit.wikimedia.org/r/104393 [08:57:28] guillom, around? [08:58:34] (03CR) 10Siebrand: "@lego: This code has aged. Needs a good look-over." [extensions/ShoutWikiAds] - 10https://gerrit.wikimedia.org/r/104380 (owner: 10Siebrand) [09:01:05] guillom, http://www.google-melange.com/gci/task/view/google/gci2013/5857766174359552 [09:01:06] Add template data to two popular Wikipedia templates #14 [09:01:06] Status: NeedsReview (2 days, 10 hours left) [09:01:06] Mentor(s): Guillaume Paumier, Quim Gil [09:07:45] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/104707 (owner: 10Theopolisme) [09:10:32] (03CR) 10Siebrand: [C: 032] wfRunHooks() return value no longer implies whether variable value was found. Bug: 12837 [core] - 10https://gerrit.wikimedia.org/r/104203 (owner: 10Vishnunk90) [09:10:53] (03PS4) 10Siebrand: wfRunHooks() return value no longer implies whether variable value was found. Bug: 12837 [core] - 10https://gerrit.wikimedia.org/r/104203 (owner: 10Vishnunk90) [09:11:03] (03CR) 10Siebrand: [C: 032] wfRunHooks() return value no longer implies whether variable value was found [core] - 10https://gerrit.wikimedia.org/r/104203 (owner: 10Vishnunk90) [09:13:20] (03CR) 10Siebrand: [C: 04-1] Remove version check for mysql 4.1 from Maintenance scripts (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104713 (owner: 1001tonythomas) [09:15:07] (03CR) 10Siebrand: [C: 032] i18n: consistency tweaks [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/104705 (owner: 10Shirayuki) [09:15:12] (03Merged) 10jenkins-bot: i18n: consistency tweaks [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/104705 (owner: 10Shirayuki) [09:16:42] (03Merged) 10jenkins-bot: wfRunHooks() return value no longer implies whether variable value was found [core] - 10https://gerrit.wikimedia.org/r/104203 (owner: 10Vishnunk90) [09:17:07] (03CR) 10Siebrand: [C: 04-1] Post appearance tweaks (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104703 (owner: 10Bsitu) [09:23:16] (03CR) 10Siebrand: Add Special:Diff as an internally-linkable redirect to diff pages (032 comments) [core] - 10https://gerrit.wikimedia.org/r/63395 (owner: 10Jérémie Roquet) [09:23:46] (03CR) 10PleaseStand: [C: 04-1] "What Siebrand said about parse() is correct. Full wikitext parsing (for things such as wikilinks) is not necessary here. Message::text() i" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104707 (owner: 10Theopolisme) [09:24:07] (03PS2) 1001tonythomas: Remove version check for mysql 4.1 from Maintenance scripts [core] - 10https://gerrit.wikimedia.org/r/104713 [09:31:02] (03PS1) 10TheDJ: Remove trailing commas [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104717 [09:31:42] (03CR) 10Siebrand: Replace $wgPasswordSenderName with a system message (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104707 (owner: 10Theopolisme) [09:32:02] (03CR) 10TheDJ: "Submitted comma fixes upstream:" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104510 (owner: 10TheDJ) [09:33:29] (03CR) 10Siebrand: [C: 031] Remove trailing commas [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104717 (owner: 10TheDJ) [09:35:10] (03CR) 10Siebrand: [C: 04-1] "The linter is checking these files. They should be ignored by adding them or folder(s) to .jshintignore." [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104510 (owner: 10TheDJ) [09:37:20] (03CR) 10Siebrand: [C: 032] "Let start with merging this... Per Ori." [core] - 10https://gerrit.wikimedia.org/r/89379 (owner: 10Bartosz Dziewoński) [09:37:35] (03PS11) 10Siebrand: Rename Watchlist request parameters for consistency with RC's ones [core] - 10https://gerrit.wikimedia.org/r/89380 (owner: 10Bartosz Dziewoński) [09:38:33] (03CR) 10jenkins-bot: [V: 04-1] Rename Watchlist request parameters for consistency with RC's ones [core] - 10https://gerrit.wikimedia.org/r/89380 (owner: 10Bartosz Dziewoński) [09:39:38] (03CR) 10Siebrand: Rename Watchlist request parameters for consistency with RC's ones (031 comment) [core] - 10https://gerrit.wikimedia.org/r/89380 (owner: 10Bartosz Dziewoński) [09:41:09] (03Merged) 10jenkins-bot: Make SpecialWatchlist extend SpecialRecentChanges (temporarily) [core] - 10https://gerrit.wikimedia.org/r/89379 (owner: 10Bartosz Dziewoński) [09:45:25] (03PS12) 10Siebrand: Rename Watchlist request parameters for consistency with RC's ones [core] - 10https://gerrit.wikimedia.org/r/89380 (owner: 10Bartosz Dziewoński) [09:46:20] (03CR) 10Bartosz Dziewoński: Rename Watchlist request parameters for consistency with RC's ones (031 comment) [core] - 10https://gerrit.wikimedia.org/r/89380 (owner: 10Bartosz Dziewoński) [09:53:52] (03PS1) 10Siebrand: Update RELEASE-NOTES [core] - 10https://gerrit.wikimedia.org/r/104718 [09:57:00] (03PS2) 10TheDJ: CodeEditor: Update to package 12.02.2013 (December 2013) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104510 [10:00:22] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [10:01:11] MatmaRex: I fixed the merge conflict for the next patch in the chain, but it looks like no one took a look at that yet. Also added ori as reviewer, as he approved the first one. [10:01:50] MatmaRex: To prevent more merge conflicts on RELEASE-NOTES, please +2 https://gerrit.wikimedia.org/r/104718 if you're okay with that change. [10:01:53] siebrand: i chatted about this briefly with matmarex and indicated i'd be reviewing the entire series sometime this week [10:01:57] (03CR) 10Bartosz Dziewoński: Update RELEASE-NOTES (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104718 (owner: 10Siebrand) [10:02:02] ori: Awesome. [10:02:08] feel free to merge if they look good to you though [10:02:27] siebrand: release notes are not a problem, the actual code is [10:02:57] SpecialPage#getTitle was remaed to #getPageTitle and searhc&replaced throughout core [10:03:05] including in code i moved around… [10:03:34] (03CR) 10Siebrand: Update RELEASE-NOTES (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104718 (owner: 10Siebrand) [10:04:00] MatmaRex: patch chains are a bitch. [10:04:06] MatmaRex: Our project is just too active :) [10:04:38] i'll rebase the whole stack some time [10:04:42] MatmaRex: What do you want me to do about release notes formatting? [10:04:53] hopefully before someone wants to merge it ;) [10:05:00] siebrand: why the blank line? [10:05:31] (you could just merge it, no idea how many people use my driver, probably not a lot, and i can just fix the code) [10:06:02] MatmaRex: I explained that in a reply: The "

" have newlines after heading. Should they be removed there? [10:06:03] It looked inconsistent to me, so I made it consistent. I can also make it consistent the other way around... [10:06:33] (or just not change it_ [10:07:02] (03PS4) 10Ori.livneh: Add RunningStat class, tests [core] - 10https://gerrit.wikimedia.org/r/104710 [10:07:17] dunno [10:07:33] sorry, i'm off for now, see you next year ;) [10:07:44] (or maybe later today, actually) [10:07:48] I've removed the lines. [10:07:57] (03PS2) 10Siebrand: Update RELEASE-NOTES [core] - 10https://gerrit.wikimedia.org/r/104718 [10:07:59] thanks [10:09:38] (03PS5) 10Ori.livneh: Add RunningStat class, tests [core] - 10https://gerrit.wikimedia.org/r/104710 [10:19:58] (03PS3) 10TheDJ: CodeEditor: Update to package 12.02.2013 (December 2013) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104510 [10:21:45] (03PS1) 10TheDJ: ContentModel: Use CM to choose CE language [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104721 [10:24:55] (03PS4) 10TheDJ: CodeEditor: Update to package 12.02.2013 (December 2013) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104510 [10:36:32] MatmaRex, hi [10:39:55] (03PS1) 10TheDJ: Remove extrenious border in CodeEditor [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104722 [10:49:13] (03PS3) 10Nikerabbit: LogEntry: Make newFromRow works with RC object [core] - 10https://gerrit.wikimedia.org/r/104708 (owner: 10Nullzero) [10:56:40] (03PS5) 10TheDJ: CodeEditor: Update to package 12.02.2013 (December 2013) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104510 [10:58:22] (03CR) 10Nikerabbit: Move non-API release notes out of the API section (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104684 (owner: 10Anomie) [10:58:32] (03CR) 10Matthias Mullie: [C: 032] No longer load blocks to format [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102972 (owner: 10EBernhardson) [10:58:39] (03Merged) 10jenkins-bot: No longer load blocks to format [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102972 (owner: 10EBernhardson) [11:00:31] (03CR) 10Matthias Mullie: [C: 032] Convert UUID length 'magic' numbers to named constants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102584 (owner: 10EBernhardson) [11:00:42] (03Merged) 10jenkins-bot: Convert UUID length 'magic' numbers to named constants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102584 (owner: 10EBernhardson) [11:41:46] (03CR) 10Ori.livneh: Add RunningStat class, tests (0311 comments) [core] - 10https://gerrit.wikimedia.org/r/104710 (owner: 10Ori.livneh) [11:43:41] (03PS5) 10Matthias Mullie: No-js css tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103763 (owner: 10EBernhardson) [11:45:44] (03CR) 10Matthias Mullie: [C: 031] "I've made a couple of changes:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103763 (owner: 10EBernhardson) [11:48:23] (03PS3) 10Siebrand: Update RELEASE-NOTES [core] - 10https://gerrit.wikimedia.org/r/104718 [11:48:36] (03CR) 10Siebrand: Move non-API release notes out of the API section (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104684 (owner: 10Anomie) [11:53:32] (03CR) 10Matthias Mullie: [C: 032] Special characters are being mis-encoded in links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103569 (owner: 10EBernhardson) [11:53:38] (03Merged) 10jenkins-bot: Special characters are being mis-encoded in links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103569 (owner: 10EBernhardson) [11:54:55] (03PS6) 10Hashar: Jenkins job validation (DO NOT SUBMIT).. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/70205 [11:55:19] (03CR) 10Nemo bis: "While we're at it, can you also make either all or no headers be followed by an empty line?" [core] - 10https://gerrit.wikimedia.org/r/104718 (owner: 10Siebrand) [11:55:20] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT).. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/70205 (owner: 10Hashar) [11:58:04] (03CR) 10Siebrand: "@neno: No, because that will slow down getting this merged. If you feel strongly about it, please submit a new patch set that will do that" [core] - 10https://gerrit.wikimedia.org/r/104718 (owner: 10Siebrand) [11:59:10] (03PS1) 10Siebrand: Fix some JSHint issues [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104728 [12:03:31] (03PS1) 10Siebrand: Update formatting of JavaScript files [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104729 [12:05:11] (03PS1) 10Hashar: .gitreview file [integration/kss] - 10https://gerrit.wikimedia.org/r/104730 [12:05:29] (03CR) 10Hashar: [C: 032 V: 032] .gitreview file [integration/kss] - 10https://gerrit.wikimedia.org/r/104730 (owner: 10Hashar) [12:11:27] (03CR) 10Hashar: "I like the idea, can you please bring the subject on the wikitech-l mailing list to attract more reviewers ?" [core] - 10https://gerrit.wikimedia.org/r/99162 (owner: 10Kambiz Darabi) [12:12:00] (03PS3) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97728 [12:12:41] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97728 (owner: 10Hashar) [12:14:09] (03CR) 10Hashar: [C: 04-1] assertValidHtml for checking html in test cases. [core] - 10https://gerrit.wikimedia.org/r/98853 (owner: 10Daniel Kinzler) [12:17:43] (03Abandoned) 10Hashar: runJobs: option to prevent logging starts [core] - 10https://gerrit.wikimedia.org/r/102332 (owner: 10Hashar) [12:19:45] (03CR) 10Hashar: "The hook is registered but only act for mysql backend when Jenkins is using sqlite as a database backend. Amending switch to add sqlite a" [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/104508 (owner: 10Hashar) [12:19:58] guillom, ping me when you are around [12:21:03] (03PS4) 10Hashar: default entry point for extension + sqlite db update [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/104508 [12:21:28] (03CR) 10jenkins-bot: [V: 04-1] default entry point for extension + sqlite db update [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/104508 (owner: 10Hashar) [12:24:01] (03PS1) 10Siebrand: Combine var statements [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104734 [12:25:01] (03CR) 10Hashar: [C: 04-1] "The mysql database updater is compatible with sqlite. There is a few tests failing now that needs to be fixed up, one is asserting a boole" [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/104508 (owner: 10Hashar) [12:29:55] (03CR) 10Hashar: [C: 04-1] "Would you mind adding in a test for that behavior? If you don't feel comfortable doing it, I will add the test class / test case." [core] - 10https://gerrit.wikimedia.org/r/104058 (owner: 10Siebrand) [12:32:22] (03CR) 10Siebrand: "I'll give it a try. Will probably be able to do this for the exception, but don't think I can manage to do it for the valid input cases." [core] - 10https://gerrit.wikimedia.org/r/104058 (owner: 10Siebrand) [12:49:14] Hey, I am working on the bug https://bugzilla.wikimedia.org/show_bug.cgi?id=41085 , could someone please tell me where the changes are to be made? The component is API, so where should the changes be made? Can someone please help me with it? [12:51:29] (03PS1) 10UltrasonicNXT: Force all links to open in new tab [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/104735 [12:52:51] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Force all links to open in new tab [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/104735 (owner: 10UltrasonicNXT) [12:54:25] (03CR) 10Hoo man: "Very good idea, btw... could also be helpful with Capiunto (I want it ...)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98853 (owner: 10Daniel Kinzler) [13:02:02] (03PS1) 10UltrasonicNXT: Reduce comment cache time [extensions/Comments] - 10https://gerrit.wikimedia.org/r/104736 [13:03:08] (03CR) 10UltrasonicNXT: "It's probably not worth a config variable, but I could add one if you like... :)" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/104736 (owner: 10UltrasonicNXT) [13:03:30] (03PS5) 10Siebrand: Throw exception for unknown field in SpecialListfiles::formatValue() [core] - 10https://gerrit.wikimedia.org/r/104058 [13:04:15] (03PS6) 10Siebrand: Throw exception for unknown field in SpecialListfiles::formatValue() [core] - 10https://gerrit.wikimedia.org/r/104058 [13:04:28] hashar: See https://gerrit.wikimedia.org/r/#/c/104058/6/tests/phpunit/includes/specials/SpecialListFilesTest.php [13:11:15] (03CR) 10Matthias Mullie: [C: 04-1] Simplify edit-title template (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103069 (owner: 10EBernhardson) [13:12:22] (03CR) 10Matthias Mullie: Simplify edit-title template (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103069 (owner: 10EBernhardson) [13:19:26] (03PS7) 10Hashar: Throw exception for unknown field in SpecialListfiles::formatValue() [core] - 10https://gerrit.wikimedia.org/r/104058 (owner: 10Siebrand) [13:20:50] (03CR) 10Hashar: [C: 031] "Following a conversation on IRC, I cleaned up the test to only care about extensions being thrown. That is good enough for now." [core] - 10https://gerrit.wikimedia.org/r/104058 (owner: 10Siebrand) [13:28:19] (03CR) 10TheDJ: [C: 032] Fix some JSHint issues [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104728 (owner: 10Siebrand) [13:28:58] (03Merged) 10jenkins-bot: Fix some JSHint issues [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104728 (owner: 10Siebrand) [13:29:14] (03CR) 10Matthias Mullie: [C: 032] Reuse code from MWException [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103627 (owner: 10Bsitu) [13:29:50] (03Merged) 10jenkins-bot: Reuse code from MWException [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103627 (owner: 10Bsitu) [13:30:28] (03CR) 10Matthias Mullie: [C: 031] Load usernames directly from wiki's in batches [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 (owner: 10EBernhardson) [13:39:03] (03CR) 10Matthias Mullie: [C: 032] (bug 58140) Multiple moderated topics in a row takes up too much space [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103357 (owner: 10Matthias Mullie) [13:39:47] (03Merged) 10jenkins-bot: (bug 58140) Multiple moderated topics in a row takes up too much space [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103357 (owner: 10Matthias Mullie) [13:40:34] (03CR) 10Matthias Mullie: [C: 031] "Still good!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [13:40:54] (03CR) 10Umherirrender: "A UserCache class also exists, which can save db queries for some properties." [core] - 10https://gerrit.wikimedia.org/r/100371 (owner: 10Matthias Mullie) [13:48:02] (03CR) 10Hashar: "I understood it is meant to dynamically load the extensions saving one the need to tweak their php.ini settings. But I disagree, I don't " [core] - 10https://gerrit.wikimedia.org/r/97329 (owner: 10Platonides) [13:51:10] (03CR) 10TheDJ: [C: 032] Update formatting of JavaScript files [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104729 (owner: 10Siebrand) [13:51:55] (03Merged) 10jenkins-bot: Update formatting of JavaScript files [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104729 (owner: 10Siebrand) [13:56:22] (03CR) 10TheDJ: [C: 04-1] Combine var statements (031 comment) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104734 (owner: 10Siebrand) [14:03:18] (03PS6) 10TheDJ: CodeEditor: Update to package 12.02.2013 (December 2013) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104510 [14:07:31] (03CR) 10Matthias Mullie: [C: 031] "When merging, first rebase & make sure to do another search for getHex() to make sure no new code with ->getHex() has slipped in." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 (owner: 10EBernhardson) [14:09:49] (03CR) 10Jack Phoenix: [C: 032 V: 032] "Looks sane and I agree that there's no need to add Yet Another Config Global for this relatively minor thing." [extensions/Comments] - 10https://gerrit.wikimedia.org/r/104736 (owner: 10UltrasonicNXT) [14:19:42] (03PS2) 10TheDJ: Remove extraneous border in CodeEditor [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104722 [14:25:15] (03CR) 10Matthias Mullie: [C: 04-1] "Some (I think) rebase errors in FlowActions, but looks fine otherwise." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102491 (owner: 10EBernhardson) [14:39:55] guillom: are you here ? [14:42:18] ls [14:43:15] (03PS7) 10TheDJ: CodeEditor: Update to package 12.02.2013 (December 2013) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104510 [14:46:56] (03PS3) 10Geek400: BookManagerv2: Invalidate navbar cache when JSON file changes [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/104208 [14:49:20] VladAndrew: problems? [14:50:27] Nemo_bis: I have a few tasks to complete [14:51:15] Nemo_bis: They are translated but it require to be accepted by the mentor [14:51:32] Also, happy new year [14:52:01] same to you :) still a few hours here [14:52:57] Nemo_bis: here too, it's 17:52 here [14:53:01] well your tasks will be marked done in due time, my suggestion is always to keep working on the next page(s) without worrying [14:53:19] ah ok :) [14:53:59] (03PS3) 10Manybubbles: Organize code in CirrusSearch namespace [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104665 (owner: 10Chad) [14:54:03] Nemo_bis: I'll work on another page [14:54:59] (03CR) 10Manybubbles: [C: 032] "Merging my own patch set because it just finishes off Chad's and passes all regression tests." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104665 (owner: 10Chad) [14:55:42] (03Merged) 10jenkins-bot: Organize code in CirrusSearch namespace [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104665 (owner: 10Chad) [14:57:07] dan-nl: hello :) [14:57:22] dan-nl: I have merged in your change of filebackend for gwtoolset on beta cluster, will self deploy soon [14:57:37] hey hashar thanks that will definitely help :) [14:58:07] then i can test again ;) [14:58:24] dan-nl: and I merged earlier the whiltelisting of *.raa.se (or something similiar) [14:58:28] even deployed it on production [14:58:33] Nemo_bis: one question, do you suggest any specific page to work on ? [14:58:35] hashar: there was also a problem with the new production deploy to Commons [14:58:45] hashar: \o/ [14:59:35] hashar: there was also an issue with the i18n files … https://gerrit.wikimedia.org/r/#/c/104741 [15:00:01] hashar: i thought you were on holiday for two weeks ... [15:00:17] dan-nl: just last week [15:00:25] came back yesterday evening, off tomorrow though [15:00:28] so this week is part time :-D [15:00:34] :) [15:02:06] hashar: do you know if there is an "official" place that documents the configuration setup for beta and production? something that would clue a developer as to how to set things up? [15:02:38] dan-nl: we suck at documentation, see bug 1 [15:02:55] :) [15:03:03] dan-nl: you can possibly add comments in the source code of operations/mediawiki-config.git [15:03:13] k, i'll see if i can sort something out in the next few weeks [15:03:29] i like the idea of having wiki pages for it [15:03:30] or if you feel brave, open a page on wikitech-l that would describe the architecture of GWToolset on wikimedia production and beta [15:03:39] err wikitech-l -> wikitech.wikimedia.org [15:03:57] i'll post something to mediawiki.org [15:04:05] i have an idea of where to place it ... [15:04:46] (03CR) 10Manybubbles: "This code review is going to require a lot of reading. I'll get to it, I promise. Just not immediately." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104675 (owner: 10Chad) [15:05:40] was thinking of placing something linked with this page http://www.mediawiki.org/wiki/Writing_an_extension_for_deployment [15:08:50] VladAndrew: https://www.mediawiki.org/wiki/Help:System_message would be rather nice [15:09:28] and https://www.mediawiki.org/wiki/Help:Mass_account_creation is easy enough [15:12:41] VladAndrew: otherwise, if you prefer something important and big, https://www.mediawiki.org/wiki/Help:Magic_words or https://www.mediawiki.org/wiki/Download [15:12:58] dan-nl: as long as it can be found easily, go for it :-] [15:13:08] dan-nl: at worth, someone will edit / move pages [15:13:16] hashar: btw, i happened to also see that AaronSchulz changed the configuration for the gwtoolset jobs … it looks like the config change took care of the background job issue [15:13:35] i'm watching a test atm and so far it looks good [15:15:18] he removed the $wgJobTypesExcludedFromDefaultQueue[] entries and so now it looks like the runJobsLoopService picks up the delayed gwtoolsetUploadMetadataJob [15:19:46] hashar job test finished and everything got picked up, so it looks like the original config he gave me with the $wgJobTypesExcludedFromDefaultQueue[] entries is what prevented the job runner from picking up the delayed jobs [15:20:52] ahhh [15:21:11] dan-nl: yeah most job runners are proceeding any jobs that around [15:21:21] but we want some jobs to run on dedicated box [15:21:34] such as for image scaling or video transcoding [15:21:55] so those images/video jobs are added in wgJobTypesExcludedFromDefaultQueue to make sure job runners don't run them unless they are able to [15:23:06] ah, so then those excluded jobs aren't picked up unless server resources are available? [15:25:12] I think so [15:25:22] that was done for TimeMediaHandler extension [15:25:22] VladAndrew: {{anchor|Creating new messages}} needs no translation, the image needs own line and the links should just use special:mylanguage [15:26:57] Nemo_bis: ok, let me change that [15:28:23] hashar: hmm … seems like he did something a bit different … don't understand why it works now, but he actually placed them in wgJobTypesExcludedFromDefaultQueue, but outside of the gwtoolset test … https://gerrit.wikimedia.org/r/#/c/103524/1 [15:29:25] in any case, i let david know and see if his test on production works ... [15:29:51] but we'll have to wait for that extension-list config change … production no longer has i18n for gwoolset [15:32:31] doh [15:32:40] I am about to leave so can't really fix that up right now [15:32:58] but if it is not fixed on thursday, I can merge / refresh them [15:36:23] hashar, thanks. i already have a patch for it, https://gerrit.wikimedia.org/r/#/c/104741/ … hoping Reedy will pick it up today if he's deploying to Commons … [15:40:41] (03CR) 10Jack Phoenix: "The change itself is probably just fine (didn't test it) -- not intuitive, but when have MW's APIs been that?" [extensions/ShoutWikiAds] - 10https://gerrit.wikimedia.org/r/104380 (owner: 10Siebrand) [15:48:19] dan-nl: you will have to ping him here :) [15:48:37] i am out of there, see you next year :] [15:48:56] k, will see if i'm able to … we're going out for dinner … maybe in between dinner and fireworks i can catch him :) [15:49:09] take care and thanks for all your help! [15:50:49] dan-nl: unlikely anything will get deployed today since most of us are partying tonight and will be unavailable tomorrow [15:50:50] so maybe thursday [15:51:05] :) [15:52:21] (03CR) 10Siebrand: Replace deprecated SpecialPage::resolveAlias() (032 comments) [extensions/ShoutWikiAds] - 10https://gerrit.wikimedia.org/r/104380 (owner: 10Siebrand) [15:53:00] and off *wave* [16:02:36] (03CR) 10Yaron Koren: [C: 032 V: 031] added $edgSuppressNoLocalVarMsg flag; added MongoDB memcached support; removed deprecated MongoDB slaveOkay flag; refactored collection exis [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/104472 (owner: 10Jqnatividad) [16:03:02] (03CR) 10Yaron Koren: [V: 032] added $edgSuppressNoLocalVarMsg flag; added MongoDB memcached support; removed deprecated MongoDB slaveOkay flag; refactored collection exis [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/104472 (owner: 10Jqnatividad) [16:10:07] (03PS1) 10Yaron Koren: A few fixes and reverts for the last change [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/104744 [16:11:32] (03CR) 10Yaron Koren: [C: 032 V: 032] A few fixes and reverts for the last change [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/104744 (owner: 10Yaron Koren) [16:14:47] (03CR) 10Anomie: [C: 04-1] "Code looks good, haven't tested. Commit summary and release notes should refer to API action=feedcontributions rather than Special:Contrib" [core] - 10https://gerrit.wikimedia.org/r/104551 (owner: 10Umherirrender) [16:19:42] (03PS1) 10Manybubbles: Leak less memory in forceSearchIndex.php [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104745 [16:22:41] (03PS1) 10Manybubbles: Fix another missing use statement [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104746 [16:28:00] (03PS1) 10Tim Landscheidt: Add job for labs/toollabs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104747 [16:28:27] (03PS1) 10Tim Landscheidt: Add job for labs/toollabs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/104748 [16:29:55] (03CR) 10Tim Landscheidt: "And https://gerrit.wikimedia.org/r/104748 for the other part." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104747 (owner: 10Tim Landscheidt) [16:32:26] (03CR) 10Tim Landscheidt: "https://gerrit.wikimedia.org/r/#/c/104747/ for the Zuul config." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/104748 (owner: 10Tim Landscheidt) [16:43:03] (03CR) 10Chad: [C: 032] Fix another missing use statement [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104746 (owner: 10Manybubbles) [16:43:47] (03Merged) 10jenkins-bot: Fix another missing use statement [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104746 (owner: 10Manybubbles) [16:45:46] (03PS2) 10Umherirrender: action=feedcontributions no longer has one item more than limit [core] - 10https://gerrit.wikimedia.org/r/104551 [16:49:00] (03CR) 10Umherirrender: "Patch Set 2: Rebased and changed Release Notes only (Should be okay in one commit)" [core] - 10https://gerrit.wikimedia.org/r/104551 (owner: 10Umherirrender) [17:03:56] anyone rememember me? [17:04:08] hi whatsup [17:04:09] hi whatsup [17:04:09] hi whatsuphi whatsup [17:04:10] hi whatsup [17:04:10] v [17:04:11] hi whatsup [17:04:11] hi whatsup [17:04:11] hi whatsup [17:04:12] hi whatsup [17:04:12] hi whatsuphi whatsup [17:04:12] hi whatsup [17:04:13] hi whatsup [17:04:14] hi whatsup [17:04:14] hi whatsup [17:04:14] hi whatsup [17:04:17] hi whatsuphi whatsuphi whatsuphi whatsuphi whatsuphi whatsuphi whatsuphi whatsuphi whatsuphi whatsuphi whatsuphi whatsuphi whatsuphi whatsuphi whatsuphi whatsuphi whatsuphi whatsup [17:04:19] hi whatsup [17:04:20] hi whatsup [17:04:20] hi whatsup [17:04:21] hi whatsuphi whatsup [17:04:21] hi whatsup [17:04:21] hi whatsuphi whatsuphi whatsuphi whatsuphi whatsup [17:04:22] hi whatsup [17:04:23] hi whatsup [17:04:25] hi whatsuphi whatsup [17:04:26] hi whatsup [17:04:27] hi whatsupvvhi whatsuphi whatsup [17:04:28] hi whatsuphi whatsuphi whatsup [17:04:28] hi whatsup [17:04:28] hi whatsupvhi whatsup [17:04:34] hi whatsuphi whatsup [17:04:50] I LOVE PIEEEEEEEEEEEE! [17:04:50] I LOVE PIEEEEEEEEEEEE! [17:04:52] I LOVE PIEEEEEEEEEEEE!I LOVE PIEEEEEEEEEEEE! [17:04:52] I LOVE PIEEEEEEEEEEEE! [17:04:53] I LOVE PIEEEEEEEEEEEE! [17:04:53] V [17:04:55] I LOVE PIEEEEEEEEEEEE! [17:04:55] <^d> Pie sucks. [17:04:55] I LOVE PIEEEEEEEEEEEE! [17:04:55] I LOVE PIEEEEEEEEEEEE! [17:04:56] I LOVE PIEEEEEEEEEEEE! [17:04:56] I LOVE PIEEEEEEEEEEEE! [17:04:56] I LOVE PIEEEEEEEEEEEE! [17:04:57] I LOVE PIEEEEEEEEEEEE! [17:04:58] I LOVE PIEEEEEEEEEEEE! [17:05:01] I LOVE PIEEEEEEEEEEEE!I LOVE PIEEEEEEEEEEEE!I LOVE PIEEEEEEEEEEEE!I LOVE PIEEEEEEEEEEEE! [17:05:01] <^d> RoanKattouw_away. [17:05:02] SDF [17:05:03] SD [17:05:03] dehunter_: Hi. Nice exercise. Typing. [17:05:03] F [17:05:03] SDF [17:05:03] SD [17:05:03] FSD [17:05:03] FSD [17:05:04] F [17:05:16] SDF [17:05:16] SDF [17:05:21] SURE WHY NOT SDFSDF [17:05:21] SD [17:05:21] FS [17:05:21] DF [17:05:21] SD [17:05:22] !ops [17:05:22] There is no such key, you probably want to try: !anonnotice, !oversight, !svnprops, !opsschool, [17:05:22] FSD [17:05:23] F [17:05:23] SD [17:05:24] SD [17:05:24] F [17:05:25] SDF [17:05:26] SD [17:05:26] SD [17:05:26] F [17:05:26] SDF [17:05:27] SD [17:05:29] DS [17:05:30] FFS [17:05:33] F [17:05:33] SGSDF [17:05:35] GG [17:05:37] SDFG [17:05:43] SDFG [17:05:43] DFSG [17:05:43] SDFG [17:05:45] SDFG [17:05:45] SDF [17:05:45] GSDF [17:05:46] G [17:05:46] SDFG [17:05:46] G [17:05:47] DG [17:05:47] D [17:05:47] DF [17:05:48] SDFG [17:05:48] HEY IM FLOODING HERE I WANNA GET BANNED!!! HELLO!!! [17:05:50] DFG [17:05:50] FGDGDF [17:05:50] G [17:05:51] DG [17:06:15] H [17:06:17] DGF [17:06:20] A [17:06:21] S [17:06:22] S [17:06:23] H [17:06:26] O [17:06:28] L [17:06:32] E [17:06:35] A [17:06:36] S [17:06:36] S [17:06:38] H [17:06:39] O [17:06:39] L [17:06:40] E [17:06:43] <^d> Or Reedy [17:06:51] I've poked freenode [17:06:52] <^d> Too bad we have almost no @'s here. [17:07:01] <^d> I've bothered to get it for myself, but nobody's done it [17:12:37] Are such pranksters a common thing in here? [17:13:00] why was he flooding the channel? [17:13:08] Who knows [17:13:19] mayankmadan: Some people just want to watch the world burn [17:13:58] marktraceur: Haha. :D [17:17:48] Niharika: I think we used to get a lot more vandalism like that, but this is first I've seen in a long time [17:21:40] I'm sure it's an educational effort, remembering the world about /IGNORE [17:23:53] <^d> Nemo_bis: Yeah, but we should also have enough ops idling here at a given time to kick the idiots out :) [17:23:57] <^d> Which we don't. [17:32:03] (03CR) 10Chad: [C: 032] Leak less memory in forceSearchIndex.php [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104745 (owner: 10Manybubbles) [17:32:47] (03Merged) 10jenkins-bot: Leak less memory in forceSearchIndex.php [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104745 (owner: 10Manybubbles) [17:45:03] (03PS2) 10Siebrand: Combine var statements [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104734 [17:45:21] (03CR) 10Siebrand: Combine var statements (031 comment) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104734 (owner: 10Siebrand) [17:48:51] siebrand, you there? [17:49:15] theopolisme: Is it maybe something we could help with? [17:49:20] theopolisme: Only for easy question... Just had a good dinner :) [17:51:13] siebrand, heh :) well, I was just going to depreciate rather than outright remove the $wgPasswordSenderName global; would the proper process just be to do essentially `$wgPasswordSenderName || wfMessage...` in the places where it is used (of course declaring the global beforehand)? [17:52:09] Or does PHP require I do something weird? ;) [17:56:51] (03PS1) 10Umherirrender: Add Title::hasFragment and use it [core] - 10https://gerrit.wikimedia.org/r/104750 [18:14:05] (03CR) 10Theopolisme: "Thanks to both of you for clarifying that! Somehow I missed it in reading the documentation. I won't make that mistake again." [core] - 10https://gerrit.wikimedia.org/r/104707 (owner: 10Theopolisme) [18:14:26] (03PS3) 10Theopolisme: Deprecate $wgPasswordSenderName [core] - 10https://gerrit.wikimedia.org/r/104707 [18:19:34] (03PS1) 10Jqnatividad: Corrected regex to handle unix domain socket and IPV4 formats. IPV6 is not supported for now. [core] - 10https://gerrit.wikimedia.org/r/104751 [18:22:35] (03PS1) 10Eranroz: Revert 164a6469b6d95c447869a1a427a66150b76a2c58 [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/104752 [18:25:14] theopolisme: You can just replace (i.e. not use it any more), but for other places where it's used, it would be problematic if you would actually remove it. Hence, deprecate, not remoce. [18:25:16] remove [18:25:19] I'm afk agin. [18:25:51] siebrand: hmm, okay. so I don't need to check for it in core anymore? siebrand [18:28:13] (03PS1) 10Umherirrender: Change Title::getInterwiki() in conditions to Title::isExternal() [core] - 10https://gerrit.wikimedia.org/r/104753 [18:29:45] (03CR) 10Jqnatividad: "Sorry about the separate patch. Still figuring out Gerrit." [core] - 10https://gerrit.wikimedia.org/r/104663 (owner: 10Jqnatividad) [18:30:08] (03PS4) 10Theopolisme: Deprecate $wgPasswordSenderName [core] - 10https://gerrit.wikimedia.org/r/104707 [18:31:00] theopolisme: Nope. [18:31:37] Please consider me unavailable from now until next year (CET) [18:32:20] (03PS1) 10UltrasonicNXT: Delete all but the 50 newest messages [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/104754 [18:34:35] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Delete all but the 50 newest messages [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/104754 (owner: 10UltrasonicNXT) [18:43:46] Happy New Year! :D [18:46:14] (03CR) 10MZMcBride: "Siebrand: I agree with you re: upstreaming. However, I disagree that such an objection is worth a -1. (Unless the -1 was for the trailing " [core] - 10https://gerrit.wikimedia.org/r/104650 (owner: 10EBernhardson) [18:46:18] (03CR) 10Parent5446: Add RunningStat class, tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104710 (owner: 10Ori.livneh) [18:47:27] (03CR) 10MarkTraceur: [C: 032] Change id to add mwe-upwiz prefix and match casing style [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/95594 (owner: 10Mattflaschen) [18:47:43] (03Merged) 10jenkins-bot: Change id to add mwe-upwiz prefix and match casing style [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/95594 (owner: 10Mattflaschen) [18:48:39] (03CR) 10Parent5446: "Aha! Thanks for the fix. I'll investigate the failures." [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/104508 (owner: 10Hashar) [18:50:19] (03CR) 10Parent5446: [C: 031] Remove version check for mysql 4.1 from Maintenance scripts [core] - 10https://gerrit.wikimedia.org/r/104713 (owner: 1001tonythomas) [18:50:39] (03PS1) 10UltrasonicNXT: Fix some users appearing twice in the user list [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/104756 [18:53:05] (03CR) 10Parent5446: Throw exception for unknown field in SpecialListfiles::formatValue() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104058 (owner: 10Siebrand) [18:53:17] (03PS2) 10UltrasonicNXT: Fix some users appearing twice in the user list [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/104756 [18:53:55] (03PS3) 10UltrasonicNXT: Fix some users appearing twice in the user list [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/104756 [18:54:23] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Fix some users appearing twice in the user list [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/104756 (owner: 10UltrasonicNXT) [18:54:47] (03PS2) 10MarkTraceur: Focus to Flickr URL input field after "upload from Flickr" is clicked [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103323 (owner: 10Gergő Tisza) [18:55:14] (03CR) 10MarkTraceur: [C: 032] "Not tested, but the worst thing that can happen is focusing on the wrong thing, which is at least no worse than now." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103323 (owner: 10Gergő Tisza) [18:55:45] (03Merged) 10jenkins-bot: Focus to Flickr URL input field after "upload from Flickr" is clicked [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103323 (owner: 10Gergő Tisza) [18:56:50] (03CR) 10Chad: [C: 032] Revert 164a6469b6d95c447869a1a427a66150b76a2c58 [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/104752 (owner: 10Eranroz) [18:56:57] (03CR) 10jenkins-bot: [V: 04-1] Revert 164a6469b6d95c447869a1a427a66150b76a2c58 [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/104752 (owner: 10Eranroz) [18:58:16] (03PS3) 10MarkTraceur: Allow category prefix when entering categories [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103345 (owner: 10Theopolisme) [18:58:40] (03CR) 10MarkTraceur: [C: 032] "Sure! Thanks so much Theo, you're doing great work here." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103345 (owner: 10Theopolisme) [18:58:51] (03Merged) 10jenkins-bot: Allow category prefix when entering categories [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103345 (owner: 10Theopolisme) [18:59:02] marktraceur: :) [18:59:33] So, re jquery.fullscreen ... I was looking at the comments in the code about UI redraw/rendering issues [18:59:38] theopolisme: Honestly if you're game to stick around I think we could get you +2 on UW and MMV [18:59:48] (03CR) 10Chad: [V: 032] Revert 164a6469b6d95c447869a1a427a66150b76a2c58 [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/104752 (owner: 10Eranroz) [19:00:04] theopolisme: Yeah, there have been sort-of-phantom issues with resizing for a while now [19:00:08] It's not super clear why [19:00:14] I suspect it has something to do with double-requests [19:01:09] I'll definitely be sticking around -- working on mediawiki/related extensions has been one of the most satisfying experiences I've ever had :) [19:01:30] So are the rendering quirks a non-issue as far as fullscreening goes, though? [19:01:43] Or should something be figured out before readding the feature? [19:02:06] marktraceur ^ [19:03:10] theopolisme: Adding the feature *as a test* should be OK [19:03:24] Fixing up the rendering issues is something I can deal with if you'd prefer, but if you think you see the cause that would be awesome [19:04:09] Well, I'm going to be on some long plane flights so I may tackle it [19:09:43] (03CR) 10TheDJ: [C: 032] Combine var statements [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104734 (owner: 10Siebrand) [19:09:57] (03Merged) 10jenkins-bot: Combine var statements [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104734 (owner: 10Siebrand) [19:12:36] (03PS4) 10Aaron Schulz: changed memcached server parsing to allow for local unix domain socket connections [core] - 10https://gerrit.wikimedia.org/r/104663 (owner: 10Jqnatividad) [19:12:55] (03Abandoned) 10Aaron Schulz: Corrected regex to handle unix domain socket and IPV4 formats. IPV6 is not supported for now. [core] - 10https://gerrit.wikimedia.org/r/104751 (owner: 10Jqnatividad) [19:13:56] (03PS1) 10Bsitu: Post content with more than 5 lines is showing a scrollbar [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104758 [19:13:58] (03CR) 10Aaron Schulz: "I changed the summary and squashed to two commits back to one. Is this fine? I'll merge if so." [core] - 10https://gerrit.wikimedia.org/r/104663 (owner: 10Jqnatividad) [19:15:06] (03CR) 10EBernhardson: [C: 032] No-js css tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103763 (owner: 10EBernhardson) [19:15:51] (03Merged) 10jenkins-bot: No-js css tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103763 (owner: 10EBernhardson) [19:16:06] (03CR) 10Aaron Schulz: "When you modify a commit (after using git-review -d you should commit it with "git commit -a --amend" instead of "git commit -a -m (03CR) 10Aaron Schulz: [C: 032] Remove version check for mysql 4.1 from Maintenance scripts [core] - 10https://gerrit.wikimedia.org/r/104713 (owner: 1001tonythomas) [19:17:17] (03Abandoned) 10EBernhardson: Use UUID::BIN_LEN & HEX_LEN in getComparisonUUID [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102441 (owner: 10Matthias Mullie) [19:17:19] (03CR) 10MarkTraceur: [C: 04-1] "The phpunit coder in me screams "assert.elementExists", but I don't think we do that in qunit as much." (035 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103624 (owner: 10Aarcos) [19:17:25] (03CR) 10EBernhardson: "same changes already commited" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102441 (owner: 10Matthias Mullie) [19:18:01] (03PS1) 10Reedy: Add Arabic namespace names [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/104759 [19:20:39] (03Merged) 10jenkins-bot: Remove version check for mysql 4.1 from Maintenance scripts [core] - 10https://gerrit.wikimedia.org/r/104713 (owner: 1001tonythomas) [19:21:24] (03PS13) 10Bsitu: Load usernames directly from wiki's in batches [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 (owner: 10EBernhardson) [19:21:48] (03CR) 10jenkins-bot: [V: 04-1] Load usernames directly from wiki's in batches [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 (owner: 10EBernhardson) [19:22:11] (03CR) 10EBernhardson: [C: 032] Fetch moderation status from last revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102203 (owner: 10Matthias Mullie) [19:22:48] (03Merged) 10jenkins-bot: Fetch moderation status from last revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102203 (owner: 10Matthias Mullie) [19:24:09] (03PS14) 10Bsitu: Load usernames directly from wiki's in batches [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 (owner: 10EBernhardson) [19:25:34] (03CR) 10Bsitu: [C: 031] "rebased" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 (owner: 10EBernhardson) [19:33:07] (03PS6) 10Ori.livneh: Add RunningStat class, tests [core] - 10https://gerrit.wikimedia.org/r/104710 [19:33:20] ^ does that look ok? :P [19:33:26] that was @AaronSchulz [19:36:02] * AaronSchulz looks [19:37:58] (03CR) 10PleaseStand: [C: 04-1] "This introduces an email header injection vulnerability." [core] - 10https://gerrit.wikimedia.org/r/104707 (owner: 10Theopolisme) [19:46:25] (03PS7) 10Parent5446: Add RunningStat class, tests [core] - 10https://gerrit.wikimedia.org/r/104710 (owner: 10Ori.livneh) [19:46:47] (03CR) 10Parent5446: "PS7: Minor doc fix." [core] - 10https://gerrit.wikimedia.org/r/104710 (owner: 10Ori.livneh) [19:47:25] * ori <3s Parent5446 [19:48:13] Who doesn't man [19:50:35] (03PS1) 1001tonythomas: Reworded visibility status of "Notes" section to 'publicly viewable' [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104761 [19:56:13] (03CR) 10Parent5446: [C: 032] Add RunningStat class, tests [core] - 10https://gerrit.wikimedia.org/r/104710 (owner: 10Ori.livneh) [19:59:35] (03Merged) 10jenkins-bot: Add RunningStat class, tests [core] - 10https://gerrit.wikimedia.org/r/104710 (owner: 10Ori.livneh) [20:11:51] ori: I was ready to +2 when I saw it was merged already [20:12:07] (03CR) 10Nemo bis: "PleaseStand, isn't there some function for address validation?" [core] - 10https://gerrit.wikimedia.org/r/104707 (owner: 10Theopolisme) [20:29:45] (03CR) 10Gergő Tisza: licenseInput: Handle redirects for license templates (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50755 (owner: 10Nischayn22) [20:34:04] (03CR) 10MZMcBride: "Why?" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/104752 (owner: 10Eranroz) [20:34:26] (03CR) 10MZMcBride: "Apparently (partially?) reverted by ." [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/102522 (owner: 10L10n-bot) [20:36:27] (03PS1) 10Anomie: API: Add prop=redirects and list=allredirects [core] - 10https://gerrit.wikimedia.org/r/104764 [20:37:05] AaronSchulz: cool, thanks [20:37:35] (03CR) 10Anomie: "Sample queries generated by the new prop=redirects module:" [core] - 10https://gerrit.wikimedia.org/r/104764 (owner: 10Anomie) [20:42:09] (03CR) 10Anomie: [C: 032] action=feedcontributions no longer has one item more than limit [core] - 10https://gerrit.wikimedia.org/r/104551 (owner: 10Umherirrender) [20:45:33] (03Merged) 10jenkins-bot: action=feedcontributions no longer has one item more than limit [core] - 10https://gerrit.wikimedia.org/r/104551 (owner: 10Umherirrender) [20:53:26] (03CR) 10Theopolisme: "From what I can see I think adding a sanitizeHeaderValue() function in UserMailer that strips newlines/etc would be sufficient." [core] - 10https://gerrit.wikimedia.org/r/104707 (owner: 10Theopolisme) [21:01:17] (03PS1) 10Chad: Add hooks to allow other extensions to extend our schema [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104766 [21:03:17] (03PS1) 10Reza: i18n: Native digits on '#renderingProgress' [extensions/Collection] - 10https://gerrit.wikimedia.org/r/104767 [21:09:26] (03PS2) 10Reza: i18n: Native digits on '#renderingProgress' [extensions/Collection] - 10https://gerrit.wikimedia.org/r/104767 [21:30:56] (03PS5) 10Parent5446: default entry point for extension + sqlite db update [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/104508 (owner: 10Hashar) [21:31:18] (03CR) 10jenkins-bot: [V: 04-1] default entry point for extension + sqlite db update [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/104508 (owner: 10Hashar) [21:43:18] (03CR) 10Eranroz: "MZMcBride:" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/104752 (owner: 10Eranroz) [21:55:39] (03PS11) 10Parent5446: Update Special:ChangePassword to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/80411 (owner: 10IAlex) [21:55:50] (03CR) 10Parent5446: "PS11: Code style fixes." [core] - 10https://gerrit.wikimedia.org/r/80411 (owner: 10IAlex) [22:02:01] (03CR) 10Parent5446: [C: 032] "Tested and good to go." [core] - 10https://gerrit.wikimedia.org/r/80411 (owner: 10IAlex) [22:05:36] :q [22:05:44] (03Merged) 10jenkins-bot: Update Special:ChangePassword to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/80411 (owner: 10IAlex) [22:15:28] (03PS1) 10Manybubbles: Shrink the LinksUpdateJob a bit [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104773 [22:20:16] (03PS1) 10Chad: Automatically create new search index [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/104774 [22:23:59] (03CR) 10Manybubbles: [C: 031] "We'll still have to do the two pass index once the pages are imported, I believe." [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/104774 (owner: 10Chad) [22:25:10] Hi Nemo_bis [22:25:48] Nemo_bis: around? [22:26:17] mayankmadan: yes [22:26:24] Great [22:26:52] Nemo_bis: http://www.google-melange.com/gci/task/view/google/gci2013/5898948669603840 [22:26:53] Add support for more types of Flickr URLs to UploadWizard [22:26:53] Status: Open [22:26:53] Mentor(s): Quim Gil [22:27:03] This is your task, isnt it? [22:27:05] nice one [22:27:13] No [22:27:14] No [22:27:29] well, not really "mine" [22:27:41] fighting with flickr API? :< [22:28:05] Nemo_bis: i was talking about http://www.google-melange.com/gci/task/view/google/gci2013/5854794258317312 [22:28:08] UploadWizard: Missing messages and [22:28:08] Status: Open [22:28:08] Mentor(s): Quim Gil [22:28:39] (03CR) 10Jqnatividad: "Great! And thanks for the Gerrit/Git tip as I mark the New Year with my first core MW patch." [core] - 10https://gerrit.wikimedia.org/r/104663 (owner: 10Jqnatividad) [22:29:21] ah [22:29:24] what about it [22:31:08] Nemo_bis: i was interested in doing this and just wanted to ask who do i refer to if i come up with a problem [22:33:24] mayankmadan: yes but better ask on the bug(s), both have way smarter people than me cc'd who also half-promised to help :) [22:33:46] (03PS2) 10Manybubbles: Add hooks to extend Elasticsearch schema [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104766 (owner: 10Chad) [22:34:14] Nemo_bis: promised? [22:34:36] offered? volunteered? [22:35:00] (03CR) 10Manybubbles: [C: 032] "This just allows you to modify the schema to index new fields or change the way in which the standard fields are analyzed. We'll need mor" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104766 (owner: 10Chad) [22:35:48] (03Merged) 10jenkins-bot: Add hooks to extend Elasticsearch schema [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104766 (owner: 10Chad) [22:37:49] Nemo_bis, can you help me setup uploadwizard [22:38:02] (03CR) 10Aaron Schulz: [C: 032] changed memcached server parsing to allow for local unix domain socket connections [core] - 10https://gerrit.wikimedia.org/r/104663 (owner: 10Jqnatividad) [22:38:05] There shouldn't be anything difficult to setup about it... [22:38:21] there's a mediawiki-vagrant role [22:39:24] mayankmadan_: see https://www.mediawiki.org/wiki/MediaWiki-Vagrant and specifically https://www.mediawiki.org/wiki/MediaWiki-Vagrant#Using_roles for an easy approach. If you already have a MediaWiki instance configured, then it's not necessary, but if not, give it a try. [22:39:52] ori, i already have mediawiki setup [22:40:00] i just wanted to know about imagemagick [22:40:03] is it necessary [22:40:47] at worst some thumbnails will fail :P [22:41:36] (03Merged) 10jenkins-bot: changed memcached server parsing to allow for local unix domain socket connections [core] - 10https://gerrit.wikimedia.org/r/104663 (owner: 10Jqnatividad) [22:41:59] the installation instructions aren't clear on this point [22:42:02] so it's a good question [22:42:05] maybe marktraceur can clarify [22:51:42] Nemo_bis, so in this task, i would need to find all the instances where those messages are used add the messages in messageEn.php ? [22:53:35] perhaps [22:53:51] probably some corner of the code is calling a message that doesn't exist, or more [22:54:13] Nemo_bis, but how do i find those instances [22:54:31] there are several places where UW glues together some strings and calls them message keys [22:54:55] the standard approach is to go over those and list in code comments all the possible keys that can be invoked by the code [22:55:17] then you can check that they all exist and be confident no problems arise [22:55:44] otherwise you can go hunting all possible corners of UW and try to blindly reproduce the problem and fix just that :) [22:55:56] Nemo_bis, i dont understand the "go over those and list" part [22:57:29] all wfMessage or whatever with a non-literal key [22:58:44] (03PS1) 10Aaron Schulz: Make branch versions of *all* extensions on internal release [tools/release] - 10https://gerrit.wikimedia.org/r/104776 [23:00:13] Yay [23:00:36] Nemo_bis, so there isnt actually a message with mwe-upwiz-undefined ? [23:00:42] california rest in peace, simultaneous release [23:00:45] wfMessage with a parameter as mwe-upwiz-undefined [23:08:19] i think im starting to get this now [23:09:03] I don't know :) might be anything [23:12:16] Nemo_bis, so basically i have to find wfMessage("mwe-upwiz-" . $someUndefinedVar) ? [23:15:15] (03CR) 10Reedy: [C: 032] Fix bug with getDupeWarning [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/103384 (owner: 10UltrasonicNXT) [23:16:12] AaronSchulz: do you know if ProfilerSimpleUDP is used outside the WMF? [23:16:44] not that I know of [23:18:54] mayankmadan_: something like that; also the javascript versions though [23:18:57] but now I'm afk [23:19:10] Nemo_bis, will you be available tomorrow? [23:19:21] sure [23:31:46] (03PS1) 10Aaron Schulz: Moved HashRing to /libs [core] - 10https://gerrit.wikimedia.org/r/104778 [23:31:52] happy new year folks ! [23:33:11] (03PS1) 10Aaron Schulz: Moved MappedIterator to /libs [core] - 10https://gerrit.wikimedia.org/r/104779 [23:35:04] (03CR) 10Aaron Schulz: "This would be easier to review if all client-size mathjax stuff was removed in another commit and this rebased on top of that. I don't see" [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [23:37:05] happy new year, thedj! [23:37:44] (03PS1) 10Ori.livneh: Refactor ProfilerSimple [core] - 10https://gerrit.wikimedia.org/r/104780 [23:38:00] ^ AaronSchulz easy change, doesn't modify behavior [23:38:29] Nemo_bis, around? [23:39:06] (03PS1) 10EBernhardson: Allow page_namespace IS NULL in watchlist query [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/104781 [23:40:51] (03PS2) 10EBernhardson: Allow page_namespace IS NULL in watchlist query [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/104781 [23:40:57] * AaronSchulz just wants https://gerrit.wikimedia.org/r/#/c/103619/ reviewed [23:41:08] AaronSchulz: i'm already on it [23:42:31] oh, and all the profiler code is awful btw [23:42:41] too much mess and duplication [23:44:58] (03CR) 10EBernhardson: [C: 032] Load usernames directly from wiki's in batches [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 (owner: 10EBernhardson) [23:45:43] (03Merged) 10jenkins-bot: Load usernames directly from wiki's in batches [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 (owner: 10EBernhardson) [23:46:44] ori: why the isPersistent() change? [23:48:02] and what about $entry['count']++; ? [23:50:58] (03CR) 10Spage: [C: 032] "Matches what SpecialListusers.php and SpecialActiveusers.php do." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/104781 (owner: 10EBernhardson) [23:51:01] (03Merged) 10jenkins-bot: Allow page_namespace IS NULL in watchlist query [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/104781 (owner: 10EBernhardson) [23:53:17] AaronSchulz: eep, my mistakes [23:55:13] (03CR) 10Aaron Schulz: Refactor ProfilerSimple (032 comments) [core] - 10https://gerrit.wikimedia.org/r/104780 (owner: 10Ori.livneh) [23:55:32] (03PS1) 10Mayankmadan: Adding code comments of resulting keys [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/104782 [23:55:37] so annoying when comments are still drafts you thought you posted already [23:55:37] (03PS2) 10Ori.livneh: Refactor ProfilerSimple [core] - 10https://gerrit.wikimedia.org/r/104780 [23:55:55] just addressed both points [23:56:00] back to reviewing your change [23:56:02] (03CR) 10Aaron Schulz: [C: 032] Refactor ProfilerSimple [core] - 10https://gerrit.wikimedia.org/r/104780 (owner: 10Ori.livneh) [23:56:15] wham bam! :D [23:56:32] thanks