[00:00:29] (03CR) 10Andrew Bogott: [C: 031] "This looks right to me. Note that it needs to be deployed concurrently with something like https://gerrit.wikimedia.org/r/#/c/104484/" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/104144 (owner: 10Ryan Lane) [00:00:46] (03CR) 10Andrew Bogott: "So far untested, but very simple." [openstack-wikistatus] - 10https://gerrit.wikimedia.org/r/104484 (owner: 10Andrew Bogott) [00:01:40] (03Merged) 10jenkins-bot: Declare visibility for class properties in DatabaseOracle.php [core] - 10https://gerrit.wikimedia.org/r/103877 (owner: 10Siebrand) [00:11:31] (03CR) 10Parent5446: [C: 031] Avoid interacting with LBFactory singleton in tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104473 (owner: 10Aude) [00:12:22] Nemo_bis: if there is a list called "wikidata", but "wikidata-l" is already subbed, do I need to sub "wikidata" (w/o the -l)? [00:12:39] theres an awful lot of missing lists O_O [00:13:17] subbed? [00:13:33] there can't be two lists like that [00:14:01] i think one is inactive [00:14:19] hm [00:14:32] ah, i went to its infopage [00:14:35] its deprecated [00:15:16] ugly [00:15:35] deprecated in the wrong direction even [00:15:48] (03CR) 10TTO: "PS6: Removed the reference to MeatballWiki, and rebased the release note" [core] - 10https://gerrit.wikimedia.org/r/87649 (owner: 10TTO) [00:16:08] just ignore it, but when we add archives we'll need to remember.. [00:19:18] there is a wikimediaru-l [00:19:22] and a wikimedia-ru [00:19:36] neither of them are deprecated according to their infopages [00:20:06] and they're both active [00:20:33] russians... could be anything [00:21:29] haha lol [00:22:24] Nemo_bis: Here is the list so far of lists not on meta [00:22:25] https://docs.google.com/document/d/1rDEkwhKvrdKzTExXMops4JwyFZxw_zCdw9oBjE1Pglg/edit [00:23:08] ah but it's just public vs. private, add the public one [00:23:10] (03CR) 10TTO: "Parent5446: OK, I'll move [Add local description] to the dropdown (that requires making it an action, not a view). But I think [Edit local" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104182 (owner: 10TTO) [00:24:00] ? [00:24:09] public google doc? [00:24:40] add to gmane wikimedia-ru which is public [00:25:07] ah, ok [00:28:38] Nemo_bis: the entire list of lists that aren't on meta https://dpaste.de/wZZO [00:28:59] some aren't on meta [00:29:02] but are on gmane [00:29:56] (03CR) 10TTO: "Actually on second thoughts I'm not sure if moving [Add local description] to actions would be a good thing. It's a breaking change to the" [core] - 10https://gerrit.wikimedia.org/r/104182 (owner: 10TTO) [00:31:07] (03PS2) 10TTO: Add extra views (tabs) for files in a foreign repository [core] - 10https://gerrit.wikimedia.org/r/104182 [00:40:53] Nemo_bis: 98 lists *jaw drops* [00:42:59] GEOFBOT: wait till you leanr how many irc channels we have [00:49:05] (03PS2) 10EBernhardson: Visualize profile output in debug toolbar [core] - 10https://gerrit.wikimedia.org/r/104318 [00:52:27] (03CR) 10jenkins-bot: [V: 04-1] Visualize profile output in debug toolbar [core] - 10https://gerrit.wikimedia.org/r/104318 (owner: 10EBernhardson) [00:54:54] (03PS3) 10EBernhardson: Visualize profile output in debug toolbar [core] - 10https://gerrit.wikimedia.org/r/104318 [00:56:21] (03CR) 10leucosticte: "Thanks for the programming tips, Parent5446." [core] - 10https://gerrit.wikimedia.org/r/101443 (owner: 10leucosticte) [00:56:40] (03CR) 10leucosticte: Add preferences checkbox to email text of watched deleted pages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/101443 (owner: 10leucosticte) [00:59:01] (03PS4) 10EBernhardson: Visualize profile output in debug toolbar [core] - 10https://gerrit.wikimedia.org/r/104318 [02:07:05] (03CR) 10Jqnatividad: "That would be a more generic way of handling it. It would be nice if you can set the default behavior for the installation, instead of to" [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/104472 (owner: 10Jqnatividad) [02:18:23] (03CR) 10MZMcBride: "For the curious, I filed bug 58626 about removing the user ID altogether." [core] - 10https://gerrit.wikimedia.org/r/101221 (owner: 10Ebrahim) [02:26:13] Nemo_bis: what should i do with ruwikiconference and ruwikiconference-l? [02:26:13] they both have similar names, but both are inactive (circa 2008) [02:44:11] GEOFBOT: Let's make ruwikipediaconference and ruwikipediaconference-l. [02:44:19] And ruwikiconf and ruwikiconf-l. [02:51:09] (03PS1) 10Andrew Bogott: Constrain service group names to alphanumerics, -, and _ [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/104485 [02:51:22] (03CR) 10Andrew Bogott: [C: 031] "untested" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/104485 (owner: 10Andrew Bogott) [03:13:36] siebrand: Nikerabbit: around? [03:13:51] there's a translation page on twn that appears completely borked. [03:14:34] https://translatewiki.net/wiki/MediaWiki:Red-link-title/be-x-old - i see "$1 (старонка не існуе)" as its contents, yet when i try to edit it, the edit field is empty, and the page seems to have no history page and no revisions [03:15:18] or is that some weird fallback behavior or something? [03:29:50] (03CR) 10MZMcBride: "Thanks, Chris!" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/90546 (owner: 10Aklapper) [04:07:43] (03PS1) 10Gnosygnu: v0.12.4.0 [xowa] - 10https://gerrit.wikimedia.org/r/104486 [04:08:04] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/104486 (owner: 10Gnosygnu) [04:34:25] (03CR) 10Parent5446: Maintenance script for benchmarking parse operations (035 comments) [core] - 10https://gerrit.wikimedia.org/r/102596 (owner: 10Tim Starling) [04:40:27] Nemo_bis: Current emotion: AWW YEAHHHH [04:40:38] finally subscribed ALL the lists! [04:42:42] need to get some sleep zzzzz [04:46:43] (03CR) 10Vishnunk90: "This is a changed one." [core] - 10https://gerrit.wikimedia.org/r/104206 (owner: 10Vishnunk90) [04:51:55] (03CR) 10Vishnunk90: "@Daniel Friesen: How can I improve it Sir?" [core] - 10https://gerrit.wikimedia.org/r/104202 (owner: 10Vishnunk90) [05:01:13] (03CR) 10Parent5446: Add preferences checkbox to email text of watched deleted pages (036 comments) [core] - 10https://gerrit.wikimedia.org/r/101443 (owner: 10leucosticte) [05:09:50] (03CR) 10Daniel Friesen: "I'm not even sure what you're trying to do. rel=author doesn't make as much sense in core MediaWiki as it does on things like a blog engin" [core] - 10https://gerrit.wikimedia.org/r/104202 (owner: 10Vishnunk90) [05:10:30] (03CR) 10PleaseStand: Work around access restriction for image attachments (032 comments) [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/90546 (owner: 10Aklapper) [05:27:53] (03PS5) 10EBernhardson: Visualize profile output in debug toolbar [core] - 10https://gerrit.wikimedia.org/r/104318 [05:49:04] (03PS6) 10EBernhardson: Visualize profile output in debug toolbar [core] - 10https://gerrit.wikimedia.org/r/104318 [06:02:31] (03CR) 10Tim Starling: Maintenance script for benchmarking parse operations (035 comments) [core] - 10https://gerrit.wikimedia.org/r/102596 (owner: 10Tim Starling) [06:19:29] hi liangent [06:25:17] hello yurik [06:30:53] h [06:40:44] liangent, online? [06:48:47] (03PS2) 10Siebrand: wfRunHooks() return value no longer implies whether variable value was found [core] - 10https://gerrit.wikimedia.org/r/104206 (owner: 10Vishnunk90) [06:50:35] (03CR) 10Siebrand: [C: 04-1] wfRunHooks() return value no longer implies whether variable value was found (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104206 (owner: 10Vishnunk90) [06:52:56] (03CR) 10Siebrand: "i18n/L10n reviewed." (031 comment) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/104485 (owner: 10Andrew Bogott) [07:00:27] mayankmadan: hi [07:01:14] liangent, first question, in which case is the articleId() null ? [07:03:51] $title->getArticleId() ? [07:04:05] when that $title is not a title of an article [07:04:27] which may be a special page, an interwiki link etc [07:04:43] mayankmadan: [07:04:46] ^ [07:04:49] (03PS2) 10Mayankmadan: verifyUpload should be called before checkWarnings [core] - 10https://gerrit.wikimedia.org/r/104012 [07:05:59] (03CR) 10jenkins-bot: [V: 04-1] verifyUpload should be called before checkWarnings [core] - 10https://gerrit.wikimedia.org/r/104012 (owner: 10Mayankmadan) [07:06:10] mayankmadan: and when the article identified by that title doesn't exist [07:06:48] okay [07:07:31] liangent, on such a page, should the crumbs be empty? [07:08:36] mayankmadan: right [07:09:01] hm and it seems article id is never null; it uses 0 instead of null [07:10:06] (03PS2) 10Grunny: Replace deprecated SpecialPage::includable() [extensions/ApiExplorer] - 10https://gerrit.wikimedia.org/r/104392 (owner: 10Siebrand) [07:12:10] (03CR) 10Grunny: [C: 032 V: 032] Replace deprecated SpecialPage::includable() [extensions/ApiExplorer] - 10https://gerrit.wikimedia.org/r/104392 (owner: 10Siebrand) [07:17:15] mayankmadan: I'm leaving now, and will be back in about 2hrs [07:17:20] liangent, wait [07:18:09] liangent, you want me to check for mDoubleUnderscores['nocontentconvert'] [07:18:15] but they are in parser class [07:27:27] (03PS1) 10Legoktm: Maintenance script to salt existing unsalted passwords [core] - 10https://gerrit.wikimedia.org/r/104487 [07:28:18] (03CR) 10Legoktm: "Note: Haven't had the chance to test this yet, will do so tomorrow hopefully." [core] - 10https://gerrit.wikimedia.org/r/104487 (owner: 10Legoktm) [07:58:09] (03CR) 10Cloudyks: "Good for me" [extensions/PushToWatch] - 10https://gerrit.wikimedia.org/r/103728 (owner: 10Shirayuki) [08:11:54] hexmode: Could it be that the advanced installation for 1.22.0 is broken? [08:12:32] hexmode: I'm trying to install a 1.22.0 with SQLite and when I go to "Ask me more questions.", there are no confirmation buttons at the bottom of the next screen. [08:14:07] siebrand: have you checked the 1.22 known issues list? [08:14:21] p858snake|l: Where is it? [08:14:33] https://www.mediawiki.org/wiki/MediaWiki_1.22/Known_issues [08:14:41] (I almost can't imagine a release with a broken installer) [08:15:16] There appear to be issues with the installer. Not the one I just reported, though. [08:27:15] mayankmadan: I'm coming back earlier :) [08:27:32] liangent, great :) [08:27:38] it's enough to just check whether a modified (set by the converter) titletext exists [08:27:45] if not, use the original title [08:27:50] okay [08:28:54] (03PS1) 10Vishnunk90: wfRunHooks() return value no longer implies whether variable value was found [core] - 10https://gerrit.wikimedia.org/r/104490 [08:34:00] (03CR) 10Nemo bis: "Welcome and congrats for your first (test) patch. :)" (031 comment) [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/104377 (owner: 10AalekhN) [08:35:01] (03CR) 10PleaseStand: With mysqli, avoid setting the charset twice (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104151 (owner: 10Aaron Schulz) [08:41:59] Answer to MatmaRex is that be-x-old is deprecated, the true page is at https://translatewiki.net/w/i.php?title=MediaWiki:Red-link-title/be&action=edit [09:24:11] !logs [09:24:11] channel logs: http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki/ html version: http://tools.wmflabs.org/wm-bot/logs/index.php?display=%23mediawiki [09:29:20] (03CR) 10Guillom: "I honestly have no idea if the patch would still apply cleanly. The blog's maintenance was moved outside my responsibilities, so I haven't" [wikimedia/communications/WP-Victor] - 10https://gerrit.wikimedia.org/r/29831 (owner: 10Guillom) [09:37:30] (03CR) 10TheDJ: "If this is to find it's way in the code, I would propose extending userLink with an option to specify an array of attributes that are adde" [core] - 10https://gerrit.wikimedia.org/r/104202 (owner: 10Vishnunk90) [10:17:45] liangent, modified titletext? [10:20:12] Nemo_bis: I got your message [10:21:05] (03CR) 10Siebrand: [C: 04-2] "Please amend your previous patch sets, and do not submit a new patch when you change something. See https://www.mediawiki.org/wiki/Git/TLD" [core] - 10https://gerrit.wikimedia.org/r/104490 (owner: 10Vishnunk90) [10:21:43] (03CR) 10Siebrand: [C: 04-2] "Please amend your previous patch sets, and do not submit a new patch when you change something. See https://www.mediawiki.org/wiki/Git/TLD" [core] - 10https://gerrit.wikimedia.org/r/104206 (owner: 10Vishnunk90) [10:22:19] !logs [10:22:19] channel logs: http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki/ html version: http://tools.wmflabs.org/wm-bot/logs/index.php?display=%23mediawiki [10:23:36] liangent, what do you mean by modified titletext? [10:27:44] Nemo_bis: about the preference, we are speaking about this {{meta|Help:Preferences}} ? [10:28:00] and the rest under it ? [10:28:07] (03CR) 10Siebrand: [C: 032] Remove extra creating invalid HTML [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/103746 (owner: 10M4tx) [10:28:10] (03Merged) 10jenkins-bot: Remove extra creating invalid HTML [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/103746 (owner: 10M4tx) [10:29:10] or about ''Username'' ? [10:33:19] VladAndrew: all the preferences names [10:33:45] basically all the stuff in italics at https://www.mediawiki.org/wiki/Help:Preferences [10:35:04] Nemo_bis: so for ''Username'' I'll put (username) ? [10:35:50] and for ''NickName'' (yournick) yes ? [10:36:23] before I change for username should I use (yourusername) or (username) ? [10:36:53] also should all of these be enclosed by "(yournick) ?" [10:37:19] not "(yournick)" but "{{int:yournick}}" [10:37:57] thanks [10:46:03] (03PS8) 10Hoo man: Add mw.html to Scribunto [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 [10:46:39] (03CR) 10Hoo man: "Allow setting several css attributes at once using a key -> value table (like with :attr)" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man) [10:52:45] (03PS4) 10Nuria: Adding user agent logging for event logging server side events. [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/104040 [10:57:12] Nemo_bis: I have changed most of them, some of the int magic are missing [10:57:22] The text is bold now [10:58:48] (03PS4) 10Mayankmadan: verifyUpload should be called before checkWarnings [core] - 10https://gerrit.wikimedia.org/r/104012 [11:02:23] (03PS5) 10Mayankmadan: Output language-converted-title in output [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 [11:06:15] liangent, https://gerrit.wikimedia.org/r/#/c/103656/ [11:07:26] VladAndrew: why missing? if the preferences don't exist you should remove them [11:08:13] Real Name for example [11:08:18] it doesn't exist [11:08:31] or it exist but I haven't found it [11:10:47] VladAndrew: it exists but not on our wikis [11:11:19] VladAndrew: it's yourrealname [11:12:18] Nemo_bis:ok [11:16:02] (03PS1) 10Matthias Mullie: Removing AbuseFilter::checkConditions' param [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104496 [11:18:50] Nemo_bis: also the E-mail me for minor edit is missing [11:19:07] that's enabled on Meta [11:21:47] enableonMeta ? [11:26:27] oh [11:26:34] where is the Meta section ? [11:29:56] (03CR) 10Ori.livneh: "I don't mean to be discouraging, but the diff is still dirty -- as in, there are still some whitespace changes that shouldn't be included " [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/104040 (owner: 10Nuria) [11:30:02] Nemo_bis: there is no prefs-meta [11:30:07] where can I find the scrion [11:31:01] meta.wikimedia.org [11:31:20] liangent, online? [11:31:32] VladAndrew: tog-enotifminoredits [11:32:26] (03PS2) 10Ori.livneh: Remove ProfilerSimple::getCpuTime [core] - 10https://gerrit.wikimedia.org/r/104326 [11:33:30] Nemo_bis: done [11:35:02] (03PS4) 10Hatul: Show a warning on page deletion if a page is linked to [core] - 10https://gerrit.wikimedia.org/r/65162 (owner: 10Amire80) [11:36:45] (03CR) 10Hatul: "I sended the patch to https://gerrit.wikimedia.org/r/#/c/65162/3" [core] - 10https://gerrit.wikimedia.org/r/103852 (owner: 10Hatul) [11:40:41] VladAndrew: ok, approved, the rest can be improved later [11:42:51] (03CR) 10Ori.livneh: "Paging Krinkle" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/100338 (owner: 10Legoktm) [11:42:58] (03CR) 10Liangent: Output language-converted-title in output (036 comments) [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 (owner: 10Mayankmadan) [11:43:10] mayankmadan_: ^ [11:47:47] liangent, why is the prefix trimmung? [11:48:33] * Nemo_bis was trying to imagine how a paginated Krinkle looks like [11:49:00] mayankmadan_: gr try the use case I mentioned [11:49:20] that Project:A/B is shown as B in breadcrumbs [11:51:54] (03PS6) 10Mayankmadan: Output language-converted-title in output [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 [11:52:16] liangent, https://gerrit.wikimedia.org/r/#/c/103656 [11:52:17] better [11:52:19] ? [11:56:42] maybe but $parserCache->getProperty("displaytitle") == false is removed? [11:57:05] (03PS1) 10Grunny: Fix typo in API doc [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/104499 [11:57:37] well if that's added back, it still seems repeating itself [11:57:45] ie code produced by copy/paste, right? [11:57:47] mayankmadan_: ^ [11:58:15] (03CR) 10Hoo man: [C: 032] "Thanks for the fix :)" [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/104499 (owner: 10Grunny) [11:58:22] (03Merged) 10jenkins-bot: Fix typo in API doc [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/104499 (owner: 10Grunny) [11:59:07] liangent, i havent removed it [14:59:16] wb wm-bot [15:08:34] (03CR) 10Phe: [C: 031] Add redlink=1 to previous and next page links if needed [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/104403 (owner: 10Tpt) [15:08:58] (03CR) 10Tpt: [C: 032] "Reviewed by Phe (thanks)" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/104403 (owner: 10Tpt) [15:09:07] (03Merged) 10jenkins-bot: Add redlink=1 to previous and next page links if needed [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/104403 (owner: 10Tpt) [15:09:12] (03PS1) 10TheDJ: CodeEditor: Update to package 12.02.2013 (December 2013) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104510 [15:11:28] mayankmadan_: I think it's possible to write something like http://pastebin.com/qEWg127e ? [15:13:16] (03PS8) 10btongminh: Basic support for WebP [core] - 10https://gerrit.wikimedia.org/r/95872 [15:13:18] liangent, i dont understand what you are trying to say [15:13:26] (03CR) 10TheDJ: "Seems this was fixed upstream and thus part of:" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/100140 (owner: 10Umherirrender) [15:13:35] (03CR) 10Mayankmadan: "I dont undersatand what you are trying to say" [core] - 10https://gerrit.wikimedia.org/r/104012 (owner: 10Mayankmadan) [15:17:35] mayankmadan_: http://pastebin.com/ZJVjfBkm [15:18:16] I'm abusing class Title a bit but it shouldn't be too dangerous [15:21:57] (03PS1) 10Cmcmahon: add BROWSER_LABEL to edit string per Bug 59011 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104511 [15:22:53] liangent, wait [15:23:31] (03PS9) 10Mayankmadan: Output language-converted-title in output [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 [15:24:01] liangent, my latest patchset is working perfectly [15:26:12] (03CR) 10Liangent: Output language-converted-title in output (031 comment) [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 (owner: 10Mayankmadan) [15:26:39] liangent, no wait, its not [15:36:28] i would like to contribute to wikimedia [15:36:35] where do i get started from ? [15:37:07] samgtr: https://www.mediawiki.org/wiki/How_to_contribute ;) [15:37:30] hoo thanks [15:38:46] samgtr: But if you have any other questions don't hesitate to ask, we're pretty good about answering :) [15:40:22] marktraceur i guess i would like to start with wikimedia development [15:44:31] liangent, around? [15:44:37] samgtr: You should probably figure out a more specific thing you want to work on; else you might try browsing https://www.mediawiki.org/wiki/Annoying_little_bugs [15:45:34] mayankmadan_: [15:45:46] liangent, great [15:45:57] marktraceur: i would try to fix easy bugs to get used to the code. i guess the link is perfect thanks [15:46:13] :) good, I'm glad [15:46:23] In fairness, that's a heavily curated list [15:47:23] A More Raw Experience might be available at https://bugzilla.wikimedia.org/buglist.cgi?keywords=easy&keywords_type=allwords&resolution=---&resolution=LATER&resolution=DUPLICATE&query_format=advanced - samgtr [15:54:56] (03PS10) 10Mayankmadan: Output language-converted-title in output [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 [15:55:22] liangent, can you have a look at the latest patchset [15:56:17] mayankmadan_: no difference about my comment? https://gerrit.wikimedia.org/r/#/c/103656/9..10/GeoCrumbs.class.php [15:59:05] liangent, thanks for pointing that out [15:59:16] liangent, it will solve another prob too :) [15:59:51] (03PS1) 10TheDJ: [WIP] Toggle invisible characters in CodeEditor [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104512 [16:06:43] (03PS1) 10Cmcmahon: WIP click the links created in this run of the tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104513 [16:12:30] (03CR) 10Zfilipin: WIP click the links created in this run of the tests (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104513 (owner: 10Cmcmahon) [16:15:51] (03CR) 10Vishnunk90: "@Siebrand: How to remove this change sir?" [core] - 10https://gerrit.wikimedia.org/r/104206 (owner: 10Vishnunk90) [16:16:27] hmm, gerrit seems a tad overloaded ? [16:16:52] thedj: not slower than usual for me [16:17:00] (03CR) 10Siebrand: "Don't worry. You're not the first, and won't be the last. There's a button "Abandon change" here. Click that, provide an optional reason f" [core] - 10https://gerrit.wikimedia.org/r/104206 (owner: 10Vishnunk90) [16:20:39] How can I delete a change which i was submitted? [16:21:33] (03CR) 10CSteipp: Work around access restriction for image attachments (031 comment) [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/90546 (owner: 10Aklapper) [16:21:37] (03CR) 10Anomie: Add mw.html to Scribunto (032 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man) [16:21:52] (03CR) 10Anomie: Add mw.html to Scribunto (037 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man) [16:22:46] (03Abandoned) 10Cmcmahon: WIP click the links created in this run of the tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104513 (owner: 10Cmcmahon) [16:23:30] (03PS4) 10CSteipp: Work around access restriction for image attachments [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/90546 (owner: 10Aklapper) [16:24:04] (03Abandoned) 10EBernhardson: Batch update job for unread user notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/64858 (owner: 10EBernhardson) [16:28:29] (03Abandoned) 10Vishnunk90: wfRunHooks() return value no longer implies whether variable value was found [core] - 10https://gerrit.wikimedia.org/r/104490 (owner: 10Vishnunk90) [16:30:19] (03Abandoned) 10Vishnunk90: wfRunHooks() return value no longer implies whether variable value was found [core] - 10https://gerrit.wikimedia.org/r/104206 (owner: 10Vishnunk90) [16:34:38] My master branch shows 35commits.But i didnt do it. Can anyone help me to remove all those? [16:35:23] (03PS1) 10Manybubbles: Elastica and Cirrus to master. [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/104516 [16:35:39] (03PS11) 10Mayankmadan: Output language-converted-title in output [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 [16:36:57] liangent, can you have a look at the latest patchset [16:37:08] liangent, and please ping me if you are online [16:37:12] (03PS1) 10Siebrand: Update type hint for CreditsAction::getAuthor() [core] - 10https://gerrit.wikimedia.org/r/104517 [16:37:13] (03PS1) 10Siebrand: Update documentation for ParserCache::save() [core] - 10https://gerrit.wikimedia.org/r/104518 [16:37:24] hi qgil [16:37:37] (03PS1) 10Manybubbles: Elastica and Cirrus to master. [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/104519 [16:38:20] qgil, https://gerrit.wikimedia.org/r/#/c/104012/ [16:38:21] ECT Showcase starting now: https://plus.google.com/events/cr341ajcslbqciqe67uqmcfv4d0 [16:40:09] (03CR) 10Anomie: [C: 032] Fixed locking in JobQueueAggregatorRedis [core] - 10https://gerrit.wikimedia.org/r/104478 (owner: 10Aaron Schulz) [16:41:10] (03CR) 10Chad: [C: 031] Elastica and Cirrus to master. [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/104519 (owner: 10Manybubbles) [16:41:14] (03CR) 10Chad: [C: 031] Elastica and Cirrus to master. [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/104516 (owner: 10Manybubbles) [16:41:28] <^d> manybubbles: Everything looks good, will merge when window opens. [16:41:40] ^d: sweet [16:41:48] when you were on a plane ori set me up with merging too [16:41:51] so you don't have to if you like [16:42:26] Looks like someone might have broken thumbnailing of instant commons images... [16:42:31] http://upload.wikimedia.org/wikipedia/commons/3/31/Furnadoia_de_Seceda_y_Resciesa.JPG [16:42:35] http://192.168.0.190/w/images/thumb/3/31/Furnadoia_de_Seceda_y_Resciesa.JPG/800px-Furnadoia_de_Seceda_y_Resciesa.JPG [16:43:24] -rw-r--r-- 1 www-data www-data 110694 Dec 30 16:41 800px-Furnadoia_de_Seceda_y_Resciesa.JPG [16:44:15] (03PS3) 10Vishnunk90: wfRunHooks() return value no longer implies whether variable value was found. Bug: 12837 [core] - 10https://gerrit.wikimedia.org/r/104203 [16:44:17] liangent, i need some help [16:44:30] Or is it thumb.php [16:44:39] which may already be known to be broken.. [16:44:42] <^d> nfc. [16:45:04] <^d> manybubbles: I could've sworn I had fixed that for you before :p [16:45:07] <^d> Whooooops [16:45:20] https://bugzilla.wikimedia.org/show_bug.cgi?id=54202 [16:45:21] Yup [16:45:47] (03Abandoned) 10Umherirrender: Remove extra comma to avoid fatal in IE7 [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/100140 (owner: 10Umherirrender) [16:46:23] (03Merged) 10jenkins-bot: Fixed locking in JobQueueAggregatorRedis [core] - 10https://gerrit.wikimedia.org/r/104478 (owner: 10Aaron Schulz) [16:48:36] (03PS4) 10Siebrand: Various fixes for EnhancedChangesList [core] - 10https://gerrit.wikimedia.org/r/96244 [16:48:44] (03CR) 10Siebrand: "PS4 has extra changes." [core] - 10https://gerrit.wikimedia.org/r/96244 (owner: 10Siebrand) [16:49:08] Reedy: did you see that the normal mediawiki update moved from Tuesday to MOnday (today) for this week? [16:50:58] liangent, okay, its done now [16:51:10] (03PS12) 10Mayankmadan: Output language-converted-title in output [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 [16:51:34] greg-g: Yeah, about 5 minutes ago ;) [16:52:02] Reedy: :) pleeenty of time then [16:52:03] liangent, its perfectly working :) [16:53:06] (03CR) 10Umherirrender: "Found three trailing commas which maybe break IE7 when using CodeEditor (not tested). Maybe there can be fixed upstream. Thanks." (033 comments) [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/104510 (owner: 10TheDJ) [16:56:31] liangent, okay now its done [16:56:39] (03PS13) 10Mayankmadan: Output language-converted-title in output [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 [16:56:41] liangent, the latest patchset fixes all the issues [16:57:47] liangent, can you please close the task now? [16:57:48] (03CR) 10Liangent: Output language-converted-title in output (031 comment) [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 (owner: 10Mayankmadan) [16:59:53] (03PS14) 10Mayankmadan: Output language-converted-title in output [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 [16:59:59] liangent, okay now its done :) [17:00:20] liangent, and will i get any credit for this task? i was very close to solving it [17:02:10] (03CR) 10Chad: [C: 032] Elastica and Cirrus to master. [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/104519 (owner: 10Manybubbles) [17:02:18] (03CR) 10Chad: [C: 032] Elastica and Cirrus to master. [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/104516 (owner: 10Manybubbles) [17:05:38] (03Merged) 10jenkins-bot: Elastica and Cirrus to master. [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/104519 (owner: 10Manybubbles) [17:05:49] (03CR) 10Liangent: Output language-converted-title in output (031 comment) [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 (owner: 10Mayankmadan) [17:06:08] mayankmadan_: hm I'm not very sure what that "credit" mean [17:06:14] any documentation? [17:06:27] liangent, documentation for what? [17:07:21] (03Merged) 10jenkins-bot: Elastica and Cirrus to master. [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/104516 (owner: 10Manybubbles) [17:07:48] (03PS15) 10Mayankmadan: Output language-converted-title in output [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 [17:08:23] (03CR) 10Nuria: "Added couple comments to CR. wondering also if we should add a README that explains how to setup the examples/run tests." (032 comments) [passport-mediawiki] - 10https://gerrit.wikimedia.org/r/103866 (owner: 10Milimetric) [17:08:25] liangent, now? [17:09:23] (03CR) 10Anomie: [C: 031] "Code seems ok, although it could probably use a refactor I won't -1 over that. Haven't tested." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/104395 (owner: 10Jackmcbarn) [17:09:47] mayankmadan_: for "credits" [17:10:27] liangent, no no, do you believe i had something to do with this task :)? [17:11:17] mayankmadan_: I was talking about spacing and indention... come to https://gerrit.wikimedia.org/r/#/c/103656/15/GeoCrumbs.class.php to see what it looks like to me [17:11:18] liangent, because that will count while the final evaluation of gci [17:13:46] (03PS16) 10Mayankmadan: Output language-converted-title in output [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 [17:14:00] (03CR) 10Milimetric: "Thanks Nuria. Answered questions and I'll add more to the readme in a moment." (032 comments) [passport-mediawiki] - 10https://gerrit.wikimedia.org/r/103866 (owner: 10Milimetric) [17:15:06] (03CR) 10Aaron Schulz: [C: 032] Show a warning on page deletion if a page is linked to [core] - 10https://gerrit.wikimedia.org/r/65162 (owner: 10Amire80) [17:15:49] (03PS17) 10Mayankmadan: Output language-converted-title in output [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 [17:16:38] liangent, now the indentation is good to go [17:18:07] (03PS4) 10Milimetric: Implementing mediawiki oauth for node [passport-mediawiki] - 10https://gerrit.wikimedia.org/r/103866 [17:18:20] hello yurik [17:18:21] (03Merged) 10jenkins-bot: Show a warning on page deletion if a page is linked to [core] - 10https://gerrit.wikimedia.org/r/65162 (owner: 10Amire80) [17:19:09] (03Abandoned) 10Mayankmadan: Adding support for more types of flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103967 (owner: 10Mayankmadan) [17:20:08] mayankmadan_: really ..? I'm feeling I want to fix those styling issues myself for you but I'm not sure whether this is some right thing to do in GCI :p [17:20:10] (03PS1) 10UltrasonicNXT: Add online users sidebar portlet [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/104525 [17:20:16] Nemo_bis: any idea ^ [17:20:58] liangent, i was getting the indentation right in the first place in sublime text 2 but i dont know why it isnt working with gerrit [17:21:49] mayankmadan_: because spaces and tabs are mixed in the file [17:21:56] liangent, ok [17:22:46] and I believe you're using a tab width of 4 [17:22:52] but gerrit uses 8 [17:23:11] (03PS18) 10Mayankmadan: Output language-converted-title in output [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 [17:23:14] (03CR) 10EBernhardson: [C: 031] "Consider also adding a method for doing the same thing in batches." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100371 (owner: 10Matthias Mullie) [17:23:39] (03PS5) 10Milimetric: Implementing mediawiki oauth for node [passport-mediawiki] - 10https://gerrit.wikimedia.org/r/103866 [17:24:25] liangent, okay now its fine [17:24:32] liangent, converted all indents to tasbs [17:24:33] *tabs [17:24:35] (03PS2) 10Aaron Schulz: With mysqli, avoid setting the charset twice [core] - 10https://gerrit.wikimedia.org/r/104151 [17:25:43] (03CR) 10Hoo man: Add mw.html to Scribunto (037 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man) [17:25:44] (03PS9) 10Hoo man: Add mw.html to Scribunto [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 [17:26:40] (03CR) 10Hoo man: "Addressed Anomie's comments." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man) [17:28:22] (03CR) 10CSteipp: [C: 032] Add comment to updateCheckUserData indicating other extensions may call it [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/93654 (owner: 10Legoktm) [17:28:25] (03Merged) 10jenkins-bot: Add comment to updateCheckUserData indicating other extensions may call it [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/93654 (owner: 10Legoktm) [17:34:55] liangent, ? [17:35:24] (03CR) 10Hoo man: "Sorry, only saw that now" (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man) [17:35:35] (03PS10) 10Hoo man: Add mw.html to Scribunto [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 [17:36:03] (03CR) 10Hoo man: "Addressed remaining comment from PS5 (only saw that now)" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man) [17:37:02] (03CR) 10Liangent: Output language-converted-title in output (034 comments) [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 (owner: 10Mayankmadan) [17:37:18] (03PS9) 10btongminh: Basic support for WebP [core] - 10https://gerrit.wikimedia.org/r/95872 [17:38:23] (03PS1) 10Siebrand: Random documentation tweaks [core] - 10https://gerrit.wikimedia.org/r/104527 [17:38:24] (03PS1) 10Siebrand: Throw exception on invalid RecentChange types [core] - 10https://gerrit.wikimedia.org/r/104528 [17:38:26] (03CR) 10Jdlrobson: [C: 032] API: Include variant name in meta=siteinfo [core] - 10https://gerrit.wikimedia.org/r/104140 (owner: 10Anomie) [17:39:15] (03CR) 10btongminh: "PS9 adds a RIFF parser and support for the VP8X file type" [core] - 10https://gerrit.wikimedia.org/r/95872 (owner: 10btongminh) [17:40:44] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Add online users sidebar portlet [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/104525 (owner: 10UltrasonicNXT) [17:42:16] (03CR) 10Liangent: "@Siebrand: I can't find anything in doc to *update*. Actually there wasn't any doc related to "variants". It's simply covered by "general " [core] - 10https://gerrit.wikimedia.org/r/104140 (owner: 10Anomie) [17:44:01] (03PS19) 10Mayankmadan: Output language-converted-title in output [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 [17:44:20] (03CR) 10Siebrand: "@liangent: Okay. It appears Jon approved the merge regardless." [core] - 10https://gerrit.wikimedia.org/r/104140 (owner: 10Anomie) [17:44:40] liangent, now it should be done [17:46:51] (03Merged) 10jenkins-bot: API: Include variant name in meta=siteinfo [core] - 10https://gerrit.wikimedia.org/r/104140 (owner: 10Anomie) [17:47:50] hi mayankmadan_ [17:48:54] hi qgil [17:49:01] (03CR) 10Robert Vogel: [C: 032 V: 032] "Good. Thanks." [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/104385 (owner: 10Siebrand) [17:49:13] (03PS1) 10Cmcmahon: target different topics per browser to prevent edit conflict [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104531 [17:49:19] (03PS1) 10Umherirrender: Fix typo - fuction -> function [core] - 10https://gerrit.wikimedia.org/r/104532 [17:49:32] qgil, i dont understand btongminh commit https://gerrit.wikimedia.org/r/#/c/104012/ [17:49:36] *comment [17:49:52] mayankmadan_: there's a tool called stylize.php [17:50:05] mayankmadan_, ask marktraceur [17:50:14] qgil, ok [17:50:24] liangent, the file looks good now [17:50:33] liangent, i dont think it needs that script [17:50:38] hi mayankmadan_, btongminh is me [17:50:42] (03PS2) 10Cmcmahon: different topics per browser to prevent edit conflict Bug 59011 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104531 [17:50:48] hi Bryan [17:50:55] I don't have time atm, but I'll explain later tonight if you're still here [17:51:04] Bryan, alright [17:51:12] Bryan, in about 2-3 hrs? [17:52:25] don't know, maybe [17:52:32] qgil: is it acceptable to do some final stylization myself for the student and mark the task as done? [17:52:32] (03CR) 10Anomie: [C: 04-1] "Looking better!" (0312 comments) [core] - 10https://gerrit.wikimedia.org/r/53964 (owner: 10Eranroz) [17:52:41] liangent, ill do it [17:52:48] or should I insist in letting the student do it him/herself [17:53:08] mayankmadan_: ok [17:54:37] Hi liangent , well, up to you but in general it is better to let them do the work themselves. [17:55:46] liangent, sometimes it is easier to do it than to explain it :) , but in any case it is good that they understand what was wrong and why. Fixing the problem is usually the best way to learn. [17:57:10] qgil: :) [17:58:58] (03CR) 10Reedy: [C: 04-1] Maintenance script to salt existing unsalted passwords (032 comments) [core] - 10https://gerrit.wikimedia.org/r/104487 (owner: 10Legoktm) [18:00:46] Bryan: FYI, I overheard you talking about UW in -commons the other day, you'll be interested to know the Multimedia team is going to roll through UploadWizard a few times in the coming months and do bug fixing and general improvements [18:02:13] qgil: just checking: are we meeting now? [18:03:06] guillom, oops, according to our calendar yes. Then again, do we need to meet? [18:03:12] (03PS2) 10Reedy: Update type hint for CreditsAction::getAuthor() [core] - 10https://gerrit.wikimedia.org/r/104517 (owner: 10Siebrand) [18:03:19] (03CR) 10Reedy: [C: 032] Update type hint for CreditsAction::getAuthor() [core] - 10https://gerrit.wikimedia.org/r/104517 (owner: 10Siebrand) [18:03:23] qgil: not really, but I wanted to be sure :) [18:04:04] guillom, ok, then agreed. :) This week I'm taking my last days of 2013 vacation tomorrow + Friday (+ New Year, like everybody else) [18:04:15] ok [18:04:55] guillom, see you around. You are not allowed to deal with GCI tasks during New Year's eve. ;) [18:05:07] I'll only be out on Wednesday [18:05:16] ok [18:05:23] (03CR) 10Ori.livneh: "diff still dirty -- and I thought we agreed not to change the schema just yet?" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/104040 (owner: 10Nuria) [18:05:25] qgil: I'm not planning to celebrate it :) [18:05:42] (03CR) 10Siebrand: [C: 032] Fix typo - fuction -> function [core] - 10https://gerrit.wikimedia.org/r/104532 (owner: 10Umherirrender) [18:06:07] guillom, I suspected [18:06:41] :) [18:07:02] (03Merged) 10jenkins-bot: Update type hint for CreditsAction::getAuthor() [core] - 10https://gerrit.wikimedia.org/r/104517 (owner: 10Siebrand) [18:07:44] hi [18:08:04] hi m4tx :) [18:08:28] :> [18:08:35] I have a question [18:08:46] (03CR) 10Ori.livneh: [C: 04-1] "There is no reason to fix a mistake in another patch when that patch hasn't been merged yet -- you can simply update the original patch." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/104509 (owner: 10Nuria) [18:09:20] is there any way to transmit some text to the JavaScript in PHP? [18:10:06] Reedy: Blimey! [18:10:12] Reedy: Why?! [30-Dec-2013 18:08:53 UTC] PHP Catchable fatal error: Argument 1 passed to CreditsAction::getAuthor() must be an instance of WikiPage, instance of Article given, called in /www/translatewiki.net/w/includes/actions/CreditsAction.php on line 70 and defined in /www/translatewiki.net/w/includes/actions/CreditsAction.php on line 86 [18:10:25] I know that there's messages system in ResourceManager, but I want to provide a string from a PHP function, actually, not only a translated message... [18:10:28] (03Merged) 10jenkins-bot: Fix typo - fuction -> function [core] - 10https://gerrit.wikimedia.org/r/104532 (owner: 10Umherirrender) [18:10:36] siebrand: It looked sane and so did the caller... [18:10:48] (03CR) 10Anomie: Throw exception on invalid RecentChange types (032 comments) [core] - 10https://gerrit.wikimedia.org/r/104528 (owner: 10Siebrand) [18:11:08] (03PS1) 10Reedy: Revert "Update type hint for CreditsAction::getAuthor()" [core] - 10https://gerrit.wikimedia.org/r/104534 [18:11:12] Reedy: Yes, indeed. [18:11:20] Reedy: I'd like to understand :( [18:11:21] (03PS2) 10Reedy: Revert "Update type hint for CreditsAction::getAuthor()" [core] - 10https://gerrit.wikimedia.org/r/104534 [18:11:29] (03CR) 10Reedy: [C: 032] Revert "Update type hint for CreditsAction::getAuthor()" [core] - 10https://gerrit.wikimedia.org/r/104534 (owner: 10Reedy) [18:11:38] * @var WikiPage|Article|ImagePage|CategoryPage|Page $page [18:11:41] That's pretty scary [18:11:50] (spot the odd one out) [18:11:55] (03CR) 10Siebrand: "And yet..." [core] - 10https://gerrit.wikimedia.org/r/104517 (owner: 10Siebrand) [18:12:58] Reedy: I think things might become better if Page would actually require something, but I have no idea if that's possible. [18:16:13] liangent, ok, i cant seem to get stylize.php working [18:17:45] (03Merged) 10jenkins-bot: Revert "Update type hint for CreditsAction::getAuthor()" [core] - 10https://gerrit.wikimedia.org/r/104534 (owner: 10Reedy) [18:18:02] mayankmadan_: php path/to/stylize.php path/to/your_file.php [18:19:10] liangent, i know that but there is MWCodeUtilsArgs.pjp [18:19:12] *php [18:19:14] in the repo [18:20:56] hey, is there any way to pass some string from PHP to JavaScript? working on extension... [18:23:03] mayankmadan_: You need the mediawki/tools/code-utils repo [18:24:50] (03PS3) 10Cmcmahon: different topics per browser to prevent edit conflict Bug 59011 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104531 [18:25:11] (03PS1) 1001tonythomas: Fix depreciation warnings in FileBackend construction for ConfirmEdit [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/104535 [18:29:28] (03CR) 10gbruin: [C: 04-1 V: 032] "Thank you for reporting this. I pushed the change to github at https://github.com/garbear/facebook-mediawiki/commit/1b1b4398c285ce0a2984f0" [extensions/FacebookOpenGraph] - 10https://gerrit.wikimedia.org/r/103934 (owner: 10Legoktm) [18:30:06] (03CR) 10gbruin: "Gerrit messed up the URL, it should be https://github.com/garbear/facebook-mediawiki/commit/1b1b4398c285ce0a2984f00c047e1af04de10575" [extensions/FacebookOpenGraph] - 10https://gerrit.wikimedia.org/r/103934 (owner: 10Legoktm) [18:33:16] (03PS20) 10Mayankmadan: Output language-converted-title in output [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 [18:33:18] liangent, stylized the file [18:33:59] m4tx, which string are you talking about? [18:34:39] I just have a function in PHP that returns string and I want to pass the return value of this function to the PHP. [18:35:41] I was wondering if I can use 'messages' ResourceLoader module, but it only supports providing translated messages to JavaScript... I need something more complex. [18:37:02] (03PS1) 1001tonythomas: Fix depreciation warnings in FileBackend construction for EasyTimeline [extensions/timeline] - 10https://gerrit.wikimedia.org/r/104536 [18:37:34] m4tx: I don't have the time to explain stuff right now, but you can have a look at: https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/client/includes/modules/SiteModule.php and https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/client/resources/Resources.php [18:38:15] oh, thanks. [18:38:21] I'll have a look at it. [18:38:34] liangent, around? [18:42:10] (03PS1) 10Manybubbles: Add method to get entire text layer. This could be useful for search [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/104537 [18:42:31] (03PS1) 10Chad: Add method to get entire text layer. This could be useful for search [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/104538 [18:42:42] (03CR) 10Cmcmahon: [C: 032] add BROWSER_LABEL to edit string per Bug 59011 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104511 (owner: 10Cmcmahon) [18:42:53] (03PS4) 10Cmcmahon: different topics per browser to prevent edit conflict Bug 59011 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104531 [18:43:03] (03CR) 10Cmcmahon: [C: 032] different topics per browser to prevent edit conflict Bug 59011 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104531 (owner: 10Cmcmahon) [18:43:32] (03Abandoned) 10Chad: Add method to get entire text layer. This could be useful for search [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/104538 (owner: 10Chad) [18:43:40] mayankmadan_, so about uploading: the upload frame work bas has been divided into two parts, the backend and the frontend [18:43:43] (03CR) 10Chad: [C: 032 V: 032] Add method to get entire text layer. This could be useful for search [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/104537 (owner: 10Manybubbles) [18:43:55] where the frontend are things like ApiUpload and SpecialUpload [18:44:04] these frontends should call the backend to perform the upload [18:44:37] and roughly, they should ask the backend four things: initialize; file verifications; warnings and performing the upload [18:44:49] each of these four actions is in theory independent of each other [18:44:54] (03Merged) 10jenkins-bot: different topics per browser to prevent edit conflict Bug 59011 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104531 (owner: 10Cmcmahon) [18:45:08] and it is the responsibility of the frontend to ensure that the backend is called in an appropriate manner [18:45:30] which is, for example, not calling performUpload or checkWarnings() if file verifcation has failed [18:45:54] therefore, the bug that we were talking about should be fixed in the front end [18:46:08] i.e., ApiUpload should not call checkWarnings() if verifyFile() has failed [18:46:52] of course, you can argue that undefined offsets should not occur, regardless of whether the frontend is doing the correct thing or not [18:47:09] I don't know [18:48:13] <^d> It's Bryan! [18:48:36] It's me! [18:48:38] hi Chad [18:48:46] <^d> Howdy. How've you been? [18:49:32] much better since I unbroke git ;) [18:49:45] busy IRL unfortunately [18:52:09] mayankmadan_: here [18:52:47] liangent, can the task be closed now? [18:52:51] any way, see y'all later [18:52:59] (03CR) 10Umherirrender: "Article::__call delegate method calls to WikiPage" [core] - 10https://gerrit.wikimedia.org/r/104517 (owner: 10Siebrand) [18:55:36] (03CR) 10Ori.livneh: "This is pretty damn cool." [core] - 10https://gerrit.wikimedia.org/r/104318 (owner: 10EBernhardson) [18:56:10] (03PS1) 1001tonythomas: Removed const ParserCache::try116cache [core] - 10https://gerrit.wikimedia.org/r/104541 [19:00:06] (03CR) 10Aaron Schulz: [C: 04-1] Removed const ParserCache::try116cache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104541 (owner: 1001tonythomas) [19:00:36] mayankmadan_: I think it looks good enough. still want to nitpick the naming of $titleText but I can't think of a better one myself. [19:00:57] liangent, so is the task good enough to be closed? [19:03:33] (03CR) 10Liangent: [C: 031] Output language-converted-title in output (031 comment) [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 (owner: 10Mayankmadan) [19:04:01] mayankmadan_: done :) thanks for your work [19:04:11] liangent, thank you [19:04:18] liangent, im really grateful to you [19:07:24] (03CR) 10Liangent: "Adding some people for final check & merge." [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 (owner: 10Mayankmadan) [19:08:13] (03PS2) 1001tonythomas: Removed const ParserCache::try116cache [core] - 10https://gerrit.wikimedia.org/r/104541 [19:08:39] guillom, http://www.google-melange.com/gci/task/view/google/gci2013/5857766174359552 [19:08:40] Add template data to two popular Wikipedia templates #14 [19:08:41] Status: ClaimRequested [19:08:41] Mentor(s): Guillaume Paumier, Quim Gil [19:10:03] (03CR) 10Aaron Schulz: [C: 032] Removed const ParserCache::try116cache [core] - 10https://gerrit.wikimedia.org/r/104541 (owner: 1001tonythomas) [19:12:07] AaronSchulz: hey, does ParserOptions::legacyOption become deprecated as in this bug https://bugzilla.wikimedia.org/show_bug.cgi?id=59127 ? [19:12:20] mayankmadan_: your edit on https://en.wikipedia.org/wiki/Template:Infobox_television_episode/doc got reverted [19:12:31] liangent, why? [19:12:58] I don't know. I just observed that [19:13:13] mayankmadan_: https://en.wikipedia.org/w/index.php?title=Template:Infobox_television_episode/doc&diff=next&oldid=587660367 [19:13:15] (03Merged) 10jenkins-bot: Removed const ParserCache::try116cache [core] - 10https://gerrit.wikimedia.org/r/104541 (owner: 1001tonythomas) [19:13:58] (03CR) 10Siebrand: Removed const ParserCache::try116cache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104541 (owner: 1001tonythomas) [19:14:03] liangent, there is no reasong given in that [19:14:24] "(Undid revision 587660367 by 120.59.44.121 (talk), wrong)" [19:14:39] I have no idea what happened exactly [19:16:41] guillom, any idea why it was reverted? [19:17:46] (03PS1) 1001tonythomas: Removed const ParserCache::try116cache [core] - 10https://gerrit.wikimedia.org/r/104543 [19:18:15] (03Abandoned) 1001tonythomas: Removed const ParserCache::try116cache [core] - 10https://gerrit.wikimedia.org/r/104543 (owner: 1001tonythomas) [19:18:53] tonythomas01: not quite it seems [19:19:08] (03CR) 10Siebrand: Output language-converted-title in output (031 comment) [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 (owner: 10Mayankmadan) [19:19:30] Aaron|home: ok. Anyway, I will upload a new patch with the whitespace removed [19:24:05] (03PS1) 1001tonythomas: Removed whitespace from ParserCache.php [core] - 10https://gerrit.wikimedia.org/r/104545 [19:24:46] (03CR) 10jenkins-bot: [V: 04-1] Removed whitespace from ParserCache.php [core] - 10https://gerrit.wikimedia.org/r/104545 (owner: 1001tonythomas) [19:25:52] (03CR) 10Umherirrender: "A UserArray class exists to select many users in one db query from the database into User objects." [core] - 10https://gerrit.wikimedia.org/r/100371 (owner: 10Matthias Mullie) [19:27:06] guillom, ping me when you are around [19:35:37] mayankmadan_: while you're waiting for guillom's appearance, are you still interested in working on https://gerrit.wikimedia.org/r/103656 , given siebrand's suggestion? [19:36:00] (03CR) 10Chad: [C: 031] With mysqli, avoid setting the charset twice [core] - 10https://gerrit.wikimedia.org/r/104151 (owner: 10Aaron Schulz) [19:37:44] (03CR) 10Chad: [C: 04-1] Add TODOs for missing return statements (032 comments) [core] - 10https://gerrit.wikimedia.org/r/104022 (owner: 10Siebrand) [19:38:48] (03CR) 10Siebrand: Add TODOs for missing return statements (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104022 (owner: 10Siebrand) [19:39:27] (03PS2) 1001tonythomas: Removed trailing whitespace from ParserCache.php [core] - 10https://gerrit.wikimedia.org/r/104545 [19:40:07] (03CR) 10jenkins-bot: [V: 04-1] Removed trailing whitespace from ParserCache.php [core] - 10https://gerrit.wikimedia.org/r/104545 (owner: 1001tonythomas) [19:40:57] (03CR) 10Chad: Add TODOs for missing return statements (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104022 (owner: 10Siebrand) [19:44:04] (03PS1) 10Reedy: Fix Argument 1 passed to Language::commaList() must be an array, null given [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/104548 [19:44:55] legoktm: hoo csteipp ^^ [19:45:04] Ryan_lane broke all the things [19:45:40] (03CR) 10Hoo man: [C: 032] Fix Argument 1 passed to Language::commaList() must be an array, null given [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/104548 (owner: 10Reedy) [19:45:43] (03Merged) 10jenkins-bot: Fix Argument 1 passed to Language::commaList() must be an array, null given [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/104548 (owner: 10Reedy) [19:45:44] here you go... [19:45:48] thanks [19:45:49] liangent, ofcourse [19:45:54] although phpunits are missing :D [19:47:00] (03PS1) 10Reedy: Update CentralAuth to master [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/104549 [19:47:55] (03CR) 10Reedy: [C: 032 V: 032] Update CentralAuth to master [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/104549 (owner: 10Reedy) [19:48:25] (03PS21) 10Mayankmadan: Output language-converted-title in output [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 [19:48:35] liangent, done [19:52:18] (03PS1) 10Chad: Use full (03PS1) 10Umherirrender: Special:Contributions RSS has 1 more than limit [core] - 10https://gerrit.wikimedia.org/r/104551 [19:53:30] Thanks for the fix Reedy [19:54:31] (03CR) 10Mwalker: [C: 04-1] BookManagerv2: Invalidate navbar cache when JSON file changes [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/104208 (owner: 10Geek400) [19:54:43] (03CR) 10Siebrand: "New PS coming up." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/104022 (owner: 10Siebrand) [19:54:51] (03CR) 10Liangent: [C: 031] Output language-converted-title in output [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 (owner: 10Mayankmadan) [19:55:14] (03PS3) 1001tonythomas: Removed whitespaces from ParserCache.php [core] - 10https://gerrit.wikimedia.org/r/104545 [19:55:55] (03CR) 10jenkins-bot: [V: 04-1] Removed whitespaces from ParserCache.php [core] - 10https://gerrit.wikimedia.org/r/104545 (owner: 1001tonythomas) [19:56:03] (03PS3) 10Siebrand: Return void for LogPager::limitPerformer and limitTitle [core] - 10https://gerrit.wikimedia.org/r/104022 [19:56:21] (03CR) 10Manybubbles: [C: 032] Use full (03Merged) 10jenkins-bot: Use full (03CR) 10Reedy: "Seemingly caused bug 59134" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/103910 (owner: 10Legoktm) [19:59:13] (03PS4) 1001tonythomas: Removed whitespace from ParserCache.php [core] - 10https://gerrit.wikimedia.org/r/104545 [19:59:15] Why is that using __call()? [20:00:31] (03CR) 10jenkins-bot: [V: 04-1] Removed whitespace from ParserCache.php [core] - 10https://gerrit.wikimedia.org/r/104545 (owner: 1001tonythomas) [20:02:59] * Reedy kicks legoktm [20:03:43] (03CR) 10Reedy: Deprecate SpecialPage::getTitle (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103587 (owner: 10Legoktm) [20:05:35] (03PS1) 10EBernhardson: Respect sizing from user-supplied class [core] - 10https://gerrit.wikimedia.org/r/104650 [20:06:01] (03PS1) 10Reedy: Revert "Replace usage of SpecialPage::getTitle with getPageTitle" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/104651 [20:06:09] (03PS1) 10Reedy: Revert "Replace usage of SpecialPage::getTitle with getPageTitle" [extensions/CentralAuth] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/104652 [20:06:18] (03Abandoned) 10Reedy: Revert "Replace usage of SpecialPage::getTitle with getPageTitle" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/104651 (owner: 10Reedy) [20:06:32] (03CR) 10Reedy: [C: 032] Revert "Replace usage of SpecialPage::getTitle with getPageTitle" [extensions/CentralAuth] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/104652 (owner: 10Reedy) [20:07:18] (03PS5) 1001tonythomas: Removed whitespaces from ParserCache.php [core] - 10https://gerrit.wikimedia.org/r/104545 [20:09:06] qgil, around? [20:09:21] mayankmadan__, yes [20:09:23] * Reedy waits for jenkins [20:09:28] (03PS2) 10EBernhardson: Respect sizing from user-supplied class [core] - 10https://gerrit.wikimedia.org/r/104650 [20:09:42] qgil, my change was abandoned on this due to some unknown(to me) reason https://en.wikipedia.org/wiki/Template:Infobox_television_episode/doc [20:10:06] (03Abandoned) 1001tonythomas: Removed whitespaces from ParserCache.php [core] - 10https://gerrit.wikimedia.org/r/104545 (owner: 1001tonythomas) [20:10:15] (03PS7) 10EBernhardson: Visualize profile output in debug toolbar [core] - 10https://gerrit.wikimedia.org/r/104318 [20:11:07] qgil, https://en.wikipedia.org/w/index.php?title=Template:Infobox_television_episode/doc&diff=next&oldid=587660367 [20:11:40] mayankmadan__: Message the user? [20:11:49] (03CR) 10CSteipp: [C: 031] "Reedy's comments would be nice, but +1 for the concept, and it looks like the logic is correct." [core] - 10https://gerrit.wikimedia.org/r/104487 (owner: 10Legoktm) [20:11:54] (03CR) 10Siebrand: [C: 04-1] "Please consider upstreaming these changes." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104650 (owner: 10EBernhardson) [20:14:22] (03CR) 10Jackmcbarn: "Just because it isn't used anywhere else, I don't think refactoring it is worthwhile." [core] - 10https://gerrit.wikimedia.org/r/104395 (owner: 10Jackmcbarn) [20:15:08] mayankmadan__, yes, the user could have been more verbose explaining why that was wrong. For what I can see, you should have added the template data at the end, out of , without any section header. I haven't checked the data itself [20:15:31] qgil so can i add it again [20:15:35] mayankmadan__, as Reedy says, the best thing is to ask directly whoever reverts your changes, in their Talk page [20:15:41] (03PS1) 1001tonythomas: Removed trailing whitespace from ParserCache.php [core] - 10https://gerrit.wikimedia.org/r/104655 [20:16:16] (03CR) 10Reedy: [V: 032] Revert "Replace usage of SpecialPage::getTitle with getPageTitle" [extensions/CentralAuth] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/104652 (owner: 10Reedy) [20:16:31] (03CR) 1001tonythomas: "Removed white space" [core] - 10https://gerrit.wikimedia.org/r/104541 (owner: 1001tonythomas) [20:16:43] mayankmadan__, sure, being careful of following the instructions and not breaking the current /doc page [20:17:24] (03PS1) 10Reedy: Switch to using 1.23wmf8 branch to gain revert [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/104656 [20:18:36] (03CR) 10Reedy: [C: 032 V: 032] Switch to using 1.23wmf8 branch to gain revert [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/104656 (owner: 10Reedy) [20:22:50] (03PS2) 10Siebrand: Removed trailing whitespace from ParserCache.php [core] - 10https://gerrit.wikimedia.org/r/104655 (owner: 1001tonythomas) [20:22:56] (03CR) 10Siebrand: [C: 032] Removed trailing whitespace from ParserCache.php [core] - 10https://gerrit.wikimedia.org/r/104655 (owner: 1001tonythomas) [20:24:12] awjr : (are you Arthur?) when must Mingle migration manifest? [20:25:35] (03CR) 10CSteipp: "Minor stuff, otherwise looks ok besides the todo for tracking nonces." (032 comments) [passport-mediawiki] - 10https://gerrit.wikimedia.org/r/103866 (owner: 10Milimetric) [20:31:01] manybubbles: https://www.ohloh.net/languages/visualbasic [20:31:03] I'm #4 [20:31:04] :/ [20:35:18] Nemo_bis: can I work on this one https://www.mediawiki.org/wiki/Help:Sysop_deleting_and_undeleting ? [20:36:31] Reedy: wow, I suppose [20:36:56] VladAndrew: yes but remember to discount the /ja units [20:37:09] (03PS6) 10Milimetric: Implementing mediawiki oauth for node [passport-mediawiki] - 10https://gerrit.wikimedia.org/r/103866 [20:37:44] Nemo_bis: sure thing, anyway I'll add 2 pages for the task and it will be far more than 120 [20:37:52] :) [20:38:32] (03CR) 10Milimetric: "Uploaded PS 6 which changes the example to use a multi-purpose example OAuth consumer. It also defaults to https for baseURL. Thanks Chr" (032 comments) [passport-mediawiki] - 10https://gerrit.wikimedia.org/r/103866 (owner: 10Milimetric) [20:38:34] Wikiedia -> Wikimedia [20:38:36] qgil: could you please take a look over this task, https://www.google-melange.com/gci/task/view/google/gci2013/5280653566279680 when you have time [20:38:37] Make MediaWiki documentation translatable #21 [20:38:38] Status: NeedsReview (3 days, 17 hours left) [20:38:38] Mentor(s): Guillaume Paumier [20:40:53] (03PS2) 10Matthias Mullie: Add error handling to contributions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102854 (owner: 10Werdna) [20:41:15] (03CR) 10Matthias Mullie: [C: 031] "Added warning" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102854 (owner: 10Werdna) [20:41:55] qgil: nevermind, now I saw that this task is different [20:43:01] (03CR) 10Matthias Mullie: [C: 032] BC for renamed actions in AbstractFormatter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102971 (owner: 10EBernhardson) [20:49:38] (03CR) 10Matthias Mullie: [C: 032] Avoid unexpected results by using unitless line-height [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103576 (owner: 10EBernhardson) [20:53:41] (03CR) 10Matthias Mullie: [C: 032] Prevent overflow of post content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103579 (owner: 10EBernhardson) [20:56:29] (03CR) 10Matthias Mullie: [C: 032] Provide test files to the UnitTestList hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103642 (owner: 10EBernhardson) [21:00:47] (03PS1) 10Jqnatividad: changed memcached server parsing to allow for local unix domain socket connections to local memcached (e.g. unix:///var/run/memcached/memcached.sock:0 ) noticeably increases memcached mediawiki performance [core] - 10https://gerrit.wikimedia.org/r/104663 [21:01:51] (03PS1) 10Umherirrender: Format functions in CacheTime [core] - 10https://gerrit.wikimedia.org/r/104664 [21:02:10] (03PS1) 10Chad: Organize code in CirrusSearch namespace [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104665 [21:02:30] theopolisme: Hey, you're working with us as part of GCI, right? [21:03:06] marktraceur: indeed I am :) [21:03:30] 'kay [21:03:39] theopolisme: Did you see tgr's comment about jquery.fullscreen? [21:04:25] marktraceur: recent? I'm not sure [21:04:26] (03CR) 10Matthias Mullie: [C: 031] "Looks good, but have not yet tested" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102972 (owner: 10EBernhardson) [21:04:30] 'kay [21:04:56] theopolisme: The gist is that we'd like you to us jquery.fullscreen to restore the fullscreen capability in MultimediaViewer [21:04:59] use* [21:05:05] If you have time/motivation for such a thing [21:05:26] We had disabled it because there were bugs in the resize code, I think it may be stable enough now [21:05:30] Well, I'm still waiting for the jquery.fullscreen patch to be merged [21:05:52] theopolisme: We won't be able to merge that without having a test case - doing MMV's integration would speed that up [21:07:58] Okay, that makes sense :) I'm actually traveling over the next week but if I have time I'd be happy to work on that -- and if not then, I can do it after GCI is over. Is there a bug report? [21:08:12] marktraceur: ^ [21:08:20] 'kay [21:08:32] theopolisme: No, it's just a thought in a comment on your patch [21:09:08] theopolisme: It should just consist of taking out the line that detaches the fullscreen button from the interface and replacing most of its click handler with a call to $.fullscreen [21:09:18] (03CR) 10EBernhardson: [C: 032] Crib some css from VE for empty external links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99520 (owner: 10EBernhardson) [21:11:53] (03PS7) 10MaxSem: Add new one-column diff mode [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/99541 [21:11:59] marktraceur: I'm currently working on some things for MobileFrontend but I'd be happy to work on that [21:13:03] 'kay, cool [21:13:13] theopolisme: If you have time this week, excellent, if not let me know [21:13:25] We'd like to get fullscreen workingish by next week [21:14:05] ooh deadlines ;) gotcha. I'll send myself an email to remember to take a look (might have time tonight) [21:14:26] 'kay, thanks [21:22:59] (03PS7) 10Milimetric: Implementing mediawiki oauth for node [passport-mediawiki] - 10https://gerrit.wikimedia.org/r/103866 [21:23:39] (03CR) 10EBernhardson: [C: 032] Add error handling to contributions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102854 (owner: 10Werdna) [21:25:21] (03Merged) 10jenkins-bot: Removed trailing whitespace from ParserCache.php [core] - 10https://gerrit.wikimedia.org/r/104655 (owner: 1001tonythomas) [21:28:26] (03Merged) 10jenkins-bot: BC for renamed actions in AbstractFormatter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102971 (owner: 10EBernhardson) [21:29:34] (03Merged) 10jenkins-bot: Avoid unexpected results by using unitless line-height [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103576 (owner: 10EBernhardson) [21:29:54] (03Merged) 10jenkins-bot: Prevent overflow of post content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103579 (owner: 10EBernhardson) [21:30:04] (03Merged) 10jenkins-bot: Provide test files to the UnitTestList hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103642 (owner: 10EBernhardson) [21:32:43] (03CR) 10EBernhardson: [C: 04-1] (bug 58376) white space in topic title appears in 'Comment on " title"' placeholder (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103545 (owner: 10Matthias Mullie) [21:32:58] (03Merged) 10jenkins-bot: Crib some css from VE for empty external links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99520 (owner: 10EBernhardson) [21:34:10] (03Merged) 10jenkins-bot: Add error handling to contributions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102854 (owner: 10Werdna) [21:36:24] (03PS2) 10EBernhardson: (bug 58376) white space in topic title appears in 'Comment on " title"' placeholder [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103545 (owner: 10Matthias Mullie) [21:36:37] (03CR) 10EBernhardson: [C: 032] (bug 58376) white space in topic title appears in 'Comment on " title"' placeholder [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103545 (owner: 10Matthias Mullie) [21:36:44] (03Merged) 10jenkins-bot: (bug 58376) white space in topic title appears in 'Comment on " title"' placeholder [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103545 (owner: 10Matthias Mullie) [21:37:40] (03CR) 10Anomie: Support ApiPageSet in ApiWatch (032 comments) [core] - 10https://gerrit.wikimedia.org/r/53964 (owner: 10Eranroz) [21:38:40] (03CR) 10Phuedx: [C: 031] "Apart from the question about lines 74 and 76, this looks good." (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103740 (owner: 10Mattflaschen) [21:46:00] (03PS2) 10Reedy: Added $purgeBlobs flag to LocalisationCacheRecache hook [core] - 10https://gerrit.wikimedia.org/r/104190 (owner: 10Aaron Schulz) [21:46:05] (03CR) 10Reedy: [C: 032] Added $purgeBlobs flag to LocalisationCacheRecache hook [core] - 10https://gerrit.wikimedia.org/r/104190 (owner: 10Aaron Schulz) [21:51:01] (03CR) 10jenkins-bot: [V: 04-1] Added $purgeBlobs flag to LocalisationCacheRecache hook [core] - 10https://gerrit.wikimedia.org/r/104190 (owner: 10Aaron Schulz) [21:51:28] https://integration.wikimedia.org/ci/job/mediawiki-core-lint/None/console : LOST [21:52:36] Aaron|home: Means Zuul got restarted probably [21:52:41] Try rebasing the patch [21:52:57] Or submitting a null change to the commit message or something [21:53:33] (03CR) 10Aaron Schulz: [V: 032] Added $purgeBlobs flag to LocalisationCacheRecache hook [core] - 10https://gerrit.wikimedia.org/r/104190 (owner: 10Aaron Schulz) [21:56:15] (03PS2) 10EBernhardson: No longer pass $permissionsUser in Templating [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102491 [21:56:25] (03CR) 10EBernhardson: "rebased" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102491 (owner: 10EBernhardson) [22:03:41] (03PS20) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [22:03:43] (03PS8) 10EBernhardson: base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 [22:03:45] (03PS10) 10EBernhardson: Convert UUID length 'magic' numbers to named constants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102584 [22:06:48] (03CR) 10Nuria: "Sorry, I thought I needed to create another patch. Diff is fixed here: https://gerrit.wikimedia.org/r/#/c/104509/" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/104040 (owner: 10Nuria) [22:08:11] (03PS11) 10EBernhardson: Convert UUID length 'magic' numbers to named constants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102584 [22:08:18] (03CR) 10EBernhardson: Convert UUID length 'magic' numbers to named constants (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102584 (owner: 10EBernhardson) [22:09:25] (03PS2) 10Chad: Organize code in CirrusSearch namespace [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104665 [22:11:09] (03PS21) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [22:11:15] (03PS1) 10Chad: Support FlaggedRevs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104675 [22:11:59] (03CR) 10Chad: "This might be totally wrong, I just wanted to get a proof of concept up to start discussion around." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104675 (owner: 10Chad) [22:15:48] (03CR) 10Parent5446: [C: 032] With mysqli, avoid setting the charset twice [core] - 10https://gerrit.wikimedia.org/r/104151 (owner: 10Aaron Schulz) [22:19:08] (03PS9) 10EBernhardson: base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 [22:21:04] (03CR) 10jenkins-bot: [V: 04-1] With mysqli, avoid setting the charset twice [core] - 10https://gerrit.wikimedia.org/r/104151 (owner: 10Aaron Schulz) [22:23:21] (03CR) 10Phuedx: "With reference to the error handling: passing the error on to the consumer with no (or little) modification makes sense for an API wrapper" (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103737 (owner: 10Mattflaschen) [22:29:30] ^d: Hi, allow me to introduce Fundraising's raddest new developer, pizzzacat. ^d: you have a minute to diagnose gerrit evilness? [22:30:06] <^d> what's evil? :) [22:30:20] (03CR) 10Parent5446: [C: 032] Define $showAll when special page is included [core] - 10https://gerrit.wikimedia.org/r/104449 (owner: 10Siebrand) [22:30:45] (03PS5) 10EBernhardson: Interface shows if someone has edited a post/topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103336 (owner: 10Bsitu) [22:31:16] (03CR) 10Parent5446: [C: 032] Replace usage of deprecated Title::escapeLocalURL() [core] - 10https://gerrit.wikimedia.org/r/104375 (owner: 10Siebrand) [22:31:31] (03CR) 10EBernhardson: [C: 032] "PS5: rebased" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103336 (owner: 10Bsitu) [22:31:38] (03Merged) 10jenkins-bot: Interface shows if someone has edited a post/topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103336 (owner: 10Bsitu) [22:33:01] ^d: sorry to be boring, but she totally kicked down the roadblock. Things are working great, thanks for asking! ;) [22:33:10] <^d> :) [22:33:29] oh, and hi! [22:33:50] (03PS4) 10EBernhardson: No-js css tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103763 [22:34:08] Raddest, eh? I thought you didn't start irradiation until the third month of employment. [22:34:11] pizzzacat: Are you a cat made out of pizza, or a pizza made out of cat? [22:36:05] (03CR) 10jenkins-bot: [V: 04-1] Define $showAll when special page is included [core] - 10https://gerrit.wikimedia.org/r/104449 (owner: 10Siebrand) [22:36:14] the former [22:36:36] (03CR) 10Parent5446: Maintenance script to salt existing unsalted passwords (032 comments) [core] - 10https://gerrit.wikimedia.org/r/104487 (owner: 10Legoktm) [22:37:29] (03CR) 10Siebrand: [C: 032] "Per Tyler's +2. Jenkins appears to have had a hiccup." [core] - 10https://gerrit.wikimedia.org/r/104449 (owner: 10Siebrand) [22:38:04] (03PS2) 10Nuria: Reverting changes to python schema.Adding test.Removing whitespace. Adding isset check for user agent for times in which this code is called outside a web context. Removing user agent from publisher before publishing event Change-Id: I0a95768fae7da6f51452 [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/104509 [22:39:52] (03PS1) 10MaxSem: Add primary coordinates to JS vars [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/104679 [22:40:10] (03CR) 10Siebrand: [C: 032] Format functions in CacheTime [core] - 10https://gerrit.wikimedia.org/r/104664 (owner: 10Umherirrender) [22:40:17] hi Nemo_bis , see the question at http://www.google-melange.com/gci/task/view/google/gci2013/5906673168285696 [22:40:20] Make MediaWiki documentation translatable #20 [22:40:21] Status: ClaimRequested [22:40:21] Mentor(s): Guillaume Paumier [22:42:01] qgil: we already discussed it, he can continue that super-huge page [22:42:07] (03CR) 10jenkins-bot: [V: 04-1] Replace usage of deprecated Title::escapeLocalURL() [core] - 10https://gerrit.wikimedia.org/r/104375 (owner: 10Siebrand) [22:43:13] hashar: What's going on here ? https://gerrit.wikimedia.org/r/#/c/104375/ https://integration.wikimedia.org/ci/job/mediawiki-core-lint/None/console : LOST [22:43:46] AaronSchulz: siebrand looking at that job [22:43:52] seems mediawiki-core-lint is broken [22:44:12] hashar: Okay. [22:46:00] (03CR) 10Kaldari: [C: 032] Add primary coordinates to JS vars [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/104679 (owner: 10MaxSem) [22:46:05] (03Merged) 10jenkins-bot: Add primary coordinates to JS vars [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/104679 (owner: 10MaxSem) [22:47:55] (03CR) 10Parent5446: Maintenance script for benchmarking parse operations (033 comments) [core] - 10https://gerrit.wikimedia.org/r/102596 (owner: 10Tim Starling) [22:47:59] ahhh [22:48:07] (03CR) 10jenkins-bot: [V: 04-1] Define $showAll when special page is included [core] - 10https://gerrit.wikimedia.org/r/104449 (owner: 10Siebrand) [22:48:28] FF************************ YAAAAA************* JENKINS (03CR) 10Bartosz Dziewoński: "Another thread about this appeared on en.wp just now: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Clickable_link_to_d" [core] - 10https://gerrit.wikimedia.org/r/63395 (owner: 10Jérémie Roquet) [22:48:58] * siebrand comforts hashar. [22:49:16] so mediawiki-core-lint reached 32000 builds [22:49:19] and failed after that [22:49:24] manybubbles: ^^^^ [22:49:43] hashar: seriously? [22:49:46] lol [22:49:50] not sure [22:49:55] but very likely [22:50:07] https://integration.wikimedia.org/ci/job/mediawiki-core-lint/ :D [22:50:08] I don't recall seeing that before [22:50:20] (03CR) 10Siebrand: "I'd make the default URL diff, and if you're really attached to DiffLink, you could add that, too." [core] - 10https://gerrit.wikimedia.org/r/63395 (owner: 10Jérémie Roquet) [22:50:28] yeah that sounds very dumb [22:50:38] disk space? [22:50:49] that is a round number but not a bitwise round number [22:50:54] ah [22:51:08] might be a limit to the number of entry a directory can have [22:51:17] hudson.util.IOException2: Failed to create a temporary file in /var/lib/jenkins/jobs/mediawiki-core-lint/builds/2013-12-30_22-50-51 [22:51:18] :D [22:51:35] so /var/lib/jenkins/jobs/mediawiki-core-lint/builds/ would have reached its limit [22:51:42] nice [22:51:51] bleh [22:51:54] that is why I am not a security expert [22:51:57] nor working in finance [22:51:58] :D [22:52:14] you don't want to loose million of dollars just because a directory is full [22:53:24] EXT3_LINK_MAX 32000 [22:53:44] ^d: afraid I am going to loose some history of our builds :-] [22:54:00] <^d> We'll live. [22:54:09] (03CR) 10jenkins-bot: [V: 04-1] Format functions in CacheTime [core] - 10https://gerrit.wikimedia.org/r/104664 (owner: 10Umherirrender) [22:54:12] :( [22:54:22] * greg-g librarian heart hurts ;) [22:54:30] why is there a cache of all builds? D: [22:54:42] <^d> So links to the old builds don't break. [22:54:46] Jenkins keep a log + artifacts of each builds [22:55:01] hashar: remind me to tell you about the time we deleted most of the 911 location records for a large Midwestern US state by accident. :-) [22:55:02] generating a directory to hold that + a symlink to it [22:55:09] ah. well, that's saner than i thought then [22:55:30] gotta put that in a more solid backend [22:55:32] like swift based [22:55:44] hashar: I've always configured that to only keep the last 10 or 20 builds. Except the release builds. We kept those forever. [22:55:54] in the meanwhile, publish a tarball of the logs soewhere? [22:56:37] manybubbles: yeah should rotate them to only keep X Days [23:02:31] (03PS1) 10Anomie: Move non-API release notes out of the API section [core] - 10https://gerrit.wikimedia.org/r/104684 [23:02:58] (03PS1) 10MaxSem: Update MobileFrontend to wmf8 tip [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/104685 [23:03:46] (03CR) 10Anomie: [C: 032] "As discussed in the MW Core meeting." [core] - 10https://gerrit.wikimedia.org/r/104684 (owner: 10Anomie) [23:04:35] Nemo_bis, thank you [23:06:18] robla: remember that performance goal from 2012 about how we were going to reduce parse times for featured articles by 75%? [23:06:34] http://tstarling.com/stuff/featured-parse-boxplot.png [23:07:02] the migration of citations to lua got us about 50% [23:07:44] AaronSchulz: siebrand mediawiki-core-lint job has been fixed. The directory holding its build history was full :/ [23:08:28] (03Merged) 10jenkins-bot: Move non-API release notes out of the API section [core] - 10https://gerrit.wikimedia.org/r/104684 (owner: 10Anomie) [23:11:28] hashar: Thanks for the fix. [23:11:53] siebrand: yeah one more time bomb I needed to fix but even exploded before I had time to fix it :( [23:12:40] (03CR) 10Siebrand: [C: 032] "@hashar gently cleaned up when the 32000 directory entries limit was reached... ;)" [core] - 10https://gerrit.wikimedia.org/r/104449 (owner: 10Siebrand) [23:14:15] (03CR) 10Siebrand: [C: 032] "Per Tyler. Jenkins is fixed now." [core] - 10https://gerrit.wikimedia.org/r/104375 (owner: 10Siebrand) [23:16:23] (03Merged) 10jenkins-bot: Define $showAll when special page is included [core] - 10https://gerrit.wikimedia.org/r/104449 (owner: 10Siebrand) [23:17:01] (03PS3) 10Aaron Schulz: With mysqli, avoid setting the charset twice [core] - 10https://gerrit.wikimedia.org/r/104151 [23:17:12] (03CR) 10Aaron Schulz: [C: 032] With mysqli, avoid setting the charset twice [core] - 10https://gerrit.wikimedia.org/r/104151 (owner: 10Aaron Schulz) [23:18:07] (03Merged) 10jenkins-bot: Replace usage of deprecated Title::escapeLocalURL() [core] - 10https://gerrit.wikimedia.org/r/104375 (owner: 10Siebrand) [23:21:10] beeeed [23:22:32] (03Merged) 10jenkins-bot: With mysqli, avoid setting the charset twice [core] - 10https://gerrit.wikimedia.org/r/104151 (owner: 10Aaron Schulz) [23:30:12] (03PS2) 10Siebrand: Maintenance script for benchmarking parse operations [core] - 10https://gerrit.wikimedia.org/r/102596 (owner: 10Tim Starling) [23:30:22] (03CR) 10Aaron Schulz: Support FlaggedRevs (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104675 (owner: 10Chad) [23:33:42] Reedy: not sure about the method names in 103619 [23:34:00] maybe it can be clearer that they are node-relative [23:34:39] (03CR) 10Siebrand: [C: 032] Format functions in CacheTime [core] - 10https://gerrit.wikimedia.org/r/104664 (owner: 10Umherirrender) [23:36:07] (03PS4) 10Bartosz Dziewoński: Add Special:Diff as an internally-linkable redirect to diff pages [core] - 10https://gerrit.wikimedia.org/r/63395 (owner: 10Jérémie Roquet) [23:38:03] (03CR) 10Bartosz Dziewoński: "Implemented what I said above." [core] - 10https://gerrit.wikimedia.org/r/63395 (owner: 10Jérémie Roquet) [23:38:24] (03CR) 10Siebrand: "This has a CR:+2, appears to be ready for merge, but wasn't merged. @ori, @matmarex, can you have a look?" [core] - 10https://gerrit.wikimedia.org/r/89379 (owner: 10Bartosz Dziewoński) [23:38:48] (03Merged) 10jenkins-bot: Format functions in CacheTime [core] - 10https://gerrit.wikimedia.org/r/104664 (owner: 10Umherirrender) [23:39:28] (03CR) 10Bartosz Dziewoński: "That was some jenkins failure. I'd prefer if at least a few of the changes from the stack here (approaching 20 changes now) were merged at" [core] - 10https://gerrit.wikimedia.org/r/89379 (owner: 10Bartosz Dziewoński) [23:41:00] (03CR) 10Parent5446: [C: 04-1] "See PS1" [core] - 10https://gerrit.wikimedia.org/r/102596 (owner: 10Tim Starling) [23:44:38] (03PS5) 10Bartosz Dziewoński: Add Special:Diff as an internally-linkable redirect to diff pages [core] - 10https://gerrit.wikimedia.org/r/63395 (owner: 10Jérémie Roquet) [23:45:38] (03CR) 10Bartosz Dziewoński: "Rebased and added release notes." [core] - 10https://gerrit.wikimedia.org/r/63395 (owner: 10Jérémie Roquet) [23:46:28] * robla catches up on backlog [23:51:07] TimStarling: interesting. there's no other template that would make the same sort of dent in the number that hasn't been converted, is there? [23:52:17] I was going to say {{convert}}, but it looks like it was migrated to Lua on December 11 [23:53:21] maybe that explains the slight dip in parse times from june to december in that graph [23:56:17] TimStarling: (you probably know, but there was a big mess around that conversion, many pages probably still use the wikitext version because some people are clearly insane) [23:57:21] heh, if https://www.mediawiki.org/wiki/Requests_for_comment/Removing_hit_counters_from_MediaWiki_core was code I'd be tempted to just merge it [23:57:26] (03PS6) 10Aaron Schulz: Added per-node sequential ID method and made SquidUpdate use it [core] - 10https://gerrit.wikimedia.org/r/103619 [23:57:40] Reedy: that should be obvious now :) [23:57:56] MatmaRex: no, I did not know that [23:57:57] (03CR) 10Siebrand: [C: 04-1] Add Special:Diff as an internally-linkable redirect to diff pages (032 comments) [core] - 10https://gerrit.wikimedia.org/r/63395 (owner: 10Jérémie Roquet) [23:58:13] Aaron|home, doncha you be tempting me:P [23:58:39] TimStarling: (also, it's supposedly still updating the transclusions lists and whatnot) [23:58:57] MaxSem: we could replace it with a few convenient hooks at most [23:59:00] (03PS18) 10AndyRussG: Let instructors and other roles add students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 [23:59:03] (or was a few days ago, if one is to believe the talk page) [23:59:21] thought one could probably make do with existing hooks just fine