[00:07:49] (03PS1) 10Aaron Schulz: Fixed silly regression with $job not being set in runJobs.php [core] - 10https://gerrit.wikimedia.org/r/104323 [00:08:16] (03CR) 10Aaron Schulz: [C: 032] Fixed silly regression with $job not being set in runJobs.php [core] - 10https://gerrit.wikimedia.org/r/104323 (owner: 10Aaron Schulz) [00:13:12] (03Merged) 10jenkins-bot: Fixed silly regression with $job not being set in runJobs.php [core] - 10https://gerrit.wikimedia.org/r/104323 (owner: 10Aaron Schulz) [01:36:26] (03PS4) 10Siebrand: [WIP] Update documentation for database related classes [core] - 10https://gerrit.wikimedia.org/r/103890 [08:48:12] (03CR) 10Nemo bis: "Hi, thanks for your first patch. It's easier to get someone to look at it if you follow the advice here: https://www.mediawiki.org/wiki/Ge" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/104208 (owner: 10Geek400) [09:07:01] (03PS6) 10TTO: Hide edit toolbar Signature button in content namespaces by default [core] - 10https://gerrit.wikimedia.org/r/87649 [09:47:54] (03CR) 10TTO: "Eranroz seems to have gone. I had a look at this but I don't really know what's going on, so I'll let someone else deal with it." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/53964 (owner: 10Eranroz) [10:06:06] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (033 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [10:14:14] (03PS1) 10Ori.livneh: Remove ProfilerSimple::getCpuTime [core] - 10https://gerrit.wikimedia.org/r/104326 [11:25:50] (03CR) 10Liangent: [C: 031] API: Include variant name in meta=siteinfo [core] - 10https://gerrit.wikimedia.org/r/104140 (owner: 10Anomie) [11:43:27] (03PS7) 10leucosticte: Add preferences checkbox to email text of watched deleted pages [core] - 10https://gerrit.wikimedia.org/r/101443 [11:52:36] (03PS1) 10Hashar: pywikibot-compat-pep8 is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104332 [11:52:45] (03CR) 10Hashar: [C: 032] pywikibot-compat-pep8 is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104332 (owner: 10Hashar) [11:52:50] (03Merged) 10jenkins-bot: pywikibot-compat-pep8 is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/104332 (owner: 10Hashar) [12:02:56] (03CR) 10Siebrand: "I think the API docs in this file have to be updated, and then we can merge." [core] - 10https://gerrit.wikimedia.org/r/104140 (owner: 10Anomie) [12:10:10] (03CR) 10Siebrand: [C: 04-1] "Needs release notes update" [core] - 10https://gerrit.wikimedia.org/r/104326 (owner: 10Ori.livneh) [12:11:12] (03PS1) 10Geek400: BookManagerv2: Clear cache when JSON file changes [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/104335 [12:11:17] (03PS1) 10Geek400: BookManagerv2: Clear cache when JSON file changes [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/104336 [12:11:18] (03CR) 10Siebrand: Remove ProfilerSimple::getCpuTime (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104326 (owner: 10Ori.livneh) [12:16:03] (03CR) 10Siebrand: [C: 04-2] "This commit should be squashed into https://gerrit.wikimedia.org/r/#/c/104208" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/104335 (owner: 10Geek400) [12:16:16] (03CR) 10Siebrand: [C: 04-2] "This commit should be squashed into https://gerrit.wikimedia.org/r/#/c/104208" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/104336 (owner: 10Geek400) [12:45:03] (03PS1) 10Merlijn van Deen: Add 'Browse projects' link to sidebar [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/104342 [13:00:18] (03CR) 10Aklapper: [C: 04-2] "Superseded by https://gerrit.wikimedia.org/r/#/c/104336" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/104208 (owner: 10Geek400) [13:04:42] (03CR) 10Aklapper: [C: 04-1] "So I need to revert my -2 as the code in this patch does need rework, and as 104336 does not supersede this patch at all. Please fix the c" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/104208 (owner: 10Geek400) [13:10:52] (03CR) 10Aklapper: [C: 031] "This is a very good idea, thanks! (and as it's a custom file anyway it would not interfere with porting to 4.4)" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/104342 (owner: 10Merlijn van Deen) [13:48:02] (03PS1) 10M4tx: Remove use of deprecated mwEditButtons property [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/104346 [14:18:21] (03CR) 10Siebrand: [C: 04-1] "I see that you're removing a deprecated function, but you're not replacing it per the recommendation, right?" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/104346 (owner: 10M4tx) [14:24:41] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/Comments] - 10https://gerrit.wikimedia.org/r/104347 [14:27:22] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/104349 [14:27:54] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/Editcount] - 10https://gerrit.wikimedia.org/r/104350 [14:28:49] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/104351 [14:29:42] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/104352 [14:31:18] (03PS2) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/104352 [14:31:32] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/ThemeDesigner] - 10https://gerrit.wikimedia.org/r/104353 [14:32:15] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/LogEntry] - 10https://gerrit.wikimedia.org/r/104354 [14:32:50] (03CR) 10Hoo man: [C: 032] Replace usage of deprecated Title::escapeLocalURL() [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/104352 (owner: 10Siebrand) [14:32:52] (03Merged) 10jenkins-bot: Replace usage of deprecated Title::escapeLocalURL() [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/104352 (owner: 10Siebrand) [14:48:41] (03CR) 10M4tx: "I just did what MatmaRex said in the bug report :)" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/104346 (owner: 10M4tx) [14:51:47] (03CR) 10Nikerabbit: Replace usage of deprecated Title::escapeLocalURL() (032 comments) [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/104352 (owner: 10Siebrand) [14:52:40] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/skins] - 10https://gerrit.wikimedia.org/r/104356 [14:55:01] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/104358 [14:56:02] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/ProtectSite] - 10https://gerrit.wikimedia.org/r/104359 [14:56:36] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/104360 [14:57:19] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/ScanSet] - 10https://gerrit.wikimedia.org/r/104361 [15:07:14] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/104362 [15:07:51] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/104363 [15:08:47] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/104364 [15:09:21] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/104365 [15:09:50] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/Video] - 10https://gerrit.wikimedia.org/r/104366 [15:10:27] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/PrivateDomains] - 10https://gerrit.wikimedia.org/r/104367 [15:11:47] (03PS2) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/104364 [15:12:07] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/104368 [15:15:44] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/UnicodeConverter] - 10https://gerrit.wikimedia.org/r/104370 [15:16:27] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/UploadLocal] - 10https://gerrit.wikimedia.org/r/104371 [15:18:11] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/104372 [15:18:36] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/104373 [15:21:28] (03PS5) 10Siebrand: [WIP] Update documentation for database related classes [core] - 10https://gerrit.wikimedia.org/r/103890 [15:22:42] (03PS1) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [core] - 10https://gerrit.wikimedia.org/r/104375 [15:24:01] For those that want to increase their merge count just before the end of the year... Some easy reviews at https://gerrit.wikimedia.org/r/#/q/status:open+topic:replace-deprecated,n,z . ktxbye ;) [15:30:53] (03PS2) 10Siebrand: Replace usage of deprecated Title::escapeLocalURL() [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/104362 [15:32:39] (03PS1) 10AalekhN: Added fiji hindi localition to the english text present in the example.i18n.php file. [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/104377 [15:34:22] (03CR) 10Physikerwelt: [C: 032 V: 032] Replace usage of deprecated Title::escapeLocalURL() [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/104373 (owner: 10Siebrand) [16:11:30] (03CR) 10Gergő Tisza: [C: 031] add templatedata api check [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/104319 (owner: 10Dan-nl) [16:45:13] (03PS1) 10Siebrand: Replace deprecated SpecialPage::resolveAlias() [extensions/URNames] - 10https://gerrit.wikimedia.org/r/104379 [16:50:10] (03PS1) 10Siebrand: Replace deprecated SpecialPage::resolveAlias() [extensions/ShoutWikiAds] - 10https://gerrit.wikimedia.org/r/104380 [16:54:08] (03PS1) 10Gerrit Patch Uploader: mediawiki.action.edit.collapsibleFooter.js use $.cookie() [core] - 10https://gerrit.wikimedia.org/r/104381 [16:54:09] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/104381 (owner: 10Gerrit Patch Uploader) [17:06:22] Nemo_bis: thanks for the help with that page [17:11:29] (03PS1) 10Hoo man: Remove two wikidata specific messages per I7d7d8a9 [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/104383 [17:15:23] (03PS1) 10Siebrand: Replace deprecated SpecialPage::resolveAlias() [extensions/SkinPerNamespace] - 10https://gerrit.wikimedia.org/r/104384 [17:15:41] (03PS2) 10Siebrand: Replace deprecated SpecialPage::resolveAliasWithSubpage() [extensions/SkinPerNamespace] - 10https://gerrit.wikimedia.org/r/104384 [17:20:13] (03PS1) 10Siebrand: Replace deprecated SpecialPage::getPage() [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/104385 [17:21:50] (03PS1) 10Siebrand: Replace deprecated SpecialPage::getPage() [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/104387 [17:22:15] (03PS2) 10Siebrand: Replace deprecated SpecialPage::getPage() [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/104387 [17:27:28] (03PS1) 10Siebrand: Replace deprecated SpecialPage::executePath() [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/104389 [17:41:55] (03PS1) 10Aude: Fix string concatenation in api documentation [core] - 10https://gerrit.wikimedia.org/r/104391 [17:52:47] (03CR) 10Hoo man: [C: 032] Fix string concatenation in api documentation [core] - 10https://gerrit.wikimedia.org/r/104391 (owner: 10Aude) [17:55:10] (03PS1) 10Siebrand: Replace deprecated SpecialPage::includable() [extensions/ApiExplorer] - 10https://gerrit.wikimedia.org/r/104392 [17:56:00] (03Merged) 10jenkins-bot: Fix string concatenation in api documentation [core] - 10https://gerrit.wikimedia.org/r/104391 (owner: 10Aude) [17:57:08] (03PS1) 10Siebrand: Replace deprecated SpecialPage::getLang() [extensions/Configure] - 10https://gerrit.wikimedia.org/r/104393 [17:57:40] (03PS2) 10Siebrand: Replace deprecated SpecialPage::getLang() [extensions/Configure] - 10https://gerrit.wikimedia.org/r/104393 [17:57:52] (03PS1) 10Siebrand: Replace deprecated SpecialPage::getLang() [extensions/Video] - 10https://gerrit.wikimedia.org/r/104394 [18:07:33] Any tips on strategies to identify uses of SpecialPage::__call? PHPStorm says no uses, but that's not reassuring in this case. [18:11:40] is Guillaume Paumier or Quim Gil online ? [18:12:57] (03PS1) 10Jackmcbarn: Allow hiding redirects in Special:ProtectedPages [core] - 10https://gerrit.wikimedia.org/r/104395 [18:17:43] VladAndrew: guillom is here. qgil is not. [18:18:57] (03CR) 10Raimond Spekking: [C: 032] Remove two wikidata specific messages per I7d7d8a9 [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/104383 (owner: 10Hoo man) [18:19:01] (03Merged) 10jenkins-bot: Remove two wikidata specific messages per I7d7d8a9 [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/104383 (owner: 10Hoo man) [18:20:48] guillom: Hey, when you have time, could you check this task https://www.google-melange.com/gci/task/view/google/gci2013/5874379107860480 ? [18:20:49] Make MediaWiki documentation translatable #11 [18:20:49] Status: NeedsReview (3 days, 15 hours left) [18:20:49] Mentor(s): Guillaume Paumier, Quim Gil [18:24:03] VladAndrew: I hadn't seen your message, but I just reviewed it :) [18:25:17] guillom: thanks [18:29:15] (03PS1) 10Siebrand: Remove methods from SpecialPage deprecated in 1.17 and 1.18 [core] - 10https://gerrit.wikimedia.org/r/104396 [18:32:35] (03CR) 10Bartosz Dziewoński: [C: 032] "Whoopsie." [core] - 10https://gerrit.wikimedia.org/r/104381 (owner: 10Gerrit Patch Uploader) [18:34:47] [18:35:48] (03Merged) 10jenkins-bot: mediawiki.action.edit.collapsibleFooter.js use $.cookie() [core] - 10https://gerrit.wikimedia.org/r/104381 (owner: 10Gerrit Patch Uploader) [18:36:17] siebrand: Yeah, it's some magical thing for PHP4, I assume it gets called automatically [18:47:26] MatmaRex: Are you busy? [18:48:13] Does anyone know who would be the go to guy for recoding FlaggedRevs to work in Template: would be? [18:49:14] umm? [18:49:22] flaggedrevs work in the template namespace [18:50:10] Technical_13: ^ [18:50:23] Not yet. [18:50:41] https://en.wikipedia.org/wiki/User:TheOriginalSoni/sandbox5 and discussion in #wikipedia-en-help [18:50:53] err.. #wikipedia-en-helpers [18:50:59] define 'not work', then [18:51:07] marktraceur: I removed it, but I can't prove there's nothing that uses it... [18:51:07] we're using it for the template namespace at pl.wp [18:51:17] siebrand: Yeah, that sounds dangerous [18:51:28] It gets called when a called function doesn't exist [18:51:37] hmm [18:51:41] They want to apply a blanket PC1 to all Template: pages [18:52:07] I'm trying to tell them that is a really bad idea on many levels. [18:52:07] We've had developer warnings on at twn since forever, and I've never seen one for this, I think. [18:53:23] Technical_13: PC1? [18:53:34] Pending Changes [18:53:36] siebrand: hey, have you seen the reply on https://gerrit.wikimedia.org/r/#/c/104346/1 ? [18:54:01] siebrand: the window.mwEditButtons variable is not used by core at all, apart from being deprecated [18:54:09] Technical_13: why would that be a bad idea? [18:54:13] MatmaRex: k. Just go ahead and merge it, then. [18:54:42] (03CR) 10Bartosz Dziewoński: [C: 032] Remove use of deprecated mwEditButtons property [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/104346 (owner: 10M4tx) [18:54:48] (03Merged) 10jenkins-bot: Remove use of deprecated mwEditButtons property [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/104346 (owner: 10M4tx) [18:55:58] Because it is required to have throughly tested their edit in the sandbox and testcases page before requesting an edit be made to a main template. If there is PC1 on the sandbox and testcases, they need to wait for that to be approved and see what happens before they can make the next edit... Making edits to sandboxes sometime take dozens of trial and error attempts (which is why we use sandboxes) and that could take months or years f [18:56:17] really bad idea. [18:56:57] It also prevents new users from creating a template because they would be unable to edit it and learn about transclusion and all of the other technical aspects. [18:57:00] ah. yeah, that would be silly [18:57:30] but, well, /sandbox subpages are pretty silly themselves [18:57:48] especially now that we have a "preview that article with this wikitext as template" feature [18:58:10] (special:templatesandbox or that little fieldset below edit form) [18:58:16] Doesn't work for me, and I don't even see that option if not logged in. [18:58:30] it definitely works, you must have used it wrong. [18:59:01] The more important part is it doesn't even show the option when I'm not logged in. [18:59:26] (03CR) 10Helder.wiki: Remove use of deprecated mwEditButtons property (031 comment) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/104346 (owner: 10M4tx) [19:01:19] Technical_13: it shows that field when you're not logged in. [19:01:34] maybe it's hidden with custom CSS [19:01:39] en.wp sure loves to disable awesome new features with CSS [19:01:46] Then there is something funky on my end. [19:01:51] could be [19:01:58] Haven't dug too deep into it. [19:02:05] (03PS1) 10Aude: Restore wikidata-copyright message... still needed [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/104398 [19:05:56] (03PS1) 10Physikerwelt: Quick hack to export MathTable to db2 [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/104400 [19:07:39] (03CR) 10Physikerwelt: [C: 032 V: 032] Quick hack to export MathTable to db2 [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/104400 (owner: 10Physikerwelt) [19:11:04] (03PS1) 10Manybubbles: Only hook nearmatch if cirrus is enabled [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104402 [19:12:01] (03CR) 10Raimond Spekking: [C: 032] Restore wikidata-copyright message... still needed [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/104398 (owner: 10Aude) [19:12:03] (03Merged) 10jenkins-bot: Restore wikidata-copyright message... still needed [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/104398 (owner: 10Aude) [19:13:30] basile: when you have time, I would like to work on this task https://www.google-melange.com/gci/task/view/google/gci2013/5890940501753856 [19:13:31] Make MediaWiki documentation translatable #09 [19:13:31] Status: ClaimRequested [19:13:31] Mentor(s): Guillaume Paumier, Quim Gil [19:14:03] VladAndrew: you can start working on it before being accepted :) [19:14:17] done [19:14:27] And now I'm really away :) [19:14:28] Thanks, I'll start right away [19:14:30] too fast :P [19:14:49] Nemo_bis: I once worked at more than one task at once [19:14:53] I got a few of them deleted [19:14:56] =)) [19:15:06] deleted? O_o [19:15:24] not one of these i18n/translation tasks though? [19:15:32] not this type [19:16:05] these are not going to be deleted nor anyone will steal you all the available pages ;) [19:16:32] Nemo_bis: then I'm starting to work on them [19:18:01] sure [19:18:19] (03PS1) 10Tpt: Add redlink=1 to previous and next page links if needed [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/104403 [19:18:40] Nemo_bis: there's one task where it seems that other Wikimedians have contributed translations to a page a GCI student was working on, so the stats are off and I'm not sure what to do: see https://www.google-melange.com/gci/task/view/google/gci2013/5776314803945472 and https://www.mediawiki.org/w/index.php?title=Differences_between_Wikipedia,_Wikimedia,_MediaWiki,_and_wiki/fr&action=history ; if you coujd take a look when you have time, it [19:18:40] would be great :) [19:18:41] Make MediaWiki documentation translatable [19:18:41] Status: NeedsReview (2 days, 17 hours left) [19:18:41] Mentor(s): Guillaume Paumier, Quim Gil [19:19:11] basile: you said you were away for real! go away! :P [19:19:26] :P [19:19:50] (03CR) 10Chad: [C: 032 V: 032] Squash master to REL1_22 [extensions/Elastica] (REL1_22) - 10https://gerrit.wikimedia.org/r/104179 (owner: 10Manybubbles) [19:19:55] (03CR) 10Chad: [C: 032 V: 032] Squash master to REL1_22 + compatibility patches [extensions/CirrusSearch] (REL1_22) - 10https://gerrit.wikimedia.org/r/104178 (owner: 10Manybubbles) [19:20:30] (03CR) 10Chad: [C: 032] Update documentation for QueryPage::execute() [core] - 10https://gerrit.wikimedia.org/r/104053 (owner: 10Siebrand) [19:20:44] (03PS1) 10Siebrand: Update documentation for SpecialPage and SpecialPageFactory [core] - 10https://gerrit.wikimedia.org/r/104404 [19:21:12] (03PS2) 10Siebrand: Update documentation for SpecialPage and SpecialPageFactory [core] - 10https://gerrit.wikimedia.org/r/104404 [19:21:22] (03CR) 10Chad: [C: 032] Declare visibility for class properties in DatabaseUtility.php [core] - 10https://gerrit.wikimedia.org/r/103873 (owner: 10Siebrand) [19:22:27] (03CR) 10Chad: [C: 032] Declare visibility for class properties in DatabaseMssql [core] - 10https://gerrit.wikimedia.org/r/103879 (owner: 10Siebrand) [19:23:31] (03CR) 10Chad: Throw exception for unknown field in SpecialListfiles::formatValue() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104058 (owner: 10Siebrand) [19:23:49] (03CR) 10Chad: [C: 032] Update documentation for ApiQueryWatchlist::parseRCType() [core] - 10https://gerrit.wikimedia.org/r/104054 (owner: 10Siebrand) [19:24:13] Nemo_bis: should things like this be translated [[Special:NewPages]] ? [19:24:29] I see that these are translated in other languages too [19:24:38] (03CR) 10Chad: [C: 032] Only hook nearmatch if cirrus is enabled [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104402 (owner: 10Manybubbles) [19:24:49] (03Merged) 10jenkins-bot: Only hook nearmatch if cirrus is enabled [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104402 (owner: 10Manybubbles) [19:25:21] (03Merged) 10jenkins-bot: Update documentation for QueryPage::execute() [core] - 10https://gerrit.wikimedia.org/r/104053 (owner: 10Siebrand) [19:25:35] (03CR) 10Siebrand: Throw exception for unknown field in SpecialListfiles::formatValue() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104058 (owner: 10Siebrand) [19:28:50] (03Merged) 10jenkins-bot: Declare visibility for class properties in DatabaseUtility.php [core] - 10https://gerrit.wikimedia.org/r/103873 (owner: 10Siebrand) [19:29:00] VladAndrew: the links you mean? [19:29:53] (03CR) 10Chad: [C: 032] Prioritize single page edits over template changes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104124 (owner: 10Manybubbles) [19:30:02] yes [19:30:05] they are different [19:30:08] in other languages [19:30:37] (03Merged) 10jenkins-bot: Declare visibility for class properties in DatabaseMssql [core] - 10https://gerrit.wikimedia.org/r/103879 (owner: 10Siebrand) [19:30:56] (03PS3) 10Siebrand: Throw exception for unknown field in SpecialListfiles::formatValue() [core] - 10https://gerrit.wikimedia.org/r/104058 [19:31:37] in polsky for example it is Spesial:Nye sider [19:31:52] (03Merged) 10jenkins-bot: Prioritize single page edits over template changes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104124 (owner: 10Manybubbles) [19:32:33] (03Merged) 10jenkins-bot: Update documentation for ApiQueryWatchlist::parseRCType() [core] - 10https://gerrit.wikimedia.org/r/104054 (owner: 10Siebrand) [19:32:50] (03PS1) 10Siebrand: Define $showAll when special page is included [core] - 10https://gerrit.wikimedia.org/r/104449 [19:33:02] Nemo_bis: it seems that all of them point to the same link but it has a different text [19:33:23] (03PS2) 10Siebrand: Define $showAll when special page is included [core] - 10https://gerrit.wikimedia.org/r/104449 [19:38:08] VladAndrew: the special pages names' are translated in all languages, however in each wiki only two languages work: the wiki's language and English [19:38:21] (03CR) 10Andrew Bogott: Initial fixes for cross-regional support (031 comment) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/104129 (owner: 10Ryan Lane) [19:38:59] VladAndrew: so usually the links to special pages are left in English and sometimes they're red nonetheless because they come from some extension that's not installed on mediawiki.org [19:39:45] we've not yet come up with a real/standard solution for this I'm afraid, I'd avoid translating the names though because there's no automatic way to ensure they are the actual translations [19:45:47] Nemo_bis: I have removed the translation from the links and striked the page name on the list, what do you think ?https://www.mediawiki.org/wiki/Help:Tracking_changes [19:46:12] (03CR) 10Hoo man: Add mw.html to Scribunto (0311 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man) [19:46:28] (03PS6) 10Hoo man: Add mw.html to Scribunto [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 [19:48:07] (03CR) 10Hoo man: "Addressed Anomie's comments (thanks for the review)." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man) [19:55:13] (03CR) 10TheDJ: [C: 04-1] Basic support for WebP (034 comments) [core] - 10https://gerrit.wikimedia.org/r/95872 (owner: 10btongminh) [19:55:43] (03PS5) 10TheDJ: Basic support for WebP [core] - 10https://gerrit.wikimedia.org/r/95872 (owner: 10btongminh) [20:01:21] * aude rages about phpunit failures [20:01:33] https://bugzilla.wikimedia.org/show_bug.cgi?id=59105 [20:03:03] (03PS6) 10TheDJ: Basic support for WebP [core] - 10https://gerrit.wikimedia.org/r/95872 (owner: 10btongminh) [20:03:46] is an empty valid code or a non-supported hack? [20:05:09] (03PS7) 10TheDJ: Basic support for WebP [core] - 10https://gerrit.wikimedia.org/r/95872 (owner: 10btongminh) [20:05:54] (03CR) 10TheDJ: "I've made some changes:" [core] - 10https://gerrit.wikimedia.org/r/95872 (owner: 10btongminh) [20:09:50] (03CR) 10Aude: "just want to note the phpunit failures which occur since this patch got merged and only when running *all* the tests. (bug 59105)" [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [20:10:57] (03CR) 10Parent5446: "One question" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104058 (owner: 10Siebrand) [20:11:39] (03PS1) 10Anomie: Fix more concatenation errors [core] - 10https://gerrit.wikimedia.org/r/104469 [20:13:01] (03CR) 10Siebrand: Throw exception for unknown field in SpecialListfiles::formatValue() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104058 (owner: 10Siebrand) [20:14:30] (03CR) 10Parent5446: Remove methods from SpecialPage deprecated in 1.17 and 1.18 (032 comments) [core] - 10https://gerrit.wikimedia.org/r/104396 (owner: 10Siebrand) [20:15:04] (03CR) 10Anomie: Fix CodeSniffer errors and warnings on some API classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95381 (owner: 10Siebrand) [20:15:07] (03CR) 10Anomie: Fix CodeSniffer errors and warnings on a number of ApiQuery classes (033 comments) [core] - 10https://gerrit.wikimedia.org/r/95455 (owner: 10Siebrand) [20:16:13] (03CR) 10Siebrand: Remove methods from SpecialPage deprecated in 1.17 and 1.18 (032 comments) [core] - 10https://gerrit.wikimedia.org/r/104396 (owner: 10Siebrand) [20:16:38] (03CR) 10Hoo man: [C: 032] "trivial one" [core] - 10https://gerrit.wikimedia.org/r/104469 (owner: 10Anomie) [20:16:55] (03CR) 10Siebrand: Fix CodeSniffer errors and warnings on a number of ApiQuery classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95455 (owner: 10Siebrand) [20:17:23] (03CR) 10Siebrand: Fix CodeSniffer errors and warnings on some API classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95381 (owner: 10Siebrand) [20:19:14] (03CR) 10Parent5446: Update documentation for SpecialPage and SpecialPageFactory (033 comments) [core] - 10https://gerrit.wikimedia.org/r/104404 (owner: 10Siebrand) [20:21:10] (03CR) 10Parent5446: Remove methods from SpecialPage deprecated in 1.17 and 1.18 (032 comments) [core] - 10https://gerrit.wikimedia.org/r/104396 (owner: 10Siebrand) [20:32:01] (03PS4) 10Siebrand: Throw exception for unknown field in SpecialListfiles::formatValue() [core] - 10https://gerrit.wikimedia.org/r/104058 [20:33:18] (03CR) 10Siebrand: Throw exception for unknown field in SpecialListfiles::formatValue() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104058 (owner: 10Siebrand) [20:35:48] (03CR) 10jenkins-bot: [V: 04-1] Basic support for WebP [core] - 10https://gerrit.wikimedia.org/r/95872 (owner: 10btongminh) [20:42:04] hey Nemo_bis, when I was subscribing some language lists [20:42:09] i forgot to specift language 0_o [20:42:11] (03Merged) 10jenkins-bot: Fix more concatenation errors [core] - 10https://gerrit.wikimedia.org/r/104469 (owner: 10Anomie) [20:42:40] GEOFBOT: ok, it's not a tragedy [20:42:44] should I subscribe twice? :P [20:42:47] (03CR) 10Parent5446: Add extra views (tabs) for files in a foreign repository (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104182 (owner: 10TTO) [20:42:54] GEOFBOT: no [20:42:58] ok [20:43:32] (03CR) 10Siebrand: "All comments addressed in the next PS." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/104404 (owner: 10Siebrand) [20:43:56] (03PS3) 10Siebrand: Update documentation for SpecialPage and SpecialPageFactory [core] - 10https://gerrit.wikimedia.org/r/104404 [20:46:31] Nemo_bis, would https://lists.wikimedia.org/mailman/listinfo/wmfcc-l count as a public list? [20:46:35] seems kind of private [20:46:39] members only [20:47:05] no, that one is private [20:47:19] ok [20:47:25] so if it says members only it is privatE? [20:47:59] you mean "The current archive is only available to the list members" ? yes [20:53:24] (03PS1) 10Jqnatividad: added $edgSuppressNoLocalVarMsg flag; added MongoDB memcached support; removed deprecated MongoDB slaveOkay flag; refactored collection exists logic; added isset check to suppress PHP Notice in apache error log [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/104472 [20:56:04] (03CR) 10Siebrand: Remove methods from SpecialPage deprecated in 1.17 and 1.18 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104396 (owner: 10Siebrand) [21:02:17] (03CR) 10Siebrand: "Is there a bugzilla issue related to this change?" [core] - 10https://gerrit.wikimedia.org/r/104395 (owner: 10Jackmcbarn) [21:02:58] (03PS1) 10Aude: Avoid interacting with LBFactory singleton in tests [core] - 10https://gerrit.wikimedia.org/r/104473 [21:04:28] (03PS14) 10Eranroz: Support ApiPageSet in ApiWatch [core] - 10https://gerrit.wikimedia.org/r/53964 [21:05:09] (03CR) 10jenkins-bot: [V: 04-1] Support ApiPageSet in ApiWatch [core] - 10https://gerrit.wikimedia.org/r/53964 (owner: 10Eranroz) [21:06:26] (03CR) 10Jackmcbarn: "Not that I know of." [core] - 10https://gerrit.wikimedia.org/r/104395 (owner: 10Jackmcbarn) [21:06:55] (03CR) 10Yaron Koren: "What's the reason for the delightfully-named $edgSuppressNoLocalVarMsg variable? Why not always show a message if the relevant variable wa" [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/104472 (owner: 10Jqnatividad) [21:06:57] (03CR) 10jenkins-bot: [V: 04-1] Avoid interacting with LBFactory singleton in tests [core] - 10https://gerrit.wikimedia.org/r/104473 (owner: 10Aude) [21:07:41] :( [21:08:08] doh [21:09:27] (03PS2) 10Aude: Avoid interacting with LBFactory singleton in tests [core] - 10https://gerrit.wikimedia.org/r/104473 [21:09:56] (03CR) 10Siebrand: "Thanks for clarifying. I thought there might have been :)." [core] - 10https://gerrit.wikimedia.org/r/104395 (owner: 10Jackmcbarn) [21:12:47] (03CR) 10jenkins-bot: [V: 04-1] Avoid interacting with LBFactory singleton in tests [core] - 10https://gerrit.wikimedia.org/r/104473 (owner: 10Aude) [21:13:01] :( [21:14:11] (03CR) 10Parent5446: "OK, finally got my dev environment working so I can test this. Overall I like it. Definitely a good idea." [core] - 10https://gerrit.wikimedia.org/r/104182 (owner: 10TTO) [21:15:41] (03PS15) 10Eranroz: Support ApiPageSet in ApiWatch [core] - 10https://gerrit.wikimedia.org/r/53964 [21:16:41] (03PS3) 10Aude: Avoid interacting with LBFactory singleton in tests [core] - 10https://gerrit.wikimedia.org/r/104473 [21:17:16] (03CR) 10Eranroz: Support ApiPageSet in ApiWatch (031 comment) [core] - 10https://gerrit.wikimedia.org/r/53964 (owner: 10Eranroz) [21:20:10] (03PS1) 10Aaron Schulz: Merged redis queue periodic tasks into recyclePruneAndUndelayJobs() [core] - 10https://gerrit.wikimedia.org/r/104475 [21:20:16] (03CR) 10Jqnatividad: "Its more of a backward-compatibility fix. Right now, a lot of out templates presume that ED will return a null if there is no local var." [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/104472 (owner: 10Jqnatividad) [21:21:18] (03PS2) 10Parent5446: Remove methods from SpecialPage deprecated in 1.17 and 1.18 [core] - 10https://gerrit.wikimedia.org/r/104396 (owner: 10Siebrand) [21:45:02] (03PS1) 10Aaron Schulz: Fixed locking in JobQueueAggregatorRedis [core] - 10https://gerrit.wikimedia.org/r/104478 [21:49:32] http://streaming.media.ccc.de/saal1/native/hq/ - https://en.wikipedia.org/wiki/Sarah_Harrison_%28journalist%29 and Assange speaking at CCC [21:56:58] (03CR) 10Parent5446: Avoid interacting with LBFactory singleton in tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104473 (owner: 10Aude) [22:04:25] (03CR) 10Aude: Avoid interacting with LBFactory singleton in tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104473 (owner: 10Aude) [22:14:34] (03PS7) 10Hoo man: Add mw.html to Scribunto [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 [22:15:41] (03CR) 10Hoo man: "Fix behaviour for empty tag names" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man) [22:22:44] (03PS1) 10Aaron Schulz: Fixed backwards JobQueueFederated::doIsEmpty() method [core] - 10https://gerrit.wikimedia.org/r/104479 [22:23:49] (03PS1) 10Aaron Schulz: Fixed backwards JobQueueFederated::doIsEmpty() method [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/104480 [22:24:33] (03CR) 10Aaron Schulz: [C: 032] Fixed backwards JobQueueFederated::doIsEmpty() method [core] - 10https://gerrit.wikimedia.org/r/104479 (owner: 10Aaron Schulz) [22:24:49] (03CR) 10Aaron Schulz: [C: 032] Fixed backwards JobQueueFederated::doIsEmpty() method [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/104480 (owner: 10Aaron Schulz) [22:31:54] (03Merged) 10jenkins-bot: Fixed backwards JobQueueFederated::doIsEmpty() method [core] - 10https://gerrit.wikimedia.org/r/104479 (owner: 10Aaron Schulz) [22:32:00] (03Merged) 10jenkins-bot: Fixed backwards JobQueueFederated::doIsEmpty() method [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/104480 (owner: 10Aaron Schulz) [22:39:35] (03PS1) 10Rudolf.grossmann: Add license info file for GPL2+ [extensions/GeoGebra] - 10https://gerrit.wikimedia.org/r/104481 [22:59:43] (03PS2) 10Aaron Schulz: Fixed locking in JobQueueAggregatorRedis [core] - 10https://gerrit.wikimedia.org/r/104478 [23:27:40] (03PS4) 10Aude: Avoid interacting with LBFactory singleton in tests [core] - 10https://gerrit.wikimedia.org/r/104473 [23:29:37] (03PS5) 10Aude: Avoid interacting with LBFactory singleton in tests [core] - 10https://gerrit.wikimedia.org/r/104473 [23:31:25] (03CR) 10Freakolowsky: [C: 031] Declare visibility for class properties in DatabaseOracle.php [core] - 10https://gerrit.wikimedia.org/r/103877 (owner: 10Siebrand) [23:36:24] Nemo_bis: I wanted to add wikimedia-commits to gmane when I found out it didn't exist? [23:37:37] yep, it was merged to mediawiki-commits I think [23:37:51] just ignore it [23:40:57] oh, ok [23:42:15] Nemo_bis: do i need to subscribe the dead mailing lists? [23:42:56] GEOFBOT: dead in what way? [23:43:37] Nemo_bis: "defunct" [23:43:43] according to the metapage [23:44:19] no [23:44:44] ok [23:44:53] I think I've subbed all the ones on the meta page [23:45:11] great :) now begins hide and seek :P [23:50:39] (03CR) 10Yaron Koren: "Alright, that makes sense. I thought about it, though, and I think a better solution is adding a 2nd, optional parameter to #external_valu" [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/104472 (owner: 10Jqnatividad) [23:52:58] (03CR) 10Tim Starling: Maintenance script for benchmarking parse operations (039 comments) [core] - 10https://gerrit.wikimedia.org/r/102596 (owner: 10Tim Starling) [23:58:29] (03CR) 10Chad: [C: 032] Declare visibility for class properties in DatabaseOracle.php [core] - 10https://gerrit.wikimedia.org/r/103877 (owner: 10Siebrand) [23:59:45] (03PS1) 10Andrew Bogott: Start using instance fqdn for the page url rather than just ec2 id. [openstack-wikistatus] - 10https://gerrit.wikimedia.org/r/104484