[00:11:07] <grrrit-wm>	 (03PS1) 10Siebrand: Declare visibility for class properties in DatabaseUtility.php [core] - 10https://gerrit.wikimedia.org/r/103873 
[00:11:08] <grrrit-wm>	 (03PS1) 10Siebrand: Declare visibility for class properties in DatabaseSqlite [core] - 10https://gerrit.wikimedia.org/r/103874 
[00:11:09] <grrrit-wm>	 (03PS1) 10Siebrand: Declare visibility for class properties in DatabasePostgres.php [core] - 10https://gerrit.wikimedia.org/r/103875 
[00:21:39] <grrrit-wm>	 (03PS8) 10Gergő Tisza: Add blacklisting feature for flickr in backend [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22)
[00:23:03] <grrrit-wm>	 (03CR) 10Gergő Tisza: "Added another API mode to get the full blacklist at once." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22)
[00:29:10] <yurik>	 ori, hi, what caused you to introduce locking into the schema? wasn't the api call cached by varnish as well?
[00:29:23] <yurik>	 i'm implementing poolcounter for it
[00:35:43] <ori>	 yurik: introduce locking into what schema?
[00:36:31] <yurik>	 ori, you have locking to prevent simultaneous db hit when lots of different appaches decide to use the same schema
[00:38:09] <ori>	 yurik: to avoid a cache stampede
[00:38:50] <yurik>	 ori, yes, so MaxSem has proposed that we use poolconter instead of silently failing
[00:39:06] <ori>	 for EL or zero or what?
[00:39:11] <yurik>	 and now i'm thinking if varnish servers should be ok to handle that stampee
[00:39:43] <yurik>	 ori, for both and potentially other
[00:39:48] <MaxSem>	 yurik, zero config is needed for every pageview -how are you going to sync it with varnish?
[00:40:45] <yurik>	 MaxSem, zero asks for configuration, same way as event logging, and that config comes from memcached or if not there - an API call for raw page content. At this point, if there is no data, it simply doesn't show banner
[00:40:56] <yurik>	 the api call goes through varnish
[00:41:39] <yurik>	 ori's solution was to put a lock into memcached
[00:42:17] <yurik>	 and silently fail if the lock is in place
[00:42:19] <MaxSem>	 pfft, doing it with PC would take 10 lines - what are you objecting against? only no care concurrency would be shorter:)
[00:42:23] <ori>	 if the schema doesn't load, the events on the client don't get verified, but the user doesn't get an error
[00:43:03] <ori>	 cache stampede is the greater risk
[00:43:08] <yurik>	 right, so that's what i'm saying - how much of a problem is when lots of apaches go against the api backend (via varnish) in the event of the missing value in memcached?
[00:43:38] <ori>	 i preferred not to have to find out
[00:44:05] <MaxSem>	 also, each apache has multiple threads;)
[00:44:18] <ori>	 bbiab
[00:44:22] <yurik>	 ori, but i somehow feel that stampee is not anywhere near the michael jackson problem that forced us to introduce the poolconter
[00:46:13] <ori>	 yurik: when it comes to distributed software, i prefer "it's obviously ok" to "it's probably okay, right? i mean, how bad could it be?"
[00:46:14] <grrrit-wm>	 (03PS1) 10Siebrand: Declare visibility for class properties in DatabaseOracle.php [core] - 10https://gerrit.wikimedia.org/r/103877 
[00:46:15] <grrrit-wm>	 (03PS1) 10Siebrand: Declare visibility for class properties in MySQLMasterPos [core] - 10https://gerrit.wikimedia.org/r/103878 
[00:46:16] <grrrit-wm>	 (03PS1) 10Siebrand: Declare visibility for class properties in DatabaseMssql [core] - 10https://gerrit.wikimedia.org/r/103879 
[00:47:01] <yurik>	 ori, my concern is that introducing additional code to solve a problem that might not be there might introduce hard to reproduce bugs
[00:47:18] <yurik>	 hence - trying to think it out, lets chat when you come back :)
[00:48:50] <grrrit-wm>	 (03PS1) 10Gergő Tisza: Enable unit tests for UploadWizard [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/103881 
[00:48:54] <ori>	 yurik: on the wmf cluster it's the same pool of apaches, right? so you have one apache worker that is busy waiting for the response to come through, and another apache worker busy generating the response
[00:49:08] <ori>	 so each request keeps two apache workers busy, right?
[00:49:23] <yurik>	 ori, wouldn't varnish optimize that?
[00:49:47] <ori>	 optimize it how?
[00:51:24] <yurik>	 if you have an identical request that is extremely fast to complete (we are not talking about page rendering) that hits a dedicated API varnish/backend cluster, the same varnish instance should see a request for the same object and see that its already pending on another thread it would block
[00:52:39] <grrrit-wm>	 (03PS1) 10Siebrand: Remove unused local variables [core] - 10https://gerrit.wikimedia.org/r/103882 
[00:54:03] <ori>	 yurik: it's called "collapsed forwarding", and it's easy to screw up
[00:54:05] <yurik>	 so in reality, in a VERY rare case of the memcached miss, a small percentage (only those requests from that specific ZERO cluster), and only those that actually hit the backend would ask for the content of a text page (raw, no parsing), via api that would hit dedicated varnish, which would in turn hit the api backend apaches
[00:54:15] * yurik  is wikiing

[00:54:47] <grrrit-wm>	 (03CR) 10Reedy: Remove unused local variables (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103882 (owner: 10Siebrand)
[00:55:18] <yurik>	 ori, i just feel that we should be more reactive to this case - see it in graphs first and than take measures
[00:55:24] <yurik>	 see my expl above
[00:55:55] <yurik>	 btw, varnish supports it - https://www.varnish-cache.org/forum/topic/395
[00:56:28] <grrrit-wm>	 (03PS2) 10Siebrand: Remove unused local variables [core] - 10https://gerrit.wikimedia.org/r/103882 
[00:57:14] <yurik>	 wow, wiki doesn't have "collapsed forwarding" anywhere :(
[01:15:22] <grrrit-wm>	 (03PS2) 10Reedy: Declare visibility for class property of LoadBalancerSingle [core] - 10https://gerrit.wikimedia.org/r/103863 (owner: 10Siebrand)
[01:15:29] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Declare visibility for class property of LoadBalancerSingle [core] - 10https://gerrit.wikimedia.org/r/103863 (owner: 10Siebrand)
[01:18:45] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: Add SVG versions of link type icons [core] - 10https://gerrit.wikimedia.org/r/98291 (owner: 10M4tx)
[01:20:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Declare visibility for class property of LoadBalancerSingle [core] - 10https://gerrit.wikimedia.org/r/103863 (owner: 10Siebrand)
[01:38:54] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] "Okay, I'm going to just merge this already. The SVG icons look almost exactly the same as original ones at the nominal resolution and look" [core] - 10https://gerrit.wikimedia.org/r/98291 (owner: 10M4tx)
[01:40:18] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-2] "Hmm" [core] - 10https://gerrit.wikimedia.org/r/98291 (owner: 10M4tx)
[01:41:18] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "This seems to include the search icons from https://gerrit.wikimedia.org/r/#/c/97307/ . As they are currently unused (and to avoid conflic" [core] - 10https://gerrit.wikimedia.org/r/98291 (owner: 10M4tx)
[01:43:12] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: Add SVG versions of link type icons [core] - 10https://gerrit.wikimedia.org/r/98291 (owner: 10M4tx)
[01:43:46] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Add SVG versions of link type icons [core] - 10https://gerrit.wikimedia.org/r/98291 (owner: 10M4tx)
[01:47:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add SVG versions of link type icons [core] - 10https://gerrit.wikimedia.org/r/98291 (owner: 10M4tx)
[01:53:55] <marktraceur>	 jdlrobson: Why is a generally useful tool entombed in MobileFrontend?
[01:55:40] <grrrit-wm>	 (03PS1) 10Siebrand: [WIP] Update documentation for database related classes [core] - 10https://gerrit.wikimedia.org/r/103890 
[01:56:44] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 031] "Looks reasonable, didn't test." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103345 (owner: 10Theopolisme)
[02:00:19] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Add SVG versions of enhanced recent changes collapse/show arrows (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96372 (owner: 10M4tx)
[02:03:30] <grrrit-wm>	 (03Abandoned) 10Bartosz Dziewoński: Add an SVG version of watch icon [core] - 10https://gerrit.wikimedia.org/r/98856 (owner: 10M4tx)
[02:04:25] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: Add an SVG version of watch icon [core] - 10https://gerrit.wikimedia.org/r/99258 (owner: 10M4tx)
[02:10:50] <grrrit-wm>	 (03CR) 10Jdlrobson: "I continue to find the existence of all of these icons insane :(" [core] - 10https://gerrit.wikimedia.org/r/98291 (owner: 10M4tx)
[02:14:44] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "Yeah, some minor improvements should be applied before we merge this:" [core] - 10https://gerrit.wikimedia.org/r/99258 (owner: 10M4tx)
[02:16:25] <grrrit-wm>	 (03CR) 10TTO: "Per https://www.mediawiki.org/wiki/Requests_for_comment/Isolate_custom_jQuery_libraries it would be good to emphasize where this library h" [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna)
[02:29:31] <grrrit-wm>	 (03PS19) 10Yurik: Initial implementation of the JSON configuration store. [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 
[03:00:51] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Optimize all SVGs [core] - 10https://gerrit.wikimedia.org/r/103894 
[03:02:45] <grrrit-wm>	 (03CR) 10Liangent: [C: 04-1] "It seems prefix trimming is missing now? try following pages in the original version and your version:" (036 comments) [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 (owner: 10Mayankmadan)
[03:18:47] <grrrit-wm>	 (03Abandoned) 10Ori.livneh: [Do not merge] Remove localStorage module caching from ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/94976 (owner: 10Ori.livneh)
[03:58:45] <grrrit-wm>	 (03CR) 10Yaron Koren: "Looks good, thanks!" [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/103395 (owner: 1001tonythomas)
[04:25:44] <grrrit-wm>	 (03PS9) 1001tonythomas: Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 
[04:26:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas)
[04:30:17] <grrrit-wm>	 (03PS10) 1001tonythomas: Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 
[04:30:57] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas)
[04:34:57] <grrrit-wm>	 (03PS11) 1001tonythomas: Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 
[04:35:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas)
[04:39:01] <grrrit-wm>	 (03PS12) 1001tonythomas: Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 
[04:42:04] <grrrit-wm>	 (03CR) 1001tonythomas: "@Aaron : Thanks for the +2, but couldn't make the patch Merger Ready earlier. Now its ok, I think." [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas)
[04:44:35] <grrrit-wm>	 (03PS1) 10Skizzerz: Make MediaWiki:Redirectpagesub accept all wikitext. [core] - 10https://gerrit.wikimedia.org/r/103898 
[05:32:18] <grrrit-wm>	 (03CR) 10Legoktm: "@Siebrand: Merging this without even bothering to leave a comment after I objected is extremely rude." [extensions/HelpPages] - 10https://gerrit.wikimedia.org/r/103637 (owner: 10Shirayuki)
[05:41:48] <greg-g>	 legoktm: and it arguably *should* be a protorelative one :/
[05:41:54] <greg-g>	 legoktm: now it's a mix of http and https
[05:42:16] <legoktm>	 sigh :/
[05:45:17] <legoktm>	 Time to upload 115 patches to gerrit!
[05:55:48] <grrrit-wm>	 (03CR) 10MZMcBride: i18n: add "https:" (031 comment) [extensions/HelpPages] - 10https://gerrit.wikimedia.org/r/103637 (owner: 10Shirayuki)
[06:06:43] <mayankmadan>	 hi liangent 
[06:07:02] <liangent>	 mayankmadan: hi
[06:22:09] <grrrit-wm>	 (03CR) 10Shirayuki: "updated message documentation" [extensions/HelpPages] - 10https://gerrit.wikimedia.org/r/103637 (owner: 10Shirayuki)
[06:32:58] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/APC] - 10https://gerrit.wikimedia.org/r/103901 
[06:35:15] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/103903 
[06:36:03] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/103904 
[06:36:31] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/103905 
[06:37:14] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/103906 
[06:37:37] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/BatchUserRights] - 10https://gerrit.wikimedia.org/r/103907 
[06:38:04] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/103908 
[06:38:29] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/103909 
[06:39:15] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/103910 
[06:40:54] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/103912 
[06:41:25] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/103913 
[06:41:54] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/103914 
[06:42:27] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Collection] - 10https://gerrit.wikimedia.org/r/103915 
[06:42:52] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Comments] - 10https://gerrit.wikimedia.org/r/103916 
[06:43:13] <greg-g>	 :)
[06:43:19] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/CommunityApplications] - 10https://gerrit.wikimedia.org/r/103917 
[06:44:00] <legoktm>	 I can tell that some of this code hasn't been touched in years.
[06:44:02] <jdlrobson>	 marktraceur: i'm glad you find it useful anyway ;-)
[06:44:02] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/CommunityHiring] - 10https://gerrit.wikimedia.org/r/103918 
[06:44:13] <ori>	 jdlrobson: new burial is sooooooo good
[06:44:40] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/CommunityTwitter] - 10https://gerrit.wikimedia.org/r/103919 
[06:44:41] <jdlrobson>	 ori: quuoiii?
[06:45:03] <ori>	 jdlrobson: http://www.factmag.com/2013/12/11/burial-releases-new-ep-rival-dealer-grab-it-now/
[06:46:18] <jdlrobson>	 ori: it says explicit lyrics
[06:46:20] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Configure] - 10https://gerrit.wikimedia.org/r/103920 
[06:46:20] <jdlrobson>	 i'm not sure i can listen
[06:46:34] <ori>	 jdlrobson: i won't tell your scrummasters
[06:46:44] <jdlrobson>	 i am the scrum master this week ori 
[06:46:46] <jdlrobson>	 i am the scrum master
[06:46:53] <ori>	 ohhh snap.
[06:46:54] * ori  hides.

[06:46:58] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/103921 
[06:48:30] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/CongressLookup] - 10https://gerrit.wikimedia.org/r/103922 
[06:49:25] * legoktm  puts grrrit-wm on ignore

[06:49:47] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Contest] - 10https://gerrit.wikimedia.org/r/103923 
[06:50:16] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/ConventionExtension] - 10https://gerrit.wikimedia.org/r/103924 
[06:50:39] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/CreateRedirect] - 10https://gerrit.wikimedia.org/r/103925 
[06:51:21] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/103926 
[06:52:00] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/103927 
[06:52:44] <jdlrobson>	 ori: this sounds like Goa
[06:52:47] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/103928 
[06:52:53] <jdlrobson>	 i'm having flashbacks
[06:53:07] <ori>	 jdlrobson: have you heard burial before?
[06:53:14] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Editcount] - 10https://gerrit.wikimedia.org/r/103929 
[06:53:16] <jdlrobson>	 no
[06:54:01] <ori>	 jdlrobson: oh! listen to 'kindred' (the track) first then
[06:54:06] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/103930 
[06:54:34] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/EmailCapture] - 10https://gerrit.wikimedia.org/r/103931 
[06:54:49] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/ExpandTemplates] - 10https://gerrit.wikimedia.org/r/103932 
[06:55:08] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/103933 
[06:55:18] <jdlrobson>	 ori: when we gonna collaborate and get the cache manifests working?
[06:55:36] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/FacebookOpenGraph] - 10https://gerrit.wikimedia.org/r/103934 
[06:55:47] <ori>	 jdlrobson: whatchoo need?
[06:55:52] <jdlrobson>	 RL magic
[06:56:01] <jdlrobson>	 you have the bag of magic right?
[06:56:13] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] Replace usage of SpecialPage::getTitle with getPageTitle (031 comment) [extensions/FacebookOpenGraph] - 10https://gerrit.wikimedia.org/r/103934 (owner: 10Legoktm)
[06:56:20] <ori>	 jdlrobson: and how
[06:56:28] <jdlrobson>	 ori: basically https://gerrit.wikimedia.org/r/#/c/100919/ it what needs to get into a merge able state
[06:56:44] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/103935 
[06:57:17] <jdlrobson>	 versioning the manifest is proving tricky
[06:57:27] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/103936 
[06:57:53] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/103938 
[06:58:02] <ori>	 jdlrobson: how are you doing it?
[06:58:15] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/103939 
[06:58:26] <jdlrobson>	 well the problem ori is the manifest needs to predict the urls that RL will use
[06:58:57] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/103940 
[06:59:06] <jdlrobson>	 and it also needs some unique id that only changes when the files in the modules listed change
[06:59:13] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/103941 
[06:59:43] <ori>	 jdlrobson: the max mtime of all declared modules?
[06:59:46] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/GoogleMaps] - 10https://gerrit.wikimedia.org/r/103942 
[07:00:01] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/103943 
[07:00:25] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/103944 
[07:00:44] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/103945 
[07:01:04] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/103946 
[07:01:30] <grrrit-wm>	 (03PS5) 10leucosticte: Add preferences checkbox to email text of watched deleted pages [core] - 10https://gerrit.wikimedia.org/r/101443 
[07:01:36] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/103947 
[07:02:01] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/103949 
[07:02:13] <grrrit-wm>	 (03CR) 10leucosticte: Add preferences checkbox to email text of watched deleted pages (036 comments) [core] - 10https://gerrit.wikimedia.org/r/101443 (owner: 10leucosticte)
[07:02:14] <jdlrobson>	 ori: yeh the problem is the manifest php file needs to be mutually exclusive from the page that requests it
[07:02:29] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/LookupUser] - 10https://gerrit.wikimedia.org/r/103950 
[07:02:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add preferences checkbox to email text of watched deleted pages [core] - 10https://gerrit.wikimedia.org/r/101443 (owner: 10leucosticte)
[07:02:42] <jdlrobson>	 so it's a question of what information needs to be passed to the manifest (query string parameters can't be dynamic and change as that will mess up things)
[07:03:25] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/103951 
[07:03:36] <ori>	 i don't entirely understand
[07:04:33] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/103952 
[07:05:51] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/103954 
[07:06:05] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Moodle] - 10https://gerrit.wikimedia.org/r/103955 
[07:07:06] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/103956 
[07:07:40] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/103957 
[07:08:31] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/103958 
[07:12:15] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/103959 
[07:12:32] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/103960 
[07:14:24] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/103961 
[07:17:17] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/103962 
[07:18:04] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/103963 
[07:18:29] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/103964 
[07:19:17] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/103965 
[07:19:46] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Poll] - 10https://gerrit.wikimedia.org/r/103966 
[07:20:03] <grrrit-wm>	 (03PS1) 10Mayankmadan: Adding support for more types of flickr URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103967 
[07:21:14] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/103968 
[07:23:26] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/PrefStats] - 10https://gerrit.wikimedia.org/r/103969 
[07:23:52] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/PrefSwitch] - 10https://gerrit.wikimedia.org/r/103970 
[07:28:29] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Premoderation] - 10https://gerrit.wikimedia.org/r/103971 
[07:29:29] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/103972 
[07:37:14] <grrrit-wm1>	 (03CR) 10Grunny: [C: 032 V: 032] Replace usage of SpecialPage::getTitle with getPageTitle [extensions/BatchUserRights] - 10https://gerrit.wikimedia.org/r/103907 (owner: 10Legoktm)
[07:37:29] <grrrit-wm1>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/103973 
[07:37:45] <legoktm>	 eh
[07:38:49] <legoktm>	 ???
[07:38:56] <Jasper_Deng>	 wtf
[07:39:02] <legoktm>	 sigh.
[07:43:43] <legoktm>	 aha, netsplit.
[07:46:23] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Push] - 10https://gerrit.wikimedia.org/r/103974 
[07:46:25] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/103975 
[07:46:26] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/RandomInCategory] - 10https://gerrit.wikimedia.org/r/103976 
[07:46:26] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/ReaderFeedback] - 10https://gerrit.wikimedia.org/r/103977 
[07:46:27] <grrrit-wm>	 (03CR) 10Hydriz: [C: 032 V: 032] Replace usage of SpecialPage::getTitle with getPageTitle [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/103913 (owner: 10Legoktm)
[07:46:28] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/ReassignEdits] - 10https://gerrit.wikimedia.org/r/103978 
[07:46:29] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/103979 
[07:46:30] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/103980 
[07:46:32] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/103981 
[07:46:32] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/SecureSessions] - 10https://gerrit.wikimedia.org/r/103982 
[07:52:15] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/SimpleSurvey] - 10https://gerrit.wikimedia.org/r/103990 
[07:52:46] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/103991 
[07:53:16] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/103992 
[07:54:04] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/103993 
[07:54:50] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Survey] - 10https://gerrit.wikimedia.org/r/103994 
[07:56:00] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/UnicodeConverter] - 10https://gerrit.wikimedia.org/r/103997 
[07:56:22] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103998 
[07:56:35] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/103999 
[07:56:45] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/104000 
[07:57:00] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/104001 
[07:57:21] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/104002 
[07:58:16] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Wikilog] - 10https://gerrit.wikimedia.org/r/104005 
[07:58:33] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/104006 
[07:59:43] <grrrit-wm>	 (03PS1) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/104008 
[07:59:48] <legoktm>	 done!
[08:00:22] <grrrit-wm>	 (03CR) 10Legoktm: "Enjoy! <https://gerrit.wikimedia.org/r/#/q/status:open+topic:getPageTitle,n,z>" [core] - 10https://gerrit.wikimedia.org/r/103587 (owner: 10Legoktm)
[08:01:51] <Jasper_Deng>	 lego: was that the 115 commits you were talking about?
[08:02:03] <legoktm>	 yup
[08:23:59] <grrrit-wm>	 (03Abandoned) 10Legoktm: Make SpecialPage a ContextSource [core] - 10https://gerrit.wikimedia.org/r/103347 (owner: 10Legoktm)
[08:27:05] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "I'm pretty sure the maintainer wants BC to one or more stable versions of MediaWiki for this." [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/103905 (owner: 10Legoktm)
[08:28:27] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "This extension has been deprecated for a very long time. We should let if die by not maintaining it any more, I think." [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/103963 (owner: 10Legoktm)
[08:30:26] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] Replace usage of SpecialPage::getTitle with getPageTitle [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/103903 (owner: 10Legoktm)
[08:30:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/103903 (owner: 10Legoktm)
[08:31:52] <hoo>	 Doh... crap
[08:31:55] <hoo>	 legoktm: Around?
[08:32:04] <legoktm>	 hi
[08:32:12] <hoo>	 This method was newly introduced?
[08:32:18] <legoktm>	 yes
[08:32:18] <mayankmadan>	 marktraceur, hi
[08:32:21] <hoo>	 damn
[08:32:39] <hoo>	 Can you supply a patch for Abusefilter than to keep it b/c
[08:32:46] <hoo>	 Didn't realize that first
[08:32:51] <hoo>	 * then
[08:33:19] <legoktm>	 easiest would be to revert it :P
[08:33:30] <hoo>	 legoktm: Sure
[08:33:32] <legoktm>	 or I could add is_callable checks I guess
[08:33:46] <hoo>	 please do so
[08:34:02] <hoo>	 I can also do that, if you don't have time
[08:34:16] <hoo>	 but I really don't want to see master "broken" for long
[08:34:42] <legoktm>	 er which one, revert or add is_callable checks?
[08:35:33] <hoo>	 legoktm: I'd prefer the is_callable
[08:35:37] <legoktm>	 hoo: other more hacky option, add getPageTitle to the SpecialAbuseLog class so it can use it even if the mw version doesn't support it
[08:36:08] <hoo>	 -1
[08:36:31] <hoo>	 or well... it's crap anyway, so do that
[08:36:46] <hoo>	 rather safe us some loc
[08:39:07] <legoktm>	 ok
[08:39:43] * legoktm  waits for his IDE to load

[08:43:56] <grrrit-wm>	 (03PS1) 10Legoktm: Restore b/c for pre-1.23 MediaWiki versions [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104009 
[08:43:59] <legoktm>	 hoo: ^
[08:46:19] <hoo>	 looking
[08:46:52] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] Restore b/c for pre-1.23 MediaWiki versions (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104009 (owner: 10Legoktm)
[08:47:00] <hoo>	 legoktm: I guess you've tested it and it's fine?!
[08:47:49] <legoktm>	 I haven't, I can probably test it tomorrow somtetime
[08:47:49] <siebrand>	 legoktm: Huge job on getPageTitle. Thanks for taking that on.
[08:47:56] <legoktm>	 thanks :)
[08:48:28] <grrrit-wm>	 (03CR) 10Legoktm: Restore b/c for pre-1.23 MediaWiki versions (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104009 (owner: 10Legoktm)
[08:48:33] <grrrit-wm>	 (03PS2) 10Legoktm: Restore b/c for pre-1.23 MediaWiki versions [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104009 
[08:49:41] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] Restore b/c for pre-1.23 MediaWiki versions [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104009 (owner: 10Legoktm)
[08:53:52] <grrrit-wm>	 (03Abandoned) 10Legoktm: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Oversight] - 10https://gerrit.wikimedia.org/r/103963 (owner: 10Legoktm)
[08:55:18] <grrrit-wm>	 (03CR) 10Legoktm: "Ok, I'll leave it up to them on whether this should be abandoned or left until the time is ready." [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/103905 (owner: 10Legoktm)
[08:55:56] <Jasper_Deng>	 legoktm: which IDE do you use?
[08:56:07] <legoktm>	 PHPStorm
[09:04:02] <grrrit-wm>	 (03CR) 10Siebrand: "@lego: There's indeed nothing wrong with a protocol relative link. A while ago, we've started to make links to pages in the mediawiki.org " [extensions/HelpPages] - 10https://gerrit.wikimedia.org/r/103637 (owner: 10Shirayuki)
[09:05:47] <grrrit-wm>	 (03CR) 10Nemo bis: "Was this change documented on mediawiki.org's pages for extension development?" [core] - 10https://gerrit.wikimedia.org/r/103587 (owner: 10Legoktm)
[09:10:23] <grrrit-wm>	 (03PS1) 10Spage: [WIP] Update login and HTMLForm to new design [core] - 10https://gerrit.wikimedia.org/r/104011 
[09:11:08] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Update login and HTMLForm to new design [core] - 10https://gerrit.wikimedia.org/r/104011 (owner: 10Spage)
[09:16:19] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik)
[09:20:43] <grrrit-wm>	 (03PS2) 10Siebrand: Declare visibility for class properties of LBFactoryMulti [core] - 10https://gerrit.wikimedia.org/r/103864 
[09:20:58] <grrrit-wm>	 (03PS2) 10Siebrand: Declare visibility for class properties of LBFactory and LBFactorySimple [core] - 10https://gerrit.wikimedia.org/r/103865 
[09:23:18] <grrrit-wm>	 (03PS2) 10Siebrand: Declare visibility for class properties in DatabaseUtility.php [core] - 10https://gerrit.wikimedia.org/r/103873 
[09:23:31] <grrrit-wm>	 (03PS2) 10Siebrand: Declare visibility for class properties in DatabaseSqlite [core] - 10https://gerrit.wikimedia.org/r/103874 
[09:23:42] <grrrit-wm>	 (03PS3) 10Siebrand: Declare visibility for class properties of LBFactoryMulti [core] - 10https://gerrit.wikimedia.org/r/103864 
[09:24:07] <grrrit-wm>	 (03PS2) 10Siebrand: Declare visibility for class properties in DatabasePostgres.php [core] - 10https://gerrit.wikimedia.org/r/103875 
[09:24:38] <grrrit-wm>	 (03PS2) 10Siebrand: Declare visibility for class properties in DatabaseOracle.php [core] - 10https://gerrit.wikimedia.org/r/103877 
[09:25:00] <grrrit-wm>	 (03PS2) 10Siebrand: Declare visibility for class properties in MySQLMasterPos [core] - 10https://gerrit.wikimedia.org/r/103878 
[09:25:16] <grrrit-wm>	 (03PS2) 10Siebrand: Declare visibility for class properties in DatabaseMssql [core] - 10https://gerrit.wikimedia.org/r/103879 
[09:25:29] <grrrit-wm>	 (03PS3) 10Siebrand: Remove unused local variables [core] - 10https://gerrit.wikimedia.org/r/103882 
[09:25:58] <grrrit-wm>	 (03PS2) 10Siebrand: [WIP] Update documentation for database related classes [core] - 10https://gerrit.wikimedia.org/r/103890 
[09:31:02] <grrrit-wm>	 (03PS3) 10Legoktm: Restore b/c for pre-1.23 MediaWiki versions [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104009 
[09:33:13] <grrrit-wm>	 (03CR) 10Spage: "These changes are up at http://ee-flow-extra.instance-proxy.wmflabs.org/wiki/Special:PasswordReset , and its Login and Create account form" [core] - 10https://gerrit.wikimedia.org/r/104011 (owner: 10Spage)
[09:39:19] <grrrit-wm>	 (03PS1) 10Mayankmadan: verifyUpload should be called before checkWarnings [core] - 10https://gerrit.wikimedia.org/r/104012 
[09:40:07] <mayankmadan>	 marktraceur, online?
[09:41:38] <grrrit-wm>	 (03CR) 10PleaseStand: [C: 04-1] Remove unused local variables (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103882 (owner: 10Siebrand)
[09:45:08] <grrrit-wm>	 (03CR) 10Siebrand: Remove unused local variables (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103882 (owner: 10Siebrand)
[10:08:25] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Only roundtrip through parsoid for wikitext when necessary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101120 (owner: 10EBernhardson)
[10:08:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Only roundtrip through parsoid for wikitext when necessary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101120 (owner: 10EBernhardson)
[10:41:17] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG)
[10:42:29] <grrrit-wm>	 (03PS2) 10Physikerwelt: Buffer png writes and flush them all at once [extensions/Math] - 10https://gerrit.wikimedia.org/r/103644 (owner: 10Aaron Schulz)
[10:42:41] <grrrit-wm>	 (03CR) 10Physikerwelt: [C: 032 V: 032] Buffer png writes and flush them all at once [extensions/Math] - 10https://gerrit.wikimedia.org/r/103644 (owner: 10Aaron Schulz)
[11:09:15] <grrrit-wm>	 (03PS4) 10M4tx: Add an SVG version of watch icon [core] - 10https://gerrit.wikimedia.org/r/99258 
[11:09:16] <grrrit-wm>	 (03PS5) 10Matthias Mullie: No Reply button after clicking Be the first to comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101164 (owner: 10Bsitu)
[11:10:04] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] No Reply button after clicking Be the first to comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101164 (owner: 10Bsitu)
[11:10:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: No Reply button after clicking Be the first to comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101164 (owner: 10Bsitu)
[11:11:04] <grrrit-wm>	 (03CR) 10M4tx: "@Bartosz: I think I fixed all the problems you were talking about, but check the speed of animation. I spent a lot of time trying to match" [core] - 10https://gerrit.wikimedia.org/r/99258 (owner: 10M4tx)
[11:31:09] <grrrit-wm>	 (03Abandoned) 10M4tx: Fixed indentation style and PNG fallback method. [core] - 10https://gerrit.wikimedia.org/r/97114 (owner: 10M4tx)
[11:31:29] <grrrit-wm>	 (03Abandoned) 10M4tx: Add SVG versions of enhanced recent changes collapse/show arrows [core] - 10https://gerrit.wikimedia.org/r/97022 (owner: 10M4tx)
[11:40:15] <grrrit-wm>	 (03CR) 10M4tx: Add SVG versions of enhanced recent changes collapse/show arrows (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96372 (owner: 10M4tx)
[11:43:39] <grrrit-wm>	 (03PS5) 10M4tx: Add SVG versions of enhanced recent changes collapse/show arrows [core] - 10https://gerrit.wikimedia.org/r/96372 
[11:47:41] <grrrit-wm>	 (03PS1) 10Umherirrender: Add more tests for title validations [core] - 10https://gerrit.wikimedia.org/r/104016 
[11:49:22] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (035 comments) [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/104014 (owner: 10MegaAlex)
[11:52:04] <grrrit-wm>	 (03PS1) 10Umherirrender: Fixed typo in comment in MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/104017 
[11:52:33] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Fixed typo in comment in MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/104017 (owner: 10Umherirrender)
[11:56:44] <grrrit-wm>	 (03PS60) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 
[11:57:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fixed typo in comment in MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/104017 (owner: 10Umherirrender)
[12:01:36] <grrrit-wm>	 (03PS1) 10Umherirrender: Remove hints to fixed bug 54044 [core] - 10https://gerrit.wikimedia.org/r/104019 
[12:02:22] <grrrit-wm>	 (03CR) 10Frédéric Wang: "> @Frédéric: Can you recheck if all files are included now?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt)
[12:04:42] <MegaAlex>	 siebrand: for gerrit: 104014 : How should I deprecate the message parameters?  Thanks for the review! :)
[12:05:39] <siebrand>	 MegaAlex: By updating the documentation for the deprecated parameter to something like "No longer used".
[12:06:35] <MegaAlex>	 ok, thanks!
[12:09:15] <grrrit-wm>	 (03CR) 10Siebrand: "Will continue this once the visibility patch sets in this folder have been merged." [core] - 10https://gerrit.wikimedia.org/r/103890 (owner: 10Siebrand)
[12:10:33] <grrrit-wm>	 (03PS2) 10UltrasonicNXT: Fix bug with getDupeWarning [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/103384 
[12:13:19] <grrrit-wm>	 (03CR) 10Siebrand: Index and search file text from pdf/djvu files (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 (owner: 10Chad)
[12:17:03] <grrrit-wm>	 (03CR) 10Tpt: [C: 032] Replace usage of SpecialPage::getTitle with getPageTitle [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/103973 (owner: 10Legoktm)
[12:17:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/103973 (owner: 10Legoktm)
[12:19:21] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "Repeating my previous review: Don't understand why you're adding hidden parameters. Chances of anyone finding out they are there are close" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/71291 (owner: 10Se4598)
[12:20:04] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 (owner: 10AndyRussG)
[12:22:06] <grrrit-wm>	 (03CR) 10Aude: Remove unused local variables (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103882 (owner: 10Siebrand)
[12:22:26] <grrrit-wm>	 (03PS2) 10MegaAlex: i18n: Supply date/time parameters to some messages [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/104014 
[12:27:09] <grrrit-wm>	 (03CR) 10Aarcos: [C: 04-1] Functionality to create a new image in upload-wizard_tests.py (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan)
[12:30:03] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "Almost there. Left 2 comments." (032 comments) [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/104014 (owner: 10MegaAlex)
[12:34:12] <grrrit-wm>	 (03CR) 10Hatul: "This patch fixes that patch." [core] - 10https://gerrit.wikimedia.org/r/103852 (owner: 10Hatul)
[12:37:39] <grrrit-wm>	 (03PS3) 10MegaAlex: i18n: Supply date/time parameters to some messages [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/104014 
[12:37:39] <grrrit-wm>	 (03PS4) 10Siebrand: Remove unused local variables [core] - 10https://gerrit.wikimedia.org/r/103882 
[12:38:00] <grrrit-wm>	 (03CR) 10Siebrand: Remove unused local variables (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103882 (owner: 10Siebrand)
[12:57:38] <grrrit-wm>	 (03PS1) 10Siebrand: Update documentation related to newFromRow and formatRow [core] - 10https://gerrit.wikimedia.org/r/104021 
[12:57:38] <grrrit-wm>	 (03PS1) 10Siebrand: Add TODOs for missing return statements [core] - 10https://gerrit.wikimedia.org/r/104022 
[12:59:28] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032 V: 032] Add logging [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/103097 (owner: 10UltrasonicNXT)
[13:00:03] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032 V: 032] i18n: Supply date/time parameters to some messages [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/104014 (owner: 10MegaAlex)
[13:09:57] <grrrit-wm>	 (03PS6) 10leucosticte: Add preferences checkbox to email text of watched deleted pages [core] - 10https://gerrit.wikimedia.org/r/101443 
[13:19:10] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "Please remove trailing whitespace from the diff." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/103852 (owner: 10Hatul)
[13:28:51] <grrrit-wm>	 (03CR) 10Siebrand: "Nice!" [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/103738 (owner: 10BryanDavis)
[13:35:58] <Niharika>	 Hello. :) 
[13:46:12] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] Restore b/c for pre-1.23 MediaWiki versions [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104009 (owner: 10Legoktm)
[13:52:05] <grrrit-wm>	 (03PS1) 10Umherirrender: Do not load special pages in WatchedItem::load [core] - 10https://gerrit.wikimedia.org/r/104024 
[13:52:52] <grrrit-wm>	 (03CR) 10Gergő Tisza: Functionality to create a new image in upload-wizard_tests.py (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan)
[14:05:29] <grrrit-wm>	 (03PS1) 10Siebrand: Remove last remainig use in core of Title::escapeFullURL() [core] - 10https://gerrit.wikimedia.org/r/104025 
[14:30:00] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] "Nice, thanks." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/103654 (owner: 10MegaAlex)
[14:30:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: i18n: Add GENDER support to epoa-visible and epca-visible [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/103654 (owner: 10MegaAlex)
[14:43:28] <grrrit-wm>	 (03PS1) 10Manybubbles: Add missing i18n note [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104027 
[14:43:47] <tonythomas01>	 legoktm: I have modified the mediaviewer as you insisted to make the lightbox close  when someone clicks on the backdrop. does it look ok https://gerrit.wikimedia.org/r/#/c/103902/
[14:43:55] <grrrit-wm>	 (03CR) 10Manybubbles: Index and search file text from pdf/djvu files (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 (owner: 10Chad)
[14:47:52] <grrrit-wm>	 (03CR) 10Anomie: [C: 031] "Code looks ok, haven't tested. But I think you might have forgotten to use one of your URL options." (035 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22)
[14:50:08] <GEOFBOT>	 does anyone here happen to speak macedonian?
[14:50:14] <GEOFBOT>	 i need a translation of the wikibooks logo :P
[14:55:38] <grrrit-wm>	 (03Abandoned) 10Anomie: Pass rights needed to protectedpagewarning [core] - 10https://gerrit.wikimedia.org/r/90357 (owner: 10Anomie)
[14:55:57] <Nemo_bis>	 GEOFBOT: I assume you know you can use the babel/user language categories?
[14:56:09] <grrrit-wm>	 (03CR) 10Physikerwelt: "Is db2 support finally removed or temporary removed. If it's fially removed the math extension would not have to care about db2 support at" [core] - 10https://gerrit.wikimedia.org/r/50764 (owner: 10Chad)
[14:56:18] <GEOFBOT>	 ah, that works
[14:56:38] <GEOFBOT>	 is it ok if I just ask them on their talk page?
[14:56:58] <Nemo_bis>	 yes, or you can check who happens to be on IRC https://meta.wikimedia.org/wiki/Category:User_mk
[14:57:10] <Nemo_bis>	 (dungo always is, but he's just mk-1 and usually afk :) )
[14:58:19] <Nemo_bis>	 and of course http://stats.wikimedia.org/wikibooks/EN/TablesWikipediaMK.htm#wikipedians
[14:59:20] <grrrit-wm>	 (03PS1) 10Siebrand: Replace deprecated Linker::makeBrokenLink() [extensions/Interlanguage] - 10https://gerrit.wikimedia.org/r/104029 
[15:02:43] <grrrit-wm>	 (03CR) 10Nemo bis: "I need a moment to check the logic" (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/103119 (owner: 10MegaAlex)
[15:03:23] <grrrit-wm>	 (03PS1) 10Siebrand: Replace use of deprecated SpecialPageFactory::getGroup() [core] - 10https://gerrit.wikimedia.org/r/104030 
[15:05:45] <grrrit-wm>	 (03PS1) 10Manybubbles: Fix profiling method calls [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104031 
[15:09:10] <grrrit-wm>	 (03PS1) 10Siebrand: Remove long deprecated methods from Linker [core] - 10https://gerrit.wikimedia.org/r/104033 
[15:13:30] <grrrit-wm>	 (03PS1) 10Siebrand: Remove deprecated SpecialRevisionDelete::extractBitField() [core] - 10https://gerrit.wikimedia.org/r/104035 
[15:13:51] <grrrit-wm>	 (03PS2) 10Siebrand: Remove deprecated SpecialRevisionDelete::extractBitField() [core] - 10https://gerrit.wikimedia.org/r/104035 
[15:18:10] <grrrit-wm>	 (03CR) 10Anomie: [C: 031] "Code looks good, seems to work. I'll leave it to others to debate whether the change is good from a social perspective and whether some so" [core] - 10https://gerrit.wikimedia.org/r/103742 (owner: 10Chad)
[15:18:34] <grrrit-wm>	 (03CR) 10Siebrand: "Given that we really removed it, I don't think it's likely to be restored easily. We usually take a lot of time before dropping a DBMS." [core] - 10https://gerrit.wikimedia.org/r/50764 (owner: 10Chad)
[15:21:37] <siebrand>	 manybubbles: On https://gerrit.wikimedia.org/r/#/c/104027/1/CirrusSearch.i18n.php. What is a snippet of a file?
[15:21:56] <manybubbles>	 siebrand: part of the text of the file
[15:22:18] <siebrand>	 manybubbles: you mean like in the case of PDF and Djvu?
[15:22:38] <siebrand>	 or word, excel, text, ...?
[15:22:57] <manybubbles>	 siebrand: technically any file that mediawiki can extract text from.  cirrus doesn't pay attention to the type, though we've been talking about pdf and djvu
[15:23:18] <manybubbles>	 I'm not sure which files mediawiki can use beyond pdf and djvu though
[15:23:28] <siebrand>	 manybubbles: Okay. First thing I thought when I read that was: How can you extract text from a(n image) file?
[15:23:38] <siebrand>	 manybubbles: I guess we can update the wording on twn.
[15:23:58] <manybubbles>	 I'm happy to update that commit if you have a better description
[15:23:58] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] "Thanks" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104027 (owner: 10Manybubbles)
[15:23:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add missing i18n note [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104027 (owner: 10Manybubbles)
[15:27:41] <grrrit-wm>	 (03PS1) 10Cmcmahon: update for new collapse display [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104039 
[15:30:43] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/104039 (owner: 10Cmcmahon)
[15:32:04] <grrrit-wm>	 (03CR) 10Siebrand: "I've added Niklas and Santhosh as reviewers. They are better able to review JS than I am." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/102679 (owner: 10Raimond Spekking)
[15:36:27] <grrrit-wm>	 (03CR) 10Parent5446: [C: 032 V: 032] Replace usage of SpecialPage::getTitle with getPageTitle [extensions/SecureSessions] - 10https://gerrit.wikimedia.org/r/103982 (owner: 10Legoktm)
[15:38:15] <grrrit-wm>	 (03CR) 10Parent5446: [C: 032] Remove hints to fixed bug 54044 [core] - 10https://gerrit.wikimedia.org/r/104019 (owner: 10Umherirrender)
[15:41:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove hints to fixed bug 54044 [core] - 10https://gerrit.wikimedia.org/r/104019 (owner: 10Umherirrender)
[15:42:52] <grrrit-wm>	 (03CR) 10Anomie: [C: 032] Moved ScopedCallback to /libs [core] - 10https://gerrit.wikimedia.org/r/102080 (owner: 10Aaron Schulz)
[15:46:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Moved ScopedCallback to /libs [core] - 10https://gerrit.wikimedia.org/r/102080 (owner: 10Aaron Schulz)
[15:46:37] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] "Thanks." [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/103230 (owner: 10MegaAlex)
[15:46:46] <grrrit-wm>	 (03CR) 10Siebrand: [V: 032] i18n: Add GENDER support to phalanx-display-row-created [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/103230 (owner: 10MegaAlex)
[15:48:55] <grrrit-wm>	 (03CR) 10Parent5446: Add preferences checkbox to email text of watched deleted pages (032 comments) [core] - 10https://gerrit.wikimedia.org/r/101443 (owner: 10leucosticte)
[15:49:38] <grrrit-wm>	 (03CR) 10Parent5446: [C: 032] Remove long deprecated methods from Linker [core] - 10https://gerrit.wikimedia.org/r/104033 (owner: 10Siebrand)
[15:52:19] <grrrit-wm>	 (03PS1) 10Nuria: Adding user agent logging for event logging server side events. Goal is to augment the event capsule and provide a way to log and handle user agent that is consistent for all events. [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/104040 
[15:52:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Adding user agent logging for event logging server side events. Goal is to augment the event capsule and provide a way to log and handle user agent that is consistent for all events. [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/104040 (owner: 10Nuria)
[15:52:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove long deprecated methods from Linker [core] - 10https://gerrit.wikimedia.org/r/104033 (owner: 10Siebrand)
[15:56:47] <grrrit-wm>	 (03PS1) 10Siebrand: Remove Exif::makeFormattedData and Exif::getFormattedData [core] - 10https://gerrit.wikimedia.org/r/104042 
[15:57:51] <grrrit-wm>	 (03PS2) 10Siebrand: Remove Exif::makeFormattedData and Exif::getFormattedData [core] - 10https://gerrit.wikimedia.org/r/104042 
[15:58:23] <grrrit-wm>	 (03PS2) 10MegaAlex: i18n: Add PLURAL/GENDER support to revreview-reject-summary-* [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/103119 
[16:04:09] <grrrit-wm>	 (03CR) 10Hoo man: [C: 04-1] Remove Exif::makeFormattedData and Exif::getFormattedData (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104042 (owner: 10Siebrand)
[16:05:32] <Nemo_bis>	 MegaAlex: just in case you don't know, there are always more i18n tasks to complete, even before they're officially assigned to you ;)
[16:07:07] <grrrit-wm>	 (03PS1) 10Siebrand: Release notes for remove and renamed classes [core] - 10https://gerrit.wikimedia.org/r/104043 
[16:10:32] <tonythomas01>	 where shall we push the changes we make to Acawiki components like BibTeximport ?
[16:10:55] <MegaAlex>	 Nemo_bis: I have started working on a "Make MediaWiki documentation tranlatable" task and I am waiting for my current task to be closed so I can ask for a review :)
[16:11:25] <grrrit-wm>	 (03PS3) 10Siebrand: Remove Exif::makeFormattedData and Exif::getFormattedData [core] - 10https://gerrit.wikimedia.org/r/104042 
[16:11:27] <grrrit-wm>	 (03CR) 10Siebrand: Remove Exif::makeFormattedData and Exif::getFormattedData (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104042 (owner: 10Siebrand)
[16:12:55] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "Seems sensible" [core] - 10https://gerrit.wikimedia.org/r/104042 (owner: 10Siebrand)
[16:13:55] <Nemo_bis>	 MegaAlex: I see; you should please write on https://www.mediawiki.org/wiki/Project:Language_policy/Migration_list what pages you're working on, so that I see them
[16:14:24] <Nemo_bis>	 you chose a big one ^^
[16:16:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove Exif::makeFormattedData and Exif::getFormattedData [core] - 10https://gerrit.wikimedia.org/r/104042 (owner: 10Siebrand)
[16:17:14] <grrrit-wm>	 (03CR) 10Chad: [C: 031] Fix profiling method calls [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104031 (owner: 10Manybubbles)
[16:24:33] <udayan>	 Cloning into core shows permission disbaled(public key) where cloning into extensions was sucesful via ssh.Can anyone help me to figure it out?
[16:27:31] <grrrit-wm>	 (03PS1) 10Siebrand: Remove deprecated methods from Revision, SkinTemplate, and WikiPage [core] - 10https://gerrit.wikimedia.org/r/104048 
[16:27:44] <grrrit-wm>	 (03PS1) 10Siebrand: Type cast formatted time [core] - 10https://gerrit.wikimedia.org/r/104049 
[16:28:45] <grrrit-wm>	 (03PS2) 10Siebrand: Type cast formatted time [core] - 10https://gerrit.wikimedia.org/r/104049 
[16:30:26] <grrrit-wm>	 (03CR) 10Hoo man: "mh... this is a obvious implicit type conversion... I'm not convinced" [core] - 10https://gerrit.wikimedia.org/r/104049 (owner: 10Siebrand)
[16:31:47] <grrrit-wm>	 (03CR) 10Siebrand: "It obviously wasn't implicit to the code analyser..." [core] - 10https://gerrit.wikimedia.org/r/104049 (owner: 10Siebrand)
[16:35:24] <grrrit-wm>	 (03PS1) 10Siebrand: Remove unreachable statement [core] - 10https://gerrit.wikimedia.org/r/104050 
[16:36:10] <tonythomas01>	 udayan: Please tell what is the exact error message you are getting on cloning the core 
[16:36:31] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] Remove unreachable statement [core] - 10https://gerrit.wikimedia.org/r/104050 (owner: 10Siebrand)
[16:36:52] <udayan_>	 tonythomas01: The as vishnu
[16:36:53] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] "Cool, thanks." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104031 (owner: 10Manybubbles)
[16:37:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix profiling method calls [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104031 (owner: 10Manybubbles)
[16:37:12] <udayan_>	 same as vishnu
[16:37:25] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "Tested with both current MediaWiki and a version w/o the new functions." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104009 (owner: 10Legoktm)
[16:37:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Restore b/c for pre-1.23 MediaWiki versions [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/104009 (owner: 10Legoktm)
[16:40:13] <udayan_>	  Cloning into core shows permission disbaled(public key) where cloning into extensions was sucesful via ssh.Can anyone help me to figure it out?
[16:40:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unreachable statement [core] - 10https://gerrit.wikimedia.org/r/104050 (owner: 10Siebrand)
[16:41:09] <grrrit-wm>	 (03CR) 10Ori.livneh: Adding user agent logging for event logging server side events. Goal is to augment the event capsule and provide a way to log and handle use (032 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/104040 (owner: 10Nuria)
[16:42:15] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "Seems sensible" [core] - 10https://gerrit.wikimedia.org/r/104035 (owner: 10Siebrand)
[16:42:56] <tonythomas01>	 udayan: please give the command you used to clone core 
[16:44:57] <udayan__>	 sudo git clone ssh://vishnu@gerrit.wikimedia.org:29418/mediawiki/core.git
[16:45:07] <tonythomas01>	 udayan: you tried without using sudo ?
[16:45:16] <udayan>	 yea
[16:45:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove deprecated SpecialRevisionDelete::extractBitField() [core] - 10https://gerrit.wikimedia.org/r/104035 (owner: 10Siebrand)
[16:46:22] <tonythomas01>	 udayan: and to clone extensions ?
[16:46:29] <udayan>	 yes it cloned perfectly
[16:47:39] <udayan>	 i was able to clone the extensions but not core 
[16:47:59] <tonythomas01>	 udayan: please paste the command you used to clone the extension 
[16:48:24] <udayan>	 git clone ssh://vishnu@gerrit.wikimedia.org:29418/mediawiki/extensions/Math.git
[16:50:41] <udayan_>	 are you able to figure it out?
[16:52:42] <mayankmadan>	 liangent, hi
[16:54:44] <tonythomas01>	 udayan_: I dont think I will be able to help you in that case, because you seem to be able to clone your extension so right and not the core. I think someone else here may be able to help. Try going through https://www.mediawiki.org/wiki/Download_from_Git
[16:54:59] <tonythomas01>	 udayan_: and if nothing happens, clone via https 
[16:56:06] <udayan_>	 thank you sir. Le me go through that
[16:56:45] <mayankmadan>	 liangent, online?
[16:57:06] <grrrit-wm>	 (03PS2) 10IAlex: Don't pass $this by reference to SkinVectorStyleModules hook. [core] - 10https://gerrit.wikimedia.org/r/101651 
[16:57:27] <grrrit-wm>	 (03PS3) 10IAlex: Don't pass $this by reference to SkinVectorStyleModules hook. [core] - 10https://gerrit.wikimedia.org/r/101651 
[17:01:01] <grrrit-wm>	 (03PS10) 10IAlex: Update Special:ChangePassword to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/80411 
[17:02:10] <grrrit-wm>	 (03PS2) 10IAlex: Don't escape the mail's subject in Special:PasswordReset [core] - 10https://gerrit.wikimedia.org/r/94816 
[17:03:10] <grrrit-wm>	 (03PS2) 10IAlex: Only put returnto parameter if needed on the from-http redirect in Special:Userlogin [core] - 10https://gerrit.wikimedia.org/r/97078 
[17:03:11] <grrrit-wm>	 (03PS1) 10Siebrand: Update documentation for QueryPage::execute() [core] - 10https://gerrit.wikimedia.org/r/104053 
[17:03:26] <grrrit-wm>	 (03PS1) 10Siebrand: Update documentation for ApiQueryWatchlist::parseRCType() [core] - 10https://gerrit.wikimedia.org/r/104054 
[17:03:26] <grrrit-wm>	 (03PS1) 10Siebrand: Add missing return value for DatabaseBase::open() overrides [core] - 10https://gerrit.wikimedia.org/r/104055 
[17:03:26] <grrrit-wm>	 (03PS1) 10Siebrand: Throw exception when ArchivedFile::getUser() has unkown type [core] - 10https://gerrit.wikimedia.org/r/104056 
[17:03:26] <grrrit-wm>	 (03PS1) 10Siebrand: Update documentation for WebInstaller_DBConnect::execute() [core] - 10https://gerrit.wikimedia.org/r/104057 
[17:03:26] <grrrit-wm>	 (03PS1) 10Siebrand: Throw exception for unknown field in SpecialListfiles::formatValue() [core] - 10https://gerrit.wikimedia.org/r/104058 
[17:05:12] <grrrit-wm>	 (03PS1) 10Siebrand: Add release notes for I9c9f5bb8af [core] - 10https://gerrit.wikimedia.org/r/104059 
[17:05:32] <grrrit-wm>	 (03PS2) 10Siebrand: Throw exception for unknown field in SpecialListfiles::formatValue() [core] - 10https://gerrit.wikimedia.org/r/104058 
[17:05:52] <grrrit-wm>	 (03PS2) 10Siebrand: Update documentation for WebInstaller_DBConnect::execute() [core] - 10https://gerrit.wikimedia.org/r/104057 
[17:05:52] <grrrit-wm>	 (03PS2) 10Siebrand: Throw exception when ArchivedFile::getUser() has unkown type [core] - 10https://gerrit.wikimedia.org/r/104056 
[17:05:58] <grrrit-wm>	 (03PS2) 10Siebrand: Add missing return value for DatabaseBase::open() overrides [core] - 10https://gerrit.wikimedia.org/r/104055 
[17:06:12] <grrrit-wm>	 (03PS2) 10Siebrand: Update documentation for ApiQueryWatchlist::parseRCType() [core] - 10https://gerrit.wikimedia.org/r/104054 
[17:20:23] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] Add release notes for I9c9f5bb8af [core] - 10https://gerrit.wikimedia.org/r/104059 (owner: 10Siebrand)
[17:22:27] <grrrit-wm>	 (03PS2) 10Milimetric: Implementing mediawiki oauth for node [passport-mediawiki] - 10https://gerrit.wikimedia.org/r/103866 
[17:22:56] <grrrit-wm>	 (03CR) 10MarkTraceur: Allow mediawiki ui resource loader module to target mobile (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/102977 (owner: 10Jdlrobson)
[17:24:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add release notes for I9c9f5bb8af [core] - 10https://gerrit.wikimedia.org/r/104059 (owner: 10Siebrand)
[17:26:28] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] "Dumb question, but what happens when *none* of the required skins are installed? "Sorry, you need one of these skins to use this feature:<" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/102383 (owner: 10Legoktm)
[17:28:08] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] "Based on product-y discussion, I think James will want to -2 this for now." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100519 (owner: 10Legoktm)
[17:31:31] <grrrit-wm>	 (03CR) 10Jdlrobson: Allow mediawiki ui resource loader module to target mobile (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/102977 (owner: 10Jdlrobson)
[17:35:34] <marktraceur>	 No, why would jdlrobson be on IRC, he's only responding to code review
[17:35:54] <marktraceur>	 Woo timing.
[17:35:54] <marktraceur>	 jdlrobson: Have you tested that patch?
[17:35:55] <marktraceur>	 I have no idea how to go about it
[17:36:09] <jdlrobson>	 marktraceur: you can test it by installing mobile frontend switching to mobile on Special:Preferences
[17:36:14] <jdlrobson>	 (assuming you are talking about beta features one)
[17:36:35] <marktraceur>	 Agh, steps.
[17:37:28] <marktraceur>	 And yeah, that's the one
[17:37:55] <marktraceur>	 Watch MobileFrontend break my wiki
[17:39:16] <marktraceur>	 jdlrobson: Where in Special:Preferences?
[17:39:37] <jdlrobson>	 in the beta features section :)
[17:39:37] <jdlrobson>	 with that patch it looks styled
[17:39:37] <jdlrobson>	 without it it is not
[17:40:17] <marktraceur>	 Oh
[17:40:34] <marktraceur>	 jdlrobson: Uh, how do I switch to mobile?
[17:40:34] <jdlrobson>	 try appending useformat=mobile
[17:40:34] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Replace usage of SpecialPage::getTitle with getPageTitle [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/104008 (owner: 10Legoktm)
[17:40:35] <jdlrobson>	 probably easiest way (to url)
[17:40:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/104008 (owner: 10Legoktm)
[17:40:58] <marktraceur>	 Wow, that does indeed look butt ugly
[17:41:18] * marktraceur  nearly typed ButtaFeatures just now, that's how bad it is

[17:41:18] <grrrit-wm>	 (03CR) 10Skizzerz: [C: 04-2] "The mainline (master branch) of Maintenance needs to be able to support at a minimum all currently supported versions of MediaWiki (which " [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/103951 (owner: 10Legoktm)
[17:42:19] <marktraceur>	 Aaaand now it's slightly (but only very slightly) better!
[17:42:39] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/103938 (owner: 10Legoktm)
[17:42:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/103938 (owner: 10Legoktm)
[17:43:16] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "Sweet, tested, works." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/102977 (owner: 10Jdlrobson)
[17:43:16] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Collection] - 10https://gerrit.wikimedia.org/r/103915 (owner: 10Legoktm)
[17:43:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Allow mediawiki ui resource loader module to target mobile [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/102977 (owner: 10Jdlrobson)
[17:43:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Collection] - 10https://gerrit.wikimedia.org/r/103915 (owner: 10Legoktm)
[17:44:20] <mayankmadan>	 marktraceur, can you do this review? https://gerrit.wikimedia.org/r/#/c/103967/ if you are free
[17:44:40] <marktraceur>	 mayankmadan: Of course I'm free. 'murica.
[17:44:57] <marktraceur>	 Ahhhhh Flickr code
[17:44:57] <marktraceur>	 I'm less capable of this, but I can at least review the code
[17:48:39] <mayankmadan>	 marktraceur, then what about this one? http://www.google-melange.com/gci/task/view/google/gci2013/5803059699515392
[17:48:42] <gcibot>	 Improve "Share this text selection" in Kiwix
[17:48:43] <gcibot>	 Status: Reopened
[17:48:43] <gcibot>	 Mentor(s): Kelson
[17:49:49] <grrrit-wm>	 (03CR) 10Mayankmadan: Functionality to create a new image in upload-wizard_tests.py (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan)
[17:50:45] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 031] "A few comments about the surrounding code, but otherwise it looks fine to me." (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103967 (owner: 10Mayankmadan)
[17:55:06] <theopolisme>	 JeffHall: Hi! Sorry about that little bug :p
[17:56:23] <theopolisme>	 https://gist.github.com/theopolisme/8143834 should be okay now
[17:58:15] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Add missing return value for DatabaseBase::open() overrides [core] - 10https://gerrit.wikimedia.org/r/104055 (owner: 10Siebrand)
[17:59:11] <JeffHall>	 theopolisme: Great - will take a look in just a few minutes
[18:00:40] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Remove unused local variables [core] - 10https://gerrit.wikimedia.org/r/103882 (owner: 10Siebrand)
[18:01:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add missing return value for DatabaseBase::open() overrides [core] - 10https://gerrit.wikimedia.org/r/104055 (owner: 10Siebrand)
[18:03:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unused local variables [core] - 10https://gerrit.wikimedia.org/r/103882 (owner: 10Siebrand)
[18:03:40] * siebrand  thanks AaronSchulz 

[18:06:19] <mayankmadan>	 marktraceur, i meant this one https://gerrit.wikimedia.org/r/#/c/104012/
[18:06:36] <marktraceur>	 Ah, that's gonna be easier :)
[18:06:37] <JeffHall>	 theopolisme: Your fix looks great - I just closed the GCI task.  Thanks for working on that!
[18:07:23] <grrrit-wm>	 (03PS1) 10Umherirrender: Use Title::isWatchable in ApiWatch [core] - 10https://gerrit.wikimedia.org/r/104060 
[18:08:57] <theopolisme>	 JeffHall: happy to! Hopefully I can do some tasks with you in the future
[18:08:57] <theopolisme>	 *some more, that is
[18:11:22] <grrrit-wm>	 (03PS1) 10Vishnunk90: Fix depreciation warnings in FileBackend construction Added wikiId and lockManager was changed to an object Bug: 58615 [extensions/Math] - 10https://gerrit.wikimedia.org/r/104061 
[18:12:13] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] verifyUpload should be called before checkWarnings (033 comments) [core] - 10https://gerrit.wikimedia.org/r/104012 (owner: 10Mayankmadan)
[18:12:21] <marktraceur>	 mayankmadan: {{done}} :)
[18:19:05] <grrrit-wm>	 (03PS9) 10Siebrand: Replace <i> and <b> by <em> and <strong> in i18n [core] - 10https://gerrit.wikimedia.org/r/99195 
[18:19:22] <dan-nl>	 Reedy: do you have time to take a look at https://gerrit.wikimedia.org/r/#/c/103561/ ?
[18:21:49] <grrrit-wm>	 (03PS1) 10Andrew Bogott: Sort role members in a few places. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/104062 
[18:24:49] <grrrit-wm>	 (03PS2) 10Siebrand: Add TODOs for missing return statements [core] - 10https://gerrit.wikimedia.org/r/104022 
[18:30:54] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/103928 (owner: 10Legoktm)
[18:30:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace usage of SpecialPage::getTitle with getPageTitle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/103928 (owner: 10Legoktm)
[18:33:36] <grrrit-wm>	 (03PS2) 10Nemo bis: Adding user agent logging for event logging server side events. Goal is to augment the event capsule and provide a way to log and handle user agent that is consistent for all events. [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/104040 (owner: 10Nuria)
[18:33:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Adding user agent logging for event logging server side events. [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/104040 (owner: 10Nuria)
[18:36:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/104093 (owner: 10L10n-bot)
[18:36:38] <grrrit-wm>	 (03PS1) 10MarkAHershberger: Add the option to pull a particular branch of an extension. [vagrant] - 10https://gerrit.wikimedia.org/r/104095 
[18:37:19] <siebrand>	 AaronSchulz: I'm having issues with the translatewiki.net queue running.
[18:37:19] <siebrand>	 runner
[18:37:39] <siebrand>	 AaronSchulz: I currently have my job runners set to 550M max, and they still run out of memory.
[18:37:47] <siebrand>	 AaronSchulz: It's processing 3.2M jobs for SemanticMediaWiki.
[18:38:02] <AaronSchulz>	 with OOM or the pre-emptive exception?
[18:38:22] <siebrand>	 I've added a little patch in b/maintenance/runJobs.php ~260:
[18:38:40] <siebrand>	 +               $usedBytes = number_format( $usedBytes / 1048576, 1 );
[18:38:40] <siebrand>	 +               echo "{$usedBytes}MB\n";
[18:38:46] <siebrand>	 AaronSchulz: I see the used memory slowly rising.
[18:39:02] <siebrand>	 137.3MB max now
[18:39:10] <siebrand>	 With a low of 86.1MB
[18:39:40] <siebrand>	 AaronSchulz: It appears that some things are not getting cleaned up.
[18:39:59] <siebrand>	 AaronSchulz: Which causes the memory that is being used to grow with every job that is completed.
[18:40:21] <siebrand>	 145.3MB now.
[18:40:31] <siebrand>	 It's doing about 80 jobs/second now.
[18:42:43] <siebrand>	 163.1MB
[18:42:43] <grrrit-wm>	 (03CR) 10Andrew Bogott: "tested on wikitech-test, works fine." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/104062 (owner: 10Andrew Bogott)
[18:43:06] <siebrand>	 AaronSchulz: is there anything I can do to provide information to debug this further?
[18:43:43] <grrrit-wm>	 (03CR) 10Andrew Bogott: [C: 032] Sort role members in a few places. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/104062 (owner: 10Andrew Bogott)
[18:43:43] <grrrit-wm>	 (03CR) 10Andrew Bogott: [V: 032] Sort role members in a few places. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/104062 (owner: 10Andrew Bogott)
[18:44:14] <grrrit-wm>	 (03PS3) 10Milimetric: Implementing mediawiki oauth for node [passport-mediawiki] - 10https://gerrit.wikimedia.org/r/103866 
[18:44:24] <AaronSchulz>	 siebrand: why don't you have a script keep spawning runJobs.php with --maxjobs?
[18:44:44] <siebrand>	 AaronSchulz: We do. For 1000 jobs.
[18:44:44] <grrrit-wm>	 (03PS2) 10Siebrand: Remove deprecated methods from Revision, SkinTemplate, and WikiPage [core] - 10https://gerrit.wikimedia.org/r/104048 
[18:45:05] <siebrand>	 AaronSchulz: And a minute of runtime.
[18:45:05] <siebrand>	 AaronSchulz: And that OOMs out with the 150MB limit core enforces.
[18:45:05] <AaronSchulz>	 huh, I was running refreshLinks for hours on terbium before it OOMed
[18:45:25] <siebrand>	 AaronSchulz: That's what got this experiment started...
[18:45:45] <AaronSchulz>	 and hours I mean like a day
[18:46:22] <siebrand>	 AaronSchulz: We have this: php /www/translatewiki.net/w/maintenance/runJobs.php --exclusive --maxtime=50 --procs=1 --memory-limit=250M
[18:47:06] <siebrand>	 AaronSchulz: The 50 is seconds, right?
[18:47:13] * AaronSchulz  wasted a lot of time trying to debug refreshLinks memory leaks...never found it

[18:47:26] <AaronSchulz>	 it probably depends on parsing certain pages that trigger some extension
[18:47:46] <siebrand>	 AaronSchulz: I think Nikerabbit and I spent a lot of time one something with memory and job queue before, too.
[18:50:49] * AaronSchulz  didn't see the $wg* vars getting much bigger (the $wgHooks would get a little bigger and plateau)

[18:51:09] <AaronSchulz>	 the xdebug output didn't have memory in the cachegrind viewer :(
[18:51:29] <AaronSchulz>	 I guess the data just had time/method stuff
[18:51:29] <grrrit-wm>	 (03CR) 10Gergő Tisza: Functionality to create a new image in upload-wizard_tests.py (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan)
[18:53:30] <siebrand>	 AaronSchulz: 234.7MB now
[18:53:44] <siebrand>	 AaronSchulz: all SMW\UpdateJob
[18:53:51] <grrrit-wm>	 (03PS1) 10MarkAHershberger: Add key for ubuntu git maintainers [vagrant] - 10https://gerrit.wikimedia.org/r/104123 
[18:54:11] <AaronSchulz>	 that probably does parse right? So that could be a lot of things
[18:56:13] <siebrand>	 AaronSchulz: *nod* Lots of methods there with Parse
[18:59:15] <marktraceur>	 Uhhhh
[18:59:35] <marktraceur>	 Is Jenkins-bot not running?
[18:59:35] <marktraceur>	 Oh, never mind, there it goes
[19:00:15] <grrrit-wm>	 (03PS1) 10Manybubbles: Prioritize single page edits over template changes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104124 
[19:01:07] <dan-nl>	 AaronSchulz: have you had a chance to review https://bugzilla.wikimedia.org/show_bug.cgi?id=58692
[19:01:37] <dan-nl>	 AaronSchulz: i tried issuing another batch job at 18:32 utc, but it still hasn't been picked up
[19:01:57] <dan-nl>	 AaronSchulz: gwtoolsetUploadMetadataJob: 0 queued; 2 claimed (1 active, 1 abandoned); 0 delayed
[19:02:44] <dan-nl>	 have no idea why 1 was abandoned and i don't see any activity in the runJobs.log for that active MetadataJob
[19:06:20] <grrrit-wm>	 (03PS2) 10EBernhardson: Remove dupicate scrollTo event for topic reply link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103593 (owner: 10Bsitu)
[19:06:24] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] "PS2: rebased" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103593 (owner: 10Bsitu)
[19:07:07] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Add SVG versions of enhanced recent changes collapse/show arrows (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96372 (owner: 10M4tx)
[19:10:55] <grrrit-wm>	 (03PS2) 10Manybubbles: Prioritize single page edits over template changes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104124 
[19:20:51] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] Add SVG versions of enhanced recent changes collapse/show arrows (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96372 (owner: 10M4tx)
[19:21:54] <aalekhN>	 Hey Guys i am trying to develop an extension ....i had a doubt....Can i insert <script> tag in mediawiki extension using echo(php )  ???
[19:22:32] <VladAndrew>	 Nemo_bis: hey, I would like to work on this page https://www.mediawiki.org/w/index.php?title=Help:Talk_page I have made the changes
[19:22:32] <thedj>	 aalekhN: you should use resourceloader
[19:23:12] <thedj>	 aalekhN: https://www.mediawiki.org/wiki/ResourceLoader/Developing_with_ResourceLoader
[19:24:33] <VladAndrew>	 any translation administrator online ?
[19:24:33] <VladAndrew>	 I have made my changes on this page https://www.mediawiki.org/w/index.php?title=Help:Talk_page 
[19:25:14] <aalekhN>	 is their any way to include font file of extension eot ,svg,woff  ....because i am trying to make extension with videojs support and it need them????
[19:25:14] <grrrit-wm>	 (03CR) 10Anomie: [C: 032] Use Title::isWatchable in ApiWatch [core] - 10https://gerrit.wikimedia.org/r/104060 (owner: 10Umherirrender)
[19:25:54] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Add SVG versions of enhanced recent changes collapse/show arrows (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96372 (owner: 10M4tx)
[19:25:54] <thedj>	 aalekhN: sure, it's just css
[19:26:35] <Nemo_bis>	 VladAndrew: why don't you just edit the list :(
[19:27:16] <VladAndrew>	 Nemo_bis: I have made the edits
[19:27:30] <VladAndrew>	 Nemo_bis: it says panding for review
[19:27:58] <Nemo_bis>	 this doesn't make sense: </nowiki></tt><br/></translate>
[19:28:36] <Nemo_bis>	 the list is this and you didn't edit it, if you edit it we're notified but if you don't few see your work if any https://www.mediawiki.org/wiki/Project:Language_policy/Migration_list?action=history
[19:29:35] <aalekhN>	 thedj:means i should include them as follow:http://pastebin.com/sNPgXGfz
[19:30:38] <thedj>	 no no no
[19:30:58] <Nemo_bis>	 VladAndrew: you need to improve the splitting/segmentation, some units are very long and there's a lot of unneeded markup between translate tags, as in the example above
[19:30:58] <Nemo_bis>	 good for the templates
[19:31:19] <VladAndrew>	 I'll make the changes right away, I'll let you know when I am done
[19:31:39] <thedj>	 aalekhN: you need to specify a css file there, that defines the url of the font to use
[19:33:00] <aalekhN>	 thedj:dependencies could be possible solution to it
[19:33:40] <thedj>	 dependencies are not needed for this
[19:34:20] <dan-nl>	 AaronSchulz: why would a job on beta stay in active state and never clear out or show any info in the runJobs.log ?
[19:34:20] <thedj>	 just put the fonts in a place where a client can download them, and use the @font-face rule in a css file.
[19:36:01] <thedj>	 aalekhN: also, it's styles, not styless of course
[19:36:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove dupicate scrollTo event for topic reply link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103593 (owner: 10Bsitu)
[19:37:23] <aalekhN>	 yeah :p
[19:40:04] <jdlrobson>	 i upgraded gerrit and now think i have hit a bug - anyone know how to fix? git checkout master / git checkout -b foo / git review / "You are about to submit multiple commits" < there should be nothing to review!!
[19:42:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use Title::isWatchable in ApiWatch [core] - 10https://gerrit.wikimedia.org/r/104060 (owner: 10Umherirrender)
[19:43:34] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] "Few issues, deferreds are a little more tricky than we may have thought." (036 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50755 (owner: 10Nischayn22)
[19:45:08] <dan-nl>	 jdlrobson: in branch foo or master try … git fetch --all
[19:46:49] <dan-nl>	 from what i understand review need to update its references with gerrit. if your only remote is gerrit you can also just issue git fetch gerrit
[19:47:55] <ebernhardson>	 yup, thats an old bug
[19:47:58] <VladAndrew>	 Nemo_bis: I have resolved the problems but even if I have <languages/> the language bar isn't there
[19:49:13] <Nemo_bis>	 VladAndrew: it appears only after the page is marked
[19:50:10] <^d>	 dan-nl: Fun trick, `git fetch --al` also works if you get tired of the extra keystroke :)
[19:50:17] <VladAndrew>	 Nemo_bis: how do I mark it ?
[19:50:48] <VladAndrew>	 oh yes, someone else should mark it 
[19:50:51] <dan-nl>	 :)
[19:51:04] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "lets do it!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/103853 (owner: 10Manybubbles)
[19:51:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Setup unit tests for cirrus [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/103853 (owner: 10Manybubbles)
[19:51:20] <grrrit-wm>	 (03CR) 10MarkTraceur: "For the record, we have moved this into BetaFeatures but would much rather have it in core. It's generally useful enough, IMO." [core] - 10https://gerrit.wikimedia.org/r/75143 (owner: 10MarkTraceur)
[19:52:03] <hashar>	 manybubbles: getting your CirrusSearch tests enabled in Zuul
[19:52:09] <Nemo_bis>	 VladAndrew: give me a moment
[19:52:12] <manybubbles>	 hashar: thanks!
[19:52:30] <hashar>	 manybubbles: should be good now :-D
[19:52:47] <Nemo_bis>	 a few other translation admins were supposed to help me, but undisciplined students don't edit the list so I'm the only who sees ;)
[19:52:54] <VladAndrew>	 Nemo_bis: Take your time
[19:53:16] <grrrit-wm>	 (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT).. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/70205 (owner: 10Hashar)
[19:53:20] <grrrit-wm>	 (03PS4) 10Hashar: Jenkins job validation (DO NOT SUBMIT).. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/70205 
[19:53:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT).. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/70205 (owner: 10Hashar)
[19:54:31] <grrrit-wm>	 (03PS5) 10Hashar: Jenkins job validation (DO NOT SUBMIT).. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/70205 
[19:54:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT).. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/70205 (owner: 10Hashar)
[19:54:43] <Nemo_bis>	 VladAndrew: why did you put this up for translation? 
[19:55:23] <jdlrobson>	 dan-nl: you're a star :D
[19:55:28] <hashar>	 manybubbles: unfortunately phpunit tests fails because they can't load mysqlnd extension :(  https://integration.wikimedia.org/ci/job/mwext-CirrusSearch-testextensions-master/1/console
[19:55:36] <VladAndrew>	 Nemo_bis: it is on this list https://www.mediawiki.org/wiki/Project:Language_policy/Migration_list
[19:55:49] <Nemo_bis>	 VladAndrew: paste fail
[19:55:57] <Nemo_bis>	 this: <div style="font-size: 150%; margin: 0; padding-top: .5em; padding-bottom: .17em; border-bottom: 1px solid #aaa;">
[19:56:01] <manybubbles>	 hashar: I'm not really sure what to do about that.  I don't know that we use it directly.
[19:56:02] <Nemo_bis>	 and |}
[19:56:41] <Nemo_bis>	 and ";Split a post into several discussions" should be together with its "explanation" :It may be appropriate to do this, if somebody has raised several points that need to be answered separately. However, you should always be respectful of other people's words. Does their post still make sense if you split it up?
[19:56:46] <hashar>	 manybubbles: that is just a warning anyway.
[19:57:03] <Nemo_bis>	 also this has nothing to translate: <div class="usermessage plainlinks">{{int:youhavenewmessages|[[{{ns:3}}:User|<span style="color:#002bb8">{{int:newmessageslink}}</span>]]|[{{fullurl:{{ns:3}}:User&diff=cur}} <span style="color:#002bb8">{{int:newmessagesdifflink}}</span>]}}</div>
[19:57:17] <hashar>	 manybubbles: the real error is an invalid callback being used for UnitTestsList hook, that throw an exception
[19:57:28] <VladAndrew>	 Nemo_bis: I'll resolve them but you have provided me with this link https://www.mediawiki.org/wiki/Project:Language_policy/Migration_list?action=history 
[19:57:28] <manybubbles>	 hashar: Invalid callback in hooks for UnitTestsList
[19:57:31] <manybubbles>	 I'll look at it
[19:57:40] <VladAndrew>	 how do I actually call other administrators ?
[19:58:06] <Nemo_bis>	 VladAndrew: just edit the list and add <s></s> around the page title or whatever
[19:58:26] <Nemo_bis>	 but don't check the minor edit checkbox
[20:00:53] <hashar>	 manybubbles: I am out, jenkins would whine meanwhile and vote -1.    The issue is that the method registered for the hook does not exist  :-D  Some typo needs to be fixed I guess
[20:01:06] <Nemo_bis>	 good VladAndrew 
[20:01:11] <hashar>	 manybubbles: feel free to email again and will follow up tomorrow. For now, gotta get some sleep
[20:01:18] <manybubbles>	 hashar: thanks!
[20:01:20] <manybubbles>	 sleep well
[20:01:24] <VladAndrew>	 I'm resoling the problems now, give me a minute
[20:01:39] <VladAndrew>	 thanks for the help
[20:02:29] <VladAndrew>	 Nemo_bis: done
[20:04:12] <grrrit-wm>	 (03PS1) 10Manybubbles: Fix unit tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104127 
[20:04:46] <grrrit-wm>	 (03CR) 10Manybubbles: "It looks like we had a typo on unit test setup. It should work if we merge this." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104127 (owner: 10Manybubbles)
[20:05:35] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Fix unit tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104127 (owner: 10Manybubbles)
[20:05:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix unit tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104127 (owner: 10Manybubbles)
[20:07:58] <grrrit-wm>	 (03PS1) 10Theopolisme: Provide language variant data via the api [core] - 10https://gerrit.wikimedia.org/r/104128 
[20:08:27] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 032] adding a more appropriate user-agent [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/103561 (owner: 10Dan-nl)
[20:08:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: adding a more appropriate user-agent [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/103561 (owner: 10Dan-nl)
[20:09:32] <Nemo_bis>	 VladAndrew: I fixed a couple things myself but this doesn't look well https://www.mediawiki.org/wiki/Help:Talk_pages#Example
[20:10:06] <Nemo_bis>	 it's better if you just use double newlines for splitting, in that section the escaping is all wrong
[20:11:03] <grrrit-wm>	 (03CR) 10Siebrand: Provide language variant data via the api (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104128 (owner: 10Theopolisme)
[20:11:36] <grrrit-wm>	 (03PS1) 10Ryan Lane: Initial fixes for cross-regional support [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/104129 
[20:12:35] <MegaAlex>	 Nemo_bis: how and when are the english page translation messages updated? I have changed some messages.
[20:13:46] <grrrit-wm>	 (03PS2) 10Ryan Lane: Initial fixes for cross-regional support [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/104129 
[20:15:41] <MegaAlex>	 oh, nvm. I was looking at the wrong thing...
[20:15:45] <Nemo_bis>	 MegaAlex: I just marked one of your changes, you now need to re-translate the unit you added (ie re-import its translations)
[20:16:22] <MegaAlex>	 oh, ok. Thanks!
[20:17:11] <VladAndrew>	 Nemo_bis: so the problem is in the Wiki text sqre yes ?
[20:18:17] <Nemo_bis>	 one should not see <translate> tags in the rendered text
[20:18:33] <VladAndrew>	 Nemo_bis: got it
[20:18:33] <VladAndrew>	 Nemo_bis: give me a second and I'll resolve all of them
[20:18:41] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Release notes for remove and renamed classes [core] - 10https://gerrit.wikimedia.org/r/104043 (owner: 10Siebrand)
[20:19:29] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "The skins/vector/images/watch-icon-loading.png file is still off by a pixel or a half. I'll just render it from the SVG you created and up" [core] - 10https://gerrit.wikimedia.org/r/99258 (owner: 10M4tx)
[20:19:30] <grrrit-wm>	 (03PS2) 10Siebrand: Release notes for remove and renamed classes [core] - 10https://gerrit.wikimedia.org/r/104043 
[20:19:30] <VladAndrew>	 Nemo_bis: I have to make them like this <translate><tt><nowiki> Bla bla
[20:19:41] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] "+2 per Chad (after fixing a typo in the commit message)" [core] - 10https://gerrit.wikimedia.org/r/104043 (owner: 10Siebrand)
[20:19:53] <VladAndrew>	 Nemo_bis: if transate if after <nowiki> it will be rendered as text
[20:21:35] <Nemo_bis>	 please refer to the manual...
[20:21:55] <Nemo_bis>	 if something's unclear there, ask on its talk page
[20:22:15] <VladAndrew>	 Nemo_bis: it works, isn't that the right way to do this ?
[20:23:37] <diwanship>	 hello yurik online?
[20:23:38] <VladAndrew>	 check it out, <translate> doesn't appear now
[20:23:56] <yurik>	 diwanship, yep
[20:25:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Release notes for removed and renamed classes [core] - 10https://gerrit.wikimedia.org/r/104043 (owner: 10Siebrand)
[20:25:58] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Remove last remainig use in core of Title::escapeFullURL() [core] - 10https://gerrit.wikimedia.org/r/104025 (owner: 10Siebrand)
[20:26:29] <diwanship>	 yurik i have one question. To show different functionalities for ex get last 5 revisions of a page and get first 5 revisions of a page , only one tutorial should cover the both functionalities or two different slides should be made?
[20:27:25] <yurik>	 diwanship, i think minor differences should be mentioned, but there is no need to do them in depth - we should assume some intelligence of our readers :)
[20:28:15] <yurik>	 so if first 5 vs last 5 requires a minor parameter change  - you could either mention it, or may even skip it alltogether - since that doesn't fundamentally change how api works
[20:28:40] <yurik>	 and someone interested in it could search through the documentation
[20:28:40] <grrrit-wm>	 (03CR) 10Physikerwelt: [C: 04-1] "for me it does not store the images correctly." [extensions/Math] - 10https://gerrit.wikimedia.org/r/104061 (owner: 10Vishnunk90)
[20:29:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove last remainig use in core of Title::escapeFullURL() [core] - 10https://gerrit.wikimedia.org/r/104025 (owner: 10Siebrand)
[20:30:42] <diwanship>	 yurik ok. 
[20:31:22] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Replace deprecated Linker::makeBrokenLink() [extensions/Interlanguage] - 10https://gerrit.wikimedia.org/r/104029 (owner: 10Siebrand)
[20:36:46] <VladAndrew>	 Nemo_bis: when you have time chek the page
[20:39:12] <grrrit-wm>	 (03PS3) 10TheDJ: Alternative idea to change: I5fe0543e273aab4fbfb88f8ce933bc49872d4793 [core] - 10https://gerrit.wikimedia.org/r/103066 
[20:45:12] <grrrit-wm>	 (03CR) 10MarkAHershberger: "That said, if you are using it, perhaps you can find someone willing to support it for core. I'm willing to help you look for someone if " [core] - 10https://gerrit.wikimedia.org/r/50764 (owner: 10Chad)
[20:46:54] <diwanship>	 yurik i have updated the lesson plan with the slides i made last week, you can visit any time
[20:52:03] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Or maybe it's the SVG that's off-center… I don't know myself now, but something is definitely not aligning here." [core] - 10https://gerrit.wikimedia.org/r/99258 (owner: 10M4tx)
[20:52:37] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 031] "Looks good; tiny quibble." (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/104095 (owner: 10MarkAHershberger)
[20:54:59] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 031] "Looks good; will merge once the previous patch is good to go." [vagrant] - 10https://gerrit.wikimedia.org/r/104123 (owner: 10MarkAHershberger)
[20:58:47] <grrrit-wm>	 (03PS1) 10Chad: Reduce insane amount of code duplication and long lines [core] - 10https://gerrit.wikimedia.org/r/104136 
[21:01:33] <grrrit-wm>	 (03PS1) 10Chad: Break some long lines [core] - 10https://gerrit.wikimedia.org/r/104137 
[21:04:27] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-1] "You can fetch variantarticlepath and the list of variants from action=query&prop=siteinfo&siprop=general. From this it appears that you ca" [core] - 10https://gerrit.wikimedia.org/r/104128 (owner: 10Theopolisme)
[21:10:10] <grrrit-wm>	 (03CR) 10Chad: "Have we ever had an actual DB2 user? :)" [core] - 10https://gerrit.wikimedia.org/r/50764 (owner: 10Chad)
[21:12:49] <grrrit-wm>	 (03CR) 10Physikerwelt: "ok it's not a fault of this change. I rebased math 2.0 against that and everything works as expected." [extensions/Math] - 10https://gerrit.wikimedia.org/r/104061 (owner: 10Vishnunk90)
[21:13:27] <grrrit-wm>	 (03CR) 10Aude: [C: 032] "much improved and looks fine" [core] - 10https://gerrit.wikimedia.org/r/104137 (owner: 10Chad)
[21:14:44] <grrrit-wm>	 (03CR) 10Aude: [C: 032] "much better" [core] - 10https://gerrit.wikimedia.org/r/104136 (owner: 10Chad)
[21:16:08] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 031] "Meh, everything is misaligned, but it lines up well enough. But I'll let someone else merge." [core] - 10https://gerrit.wikimedia.org/r/99258 (owner: 10M4tx)
[21:17:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Reduce insane amount of code duplication and long lines [core] - 10https://gerrit.wikimedia.org/r/104136 (owner: 10Chad)
[21:18:41] <grrrit-wm>	 (03CR) 10Theopolisme: "api.php?action=query&meta=siteinfo&siprop=general does not provide the *names* of the language variants (unless I'm mistaken), so we're le" [core] - 10https://gerrit.wikimedia.org/r/104128 (owner: 10Theopolisme)
[21:19:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Break some long lines [core] - 10https://gerrit.wikimedia.org/r/104137 (owner: 10Chad)
[21:20:42] <grrrit-wm>	 (03CR) 10Jdlrobson: "Variants are buried in action=query&prop=siteinfo&siprop=general and not obvious at all that they exist. You'd have to iterate through eve" [core] - 10https://gerrit.wikimedia.org/r/104128 (owner: 10Theopolisme)
[21:22:54] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Actually it turns out that this breaks stuff: New skin files (images etc.) seem to be matches by these rules. I'm going to revert this for" [core] - 10https://gerrit.wikimedia.org/r/88670 (owner: 10Huji)
[21:23:22] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Revert "Add .gitignore to the /skins directory" [core] - 10https://gerrit.wikimedia.org/r/104139 
[21:23:36] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Revert "Add .gitignore to the /skins directory" [core] - 10https://gerrit.wikimedia.org/r/104139 (owner: 10Bartosz Dziewoński)
[21:25:46] <grrrit-wm>	 (03CR) 10Siebrand: "https://integration.wikimedia.org/ci/job/mediawiki-core-regression-phpcs-HEAD/3452/console had 5 more long lines. Might have taken care of" [core] - 10https://gerrit.wikimedia.org/r/104137 (owner: 10Chad)
[21:27:24] <grrrit-wm>	 (03PS1) 10Anomie: API: Include variant name in meta=siteinfo [core] - 10https://gerrit.wikimedia.org/r/104140 
[21:28:00] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-2] "> api.php?action=query&meta=siteinfo&siprop=general does not provide the *names* of the language variants" [core] - 10https://gerrit.wikimedia.org/r/104128 (owner: 10Theopolisme)
[21:28:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Add .gitignore to the /skins directory" [core] - 10https://gerrit.wikimedia.org/r/104139 (owner: 10Bartosz Dziewoński)
[21:32:07] <grrrit-wm>	 (03PS61) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 
[21:36:23] <grrrit-wm>	 (03CR) 10Physikerwelt: [C: 032 V: 032] Fix depreciation warnings in FileBackend construction Added wikiId and lockManager was changed to an object Bug: 58615 [extensions/Math] - 10https://gerrit.wikimedia.org/r/104061 (owner: 10Vishnunk90)
[21:36:40] <grrrit-wm>	 (03PS62) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 
[21:37:12] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Remove deprecated methods from Revision, SkinTemplate, and WikiPage [core] - 10https://gerrit.wikimedia.org/r/104048 (owner: 10Siebrand)
[21:38:13] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Frankly, I don't see any use-cases for this apart from BetaFeatures." [core] - 10https://gerrit.wikimedia.org/r/75143 (owner: 10MarkTraceur)
[21:38:37] <grrrit-wm>	 (03PS2) 10Ori.livneh: Add the option to pull a particular branch of an extension. [vagrant] - 10https://gerrit.wikimedia.org/r/104095 (owner: 10MarkAHershberger)
[21:38:47] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Add the option to pull a particular branch of an extension. [vagrant] - 10https://gerrit.wikimedia.org/r/104095 (owner: 10MarkAHershberger)
[21:38:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add the option to pull a particular branch of an extension. [vagrant] - 10https://gerrit.wikimedia.org/r/104095 (owner: 10MarkAHershberger)
[21:38:56] <grrrit-wm>	 (03PS2) 10Ori.livneh: Add key for ubuntu git maintainers [vagrant] - 10https://gerrit.wikimedia.org/r/104123 (owner: 10MarkAHershberger)
[21:39:55] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Add key for ubuntu git maintainers [vagrant] - 10https://gerrit.wikimedia.org/r/104123 (owner: 10MarkAHershberger)
[21:39:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add key for ubuntu git maintainers [vagrant] - 10https://gerrit.wikimedia.org/r/104123 (owner: 10MarkAHershberger)
[21:39:59] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "This should be squashed on top of https://gerrit.wikimedia.org/r/#/c/65162/ (messages are missing)." [core] - 10https://gerrit.wikimedia.org/r/103852 (owner: 10Hatul)
[21:40:22] <grrrit-wm>	 (03CR) 10MarkAHershberger: "dang, beat me to it." [vagrant] - 10https://gerrit.wikimedia.org/r/104095 (owner: 10MarkAHershberger)
[21:40:26] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "https://gerrit.wikimedia.org/r/#/c/103852/ was submitted which would fix the issue Aaron and I pointed out, if it were squashed on top of " [core] - 10https://gerrit.wikimedia.org/r/65162 (owner: 10Amire80)
[21:40:39] <grrrit-wm>	 (03PS1) 10Siebrand: Replace deprecated CategoryViewer::addSubcategory() [extensions/Video] - 10https://gerrit.wikimedia.org/r/104143 
[21:41:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove deprecated methods from Revision, SkinTemplate, and WikiPage [core] - 10https://gerrit.wikimedia.org/r/104048 (owner: 10Siebrand)
[21:43:09] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "I don't really understand what this does, sorry." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104016 (owner: 10Umherirrender)
[21:43:30] <Krenair>	 ori, was it you that had been playing with localStorage recently?
[21:43:43] <ori>	 yes
[21:44:10] <grrrit-wm>	 (03CR) 10MarkTraceur: "I assumed it could be useful for features in other parts of Special:Preferences, possibly in a more compact form (i.e. no description)." [core] - 10https://gerrit.wikimedia.org/r/75143 (owner: 10MarkTraceur)
[21:44:45] <MatmaRex>	 oh ori, that reminds me of https://gerrit.wikimedia.org/r/#/c/100930/ :)
[21:45:14] <grrrit-wm>	 (03PS1) 10Ryan Lane: Fully qualify instance resource pages [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/104144 
[21:46:10] <Krenair>	 ori, someone has been saying that setting dom.storage.enabled to false causes FF to crash on Wikipedia
[21:46:27] <MatmaRex>	 "crash"?
[21:46:35] <ori>	 module storage is disabled everywhere at the moment
[21:47:08] <VladAndrew>	 Nemo_bis: what do you think ? is the page well ?
[21:47:13] <ori>	 there was a confound (the language data module bug) that made our measurements noisy
[21:47:33] <ori>	 i'm waiting for the holiday season to end to re-enable it
[21:47:33] <Nemo_bis>	 VladAndrew: I'm off for today, will check tomorrow
[21:47:48] <ori>	 MatmaRex: i'm not thrilled about the addition of try / catch
[21:47:51] <VladAndrew>	 Nemo_bis: I see, is there anyone else who I can contact ?
[21:48:15] <Krenair>	 ori, okay so you don't think this issue is related to your module storage then?
[21:48:23] <MatmaRex>	 ori: do you have a better idea how to handle syntax errors in the cached code?
[21:48:28] <ori>	 Krenair: not if the wiki in question is hosted by wikimedia
[21:48:42] <Krenair>	 well this went to info-en@, so I would assume so
[21:48:54] <ori>	 MatmaRex: could you split it in two? the workaround in one patch, and the try / catch logic in a dependent patch?
[21:49:21] <ori>	 the former would be uncontroversial from my perspective so we could merge it right away
[21:49:24] <grrrit-wm>	 (03PS1) 10Siebrand: Replace deprecated WebRequest::getFileSize() [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/104145 
[21:49:28] <ori>	 the second i want to think about a little bit
[21:49:34] <grrrit-wm>	 (03CR) 10MaxSem: "Hmm, this returns "sr" as variant name for language "sr"." [core] - 10https://gerrit.wikimedia.org/r/104140 (owner: 10Anomie)
[21:49:56] <ori>	 oh, and i meant to merge your svg patch
[21:50:00] <grrrit-wm>	 (03PS1) 10Siebrand: Replace deprecated WebRequest::getFileSize() [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/104146 
[21:50:09] <MatmaRex>	 ori: hm, okay
[21:51:46] <grrrit-wm>	 (03PS2) 10Ori.livneh: Optimize all SVGs [core] - 10https://gerrit.wikimedia.org/r/103894 (owner: 10Bartosz Dziewoński)
[21:51:59] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] "I was a bit hesitant about this because I think the format of files in Git should be optimized for readability, rather than leanness. But " [core] - 10https://gerrit.wikimedia.org/r/103894 (owner: 10Bartosz Dziewoński)
[21:52:35] <grrrit-wm>	 (03CR) 10Anomie: "That's apparently what is configured as the variant name for 'sr'. The API is just reporting whatever the getVariantname method returns." [core] - 10https://gerrit.wikimedia.org/r/104140 (owner: 10Anomie)
[21:52:52] <ori>	 MatmaRex: thanks :) sorry to have not replied until now
[21:53:24] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] "Sounds reasonable, I confirmed that it works." [core] - 10https://gerrit.wikimedia.org/r/103898 (owner: 10Skizzerz)
[21:54:42] <grrrit-wm>	 (03PS1) 10Aaron Schulz: [WIP] Added "dbmsOptions" options to Database classes [core] - 10https://gerrit.wikimedia.org/r/104148 
[21:55:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Optimize all SVGs [core] - 10https://gerrit.wikimedia.org/r/103894 (owner: 10Bartosz Dziewoński)
[21:59:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make MediaWiki:Redirectpagesub accept all wikitext. [core] - 10https://gerrit.wikimedia.org/r/103898 (owner: 10Skizzerz)
[22:00:23] <grrrit-wm>	 (03PS6) 10M4tx: Add SVG versions of enhanced recent changes collapse/show arrows [core] - 10https://gerrit.wikimedia.org/r/96372 
[22:08:33] <grrrit-wm>	 (03PS2) 10Umherirrender: Add more tests for title validations [core] - 10https://gerrit.wikimedia.org/r/104016 
[22:09:58] <grrrit-wm>	 (03PS3) 10Umherirrender: Add more tests for title validations [core] - 10https://gerrit.wikimedia.org/r/104016 
[22:13:55] <grrrit-wm>	 (03CR) 10M4tx: "What do you mean by "everything is misaligned"? I think I'm missing something when testing this changeset..." [core] - 10https://gerrit.wikimedia.org/r/99258 (owner: 10M4tx)
[22:15:35] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "It's not pixel-perfect and not mathematically ideal ;) but certainly good enough in practice." [core] - 10https://gerrit.wikimedia.org/r/99258 (owner: 10M4tx)
[22:16:16] <VladAndrew>	 Any translation administrator who can mark this page as translatable https://www.mediawiki.org/wiki/Help:Talk_pages ?
[22:16:17] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: mw.loader.store: More fault tolerance [core] - 10https://gerrit.wikimedia.org/r/100930 
[22:16:17] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: mw.loader.store: Detect malformed function stringification [core] - 10https://gerrit.wikimedia.org/r/104149 
[22:16:28] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Ori asked me to split the Opera workaround part to a separate patch: https://gerrit.wikimedia.org/r/104149" [core] - 10https://gerrit.wikimedia.org/r/100930 (owner: 10Bartosz Dziewoński)
[22:16:38] <MatmaRex>	 ori: ^
[22:17:25] <ori>	 thanks
[22:18:03] <grrrit-wm>	 (03PS2) 10Ori.livneh: mw.loader.store: Detect malformed function stringification [core] - 10https://gerrit.wikimedia.org/r/104149 (owner: 10Bartosz Dziewoński)
[22:18:11] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] mw.loader.store: Detect malformed function stringification [core] - 10https://gerrit.wikimedia.org/r/104149 (owner: 10Bartosz Dziewoński)
[22:18:46] <Nemo_bis>	 VladAndrew: #mediawiki is supposed to be a better channel for such things btw
[22:19:34] <grrrit-wm>	 (03Abandoned) 10Theopolisme: Provide language variant data via the api [core] - 10https://gerrit.wikimedia.org/r/104128 (owner: 10Theopolisme)
[22:20:41] <VladAndrew>	 thanks!
[22:22:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: mw.loader.store: Detect malformed function stringification [core] - 10https://gerrit.wikimedia.org/r/104149 (owner: 10Bartosz Dziewoński)
[22:33:22] <grrrit-wm>	 (03PS7) 10Bartosz Dziewoński: Add SVG versions of enhanced recent changes collapse/show arrows [core] - 10https://gerrit.wikimedia.org/r/96372 (owner: 10M4tx)
[22:34:00] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] "Optimized the SVGs, they were obscenely large. Let's get this merged at last." [core] - 10https://gerrit.wikimedia.org/r/96372 (owner: 10M4tx)
[22:38:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add SVG versions of enhanced recent changes collapse/show arrows [core] - 10https://gerrit.wikimedia.org/r/96372 (owner: 10M4tx)
[22:40:40] <grrrit-wm>	 (03PS1) 10Aaron Schulz: With mysqli, avoid setting the charset twice [core] - 10https://gerrit.wikimedia.org/r/104151 
[22:40:55] <grrrit-wm>	 (03CR) 10Aaron Schulz: "See the last comment of https://bugs.php.net/bug.php?id=44118&edit=3" [core] - 10https://gerrit.wikimedia.org/r/104151 (owner: 10Aaron Schulz)
[22:47:34] <grrrit-wm>	 (03PS1) 10Siebrand: Replace deprecated use of WikiError class [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/104153 
[22:48:11] <grrrit-wm>	 (03PS1) 10Siebrand: Replace deprecated use of WikiError class [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/104155 
[22:57:54] <grrrit-wm>	 (03PS1) 10Siebrand: Remove classes and functions deprecated in MediaWiki 1.17 [core] - 10https://gerrit.wikimedia.org/r/104156 
[22:58:00] <grrrit-wm>	 (03CR) 10Siebrand: [V: 032] "Per Chad." [extensions/Interlanguage] - 10https://gerrit.wikimedia.org/r/104029 (owner: 10Siebrand)
[23:04:40] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Replace use of deprecated SpecialPageFactory::getGroup() [core] - 10https://gerrit.wikimedia.org/r/104030 (owner: 10Siebrand)
[23:04:57] <siebrand>	 MatmaRex: Has revs in need of reviewers :)
[23:06:19] <MatmaRex>	 siebrand: yeah, i was just looking at my mail
[23:06:27] <MatmaRex>	 i have never even heard of these extensions
[23:06:42] <siebrand>	 MatmaRex: Was just making sure I've added some reviewers for all the patch sets I uploaded today...
[23:06:56] <siebrand>	 MatmaRex: I've seen the names of most.
[23:07:11] <siebrand>	 MatmaRex: I basically have all Gerrit extensions clonesd, except for a few.
[23:07:54] <siebrand>	 MatmaRex: 640 at the moment, and PHPStorm happily searches them for me :)
[23:07:54] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Replace deprecated use of WikiError class [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/104155 (owner: 10Siebrand)
[23:07:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace deprecated use of WikiError class [extensions/ContactPageFundraiser] - 10https://gerrit.wikimedia.org/r/104155 (owner: 10Siebrand)
[23:07:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace use of deprecated SpecialPageFactory::getGroup() [core] - 10https://gerrit.wikimedia.org/r/104030 (owner: 10Siebrand)
[23:08:25] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Replace deprecated use of WikiError class [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/104153 (owner: 10Siebrand)
[23:08:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace deprecated use of WikiError class [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/104153 (owner: 10Siebrand)
[23:09:47] <MatmaRex>	 siebrand: you might want to look at https://gerrit.wikimedia.org/r/#/q/status:open+topic:getPageTitle,n,z :)
[23:10:05] <siebrand>	 MatmaRex: I've seen them.
[23:10:19] <siebrand>	 MatmaRex: I'm a bit hesitant.
[23:10:45] <MatmaRex>	 siebrand: huh, why is WebRequest#getFileSize deprecated?
[23:11:00] <siebrand>	 MatmaRex: I know that a lot of maintainers want BC, and this breaks a lot of high profile extensions's immediately.
[23:11:01] <MatmaRex>	 #getFileTempname and #getUploadError aren't, and they're almost exactly the same
[23:11:15] <aude>	 i'm sure stuff like semantic mediawiki want to keep backwards compatibility
[23:11:38] <siebrand>	 MatmaRex: https://gerrit.wikimedia.org/r/#/c/104156/1/includes/WebRequest.php
[23:11:45] <MatmaRex>	 SpecialPage#getPageTitle has existed for a long time though, hasn't it?
[23:12:03] <MatmaRex>	 changing that #getTitle to do something else might be troublesome, but deprecating it isn't
[23:12:46] <MatmaRex>	 siebrand: yeah, what i'm asking is why that method and not the other two (apart from them not being marked as deprecated in advance)
[23:12:47] <siebrand>	 MatmaRex: Will look into it again tomorrow. If I'm convinced, I'll review and merge a bunch.
[23:12:49] <aude>	 no it's new
[23:12:52] * aude  thinks so

[23:13:03] <aude>	 https://gerrit.wikimedia.org/r/#/c/103587/1/includes/specialpage/SpecialPage.php
[23:13:06] <aude>	 unless i am missing something
[23:13:16] <siebrand>	 MatmaRex: I didn't look into what else could be deprecated. But do feel free to slap some deprecated 1.23 tags where needed...
[23:13:23] <MatmaRex>	 aude: oh. hmm
[23:13:26] <MatmaRex>	 it's missing @since, then
[23:14:00] <siebrand>	 MatmaRex: Yes, I noted that in the patch set..
[23:15:16] <aude>	 Call to undefined method Wikibase\Repo\Specials\SpecialSetLabel::getPageTitle</p><p>Backtrace:</p><p>#0 
[23:15:26] <aude>	 yep, wikibase master against older mediawiki
[23:15:59] <aude>	 for wikibase, we don't really care that much since it broke backwards compatibility in other places 
[23:16:32] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Remove classes and functions deprecated in MediaWiki 1.17 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104156 (owner: 10Siebrand)
[23:18:25] <MatmaRex>	 aude: siebrand: hmm, the more i think about it (eradicating old usages and then changing semantics of getTitle), the more it seems like something that shouldn't be done or should be discussed on wikitech first
[23:18:30] <MatmaRex>	 legoktm: ^
[23:18:44] <grrrit-wm>	 (03CR) 10Jack Phoenix: [C: 031] "This is fine by me, we've been running this on ShoutWiki since 7 December 2013 (ShoutWiki SVN r2317), but I'm not able to +2 this changese" [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/103384 (owner: 10UltrasonicNXT)
[23:18:44] <aude>	 i think what lego wants is special page to extend context source
[23:18:48] <MatmaRex>	 deprecating is good, the function name is stupid
[23:19:24] <aude>	 which means getTitle() means something else
[23:19:24] <MatmaRex>	 yeah, i know .regadless.
[23:19:24] <MatmaRex>	 yeah, i know. regardless. *
[23:19:24] <aude>	 it would be overridden in special page 
[23:19:25] * aude  nods

[23:20:27] <grrrit-wm>	 (03CR) 10Siebrand: Remove classes and functions deprecated in MediaWiki 1.17 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/104156 (owner: 10Siebrand)
[23:20:45] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "I don't think this method should have been deprecated, see my comment on https://gerrit.wikimedia.org/r/#/c/104156/" [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/104146 (owner: 10Siebrand)
[23:20:49] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "I don't think this method should have been deprecated, see my comment on https://gerrit.wikimedia.org/r/#/c/104156/" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/104145 (owner: 10Siebrand)
[23:22:56] <aude>	 MatmaRex: siebrand legoktm if we kept using the deprecated function in wikibase, then it causes a warning (i guess okay)
[23:23:04] <aude>	 but causes jenkins error
[23:23:04] <aude>	 https://integration.wikimedia.org/ci/job/mwext-Wikibase-repoapi-tests/1879/console
[23:23:18] <aude>	 either choice is not ideal
[23:23:54] <MatmaRex>	 aude: most extensions don't have tests ran by jenkins (or have tests that don't care about deprecations)
[23:24:38] <siebrand>	 aude: I'm pretty sure that you can make a setting to only throw deprecation warnings for versions up to x.
[23:24:51] <MatmaRex>	 aude: if feasible, we should definitely switch to getPageTitle, but if it's troublesome, then let's not bother in these cases
[23:24:55] <siebrand>	 aude: We have Translate BC down to 1.21, for example, and Jenkins is not whining about that.
[23:25:12] <MatmaRex>	 abusefilter also calls deprecated methods for compatibility
[23:25:19] <siebrand>	 aude: You should ask Antoine or Timo how that's done.
[23:28:56] <ori>	 siebrand: which URL?
[23:29:09] <siebrand>	 ori: The URL on the report.
[23:29:46] <siebrand>	 ori: There's a URL field that contains http://noc.wikimedia.org/cgi-bin/ng/report.py?db=others&sort=count&limit=5000&sample=&compare=&prefix=MessageCache::get
[23:30:17] <ori>	 ah, right. sorry, I'm a dork. I fixed http://noc.wikimedia.org/cgi-bin/report.py
[23:30:21] <ori>	 I don't know what this 'ng' thing is, have to look
[23:30:30] <ori>	 'next generation', presumably
[23:30:42] <siebrand>	 ori: That was the URL for the toy back then, I assume.
[23:31:01] <siebrand>	 Geek Jeopardy in German at 30C3...
[23:31:12] <ori>	 yeah, ng/ is not in puppet, so it's just detritus
[23:31:13] <siebrand>	 http://streaming.media.ccc.de/saal1/native/hd/ if you can understand German ;)
[23:31:36] <ori>	 ein bisschen
[23:32:41] <siebrand>	 The stream breaks up for me a lot at the moment.
[23:32:50] <siebrand>	 It was very stable during the earlier sessions.
[23:33:35] <aude>	 siebrand: hmmm, ok
[23:33:39] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 031] Prioritize single page edits over template changes (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104124 (owner: 10Manybubbles)
[23:39:52] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] Fix user-friendlyness of block confirmation screen (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103351 (owner: 10M4tx)
[23:40:38] <grrrit-wm>	 (03CR) 10Aaron Schulz: "Intra-queue priority could be added, though I never did it out of starvation worries." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/104124 (owner: 10Manybubbles)
[23:53:08] <grrrit-wm>	 (03PS1) 10Skizzerz: Fix error introduced in Change Ieae80c63e391cfb1af61841a6badd51b87d00cfe [core] - 10https://gerrit.wikimedia.org/r/104164 
[23:53:27] <grrrit-wm>	 (03CR) 10Skizzerz: "This change breaks the {{NAMESPACE}} magic word, as the proper function name for it is CoreParserFunctions::mwnamespace (note the mw in fr" [core] - 10https://gerrit.wikimedia.org/r/104136 (owner: 10Chad)
[23:54:16] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix error introduced in Change Ieae80c63e391cfb1af61841a6badd51b87d00cfe [core] - 10https://gerrit.wikimedia.org/r/104164 (owner: 10Skizzerz)
[23:55:52] <grrrit-wm>	 (03PS2) 10Skizzerz: Fix error introduced in Change Ieae80c63e391cfb1af61841a6badd51b87d00cfe [core] - 10https://gerrit.wikimedia.org/r/104164