[00:32:10] (03CR) 10Jhall: [C: 031] "Looks good to me - runs fine and works as expected in commons.wikimedia.beta.wmflabs.org." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [00:55:37] (03CR) 10Nemo bis: "needs V+2" [extensions/HelpPages] - 10https://gerrit.wikimedia.org/r/103637 (owner: 10Shirayuki) [00:57:19] (03CR) 10Nemo bis: "Right, better mention things like that in commit message last time." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103640 (owner: 10Shirayuki) [01:14:21] (03PS1) 10Shirayuki: i18n: remove BOM character [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/103727 [01:17:16] (03PS1) 10Shirayuki: i18n: remove BOM character [extensions/PushToWatch] - 10https://gerrit.wikimedia.org/r/103728 [01:19:57] (03PS1) 10Shirayuki: i18n: remove BOM character [extensions/QuizTabulate] - 10https://gerrit.wikimedia.org/r/103729 [03:05:10] (03CR) 10Legoktm: [C: 04-1] "Like I said, there's nothing wrong with a protocol relative link." [extensions/HelpPages] - 10https://gerrit.wikimedia.org/r/103637 (owner: 10Shirayuki) [03:16:53] (03PS3) 10Mattflaschen: Change modal to use API instead of special page, refactor [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103079 [03:20:42] (03PS4) 10Mattflaschen: Change modal to use API instead of special page, refactor [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103079 [03:28:34] (03CR) 10Mattflaschen: "Patch set 4 addresses Ori's comments, and a couple other small issues." (032 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103079 (owner: 10Mattflaschen) [03:39:47] (03PS1) 10Mattflaschen: Breaking Change: All lower case excludedtitle for consistency [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103734 [04:00:44] (03CR) 10Mattflaschen: "It's not used in master anywhere else I know of (I checked MobileFrontend, and the changes to GettingStarted to use it in additional place" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103734 (owner: 10Mattflaschen) [04:00:57] (03PS2) 10Mattflaschen: Breaking Change: All lower case excludedtitle for consistency [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103734 [04:03:29] (03CR) 10Mattflaschen: [C: 04-2] "Will be rebased on top of a couple other related changes." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103079 (owner: 10Mattflaschen) [04:49:28] (03PS1) 10Mattflaschen: Client-side wrapper for GettingStartedGetPages API [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103737 [04:50:36] (03CR) 10Mattflaschen: "I would appreciate feedback on this in general, but particularly the error-handling approach." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103737 (owner: 10Mattflaschen) [04:58:02] (03CR) 10Mattflaschen: [C: 04-2] "Not sure about this error handling approach. For now, do not merge." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103737 (owner: 10Mattflaschen) [05:19:12] (03PS2) 10Mattflaschen: Client-side wrapper for GettingStartedGetPages API [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103737 [05:20:22] (03PS1) 10BryanDavis: Set UI language from Accept-Language header [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/103738 [05:24:19] (03PS2) 10BryanDavis: Set UI language from Accept-Language header [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/103738 [05:31:39] (03PS5) 10Mattflaschen: Change modal to use API instead of special page, refactor [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103079 [05:32:22] (03CR) 10Mattflaschen: "Rebased on top of a separate client-side wrapper (previously embedded into return.js)." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103079 (owner: 10Mattflaschen) [05:46:33] (03PS6) 10Mattflaschen: Change modal to use API instead of special page, refactor [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103079 [05:46:34] (03PS3) 10Mattflaschen: Client-side wrapper for GettingStartedGetPages API [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103737 [05:52:27] (03PS4) 10Mattflaschen: Client-side wrapper for GettingStartedGetPages API [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103737 [06:24:24] (03PS1) 10Mattflaschen: WIP: Remove uses of Special:GettingStarted from task toolbar [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103740 [06:24:27] (03CR) 10jenkins-bot: [V: 04-1] WIP: Remove uses of Special:GettingStarted from task toolbar [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103740 (owner: 10Mattflaschen) [06:26:16] (03PS2) 10Mattflaschen: WIP: Remove uses of Special:GettingStarted from task toolbar [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103740 [06:58:33] (03PS1) 10Legoktm: Fix typo in DerivativeContext doc [core] - 10https://gerrit.wikimedia.org/r/103741 [07:05:25] (03CR) 10Aaron Schulz: [C: 032] Fix typo in DerivativeContext doc [core] - 10https://gerrit.wikimedia.org/r/103741 (owner: 10Legoktm) [07:08:29] (03Merged) 10jenkins-bot: Fix typo in DerivativeContext doc [core] - 10https://gerrit.wikimedia.org/r/103741 (owner: 10Legoktm) [07:10:31] (03CR) 10Liangent: [C: 04-1] Output language-converted-title in output (035 comments) [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 (owner: 10Mayankmadan) [07:10:46] Hi liangent [07:11:06] mayankmadan: hi [07:17:02] liangent, shouldnt snake case be used for the variables? [07:19:30] mayankmadan: well mediawiki codebase is following this convention [07:19:47] Okay [07:53:09] (03PS1) 10Chad: Remove "or other" option for stubtreshold [core] - 10https://gerrit.wikimedia.org/r/103742 [08:13:12] (03PS18) 10Yurik: Initial implementation of the JSON configuration store. [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 [08:40:45] (03CR) 10Chad: [C: 04-1] "This feels gross and hacky." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/103389 (owner: 10Manybubbles) [08:41:31] (03CR) 10Chad: [C: 032] Make background image stretch with window [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/103374 (owner: 10BryanDavis) [08:41:34] (03Merged) 10jenkins-bot: Make background image stretch with window [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/103374 (owner: 10BryanDavis) [08:43:31] (03CR) 10Chad: [C: 032] Boost page score by templates contained on page [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/103369 (owner: 10Manybubbles) [08:43:35] (03Merged) 10jenkins-bot: Boost page score by templates contained on page [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/103369 (owner: 10Manybubbles) [10:41:08] (03PS1) 10Hatul: add max-width to vector skin [core] - 10https://gerrit.wikimedia.org/r/103744 [10:45:37] (03PS2) 10Hatul: add max-width to vector skin [core] - 10https://gerrit.wikimedia.org/r/103744 [11:32:52] (03CR) 10Nemo bis: [C: 04-1] i18n: Add GENDER support to epoa-visible (032 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/103654 (owner: 10MegaAlex) [12:47:57] (03CR) 10Gergő Tisza: "Rebase, some refactoring, integration tests, handle missing blacklist and malformed image url better." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [12:51:55] (03PS1) 10M4tx: Fix extra output creating invalid HTML [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/103746 [12:56:14] (03CR) 10Physikerwelt: "I think it looks good, but not everything is completly clear to me." (033 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/103644 (owner: 10Aaron Schulz) [13:03:47] Hello. [13:08:00] (03CR) 10Nemo bis: "Caused/surfaced bug 58439." [core] - 10https://gerrit.wikimedia.org/r/97853 (owner: 10Bartosz Dziewoński) [13:09:25] (03PS2) 10Nemo bis: Fix extra output creating invalid HTML [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/103746 (owner: 10M4tx) [13:16:15] hi liangent [13:17:24] mayankmadan: hi [13:18:15] liangent, why is it that i can access the target variable but i cant access the getter function? [13:20:10] mayankmadan: both getDisplayTitle() and getTitleText() seem working for me... [13:20:26] what does it say when you do so? [13:21:35] mayankmadan: I'll be back in 20 minutes [13:23:12] (03CR) 10Siebrand: [V: 032] i18n: add "https:" [extensions/HelpPages] - 10https://gerrit.wikimedia.org/r/103637 (owner: 10Shirayuki) [13:24:50] (03CR) 10Siebrand: [C: 032 V: 032] i18n: remove BOM character [extensions/QuizTabulate] - 10https://gerrit.wikimedia.org/r/103729 (owner: 10Shirayuki) [13:25:03] (03CR) 10Siebrand: [C: 032 V: 032] i18n: remove BOM character [extensions/PushToWatch] - 10https://gerrit.wikimedia.org/r/103728 (owner: 10Shirayuki) [13:26:33] (03CR) 10Siebrand: [C: 032] i18n: remove BOM character [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/103727 (owner: 10Shirayuki) [13:26:35] (03Merged) 10jenkins-bot: i18n: remove BOM character [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/103727 (owner: 10Shirayuki) [13:53:31] hi liangent [13:53:56] liangent, i get this error when i try to access a method of a class Fatal error: Call to a member function getProperty() on a non-object in /opt/lampp/htdocs/mediawiki/core/extensions/GeoCrumbs/GeoCrumbs.class.php on line 122 [13:55:41] mayankmadan: because $parserCache is null I guess [13:55:59] liangent, but why is the $parserCache instance null [13:57:50] what article id did you give getParserCache? [13:58:24] (03PS3) 1001tonythomas: Resized the Text area fields in ReplaceText [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/103395 [14:00:41] (03CR) 10Siebrand: [C: 04-1] "Thanks for tracking this down!" (031 comment) [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/103746 (owner: 10M4tx) [14:01:01] liangent, article id of the $title argument [14:01:40] what is it? [14:02:30] (03CR) 10Siebrand: [C: 032] "Thanks, Tony." [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/103395 (owner: 1001tonythomas) [14:02:32] (03Merged) 10jenkins-bot: Resized the Text area fields in ReplaceText [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/103395 (owner: 1001tonythomas) [14:03:33] (03CR) 1001tonythomas: "@Siebrand: Anytime :)" [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/103395 (owner: 1001tonythomas) [14:04:55] (03CR) 10M4tx: Remove extra creating invalid HTML (031 comment) [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/103746 (owner: 10M4tx) [14:05:32] mayankmadan: all source code is publicly available, you can always read the source of other components (getParserCache in this case, and previously, getDisplayTitle, getTitleText etc) to figure out why something unexpected is given to you [14:05:46] liangent, okay [14:09:40] (03PS3) 10M4tx: Remove extra creating invalid HTML [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/103746 [14:10:16] (03CR) 10M4tx: "This one works both with old and new versions of MediaWiki." [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/103746 (owner: 10M4tx) [14:10:50] (03PS4) 10M4tx: Remove extra creating invalid HTML [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/103746 [14:15:05] anomie: around? [14:15:28] MatmaRex: Yes, but busy at the moment. Ping me again in about 15 minutes? [14:15:42] anomie: how do i make action=setnotificationtimestamp accept the token? [14:15:42] sure [14:15:46] https://gist.github.com/guoguo12/8129739 [14:15:55] a GCI student asked me why this doesn't work, and i can't figure it out [14:36:18] MatmaRex: It's doing the cookie handling wrong. The first request (line 12) returns an enwikiSession cookie, and this cookie is being included in the second request (line 14) but isn't being included in the other requests. Edit tokens don't work without that cookie. [14:38:01] anomie: how are they not being included? [14:38:18] ah, the two sets of cookies from the first two requests sphould be merged? [14:38:30] MatmaRex: Ask someone who knows python about that. I have no idea. [14:41:05] (they should, it works when i do that) [14:41:12] thanks, that was silly [14:55:19] (03PS9) 10Bartosz Dziewoński: Disabled, unticked "Suppress redirect" checkbox when redirect impossible [core] - 10https://gerrit.wikimedia.org/r/103530 (owner: 10Jcf2000) [14:55:32] (03CR) 10Bartosz Dziewoński: [C: 032] "Thanks for working on this!" [core] - 10https://gerrit.wikimedia.org/r/103530 (owner: 10Jcf2000) [14:58:14] (03CR) 10Bartosz Dziewoński: [C: 031] "Scary." [core] - 10https://gerrit.wikimedia.org/r/103587 (owner: 10Legoktm) [14:59:28] (03CR) 10Bartosz Dziewoński: "That would probably mean I should go through everything using this and update it… ;)" [core] - 10https://gerrit.wikimedia.org/r/95962 (owner: 10Bartosz Dziewoński) [15:01:13] (03Merged) 10jenkins-bot: Disabled, unticked "Leave redirect" checkbox when redirect impossible [core] - 10https://gerrit.wikimedia.org/r/103530 (owner: 10Jcf2000) [15:21:14] (03PS1) 10Cmcmahon: minor changes to messages shown when topics collapse [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103751 [15:21:50] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103751 (owner: 10Cmcmahon) [15:24:19] (03CR) 10Bartosz Dziewoński: "What about thos is "WIP"?" [core] - 10https://gerrit.wikimedia.org/r/95463 (owner: 10Krinkle) [15:59:30] (03CR) 10Anomie: [C: 04-1] Add blacklisting feature for flickr in backend (036 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [16:26:25] Nemo_bis, online? [16:28:12] mayankmadan_: sort of [16:41:09] (03PS2) 10M4tx: Add SVG versions of link type icons [core] - 10https://gerrit.wikimedia.org/r/98291 [16:42:56] (03CR) 10M4tx: "I modified the icons according to the Bartosz's comment. I think they're better now... :)" [core] - 10https://gerrit.wikimedia.org/r/98291 (owner: 10M4tx) [16:42:59] (03PS3) 10BryanDavis: Add cache-control and vary headers [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102725 [16:43:58] nevermind, figured it out [16:45:28] (03CR) 10BryanDavis: "Patch set 3 was a manual rebase required due to conflicts introduced by I54ff710." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102725 (owner: 10BryanDavis) [16:48:35] (03PS4) 10Mayankmadan: Output language-converted-title in output [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/103656 [16:52:22] (03PS2) 10Manybubbles: Keep special syntax in suggestions [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/103389 [16:54:29] (03PS2) 10MegaAlex: i18n: Add GENDER support to epoa-visible and epca-visible [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/103654 [16:56:16] (03PS1) 10Manybubbles: Fix prefer-recent [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/103754 [16:57:19] (03CR) 10Manybubbles: "This is _less_ gross and hacky and lets us keep a bunch of other syntax while performing suggestions. It is still somewhat gross and hack" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/103389 (owner: 10Manybubbles) [16:59:30] (03CR) 10Chad: [C: 032] Fix prefer-recent [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/103754 (owner: 10Manybubbles) [16:59:33] (03Merged) 10jenkins-bot: Fix prefer-recent [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/103754 (owner: 10Manybubbles) [17:03:27] (03PS3) 10Nemo bis: i18n: Add GENDER support to epoa-visible and epca-visible [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/103654 (owner: 10MegaAlex) [17:05:59] (03CR) 10Nemo bis: [C: 031] "l10n ok, didn't test." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/103654 (owner: 10MegaAlex) [17:09:54] (03PS1) 10Manybubbles: Simple script to check document counts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/103758 [17:18:34] (03CR) 10Chad: [C: 032] "Much better :)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/103389 (owner: 10Manybubbles) [17:18:37] (03Merged) 10jenkins-bot: Keep special syntax in suggestions [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/103389 (owner: 10Manybubbles) [17:53:00] (03CR) 10Aaron Schulz: [C: 032] Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas) [17:53:38] (03CR) 10jenkins-bot: [V: 04-1] Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas) [18:02:08] (03PS1) 10Manybubbles: Smarter defaults for forceSearchIndex's batch-size [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/103762 [18:02:29] (03PS1) 10EBernhardson: No-js css tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103763 [18:03:23] (03PS2) 10EBernhardson: No-js css tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103763 [18:04:39] (03CR) 10Aaron Schulz: [C: 032] Use a better regular expression to find documented hooks in findHooks.php [core] - 10https://gerrit.wikimedia.org/r/101650 (owner: 10IAlex) [18:09:26] (03Merged) 10jenkins-bot: Use a better regular expression to find documented hooks in findHooks.php [core] - 10https://gerrit.wikimedia.org/r/101650 (owner: 10IAlex) [18:13:30] <^d> AaronSchulz: https://gerrit.wikimedia.org/r/#/c/103742/ :p [18:15:04] (03Merged) 10jenkins-bot: Use WikiPage::prepareContentForEdit in SpamBlacklistHooks::filterMergedContent [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/101490 (owner: 10Anomie) [18:15:50] (03CR) 10Aaron Schulz: "Do those values cause some sort of problem?" [core] - 10https://gerrit.wikimedia.org/r/103742 (owner: 10Chad) [18:19:57] (03CR) 10Chad: "No, but they're dumb values and it creates preference clutter." [core] - 10https://gerrit.wikimedia.org/r/103742 (owner: 10Chad) [18:20:16] (03PS3) 10EBernhardson: No-js css tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103763 [18:27:55] (03CR) 10Jack Phoenix: [C: 04-1] "The getDupeWarning() method is still being used statically on line 239. That needs to be fixed for this fix to work." [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/103384 (owner: 10UltrasonicNXT) [18:30:28] (03CR) 10Chad: [C: 032] Smarter defaults for forceSearchIndex's batch-size [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/103762 (owner: 10Manybubbles) [18:30:39] (03Merged) 10jenkins-bot: Smarter defaults for forceSearchIndex's batch-size [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/103762 (owner: 10Manybubbles) [18:31:04] (03CR) 10Chad: [C: 032] Simple script to check document counts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/103758 (owner: 10Manybubbles) [18:31:07] (03Merged) 10jenkins-bot: Simple script to check document counts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/103758 (owner: 10Manybubbles) [18:32:38] (03CR) 10Chad: [C: 032] Add cache-control and vary headers [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102725 (owner: 10BryanDavis) [18:32:50] (03Merged) 10jenkins-bot: Add cache-control and vary headers [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102725 (owner: 10BryanDavis) [18:33:40] (03CR) 10Chad: [C: 032] Set UI language from Accept-Language header [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/103738 (owner: 10BryanDavis) [18:33:46] (03Merged) 10jenkins-bot: Set UI language from Accept-Language header [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/103738 (owner: 10BryanDavis) [18:35:37] (03CR) 10Chad: [C: 032] Don't escape HTML title of Special:Contributions for newbies [core] - 10https://gerrit.wikimedia.org/r/103354 (owner: 10Whym) [18:36:00] (03CR) 10Chad: [C: 032] Declare visibility on log class related properties [core] - 10https://gerrit.wikimedia.org/r/98969 (owner: 10Siebrand) [18:36:30] (03CR) 10Chad: [C: 032] Add missing subjectspace pages to watchlist on update. [core] - 10https://gerrit.wikimedia.org/r/98563 (owner: 10Brian Wolff) [18:37:35] (03PS1) 10Milimetric: Adapting passport-google-oauth for mediawiki [passport-mediawiki] - 10https://gerrit.wikimedia.org/r/103765 [18:37:36] (03PS1) 10Milimetric: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/passport-mediawiki [passport-mediawiki] - 10https://gerrit.wikimedia.org/r/103766 [18:38:38] any translation administrator here ? [18:39:14] (03Merged) 10jenkins-bot: Don't escape HTML title of Special:Contributions for newbies [core] - 10https://gerrit.wikimedia.org/r/103354 (owner: 10Whym) [18:39:23] VladAndrew: for which wiki? [18:39:38] Nikerabbit: https://www.mediawiki.org/wiki/Help:Links [18:40:41] https://www.mediawiki.org/w/index.php?title=Help:Links&oldid=829524&diff=848769 you want these marked for translation? [18:40:54] (03Merged) 10jenkins-bot: Declare visibility on log class related properties [core] - 10https://gerrit.wikimedia.org/r/98969 (owner: 10Siebrand) [18:41:26] (03PS4) 10Manybubbles: Implement near match and improve prefix search [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102958 [18:41:32] ^d: ^^ [18:42:01] (03CR) 10Chad: [C: 032] Implement near match and improve prefix search [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102958 (owner: 10Manybubbles) [18:42:09] (03Merged) 10jenkins-bot: Implement near match and improve prefix search [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102958 (owner: 10Manybubbles) [18:42:14] <^d> merge alllll the changes [18:42:37] (03Merged) 10jenkins-bot: Add missing subjectspace pages to watchlist on update. [core] - 10https://gerrit.wikimedia.org/r/98563 (owner: 10Brian Wolff) [18:43:02] Nikerabbit: yes, that's the page [18:43:35] (03CR) 10EBernhardson: [C: 032] "With schema change finished this can be deployed with the next train." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 (owner: 10EBernhardson) [18:43:57] (03CR) 10jenkins-bot: [V: 04-1] Load usernames directly from wiki's in batches [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 (owner: 10EBernhardson) [18:44:19] VladAndrew: why don't you follow the task instructions? [18:45:07] Nemo_bis: huh..? [18:45:54] ok, something else [18:45:59] Nemo_bis: the page already contain tag, what else should I add ? [18:46:25] nothing [18:46:29] pick another [18:47:23] Nemo_bis: have I done something wrong ? [18:48:54] Nemo_bis: https://www.mediawiki.org/wiki/Help:Patrolled_edits this page [18:49:13] I should add yes ? [18:50:00] among other things [18:50:15] first things first, you'r doing the GCI task right? [18:50:18] yes [18:50:27] have you read the pages it tells you to read? [18:50:27] Nemo_bis: here https://www.google-melange.com/gci/task/view/google/gci2013/5836117928574976 [18:50:28] Make MediaWiki documentation translatable [18:50:28] Status: Claimed (17 hours, 21 minutes left) [18:50:28] Mentor(s): Guillaume Paumier, Quim Gil [18:50:47] Nemo_bis: yes [18:52:20] Nemo_bis: I have to add ... if it is missing and click the Mark this page for translation" link [18:52:50] This is the second page I am working on [18:52:51] sort of [18:52:59] then go ahead :) [18:53:48] (03PS10) 10EBernhardson: Load usernames directly from wiki's in batches [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 [18:56:03] Nemo_bis: I have added the tag [18:56:17] https://www.mediawiki.org/w/index.php?title=Help:New_images [18:57:05] that's not enough [18:57:49] Nemo_bis: {{Languages}} should be included ? [18:58:51] Nemo_bis: or [18:58:58] or there is something else i should add [18:59:40] no and no to both [18:59:52] VladAndrew: look and remember for next time https://www.mediawiki.org/w/index.php?title=Help:New_images&diff=849765&oldid=849762 [19:00:18] all this is covered in the docs, if you tell me what you have *actually* read we can figure if they need improvement or what [19:01:40] VladAndrew: now import the old translations :) [19:01:52] Nemo_bis: I read a few from all of them [19:01:56] Nemo_bis: ok [19:02:29] obviously not the correct parts then ;) [19:03:26] Nemo_bis: an example like the one you have provided is a lot more useful than lots of words [19:05:21] Nemo_bis: I'll look over them again and thanks again for the help [19:07:10] VladAndrew: yes, that's why the steps in the task are as they are: Guillom is busy with a lot of tasks, he can't check all the details of translation preparation [19:07:31] so please follow the steps provided and tell translation admins what pages you're working on by editing the list [19:07:35] same errors in https://www.mediawiki.org/w/index.php?title=Help%3ABots&diff=849785&oldid=849537 [19:07:50] Nemo_bis: I'll resolve them right away [19:10:35] VladAndrew: you didn't import all old translations https://www.mediawiki.org/w/index.php?title=Help:Bots/pt&diff=849789&oldid=732411 ; please work on one page at a time but don't leave stuff behind [19:13:31] (03CR) 10Chad: [C: 031] "Barring any message changes, let's land this. The reindex is gonna suck so I'd rather be able to do it sooner rather than later." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 (owner: 10Chad) [19:13:52] <^d> manybubbles: Actually, that needs a rebase ^ [19:13:54] <^d> I'll handle it [19:14:09] k [19:14:52] Nemo_bis: old translations...? [19:16:08] VladAndrew: previous translations of the page: your goal is to import them into the Translate system [19:16:30] (03PS7) 10Chad: Begin indexing file text from pdf/djvu files [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 [19:17:45] <^d> Easy rebase is easy. [19:18:02] ooooh text indexing? [19:18:04] yayyyyy [19:18:16] i wonder if we could extract text from SVGs for indexing too [19:18:27] OR DO OCR ON PNGS [19:19:07] brion: archive.org does that [19:19:29] oooooh nice [19:19:33] (OCR images I mean) [19:19:33] Nemo_bis: and to do that I have to add some special tag ? [19:19:42] VladAndrew: no [19:19:56] (03PS1) 10Manybubbles: Autoloader update [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/103776 [19:20:25] VladAndrew: can you please clarify what you (not) understand in the sentence "When it's approved, complete the job: copy the old translations to corresponding units with Special:Translate (as a translator would do in the translation tutorial linked above)." [19:20:55] (03CR) 10Manybubbles: "This is required for stuff we've already merged into Cirrus." [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/103776 (owner: 10Manybubbles) [19:21:32] and just to check, have you fully read the translation tutorial [19:22:24] (03CR) 10Chad: [C: 032] "I wonder if we could just do some magic globbing so we don't have to add things ever :)" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/103776 (owner: 10Manybubbles) [19:23:21] (03CR) 10Manybubbles: "Is that kind of thing too slow to do on every php startup? I thought directory scan stuff would be slow for that." [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/103776 (owner: 10Manybubbles) [19:25:21] Nemo_bis: so let me understand, here https://www.mediawiki.org/w/index.php?title=Special:MessageGroupStats&language=ro&group=page-Help:Bots I should have all the other translations [19:25:28] no [19:25:32] or by old you mean old translations in the same language [19:25:36] you must *enter* them [19:26:01] Nemo_bis: how do I do that ? [19:26:26] copy https://www.mediawiki.org/w/index.php?title=Help:Bots/pt&action=edit&oldid=732411 -> paste https://www.mediawiki.org/w/index.php?title=Special:Translate&group=page-Help%3ABots&action=page&filter=&language=pt [19:26:59] do you know how I found the first of the two links? and the second? [19:27:26] you clicked the specific language ? [19:29:14] I see, and I have to do that for all the other languages yes ? [19:30:15] Nemo_bis: wait, so my task was not to translate the wiki in another language...oh [19:30:41] VladAndrew: that's explicitly forbidden [19:30:42] Nemo_bis: of course, yes sorry [19:30:49] i think your task is to make the wiki translatable [19:31:09] VladAndrew: please note that you made translations yourself on the task, they need to be deducted or we'll break Google rules [19:31:43] Nemo_bis: yes, deduct them [19:31:45] it's a contract you and your mentor have with Google; not important if that's outside GCI but quite a problem otherwise [19:31:53] Nemo_bis, just out of curiosity, what google rules? [19:32:07] note on the task what pages you translated, please [19:32:22] mayankmadan__: rules for gci, no time to dig them right now [19:32:32] okay np [19:35:05] Nemo_bis: so I should add a comment to tell them that by mistake I have translated the page to another language yes ? [19:35:26] yes [19:35:50] Nemo_bis: here is the page https://www.mediawiki.org/wiki/Help:Bots [19:36:05] Nemo_bis: can I still continue the task ? [19:37:18] VladAndrew: sure, just need not to count the parts which are not asked by the task [19:37:30] please read the task instructions fully next time [19:37:38] if not the docs, at least the task itself [19:38:22] Nemo_bis: and my actually task is to modify the source and add the old translations [19:38:44] for example now I'll copy the pt translations. [19:43:48] Nemo_bis: for the deautch translations I have to copy https://www.mediawiki.org/w/index.php?title=Help:Bots/de&action=edit&oldid=732411 ---> https://www.mediawiki.org/w/index.php?title=Special:Translate&group=page-Help%3ABots&action=page&filter=&language=de yes ? [19:50:57] the first link is wrong [19:52:14] VladAndrew: do you know how to use page history? you click the "history" link at the top of the page (it might be hidden in some dropdown if you use the default vector skin) https://www.mediawiki.org/w/index.php?title=Help:Bots/de&action=history then you select the last revision before FuzzyBot and click its timestamp https://www.mediawiki.org/w/index.php?title=Help:Bots/de&oldid=718464 then you click edit [19:52:43] if this part was unclear we'll try to clarify it in the instructions [20:31:12] hello hoo, please finally review https://gerrit.wikimedia.org/r/71291 and make a decision in this case: It's sitting around for too long :) [20:33:51] (03PS12) 10AndyRussG: Fix errors if course/org forms are re-submitted [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 [20:35:54] se4598: looking [20:36:39] Nemo_bis: how do I know how many translations units have I made ? [20:36:48] for example here https://www.mediawiki.org/w/index.php?title=Special:MessageGroupStats&language=ro&group=page-Help:Bots [20:37:16] do I have 83 translation units ? [20:37:32] (03CR) 10Aaron Schulz: Buffer png writes and flush them all at once (032 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/103644 (owner: 10Aaron Schulz) [20:38:04] se4598: AbuseFilter's code is horrible, so that I need to test that manually, I guess [20:38:25] (03CR) 10Hoo man: [C: 031] "Didn't test, yet" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/71291 (owner: 10Se4598) [20:38:35] oh, it needs a rebase, pity [20:39:44] (03PS3) 10AndyRussG: Style deletion warning messages [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/99316 [20:39:50] se4598: ^ [20:40:46] VladAndrew: well, you need to complete the pagt in any case, did you [20:40:58] hoo: should I press "rebase change" in gerrit or does it need manual rebase? [20:41:13] Nemo_bis: pagt ? [20:41:25] se4598: Manual rebase :/ [20:41:25] page [20:41:29] (03PS2) 10AndyRussG: Fix undelete courses and institutions [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98475 [20:41:46] VladAndrew: that's currently 83 +15 (en) -15 (ro) [20:42:11] yep I got it right [20:43:13] (03PS14) 10AndyRussG: Let instructors and volunteers assign articles [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 [20:43:20] yay something that's not unclear in my instructions ;) [20:44:00] Nemo_bis: btw, New images got striked while I was working on the other [20:44:10] Should I chose another one ? [20:45:25] I struck it for you because you had forgotten to do so [20:45:37] (and I had already marked it) [20:45:53] complete that one, then you'll probably need a third (small) page [20:46:00] Nemo_bis: ok [20:49:10] (03CR) 10Chad: [V: 032] "Possibly. It was just a thought :)" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/103776 (owner: 10Manybubbles) [20:51:09] (03PS11) 10EBernhardson: Load usernames directly from wiki's in batches [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 [20:55:16] (03PS12) 10EBernhardson: Load usernames directly from wiki's in batches [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 [21:05:30] Nemo_bis: hey, I've modified https://www.mediawiki.org/w/index.php?title=Help:Editing [21:06:02] Nemo_bis: It said that it needs approve [21:06:34] Nemo_bis: I have added for every item [21:06:49] or it should be only one for one [21:11:15] (03PS5) 10Se4598: Add triggered filter id as parameter to messages [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/71291 [21:13:00] (03PS2) 10EBernhardson: Only roundtrip through parsoid for wikitext when necessary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101120 [21:13:02] (03CR) 10jenkins-bot: [V: 04-1] Only roundtrip through parsoid for wikitext when necessary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101120 (owner: 10EBernhardson) [21:14:07] (03CR) 10Se4598: "PS5: rebased and qqq-msg 'abusefilter-degroupreason' fixed (forgotton to add new param-desc there)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/71291 (owner: 10Se4598) [21:15:05] (03PS3) 10EBernhardson: Only roundtrip through parsoid for wikitext when necessary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101120 [21:15:07] (03CR) 10jenkins-bot: [V: 04-1] Only roundtrip through parsoid for wikitext when necessary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101120 (owner: 10EBernhardson) [21:17:14] (03PS7) 10Gergő Tisza: Add blacklisting feature for flickr in backend [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [21:18:48] (03PS4) 10EBernhardson: Only roundtrip through parsoid for wikitext when necessary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101120 [21:18:56] (03CR) 10Gergő Tisza: "Moved functionality out of API class to avoid internal API calls, switched Flickr format from serialized PHP to JSON, some more small chan" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65109 (owner: 10Nischayn22) [21:19:05] (03CR) 10EBernhardson: "also rebased, mergable now." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101120 (owner: 10EBernhardson) [21:23:53] (03CR) 10CSteipp: [C: 031] "Security looks fine, and I don't think any admins will object." [core] - 10https://gerrit.wikimedia.org/r/103351 (owner: 10M4tx) [21:25:58] (03PS1) 10Hatul: Show a warning on page deletion if a page is linked to [core] - 10https://gerrit.wikimedia.org/r/103852 [21:26:09] (03PS5) 10EBernhardson: Make condensed view more condensed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102707 (owner: 10Matthias Mullie) [21:26:17] (03CR) 10EBernhardson: "PS5: rebased" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102707 (owner: 10Matthias Mullie) [21:28:02] <^d> siebrand: I'm going to get 96469 in today. [21:28:17] <^d> Just needs a rebase & to fix the merge conflicts in the release notes. [21:28:20] <^d> Which I'm already doing. [21:28:59] ^d: Awesome... I'm ark, watching a movie. [21:30:19] afk, that is... Damn auto correct. [21:30:20] (03PS1) 10Manybubbles: Setup unit tests for cirrus [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/103853 [21:30:32] (03PS12) 10Chad: Remove underscore from classes LBFactory_*, LoadBalancer_*, LoadMonitor_* [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [21:31:59] (03PS8) 10Manybubbles: Begin indexing file text from pdf/djvu files [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 (owner: 10Chad) [21:32:00] (03CR) 10jenkins-bot: [V: 04-1] Begin indexing file text from pdf/djvu files [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 (owner: 10Chad) [21:33:02] VladAndrew: you should never add that [21:33:24] (03PS9) 10Manybubbles: Index and search file text from pdf/djvu files [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 (owner: 10Chad) [21:33:25] (03CR) 10jenkins-bot: [V: 04-1] Index and search file text from pdf/djvu files [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 (owner: 10Chad) [21:34:09] VladAndrew: I don't see any edit to that page and links lists are not really a good choice as a start [21:34:44] Nemo_bis: They are all translated in other languages but I'll chose another one [21:35:32] Nemo_bis: this one https://www.mediawiki.org/wiki/Help:Managing_files [21:35:35] (03CR) 10Fomafix: Add legend to Special:RecentChanges and Special:Watchlist (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [21:36:01] (03CR) 10Brian Wolff: "This should have ->escaped on the end of it (Its being output directly to html If I'm reading correctly)." [core] - 10https://gerrit.wikimedia.org/r/103354 (owner: 10Whym) [21:37:32] (03PS10) 10Manybubbles: Index and search file text from pdf/djvu files [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 (owner: 10Chad) [21:38:48] VladAndrew: you still didn't take care of the templates [21:39:06] and you need to add some newlines or the translation units will get too big [21:39:42] as covered in https://www.mediawiki.org/wiki/Help:Extension:Translate/Page_translation_administration#Segmentation [21:41:00] (03CR) 10Manybubbles: [C: 032] "I'm going to +2 this because it is either Chad or I, and both of us have worked on it extensively. I'm +2ing it with a clear conscience a" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 (owner: 10Chad) [21:41:04] (03Merged) 10jenkins-bot: Index and search file text from pdf/djvu files [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 (owner: 10Chad) [21:41:19] ^d: ^^ [21:41:26] <^d> woot! [21:41:54] <^d> Fixing a 4-digit bug is fun :) [21:45:59] yeah [21:46:06] I imagine those aren't easy any more [21:46:28] that took three of us and a grand total of a few days [21:46:33] (03PS1) 10Brian Wolff: Don't include empty categories in Special:Mostlinkedcategories [core] - 10https://gerrit.wikimedia.org/r/103856 [21:49:13] (03PS6) 10EBernhardson: Make condensed view more condensed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102707 (owner: 10Matthias Mullie) [21:50:50] Nemo_bis: ok, I thinks I got it right this time [21:53:30] (03CR) 10EBernhardson: [C: 032] "PS6:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102707 (owner: 10Matthias Mullie) [21:53:37] (03Merged) 10jenkins-bot: Make condensed view more condensed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102707 (owner: 10Matthias Mullie) [21:59:28] Nemo_bis: I have studied other files, I may have added yoo many but I can remove them [21:59:41] VladAndrew: almost :) double newline is the same as btw [21:59:46] yes [22:00:34] you can do better in the next page, for now import the old translations of this and add the required links to the task on melange [22:01:09] Nemo_bis: ok [22:01:14] then you can go on with your next page immediately and claim the next task on melange later, there will always be one to claim [22:02:06] Sure thing [22:12:16] (03CR) 10PleaseStand: "> This should have ->escaped on the end of it (Its being output directly to html If I'm reading correctly)." [core] - 10https://gerrit.wikimedia.org/r/103354 (owner: 10Whym) [22:13:06] (03CR) 10Jack Phoenix: "I didn't have any objections to start with, just questions -- I usually tend to mark my objections clearly as such with -1 or -2." [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna) [22:13:38] (03CR) 10CSteipp: [C: 032] "Looks ok, and working in my test setup. Thanks!" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92053 (owner: 10Legoktm) [22:13:47] (03Merged) 10jenkins-bot: Send AbuseFilter hits to CheckUser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92053 (owner: 10Legoktm) [22:14:33] (03CR) 10Brian Wolff: "Sorry, my mistake, ignore me :)" [core] - 10https://gerrit.wikimedia.org/r/103354 (owner: 10Whym) [22:15:04] (03CR) 10Siebrand: "Removing merge block, as BC is kept in this patch." [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/96460 (owner: 10Siebrand) [22:17:03] (03CR) 10Chad: [C: 032] Remove underscore from classes LBFactory_*, LoadBalancer_*, LoadMonitor_* [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [22:17:10] <^d> siebrand: ^^^ :) [22:17:16] ^d: great. [22:17:37] ^d: You can also merge https://gerrit.wikimedia.org/r/#/c/96460/ [22:18:06] ^d: we should hold off on the other 3 until Wikimedia runs the new code. [22:18:21] (03CR) 10Chad: [C: 032] Remove underscore from class names LBFactory_* [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/96460 (owner: 10Siebrand) [22:18:31] (03CR) 10Chad: [V: 032] Remove underscore from class names LBFactory_* [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/96460 (owner: 10Siebrand) [22:19:24] (03CR) 10Chad: [C: 031] Setup unit tests for cirrus [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/103853 (owner: 10Manybubbles) [22:19:56] (03CR) 10Siebrand: "Should be merged once all Wikimedia sites run 1.23wmf9." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/96463 (owner: 10Siebrand) [22:20:16] (03Merged) 10jenkins-bot: Remove underscore from classes LBFactory_*, LoadBalancer_*, LoadMonitor_* [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [22:20:17] (03CR) 10Chad: [C: 032] Made Title cache use MapCacheLRU [core] - 10https://gerrit.wikimedia.org/r/99043 (owner: 10Aaron Schulz) [22:24:16] (03Merged) 10jenkins-bot: Made Title cache use MapCacheLRU [core] - 10https://gerrit.wikimedia.org/r/99043 (owner: 10Aaron Schulz) [22:33:03] (03PS2) 10EBernhardson: (bug 58140) Multiple moderated topics in a row takes up too much space [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103357 (owner: 10Matthias Mullie) [22:33:20] (03CR) 10Parent5446: "Just remember to remove the URL from the commit message before merging, unless that link is permanent." [core] - 10https://gerrit.wikimedia.org/r/103742 (owner: 10Chad) [22:33:28] (03CR) 10EBernhardson: "PS2: Rebased, required a few tweaks to merge so probably needs another review." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103357 (owner: 10Matthias Mullie) [22:36:26] (03CR) 10MaxSem: [C: 04-1] Initial implementation of the JSON configuration store. (033 comments) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [22:39:32] (03CR) 10PleaseStand: "> __toString was previously called here, though now it isn't." [core] - 10https://gerrit.wikimedia.org/r/103354 (owner: 10Whym) [22:40:03] (03CR) 10EBernhardson: "imo, a clearfix would be appropriate in core(+1 here). Going off on a tangent, but there is .ui-helper-clearfix defined by jquery.ui in c" [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna) [22:41:05] (03CR) 10EBernhardson: [C: 031] Add new jquery.scroll.js plugin [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna) [22:41:54] (03CR) 10Parent5446: [C: 032] Deprecate SpecialPage::getTitle [core] - 10https://gerrit.wikimedia.org/r/103587 (owner: 10Legoktm) [22:44:33] (03CR) 10Parent5446: "Duplicate patch? https://gerrit.wikimedia.org/r/65162" [core] - 10https://gerrit.wikimedia.org/r/103852 (owner: 10Hatul) [22:45:08] (03Merged) 10jenkins-bot: Deprecate SpecialPage::getTitle [core] - 10https://gerrit.wikimedia.org/r/103587 (owner: 10Legoktm) [22:48:09] (03CR) 10Jdlrobson: [C: 032] Follow CSS conventions, including @embed [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/103726 (owner: 10Mattflaschen) [22:48:49] (03Merged) 10jenkins-bot: Follow CSS conventions, including @embed [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/103726 (owner: 10Mattflaschen) [22:51:22] (03PS16) 10AndyRussG: Let instructors and other roles add students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 [22:58:05] (03PS1) 10Siebrand: Declare visibility for class property of LoadBalancerSingle [core] - 10https://gerrit.wikimedia.org/r/103863 [22:58:06] (03PS1) 10Siebrand: Declare visibility for class properties of LBFactoryMulti [core] - 10https://gerrit.wikimedia.org/r/103864 [22:58:07] (03PS1) 10Siebrand: Declare visibility for class properties of LBFactory and LBFactorySimple [core] - 10https://gerrit.wikimedia.org/r/103865 [22:59:17] (03CR) 10Krinkle: [C: 04-1] "How would these values end up in cache? This looks like a bug workaround, if so, I'd prefer a bug report first (or describe it in the comm" [core] - 10https://gerrit.wikimedia.org/r/103407 (owner: 10Dr0ptp4kt) [23:00:38] (03CR) 10Krinkle: "Why did the module array move to a static variable?" [core] - 10https://gerrit.wikimedia.org/r/102344 (owner: 10Dr0ptp4kt) [23:11:32] (03CR) 10Chad: "Why wouldn't it be? No worse than any other pastebin :p" [core] - 10https://gerrit.wikimedia.org/r/103742 (owner: 10Chad) [23:13:29] (03CR) 10Nemo bis: "Further, if something bad happened to that URL that would only confirm our rule on blaming domas." [core] - 10https://gerrit.wikimedia.org/r/103742 (owner: 10Chad) [23:14:13] (03PS1) 10Milimetric: Implementing mediawiki oauth for node [passport-mediawiki] - 10https://gerrit.wikimedia.org/r/103866 [23:25:22] (03CR) 10Bartosz Dziewoński: "This will cause the current values to continue to be set, right? Not sure if that's good UI…" [core] - 10https://gerrit.wikimedia.org/r/103742 (owner: 10Chad) [23:30:22] (03PS3) 10Dr0ptp4kt: Make RL more forgiving about cache keys that are int-like strings. [core] - 10https://gerrit.wikimedia.org/r/103407 [23:31:02] (03CR) 10Dr0ptp4kt: "Updated commit message." [core] - 10https://gerrit.wikimedia.org/r/103407 (owner: 10Dr0ptp4kt) [23:33:39] (03PS7) 10Dr0ptp4kt: Add support to get just the startup module URL with version. [core] - 10https://gerrit.wikimedia.org/r/102344 [23:37:24] jdlrobson: you changed the sans-serif and serif font stacks when you moved the LESS into extension VectorBeta, putting the F/OSS fonts first. I like it, why you didn't mention it in the typography design thread? People still think we're preferring proprietary [23:37:55] spagewmf: i've muted that conversation it was frustrating me. [23:38:01] The thread was about which free font to use [23:38:05] not the fact we were using free fonts [23:38:23] there was too much confusion on the email thread and my patience was thin :) [23:38:40] jdlrobson: I can imagine :) Is it OK if I mention the change? It'll go out with 1.23wmf9, right? [23:39:28] sure [23:44:40] (03CR) 10Dr0ptp4kt: "The thought was to have a new static method that didn't technically require an instantiated ResourceLoaderModule subclass. That said, shou" [core] - 10https://gerrit.wikimedia.org/r/102344 (owner: 10Dr0ptp4kt) [23:46:25] (03CR) 10Dr0ptp4kt: "Maybe that doesn't answer the question, though. The point was just to make it the array available where needed elsewhere. It could just as" [core] - 10https://gerrit.wikimedia.org/r/102344 (owner: 10Dr0ptp4kt) [23:58:33] (03CR) 10CSteipp: [C: 04-1] "Not working well in test yet.." (034 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (owner: 10Legoktm)