[05:21:06] (03CR) 10EBernhardson: Split redlinking out of Templating class (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103259 (owner: 10EBernhardson) [05:21:07] vishnu: looks like it moved to includes/cache/ http://git.wikimedia.org/commit/mediawiki%2Fcore.git/43ae2fb6f91e25d03bd8ddc358debc1f95a13e57 [05:21:46] vishnu: http://git.wikimedia.org/blob/mediawiki%2Fcore.git/f22e2e04fdded135353f188a5840671824529771/includes%2Fcache%2FMessageCache.php [05:22:38] moved to includes/clientpool/RedisConnectionPool.php ? [05:23:06] mutante: Thank you sir for the reply anyway [05:23:07] vishnu: i still see it in mediawiki/core in includes/cache/ [05:23:08] vishnu: While the patch is 6 years old. Things bitrot [05:23:22] vishnu: i just search git.wikimedia.org for the file name [05:23:35] here is how to clone and submit patch http://www.mediawiki.org/wiki/Gerrit/Tutorial [05:23:45] the better way than appending to Bugzilla and SVN back then [05:24:02] it all changed in between [05:24:34] Sir i cant find the codes which are mentioned in the diff in those MessageCache.php to submit my patch.I cant edit it because i am not able to find the codes mentioned [05:26:57] vishnu: I see you already updated the bug, that's good [05:27:06] Nemo_bis: can you help vishnu ? [05:30:21] vishnu: you can also try posting this on the mailing list to get faster replies [05:30:42] I already posted sir [05:32:02] I was trying to learn submitting a patch through this bug. Hopefully it was an outdated one.Any way can you suggest me with any easy bugs to start with.I tried searching but As you know Im new to this i was not able to gigure it out [05:34:10] vishnu: sorry, I think just nobody knows the line number yet because the bug is so old and since 2007 it is so different [05:34:19] yes, hold on [05:34:28] Also I don't think that bug is even present anymore [05:34:50] vishnu: look for something else here maybe http://www.mediawiki.org/wiki/Annoying_little_bugs [05:34:59] So I think there's no point in trying to submit that patch right? [05:35:01] vishnu: and to learn how to submit a patch, see the Gerrit tutorial [05:35:09] everything is git and Gerrit now [05:35:30] not SVN and diffs anymore like you found on that old bug [05:35:38] that just made it more confusing for you [05:35:42] to begin with [05:36:06] vishnu: maybe it was just not the best one to use to learn how to submit a simple patch [05:36:12] but there are others [05:36:49] Aren't there test repos for people who just want to try submitting something as a test? [05:36:49] https://bugzilla.wikimedia.org/buglist.cgi?columnlist=opendate%2Cvotes%2Cbug_severity%2Cpriority%2Cop_sys%2Cbug_status%2Cresolution%2Cshort_desc&field0-0-0=votes&query_format=advanced&resolution=---&type0-0-0=greaterthan&value0-0-0=-1&order=votes%20DESC%2C&keywords=easy&keywords_type=allwords&list_id=261607 [05:37:15] dunno, gammalabs? [05:37:26] eh, alpha:) [05:37:53] vishnu: If you want a super easy bug, try https://bugzilla.wikimedia.org/show_bug.cgi?id=58615 [05:39:02] component Math. heh [05:39:09] vishnu: You basically have to do the exact same as this patchset: https://gerrit.wikimedia.org/r/#/c/103088/ except in the Math extension instead of Score extension [05:39:37] mutante: The non scary (non-OCamal) part of that extension :P [05:39:54] ok:) [05:40:25] bawolff: thank you sir, In between can you please tell me how to get that bug assigned ? [05:41:03] vishnu: Is your bugzilla email mails2vichu@gmail.com ? [05:41:11] yes sir [05:42:26] should be assigned to you now [05:42:51] Thank you sir [05:43:08] For what its worth, we don't actually use the assignment feature of bugzilla too much, so you don't have to have a bug assigned to you to work on it [05:43:43] Im gonna work on that sir.Hope you will help me if i am stuck with it [05:45:30] vishnu: Of course. Also you don't have to use "sir", we're an informal bunch [05:45:43] ok :) [05:49:03] Can you please tell me how to download that patch from the link that you gave me a few seconds back [05:49:27] vishnu: Do you have git setup? [05:49:47] yes [05:50:28] do you also have "git review" setup? [05:50:39] it's an extra tool [05:50:42] yes [05:51:31] vishnu: git review -d 103088 [05:51:44] i just took the number from the link [05:51:51] Make sure to do that from inside the repo for the Score extension [05:52:24] inside core? [05:52:51] A no, that patch is for an extension (As opposed to mediawiki core), so you have to download that extension as a separate git repo [05:52:54] there are several ways, you can also go to https://gerrit.wikimedia.org/r/#/c/103088/1/Score.body.php and click the Download icon on the right hand side [05:53:13] ok, listen to bawolff:) [05:54:31] you can use a command like git clone https://gerrit.wikimedia.org/r/p/mediawiki/extensions/Score.git [05:54:43] i just ran the command git review -d 103088 but it says could not connect to geerit [05:57:04] if you run it the very first time you need to use -s to set it up, one time only [05:57:27] Thank you.Downloaded through the link given by you [05:58:06] https://www.mediawiki.org/wiki/Git/git-review#Setting_up_git-review [05:58:13] nice [05:59:30] (03CR) 10Mattflaschen: "See inline. Bottom line, I can changed it to @embed in this, or a separate patch." (031 comment) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/103491 (owner: 10Mattflaschen) [06:00:23] Now i just have to submit a patch like what exactly did in the patch you gave? [06:06:34] vishnu: Yes, but for the other extension [06:10:02] yurik Hello [06:12:05] Ok .I'll go through it [06:52:16] (03CR) 10Mattflaschen: "What about existing code using jquery.client that is also philosophically incorrect? :)" [core] - 10https://gerrit.wikimedia.org/r/95962 (owner: 10Bartosz Dziewoński) [06:53:11] (03PS1) 10Brian Wolff: getDescription must return a string, not a message object. [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/103527 [06:59:07] (03CR) 10Siebrand: [C: 032] getDescription must return a string, not a message object. [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/103527 (owner: 10Brian Wolff) [07:00:29] (03PS1) 10Brian Wolff: Clarify comment on SpecialPage::getDescription [core] - 10https://gerrit.wikimedia.org/r/103528 [07:00:29] Woo, quick review. Thanks siebrand [07:01:02] bawolff: I always start with the latest thread in mediawiki-commits, so someone is the lucky one :) [07:02:37] siebrand: I've been meaning to ask you. There's a patch by a new person who added a message, they also added a translation to the pl file. Would translatewiki sort that out fine, or would that cause a problem? [07:03:21] bawolff: That Polish thing? [07:03:29] bawolff: It's highly discouraged. [07:03:51] So I should -1 the commit on account of that? [07:04:08] I've got other things to -1 it for as well, so its not just that [07:04:32] bawolff: It should be okay, but adds possible confusion when processing for L10n. It's not a -1 thing, but worth a comment with ref to docs. [07:04:48] ok [07:10:08] (03CR) 10Legoktm: [V: 032] getDescription must return a string, not a message object. [extensions/TwoFactorAuthentication] - 10https://gerrit.wikimedia.org/r/103527 (owner: 10Brian Wolff) [07:10:40] legoktm: Hmm, that extension needs Jenkins. [07:10:51] yeah [07:11:31] I've always wondered why jenkins doesn't just lint all extensions, would make "verified" less confusing if it was only ever touched by the bot [07:12:34] has anyone checked that all extensions pass linting? :P [07:13:51] bawolff: did you see my last comment at https://gerrit.wikimedia.org/r/#/c/103347/ ? [07:13:54] i walked a new wmf engineering recruit through our gerrit workflow last week [07:14:07] it's impossible to do without constantly apologizing for how awful so many things are [07:14:33] Hi guys i am new developer to this community had a doubt while making a tag extension ....does the example given in https://www.mediawiki.org/wiki/Manual:Tag_extensions/Example works well for mediawiki 1.21.2???? [07:15:32] ori-l: Quick question: css selectors like label[for=foo] are bad css-performance wise, right? [07:16:16] aalekhN: yeah, it should. is something not working? [07:16:16] aalekhN: Better than most of the outdated tutorials that are on MediaWiki.org [07:17:25] aalekhN: There's one or two minor things about the tutorial (Like mediawiki naming conventions would have the file named Poll_body.php not poll_body.php) but they are pretty minor [07:17:45] aalekhN: Except the part about $wgOut, that's wrong [07:17:53] i was trying to implement css as told by the tutorial but there doesn't seem to have any result to the given css [07:18:37] so what should i do to implement the css?? [07:18:43] aalekhN: Well not wrong as in it doesn't work, just that includes the css on all pages, where the proper thing to do is only include the css on needed pages [07:19:46] aalekhN: Can you pastebin the code you have somewhere? [07:20:46] yup 2 min i am pasting the code for Onparseeinit func. [07:20:47] (03CR) 10Brian Wolff: [C: 04-1] "I asked Siebrand for clarification, and he said that adding non-en messages in git is discouraged, but not outright disallowed." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/103351 (owner: 10M4tx) [07:21:22] bawolff: not really [07:22:09] http://pastebin.com/6BaFrzkp [07:22:28] if you compare it to a class name selector you'll find that performance is worse because the browser has to perform more checks (is the node a label? does it have a 'for' attribute? is its value 'foo'?) [07:23:03] but the difference is minuscule. the overriding consideration should be clarity and consistency of code style [07:23:04] ori-l: I mean #SomeAppropriateId vs label[for="mw-input-wpConfirm"] [07:23:31] Or more specificly is my comment on https://gerrit.wikimedia.org/r/#/c/103351/1/resources/mediawiki.special/mediawiki.special.block.css totally wrong [07:24:17] there is a difference, just not a relevant one [07:24:25] ok [07:24:58] (03CR) 10Brian Wolff: Fix user-friendlyness of block confirmation screen (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103351 (owner: 10M4tx) [07:26:21] aalekhN: Is that all the code you have? that by itself won't work as its missing the hook registration part, and the module registration [07:27:31] no no i just gave u the onparseinit func part wait i m sending u the every part [07:28:15] legoktm: On the specialpage thing. That still seems kind of weird - deprecate a function, moving people to a new function, so we can undeprecate it and reuse the function name for something else later [07:28:33] It does, but I can't think of a better way to do it [07:29:14] Personally I'm not sure the small benefit of being able to remove a small amount of repetitive code is worth all that [07:29:32] Well, should SpecialPage's not be ContextSources? [07:31:29] bawolff:::Here is the complete code of all files u asked http://pastebin.com/GUHt9J9a [07:37:58] aalekhN: So it seems your missing the aalekhN: Also, did you remember to add require_once( "$IP/extensions/Poll/poll.php" ); to the bottom of LocalSettings.php [07:40:32] bawolff: PHPStorm finds 618 usages of SpecialPage::getTitle in core + extensions in gerrit ;) [07:40:47] yeah, have fun deprecating that :P [07:41:10] well, it takes PHPStorm about 2 minutes to update all the files [07:41:16] someone just has to merge all the commits :P [07:41:32] (03PS1) 10Siebrand: Add Jenkins jobs for TwoFactorAuthentication [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/103529 [07:42:48] Yup tried these suggestions also and placed the css file in a folder named resources but still not working earlier in ur mess. u were telling some problem with $wgOut please elaborate ....is it not supposed to be there?? [07:42:52] The things people can do with computers... [07:44:06] (03CR) 10Siebrand: [C: 04-1] Clarify comment on SpecialPage::getDescription (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103528 (owner: 10Brian Wolff) [07:44:10] aalekhN: Oh, you're not supposed to put the css file in the resources folder of mediawiki [07:44:28] aalekhN: You're supposed to put it in a folder named resources that is a subfolder of Poll [07:44:34] liangent, online? [07:45:17] siebrand: Interesting, that actually happened, I thought that was still in RFC stage [07:45:31] yup i did exactly the same....resources folder inside poll folder [07:45:56] bawolff: https://github.com/wikimedia/mediawiki-core/commit/2f7b68ffde472d1faf95f7402056ad0a0feab1fb [07:46:19] aalekhN: Does the actual tag part work? [07:46:21] oh, let me find the real commit [07:46:29] https://github.com/wikimedia/mediawiki-core/commit/6380e81cd0c2dcfe387f2fcc8646a3ab1165b57d [07:46:36] bawolff: Translate is already converted, with BC, TwnMainPage has no BC (so 1.23 alpha and up only), and it's running production on ttranslateiwki.net [07:46:47] cool [07:47:14] However, perhaps I should just link to the docs on mw.org instead of talking about a specific variable [07:47:16] bawolff: There are some todos, but highest priority now is for LocalisationUpdate to support the new format. RoanKattouw_away will be working on that once he gets back from leave. [07:47:32] That would probably be more useful then the specific variable name [07:47:39] * siebrand nods. [07:47:40] vishnu gone I see [07:48:15] yes it worked perfectly and let me remind u i m working with mediawiki1.21.2......does version affects the compatibility of example specified? [07:48:39] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88895 (owner: 10Legoktm) [07:48:52] Nemo_bis: I convinced him to work on an easy bug in the Math extension [07:52:03] (03CR) 10Siebrand: [C: 032] i18n: consistency tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103507 (owner: 10Shirayuki) [07:52:12] aalekhN: That's a close enough version it wouldn't matter. [07:52:17] (03Merged) 10jenkins-bot: i18n: consistency tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103507 (owner: 10Shirayuki) [07:53:48] aalekhN: Maybe something wrong with how its loading css. The next debuging step I would reccomend is using firebug (or some other browser debugger), load a page with ?debug=true and see if there's any 404 errors on the loaded resources [07:53:50] (03CR) 10Siebrand: Avoid globally oversighting users with over 1000 edits (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/103216 (owner: 10Theopolisme) [07:56:17] bawolff::going to try that....maybe i should also try experimenting with the css file by making extension input colored Hello World and see if that worked out.... [07:56:25] (03PS2) 10Brian Wolff: Clarify comment on SpecialPage::getDescription [core] - 10https://gerrit.wikimedia.org/r/103528 [07:59:16] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103336 (owner: 10Bsitu) [08:00:38] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102707 (owner: 10Matthias Mullie) [08:01:37] aalekhN: btw, usually in the resource loader definitions, the path parts are in a different part (like https://dpaste.de/CwOP ). I don't think it makes a difference though [08:03:32] (03CR) 10Brian Wolff: "Sorry, forgot one thing, When adding new messages, you also need to add documentation to MessagesQqq.php https://www.mediawiki.org/wiki/I1" [core] - 10https://gerrit.wikimedia.org/r/103351 (owner: 10M4tx) [08:16:25] (03CR) 10Siebrand: Clarify comment on SpecialPage::getDescription (032 comments) [core] - 10https://gerrit.wikimedia.org/r/103528 (owner: 10Brian Wolff) [08:18:27] siebrand: The reason I thought to add it was due to the bug in the other extension. Its somewhat of a reasonable assumption that an object with a toString() method can be returned where a string is expected [08:19:19] bawolff: Feels to me like a lot of weight. I don't feel strongly about it, and to be fair, it does correct something that's plain wrong :) [08:19:58] bawolff: Can you fix the @return String -> @return string? I'll +2 after. [08:20:20] Maybe you're right. It is really something that should be sufficient to just have the return type [08:23:46] (03PS3) 10Brian Wolff: Clarify comment on SpecialPage::getDescription [core] - 10https://gerrit.wikimedia.org/r/103528 [08:25:09] (03CR) 10saper: "I think the core of the problem is somewhere else, just wrapping an exception is not good. Besides, if *no* database extensions are instal" [core] - 10https://gerrit.wikimedia.org/r/103379 (owner: 10btongminh) [08:39:13] (03PS16) 10Yurik: Initial implementation of the JSON configuration store. [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 [08:39:24] (03CR) 10Brian Wolff: [C: 04-1] "See inline comments." (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103345 (owner: 10Theopolisme) [08:53:03] (03PS1) 10Jcf2000: Show "Suppress Redirect" checkbox on Special:MovePage when redirect is impossible [core] - 10https://gerrit.wikimedia.org/r/103530 [09:03:40] (03PS2) 10Brian Wolff: Show "Suppress Redirect" checkbox on Special:MovePage when redirect is impossible [core] - 10https://gerrit.wikimedia.org/r/103530 (owner: 10Jcf2000) [09:04:10] (03CR) 10Brian Wolff: "Some minor comments (See inline on PS1)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/103530 (owner: 10Jcf2000) [09:07:28] hi guillom [09:07:35] hi [09:08:04] mayankmadan: there is no need to send me e-mails about your tasks. I get automated notifications from Melange. [09:08:13] did not know that [09:08:21] and sorry [09:08:23] You do now :) [09:08:28] No problem. [09:12:59] guillom, did you send any messages? [09:13:09] no [09:13:11] i didnt receive any because i disconnected [09:13:16] (03PS1) 10Matthias Mullie: Add tipsy className before calculating position [core] - 10https://gerrit.wikimedia.org/r/103531 [09:16:21] liangent, online? [09:18:14] I was having troubles with cloning the repository Math.git and it says permission denied(Public key).Can anyone help me to figure it out? [09:21:48] (03PS3) 10Jcf2000: Show "Suppress Redirect" checkbox on Special:MovePage when redirect is impossible [core] - 10https://gerrit.wikimedia.org/r/103530 [09:22:29] I didn't get you [09:22:49] udayan_: What OS are you running? [09:22:57] Ubuntu [09:24:26] Usually permission denied will occur if you typed in your name wrong. Are you using the git clone ssh://@gerrit.wikimedia.org:29418/mediawiki/extensions/.git format? [09:24:46] Because if so, make sure was correct [09:26:09] but i checked.Username is correct Im sure [09:26:35] Not tested, but try this then [09:26:36] git clone https://gerrit.wikimedia.org/r/p/mediawiki/extensions/Math.git [09:28:22] Not working [09:28:34] Same error? [09:29:11] one sec [09:29:17] let me try oncemore [09:30:07] It worked.Thanks dude [09:30:18] No problem :) [09:31:05] could someone help me here? [09:31:14] I'm waiting for my GCI task to be reviewed [09:31:29] will it still be reviewed if the time's up? [09:32:18] Do you mean your gerrit patch? [09:32:39] yes [09:32:41] microchip_sac: what task is it? [09:32:55] http://www.google-melange.com/gci/task/view/google/gci2013/5221651989921792 [09:32:56] Port lonelypages.py to core [09:32:56] Status: NeedsReview (4 hours, 53 minutes left) [09:32:56] Mentor(s): Strainu [09:33:25] and if it's all right, it needs to be accepted [09:35:57] Your work will be reviewed regardless of whether your task time has run out. However, you may need to ask for a time extension or reclaim the task if you want it completed as well [09:37:33] but is the gerrit patch all right? [09:37:57] I still have some time remaining, so I could fix any problems [09:38:08] and the task could be completed as well [09:38:56] mayankmadan_: as a general comment: please add a descriptive edit summary when you add TemplateData to a page. It can be something as simple as "add TemplateData". It will make it easier for other editors to know what your large edit was about without having to pull the diff. [09:39:53] guillom: did you see the patch? [09:40:34] microchip_sac: I did, but I can't review your code. [09:40:49] who can? [09:40:59] You'll need to wait for your mentor or another developer to do it. [09:43:15] guillom, what is descriptive edit summary and where do i add it? [09:44:05] mayankmadan_: https://en.wikipedia.org/wiki/Help:Edit_summary [09:45:17] guillom, http://www.google-melange.com/gci/task/view/google/gci2013/5881551703244800 [09:45:18] Add template data to two popular Wikipedia templates #7 [09:45:18] Status: ClaimRequested [09:45:18] Mentor(s): Guillaume Paumier, Quim Gil [09:46:18] guillom, i have claimed it and have already done it [09:47:29] mayankmadan_: You're doing good work, but I'm not sure you're learning a lot by repeating the same work again and again [09:47:53] guillom, i am just doing it to increase the no. of tasks [09:48:45] i have already talked to yurik about developing full test coverage for zero repository [09:48:47] guillom, ^ [09:50:32] mayankmadan_: You do realize that the number of tasks you accomplish is only one factor and won't automatically grant you a plane ticket to Google HQ, right? [10:07:44] guillom, i do complex tasks too [10:11:00] is aaron aarcos online? [10:25:58] Hi, I'm inspecting the bug report at https://bugzilla.wikimedia.org/show_bug.cgi?id=58356 and I can't seem to replicate the issue [10:26:15] What exactly do they mean by "headings" in the mobile frontend editor? [10:28:26] git review -R doesn't works it says couldnt connect to gerrit [10:28:39] is there any other way to push it? [10:29:25] it say "We don't know where your gerrit is. Please manually create a remote [10:29:25] named "gerrit" and try again." [10:30:38] It sounds to me like you didn't set up your gerrit environment correctly [10:31:19] Try running just plain git review [10:31:31] No -R; may or may not work, just try it [10:33:08] still error [10:34:54] (03PS2) 10M4tx: Fix user-friendlyness of block confirmation screen [core] - 10https://gerrit.wikimedia.org/r/103351 [10:35:47] udayan_: Still there? [10:35:55] yup [10:36:07] udayan_: Try running git review -s in your project directory [10:36:17] (03CR) 10jenkins-bot: [V: 04-1] Fix user-friendlyness of block confirmation screen [core] - 10https://gerrit.wikimedia.org/r/103351 (owner: 10M4tx) [10:36:46] project directory? [10:36:59] Yeah, the directory of the repo [10:37:06] Your working directory [10:39:12] still error it seems [10:39:41] Can you copy the error? [10:40:20] yup [10:41:57] Trying again with ssh://vishnu@gerrit.wikimedia.org:29418/mediawiki/extensions/Math.git [10:41:57] [10:41:57] We don't know where your gerrit is. Please manually create a remote [10:41:57] named "gerrit" and try again. [10:41:57] Traceback (most recent call last): [10:41:57] File "/usr/local/bin/git-review", line 1196, in [10:41:59] main() [10:42:01] File "/usr/local/bin/git-review", line 1110, in main [10:42:03] config['hostname'], config['port'], config['project']) [10:42:05] File "/usr/local/bin/git-review", line 489, in check_remote [10:42:07] add_remote(hostname, port, project, remote) [10:42:09] File "/usr/local/bin/git-review", line 344, in add_remote [10:42:11] raise Exception("Could not connect to gerrit at %s" % remote_url) [10:42:13] Exception: Could not connect to gerrit at ssh://vishnu@gerrit.wikimedia.org:29418/mediawiki/extensions/Math.git [10:42:40] udayan_: please use pastebin [10:42:46] for long pastes [10:42:57] how? [10:43:06] go to pastebin.com [10:43:15] paste your copy/paste there [10:43:23] link the resulting paste URL here [10:43:56] udayan_: does "ssh -p 29418 vishnu@gerrit.wikimedia.org" work? [10:44:50] no it didnt work [10:44:54] it said ssh: connect to host gerrit.wikimedia.org port 29418: No route to host [10:45:16] so you have some firewall/networking problem to connect to gerrit Wikimedia installation [10:46:30] you need to have a clear TCP connection to port 29418/tcp to IPv6 2620:0:861:3:208:80:154:81 or IPv4 208.80.154.81 [10:46:32] Im using ubuntu so will it happen? [10:46:46] Im ubuntu so how to do that? [10:46:51] can you ping 208.80.154.81 ? [10:47:50] i did [10:48:00] (03CR) 10Siebrand: [C: 032] Clarify comment on SpecialPage::getDescription [core] - 10https://gerrit.wikimedia.org/r/103528 (owner: 10Brian Wolff) [10:48:20] and? I get "2 packets transmitted, 2 packets received, 0.0% packet loss [10:48:53] so what should i understand from that? [10:48:57] (03PS3) 10M4tx: Fix user-friendlyness of block confirmation screen [core] - 10https://gerrit.wikimedia.org/r/103351 [10:48:58] (03PS3) 10Springle: Added a page_links_updated column for job de-duplication [core] - 10https://gerrit.wikimedia.org/r/101170 (owner: 10Aaron Schulz) [10:49:16] do you have "packets transmitted" line after you press ctrl-c ? [10:49:46] 124 packets transmitted, 123 received, 0% packet loss, time 123145ms [10:50:26] ok [10:50:46] Are you able to figure it out? [10:50:53] can you try "ping6 2620:0:861:3:208:80:154:81" as well? [10:51:29] From fe80::48ea:42a9:362a:dad icmp_seq=5 Destination unreachable: Beyond scope of source addres [10:51:41] no, I am not able to figure your problem out. Seems like the problem with your Ubuntu installation/your router/your Internet provider [10:51:46] ah [10:52:10] (03Merged) 10jenkins-bot: Clarify comment on SpecialPage::getDescription [core] - 10https://gerrit.wikimedia.org/r/103528 (owner: 10Brian Wolff) [10:52:33] is there any other way? [10:52:44] looks like there is some IPv6 problem there [10:53:11] udayan_: does does "ifconfig eth0 | grep inet6" say? [10:53:32] er, udayan_: what does "ifconfig eth0 | grep inet6" say? [10:53:58] nothing is displayed [10:54:34] (03PS4) 10Springle: Added a page_links_updated column for job de-duplication [core] - 10https://gerrit.wikimedia.org/r/101170 (owner: 10Aaron Schulz) [10:56:01] I have a question about https://bugzilla.wikimedia.org/show_bug.cgi?id=58356. In the bug report, it indicated that the headings are still printed in English. However, I can't find the headers they are referring to. What are the headers in the mobile editor? [10:56:16] udayan_: what does this say: "ip -f inet6 addr list" [10:56:53] saper: i had problem when i configured git review.I was not able to find the git-review.conf file [10:58:43] (03CR) 10Springle: [C: 032] "Schema change done." [core] - 10https://gerrit.wikimedia.org/r/101170 (owner: 10Aaron Schulz) [11:00:58] saper: you there? [11:03:02] udayan_: yes, I am here. But you have a networking problem. [11:03:40] why? Isn't it some problem with configuring git review.it was not done proprly [11:03:47] no [11:04:05] you just can't connect to some IPv6 sites I think. [11:04:26] how can i solve it? [11:04:29] but I don't know for sure unless you give me "ip -f inet6 addr list" [11:04:58] here's what you asked for [11:04:59] http://pastebin.com/bWKfMVta [11:05:41] thanks [11:05:58] udayan_: can you also paste me "ip -f inet6 route list [11:06:55] http://pastebin.com/Gy9xqmpe [11:07:25] udayan_: I think your wireless router is misconfigured [11:07:36] misconfigured? [11:07:45] yes [11:07:55] is there anything that i could do to fix it? [11:08:10] it does announce IPv6 default route to wireless stations and does not provide real IPv6 connectivity [11:08:31] udayan_: is this router yours or coming from the provider? [11:08:47] from the provider [11:08:53] udayan_: you can check if there are any IPv6 options in your router [11:09:35] udayan_: so ask call them and tell them you are getting "From fe80::48ea:42a9:362a:dad icmp_seq=5 Destination unreachable: Beyond scope of source address" when trying to "ping6 2620:0:861:3:208:80:154:81" and ask them to enable real IPv6 access for you. [11:11:08] or alternatively, ask them how to "disable sending IPv6 router advertisements by the router" [11:11:39] by the way you might be having lots of problems with many websites [11:13:45] oho router got restarted :) [11:26:31] (03PS2) 10Nemo bis: Included a hook to have access to templates and other transcluded pages. [core] - 10https://gerrit.wikimedia.org/r/103238 (owner: 10Cptanu) [11:31:38] saper:you there? [11:36:34] udayan_: yes? [11:36:44] (03CR) 10Gergő Tisza: "Nitpicks." (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103518 (owner: 10Aarcos) [11:37:44] udayan_: how's your IPv6? [11:37:47] (03PS1) 10Shirayuki: i18n: consistency tweaks [extensions/TimezoneSelector] - 10https://gerrit.wikimedia.org/r/103533 [11:40:15] udayan_: can you go to http://test-ipv6.com/ ? [11:40:30] i enabled ipv6 [11:40:31] but still same error [11:43:07] udayan_: can you try http://test-ipv6.com/ ? [11:45:54] udayan_: looks interesting http://soumalyaray.blogspot.de/2011/01/bsnl-has-zero-compatibility-with-ipv6.html but it's almost 3 years old [12:04:51] Does anyone have chrome beta ( 32.0.1700.68 beta ) installed? [12:07:53] (03PS1) 10Shirayuki: i18n: reword messages [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/103536 [12:08:10] (03CR) 10M4tx: "Second changeset is another implementation of what I've done here. I was asked to do it as separate commit, so I've done it. Although, I t" [core] - 10https://gerrit.wikimedia.org/r/98856 (owner: 10M4tx) [12:29:45] (03CR) 10Nemo bis: [C: 031] i18n: consistency tweaks [extensions/TimezoneSelector] - 10https://gerrit.wikimedia.org/r/103533 (owner: 10Shirayuki) [12:43:34] (03CR) 10btongminh: "Causes bug 58167" [core] - 10https://gerrit.wikimedia.org/r/90269 (owner: 10Tim Starling) [12:45:13] (03CR) 10btongminh: "Perhaps not good, but I don't see a proper way to fix this other than splitting up DatabaseBase::factory() in a check and a construction p" [core] - 10https://gerrit.wikimedia.org/r/103379 (owner: 10btongminh) [12:48:36] (03CR) 10saper: "Yes, Id1a3fc34e94006b880f58de83e5e7c70b21d26ed should be reverted/revisited, working it around makes no sense." [core] - 10https://gerrit.wikimedia.org/r/103379 (owner: 10btongminh) [12:49:31] (03CR) 10Siebrand: [C: 032 V: 032] i18n: reword messages [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/103536 (owner: 10Shirayuki) [12:50:23] (03CR) 10Siebrand: [C: 032 V: 032] "Thanks!" [extensions/TimezoneSelector] - 10https://gerrit.wikimedia.org/r/103533 (owner: 10Shirayuki) [12:54:54] (03CR) 10Siebrand: "This causes:" [core] - 10https://gerrit.wikimedia.org/r/101170 (owner: 10Aaron Schulz) [12:55:12] springle-away: Hmm on https://gerrit.wikimedia.org/r/#/c/101170/. [12:55:45] AaronSchulz: https://gerrit.wikimedia.org/r/#/c/101170/ spews warnings as long as the schema is not updated. I thought that schema updates have to be implemented in a forgiving way. [12:56:14] 2013-12-24 12:56:08 v220131064414794.yourvserver.net translatewiki_net-bw_: [293a9034] /wiki/Wikimedia:Wsa-review-view-contrib-explain/en Exception from line 1111 of /www/translatewiki.net/w/includes/db/Database.php: A database error has occurred. Did you forget to run maintenance/update.php after upgrading? See: https://www.mediawiki.org/wiki/Manual:Upgrading#Run_the_update_script [12:56:56] (03CR) 10Phe: [C: 031] "+1 but wasn't the summary like /* Msg */ rather than /*Msg*/ ? This change was added by a previous patch but I missed it." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/103349 (owner: 10Tpt) [12:58:31] apergos: PHP fatal error in /usr/local/apache/common-local/php-1.23wmf7/extensions/GlobalBlocking/SpecialGlobalBlock.php line 278:Call to a member function getPrefixedText() on a non-object [12:58:54] opps, sorry didn't mean to ping you again [12:58:56] heh [12:59:29] aharoni: would you know who might know about this? [13:01:03] (03PS2) 10Gergő Tisza: Handle multiple Flickr uploads with identical title [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103388 [13:03:29] (03CR) 10Gergő Tisza: "Added tests." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103388 (owner: 10Gergő Tisza) [13:03:36] (03CR) 10Gergő Tisza: Handle multiple Flickr uploads with identical title (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103388 (owner: 10Gergő Tisza) [13:11:09] (03CR) 10Rtdwivedi: [C: 031] (bug 58870) Add the level tag even if an other autosummary is created [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/103349 (owner: 10Tpt) [13:11:28] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/103351 (owner: 10M4tx) [13:15:12] (03CR) 10Siebrand: [C: 04-1] "Per https://gerrit.wikimedia.org/r/#/c/98767/10/JsonConfig.i18n.php" [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [13:16:21] siebrand, what's the issue with it? [13:17:04] matanya: That's occuring? [13:17:21] yes Reedy [13:17:51] (03CR) 10Nemo bis: "Where is the bug for this? https://wikitech.wikimedia.org/wiki/Schema_changes" [core] - 10https://gerrit.wikimedia.org/r/101170 (owner: 10Aaron Schulz) [13:17:55] very hard to global block this way [13:18:17] $title = Title::makeTitleSafe( NS_USER, $this->mAddress ); [13:18:21] When is a title not a title [13:18:37] (03CR) 10Siebrand: "You can use the API to find gender for users you have the name of, but not the gender. Example: https://translatewiki.net/w/api.php?action" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/102679 (owner: 10Raimond Spekking) [13:18:45] Wonder who changed it recently [13:19:04] git blame :) [13:19:12] I'm github blame [13:19:38] matanya: Not for years [13:19:51] 2009 and 2012 [13:19:54] this one was ipv6 address [13:20:23] Reedy: 2A02:2498:E003:68:225:90FF:FE88:4840 if to be specific [13:20:38] I suspect this is easily replicable using eval.php [13:20:43] matanya: Which wiki? [13:21:08] meta, as this is a gblock [13:22:44] Interesting, it's not null via eval.php [13:23:41] anyway, even if it is null, i should get a proper warning, not the "wikimedia error" page :) [13:24:20] I'm going to at least stop the fatal in production [13:24:32] Might need/want a bit of further investigation later [13:25:16] matanya: https://bugzilla.wikimedia.org/show_bug.cgi?id=58934 [13:25:28] Reedy: if you need me ping [13:25:56] Might wanna CC yourself on the bug [13:26:57] (03PS1) 10Reedy: Title::makeTitleSafe can return null [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/103542 [13:27:15] (03CR) 10Reedy: [C: 032] Title::makeTitleSafe can return null [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/103542 (owner: 10Reedy) [13:27:17] done. thanks a lot Reedy [13:27:17] (03Merged) 10jenkins-bot: Title::makeTitleSafe can return null [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/103542 (owner: 10Reedy) [13:28:45] (03PS1) 10Reedy: Update GlobalBlocking to master [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/103543 [13:29:17] (03PS2) 10Reedy: Update GlobalBlocking to master [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/103543 [13:29:35] (03CR) 10Reedy: [C: 032 V: 032] Update GlobalBlocking to master [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/103543 (owner: 10Reedy) [13:33:05] (03CR) 10Siebrand: [C: 04-1] "It used to be 2 rows, 50 columns. That's now 25 rows, 125 columns. That's indeed a lot. This patch reduces to 15 rows and 100 columns. I t" [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/103395 (owner: 1001tonythomas) [13:34:58] better new Reedy : i got Your block was unsuccessful, for the following reason: [13:34:58] The IP address (2A02:2498:E003:68:225:90FF:FE88:4840) you entered is invalid. Please note that you cannot enter a user name! [13:35:34] globalblocking-block-ipinvalid [13:35:49] if ( !IP::isIPAddress( $ip ) ) { [13:36:09] so this is much better, though i would expect it to work :) [13:36:29] > var_dump( IP::isIPAddress( '2A02:2498:E003:68:225:90FF:FE88:4840' ) ); [13:36:30] bool(true) [13:36:32] Eh [13:37:21] Oh, lets see what the sanitizer does [13:37:35] I wonder if that's why it was null above oto [13:40:25] (03PS1) 10Matthias Mullie: (bug 58376) white space in topic title appears in 'Comment on " title"' placeholder [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103545 [13:43:08] (03CR) 10Siebrand: "Documentation issue inline." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/101170 (owner: 10Aaron Schulz) [13:46:33] Reedy: if you are already in blocking issue: https://nl.wikipedia.org/w/index.php?title=Speciaal:Logboeken&type=block&page=User%3AHoogeveen123&uselang=en [13:46:42] with an expiry time of 20:02, 1 January 1970 [13:48:36] (03PS3) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement execute() [core] - 10https://gerrit.wikimedia.org/r/103240 [13:48:37] (03PS1) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/103546 [13:49:26] (03CR) 10jenkins-bot: [V: 04-1] ChangesListSpecialPage: Implement execute() [core] - 10https://gerrit.wikimedia.org/r/103240 (owner: 10Bartosz Dziewoński) [13:50:11] (03CR) 10jenkins-bot: [V: 04-1] ChangesListSpecialPage: Implement buildMainQueryConds() [core] - 10https://gerrit.wikimedia.org/r/103546 (owner: 10Bartosz Dziewoński) [13:55:17] (03CR) 10Siebrand: "@Nik: Yes, that's why I added Raimond as reviewer. If you don't do it, he'll at least consider doing it :)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/103369 (owner: 10Manybubbles) [13:55:32] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/103369 (owner: 10Manybubbles) [14:08:58] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.Uri: Fix host example and change foo.com to example.com [core] - 10https://gerrit.wikimedia.org/r/103488 (owner: 10Krinkle) [14:12:24] (03Merged) 10jenkins-bot: mediawiki.Uri: Fix host example and change foo.com to example.com [core] - 10https://gerrit.wikimedia.org/r/103488 (owner: 10Krinkle) [14:14:16] (03PS1) 10Cicalese: Improved SMW query code. [extensions/TitleIcon] - 10https://gerrit.wikimedia.org/r/103549 [14:15:56] mayankmadan_: hello [14:17:19] hi liangent [14:19:24] (03CR) 10Cicalese: [C: 032 V: 032] Improved SMW query code. [extensions/TitleIcon] - 10https://gerrit.wikimedia.org/r/103549 (owner: 10Cicalese) [14:19:49] liangent, i was thinking about starting on the task [14:21:04] mayankmadan_: nice [14:21:15] liangent, ill probably need a little help [14:21:57] mayankmadan_: ok [14:22:12] liangent, ill ping you in about 5 mins [14:22:13] and actually you don't have to wait for me. everyone here can offer help [14:23:02] (03PS1) 10M4tx: Add "Test images" category to "upload-wizard_tests.py" script [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103552 [14:25:03] (03PS2) 10Tpt: (bug 58870) Add the level tag even if an other autosummary is created [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/103349 [14:26:12] (03CR) 10Tpt: "addition of spaces as suggested by Phe" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/103349 (owner: 10Tpt) [14:26:30] (03CR) 10Tpt: [C: 032] "Reviewed by Phe and Aarti" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/103349 (owner: 10Tpt) [14:26:39] (03Merged) 10jenkins-bot: (bug 58870) Add the level tag even if an other autosummary is created [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/103349 (owner: 10Tpt) [14:30:42] (03CR) 10Bartosz Dziewoński: "The existing code will continue to work if it used numbers, and will continue to work in most cases if it used strings (the "sane" compari" [core] - 10https://gerrit.wikimedia.org/r/95962 (owner: 10Bartosz Dziewoński) [14:31:43] (03CR) 10Parent5446: "^that exactly. Sounds good to me." [core] - 10https://gerrit.wikimedia.org/r/103347 (owner: 10Legoktm) [14:31:44] (03PS2) 10Bartosz Dziewoński: jquery.client: Component-wise version comparison in #test with strings [core] - 10https://gerrit.wikimedia.org/r/95962 [14:32:14] (03PS3) 10Bartosz Dziewoński: jquery.client: Component-wise version comparison in #test with strings [core] - 10https://gerrit.wikimedia.org/r/95962 [14:33:43] liangent, where should i begin [14:34:32] specifically for this task, or generally for mediawiki and its extensions? [14:34:54] ie. are you already working on mediawiki, eg. did you complete another task just now? [14:35:08] mayankmadan_: ^ [14:35:39] liangent, i have completed some mediawiki task [14:35:48] i have downloaded geocrumb extension [14:36:14] (03PS4) 10Bartosz Dziewoński: jquery.client: Component-wise version comparison in #test with strings [core] - 10https://gerrit.wikimedia.org/r/95962 [14:36:32] (03CR) 10Bartosz Dziewoński: "Also added release notes." [core] - 10https://gerrit.wikimedia.org/r/95962 (owner: 10Bartosz Dziewoński) [14:36:37] (03PS4) 10Bartosz Dziewoński: mediawiki.searchSuggest: Blacklist Konqueror < 4.11 [core] - 10https://gerrit.wikimedia.org/r/95871 [14:37:40] (03CR) 10Nemo bis: [C: 031] "Looks ok, untested." [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/103230 (owner: 10MegaAlex) [14:39:35] mayankmadan_: ok I guess you should be able to find where those breadcrumb links are constructed, in the extension [14:39:56] liangent, i cant use geocrumb [14:40:02] huh? [14:40:11] when i require geocrumb.php in localsettings.php [14:40:24] the server gives an error [14:40:43] mayankmadan_: error for what? [14:40:56] liangent, Unexpected non-MediaWiki exception encountered, of type "Exception" [14:40:56] Notice: Uncommitted DB writes (transaction from DatabaseBase::query (MessageBlobStore::clear)). in /opt/lampp/htdocs/mediawiki/core/includes/db/Database.php on line 4104 [14:41:23] this happens only when i require geocrumb.php in localsettings.php [14:41:28] liangent, ^ [14:41:58] mayankmadan_: any backtrace? [14:42:32] liangent, im only getting Unexpected non-MediaWiki exception encountered, of type "Exception" now [14:42:44] the second line of error has dissappeared [14:43:56] liangent, how do i check for backtrace? [14:44:21] mayankmadan_: disappeared? did you turn on everything for debugging? [14:44:50] liangent, what do i need to turn on? [14:44:55] (03CR) 10UltrasonicNXT: "Yeah, MaxSem in IRC told me of this. I have now passed it down with other API calls in that latest patch though." [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/102679 (owner: 10Raimond Spekking) [14:44:55] error_reporting( E_ALL | E_STRICT ); ini_set( 'display_errors', 1 ); $wgShowSQLErrors = true; $wgShowExceptionDetails = true; $wgShowDBErrorBacktrace = true; [14:45:45] (03CR) 10Bartosz Dziewoński: [C: 031] "Can I merge this now or will it cause annoyance to people working on mediawiki.ui? Juliusz?" [core] - 10https://gerrit.wikimedia.org/r/103498 (owner: 10Mattflaschen) [14:45:51] mayankmadan_: https://www.mediawiki.org/wiki/How_to_debug [14:48:37] liangent, https://dpaste.de/feOw [14:48:42] backtrace [14:50:48] mayankmadan_: ah this error. read the exception details and the description page of that extension, then you should be able to figure it out yourself [14:51:09] liangent, i have to to install CustomData extension [14:51:23] mayankmadan_: right [14:52:12] Sorry for Interrupting anyway it would be great if anyone could help me. I was not able to push my change set to gerrit, while running git review -R.It says coulnt connect to gerrit [14:52:35] liangent, its working now [14:53:07] liangent, what are breadcrumbs? [14:53:37] mayankmadan_: jargon https://en.wiktionary.org/wiki/breadcrumbs [14:54:03] and https://en.wikipedia.org/wiki/Breadcrumb_%28navigation%29 [14:56:57] liangent, so where do i begin [14:57:09] udayan_: does `nc gerrit.wikimedia.org 29418` or `telnet gerrit.wikimedia.org 29418` work for you? [14:57:26] it should output something beginning with "SSH-2.0-GerritCodeReview_2.7-rc2-507-g1e7090b (SSHD-CORE-0.6.0)" [14:59:12] mayankmadan_: if you really think it's difficult ... what you need to edit is GeoCrumbs.class.php [14:59:27] yurik online? [15:00:13] mayankmadan_: but it might be necessary to understand how the parser works too [15:00:43] so grep for "convertTitle" in includes/parser/Parser.php and look at code lines near that [15:00:50] includes/parser/Parser.php in core [15:05:25] liangent, so, $titleText = $this->getConverterLanguage()->convertTitle( $title ); [15:05:35] is converting the title into the given language [15:06:01] liangent, and i just wanted to ask, where do the bread crumbs appear on the page? [15:06:05] i cant see any [15:09:31] liangent, ^ [15:09:44] mayankmadan_: create [[A]] with some contents. then create [[B]] with "{{#isin:A}}" [15:10:19] liangent, [[A]] and [[B]] are pages, right? [15:11:04] mayankmadan_: right [15:12:23] liangent, that worked :) [15:14:20] liangent, so the bug is that the text in the breadcrumb always appear in english [15:14:21] right? [15:16:04] mayankmadan__: not really. there's no such issue in English. set $wgLanguageCode = 'sr' in your LocalSettings.php, if you think Chinese is too difficult for you [15:16:42] liangent, which language is sr? :) [15:17:26] okay its serbian [15:18:21] liangent, i dont see any prob? [15:19:40] mayankmadan: now create [[srpski]] on your wiki, then [[srpski1]] with "srpski{{#isin:srpski}}" [15:20:45] then choose "Ћирилица" from the dropdown near "Page" / "Discussion" [15:21:32] now every "srpski" is replaced with "српски", but not the ones in those breadcrumbs [15:22:10] (the action of transforming srpski to српски is known as transliteration) [15:22:40] okay but the one in breadcrumb isnt changed [15:23:52] (03CR) 10Anomie: [C: 032] "Index is merged and deployed, queries have been reviewed by the appropriate person, and code looks good and seems to work." [core] - 10https://gerrit.wikimedia.org/r/85436 (owner: 10Jackmcbarn) [15:24:03] mayankmadan: yeah the expected behavior is to change them too [15:24:55] liangent: Are you able to figure it out? [15:26:34] udayan_: well I doubt it's your network connection's fault [15:27:02] so I'd like to check it first [15:27:08] (or ask you to check it [15:27:17] (03Merged) 10jenkins-bot: Allow searching for IPs' logs [core] - 10https://gerrit.wikimedia.org/r/85436 (owner: 10Jackmcbarn) [15:27:43] liangent: I tried everything.Please help me out. [15:28:39] udayan_: well does it work for you to connect to gerrit.wikimedia.org at port 29418 ? [15:29:28] (03CR) 10btongminh: "I could think of moving the construction of the classes out of DatabaseBase::factory and into a new DatbaseBase::newFromType(), which does" [core] - 10https://gerrit.wikimedia.org/r/103379 (owner: 10btongminh) [15:29:55] liangent: how to connect? [15:31:00] (03CR) 10Yaron Koren: "5 * 100 seems reasonable to me too..." [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/103395 (owner: 1001tonythomas) [15:33:55] udayan_: I would use netcat / putty / telnet or whatever creates an (almost) raw tcp connection [15:34:36] but it says permission denied(Public Key) [15:35:54] (03PS3) 10btongminh: Basic support for WebP [core] - 10https://gerrit.wikimedia.org/r/95872 [15:36:23] liangent, after making the changes, do i need to make another page to check if it has worked or will a simple refresh work? [15:37:44] udayan_: oh then what about `ssh gerrit.wikimedia.org -p 29418` ? [15:38:37] mayankmadan: I'm not quite sure but purging or null editing the page you're viewing should be enough I guess [15:38:55] liangent, what is null editing? ;) [15:40:34] mayankmadan: https://en.wikipedia.org/wiki/Wikipedia:Purge [15:45:08] (03PS4) 10btongminh: Basic support for WebP [core] - 10https://gerrit.wikimedia.org/r/95872 [16:06:15] git pull origin master doesn't work.It says permission denied(public key) [16:06:34] (03PS4) 10Dan-nl: Couple of type hints [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102455 (owner: 10Reedy) [16:06:37] On what repo? [16:07:00] Problem running 'git remote update gerrit' [16:09:39] Which repo? [16:10:49] (03CR) 10Theopolisme: Allow category prefix when entering categories (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103345 (owner: 10Theopolisme) [16:13:08] Math.git [16:13:33] Have you uploaded a key to gerrit? [16:14:52] liangent, i instantiated parser using $parser = new Parser(); [16:15:04] then used $link = $parserBlah->getConverterLanguage()->convertTitle( $link_raw ); [16:15:16] * $link = $parser->getConverterLanguage()->convertTitle( $link_raw ); [16:16:23] (03PS1) 10Bartosz Dziewoński: Remove grey background from login/createaccount form on Monobook [core] - 10https://gerrit.wikimedia.org/r/103558 [16:16:29] mayankmadan: I don't think a new parser is needed, as there're already some parseroutput objects in hand [16:16:41] but sorry I have to leave soon [16:16:57] anyone here? ^ is trivial [16:17:09] hi MatmaRex [16:17:14] MatmaRex, what is trivial [16:17:18] mayankmadan: see GeoCrumbs::getParserCache() [16:17:56] the patch is just submitted is trivial to review :) [16:18:00] i just submitted* [16:19:05] liangent, but there still isnt any Parser object [16:21:47] MatmaRex, ^, any ideas? [16:23:04] mayankmadan: i have no idea what are you two talking about :) [16:23:12] i've never used nor looked at GeoCrumbs [16:23:35] Reedy did you want to review this https://gerrit.wikimedia.org/r/102455 ? [16:25:03] dan-nl: For what/why? [16:25:03] (03PS59) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [16:25:23] Reedy: i made a slight change that's all … i can merge it [16:25:35] thought you might want to look before i merge [16:26:11] Looks fine to me [16:28:14] thanks [16:28:38] (03PS1) 10Bartosz Dziewoński: Remove old styles for #userlogin and #userloginForm [core] - 10https://gerrit.wikimedia.org/r/103559 [16:29:17] (03CR) 10Dan-nl: [C: 032 V: 032] Couple of type hints [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102455 (owner: 10Reedy) [16:29:54] Reedy: also have this one for you per an earlier request you made https://gerrit.wikimedia.org/r/#/c/102739/ [16:31:07] (03CR) 10UltrasonicNXT: "Although when I test it out, the {{GENDER}} and {{PLURAL}} functions don't seem to be being rendered, and are just left as {{GENDER:Test|b" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/102679 (owner: 10Raimond Spekking) [16:43:53] MatmaRex, what does this error mean? Call to a member function getTargetLanguage() on a non-object [16:44:02] on a non-object? [16:44:17] that usually means that your variable is a null [16:44:36] instead of the object you expected [16:44:49] MatmaRex, why does that usually happen? :) [16:45:31] all sorts of reason, can't really tell without knowing the code [16:45:38] of reasons* [16:45:51] either you didn't define the variable, or something you assigned to it was a null too [16:46:30] MatmaRex, the variable was an instance of Parser Class [16:46:47] and getTargetLanguage() is a function in Parser class [16:47:12] (03PS1) 10Dan-nl: adding a more appropriate user-agent [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/103561 [16:48:34] MatmaRex, ^^ [16:49:16] i have no idea what could cause a null to appear there [16:49:20] how are you getting hte Parser? [16:49:37] MatmaRex, $parser = new Parser(); [16:50:29] MatmaRex $link = $parser->getConverterLanguage()->convertTitle( $link_raw ); [16:52:19] weird [16:52:28] i don't know, sorry [16:54:18] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Comments inline." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/103530 (owner: 10Jcf2000) [16:55:17] (03CR) 10Bartosz Dziewoński: "I am wondering if we should provide some explanation about why the checkbox is disabled, but it's probably not necessary." [core] - 10https://gerrit.wikimedia.org/r/103530 (owner: 10Jcf2000) [16:56:51] Reedy: are you okay with closing this bug now https://bugzilla.wikimedia.org/show_bug.cgi?id=58591 ? [17:05:43] (03CR) 10btongminh: "Updated RELEASE-NOTES in PS4." [core] - 10https://gerrit.wikimedia.org/r/95872 (owner: 10btongminh) [17:07:53] (03PS4) 10Nemo bis: Show "Suppress Redirect" checkbox on Special:MovePage when redirect is impossible [core] - 10https://gerrit.wikimedia.org/r/103530 (owner: 10Jcf2000) [17:08:17] (03CR) 10Nemo bis: [C: 04-1] "Per MatmaRex, just removed an out of place Title Case" [core] - 10https://gerrit.wikimedia.org/r/103530 (owner: 10Jcf2000) [17:10:46] (03PS5) 10Nemo bis: Show "Suppress redirect" checkbox on Special:MovePage when redirect is impossible [core] - 10https://gerrit.wikimedia.org/r/103530 (owner: 10Jcf2000) [17:11:07] (03CR) 10Nemo bis: [C: 04-1] "And again, sorry... I couldn't make any sense out of the previous commit message." [core] - 10https://gerrit.wikimedia.org/r/103530 (owner: 10Jcf2000) [17:31:15] hi [17:32:24] I want to request you all to all upload a tutorial to mediawiki " How to use mobilefrontened on m subdomain on apache server" [17:32:58] i am having a lot of problem [17:33:14] can i get intouch with the expert [17:41:26] Urgent: i wouldn't expect anybody competent to be here on christmas eve [17:42:34] MatmaRex: That's a little offensive against the people in here (you included :P) :D [17:44:30] well, i'm out of here in ~30 minutes :) [17:46:27] Urgent: #wikimedia-mobile? [17:47:58] MatmaRex: :) Happy holidays! [17:50:11] (03PS4) 10Aarcos: Add smoke test to LicenseInput class and needed testing hooks. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103518 [17:54:09] hoo: you too :) [17:56:41] (03PS1) 10Yuvipanda: debug: Add exception and resourceloader, remove dupe wgDebugLogFile [vagrant] - 10https://gerrit.wikimedia.org/r/103567 [17:56:46] ori-l: Krinkle|detached ^ [17:56:54] I will try [17:57:05] to get help from them [17:57:46] (03CR) 10Ori.livneh: [C: 032] debug: Add exception and resourceloader, remove dupe wgDebugLogFile [vagrant] - 10https://gerrit.wikimedia.org/r/103567 (owner: 10Yuvipanda) [17:57:49] (03Merged) 10jenkins-bot: debug: Add exception and resourceloader, remove dupe wgDebugLogFile [vagrant] - 10https://gerrit.wikimedia.org/r/103567 (owner: 10Yuvipanda) [17:57:50] YuviPanda: thanks! [17:57:53] & hi! [17:57:53] ori-l: yw :) [17:58:04] ori-l: :D hi! [17:58:07] ori-l: not on vacation? [18:00:40] ori-l: I'm theoretically on vacation from tomorrow for 6 working days. should hopefully help :) [18:03:37] YuviPanda: vacations are good! [18:03:58] ori-l: heh, yeah. Now need to find something to actually *do* in that time, although I guess not doing anything is also acceptable [18:12:24] (03CR) 10Swalling: [C: 031] "LGTM" [core] - 10https://gerrit.wikimedia.org/r/103498 (owner: 10Mattflaschen) [18:38:40] (03CR) 10Aarcos: [C: 031] Add "Test images" category to "upload-wizard_tests.py" script [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103552 (owner: 10M4tx) [18:39:56] (03PS1) 10EBernhardson: Special characters are being mis-encoded in links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103569 [18:43:15] (03CR) 10Jhall: [C: 032] "Looks great!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103552 (owner: 10M4tx) [18:43:20] (03Merged) 10jenkins-bot: Add "Test images" category to "upload-wizard_tests.py" script [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103552 (owner: 10M4tx) [18:44:09] (03PS2) 10JGonera: [WIP] Update mediawiki.ui button styles [core] - 10https://gerrit.wikimedia.org/r/103494 [18:55:45] (03PS3) 10JGonera: [WIP] Update mediawiki.ui button styles [core] - 10https://gerrit.wikimedia.org/r/103494 [18:59:08] (03PS2) 10Jack Phoenix: Default to HTML5 player instead of Flash Player. [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/101672 [18:59:10] (03PS2) 10Jdlrobson: Allow mediawiki ui resource loader module to target mobile [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/102977 [19:02:11] physikerwelt: how hard would it be to make a patch removing MW_MATH_MATHJAX and related code? [19:02:40] (03PS3) 10Jack Phoenix: Default to HTML5 player instead of Flash Player. [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/101672 [19:08:17] (03CR) 10Aaron Schulz: [C: 032] Store title as a job parameter [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/101814 (owner: 10Legoktm) [19:08:29] (03Merged) 10jenkins-bot: Store title as a job parameter [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/101814 (owner: 10Legoktm) [19:09:32] (03CR) 10Skizzerz: [C: 031] "Finally looks good, thanks for fixing unrelated issues :)" [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/101672 (owner: 10Jack Phoenix) [19:26:55] (03CR) 10Nikerabbit: "recheck" [core] - 10https://gerrit.wikimedia.org/r/103546 (owner: 10Bartosz Dziewoński) [19:27:45] (03CR) 10Aaron Schulz: "This shouldn't be needed anymore now." [core] - 10https://gerrit.wikimedia.org/r/91858 (owner: 10Reedy) [19:27:49] (03PS1) 10Kaldari: Add logging support for mobile boolean flag in EchoInteraction [extensions/Echo] - 10https://gerrit.wikimedia.org/r/103573 [19:31:05] (03CR) 10Nikerabbit: ChangesListSpecialPage: Implement buildMainQueryConds() (032 comments) [core] - 10https://gerrit.wikimedia.org/r/103546 (owner: 10Bartosz Dziewoński) [19:33:01] (03CR) 10Jdlrobson: [C: 032] "Do it in a follow up :)" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/103491 (owner: 10Mattflaschen) [19:33:41] (03Merged) 10jenkins-bot: Remove unused button CSS (inherited from GuidersJS) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/103491 (owner: 10Mattflaschen) [19:41:58] (03CR) 10Bartosz Dziewoński: ChangesListSpecialPage: Implement buildMainQueryConds() (032 comments) [core] - 10https://gerrit.wikimedia.org/r/103546 (owner: 10Bartosz Dziewoński) [19:43:23] (03CR) 10Jdlrobson: [C: 032] Apply mediawiki.ui.button colors to all skins [core] - 10https://gerrit.wikimedia.org/r/103498 (owner: 10Mattflaschen) [19:45:25] (03CR) 10Jdlrobson: [C: 031] Add logging support for mobile boolean flag in EchoInteraction [extensions/Echo] - 10https://gerrit.wikimedia.org/r/103573 (owner: 10Kaldari) [19:45:52] (03PS2) 10Jdlrobson: Add logging support for mobile boolean flag in EchoInteraction [extensions/Echo] - 10https://gerrit.wikimedia.org/r/103573 (owner: 10Kaldari) [19:46:55] (03Merged) 10jenkins-bot: Apply mediawiki.ui.button colors to all skins [core] - 10https://gerrit.wikimedia.org/r/103498 (owner: 10Mattflaschen) [19:47:09] (03CR) 10Jdlrobson: [C: 032] Add logging support for mobile boolean flag in EchoInteraction [extensions/Echo] - 10https://gerrit.wikimedia.org/r/103573 (owner: 10Kaldari) [19:47:57] (03Merged) 10jenkins-bot: Add logging support for mobile boolean flag in EchoInteraction [extensions/Echo] - 10https://gerrit.wikimedia.org/r/103573 (owner: 10Kaldari) [19:54:32] (03CR) 10Aarcos: [C: 031] "One comment needs rewording but otherwise this looks good to me. I am giving you a +1, you can merge once the comment is fixed." (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103388 (owner: 10Gergő Tisza) [19:54:53] (03PS1) 10EBernhardson: Avoid unexpected results by using unitless line-height [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103576 [19:55:36] (03CR) 10EBernhardson: "example: http://ee-flow.wmflabs.org/w/index.php?title=User_talk:Ebernhardson&workflow=050c87c280dff00fc8b1fa163e68c4ac#flow-post-050c98a7e" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103576 (owner: 10EBernhardson) [19:55:57] jdlrobson: thanks! [19:56:08] MatmaRex: np [19:56:18] (03PS2) 10Bartosz Dziewoński: Remove grey background from login/createaccount form on Monobook [core] - 10https://gerrit.wikimedia.org/r/103558 [19:56:52] jdlrobson: wanna merge https://gerrit.wikimedia.org/r/#/c/103558/ too, so we can close https://bugzilla.wikimedia.org/show_bug.cgi?id=47698 ? [19:57:20] (and https://gerrit.wikimedia.org/r/#/c/103559/ too for good measure, both are trivial patches :) ) [20:06:13] (03PS1) 10EBernhardson: Prevent overflow of post content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103579 [20:08:15] I'll take a look after lunch MatmaRex [20:10:08] thanks [20:19:06] (03CR) 10Gergő Tisza: [C: 031] adding a more appropriate user-agent [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/103561 (owner: 10Dan-nl) [20:28:56] (03PS3) 10Gergő Tisza: Handle multiple Flickr uploads with identical title [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103388 [20:35:02] (03CR) 10Gergő Tisza: "Clarified jsdoc for reserveFileName()." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103388 (owner: 10Gergő Tisza) [20:37:23] [09:44:30 AM] well, i'm out of here in ~30 minutes :) <-- still online xD [20:39:50] heh [20:39:53] more like back online, but true [20:42:13] (03CR) 10Aarcos: [C: 031] "A wording suggestion but otherwise LGTM." (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103388 (owner: 10Gergő Tisza) [20:48:52] (03PS1) 10Legoktm: Deprecate SpecialPage::getTitle [core] - 10https://gerrit.wikimedia.org/r/103587 [20:50:06] (03CR) 10Legoktm: "Done in https://gerrit.wikimedia.org/r/#/c/103587/" [core] - 10https://gerrit.wikimedia.org/r/103347 (owner: 10Legoktm) [20:52:12] (03CR) 10Legoktm: "I can/will prepare patches for all the extensions in gerrit that will need to be updated, there are about 115 of them." [core] - 10https://gerrit.wikimedia.org/r/103587 (owner: 10Legoktm) [20:52:15] Hi guys i was making an tag extension .....in which i needed to take arguments .....can some one guide me to how to take input from such arguments .....i was successful in rendering basic html,css,javascript events needed for the extension???? [20:54:52] (03CR) 10Gergő Tisza: [C: 031] Make DjVu metadata be stored as serialized PHP array. [core] - 10https://gerrit.wikimedia.org/r/99544 (owner: 10Brian Wolff) [21:00:08] (03PS1) 10Anomie: API: Make more continuations unique [core] - 10https://gerrit.wikimedia.org/r/103589 [21:12:32] (03PS1) 10EBernhardson: Prevent blank topic titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103590 [21:25:11] (03PS1) 10Bsitu: Remove dupicate scrollTo event for topic reply link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103593 [21:45:54] (03PS1) 10Mayankmadan: Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 [21:45:58] (03CR) 10jenkins-bot: [V: 04-1] Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [21:51:00] legoktm: O: [21:58:29] (03PS2) 10Mayankmadan: Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 [21:58:32] (03CR) 10jenkins-bot: [V: 04-1] Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [21:59:54] (03PS2) 10Theopolisme: Allow category prefix when entering categories [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103345 [22:00:59] (03CR) 10Theopolisme: "mw.Title is very cool; thanks for that, Brian! Learn something new every day :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103345 (owner: 10Theopolisme) [22:04:40] (03PS3) 10Mayankmadan: Functionality to create a new image in upload-wizard_tests.py [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 [22:26:08] Nemo_bis: hmmm? [22:26:49] need svn back for those mass changes [22:30:01] (03CR) 10Bsitu: [C: 032] Split redlinking out of Templating class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103259 (owner: 10EBernhardson) [22:30:08] (03Merged) 10jenkins-bot: Split redlinking out of Templating class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103259 (owner: 10EBernhardson) [22:40:13] (03CR) 10Jhall: [C: 04-1] "Looks good overall, but a couple of things could be improved:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [22:41:40] (03CR) 10Aarcos: [C: 04-1] Functionality to create a new image in upload-wizard_tests.py (035 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103596 (owner: 10Mayankmadan) [22:42:12] Nemo_bis: yeah :/ [23:17:25] (03PS1) 10Bsitu: Log the exception message as well [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103608 [23:39:52] (03PS1) 10Bsitu: Page results from exception should not have 200 status code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103613 [23:41:40] (03PS2) 10Bsitu: Page resulting from exception should not have 200 status code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103613 [23:46:30] (03CR) 10Mattflaschen: [C: 031] "I confirmed the blacklist works in Konqueror 4.8.4, but it still shows the suggestions in Iceweasel/Firefox 23.0 and Chromium 31.0.1650.63" [core] - 10https://gerrit.wikimedia.org/r/95871 (owner: 10Bartosz Dziewoński) [23:49:45] (03CR) 10Spage: "The change works, now prints:" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103608 (owner: 10Bsitu) [23:55:43] (03CR) 10Legoktm: [C: 04-1] "Needs rebase." [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88257 (owner: 10Legoktm) [23:59:27] (03CR) 10Gergő Tisza: [C: 032] Add smoke test to LicenseInput class and needed testing hooks. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103518 (owner: 10Aarcos) [23:59:31] (03Merged) 10jenkins-bot: Add smoke test to LicenseInput class and needed testing hooks. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/103518 (owner: 10Aarcos)