[00:05:36] (03CR) 10Brian Wolff: "This actually changes the message for non-admins too. For example, if someone went to https://test.wikipedia.org/w/index.php?title=User:Ba" [core] - 10https://gerrit.wikimedia.org/r/40283 (owner: 10Alex Monk) [00:05:42] (03CR) 10Helder.wiki: Always load 'mediawiki.special.changeslist' on SpecialRecentChanges and subclasses (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97451 (owner: 10Bartosz Dziewoński) [00:14:35] (03PS1) 10Werdna: Add error handling to contributions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102854 [00:16:47] (03PS1) 10Bsitu: Allow icons to set different ltr/rtl versions [extensions/Echo] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/102855 [00:21:36] (03PS3) 10Aarcos: Smoke tests for Upload Wizard using the API. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/102603 [00:24:08] (03CR) 10Spage: [C: 032] "Backport same as original." [extensions/Echo] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/102855 (owner: 10Bsitu) [00:24:15] (03Merged) 10jenkins-bot: Allow icons to set different ltr/rtl versions [extensions/Echo] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/102855 (owner: 10Bsitu) [00:27:09] (03PS2) 10Spage: Add rtl and ltr icons for flow notification [extensions/Flow] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/102851 (owner: 10Bsitu) [00:27:35] (03CR) 10Spage: [C: 032] "The code we want" [extensions/Flow] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/102851 (owner: 10Bsitu) [00:27:40] (03Merged) 10jenkins-bot: Add rtl and ltr icons for flow notification [extensions/Flow] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/102851 (owner: 10Bsitu) [00:28:59] (03PS4) 10Aarcos: Smoke tests for Upload Wizard using the API. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/102603 [00:31:08] (03CR) 10Aarcos: "Thanx for your comments, I think I addressed everything. Please take another look and let me know if any issues left. Thanx !" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/102603 (owner: 10Aarcos) [00:33:15] ori_, got a second? [00:34:57] (03PS1) 10Ori.livneh: Rename schema and update schema revision [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/102857 [00:35:06] MaxSem: what's up? [00:35:45] ori_, I think I saw some graphs of mobile site response times from you [00:36:05] MaxSem: http://ganglia.wikimedia.org/latest/?r=month&cs=&ce=&tab=v&vn=Navigation+Timing&hide-hf=false [00:36:08] MaxSem: red lines are mobile [00:36:18] thanks:) [00:37:01] the value is logged every five minutes; the figures plotted represent the median value of that five-minute period [00:37:26] and before you say it: yes, it's not adequate to just plot the median, but... there are only 24 hours in a day :) [00:37:36] (03CR) 10EBernhardson: (bug 58645) Merge RecentChanges & Contributions' formatters extend from 1 same base class (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102674 (owner: 10Matthias Mullie) [00:40:18] (03CR) 10Nuria: [C: 032] Rename schema and update schema revision [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/102857 (owner: 10Ori.livneh) [00:40:19] (03Merged) 10jenkins-bot: Rename schema and update schema revision [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/102857 (owner: 10Ori.livneh) [00:41:39] (03PS1) 10Ori.livneh: Update WikimediaEvents to master [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102858 [00:42:25] (03PS1) 10Ori.livneh: Update WikimediaEvents to master [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/102860 [00:43:27] (03CR) 10Ori.livneh: [C: 032] Update WikimediaEvents to master [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102858 (owner: 10Ori.livneh) [00:43:42] (03CR) 10Ori.livneh: [C: 032] Update WikimediaEvents to master [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/102860 (owner: 10Ori.livneh) [00:46:15] (03CR) 10MarkTraceur: "So." [extensions/EtherEditor] - 10https://gerrit.wikimedia.org/r/43100 (owner: 10SuchetaG) [00:46:37] (03PS1) 10Bsitu: Update Echo and Flow [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/102861 [00:49:23] (03CR) 10EBernhardson: Improve findMulti() for BasicDbStorage (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102599 (owner: 10Bsitu) [00:50:04] (03CR) 10EBernhardson: [C: 032] Add flow specific exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100524 (owner: 10Bsitu) [00:50:10] siebrand, is it OK to assume that we're running qunit tests in English, or should I be testing against an mw.msg return value? [00:51:24] (03PS2) 10Spage: Update Echo and Flow [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/102861 (owner: 10Bsitu) [00:51:32] (03CR) 10EBernhardson: Add error handling to contributions (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102854 (owner: 10Werdna) [00:52:06] (03PS5) 10EBernhardson: Convert UUID length 'magic' numbers to named constants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102584 [00:52:09] (03CR) 10Spage: "These are the bumps we're looking for." [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/102861 (owner: 10Bsitu) [00:52:32] (03Merged) 10jenkins-bot: Add flow specific exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100524 (owner: 10Bsitu) [00:53:39] (03PS16) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [00:53:41] (03CR) 10jenkins-bot: [V: 04-1] [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [00:55:06] (03PS6) 10EBernhardson: Convert UUID length 'magic' numbers to named constants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102584 [00:55:07] csteipp: is the gu_salt column always empty? [00:55:43] -- For migrated passwords, the salt is the local user_id. [00:56:02] legoktm: I'm pretty sure it's blank for most users now [00:56:09] (03CR) 10Spage: [C: 032] "Actual +2" [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/102861 (owner: 10Bsitu) [00:58:15] csteipp: ok, i'll set it as empty string for the create a new global account after rename patch [00:59:13] (03Merged) 10jenkins-bot: Update Echo and Flow. [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/102861 (owner: 10Bsitu) [00:59:35] (03PS17) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [00:59:37] (03PS4) 10EBernhardson: base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 [00:59:39] (03PS7) 10EBernhardson: Convert UUID length 'magic' numbers to named constants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102584 [00:59:41] (03CR) 10jenkins-bot: [V: 04-1] [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [00:59:43] (03CR) 10jenkins-bot: [V: 04-1] base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 (owner: 10EBernhardson) [00:59:44] (03CR) 10jenkins-bot: [V: 04-1] Convert UUID length 'magic' numbers to named constants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102584 (owner: 10EBernhardson) [00:59:46] (03CR) 10Aaron Schulz: [C: 032 V: 032] Fix RequestAccountPage::confirmEmailToken() [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/100193 (owner: 10PleaseStand) [01:03:26] (03PS18) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [01:03:27] (03PS5) 10EBernhardson: base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 [01:03:29] (03PS8) 10EBernhardson: Convert UUID length 'magic' numbers to named constants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102584 [01:03:35] (03CR) 10jenkins-bot: [V: 04-1] [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [01:03:41] (03CR) 10jenkins-bot: [V: 04-1] base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 (owner: 10EBernhardson) [01:07:32] (03PS19) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [01:08:44] (03PS6) 10EBernhardson: base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 [01:08:49] (03CR) 10jenkins-bot: [V: 04-1] base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 (owner: 10EBernhardson) [01:11:22] (03PS7) 10EBernhardson: base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 [01:20:34] (03PS2) 10Legoktm: Autocreate global account after rename [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/102635 [01:28:12] (03PS5) 10Aarcos: Smoke tests for Upload Wizard using the API. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/102603 [01:32:49] (03PS3) 10Legoktm: Autocreate global account after rename [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/102635 [01:48:05] (03PS4) 10Bsitu: Improve findMulti() for BasicDbStorage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102599 [01:51:23] (03CR) 10Yaron Koren: Added i18n functions and messages to PageSchemas (031 comment) [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/101499 (owner: 10Apsdehal) [02:37:39] (03PS1) 10Mattflaschen: Remove unused message [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/102872 [02:56:09] (03PS1) 10Legoktm: Log title that spambot tried to edit [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/102873 [03:29:53] (03CR) 10Skizzerz: Log title that spambot tried to edit (031 comment) [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/102873 (owner: 10Legoktm) [03:31:23] (03PS2) 10Legoktm: Log title that spambot tried to edit [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/102873 [03:31:27] (03CR) 10Legoktm: Log title that spambot tried to edit (031 comment) [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/102873 (owner: 10Legoktm) [03:32:22] (03CR) 10Skizzerz: [C: 032 V: 032] "Looks good" [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/102873 (owner: 10Legoktm) [03:36:26] (03PS1) 10Legoktm: Add jobs for GlobalPreferences and StopForumSpam extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102876 [03:39:12] (03PS1) 10Legoktm: Triggers for GlobalPreferences and StopForumSpam extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102877 [04:15:15] (03CR) 10Legoktm: [C: 031] "Looks fine to me, untested." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/100934 (owner: 10Mattflaschen) [04:43:29] Good morning/evening/afternoon. [05:07:05] (03PS1) 10Aaron Schulz: [WIP] Added a script to update cdb files from JSON change descriptions [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/102878 [05:21:54] (03CR) 10Apsdehal: Added i18n functions and messages to PageSchemas (031 comment) [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/101499 (owner: 10Apsdehal) [05:48:48] (03PS1) 10TTO: Make Special:Redirect able to redirect by page ID [core] - 10https://gerrit.wikimedia.org/r/102879 [05:57:19] (03CR) 10Apsdehal: "Whats the final status of this patch?" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/101494 (owner: 10Apsdehal) [06:09:47] (03CR) 10Faidon Liambotis: "Remember to revert https://gerrit.wikimedia.org/r/#/c/102744/ after this is merged." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102725 (owner: 10BryanDavis) [06:21:00] (03CR) 10Ori.livneh: [WIP] Added a script to update cdb files from JSON change descriptions (0310 comments) [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/102878 (owner: 10Aaron Schulz) [06:24:29] (03CR) 10Santhosh: [WIP] Add support for JSON i18n files (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102098 (owner: 10Catrope) [13:08:22] It would be a boilerplate for how to do b/c in an extension [13:08:24] Probably in VisualEditor [13:09:28] RoanKattouw: hmm right, sorry I'm slow today [13:09:31] I thought I could just write an .i18n.php file that fakes the $messages array by reading it in from the .json files, but that doesn't work because 1) you don't know the language so you have to read all of them and 2) you don't end up registering CacheDependencies on the .json files [13:09:56] I called that a "shim" [13:10:24] But instead of a shim, I'll just need to use a hook [13:11:55] (03CR) 10Nikerabbit: [C: 031] Add support for JSON i18n files [core] - 10https://gerrit.wikimedia.org/r/102098 (owner: 10Catrope) [13:12:21] I'll give +2 after lunch ;) [13:22:35] (03PS1) 10Hashar: mediawiki/services/parsoid/deploy playground [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102930 [13:22:44] (03CR) 10Hashar: [C: 032] mediawiki/services/parsoid/deploy playground [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102930 (owner: 10Hashar) [13:22:50] (03Merged) 10jenkins-bot: mediawiki/services/parsoid/deploy playground [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102930 (owner: 10Hashar) [13:23:06] (03PS7) 10Catrope: Add support for JSON i18n files [core] - 10https://gerrit.wikimedia.org/r/102098 [13:24:37] Nikerabbit: Made another small change: removed all keys starting with @ , rather than just @metadata. That way the entire @ space is reserved for future expansion (non-message variables like magic words etc) [13:28:17] RoanKattouw: okay [13:29:14] (03PS1) 10Netbrain: Initial import [extensions/Convert2Wiki] - 10https://gerrit.wikimedia.org/r/102933 [13:29:37] (03CR) 10Netbrain: [C: 032 V: 032] Initial import [extensions/Convert2Wiki] - 10https://gerrit.wikimedia.org/r/102933 (owner: 10Netbrain) [13:30:08] RoanKattouw: there is slight chance that key might be "", should we handle dhat? [13:31:53] Hmm [13:32:05] I think if the key is actually an empty string then we have a legitimate case of GIGO [13:32:25] * siebrand does a little dance with RoanKattouw and Nikerabbit. [13:32:31] But it's quite likely we'll extend the spec to allow things like "@magicwords": { "notoc": "__NOTOC__" } [13:33:10] RoanKattouw: I would still not throw PHP notice on it... [13:33:19] Oh! [13:33:21] That's what you meant [13:33:22] Right [13:33:28] $key[0] will fail if strlen($key) < 1 [13:33:41] simple $key !== '' && ... will do it [13:34:04] Yeah [13:34:32] (03PS8) 10Catrope: Add support for JSON i18n files [core] - 10https://gerrit.wikimedia.org/r/102098 [13:37:14] RoanKattouw: yep I'm gonna merge it and siebrand will start testing (I think he started already) [13:37:23] Sweet [13:37:33] I'm almost done with the b/c thing in VisualEditor [13:37:40] Haven't started. [13:37:47] Also have to go and do some shopping soon. [13:37:54] For now you can test with: [13:37:56] !g Ib8490d3e327ddf5852827c24ee2aa2916c8af072 [13:37:56] https://gerrit.wikimedia.org/r/#q,Ib8490d3e327ddf5852827c24ee2aa2916c8af072,n,z [13:38:00] I will update that soon to add b/c [13:38:02] But will probably convert some extensions used at twn today. [13:38:06] Sweet [13:38:32] RoanKattouw: We don't use VE, so I can't use that. [13:38:39] Right, OK [13:38:42] (03CR) 10Nikerabbit: [C: 032] "Yay!" [core] - 10https://gerrit.wikimedia.org/r/102098 (owner: 10Catrope) [13:38:48] RoanKattouw: But will probably convert TwnMainPage (without BC) [13:38:52] Nikerabbit: Yay! [13:38:55] OK [13:38:57] Yay! [13:39:12] The conversion script is in a commit on top of 102098 that hasn't been merged yet [13:39:23] * RoanKattouw looks expectantly in Nikerabbit's general direction ;) [13:40:29] RoanKattouw: He'll merge that too. I proposed to cherry pick it on master and merge it before the first :) [13:40:33] (03PS7) 10Nikerabbit: Script to convert PHP i18n to JSON [core] - 10https://gerrit.wikimedia.org/r/102171 (owner: 10Catrope) [13:40:53] We also need some release notes :) [13:41:01] Yes, those [13:41:10] Would you mind doing those? [13:41:15] * siebrand hides. [13:41:35] Working on this bug:https://bugzilla.wikimedia.org/show_bug.cgi?id=30700. Anyone know where Acawiki Repos are? [13:41:44] (03Merged) 10jenkins-bot: Add support for JSON i18n files [core] - 10https://gerrit.wikimedia.org/r/102098 (owner: 10Catrope) [13:41:55] tinaj: have you searched git.wikimedia.org? [13:42:12] I think we need a doc page Manual:$wgExtensionMessagesDirs [13:42:45] tinaj: it may still be in svn, those are ancient [13:44:34] Nemo_bis: searched git.wikimedia.org and nothing [13:45:07] (03CR) 10Nikerabbit: [C: 032] "Tested with Translate.i18n.php, output looks as expected and no PHP notices." [core] - 10https://gerrit.wikimedia.org/r/102171 (owner: 10Catrope) [13:45:16] or maybe they never reached wikimedia servers, it's an abandoned project from wikimedia perspective [13:45:51] Nikerabbit: Thanks man :) [13:46:31] Nemo_bis: oh! [13:46:55] Nemo_bis: wonder why bugs are still reported for Acawiki [13:47:05] Small bug on 5971 of https://gerrit.wikimedia.org/r/#/c/102098/8/includes/DefaultSettings.php (; missing) [13:47:34] Oh right :) [13:48:16] (03Merged) 10jenkins-bot: Script to convert PHP i18n to JSON [core] - 10https://gerrit.wikimedia.org/r/102171 (owner: 10Catrope) [13:49:04] (03CR) 10Bartosz Dziewoński: Always load 'mediawiki.special.changeslist' on SpecialRecentChanges and subclasses (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97451 (owner: 10Bartosz Dziewoński) [13:49:37] tinaj: are they? anyway, we host their bugs but it's not related to us [13:50:37] RoanKattouw, Nikerabbit : Please do a quick review: https://www.mediawiki.org/wiki/Manual:$wgExtensionMessagesDirs and https://www.mediawiki.org/wiki/Manual:$wgExtensionMessagesFiles (updates have been copied from the changes in DefaultSettings.php) [13:50:49] siebrand: Will do in a second [13:52:31] (03PS1) 10Hashar: parsoidsvc jobs are now concurrents [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102939 [13:52:57] http://dev.translatewiki.net/wiki/Special:MainPage is now running form json only i18n files [13:53:21] (03CR) 10Hashar: [C: 032] parsoidsvc jobs are now concurrents [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102939 (owner: 10Hashar) [13:53:38] (03Merged) 10jenkins-bot: parsoidsvc jobs are now concurrents [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102939 (owner: 10Hashar) [13:56:01] cute [13:56:03] Nemo_bis: oh! didn't know that. Thanks! [13:59:02] (03PS5) 10Hashar: multigit: handles multiple git repository [integration/jenkins] - 10https://gerrit.wikimedia.org/r/102716 [13:59:15] (03PS8) 1001tonythomas: Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 [14:00:17] Code is now also live on twn production, but no extensions using JSON yet. [14:00:27] I'll be changing that once I get back from shopping [14:20:14] MW.org docs look good [14:20:35] We'll also want to write a page about how to migrate an extension, once someone code reviews my shim [14:20:50] ( https://gerrit.wikimedia.org/r/102100 ) but I need to get it to pass Jenkins [14:40:36] (03CR) 10Gergő Tisza: [C: 031] correcting gwtoolset permission check [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102814 (owner: 10Dan-nl) [14:41:09] (03CR) 10Matthias Mullie: Convert UUID length 'magic' numbers to named constants (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102584 (owner: 10EBernhardson) [14:41:30] hashar: Waited for 20 minutes, but jenkins does not work upon "recheck" on: [14:41:34] hashar: https://gerrit.wikimedia.org/r/#/c/102299/ [14:41:52] (03PS9) 10Matthias Mullie: Convert UUID length 'magic' numbers to named constants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102584 (owner: 10EBernhardson) [14:42:05] hashar: Is there some other way I can get Jenkins to recheck the change? [14:42:28] (03CR) 10Matthias Mullie: [C: 031] "LGTM now; just added some minor changes, so I'll let someone else review those before +2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102584 (owner: 10EBernhardson) [14:43:30] (03CR) 10Matthias Mullie: [C: 031] "LGTM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [14:43:55] (03PS6) 10Hashar: multigit: handles multiple git repository [integration/jenkins] - 10https://gerrit.wikimedia.org/r/102716 [14:44:15] (03CR) 10Hashar: [C: 032] "good enough for now, deploying" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/102716 (owner: 10Hashar) [14:44:33] (03Merged) 10jenkins-bot: multigit: handles multiple git repository [integration/jenkins] - 10https://gerrit.wikimedia.org/r/102716 (owner: 10Hashar) [14:47:13] (03CR) 10Hashar: "deployed" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/102716 (owner: 10Hashar) [14:48:02] qchris: ahh [14:48:09] qchris: try uploading a new patchset [14:48:35] qchris: got to verify the configuration though since +2 should have executed some tests [14:48:51] (03CR) 10Matthias Mullie: (bug 58645) Merge RecentChanges & Contributions' formatters extend from 1 same base class (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102674 (owner: 10Matthias Mullie) [14:48:55] (03PS2) 10Matthias Mullie: (bug 58645) Merge RecentChanges & Contributions' formatters extend from 1 same base class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102674 [14:49:33] hashar: Thanks. Ok. [14:49:36] This change depends on a change that failed to merge. [14:49:37] ho [14:50:07] Yes. But that is now merged ... :-) [14:50:35] got to look at Zuul [14:54:04] ah [14:54:37] created a new patch [14:54:53] (03CR) 10Bartosz Dziewoński: "This is a perfect example of why skinStyles sucks really bad. :/" [core] - 10https://gerrit.wikimedia.org/r/102891 (owner: 10Jdlrobson) [14:55:00] it failed because it depends on https://gerrit.wikimedia.org/r/#/c/102292/ which was failling [14:55:11] passing now [14:55:20] qchris: you can +2 https://gerrit.wikimedia.org/r/#/c/102299/ :-D it should merge now [14:56:05] Got torn into a meeting. [14:56:20] hashar: I'll try and report back if it did not work :-) [14:56:34] or i can do it :D [15:00:36] guillom, http://www.google-melange.com/gci/task/view/google/gci2013/5318731135713280 [15:00:37] Add template data to two popular Wikipedia templates [15:00:37] Status: Open [15:00:37] Mentor(s): Guillaume Paumier, Quim Gil [15:00:54] hello mayankmadan_ [15:00:58] guillom, hi [15:01:04] guillom, what is template data [15:01:58] mayankmadan_: https://www.mediawiki.org/wiki/Help:TemplateData [15:04:48] guillom, where do i begin [15:05:24] mayankmadan_: you can begin with the reading recommended in the task :) [15:05:42] I'll be right back [15:06:04] guillom, sorry i disconnected [15:13:04] mayankmadan__: mayankmadan_: you can begin with the reading recommended in the task :) [15:13:32] mayankmadan__: I've assigned the task to you [15:14:51] (03CR) 10Matthias Mullie: Convert moderation success dialogs to inline boxes (037 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100953 (owner: 10Werdna) [15:15:43] (03CR) 10Siebrand: [C: 031] "i18n reviewed. Trivial." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102814 (owner: 10Dan-nl) [15:22:47] (03PS1) 10Pigpen: Latest state of development [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/102946 [15:22:53] (03PS1) 10Pigpen: Latest state of development [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/102947 [15:22:58] (03PS1) 10Pigpen: Latest state of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/102948 [15:23:00] (03PS6) 10Apsdehal: Added i18n functions and messages to PageSchemas [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/101499 [15:23:26] (03CR) 10Pigpen: [V: 032] Latest state of development [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/102946 (owner: 10Pigpen) [15:23:47] (03CR) 10Pigpen: [C: 032] Latest state of development [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/102946 (owner: 10Pigpen) [15:24:10] (03CR) 10Pigpen: [C: 032 V: 032] Latest state of development [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/102947 (owner: 10Pigpen) [15:24:28] (03CR) 10Pigpen: [C: 032 V: 032] Latest state of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/102948 (owner: 10Pigpen) [15:26:08] guillom, any help? [15:26:30] guillom, i wanted to add template data for https://en.wikipedia.org/wiki/Template:Infobox_writer [15:26:35] but how do i start? [15:26:39] (03CR) 10Apsdehal: "Now check the solution if it suites, I think its clean enough." [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/101499 (owner: 10Apsdehal) [15:26:58] mayankmadan__: have you read the task's derscription? [15:27:33] guillom, in step 3, the task description says Add the template data following the instructions in that page. [15:27:49] (03CR) 10Apsdehal: "Whats the future of this patch?" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 (owner: 10Apsdehal) [15:27:49] guillom, following the instruction in which page? [15:27:55] mayankmadan__: https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/TemplateData_tutorial [15:27:58] (03PS1) 10Hashar: parsoidsvc bring more test to deploy repository [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102949 [15:28:09] (03CR) 10Hashar: [C: 032] parsoidsvc bring more test to deploy repository [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102949 (owner: 10Hashar) [15:28:15] (03Merged) 10jenkins-bot: parsoidsvc bring more test to deploy repository [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102949 (owner: 10Hashar) [15:30:42] (03PS1) 10Hashar: parsoidsvc: remove duplicates [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102950 [15:30:50] (03CR) 10Hashar: [C: 032] parsoidsvc: remove duplicates [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102950 (owner: 10Hashar) [15:30:55] (03Merged) 10jenkins-bot: parsoidsvc: remove duplicates [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102950 (owner: 10Hashar) [15:35:13] (03CR) 10Parent5446: [C: 032] Make Special:Redirect able to redirect by page ID [core] - 10https://gerrit.wikimedia.org/r/102879 (owner: 10TTO) [15:35:14] guillom, where do i write the template data? [15:36:08] mayankmadan__: if you're done, on the template's documentation subpage [15:36:56] guillom, ? [15:38:07] mayankmadan__: https://en.wikipedia.org/wiki/Template:Infobox_writer/doc [15:38:22] (03Merged) 10jenkins-bot: Make Special:Redirect able to redirect by page ID [core] - 10https://gerrit.wikimedia.org/r/102879 (owner: 10TTO) [15:41:19] guillom, ok i have read the template's documentation page [15:46:10] (03PS1) 10Hashar: parsoidsvc using multigit script [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102952 [15:46:39] (03CR) 10Hashar: [C: 032] "deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102952 (owner: 10Hashar) [15:46:57] (03Merged) 10jenkins-bot: parsoidsvc using multigit script [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102952 (owner: 10Hashar) [15:47:38] (03CR) 10Jhall: [C: 031] "Looks great!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/102603 (owner: 10Aarcos) [15:49:44] (03CR) 10Chad: [C: 032] Clean up en messages and usage [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102627 (owner: 10BryanDavis) [15:49:49] (03Merged) 10jenkins-bot: Clean up en messages and usage [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102627 (owner: 10BryanDavis) [15:51:45] (03PS1) 10Dan-nl: removing initial delay [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102955 [15:52:43] guillom, ? [15:54:52] RoanKattouw: Siebrand suggests renaming the new global to just $wgMessageDirs [15:54:59] (03PS1) 10Siebrand: Rename $wgExtensionMessagesDirs to $wgMessagesDirs [core] - 10https://gerrit.wikimedia.org/r/102957 [15:55:20] mayankmadan__: are you having trouble with something? I was hoping to finish my work day soon :) [15:55:30] guillom, it wont take long [15:55:34] ok [15:55:48] Nikerabbit: Fine with me, I don't care [15:55:52] guillom, do i write the templatedata in the template's doc page? [15:55:59] Makes some sense given that the format will now be the same for core and extensions [15:56:36] mayankmadan__: yes [15:56:36] guillom, by following edit source link [15:56:46] (03CR) 10jenkins-bot: [V: 04-1] Rename $wgExtensionMessagesDirs to $wgMessagesDirs [core] - 10https://gerrit.wikimedia.org/r/102957 (owner: 10Siebrand) [15:59:12] guillom, and do i write it by { "description": ... etc ? [15:59:26] mayankmadan__: precisely [15:59:33] great [16:02:17] (03PS2) 10Dan-nl: removing initial delay [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102955 [16:02:42] (03PS2) 10Siebrand: Rename $wgExtensionMessagesDirs to $wgMessagesDirs [core] - 10https://gerrit.wikimedia.org/r/102957 [16:02:59] (03CR) 10Dan-nl: "- added bug reference" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102955 (owner: 10Dan-nl) [16:04:34] (03CR) 10Hashar: [C: 032] removing initial delay [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102955 (owner: 10Dan-nl) [16:04:41] (03Merged) 10jenkins-bot: removing initial delay [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102955 (owner: 10Dan-nl) [16:07:19] (03CR) 10Nikerabbit: [C: 032] Rename $wgExtensionMessagesDirs to $wgMessagesDirs [core] - 10https://gerrit.wikimedia.org/r/102957 (owner: 10Siebrand) [16:07:25] (03CR) 10Andrew Bogott: [C: 032 V: 032] Move the request for shell access to a later callback. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/102574 (owner: 10Andrew Bogott) [16:07:44] (03PS6) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 [16:07:46] (03PS3) 10Hashar: make browsertest runner a macro [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100798 [16:07:58] (03CR) 10Hashar: [C: 032] make browsertest runner a macro [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100798 (owner: 10Hashar) [16:08:02] (03PS1) 10Manybubbles: Reimplement TitleKey's nearmatch finding [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102958 [16:08:53] (03CR) 10Jdlrobson: [C: 04-1] "Agreed. Forgot to say do not submit this it's more meant for discussion." [core] - 10https://gerrit.wikimedia.org/r/102891 (owner: 10Jdlrobson) [16:09:49] (03Merged) 10jenkins-bot: make browsertest runner a macro [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100798 (owner: 10Hashar) [16:10:02] (03PS1) 10Andrew Bogott: Grab the host from the instance before deleting the instance. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/102959 [16:10:38] (03Merged) 10jenkins-bot: Rename $wgExtensionMessagesDirs to $wgMessagesDirs [core] - 10https://gerrit.wikimedia.org/r/102957 (owner: 10Siebrand) [16:14:41] guillom, what type do i use for image? [16:14:52] guillom, it should be file, right? [16:17:42] (03CR) 10Andrew Bogott: [C: 032 V: 032] Grab the host from the instance before deleting the instance. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/102959 (owner: 10Andrew Bogott) [16:19:38] (03CR) 10Chad: Reimplement TitleKey's nearmatch finding (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102958 (owner: 10Manybubbles) [16:21:20] (03CR) 10Manybubbles: Reimplement TitleKey's nearmatch finding (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102958 (owner: 10Manybubbles) [16:22:42] <^d> manybubbles: Putting all the hooks in that file was kind of the point :) [16:22:51] <^d> I could've sworn they'd all made it in. [16:28:44] andre__, hi [16:28:51] andre__, what is pseudonym? [16:28:52] hi mayankmadan__ [16:29:30] mayankmadan__, https://en.wiktionary.org/wiki/pseudonym ? [16:29:41] andre__, https://en.wikipedia.org/wiki/Template:Infobox_writer [16:29:57] andre__, pseudonym in parameters [16:30:03] mayankmadan__, why do you ask me? [16:30:19] because i dont know what it is :) [16:30:55] mayankmadan__, well, you can ask anybody in this room :) [16:30:57] mayankmadan__: Some writers use a pseudonym (publish under a different name than their real name). An "artist name", so to say. [16:31:09] okay [16:31:27] mayankmadan__, see the first paragraph of https://en.wikipedia.org/wiki/Kurt_Tucholsky for example [16:31:27] "He also wrote under the pseudonyms Kaspar Hauser, Peter Panter, Theobald Tiger and Ignaz Wrobel." [16:31:55] oh [16:51:12] what does birthname means here https://en.wikipedia.org/wiki/Template:Infobox_writer [16:51:18] in the parameters [16:51:28] is it the place of birth? [16:51:44] <^d> birth name -> name you were born with [16:51:51] :) [16:52:13] ^d, then how is it different from name param [16:52:33] mayankmadan__, I really recommend wiktionary for basic words. [16:52:34] like https://en.wiktionary.org/wiki/birth_name [16:52:36] <^d> You can change your name, but you can't change your birth name. [16:52:40] mayankmadan__, name is your current name. [16:52:49] okay [16:52:50] A person like me has a different name than their birth name. [16:53:19] mayankmadan__, if two people marry in some cultures you have to get the same family name, so one person has to drop her/his family name and take the family name of the partner [16:53:22] (03CR) 10Anomie: remove forced index causing full index scans (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102880 (owner: 10Springle) [16:54:22] hey AaronSchulz. i have updated https://bugzilla.wikimedia.org/show_bug.cgi?id=58692 with some additional findings. please take a look and feel free to ask any questions you might have [17:00:43] (03CR) 10Jhall: [C: 032] Smoke tests for Upload Wizard using the API. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/102603 (owner: 10Aarcos) [17:00:47] (03Merged) 10jenkins-bot: Smoke tests for Upload Wizard using the API. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/102603 (owner: 10Aarcos) [17:01:22] ^d: I'll shove them all in:) [17:04:28] (03CR) 10Hashar: "The job seems to work more or less though the browser tests are still broken :-D" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 (owner: 10Hashar) [17:04:37] (03CR) 10Hashar: [C: 04-2] (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 (owner: 10Hashar) [17:07:15] resting place is where the grave of person is right? [17:07:29] resting place is where the grave of person is [17:11:39] (03CR) 10Anomie: "PITA that we already have three synonyms here, and now we're having four." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102896 (owner: 10Legoktm) [17:15:42] anomie: it's to ensure more options for wheelwar are available [17:21:43] (03PS3) 10UltrasonicNXT: Consistency tweaks in preparatation for adding extension to translatewiki.net [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/102679 (owner: 10Raimond Spekking) [17:26:05] (03CR) 10Aarcos: "Hi there folks," [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/102603 (owner: 10Aarcos) [17:32:58] (03CR) 10Siebrand: [C: 04-1] "Needs more discussion, preferably with designer input." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 (owner: 10Apsdehal) [17:34:21] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed. The code is also pretty readable now." [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/101499 (owner: 10Apsdehal) [17:41:14] ^d, what is portaldisp? [17:43:57] (03CR) 10Siebrand: [C: 04-1] "Needs more GENDER. That's what you get talking about users..." (037 comments) [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/102679 (owner: 10Raimond Spekking) [17:50:00] is there an easier way to know where the json error is? [17:50:10] (03PS1) 10Manybubbles: Switch index requests to updates with docAsUpsert [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102967 [18:04:32] RoanKattouw: Only BC code remaining on https://wikimedia.mingle.thoughtworks.com/projects/language_engineering/cards/3889 [18:04:43] siebrand: Already written but V-1ed right now [18:04:54] RoanKattouw: ah, where is it? [18:05:37] (03CR) 10EBernhardson: (bug 58645) Merge RecentChanges & Contributions' formatters extend from 1 same base class (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102674 (owner: 10Matthias Mullie) [18:06:08] (03PS3) 10EBernhardson: (bug 58645) Merge RecentChanges & Contributions' formatters extend from 1 same base class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102674 (owner: 10Matthias Mullie) [18:06:30] (03CR) 10EBernhardson: [C: 032] "PS2: Fixed typo in comments." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102674 (owner: 10Matthias Mullie) [18:06:37] (03Merged) 10jenkins-bot: (bug 58645) Merge RecentChanges & Contributions' formatters extend from 1 same base class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102674 (owner: 10Matthias Mullie) [18:07:46] (03CR) 10Siebrand: [C: 032] Add local names in Persian [extensions/cldr] - 10https://gerrit.wikimedia.org/r/102921 (owner: 10Ebrahim) [18:07:54] (03Merged) 10jenkins-bot: Add local names in Persian [extensions/cldr] - 10https://gerrit.wikimedia.org/r/102921 (owner: 10Ebrahim) [18:09:03] siebrand: https://gerrit.wikimedia.org/r/102100 [18:09:26] RoanKattouw: Ah, like that... [18:10:02] RoanKattouw: That diff is a bitch... :) [18:16:31] (03PS1) 10BryanDavis: Store full URL in session when redirecting to login form [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102969 [18:17:15] (03PS1) 10EBernhardson: Correct NoIndexException class name in autoloader [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102970 [18:24:35] (03PS1) 10EBernhardson: BC for renamed actions in AbstractFormatter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102971 [18:25:11] (03PS1) 10EBernhardson: No longer load blocks to format [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102972 [18:25:53] (03PS2) 10Manybubbles: Reimplement TitleKey's nearmatch finding [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102958 [18:27:06] (03PS1) 10BryanDavis: Respect log verbosity setting [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102973 [18:27:26] (03CR) 10Manybubbles: Reimplement TitleKey's nearmatch finding (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102958 (owner: 10Manybubbles) [18:28:06] (03CR) 10Bsitu: Correct NoIndexException class name in autoloader (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102970 (owner: 10EBernhardson) [18:28:27] hello yurik [18:28:34] (03CR) 10Anomie: [C: 04-1] "Who cares if it takes three function calls instead of one? Neither of these seem to be on a critical path and it's not like disabling the " (033 comments) [core] - 10https://gerrit.wikimedia.org/r/102845 (owner: 10Yurik) [18:32:08] (03CR) 10Bsitu: [C: 032] Correct NoIndexException class name in autoloader [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102970 (owner: 10EBernhardson) [18:32:14] (03Merged) 10jenkins-bot: Correct NoIndexException class name in autoloader [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102970 (owner: 10EBernhardson) [18:33:20] (03PS1) 10Manybubbles: Log a warning when retrying the connection [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/102975 [18:33:36] (03CR) 10Siebrand: [C: 04-1] i18n: Native digits on 'agent-other-display' (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102910 (owner: 10Ebrahim) [18:34:28] guillom, i have completed the task [18:34:45] guillom, if you are online and have some time please revuew ut asap [18:40:10] (03Abandoned) 10Jdlrobson: Apply default preferences styles to Minerva (mobile skin) [core] - 10https://gerrit.wikimedia.org/r/102891 (owner: 10Jdlrobson) [18:44:23] bd808: working on setting up L10n workflow for the scholarships app [18:44:47] siebrand: Awesome [18:45:09] Is there more help/changes needed from the app side? [18:46:24] (03CR) 10EBernhardson: [C: 032] Improve findMulti() for BasicDbStorage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102599 (owner: 10Bsitu) [18:46:28] bd808: I don't think so. [18:46:29] (03Merged) 10jenkins-bot: Improve findMulti() for BasicDbStorage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102599 (owner: 10Bsitu) [18:46:34] bd808: Will keep you updated. [18:46:46] thanks! [18:47:59] (03CR) 10Ebrahim: "the line above it says: // the number used for plural support I see it used as http://translatewiki.net/w/i.php?title=MediaWiki:notificati" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102910 (owner: 10Ebrahim) [18:49:55] (03PS1) 10Jdlrobson: Allow mediawiki ui resource loader module to target mobile [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/102977 [18:50:42] AaronSchulz: ping [19:02:46] (03CR) 10Ebrahim: "In the other word, no it is not needed." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102910 (owner: 10Ebrahim) [19:03:10] legoktm: Do you want me to add you to the default CC for BetaFeatures? I'm just doing it for myself… [19:10:39] spagewmf: you there? [19:16:37] (03CR) 10Jdlrobson: Add ability to generate KSS files for mediawiki.ui (037 comments) [core] - 10https://gerrit.wikimedia.org/r/98990 (owner: 10Jdlrobson) [19:23:09] (03CR) 10Chad: [C: 032] Add jQuery sourcemap file [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102839 (owner: 10BryanDavis) [19:23:12] (03Merged) 10jenkins-bot: Add jQuery sourcemap file [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102839 (owner: 10BryanDavis) [19:24:17] plop [19:24:21] (03CR) 10Chad: [C: 032] Respect log verbosity setting [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102973 (owner: 10BryanDavis) [19:24:24] (03Merged) 10jenkins-bot: Respect log verbosity setting [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102973 (owner: 10BryanDavis) [19:24:54] (03CR) 10Chad: [C: 032] Store full URL in session when redirecting to login form [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102969 (owner: 10BryanDavis) [19:24:57] (03Merged) 10jenkins-bot: Store full URL in session when redirecting to login form [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102969 (owner: 10BryanDavis) [19:26:22] (03CR) 10Hashar: [C: 04-1] "The static cache is fine and is a good idea. dl() … I really don't want it our code base anymore since it is not supported by hiphopvm. " (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97329 (owner: 10Platonides) [19:26:38] (03CR) 10Chad: [C: 032] Removed deprecated functions and merged ProxyTools into GlobalFunctions [core] - 10https://gerrit.wikimedia.org/r/101798 (owner: 10Aaron Schulz) [19:29:44] (03Merged) 10jenkins-bot: Removed deprecated functions and merged ProxyTools into GlobalFunctions [core] - 10https://gerrit.wikimedia.org/r/101798 (owner: 10Aaron Schulz) [19:30:48] (03CR) 10Chad: [C: 032] Log a warning when retrying the connection [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/102975 (owner: 10Manybubbles) [19:32:15] spagewmf: i neeeedddd you [19:33:10] jdlrobson: hes in a meeting [19:42:20] (03CR) 10Chad: [C: 032] Switch index requests to updates with docAsUpsert [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102967 (owner: 10Manybubbles) [19:42:23] (03Merged) 10jenkins-bot: Switch index requests to updates with docAsUpsert [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102967 (owner: 10Manybubbles) [19:42:32] (03CR) 10Chad: [V: 032] Log a warning when retrying the connection [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/102975 (owner: 10Manybubbles) [19:42:54] (03CR) 10Manybubbles: [C: 04-1] "poking this some more. please do not merge yet." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102958 (owner: 10Manybubbles) [19:44:38] (03CR) 10Bartosz Dziewoński: "We should kill skinStyles with fire and then, instead of allowing modules to define styles for particular skins, allow skins to define sty" [core] - 10https://gerrit.wikimedia.org/r/102891 (owner: 10Jdlrobson) [19:45:00] (03CR) 10Cscott: [C: 032] Add icu-bidi package. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/102469 (owner: 10Cscott) [19:45:08] (03CR) 10Cscott: [C: 032] Refactor: `Formatter` class tracks paragraph/inline state. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/102470 (owner: 10Cscott) [19:45:15] (03CR) 10Cscott: [C: 032] Support element. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/102471 (owner: 10Cscott) [19:45:43] (03Merged) 10jenkins-bot: Add icu-bidi package. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/102469 (owner: 10Cscott) [19:45:44] (03Merged) 10jenkins-bot: Refactor: `Formatter` class tracks paragraph/inline state. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/102470 (owner: 10Cscott) [19:45:59] (03Merged) 10jenkins-bot: Support element. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/102471 (owner: 10Cscott) [19:47:03] (03CR) 10Chad: "Yeah I hadn't reviewed it yet :)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102958 (owner: 10Manybubbles) [19:48:44] (03CR) 10Manybubbles: "unfortunately for you, I ended up opening up another bug, having an epiphany about this one, and combining their solutions...." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102958 (owner: 10Manybubbles) [19:48:47] (03PS1) 10Cscott: Update `mocha` dependency. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/102979 [19:49:30] (03CR) 10Cscott: [C: 032] Update `mocha` dependency. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/102979 (owner: 10Cscott) [19:49:49] (03Merged) 10jenkins-bot: Update `mocha` dependency. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/102979 (owner: 10Cscott) [19:52:49] (03PS1) 10Cscott: Update `mocha` dependency to 1.16.x. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/102981 [19:52:50] (03PS1) 10Cscott: Update README. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/102982 [19:53:13] (03CR) 10Cscott: [C: 032] Update `mocha` dependency to 1.16.x. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/102981 (owner: 10Cscott) [19:53:22] (03CR) 10Cscott: [C: 032] Update README. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/102982 (owner: 10Cscott) [19:53:38] (03CR) 10Hashar: [C: 031] "My only objection was making sure we kept back compatibility. The tests I wrote cover that point so that is good to me." [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [19:57:59] (03Merged) 10jenkins-bot: Update `mocha` dependency to 1.16.x. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/102981 (owner: 10Cscott) [19:58:36] (03CR) 10Chad: [C: 032] Build Special:Search's title without escaping [core] - 10https://gerrit.wikimedia.org/r/102820 (owner: 10Manybubbles) [19:59:50] (03Merged) 10jenkins-bot: Update README. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/102982 (owner: 10Cscott) [20:00:51] (03CR) 10Siebrand: [C: 032] i18n: Native digits on 'agent-other-display' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102910 (owner: 10Ebrahim) [20:01:01] (03Merged) 10jenkins-bot: i18n: Native digits on 'agent-other-display' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102910 (owner: 10Ebrahim) [20:01:16] (03PS4) 10Jdlrobson: Add ability to generate KSS files for mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/98990 [20:01:49] ^ spagewmf superm401 if one of you want to merge that i will personally think of you as awesome from now on [20:02:00] (03Merged) 10jenkins-bot: Build Special:Search's title without escaping [core] - 10https://gerrit.wikimedia.org/r/102820 (owner: 10Manybubbles) [20:02:22] (03CR) 10Yaron Koren: [C: 032 V: 032] "This looks great. Thanks a lot for helping with this extension!" [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/101499 (owner: 10Apsdehal) [20:04:49] (03PS14) 10Gergő Tisza: licenseInput: Handle redirects for license templates [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50755 (owner: 10Nischayn22) [20:13:39] (03CR) 10Jdlrobson: "Is there a bug open?" [core] - 10https://gerrit.wikimedia.org/r/102891 (owner: 10Jdlrobson) [20:15:37] (03CR) 10RobLa: "Hi Yuri, why is this GPLv3?" [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [20:19:31] if i am reworking a commit the original author abandoned, is it fine to put it under my name? it is nice to see all my pending stuff together in gerrit [20:20:12] by abandoned i mean did not touch in a long time, not abandoned via the gerrit button [20:20:35] bd808|LUNCH: https://translatewiki.net/wiki/Special:Translate/out-wikimania-scholarships-app [20:20:42] (03PS5) 10Jdlrobson: Add ability to generate KSS files for mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/98990 [20:21:52] tgr: Under your name how? [20:22:27] by changing the commit author [20:22:39] i presume that would change the owner field in gerrit [20:23:01] <^demon> No, owner != author [20:23:08] <^demon> owner == original committer [20:23:19] tgr: Gerrit will forever believe the original author "owns" it [20:23:32] <^demon> Not original author. [20:23:35] <^demon> Original committer [20:23:36] You can change the Author and Committer metadata in git but unfortunately you can't change the owner [20:23:39] Right, sorry [20:23:44] ah, ok [20:25:45] (03PS6) 10Jdlrobson: Add ability to generate KSS files for mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/98990 [20:27:35] robla, hi, do you think gplv3 is bad? i thought it was the most up to date and non-tivo-isable one [20:28:30] yurik: I'm not personally opposed to GPLv3 from a philosophical perspective, but our current standard is GPLv2 or later [20:28:53] hey ^demon and manybubbles. Are you guys working on multilingual / multisite searching? [20:29:03] ...and we should just slip code into our codebase that's GPLv3 without being more deliberate about it [20:29:36] <^demon> yuvipanda: It's on our radar, yeah. [20:29:43] <^demon> Haven't actually started implementation yet. [20:29:45] robla, should or shouldn't ? :) [20:29:50] ^demon: ah, ok! approximate timeline? [20:29:56] sorry, "shouldn't" :-) [20:30:11] <^demon> yuvipanda: Between now and the heat death of the universe ;-) [20:30:16] yurik: not a license expert and ianal, but i see Tim using that delibate "any comptabile license and i meant that" thing [20:30:24] <^demon> (Or the second coming, depending on your philosophy) [20:30:36] ^demon: right before we move from PHP to nodejs? :P [20:30:52] we are moving from php? wow!\ [20:30:54] <^demon> Before that, yes :p [20:31:00] siebrand: That is cool. [20:31:10] robla, ok, will update. Any other comments? :) [20:31:11] ^demon: :D but 'more accurately', say, 6 months? [20:31:27] <^demon> I could see something inside 6 months, yeah :) [20:31:38] robla, i should try to port some of your stuff in as well - they would mash well imo [20:31:55] <^demon> yuvipanda: The cluster supports it, it's just a matter of code + UI. [20:31:55] ^demon: ok :) [20:31:59] yurik: no other comments from me. [20:32:13] ^demon: right. so what I'd want is just an API, because app. [20:32:16] robla, ok, will deploy to all wikies later today [20:32:22] ^demon, aude & robla: siebrand got Scholarships hooked into translatewiki -- https://translatewiki.net/wiki/Special:Translate/out-wikimania-scholarships-app [20:32:25] ^demon: oh, also just to make sure: it searches *across* language wikis, right? [20:32:43] <^demon> bd808: Awesome. [20:32:48] yurik: riiiiight [20:32:54] <^demon> yuvipanda: We haven't added any new APIs, we just implement the backend. [20:33:01] <^demon> Cross-site search might need some API. [20:33:04] <^demon> :) [20:33:05] ^demon: true. [20:33:20] ^demon: but just wanted to verify we were talking about the same thing when we mean 'cross language search' :) [20:33:22] bd808: siebrand: cool! [20:33:45] <^demon> yuvipanda: I think so :) [20:33:50] ^demon: sweet! [20:33:57] robla, in reality, the code is almost identical to what we already have in zero, so this is more of a refactoring than totally new unneeded feature. So i don't think it should be that long to push it to prod - probably sometime mid jan [20:34:28] plus ori-l will be happy [20:34:53] bd808: I guess we actually don't get the ability to edit the English strings for free using that, do we? [20:34:54] as he will be able to remove a large chunk of his schema code as well [20:36:55] robla: Not sure, but i think maybe? I can get an edit box for the english version of a string. [20:37:13] <^demon> They'll get overwritten. [20:37:22] <^demon> TWN imports the en translations from the software(s). [20:37:32] <^demon> So en changes should be done in the git repo. [20:37:36] <^demon> (How it's always been :)) [20:37:50] yeah, I'd forgotten about that [20:38:01] Darn. Still cool though [20:38:16] <^demon> Still, fact that we split everything out to language files makes it easier for non-coders to edit. [20:38:22] <^demon> :) [20:38:52] Yes, but the php json parser is really strict and easy to piss off [20:39:39] I was going to ask hashar about making a json lint jenkins job to watch that [20:39:53] <^demon> bd808: You won't like [the php json parser] when he's angry! [20:40:55] so...we could encourage a non-technical person to get a GitHub account, edit here, and submit pull requests: https://github.com/wikimedia/wikimedia-wikimania-scholarships/blob/master/data/i18n/en.json [20:41:14] Yeah that would work [20:42:10] <^demon> I've never seen "encourage" and "github" in the same sentence before ;-) [20:42:14] * bd808 hides before the anti-github mob arrives [20:42:24] bd808: I guess you didn't see the big red warning "Don't edit English strings"? :) [20:42:49] <^demon> bd808: Arrive? I've been here. And a mob of 1? [20:42:50] <^demon> :p [20:43:43] Gerrit needs to catch up with the Jones's on that feature :-P [20:43:46] Nemo_bis: Actually I haven't. But my login has "You need translation rights to translate messages." on everything too [20:44:56] bd808: Follow the drill at https://translatewiki.net/wiki/Special:Mainpage [20:44:59] (03PS3) 10Manybubbles: Implement near match and improve prefix search [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102958 [20:45:02] <^demon> robla: Stop trying to troll me :P [20:45:23] ^demon: trying? clearly I'm succeeding :-P [20:45:27] bd808: let me know when done, I'll approve. [20:46:24] siebrand: I've been looking for your account but I don't find it [20:46:29] * bd808 [20:46:45] Nemo_bis: It's BryanDavis [20:47:07] <^demon> robla: I know, I shouldn't allow myself to be baited :) [20:47:07] Just created today [20:47:14] (03CR) 10Legoktm: [C: 04-1] "See inline comments. Also add a link to bug 55338 in the commit message please." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/98863 (owner: 10Ebrahim) [20:47:20] ok, done [20:47:22] Nemo_bis: BryanDavis (Overleg | bijdragen | blokkeren) (Geregistreerd op 20 dec 2013 om 19:55) [20:47:26] (03Abandoned) 10Legoktm: Use localized group names for user rights changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91630 (owner: 10Gerrit Patch Uploader) [20:47:28] * Nemo_bis already had userrights open [20:48:07] <^demon> Nemo_bis: I keep userrights open for mw.org in an extra tab usually. ;-) [20:48:29] siebrand: is there a way (short of learning Gerrit or emailing devs) for non-tech users to suggest changes to source language strings? (or is there a feature request you're tracking for that)? [20:48:57] robla: We have an "ask question" feature in our UI. [20:49:17] robla: That's what translators should use to ask questions about strings. [20:49:20] and now siebrand also edit conflicts me :) [20:49:30] ^demon: lol [20:49:50] robla: Those questions end up at https://translatewiki.net/wiki/Support and people like Nemo_bis start nagging you if you don't follow up on those... [20:49:55] ^demon: anything you can add to account #35927 ? [20:50:28] robla: and this is why we just tricked bd808 into signing up :P [20:50:58] robla: When SemanticMediaWiki is unbroken again, we'll be able to provide updated lists like https://translatewiki.net/wiki/User:Jrice again and those do have RSS feeds... [20:51:14] * robla goes into TranslateWiki, switches to "British English", and starts arbitrarily adding "u"s after "o"s in random places [20:51:19] <^demon> Nemo_bis: I'm assuming that's your UID? Too lazy to look it up :) [20:51:43] y [20:52:08] (03CR) 10Gergő Tisza: "Fixed several issues with promises in deed validation. Changed category checking for license tags, it used to do a depth-Tested, seems to " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50755 (owner: 10Nischayn22) [20:53:02] <^demon> Dafuq? [20:53:09] <^demon> Why is "Steward" a group I can change on mw.org [20:53:33] * hoo searches his abuse banner [20:53:37] ^demon: staff? [20:53:39] ^demon: Abuse!11111 [20:53:43] /sysop [20:53:58] <^demon> Reedy: I don't have +staff. [20:54:05] <^demon> Although I do have +sysadmins or whatever it is. [20:54:08] <^demon> Maybe that's it? [20:54:14] that's more powerful iirc [20:54:28] <^demon> bwahahaha! [20:54:33] https://toolserver.org/~pathoschild/globalgroups/#sysadmin [20:54:34] <^demon> power -> head [20:54:46] * hoo has all the rights [20:54:52] * yuvipanda waves at siebrand [20:54:54] actually I don't, but taht sounds good :P [20:54:58] not even stewards have "userrights" globally O_O [20:55:17] (03CR) 10Gergő Tisza: "Most of the promise/async stuff is done in the license text validator. That code is mostly independent from the rest, and a good candidate" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50755 (owner: 10Nischayn22) [20:55:20] If you've already got database access.... [20:55:31] hey yuvipanda. Exam results in yet? [20:55:39] siebrand: at least another month and a half, sadlyu [20:55:41] *sadly [20:55:50] <^demon> Reedy: Anyone who has access to the database effectively has userrights on all wikis ;-) [20:55:52] siebrand: not coming to brussels either [20:55:54] yuvipanda: outrageous. 10 week wait!? [20:55:56] <^demon> :) [20:56:00] INSERT INTO user_groups SELECT user_id, 'sysop' FROM user; [20:56:11] siebrand: more like 3 months. it's been a month since i wrote it [20:56:16] yuvipanda: miss you! [20:56:18] ^demon: I think he means that it's an incentive to use wiki instead of DB :P [20:56:24] siebrand: you too! [20:56:35] siebrand: so, wanted to get the new wikipedia app up on translatewiki :) [20:56:49] siebrand: I'll do all the necessary commits to the 'translate' repo on monday [20:57:04] siebrand: but what I wanted to ask was, we already have the old 'wikipedia' app there. what would you do with it? [20:57:04] yuvipanda: Its been a crazy day... We landed the new mediawiki L10n format in core today, it's live with 2 extension on twn now. [20:57:11] siebrand: wooo! [20:57:13] siebrand: nice! [20:57:18] siebrand: the one based off jquery.i18n? [20:57:20] <^demon> manybubbles: 102958 ready for review? [20:57:21] yuvipanda: Also added support for the Wikimania Scholarship app. [20:57:27] yuvipanda: yep [20:57:30] siebrand: nice! [20:57:37] siebrand: no more crazy-huge php files :) [20:57:40] <^demon> siebrand: Speaking of TWN + new i18n, thanks for helping get the Scholarships thing live. It's exciting :) [20:57:43] siebrand: congratulations, [20:57:49] s/,/!/ [20:57:57] ^demon: if you are ready for it [20:57:59] it got a bit big [20:58:02] yuvipanda: Thanks. RoanKattouw did a lot of the implementation work, with help of Nikerabbit and Santhosh. [20:58:07] siebrand: nice! [20:58:11] but it really makes a lot of sense [20:58:15] to me, at least [20:58:20] yuvipanda: https://gerrit.wikimedia.org/r/#/c/102940/ has no BC support, so only works with current 1.23alpha. [20:58:24] <^demon> manybubbles: Yeah, it is getting big :) [20:58:32] the whole prefix search being a special case of near match search [20:58:34] yuvipanda: Only thing left is BC support. [20:58:43] siebrand: nice [20:58:53] yuvipanda: and then the conversion spree can start. [20:58:53] <^demon> Nemo_bis: So, back to your original question if there's any rights I can give your account.... [20:58:57] siebrand: nice [20:59:00] <^demon> I suppose we could give you +steward on mw.org lolol [20:59:19] ^demon: sounds legit [20:59:22] * yuvipanda takes ^demon to arbcom [20:59:26] Wikimedia:Wsa-form-chapteragree/en-gb shows blank.. [20:59:35] yuvipanda: Anyway.. You'd make my life a lot easier if you could send me a mail with the detials. [20:59:41] <^demon> yuvipanda: mw.org arbcom? [20:59:44] <^demon> We have no arbcom! [20:59:46] yuvipanda: I'll probably add support somewhere in the next 7 days. [20:59:47] siebrand: don't worry about it :) I'll do that next week [20:59:51] ^demon: we do, you chair it! [21:00:06] siebrand: not *that* urgent [21:00:09] <^demon> I'm loving this system more and more by the minute. [21:00:21] ^demon: well, we took you to it, so you are it now [21:03:00] <^demon> Bleh. I hate when I try to use [ and ] and expect it to cycle through documents or e-mails or somesuch. [21:03:08] <^demon> I spend too much time on Gerrit :\ [21:04:09] (change visibility) 21:02, 20 December 2013 (diff | hist) . . (+212)‎ . . N Wikimedia:Wsa-new-account-email/en-gb ‎ (current) [21:04:09] (change visibility) 21:02, 20 December 2013 (diff | hist) . . (+364)‎ . . N Wikimedia:Wsa-form-chapteragree/en-gb ‎ (current) [21:04:09] (change visibility) 21:01, 20 December 2013 (diff | hist) . . (+2,288)‎ . . N Wikimedia:Wsa-form-rights/en-gb ‎ (current) [21:04:11] luls [21:04:19] I noticed that in change screen 2 there is no change URL given for "git fetch .... " [21:04:35] <^demon> It's there. [21:04:42] <^demon> Oh wait, no, it's a plugin now. [21:04:56] <^demon> saper: I have a burning rage for CS2 :( [21:05:00] <^demon> I hate hate HATE it. [21:05:18] make CS1 really shine [21:05:21] makes [21:05:31] in comparison, unfortunately [21:05:31] James_F|Away: sure [21:05:56] <^demon> saper: But what do you expect when the author of JGit decides he's going to put on a UI designer hat? *sigh* [21:06:29] I wanted to fetch a change and had to guess the URL for "git fetch". Needless to say, git-review does not work for gerrit's own repo because it's HTTP and not SSH. [21:07:42] <^demon> saper: Yeahhhhh....luckily 2.8 snuck out before it got made default, so we can at least upgrade to 2.8 without forcing CS2 on peeps. [21:08:09] <^demon> I think I'll spend my Christmas testing 2.8 :) [21:08:42] yaah, default CS2 is in pretty fresh master only [21:12:45] (03Restored) 10Legoktm: Use localized group names for user rights changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91630 (owner: 10Gerrit Patch Uploader) [21:13:40] (03Abandoned) 10Ebrahim: i18n: Localized user right labels [extensions/Echo] - 10https://gerrit.wikimedia.org/r/98863 (owner: 10Ebrahim) [21:17:25] (03CR) 10Hashar: "I am on vacations but you can reach out with Mark Holqmist next to you who has some experience with Jenkins. You could create a job that " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/102603 (owner: 10Aarcos) [21:18:13] (03PS1) 10Yaron Koren: Fix for bug where variables with 10-char name always get URL-encoded [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/103039 [21:19:20] (03CR) 10TheDJ: [C: 04-1] "Breaks Safari, by changing the looks of the input to the search appearance due to usage of input type "search"." [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński) [21:19:40] (03CR) 10Yaron Koren: [C: 032 V: 031] Fix for bug where variables with 10-char name always get URL-encoded [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/103039 (owner: 10Yaron Koren) [21:20:10] thedj: "breaks"? [21:20:11] (03CR) 10Yaron Koren: [V: 032] Fix for bug where variables with 10-char name always get URL-encoded [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/103039 (owner: 10Yaron Koren) [21:20:37] bd808: btw, live translation statistics: https://translatewiki.net/w/i.php?title=Special%3ATranslationStats&preview=1&days=30&scale=days&count=edits&group=out-wikimania-scholarships-app and https://translatewiki.net/wiki/Special:MessageGroupStats/out-wikimania-scholarships-app [21:23:03] <^demon> siebrand: Those links time out for me [21:23:09] <^demon> (Granted, I'm on an absolute shit connection) [21:23:17] MatmaRex: yeah, like in look so ugly people will report it as a bug [21:23:25] heh [21:23:29] ^demon: They should provide content within 10 seconds, immediately if we have the stats cached. [21:23:37] screenshot? [21:23:57] ^demon: sever time for both is <1 sec. [21:24:07] <^demon> Damn, must be my connection. [21:24:18] <^demon> (I'm tethering through TMo right now) [21:25:07] <^demon> siebrand: No big deal, I'll check them later :) [21:25:34] ^demon: I checked the English versions anonymous, and server time for both is about 0.30seconds [21:25:50] <^demon> Yeah, must me me :p [21:26:01] (03PS2) 10Mattflaschen: Whitelist 'useskin' and 'uselang' when choosing buttons to show [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/100934 [21:26:14] ^demon: anyway, the summary is: Dutch 43%, German 24% :) [21:26:27] <^demon> Sweet :) [21:26:37] MatmaRex: http://imagebin.ca/v/160xVNUb0lUs [21:27:17] (03PS3) 10Mattflaschen: Whitelist 'useskin' and 'uselang' when choosing buttons to show [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/100934 [21:27:46] oh wow, lol. [21:29:36] nice thing btw is that with appearence:none, you still get the clear button. [21:29:48] <^demon> Wait, are we getting rid of that stupid rounded box? [21:29:54] <^demon> If so, yay. I hate those. [21:30:09] <^demon> thedj: Am I the only person who doesn't like that clear button? [21:30:20] hehe i guess so. [21:30:36] <^demon> I've never once clicked it on purpose. [21:32:22] * thedj goes to file a webkit bug... [21:32:42] appearence:none doesn't remove the text-indent of the searchfield. [21:37:34] ^demon / bd808 : 3 of the 4 top topics https://translatewiki.net/wiki/Support are about issues with the scholarship apps' messages. Nothing too bad. [21:38:08] * ^demon clicks, twiddles thumbs, goes to grab a drink while the tab loads [21:39:55] (03PS1) 10Siebrand: L10n updates [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/103041 [21:40:13] ^demon: Just review https://gerrit.wikimedia.org/r/#/c/103041/ [21:41:13] (03CR) 10Chad: [C: 032] L10n updates [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/103041 (owner: 10Siebrand) [21:41:16] (03Merged) 10jenkins-bot: L10n updates [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/103041 (owner: 10Siebrand) [21:41:32] <^demon> Merged :) [21:43:17] hey AaronSchulz did you happen to have a chance to look at the updated notes for https://bugzilla.wikimedia.org/show_bug.cgi?id=58692 [21:44:41] not really [21:47:16] k, i'm hoping the additional notes might help you narrow down what the issue might be … hopefully you can get to it early next week. we don't want to move forward on production until we can sort this out. basically it looks like delayed jobs are not being picked up as expected [21:49:21] (03CR) 10TheDJ: "Apparently this is the advised CSS:" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński) [21:51:56] Phew, 94% [21:52:37] <^demon> On Dutch? [21:56:00] (03CR) 10TheDJ: "-webkit-appearance: none; instead of display:none; also works and might be more correct..." [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński) [21:57:19] (03PS2) 10Aaron Schulz: [WIP] Added scripts to update CDB files without sending them [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/102878 [22:00:26] ori-l, is MW-Vagrant supposed to include https://github.com/atdt/phpsh/commit/8a47fac3aaa85b8e1c379a7af73eb6a0f908dc5b ? [22:00:43] I'm not sure if my machine is too old, or it's not in the requested pip version. [22:05:58] (03PS1) 10Spage: `make master` command, useful for ee-flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103046 [22:08:30] Nope, but I saw you already built 1.3.3 which has it. [22:08:35] I'll submit a patch to MWV. [22:09:28] MatmaRex: he, i just noticed that the simplesearch browsercheck is broken.. [22:11:14] $client.test( map ) but that should be $client.test( map.browsers ) [22:11:22] or client lib is broken of course... [22:13:01] thedj: I merged that patch this week I thought? [22:13:20] thedj: https://gerrit.wikimedia.org/r/#/c/95870/ [22:13:42] (03PS1) 10Siebrand: Localisation fixes [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/103048 [22:13:50] (03PS1) 10Mattflaschen: Update to phpsh 1.3.3 (latest of Ori's pip versions) [vagrant] - 10https://gerrit.wikimedia.org/r/103049 [22:14:00] bd808: https://gerrit.wikimedia.org/r/#/c/103048/ [22:14:04] oh, matma's changes are not rebased since then [22:14:16] ori-l, https://gerrit.wikimedia.org/r/#/c/103049/ [22:14:17] * thedj was grepping stepping trough code [22:14:35] (03CR) 10BryanDavis: [C: 032] "Thanks for the fixes!" [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/103048 (owner: 10Siebrand) [22:14:39] (03Merged) 10jenkins-bot: Localisation fixes [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/103048 (owner: 10Siebrand) [22:15:18] :) [22:19:33] (03PS4) 10Jdlrobson: Move all VectorBeta RL modules from core. [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99523 [22:22:26] (03PS1) 10Mattflaschen: Handle empty Redis sets without a warning from array_key_exists [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103050 [22:27:08] (03CR) 10BryanDavis: [C: 032] Update to phpsh 1.3.3 (latest of Ori's pip versions) [vagrant] - 10https://gerrit.wikimedia.org/r/103049 (owner: 10Mattflaschen) [22:27:10] (03Merged) 10jenkins-bot: Update to phpsh 1.3.3 (latest of Ori's pip versions) [vagrant] - 10https://gerrit.wikimedia.org/r/103049 (owner: 10Mattflaschen) [22:27:44] (03Abandoned) 10Siebrand: Localisation updates from https://translatewiki.net. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/103051 (owner: 10L10n-bot) [22:30:22] (03Abandoned) 10Siebrand: Localisation updates from https://translatewiki.net. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/103053 (owner: 10L10n-bot) [22:30:55] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/103054 (owner: 10L10n-bot) [22:31:07] * siebrand mumbles something about Gerrit access rights. [22:32:24] Does anyone know why this happened? I merged L10n-bot merged: Merging 103054... error: submit not permitted; one or more approvals failed; review output above [22:32:24] And the patch set was merged anyway... [22:32:54] siebrand: there can be checks that vote -1 but are still set to be ignored [22:32:58] temp or permanent [22:33:10] mutante: https://gerrit.wikimedia.org/r/#/c/103054/ shows no negative votes. [22:33:14] hashar would know, but i know he like literally just left [22:33:34] mutante: Oh, I think that jenkins actually merged with its verified +2. [22:33:44] mutante: I'll create a bug. [22:33:47] mutante: thanks [22:34:12] siebrand: where do you see the error? [22:34:27] mutante: In Gerrit ssh shell (scripted on translateiwki.net) [22:34:55] siebrand: oooh, i never knew you used Gerrit ssh shell and a script, i would be suspicious of that part then [22:35:15] it looks ok in browser [22:35:24] everything success and such [22:35:33] mutante: we use ssh to merge all open L10n-bot patch sets. [22:35:51] OMG jenkins TOO FAST [22:35:55] i would open the bug against the script/ssh way then [22:36:06] not jenkins globally i suppose [22:38:23] thedj: i have a patch for that pending, too [22:38:41] it's called "unbreak simplesearch browser check" or something [22:40:20] (03PS7) 10Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/100800 [22:42:40] MatmaRex: yeah, it's already merged [22:42:50] but your other patch isn't rebased against that yet. [22:47:10] (03CR) 10Ori.livneh: Handle empty Redis sets without a warning from array_key_exists (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103050 (owner: 10Mattflaschen) [22:48:26] (03CR) 10Kaldari: [C: 04-1] "Why are the font orders reversed from what they were in core? I'm fine with having free fonts first, but there is no way we should have De" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99523 (owner: 10Jdlrobson) [22:50:46] (03CR) 10MaxSem: [C: 032] Add logging for "Invalid message parameter" [core] - 10https://gerrit.wikimedia.org/r/102604 (owner: 10Yurik) [22:50:57] (03PS11) 10Ori.livneh: Make SpecialWatchlist extend SpecialRecentChanges (temporarily) [core] - 10https://gerrit.wikimedia.org/r/89379 (owner: 10Bartosz Dziewoński) [22:51:07] (03CR) 10Ori.livneh: [C: 032] Make SpecialWatchlist extend SpecialRecentChanges (temporarily) [core] - 10https://gerrit.wikimedia.org/r/89379 (owner: 10Bartosz Dziewoński) [22:51:29] MatmaRex: why not add both buttons, and use classes to switch between which one is visible ? then remove the "search" one from the dom in js ? [22:52:31] thedj: my buffer doesn't have enough to context -- are you talking about the change i just +2'd? [22:52:43] if you want to discuss it further, i can -1 it to block jenkins. [22:52:54] ori-l: im talking about search field [22:53:00] ok, disregard :) [22:54:34] (03CR) 10jenkins-bot: [V: 04-1] Add logging for "Invalid message parameter" [core] - 10https://gerrit.wikimedia.org/r/102604 (owner: 10Yurik) [22:56:08] (03CR) 10jenkins-bot: [V: 04-1] Make SpecialWatchlist extend SpecialRecentChanges (temporarily) [core] - 10https://gerrit.wikimedia.org/r/89379 (owner: 10Bartosz Dziewoński) [22:56:27] is jenkins ok? [22:59:42] (03CR) 10Kaldari: [C: 032] Move all VectorBeta RL modules from core. [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99523 (owner: 10Jdlrobson) [22:59:48] (03Merged) 10jenkins-bot: Move all VectorBeta RL modules from core. [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99523 (owner: 10Jdlrobson) [23:00:14] (03CR) 10Kaldari: [C: 032] Move VectorBeta modules to VectorBeta extension [core] - 10https://gerrit.wikimedia.org/r/99524 (owner: 10Jdlrobson) [23:03:15] (03Merged) 10jenkins-bot: Move VectorBeta modules to VectorBeta extension [core] - 10https://gerrit.wikimedia.org/r/99524 (owner: 10Jdlrobson) [23:11:28] (03PS1) 10Theopolisme: Add timedmedia-flac message [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/103060 [23:13:24] (03PS2) 10Mattflaschen: Handle empty Redis sets without a warning from array_key_exists [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103050 [23:13:47] (03CR) 10Mattflaschen: "Changed to is_numeric. See inline." (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/103050 (owner: 10Mattflaschen) [23:14:23] MatmaRex: like this http://pastebin.com/FT27G2V1 [23:15:23] no FOUC, and i doubt anyone is quick enough to type and press enter (and if so, he'd just go to fullsearch page) [23:19:59] thedj: i'm afraid i have no idea what that patch is supposed to achieve [23:23:21] (03CR) 10Bartosz Dziewoński: "Whut?" [core] - 10https://gerrit.wikimedia.org/r/89379 (owner: 10Bartosz Dziewoński) [23:24:23] not using noscript [23:24:33] (03PS3) 10Aaron Schulz: [WIP] Added scripts to update CDB files without sending them [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/102878 [23:25:05] so that iphone/ipod/opera blacklist works as well. (though the toggle needs to be under the blacklist return for that) [23:25:09] thedj: well, it had an inline script before, but i was bitched at for doing that [23:25:20] ori-l: so, that takes 5.5sec on my 4-core (12 threads) to update 100 ~2MiB CDB files [23:25:50] (03PS2) 10EBernhardson: No longer load blocks to format [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102972 [23:25:52] the i18n ones under my /cache dir are all < 1Mb [23:25:58] MatmaRex: yeah, but this is not inlinescript and it has not fouc. should address the bitching concerns right ? [23:26:04] * AaronSchulz is just using 2Mb test files for good measure [23:26:17] making the diffs is about the same time [23:27:19] thedj: hiding stuff with display:none; when JS is off sounds unpleasant [23:27:20] meh [23:27:28] i have to reread what i wrote in that patch some time [23:27:35] i completely forgot what's in there by now [23:27:55] ori-l, around? [23:27:56] yeah, it's a bit complex :D [23:28:41] MatmaRex: hiding in general is bad, but this is basically doing a toggle [23:29:26] (03PS3) 10Yurik: Add logging for "Invalid message parameter" [core] - 10https://gerrit.wikimedia.org/r/102604 [23:29:33] i preferred the earlier versions of that patch [23:29:40] with fewer buttons [23:29:49] (03CR) 10Yurik: [C: 032] "MaxSem already approved, Jenkins is having issues" [core] - 10https://gerrit.wikimedia.org/r/102604 (owner: 10Yurik) [23:30:50] or actually, with more buttons [23:30:55] and less poking around the,m [23:31:18] (03PS1) 10EBernhardson: Simplify header and edit-header templates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103064 [23:32:37] (03CR) 10jenkins-bot: [V: 04-1] Add logging for "Invalid message parameter" [core] - 10https://gerrit.wikimedia.org/r/102604 (owner: 10Yurik) [23:32:56] (03PS2) 10EBernhardson: Simplify header and edit-header templates [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103064 [23:37:48] did someone mess up master? [23:38:13] several +2's for core are blocked by jenkins due to unit test failures [23:38:30] (03PS3) 10CSteipp: Work around access restriction for image attachments [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/90546 (owner: 10Aklapper) [23:38:40] https://integration.wikimedia.org/ci/job/mediawiki-core-phpunit-misc/17070/console [23:38:55] yeah noticed that as well... [23:40:22] (03CR) 10CSteipp: "Feel free to add more comments, but this is working on my test install." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/90546 (owner: 10Aklapper) [23:44:02] (03CR) 10Bartosz Dziewoński: "(Also, if this is getting merged, it should probably be followed by a few more items from the stack.)" [core] - 10https://gerrit.wikimedia.org/r/89379 (owner: 10Bartosz Dziewoński) [23:47:04] ori-l: I think I'll just turn the whole file into json instead of diffs [23:47:07] * AaronSchulz refactors [23:52:10] (03PS1) 10TheDJ: Alternative idea to change: I5fe0543e273aab4fbfb88f8ce933bc49872d4793 [core] - 10https://gerrit.wikimedia.org/r/103066 [23:55:17] (03PS1) 10EBernhardson: Simplify edit-title template [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103069 [23:56:08] (03CR) 10Spage: [C: 032] "make love" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103046 (owner: 10Spage) [23:56:14] (03Merged) 10jenkins-bot: `make master` command, useful for ee-flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/103046 (owner: 10Spage) [23:56:39] (03PS2) 10TheDJ: Alternative idea to change: I5fe0543e273aab4fbfb88f8ce933bc49872d4793 [core] - 10https://gerrit.wikimedia.org/r/103066