[00:00:21] (03Merged) 10jenkins-bot: Remove unused '{name}-{ext-name}-install' job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102597 (owner: 10Krinkle) [00:02:24] (03PS1) 10Bsitu: Improve findMulti() for BasicDbStorage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102599 [00:04:07] (03PS2) 10Bsitu: Improve findMulti() for BasicDbStorage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102599 [00:20:30] (03CR) 10Spage: "It passes whether or not I understand the English-ish parsing of "Body of Flow Topic". I'll rebase it onto the double quotes patch and +2" (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102488 (owner: 10Cmcmahon) [00:22:10] (03PS1) 10Aarcos: Smoke tests for Upload Wizard using the API. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/102603 [00:27:36] (03CR) 10Bsitu: "Tested and it is working, a few things:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95975 (owner: 10Werdna) [00:29:57] (03PS1) 10Yurik: Bug 58676: Added logging for "Invalid message parameter" [core] - 10https://gerrit.wikimedia.org/r/102604 [00:37:46] (03PS5) 10EBernhardson: Add flow specific exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100524 (owner: 10Bsitu) [00:37:48] (03CR) 10jenkins-bot: [V: 04-1] Add flow specific exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100524 (owner: 10Bsitu) [00:38:10] (03CR) 10Tim Starling: "CategoryTree does three things: it modifies the subcategory listing on category pages, it provides Special:CategoryTree, and it provides t" [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/57041 (owner: 10Njw) [00:38:38] (03CR) 10EBernhardson: Add flow specific exceptions (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100524 (owner: 10Bsitu) [00:39:31] (03CR) 10Mattflaschen: "I marked this "do not translate" in the comment here too." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/100534 (owner: 10Mattflaschen) [00:40:31] (03PS1) 10Bsitu: Fix the wording in 'edit post' notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102607 [00:42:04] (03CR) 10Nuria: [C: 032] Log event when new editors reach edit milestone [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/98079 (owner: 10Ori.livneh) [00:42:07] (03Merged) 10jenkins-bot: Log event when new editors reach edit milestone [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/98079 (owner: 10Ori.livneh) [00:45:03] (03PS6) 10EBernhardson: Add flow specific exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100524 (owner: 10Bsitu) [00:52:06] (03CR) 10EBernhardson: [C: 031] "This looks good to be, but it touches so many files going to wait until the deployment train has gone out tomorrow before merging." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100524 (owner: 10Bsitu) [00:59:25] (03PS5) 10Spage: new test for Collapsed/Full/Small view modes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102488 (owner: 10Cmcmahon) [01:00:01] (03CR) 10Spage: [C: 032] new test for Collapsed/Full/Small view modes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102488 (owner: 10Cmcmahon) [01:00:06] (03Merged) 10jenkins-bot: new test for Collapsed/Full/Small view modes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102488 (owner: 10Cmcmahon) [01:07:30] (03CR) 10Swalling: [C: 031] "Please do." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/100934 (owner: 10Mattflaschen) [01:26:36] (03PS1) 10Mattflaschen: Add mediawiki.ui.button to places in core using mw.ui [core] - 10https://gerrit.wikimedia.org/r/102608 [01:26:56] (03CR) 10Mattflaschen: "Follow-up (#2, for core): https://gerrit.wikimedia.org/r/102608" [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari) [02:37:02] (03CR) 10Krinkle: [C: 032] "Didn't push any new jobs to jenkins, macro for future use." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102598 (owner: 10Krinkle) [02:37:20] (03Merged) 10jenkins-bot: Add '{name}-{ext-name}-phplint' job template [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102598 (owner: 10Krinkle) [02:40:31] (03CR) 10Jforrester: "Is this still valid? It's been a year sitting un-merged (because it was V+1'ed not V+2'ed)…" [wikimedia/communications/WP-Victor] - 10https://gerrit.wikimedia.org/r/29831 (owner: 10Guillom) [02:42:15] (03PS2) 10Krinkle: Fixed bug where variables referenced where not reachable (out of scope) [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/97902 (owner: 10Netbrain) [02:43:15] (03CR) 10Krinkle: [C: 032] "(re-applying earlier +2 during Zuul outage)" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/102552 (owner: 10MegaAlex) [02:43:19] (03Merged) 10jenkins-bot: I18N: Should have a capital letter after the colon [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/102552 (owner: 10MegaAlex) [03:11:22] (03PS2) 10Legoktm: Kill uneeded global variable [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/88482 [03:11:40] (03CR) 10Legoktm: Kill uneeded global variable (031 comment) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/88482 (owner: 10Legoktm) [03:11:46] (03PS3) 10Legoktm: Kill uneeded global variable [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/88482 [03:13:07] (03PS4) 10Springle: Add index on logging.log_user_text [core] - 10https://gerrit.wikimedia.org/r/85508 (owner: 10Jackmcbarn) [03:17:58] (03CR) 10Hoo man: [C: 032] Kill uneeded global variable [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/88482 (owner: 10Legoktm) [03:18:00] (03Merged) 10jenkins-bot: Kill uneeded global variable [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/88482 (owner: 10Legoktm) [03:18:13] (03CR) 10Springle: [C: 032] "Schema changes done." [core] - 10https://gerrit.wikimedia.org/r/85508 (owner: 10Jackmcbarn) [03:22:37] springle: thanks! [03:23:50] jackmcbarn: np. sorry it took so long [03:24:31] (03CR) 10Legoktm: "Ping?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90688 (owner: 10Legoktm) [03:24:39] yeah, thats fine. im just glad i got it through at all [03:27:24] hoo: wanna look at https://gerrit.wikimedia.org/r/#/c/92051/ ? it's pretty simple [03:27:56] legoktm: that one caught a -1 :/ [03:28:13] oh, blegh. [03:28:21] His proposed solution didn't really work either... [03:28:30] hoo: maybe https://gerrit.wikimedia.org/r/#/c/92053/ then? :D [03:29:15] oh that, I already reviewed it (forgot to +1), but didn't test [03:31:39] (03CR) 10Hoo man: [C: 031] "Didn't test, but looks good." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92053 (owner: 10Legoktm) [03:35:49] (03PS3) 10Legoktm: Add handler for GetLogTypesOnUser hook [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/95097 [03:36:52] (03Abandoned) 10Legoktm: Return an empty array if there are no page properties [core] - 10https://gerrit.wikimedia.org/r/96951 (owner: 10Legoktm) [03:38:52] (03CR) 10Krinkle: [C: 04-1] "What is the rationale for introducing skins.common and renaming the skins.* modules? That seems unrelated? Or does the VectorBeta need it?" [core] - 10https://gerrit.wikimedia.org/r/99524 (owner: 10Jdlrobson) [03:39:56] (03CR) 10Mattflaschen: [C: 032] "Works locally" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/95097 (owner: 10Legoktm) [03:40:04] (03Merged) 10jenkins-bot: Add handler for GetLogTypesOnUser hook [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/95097 (owner: 10Legoktm) [03:44:32] (03CR) 10Legoktm: [C: 031] "Untested." [core] - 10https://gerrit.wikimedia.org/r/100563 (owner: 10Daniel Kinzler) [03:45:46] (03CR) 10Krinkle: [C: 032] "Pushed VisualEditor-jslint, VisualEditor-npm, and VisualEditor-ruby1.9.3lint to Jenkins." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102587 (owner: 10Krinkle) [03:46:05] (03Merged) 10jenkins-bot: Add jobs for VisualEditor.git [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102587 (owner: 10Krinkle) [03:48:28] (03PS1) 10Krinkle: Enable VisualEditor/VisualEditor jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102619 [03:49:04] * AaronSchulz pulls some hairs at bug 58094 [03:49:21] (03CR) 10Krinkle: [C: 032] Enable VisualEditor/VisualEditor jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102619 (owner: 10Krinkle) [03:49:28] (03Merged) 10jenkins-bot: Enable VisualEditor/VisualEditor jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102619 (owner: 10Krinkle) [03:49:56] (03CR) 10Legoktm: [C: 032 V: 032] Typofix and dummy README [tools/grabbers] - 10https://gerrit.wikimedia.org/r/101832 (owner: 10Nemo bis) [03:50:00] (03PS2) 10Jackmcbarn: Allow searching for IPs' logs [core] - 10https://gerrit.wikimedia.org/r/85436 [03:50:19] can someone mark https://bugzilla.wikimedia.org/show_bug.cgi?id=54432 fixed? [03:51:14] jackmcbarn: you should ask andre for editbugs [03:51:18] (and done) [03:51:22] k [03:51:50] (03PS1) 10Aaron Schulz: Added a MemoryFileBackend class and made MockFileBackend subclass it [core] - 10https://gerrit.wikimedia.org/r/102621 [03:55:09] (03CR) 10Legoktm: [C: 04-1] Default to HTML5 player instead of Flash Player. (031 comment) [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/101672 (owner: 10Jack Phoenix) [03:56:04] (03CR) 10Legoktm: [C: 04-1] "Needs rebase." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/95647 (owner: 10Addshore) [04:00:42] (03PS8) 10Brian Wolff: Special:ListGroupRights: Add per-namespace restrictions and rights [core] - 10https://gerrit.wikimedia.org/r/40096 (owner: 10Alex Monk) [04:09:46] (03CR) 10Jdlrobson: "Please take the time to look at and understand the dependency mentioned in the commit. A -1 seems unfair." [core] - 10https://gerrit.wikimedia.org/r/99524 (owner: 10Jdlrobson) [04:19:08] (03CR) 10Brian Wolff: [C: 04-1] "Sorry, gerrit's UI is stupid, and I left half my comments on PS7 and half on PS8." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/40096 (owner: 10Alex Monk) [04:19:32] (03CR) 10Brian Wolff: "Sorry, left half my comments on PS7 and half on PS8" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/40096 (owner: 10Alex Monk) [04:34:46] (03CR) 10Brian Wolff: Special:ListGroupRights: Add per-namespace restrictions and rights (031 comment) [core] - 10https://gerrit.wikimedia.org/r/40096 (owner: 10Alex Monk) [04:50:52] am i correct in thinking that https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28proposals%29#Template_vandalism_with_images would require solving the halting problem? [04:50:57] (03CR) 10Legoktm: [C: 04-1] Allow searching for IPs' logs (031 comment) [core] - 10https://gerrit.wikimedia.org/r/85436 (owner: 10Jackmcbarn) [04:51:25] jackmcbarn: http://xkcd.com/1266/ [04:51:52] in seriousness, though. whether a template will result in an image loading or not is harder to solve than the halting problem? [04:52:23] (03CR) 10Jackmcbarn: Allow searching for IPs' logs (031 comment) [core] - 10https://gerrit.wikimedia.org/r/85436 (owner: 10Jackmcbarn) [04:52:28] Easier then the halting problem [04:52:37] Still hard enough that its not going to happen [04:52:56] or actually no. we have lua now [04:53:02] yeah, was just going to say that [04:54:23] legoktm: re my gerrit change, "that's not a bug; it's a feature!" [04:54:32] Anyhow, shock images are hardly a new thing [04:54:56] I think people are overreacting, the bot we have in -en-admins is actually doing a pretty great job at pinging us when someone vandalizes. [04:56:17] (03CR) 10Legoktm: Allow searching for IPs' logs (031 comment) [core] - 10https://gerrit.wikimedia.org/r/85436 (owner: 10Jackmcbarn) [04:57:55] If I remember correctly, one of the first conversations I ever stumbled upon on wikipedia was an argument over someone replacing the main page with a shock image, combined with the servers falling over at the same time so the wiki was read only for an hour, which just happened to combine with some teacher showing wikipedia to a bunch of third graders [05:00:23] TimStarling: can't believe it took you this long to comment on acupuncture...the old tim would have jumped on that [05:01:03] yeah, I'm not spending enough time reading staff lists these days [05:01:26] I read that whole thread just now and commented on it immediately [05:02:16] I borrowed those three links from a facebook comment I wrote 6 months ago [05:03:30] (03CR) 10Legoktm: [C: 032] Grammar and consistency in English messages [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/38904 (owner: 10Amire80) [05:03:36] (03Merged) 10jenkins-bot: Grammar and consistency in English messages [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/38904 (owner: 10Amire80) [05:06:37] in Sirens Of Titan, a man has an accident and becomes omniscient as a result, knowing past and future and the consequences of his actions [05:07:06] so, he sets up a religion which unifies mankind and ends all war [05:07:12] called "Church of God the Utterly Indifferent" [05:16:01] (03CR) 10Legoktm: Allow InputBoxes to be used to move pages (031 comment) [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/97559 (owner: 10Jackmcbarn) [05:23:59] (03PS1) 1001tonythomas: Reworded 'Incorrect or missing confirmation code' CAPTCHA message [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/102623 [05:38:03] (03PS1) 10PleaseStand: Correct patch filenames in MysqlUpdater [core] - 10https://gerrit.wikimedia.org/r/102624 [05:39:12] (03CR) 10PleaseStand: Add index on logging.log_user_text (031 comment) [core] - 10https://gerrit.wikimedia.org/r/85508 (owner: 10Jackmcbarn) [05:43:01] (03CR) 10Mattflaschen: [C: 032] "Everything looks good locally, including the rate limit." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 (owner: 10Legoktm) [05:43:12] (03Merged) 10jenkins-bot: Add Special:Thanks as a non-JS fallback [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 (owner: 10Legoktm) [05:43:23] superm401: woo thanks! [05:43:42] legoktm, no problem. [05:44:40] legoktm, might be worth of putting on https://meta.wikimedia.org/wiki/Tech/News/Next [05:44:43] Up to you [05:44:49] sure [05:47:05] https://meta.wikimedia.org/w/index.php?title=Tech%2FNews%2F2013%2F51&diff=6784163&oldid=6778574 [05:48:15] (03PS6) 10Brian Wolff: Fix slightly broken behaviour with suppressed revisions on Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/40283 (owner: 10Alex Monk) [05:48:34] legoktm, thanks. ;0 [05:50:04] bawolff: https://commons.wikimedia.org/wiki/Commons:Village_pump#December_5_image_loss.3F \o/ [05:50:31] Aaron|home: Woo, thanks for looking into that [05:51:45] odd that the file changes must have had a bad status, yes the DB changes went though... [06:07:54] (03CR) 10PleaseStand: Script to convert PHP i18n to JSON (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102171 (owner: 10Catrope) [06:17:20] (03CR) 10BryanDavis: [C: 032] Remove trailing whitespace in messages [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102490 (owner: 10Siebrand) [06:17:26] (03Merged) 10jenkins-bot: Remove trailing whitespace in messages [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102490 (owner: 10Siebrand) [06:18:13] (03PS2) 10BryanDavis: Add some translations for Dutch [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102489 (owner: 10Siebrand) [06:18:22] (03CR) 10BryanDavis: [C: 032] Add some translations for Dutch [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102489 (owner: 10Siebrand) [06:18:26] (03Merged) 10jenkins-bot: Add some translations for Dutch [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102489 (owner: 10Siebrand) [06:20:02] (03PS3) 10Bsitu: Improve findMulti() for BasicDbStorage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102599 [06:20:19] (03CR) 10Brian Wolff: [C: 04-1] "PS6: rebase" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/40283 (owner: 10Alex Monk) [06:24:52] (03PS1) 10EBernhardson: base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 [06:24:54] (03CR) 10jenkins-bot: [V: 04-1] base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 (owner: 10EBernhardson) [06:28:24] (03PS1) 10BryanDavis: Clean up en messages and usage [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102627 [06:28:56] (03PS2) 10BryanDavis: Clean up en messages and usage [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102627 [06:39:29] * bawolff wonders why the features team is now being called the "core features" team [06:39:44] Given that they don't actually work on core, that just seems bound to cause confusion [06:40:18] (03PS1) 10BryanDavis: Add qqq i18n file to provide translation hints [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102628 [06:43:37] bawolff: there's also Growth which is is not the only one working on growth [06:45:04] but Features still exist, it's a superset :) CF was called EE [06:45:05] We should rename all wmf teams to e [06:46:01] If you take the dictionary definition of what I think the words "core features" mean, you end up with what platform does (imo) [06:48:44] Hmm, I'm not sure that I really like the flow demo [06:48:51] everything seems kind of busy [06:49:03] and random things keep appearing on hover which is distracting [06:49:14] and it doesn't work on older browsers [06:50:03] https://gerrit-review.googlesource.com/53311 [06:50:33] (03CR) 10Siebrand: [C: 032] "Great job, Mr. Davis!" [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102628 (owner: 10BryanDavis) [06:50:37] (03Merged) 10jenkins-bot: Add qqq i18n file to provide translation hints [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102628 (owner: 10BryanDavis) [06:50:37] and the typography looks all out of place [06:51:09] yurik [06:51:22] you can help improving the note at top of https://www.mediawiki.org/wiki/Core_features btw [06:53:25] (03CR) 10Siebrand: [C: 032] Reworded 'Incorrect or missing confirmation code' CAPTCHA message [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/102623 (owner: 1001tonythomas) [06:53:27] (03Merged) 10jenkins-bot: Reworded 'Incorrect or missing confirmation code' CAPTCHA message [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/102623 (owner: 1001tonythomas) [06:53:45] My idea of improvement involves Special:MovePage [06:53:54] but I don't think that would go over too well [06:55:58] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100524 (owner: 10Bsitu) [06:58:10] bawolff: also Special:MoveChannel for #wikimedia-corefeatures ;) [06:59:22] Oh good, an irc channel named #wikimedia-corefeatures to discuss features embodied in two non-core extensions :) [06:59:46] otherwise it would be #mediawiki-corefeatures, clearly [07:00:25] obviously [07:00:47] this is not helpful https://en.wiktionary.org/wiki/Special:Search?search=core&ns110=1&fulltext=Search+Wikisaurus [07:01:08] I need a synonym and an analogical dictionary of English, online resources are so unhelpful [07:03:17] Nemo_bis: WMF drywall team sounds fine to me [07:07:06] Nemo_bis: I think calling them the "User interaction" team might be good [07:07:28] They work on things like AFT, echo, flow, and page triage [07:07:42] bawolff: no one works on AFT or page triage. [07:08:00] Its listed on their page as what they did in the past [07:08:37] https://gerrit.wikimedia.org/r/#/c/94403/ :( [07:09:22] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/101499 (owner: 10Apsdehal) [07:09:26] yeah, in the past. they're somewhat abandoned now though [07:09:57] Well you know, features create, and nobody maintains unless it becomes super broken and then platform steps in ;) [07:10:23] WMF needs a better new feature maintenance plan imo [07:10:41] Something better than the current abandon it procedure [07:11:26] agreed [07:15:40] bawolff: I've identified the same issue internally in the Product management department. [07:15:51] bawolff: There's no solution yet. [07:16:00] legoktm: https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/PageTriage,dashboards/default has different results then https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/PageTriage+status:open,n,z [07:16:21] dashboard is just recent stuff [07:16:27] bawolff: In LangEng, I do see it as our team's responsibility to maintain previously delivered functionality, but it's always competing with development of new features. [07:16:37] siebrand: To be honest, my opinion has largely been formed by hearing WMF people complain [07:16:50] bawolff: They're not wrong :) [07:17:32] legoktm: Another good example of gerrit usability :) [07:17:33] Truth is, it's possible to tinker with delivered feature literally forever. [07:17:47] At some point, it's declared good enough, and we move on. [07:18:11] http://www.agilemodeling.com/essays/barelyGoodEnough.html [07:18:44] siebrand: There's certainly a balance to be achieved there [07:18:52] I do think that backlog refinement of delivered features could decrease the number of crises that surface. [07:20:34] bawolff: I think it just means Features - Main [07:21:37] siebrand: there's also the bigger issue of features being developed for enwiki and then getting deployed elsewhere and not working properly, but no one is left working on it (or worse, not getting deployed anywhere else) [07:21:56] but that's a much older issue too. [07:21:57] legoktm: I prefer to not comment on that. [07:22:06] :) [07:22:39] (imho) There seems to be a problem with the "features" team sometimes thinking that enwiki is the only wiki in the world [07:22:50] For example, with PageTriage [07:23:10] Which is so very tied to the social conventions of enwiki [07:23:35] My suggestion is to raise this issue on wikitech-l. I would very much support and encourage that discussion. [07:24:11] I've suggested a few times that features be developed and implemented first on non-English language projects for several reasons. [07:24:45] Which is not only bad for not being deployable on other wikis, but social conventions change over time, things hard coded in the php will probably not change with them [07:25:13] (03PS1) 10Ori.livneh: Fix round-off error in Vector's collapsibleTabs.js [core] - 10https://gerrit.wikimedia.org/r/102632 [07:25:32] In part, this is also being resolved by WMF getting better at product management for more recent projects. [07:26:12] I think the search project is a pretty good example of what to do [07:28:41] relatedly, https://www.mediawiki.org/wiki/Thread:Project_talk:New_contributors/English_Wikipedia_first (now abandoned idea, was mainly food for thought I think) [07:29:11] (03PS4) 10Apsdehal: Added i18n functions and messages to PageSchemas [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/101499 [07:30:06] Hah! Got it, should be called "Quick Features" or "Inner space Features" http://www.merriam-webster.com/thesaurus/core [07:31:39] "Soul features" [07:33:36] this word must have a good story to tell https://en.wiktionary.org/wiki/brunt [07:35:35] maybe "Essential features" is excessive; "Chief features" sort of, but confusing with personal titles; "Central features" would be closer to what they meant, they're new features for everyone, like a central square everyone walks in, as opposed to marginal areas of the interface [07:37:24] (03CR) 1001tonythomas: [C: 031] Removed indentation button from WikiEditor toolbar. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/94500 (owner: 10Tinaj1234) [07:38:19] Nemo_bis: omphalos-features. Nobody would know what it means; everyone wins! [07:39:22] (03PS6) 10Apsdehal: Updated Special:GlobalUsers to show creation date of global user account [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 [07:40:33] (03CR) 10Nikerabbit: "This might just work as those two messages don't have any translations, though I'm not a fan of this solution for the issue." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/100534 (owner: 10Mattflaschen) [07:41:25] "world was created with certain indicia of a history which had not actually occurred" [07:41:31] sounds like Flow, indeed [07:41:34] APPROVED [07:46:58] (03CR) 10Nikerabbit: [C: 031] "I've encountered this once." [core] - 10https://gerrit.wikimedia.org/r/102632 (owner: 10Ori.livneh) [08:05:36] (03CR) 10Spage: [C: 031] "Looks good, a few minor comment comments." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/98990 (owner: 10Jdlrobson) [08:22:10] (03PS16) 10Legoktm: Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 [08:22:12] (03CR) 10jenkins-bot: [V: 04-1] Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (owner: 10Legoktm) [08:22:21] (03CR) 10Legoktm: Allow for global renaming of users (035 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (owner: 10Legoktm) [08:24:05] (03PS17) 10Legoktm: Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 [08:28:22] (03CR) 10Spage: "More comment comments. The missing skin CSS and shared.css in the generated style guide are a problem." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/98990 (owner: 10Jdlrobson) [08:31:03] (03PS1) 10Legoktm: Autocreate global account after rename [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/102635 [08:42:40] (03CR) 10Legoktm: [C: 032] "The wording in the master branch is a little different, but that's fine I guess." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102163 (owner: 10Tinaj1234) [08:45:48] (03Merged) 10jenkins-bot: Corrected memcached.txt in MediaWiki 1.22 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102163 (owner: 10Tinaj1234) [08:48:33] (03CR) 10Ori.livneh: [C: 032] Correct patch filenames in MysqlUpdater [core] - 10https://gerrit.wikimedia.org/r/102624 (owner: 10PleaseStand) [08:51:36] (03Merged) 10jenkins-bot: Correct patch filenames in MysqlUpdater [core] - 10https://gerrit.wikimedia.org/r/102624 (owner: 10PleaseStand) [09:02:40] (03CR) 10Ori.livneh: [C: 032] "Hey, awesome. Works like a charm. Thanks for the patch." [vagrant] - 10https://gerrit.wikimedia.org/r/102592 (owner: 10CSteipp) [09:02:45] (03Merged) 10jenkins-bot: Add OAuth as a role [vagrant] - 10https://gerrit.wikimedia.org/r/102592 (owner: 10CSteipp) [09:14:48] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (owner: 10Legoktm) [09:23:33] (03CR) 10Siebrand: "I'm inclined to draw the line somewhere adding more stuff that clutters pages like these in their current form. I don't know if I should d" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 (owner: 10Apsdehal) [09:25:19] (03CR) 10Nemo bis: [C: 04-1] "You also need to remove it from includes/DefaultSettings.php don't you?" [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas) [09:43:02] (03CR) 10Hashar: "thanks for the revert Timo" (031 comment) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102579 (owner: 10Krinkle) [09:44:25] (03PS1) 10Hashar: blacklist l10n-bot [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102636 [09:44:56] (03CR) 10Hashar: "I will have one day to write some integration tests for us :D" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102636 (owner: 10Hashar) [09:49:34] (03CR) 10Siebrand: [C: 04-1] Added i18n functions and messages to PageSchemas (031 comment) [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/101499 (owner: 10Apsdehal) [09:56:15] (03PS1) 10Siebrand: Only variables should be passed by reference [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/102637 [10:14:09] (03PS3) 10Umherirrender: Store timestamp, user and reason for page protections in the db [core] - 10https://gerrit.wikimedia.org/r/98175 [10:14:45] (03CR) 10Umherirrender: "Patch Set 3: rebased and resolve conflicts" [core] - 10https://gerrit.wikimedia.org/r/98175 (owner: 10Umherirrender) [10:16:52] (03Abandoned) 10Umherirrender: Fix redirect detection on image page's "file usages" section [core] - 10https://gerrit.wikimedia.org/r/85517 (owner: 10Umherirrender) [10:21:38] Nemo_bis: wrt your comments on https://gerrit.wikimedia.org/r/#/c/99171/ , I cant understand why the editsection codes needs to be removed from includes/parser/Parser.php or other Parse files. I am removing just the section editing via [links] only right ? in bug: 52811 [10:24:07] (03CR) 10Hashar: "Hi Aaron," (035 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/102603 (owner: 10Aarcos) [10:26:48] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Add .gitreview [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/102570 (owner: 10Raimond Spekking) [10:37:39] (03CR) 1001tonythomas: "@Nemo Bis: I removed it from includes/DefaultSettings.php." [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas) [10:48:08] (03CR) 10Apsdehal: Added i18n functions and messages to PageSchemas (031 comment) [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/101499 (owner: 10Apsdehal) [10:58:37] tonythomas01: I don't know [11:05:41] (03PS2) 10Hashar: jobs for new repo mediawiki/services/parsoid [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101912 (owner: 10Subramanya Sastry) [11:05:52] (03CR) 10Hashar: jobs for new repo mediawiki/services/parsoid (038 comments) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101912 (owner: 10Subramanya Sastry) [11:06:32] (03PS3) 10Hashar: jobs for new repo mediawiki/services/parsoid [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101912 (owner: 10Subramanya Sastry) [11:06:58] (03CR) 10Hashar: "rebased, listed jobs created in commit summary." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101912 (owner: 10Subramanya Sastry) [11:09:22] (03PS1) 10Gerrit Patch Uploader: Change system message "Wminc-search-nocreate-suggest" for English. [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/102639 [11:09:40] (03PS5) 10Hashar: Add Jenkins tests for commits to new Parsoid repo [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/101460 (owner: 10Subramanya Sastry) [11:11:36] (03CR) 10Hashar: Add Jenkins tests for commits to new Parsoid repo (032 comments) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/101460 (owner: 10Subramanya Sastry) [11:11:46] (03PS6) 10Hashar: Add Jenkins tests for commits to new Parsoid repo [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/101460 (owner: 10Subramanya Sastry) [11:13:17] (03PS4) 10Hashar: jobs for new repo mediawiki/services/parsoid [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101912 (owner: 10Subramanya Sastry) [11:13:40] (03CR) 10Hashar: "added in a call to '{name}-jslint' to generate the parsoidsvc-jslint job." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101912 (owner: 10Subramanya Sastry) [11:14:11] (03CR) 10Hashar: "dropped the php jobs and the one starting with mwext-Parsoid." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/101460 (owner: 10Subramanya Sastry) [11:15:23] (03PS7) 10Hashar: Add Jenkins tests for commits to new Parsoid repo [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/101460 (owner: 10Subramanya Sastry) [11:16:07] (03CR) 10Hashar: [C: 032] "PS7 made the job non voting so they are not going to block any development. Deploying this and will amend later on as needed." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/101460 (owner: 10Subramanya Sastry) [11:16:12] (03Merged) 10jenkins-bot: Add Jenkins tests for commits to new Parsoid repo [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/101460 (owner: 10Subramanya Sastry) [11:24:37] (03PS5) 10Hashar: jobs for new repo mediawiki/services/parsoid [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101912 (owner: 10Subramanya Sastry) [11:26:02] (03CR) 10Hashar: "PS5 fix a typo :-D" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101912 (owner: 10Subramanya Sastry) [11:29:37] (03CR) 10Siebrand: Added i18n functions and messages to PageSchemas (031 comment) [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/101499 (owner: 10Apsdehal) [11:31:05] (03CR) 10Siebrand: "This caused bug 58684 with a proposed fix in https://gerrit.wikimedia.org/r/#/c/102637/" [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/88482 (owner: 10Legoktm) [11:31:51] (03PS2) 10Siebrand: Only variables should be passed by reference [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/102637 [11:33:51] (03CR) 10Siebrand: [C: 032] Fix the wording in 'edit post' notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102607 (owner: 10Bsitu) [11:33:58] (03Merged) 10jenkins-bot: Fix the wording in 'edit post' notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102607 (owner: 10Bsitu) [11:34:32] (03PS2) 10Siebrand: Bug 58676: Added logging for "Invalid message parameter" [core] - 10https://gerrit.wikimedia.org/r/102604 (owner: 10Yurik) [11:43:51] (03CR) 10Edokter: [C: 031] "Re: inline comment; what I ment is if expressions are allowed in a case statement. They apparently are, but this works just as well." [core] - 10https://gerrit.wikimedia.org/r/96239 (owner: 10Bartosz Dziewoński) [12:20:28] (03CR) 10Hydriz: [C: 031] "Verified. $2 is actually mapped to Message::numParam( $num ) in SpecialSearch.php, but in this case it was intended for providing a link t" [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/102639 (owner: 10Gerrit Patch Uploader) [12:33:44] (03PS1) 10Siebrand: Update docs for Revision::getRevisionText() [core] - 10https://gerrit.wikimedia.org/r/102655 [13:36:06] just got "An error has occurred while searching: Pool queue is full" on en.wp, when searching [13:36:28] oops I think that should be for #wikimedia-tech instead [13:48:34] (03CR) 10Nikerabbit: Script to convert PHP i18n to JSON (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102171 (owner: 10Catrope) [13:56:09] (03PS1) 10Matthias Mullie: (bug 58645) Merge RecentChanges & Contributions' formatters extend from 1 same base class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102674 [14:15:42] (03PS1) 10Matthias Mullie: Get rid of 'Talk to User' link for moderated posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102676 [14:18:29] (03CR) 10Siebrand: [C: 031] "Trivial i18n changes." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102676 (owner: 10Matthias Mullie) [14:23:59] (03PS1) 10Ebrahim: i18n: Make LogEventsList user language direction aware [core] - 10https://gerrit.wikimedia.org/r/102677 [14:28:19] Hello. :) [14:32:45] (03PS1) 10Raimond Spekking: Consistency tweaks in preparatation for adding extension to translatewiki.net [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/102679 [14:39:24] (03CR) 10Anomie: "Code change seems good, but I'm not sure about the comment suggesting re-adding it at any particular point." [core] - 10https://gerrit.wikimedia.org/r/102557 (owner: 10Yurik) [14:50:47] (03CR) 10Anomie: [C: 04-1] "If other conditions are also included (e.g. an uncommon log_type, or a log_namespace+log_title for some page without an extreme number of " (031 comment) [core] - 10https://gerrit.wikimedia.org/r/85436 (owner: 10Jackmcbarn) [14:55:02] (03PS4) 10Cmcmahon: Less specific button selectors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102544 (owner: 10Spage) [14:55:59] (03CR) 10Cmcmahon: [C: 032] "fixed merge conflict" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102544 (owner: 10Spage) [14:58:40] (03PS1) 10Siebrand: Add special page group for AdminLinks [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/102686 [15:03:03] (03CR) 10Bartosz Dziewoński: Add ability to generate KSS files for mediawiki.ui (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98990 (owner: 10Jdlrobson) [15:03:04] (03CR) 10Anomie: [C: 04-1] Autocreate global account after rename (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/102635 (owner: 10Legoktm) [15:04:36] (03CR) 10Siebrand: [C: 032] Add special page group for AdminLinks [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/102686 (owner: 10Siebrand) [15:04:38] (03Merged) 10jenkins-bot: Add special page group for AdminLinks [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/102686 (owner: 10Siebrand) [15:27:47] (03CR) 10Jackmcbarn: Allow InputBoxes to be used to move pages (031 comment) [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/97559 (owner: 10Jackmcbarn) [15:28:01] (03PS11) 10Gergő Tisza: licenseInput: Handle redirects for license templates [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50755 (owner: 10Nischayn22) [15:28:03] (03CR) 10jenkins-bot: [V: 04-1] licenseInput: Handle redirects for license templates [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50755 (owner: 10Nischayn22) [15:30:27] Working on this bug - https://bugzilla.wikimedia.org/show_bug.cgi?id=56267, I have to edit the parameter '$1' inside the UploadWizard.i18n.php of the UploadWizard extenstion. But, I am finding the $1, $2 and $3 usage in the file confusing. Where is the value of these variables defined ? [15:30:52] tonythomas01: Those get passed into the message building functions [15:31:25] (03CR) 10Jackmcbarn: "It should be indexed. https://gerrit.wikimedia.org/r/#/c/85508/ just got merged." [core] - 10https://gerrit.wikimedia.org/r/85436 (owner: 10Jackmcbarn) [15:31:26] (03PS12) 10Gergő Tisza: licenseInput: Handle redirects for license templates [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50755 (owner: 10Nischayn22) [15:31:54] marktraceur: But, where is the values defined for the same ? I did find a lot of $1 ,$2 and $3, but where is it defined ? [15:31:59] tonythomas01: When we use a message, we do something like mw.message( 'my-message-name' ).text(). If there's a $1 in the message, we can set its value by doing mw.message( 'my-message-name', 'aoeu' ).text(), and $1 will be replaced by 'aoeu' [15:32:08] (03CR) 10Gergő Tisza: "Rebased old code." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50755 (owner: 10Nischayn22) [15:33:58] (03PS13) 10Gergő Tisza: licenseInput: Handle redirects for license templates [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50755 (owner: 10Nischayn22) [15:34:21] (03CR) 10Gergő Tisza: "Typo." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50755 (owner: 10Nischayn22) [15:34:32] Yay. [15:34:44] tonythomas01: I hope that was helpful [15:37:07] (03CR) 10Bartosz Dziewoński: [C: 032] "I have just spent the last 15 minutes looking like an idiot trying to move my mouse by a micrometer to reproduce this and failed miserably" [core] - 10https://gerrit.wikimedia.org/r/102632 (owner: 10Ori.livneh) [15:38:46] (03CR) 10Bartosz Dziewoński: "We could kill the mw.loader.using( 'ext.wikiLove.local' ) then, no?" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/100338 (owner: 10Legoktm) [15:39:51] marktraceur: so a $1 just gets the value that we pass from some other function as a side argument ? [15:40:15] (03Merged) 10jenkins-bot: Fix round-off error in Vector's collapsibleTabs.js [core] - 10https://gerrit.wikimedia.org/r/102632 (owner: 10Ori.livneh) [15:40:37] tonythomas01: Yes :) it's sort of like declaring a function's parameters in a string. [15:40:55] The zeroth parameter will always be the message name, so we aren't allowed to use that [15:41:08] But we can start defining the rest of them. [15:41:23] (03CR) 10Anomie: "Ah, ok. Note the schema change needs to be deployed to WMF wikis' databases (if it hasn't already?) before this may be merged." [core] - 10https://gerrit.wikimedia.org/r/85436 (owner: 10Jackmcbarn) [15:41:50] (03CR) 10Jackmcbarn: "It already has been." [core] - 10https://gerrit.wikimedia.org/r/85436 (owner: 10Jackmcbarn) [15:44:44] (03CR) 10Anomie: "Well, at least log_user_text_time has been, at least to enwiki. The logging table on enwiki is currently still missing log_user_text_type_" [core] - 10https://gerrit.wikimedia.org/r/85436 (owner: 10Jackmcbarn) [15:45:37] (03CR) 10Jackmcbarn: "Hmm. Poking Springle." [core] - 10https://gerrit.wikimedia.org/r/85436 (owner: 10Jackmcbarn) [15:46:07] (03PS1) 10Siebrand: Special special page group for ExpandTemplates [core] - 10https://gerrit.wikimedia.org/r/102701 [15:46:08] (03PS1) 10Siebrand: Change special page group for BookSources [core] - 10https://gerrit.wikimedia.org/r/102702 [15:46:28] (03PS2) 10Siebrand: Change special page group for BookSources [core] - 10https://gerrit.wikimedia.org/r/102702 [15:46:36] marktraceur: so, that means that the $1 is not getting declared in the UploadWizard.i18n.php file right ? [15:48:48] tonythomas01: Correct. [15:52:41] (03PS1) 10Bartosz Dziewoński: vector: Switch around regular and HD content padding [core] - 10https://gerrit.wikimedia.org/r/102703 [15:54:27] (03CR) 10BryanDavis: "I understand the need for a guard against the infinite loop lookup problem, but I'm not sure I understand the point of logging that a loop" [core] - 10https://gerrit.wikimedia.org/r/102557 (owner: 10Yurik) [15:59:04] (03CR) 10Bartosz Dziewoński: Integrate feed-specific setup into general setup (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96070 (owner: 10Poke) [16:00:36] (03CR) 10Jhall: "It might be helpful to add a "requirements.txt" file to capture the dependencies (poster and wikitools), similar to what we do with "Gemfi" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/102603 (owner: 10Aarcos) [16:01:35] (03CR) 10Anomie: "The recursion guard was added in Idc11b547 as an uncaught exception. I2e8c0627 changed it to log with the current fallback behavior. I don" [core] - 10https://gerrit.wikimedia.org/r/102557 (owner: 10Yurik) [16:03:31] (03CR) 10Siebrand: "Raimond, there is more wrong here. Please don't add support until resolved." (034 comments) [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/102679 (owner: 10Raimond Spekking) [16:05:22] (03CR) 10Raimond Spekking: "Siebrand: I know, see my TODOs in the commit message. Let's fix it in the iterative way :-)" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/102679 (owner: 10Raimond Spekking) [16:14:18] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Final minor comments. Thanks!" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96070 (owner: 10Poke) [16:15:16] (03CR) 10Legoktm: [C: 032] "Thanks!" [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/102637 (owner: 10Siebrand) [16:15:19] (03Merged) 10jenkins-bot: Only variables should be passed by reference [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/102637 (owner: 10Siebrand) [16:23:05] (03CR) 10Gergő Tisza: [C: 04-1] "I don't like the way promises are used here; rejecting one should be like throwing an exception, a validation fail could be better handled" (034 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/50755 (owner: 10Nischayn22) [16:28:07] (03PS3) 10Legoktm: Load ext.wikiLove.local from PHP [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/100338 [16:28:13] (03CR) 10Legoktm: "Done in PS3." [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/100338 (owner: 10Legoktm) [16:30:59] (03PS4) 10Poke: Integrate feed-specific setup into general setup [core] - 10https://gerrit.wikimedia.org/r/96070 [16:32:39] (03CR) 10Poke: "(rebased on master)" [core] - 10https://gerrit.wikimedia.org/r/96070 (owner: 10Poke) [16:34:57] legoktm: huh, i'm actually looking at the code now and wondering wtf is that file for? [16:35:14] local customizations [16:35:23] it just loads MediaWiki:Wikiove.js [16:35:53] https://en.wikipedia.org/wiki/MediaWiki:WikiLove.js so enwiki has more kittens then the default [16:36:06] woot. [16:37:06] (03CR) 10Gergő Tisza: "Tested, works." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/101029 (owner: 10Inchikutty) [16:37:16] And I have no clue why the init.js script exists, but I don't want to fall in the hole of starting to fix that extension >.> [16:38:28] php question: Are instance variables, that are not explicitely initialized, null by default? [16:38:40] yes [16:38:41] yeah, that's some weird stuff [16:38:49] poke`: yes, but please declare them always :) [16:39:05] (ah, or did you mean actual initialization– okay.) [16:39:32] legoktm: oh wow, i looked at /modules/ext.wikiLove/ext.wikiLove.core.js and there's a commented-out 100-line block of code in there [16:40:37] MatmaRex: I mean initialization; it's declared as a protected variable, and I want to know if it's null by default or if I should write `protected $feedFormat = null;` ;) [16:41:04] it'll be null then [16:41:07] yeah, i understood now :) [16:41:12] i'd be explicit, but both ways are fine [16:41:25] Alright :) [16:41:30] legoktm: hmm, that file was added by krinkle [16:41:32] 5fba53846efdf1302232689553fbb5ce53b06f08 [16:41:47] it explicitly mentions "Loading local config with mw.loader.using instead of a dependancy in the module definition." as a solution to some stuff [16:41:54] :o [16:42:11] "I made an attempt to re-implement a local config that doesn't require declaring all of the options, and doesn't require the init-call to be part of the local config (which is dangerous. one syntax error and it wont init at all)." [16:42:18] (03CR) 10Reedy: [C: 032] Make legend on Special:RecentChanges and Special:Watchlist collapsible [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102487 (owner: 10Bartosz Dziewoński) [16:42:28] i have no idea if it can be safely changed back or what [16:42:35] I'll add him as a reviewer [16:42:56] ah, hmmm [16:43:00] "// Because of bug 29608 we can't make a dependancy on a wiki module yet" [16:43:04] "// For now using 'using' to load the wiki module from within init." [16:43:18] that bug was fixed apparently [16:43:25] so maybe it can be done after all [16:43:25] yeah, just found that [16:43:33] (03PS1) 10Reedy: Remove ExpandTemplates [tools/release] - 10https://gerrit.wikimedia.org/r/102706 [16:44:29] * MatmaRex lets legoktm figure this mess out [16:45:23] (03Merged) 10jenkins-bot: Make legend on Special:RecentChanges and Special:Watchlist collapsible [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102487 (owner: 10Bartosz Dziewoński) [16:46:24] (03CR) 10Legoktm: "MatmaRex noticed that this was intentionally done by Krinkle in r91083 for bug 29608 (now fixed). I've added him as a reviewer." [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/100338 (owner: 10Legoktm) [16:46:31] (03CR) 10Reedy: [C: 032] Remove ExpandTemplates [tools/release] - 10https://gerrit.wikimedia.org/r/102706 (owner: 10Reedy) [16:46:34] (03Merged) 10jenkins-bot: Remove ExpandTemplates [tools/release] - 10https://gerrit.wikimedia.org/r/102706 (owner: 10Reedy) [16:48:38] Krenair: Hi! [16:48:45] twkozlowski, hi? [16:49:01] Krenair: I don't really understand https://bugzilla.wikimedia.org/show_bug.cgi?id=37120#c2 [16:49:13] Bawolff added me to https://gerrit.wikimedia.org/r/#/c/40283/ [16:50:09] Krenair: specifically "with a link to the suppression log for the page which the revision was on instead of the suppression log for Special:Undelete." [16:51:54] twkozlowski, what don't you understand about that...? [16:52:24] I don't know what 'the suppression log for Special:Undelete' is [16:54:19] hello yurik u der? [16:55:41] "I was able to reproduce it only with all wikimedia extensions in the project(more than 1gb of code). It doesn't have an infinite loop, but make some pretty useless job of processing more than 2000 resolve results of a reference named "text" :) I limited it and inspections finished in a moment." [16:55:45] Sweet. So to find/test a bug, they checked out over 800 git repos [16:56:14] (03PS1) 10Matthias Mullie: Make condensed view more condensed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102707 [16:56:17] Reedy: Maybe they really, really wanted to help. [16:56:32] The JetBrains team are pretty good usually [16:56:36] They give us free stuff [16:56:39] So they are [16:57:29] twkozlowski, well I did write this over 18 months ago, but it seems like it was linking to Special:Log/suppress?page=Special:Undelete... [16:58:33] Krenair: Just checked a suppression I performed on Commons couple of days ago, the link's fine [16:59:04] it links to Special:Log/suppress&page=File:whatever.ext now [17:01:37] twkozlowski, it might have been on a weird URL... [17:03:28] what query params were set on the page where you saw the good link? title, target, and timestamp? [17:04:26] Krenair: it might be as well me not understanding what this is about. [17:04:35] twkozlowski, okay, I've just confirmed that the bug is still fully valid [17:04:42] you said "Special:Undelete" in the Gerrit patch subject [17:04:57] (03CR) 10Santhosh: Replacing 'show on map' button with a link (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/101029 (owner: 10Inchikutty) [17:05:13] As a sysop (NOT a suppressor), click that link and you see "This page revision has been deleted. Details can be found in the deletion log." [17:05:31] 'deletion log' is linked to https://www.mediawiki.org/w/index.php?title=Special:Log/delete&page=Special:Undelete [17:05:33] That'd work for all users, right? [17:05:57] Oh no, it doesn't. [17:06:02] MatmaRex: About the release notes thing, should I add a note that the bug is fixed too, or is that too minor to mention? [17:06:18] No, anonymous users get a generic permissions error [17:06:36] Krenair: oh, I see now, thanks [17:07:01] "One consequence of this change, is that people without suppressionlog rights would now be able to tell if a revision is normal revdeleted or suppressed" [17:07:21] They already can [17:07:50] Damn it [17:07:56] (Even if they couldn't they should be able to.) [17:08:09] Krenair: but this fixes the link for admins, or am I getting this wrong? [17:08:15] Yes [17:08:48] (03PS1) 10Reedy: Add GWToolset [tools/release] - 10https://gerrit.wikimedia.org/r/102711 [17:08:51] These users can see normal revdeleted revisions, but can't see suppressed ones. They know this revision is one of those, so it's not possible to hide the true status [17:08:58] so if I'm not an admin, I'll get thrown the usual permission error, but it'll tell me specifically that the revision was suppressed, not deleted [17:09:06] (03CR) 10Reedy: [C: 032] Add GWToolset [tools/release] - 10https://gerrit.wikimedia.org/r/102711 (owner: 10Reedy) [17:09:08] (03Merged) 10jenkins-bot: Add GWToolset [tools/release] - 10https://gerrit.wikimedia.org/r/102711 (owner: 10Reedy) [17:09:19] no, if you're not an admin it won't tell you that [17:09:26] it will only tell you that if you ARE an admin [17:09:27] (03PS1) 10MarkTraceur: Add additional awesome extensions to multimedia [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/102712 [17:09:29] tgr: ^^ [17:09:43] Krenair: oh, then it's not that big of a deal [17:09:53] James_F: Getting pinged in two channels for that patchset was not the most useful thing [17:10:00] poke`: mentioning too many things is less of an issue than not mentioning something important :) i think it's perfectly fine to include [17:10:06] I fear this will get very frustrating [17:10:14] twkozlowski, yes, that's why it's marked Low/minor and the patch has been sitting around for so long. [17:11:01] (03CR) 10Odder: "Alex tells me this will only affect the message shown to administrators, not regular users, so I can't see anything dangerous/wrong/unwant" [core] - 10https://gerrit.wikimedia.org/r/40283 (owner: 10Alex Monk) [17:11:13] marktraceur: So don't hang out in -labs? Krinkle has us being pinged for CI things in -qa and here… [17:11:18] Krenair: thanks, commented [17:11:31] marktraceur: Also, the number of patches is low enough to not be too bad. [17:12:06] *nod* [17:12:19] marktraceur: beware that if you mention a pattern only once, it will no longer go to the default [17:12:26] (03CR) 10Alex Monk: "Yeah, admins already know that this is either a revdeleted or fully suppressed revision. They can see normally revdeleted revisions, but n" [core] - 10https://gerrit.wikimedia.org/r/40283 (owner: 10Alex Monk) [17:12:29] if you want it to go to dev and another channel, you have to specifify it in both. [17:12:36] Krinkle: Aha. [17:12:39] (03PS1) 10Reedy: Re-add GWToolset [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/102713 [17:12:44] hey Nemo_bis, do you know what's the font used in Wikinews logos? [17:12:52] Don't shoot the messenger, I just noticed it the other day. [17:13:02] twkozlowski: no [17:13:16] Krinkle: Wait - https://git.wikimedia.org/commitdiff/labs%2Ftools%2Fgrrrit.git/5eb7599b5bebadb6bf8f83783874e78c981a1a5a *only* adds the grrrit line, but I see messages in both labs and here. [17:13:22] I notice there is no documentation for that, Nemo_bis. [17:13:27] Unusual. [17:13:31] marktraceur: the default is -dev [17:13:36] marktraceur: it was already listed in -labs [17:13:40] (03CR) 10Reedy: [C: 032 V: 032] Re-add GWToolset [core] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/102713 (owner: 10Reedy) [17:13:46] by adding it to -dev, it now goes to both [17:13:48] Oh, but as a less specific pattern [17:13:59] right [17:14:08] twkozlowski: yeah, those weird wikinews users [17:14:57] (03PS2) 10MarkTraceur: Add additional awesome extensions to multimedia [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/102712 [17:15:00] Krinkle: Thanks [17:15:46] Nemo_bis: qgil said we shouldn't give logos we don't know fonts for to GCI students [17:16:37] hi twkozlowski Nemo_bis I'm looking at the Wikinews scenario right now. A bit tricky. [17:17:12] https://meta.wikimedia.org/wiki/File:Wikibooks-logo-en.svg doesn't tell us what's the font used there, either [17:17:15] (03PS5) 10Poke: Integrate feed-specific setup into general setup [core] - 10https://gerrit.wikimedia.org/r/96070 [17:17:17] how useful. [17:18:41] or wait a second, I think I got it. [17:18:54] Oh, wait, yuvipanda wrote me a blank check to self-merge in that repo [17:18:56] Nearly forgot [17:20:18] qgil: so how's it going? [17:20:25] should we switch to Wikibooks for the time being? [17:20:38] twkozlowski, Nemo_bis and added complexity to Wikinews is that the English svg is not a pure replica of the PNG. Isarra worked on a better SVG logo, but we still have the problems of the font, not just which font but also that blur in the PNG: https://commons.wikimedia.org/wiki/File:Wikinews-logo-en.png [17:20:58] twkozlowski, Isarra Nemo_bis should we try to keep the blur? Blur and SVG... [17:21:07] (03CR) 10MarkTraceur: "(ignore this message)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/101029 (owner: 10Inchikutty) [17:21:09] (03CR) 10Poke: Integrate feed-specific setup into general setup (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96070 (owner: 10Poke) [17:21:28] it's more than possible to have blurred objects in SVG :-) [17:21:41] twkozlowski, possible yes, but efficient? Anyway, your call. :) [17:21:46] MatmaRex: Okay, I'm ready when you are ^^ [17:21:58] (03CR) 10MarkTraceur: [C: 032] Add additional awesome extensions to multimedia [labs/tools/grrrit] - 10https://gerrit.wikimedia.org/r/102712 (owner: 10MarkTraceur) [17:22:17] qgil: Perhaps we (and by "we" I mean "I") could create a blueprint, just like I did with the Wiktionary logo [17:22:27] qgil: and the font looks similar to Gill Sans, doesn't it. [17:23:19] twkozlowski, the Wikinews font is definitely no rocket science. I would try with Liberation Sans first, just in case it matches, only to get rid of a non-required poprietary font [17:23:35] Gill Sans is PD too [17:23:43] really? [17:23:53] since the end of 2011, yes. [17:23:55] hey [17:24:01] qgil: on a happier note, https://commons.wikimedia.org/w/index.php?diff=112172394&oldid=84457790 [17:24:50] cool, that's the favicon I updated :D [17:25:24] twkozlowski, double \o/ then! [17:25:34] twkozlowski, I shouldn't rely on https://en.wikipedia.org/wiki/Gill_Sans alone [17:26:19] qgil: You can ask the Foundation people why they keep using Gill Sans for their official logo then :) [17:27:33] twkozlowski, I was about to actually, but I have already an open front about open fonts (pun intended) with the Mobile/UX teams and I didn't want to open another one [17:27:38] If someone needs an alternative to Gill Sans, then PT Sans is pretty good [17:27:42] From the license: Permission is hereby granted, free of charge, to any person obtaining a copy of the font software, to use, study, copy, merge, embed, modify, redistribute, and sell modified and unmodified copies of the font software, subject to the following conditions: [17:27:53] So, it's free to use :) [17:28:21] Ahmad96: Gill Sans is rumoured to be in the public domain [17:28:25] at least according to Wikipedia [17:28:36] Ahmad96: Free of cost or free outright? [17:28:39] poke`: yay, looking [17:28:42] The conditions matter [17:29:08] Hmm, the license say you can do everything with it [17:29:16] hi Ahmad96 , as said, the last thing I need myself right now is to join another discussion about free fonts. :) We have the Wikibooks font specs, let's go for that. [17:29:17] But what are the *conditions* [17:29:31] haha ok :) [17:30:05] qgil: Just a moment, please, researching the Wikinews font right now :) [17:30:21] http://www.paratype.com/cinfo/news.asp?NewsId=318 says Open Font License [17:30:26] marktraceur: http://paste.ubuntu.com/6600822/ [17:30:33] So we should be covered [17:31:41] C:\Documents and Settings\Peter\Desktop\wiki stuff [17:32:08] what can you find inside SVG files... [17:32:18] (03CR) 10Bartosz Dziewoński: [C: 032] "Looks nice, doesn't seem to break anything, and removes some code which is always good. :D" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96070 (owner: 10Poke) [17:32:58] (03CR) 10Siebrand: [C: 031] "Trivial i18n changes." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102707 (owner: 10Matthias Mullie) [17:33:06] (03PS1) 10Bartosz Dziewoński: Fix formatting in release notes [core] - 10https://gerrit.wikimedia.org/r/102715 [17:33:21] (03CR) 10Bartosz Dziewoński: [C: 032] Fix formatting in release notes [core] - 10https://gerrit.wikimedia.org/r/102715 (owner: 10Bartosz Dziewoński) [17:33:22] poke`: merged :D [17:33:37] (okay, technically not yet merged, but it's happening as we speak) [17:34:57] MatmaRex: yaay ;D [17:35:04] (finally ^^) [17:35:23] yeah, we have quite a backlog here [17:35:28] twkozlowski, marktraceur Ahmad96 the legal status of Gill-Sans-distributed-by-Adobe (which is what people have in their computers) seems to be a bit more tricky than "public domain" but that is all I will research and say for now. :) [17:35:34] feel free to help with that ;) [17:35:43] (03Merged) 10jenkins-bot: Integrate feed-specific setup into general setup [core] - 10https://gerrit.wikimedia.org/r/96070 (owner: 10Poke) [17:36:28] qgil: https://commons.wikimedia.org/wiki/File:WikiNews-Logo-en.svg says "Bitstream Vera Sans" [17:36:31] Sure, what shall I do? ^^ [17:36:57] (03PS1) 10Hashar: multigit: handles multiple git repository [integration/jenkins] - 10https://gerrit.wikimedia.org/r/102716 [17:37:29] twkozlowski, yes, but it also says "This is not the same as official png version"below, and comparing that SVG with the current PNG used in en.wikinews you can clearly see the difference in text,, and logo [17:37:35] poke`: look at changes and comment on them :) [17:37:57] qgil: I'm talking inside the file, not the nonsense file description :) [17:38:00] So, reviewing changes, will do :) [17:38:05] https://www.mediawiki.org/wiki/Gerrit/Reports#Reports has some fun links [17:38:57] (03Merged) 10jenkins-bot: Fix formatting in release notes [core] - 10https://gerrit.wikimedia.org/r/102715 (owner: 10Bartosz Dziewoński) [17:39:12] twkozlowski, the logo part is not problematic because https://commons.wikimedia.org/wiki/File:Wikinews-logo.svg was improved in the past years and it looks like ready for a substitution [17:39:19] Wow, I got rid of 10 patches yesterday :D [17:42:11] twkozlowski, all I'm saying is that https://commons.wikimedia.org/wiki/File:WikiNews-Logo-en.svg and https://commons.wikimedia.org/wiki/File:Wikinews-logo-en.png have visible differences when put side by side [17:42:11] (03CR) 10Siebrand: [C: 04-1] i18n: Make LogEventsList user language direction aware (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102677 (owner: 10Ebrahim) [17:47:01] qgil: Yes, but it's about the globe rather than the font, right? [17:48:12] * qgil opened Inkscape and is trying something twkozlowski  [17:49:43] qgil: I think it /is/ Bitstream Vera Sans, but I can't get it right just yet. [17:51:40] Or maybe it's not; the letters "K" and "S" are different in the PNG logo. [17:52:48] qgil: OK, so I'll drop Wikinews for now and will add some Wikibooks logo to the bug [17:56:28] (03PS1) 10Legoktm: Add .gitreview [extensions/PageBlock] - 10https://gerrit.wikimedia.org/r/102720 [17:56:39] (03CR) 10Legoktm: [C: 032 V: 032] Add .gitreview [extensions/PageBlock] - 10https://gerrit.wikimedia.org/r/102720 (owner: 10Legoktm) [17:57:23] ok twkozlowski - [18:08:30] (03PS2) 10Ebrahim: i18n: Make LogEventsList user language direction aware [core] - 10https://gerrit.wikimedia.org/r/102677 [18:09:04] (03PS4) 10EBernhardson: Convert UUID length 'magic' numbers to named constants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102584 [18:09:16] (03PS15) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [18:09:29] (03CR) 10Ebrahim: "Thank you. Tested here http://tools.wmflabs.org/ebraminio-dev/w/index.php?title=MediaWiki:Abd.js?uselang=fa" [core] - 10https://gerrit.wikimedia.org/r/102677 (owner: 10Ebrahim) [18:13:27] (03PS2) 10EBernhardson: base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 [18:18:26] (03CR) 10Aaron Schulz: "Can't LogEntry::setRelations be used to store the log_id <=> pr_id mapping instead?" [core] - 10https://gerrit.wikimedia.org/r/98175 (owner: 10Umherirrender) [18:19:12] (03CR) 10Nikerabbit: [C: 032] i18n: Make LogEventsList user language direction aware [core] - 10https://gerrit.wikimedia.org/r/102677 (owner: 10Ebrahim) [18:19:50] MatmaRex: try setting the width of the window to 702px while viewing talk:main page on enwiki as anon [18:20:45] MatmaRex: http://www.youtube.com/watch?v=P9N9F9C640Q [18:22:13] (03Merged) 10jenkins-bot: i18n: Make LogEventsList user language direction aware [core] - 10https://gerrit.wikimedia.org/r/102677 (owner: 10Ebrahim) [18:23:12] (03PS1) 10BryanDavis: Add cache-control and vary headers [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102725 [18:23:13] ori_: the width is probably font-, system- and browser-dependent, 702px is well into the collapsed state for me [18:23:31] ori_: (on a side note, the fundarising notice seems to break the layout at that width, even when hidden) [18:24:02] http://i.imgur.com/GNayCs6.png [18:24:25]
wat. [18:24:49] (03PS1) 10Legoktm: User::loadFromRow takes a stdClass object, not an array [core] - 10https://gerrit.wikimedia.org/r/102726 [18:27:15] twkozlowski, this is how far I could get: https://commons.wikimedia.org/wiki/File:Wikinews-logo-en-qgil.svg [18:27:20] (03CR) 10Siebrand: "@Ebrahim: I assigned the resolved bug to you, but I'm not sure it's the correct email address." [core] - 10https://gerrit.wikimedia.org/r/102677 (owner: 10Ebrahim) [18:27:34] twkozlowski, tried DejaVu Sans and other free sans I have around, but the differences were more visible [18:30:39] (03CR) 10BryanDavis: "Hoping for some good feedback from reviewers on whether this is a sane approach or not." (032 comments) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102725 (owner: 10BryanDavis) [18:31:05] (03CR) 10Krinkle: Purge user css/js. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95095 (owner: 10Brian Wolff) [18:32:18] https://upload.wikimedia.org/wikipedia/commons/a/ac/Wikinews-logo-en-qgil.svg [18:32:24] is it my browser that's broken? [18:34:13] (03CR) 10CSteipp: Add cache-control and vary headers (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102725 (owner: 10BryanDavis) [18:34:41] (03CR) 10Legoktm: Autocreate global account after rename (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/102635 (owner: 10Legoktm) [18:35:54] qgil: looks good, except for the letter 'S' :) [18:38:17] (03PS2) 10Aaron Schulz: Added a MemoryFileBackend class and made MockFileBackend subclass it [core] - 10https://gerrit.wikimedia.org/r/102621 [18:38:35] ori_: can you look at https://gerrit.wikimedia.org/r/#/c/102621/ ? it's pretty simple [18:40:29] twkozlowski, the K has a slightly different angle, the E is wider... Then again it is one of these things where I wish I could just swap logos and wait until someone in the project notices... [18:40:51] (03CR) 10Krinkle: "Hm.. strange. Both when logged in and when logged out, I don't get any public caching or maxage on the action=raw css/js requests." [core] - 10https://gerrit.wikimedia.org/r/95095 (owner: 10Brian Wolff) [18:42:26] If you enjoy dramah, then sure. [18:43:29] twkozlowski, :) anyway, if someone finds out which font was used, now only a copy & past would be needed, plus the blur [18:43:49] Yes. [18:44:00] and it would've taken the author five minutes to write down what font they used [18:44:13] now I want to smack them on the head [18:50:31] (03PS2) 10Reedy: Update CentralAuth recent change notification code [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92461 [18:51:01] (03CR) 10Ebrahim: "OK, I made another account on Bugzilla again to reduce the confusion. I couldn't change the assigned email with this new account but it is" [core] - 10https://gerrit.wikimedia.org/r/102677 (owner: 10Ebrahim) [18:52:31] Aaron|home: reviewing. it's pretty cool [18:52:34] (03PS1) 10Petr Onderka: Updated location of zhtable in comment [core] - 10https://gerrit.wikimedia.org/r/102733 [18:53:04] ori_: it's mostly just some refactoring really [18:53:45] (03PS2) 10Petr Onderka: Updated location of zhtable in comment [core] - 10https://gerrit.wikimedia.org/r/102733 [18:54:31] (03CR) 10Parent5446: [C: 032] User::loadFromRow takes a stdClass object, not an array [core] - 10https://gerrit.wikimedia.org/r/102726 (owner: 10Legoktm) [18:54:54] ori_: instead of storing 'data' I could probably also use php:// handles and file_get_contents() those as needed...that would let files drop onto disk if they get too big [18:55:05] but that's probably overkill for right now [18:57:06] manybubbles: you might enjoy replying to https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=586818104#Suggest_search_features_.28lemmatisation.2C_stemming.29 :) [18:57:34] MatmaRex: reading! [18:57:39] (03Merged) 10jenkins-bot: User::loadFromRow takes a stdClass object, not an array [core] - 10https://gerrit.wikimedia.org/r/102726 (owner: 10Legoktm) [19:06:48] (03CR) 10Ori.livneh: "There's a loose equality test on line 256 that should be strict; looks good otherwise." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102621 (owner: 10Aaron Schulz) [19:09:10] (03Abandoned) 10Odder: Add a LanguageAng.php file for Old English projects [core] - 10https://gerrit.wikimedia.org/r/99641 (owner: 10Odder) [19:13:05] (03CR) 10Siebrand: [C: 032] "Thanks." [core] - 10https://gerrit.wikimedia.org/r/102733 (owner: 10Petr Onderka) [19:16:29] (03Merged) 10jenkins-bot: Updated location of zhtable in comment [core] - 10https://gerrit.wikimedia.org/r/102733 (owner: 10Petr Onderka) [19:16:48] (03CR) 10Parent5446: [C: 04-1] Maintenance script for benchmarking parse operations (0316 comments) [core] - 10https://gerrit.wikimedia.org/r/102596 (owner: 10Tim Starling) [19:17:38] yurik i was going through action=parse using summary but couldn't understand it properly [19:18:16] summary parameter takes which value? [19:19:21] (03CR) 10Parent5446: "Correct me if I'm wrong, but would it be possible for anonymous users to be the performer of page protection?" [core] - 10https://gerrit.wikimedia.org/r/98175 (owner: 10Umherirrender) [19:20:23] diwanship, tell you the truth, i don't exactly know what summary param does, but i suspect that it is used to parse the summary message when you change a wiki article [19:20:41] summary params are parsed a bit differently [19:21:01] for example, the /* ... */ gets parsed as a link to the section [19:21:22] try editing any article's section, it will automatically have that string in the summary [19:22:03] yurik yes i was thtinking to skip summary here and take it in action=edit [19:22:27] (03PS1) 10Aaron Schulz: Include delayed job count in showJobs.php [core] - 10https://gerrit.wikimedia.org/r/102738 [19:23:00] you might want to mention it, but probably don't need a tutorial for it.... any luck with the overal lessons plan? [19:24:31] yurik i made a subpage under my user page https://www.mediawiki.org/wiki/User:Diwanshipandey/OPW_Internship_Report although it needs modifications . [19:25:38] diwanship, yep, this is good! Lets also have a lesson plan though :) [19:26:02] yurik i was thinking to start action=query module and will make lesson plan acc to that but before that i wanted to ask you that acc to you is there any thing in parsing which should be implemented [19:28:02] diwanship, i think we should cover parsing of the saved page too [19:28:11] ( number 1 in the doc ) [19:28:28] also you might want to show how to get various prop [19:29:50] yurik , i think parsing of saved page you have already covered in the exercise and its 1st exercise [19:29:55] (03CR) 10Parent5446: [C: 031] Include delayed job count in showJobs.php [core] - 10https://gerrit.wikimedia.org/r/102738 (owner: 10Aaron Schulz) [19:32:48] (03CR) 10Aaron Schulz: [C: 04-1] Store timestamp, user and reason for page protections in the db [core] - 10https://gerrit.wikimedia.org/r/98175 (owner: 10Umherirrender) [19:34:00] yurik, and i thought prop could be covered in action=query [19:34:20] diwanship, those are different props - somewhat similar, but they are not query props [19:34:40] diwanship, as for parse slides - at some we will need to restructure our lecture to keep parse slides together, etc. Also, I was thinking if at any point we might want to break different functionality into different lessons [19:34:55] not sure about this one though [19:35:43] have you heard from the site re import/export functionality? [19:36:01] no they haven't replied after that yet [19:37:10] yurik, one more thing i was thinking about amking 3 sections in exercise for parsing,querying and modifying respctvly [19:37:35] yes, sounds good [19:37:50] that will all be a part of your lesson plan doc ;) [19:39:06] yurik :D yes. the prop you have covered in the exercise are related to action=query? [19:41:53] oh come on, you can figure that one out :-P [19:46:12] yurik ok i'l see and start accordingly [19:46:33] have fun, let me know how it progresses :) [19:46:55] ya i'l send you the link [19:47:14] :0 [19:47:16] :) [19:51:34] (03PS1) 10Reedy: Add logging for "Invalid message parameter" [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102741 [19:51:48] (03CR) 10Reedy: [C: 032 V: 032] Add logging for "Invalid message parameter" [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102741 (owner: 10Reedy) [19:55:30] (03CR) 10Umherirrender: "I am not sure, but it is possible, that the parser part is still used for __NOEDITSECTION__ magic word or when set to false for old versio" [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas) [19:59:11] twkozlowski, https://en.wikinews.org/wiki/Wikinews:Water_cooler/technical#Font_used_in_the_Wikinews_logo.3F [19:59:48] qgil: Thanks! [20:00:00] hashar: Where in Jenkins would I find whether some gerrit repo has it's changes automatically merged upon CR+2 V+2, or it needs a Submit? [20:00:24] hashar: (I am interested in the analytics/wikistats repo) [20:00:34] (03CR) 10Umherirrender: "When using the relations, that means to join three tables instead of adding new fields. A log entry can have more than one pr_id, but rela" [core] - 10https://gerrit.wikimedia.org/r/98175 (owner: 10Umherirrender) [20:00:44] qgil: Have you already noticed the deployment spree Reedy was on ~50 minutes ago? [20:01:05] qgil: a few more favicons got online! \o/ [20:01:13] yep! [20:04:43] (03CR) 10Umherirrender: [C: 031] Special special page group for ExpandTemplates [core] - 10https://gerrit.wikimedia.org/r/102701 (owner: 10Siebrand) [20:06:20] MatmaRex: replied [20:06:40] (03CR) 10Brian Wolff: "That's a varnish/squid cache hit (the age header and the x-cache header). The max-age is maybe getting overriden by varnish (probably inap" [core] - 10https://gerrit.wikimedia.org/r/95095 (owner: 10Brian Wolff) [20:07:47] (03CR) 10Bartosz Dziewoński: [C: 032] Special special page group for ExpandTemplates [core] - 10https://gerrit.wikimedia.org/r/102701 (owner: 10Siebrand) [20:09:12] manybubbles: thanks [20:09:26] AaronSchulz, are you around for a consultation about fileRepo api? I was told you might be able to help [20:09:28] thanks for pointing it out [20:09:48] I might get some good information about what to do for ascii squashing in french from it [20:10:55] (03Merged) 10jenkins-bot: Special special page group for ExpandTemplates [core] - 10https://gerrit.wikimedia.org/r/102701 (owner: 10Siebrand) [20:11:20] (03CR) 10BryanDavis: [C: 04-2] "Don't want to merge yet even if it's "correct" code. Trying a pure Varnish solution first with Ie5c2e26." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102725 (owner: 10BryanDavis) [20:16:12] (03PS1) 10Dan-nl: update-install-instructions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102747 [20:18:26] mooeypoo: if it's api.php you can ask anomie [20:18:59] (03PS1) 10Manybubbles: Stop warning [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102748 [20:19:28] hm, I'm not sure if it's the api or info about filerepo -- I'm working on a VE improvement where we take file repos from the api rather than have them hard-coded for images, etc. But on the fileRepo request, some get 'url' and some 'apiurl' [20:20:10] not necessarily related to whether they're set to local=true or not. Is this a fileRepo configuration issue, or an api response issue? [20:20:59] (03PS2) 10Manybubbles: Stop warning [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102748 [20:21:36] mooeypoo: "apiurl" should only be coming from ForeignAPIRepo repos, I believe. [20:21:57] * mooeypoo nods [20:22:15] everything else will have 'url' as the relevant place to look for the images? [20:23:45] (03PS2) 10Dan-nl: update-install-instructions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102747 [20:25:03] (03PS1) 10Aaron Schulz: Make executeReadyPeriodicTasks() notify the aggregator when jobs are released/recycled [core] - 10https://gerrit.wikimedia.org/r/102749 [20:26:19] (03PS1) 10EBernhardson: Allow icon paths to be resolved when requested [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102750 [20:28:29] bd808: https://gerrit.wikimedia.org/r/#/c/102749/ is fairly trivial [20:29:36] Aaron|home: Is that related to the stuck jobs stuff that Dan was seeing in beta? [20:29:39] Aaron|home: https://gerrit.wikimedia.org/r/#/c/102621/ is '=' away from being mergable, see my comment [20:30:05] (03CR) 10Jdlrobson: [C: 032] Add mediawiki.ui.button to places in core using mw.ui [core] - 10https://gerrit.wikimedia.org/r/102608 (owner: 10Mattflaschen) [20:31:12] I guess !== can't hurt [20:32:11] bd808: this is just for delayed or previously failed stuff, but I may as well fix that since I noticed it [20:32:25] (03Abandoned) 10Jdlrobson: WIP: Allow Skins to define other HTML tag attributes [core] - 10https://gerrit.wikimedia.org/r/100920 (owner: 10Jdlrobson) [20:32:33] bd808: I can't reproduce that problem and probably wasted enough time messing around on labs today [20:32:52] ori_: it should already be a string or null though [20:33:29] (03Merged) 10jenkins-bot: Add mediawiki.ui.button to places in core using mw.ui [core] - 10https://gerrit.wikimedia.org/r/102608 (owner: 10Mattflaschen) [20:33:39] (03PS3) 10Jdlrobson: Move all VectorBeta RL modules from core. [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99523 [20:34:40] (03CR) 10Jdlrobson: "This should only be merged at the same time as core otherwise 2 ResourceLoader modules with the same name will exist and everything will e" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99523 (owner: 10Jdlrobson) [20:36:49] Aaron|home: '==' is sufficiently rare in our code base and type-juggling in PHP is sufficiently tricky that encountering one while you're reading code stops you in your tracks and forces you to reason about whether or not there's a bug hiding [20:37:02] even if there isn't one, it's worth removing it [20:37:12] (03PS3) 10Jdlrobson: Move VectorBeta modules to VectorBeta extension. [core] - 10https://gerrit.wikimedia.org/r/99524 [20:37:18] Krinkle has made this point often about empty() and I think it's a good one [20:38:08] FWIW I agree with Ori. Squashing `==` bugs was a major pastime at my last gig [20:38:11] Aaron|home: you tried to replicate the issue i mentioned using gwtoolset and didn't run into it? [20:38:23] bd808: I never said I disagreed [20:38:40] it just takes forever to push patches with msysgit [20:38:48] Aaron|home: happy to update it if you like [20:38:55] it's pushing now [20:39:34] Aaron|home: I thought you might have planted it there, like the Van Halen "no brown M&Ms" clause [20:39:46] (see the block quote in ) [20:39:54] as a test for whether someone is reading the code carefully :P [20:40:24] (03PS3) 10Aaron Schulz: Added a MemoryFileBackend class and made MockFileBackend subclass it [core] - 10https://gerrit.wikimedia.org/r/102621 [20:40:52] (03PS2) 10Spage: Allow icon paths to be resolved when requested [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102750 (owner: 10EBernhardson) [20:41:53] anomie, hm, the repo type seems to not be returned in the api, unless I'm missing something. And without it, I'm not sure how to tell VE to pick the right url source to fetch images from [20:42:55] anomie, I though at first that if 'local=true' then use 'url' and local=false use 'apiurl' but that clearly isn't the case. Can I assume that 'use apiurl if exists, otherwise url' ? [20:42:58] (03CR) 10BryanDavis: [C: 032] Make executeReadyPeriodicTasks() notify the aggregator when jobs are released/recycled [core] - 10https://gerrit.wikimedia.org/r/102749 (owner: 10Aaron Schulz) [20:43:37] mooeypoo: server + url (or thumbUrl) + file name, I'd think. marktraceur or tgr, you used this (api meta=filerepoinfo) in your Multimedia work, haven't you? [20:43:48] anomie, I'm otherwise stuck in trying to recognize which is which. See here for instance: https://en.wikipedia.org/w/api.php?action=query&meta=filerepoinfo&format=jsonfm [20:44:18] (03CR) 10Chad: [C: 032] Add a unit test to check if it broke any hooks [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102461 (owner: 10Manybubbles) [20:44:22] anomie: Yes [20:44:30] (03Merged) 10jenkins-bot: Add a unit test to check if it broke any hooks [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102461 (owner: 10Manybubbles) [20:44:36] anomie / marktraceur if you can, see lines 98 and up here: https://gerrit.wikimedia.org/r/#/c/102377/2/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js [20:44:41] 'kay [20:45:00] this.sources has the api reply, now I am just trying to see how to get the url that images are searched from [20:45:06] (03CR) 10Chad: [C: 032] Disable dynamic mapping [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102572 (owner: 10Manybubbles) [20:45:10] (03Merged) 10jenkins-bot: Disable dynamic mapping [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102572 (owner: 10Manybubbles) [20:45:11] mooeypoo: You mean 98 through to the end of the file, or "98 and the things that are visually above that"? [20:45:11] It *seems* that APIs use apiurl and others use url [20:45:15] but it's not consistent [20:45:24] mooeypoo: Oh, yeah, that's *super* fun [20:45:24] (03CR) 10Chad: [C: 032] Stop warning [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102748 (owner: 10Manybubbles) [20:45:30] (03Merged) 10jenkins-bot: Stop warning [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102748 (owner: 10Manybubbles) [20:45:31] marktraceur, 114-119 is the relevant bit [20:45:36] mooeypoo: What you're seeing is that there are foreign API repos and foreign DB repos [20:45:37] (03CR) 10Legoktm: "Why not just allow setting ltr or rtl keys in the configuration?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102750 (owner: 10EBernhardson) [20:45:51] marktraceur, I understand, but the api answer doesn't discern it [20:46:00] mooeypoo: https://gerrit.wikimedia.org/r/102553 [20:46:02] (03Merged) 10jenkins-bot: Make executeReadyPeriodicTasks() notify the aggregator when jobs are released/recycled [core] - 10https://gerrit.wikimedia.org/r/102749 (owner: 10Aaron Schulz) [20:46:04] Is how I fixed mine [20:46:06] I can't check "if api / if db" [20:46:12] Oh, hm. [20:46:15] So [20:46:25] ori_: There's an empty() in https://gerrit.wikimedia.org/r/#/c/102621/3/includes/filebackend/MemoryFileBackend.php as well, aside from the != [20:46:28] mooeypoo: You Really Probably Shouldn't be accessing a remote API directly [20:46:34] not sure if you pointed that out already [20:46:47] marktraceur, what do you mean? [20:46:48] it doesn't matter [20:47:17] mooeypoo: It's imperfect because it will cause troubles if you're using an API remote repo and haven't set up CORS for it [20:47:22] marktraceur, the idea was to move the hardcoded local+commons from VE's init settings to use the file repos. So it asks the remote api if needed, isn't that the point of file repos? [20:48:04] (03CR) 10Anomie: Autocreate global account after rename (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/102635 (owner: 10Legoktm) [20:48:55] marktraceur, to be perectly honest, the entire fileRepo thing was very confusing to understand how to set up from a user perspective. I ended up enbling wgUseInstantCommons [20:49:40] marktraceur, for the moment, the fix in VE assumes users know how to set the repos up, I believe. It just needs to use the repos that were set up in the media insertion dialog and for THAT, I need to consistently use the proper url :\ [20:49:57] Mark is right that you need jsonp for foreign APIs [20:50:12] I forgot about that when reviewing your code [20:50:15] (03CR) 10Krinkle: Added a MemoryFileBackend class and made MockFileBackend subclass it (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102621 (owner: 10Aaron Schulz) [20:51:02] RoanKattouw, I'm a bit confused now. [20:51:23] For foreign APIs, we need jsonp instead of json in the api lookup request? [20:51:50] RoanKattouw, marktraceur but there's no identifier on whether a fileRepo is remote API or not :\ [20:51:51] (03CR) 10Legoktm: "On my phone, but to be more clearer I'm thinking of just checking if the logo is an array, and if so, to check if it has ltr/rtl keys, and" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102750 (owner: 10EBernhardson) [20:53:07] (03PS1) 10Bsitu: Allow defining clousre for notification icon path [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102783 [20:53:39] mooeypoo: Yeah there is, it gets returned as the local attribute on a repoInfo object [20:53:43] (03PS1) 10Bsitu: Define icon patch as closure [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102790 [20:54:49] (03PS2) 10Bsitu: Define icon patch as closure [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102790 [20:54:59] mooeypoo: My point is, the backend should be doing the searching for you, not the frontend [20:55:02] marktraceur, local= true you mean? but isn't that true for both local API and local DB ? [20:55:08] Ugh, maybe. [20:55:27] No! [20:55:31] https://en.wikipedia.org/w/api.php?action=query&format=json&titles=File%3AJoseph+Grimaldi%2Ejpg&prop=imageinfo&iiprop=timestamp%7Cuser%7Cuserid%7Ccomment%7Curl%7Csize%7Csha1%7Cmime%7Cmediatype%7Cmetadata%7Cextmetadata&iiurlwidth=1585&iiurlheight=441&iiextmetadatalanguage=en&meta=filerepoinfo [20:55:36] Fucking....longurl [20:55:49] O.O what? [20:55:51] https://en.wikipedia.org/w/api.php?action=query&format=json&meta=filerepoinfo [20:55:54] Better [20:55:59] local=false for commons [20:56:11] Wait. [20:56:35] Why would there be a local API repo? [20:56:35] I'm very confused. [20:57:09] marktraceur, local no, but url vs apiurl [20:57:11] mooeypoo: Read about what JSONP is on Wikipedia [20:57:12] see: https://en.wikipedia.org/w/api.php?action=query&meta=filerepoinfo&format=jsonfm [20:57:27] ... [20:57:59] mooeypoo: Protip https://chrome.google.com/webstore/detail/jsonview/chklaanhfefbnpoihckbnefhakgolnmc?hl=en [20:58:06] Anyway [20:58:20] \o/ that rocks [20:59:01] mooeypoo: I think it's a mistake for VE frontend to be accessing remote image search APIs. It should be calling a local API module that *maybe* searches a remote API, if requested. [20:59:19] Or maybe if not disabled, or something [20:59:27] how does mw in general does it though? [20:59:41] mooeypoo: FileRepo objects basically chain to each other across the network [20:59:45] because aren't the point of fileRepos to allow exactly for that - external media sources ? [20:59:52] isn't* [21:00:11] mooeypoo: If I set up a remote API repo, I can find things on that repo because my wiki calls its API to find them [21:00:30] Similarly if I set up a remote shared DB repo, I find things on that wiki because my wiki searches that wiki's databaes. [21:00:31] right [21:00:35] database even. [21:00:52] right [21:01:08] You should write an API module that makes similar requests, but for search results, to the remote API and DB. [21:01:25] And then use that API module in VE, locally, instead of screwing around with CORS or JSONP or whatever other hell [21:01:39] I see. [21:01:48] At least this is how it makes sense to me. [21:01:52] tgr, bd808, thoughts? [21:02:07] Maybe Aaron|home also. [21:02:20] * bd808 reads scrollback [21:02:35] I'll have to get into how to do that more, then. The whole fileRepo was confusing, it was really weird to set up (I never did that before) [21:02:43] Yeah [21:02:57] You can look at the wmf config files for more examples [21:03:11] Understanding how the code works probably helps understand how to configure it :) [21:03:41] btw, James_F might want to jump in too [21:03:51] marktraceur, indeed [21:05:20] (03PS1) 10Dan-nl: correcting gwtoolset permission check [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102814 [21:05:38] (03PS1) 10Aaron Schulz: Removed isQueueDeprioritized() [core] - 10https://gerrit.wikimedia.org/r/102815 [21:06:15] I might? [21:06:22] Oh. [21:06:26] * James_F reads scrollback. [21:07:17] twkozlowski, just checking, will you have a chance to comment on https://bugzilla.wikimedia.org/show_bug.cgi?id=52019#c60 ? [21:07:22] marktraceur: I think that the VE front end code that calls the MW backend will transfer to VE front end calling MediaService (or whatever) front end that will do searches and uploads and other back-end things. [21:07:29] marktraceur: … in time? [21:07:38] er , silly connection [21:08:22] What did I miss? [21:08:38] marktraceur: So you're right, ideally we'd have a search API [21:08:44] MW core should have that [21:08:46] But it doesn't [21:08:49] Chad built one in Cirrus [21:09:11] qgil: How do I comment on an almost-perfect comment of her? :-) [21:09:29] qgil: I did edit those file descriptions a bit and gave Natasha +autopatrolled on Commons though [21:09:56] RoanKattouw: So we can use that when Cirrus is available everywhere? Oh, except, yay, another dependency. :-( [21:10:15] We should use it if available and have a fallback for when it's not [21:10:25] (03CR) 10Ori.livneh: [C: 032] Added a MemoryFileBackend class and made MockFileBackend subclass it [core] - 10https://gerrit.wikimedia.org/r/102621 (owner: 10Aaron Schulz) [21:10:50] aye but it's not yet available on production wikis is it? [21:11:03] Not on ones where we have VE I don't think [21:11:52] so do we wait, do we do this non-perfect front-end api call meanwhile, or do we work on our own search module (which might be reinventing the wheel really, it sounds like) [21:13:49] hashar: anything else on https://gerrit.wikimedia.org/r/#/c/102152/ ? [21:14:04] https://gerrit.wikimedia.org/r/102621 fixes the svg file race [21:14:18] (03PS2) 10Cmcmahon: Smoke tests for Upload Wizard using the API. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/102603 (owner: 10Aarcos) [21:14:26] Aaron|home: ah that is nice :-} [21:15:34] Aaron|home: though you implemented a new filesystem in memory [21:16:07] mostly just cleanup, but using create() instead of store() fixes that problem [21:16:44] Aaron|home: you might have implemented create / store in the MockFileBackend ? [21:16:58] I don't want to use vfsstream unless really needed...and even then that would break things that shell out [21:17:20] na not vfsstream [21:17:53] I mean, instead of implementing MemoryFileBackend, you could just have implemented a very simple create/store version directly in the MockFileBackend :D [21:18:44] I'd like to have a fully working memory version just like HashBagOStuff [21:19:00] which I added [21:19:14] hashar: anyway, what else is blocking that commit? [21:19:38] well it got merged so.. [21:19:44] nothing? :-] [21:20:19] ah sorry the other change [21:20:28] gotta test it out [21:20:43] plus that would only work in master not in REL_ branches :( [21:21:31] will look at it tomorrow, got to let the job be runnable concurrently, trigger two runs and make sure it still works :D [21:21:39] s/two/Several runs/ [21:21:53] ok [21:22:06] will poke tomorrow [21:22:20] also got to test the REL branches, they are most probably going to be broken unfortunately [21:22:40] (03CR) 10Catrope: [WIP] Add support for JSON i18n files (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102098 (owner: 10Catrope) [21:22:55] Aaron|home: on another topic, dan-nl has some issues with gwtoolset jobs :( [21:22:59] filled a bug about it today https://bugzilla.wikimedia.org/show_bug.cgi?id=58692 [21:23:20] for some reason nextJobDB.php does not find the gwtoolset jobs on beta :( [21:23:36] looking at the result of JobQueueAggregator::singleton()->getAllReadyWikiQueues() , they are definitely not there [21:23:38] BUT [21:23:56] JobQueueAggregator::singleton()->purge() helped that ;) [21:24:05] showJobs.php (which uses JobQueueGroup::singleton(); ) does get them [21:25:00] hashar: if the jobs failed the first time and were recycled the aggregator would be stale (fixed in https://gerrit.wikimedia.org/r/#/c/102749/) [21:25:10] dan-nl: ^^^^ [21:25:20] thanks both, i'll try now [21:25:28] of course jobs shouldn't really be failing unless something else was wrong already [21:25:45] and if they don't fail in run() that change won't help [21:25:51] but if they do fail, that should show in runJobs.log, yes? [21:26:39] twkozlowski, ok, so Natasha's task is completed, then [21:27:00] … or in exceptions.log [21:27:09] (03CR) 10Hashar: "Now we got to manually enable the parser job to be runnable concurrently and then trigger a bunch of build. They should pass with master." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102152 (owner: 10Hashar) [21:27:43] qgil: if we let her not draw the hy logo just yet, then yes. [21:28:12] and seeing she doesn't know what's the font used, I say we should let her not draw it just yet [21:29:38] twkozlowski, I'm fine with that. I think we can trust students that have delivered 80% and are waiting for editors to answer about the 20% :) [21:30:09] twkozlowski, I will create the new task your provided first, though [21:30:39] OK [21:36:28] (03Abandoned) 10Mattflaschen: Blank signupstart and signupend [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/100534 (owner: 10Mattflaschen) [21:38:17] marktraceur, if you can have a look at GCI-related https://gerrit.wikimedia.org/r/#/c/102595/ that would be great [21:39:11] Aaron|home: i submitted a gwtoolsetMetadataJob to beta at 21:29 utc, but it still doesn't show in the runJobs.log or when running mwscript showJobs.php --wiki=commonswiki --group and there is no exceptions.log [21:39:41] (03PS1) 10Manybubbles: Build Special:Search's title without escaping [core] - 10https://gerrit.wikimedia.org/r/102820 [21:40:06] is there another config setting we need to add since it's part of the $wgJobTypesExcludedFromDefaultQueue array? [21:41:37] (03PS2) 10Hashar: multigit: handles multiple git repository [integration/jenkins] - 10https://gerrit.wikimedia.org/r/102716 [21:52:14] (03PS4) 10Catrope: Script to convert PHP i18n to JSON [core] - 10https://gerrit.wikimedia.org/r/102171 [21:54:05] Aaron|home: fyi, it looks like beta picked up that job. it took about 15 minutes before it ran it. but at least that's a good sign. [21:56:45] (03PS3) 10Hashar: multigit: handles multiple git repository [integration/jenkins] - 10https://gerrit.wikimedia.org/r/102716 [21:58:49] (03CR) 10Hashar: [C: 04-2] "not ready yet, totally experimental. Will play with that script for the mediawiki/services/parsoid/deploy job." (031 comment) [integration/jenkins] - 10https://gerrit.wikimedia.org/r/102716 (owner: 10Hashar) [21:59:04] (03CR) 10Bartosz Dziewoński: [C: 032] "You know what, waiting a month for reviews for a trivial change like this one just makes no sense." [core] - 10https://gerrit.wikimedia.org/r/95703 (owner: 10Bartosz Dziewoński) [22:00:47] (03CR) 10Siebrand: [C: 031] "i18n reviewed. Trivial." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102814 (owner: 10Dan-nl) [22:09:33] (03Merged) 10jenkins-bot: Fix TOC display for printing [core] - 10https://gerrit.wikimedia.org/r/95703 (owner: 10Bartosz Dziewoński) [22:10:02] (03CR) 10Spage: "I think it should be refactored to share the code; it's someone else's call whether you want to do this now or later." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102783 (owner: 10Bsitu) [22:12:20] (03PS2) 10BryanDavis: Add cache-control and vary headers [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102725 [22:14:02] (03PS4) 10Hashar: multigit: handles multiple git repository [integration/jenkins] - 10https://gerrit.wikimedia.org/r/102716 [22:14:49] (03CR) 10BryanDavis: "Changed my mind a bit. Now setting headers similar to those used in the MW core OutputPage class for authenticated users." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102725 (owner: 10BryanDavis) [22:16:57] bd808: Changed your mind? flip-flopper! [22:17:12] I never inhaled [22:19:21] (03CR) 10BryanDavis: [C: 032] "Basically reverts I29cb22e" [core] - 10https://gerrit.wikimedia.org/r/102815 (owner: 10Aaron Schulz) [22:21:04] (03CR) 10Aaron Schulz: [C: 04-2] "Missed a caller" [core] - 10https://gerrit.wikimedia.org/r/102815 (owner: 10Aaron Schulz) [22:21:40] (03CR) 10Gergő Tisza: update-install-instructions (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102747 (owner: 10Dan-nl) [22:21:46] hey Aaron|home, i tried another upload at 21:56 utc and that one hasn't been picked up yet. it's been about 24 minutes now. i have no idea how to trouble shoot this issue. i'll send you a sample xml file with some instructions that replicate what i'm doing. i really need your help here as i really don't understand the puppet config or the job runner or what is triggering it so that it picks up the gwtoolset jobs. the jobs worked when we didn't use the [22:21:46] $wgJobTypesExcludedFromDefaultQueue array or the puppet config … [22:22:11] (03PS2) 10Aaron Schulz: Removed isQueueDeprioritized() [core] - 10https://gerrit.wikimedia.org/r/102815 [22:23:07] bd808: updated https://gerrit.wikimedia.org/r/#/c/102815/2 [22:24:32] (03CR) 10Tim Starling: "It is logged because the behaviour is incorrect, the wrong language object is returned. The consequences of this are unknown but probably " [core] - 10https://gerrit.wikimedia.org/r/102557 (owner: 10Yurik) [22:25:06] (03PS3) 10Dan-nl: update-install-instructions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102747 [22:26:15] (03CR) 10Dan-nl: "- addressed gergő’s inline comment in ps1." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102747 (owner: 10Dan-nl) [22:26:21] (03CR) 10Tim Starling: "Maybe if this was against a deployment branch instead of master, it would be OK." [core] - 10https://gerrit.wikimedia.org/r/102557 (owner: 10Yurik) [22:27:28] Aaron|home: Gah. That's what I get for trusting you :P [22:27:34] (03CR) 10Yurik: "wouldn't stay ok for just 2 or even 1 week, and we would have to re-apply it for the next branch?" [core] - 10https://gerrit.wikimedia.org/r/102557 (owner: 10Yurik) [22:28:14] bd808: I have to keep you on your toes [22:29:27] (03CR) 10BryanDavis: [C: 032] "I don't see any more uses of isQueueDeprioritized" [core] - 10https://gerrit.wikimedia.org/r/102815 (owner: 10Aaron Schulz) [22:29:47] Aaron|home: don't know if this helps, but now the job got picked up … job timestamp was Thu, 19 Dec 2013 21:57:43 GMT … job ran at 2013-12-19 22:28:12 [22:29:48] (03PS2) 10Spage: Allow defining clousre for notification icon path [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102783 (owner: 10Bsitu) [22:30:27] seems that every time i mention it in irc it gets picked up a few moments later ... [22:30:41] (03CR) 10Spage: [C: 032] "I think it works, approving for high-priority fix." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102783 (owner: 10Bsitu) [22:30:46] (03CR) 10Tim Starling: "Yes, that is the idea. You said it was temporary, right?" [core] - 10https://gerrit.wikimedia.org/r/102557 (owner: 10Yurik) [22:30:47] (03CR) 10Gergő Tisza: "You could probably remove WikiChecks::checkUserWikiGroups() and Config::$user_group, too." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102814 (owner: 10Dan-nl) [22:30:54] (03Merged) 10jenkins-bot: Allow defining clousre for notification icon path [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102783 (owner: 10Bsitu) [22:32:36] (03Merged) 10jenkins-bot: Removed isQueueDeprioritized() [core] - 10https://gerrit.wikimedia.org/r/102815 (owner: 10Aaron Schulz) [22:32:48] (03CR) 10Gergő Tisza: [C: 031] update-install-instructions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102747 (owner: 10Dan-nl) [22:32:50] (03CR) 10Legoktm: "I don't like this fix. If I stick a file at "foo" and some other extension has a function named "foo", this will break." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102783 (owner: 10Bsitu) [22:33:38] (03CR) 10Legoktm: Allow defining clousre for notification icon path (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102783 (owner: 10Bsitu) [22:37:52] (03PS2) 10Dan-nl: correcting gwtoolset permission check [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102814 [22:39:02] (03CR) 10Dan-nl: "- addressing gergő’s comment in ps1" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102814 (owner: 10Dan-nl) [22:39:41] (03PS1) 10Spage: Revert "Allow defining clousre for notification icon path" , going to improve it. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102830 [22:39:48] (03CR) 10Bsitu: Allow defining clousre for notification icon path (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102783 (owner: 10Bsitu) [22:39:51] (03CR) 10Kaldari: [C: 04-1] "As the code comments indicate, removing the time for timestamps that were not recent was on purpose (as specified by the WMF UX team). If " [core] - 10https://gerrit.wikimedia.org/r/70763 (owner: 10Se4598) [22:44:18] (03PS15) 10Yurik: Initial implementation of the JSON configuration store. [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 [22:44:57] (03CR) 10BryanDavis: [C: 032] Include delayed job count in showJobs.php [core] - 10https://gerrit.wikimedia.org/r/102738 (owner: 10Aaron Schulz) [22:47:58] (03Merged) 10jenkins-bot: Include delayed job count in showJobs.php [core] - 10https://gerrit.wikimedia.org/r/102738 (owner: 10Aaron Schulz) [22:48:07] ori_: https://gerrit.wikimedia.org/r/#/c/102833/ [22:49:04] (03PS1) 10Legoktm: Allow icons to set different ltr/rtl versions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102834 [22:52:23] (03PS2) 10Legoktm: Allow icons to set different ltr/rtl versions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102834 [22:53:44] (03PS1) 10BryanDavis: Add jQuery sourcemap file [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102839 [22:56:15] csteipp_afk: if you have some time, could you take a look at https://gerrit.wikimedia.org/r/#/c/102635/1/CentralAuthHooks.php ? [22:56:19] (03PS3) 10EBernhardson: base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 [22:56:34] (03CR) 10jenkins-bot: [V: 04-1] base36 uuids [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102626 (owner: 10EBernhardson) [22:58:09] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/65162 (owner: 10Amire80) [22:59:50] Hi, on my fist week here l am wondering ... [23:00:05] do i need to be susbscribed to anything to get gerrit's e-mail [23:01:01] you have to be the owner, author or reviewer on a change to get all of the mail about it [23:01:08] (or star it) [23:01:32] (03CR) 10Siebrand: "Is this still relevant in any way? What needs to be done to get progress?" [core] - 10https://gerrit.wikimedia.org/r/75079 (owner: 10Pginer) [23:01:50] (03CR) 10Krinkle: "A -1 is perfectly in order, there was an issue. You fixed it in the next patch set https://gerrit.wikimedia.org/r/#/c/99524/2..3//COMMIT_M" [core] - 10https://gerrit.wikimedia.org/r/99524 (owner: 10Jdlrobson) [23:02:13] (03CR) 10Siebrand: "Is the aim still to get this merged? What needs to be done to get this moving again?" [extensions/EtherEditor] - 10https://gerrit.wikimedia.org/r/43100 (owner: 10SuchetaG) [23:02:52] (03CR) 10Siebrand: "Should this still get merged? What needs to be done to get this moving again?" [extensions/Agora] - 10https://gerrit.wikimedia.org/r/53353 (owner: 10Pginer) [23:03:35] very well, thanks [23:04:57] (03PS4) 10Bartosz Dziewoński: Create ChangesListSpecialPage as a base class for Watchlist and RC [core] - 10https://gerrit.wikimedia.org/r/102458 [23:04:57] (03PS6) 10Bartosz Dziewoński: SpecialWatchlist: Don't overwrite context now that we don't have to [core] - 10https://gerrit.wikimedia.org/r/94289 [23:04:57] (03PS8) 10Bartosz Dziewoński: SpecialWatchlist: Use FormOptions for parameter handling [core] - 10https://gerrit.wikimedia.org/r/94288 [23:04:57] (03PS6) 10Bartosz Dziewoński: SpecialWatchlist: JS enhancements to namespace selector (like RC) [core] - 10https://gerrit.wikimedia.org/r/94617 [23:04:58] (03PS10) 10Bartosz Dziewoński: Rename Watchlist request parameters for consistency with RC's ones [core] - 10https://gerrit.wikimedia.org/r/89380 [23:05:04] (03PS5) 10Bartosz Dziewoński: SpecialWatchlist: Synchronise some code with newer versions from RC [core] - 10https://gerrit.wikimedia.org/r/94628 [23:05:04] (03PS5) 10Bartosz Dziewoński: SpecialWatchlist: Reorder some stuff in #execute [core] - 10https://gerrit.wikimedia.org/r/94627 [23:05:04] (03PS5) 10Bartosz Dziewoński: SpecialWatchlist: Split #execute into subfunctions like SpecialRecentChanges [core] - 10https://gerrit.wikimedia.org/r/94677 [23:05:04] (03PS4) 10Bartosz Dziewoński: Always load 'mediawiki.special.changeslist' on SpecialRecentChanges and subclasses [core] - 10https://gerrit.wikimedia.org/r/97451 [23:05:04] (03PS10) 10Bartosz Dziewoński: Make SpecialWatchlist extend SpecialRecentChanges (temporarily) [core] - 10https://gerrit.wikimedia.org/r/89379 [23:05:28] i love rebases. [23:06:23] (03PS3) 10Legoktm: Allow icons to set different ltr/rtl versions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102834 [23:07:28] (03PS4) 10Bartosz Dziewoński: Move VectorBeta modules to VectorBeta extension. [core] - 10https://gerrit.wikimedia.org/r/99524 (owner: 10Jdlrobson) [23:08:11] (03CR) 10Bartosz Dziewoński: [C: 031] "I did not go through this in depth, but it looks reasonable. I messed with the commit message." [core] - 10https://gerrit.wikimedia.org/r/99524 (owner: 10Jdlrobson) [23:09:26] Aaron|home: i attached a sample xml file to that bug and some instructions that should help guide you through the toolset … hopefully that will help you spot what might be going on ... [23:09:40] closing for the night. have a good day/might [23:12:32] (03Abandoned) 10Yurik: Hide warning "Recursion detected in RequestContext::getLanguage" [core] - 10https://gerrit.wikimedia.org/r/102557 (owner: 10Yurik) [23:26:19] (03CR) 10Bsitu: [C: 032] Allow icons to set different ltr/rtl versions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102834 (owner: 10Legoktm) [23:26:28] (03Merged) 10jenkins-bot: Allow icons to set different ltr/rtl versions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102834 (owner: 10Legoktm) [23:27:34] (03Abandoned) 10EBernhardson: Allow icon paths to be resolved when requested [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102750 (owner: 10EBernhardson) [23:27:46] (03PS3) 10Bsitu: Add rtl and ltr icons for flow notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102790 [23:28:16] (03PS4) 10Bsitu: Add rtl and ltr icons for flow notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102790 [23:29:04] (03CR) 10Legoktm: [C: 031] Add rtl and ltr icons for flow notification (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102790 (owner: 10Bsitu) [23:30:02] (03PS5) 10Bsitu: Add rtl and ltr icons for flow notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102790 [23:30:24] (03CR) 10Legoktm: [C: 032] Add rtl and ltr icons for flow notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102790 (owner: 10Bsitu) [23:30:30] (03Merged) 10jenkins-bot: Add rtl and ltr icons for flow notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102790 (owner: 10Bsitu) [23:33:30] (03Abandoned) 10Spage: Revert "Allow defining clousre for notification icon path" , going to improve it. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/102830 (owner: 10Spage) [23:43:23] (03PS1) 10Yurik: Added ApiResult::NO_SIZE_CHECK flag for addValue() [core] - 10https://gerrit.wikimedia.org/r/102845 [23:51:57] (03PS1) 10Ori.livneh: Update WikimediaEvents to master [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102849 [23:53:39] (03CR) 10Ori.livneh: [C: 032] Update WikimediaEvents to master [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102849 (owner: 10Ori.livneh) [23:56:10] (03CR) 10CSteipp: Autocreate global account after rename (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/102635 (owner: 10Legoktm) [23:57:31] (03Merged) 10jenkins-bot: Update WikimediaEvents to master [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102849 (owner: 10Ori.livneh) [23:59:43] (03PS1) 10Bsitu: Add rtl and ltr icons for flow notification [extensions/Flow] (wmf/1.23wmf8) - 10https://gerrit.wikimedia.org/r/102851