[00:00:23] <grrrit-wm>	 (03CR) 10Platonides: [C: 032] "Good work" [core] - 10https://gerrit.wikimedia.org/r/102121 (owner: 10Theopolisme)
[00:02:30] <Aaron|home>	 man that function is long
[00:02:36] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Remove lint jobs from mediawiki-core postmerge pipeline [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102337 (owner: 10Krinkle)
[00:03:19] <grrrit-wm>	 (03PS3) 10TTO: Replace hidesig module with a more robust implementation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102076 
[00:04:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove lint jobs from mediawiki-core postmerge pipeline [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102337 (owner: 10Krinkle)
[00:04:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fixed error in LocalRepo::findFiles() [core] - 10https://gerrit.wikimedia.org/r/102303 (owner: 10Aaron Schulz)
[00:04:30] <grrrit-wm>	 (03CR) 10TTO: "Do I need to subscribe to the mailing list to send messages to it?" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/76460 (owner: 10TTO)
[00:04:41] <grrrit-wm>	 (03PS1) 10BryanDavis: Make fields with validation errors more prominent [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102355 
[00:06:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add raw HTML output functionality [core] - 10https://gerrit.wikimedia.org/r/102121 (owner: 10Theopolisme)
[00:07:09] <grrrit-wm>	 (03CR) 10BryanDavis: Make fields with validation errors more prominent (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102355 (owner: 10BryanDavis)
[00:07:35] <grrrit-wm>	 (03PS3) 10Platonides: Make checkPHPExtension() load the extension when it's available. [core] - 10https://gerrit.wikimedia.org/r/97329 
[00:08:01] <grrrit-wm>	 (03CR) 10Springle: "This schema change will begin on Fri 20th." [core] - 10https://gerrit.wikimedia.org/r/101170 (owner: 10Aaron Schulz)
[00:08:05] <grrrit-wm>	 (03PS2) 10Bsitu: Add flow specific exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100524 
[00:08:42] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Make SVG language selector "use default lang" actually work [core] - 10https://gerrit.wikimedia.org/r/101493 (owner: 10Brian Wolff)
[00:08:42] <grrrit-wm>	 (03PS12) 10EBernhardson: Better GENDER support in moderation.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 (owner: 10Amire80)
[00:08:53] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] "PS12: Updated commit message to match current state of the patch." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 (owner: 10Amire80)
[00:08:55] <grrrit-wm>	 (03PS3) 10Platonides: Replace a bunch of extension_loaded() checks with checkPHPExtension() [core] - 10https://gerrit.wikimedia.org/r/97330 
[00:09:25] <grrrit-wm>	 (03CR) 10Platonides: "PS3: Rebased and fixed conflict with 3c57bec275accde0ca403d6e186806efae2fb6df" [core] - 10https://gerrit.wikimedia.org/r/97330 (owner: 10Platonides)
[00:09:26] <grrrit-wm>	 (03CR) 10Springle: "Update: the indexing changes are about 50% done in production. Estimate two more days." [core] - 10https://gerrit.wikimedia.org/r/85508 (owner: 10Jackmcbarn)
[00:09:33] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032] Add space between '[Show]' and 'Hidden by User' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102136 (owner: 10Matthias Mullie)
[00:09:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add flow specific exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100524 (owner: 10Bsitu)
[00:10:01] <grrrit-wm>	 (03Abandoned) 10EBernhardson: Ensure non-binary cache keys [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98993 (owner: 10EBernhardson)
[00:11:05] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 04-1] "Is there actually a load problem now? It is indeed useful to log starts for jobs that timeout or fatal out." [core] - 10https://gerrit.wikimedia.org/r/102332 (owner: 10Hashar)
[00:11:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Better GENDER support in moderation.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 (owner: 10Amire80)
[00:12:29] <grrrit-wm>	 (03PS5) 10TTO: Hide edit toolbar Signature button in content namespaces by default [core] - 10https://gerrit.wikimedia.org/r/87649 
[00:13:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make SVG language selector "use default lang" actually work [core] - 10https://gerrit.wikimedia.org/r/101493 (owner: 10Brian Wolff)
[00:13:33] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Fetch latest title content from API instead of relying on (old) html [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101001 (owner: 10Matthias Mullie)
[00:13:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add space between '[Show]' and 'Hidden by User' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102136 (owner: 10Matthias Mullie)
[00:15:50] <grrrit-wm>	 (03CR) 10MaxSem: [V: 032] Initial conversion of prop=extracts from MobileFrontend [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/102305 (owner: 10MaxSem)
[00:17:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fetch latest title content from API instead of relying on (old) html [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101001 (owner: 10Matthias Mullie)
[00:17:54] <grrrit-wm>	 (03PS1) 10Reedy: Use more usual maintenance initiali[sz]ation code [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102357 
[00:18:19] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] (bug 42837) AFT uses dangerously generic class names like 'buttons' [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/64084 (owner: 10Matthias Mullie)
[00:18:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] (bug 42837) AFT uses dangerously generic class names like 'buttons' [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/64084 (owner: 10Matthias Mullie)
[00:22:38] <grrrit-wm>	 (03PS1) 10Bsitu: Declare getRevisionType() as abstract in base revision class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102358 
[00:27:54] <grrrit-wm>	 (03PS1) 10Reedy: Remove numerous unused variables, parameters etc [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102359 
[00:33:27] <grrrit-wm>	 (03PS4) 10Reedy: Remove some of the permissions so they can be configured per-wiki [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102343 (owner: 10Brian Wolff)
[00:34:04] <Reedy>	 The casing of the GWToolset code irritates me
[00:43:46] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 032] Use more usual maintenance initiali[sz]ation code [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102357 (owner: 10Reedy)
[00:43:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use more usual maintenance initiali[sz]ation code [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102357 (owner: 10Reedy)
[00:44:38] <Reedy>	 Warning:  array_merge() [<a href='function.array-merge'>function.array-merge</a>]: Argument #2 is not an array in /usr/local/apache/common-local/wmf-config/CommonSettings.php on line 2552
[00:45:18] <Reedy>	 $wgExemptFromUserRobotsControl = array_merge( $wgContentNamespaces, $wmgExemptFromUserRobotsControlExtra );
[00:45:28] <mwalker>	 spagewmf: ! you just updated a bug about the special:version api! want to review some code! :D
[00:45:41] <Reedy>	 'wmgExemptFromUserRobotsControlExtra' => array(
[00:45:41] <Reedy>	         'default' => array(),
[00:45:41] <Reedy>	         'enwiki' => array( 118, 119 ), // draft and draft talk
[00:45:41] <Reedy>	 ),
[00:47:26] <Reedy>	 mumble mumble php warnings mumble mumble
[00:47:46] <bd808>	 Reedy: Yeah. the code style that Dan picked is "interesting"
[00:48:23] <Reedy>	 There seems to be a lot of verbosity too
[00:48:34] <Reedy>	 5 or 10 lines could be replaced by a couple of php functions
[00:55:31] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Added simpler handleError() method RedisConnectionPool [core] - 10https://gerrit.wikimedia.org/r/102361 
[00:56:27] <Aaron|home>	 Reedy: I like how the extension credits used to be build using Config, and passed through Filter :)
[00:56:31] <Aaron|home>	 *built
[00:59:31] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Remove 'parse' prefix from ApiParsoidUtilsFlow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102045 (owner: 10Legoktm)
[01:00:14] <grrrit-wm>	 (03PS2) 10EBernhardson: Require getRevisionType in classes that extend AbstractRevision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102156 (owner: 10Matthias Mullie)
[01:00:31] <grrrit-wm>	 (03CR) 10EBernhardson: "PS2: Rebase on master" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102156 (owner: 10Matthias Mullie)
[01:00:45] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Require getRevisionType in classes that extend AbstractRevision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102156 (owner: 10Matthias Mullie)
[01:00:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Require getRevisionType in classes that extend AbstractRevision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102156 (owner: 10Matthias Mullie)
[01:04:41] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 04-1] "Same concern as matthias, we want both title and workflow id in many instances." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102025 (owner: 10Legoktm)
[01:04:49] <grrrit-wm>	 (03PS2) 10Legoktm: Don't dynamically define $container [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102027 
[01:05:09] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Don't dynamically define $container [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102027 (owner: 10Legoktm)
[01:05:11] <grrrit-wm>	 (03Abandoned) 10Bsitu: Declare getRevisionType() as abstract in base revision class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102358 (owner: 10Bsitu)
[01:05:51] <grrrit-wm>	 (03CR) 10GWicke: [C: 04-1] "Could you open a bug for this? Handling the empty fragment like any other fragment sounds fine to me. Lets fix this and add a passing test" [core] - 10https://gerrit.wikimedia.org/r/98119 (owner: 10Bartosz Dziewoński)
[01:06:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't dynamically define $container [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102027 (owner: 10Legoktm)
[01:18:01] <Reedy>	 if ( $action === 'create' && $title->getNamespace() === 118 && $user->isAnon() ) {
[01:18:06] <Reedy>	 Didn't I simplify that once already?
[01:18:19] <legoktm>	 how do you simplify that?
[01:18:56] <Reedy>	 Code after it
[01:18:58] <Reedy>	 4 lines into 1
[01:19:09] <Reedy>	 +    if ( $action === 'create' && $title->getNamespace() === 118 && $user->isAnon() ) {
[01:19:10] <Reedy>	  +      return false;
[01:19:10] <Reedy>	  +    }
[01:19:10] <Reedy>	  +    return true;
[01:19:18] <legoktm>	 lol
[01:19:26] <Reedy>	 This code looks very familiar
[01:19:32] <Reedy>	 What the hell did I change recently like this
[01:19:55] <grrrit-wm>	 (03PS3) 10Hoo man: Add mw.html to Scribunto [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 
[01:21:25] <grrrit-wm>	 (03CR) 10Hoo man: Add mw.html to Scribunto (0314 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man)
[01:21:44] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add mw.html to Scribunto [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man)
[01:21:55] <grrrit-wm>	 (03CR) 10Hoo man: "Addressed almost all of Anomie's comments. This is going to be in mw.html per default now." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man)
[01:24:19] <grrrit-wm>	 (03CR) 10Bsitu: [C: 032] Support non-English namespace names in DiscussionParser::getUserFromLine [extensions/Echo] - 10https://gerrit.wikimedia.org/r/87477 (owner: 10Legoktm)
[01:24:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Support non-English namespace names in DiscussionParser::getUserFromLine [extensions/Echo] - 10https://gerrit.wikimedia.org/r/87477 (owner: 10Legoktm)
[01:26:13] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 04-1] "Anything that operates on a post also needs to check the topic title for view permissions. The basic principle here is that if a topic ha" (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102201 (owner: 10Matthias Mullie)
[01:26:44] <grrrit-wm>	 (03PS4) 10Hoo man: Add mw.html to Scribunto [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 
[01:27:25] <grrrit-wm>	 (03CR) 10Hoo man: "Forgot to unset the mw_interface global." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man)
[01:28:59] <grrrit-wm>	 (03PS1) 10Brian Wolff: Don't require midi output in raw mode if not linking to it [extensions/Score] - 10https://gerrit.wikimedia.org/r/102367 
[01:32:05] <grrrit-wm>	 (03CR) 10EBernhardson: Use FlowAction permissions in AbstractRevision (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102154 (owner: 10Matthias Mullie)
[01:32:21] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 031] "Seems good enough, but depends on other patches." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102154 (owner: 10Matthias Mullie)
[01:33:53] <grrrit-wm>	 (03PS5) 10Hoo man: Add mw.html to Scribunto [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 
[01:39:00] <grrrit-wm>	 (03PS1) 10BryanDavis: Add new question [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102370 
[01:54:12] <grrrit-wm>	 (03PS4) 10Chad: Respect revision deletion in CirrusSearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101447 
[01:54:14] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Respect revision deletion in CirrusSearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101447 (owner: 10Chad)
[01:54:29] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Respect revision deletion in CirrusSearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101447 (owner: 10Chad)
[01:54:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Respect revision deletion in CirrusSearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101447 (owner: 10Chad)
[02:02:31] <grrrit-wm>	 (03PS1) 10BryanDavis: Give user a visible warning when save fails [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102373 
[02:24:53] <grrrit-wm>	 (03CR) 10Legoktm: "Yes." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/76460 (owner: 10TTO)
[02:25:49] <grrrit-wm>	 (03PS1) 10BryanDavis: Text updates [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102375 
[02:32:29] <grrrit-wm>	 (03CR) 10Bsitu: Load usernames directly from wiki's in batches (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 (owner: 10EBernhardson)
[02:41:08] <grrrit-wm>	 (03PS1) 10Legoktm: Remove "@todo Do not release 1.19 with this." [core] - 10https://gerrit.wikimedia.org/r/102378 
[02:43:35] <Reedy>	 Fatal error:  Call to a member function getParserOutput() on a non-object in /usr/local/apache/common-local/php-1.23wmf6/extensions/FlaggedRevs/backend/FlaggedRevs.class.php on line 541
[02:43:39] <Reedy>	 That feels deja vu too
[02:51:29] <grrrit-wm>	 (03PS1) 10Legoktm: Don't rely on array() == null [core] - 10https://gerrit.wikimedia.org/r/102380 
[02:54:20] <Reedy>	 AaronSchulz: https://bugzilla.wikimedia.org/show_bug.cgi?id=55471
[02:54:29] <Reedy>	 I'm quite amused that revision has a length of 42
[03:09:47] <grrrit-wm>	 (03PS8) 10EBernhardson: Load usernames directly from wiki's in batches [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 
[03:09:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Load usernames directly from wiki's in batches [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 (owner: 10EBernhardson)
[03:14:09] <grrrit-wm>	 (03PS9) 10EBernhardson: Load usernames directly from wiki's in batches [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 
[03:26:32] <grrrit-wm>	 (03PS2) 10BryanDavis: Localize final form of scholarships app [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102307 (owner: 10Chad)
[03:29:48] <grrrit-wm>	 (03CR) 10BryanDavis: "Rebased manually on my every growing patch chain and fixed the things that I complained about in Chad's initial patch." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102307 (owner: 10Chad)
[03:30:23] <grrrit-wm>	 (03PS1) 10Mattflaschen: Fix hook registration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102381 
[03:31:32] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Fix hook registration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102381 (owner: 10Mattflaschen)
[03:31:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix hook registration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102381 (owner: 10Mattflaschen)
[03:31:37] <Reedy>	 superm401: That looks like an oopsy
[03:32:35] <superm401>	 Reedy, yeah, it was breaking Beta Labs.
[03:34:15] <grrrit-wm>	 (03CR) 10Reedy: Respect revision deletion in CirrusSearch (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101447 (owner: 10Chad)
[03:34:19] <Reedy>	 "only" labs at least
[03:34:31] <Reedy>	 I presume..
[03:35:19] <Reedy>	 Yup, not in productionm
[04:04:42] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Don't try to use the now removed ipbreasonotherlist message [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/102350 (owner: 10Hoo man)
[04:04:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't try to use the now removed ipbreasonotherlist message [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/102350 (owner: 10Hoo man)
[04:34:33] <grrrit-wm>	 (03PS2) 10Tinaj1234: Corrected memcached.txt in MediaWiki 1.22 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102163 
[04:37:44] <diwanship>	 hello yurik or yurik-road
[04:37:52] <yurik-road>	 hi diwanship
[04:38:21] <diwanship>	 :) pls review the changes https://etherpad.wikimedia.org/p/codeacademy-diwanship
[04:38:26] <diwanship>	 sry not this
[04:38:34] <diwanship>	 http://www.codecademy.com/courses/web-intermediate-en-BLea4/0/9
[04:41:43] <grrrit-wm>	 (03PS1) 10Legoktm: Don't show skin names if the user can't enable them [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/102383 
[04:47:45] <diwanship>	 yurik-road2 hello did you get the link?
[04:48:44] <yurik-road2>	 diwanship, sorry connection issues, got the link.  Btw, sometimes the HTML is not simple ;)
[04:49:28] <yurik-road2>	 diwanship, do you think the first example should not be multi-lined? you might be right
[04:49:47] <yurik-road2>	 btw, please revise your instructions - they don't format right
[04:50:38] <yurik-road2>	 but i wouldn't put <br> in there - makes things a bit more complex
[04:50:43] <diwanship>	 yurik-road2 yes to show the difference between bold and normal i made it multilined
[04:51:10] <diwanship>	 i think it should be one sentence only. 
[04:51:40] <yurik-road2>	 I think something like    "Some text could be '''bold''', ''italic'', or '''''both'''''."
[04:51:47] <yurik-road2>	 would be better?
[04:51:52] <yurik-road2>	 simple one sentence?
[04:52:15] <yurik-road2>	 btw, i don't know the ultimate answer on all this :)
[04:52:32] <yurik-road2>	 diwanship, but please fix the instructions on the side - they don't show correctly
[04:52:56] <diwanship>	 yurik-road2 yes i was thinking of the same thing but then what would user enter to modify?
[04:54:06] <diwanship>	 just a string change would be ok??
[04:54:08] <yurik-road2>	 Ask them to add a link to the external site using wiki notation - [http://www.wikipedia.org Wikipedia]
[04:54:27] <yurik-road2>	 this way they will learn to add links, and you can add it into a hint
[04:54:49] <diwanship>	 yurik-road2 ok got it
[05:07:59] <grrrit-wm>	 (03CR) 10GWicke: [C: 031] "Looks good at a first cursory look." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/101226 (owner: 10Aaron Schulz)
[05:13:18] <grrrit-wm>	 (03Abandoned) 10Tinaj1234: Removed indentation button from WikiEditor extension [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102101 (owner: 10Tinaj1234)
[05:20:50] <grrrit-wm>	 (03PS1) 10Legoktm: Fix spacing [core] - 10https://gerrit.wikimedia.org/r/102387 
[05:22:58] <grrrit-wm>	 (03Abandoned) 10Tinaj1234: Removed the indentation button from the WikiEditor toolbar. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/93665 (owner: 10Tinaj1234)
[05:24:56] <diwanship>	 yurik-road2  did the changes . you can check now http://www.codecademy.com/courses/web-intermediate-en-BLea4/0/9
[05:32:03] <diwanship>	 yurik (i think yurik-road2 isn't working) did the changes . you can check now http://www.codecademy.com/courses/web-intermediate-en-BLea4/0/9
[05:38:55] <grrrit-wm>	 (03PS2) 10BryanDavis: Rewrite i18n support to use new json format [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102315 (owner: 10Chad)
[05:40:27] <grrrit-wm>	 (03CR) 10BryanDavis: "Rebased, updated and tested. Now with 100% workingness." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102315 (owner: 10Chad)
[05:48:15] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Text updates [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102375 (owner: 10BryanDavis)
[05:50:43] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Fix html escaping problem with post-deadline message [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102300 (owner: 10BryanDavis)
[05:50:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix html escaping problem with post-deadline message [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102300 (owner: 10BryanDavis)
[05:53:14] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Add new question [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102370 (owner: 10BryanDavis)
[05:53:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add new question [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102370 (owner: 10BryanDavis)
[05:53:45] <grrrit-wm>	 (03PS1) 10BryanDavis: Add configuration setting for twig cache [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102391 
[05:56:16] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Add configuration setting for twig cache [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102391 (owner: 10BryanDavis)
[05:56:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add configuration setting for twig cache [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102391 (owner: 10BryanDavis)
[06:00:39] <grrrit-wm>	 (03PS1) 10Krinkle: Create mwext-VisualEditor-npm job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102392 
[06:02:03] <grrrit-wm>	 (03PS2) 10Ori.livneh: Make reviewer ratings range from 0 to 10 [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102351 (owner: 10BryanDavis)
[06:02:24] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] "Doesn't go to 11, sadly." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102351 (owner: 10BryanDavis)
[06:02:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make reviewer ratings range from 0 to 10 [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102351 (owner: 10BryanDavis)
[06:02:43] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] "Pushed mwext-VisualEditor-npm to Jenkins." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102392 (owner: 10Krinkle)
[06:03:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Create mwext-VisualEditor-npm job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102392 (owner: 10Krinkle)
[06:03:42] <yurik>	 diwanship, i think that's better (only please reread your text - there is some strtange capitalization)
[06:04:21] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Make fields with validation errors more prominent [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102355 (owner: 10BryanDavis)
[06:04:23] <yurik>	 diwanship, have you had a chance to email them?
[06:04:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make fields with validation errors more prominent [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102355 (owner: 10BryanDavis)
[06:05:23] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Remove pointless function [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/102295 (owner: 10Chad)
[06:05:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove pointless function [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/102295 (owner: 10Chad)
[06:08:29] <grrrit-wm>	 (03PS1) 10Krinkle: Enable mwext-VisualEditor-npm, disable -jslint, -csslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102394 
[06:09:02] <grrrit-wm>	 (03PS1) 10Krinkle: Enable mwext-VisualEditor-npm, disable -jslint, -csslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102395 
[06:09:32] <grrrit-wm>	 (03Abandoned) 10Krinkle: Enable mwext-VisualEditor-npm, disable -jslint, -csslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102394 (owner: 10Krinkle)
[06:10:57] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Enable mwext-VisualEditor-npm, disable -jslint, -csslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102395 (owner: 10Krinkle)
[06:11:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Enable mwext-VisualEditor-npm, disable -jslint, -csslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102395 (owner: 10Krinkle)
[06:14:45] <diwanship>	 yurik yes i am going to mail them today itself i will cc you
[06:19:03] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Give user a visible warning when save fails [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102373 (owner: 10BryanDavis)
[06:19:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Give user a visible warning when save fails [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102373 (owner: 10BryanDavis)
[06:19:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Text updates [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102375 (owner: 10BryanDavis)
[06:22:13] <grrrit-wm>	 (03CR) 10Aaron Schulz: Removed cloudfiles dependency in SwiftFileBackend (031 comment) [core] - 10https://gerrit.wikimedia.org/r/101226 (owner: 10Aaron Schulz)
[06:23:16] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Rewrite i18n support to use new json format [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102315 (owner: 10Chad)
[06:24:09] <grrrit-wm>	 (03PS3) 10Ori.livneh: Localize final form of scholarships app [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102307 (owner: 10Chad)
[06:24:40] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Localize final form of scholarships app [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102307 (owner: 10Chad)
[06:24:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Localize final form of scholarships app [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102307 (owner: 10Chad)
[06:28:49] <grrrit-wm>	 (03PS3) 10BryanDavis: Rewrite i18n support to use new json format [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102315 (owner: 10Chad)
[06:30:38] <grrrit-wm>	 (03CR) 10Nikerabbit: [C: 032] Fix spacing [core] - 10https://gerrit.wikimedia.org/r/102387 (owner: 10Legoktm)
[06:33:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix spacing [core] - 10https://gerrit.wikimedia.org/r/102387 (owner: 10Legoktm)
[06:59:00] <grrrit-wm>	 (03PS2) 10IAlex: Remove "@todo Do not release 1.19 with this." [core] - 10https://gerrit.wikimedia.org/r/102378 (owner: 10Legoktm)
[06:59:06] <grrrit-wm>	 (03CR) 10IAlex: [C: 032] Remove "@todo Do not release 1.19 with this." [core] - 10https://gerrit.wikimedia.org/r/102378 (owner: 10Legoktm)
[06:59:41] <grrrit-wm>	 (03PS2) 10IAlex: Don't rely on array() == null [core] - 10https://gerrit.wikimedia.org/r/102380 (owner: 10Legoktm)
[07:04:00] <cortexA9>	 hello
[07:04:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove "@todo Do not release 1.19 with this." [core] - 10https://gerrit.wikimedia.org/r/102378 (owner: 10Legoktm)
[07:05:18] <grrrit-wm>	 (03CR) 10IAlex: [C: 032] Don't rely on array() == null [core] - 10https://gerrit.wikimedia.org/r/102380 (owner: 10Legoktm)
[07:05:19] <grrrit-wm>	 (03CR) 10TTO: WIP: Allow Skins to define other HTML tag attributes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100920 (owner: 10Jdlrobson)
[07:06:31] <grrrit-wm>	 (03PS13) 10Yurik: Initial implementation of the JSON configuration store. [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 
[07:09:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't rely on array() == null [core] - 10https://gerrit.wikimedia.org/r/102380 (owner: 10Legoktm)
[07:29:18] <grrrit-wm>	 (03CR) 10Krinkle: Hide edit toolbar Signature button in content namespaces by default (031 comment) [core] - 10https://gerrit.wikimedia.org/r/87649 (owner: 10TTO)
[07:34:00] <grrrit-wm>	 (03PS4) 10Krinkle: Replace hidesig module with a more robust implementation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102076 (owner: 10TTO)
[07:35:23] <grrrit-wm>	 (03CR) 10Legoktm: Hide edit toolbar Signature button in content namespaces by default (031 comment) [core] - 10https://gerrit.wikimedia.org/r/87649 (owner: 10TTO)
[07:35:44] <grrrit-wm>	 (03CR) 10Krinkle: mediawiki.hlist: Use mw.hook( 'wikipage.content' ) in JS fallback (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96239 (owner: 10Bartosz Dziewoński)
[07:36:01] <grrrit-wm>	 (03PS4) 10Krinkle: Added Jenkins tests for commits to new Parsoid repo. [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/101460 (owner: 10Subramanya Sastry)
[07:39:29] <grrrit-wm>	 (03CR) 10TTO: Hide edit toolbar Signature button in content namespaces by default (031 comment) [core] - 10https://gerrit.wikimedia.org/r/87649 (owner: 10TTO)
[07:42:55] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102076 (owner: 10TTO)
[07:50:24] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "L10n reviewed." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100524 (owner: 10Bsitu)
[07:55:35] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "Cool beans." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102315 (owner: 10Chad)
[08:16:54] <grrrit-wm>	 (03PS1) 10Tpt: Makes zoom system work with IE 8 [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/102401 
[08:23:38] <grrrit-wm>	 (03CR) 10Tpt: "The content handler system use the message content-model-NAME_OF_THE_CONTENT_MODEL to output a nice name for a content model in the Conten" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101678 (owner: 10Tpt)
[08:38:06] <grrrit-wm>	 (03CR) 10Siebrand: "@matt: That appears to have been something that slipped through the cracks, and is less of a problem since the message is marked as ignore" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/100534 (owner: 10Mattflaschen)
[08:46:25] <grrrit-wm>	 (03CR) 10Physikerwelt: "Thank you for your comments" (0331 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt)
[09:23:11] <grrrit-wm>	 (03CR) 10Hashar: "Blocked by parsertests not being runnable in parralel https://bugzilla.wikimedia.org/show_bug.cgi?id=58094" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102152 (owner: 10Hashar)
[09:42:21] <grrrit-wm>	 (03CR) 10TTO: Hide edit toolbar Signature button in content namespaces by default (031 comment) [core] - 10https://gerrit.wikimedia.org/r/87649 (owner: 10TTO)
[09:59:03] <grrrit-wm>	 (03PS14) 10Yurik: Initial implementation of the JSON configuration store. [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 
[10:05:43] <grrrit-wm>	 (03PS1) 10Yurik: Added JsonConfig extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102410 
[10:28:28] <grrrit-wm>	 (03PS2) 10Dan-nl: Remove numerous unused variables, parameters etc [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102359 (owner: 10Reedy)
[10:29:32] <grrrit-wm>	 (03CR) 10Dan-nl: [C: 032 V: 032] "- parameter MediawikiTemplate $MediawikiTemplate needed to be removed from XmlDetectHandler->getMetadataAsTableCells()" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102359 (owner: 10Reedy)
[10:30:01] <grrrit-wm>	 (03PS1) 10Yurik: Added JsonConfig [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102414 
[10:30:27] <grrrit-wm>	 (03PS2) 10Yurik: Added JsonConfig extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102410 
[10:30:35] <grrrit-wm>	 (03PS2) 10Yurik: Added JsonConfig [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102414 
[10:39:57] <grrrit-wm>	 (03PS2) 10Hashar: Add Scribunto as dependency for Wikibase (client) tests [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102109 (owner: 10Aude)
[10:41:27] <grrrit-wm>	 (03PS3) 10Hashar: Add Scribunto as dependency for Wikibase (client) tests [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102109 (owner: 10Aude)
[10:41:54] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "being deployed :-)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102109 (owner: 10Aude)
[10:42:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add Scribunto as dependency for Wikibase (client) tests [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102109 (owner: 10Aude)
[11:19:02] <grrrit-wm>	 (03PS3) 10Hashar: Bug 57913 - Added JsonConfig extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102410 (owner: 10Yurik)
[11:19:04] <grrrit-wm>	 (03CR) 10Helder.wiki: "FYI: Some scripts used in various Wikipedias stoped working after this change:" [core] - 10https://gerrit.wikimedia.org/r/94899 (owner: 10Amire80)
[11:19:29] <grrrit-wm>	 (03PS4) 10Hashar: Bug 57913 - Added JsonConfig extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102410 (owner: 10Yurik)
[11:21:07] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "jobs deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102410 (owner: 10Yurik)
[11:21:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Added JsonConfig extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102410 (owner: 10Yurik)
[11:22:04] <grrrit-wm>	 (03PS3) 10Hashar: Added JsonConfig extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102414 (owner: 10Yurik)
[11:22:54] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Added JsonConfig extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102414 (owner: 10Yurik)
[11:23:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Added JsonConfig extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102414 (owner: 10Yurik)
[11:25:07] <grrrit-wm>	 (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/102420 
[11:25:16] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/102420 (owner: 10Hashar)
[11:26:38] <grrrit-wm>	 (03CR) 10Nikerabbit: "Some scripts? I see only one, FA broken in multiple wikis, and that is because it assumed that the given element has one class and one cla" [core] - 10https://gerrit.wikimedia.org/r/94899 (owner: 10Amire80)
[11:26:54] <grrrit-wm>	 (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/102420 (owner: 10Hashar)
[11:28:47] <grrrit-wm>	 (03PS1) 10Dan-nl: adding additional namespace test [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102423 
[11:29:39] <yurik>	 Nikerabbit, i added some examples to https://www.mediawiki.org/wiki/Requests_for_comment/Json_Config_pages_in_wiki
[11:32:05] <werdna>	 howdy howdy
[11:44:24] <grrrit-wm>	 (03CR) 10Helder.wiki: "Sorry, the other script was this:" [core] - 10https://gerrit.wikimedia.org/r/94899 (owner: 10Amire80)
[11:53:45] <DanielK_WMDE>	 oy! werdna!
[11:54:51] * werdna  hides

[11:54:52] <werdna>	 wassup DanielK_WMDE 
[11:55:37] <DanielK_WMDE>	 breaking the code just before everyone goes off for the holidays, what else :)
[11:58:12] <werdna>	 of course :P
[11:58:17] <werdna>	 how's Daniel life?
[11:58:20] <werdna>	 what're you doing for christmas
[12:23:01] <grrrit-wm>	 (03CR) 10Helder.wiki: "I sent a message to" [core] - 10https://gerrit.wikimedia.org/r/94899 (owner: 10Amire80)
[12:29:07] <grrrit-wm>	 (03CR) 10Phe: [C: 031] Makes zoom system work with IE 8 [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/102401 (owner: 10Tpt)
[12:31:42] <Niharika>	 Hello. 
[12:32:25] <grrrit-wm>	 (03PS1) 10Aude: add separate job for Wikibase-Scribunto [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102427 
[12:32:59] <grrrit-wm>	 (03CR) 10Manybubbles: "Thanks! I hate missing this stuff. Normally those regression tests do a great job of catching this but the problem with the revdel stuff" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102381 (owner: 10Mattflaschen)
[12:33:41] <grrrit-wm>	 (03CR) 10Tpt: [C: 032] "Reviewed by Phe" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/102401 (owner: 10Tpt)
[12:33:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Makes zoom system work with IE 8 [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/102401 (owner: 10Tpt)
[12:34:14] <grrrit-wm>	 (03PS1) 10Aude: Make Wikibase client-scribunto tests non-voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102428 
[12:34:35] <aude>	 hashar: seems the scribunto tests are not ready to be voting with wikibase
[12:35:40] <aude>	 hashar: nevermind
[12:36:12] <grrrit-wm>	 (03Abandoned) 10Aude: add separate job for Wikibase-Scribunto [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102427 (owner: 10Aude)
[12:36:46] <grrrit-wm>	 (03Abandoned) 10Aude: Make Wikibase client-scribunto tests non-voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102428 (owner: 10Aude)
[12:38:45] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Lol." [core] - 10https://gerrit.wikimedia.org/r/102378 (owner: 10Legoktm)
[13:39:44] <grrrit-wm>	 (03PS5) 10Inchikutty: Replacing 'show on map' button with a link [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/101029 
[13:46:33] <grrrit-wm>	 (03CR) 10Nikerabbit: "The is a lang attribute on the link inside." [core] - 10https://gerrit.wikimedia.org/r/94899 (owner: 10Amire80)
[13:48:43] <grrrit-wm>	 (03CR) 10Siebrand: "I'd prefer the numbers to be used, and to not add constants in the namespaces file." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102423 (owner: 10Dan-nl)
[14:04:02] <grrrit-wm>	 (03PS1) 10Manybubbles: Update Cirrus to master [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/102434 
[14:07:13] <grrrit-wm>	 (03PS1) 10Manybubbles: Update Cirrus to master [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102436 
[14:14:38] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 (owner: 10Matthias Mullie)
[14:30:37] <grrrit-wm>	 (03CR) 10Siebrand: "In case you feel like fixing more extensions that have this same issue:" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/101055 (owner: 10Leaves in Motion)
[14:34:24] <grrrit-wm>	 (03PS10) 10Matthias Mullie: Add Flow events to Special:Contributions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99038 (owner: 10Werdna)
[14:34:51] <grrrit-wm>	 (03CR) 10Matthias Mullie: Add Flow events to Special:Contributions. (0311 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99038 (owner: 10Werdna)
[14:35:09] <grrrit-wm>	 (03CR) 10Matthias Mullie: Add Flow events to Special:Contributions. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99038 (owner: 10Werdna)
[14:42:47] <grrrit-wm>	 (03CR) 10Anomie: "Code itself seems ok. But I'm curious what the use case is for this." [core] - 10https://gerrit.wikimedia.org/r/102329 (owner: 10MaxSem)
[14:43:50] <grrrit-wm>	 (03CR) 10MaxSem: "1) We can do it now:)" [core] - 10https://gerrit.wikimedia.org/r/102329 (owner: 10MaxSem)
[14:44:03] <MaxSem>	 anomie, ^:)
[14:45:31] <anomie>	 MaxSem: So this is something Mobile is going to use?
[14:46:09] <grrrit-wm>	 (03PS2) 10Dan-nl: adding namespaces as numeric values to GWToolset.namespaces.php and simplifying the defined test in GWToolset.php [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102423 
[14:46:57] <MaxSem>	 yes - I was thinking about making action=parse&mobileformat set disabletoc to avoid an HTML parse
[14:47:33] <grrrit-wm>	 (03CR) 10Dan-nl: "- addressing siebrand’s comment in ps1" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102423 (owner: 10Dan-nl)
[14:48:52] <grrrit-wm>	 (03CR) 10Anomie: [C: 032] "Ok, mobile is a good use case." [core] - 10https://gerrit.wikimedia.org/r/102329 (owner: 10MaxSem)
[14:50:15] <MaxSem>	 thanks:)
[14:51:11] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Use UUID::BIN_LEN & HEX_LEN in getComparisonUUID [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102441 
[14:51:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use UUID::BIN_LEN & HEX_LEN in getComparisonUUID [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102441 (owner: 10Matthias Mullie)
[14:52:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: API: allow disabling TOC in action=parse [core] - 10https://gerrit.wikimedia.org/r/102329 (owner: 10MaxSem)
[14:52:54] <grrrit-wm>	 (03CR) 10Matthias Mullie: Add Flow events to Special:Contributions. (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99038 (owner: 10Werdna)
[14:54:50] <grrrit-wm>	 (03PS1) 10Manybubbles: Fix error in other index updates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102442 
[15:04:01] <grrrit-wm>	 (03PS4) 10Matthias Mullie: Use FlowAction permissions in AbstractRevision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102154 
[15:06:28] <grrrit-wm>	 (03CR) 10Matthias Mullie: "Switched dependencies, this one's ready to be merged now ;)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102154 (owner: 10Matthias Mullie)
[15:07:24] <grrrit-wm>	 (03CR) 10Chad: [C: 031] Update Cirrus to master [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/102434 (owner: 10Manybubbles)
[15:07:33] <grrrit-wm>	 (03CR) 10Chad: [C: 031] Update Cirrus to master [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102436 (owner: 10Manybubbles)
[15:07:54] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Fix error in other index updates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102442 (owner: 10Manybubbles)
[15:07:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix error in other index updates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102442 (owner: 10Manybubbles)
[15:30:44] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Filed bug 58647, but fixing it looks non-trivial to me; I'd prefer to have the test merged first." [core] - 10https://gerrit.wikimedia.org/r/98119 (owner: 10Bartosz Dziewoński)
[15:36:39] <grrrit-wm>	 (03CR) 10Gergő Tisza: "Some small issues. Also, the indentation looks weird." (034 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/101029 (owner: 10Inchikutty)
[15:43:01] <tonythomas01>	 Thehelpfulone: hi I was going through your bug https://bugzilla.wikimedia.org/show_bug.cgi?id=47689 . is this problem still existing ?
[15:43:30] <tonythomas01>	 Thehelpfulone: I meant, is it part of the extension ConfirmEdit ?
[16:10:02] <legoktm>	 MatmaRex: do you use the CologneBlue skin?
[16:10:38] <grrrit-wm>	 (03CR) 10Andrew Bogott: [C: 032 V: 032] Check the puppetstatus timestamp. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/102155 (owner: 10Andrew Bogott)
[16:11:51] <MatmaRex>	 legoktm: no, but i usually test my changes on it to see how they break on exotic stuff, why?
[16:12:20] <legoktm>	 MatmaRex: http://cl.ly/image/0E3o1D2H0W3w
[16:13:16] <legoktm>	 also this nightmare: http://cl.ly/image/372U0w0q0n30 (the legend is all weird)
[16:13:17] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Rename SpecialRecentchangeslinked → SpecialRecentChangesLinked [core] - 10https://gerrit.wikimedia.org/r/102449 
[16:15:06] <MatmaRex>	 whut
[16:15:06] <MatmaRex>	 why would people add all the interwiki to a special page
[16:15:06] <MatmaRex>	 this is why we can't have nice things
[16:15:06] <MatmaRex>	 and yeah lol, the notifications are funny
[16:17:44] <grrrit-wm>	 (03PS5) 10Manybubbles: Begin indexing file text from pdf/djvu files [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 (owner: 10Chad)
[16:19:41] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 04-1] "I'd love to hear from Deskana about what he thinks the text prepended to the result should be. -1 until then." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 (owner: 10Chad)
[16:32:59] <Reedy>	 bd808: What's with the {array} notation for type hints in GWToolset?
[16:33:07] <Reedy>	 I can't see anywhere else that does it
[16:33:26] <marktraceur>	 It's sort of JSDucky, maybe?
[16:33:33] <bd808>	 It's all dan-nl's invention AFAIK
[16:33:48] <Nikerabbit>	 php or js?
[16:33:58] <bd808>	 I'm sure he borrowed the style from somewhere
[16:34:11] <bd808>	 Nikerabbit: in php
[16:34:36] <Reedy>	 I'm particularly fond of calling class members their full class name in CamelCase
[16:34:59] <Reedy>	 $this->SomeClassName->bar();
[16:35:17] <marktraceur>	 Basically looks like jsduck, but poorly written? So basically jsduck.
[16:35:23] <marktraceur>	 (heyoooo)
[16:35:50] <Reedy>	 I herd u liel js, so i wrote js in your php..
[16:36:15] <marktraceur>	 Nothin' in the rules about a dog writing JS in a PHP file.
[16:36:29] <bd808>	 Dan has worked really hard on that project. It has some quirks but he's been great about fixing things when they have been explained to him.
[16:36:53] <Nikerabbit>	 $this->someClassName->bar()->getBeer();
[16:36:53] <grrrit-wm>	 (03PS1) 10Reedy: Couple of type hints [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102455 
[16:36:53] <marktraceur>	 *nod* it's a great project
[16:37:19] <MatmaRex>	 does anybody care about https://gerrit.wikimedia.org/r/#/c/101446/ ? :/
[16:37:39] <MatmaRex>	 i asked to have it backported and deployed, that's greenlighted by dan and greg, except that nobody bothered to review it yet :/
[16:37:58] <MatmaRex>	 (the other dan, not the one who was just mentioned.)
[16:38:17] <marktraceur>	 :/
[16:38:34] <dan-nl>	 Reedy: yes, i used the jsduck form of type hinting in the doc block {} i like it because i find it easier to identify the type in the comment block … 
[16:38:35] <marktraceur>	 MatmaRex: Backported and deployed today? 
[16:38:46] <MatmaRex>	 marktraceur: i asked last thursday, i think
[16:38:50] <marktraceur>	 Sigh.
[16:38:51] <robla>	 Reedy: ping
[16:38:53] <MatmaRex>	 i was hoping it would be backported and deployed on monday
[16:38:57] <MatmaRex>	 (the previous one, too)
[16:38:57] <Reedy>	 https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP#Comments_and_documentation
[16:39:05] <dan-nl>	 as far as the CamelCase, i use it for objects https://www.mediawiki.org/wiki/Extension:GWToolset/Technical_Implementation#Code_conventions
[16:39:06] <marktraceur>	 MatmaRex: I'll leave the window open and see what I can do.
[16:39:12] <MatmaRex>	 but i was too busy on monday and tuesday to poke people
[16:39:16] <MatmaRex>	 and that's apparently required :/
[16:39:30] <marktraceur>	 MatmaRex: Not required, I guess you just got lucky :)
[16:39:38] <marktraceur>	 But seriously I'll do what I can
[16:39:45] <MatmaRex>	 thanks
[16:40:05] <marktraceur>	 greg-g: If we backport MatmaRex's patch, can we LD it today?
[16:40:35] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-1] Add mw.html to Scribunto (0311 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man)
[16:40:39] <dan-nl>	 the js docs show the use of jsduck style, the php show the use of phpdoc style of type hinting … i prefer the {} as mentioned … if you want me to change the php docblocks so they don't use {} i can ...
[16:41:22] <dan-nl>	 and leave the js with the jsduck style
[16:41:44] <dan-nl>	 but i'd prefer to leave the {} in php if you're okay with that
[16:45:24] <grrrit-wm>	 (03PS5) 10Bartosz Dziewoński: SpecialWatchlist: Don't overwrite context now that we don't have to [core] - 10https://gerrit.wikimedia.org/r/94289 
[16:45:25] <grrrit-wm>	 (03PS7) 10Bartosz Dziewoński: SpecialWatchlist: Use FormOptions for parameter handling [core] - 10https://gerrit.wikimedia.org/r/94288 
[16:45:26] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: Make legend on Special:RecentChanges and Special:Watchlist collapsible [core] - 10https://gerrit.wikimedia.org/r/101446 
[16:45:27] <grrrit-wm>	 (03PS5) 10Bartosz Dziewoński: SpecialWatchlist: JS enhancements to namespace selector (like RC) [core] - 10https://gerrit.wikimedia.org/r/94617 
[16:45:28] <grrrit-wm>	 (03PS9) 10Bartosz Dziewoński: Rename Watchlist request parameters for consistency with RC's ones [core] - 10https://gerrit.wikimedia.org/r/89380 
[16:45:29] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: Rename SpecialRecentchangeslinked → SpecialRecentChangesLinked [core] - 10https://gerrit.wikimedia.org/r/102449 
[16:45:30] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: SpecialWatchlist: Synchronise some code with newer versions from RC [core] - 10https://gerrit.wikimedia.org/r/94628 
[16:45:31] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: SpecialWatchlist: Reorder some stuff in #execute [core] - 10https://gerrit.wikimedia.org/r/94627 
[16:45:32] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: SpecialWatchlist: Split #execute into subfunctions like SpecialRecentChanges [core] - 10https://gerrit.wikimedia.org/r/94677 
[16:45:33] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: Always load 'mediawiki.special.changeslist' on SpecialRecentChanges and subclasses [core] - 10https://gerrit.wikimedia.org/r/97451 
[16:45:34] <grrrit-wm>	 (03PS9) 10Bartosz Dziewoński: Make SpecialWatchlist extend SpecialRecentChanges (temporarily) [core] - 10https://gerrit.wikimedia.org/r/89379 
[16:45:35] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Create ChangesListSpecialPage as a base class for Watchlist and RC [core] - 10https://gerrit.wikimedia.org/r/102458 
[16:46:59] <MatmaRex>	 pow.
[16:47:10] <MatmaRex>	 somebody should start merging this stack.
[16:47:54] <greg-g>	 marktraceur: which one is that?
[16:47:55] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: Create ChangesListSpecialPage as a base class for Watchlist and RC [core] - 10https://gerrit.wikimedia.org/r/102458 
[16:48:09] <MatmaRex>	 greg-g: https://gerrit.wikimedia.org/r/#/c/101446/
[16:48:24] <greg-g>	 ah yeah, that :)
[16:49:43] <greg-g>	 MatmaRex: there's sufficient consensus or at least not any uproar about that, right?
[16:50:26] <MatmaRex>	 greg-g: well, nobody commented…
[16:50:31] <greg-g>	 but yeah, please add to wiki calendar, I have to run to a drs appt, will check in after
[16:50:37] <grrrit-wm>	 (03CR) 10Chad: Begin indexing file text from pdf/djvu files (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 (owner: 10Chad)
[16:51:18] <MatmaRex>	 greg-g: it would be great if you can get ahold of Krinkle|detached and ask him to look at it quickly
[16:51:38] <greg-g>	 marktraceur: can you help with that while I'm getting my son measured?
[16:51:47] <MatmaRex>	 since it's a pretty trivial change (just with lots of files touched, eh)
[16:51:51] * greg-g  goes

[16:52:41] <grrrit-wm>	 (03PS1) 10Hashar: whitelist Christian "qchris" Aistleitner [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102460 
[16:54:22] <grrrit-wm>	 (03PS2) 10Hashar: whitelist Christian "qchris" Aistleitner [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102460 
[16:54:26] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 031] Load usernames directly from wiki's in batches [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 (owner: 10EBernhardson)
[16:54:37] <grrrit-wm>	 (03PS1) 10Manybubbles: Add a unit test to check if it broke any hooks [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102461 
[16:55:24] <grrrit-wm>	 (03CR) 10Manybubbles: "Not sure if it is ok to add unit tests for something like this, especially when it checks things that could be broken by other extensions." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102461 (owner: 10Manybubbles)
[16:55:27] <grrrit-wm>	 (03CR) 10QChris: [C: 031] whitelist Christian "qchris" Aistleitner [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102460 (owner: 10Hashar)
[16:57:05] <grrrit-wm>	 (03PS2) 10Manybubbles: Add a unit test to check if it broke any hooks [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102461 
[16:57:36] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Done: https://meta.wikimedia.org/w/index.php?title=Tech/News/2013/51&diff=6776946&oldid=6774620" [core] - 10https://gerrit.wikimedia.org/r/95742 (owner: 10Bartosz Dziewoński)
[16:59:13] <grrrit-wm>	 (03PS6) 10Manybubbles: Begin indexing file text from pdf/djvu files [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 (owner: 10Chad)
[17:01:48] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] Update Cirrus to master [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102436 (owner: 10Manybubbles)
[17:05:19] <grrrit-wm>	 (03CR) 10Manybubbles: Begin indexing file text from pdf/djvu files (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 (owner: 10Chad)
[17:05:36] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 04-1] "still -1 until I hear that text is ok." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 (owner: 10Chad)
[17:14:23] <marktraceur>	 greg-g: I can!
[17:14:36] <marktraceur>	 You gotta keep an eye on those little uns
[17:14:42] <marktraceur>	 Can't let 'em grow unchecked
[17:14:48] <grrrit-wm>	 (03PS6) 10Inchikutty: Replacing 'show on map' button with a link [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/101029 
[17:15:40] <marktraceur>	 Hm, wait. MatmaRex, will this require a scap? :/
[17:16:11] <marktraceur>	 'cause it looks like new messages
[17:16:16] <MatmaRex>	 marktraceur: no idea. what requires a scap?
[17:16:17] <MatmaRex>	 ah, yeah
[17:16:29] <marktraceur>	 So, um
[17:16:32] <MatmaRex>	 then it probably will
[17:16:33] <marktraceur>	 That can't really be LD'd
[17:16:46] <marktraceur>	 Because an LD window is 30 minutes and scap takes 27 at last check
[17:16:51] <MatmaRex>	 are there people queued after you?
[17:16:53] <marktraceur>	 Well
[17:16:56] <marktraceur>	 I dunno.
[17:17:11] <marktraceur>	 But it would be mighty selfish and against the spirit of the thing
[17:17:46] <grrrit-wm>	 (03PS1) 10Hashar: WMF: less build description updates [integration/zuul] - 10https://gerrit.wikimedia.org/r/102465 
[17:17:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update Cirrus to master [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102436 (owner: 10Manybubbles)
[17:18:46] <grrrit-wm>	 (03CR) 10Hashar: [C: 032 V: 032] "Added Timo/Ori/Christian on review since we talked about this yesterday." [integration/zuul] - 10https://gerrit.wikimedia.org/r/102465 (owner: 10Hashar)
[17:18:56] <MatmaRex>	 marktraceur: there's a scheduled deployment tomorrow, though, right?
[17:19:07] <marktraceur>	 Well, yeah
[17:19:33] <MatmaRex>	 this is medium-priority anyway, it should just be done before christmas break
[17:20:35] <MatmaRex>	 (if it wasn't for the break, i probably wouldn't bother with backporting and stuff)
[17:20:57] <grrrit-wm>	 (03CR) 10Jhall: [C: 031] Replacing single quotes with double quotes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102204 (owner: 10Zfilipin)
[17:21:04] <MatmaRex>	 so who do i poke about tomorrow? reed.y?
[17:21:19] <marktraceur>	 Yeah, sounds right
[17:21:59] <MatmaRex>	 okay
[17:22:10] <MatmaRex>	 (also, i still need reviewers on the thing. :>)
[17:22:12] <marktraceur>	 I can at least merge it, yeah
[17:24:06] <grrrit-wm>	 (03CR) 10Ori.livneh: "re-ping" [core] - 10https://gerrit.wikimedia.org/r/99547 (owner: 10Ori.livneh)
[17:27:00] <grrrit-wm>	 (03CR) 10Matthias Mullie: Consolidate and clean up "scroll to this element" code (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95975 (owner: 10Werdna)
[17:30:33] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "A doc comment." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99547 (owner: 10Ori.livneh)
[17:31:03] <grrrit-wm>	 (03PS7) 10Inchikutty: Replacing 'show on map' button with a link [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/101029 
[17:31:15] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 032] Update Cirrus to master [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/102434 (owner: 10Manybubbles)
[17:34:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update Cirrus to master [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/102434 (owner: 10Manybubbles)
[17:36:33] <grrrit-wm>	 (03PS1) 10Cscott: Remove a duplicate method. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/102467 
[17:36:34] <grrrit-wm>	 (03PS1) 10Cscott: Quiet missing language warnings: only report each missing language once. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/102468 
[17:36:35] <grrrit-wm>	 (03PS1) 10Cscott: Add icu-bidi package. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/102469 
[17:36:36] <grrrit-wm>	 (03PS1) 10Cscott: Refactor: `Formatter` class tracks paragraph/inline state. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/102470 
[17:36:37] <grrrit-wm>	 (03PS1) 10Cscott: Support <wbr> element. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/102471 
[17:37:06] <grrrit-wm>	 (03CR) 10Cscott: [C: 032] Update `request` dependency to 2.30. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/102206 (owner: 10Cscott)
[17:37:28] <grrrit-wm>	 (03CR) 10Cscott: [C: 032] Remove a duplicate method. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/102467 (owner: 10Cscott)
[17:37:40] <grrrit-wm>	 (03CR) 10Gergő Tisza: "One tiny spacing issue. Otherwise looks fine!" (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/101029 (owner: 10Inchikutty)
[17:37:47] <grrrit-wm>	 (03CR) 10Cscott: [C: 032] Quiet missing language warnings: only report each missing language once. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/102468 (owner: 10Cscott)
[17:38:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refactor: `Formatter` class tracks paragraph/inline state. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/102470 (owner: 10Cscott)
[17:38:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Support <wbr> element. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/102471 (owner: 10Cscott)
[17:39:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove a duplicate method. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/102467 (owner: 10Cscott)
[17:39:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Quiet missing language warnings: only report each missing language once. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/102468 (owner: 10Cscott)
[17:41:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update `request` dependency to 2.30. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/102206 (owner: 10Cscott)
[17:41:45] <grrrit-wm>	 (03Abandoned) 10Matthias Mullie: load* shouldn't check for view permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102201 (owner: 10Matthias Mullie)
[17:42:05] <marktraceur>	 MatmaRex: Does it bother you that we're using the term "legend" to mean something HTML didn't intend? :P
[17:43:49] <grrrit-wm>	 (03PS8) 10Inchikutty: Replacing 'show on map' button with a link [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/101029 
[17:44:32] <MatmaRex>	 marktraceur: i forced myself to stop being bothered about naming inconsistencies in the Wikimedia community some time ago, lest i go mad
[17:44:54] <MatmaRex>	 but yeah, we have a <legend> and a 'rclegend' and a "Legend:" there and it is driving me slightly insane
[17:45:44] <marktraceur>	 Hah.
[17:46:06] <marktraceur>	 MatmaRex: OK, as long as you feel as bad about it as I do, we're covered
[17:46:18] <marktraceur>	 Unless you want to spend cycles on this patch fixing it, that is
[17:47:09] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 032] Rewrite i18n support to use new json format [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102315 (owner: 10Chad)
[17:47:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Rewrite i18n support to use new json format [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102315 (owner: 10Chad)
[17:47:19] <MatmaRex>	 that would conflict with the Great Rewrite i have going
[17:47:23] <MatmaRex>	 and the Great Redesign i have planned
[17:48:05] <marktraceur>	 Hahaha.
[17:48:25] <grrrit-wm>	 (03PS2) 10Cscott: Refactor: `Formatter` class tracks paragraph/inline state. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/102470 
[17:48:26] <grrrit-wm>	 (03PS2) 10Cscott: Support <wbr> element. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/102471 
[17:49:40] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] "Thanks" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102423 (owner: 10Dan-nl)
[17:49:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: adding namespaces as numeric values to GWToolset.namespaces.php and simplifying the defined test in GWToolset.php [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102423 (owner: 10Dan-nl)
[17:50:02] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] whitelist Christian "qchris" Aistleitner [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102460 (owner: 10Hashar)
[17:50:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: whitelist Christian "qchris" Aistleitner [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102460 (owner: 10Hashar)
[17:50:28] <grrrit-wm>	 (03PS5) 10Reedy: Remove some of the permissions so they can be configured per-wiki [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102343 (owner: 10Brian Wolff)
[17:50:29] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove some of the permissions so they can be configured per-wiki [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102343 (owner: 10Brian Wolff)
[17:51:32] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Remove some of the permissions so they can be configured per-wiki [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102343 (owner: 10Brian Wolff)
[17:52:00] <grrrit-wm>	 (03PS1) 10Cscott: Release 0.2.1. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/102474 
[17:52:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove some of the permissions so they can be configured per-wiki [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102343 (owner: 10Brian Wolff)
[17:52:31] <grrrit-wm>	 (03CR) 10Cscott: [C: 032] Release 0.2.1. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/102474 (owner: 10Cscott)
[17:52:49] <grrrit-wm>	 (03CR) 10MarkTraceur: "Some thoughts and questions, not -1 material but things I'm curious about." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/101446 (owner: 10Bartosz Dziewoński)
[17:52:59] <marktraceur>	 MatmaRex: From SF with love
[17:53:45] <grrrit-wm>	 (03CR) 10Hashar: "deployed, you should be able to use recheck and get tests jobs triggered :-)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102460 (owner: 10Hashar)
[17:54:30] <MatmaRex>	 marktraceur: looking, thanks
[17:56:17] <marktraceur>	 My pleasure
[17:56:42] <grrrit-wm>	 (03CR) 10Gergő Tisza: Replacing 'show on map' button with a link (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/101029 (owner: 10Inchikutty)
[17:56:46] <grrrit-wm>	 (03PS1) 10Tpt: Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 
[17:57:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Release 0.2.1. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/102474 (owner: 10Cscott)
[17:57:56] <grrrit-wm>	 (03CR) 10MarkTraceur: "Also I guess [expand] and Legend: should be centered relative to each other when collapsed." [core] - 10https://gerrit.wikimedia.org/r/101446 (owner: 10Bartosz Dziewoński)
[17:59:18] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Make legend on Special:RecentChanges and Special:Watchlist collapsible (034 comments) [core] - 10https://gerrit.wikimedia.org/r/101446 (owner: 10Bartosz Dziewoński)
[17:59:43] <grrrit-wm>	 (03PS1) 10Cscott: Bump version after release. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/102476 
[18:00:00] <grrrit-wm>	 (03CR) 10Cscott: [C: 032] Bump version after release. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/102476 (owner: 10Cscott)
[18:00:07] <MatmaRex>	 marktraceur: hmm, centered?
[18:00:17] <marktraceur>	 Aligned
[18:00:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Addition of a parser test for page= parameter of image inclusion [core] - 10https://gerrit.wikimedia.org/r/102475 (owner: 10Tpt)
[18:01:19] <MatmaRex>	 marktraceur: it looks like this to me: http://i.imgur.com/nt6I3Gg.png
[18:01:53] <grrrit-wm>	 (03PS1) 10BryanDavis: Change text of confirmation email [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102477 
[18:01:58] <MatmaRex>	 welp, it naturally looks different on Blink :/
[18:03:32] <bd808>	 Anybody want to review a 2 word change in a localization file for Scholarships? https://gerrit.wikimedia.org/r/#/c/102477/1
[18:03:43] * aude  can't merge it

[18:03:48] <bd808>	 marktraceur: ^
[18:03:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Bump version after release. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/102476 (owner: 10Cscott)
[18:03:52] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Change text of confirmation email [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102477 (owner: 10BryanDavis)
[18:03:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Change text of confirmation email [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102477 (owner: 10BryanDavis)
[18:04:00] <legoktm>	 :D
[18:04:01] <grrrit-wm>	 (03PS9) 10Inchikutty: Replacing 'show on map' button with a link [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/101029 
[18:04:03] <bd808>	 Thanks legoktm 
[18:04:12] <RoanKattouw>	 bd808: Dude, JSON i18n? Awesome!
[18:04:16] <bd808>	 aude: Where do I need to vote on your +2
[18:04:20] <grrrit-wm>	 (03PS2) 10Jdlrobson: Move all VectorBeta RL modules from core. [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99523 
[18:04:21] <Reedy>	 "travel to"
[18:04:35] <aude>	 for core, done... for scholarships no idea
[18:04:36] <Reedy>	 "I attend to travel to London but am not going to attend Wikimania 2014"
[18:04:41] <RoanKattouw>	 bd808: Mind listing yourself on the RfC page as a project that's using it?
[18:05:08] <bd808>	 RoanKattouw: Sure. Chad made a comment there yesterday too
[18:05:19] <grrrit-wm>	 (03PS2) 10Jdlrobson: Move VectorBeta modules to VectorBeta extension. [core] - 10https://gerrit.wikimedia.org/r/99524 
[18:05:20] <bd808>	 Reedy: Fight it out with Ellie
[18:05:20] <marktraceur>	 Blargh
[18:05:20] <grrrit-wm>	 (03CR) 10Tpt: "Warning: change not ready for review" [core] - 10https://gerrit.wikimedia.org/r/102475 (owner: 10Tpt)
[18:05:24] * aude  seriously impressed with where schoalrships is now 

[18:05:32] <aude>	 scholarships*
[18:05:40] <marktraceur>	 MatmaRex: It's on two lines for me
[18:05:44] <grrrit-wm>	 (03CR) 10Jdlrobson: "Okay this is good to merge but please merge the dependency at the same time." [core] - 10https://gerrit.wikimedia.org/r/99524 (owner: 10Jdlrobson)
[18:05:51] <marktraceur>	 I guess the font face may change the size requirements
[18:05:57] <bd808>	 aude: thanks
[18:06:19] * aude  should spend time on the program committee workflow or some other part

[18:06:27] <MatmaRex>	 marktraceur: yeah, for me too on Opera 19
[18:06:28] <MatmaRex>	 lol
[18:06:32] <bd808>	 I promised rob-la that I wouldn't gold plate it and then did anyway 
[18:06:41] <MatmaRex>	 when i open the inspector and toggle the float:right style on the [Expand]
[18:06:44] <MatmaRex>	 and then toggle it back
[18:06:47] <MatmaRex>	 it displays on one line
[18:06:51] <aude>	 it's a good prototype for trying new stuff
[18:06:56] <aude>	 worth it
[18:07:02] <MatmaRex>	 marktraceur: can you verify? i think we've got a Blink bug to report. :P
[18:07:03] <marktraceur>	 MatmaRex: Weird.
[18:07:09] <marktraceur>	 Uh, sure
[18:07:28] <marktraceur>	 MatmaRex: Confirmed
[18:07:38] <MatmaRex>	 and good ol' trusty Opera 12 displays it correctly ~
[18:08:19] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "That's a Chrome/Blink bug, it should be displayed on one line like this: http://i.imgur.com/nt6I3Gg.png – I'll file it in their tracker." [core] - 10https://gerrit.wikimedia.org/r/101446 (owner: 10Bartosz Dziewoński)
[18:08:20] <marktraceur>	 I imagine MatmaRex with a bookshelf dedicated to different Opera versions
[18:08:38] <MatmaRex>	 there are just two that matter, the proper one and the new one. :P
[18:09:14] <grrrit-wm>	 (03Abandoned) 10Andrew Bogott: Pull in some updates to OSM. [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97158 (owner: 10Andrew Bogott)
[18:09:15] <MatmaRex>	 and 9.62, which a non-zero number of people still apparently use
[18:09:18] <grrrit-wm>	 (03CR) 10EBernhardson: Use FlowAction permissions in AbstractRevision (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102154 (owner: 10Matthias Mullie)
[18:09:24] <MatmaRex>	 i think that's the last one that ran on Windows 98
[18:09:30] <marktraceur>	 "And this, oh, this is a very rare version, it's an Opera 13.25 RC2 with a slight imperfection in the GUI - you can see it right there..."
[18:09:39] <MatmaRex>	 heh
[18:10:19] <grrrit-wm>	 (03CR) 10QChris: "Yay!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102460 (owner: 10Hashar)
[18:11:00] <marktraceur>	 bd808: Wait, are you using the Brand Spanking New JSON i18n format?
[18:11:24] <bd808>	 Yup. Siebrand talked us into it
[18:11:29] <marktraceur>	 Ah sweet
[18:12:18] <marktraceur>	 bd808: But no qqq?
[18:12:35] <bd808>	 marktraceur: Not yet, but soon
[18:12:38] <marktraceur>	 'kay.
[18:12:50] * marktraceur  shushes

[18:13:08] <bd808>	 baby steps man
[18:13:19] <bd808>	 I'm eating an elephant over here
[18:14:19] * aude  scratches head over random failing wikibase tests

[18:14:44] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 031] "Seems like a good idea. needs manual verification." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/101895 (owner: 10Aude)
[18:17:36] <grrrit-wm>	 (03CR) 10MarkTraceur: "I'm not sure of the utility of overridability, but I guess I'll leave it up to siebrand! +1 because everything else seems fine." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/101446 (owner: 10Bartosz Dziewoński)
[18:18:00] * marktraceur  looks at Nikerabbit because apparently siebrand isn't in

[18:20:07] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 04-1] Attribution for authors of moderated content (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102153 (owner: 10Matthias Mullie)
[18:20:08] <Nemo_bis>	 marktraceur: where are your two comments? 
[18:20:32] * Nemo_bis  doesn't open diffs on MessagesEn.php unless really needed because they make browser explode

[18:21:53] <marktraceur>	 Sadly it's in MessagesEn
[18:21:56] <marktraceur>	 I can summarize though
[18:22:11] <marktraceur>	 Nemo_bis: We have a message that's used as a header, the text is currently "'''Legend:'''"
[18:22:23] <marktraceur>	 I wondered if we should make it "Legend:" instead and do the styling in CSS
[18:23:39] * Nemo_bis  spawned another browser

[18:25:30] <grrrit-wm>	 (03CR) 10EBernhardson: "I dunno, we will certainly need some sort of refactor. Andrew?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101903 (owner: 10Matthias Mullie)
[18:26:18] <MatmaRex>	 marktraceur: are you bored? creating a reduced testcase of that rendering bug is turning out to be non-trivial :P
[18:26:38] <marktraceur>	 Ugh.
[18:26:50] <marktraceur>	 MatmaRex: I'm not particularly bored, no
[18:26:59] <MatmaRex>	 and i can't just report it like that since that's not live anywhere stable
[18:27:04] <MatmaRex>	 oh well, it can wait
[18:27:10] <MatmaRex>	 it's not like they would react
[18:27:12] <grrrit-wm>	 (03CR) 10Nemo bis: Make legend on Special:RecentChanges and Special:Watchlist collapsible (031 comment) [core] - 10https://gerrit.wikimedia.org/r/101446 (owner: 10Bartosz Dziewoński)
[18:27:15] <marktraceur>	 I Should Really Be working on these Multimedia stat script things
[18:27:24] <MatmaRex>	 my last bug was moved between three different milestones, then had the milestone removed
[18:27:31] <MatmaRex>	 (my last reported chrome bug*)
[18:27:50] <marktraceur>	 Right
[18:27:57] <Nemo_bis>	 better than being ignored and then having it closed "too old"
[18:29:48] <grrrit-wm>	 (03CR) 10Bsitu: Consolidate and clean up "scroll to this element" code (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95975 (owner: 10Werdna)
[18:31:03] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] Move all VectorBeta RL modules from core. (031 comment) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99523 (owner: 10Jdlrobson)
[18:31:38] <grrrit-wm>	 (03PS6) 10Aaron Schulz: Removed cloudfiles dependency in SwiftFileBackend [core] - 10https://gerrit.wikimedia.org/r/101226 
[18:31:40] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "(This is ready to merge otherwise, right?)" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99523 (owner: 10Jdlrobson)
[18:32:53] <AaronSchulz>	 Undefined variable: config
[18:32:54] <AaronSchulz>	 /var/www/DevWiki/core/tests/phpunit/includes/filebackend/FileBackendTest.php:40
[18:33:03] <AaronSchulz>	 huh, I just pulled and get that now
[18:35:38] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "LESS-related changes → paging Ori. :)" [core] - 10https://gerrit.wikimedia.org/r/99524 (owner: 10Jdlrobson)
[18:36:18] <grrrit-wm>	 (03PS1) 10Dr0ptp4kt: Add support for skins to set attributes of <html> element. [core] - 10https://gerrit.wikimedia.org/r/102479 
[18:36:27] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 031] "Looks good, haven't tested yet." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/101029 (owner: 10Inchikutty)
[18:36:28] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Fixed undefined variable errors that made tests fail [core] - 10https://gerrit.wikimedia.org/r/102480 
[18:36:37] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Fixed undefined variable errors that made tests fail [core] - 10https://gerrit.wikimedia.org/r/102480 (owner: 10Aaron Schulz)
[18:37:12] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Ah, actually it won't, I see what you did there. Nice." [core] - 10https://gerrit.wikimedia.org/r/99524 (owner: 10Jdlrobson)
[18:38:50] <grrrit-wm>	 (03CR) 10GWicke: "Antoine, any news on this? Should we try to push this along a bit further?" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101912 (owner: 10Subramanya Sastry)
[18:39:25] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Also, I'd love to have the change that brings the modules to their final state submitted already, so we don't get stuck with ugly-ass FIXM" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99524 (owner: 10Jdlrobson)
[18:41:45] <grrrit-wm>	 (03CR) 10Njw: "> Why disable all JavaScript globally? If you want to disable dynamic expansion on the subcategory listing on category pages, you should h" [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/57041 (owner: 10Njw)
[18:41:57] <grrrit-wm>	 (03PS2) 10Apsdehal: Added i18n functions and messages to PageSchemas [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/101499 
[18:45:16] <hexmode>	 ori-l, James_F: how can I add my own role to vagrant without messing around in roles.pp?
[18:45:28] <grrrit-wm>	 (03PS2) 10Dr0ptp4kt: Add support for skins to set attributes of <html> element. [core] - 10https://gerrit.wikimedia.org/r/102479 
[18:45:53] <hexmode>	 I was successful when I did it there, but when I put it in a .pp file in manifests.d, it didn't work
[18:46:03] * hexmode  goes to look for roles.d

[18:46:46] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/101446 (owner: 10Bartosz Dziewoński)
[18:48:15] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Practical use case, please? So far we've been sticking this kind of stuff on <body>, if I understand correctly." [core] - 10https://gerrit.wikimedia.org/r/102479 (owner: 10Dr0ptp4kt)
[18:49:27] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102153 (owner: 10Matthias Mullie)
[18:49:56] <grrrit-wm>	 (03CR) 10Edokter: mediawiki.hlist: Use mw.hook( 'wikipage.content' ) in JS fallback (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96239 (owner: 10Bartosz Dziewoński)
[18:53:41] <grrrit-wm>	 (03CR) 10Edokter: "TheDJ: Good question. Until now, hlist has only been used inside content. Are there any situations feasable where it would be used anywher" [core] - 10https://gerrit.wikimedia.org/r/96239 (owner: 10Bartosz Dziewoński)
[18:54:17] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 031] "dependant patch needs merge" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101164 (owner: 10Bsitu)
[18:55:51] <Ahmad96>	 hey qgil, you there? :)
[18:56:03] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: "Good question. It's for stuff like the following:" [core] - 10https://gerrit.wikimedia.org/r/102479 (owner: 10Dr0ptp4kt)
[18:56:18] <Ahmad96>	 Just pushed the favicon. This time all icons have the same font color (black)
[18:57:58] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: Create ChangesListSpecialPage as a base class for Watchlist and RC [core] - 10https://gerrit.wikimedia.org/r/102458 
[18:58:24] <Ahmad96>	 oh, ups, pushed the wrong version. 
[18:58:30] <Ahmad96>	 Let me fix that 
[18:58:45] <grrrit-wm>	 (03Abandoned) 10Legoktm: Use ApiBase::requireOnlyOneParameter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102025 (owner: 10Legoktm)
[19:01:41] <grrrit-wm>	 (03PS1) 10Reedy: Update GWToolset to master [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102483 
[19:03:01] <grrrit-wm>	 (03CR) 10Edokter: mediawiki.hlist: Use mw.hook( 'wikipage.content' ) in JS fallback (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96239 (owner: 10Bartosz Dziewoński)
[19:03:26] <grrrit-wm>	 (03CR) 10Legoktm: Create ChangesListSpecialPage as a base class for Watchlist and RC (032 comments) [core] - 10https://gerrit.wikimedia.org/r/102458 (owner: 10Bartosz Dziewoński)
[19:03:41] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Update GWToolset to master [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102483 (owner: 10Reedy)
[19:03:47] <grrrit-wm>	 (03CR) 10Reedy: [V: 032] Update GWToolset to master [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102483 (owner: 10Reedy)
[19:05:35] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Create ChangesListSpecialPage as a base class for Watchlist and RC (032 comments) [core] - 10https://gerrit.wikimedia.org/r/102458 (owner: 10Bartosz Dziewoński)
[19:05:55] <grrrit-wm>	 (03CR) 10Legoktm: Create ChangesListSpecialPage as a base class for Watchlist and RC (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102458 (owner: 10Bartosz Dziewoński)
[19:06:34] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Create ChangesListSpecialPage as a base class for Watchlist and RC (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102458 (owner: 10Bartosz Dziewoński)
[19:07:36] <qgil>	 Ahmad96, hi 
[19:09:29] <grrrit-wm>	 (03CR) 10Legoktm: [C: 031] "Looks fine to me." [core] - 10https://gerrit.wikimedia.org/r/102458 (owner: 10Bartosz Dziewoński)
[19:09:54] <MatmaRex>	 omgz.
[19:09:56] <grrrit-wm>	 (03PS3) 10Bsitu: Add flow specific exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100524 
[19:10:16] <MatmaRex>	 legoktm: have you looked at earlier changes in the stack? (there are 9 more + 2 unrelated ones)
[19:10:32] <legoktm>	 oh wait, that's not the top? blegh
[19:10:41] <MatmaRex>	 that is the top
[19:10:47] <MatmaRex>	 or the "leaf", rather
[19:11:05] <legoktm>	 everything depends on https://gerrit.wikimedia.org/r/#/c/101446/3 >.>
[19:11:20] <MatmaRex>	 less rebasing that way
[19:12:17] <legoktm>	 what are the MessagesEn comments? I don't want to kill my browser
[19:12:59] <MatmaRex>	 tl;dr they're resolved
[19:13:07] <legoktm>	 ok :P
[19:13:08] <MatmaRex>	 they were about the bolding i stuffed in the new message
[19:13:28] <grrrit-wm>	 (03PS4) 10Bsitu: Add flow specific exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100524 
[19:13:57] <legoktm>	 ehhhhhh
[19:14:02] <grrrit-wm>	 (03CR) 10Bsitu: Add flow specific exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100524 (owner: 10Bsitu)
[19:14:04] <grrrit-wm>	 (03PS3) 10Apsdehal: Added message for key 'abusefilter-edit-warn-view' to AbuseFilter.i18n.php [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/101494 
[19:14:20] <legoktm>	 MatmaRex: it flickers when i reload the page if I have it collapsed
[19:14:54] <MatmaRex>	 it does, yeah
[19:14:57] <MatmaRex>	 so does everything else
[19:15:03] <legoktm>	 :/
[19:15:05] <MatmaRex>	 like the entire vector navigation sidebar
[19:15:09] <legoktm>	 is there no better way to do this?
[19:15:25] <MatmaRex>	 inline <script> right after the element, or reimplementing the cookie handling logic in PHP
[19:15:52] <MatmaRex>	 (actually, the second one is a no-go since it would become inaccessible for people without JS support if they managed to toggle that cookie(
[19:15:54] <MatmaRex>	 ))
[19:16:16] <MatmaRex>	 (and i've been bitched at for suggesting inline <script>s in the past)
[19:16:38] <legoktm>	 oh wow
[19:16:38] <Ahmad96>	 heya qgil, now I really pushed the right version haha. Pushed the wrong version earlier. 
[19:16:46] <legoktm>	 Vector sucks xP
[19:17:36] <qgil>	 Ahmad96, looks good to me but I will wait to Tomasz review, if you don't mind. I appreciate your effort fghiting the 16x16 version piexel by pixel  :)
[19:18:47] <grrrit-wm>	 (03CR) 10Rillke: mediawiki.hlist: Use mw.hook( 'wikipage.content' ) in JS fallback (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96239 (owner: 10Bartosz Dziewoński)
[19:20:12] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: mediawiki.hlist: Use mw.hook( 'wikipage.content' ) in JS fallback (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96239 (owner: 10Bartosz Dziewoński)
[19:21:10] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: mediawiki.hlist: Use mw.hook( 'wikipage.content' ) in JS fallback [core] - 10https://gerrit.wikimedia.org/r/96239 
[19:24:24] <grrrit-wm>	 (03PS7) 10Aaron Schulz: Removed cloudfiles dependency in SwiftFileBackend [core] - 10https://gerrit.wikimedia.org/r/101226 
[19:24:46] <grrrit-wm>	 (03CR) 10Aaron Schulz: "Rebased" [core] - 10https://gerrit.wikimedia.org/r/101226 (owner: 10Aaron Schulz)
[19:25:21] <grrrit-wm>	 (03CR) 10Deskana: [C: 031] Make legend on Special:RecentChanges and Special:Watchlist collapsible [core] - 10https://gerrit.wikimedia.org/r/101446 (owner: 10Bartosz Dziewoński)
[19:26:46] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] "Tested, works as expected." [core] - 10https://gerrit.wikimedia.org/r/101446 (owner: 10Bartosz Dziewoński)
[19:27:34] <grrrit-wm>	 (03CR) 10Bsitu: [C: 031] Load usernames directly from wiki's in batches [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 (owner: 10EBernhardson)
[19:27:48] <grrrit-wm>	 (03PS2) 10Dan-nl: Couple of type hints [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102455 (owner: 10Reedy)
[19:29:00] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 031] "A minor quibble re: documentation, but otherwise good." (033 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 (owner: 10Legoktm)
[19:29:21] <legoktm>	 MatmaRex: for https://gerrit.wikimedia.org/r/#/c/102449/, can you adjust the commit message to specify you're only renaming the class and not the actual special page?
[19:30:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make legend on Special:RecentChanges and Special:Watchlist collapsible [core] - 10https://gerrit.wikimedia.org/r/101446 (owner: 10Bartosz Dziewoński)
[19:30:13] <MatmaRex>	 legoktm: hm, yeah, can do i guess
[19:30:21] <grrrit-wm>	 (03CR) 10Dan-nl: [C: 031] "- as far as i could tell the addition to includes/Handlers/Forms/FormHandler.php wasn’t necessary." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102455 (owner: 10Reedy)
[19:30:22] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: Rename SpecialRecentchangeslinked → SpecialRecentChangesLinked [core] - 10https://gerrit.wikimedia.org/r/102449 
[19:30:25] <MatmaRex>	 but i had to drop the arrow :(
[19:31:11] <MatmaRex>	 legoktm: (btw, if you just happen to want to merge that stack now, i want hoo to comment on it first since he complained :) )
[19:31:23] <hoo>	 uh what?
[19:31:28] <MatmaRex>	 (and also i want it merged in its entirety at once for the same reason)
[19:31:35] <MatmaRex>	 hoo: i made a ChangesListSpecialPage for you.
[19:31:45] <hoo>	 heh :)
[19:31:45] <legoktm>	 MatmaRex: the renaming class one is independent though?
[19:31:51] <MatmaRex>	 https://gerrit.wikimedia.org/r/#/c/102458/
[19:32:01] <MatmaRex>	 legoktm: yeah, the RCLinked things in unrelated
[19:32:04] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] "Follow up patch will reduce the creation of duplicate objects." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102154 (owner: 10Matthias Mullie)
[19:32:05] <MatmaRex>	 thing is*
[19:33:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use FlowAction permissions in AbstractRevision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102154 (owner: 10Matthias Mullie)
[19:33:32] <legoktm>	 ok, just waiting for my grep to finish running
[19:33:37] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Make legend on Special:RecentChanges and Special:Watchlist collapsible [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/102486 
[19:33:53] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Make legend on Special:RecentChanges and Special:Watchlist collapsible [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102487 
[19:34:20] <hoo>	 MatmaRex: I doubt I have time today (few things I need to do until tomorrow...)
[19:34:44] <hoo>	 but from tomorrow on I have tons of spare time (ok, not actually... but some)
[19:34:48] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Needs going with the deploy tomorrow (since it requires scap)." [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/102486 (owner: 10Bartosz Dziewoński)
[19:34:50] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Needs going with the deploy tomorrow (since it requires scap)." [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102487 (owner: 10Bartosz Dziewoński)
[19:34:51] <grrrit-wm>	 (03PS1) 10Cmcmahon: new test for collapse view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102488 
[19:35:10] <MatmaRex>	 hmm actually, won't the tomorrow deploy kill wmf6?
[19:35:29] <grrrit-wm>	 (03PS2) 10Cmcmahon: new test for collapse view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102488 
[19:36:00] <legoktm>	 yeah, it will
[19:37:03] <grrrit-wm>	 (03PS2) 10Legoktm: Cleanup ApiParsoidUtilsFlow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102044 
[19:37:12] <grrrit-wm>	 (03Abandoned) 10Bartosz Dziewoński: Make legend on Special:RecentChanges and Special:Watchlist collapsible [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/102486 (owner: 10Bartosz Dziewoński)
[19:37:16] <grrrit-wm>	 (03CR) 10Legoktm: Cleanup ApiParsoidUtilsFlow (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102044 (owner: 10Legoktm)
[19:37:25] <grrrit-wm>	 (03CR) 10Cmcmahon: "I think this is a legitimate use of sleep(), to wait while the view of the page rearranges itself upon clicking the collapse icons. Other" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102488 (owner: 10Cmcmahon)
[19:38:30] <grrrit-wm>	 (03PS2) 10Legoktm: ApiBase is a context source [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102046 
[19:39:59] <grrrit-wm>	 (03CR) 10Jdlrobson: "The FIXME's have to live here until the cache gets cleared unfortunately we have to wait 30 days.." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99524 (owner: 10Jdlrobson)
[19:41:34] <grrrit-wm>	 (03PS5) 10Apsdehal: Updated Special:GlobalUsers to show creation date of global user account [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 
[19:42:28] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 04-2] "Patch ready to go, do not submit until schema change is applied." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 (owner: 10EBernhardson)
[19:43:21] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Yeah, I understand why this has to be done in this way, I'd just like to have the patch to be merged in 30 days ready now so it's a one-cl" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99524 (owner: 10Jdlrobson)
[19:43:23] <grrrit-wm>	 (03CR) 10Anomie: [C: 031] ApiBase is a context source [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102046 (owner: 10Legoktm)
[19:44:26] <mooeypoo>	 AaronSchulz, hey hey, are you around by any chance? I have a couple of questions about fileRepo information I am hoping you might be able to help with
[19:44:39] <grrrit-wm>	 (03PS1) 10Siebrand: Add some translations for Dutch [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102489 
[19:46:51] <grrrit-wm>	 (03CR) 10Adamw: [C: 032] FR #1113 Treat a subpage like it's a language [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/99613 (owner: 10Mwalker)
[19:46:59] <grrrit-wm>	 (03CR) 10Adamw: [V: 032] FR #1113 Treat a subpage like it's a language [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/99613 (owner: 10Mwalker)
[19:48:55] <grrrit-wm>	 (03PS1) 10Siebrand: Remove trailing whitespace in messages [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102490 
[19:50:13] <bd808|MEETING>	 siebrand: I'm working on the qqq file. I'll add you to the review when it's ready so you can tell me how badly I did it wrong. :)
[19:50:42] <siebrand>	 bd808|MEETING: Read the docs? https://www.mediawiki.org/wiki/I18n#Message_documentation
[19:50:50] <siebrand>	 bd808|MEETING: It helps to do that beforehand :)
[19:51:05] <grrrit-wm>	 (03PS3) 10Cmcmahon: new test for collapse view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102488 
[19:51:27] <siebrand>	 bd808|MEETING: I made a few small tweaks to the en.json (removed trailing whitespace in the messages) and added some Dutch translations so you can do some testing.
[19:51:32] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 031] Add support for skins to set attributes of <html> element. [core] - 10https://gerrit.wikimedia.org/r/102479 (owner: 10Dr0ptp4kt)
[19:51:47] <bd808|MEETING>	 I saw that. Thanks
[19:52:40] <grrrit-wm>	 (03PS1) 10EBernhardson: No longer pass $permissionsUser in Templating [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102491 
[19:53:51] <grrrit-wm>	 (03PS1) 10Jdlrobson: Now cache has cleared remove superfluous modules [core] - 10https://gerrit.wikimedia.org/r/102492 
[19:54:04] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] jpegmeta: Add links to source version and improve documentation [core] - 10https://gerrit.wikimedia.org/r/102031 (owner: 10Krinkle)
[19:54:10] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-2] "Merge in 30 days after dependency has been merged." [core] - 10https://gerrit.wikimedia.org/r/102492 (owner: 10Jdlrobson)
[19:54:27] <grrrit-wm>	 (03CR) 10Jdlrobson: "Done. Hopefully there won't be merge conflicts in 30 days." [core] - 10https://gerrit.wikimedia.org/r/99524 (owner: 10Jdlrobson)
[19:56:29] <grrrit-wm>	 (03PS2) 10Cmcmahon: Replacing single quotes with double quotes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102204 (owner: 10Zfilipin)
[19:57:08] <grrrit-wm>	 (03PS3) 10EBernhardson: Attribution for authors of moderated content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102153 (owner: 10Matthias Mullie)
[19:57:35] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] "PS3: Use css transitions on opacity rather than display: none" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102153 (owner: 10Matthias Mullie)
[19:57:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Attribution for authors of moderated content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102153 (owner: 10Matthias Mullie)
[19:58:11] <grrrit-wm>	 (03PS1) 10Bsitu: Connvert index option to db option when no index is found [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102494 
[19:58:20] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] ApiBase is a context source [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102046 (owner: 10Legoktm)
[19:59:00] <grrrit-wm>	 (03PS2) 10Matthias Mullie: Instead of failing, remove history logs that user can't see [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102169 
[19:59:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: jpegmeta: Add links to source version and improve documentation [core] - 10https://gerrit.wikimedia.org/r/102031 (owner: 10Krinkle)
[19:59:29] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] "Did a grep of all extensions in gerrit and couldn't find anything that uses this class." [core] - 10https://gerrit.wikimedia.org/r/102449 (owner: 10Bartosz Dziewoński)
[19:59:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: ApiBase is a context source [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102046 (owner: 10Legoktm)
[20:00:35] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: Rename SpecialRecentchangeslinked class to SpecialRecentChangesLinked [core] - 10https://gerrit.wikimedia.org/r/102449 
[20:00:43] <MatmaRex>	 legoktm: i spotted a typo :)
[20:00:47] <MatmaRex>	 legoktm: again please? ^
[20:00:54] <legoktm>	 ok :P
[20:01:03] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Instead of failing, remove history logs that user can't see [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102169 (owner: 10Matthias Mullie)
[20:01:11] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Rename SpecialRecentchangeslinked class to SpecialRecentChangesLinked [core] - 10https://gerrit.wikimedia.org/r/102449 (owner: 10Bartosz Dziewoński)
[20:01:17] <MatmaRex>	 thanks
[20:02:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Instead of failing, remove history logs that user can't see [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102169 (owner: 10Matthias Mullie)
[20:02:40] <grrrit-wm>	 (03PS3) 10Matthias Mullie: Users probably shouldn't see deleted entries too, unless they have sufficient permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102172 
[20:02:48] <matanya>	 RoanKattouw: can https://bugzilla.wikimedia.org/show_bug.cgi?id=50514 be closed?
[20:05:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Rename SpecialRecentchangeslinked class to SpecialRecentChangesLinked [core] - 10https://gerrit.wikimedia.org/r/102449 (owner: 10Bartosz Dziewoński)
[20:05:50] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 04-2] "Checked with Ironholds, deleted revisions should be listed in the history but shown redacted." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102172 (owner: 10Matthias Mullie)
[20:07:47] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Cleanup ApiParsoidUtilsFlow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102044 (owner: 10Legoktm)
[20:07:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Cleanup ApiParsoidUtilsFlow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102044 (owner: 10Legoktm)
[20:08:09] <grrrit-wm>	 (03PS2) 10Matthias Mullie: Don't fail if there is not history (e.g. everything is moderated) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102202 
[20:08:11] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] Updated Special:GlobalUsers to show creation date of global user account (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 (owner: 10Apsdehal)
[20:08:12] <grrrit-wm>	 (03PS2) 10Legoktm: Remove 'parse' prefix from ApiParsoidUtilsFlow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102045 
[20:08:45] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Don't fail if there is not history (e.g. everything is moderated) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102202 (owner: 10Matthias Mullie)
[20:08:48] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Integrate feed-specific setup into general setup (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96070 (owner: 10Poke)
[20:08:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't fail if there is not history (e.g. everything is moderated) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102202 (owner: 10Matthias Mullie)
[20:09:12] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Remove 'parse' prefix from ApiParsoidUtilsFlow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102045 (owner: 10Legoktm)
[20:09:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove 'parse' prefix from ApiParsoidUtilsFlow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102045 (owner: 10Legoktm)
[20:09:30] <grrrit-wm>	 (03PS4) 10Siebrand: Added message for key 'abusefilter-edit-warn-view' to AbuseFilter.i18n.php [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/101494 (owner: 10Apsdehal)
[20:11:53] <grrrit-wm>	 (03CR) 10Siebrand: "I updated the commit summary. It was verbose and repetitive." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/101494 (owner: 10Apsdehal)
[20:13:03] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Integrate feed-specific setup into general setup (034 comments) [core] - 10https://gerrit.wikimedia.org/r/96070 (owner: 10Poke)
[20:13:54] <grrrit-wm>	 (03PS4) 10Cmcmahon: new test for collapse view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102488 
[20:14:29] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: WIP: Allow Skins to define other HTML tag attributes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100920 (owner: 10Jdlrobson)
[20:16:05] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "L10n reviewed." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100524 (owner: 10Bsitu)
[20:18:24] <RoanKattouw>	 matanya: Maybe. We have such a system now but we need to actually document it, and possibly polish it a bit
[20:18:29] <RoanKattouw>	 I'm actually about to write the first commit that uses it
[20:18:54] <matanya>	 ok thanks RoanKattouw. i'll leave it open atm
[20:18:55] <RoanKattouw>	 matanya: Also, James_F runs our Bugzilla for us so re "should the bug be open or closed?" I defer to him
[20:19:25] <matanya>	 sure, thanks.
[20:20:44] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "L10n reviewed." (037 comments) [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/101499 (owner: 10Apsdehal)
[20:21:32] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: WIP: Allow Skins to define other HTML tag attributes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100920 (owner: 10Jdlrobson)
[20:30:40] <James_F>	 RoanKattouw: Re. closing 50514 (plugin system), I thought that we'd agreed that that was blocked on documentation?
[20:31:40] <RoanKattouw>	 Yeah that seems reasonable
[20:35:53] <yurik>	 robla, around?
[20:36:16] <robla>	 in a meeting
[20:42:21] <grrrit-wm>	 (03PS3) 10Apsdehal: Added i18n functions and messages to PageSchemas [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/101499 
[20:42:46] <grrrit-wm>	 (03CR) 10Dzahn: [C: 032] "not that i added this and know better when it was added, but the reasoning makes a lot of sense to me and andre tests his stuff" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/101655 (owner: 10Aklapper)
[20:43:04] <grrrit-wm>	 (03CR) 10Dzahn: [V: 032] "not that i added this and know better when it was added, but the reasoning makes a lot of sense to me and andre tests his stuff" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/101655 (owner: 10Aklapper)
[20:45:42] <grrrit-wm>	 (03CR) 10Dzahn: "deployed, kaulen" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/101655 (owner: 10Aklapper)
[20:47:23] <grrrit-wm>	 (03PS1) 10Spage: Less specific button selectors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102544 
[20:47:48] <grrrit-wm>	 (03CR) 10Apsdehal: Updated Special:GlobalUsers to show creation date of global user account (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 (owner: 10Apsdehal)
[20:51:59] <grrrit-wm>	 (03PS1) 10MegaAlex: I18N: Fix some messages' documentation [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/102545 
[20:56:02] <grrrit-wm>	 (03CR) 10Jhall: [C: 031] Replacing single quotes with double quotes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102204 (owner: 10Zfilipin)
[20:57:05] <grrrit-wm>	 (03CR) 10Jhall: [C: 031] new test for collapse view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102488 (owner: 10Cmcmahon)
[21:01:11] <yurik>	 anomie, i saw you were pocking at the Recursion detected in RequestContext::getLanguage -- do you think we should hide that warning now?
[21:01:24] <yurik>	 it spams fatalmonitor without adding much value
[21:02:57] <grrrit-wm>	 (03PS1) 10Spage: Update test requirements [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102549 
[21:04:24] <grrrit-wm>	 (03PS1) 10Umherirrender: Give alreadyrolled error when rollback will be a null edit [core] - 10https://gerrit.wikimedia.org/r/102550 
[21:04:46] <anomie>	 yurik: Bug 54193? Probably, at least the trigger_error one.
[21:04:52] <grrrit-wm>	 (03PS1) 10MegaAlex: I18N: Should have a capital letter after the colon [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/102552 
[21:05:01] <yurik>	 anomie, yep. I'm commenting it out
[21:07:06] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] "Thanks." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/102552 (owner: 10MegaAlex)
[21:07:32] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] "Thanks." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/102545 (owner: 10MegaAlex)
[21:07:53] <grrrit-wm>	 (03PS1) 10Brian Wolff: Change location of period in img-lang-info [core] - 10https://gerrit.wikimedia.org/r/102556 
[21:08:28] <grrrit-wm>	 (03PS1) 10Yurik: Hide warning "Recursion detected in RequestContext::getLanguage" [core] - 10https://gerrit.wikimedia.org/r/102557 
[21:08:38] <yurik>	 anomie, ^
[21:09:10] <grrrit-wm>	 (03CR) 10Siebrand: Updated Special:GlobalUsers to show creation date of global user account (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 (owner: 10Apsdehal)
[21:11:01] <grrrit-wm>	 (03PS2) 10Cmcmahon: Less specific button selectors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102544 (owner: 10Spage)
[21:11:44] <grrrit-wm>	 (03PS1) 10Hashar: blacklist l10n-bot [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102559 
[21:12:03] <grrrit-wm>	 (03CR) 10Hashar: [C: 032 V: 032] blacklist l10n-bot [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102559 (owner: 10Hashar)
[21:12:42] <spagewmf>	 If I'm looking at a patch in Gerrit, how do I go to looking at other patches for that project (i.e. its default dashboard?) The Project link and the submenu under Projects don't do it. 
[21:13:20] <hashar>	 !g project:mediawiki/core
[21:13:21] <wm-bot>	 https://gerrit.wikimedia.org/r/#q,project:mediawiki/core,n,z
[21:13:29] <hashar>	 spagewmf: ^^^
[21:13:39] <hashar>	 list all changes for mw/core
[21:13:58] <hashar>	 adding in  'is:merged'  would only list the merged changes
[21:13:59] <spagewmf>	 hashar: sure, I'm just wondering why the gerrit UI makes it so hard to get there
[21:14:13] <hashar>	 it is in the search box at the top right
[21:14:20] <hashar>	 you even get some code completion :-]
[21:14:41] <grrrit-wm>	 (03CR) 10Apsdehal: Updated Special:GlobalUsers to show creation date of global user account (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 (owner: 10Apsdehal)
[21:14:45] <hashar>	 the search doc is in Documentation (top menu) then  Searching
[21:14:50] <hashar>	 gives you https://gerrit.wikimedia.org/r/Documentation/user-search.html
[21:15:00] <hashar>	 which probably has everything you want
[21:15:01] <spagewmf>	 right but I'm already looking at a patch for that project. The current links presented to me seem useless 97% of the time
[21:15:14] <hashar>	 what do you know about the patch ?
[21:15:29] <hashar>	 if you get the sha1 or Change-Id you can search for it
[21:16:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Less specific button selectors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102544 (owner: 10Spage)
[21:16:43] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "Thanks S! (Usually we have page elements in alphabetical order by abstraction name, but I don't mind putting all the tipsy elements in a b" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102544 (owner: 10Spage)
[21:17:14] <grrrit-wm>	 (03PS2) 10Cmcmahon: Update test requirements [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102549 (owner: 10Spage)
[21:17:32] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "documentation" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102549 (owner: 10Spage)
[21:17:47] <spagewmf>	 hashar: WHEN I am looking at any patch in gerrit THEN all the project links on that page are useless and none takes me to a useful list of patches.
[21:18:16] <hashar>	 yeah must agree 
[21:18:28] <hashar>	 the dashboard is a nice idea but it is not reachable easily :-D
[21:20:15] <spagewmf>	 seems a useful link would be https://gerrit.wikimedia.org/r/#/projects/<THISPROJECT>,dashboards/default
[21:20:21] <spagewmf>	 I'll file a bug
[21:20:22] <bd808>	 spagewmf: Click the project name in the table in the upper left, the click "projects" in the top nav, then click "Dashboards" in the sub-nav, then click "open", "recent" or "review"
[21:20:39] <bd808>	 Design by coder monkeys
[21:21:53] <ebernhardson>	 pssh, be happy its only 5 clicks deep :P
[21:22:32] <bd808>	 The discoverability of gerrit's interface is horrible
[21:22:38] <grrrit-wm>	 (03PS1) 10Apsdehal: Updated the message for centralauth-admin-status-locked-yes [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/102560 
[21:22:58] <hashar>	 bd808: nice
[21:24:03] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Change location of period in img-lang-info [core] - 10https://gerrit.wikimedia.org/r/102556 (owner: 10Brian Wolff)
[21:24:58] <MatmaRex>	 bd808: "horrible" is a nice euphemism for "it fucking sucks", isn't it.
[21:25:11] <spagewmf>	 bd808, hashar Glory be, it's the search icon next to the italic "Project" link. That doesn't search, it shows the default dashboard.
[21:25:43] <bd808>	 Ha! Makes perfect sense :/
[21:26:02] <bd808>	 "I need an icon" "Use that magnifying glass"
[21:26:26] <hashar>	 I wrote my own search queries and bookmarked them
[21:26:50] <hashar>	 i.e. all changes failed by Jenkins ( status:open  label:Verified-1 ) https://gerrit.wikimedia.org/r/#/q/status:open+label:Verified-1,n,z
[21:27:03] <bd808>	 The tool tip even says "search for changes…."
[21:27:08] <hashar>	 all changes opened by people not in wmf LDAP group:  status:open -ownerin:ldap/wmf  :D
[21:27:57] <grrrit-wm>	 (03CR) 10Nikerabbit: Integrate feed-specific setup into general setup (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96070 (owner: 10Poke)
[21:27:59] <hashar>	 and for mw/core I used  status:open project:mediawiki/core -label:CodeReview-1 -label:CodeReview-2 -label:Verified-1
[21:35:18] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Add support for skins to set attributes of <html> element. [core] - 10https://gerrit.wikimedia.org/r/102479 (owner: 10Dr0ptp4kt)
[21:35:38] <spagewmf>	 is someone changing the Gerrit's top menu? While filing a bug Projects submenu changed to just "List", no more "General Branches Dashboard"
[21:35:56] <dr0ptp4kt>	 kaldari, thx
[21:36:38] <hashar>	 time to sleeep
[21:39:47] <RoanKattouw>	 spagewmf: Did you get logged out perhaps?
[21:40:58] <spagewmf>	 RoanKattouw: no.  Mysterious. Anyway, I'm filing a bug to make a useful obvious project link
[21:41:14] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Minor tweak and i'll merge" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari)
[21:43:06] <grrrit-wm>	 (03PS8) 10Kaldari: Add 'mediawiki.ui.button' CSS module [core] - 10https://gerrit.wikimedia.org/r/98869 
[21:43:46] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] "Code looks good, did a basic UploadWizard test locally." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/79917 (owner: 10MarkTraceur)
[21:44:14] <Nemo_bis>	 siebrand: also needs V+2 https://gerrit.wikimedia.org/r/#/c/102545/
[21:44:28] <grrrit-wm>	 (03CR) 10Parent5446: [C: 04-1] "This is not a problem with MediaWiki core but with extensions. If WMF is annoyed by the errors, then this patch should be merged in whatev" [core] - 10https://gerrit.wikimedia.org/r/102557 (owner: 10Yurik)
[21:44:31] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Add 'mediawiki.ui.button' CSS module [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari)
[21:45:19] <marktraceur>	 :D
[21:45:24] <marktraceur>	 superm401: Yaaaayyyy
[21:45:55] <superm401>	 marktraceur, yep.  Rahul21 got me looking at it again, since he is trying to get PR up and running again.
[21:46:06] <marktraceur>	 Cool!
[21:46:10] <superm401>	 It would also be nice to finally get jshint passing (and voting!) in that repo.
[21:46:21] <superm401>	 It looks like there are ~3 files left.
[21:46:37] <superm401>	 Unless jshint just stops looking at new files when there are too many (I know it stops looking at later lines).
[21:46:42] <superm401>	 I think there are probably open patch sets for all of it.
[21:47:22] <marktraceur>	 Yeeeahhh.
[21:47:33] <twkozlowski>	 qgil: Good day to you, sir.
[21:47:48] <marktraceur>	 superm401: I definitely got jshint passing
[21:47:57] <marktraceur>	 But that was a few months back
[21:48:03] <marktraceur>	 So there may be new patches that are not so passing
[21:48:15] <superm401>	 marktraceur, well, I think you got it, but not all of your stuff got merged.
[21:48:26] <superm401>	 E.g. https://gerrit.wikimedia.org/r/#/c/86779/
[21:48:37] <superm401>	 Once it's all merged, we should make it voting.
[21:49:12] <marktraceur>	 Right.
[21:49:19] <marktraceur>	 There may be -1s on it
[21:49:25] <marktraceur>	 I got distracted by MMV stuff
[21:49:31] <superm401>	 Yeah, I understand
[21:49:37] <marktraceur>	 I guess I could maybe work on that while I'm bored and in Las Vegas
[21:49:48] <superm401>	 There's only two inline comments on that one.
[21:49:53] <superm401>	 One has nothing to do with jshint, but meh.
[21:51:44] <spagewmf>	 I filed https://bugzilla.wikimedia.org/show_bug.cgi?id=58669 "Gerrit's Change page should provide a useful obvious link to project" if anyone has creative suggestions
[21:51:53] <spagewmf>	 s/project/project changes/
[21:57:49] <siebrand>	 Nemo_bis: No. It'll happen once Jekins catches up.
[21:58:27] <siebrand>	 RfC meeting in #wikimedia-meetbot in 2 minutes.
[21:58:39] <siebrand>	 Details at https://www.mediawiki.org/wiki/Architecture_meetings/RFC_review_2013-12-18
[21:59:43] <Nemo_bis>	 ok, I was told jenkins is busy only around lunch ;)
[22:00:34] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "...Jenkins?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/79917 (owner: 10MarkTraceur)
[22:00:58] <grrrit-wm>	 (03PS1) 10Shirayuki: i18n: fix typo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102565 
[22:01:12] <Nemo_bis>	 hmm don't see the queue and last two merged changes in that repo were manually v+2'ed
[22:01:14] <grrrit-wm>	 (03PS2) 10Poke: Integrate feed-specific setup into general setup [core] - 10https://gerrit.wikimedia.org/r/96070 
[22:01:36] <marktraceur>	 Yeah, I think something's effed up with Zuul
[22:01:42] <marktraceur>	 Wild speculation.
[22:02:36] <bd808>	 The virtual room is filling up over in #wikimedia-meetbot for today's RFC discussion
[22:02:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Integrate feed-specific setup into general setup [core] - 10https://gerrit.wikimedia.org/r/96070 (owner: 10Poke)
[22:02:41] <grrrit-wm>	 (03PS1) 10EBernhardson: Punctuation and Gender i18n cleanups [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102566 
[22:03:01] <twkozlowski>	 virtual room
[22:03:09] <twkozlowski>	 haven't heard that for a while.
[22:03:27] <twkozlowski>	 s/for/in
[22:03:35] * bd808  rocks it old school

[22:03:44] <twkozlowski>	 :-)
[22:05:14] <grrrit-wm>	 (03PS3) 10Poke: Integrate feed-specific setup into general setup [core] - 10https://gerrit.wikimedia.org/r/96070 
[22:05:52] <grrrit-wm>	 (03CR) 10Catrope: Script to convert PHP i18n to JSON (0310 comments) [core] - 10https://gerrit.wikimedia.org/r/102171 (owner: 10Catrope)
[22:06:26] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Punctuation and Gender i18n cleanups [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102566 (owner: 10EBernhardson)
[22:07:18] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] i18n: fix typo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102565 (owner: 10Shirayuki)
[22:08:42] <grrrit-wm>	 (03CR) 10Poke: "Patch 3 (just ignore the embarassing #2 please :P) includes adjustments based on comments. Most notably, `$isFeed` was moved to an instanc" [core] - 10https://gerrit.wikimedia.org/r/96070 (owner: 10Poke)
[22:09:05] <grrrit-wm>	 (03PS1) 10Bsitu: The batch query for rev_id is not working as it's supposed to [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102569 
[22:10:47] <grrrit-wm>	 (03PS2) 10EBernhardson: Punctuation and Gender i18n cleanups [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102566 
[22:10:53] <poke`>	 hey
[22:12:06] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] I18N: Fix some messages' documentation [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/102545 (owner: 10MegaAlex)
[22:12:11] <poke`>	 MatmaRex: I've updated #96070, does it look fine to you now?
[22:13:38] <grrrit-wm>	 (03PS1) 10Raimond Spekking: Add .gitreview [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/102570 
[22:13:58] <qgil>	 hi twkozlowski :)  Happy to see the end of the ico & svg tunnels  ;)
[22:14:13] <twkozlowski>	 well yeah
[22:15:02] <twkozlowski>	 not to happy about the latest logos & feeling a bit discouraged right nowe
[22:15:05] <twkozlowski>	 now*
[22:15:39] <qgil>	 twkozlowski, you mean the last 5 svg?
[22:15:54] <twkozlowski>	 Yes.
[22:15:59] * qgil  looks

[22:16:02] <grrrit-wm>	 (03PS1) 10Manybubbles: Disable dynamic mapping [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102572 
[22:17:27] <grrrit-wm>	 (03CR) 10MZMcBride: "Bump." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87183 (owner: 10Legoktm)
[22:21:28] <MatmaRex>	 poke`: i'll probably look at it tomorrow, sorry
[22:21:29] <MatmaRex>	 and thanks!
[22:23:18] <grrrit-wm>	 (03PS1) 10Andrew Bogott: Move the request for shell access to a later callback. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/102574 
[22:25:22] <qgil>	 twkozlowski, ok, I see. I can answer to the student if you answer a couple of questions first here
[22:25:55] <qgil>	 twkozlowski, is the Kanada version correct (the site says "Wikisource", his logo is in (I guess) Kanada)
[22:25:58] <Krinkle>	 MatmaRex: checking
[22:26:19] <MatmaRex>	 thanks
[22:26:21] <qgil>	 twkozlowski, the Norwegian logo with those fonts and colors... is this correct?
[22:27:08] <twkozlowski>	 qgil: kn is correct, no is... weird
[22:27:16] <twkozlowski>	 we already have that exact logo.
[22:27:25] <qgil>	 twkozlowski, the Thai fonts... are they the same? The new logo looks like having a thinner font but Thai is not among my strengths
[22:27:33] <twkozlowski>	 https://commons.wikimedia.org/wiki/File:Wikisource-logo-no.svg
[22:27:40] <grrrit-wm>	 (03PS3) 10EBernhardson: Punctuation and Gender i18n cleanups [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102566 
[22:27:41] <qgil>	 twkozlowski, kn if we have the exact logo then we won't bother the student
[22:27:51] <twkozlowski>	 oh sorry
[22:27:58] <twkozlowski>	 the no part is language code for Norwegian :)
[22:28:02] <twkozlowski>	 no = Norwegian
[22:28:03] <Krinkle>	 MatmaRex: Seems fine now?
[22:28:14] <Krinkle>	 https://integration.wikimedia.org/zuul/
[22:28:15] <Krinkle>	 puppet as well
[22:28:18] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] "Re-applying earlier +2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102566 (owner: 10EBernhardson)
[22:28:18] <Krinkle>	 maybe just mw?
[22:28:29] <poke`>	 MatmaRex: It's okay, I appreciate that something is finally happening with the change ;)
[22:28:44] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] "Testing [019kfn102df]" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102566 (owner: 10EBernhardson)
[22:28:44] <MatmaRex>	 Krinkle: define 'fine'? it was voting, but not merging
[22:28:50] <poke`>	 btw. should I put another patch up is rebased onto current master, or just keep it?
[22:28:51] <qgil>	 twkozlowski, Norwegian was also there as SVG already? Ok, one less.
[22:29:07] <Krinkle>	 MatmaRex: This one ran and voted: https://gerrit.wikimedia.org/r/#/c/102075/
[22:29:12] <Krinkle>	 MatmaRex: trying a gate pipeline now
[22:29:15] <twkozlowski>	 qgil: the thai indeed uses a different font, the characters are fine
[22:29:18] <MatmaRex>	 poke`: no need to rebase the patch as long as it merges (also, you can rebase using the "Rebase" button on gerrit)
[22:29:27] <Krinkle>	 Doesn't even run the job, let alone vote or submit.
[22:29:28] <MatmaRex>	 poke`: it was sitting on my todo list, only got around to it now :)
[22:29:41] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] [WIP] Add support for JSON i18n files (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102098 (owner: 10Catrope)
[22:29:42] <poke`>	 MatmaRex: Ah, good to know! Thanks a lot :)
[22:30:02] <twkozlowski>	 qgil: The Norwegian one is different from the scheme, I thought they will draw it anew
[22:30:26] <twkozlowski>	 and now we have https://commons.wikimedia.org/wiki/File:Wikisource-logo-no.svg and they created https://commons.wikimedia.org/wiki/File:Wikisource-logo-no-svg.svg
[22:30:26] <qgil>	 twkozlowski, they meaning the student or the project?
[22:30:42] <twkozlowski>	 the student
[22:30:56] <qgil>	 twkozlowski, what does the project need, a new one standardized?
[22:31:36] <twkozlowski>	 qgil: yeah, but I think I'm wasting your time right now :-)
[22:31:41] <twkozlowski>	 I can comment on it in the morning no problem
[22:31:43] <qgil>	 zh-min-nan and bg look good to me...
[22:31:48] <twkozlowski>	 Just lost my patience today I think
[22:31:50] <Krinkle>	 MatmaRex: Might be related to the Zuul upgrade, or the changes hashar made to the e-mail filter for l10n bot
[22:31:55] <qgil>	 twkozlowski, you are not wasting my time!
[22:32:12] <qgil>	 I'm happy to help, and be helped (by great people like you)
[22:32:44] <grrrit-wm>	 (03PS6) 10Krinkle: No need to use custom mw.log anymore [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/79917 (owner: 10MarkTraceur)
[22:32:46] <qgil>	 twkozlowski, just confirm that zh-min-nan and bg look good (or not) and I will reply
[22:32:46] <MatmaRex>	 Krinkle: i think jobs were still being ran after the upgrade, i've only noticed this just now
[22:33:09] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] No need to use custom mw.log anymore [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/79917 (owner: 10MarkTraceur)
[22:33:16] <marktraceur>	 Thanks Krinkle
[22:33:33] <Krinkle>	 Nothing is happening in Zuul after CR+2, no job, no vote, no submit.
[22:36:07] <grrrit-wm>	 (03PS7) 10MarkTraceur: No need to use custom mw.log anymore [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/79917 
[22:36:17] <marktraceur>	 ...weird
[22:36:32] <marktraceur>	 I saw it running WikiData and Flow jobs, but nothing else
[22:36:41] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] "Testing [109xn1d-f]" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/79917 (owner: 10MarkTraceur)
[22:36:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: No need to use custom mw.log anymore [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/79917 (owner: 10MarkTraceur)
[22:36:48] <marktraceur>	 Hah.
[22:36:58] <marktraceur>	 Magical codes?
[22:37:04] <grrrit-wm>	 (03CR) 10Spage: [C: 032] "OK. I updated https://www.mediawiki.org/wiki/Quality_Assurance/Browser_testing/Writing_tests#Page_Objects to reflect this change." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102204 (owner: 10Zfilipin)
[22:37:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replacing single quotes with double quotes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102204 (owner: 10Zfilipin)
[22:37:34] <grrrit-wm>	 (03PS1) 10Krinkle: Revert "blacklist l10n-bot" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102579 
[22:37:36] <grrrit-wm>	 (03CR) 10Catrope: "Notes from RfC meeting:" [core] - 10https://gerrit.wikimedia.org/r/102098 (owner: 10Catrope)
[22:37:41] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032 V: 032] Revert "blacklist l10n-bot" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102579 (owner: 10Krinkle)
[22:39:19] <twkozlowski>	 qgil: Yeah, they look OK.
[22:39:21] <Krinkle>	 marktraceur: MatmaRex: ebernhardson: Back up :)
[22:39:38] <marktraceur>	 Thanks!
[22:39:43] <Krinkle>	 marktraceur: MatmaRex: ebernhardson: [x] the V+2 CR+2 votes and submit them again 
[22:39:46] <twkozlowski>	 not exactly the same dimensions as the current logos, qgil, but I can live with it
[22:39:52] <Krinkle>	 s/submit/publish/
[22:40:09] <marktraceur>	 I don't think I had any others
[22:40:21] <MatmaRex>	 Krinkle: thanks
[22:40:26] <grrrit-wm>	 (03CR) 10Jforrester: "recheck" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97366 (owner: 10Legoktm)
[22:40:29] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Don't parse custom footer [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97366 (owner: 10Legoktm)
[22:40:42] <legoktm>	 blegh
[22:41:17] <James_F>	 legoktm: Sorry.
[22:41:23] <qgil>	 twkozlowski, thank you. Last question: the useless files created like all the pngs can be marked with {{speedydelete}} template, right?
[22:41:24] <legoktm>	 :P
[22:41:37] <legoktm>	 James_F: not your fault :)
[22:42:03] <legoktm>	 James_F: that's probably going to need a lot of rebases, there are like 4 patches before it.
[22:42:41] <twkozlowski>	 qgil: that's generally debatable :-)
[22:42:46] <James_F>	 legoktm: Sorry for being the bearer of bad news, at least. :-)
[22:43:09] <qgil>	 twkozlowski, ok, then I will leave that to you for comment tomorrow.  :)  I'm answering already about the rest.
[22:43:12] <twkozlowski>	 qgil: I know some folks prefer to use direct PNGs instead of PNG thumbnails of SVG files...
[22:43:24] <twkozlowski>	 and having the PNGs on Commons won't hurt us.
[22:43:34] <qgil>	 good, thank you
[22:43:40] <twkozlowski>	 I'll comment tomorrow, and will fix the file description pages and move the -svg.svg files too
[22:43:49] <twkozlowski>	 someone should fix this, BTW
[22:43:55] <twkozlowski>	 or maybe they do something wrong.
[22:44:05] <twkozlowski>	 I don't use UploadWizard, so can't tell :)
[22:44:14] <qgil>	 that is indeed weird, I didn't find such problem myself
[22:44:19] <qgil>	 I use it
[22:44:45] <qgil>	 thank you again, take a good rest!  :)
[22:44:46] <twkozlowski>	 even if there is Wikisource-logo-xx.png, they shouldn't have problems with uploading Wikisource-logo-xx.svg
[22:45:13] <twkozlowski>	 and that's already two different people reporting that
[22:45:19] <marktraceur>	 twkozlowski: We're aware
[22:45:27] <qgil>	 ah
[22:45:33] <twkozlowski>	 oh, great marktraceur :)
[22:45:43] <marktraceur>	 twkozlowski: It's been assigned to me; it's not a problem with core but UploadWizard
[22:46:04] <twkozlowski>	 yeah, I thought it must be
[22:46:09] <marktraceur>	 Sadly we're focused on other stuff at the moment, but I'll get to it as soon as I can
[22:46:20] <twkozlowski>	 great
[22:46:24] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] Updated the message for centralauth-admin-status-locked-yes [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/102560 (owner: 10Apsdehal)
[22:46:33] <twkozlowski>	 I'll keep moving the files after they are uploaded for the time being then :)
[22:46:38] <marktraceur>	 'kay
[22:46:56] <hoo>	 are gate and submits working again?
[22:47:21] <grrrit-wm>	 (03PS3) 10EBernhardson: Fetch moderation status from last revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102203 (owner: 10Matthias Mullie)
[22:47:21] <grrrit-wm>	 (03CR) 10EBernhardson: "PS3: Cherry-picked onto master" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102203 (owner: 10Matthias Mullie)
[22:47:28] <marktraceur>	 hoo: Seem to be
[22:50:25] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 04-1] "The number of network requests required scales linearly with the amount of history rendered." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102203 (owner: 10Matthias Mullie)
[22:52:24] <grrrit-wm>	 (03CR) 10Hoo man: [V: 032] Updated the message for centralauth-admin-status-locked-yes [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/102560 (owner: 10Apsdehal)
[22:54:57] <grrrit-wm>	 (03PS2) 10Andrew Bogott: Move the request for shell access to a later callback. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/102574 
[22:58:36] <James_F>	 greg-g: Can we have an LD slot tonight? RoanKattouw's found a config error about Parsoid.
[22:58:56] <greg-g>	 James_F: yessir
[22:59:06] <James_F>	 greg-g: Thanks! (Grumble.)
[22:59:39] <greg-g>	 :)
[23:02:55] <grrrit-wm>	 (03PS3) 10Spage: Less specific button selectors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102544 
[23:04:03] <grrrit-wm>	 (03PS1) 10EBernhardson: Convert UUID length 'magic' numbers to named constants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102584 
[23:04:26] <grrrit-wm>	 (03CR) 10Spage: "I had to manually rebase PS3 due to Zfilipin's change to double-quotes ;)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102544 (owner: 10Spage)
[23:09:11] <grrrit-wm>	 (03PS13) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 
[23:09:12] <grrrit-wm>	 (03PS2) 10EBernhardson: Convert UUID length 'magic' numbers to named constants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102584 
[23:10:35] <grrrit-wm>	 (03CR) 10EBernhardson: "PS12: separate new UUID constants into their own patch." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson)
[23:10:50] <grrrit-wm>	 (03CR) 10EBernhardson: "above was for PS13, not 12" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson)
[23:12:48] <grrrit-wm>	 (03PS14) 10EBernhardson: [SCHEMA CHANGE] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 
[23:12:50] <grrrit-wm>	 (03PS3) 10EBernhardson: Convert UUID length 'magic' numbers to named constants [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102584 
[23:15:10] <grrrit-wm>	 (03CR) 10EBernhardson: "I've added a new gerrit patch, 102584. That will allow the constants to be merged and used without requiring the prior merging the 88bit " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102441 (owner: 10Matthias Mullie)
[23:15:16] <grrrit-wm>	 (03CR) 10Spage: "(I don't understand why Jenkins didn't merge this on Cmcmahon's earlier "Patch Set 2: Code-Review+2", so I clicked the [Submit] button.)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102549 (owner: 10Spage)
[23:15:23] <grrrit-wm>	 (03CR) 10EBernhardson: "https://gerrit.wikimedia.org/r/#/c/102584/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102441 (owner: 10Matthias Mullie)
[23:18:16] <grrrit-wm>	 (03PS1) 10Krinkle: Add jobs for VisualEditor.git [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102587 
[23:19:34] <grrrit-wm>	 (03PS2) 10Krinkle: Add jobs for VisualEditor.git [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102587 
[23:42:17] <grrrit-wm>	 (03CR) 10Krinkle: "Re-applying earlier +2 from Siebrand" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102566 (owner: 10EBernhardson)
[23:43:29] <TimStarling>	 anomie|away, robla: http://tstarling.com/stuff/lua-module-edits-2013.png    http://tstarling.com/stuff/lua-unique-editors-2013.png
[23:45:30] <robla>	 hmmm....interesting.  looks like we have a fairly stable community.  how does that compare to wikitext template editing?
[23:45:49] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Punctuation and Gender i18n cleanups [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102566 (owner: 10EBernhardson)
[23:45:54] <grrrit-wm>	 (03PS1) 10CSteipp: Add OAuth as a role [vagrant] - 10https://gerrit.wikimedia.org/r/102592 
[23:45:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Punctuation and Gender i18n cleanups [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102566 (owner: 10EBernhardson)
[23:46:04] <robla>	 (apples to oranges in some respects, I know, but it's still has some use as a comparison)
[23:46:45] <grrrit-wm>	 (03PS12) 10Werdna: Consolidate and clean up "scroll to this element" code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95975 
[23:46:47] <grrrit-wm>	 (03PS1) 10Werdna: Fix VisualEditor integration to work with updated API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102593 
[23:46:52] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] i18n: fix typo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102565 (owner: 10Shirayuki)
[23:46:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Consolidate and clean up "scroll to this element" code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95975 (owner: 10Werdna)
[23:47:02] <grrrit-wm>	 (03CR) 10EBernhardson: [V: 032] i18n: fix typo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102565 (owner: 10Shirayuki)
[23:47:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: i18n: fix typo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102565 (owner: 10Shirayuki)
[23:47:15] <TimStarling>	 robla, pretty consistent: http://reportcard.wmflabs.org/graphs/active_editors
[23:47:50] <robla>	 AaronSchulz: https://github.com/symfony/HttpFoundation maybe?
[23:47:58] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Fix VisualEditor integration to work with updated API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102593 (owner: 10Werdna)
[23:48:04] <grrrit-wm>	 (03PS13) 10Werdna: Consolidate and clean up "scroll to this element" code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95975 
[23:48:07] <robla>	 TimStarling: I was referring to templates specifically rather than all edits
[23:48:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix VisualEditor integration to work with updated API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102593 (owner: 10Werdna)
[23:48:10] <grrrit-wm>	 (03PS2) 10Krinkle: I18N: Fix some messages' documentation [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/102545 (owner: 10MegaAlex)
[23:48:58] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Connvert index option to db option when no index is found [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102494 (owner: 10Bsitu)
[23:49:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Connvert index option to db option when no index is found [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102494 (owner: 10Bsitu)
[23:49:28] <TimStarling>	 I'm not sure if my scripts would work well with the larger number of edits
[23:49:36] <TimStarling>	 I'm just using some one-liners
[23:50:48] <TimStarling>	 but if you look at https://en.wikipedia.org/w/index.php?namespace=10&tagfilter=&title=Special%3ARecentChanges
[23:50:48] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] "(re-applying earlier +2 during Zuul outage)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/102545 (owner: 10MegaAlex)
[23:50:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: i18n: Fix some messages' documentation [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/102545 (owner: 10MegaAlex)
[23:51:00] <grrrit-wm>	 (03PS1) 10Spage: Clean up meaningless "post body" language [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102594 
[23:51:12] <TimStarling>	 you see that there are a lot of edits to templates by non-programmer types, so template namespace edits probably follow general active editor counts pretty closely
[23:52:05] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] The batch query for rev_id is not working as it's supposed to [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102569 (owner: 10Bsitu)
[23:52:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: The batch query for rev_id is not working as it's supposed to [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102569 (owner: 10Bsitu)
[23:52:58] <robla>	 yeah, that's a tough comparison to make
[23:54:00] <grrrit-wm>	 (03PS1) 10Tim Starling: Maintenance script for benchmarking parse operations [core] - 10https://gerrit.wikimedia.org/r/102596 
[23:55:44] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Add Flow events to Special:Contributions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99038 (owner: 10Werdna)
[23:55:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add Flow events to Special:Contributions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99038 (owner: 10Werdna)
[23:59:18] <grrrit-wm>	 (03PS3) 10Krinkle: Add jobs for VisualEditor.git [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102587 
[23:59:20] <grrrit-wm>	 (03PS1) 10Krinkle: Remove unused '{name}-{ext-name}-install' job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102597 
[23:59:22] <grrrit-wm>	 (03PS1) 10Krinkle: Add '{name}-{ext-name}-phplint' job template [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102598 
[23:59:28] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Remove unused '{name}-{ext-name}-install' job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102597 (owner: 10Krinkle)