[00:01:34] (03CR) 10Krinkle: "Hm.. tried the same locally on the host and getting the same error. Networking is working fine though, it does fetch the tarballs. But fai" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101461 (owner: 10Krinkle) [00:08:13] (03PS1) 10Legoktm: Cleanup ApiParsoidUtilsFlow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102044 [00:11:12] (03PS9) 10Werdna: [WIP] Add Flow events to Special:Contributions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99038 [00:11:37] (03CR) 10Werdna: "Still some stuff for Matthias to look at." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99038 (owner: 10Werdna) [00:11:54] (03CR) 10Werdna: [WIP] Add Flow events to Special:Contributions. (036 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99038 (owner: 10Werdna) [00:12:56] (03PS1) 10Legoktm: Remove 'parse' prefix from ApiParsoidUtilsFlow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102045 [00:24:00] (03CR) 10BryanDavis: [C: 032] Remove test wikis from wiki list [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102039 (owner: 10Chad) [00:24:06] (03Merged) 10jenkins-bot: Remove test wikis from wiki list [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102039 (owner: 10Chad) [00:31:26] (03PS3) 10Werdna: No Reply button after clicking Be the first to comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101164 (owner: 10Bsitu) [00:31:28] (03PS10) 10Werdna: Consolidate and clean up "scroll to this element" code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95975 [00:31:54] (03CR) 10Werdna: "PS10 is just a rebase." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95975 (owner: 10Werdna) [00:32:32] (03CR) 10Werdna: [C: 031] "PS3 makes this change dependent on change 95975, because it touches scroll handling behaviour." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101164 (owner: 10Bsitu) [00:36:20] (03PS1) 10Legoktm: ApiBase is a context source [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102046 [00:38:13] (03PS11) 10Werdna: Consolidate and clean up "scroll to this element" code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95975 [00:41:09] (03PS4) 10Werdna: No Reply button after clicking Be the first to comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101164 (owner: 10Bsitu) [00:43:45] (03CR) 10Werdna: [C: 031] "PS4 fixes an oversight or two, and also adds a .focus() call." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101164 (owner: 10Bsitu) [00:45:00] (03CR) 10Werdna: "PS11 adds the jquery.scroll.js dependency to the discussion module." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95975 (owner: 10Werdna) [00:48:41] ^d: if you have a few minutes, can you add Skizzerz to the "StopForumSpam" extension group? [00:54:38] <^d> legoktm: Done. [00:57:41] (03PS2) 10BryanDavis: Localize most remaining review pages [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102032 (owner: 10Chad) [01:00:00] (03CR) 10BryanDavis: [C: 032] Localize most remaining review pages [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102032 (owner: 10Chad) [01:00:04] (03Merged) 10jenkins-bot: Localize most remaining review pages [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102032 (owner: 10Chad) [01:00:26] (03PS2) 10BryanDavis: Blank all non-en messages [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102037 (owner: 10Chad) [01:02:17] (03CR) 10BryanDavis: [C: 032] Blank all non-en messages [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102037 (owner: 10Chad) [01:02:22] (03Merged) 10jenkins-bot: Blank all non-en messages [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102037 (owner: 10Chad) [01:04:51] <^demon|away> bd808: Other than that one form, we did it :) [01:05:43] ^demon|away: Pretty cool. Now I suppose we should figure out how to integrate with translatewiki [01:06:13] <^demon|away> Yeah, we can probably pester them now :) [01:06:56] Let's wait to see if there are more text changes from tomorrow's meeting. [01:08:01] But it should be really close. Really, really close. [01:10:04] ^demon|away: thanks! [01:10:23] <^demon|away> yw [01:12:29] (03PS4) 10Skizzerz: Add ghetto batching to the BlacklistUpdate [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101620 [01:13:06] mwalker: SURE! [01:13:18] I live for occupying myself when I Should Be Doing Other Things [01:17:32] (03PS5) 10Skizzerz: Add ghetto batching to the BlacklistUpdate [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101620 [01:21:56] (03PS1) 10Chad: WIP: Allow reindexing by namespace [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102047 [01:22:45] (03CR) 10Skizzerz: [C: 032 V: 032] Add $wgSFSEnableConfidenceVariable to enable AbuseFilter integration [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/102017 (owner: 10Legoktm) [01:22:47] (03CR) 10Chad: "Should make it easier for us to reindex all of NS_FILE after things like I43aefede land." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102047 (owner: 10Chad) [01:26:02] (03CR) 10Chad: "Manybubbles: I'm still not sure how to include it in the result. I imagine you'll usually match page text or file text, but not both, but " [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 (owner: 10Chad) [01:26:49] (03CR) 10Legoktm: Add ghetto batching to the BlacklistUpdate (031 comment) [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101620 (owner: 10Skizzerz) [01:28:08] (03CR) 10Legoktm: "Did you change your content language to pt? It's working for me..." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/87477 (owner: 10Legoktm) [01:31:21] (03PS6) 10Skizzerz: Add ghetto batching to the BlacklistUpdate [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101620 [01:32:22] (03CR) 10Skizzerz: Add ghetto batching to the BlacklistUpdate (031 comment) [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101620 (owner: 10Skizzerz) [01:35:15] (03PS1) 10PleaseStand: update.php: Fix PHP4 syntax error [core] - 10https://gerrit.wikimedia.org/r/102049 [01:35:22] (03PS7) 10Legoktm: Add ghetto batching to the BlacklistUpdate [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101620 (owner: 10Skizzerz) [01:35:45] (03CR) 10Legoktm: [C: 032 V: 032] "Woo!" [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101620 (owner: 10Skizzerz) [01:35:49] (03CR) 10Bsitu: "The 'comment(x)' link still doesn't work" (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95975 (owner: 10Werdna) [01:37:07] (03CR) 10Krinkle: [C: 032] Add 'npm' macro and jobs for oojs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101461 (owner: 10Krinkle) [01:37:55] (03Merged) 10jenkins-bot: Add 'npm' macro and jobs for oojs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101461 (owner: 10Krinkle) [01:39:37] (03PS1) 10Krinkle: Restore oojs-core-jslint and oojs-ui-jslint for 'check' pipeline [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102053 [01:39:44] (03CR) 10Krinkle: [C: 032] Restore oojs-core-jslint and oojs-ui-jslint for 'check' pipeline [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102053 (owner: 10Krinkle) [01:39:52] marktraceur: heh; we just distracted ourselves by filling a yoda gumball machine with gumballs [01:40:09] (03Merged) 10jenkins-bot: Restore oojs-core-jslint and oojs-ui-jslint for 'check' pipeline [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102053 (owner: 10Krinkle) [01:40:23] but! if you're up for it: https://gerrit.wikimedia.org/r/#/c/65299/ and https://gerrit.wikimedia.org/r/#/c/65868/ [01:42:57] (03PS1) 10Krinkle: Enable oojs-core-npm and oojs-ui-npm jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102054 [01:44:08] mwalker: So good to hear that it's a productive fundraising season [01:44:33] :D in this case; Josh's mum sent him some xmas presents that he didn't want to take home [01:44:35] mwalker: Have you been a good little boy and addressed the concerns of the other reviewers? [01:44:52] marktraceur: in the first two patches, mostly [01:44:55] it's been a LONG time though [01:45:20] the only one that I'm guesisng hasn't happened is getting chris to look at it [01:45:35] Ah, 'kay. [01:46:16] www.ohloh.net has redesigned profile pages, if you dont know ohloh.net, stats about all your commits across projects [01:46:58] * marktraceur is still waiting for their source code but kthx mutante [01:47:18] ohloh isn't open source? that's ironic [01:47:45] Right? [01:47:58] They have some data-crunching stuff that's free, but their website isn't AFAIK [01:48:05] Unless something changed [01:49:15] marktraceur: needs an an active opt-in if you want the new profile [01:49:27] among the new thigns are badges and [01:49:30] A new “current affiliation” field which will link you to your organization (upcoming feature) [01:49:46] Cool. [01:49:55] Badges reward your participation in FOSS projects and on Ohloh. To date, more than 75,000 Ohloh users have been awarded badges. [01:50:04] A cleaner, more compelling presentation of your online profile with new visualizations. Read more about new people pages - FOSS resume. [01:50:04] oooh; gamification [01:50:54] Gammification! [01:51:38] hmm... is that actually where they threaten to point a gamma ray source at you unless you fix all the bugs? [01:52:28] I think you mean "fix ALL the bugs." [01:53:08] hurm... side benefit of gamma radiation? the only bugs left remaining are related to cockroaches [01:55:28] (03PS4) 10Aaron Schulz: Removed cloudfiles dependency in SwiftFileBackend [core] - 10https://gerrit.wikimedia.org/r/101226 [01:55:39] mwalker: First MediaWiki, then THE WORLD!!!! Muahahaha. [01:55:45] (03CR) 10Aaron Schulz: "Passes all tests against ceph locally." [core] - 10https://gerrit.wikimedia.org/r/101226 (owner: 10Aaron Schulz) [01:55:47] (03CR) 10Krinkle: [C: 032] Enable oojs-core-npm and oojs-ui-npm jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102054 (owner: 10Krinkle) [01:55:51] can I stop for cookies first? [01:55:56] Sure sure [01:56:05] ok! I'm in [01:56:08] There will be cookies provided at regular intervals per your henchman contract [01:56:28] (03Merged) 10jenkins-bot: Enable oojs-core-npm and oojs-ui-npm jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102054 (owner: 10Krinkle) [02:09:36] (03PS1) 10Werdna: Fix post-edit page refreshing. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102057 [02:13:52] Hello! [02:17:05] (03CR) 10Aaron Schulz: [C: 032] update.php: Fix PHP4 syntax error [core] - 10https://gerrit.wikimedia.org/r/102049 (owner: 10PleaseStand) [02:18:06] (03CR) 10Bsitu: [C: 032] Fix post-edit page refreshing. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102057 (owner: 10Werdna) [02:18:18] (03Merged) 10jenkins-bot: Fix post-edit page refreshing. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102057 (owner: 10Werdna) [02:20:12] (03Merged) 10jenkins-bot: update.php: Fix PHP4 syntax error [core] - 10https://gerrit.wikimedia.org/r/102049 (owner: 10PleaseStand) [02:25:50] (03PS5) 10Aaron Schulz: Removed cloudfiles dependency in SwiftFileBackend [core] - 10https://gerrit.wikimedia.org/r/101226 [02:35:42] (03CR) 10Aaron Schulz: [C: 032] Provide access to Language::getFallbacksFor() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101910 (owner: 10Anomie) [02:37:36] (03Merged) 10jenkins-bot: Provide access to Language::getFallbacksFor() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101910 (owner: 10Anomie) [02:56:54] (03PS1) 10Krinkle: Make mwext-TemplateData-jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102059 [02:57:29] (03CR) 10Krinkle: [C: 032] Make mwext-TemplateData-jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102059 (owner: 10Krinkle) [02:57:38] (03Merged) 10jenkins-bot: Make mwext-TemplateData-jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102059 (owner: 10Krinkle) [02:59:34] (03PS1) 10Legoktm: Show log extract on Special:CentralAuth for all users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/102060 [03:17:31] (03PS1) 10Legoktm: Fix handling of IP blocks [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/102061 [03:29:37] (03CR) 10Shirayuki: "Thanks." [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/83096 (owner: 10Shirayuki) [03:39:23] (03PS1) 10Legoktm: Fix BlacklistUpdate::saveState [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/102064 [03:41:11] (03PS1) 10Tim Starling: eval.php: update intro comment [core] - 10https://gerrit.wikimedia.org/r/102065 [03:56:25] (03CR) 10Tim Starling: [C: 031] "Looks good, can be merged when the schema change is done." [core] - 10https://gerrit.wikimedia.org/r/101170 (owner: 10Aaron Schulz) [04:04:48] (03CR) 10Skizzerz: [C: 032 V: 032] Fix BlacklistUpdate::saveState [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/102064 (owner: 10Legoktm) [04:08:02] (03CR) 10Tim Starling: [C: 04-1] "Looks good, apart from a style issue." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100198 (owner: 10Umherirrender) [04:13:11] (03PS1) 10Legoktm: Respect $wgBlockAllowsUTEdit [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/102068 [04:14:16] (03CR) 10Skizzerz: [C: 04-1] Don't load confidence if we've already made 20,000 requests (033 comments) [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/102018 (owner: 10Legoktm) [04:27:26] (03PS2) 10Legoktm: Use a specific debug log group. [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/102061 [04:38:44] (03CR) 10Skizzerz: [C: 032 V: 032] "Ayup." [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/102061 (owner: 10Legoktm) [04:55:12] hey yurik [04:57:37] hi diwanship [04:58:44] Please review slide 9 http://www.codecademy.com/courses/web-intermediate-en-BLea4/0/9 [04:59:41] diwanship, use names: == header == === subheader=== etc [04:59:57] diwanship, also, the intro text is missing - see my notes https://etherpad.wikimedia.org/p/codeacademy-diwanship [05:02:43] ok yurik i wanted to make it for bolding the text but as bolding needs 3 apostrophes and anything under text parameter is written within single quotes [05:03:01] the bold text is not working i tried usinf slashes too [05:03:19] diwanship, use double quotes " " [05:03:33] in javascript you can use either [05:03:45] (03PS1) 10Shirayuki: i18n: add whitespace before "gwtoolset-required-field" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102069 [05:04:18] ok yurik :) [05:11:12] (03CR) 10Santhosh: [C: 031] "Thanks, looks good to me, Added Niklas also as reviewer." [core] - 10https://gerrit.wikimedia.org/r/100931 (owner: 10Tim Starling) [05:37:34] yurik please review the changes http://www.codecademy.com/courses/web-intermediate-en-BLea4/0/9 [05:39:11] legoktm: The MassMessage log is making me sad. [05:39:13] diwanship, looks better, but i wouldn't have a separate CSS here (usually you would, just that here i would rather simplify... [05:39:22] Because it has literal "[[m:]]" in it. [05:39:30] It looks pretty ghetto. [05:39:36] i'm not 100% positive on this [05:39:44] diwanship, ^ [05:40:08] i suggest you just set style for the needed element directly [05:40:23] e.g.
[05:40:27] ya sure [05:40:29] btw, id=X [05:40:38] is not a good form imho - shouldn't it be quoted? [05:41:10] yes it should hav been my mistake [05:41:14] Gloria: oh, hmmm. [05:41:23] Gloria: can you file a bug for that? [05:41:32] I thought you knew, heh. [05:41:33] Yes. [05:42:14] diwanship, have you had a chance to email codeacademy re import/export functionality? It would be awesome if we could just put all that text into git [05:42:26] much more managable, easier to see history, etc [05:42:39] and much safer [05:43:17] (doesn't dissappear if they crash) [05:43:30] https://bugzilla.wikimedia.org/show_bug.cgi?id=58565 [05:45:12] No but i think i will email them about this also thier code window hangs frequently because of which work gets slowed [05:48:45] (03CR) 10IAlex: [C: 032] eval.php: update intro comment [core] - 10https://gerrit.wikimedia.org/r/102065 (owner: 10Tim Starling) [05:51:45] (03Merged) 10jenkins-bot: eval.php: update intro comment [core] - 10https://gerrit.wikimedia.org/r/102065 (owner: 10Tim Starling) [05:53:13] diwanship, don't put it into the same email - one issue per email is the rule :) [05:54:04] diwanship, also, you probably want to keep the code the same style as all other slides for consistency - just make the HTML different - would be easier too [05:56:56] (03CR) 10Krinkle: [C: 04-1] Migrate redirectToFragment() from wikibits.js to own module (033 comments) [core] - 10https://gerrit.wikimedia.org/r/94412 (owner: 10Umherirrender) [05:57:38] Gloria: blegh, it was a stupid bug. [05:57:47] (03CR) 10Krinkle: Migrate redirectToFragment() from wikibits.js to own module (031 comment) [core] - 10https://gerrit.wikimedia.org/r/94412 (owner: 10Umherirrender) [05:57:48] yurik that is why i used the diffrent css file so that i can use the same css in all slides. i have changed the css http://www.codecademy.com/courses/web-intermediate-en-BLea4/0/9 pls see [05:58:55] diwanship, there is no css [05:59:10] which part are you showing? [06:00:13] diwanship, you don't want to set text-align for html result [06:00:45] Gloria: http://cl.ly/image/3W203W3x0R2J :| [06:01:23] legoktm: Weird. [06:01:28] Something not getting escaped? [06:01:33] well, I'm parsing all wikitext [06:01:38] yurik sorry gave you the wrong link http://www.codecademy.com/courses/web-intermediate-en-BLea4/0/9 [06:01:53] legoktm: Right. You need the edit summary parser, if it's available. [06:02:02] I have no idea if it is. [06:02:06] One wonders where it lives. [06:02:29] yes changed it [06:02:32] That would work, right? Because you want to parse only links, but not and such. [06:03:26] diwanship, much better, i was kinda worried with the prev link :) [06:04:00] :) tell me how i can make it 100% positive [06:05:14] Gloria: aha, this will be interesting. [06:05:56] diwanship, that will be a while - there are two key principals you MUST learn. I will not like it unless they are followed: KISS and DRY [06:06:16] do you know what they are? [06:06:38] :P no i have no idea yurik [06:06:46] google is your friend :) [06:07:08] search for define:KISS [06:09:45] yurik got it :) [06:09:53] both? [06:10:01] yes [06:10:10] good, now lets try to look at index.php [06:10:13] You don't need Google. [06:10:14] sorry, index.html [06:10:16] Wikipedia covers that. [06:10:19] ;-) [06:10:19] yes [06:10:21] Or Wiktionary! [06:10:35] gloria, google is a small proprietary search utility for wikipedia [06:10:42] Heh. [06:10:58] we are working on replacing it, but currently a bit understaffed [06:11:21] Cirrus! [06:11:49] diwanship, soo... what do you see there that doesn't fit in those terms? [06:13:20] yurik repeated div tags and its not simple to read the code it may be difficult for novice users [06:13:29] good :) [06:14:06] also look at CSS [06:14:35] so clean it up, and i will critique further [06:14:51] and be prepared that until it looks perfect, i will critique [06:15:06] but hopefully i won't have to do as much critiquing on the next one [06:15:26] ok in css what? the colors or the style ? [06:15:41] (03PS1) 10Legoktm: Parse wikilinks in skip log entries [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/102072 [06:15:47] Gloria: ^ [06:16:14] diwanship, color repeats, you use different text align pattern, etc [06:16:16] \o/ [06:16:43] diwanship, also, since parse adds "[edit]", lets use "KISS" and show bold / italic first [06:17:01] because we don't want to confuse and explain it [06:17:21] (03PS2) 10Legoktm: Parse wikilinks in skip log entries [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/102072 [06:19:02] ok so i'l make the same(with mentioned changes) but for showing bold /italics wiki markup [06:19:06] diwanship, when you email them, CC me [06:19:26] ya sure i'll [06:19:33] diwanship, just change this one [06:19:38] ok [06:19:58] this is the first intro slide, lets intro it as such, and btw, use several text lines [06:21:08] yurik i dint get "use several text lines" [06:23:05] diwanship, set text: "some text \ [06:23:09] some more text\ [06:23:17] and maybe a bit more", [06:23:42] like two or more sentences [06:32:33] diwanship, more like a few lines that show '''bold text''', ''italic text'', [http://link-to-api-doc documentation link], etc [06:33:21] ok yurik [06:34:29] (03CR) 1001tonythomas: "@Parent5446 :- Can you please hint out what needs to be done with the Token Cookies. I am new to Token Cookies, thats why." [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [06:44:11] (03PS1) 10TTO: Replace hidesig module with a more robust implementation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102076 [06:44:13] (03CR) 10jenkins-bot: [V: 04-1] Replace hidesig module with a more robust implementation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102076 (owner: 10TTO) [06:47:06] (03PS1) 10Krinkle: Allow concurrent builds for {name}-npm jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102078 [06:47:33] (03PS2) 10Krinkle: Allow concurrent builds for {name}-npm jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102078 [06:48:38] (03CR) 10Krinkle: [C: 032] "Pushed updates for 'oojs-core-npm' and 'oojs-ui-npm' to Jenkins." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102078 (owner: 10Krinkle) [06:51:04] (03PS3) 10Tim Starling: Removed deprecated job ID cruft [core] - 10https://gerrit.wikimedia.org/r/101815 (owner: 10Aaron Schulz) [06:51:11] (03CR) 10Tim Starling: [C: 032] Removed deprecated job ID cruft [core] - 10https://gerrit.wikimedia.org/r/101815 (owner: 10Aaron Schulz) [06:51:54] (03CR) 10jenkins-bot: [V: 04-1] Removed deprecated job ID cruft [core] - 10https://gerrit.wikimedia.org/r/101815 (owner: 10Aaron Schulz) [06:52:19] (03CR) 10Krinkle: [C: 04-1] Replace hidesig module with a more robust implementation (032 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102076 (owner: 10TTO) [06:56:29] (03CR) 10Krinkle: Removed 'Remember my login' option from the Preferences page (031 comment) [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [06:56:35] (03CR) 10Krinkle: [C: 04-1] Removed 'Remember my login' option from the Preferences page [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [06:59:23] (03PS11) 10Yurik: Initial implementation of the JSON configuration store. [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 [07:04:07] (03PS2) 10TTO: Replace hidesig module with a more robust implementation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102076 [07:09:47] (03PS1) 10Aaron Schulz: Moved ScopedCallback to /libs [core] - 10https://gerrit.wikimedia.org/r/102080 [07:13:01] (03CR) 10IAlex: "You need to pass $this->mRemember as new parameter to User::setCookies() as before this was done by setting the 'rememberpassword' option." [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [07:14:44] (03PS1) 10PleaseStand: Check for very old PCRE versions in installer and updater [core] - 10https://gerrit.wikimedia.org/r/102081 [07:17:29] (03CR) 10Siebrand: [C: 032] Correct the plural forms for Manx (Gaelg) [core] - 10https://gerrit.wikimedia.org/r/100757 (owner: 10Santhosh) [07:20:40] (03Merged) 10jenkins-bot: Correct the plural forms for Manx (Gaelg) [core] - 10https://gerrit.wikimedia.org/r/100757 (owner: 10Santhosh) [07:23:28] (03CR) 10PleaseStand: "Note that the target of the "More information" link is still a draft and is currently located at (03PS1) 10Siebrand: Correct the plural forms for Manx (Gaelg) [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102082 [07:34:34] (03PS1) 10Netbrain: Added support for html comments within sidebarmenu syntax, this allows for adding comments within the syntax. [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/102083 [07:35:41] (03CR) 10Netbrain: [C: 032 V: 032] "ok" [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/102083 (owner: 10Netbrain) [07:39:56] superm401: ping [07:40:03] Hey, Krinkle [07:40:17] superm401: Did you make MediaWiki:Signupend as staff or as global edit interface? [07:40:32] Either way, please respond to nl.wikipedia where they reverted your edit. [07:40:51] edit interface. Philippe preferred that to staff. [07:41:01] or #wikipedia-nl, user Moira2. [07:41:19] She (Moira2) just pinged me there to ping you. [07:42:09] let me ping you guys about -nl reverting what you just pinged each other about :) [07:42:56] superm401: Could you join for a bit? [07:43:05] Krinkle, yeah, I was looking at the wiki. [07:50:10] (03PS1) 10Siebrand: Handle explicit plural forms in custom convertPlural in language classes [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/102085 [07:51:35] (03CR) 10jenkins-bot: [V: 04-1] Handle explicit plural forms in custom convertPlural in language classes [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/102085 (owner: 10Siebrand) [07:54:56] StevenW: superm401: The reason was indeed usability/design, right? [07:55:14] Krinkle, exactly. [07:55:30] We think the people who make lame usernames are unlikely to heed these instructions. [07:55:38] Whereas for everyone else it's a huge block of text. [07:55:51] Yeah, I agree completely. If anything, it would've been another reason to get rid of it. [07:56:22] (03PS2) 10Aude: Add SkinTemplateAfterLanguages hook to add html after language links [core] - 10https://gerrit.wikimedia.org/r/101895 [07:57:31] (03PS5) 10Dan-nl: add-project-link [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 [08:01:12] (03PS2) 10Siebrand: Fixes for plural handling [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102082 [08:01:45] (03CR) 10Aude: "renamed the hook and added support for CologneBlue. ModernTemplate derives from MonoBookTemplate, so it is covered here." [core] - 10https://gerrit.wikimedia.org/r/101895 (owner: 10Aude) [08:02:28] (03Abandoned) 10Siebrand: Make explicit plural forms work for Russian [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/99090 (owner: 10Siebrand) [08:02:29] (03CR) 10Dan-nl: "- addressed siebrand’s inline comments in ps 3." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 (owner: 10Dan-nl) [08:02:30] (03PS3) 10Aude: Add SkinTemplateAfterLanguages hook to add html after language links [core] - 10https://gerrit.wikimedia.org/r/101895 [08:02:33] (03Abandoned) 10Siebrand: Handle explicit plural forms in custom convertPlural in language classes [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/99088 (owner: 10Siebrand) [08:03:15] (03CR) 10jenkins-bot: [V: 04-1] Fixes for plural handling [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102082 (owner: 10Siebrand) [08:03:50] (03PS6) 10Dan-nl: add-project-link [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 [08:05:57] (03PS7) 10Dan-nl: add-project-link [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 [08:06:14] (03CR) 10Dan-nl: "- fixed punctuation." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 (owner: 10Dan-nl) [08:08:33] (03PS1) 10Aaron Schulz: Added streamFile() unit tests [core] - 10https://gerrit.wikimedia.org/r/102086 [08:12:30] (03CR) 10Physikerwelt: [C: 032] Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 (owner: 10Physikerwelt) [08:17:02] (03CR) 10MZMcBride: Store title as a job parameter (032 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/101814 (owner: 10Legoktm) [08:18:26] (03Abandoned) 10Siebrand: Handle explicit plural forms in custom convertPlural in language classes [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/102085 (owner: 10Siebrand) [08:27:31] (03CR) 10Yurik: "MaxSem, thanks for the excellent review. Most of the issues were fixed already, some more fixes will be checked in shortly. Comments inlin" (0328 comments) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [08:27:34] (03PS1) 10Aaron Schulz: Remove unused job ID parameter from jobs [core] - 10https://gerrit.wikimedia.org/r/102087 [08:29:25] (03PS3) 10Siebrand: Fixes for plural handling [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102082 [08:32:23] (03PS4) 10Siebrand: Fixes for plural handling [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102082 [08:52:31] (03CR) 10Nikerabbit: "Can these be removed from extensions as well? What is the minimum version of MediaWiki that can do without these?" [core] - 10https://gerrit.wikimedia.org/r/101815 (owner: 10Aaron Schulz) [08:54:02] (03PS12) 10TTO: Support ApiPageSet in ApiWatch [core] - 10https://gerrit.wikimedia.org/r/53964 (owner: 10Eranroz) [08:54:28] (03CR) 10TTO: "PS12: another rebase" [core] - 10https://gerrit.wikimedia.org/r/53964 (owner: 10Eranroz) [09:02:33] (03PS7) 1001tonythomas: Removed 'Remember my login' option from the Preferences page [core] - 10https://gerrit.wikimedia.org/r/94614 [09:03:12] (03CR) 10jenkins-bot: [V: 04-1] Removed 'Remember my login' option from the Preferences page [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [09:06:25] (03PS12) 10Yurik: Initial implementation of the JSON configuration store. [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 [09:28:58] (03PS8) 1001tonythomas: Removed 'Remember my login' option from the Preferences page [core] - 10https://gerrit.wikimedia.org/r/94614 [09:46:28] (03PS9) 1001tonythomas: Removed 'Remember my login' option from the Preferences page [core] - 10https://gerrit.wikimedia.org/r/94614 [09:51:20] (03PS1) 10Catrope: [WIP] Add support for JSON i18n files [core] - 10https://gerrit.wikimedia.org/r/102098 [09:57:39] (03CR) 10Catrope: "TODO:" [core] - 10https://gerrit.wikimedia.org/r/102098 (owner: 10Catrope) [10:07:37] (03CR) 10Hashar: some group and right messages are missing (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101861 (owner: 10Dan-nl) [10:07:45] How to change the release notes, in the mediawiki tarball we get on download ? [10:17:49] (03PS1) 10Tinaj1234: Removed indentation button from WikiEditor extension [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102101 [10:21:32] (03CR) 10Nikerabbit: [WIP] Add support for JSON i18n files (033 comments) [core] - 10https://gerrit.wikimedia.org/r/102098 (owner: 10Catrope) [10:23:04] (03CR) 10Catrope: [WIP] Add support for JSON i18n files (032 comments) [core] - 10https://gerrit.wikimedia.org/r/102098 (owner: 10Catrope) [10:35:20] (03CR) 10Bartosz Dziewoński: "The "…\K" in CSSMin is my doing, but it seems necessary without rewriting the entire logic from scratch; the only alternative I could thin" [core] - 10https://gerrit.wikimedia.org/r/102081 (owner: 10PleaseStand) [10:35:20] (03PS2) 10Daniel Kinzler: (bug 47070) check content model namespace on import. [core] - 10https://gerrit.wikimedia.org/r/100563 [10:36:31] (03CR) 10Bartosz Dziewoński: [C: 031] Check for very old PCRE versions in installer and updater [core] - 10https://gerrit.wikimedia.org/r/102081 (owner: 10PleaseStand) [10:37:27] (03PS4) 10Hashar: Clean up: Remove a few redundant 'scm' properties [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101462 (owner: 10Krinkle) [10:40:20] (03CR) 10Hashar: [C: 032] "indeed no code change. The way I do the comparison is:" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101462 (owner: 10Krinkle) [10:40:37] (03Merged) 10jenkins-bot: Clean up: Remove a few redundant 'scm' properties [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101462 (owner: 10Krinkle) [10:40:51] (03PS3) 10Hashar: Allow concurrent builds for {name}-npm jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102078 (owner: 10Krinkle) [10:42:24] (03CR) 10Hashar: [C: 032] "confirmed on Jenkins that this has been deployed." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102078 (owner: 10Krinkle) [10:42:38] (03PS1) 10Ori.livneh: Fix command-line argument handling for Vagrant 1.4 [vagrant] - 10https://gerrit.wikimedia.org/r/102105 [10:42:40] (03Merged) 10jenkins-bot: Allow concurrent builds for {name}-npm jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102078 (owner: 10Krinkle) [10:43:10] (03CR) 10Ori.livneh: [C: 032] Fix command-line argument handling for Vagrant 1.4 [vagrant] - 10https://gerrit.wikimedia.org/r/102105 (owner: 10Ori.livneh) [10:43:14] (03Merged) 10jenkins-bot: Fix command-line argument handling for Vagrant 1.4 [vagrant] - 10https://gerrit.wikimedia.org/r/102105 (owner: 10Ori.livneh) [10:47:22] (03CR) 10Bartosz Dziewoński: "IE8 issues were filed as bug 58536." [core] - 10https://gerrit.wikimedia.org/r/98137 (owner: 10MegaAlex) [10:52:39] (03CR) 10Hashar: "> a pretty old npm (v1.1.39)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101461 (owner: 10Krinkle) [10:53:26] (03PS13) 10TTO: Support ApiPageSet in ApiWatch [core] - 10https://gerrit.wikimedia.org/r/53964 (owner: 10Eranroz) [10:54:26] (03CR) 10TTO: "PS13: re-add release note that got lost in the rebase (to 1.23 file this time)" [core] - 10https://gerrit.wikimedia.org/r/53964 (owner: 10Eranroz) [11:02:48] (03Abandoned) 10Bartosz Dziewoński: Update collapsible lists below edit form on live preview via mw.hook [core] - 10https://gerrit.wikimedia.org/r/99714 (owner: 10Bartosz Dziewoński) [11:03:07] (03CR) 10Helder.wiki: "Shouldn't this be on" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102101 (owner: 10Tinaj1234) [11:05:14] (03CR) 10Helder.wiki: "See also:" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/93665 (owner: 10Tinaj1234) [11:11:29] (03CR) 10Bartosz Dziewoński: "±0 :)" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/101470 (owner: 10Krinkle) [11:14:32] (03CR) 10Bartosz Dziewoński: "Copied some comments from older patchsets." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/53964 (owner: 10Eranroz) [11:15:27] (03CR) 10Jens Ohlig: [C: 04-1] "See comments by anomie." (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man) [11:16:51] (03PS1) 10Aude: Add Scribunto as dependency for Wikibase (client) tests [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102109 [11:27:29] (03CR) 10Bartosz Dziewoński: "And re createaccount, it is definitely not used as button label right now (createacct-submit is used instead)." [core] - 10https://gerrit.wikimedia.org/r/100724 (owner: 10MegaAlex) [11:28:34] (03CR) 10Bartosz Dziewoński: "(I think this can be merged now, no? Assuming somebody from TWN will copy the current translations.)" [core] - 10https://gerrit.wikimedia.org/r/100724 (owner: 10MegaAlex) [11:30:03] (03CR) 10TTO: "Eranroz: if you're still around, would you like to fix this up?" [core] - 10https://gerrit.wikimedia.org/r/53964 (owner: 10Eranroz) [12:16:31] (03PS1) 10Theopolisme: Add raw HTML output functionality [core] - 10https://gerrit.wikimedia.org/r/102121 [12:28:42] (03CR) 10Siebrand: "Fixed in next PS." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100981 (owner: 10Siebrand) [12:29:45] (03PS2) 10Siebrand: Update comment for wfMsgExt() [core] - 10https://gerrit.wikimedia.org/r/100981 [12:35:44] hey siebrand, do i need to adjust anything else for https://gerrit.wikimedia.org/r/#/c/101487/ or does it look okay now? [12:38:03] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 (owner: 10Dan-nl) [12:38:26] thanks siebrand [12:40:34] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/100563 (owner: 10Daniel Kinzler) [12:42:55] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/102121 (owner: 10Theopolisme) [12:51:26] (03PS1) 10Hashar: make some more jobs concurrent [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102125 [12:51:38] (03CR) 10Hashar: [C: 032] make some more jobs concurrent [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102125 (owner: 10Hashar) [12:51:56] (03Merged) 10jenkins-bot: make some more jobs concurrent [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102125 (owner: 10Hashar) [12:53:39] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102081 (owner: 10PleaseStand) [12:54:56] I am getting this error while pushing code into mediawiki-core branch REL1_22. In git status it says ' Your branch is ahead of 'origin/REL1_22' by 1 commit.' and while git review, it shows a lot of commits, and therefore cant upload patch [12:55:02] Please help [12:55:36] (03CR) 10Siebrand: [C: 04-1] "Please do not re-upload your patches, but amend them. See https://www.mediawiki.org/wiki/Git/TLDR for details." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102101 (owner: 10Tinaj1234) [13:01:27] (03CR) 10Matthias Mullie: [C: 032] Don't dynamically define $container [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102027 (owner: 10Legoktm) [13:01:46] (03CR) 10Siebrand: "See inline reply." (031 comment) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [13:02:07] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [13:02:08] (03CR) 10Matthias Mullie: [C: 032] Fix typo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102028 (owner: 10Legoktm) [13:02:19] (03Merged) 10jenkins-bot: Fix typo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102028 (owner: 10Legoktm) [13:05:13] (03CR) 10Matthias Mullie: Cleanup ApiParsoidUtilsFlow (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102044 (owner: 10Legoktm) [13:06:32] (03CR) 10Matthias Mullie: [C: 032] Cleanup ApiQueryFlow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102030 (owner: 10Legoktm) [13:06:42] (03Merged) 10jenkins-bot: Cleanup ApiQueryFlow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102030 (owner: 10Legoktm) [13:07:06] tonythomaas01: this is a common annoyance with git review. do git fetch --all, then try again [13:08:12] (you could actually just push all of these commits, they should all be ignored because they are already known, but i know, it's annoying) [13:09:41] (03CR) 10Tinaj1234: "I tried amending the change but I'm not able to checkout the change. This is the error I get:" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102101 (owner: 10Tinaj1234) [13:10:46] I tried it too, actually git status shows everything exact till I do git-commit. After git-commit, even git show HEAD shows the right thing. Then git-review gives me the wrong result [13:10:49] :( [13:11:17] DanielK_WMDE: I can push all those ? [13:11:21] tonythomaas01: that's because git-review uses a different master. are you sure you tried git fetch --all, and it doen't help? [13:11:26] (the --all is important) [13:12:13] tonythomaas01: you can also push directly without using git-review, but i keep forgetting the correct syntax [13:12:50] DanielK_WMDE: ok. Again, after git fetch --all gives me the same result. [13:13:06] DanielK_WMDE: Is there a way to push only the HEAD into gerrit ? [13:13:23] git push origin HEAD:refs/for/...soemthing... [13:13:39] to find the ...something..., look at the git fetch line given on the change's page on gerrit [13:14:00] DanielK_WMDE: OK. Let me check that out [13:14:03] tonythomaas01: are you sure your repo is set up right? do you have a remote called "gerrit"? [13:14:09] git push gerrit HEAD:refs/for/master [13:14:19] https://www.mediawiki.org/wiki/Git/Workflow [13:14:22] thedj: But I am not working on master [13:14:35] thedj: Its on REL1_22 [13:14:38] here's some troublöe shooting info: https://www.mediawiki.org/wiki/Gerrit/Advanced_usage [13:14:51] (03CR) 10Matthias Mullie: [C: 04-1] Use ApiBase::requireOnlyOneParameter (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102025 (owner: 10Legoktm) [13:15:17] thedj: oh, you don't push to the changes branch at all, but directly to refs/for/whatever?... [13:15:20] i find that confusing :) [13:15:33] it is confusing [13:15:37] tonythomaas01: then it's refs/for/REL1_22 [13:15:58] and i believe it's not even necessary anymore nowadays, but i'm not gonna be the one to try that out :D [13:16:03] DanielK_WMDE: Ok. Let me try that [13:17:13] tonythomaas01: oh! but that may also be the reason "git review" shows you a bazillion commits! you need to explicitly specify the target branch. so, you have to use "git review REL1_22". That should not show you all the extra commits [13:17:43] (why git-review can't recall what the current change aplpied to, i don't know) [13:19:30] DanielK_WMDE: and I get this error '! [remote rejected] HEAD -> correctReleaseNote (prohibited by Gerrit) ! [remote rejected] refs/for/REL1_22 (missing object(s)' [13:19:32] :( [13:20:07] DanielK_WMDE: This time I am going to push them all. [13:20:23] (03PS1) 1001tonythomas: Corrected the MediaWiki 1.22 Release notes [core] - 10https://gerrit.wikimedia.org/r/102131 [13:20:26] tonythomaas01: sounds like something is quite confused :) did you try "git review REL1_22"? [13:20:49] tonythomaas01: oh, look - that#s your change up there --^^ [13:20:55] DanielK_WMDE: I didnt do that. Oh [13:21:00] um [13:21:02] (03CR) 10jenkins-bot: [V: 04-1] Corrected the MediaWiki 1.22 Release notes [core] - 10https://gerrit.wikimedia.org/r/102131 (owner: 1001tonythomas) [13:21:06] git checkout, rather? [13:21:15] git checkout gerrit/REL1_22 [13:21:17] MatmaRex: hm? [13:21:23] to check out the branch [13:21:26] MatmaRex: he was trying to push [13:21:28] then just `git review` to submit changes [13:22:00] ah, hmm [13:22:02] Now jenkins bot gives cross. Ok. Let me try git-review REL1_22 [13:22:06] this is based on REL1)22 [13:22:18] tonythomaas01: git push gerrit HEAD:refs/for/REL1_22 [13:22:41] (03Abandoned) 1001tonythomas: Corrected the MediaWiki 1.22 Release notes [core] - 10https://gerrit.wikimedia.org/r/102131 (owner: 1001tonythomas) [13:22:48] git review should do that internally, hm. [13:24:18] i think somebody forgot to update the .gitreview config on the branch… [13:24:24] * MatmaRex points at hexmode [13:24:34] (03PS1) 1001tonythomas: Corrected the MediaWiki 1.22 Release notes [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102132 [13:25:40] Looks like git-review REL1_22 [13:25:53] worked. waiting for jenkins-bot [13:26:06] It got +1, thanks [13:26:34] (03PS1) 10Bartosz Dziewoński: Update .gitreview for REL1_22 branch [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102134 [13:26:48] tonythomaas01: the above change will make plain `git review` work as well [13:27:01] gods, the 1.22 release was such a total failure it's not even funny [13:27:13] MatmaRex: Thanks ! :) [13:27:49] (03CR) 10Bartosz Dziewoński: [C: 032] "This should have been done right after branching…" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102134 (owner: 10Bartosz Dziewoński) [13:29:13] (03CR) 10Jens Ohlig: [C: 031] "Needed to make Jenkins run automatic tests." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102109 (owner: 10Aude) [13:31:43] (03Merged) 10jenkins-bot: Update .gitreview for REL1_22 branch [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102134 (owner: 10Bartosz Dziewoński) [13:35:00] (03CR) 10Parent5446: [C: 04-1] Moved ScopedCallback to /libs (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102080 (owner: 10Aaron Schulz) [13:41:31] (03CR) 10Multichill: [C: 031] "Fine with me." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 (owner: 10Dan-nl) [13:43:55] (03CR) 10Parent5446: "Explanation inline. Sorry for not explaining earlier." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [13:45:47] (03PS1) 10Matthias Mullie: Add space between '[Show]' and 'Hidden by User' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102136 [13:46:14] (03PS1) 10Hashar: mediawiki-core-code-coverage with phpclover plugin [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102137 [13:46:22] (03CR) 10Hashar: [C: 032] mediawiki-core-code-coverage with phpclover plugin [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102137 (owner: 10Hashar) [13:46:44] (03Merged) 10jenkins-bot: mediawiki-core-code-coverage with phpclover plugin [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102137 (owner: 10Hashar) [13:48:20] (03PS1) 10Hashar: typo in mediawiki-core-code-coverage [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102138 [13:48:37] (03CR) 10Hashar: [C: 032] typo in mediawiki-core-code-coverage [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102138 (owner: 10Hashar) [13:48:56] (03Merged) 10jenkins-bot: typo in mediawiki-core-code-coverage [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102138 (owner: 10Hashar) [13:50:12] (03CR) 10MarkAHershberger: [C: 032] "thanks" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102082 (owner: 10Siebrand) [13:50:21] (03CR) 10Parent5446: [C: 031] "Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/101233 (owner: 10Umherirrender) [13:52:17] (03PS3) 10Hashar: Count categories in deploy script [tools/release] - 10https://gerrit.wikimedia.org/r/101130 (owner: 10Jdlrobson) [13:53:26] (03CR) 10Parent5446: [C: 04-1] "Minor formatting issue." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98267 (owner: 10Umherirrender) [13:57:00] (03CR) 10Hashar: [C: 032] git-logs: count categories in deploy script [tools/release] - 10https://gerrit.wikimedia.org/r/101130 (owner: 10Jdlrobson) [13:57:06] (03Merged) 10jenkins-bot: git-logs: count categories in deploy script [tools/release] - 10https://gerrit.wikimedia.org/r/101130 (owner: 10Jdlrobson) [14:03:24] (03CR) 10Parent5446: [WIP] Add support for JSON i18n files (032 comments) [core] - 10https://gerrit.wikimedia.org/r/102098 (owner: 10Catrope) [14:06:37] (03CR) 10Bartosz Dziewoński: Make SpecialWatchlist extend SpecialRecentChanges: step 1 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/89379 (owner: 10Bartosz Dziewoński) [14:19:26] (03CR) 10Nikerabbit: [WIP] Add support for JSON i18n files (032 comments) [core] - 10https://gerrit.wikimedia.org/r/102098 (owner: 10Catrope) [14:36:23] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102076 (owner: 10TTO) [14:41:32] (03CR) 10Siebrand: "* Why blank?" [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102037 (owner: 10Chad) [14:48:13] (03PS1) 10Siebrand: Successfuly decrease the number of superfluous words [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102146 [14:53:04] (03CR) 10Siebrand: [C: 032] Change message 'rcshowhideliu' to match its actual functionality [core] - 10https://gerrit.wikimedia.org/r/102019 (owner: 10MegaAlex) [14:55:39] (03CR) 10Anomie: [C: 031] "Seems sane. Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/102081 (owner: 10PleaseStand) [14:56:13] (03Merged) 10jenkins-bot: Change message 'rcshowhideliu' to match its actual functionality [core] - 10https://gerrit.wikimedia.org/r/102019 (owner: 10MegaAlex) [14:57:10] (03CR) 10Werdna: [C: 04-2] "I don't think these copy changes make sense. "Successfully" is common in confirmation messages, and there's no reason to remove it – the s" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102146 (owner: 10Siebrand) [14:59:37] (03CR) 10Werdna: Consolidate and clean up "scroll to this element" code (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95975 (owner: 10Werdna) [15:02:16] (03CR) 10Anomie: "You may as well fix the call to $this->getContext()->getUser() in ApiQueryFlow.php while you're at it." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102046 (owner: 10Legoktm) [15:12:01] (03CR) 10Anomie: [C: 04-1] "See comments on earlier patches." [core] - 10https://gerrit.wikimedia.org/r/53964 (owner: 10Eranroz) [15:17:12] (03PS1) 10Hashar: mw-install-sqlite: .sqlite deletion had a race condition [integration/jenkins] - 10https://gerrit.wikimedia.org/r/102149 [15:17:24] (03CR) 10Hashar: [C: 032] mw-install-sqlite: .sqlite deletion had a race condition [integration/jenkins] - 10https://gerrit.wikimedia.org/r/102149 (owner: 10Hashar) [15:17:50] (03Merged) 10jenkins-bot: mw-install-sqlite: .sqlite deletion had a race condition [integration/jenkins] - 10https://gerrit.wikimedia.org/r/102149 (owner: 10Hashar) [15:18:39] (03CR) 10Anomie: Add mw.html to Scribunto (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man) [15:22:59] (03PS1) 10Hashar: (WIP) mediawiki-core-phpunit-* made concurrent (WIP) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102152 [15:23:40] (03CR) 10MarkAHershberger: [C: 032] "Thanks!" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102132 (owner: 1001tonythomas) [15:25:03] (03CR) 10Hashar: [C: 04-2] "Deployed manually on:" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102152 (owner: 10Hashar) [15:25:33] (03CR) 10MarkAHershberger: "adding mglaser so he gets an email about this for testing." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102134 (owner: 10Bartosz Dziewoński) [15:28:01] (03CR) 1001tonythomas: "The stable version is 1.22.0 itself right? So I thought making it thus won't do much harm. :)" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102132 (owner: 1001tonythomas) [15:29:38] (03PS1) 10Matthias Mullie: Attribution for authors of moderated content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102153 [15:29:40] (03PS1) 10Matthias Mullie: Use FlowAction permissions in AbstractRevision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102154 [15:30:22] (03CR) 10Dan-nl: [C: 032 V: 032] i18n: add whitespace before "gwtoolset-required-field" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102069 (owner: 10Shirayuki) [15:30:52] (03PS1) 10Andrew Bogott: Check the puppetstatus timestamp. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/102155 [15:33:12] (03PS1) 10Matthias Mullie: Require getRevisionType in classes that extend AbstractRevision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102156 [15:33:20] (03CR) 10jenkins-bot: [V: 04-1] Require getRevisionType in classes that extend AbstractRevision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102156 (owner: 10Matthias Mullie) [15:34:24] (03Merged) 10jenkins-bot: Corrected the MediaWiki 1.22 Release notes [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102132 (owner: 1001tonythomas) [15:36:06] (03PS2) 10Catrope: [WIP] Add support for JSON i18n files [core] - 10https://gerrit.wikimedia.org/r/102098 [15:36:32] andre__: thank you for pinging bugs from time to time :-) [15:36:39] andre__: recent example of one of your ping https://bugzilla.wikimedia.org/show_bug.cgi?id=57880#c3 [15:36:53] andre__: that forced me to look at the bug and eventually closed it \O/ [15:36:55] 1 less bug! [15:38:56] (03CR) 10Mglaser: Corrected the MediaWiki 1.22 Release notes (031 comment) [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102132 (owner: 1001tonythomas) [15:39:59] (03CR) 10Mglaser: "Thanks for working on this. Please see my previous comment, though" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102132 (owner: 1001tonythomas) [15:41:28] hashar, sometimes I go through ancient stuff. Glad it helps :) [15:43:31] (03CR) 10Catrope: [WIP] Add support for JSON i18n files (034 comments) [core] - 10https://gerrit.wikimedia.org/r/102098 (owner: 10Catrope) [15:45:54] (03CR) 10Daniel Kinzler: "@siebrand: there are no new keys, just updated wording." [core] - 10https://gerrit.wikimedia.org/r/100563 (owner: 10Daniel Kinzler) [15:49:00] andre__: really helpful, keep doing it :) [15:53:06] (03PS2) 10Andrew Bogott: Check the puppetstatus timestamp. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/102155 [16:05:32] (03PS1) 1001tonythomas: The Release Notes for Mediawiki 1.22 was updated. [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102162 [16:07:49] (03CR) 1001tonythomas: "@Mglaser: I corrected line 7 to look more meaningfull" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102132 (owner: 1001tonythomas) [16:08:46] (03CR) 10Mglaser: [C: 031] "Thanks! Looks good to me now" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102162 (owner: 1001tonythomas) [16:08:50] (03PS2) 10Matthias Mullie: Use FlowAction permissions in AbstractRevision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102154 [16:08:54] (03PS1) 10Tinaj1234: Corrected memcached.txt in MediaWiki 1.22 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102163 [16:10:20] (03PS8) 10BryanDavis: add-project-link [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 (owner: 10Dan-nl) [16:11:04] (03CR) 10BryanDavis: [C: 032] "Approving based on +1 from Siebrand and Multichill." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 (owner: 10Dan-nl) [16:11:28] thanks bryan [16:11:42] (03CR) 1001tonythomas: "Thanks. Anytime :)" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102162 (owner: 1001tonythomas) [16:14:04] (03PS3) 10Daniel Kinzler: (bug 47070) check content model namespace on import. [core] - 10https://gerrit.wikimedia.org/r/100563 [16:14:31] (03CR) 10Daniel Kinzler: "@siebrand: ok, you were right - fixed :)" [core] - 10https://gerrit.wikimedia.org/r/100563 (owner: 10Daniel Kinzler) [16:15:43] (03CR) 10Parent5446: [WIP] Add support for JSON i18n files (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102098 (owner: 10Catrope) [16:21:10] hello yurik u der? [16:22:42] (03CR) 10Daniel Kinzler: [C: 04-1] "the hook interface could be a bit cleaner." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/101895 (owner: 10Aude) [16:25:06] (03PS3) 10Matthias Mullie: Use FlowAction permissions in AbstractRevision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102154 [16:25:19] (03PS1) 10BryanDavis: Hide language selector if only one language is available [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102166 [16:29:16] (03CR) 10BryanDavis: Hide language selector if only one language is available (032 comments) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102166 (owner: 10BryanDavis) [16:30:11] dan-nl: What else is left to do before you release today? [16:30:49] bd808: nothing that i can think of atm [16:30:54] (03CR) 10jenkins-bot: [V: 04-1] Check the puppetstatus timestamp. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/102155 (owner: 10Andrew Bogott) [16:31:04] i think we're all set [16:31:13] Awesome [16:31:28] (03CR) 10Gergő Tisza: "I don't see why that would be a problem. The code calls $file->transform(); that checks $file->getHandler()->getScriptedTransform(); if $w" [core] - 10https://gerrit.wikimedia.org/r/96920 (owner: 10Gergő Tisza) [16:31:32] as we develop after this how are things deployed to production? [16:35:13] (03CR) 10Andrew Bogott: "recheck" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/102155 (owner: 10Andrew Bogott) [16:35:51] (03CR) 10jenkins-bot: [V: 04-1] The Release Notes for Mediawiki 1.22 was updated. [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102162 (owner: 1001tonythomas) [16:36:12] dan-nl: You will continue to develop on the master branch. When you get to a point that you are ready to release you will either "ride the deploy train" or ask for a special deployment window. In either case you will probably work with Mark and Gergő to get everything scheduled and pushed out. [16:36:56] (03CR) 10jenkins-bot: [V: 04-1] Use FlowAction permissions in AbstractRevision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102154 (owner: 10Matthias Mullie) [16:37:47] (03CR) 10MarkAHershberger: [C: 032 V: 032] "I have no idea what those results from Jenkin's mean." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102162 (owner: 1001tonythomas) [16:38:39] (03CR) 10jenkins-bot: [V: 04-1] Corrected memcached.txt in MediaWiki 1.22 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102163 (owner: 10Tinaj1234) [16:38:41] (03CR) 10jenkins-bot: [V: 04-1] add-project-link [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 (owner: 10Dan-nl) [16:40:11] hashar: How do I find out what went wrong with the merge of https://gerrit.wikimedia.org/r/#/c/101487/? [16:40:50] * bd808 sees that Jenkins is restarting. That may explain it [16:41:26] (03CR) 10jenkins-bot: [V: 04-1] add-project-link [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 (owner: 10Dan-nl) [16:42:02] lol, LOST. That's a great error message [16:42:57] bd808: When jenkins acts up for me, I usually just rebase the change and +2 it again. Usually it works the second time [16:43:22] bawolff: Thanks. I'll try that if Jenkins every comes back to life. [16:43:26] *ever [16:44:19] (03PS6) 10Dr0ptp4kt: WIP: Allow Skins to define other HTML tag attributes [core] - 10https://gerrit.wikimedia.org/r/100920 (owner: 10Jdlrobson) [16:44:58] (03PS1) 10Matthias Mullie: Instead of failing, remove history logs that user can't see [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102169 [16:45:28] Given its only doing linting (which really isn't very important), you could probably just hit the verified +2 yourself, and then hit submit on gerrit, which will override gerrit [16:46:15] bd808: yeah Jenkins died :( [16:47:13] (03CR) 10jenkins-bot: [V: 04-1] (bug 47070) check content model namespace on import. [core] - 10https://gerrit.wikimedia.org/r/100563 (owner: 10Daniel Kinzler) [16:47:24] hashar: I saw your log in #-operations after I asked Poor little guy is just overworked. [16:47:42] WMF unfair to bots! [16:48:20] bd808: yeah sorry jenkins dead [16:48:25] bd808: it is busy restarting :( [16:49:37] (03CR) 10jenkins-bot: [V: 04-1] Use FlowAction permissions in AbstractRevision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102154 (owner: 10Matthias Mullie) [16:50:44] (03CR) 10jenkins-bot: [V: 04-1] Hide language selector if only one language is available [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102166 (owner: 10BryanDavis) [16:54:41] hashar, jenkins seems to lose jobs when restarted [16:54:57] MaxSem: yeah because Zuul can't launch the jobs [16:55:19] is it safe to restart now? [16:55:31] MaxSem: Yourself? [16:55:35] MaxSem: Windows? [16:55:48] Reedy, Reedy [16:56:25] restart jenkins tests [16:56:41] It looks like it's alive. [16:57:11] yeah should be fine [16:57:14] you will have to retrigger jobs [16:57:21] (03CR) 10Siebrand: Hide language selector if only one language is available (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102166 (owner: 10BryanDavis) [16:57:57] (03PS1) 10Catrope: [WIP] First stab at a script to convert PHP i18n to JSON [core] - 10https://gerrit.wikimedia.org/r/102171 [16:58:46] it is back [16:58:58] (03PS4) 10Daniel Kinzler: (bug 47070) check content model namespace on import. [core] - 10https://gerrit.wikimedia.org/r/100563 [16:59:10] cool [17:00:10] (03Merged) 10jenkins-bot: The Release Notes for Mediawiki 1.22 was updated. [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102162 (owner: 1001tonythomas) [17:00:27] (03CR) 10BryanDavis: Hide language selector if only one language is available (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102166 (owner: 10BryanDavis) [17:01:41] bd808: MaxSem Jenkins is alive. I am off to commute. [17:01:43] * hashar wave [17:01:43] (03PS1) 10Matthias Mullie: Users probably shouldn't see deleted entries too, unless they have sufficient permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102172 [17:02:12] * bd808 waves back [17:02:44] (03PS2) 10BryanDavis: Hide language selector if only one language is available [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102166 [17:02:47] (03PS2) 10Matthias Mullie: Users probably shouldn't see deleted entries too, unless they have sufficient permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102172 [17:03:50] (03CR) 10BryanDavis: "Patch set 2 was just touching the commit message so our friend Jenkins would see that there is work to do here." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102166 (owner: 10BryanDavis) [17:05:26] (03CR) 10Chad: "I didn't think about deleting the files tbh :\" [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102037 (owner: 10Chad) [17:06:14] (03PS9) 10BryanDavis: add-project-link [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 (owner: 10Dan-nl) [17:06:35] (03CR) 10Chad: [C: 031] Hide language selector if only one language is available [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102166 (owner: 10BryanDavis) [17:06:54] (03CR) 10BryanDavis: "Patch set 9 changed commit message to wake Jenkins up." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 (owner: 10Dan-nl) [17:08:55] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/100563 (owner: 10Daniel Kinzler) [17:10:32] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 (owner: 10Dan-nl) [17:17:27] (03PS2) 10Catrope: [WIP] First stab at a script to convert PHP i18n to JSON [core] - 10https://gerrit.wikimedia.org/r/102171 [17:21:33] hello yurik [17:22:24] (03CR) 10BryanDavis: [C: 032] "Let's see if Jenkins can merge us this time. :)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 (owner: 10Dan-nl) [17:22:34] (03Merged) 10jenkins-bot: add-project-link [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 (owner: 10Dan-nl) [17:24:00] <^d> siebrand: Howdy, so I think bd808 and I are just about ready to unleash the scholarships app on translatewiki :) [17:24:13] <^d> (Just have one form left with hardcoded english, which I plan to finish fixing today) [17:25:37] ^d: We should really add a qqq file too. Like siebrand pointed out in the code review not having one is tech debt from day zero. [17:25:49] bd808 thanks for taking care of that 101487 [17:26:01] dan-nl: You're welcome [17:26:21] ^d: I think there are 2 possible hurdles. I'd need some advice from Nikerabbit about it. [17:26:50] ^d: 1 is that I think it needs a "$messages = array();" in en.php to have the same formatting as MediaWiki extension messages files. [17:27:42] ^d: 2 is that I see the locales are stored in different files. I'm not sure we have support for that at the moment. With (1) satisfied, I'm sure we could support it with all localised in a single file. [17:27:53] siebrand: We can change how the i18n files work pretty easily if there is a better way to do them. [17:27:57] ^d: As said, need Nikerabbit to confirm what is needed exactly. [17:28:11] bd808: Using JSON would be awesomest, I think :) [17:28:31] siebrand: Ok. As a single file or multiple files? [17:28:31] bd808: And RoanKattouw almost has a conversion script ready. [17:28:46] bd808: multiple. 1 per locale, flat file. Example: [17:29:06] <^d> Switching to json would be pretty easy for us at this point. [17:29:37] bd808 / ^d : https://gerrit.wikimedia.org/r/#/c/101848/5/modules/ve-mw/i18n/en.json [17:29:41] I have a shim for JSON files rotting away somewhere [17:29:43] <^d> We've only got a ~200 or so :) [17:29:45] I need to fix it to not load all languages [17:29:55] <^d> It's 200 messages in one language right now. [17:29:59] Also, yeah, I have a functional conversion script as a WIP in Gerrit [17:30:01] <^d> Spitting out json for that is trivial. [17:30:06] It just doesn't preserve authorship info [17:30:21] But I have this sneaking suspicion that the number of authors is between 1 and 2 [17:30:52] ^d: Do you have time to take on changing the format or would you like me to do that? [17:31:14] ^d / bd808 : That format is most probably very future proof. See https://www.mediawiki.org/wiki/Requests_for_comment/Localisation_format and please participate in tomorrow's RfC meeting ;) [17:31:36] <^d> siebrand: I did skim that RfC. Won't be able to make the meeting (on an airplane), but I do like the idea in principle :) [17:31:43] (03PS1) 10Legoktm: Avoid calling protected File field [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/102176 [17:32:02] (03PS1) 10Legoktm: Avoid calling protected File field [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102177 [17:32:15] I like the idea of config not being executable [17:32:54] * bd808 likes yaml better than json, but that's another debate [17:32:59] <^d> bd808: I'll get that btw. [17:33:12] ^d: Awesome sauce [17:33:24] <^d> I did see that you added qqq support. [17:33:27] <^d> Which is sweet. [17:33:52] YAML has all sorts of problems. All the shorthand ways of writing things are tricky to deal with [17:33:52] Fortunately, in the new version of the YAML spec, JSON is now valid YAML :) [17:33:59] Wasn't YAML always a superset of JSON? [17:34:41] One way or another, yes [17:34:55] <^d> Do we have stats on api format usage? [17:35:00] bd808: See the json and yaml formatters in the api [17:35:13] * ^d wonders how many people are using the /weird/ ones [17:35:19] ^d: I don't think so, but should easily be doable [17:35:44] api logs exist etc [17:35:50] <^d> *nod* [17:36:17] literally grep -i -c json file.log [17:36:31] * bd808 is not a YAML expert but accidentally became the maintainer of a YAML PECL module [17:36:33] in other cases, I can't imagine other parameters will give false positives [17:36:52] class ApiFormatYaml extends ApiFormatJson { [17:37:03] We only change the description and the mimetype [17:37:09] Nice [17:38:50] <^d> Reedy: Nobody uses wddx [17:39:23] * Copyright © 2006 Yuri Astrakhan "@gmail.com" [17:39:24] lol [17:39:48] ugagag [17:39:53] ^d: yurik (and maybe anomie?) want to kill everything except json [17:39:55] who is pinging me [17:40:13] <^d> legoktm: I wouldn't mind if they did :) [17:40:42] In a "new api" [17:40:50] Just removing XML from core is mean [17:41:02] <^d> You could deprecate ones people aren't using much. [17:41:03] https://www.mediawiki.org/wiki/Requests_for_comment/API_roadmap#Remove_the_XML_format [17:41:03] hmm [17:41:12] Reedy: At one point yaml format was different. But then the new version of yaml was released that is a superset of json, so... [17:41:12] <^d> Low hanging fruit is easier than breaking everyone :) [17:41:17] Especially with the amount of traffic AWB puts to the cluster [17:41:46] To port AWB to use JSON is on my todo list... [17:42:19] Nikerabbit: I think you got pinged in the discussion between ^d, siebrand and myself about how to properly do the i18n files for Wikimedia Scholarships app [17:42:38] We're going to switch to the per-language json files [17:42:42] The problem with the XML format is that it requires API modules to do a bunch of strange things to make the XML format work right. [17:42:44] (03CR) 10Chad: [C: 032] Hide language selector if only one language is available [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102166 (owner: 10BryanDavis) [17:42:58] (03Merged) 10jenkins-bot: Hide language selector if only one language is available [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102166 (owner: 10BryanDavis) [17:43:02] bd808: looks so yes [17:45:03] (03CR) 10Reedy: [C: 032] Avoid calling protected File field [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102177 (owner: 10Legoktm) [17:45:09] (03CR) 10Reedy: [C: 032] Avoid calling protected File field [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/102176 (owner: 10Legoktm) [17:47:45] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102153 (owner: 10Matthias Mullie) [17:48:19] <^d> Nikerabbit: Once we support json instead, we also have support for qqq, so I think that's the final bit we need. [17:48:42] (03Merged) 10jenkins-bot: Avoid calling protected File field [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102177 (owner: 10Legoktm) [17:50:24] (03Merged) 10jenkins-bot: Avoid calling protected File field [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/102176 (owner: 10Legoktm) [17:52:57] (03CR) 10Siebrand: "I guess this can be merged, right?" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/102152 (owner: 10Hashar) [18:11:55] (03CR) 10Chad: Index page templates (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101992 (owner: 10Chad) [18:13:16] ^d: https://gerrit.wikimedia.org/r/#/c/102087/ [18:15:53] (03CR) 10Siebrand: "I don't really understand what this does. Has this key been forgotten in a previous patch set. Which?" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101678 (owner: 10Tpt) [18:16:50] (03PS4) 10Umherirrender: Raw option of parser functions should match complete word [core] - 10https://gerrit.wikimedia.org/r/100198 [18:17:38] (03CR) 10Deskana: Index page templates (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101992 (owner: 10Chad) [18:17:42] (03CR) 10Chad: [C: 032] Remove unused job ID parameter from jobs [core] - 10https://gerrit.wikimedia.org/r/102087 (owner: 10Aaron Schulz) [18:17:45] (03CR) 10Aaron Schulz: Moved ScopedCallback to /libs (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102080 (owner: 10Aaron Schulz) [18:18:03] (03PS2) 10Aaron Schulz: Moved ScopedCallback to /libs [core] - 10https://gerrit.wikimedia.org/r/102080 [18:18:30] (03CR) 10Umherirrender: "Patch Set 4: fixed style issue" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100198 (owner: 10Umherirrender) [18:21:53] (03CR) 10Siebrand: [C: 04-1] JS --> JavaScript (031 comment) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/101624 (owner: 10Legoktm) [18:22:07] (03Merged) 10jenkins-bot: Remove unused job ID parameter from jobs [core] - 10https://gerrit.wikimedia.org/r/102087 (owner: 10Aaron Schulz) [18:22:19] (03CR) 10Siebrand: [C: 032] JS --> JavaScript [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/101624 (owner: 10Legoktm) [18:22:41] siebrand: yeah, that's in the next patch :) [18:23:05] legoktm: Just spotted that :) [18:23:20] (03CR) 10Siebrand: [C: 032] Improve 'globalcssjs-desc' message [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/101625 (owner: 10Legoktm) [18:24:09] (03Merged) 10jenkins-bot: JS --> JavaScript [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/101624 (owner: 10Legoktm) [18:24:10] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/101626 (owner: 10Legoktm) [18:24:11] (03Merged) 10jenkins-bot: Improve 'globalcssjs-desc' message [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/101625 (owner: 10Legoktm) [18:25:26] (03CR) 10Aaron Schulz: [C: 032] Add one more missing directory to findHooks.php [core] - 10https://gerrit.wikimedia.org/r/101644 (owner: 10IAlex) [18:25:48] <^d> Possibly dumb question. [18:26:07] <^d> What would be the *easiest* way to see if a page *doesn't* have a namespace? Construct a title and check NS_MAIN? [18:26:41] <^d> s/a page/a string that is probably a valid title/ [18:28:14] ^d: yeah, I think so. [18:28:33] (03Merged) 10jenkins-bot: Add one more missing directory to findHooks.php [core] - 10https://gerrit.wikimedia.org/r/101644 (owner: 10IAlex) [18:30:25] (03CR) 10Parent5446: [C: 031] "Yeah, sorry, it's a force of habit. Sometimes I even -1 when I actually meant +1." [core] - 10https://gerrit.wikimedia.org/r/102080 (owner: 10Aaron Schulz) [18:30:38] (03PS1) 10Reedy: Add GWToolset [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102197 [18:32:16] (03CR) 10Aaron Schulz: [C: 032] "I don't see anything that would break by this in grep" [core] - 10https://gerrit.wikimedia.org/r/101038 (owner: 10Brian Wolff) [18:32:21] (03PS2) 10Reedy: Change Collection to a deploy branch [tools/release] - 10https://gerrit.wikimedia.org/r/101108 (owner: 10Mwalker) [18:32:26] (03CR) 10Reedy: [C: 032] Change Collection to a deploy branch [tools/release] - 10https://gerrit.wikimedia.org/r/101108 (owner: 10Mwalker) [18:34:55] (03CR) 10Reedy: [V: 032] Change Collection to a deploy branch [tools/release] - 10https://gerrit.wikimedia.org/r/101108 (owner: 10Mwalker) [18:35:38] (03PS3) 10Catrope: Script to convert PHP i18n to JSON [core] - 10https://gerrit.wikimedia.org/r/102171 [18:36:17] (03PS3) 10Reedy: Remove ArticleFeedbackTool v4 [tools/release] - 10https://gerrit.wikimedia.org/r/101122 (owner: 10Nemo bis) [18:36:24] (03CR) 10Reedy: [C: 032 V: 032] Remove ArticleFeedbackTool v4 [tools/release] - 10https://gerrit.wikimedia.org/r/101122 (owner: 10Nemo bis) [18:37:42] ^d: https://gerrit.wikimedia.org/r/#/c/102086/ just some tests [18:37:45] (03CR) 10Bartosz Dziewoński: "This in no way affects the release, this file might as well be stripped from the tarball. It does, however, affect the `git review` comman" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/102134 (owner: 10Bartosz Dziewoński) [18:39:10] (03Merged) 10jenkins-bot: Fix inconsistency in ArchivedFile::getUser [core] - 10https://gerrit.wikimedia.org/r/101038 (owner: 10Brian Wolff) [18:39:54] (03CR) 10Manybubbles: Index page templates (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101992 (owner: 10Chad) [18:42:25] (03PS8) 10Umherirrender: Migrate redirectToFragment() from wikibits.js to own module [core] - 10https://gerrit.wikimedia.org/r/94412 [18:42:28] (03CR) 10Chad: Index page templates (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101992 (owner: 10Chad) [18:43:23] (03PS3) 10Chad: Index page templates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101992 [18:44:10] (03CR) 10Manybubbles: Index page templates (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101992 (owner: 10Chad) [18:44:17] (03CR) 10Umherirrender: "Patch Set 8: Addressed comments" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/94412 (owner: 10Umherirrender) [18:45:04] (03PS4) 10Chad: Index page templates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101992 [18:45:25] (03CR) 10jenkins-bot: [V: 04-1] Index page templates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101992 (owner: 10Chad) [18:46:02] (03PS1) 10Matthias Mullie: load* shouldn't check for view permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102201 [18:46:04] (03PS1) 10Matthias Mullie: Don't fail if there is not history (e.g. everything is moderated) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102202 [18:46:06] (03PS1) 10Matthias Mullie: Fetch moderation status from last revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102203 [18:46:10] (03PS1) 10Zfilipin: Replacing single quotes with double quotes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102204 [18:46:42] (03PS2) 10Matthias Mullie: Fetch moderation status from last revision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102203 [18:47:02] (03CR) 10jenkins-bot: [V: 04-1] Index page templates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101992 (owner: 10Chad) [18:47:53] (03PS1) 10Cscott: Link to the mw-ocg-texter backend in the README. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/102205 [18:47:54] (03PS1) 10Cscott: Update `request` dependency to 2.30. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/102206 [18:53:03] (03CR) 10Parent5446: [C: 04-1] Script to convert PHP i18n to JSON (0310 comments) [core] - 10https://gerrit.wikimedia.org/r/102171 (owner: 10Catrope) [18:54:08] (03PS4) 10Aude: Add QuickTemplateAfterPortlet hook to add html after portlets [core] - 10https://gerrit.wikimedia.org/r/101895 [18:57:16] (03PS5) 10Umherirrender: Add $wgHideUserContribLimit config setting [core] - 10https://gerrit.wikimedia.org/r/98267 [18:57:53] (03CR) 10Umherirrender: "Patch Set 5: Fixed style issue" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98267 (owner: 10Umherirrender) [18:59:04] (03CR) 10Aude: Add QuickTemplateAfterPortlet hook to add html after portlets (034 comments) [core] - 10https://gerrit.wikimedia.org/r/101895 (owner: 10Aude) [19:07:00] (03PS1) 10Chad: Never index negative namespaces [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102220 [19:07:03] (03CR) 10jenkins-bot: [V: 04-1] Never index negative namespaces [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102220 (owner: 10Chad) [19:07:15] (03PS2) 10Chad: Never index negative namespaces [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102220 [19:07:49] (03PS3) 10Chad: Never index negative namespaces [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102220 [19:08:33] (03CR) 10Manybubbles: Never index negative namespaces (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102220 (owner: 10Chad) [19:09:15] ^d: is that something we need to push before tommorrow during out window? [19:09:23] we don't see many exceptions from it. [19:09:31] we actually see more from the jobs timing out then this [19:09:49] <^d> RoanKattouw reported it. [19:09:56] <^d> If it's not common, I think it can wait and go out tomorrow. [19:10:14] Krinkle: around? [19:10:29] (03PS4) 10Chad: Never index negative namespaces [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102220 [19:10:51] Krinkle: wanna review my latest RC/watchlist legend patch? you called that feature a regression [19:10:59] https://gerrit.wikimedia.org/r/101446 [19:11:11] so i'd expect some input from you :) [19:11:43] greg-g: dan-nl-afk: or, can one of you tell me what's the status for that? (i asked about reviewing and backporting that last week) [19:11:48] of that* [19:12:01] (03CR) 10Manybubbles: [C: 032] Never index negative namespaces [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102220 (owner: 10Chad) [19:12:06] (03Merged) 10jenkins-bot: Never index negative namespaces [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102220 (owner: 10Chad) [19:14:37] MatmaRex: which commit? [19:15:11] dan-nl: https://gerrit.wikimedia.org/r/101446 as a fix to https://bugzilla.wikimedia.org/show_bug.cgi?id=52005#c17 [19:15:42] (wait, are you the right dan to ask? :) ) [19:16:15] MatmaRex: no, don't know about that :) [19:16:51] heh, okay. sorry then :P the dan i'm looking for is the garry one ;) [19:17:12] sorry. [19:17:18] MatmaRex: he's DGarry :P [19:18:21] wait, you're over here MatmaRex [19:18:24] anywho... [19:18:32] yeah, it's Dan Garry, DGarry [19:18:45] and yeah, he thought it was ok to backport/push out [19:19:14] i just need someone to review it now, eh… [19:19:28] :) [19:21:21] MatmaRex: why not use localstorage instead of cookies? [19:21:43] MatmaRex: it's non-essential functionality, works on 90% of browsers, and doesn't add a byte payload to *every* *damn* *request* [19:26:11] ori-l: do you feel like chatting about that with angered 'pedians using their IE6s? :P [19:26:29] ori-l: we have been storin the state of any collapsible items which keep state in cookies so far. [19:26:42] the navigation menu, the tocs, the lists below edit field [19:27:27] i'm not going to redo that now, any cleanup commits of mine just rot forever [19:28:08] other commits, too. i have one to change the font color on something to a darker grey to make it legible which is waiting for i think second month now [19:28:58] MatmaRex: change? [19:28:59] hey, actually, it will be two months old tomorrow. [19:29:02] https://gerrit.wikimedia.org/r/#/c/90563/ [19:29:23] I'll make the cake [19:29:46] (03PS3) 10Ori.livneh: Make #contentSub slightly darker [core] - 10https://gerrit.wikimedia.org/r/90563 (owner: 10Bartosz Dziewoński) [19:29:51] (03CR) 10Ori.livneh: [C: 032] Make #contentSub slightly darker [core] - 10https://gerrit.wikimedia.org/r/90563 (owner: 10Bartosz Dziewoński) [19:30:40] in fact, i have 7 commits ready to merge with a +1 [19:30:55] (03CR) 10Bsitu: [WIP] Add Flow events to Special:Contributions. (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99038 (owner: 10Werdna) [19:31:07] MatmaRex: well, let's have them [19:31:23] i guess i *could* just search [19:35:15] https://gerrit.wikimedia.org/r/#/q/owner%3A%22Bartosz+Dziewoński%22+project%3Amediawiki%2Fcore+status%3Aopen,n,z [19:35:35] i hope they still merge cleanly [19:35:39] or at least most of them [19:35:52] lots of things could have happened since, say, september [19:36:10] (i am unable to get gerrit to only show changes with a CR+1.) [19:36:21] if i didn't know any better i would have guessed you're a bit bitter about it [19:37:46] i am consistently winning https://www.mediawiki.org/wiki/Gerrit/Reports/Open_changesets_by_owner when sorted by last column [19:37:57] lego has me beaten in the first two, though [19:38:07] legoktm: 80? last time i looked you had 60, heh [19:38:18] :| [19:38:20] I've been busy [19:41:33] (03CR) 10Bartosz Dziewoński: [C: 032] Check supposed revision being reverted is on the same page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/97191 (owner: 10Legoktm) [19:41:43] (03PS1) 10Ryan Lane: Use image metadata for hidden and default images. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/102285 [19:43:37] (03PS5) 10Manybubbles: Index page templates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101992 (owner: 10Chad) [19:43:38] MatmaRex: thanks :D [19:44:02] (03CR) 10Bartosz Dziewoński: [C: 032] Cleanup inconsistent code style [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97468 (owner: 10Legoktm) [19:44:17] (03PS1) 10Reedy: Revert "Optimized LocalRepo::findFiles()" [core] - 10https://gerrit.wikimedia.org/r/102287 [19:44:18] legoktm: i'll leave it to you to decide what to do with that bug [19:44:45] I think the revert detection needs to be made better [19:44:54] so do i [19:44:58] not sure how to do that though :P [19:45:12] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Does not merge/rebase." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97479 (owner: 10Legoktm) [19:45:15] (03CR) 10Manybubbles: "Cleaned up some of the filter parsing code because it was super confusing and wrong in the case of -incategory:." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101992 (owner: 10Chad) [19:45:56] Reedy: it's easier to just add an isset() for now [19:45:56] you'd have to revert a follow up plus an ext change [19:45:57] stupid flexible mediawiki, right? [19:46:16] i actually have no idea why we allow users to edit a change after they click "undo", that's silly. [19:46:48] (03Abandoned) 10Reedy: Revert "Optimized LocalRepo::findFiles()" [core] - 10https://gerrit.wikimedia.org/r/102287 (owner: 10Reedy) [19:46:59] (03PS6) 10Manybubbles: Index page templates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101992 (owner: 10Chad) [19:47:27] (03CR) 10Manybubbles: [C: 031] "Amended commit message with deployment notes." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101992 (owner: 10Chad) [19:47:34] Reedy: pushing [19:47:52] still not sure how that's possible [19:48:19] (03CR) 10Bartosz Dziewoński: Show an error to the user if the spamlist has no targets on it (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 (owner: 10Legoktm) [19:48:38] (03PS1) 10Reedy: Fix fatal in LocalRepo::findFiles() [core] - 10https://gerrit.wikimedia.org/r/102288 [19:49:40] gah, msysgit is just waaay too slow [19:49:54] (03PS1) 10Reedy: Fix fatal in LocalRepo::findFiles() [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102290 [19:50:58] (03PS2) 10Ryan Lane: Use image metadata for hidden and default images. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/102285 [19:51:23] (03CR) 10Manybubbles: [C: 031] "Looks good to me. Why WIP?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102047 (owner: 10Chad) [19:51:44] MatmaRex: what's the difference between $wgMemc and wfGetCache? [19:52:15] $wgMemc = wfGetMainCache(); [19:52:29] no idea, to be honest [19:52:34] oh [19:52:35] but i've never seen it used directly [19:52:45] it probably doesn't matter in most cases [19:52:52] (03CR) 10Reedy: [C: 032 V: 032] Fix fatal in LocalRepo::findFiles() [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102290 (owner: 10Reedy) [19:52:55] back compat [19:53:24] huh, http://en.wiktionary.org/w/api.php?action=query&titles=File:En-us-calamity.ogg&prop=imageinfo&iiprop=url&format=json works [19:53:31] (03CR) 10Andrew Bogott: [C: 031] "lgtm" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/102285 (owner: 10Ryan Lane) [19:53:37] but "en" doesn't [19:53:49] (03CR) 10Bartosz Dziewoński: [C: 032] "I trust that the minimal version requirement is documented somewhere. Maybe we should do a check and bail out on earlier versions?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96677 (owner: 10Legoktm) [19:54:11] (03CR) 10Swalling: [C: 031] "Seems sane." [core] - 10https://gerrit.wikimedia.org/r/95742 (owner: 10Bartosz Dziewoński) [19:54:51] StevenW: you should totally start merging my changes instead of just +1ing them. ;) [19:56:04] (03CR) 10Ryan Lane: [C: 032] Use image metadata for hidden and default images. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/102285 (owner: 10Ryan Lane) [19:56:44] (03CR) 10Bartosz Dziewoński: [C: 032] Don't parse custom footer [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97366 (owner: 10Legoktm) [19:57:04] {"query":{"pages":{"-1":{"ns":6,"title":"File:en-us-calamity.ogg","missing":"","imagerepository":""}}}} [19:57:31] (03PS2) 10Reedy: Add GWToolset [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102197 [19:57:39] (03CR) 10Reedy: [C: 032 V: 032] Add GWToolset [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102197 (owner: 10Reedy) [20:02:06] Reedy: odd, RepoGroup::singleton()->findFiles( array( 'en-us-calamity.ogg' ) ) works fine on commons and enwiki but returns an empty array for wiktionary [20:02:20] 'En...' always works [20:03:03] (03CR) 10Ryan Lane: [V: 032] Use image metadata for hidden and default images. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/102285 (owner: 10Ryan Lane) [20:04:09] ahh, I see, getNameFromTitle is used to do proper case handling based on the foreign repo but the $searchSet[$dbKey] is look for the search on the title without the foreign style casing [20:05:02] Reedy: should I just amend 102288? [20:05:09] *is looking [20:09:15] (03PS53) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [20:14:04] superm401, hi! Is there a way to see which guided tours are available in a wiki? [20:14:23] superm401, for instance in en.wiki [20:14:29] (03CR) 10Siebrand: Latest SoundManager2 updates and asynchronous script loading fixes (031 comment) [extensions/SoundManager2Button] - 10https://gerrit.wikimedia.org/r/101637 (owner: 10kroocsiogsi) [20:14:41] qgil, for locally defined ones it's easy [20:14:45] See link at bottom of https://en.wikipedia.org/wiki/Wikipedia:GuidedTour [20:14:58] There's not a way currently if you want to see extension-defined ones. [20:15:11] Without looking at the code of the installed extensions. [20:16:33] superm401, extension-defined, which are those? [20:16:47] superm401, new registration? [20:16:50] E.g. the GettingStarted extension installs tours [20:17:01] qgil, what do you mean about "new registration"? [20:17:42] superm401, I mean GettingStarted, sorry ;) [20:18:55] (03CR) 10Siebrand: [C: 04-1] "Please add message documentation. See https://www.mediawiki.org/wiki/I18n#Message_documentation for details." (033 comments) [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/101499 (owner: 10Apsdehal) [20:19:29] superm401, ca.wikipedia.org want to try Guided Tours, and I want to tell them to start translating existing tours as opposed to create new ones without checking before what is available [20:19:44] superm401, the problem is, it is not clear what is available [20:19:46] qgil, sure the main general-purpose one is "firstedit". [20:19:51] Then there are some custom ones are various wikis. [20:20:09] The link for the wiki-specific (or at least in the MediaWiki namespace ones is): [20:20:31] https://en.wikipedia.org/wiki/Special:PrefixIndex/MediaWiki:Guidedtour-tour- [20:20:43] Everything after the domain would be the same on Catalan wiki. [20:21:38] (03CR) 10Siebrand: [C: 04-1] "Per Tyler's comments." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/101494 (owner: 10Apsdehal) [20:22:02] superm401, but "first edit"seems to be only this? [20:22:04] https://en.wikipedia.org/wiki/MediaWiki:Guidedtour-tour-firstedit-edit-page-description [20:22:55] (03CR) 10Physikerwelt: Math 2.0 (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [20:22:56] qgil, no, that's just the override on English Wikipedia. [20:23:29] superm401, right... is there a URL I can share with editors to tell them: start translating that [20:23:40] qgil, TranslateWiki.net. :) [20:23:59] qgil, FYI, the default messages are at https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGuidedTour.git/e129e58c002ff30830b92b1cf0854437bc1fa01e/GuidedTour.i18n.php#L41 (in the code) [20:24:04] superm401, are you handling guided tours in translatewiki? [20:24:27] qgil, yes: https://translatewiki.net/w/i.php?title=Special:Translate&group=ext-guidedtour [20:24:43] BTW, I appreciate that they're interested. Please do keep me posted if they're interested in a custom tour. [20:25:16] (03CR) 10Mattflaschen: [C: 032] "Tested locally." [core] - 10https://gerrit.wikimedia.org/r/95742 (owner: 10Bartosz Dziewoński) [20:25:44] superm401, GuidedTours i basically translated to Catalan already: https://translatewiki.net/w/i.php?title=Special:Translate&group=ext-guidedtour&language=ca&filter=!translated&action=translate [20:25:56] (03CR) 10Legoktm: [C: 032] "Tested, works fine." [core] - 10https://gerrit.wikimedia.org/r/95870 (owner: 10Bartosz Dziewoński) [20:26:08] superm401, now, let me see how to find them in http://ca.wikipedia.org ... [20:26:09] MatmaRex: I'll remember that for next time. ;) [20:26:19] In this case superm401 wanted a pass at testing. [20:26:46] qgil, I get what you're saying. [20:27:07] It would be good if you could just list all the tours installed on the wiki (including the out of the box ones provided by the extensions) [20:27:17] It's already a bug in fact: https://bugzilla.wikimedia.org/show_bug.cgi?id=51419 [20:27:33] However, for now, you can only list ones that are installed through the MW namespace. [20:27:34] StevenW: superm401: thanks! :D [20:27:43] (03Merged) 10jenkins-bot: Check supposed revision being reverted is on the same page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/97191 (owner: 10Legoktm) [20:27:55] wow, that took a really long time >.> [20:28:04] superm401, ok, understood. CCed myself to the bug. [20:28:10] qgil, as for the actual tour URL, it's https://ca.wikipedia.org/wiki/Roques_Grosses?tour=firstedit [20:28:14] I just picked a random article. [20:28:24] > Queue lengths: 152 events, 7 results. [20:28:57] They can definitely make a custom tour if they want to do something specific to their wiki, or talk to us about general-purpose tours. [20:30:03] (03Merged) 10jenkins-bot: Make #contentSub slightly darker [core] - 10https://gerrit.wikimedia.org/r/90563 (owner: 10Bartosz Dziewoński) [20:30:07] (03Abandoned) 10Siebrand: Successfuly decrease the number of superfluous words [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102146 (owner: 10Siebrand) [20:31:35] (03Merged) 10jenkins-bot: Cleanup inconsistent code style [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97468 (owner: 10Legoktm) [20:32:46] !e MultimediaViewer | jgonera [20:32:47] jgonera: https://www.mediawiki.org/wiki/Extension:MultimediaViewer [20:32:48] superm401, the steps would be: 1 now what tours are already available in ca.wiki (we/they don't know). 2 Promote those. 3 This if we are missing anything. [20:32:52] know [20:33:25] 3 Think whether we are missing anything (sorry for more-broken-than-usual) English [20:34:06] qgil, I've got to go to a meeting. [20:34:12] thank you! [20:34:16] I'll follow up after. [20:41:42] (03PS1) 10Chad: Remove pointless function [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/102295 [20:43:38] (03CR) 10Chad: "I hadn't tested it at all :p" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102047 (owner: 10Chad) [20:44:44] Reedy: You still got the deploy? Able to do a super-quick config commit for officewiki? :-) [20:44:46] (03PS2) 10Chad: WIP: Allow reindexing by namespace [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102047 [20:45:20] Cleaning up stuff other people didn't so I can deploy... [20:45:27] Reedy: Specifically, https://gerrit.wikimedia.org/r/#/c/101908/ for guillom. [20:45:35] Reedy: Eurgh, my sympathies. :-( [20:49:53] (03Merged) 10jenkins-bot: Only run onUserSaveSettings hook if not in update.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96677 (owner: 10Legoktm) [20:51:27] (03CR) 10Manybubbles: "About to amend with a regression test and some more docs." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101447 (owner: 10Chad) [20:51:28] Quick question: I pushed something for the first time for review to gerrit (https://gerrit.wikimedia.org/r/#/c/102297/). Should I add a reviewer myself? [20:51:53] (03PS2) 10Manybubbles: Respect revision deletion in CirrusSearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101447 (owner: 10Chad) [20:52:12] (03CR) 10Chad: "Unless lego knows of a way we can get that info :p" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101447 (owner: 10Chad) [20:52:24] (03PS1) 10BryanDavis: Fix html escaping problem with post-deadline message [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102300 [20:52:31] ohai [20:53:17] legoktm: it is like a Rube Goldberg pinging machine [20:53:21] ^d, manybubbles: fix the hook! [20:53:33] not sure it is worth it [20:53:47] <^d> legoktm: But I'm scared! [20:57:05] Ahmad96: yeah, feel free to add reviewers yourself [20:57:11] (03CR) 10Legoktm: "Ideally the hook would provide more information than just the title, but I don't think it's worth blocking this until that happens if you " [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101447 (owner: 10Chad) [20:57:15] okay [20:58:10] Ahmad96: qgil has already left some feedback about the commit message [20:59:27] bawolff: I added a refrence to the bug report at the end of the commit (Bug: 58165), isn't that the right way to do it? [20:59:46] Ahmad96: You should end newlines between the different parts [20:59:54] *You should add newlines [20:59:58] Oh okay [21:00:14] Hmm how do I recommit that now? :/ [21:00:28] For commit messages you can actually edit them online in gerrit [21:00:43] Oh neat! thanks bawolff [21:00:57] there's a little pencil icon near the top right of where the commit message is displayed on https://gerrit.wikimedia.org/r/#/c/102297/ [21:01:34] But in general, you would also be able to recommit it by downloading the commit if neccessary (via git review -d 102297) and then doing git commit --amend, followed by git review [21:04:09] Ah cool, just edited it bawolff [21:04:15] thanks again [21:04:19] hi Ahmad96 ! I just provided more details in the GCI task. Once your commit message is correct, the related Bugzilla report will be updated. I have added Tomasz (Odder) as a reviewer already [21:04:54] qgil: Just fixed my commit message [21:05:02] qgil: Did odder un-add himself - he was listed as a reviewer 10 seconds ago and now is not listed... [21:05:18] Can you please readd Odder to the task, I think I kinda accidentally removed him :/ [21:05:25] Sorry, was a dumb mistake [21:05:31] done [21:05:42] I didn't think you had the technical ability to actually do that [21:06:14] Ahmad96: For the commit message, try and making the first line shorter. You should aim for around 65 letters, followed by a blank line, and then followed by more in depth details [21:06:17] Ahmad96... and I just received the Bugzilla notification, which is a very basic automatic test of the usefulness of a commit message. ;) Good! [21:06:45] Ahmad96: Also, to be nitpicky, remove the space between the Bug: 58165 line and the Change-id line [21:06:54] haha okay :) [21:07:14] Ahmad96, you don't need to say "It substitutes wikibooks.ico at operations/mediawiki-config/docroot/bits/favicon. " [21:07:25] Ahmad96, it is obvious in the git/Gerrit change [21:08:28] (03Merged) 10jenkins-bot: Watch user page and user talk page by default [core] - 10https://gerrit.wikimedia.org/r/95742 (owner: 10Bartosz Dziewoński) [21:08:29] Ahmad96: For example, this is what the commit message looks like on a different change (chosen at random) https://gerrit.wikimedia.org/r/#/c/101479/ [21:09:06] The new version of the commit message looks good :) [21:09:22] (03PS3) 10Manybubbles: Allow reindexing by namespace [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102047 (owner: 10Chad) [21:09:32] thanks for the tips :) [21:09:32] Ahmad96, you can find examples of similar Gerrit changes that went through at https://bugzilla.wikimedia.org/show_bug.cgi?id=45036 (click the "Depends on" that are already fixed) [21:09:50] Or actually that was odder who just changed the commit message [21:09:51] (03Merged) 10jenkins-bot: mediawiki.searchSuggest: Unbreak browser blacklist [core] - 10https://gerrit.wikimedia.org/r/95870 (owner: 10Bartosz Dziewoński) [21:10:05] https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines#Example [21:10:11] hello. [21:10:23] speaking of odder, here he is. /me waves at twkozlowski [21:10:43] (03PS3) 10Manybubbles: Respect revision deletion in CirrusSearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101447 (owner: 10Chad) [21:10:46] hi bawolff [21:10:56] it's magic that brought me here, see [21:11:49] qgil: did you have a look at http://tools.wikimedia.pl/~odder/favs/ ? [21:12:28] I still think that the current favicon is sharper than the new one [21:12:44] bawolff: is https://gerrit.wikimedia.org/r/#/c/102086/ ok? [21:12:58] (03PS1) 10Aaron Schulz: Fixed error in LocalRepo::findFiles() [core] - 10https://gerrit.wikimedia.org/r/102303 [21:13:13] * bawolff looks [21:13:25] [21:13:52] Amgine: what did I break this time? [21:14:09] bawolff: oh, and https://gerrit.wikimedia.org/r/102303 too [21:14:51] twkozlowski, alright then I might have closed that wikipedia favicon task too soon... [21:15:26] Oh, it's not something you did. It's just better to have a designated scapegoat for whatever the next complaint will be. [21:16:00] Amgine: Point taken. [21:16:10] Ahmad96, after a review in record time... would you like to work on another favicon? [21:16:19] Yeah sure :) [21:16:27] Ahmad96, give me one minute or two [21:16:40] qgil: What I meant is that there have been press articles about Wikipedia changing its favicon [21:16:51] so there are some serious weirdos out there who care about this :) [21:17:17] so I think we should make sure we won't change the current favicon into a lower quality one [21:17:34] This isn [21:17:35] twkozlowski, sure, I'm with you. This is why I'm going to create a GCI task to get a great wikipedia favicon in 3 resolutions [21:17:53] this isn't as hard as I thought (the gerrit review) [21:17:55] * [21:17:58] Ahmad96, we are talking about the Wikipedia favicon, not your Wikibooks favicon. No worries. :) [21:18:16] haha :D [21:18:35] qgil: Maciej submitted a good one, in three resolutions too. [21:18:43] it just isn't perfect :) [21:18:43] I only did taks for the kiwix app so far, so this way my first gerrit review [21:19:22] twkozlowski, so we need another Wikipedia fvicon or not? [21:19:43] Ahmad96, there are more favicon tasks currently open. Feel free choosing one. [21:20:18] (03CR) 10TheDJ: "So the IE Fixes are only supposed to be used on content ? Not on 'UI chrome' where they possibly might be used ?" [core] - 10https://gerrit.wikimedia.org/r/96239 (owner: 10Bartosz Dziewoński) [21:20:21] qgil: We need that person to re-check the one they already submitted. [21:20:38] (03PS1) 10MaxSem: Initial conversion of prop=extracts from MobileFrontend [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/102305 [21:20:49] or maybe it's just me being blind, can you confirm that the new one is more blurred than the one we use right now? [21:21:10] (03CR) 10Manybubbles: [C: 031] "I filed https://bugzilla.wikimedia.org/show_bug.cgi?id=58596" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101447 (owner: 10Chad) [21:21:14] http://tools.wikimedia.pl/~odder/favs/ - you can open them in tabs next to each other [21:22:05] okay I just did qgil [21:22:41] (03CR) 10MaxSem: [C: 031] Add QuickTemplateAfterPortlet hook to add html after portlets [core] - 10https://gerrit.wikimedia.org/r/101895 (owner: 10Aude) [21:27:33] (03CR) 10Brian Wolff: Added streamFile() unit tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102086 (owner: 10Aaron Schulz) [21:31:29] twkozlowski, you are right, and I -1 and commented at https://gerrit.wikimedia.org/r/#/c/99768/ [21:31:49] Thanks qgil [21:32:33] (03PS2) 10Ori.livneh: jquery.suggestions: Remove any highlights when hiding suggestions [core] - 10https://gerrit.wikimedia.org/r/82098 (owner: 10Bartosz Dziewoński) [21:32:39] "Imagine how many times this icon is displayed every day." [21:32:44] (03CR) 10Ori.livneh: [C: 032] jquery.suggestions: Remove any highlights when hiding suggestions [core] - 10https://gerrit.wikimedia.org/r/82098 (owner: 10Bartosz Dziewoński) [21:32:45] hah! good motivation technique, qgil! [21:33:01] (03CR) 10kroocsiogsi: "Hm. Because I don't understand the git workflow. I accidentally reverted the last change. Is it possible to recommit/rereview/rewhatever c" [extensions/SoundManager2Button] - 10https://gerrit.wikimedia.org/r/101637 (owner: 10kroocsiogsi) [21:33:02] :) [21:36:02] (03PS1) 10Chad: Localize final form of scholarships app [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102307 [21:36:03] (03PS2) 10Aaron Schulz: Added streamFile() unit tests [core] - 10https://gerrit.wikimedia.org/r/102086 [21:36:18] (03CR) 10Mattflaschen: "Matmarex, can you add this to the release notes and maybe https://meta.wikimedia.org/wiki/Tech/News/Next ?" [core] - 10https://gerrit.wikimedia.org/r/95742 (owner: 10Bartosz Dziewoński) [21:37:43] (03CR) 10TheDJ: [C: 031] "I agree that changing those classnames probably can better be done in a separate changeset" [core] - 10https://gerrit.wikimedia.org/r/98589 (owner: 10Bartosz Dziewoński) [21:39:19] I was going to ask how I eat Indian food with my hands whilst not making a mess of my laptop [21:39:21] No Yuvi to ask [21:39:23] :( [21:39:43] hashar: There's something weird in Zuul/Jenkins/queue [21:40:08] well VisualEditor jobs in gate are all waiting for the -qunit job [21:40:11] it is not concurrent yet [21:40:16] hashar: http://cl.ly/image/1D3W05382Y1e [21:40:19] yeah, but still [21:40:24] for a minute or 2 it was like that [21:40:25] Reedy: It's easy, eat with one hand, use other hand for your laptop. [21:40:26] nothing in progress [21:40:29] only queued and done [21:40:39] why is it not processing other events meanwhile to schedule new jobs? [21:40:43] ah yeah [21:40:53] I've noticed this a lot, something is keeping it from processing events [21:41:06] so there is a lame bug in Zuul version we use is that the top priorities are roughly: [21:41:19] the jobs are asynchronous right? the only thing blocking incoming events should be sending jobs to gearman/jenkins, that should be a very cheap operation. [21:41:26] 1) update job descriptions (that block all processing) 2) trigger / query jobs [21:41:33] 3) send back results [21:41:57] as you can see on your screenshot, there are 38 results pending [21:42:05] each being a comment that should be reported back to Gerrit [21:42:15] ah, results is gerrit comments? [21:42:19] I never knew that [21:42:27] I wanted to backport the patch from a later version but that does not apply cleanly on our current version :-( [21:42:46] results is when something Zuul has send back to Gerrit [21:42:51] can be a simple --submit [21:43:03] but in our context there is always a comment with it [21:43:18] so yeah that screenshot highlight the issue we had with Zuul for quite a long time :-( [21:43:49] whenever the few changes have been completed, it would probably send all results at once [21:44:43] qgil: The previous student on this task: https://www.google-melange.com/gci/task/view/google/gci2013/5791471743533056 put together the icon with this icon https://commons.wikimedia.org/wiki/File:Wikimedia_logo_text_RGB.svg and the inter text beneath it. Should I do this as well? [21:44:44] Fix internal.ico favicon [21:44:44] Status: Claimed (2 days, 23 hours left) [21:44:44] Mentor(s): Quim Gil [21:44:47] hashar: even worse now: http://cl.ly/image/3d0X1i322p0k [21:45:02] 104 events, only 2 jobs running in Jenkins, 8 results [21:45:18] Krinkle: lot of those issues are fixed upstream now. The Zuul scheduler only interacts with its embedded Gearman server so it is never blocking. Then Gearman is basically a huge queue of tasks that need to be done in Jenkins [21:45:27] OK [21:46:09] Krinkle: on gallium you can: tail -f /var/log/jenkins/access.log |fgrep urllib [21:46:11] Krinkle: that shows Zuul doing API calls back to Jenkins [21:46:55] each description updates takes 250 ms or 4/ seconds [21:47:23] when a change triggers 10 jobs, whenever a job change of status (i.e. queued -> in progress -> ok), Zuul update the description of the other 9 jobs [21:47:23] hashar: So what is slowing down Jenkins? Build history? [21:48:12] (03CR) 10MaxSem: [C: 032] Link to the mw-ocg-texter backend in the README. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/102205 (owner: 10Cscott) [21:48:12] so each status change (2) X all other jobs in the change (9) x time for a description change (250ms) = 4,5 seconds on every status change :( [21:48:39] Jenkins API is not very fast, it has some overhead, maybe 100 ms [21:48:49] (03PS1) 10Ori.livneh: startup.js: log current time as global 'mediaWikiLoadStart' [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102310 [21:49:13] then there is some time for the POST to be actually handled then the GET to fetch the result [21:49:24] these are all in the same data center, all pure http, these machines have shitload of cpu and ram and ssd. 4,5 seconds for anything that doesn't involve parsing huge chunks of wikitetext, database calls or image scaling, should be < 500ms for any realistic number of http requests triggered at the same time. [21:49:32] yeah [21:49:34] hence why [21:49:41] next fiscal year i will propose to phase out jenkins entirely [21:50:02] at least for mass CI purposes [21:50:09] we can still use jenkins for adhoc jobs though [21:50:13] hashar: Let me guess, gearman will communicate directly with the labs vm pool? [21:50:29] and then zuul publishes console logs? [21:50:33] but first I need to document the architecture / design of the CI platform. It has been pending for two years now :( [21:50:34] (03PS2) 10Theopolisme: Add raw HTML output functionality [core] - 10https://gerrit.wikimedia.org/r/102121 [21:50:41] Ahmad96, look at all the comments we left in his Gerrit patch. There is more than enough to understand the work that needs to be done (which is basically keep the same format as the original 16x16 icon) [21:50:47] Krinkle: think of Gearman like a huge job queue from which workers can fetch jobs they are interested in [21:51:18] Krinkle: we could potentially boot instances in labs with a gearman worker that would be made to only pick one task and delete the instance after it has complete its work. [21:51:21] Right, in that case we'll need a master still to actually give jobs to the pool, because we can't have the pools asking for jobs themselves since they can't start themselves. [21:51:25] (03CR) 10BryanDavis: [C: 04-1] Localize final form of scholarships app (033 comments) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102307 (owner: 10Chad) [21:51:28] Sounds good [21:51:36] Krinkle: something like listen( '*qunit' ); selfdesctruct() [21:51:49] (03CR) 10Ori.livneh: [C: 032] startup.js: log current time as global 'mediaWikiLoadStart' [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102310 (owner: 10Ori.livneh) [21:51:54] the trick, is that the worker can be whatever we want [21:51:57] ie Travis :-] [21:52:43] Krinkle: highlight of VE taking a while with job descriptions updates : http://paste.debian.net/71470/ [21:53:05] Krinkle: Zuul spams jenkins with POST submitDescription then does a GET (the post redirects iirc) [21:53:15] yeah POST emit a 302 [21:53:45] hashar: Can we disable the job descriptoin updating maybe? As long as there is a link back to the gerrit change, it is still easy to get to the other jobs. [21:53:57] yeah I thought about that [21:54:11] didn't manage to find a solution to disable only the submitDescription calls :( [21:54:26] feel free to hack it in if you find something fastly [21:54:34] but anyway, that will be resolved when I get zuul upgraded [21:54:51] not sure yet when it will happen, most probably the first week of january [21:55:57] then the description updates are sent to Gearman and thus are no more blocking Zuul [21:56:19] (03CR) 10Ori.livneh: [V: 032] startup.js: log current time as global 'mediaWikiLoadStart' [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102310 (owner: 10Ori.livneh) [21:57:17] (03CR) 10Krinkle: Add 'mediaWikiLoadComplete' measurement (031 comment) [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/100951 (owner: 10Ori.livneh) [21:58:06] hashar: The main issue is not having response in gerrit. [21:58:12] Krinkle: " I've already typed it now, so, have a nice day."? [21:58:15] * ori-l doesn't get it. [21:59:11] hashar: e.g. take ori-l's backport as example, in over 7 minutes there wasn't even a "Pipeline gate-and-submit started", at least an acknowledgement like that is progress and would likely speed things up perspectively and prevent people from bypassing it during peak load :) [21:59:32] Krinkle: it's true [21:59:41] that would have probably stopped me [21:59:56] Anyway, so it did start, by no worries. [22:00:12] jenkins also seems to repeat tests a lot [22:00:25] ori-l: Elaborate? [22:01:27] Krinkle: e.g.: https://gerrit.wikimedia.org/r/#/c/95070/ (lint, jslint, jsduck) [22:03:14] ori-l: Well, that depends. This one has a confusing timeline, but it's no more repeating than reasonable imho. In theory it could be optimised, but unlikely except for git-parent checks. [22:03:21] There is an initial test on submission against current master. [22:03:29] Then the gate test against what it will be merged as. [22:03:51] which, depending on how long it has been sitting there, can be important. and will also fail if it conflicts. [22:04:07] Krinkle: I am not sure how the "pipeline started" is handled internally by Zuul. Might be a result event [22:04:15] (03PS1) 10Reedy: Remove unreachable Html::rawElement( 'br' ) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102313 [22:04:15] and then some post-merge checks, which shouldn't include linting imho, but we do for some reason (paranoia?) [22:04:21] Krinkle: and hence it ends up being stuck waiting for jobs to be processed [22:04:40] the post-merge lint can be removed. [22:04:40] since rebase followed by an immediate +2 is quite common, would it be possible to have jenkins abort the rebase tests? [22:05:03] or perhaps wait a few seconds before dispatching them, and only run them if no +2 followed? [22:05:14] ori-l: That would require jenkins to know the test pipeline and gate pipeline contain the same build steps [22:05:28] ori-l: yeah I think that is supported in next Zuul version. Ie pipelines have some sort of precedences iirc [22:05:31] for example, post-merge pipeline is different. [22:05:48] yeah, i figured it'd be hard to do [22:05:50] ori-l: so I think we can make gate-and-submit to dequeue a change in the test pipeline [22:05:52] or rather, zuul, not jenkins, but anyhow. [22:06:03] Even worse, right now it is soo flexible, that the pipeline is exposed to the bash that executes it [22:06:10] (03PS1) 10Reedy: Swap deprecated key_exists() for array_key_exists() [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102314 [22:06:14] (03Merged) 10jenkins-bot: jquery.suggestions: Remove any highlights when hiding suggestions [core] - 10https://gerrit.wikimedia.org/r/82098 (owner: 10Bartosz Dziewoński) [22:06:17] so job-lint could so something different in pipeline test or gate [22:06:25] but that's evil :) [22:06:26] what else could we do to make it faster? can we just throw more hardware at the problem? [22:06:44] (03PS1) 10Chad: Rewrite i18n support to use new json format [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102315 [22:06:46] ori-l: ah forget me, precedence is just the priority of each pipelines to process some jobs before others. [22:06:56] ^d: So, once upon a time, there was a VisualEditor/core.git repo, what ever happened to that? [22:06:58] (03CR) 10Chad: "Completely untested :D" [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102315 (owner: 10Chad) [22:07:21] ori-l: Not right now, in fact, we'll make it worse by making jobs run in sequence on a vm in the future instead of separated. This reduces set up cost, but increases run time. However we will be able to scale better there by adding resources to the vms in general. [22:07:32] <^d> The VisualEditor/* ones were deleted, remember? Because you wanted mediawiki/extensions to work and it wasn't for $someReason. [22:07:36] ori-l: e.g. more like travis-ci [22:07:44] Krinkle: makes sense [22:07:57] one vm per pipeline event, and then run all the different tests and then destruct it. [22:08:14] (03PS1) 10Reedy: Return value in UploadMetadataJob::recreateMetadataJob() [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102319 [22:08:19] ^d: We now want it back. :-) [22:08:23] however most of our speed issues are in the environment, the testts themselves (except for phpunit) are all very fast [22:08:28] * Aaron|home wonders where bawolff went ;) [22:08:30] <^d> James_F: Roan knows how to make repos :) [22:08:41] (03PS1) 10Ori.livneh: startup.js: log current time as global 'mediaWikiLoadStart' [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/102320 [22:08:43] and set up cost for vm will be cheap as we'll have a pool of hot standbys [22:09:09] (03CR) 10Ori.livneh: [C: 032] startup.js: log current time as global 'mediaWikiLoadStart' [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/102320 (owner: 10Ori.livneh) [22:09:10] Krinkle: hopefully :-] [22:09:10] ^d: But not /why/ it was deleted in sufficient detail to fix jenkins once he does. :-) [22:09:15] <^d> It wasn't jenkins, it was gerrit. [22:09:17] ^d: I guess we can make that Krinkle and hashar's problem. [22:09:24] <^d> And we won't know if it fucks up until someone tries to make it again. [22:09:25] ^d: Oh, yes, now I remember. [22:09:27] * James_F sighs. [22:09:29] OK, let's go. [22:09:31] Krinkle: but first, got to get Zuul upgraded. It takes half an hour but needs a few days of monitoring, specially during (my) evenings [22:09:37] RoanKattouw: Have fun. [22:09:38] (03PS1) 10Reedy: Remove unused imports [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102321 [22:09:51] Aaron|home: back now [22:10:01] <^d> James_F, RoanKattouw: It's easy enough to verify. Check database to make sure submodule_subscriptions for VE-related things are sane. [22:10:04] <^d> If not, panic. [22:10:18] * James_F nods. [22:10:28] (03PS1) 10Reedy: Fix undefined MWException from global scope [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102322 [22:10:36] ^d: Was it case-sensitive? Maybe RoanKattouw should make the new repo with a different case? [22:10:53] (03CR) 10Ori.livneh: [V: 032] startup.js: log current time as global 'mediaWikiLoadStart' [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/102320 (owner: 10Ori.livneh) [22:10:57] ^d: speaking of that, will probably stop using mediawiki/extensions.git one day [22:10:58] ^d: in favor of a daemon listening for refs/updated events for master branch of all extensions and directly refresh them [22:11:24] ^d: that will be less lame than the brute force while(true); sleep 6minutes; git pull; done; [22:11:28] qgil: I read through the comments and tried to replicate it like you said. It currently looks like this: http://i.imgur.com/ROwtp3q.png. Is this fine? [22:11:57] I even found a font, that almost matches the original font [22:13:18] Ahmad96: The Wikimedia logo has to be cut in half by the white rectangle [22:13:34] http://bits.wikimedia.org/favicon/internal.ico is the favicon we use now [22:13:35] oh okay [22:13:43] (03PS1) 10Manybubbles: Use Cirrus's fancy redirect tracing with --from [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102323 [22:14:01] (03Merged) 10jenkins-bot: Link to the mw-ocg-texter backend in the README. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/102205 (owner: 10Cscott) [22:14:04] and the 'inter' part has to be in lower-case letters [22:14:11] bd808: You did a lot of the code review for GWTooolset? I'm getting a little stack of cleanup commits going ;) https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/GWToolset,n,z [22:14:24] OK, let's try and create another VisualEditor/core repo then [22:14:32] And hope it doesn't bork labs updates again [22:14:35] Yay. [22:14:45] Reedy: Yikes [22:15:19] Couple are potential bugs.. [22:15:20] (03PS6) 10EBernhardson: Load usernames directly from wiki's in batches [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 [22:15:21] bawolff: I was thinking about https://gerrit.wikimedia.org/r/#/c/102086/ and https://gerrit.wikimedia.org/r/#/c/102303/ [22:15:36] <^d> James_F: No, it shouldn't be. [22:15:38] (03CR) 10Manybubbles: [C: 031] "I checked it out, poked it a little bit, tested it pretty thoroughly, and removed the WIP." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102047 (owner: 10Chad) [22:15:42] <^d> The underlying filesystem isn't. [22:15:59] James_F: Do you figure we'll need multiple repos in the VisualEditor/* space? I personally doubt we will, thinking we should just create VisualEditor.git rather than VisualEditor/core.git [22:16:15] Cause I'm having trouble coming up with what else we would have [22:16:22] <^d> hashar: That'll be nice for beta/jenkins, but I don't see us deleting the repo. People use it :\ [22:16:27] Integrations for non-MW things, I guess? [22:16:35] ^d: yeah was referring to beta [22:16:37] bd808: when do you think scholarships will wrap up for you maybe? [22:16:44] RoanKattouw: We were talking about having core and then each of the editing tools split out (e.g. tables, imagemaps, etc.) as well as integrations other than MW> [22:16:56] ^d: I should fill a bug report about it and get someone to write such a daemon for us :) [22:16:58] <^d> Aaron|home: When I stop removing his hardcoded english and making him do i18n review :p [22:17:16] bd808: oh, and here is a random commit: https://gerrit.wikimedia.org/r/#/c/102080/ [22:17:26] <^d> James_F, RoanKattouw: Take it from me, don't name things core. [22:17:33] <^d> Biggest regret of gerrit: mediawiki/core. [22:17:35] Aaron|home: Hoping that it will be "done" this week [22:17:42] ^d: So call it VisualEditor/VisualEditor.git? [22:17:57] Actually hoping that it will be done by the end of the day tomorrow [22:18:15] OK, creating VisualEditor/VisualEditor.git then [22:18:16] <^d> James_F: I've given up trying to be consistent in gerrit, we can call it anything you'd like :D [22:19:04] RoanKattouw: OK. [22:19:11] ^d: Yessir. :-) [22:20:36] (03CR) 10Brian Wolff: [C: 032] "lgtm" [core] - 10https://gerrit.wikimedia.org/r/102086 (owner: 10Aaron Schulz) [22:20:39] (03CR) 10BryanDavis: [C: 032] Remove unreachable Html::rawElement( 'br' ) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102313 (owner: 10Reedy) [22:21:25] hi, how could one edit https://en.wikipedia.org/wiki/Special:Book ? [22:21:47] rutu: Edit what exactly? [22:21:49] (03CR) 10BryanDavis: [C: 032] Swap deprecated key_exists() for array_key_exists() [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102314 (owner: 10Reedy) [22:21:52] try ?uselang=qqx in the end of the URL to find out [22:22:03] RoanKattouw: Also, yay for yet-more repos for you to add to the dashboard. :-) [22:22:06] i tried to call it from a mobile device and the user experience is mediocre so to say ... [22:22:09] (03CR) 10Chad: [C: 032] Use Cirrus's fancy redirect tracing with --from [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102323 (owner: 10Manybubbles) [22:22:10] (03PS1) 10Ori.livneh: Update NavigationTiming to master [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102324 [22:22:29] Ahmad96, do you see the little icon at the left with the pink bachttps://gerrit.wikimedia.org/r/#/c/100326/9/docroot/bits/favicon/internal.icokground (aka the current version)? [22:22:38] James_F: Yeah... [22:22:40] reedy: the page itself. have the download on top. [22:22:51] (03CR) 10Chad: [C: 032] Allow reindexing by namespace [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102047 (owner: 10Chad) [22:22:58] (03CR) 10Ori.livneh: [C: 032] Update NavigationTiming to master [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102324 (owner: 10Ori.livneh) [22:23:04] reddy: and have "writer=zim" preset [22:23:54] Ahmad96, now look at your own version: http://i.imgur.com/ROwtp3q.png . These are not replicas. They are visibly different. Please spend some time working on your icon and ask for review only after you are sure that you and your relatives at home :) see both icons identical [22:24:39] reedy: i am trying to extend the kiwix help so people can download books and create books. but, somehow the entry points are not there in wikipedia ... [22:25:00] which is somehow surprising :) [22:25:01] (03CR) 10Chad: [C: 032] Respect revision deletion in CirrusSearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101447 (owner: 10Chad) [22:25:01] Ahmad96, the previous student got stuck sending versions that didn't look like the original. I'm not talking about pixel differences, I'm talking about obvious differences. Please don't do that. :) [22:25:05] What entry points? [22:25:11] (03CR) 10Chad: [C: 032] Index page templates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101992 (owner: 10Chad) [22:25:34] reedy: to create a book to read offline later on. [22:25:52] (03CR) 10Ori.livneh: [V: 032] Update NavigationTiming to master [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/102324 (owner: 10Ori.livneh) [22:26:00] qgil: Oh okay. So it shouldn't look like this one? http://bits.wikimedia.org/favicon/internal.ico [22:26:12] But like the pink one on gerrit? [22:26:27] reedy: (1) the mobile skin lacks the "book" link. and (2) the book creating page does not show anything useful ... [22:27:10] Ahmad96, both are the same. :) It's the current version. See how the Wikimedia logo is half the icon, and the other half is the inter wod. Your version has a full Wikimedia icon. Isn't it obvious? :) [22:27:11] rutu: Ok, so that's 2 different issues then :) [22:28:00] reedy: yes, i thought i ask one after the other *blush* but i guess it is easier to explain in context, now than you say ... [22:28:03] qgil: ah okay haha, got it. I just thought for a moment you were refering to this icon You mean this pink icon, right? http://i.imgur.com/lgIdNyw.png [22:28:12] WIll correct it! [22:29:08] Ahmad96, that is the Gerrit icon. Nevermind. As said, make sure your version looks identical to the previous one. Thank you! [22:29:47] okay, will do [22:29:48] ^d: I shot myself in the foot. Help? I messed up and now the VisualEditor project has no owner [22:29:53] So I can't assign it a new one [22:29:54] (03PS2) 10BryanDavis: Fix undefined MWException from global scope [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102322 (owner: 10Reedy) [22:29:58] <^d> Set the owner. [22:30:07] I thought I was being clever by adding a new owner and removing the old one in the same ACL change [22:30:12] In that order but that didn't help [22:30:13] How? [22:30:19] <^d> `ssh -p 29418 gerrit.wikimedia.org gerrit set-project-owner --help` [22:30:24] <^d> I can't remember the syntax beyond that. [22:30:40] <^d> Might be [22:30:41] (03CR) 10BryanDavis: "Changed fix to match other classes in the project." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102322 (owner: 10Reedy) [22:30:46] Awesome thanks [22:31:03] <^d> yw [22:31:38] (03PS1) 10MaxSem: API: allow disabling TOC in action=parse [core] - 10https://gerrit.wikimedia.org/r/102329 [22:32:14] Nope, that doesn't exist, and set-project doesn't have anything related to ownership [22:32:16] To Google [22:33:04] (03CR) 10BryanDavis: "Not tested but I like the idea." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102321 (owner: 10Reedy) [22:33:07] <^d> Oh, parent. [22:33:08] <^d> Duh [22:33:19] <^d> parent != owner [22:33:22] (03PS7) 10EBernhardson: Load usernames directly from wiki's in batches [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 [22:33:25] Yeah [22:33:34] Maybe I should just delete the project [22:33:37] How do I do that? [22:33:47] qgil: I cut it in half now (and streched the font a bit): http://i.imgur.com/yZQDwbz.png. I think it looks quite similar now. What do you think? :) [22:33:49] <^d> I set owner to admins. [22:33:49] <^d> https://gerrit.wikimedia.org/r/#/admin/projects/VisualEditor,access [22:34:01] (03CR) 10EBernhardson: Load usernames directly from wiki's in batches (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 (owner: 10EBernhardson) [22:34:03] Whoa wtf [22:34:04] It didn't let me [22:34:10] <^d> I don't have any special privs you don't. [22:34:32] Oh wait no I realized what I did [22:34:34] Stupid Gerrit UI [22:34:45] hashar: I noticed for a few weeks (months?) now that operations/software tends to hang in zuul for a long time [22:34:46] 0 jobs [22:34:50] You have to click Add even after clicking a suggestion [22:34:52] https://integration.wikimedia.org/zuul/ https://gerrit.wikimedia.org/r/#/c/102318/ [22:35:09] http://cl.ly/image/2I0K0t0X3l2c [22:35:16] (03PS1) 10Ori.livneh: Update NavigationTiming to master [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/102330 [22:36:01] <^d> RoanKattouw: It's always been that way ;-) [22:36:12] (03CR) 10Ori.livneh: [C: 032 V: 032] Update NavigationTiming to master [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/102330 (owner: 10Ori.livneh) [22:36:45] Yeah I know [22:36:49] (03CR) 10BryanDavis: [C: 032] Return value in UploadMetadataJob::recreateMetadataJob() [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102319 (owner: 10Reedy) [22:37:10] qgil, you there? [22:37:13] * Aaron|home is disappointed at the leak of memory stuff in his xdebug cachegrind file [22:37:16] (03CR) 10Reedy: "In theory it should be correct... It was done by PhpStorm" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102321 (owner: 10Reedy) [22:37:22] *lack of [22:37:59] Aaron|home, freudian slip? :) [22:38:08] (03Merged) 10jenkins-bot: Remove unreachable Html::rawElement( 'br' ) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102313 (owner: 10Reedy) [22:38:14] Ahmad96, your logo still has a very visible difference with the current icon. Look at the point where the current icon is cut, and look at the point you are cutting it. This is another very visible difference..... [22:38:18] (03Merged) 10jenkins-bot: Swap deprecated key_exists() for array_key_exists() [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102314 (owner: 10Reedy) [22:38:19] heh, well I'm looking at a mem leak [22:38:24] (03Merged) 10jenkins-bot: Use Cirrus's fancy redirect tracing with --from [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102323 (owner: 10Manybubbles) [22:38:29] (03CR) 10GWicke: Added new jenkins jobs file for /mediawiki/services/parsoid repo (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101912 (owner: 10Subramanya Sastry) [22:38:48] qgil: oh, right, sorry about that [22:39:03] Ahmad96, you were very lucky getting 2-4 reviewers instantly in your first patch. This will not happen always. You need to be careful calling people for review only when you have tested carefully your own work. [22:39:06] (03Merged) 10jenkins-bot: Added streamFile() unit tests [core] - 10https://gerrit.wikimedia.org/r/102086 (owner: 10Aaron Schulz) [22:39:25] (03Merged) 10jenkins-bot: Allow reindexing by namespace [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102047 (owner: 10Chad) [22:39:44] qgil: ok, sorry :/ Will take care of that in the future [22:40:04] Ahmad96, please do your homework with enough time and patience. Today you got a task closed within a couple of hours or so. Sit back, work well, come back when you have a favicon with three layers and a 16x16 version that looks like the current one, if not better. Thank you! [22:40:13] dan-nl: Can you test https://gerrit.wikimedia.org/r/#/c/102321/ locally? [22:40:21] hi superm401 [22:40:22] okay [22:40:45] bd808, k [22:41:04] dan-nl: Thanks. Reedy is using his magic tools to find all the cruft [22:41:19] qgil, so I'm pretty sure the only tour on ca.wikipedia is firstedit. [22:41:27] If there were a custom tour in the MW namespace, it would be at: [22:41:29] https://ca.wikipedia.org/wiki/Especial:Cerca_per_prefix/MediaWiki:Guidedtour-tour- [22:41:36] (that works on any wiki, just change the domain). [22:41:58] And the only ones GuidedTour bundles are firstedit (plus the firstedit version for VisualEditor). [22:42:16] qgil, it could be one of the extension at https://ca.wikipedia.org/wiki/Especial:Versi%C3%B3 bundles a tour. [22:42:33] But I don't think so, since the only other extension I know with tours is GettingStarted [22:42:34] (03CR) 10jenkins-bot: [V: 04-1] Respect revision deletion in CirrusSearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101447 (owner: 10Chad) [22:42:36] Which is not installed there yet. [22:42:39] (03Merged) 10jenkins-bot: Index page templates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101992 (owner: 10Chad) [22:42:58] (03PS1) 10Hashar: runbJobs: rm outdated options in comments [core] - 10https://gerrit.wikimedia.org/r/102331 [22:42:59] (03PS1) 10Hashar: runJobs: option to prevent logging starts [core] - 10https://gerrit.wikimedia.org/r/102332 [22:43:22] superm401, yep, I reached to these conclusions while you were away. :) [22:43:30] qgil, sorry, wasn't sure. [22:43:40] superm401, so... what should we do to have Getting Started in ca.wiki, apart from translate it? [22:44:01] qgil, the first thing to research is what cleanup-type templates you have. [22:44:12] Ideally "needs copyediting", but we might eventually add support for others. [22:44:14] superm401, as I see it is only on n.wiki now. ca.wiki is a rather tech- and novelty-friendly project. We would be happy to test [22:44:21] Excellent. [22:44:38] We are probably going to roll out to other wikis relatively soon even without those categories/templates. [22:44:54] But there will be an extra feature (finding articles to work on that need copy-editing) for wikis that do have such a cat. [22:44:57] (03CR) 10Hashar: "logging starts was an idea from a discussion a while back with Asher. I am pretty sure we never used those STARTING lines in runJobs.log a" [core] - 10https://gerrit.wikimedia.org/r/102332 (owner: 10Hashar) [22:45:08] superm401, alright, I will propose to the editors to do the homework at translatewiki with this extensions [22:45:10] (03CR) 10Bsitu: "Just did some syntax review, didn't know contribution enough yet to comment on implementation detail, :)" (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99038 (owner: 10Werdna) [22:45:11] extension [22:45:33] qgil, if there is such a category, add it to https://www.wikidata.org/wiki/Q8235695 . [22:48:28] superm401, reload [22:49:51] qgil, cool, thanks. :) [22:54:38] (03Merged) 10jenkins-bot: Return value in UploadMetadataJob::recreateMetadataJob() [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102319 (owner: 10Reedy) [22:56:07] (03CR) 10Dan-nl: [C: 032 V: 032] "thanks!" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102321 (owner: 10Reedy) [22:57:48] (03CR) 10Dan-nl: [C: 032 V: 032] Fix undefined MWException from global scope [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102322 (owner: 10Reedy) [22:57:54] hashar: I'd like to remote -phplint from postmerge for mediawiki-core, we only test changed files, so it's unlikely to reveal anything. especially because we already run it on gate as well [22:58:10] remove* [22:58:28] Krinkle: +2 :-] [22:58:49] ^d: OK so now I've gotten the VisualEditor/VisualEditor.git repo in a weird state. I pushed a bunch of stuff into it, got a timeout error from Gerrit, but deleting and recloning shows the commits are all there. However, gitblit doesn't see them [22:59:00] Krinkle: never really thought about what jobs should be running on post merge, so be bold! :] [22:59:14] (03PS1) 10Krinkle: Remove lint jobs from mediawiki-core postmerge pipeline [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/102337 [22:59:15] RoanKattouw: Cache? gitblit pisses me off for that [22:59:22] <^d> I hate that cache. [22:59:32] ?givemethedamnnewestversion [22:59:38] <^d> That, and if you rewrote history from the repo you initially created you broke replication. [23:00:07] DontDoThat :P [23:01:57] (03PS1) 10Catrope: Update .gitreview and remove MW-specific things [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/102339 [23:02:02] Wheee [23:02:18] (03CR) 10Krinkle: [C: 032] Remove unused 'tools/gruntjs' submodule [integration/jenkins] - 10https://gerrit.wikimedia.org/r/102022 (owner: 10Krinkle) [23:02:21] (03PS2) 10Krinkle: Remove unused 'tools/gruntjs' submodule [integration/jenkins] - 10https://gerrit.wikimedia.org/r/102022 [23:02:26] (03CR) 10Krinkle: [C: 032] Remove unused 'tools/gruntjs' submodule [integration/jenkins] - 10https://gerrit.wikimedia.org/r/102022 (owner: 10Krinkle) [23:02:31] RoanKattouw: Want me to +2? [23:03:07] Sure [23:03:14] But I'd also like Krinkle's input on what else we should do [23:03:26] As it stands we need to at least tweak README.md and CONTRIBUTING.md [23:03:27] RoanKattouw: I assume I'll need to V+2 too? [23:03:28] VisualEditor/VisualEditor? [23:03:32] I don't think any of the file paths need to change [23:03:33] Eh? [23:03:43] Krinkle: ^d said "don't name things core.git" [23:03:49] RoanKattouw: And Krinkle will need to do his magic re. jenkins. [23:03:54] I also haven't tested that this works *at all* [23:03:57] Yeah [23:03:57] :-) [23:04:03] Lots of work to be done here [23:04:06] RoanKattouw: Because.. ? [23:04:09] (03CR) 10Jforrester: [C: 032 V: 032] Update .gitreview and remove MW-specific things [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/102339 (owner: 10Catrope) [23:04:09] off to bed *wave* [23:04:10] Let's not merge this commit until Jenkins is running properly [23:04:16] Bye hashar. :-) [23:04:24] Timing ... :( [23:04:28] Eurgh. [23:04:32] (03CR) 10EBernhardson: [WIP] Add Flow events to Special:Contributions. (036 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99038 (owner: 10Werdna) [23:04:33] Jenkins is slow, cancel it if you like [23:04:41] That was an insta-merge [23:04:43] Jenkins is slow, but gerrit is instant. [23:04:46] C+2 V+2 [23:04:47] oh he bypassed it [23:04:49] right [23:04:56] (03CR) 10EBernhardson: [C: 032] Remove ul margin around ul.topic-collapser [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101824 (owner: 10Matthias Mullie) [23:05:25] RoanKattouw: We're not yet loading it for mw-ext-VE, so it's not too bad if it's broken right now. [23:05:32] RoanKattouw: Can we replicate to wikimedia/VisualEditor :) ? [23:05:34] Yeah we're not using it [23:06:01] * Krinkle patches grrrit-wm [23:06:11] (unless someone else is on it) [23:06:12] (03CR) 10EBernhardson: [C: 032] GENDER and number i18n for flow-topic-meta-minimal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101947 (owner: 10Amire80) [23:06:17] Krinkle: I asked if we should have VisualEditor.git straight up, but James foresees a future in which we'll have more VE-related repos [23:06:35] Krinkle: Wikimedia/VE? WTF? [23:06:46] Krinkle: This isn't Wikimedia's fork of VE. :-) [23:07:18] James_F: It is going to be on @wikimedia regardless because it is in our gerrit, wikimedia is hosting it. So choose between wikimedia/VisualEditor-VisualEditor or wikimedia/VisualEditor [23:07:26] (03CR) 10EBernhardson: [C: 032] "While it would be better to fix this in core, this is a valid pragmatic solution." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101994 (owner: 10Bsitu) [23:07:40] (03Merged) 10jenkins-bot: Remove unused 'tools/gruntjs' submodule [integration/jenkins] - 10https://gerrit.wikimedia.org/r/102022 (owner: 10Krinkle) [23:07:43] The latter is what it'll be (note, this is independent of gerrit's name, github doesn't have this silly limitation of repo or repo group) [23:07:46] just like wikimedia/oojs [23:07:54] (03Merged) 10jenkins-bot: Remove ul margin around ul.topic-collapser [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101824 (owner: 10Matthias Mullie) [23:08:05] Krinkle: Oh, you mean on GitHub? [23:08:13] Replication, yes. [23:08:15] (03Merged) 10jenkins-bot: GENDER and number i18n for flow-topic-meta-minimal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101947 (owner: 10Amire80) [23:08:23] Krinkle: As opposed to https://git.wikimedia.org/summary/?r=wikimedia/wikimania-scholarships.git etc.? [23:08:29] (03CR) 10Werdna: [WIP] Add Flow events to Special:Contributions. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99038 (owner: 10Werdna) [23:08:32] Who uses that :P [23:08:33] Krinkle: Context is a lovely thing. :-) [23:08:34] (03Merged) 10jenkins-bot: curl_setopt doesn't seem to url-encode the text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101994 (owner: 10Bsitu) [23:08:42] Krinkle: Not us, as you may have learnt. :-) [23:11:14] (03PS1) 10Brian Wolff: Remove some of the permissions so they can be configured per-wiki [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102343 [23:11:20] (03PS1) 10Dr0ptp4kt: Add support to get just the startup module URL with version. [core] - 10https://gerrit.wikimedia.org/r/102344 [23:11:27] ebernhardson++ thanks for the merge [23:11:54] (03PS2) 10Dr0ptp4kt: WIP: Add support to get just the startup module URL with version. [core] - 10https://gerrit.wikimedia.org/r/102344 [23:12:29] (03CR) 10Steinsplitter: [C: 031] Remove some of the permissions so they can be configured per-wiki [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102343 (owner: 10Brian Wolff) [23:15:39] (03PS2) 10Odder: Remove some of the permissions so they can be configured per-wiki [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102343 (owner: 10Brian Wolff) [23:15:50] (03CR) 10TheDJ: [C: 04-1] Math 2.0 (0341 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [23:15:53] (03PS3) 10Odder: Remove some of the permissions so they can be configured per-wiki [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102343 (owner: 10Brian Wolff) [23:17:00] legoktm: Want to merge and deploy https://gerrit.wikimedia.org/r/#/c/102346/ too? [23:17:10] (03CR) 10Kaldari: [C: 04-1] Initial conversion of prop=extracts from MobileFrontend (037 comments) [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/102305 (owner: 10MaxSem) [23:18:21] James_F: done [23:18:31] legoktm: You're awesome. [23:19:35] has: While you're here... [23:19:40] and not anymore.. [23:22:22] bd808: how scary does https://gerrit.wikimedia.org/r/#/c/86642/9 look? [23:22:38] (03PS1) 10EBernhardson: Compare sort order direction in uppercase [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102348 [23:23:34] Aaron|home: I don't remember. Gerrit tells me I've looked at it before but I don't remember it at all [23:24:34] I can try to look at it on Thursday. I'm busy until then with the final bits of Scholarships [23:27:34] gwicke: https://gerrit.wikimedia.org/r/#/c/101226/5 I have no magic auth callbacks there, but it works fine [23:28:19] Aaron|home: On the capitalization for LocalRepo::findFiles change - is the str_replace( ' ', '_', $file->getName() ) for paranoia purposes, or could there really ever be spaces in the result? [23:29:21] sanity I guess [23:30:07] (03CR) 10Odder: [C: 04-1] "Per chat with Brian, let's give the Commons community a few days' time to add all the competent people to the gwtoolset user group before " [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102343 (owner: 10Brian Wolff) [23:30:26] gwicke: I do cheat in doExecuteOpHandlesInternal() a little, doing some mangling + header addition there to avoid duplication though [23:30:28] Aaron|home: ok, just wanted to make sure [23:32:17] TimStarling: any chance to look at https://gerrit.wikimedia.org/r/#/c/94436/? [23:32:37] (03PS3) 10Dr0ptp4kt: Add support to get just the startup module URL with version. [core] - 10https://gerrit.wikimedia.org/r/102344 [23:33:16] (03PS1) 10Hoo man: Don't try to use the now removed ipbreasonotherlist message [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/102350 [23:33:48] (03PS1) 10BryanDavis: Make reviewer ratings range from 0 to 10 [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102351 [23:34:07] (03PS2) 10Hoo man: Don't try to use the now removed ipbreasonotherlist message [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/102350 [23:34:19] (03PS4) 10Tim Starling: Error handling tweaks in JobQueueFederated [core] - 10https://gerrit.wikimedia.org/r/94436 (owner: 10Aaron Schulz) [23:34:26] (03CR) 10Tim Starling: [C: 032] Error handling tweaks in JobQueueFederated [core] - 10https://gerrit.wikimedia.org/r/94436 (owner: 10Aaron Schulz) [23:35:54] (03CR) 10Parent5446: [C: 031] Add $wgHideUserContribLimit config setting [core] - 10https://gerrit.wikimedia.org/r/98267 (owner: 10Umherirrender) [23:36:52] (03CR) 10BryanDavis: Make reviewer ratings range from 0 to 10 (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102351 (owner: 10BryanDavis) [23:37:04] (03CR) 10Parent5446: [C: 032] Fix fatal in LocalRepo::findFiles() [core] - 10https://gerrit.wikimedia.org/r/102288 (owner: 10Reedy) [23:37:29] Aaron|home: ahh, shiny [23:38:18] (03CR) 10Bsitu: [WIP] Add Flow events to Special:Contributions. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99038 (owner: 10Werdna) [23:38:43] (03CR) 10Parent5446: Fixed error in LocalRepo::findFiles() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/102303 (owner: 10Aaron Schulz) [23:39:42] gwicke: I think I can do that stuff as a follow-up later [23:39:49] (03Merged) 10jenkins-bot: Error handling tweaks in JobQueueFederated [core] - 10https://gerrit.wikimedia.org/r/94436 (owner: 10Aaron Schulz) [23:40:11] (03PS2) 10MaxSem: Initial conversion of prop=extracts from MobileFrontend [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/102305 [23:40:42] Aaron|home, did you see the https://www.mediawiki.org/wiki/Talk:Requests_for_comment/PHP_web_service_interface [23:40:43] ? [23:40:44] (03CR) 10Parent5446: [C: 032] runbJobs: rm outdated options in comments [core] - 10https://gerrit.wikimedia.org/r/102331 (owner: 10Hashar) [23:41:05] (03CR) 10Bsitu: [C: 032] Compare sort order direction in uppercase [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102348 (owner: 10EBernhardson) [23:41:26] it might not be worth using guzzle, but interesting nevertheless [23:42:19] (03Merged) 10jenkins-bot: Fix fatal in LocalRepo::findFiles() [core] - 10https://gerrit.wikimedia.org/r/102288 (owner: 10Reedy) [23:42:55] (03CR) 10Odder: [C: 031] "Commons community was really fast in starting a discussion at https://commons.wikimedia.org/wiki/Commons:Administrators'_noticeboard#GWToo" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/102343 (owner: 10Brian Wolff) [23:43:03] gwicke: I haven't looked at the other rfc [23:43:25] * Aaron|home recalls running into guzzle with that super java style AWS vender code [23:43:43] ;) [23:43:46] (03Merged) 10jenkins-bot: Compare sort order direction in uppercase [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102348 (owner: 10EBernhardson) [23:45:46] Aaron|home, do you want me to do a review of https://gerrit.wikimedia.org/r/#/c/101226/ ? [23:46:14] (03Merged) 10jenkins-bot: runbJobs: rm outdated options in comments [core] - 10https://gerrit.wikimedia.org/r/102331 (owner: 10Hashar) [23:46:36] gwicke: if you have time [23:47:52] Aaron|home: k, might get to it tomorrow [23:48:11] (03CR) 10BryanDavis: [C: 04-1] Rewrite i18n support to use new json format (033 comments) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102315 (owner: 10Chad) [23:48:38] (03CR) 10Brian Wolff: [C: 031] "The loop is a bit confusing, could maybe use a comment. Otherwise looks good, also tested and it works" [core] - 10https://gerrit.wikimedia.org/r/102303 (owner: 10Aaron Schulz) [23:49:19] bawolff: a comment where? [23:49:23] Aaron|home: On 102303 - I +1'd instead of +2'd because of Parent's comment. I'm not sure how much you care about his kind of nitpicky comment [23:52:17] Aaron|home: More a comment explaining what is happening (Must check for lowercase version in the searchSet in case a lower case version key was passed but would be capitalized by the repo) [23:52:33] I added a line about that already though [23:52:42] hmm [23:53:47] Aaron|home: I found the code a little dense even with that comment, however its still clear enough that I'd +2 it [23:53:53] TimStarling: maybe you can look at https://gerrit.wikimedia.org/r/#/c/86642/ if you have extra time to mill around, it's a bit old [23:56:50] that one didn't seem like a high priority when I was looking through commits to review, since it had no caller which needed those features [23:56:54] (03CR) 10Awjrichards: [C: 032] Initial conversion of prop=extracts from MobileFrontend [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/102305 (owner: 10MaxSem) [23:57:22] (03PS2) 10Aaron Schulz: Fixed error in LocalRepo::findFiles() [core] - 10https://gerrit.wikimedia.org/r/102303 [23:57:26] bawolff: rebased [23:57:27] (03PS2) 10Brian Wolff: Make SVG language selector use default lang better [core] - 10https://gerrit.wikimedia.org/r/101493 [23:58:28] TimStarling: it would also be nice for the setFileHeaders script instead of spamming HEAD+POST requests for files that already have the headers [23:58:40] but yeah it's hardly urgent, just old [23:58:42] (03CR) 10Brian Wolff: [C: 032] Fixed error in LocalRepo::findFiles() [core] - 10https://gerrit.wikimedia.org/r/102303 (owner: 10Aaron Schulz) [23:59:28] Aaron|home: Any chance you could look at https://gerrit.wikimedia.org/r/#/c/101493/ - its just fixing me being stupid in a previous commit + some parts of ImagePage which weren't validating parameters properly