[00:06:28] (03PS17) 10Mwalker: Update Special:Version licensing for extensions [core] - 10https://gerrit.wikimedia.org/r/65299 [00:07:08] (03CR) 10jenkins-bot: [V: 04-1] Update Special:Version licensing for extensions [core] - 10https://gerrit.wikimedia.org/r/65299 (owner: 10Mwalker) [00:11:42] (03PS2) 10Legoktm: Add SpecialBlockModifyFormFields hook [core] - 10https://gerrit.wikimedia.org/r/101063 [00:12:11] (03CR) 10Legoktm: "Ok, I just added a hook for Special:Block then." [core] - 10https://gerrit.wikimedia.org/r/101063 (owner: 10Legoktm) [00:15:24] (03PS18) 10Mwalker: Update Special:Version licensing for extensions [core] - 10https://gerrit.wikimedia.org/r/65299 [00:16:02] (03CR) 10Mwalker: "@MZ Basically I work on this as I have time. If anyone wants to take it over they're welcome to." [core] - 10https://gerrit.wikimedia.org/r/65299 (owner: 10Mwalker) [00:20:58] (03PS15) 10Mwalker: Further cleanup to Special:Version [core] - 10https://gerrit.wikimedia.org/r/65868 [01:05:47] (03PS2) 10Legoktm: Add BagOStuff::setMulti for batch insertions [core] - 10https://gerrit.wikimedia.org/r/101617 [01:06:19] (03CR) 10Legoktm: "Added implementation for MemcachedPeclBagOStuff too." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/101617 (owner: 10Legoktm) [01:10:43] (03CR) 10Aaron Schulz: Add BagOStuff::setMulti for batch insertions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/101617 (owner: 10Legoktm) [01:11:57] (03CR) 10Legoktm: Add BagOStuff::setMulti for batch insertions (032 comments) [core] - 10https://gerrit.wikimedia.org/r/101617 (owner: 10Legoktm) [01:42:35] (03CR) 10Isarra: "Two things to make sure it gracefully handles:" [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/101672 (owner: 10Jack Phoenix) [01:55:25] (03CR) 10Hoo man: [C: 04-1] "I don't see why you chose the overly complicated switch statement." (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98568 (owner: 10Anomie) [01:56:03] (03CR) 10Hoo man: Correct failure message when account is locked (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98568 (owner: 10Anomie) [01:58:12] (03PS1) 10Aaron Schulz: Added more Setup.php profiling [core] - 10https://gerrit.wikimedia.org/r/101794 [01:59:17] (03CR) 10jenkins-bot: [V: 04-1] Added more Setup.php profiling [core] - 10https://gerrit.wikimedia.org/r/101794 (owner: 10Aaron Schulz) [02:00:37] (03Abandoned) 105xbe: change README [extensions/examples] - 10https://gerrit.wikimedia.org/r/98992 (owner: 105xbe) [02:03:33] (03PS2) 10Aaron Schulz: Added more Setup.php profiling [core] - 10https://gerrit.wikimedia.org/r/101794 [02:03:35] (03CR) 10TTO: [C: 04-1] "Duplicate of I38ed73fbc4044b18c4370ddb1c54bb6ec4389950" [core] - 10https://gerrit.wikimedia.org/r/100379 (owner: 10Gerrit Patch Uploader) [02:07:35] (03PS1) 10Aaron Schulz: Removed deprecated functions and merged ProxyTools into IP file [core] - 10https://gerrit.wikimedia.org/r/101798 [02:13:50] (03PS3) 10Legoktm: Add BagOStuff::setMulti for batch insertions [core] - 10https://gerrit.wikimedia.org/r/101617 [02:15:58] (03CR) 10Legoktm: Add BagOStuff::setMulti for batch insertions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/101617 (owner: 10Legoktm) [02:28:11] (03CR) 10Hoo man: [C: 04-1] "Nitpick..." (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101471 (owner: 10Legoktm) [02:28:36] bleh, too much copy pasting :P [02:28:41] :D [02:30:09] (03PS3) 10Skizzerz: Add ghetto batching to the BlacklistUpdate [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101620 [02:30:11] (03PS2) 10Legoktm: Show log extract on Special:WikiSets [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101471 [02:30:17] hoo: fixed ^ [02:31:28] :) [02:31:33] will test it... [02:36:36] legoktm: You didn't test that, did you? :D [02:36:42] I did [02:36:48] the only weird thing is that it shows up in the fieldset [02:39:23] ah, ok... it doesn't work for creations... intended? [02:39:33] that's a different bug [02:39:38] k [02:39:42] because those are stored as Special:WikiSets/0 [02:39:47] * legoktm finds [02:40:08] Sounds totally sane... legacy code style! [02:40:32] hoo: https://bugzilla.wikimedia.org/show_bug.cgi?id=27031 [02:41:22] -.- [02:41:24] Thanks [02:41:57] (03CR) 10Hoo man: [C: 032] "Works like it should (see also bug 27031)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101471 (owner: 10Legoktm) [02:42:00] (03Merged) 10jenkins-bot: Show log extract on Special:WikiSets [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101471 (owner: 10Legoktm) [02:42:08] woo :D [02:44:30] hoo: Also I started working on a cross-wiki nuke tool [02:44:46] oO how should I imagine that? [02:44:57] gadget or extension? [02:45:49] in the Nuke extension. only works for accounts, it basically uses centralauth to find where the user is attached checks if they have edit count > 0, and launches jobs to delete any pages the user has created [02:46:16] oO [02:46:57] then I'm thinking we can add a checkbox to the lock interface, and say "delete any pages this user has created" if cross-wiki nuke is installed and enabled [02:47:27] mh, difficult community wise... but interesting move [02:47:44] legoktm: Are you working on admin tools for the foundation or in your spare time? [02:48:07] both! [02:48:30] https://bugzilla.wikimedia.org/show_bug.cgi?id=11069 is the bug for it [02:50:23] mh... any plans to work on AbuseFilter? Or even a new "ActionFilter" like extension? ;) [02:52:12] heh [02:52:23] i've been mainly clearing through the SWMT tracking bug [02:52:39] are there any technical issues left for global AF? [02:52:58] oh, the local disabling thingy [02:52:59] blegh [02:53:00] legoktm: Yep, you can't disable them locally... I planned to hack up a special page for tha tlong ago [02:53:03] yeah [02:53:08] but I never came to it [02:53:25] I'll spend some time on that this week [02:53:41] I also started working on some anti-spam stuff: https://www.mediawiki.org/wiki/Extension:StopForumSpam [02:53:57] in my testing on Uncyclopedia in log-only mode, it's pretty effective [02:54:53] legoktm: mh... that's not something we can realistically deploy on WMF though (I guess) [02:55:04] and if we do, that imposes various questions [02:55:10] yeah, I'm not sure [02:55:25] I know that we had something enabled with projecthoneypot, but I need to look into the history of that [02:56:05] https://wikitech.wikimedia.org/wiki/Project_Honeypot [02:57:23] mh... I see privacy problems :/ [02:57:34] Proper global abusefilters would already help a *lot* [02:57:47] ok... proper != our own custom hacky filter language [03:00:36] legoktm: Are you into the auth mechanism of CA? I have stuff to do there :/ [03:00:44] auth mechanism? [03:00:46] https://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/HoneypotIntegration/ [03:00:50] client side stuff, I mean [03:02:06] probably. what needs doing? [03:03:04] legoktm: https://bugzilla.wikimedia.org/show_bug.cgi?id=48389 [03:03:22] make CORS cw-wiki requests work even if the users disabled 3rd party cookies [03:03:29] legoktm tries using anti-spam stuff. it's super effective! [03:03:31] I want to hook into mw.Api [03:04:08] damn... the bit of doc. I already wrote about that is in German -.- [03:04:45] ori-l: tbh, I was pretty surprised when I started looking at the logs and noticed we get at least 4 spambots hitting us every minute, all being stopped by simpleantispam + fancycaptcha [03:05:38] i was just making a pokemon joke, but yeah, it's odd [03:05:53] hoo: so we would use the fact that they're authenticated on enwiki + CA linked to wikidata to authenticate their edit? [03:06:37] legoktm: We already do this... but my plan is to hook into mw.Api so that always includes the centralauthtoken (which you can get from the API) in CORS requests [03:06:43] * that it [03:06:55] that way no gadget/ extension needs to be changed [03:07:00] but we can still support htem all [03:08:16] is there already a framework for hooking into mw.Api? [03:08:22] i'm guessing thats the difficult part. [03:09:09] legoktm: nope... but we could (ab)use mw.hook [03:09:14] hopefully [03:10:52] what about adding it to mw.Api.defaultOptions? [03:13:33] legoktm: mh, that one is static isn't it? [03:13:42] The centralauthtokens usually expire fast etc. [03:13:48] it looks like it [03:13:51] fast = 10s (AFAIR) [03:13:57] o.O [03:14:17] is this the same token as CentralAuthUser::getAuthToken()? [03:15:42] or maybe it's CentralAuthHooks::hasApiToken()? [03:17:58] legoktm: to tired to recall... wait [03:18:33] hasApiToken is is AFAIS [03:19:09] ok [03:20:08] aha [03:20:09] https://en.wikipedia.org/w/api.php?action=tokens&type=centralauth [03:20:33] mh? [03:20:35] > Each token may only be used once, and expires after 10 seconds. [03:21:05] I guess we could easily bump that to 30s for slow connection (Chris might not be a huge fan of this idea, though) [03:21:14] well... 10s might also be enough [03:21:33] but still the problem is getting that all together [03:22:02] why don't you use mw.Api.getToken('centralauth') then whatever else? [03:22:05] and of course we shouldn't send tokens along if mw.Api calls out to 3rd party sites, I guess (which makes this much more complicated) [03:22:19] legoktm: mh? [03:23:05] sorry i gtg, i'll be back in like 15min [03:23:19] not sure I'll still be around then... pretty tired already [03:28:06] I'm not very good at estimating time apparently. [03:28:38] :D [03:28:57] (04:22:02 AM) legoktm: why don't you use mw.Api.getToken('centralauth') then whatever else? [03:29:06] I still don't get the solution you suggest there [03:29:15] so as long as you pass the centralauth token, everything should work right? [03:29:25] legoktm: Yep [03:29:41] so...that shouldn't be that difficult right? :P [03:29:54] heh, I think I wrote that code once upon a time [03:29:57] like, in 2007 [03:29:59] nah, probably 2008 [03:30:24] werdna: yeah, I was going to ask you about that :P. were there any privacy issues about giving out user's IP addresses? [03:30:37] legoktm: context? [03:31:02] werdna: for the project honeypot thing, wasn't it giving out user's IPs? [03:31:35] oh we're talking project honeypot [03:31:42] I don't think that runs anymore [03:32:02] it doesn't, but I was thinking about something similar for stopforumspam.com [03:36:51] hoo: I tried looking through jquery.wikibase.linkitem but couldn't figure out where the actual API call is [03:37:32] (03CR) 10Isarra: [C: 031] "I have no idea how these calls work or anything but someone told me to review this so I'm reviewing it anyway. Yay!" [core] - 10https://gerrit.wikimedia.org/r/95742 (owner: 10Bartosz Dziewoński) [03:37:39] legoktm: hah :) [03:37:53] It uses the page connector [03:38:02] and that uses mw.RepoApi [03:38:22] aha [03:38:23] so mw.RepoApi is probably what you want to look at (in lib/resources/mw.RepoApi [03:38:25] ) [03:38:27] .post [03:39:24] so in that section, why not also send the centralauthtoken? [03:42:26] (03CR) 10PleaseStand: [C: 04-1] "Change looks OK; however, wfGetIP() is still used in various extensions. At least remove usage from what WMF uses: mediawiki/extensions/Se" [core] - 10https://gerrit.wikimedia.org/r/101798 (owner: 10Aaron Schulz) [03:42:46] legoktm: Because Wikibase shouldn't really know about CentralAuth?! [03:42:59] and a general solution is nicer in all cases [03:43:30] yes but ://////// [03:45:06] dinner, bbl [03:45:33] I doubt I could get smth. like that through CR, even if I wanted [03:45:43] bye, cu tomorrow [04:17:25] (03PS9) 10Yurik: Initial implementation of the JSON configuration store. [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 [04:29:56] (03PS1) 10Gnosygnu: v0.12.2.0 [xowa] - 10https://gerrit.wikimedia.org/r/101806 [04:35:17] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/101806 (owner: 10Gnosygnu) [04:38:40] (03PS1) 10Legoktm: Add debug logging for bug 57464 [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/101808 [04:45:50] ori-l: do you have some time to look into (or help me look into) bug 57464? ^ [04:47:16] legoktm: I'd be happy to merge it if you write a better commit message. Just summarize the bug in a sentence and explain why you think those debug statements might shed light on things. [04:47:33] ok [04:50:51] (03PS2) 10Legoktm: Add debug logging for bug 57464 [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/101808 [04:50:59] ori-l: better? ^ [04:51:13] err, wrong commit hash [04:51:40] (03PS3) 10Legoktm: Add debug logging for bug 57464 [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/101808 [04:51:48] there [04:56:08] (03PS4) 10Ori.livneh: Add debug logging for bug 57464 [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/101808 (owner: 10Legoktm) [04:56:34] (03CR) 10Ori.livneh: [C: 032] Add debug logging for bug 57464 [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/101808 (owner: 10Legoktm) [04:56:41] (03Merged) 10jenkins-bot: Add debug logging for bug 57464 [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/101808 (owner: 10Legoktm) [05:06:38] (03CR) 10Springle: "Is the expectation is that de-duplication will reduce overall db write load despite the additional update?" [core] - 10https://gerrit.wikimedia.org/r/101170 (owner: 10Aaron Schulz) [05:08:21] (03PS1) 10Legoktm: Add debug logging for bug 57464 [extensions/MassMessage] (1.23wmf6) - 10https://gerrit.wikimedia.org/r/101810 [05:08:35] (03CR) 10Legoktm: [C: 032] Add debug logging for bug 57464 [extensions/MassMessage] (1.23wmf6) - 10https://gerrit.wikimedia.org/r/101810 (owner: 10Legoktm) [05:08:41] (03Merged) 10jenkins-bot: Add debug logging for bug 57464 [extensions/MassMessage] (1.23wmf6) - 10https://gerrit.wikimedia.org/r/101810 (owner: 10Legoktm) [05:16:13] (03CR) 10Springle: [C: 031] Expand cleanupPreferences.php script to handle unused preferences [core] - 10https://gerrit.wikimedia.org/r/101233 (owner: 10Umherirrender) [05:24:15] (03PS1) 10Legoktm: Updating MassMessage to tip of 1.23wmf6 branch [core] - 10https://gerrit.wikimedia.org/r/101811 [05:24:46] that doesn't seem right... [05:24:53] (03CR) 10jenkins-bot: [V: 04-1] Updating MassMessage to tip of 1.23wmf6 branch [core] - 10https://gerrit.wikimedia.org/r/101811 (owner: 10Legoktm) [05:25:50] legoktm: "assuming you have a 1.22wmf6 branch tracking origin/1.22wmf6, and assuming it's checked out" [05:26:26] (03PS1) 10Legoktm: Updating MassMessage to tip of 1.23wmf6 branch [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/101812 [05:26:34] yeah, I was on that branch, except I have "refs/for/master" hardcoded [05:26:49] (03Abandoned) 10Legoktm: Updating MassMessage to tip of 1.23wmf6 branch [core] - 10https://gerrit.wikimedia.org/r/101811 (owner: 10Legoktm) [05:28:25] (03CR) 10Ori.livneh: [C: 032] Updating MassMessage to tip of 1.23wmf6 branch [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/101812 (owner: 10Legoktm) [05:31:34] (03Merged) 10jenkins-bot: Updating MassMessage to tip of 1.23wmf6 branch [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/101812 (owner: 10Legoktm) [05:46:32] (03PS1) 10Skizzerz: Major rewrite of SecurePasswords [extensions/SecurePasswords] - 10https://gerrit.wikimedia.org/r/101813 [05:50:51] (03PS2) 10Skizzerz: Major rewrite of SecurePasswords [extensions/SecurePasswords] - 10https://gerrit.wikimedia.org/r/101813 [05:53:10] hello yurik [05:53:30] hi diwanship ) [05:54:54] ori-l: so I see the fix for JobQueueRedis, gonna see if JobQueueDB also has it too [05:55:48] yurik i made some changes to the tutotrial pls review http://www.codecademy.com/courses/web-intermediate-en-BLea4/0/9 [05:56:39] if the text parameter is still not clear pls tell me what should i do [05:57:38] the html code is showing at d top and parsed one below that [05:57:58] (03CR) 10Skizzerz: [C: 032 V: 032] " > in gerrit" [extensions/SecurePasswords] - 10https://gerrit.wikimedia.org/r/101813 (owner: 10Skizzerz) [06:08:28] yurik does it still need some changs? [06:08:35] oh yes :) [06:08:50] i won't be easy ;) [06:09:01] you have no idea what you signed up to [06:09:51] ori-l, Gloria: https://bugzilla.wikimedia.org/show_bug.cgi?id=58524 [06:10:30] diwanship, https://etherpad.wikimedia.org/p/codeacademy-diwanship [06:12:48] yurik :P etherpad is very good option [06:13:00] good, please save the link to it [06:13:13] although don't forget that its not very permanent [06:13:56] legoktm: Fun bug. [06:14:25] I have a rather simple workaround :) [06:14:45] Not using makeTitleSafe? [06:16:06] no [06:16:07] one sec [06:20:14] (03CR) 10Tim Starling: [C: 04-1] "I mean the fact that they start with a captial letter, not just the fact that they have underscores in their names. Like DiffEngine.h and " [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/99541 (owner: 10MaxSem) [06:20:21] (03PS1) 10Legoktm: Store title as a job parameter [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/101814 [06:20:28] (03CR) 10jenkins-bot: [V: 04-1] Store title as a job parameter [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/101814 (owner: 10Legoktm) [06:21:54] (03CR) 10Tim Starling: "I mean, just call the class InlineDiff or something. Put all the classes in a Wikidiff namespace if you think it's going to conflict with " [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/99541 (owner: 10MaxSem) [06:23:33] (03PS2) 10Legoktm: Store title as a job parameter [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/101814 [06:23:45] Gloria: there. ^ :D [06:25:35] legoktm: Nice. :-) [06:26:48] (03CR) 10Siebrand: [C: 04-1] add-project-link (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 (owner: 10Dan-nl) [06:32:51] diwanship, i think i'm more or less done with the https://etherpad.wikimedia.org/p/codeacademy-diwanship [06:33:08] feel free to write there too of course [06:33:21] (03PS1) 10Aaron Schulz: Removed deprecated job ID cruft [core] - 10https://gerrit.wikimedia.org/r/101815 [06:34:01] ok yurik tell me one thing that the text parameter can only have the {{pagename}} value or it can have other values too [06:36:36] (03CR) 10jenkins-bot: [V: 04-1] Removed deprecated job ID cruft [core] - 10https://gerrit.wikimedia.org/r/101815 (owner: 10Aaron Schulz) [06:36:41] i searched the all wiki pages related to that which says text is a text to parse or wikitext with {{pagename}} value [06:44:41] (03PS2) 10Aaron Schulz: Removed deprecated job ID cruft [core] - 10https://gerrit.wikimedia.org/r/101815 [06:50:49] (03CR) 10Aaron Schulz: "Yeah I grepped those and got no results since the "|" was apparently interpreted literally in GitBash..." [core] - 10https://gerrit.wikimedia.org/r/101798 (owner: 10Aaron Schulz) [06:54:06] (03PS2) 10Aaron Schulz: Removed deprecated functions and merged ProxyTools into IP file [core] - 10https://gerrit.wikimedia.org/r/101798 [06:56:29] diwanship, sorry, missed your text, one sec [06:57:47] ya sure [06:58:35] diwanship, text parameter is the wiki markup - it can be anything at all [06:58:58] diwanship, any content, just like we write wikipedia articles - same markup [06:59:35] the {{xx}} is part of that markup [07:00:01] it means - take a page named Template:xx, and insert its content here [07:01:10] please take a look at the wiki markup guide at https://en.wikipedia.org/wiki/Help:Wiki_markup [07:01:14] diwanship, ^ [07:01:16] so the text can have a simple text like we write for wiki articles [07:01:26] exactly [07:01:52] that's the whole point of action=parse -- to convert wiki markup into HTML [07:04:00] ok i was getting it all wrong [07:04:19] ei! better figure it out earlier than later ;) [07:05:43] thanks for the instructions :) [07:05:59] i think that's why you had problems with the side text - you need to understand it very well to explain ... there is an old russian joke: "my students are idiots" said professor to his friend. I explained it to them once - they didn't get it. Explained it second time - didn't get it. Third time - even I got it - they still don't get it [07:06:54] hehehehehe [07:07:05] yes that's y i was having problem with text :P [07:08:00] so yes, don't start them with the template expansion (although that would be a good 2nd or 3rd example - show them something simple like making things bold, etc [07:10:40] ok [07:11:19] how many examples i should implement? [07:14:57] I have submitted a patch. But there are some issues? So should I submit again? Read through the link before replying. https://gerrit.wikimedia.org/r/#/c/94598/ [07:15:01] Thanks in advance [07:16:29] arav93, you have merge conflicts? [07:16:47] What is that? [07:17:05] This is my first patch, so I don't know what it means. [07:17:20] wow, that's a very ambitious first patch ;) [07:18:09] if you change code and submit a patch, and in the mean time someone changes some of the same code as you and also submits (or has submitted before you), and it is merged into the main code, you have a merge conflict [07:18:27] because two of you have changed the same code [07:18:52] but their change has been merged with master version [07:19:06] and now your code cannot be merged with master automatically [07:19:19] please google resolving merge conflicts in git [07:19:42] I don't think there are any merge conflicts. [07:19:56] how do you know that? [07:20:41] Well, it hasn't been merged because I apparently changed some unneccessary variables as well. [07:21:04] First it has a negative review, now it has been removed. [07:21:13] So, I dunno if it's right or wrong. [07:21:49] arav93, that's not the point - you keep updating your patch - you are still working from the same original point in time. [07:22:23] oh [07:22:25] there was "master" at one point in time - you took it, created a branch, and changed it somehow. That was your patchset #1 [07:22:51] than you fixed some issues that people have raised with your code - that was ps #2 - you basically replaced #1 with #2 [07:23:07] or maybe you didn't fix their concerns [07:23:17] but still changed something in the patch and submitted it [07:23:32] -1 automatically goes away when replace one patch with another [07:23:55] but all this time other people have been worknig on the master [07:24:22] and at some point your changes began to conflict with theirs [07:24:53] but until your changes are merged with master, you have to keep "rebasing" your changes [07:25:13] so that that "starting point" that i spoke of is no longer the old one, but the current one [07:25:32] rebasing means - base my patch not from the old version of master, but from the new version of master [07:26:08] please read up on git rebasing - we have tons of documentation on how to do all that, and with gerrit [07:26:22] yes, its not very simple - but neither is the patch thatchanges all our settings files ;) [07:28:15] yurik: I'm a new contributor. Would the bitesized bugs on openhatch be a good place to start? [07:28:40] dshgna, small bugs are always better to start with, but i'm not sure what openhatch you refer to. link? [07:29:34] yurik: https://openhatch.org/search/?q=&project=MediaWiki [07:36:28] dshgna, very cool site! thanks! didn't know about it. [07:36:47] yes, taking a bug from that list, the smaller the better, would be an awesome place to start [07:37:09] because your biggest concern would be to learn the process, not to actually solve it [07:37:25] once that's behind you, you can do more complex stuff [07:37:41] although someone needs to solve the easy bugs too :) [07:38:27] arav93, btw, hope i explained it sufficiently, bug us if you run into bigger issues [07:38:44] hmm... that didn't come out right :) [07:38:57] bigger is not needed there [07:39:07] was still thinking of the bug size :) [08:02:07] (03CR) 10Siebrand: [C: 032] "Thanks." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/101786 (owner: 10Shirayuki) [08:02:34] (03Merged) 10jenkins-bot: i18n: add full-stop [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/101786 (owner: 10Shirayuki) [08:02:51] (03CR) 10Siebrand: [C: 032] "Thanks." [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/101785 (owner: 10Shirayuki) [08:03:45] (03CR) 10Siebrand: [C: 032] i18n: make "potentially" lowercase [core] - 10https://gerrit.wikimedia.org/r/101658 (owner: 10Shirayuki) [08:04:16] (03CR) 10Siebrand: [C: 032] i18n: make "wiki" lowercase [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/101654 (owner: 10Shirayuki) [08:04:38] (03CR) 10Siebrand: [C: 032] i18n: replace "wiki" by "project" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/101652 (owner: 10Shirayuki) [08:04:42] (03Merged) 10jenkins-bot: i18n: make "wiki" lowercase [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/101654 (owner: 10Shirayuki) [08:04:56] (03Merged) 10jenkins-bot: i18n: replace "wiki" by "project" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/101652 (owner: 10Shirayuki) [08:05:05] (03CR) 10Siebrand: [C: 032 V: 032] i18n: capitalize "Bayesian" [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/101645 (owner: 10Shirayuki) [08:06:55] (03Merged) 10jenkins-bot: i18n: make "potentially" lowercase [core] - 10https://gerrit.wikimedia.org/r/101658 (owner: 10Shirayuki) [08:07:06] (03CR) 10Siebrand: [C: 032] add explicit "escaped()" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100972 (owner: 10Shirayuki) [08:08:05] (03Merged) 10jenkins-bot: add explicit "escaped()" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100972 (owner: 10Shirayuki) [08:08:53] dshgna and arav93, btw, when you develop, you will need a running wiki on your machine -- the easiest is to get it via Ori's vagrant [08:09:11] \o/ Shirayuki [08:11:06] dshgna, arav93 : https://www.mediawiki.org/wiki/User:Yurik/Installing_MW_vagrant_box_under_Windows_7 [08:11:13] if you have windows [08:27:17] (03PS2) 10Shirayuki: i18n: consistency tweaks [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/101785 [08:29:46] yurik: I did make a running installation from the instructions on http://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker [08:30:28] dshgna, bleh, that page is in a bad need of updating [08:30:42] we have vagrant now, which greatly simplifies all those steps [08:30:44] :( [08:30:57] need to bug quim about making a project for that [08:31:24] but if you got it running, its all good :)\ [08:31:37] yurik: I felt so cos I got stuck so much :(. wud thr be a better page as a starter? Yep, it runs fine [08:32:14] https://www.mediawiki.org/wiki/Vagrant [08:32:49] its a bit out of date [08:34:14] okie :) would it be ok if I use my old installation or wud be using vagrant be better? [08:46:29] dshgna, well, if everything works for you, i guess you can keep it, or you can have them in parallel - up to you :) [08:46:45] i prefer vagrant because its already properly pre-configured [08:47:00] yurik: Set up vagrant too. thanks for the link:) [08:47:17] and you can easily do things like add debugging, add various extensions, etc [08:47:51] we really ought to switch to the vagrant way [08:47:55] of doing things [08:48:04] makes everyone's development environment the same [08:48:26] yurik: it was much more faster than doing it manually :) [08:48:51] of course it is :) [08:54:20] (03PS10) 10Yurik: Initial implementation of the JSON configuration store. [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 [09:07:17] (03CR) 10Daniel Kinzler: "@aude: that's a bug in Special:Import: it will say "all revisions previously imported" when no revisions where imported. It just assumes t" [core] - 10https://gerrit.wikimedia.org/r/100563 (owner: 10Daniel Kinzler) [09:36:37] (03CR) 10Nemo bis: "Bug 15907 had a summary covering this, but was even too generic. Filing bugs about specific situations to cover, like this, would indeed b" [core] - 10https://gerrit.wikimedia.org/r/100563 (owner: 10Daniel Kinzler) [09:51:31] (03CR) 10Matthias Mullie: [C: 032] Only require one click to expand moderated topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101441 (owner: 10EBernhardson) [09:51:36] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Trying to review a change without even looking at a potential fix at https://gerrit.wikimedia.org/r/101446 ? Not nice of you to do." [core] - 10https://gerrit.wikimedia.org/r/101603 (owner: 10Danny B.) [09:51:39] (03Merged) 10jenkins-bot: Only require one click to expand moderated topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101441 (owner: 10EBernhardson) [09:51:41] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Trying to review a change without even looking at a potential fix at https://gerrit.wikimedia.org/r/101446 ? Not nice of you to do." [core] - 10https://gerrit.wikimedia.org/r/101604 (owner: 10Danny B.) [09:52:26] (03CR) 10Matthias Mullie: [C: 032] Add Talk icon for RTL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101621 (owner: 10Amire80) [09:52:38] (03Merged) 10jenkins-bot: Add Talk icon for RTL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101621 (owner: 10Amire80) [09:57:19] (03CR) 10Matthias Mullie: [C: 032] Discussion toggle icons for RTL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101622 (owner: 10Amire80) [09:57:24] (03CR) 10Aude: "ok, now it makes more sense. i understood it as all revisions of Q138 had been imported." [core] - 10https://gerrit.wikimedia.org/r/100563 (owner: 10Daniel Kinzler) [09:57:29] (03Merged) 10jenkins-bot: Discussion toggle icons for RTL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101622 (owner: 10Amire80) [10:03:30] (03PS1) 10Matthias Mullie: Remove ul margin around ul.topic-collapser [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101824 [10:04:40] (03CR) 10Matthias Mullie: [C: 032] Permalink RTL icon [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101638 (owner: 10Amire80) [10:04:49] (03Merged) 10jenkins-bot: Permalink RTL icon [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101638 (owner: 10Amire80) [10:05:29] (03CR) 10Matthias Mullie: [C: 032] "It is not currently used, but may be in the future. Good to have rtl/ltr variants already!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101639 (owner: 10Amire80) [10:05:36] yurik: is there any best ide to use for mediawiki dev? :) [10:05:39] (03Merged) 10jenkins-bot: RTL icon for search [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101639 (owner: 10Amire80) [10:06:03] dshgna, hard question - i personally prefer phpstorm, but that's not free [10:06:44] dshgna, although you could request an open source license http://www.jetbrains.com/phpstorm/buy/ [10:07:01] I think we already have them [10:07:02] eclypse is clunky imo [10:07:11] you just need to ask Reedy about phpstorm [10:07:35] (03CR) 10Matthias Mullie: [C: 032] Add GENDER and localized number to flow-topic-comments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98769 (owner: 10Amire80) [10:07:45] (03Merged) 10jenkins-bot: Add GENDER and localized number to flow-topic-comments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98769 (owner: 10Amire80) [10:07:49] p858snake|l, well, this is a bit complex - i also have that license - the question is if we are allowed to give them to the community - its a legal issue :( [10:09:19] btw, we also have licenses for webstorm (javascript), rubymine, and pycharm (python) [10:09:30] (all from jetbrains) [10:09:54] * yurik doesn't like legal issues [10:10:35] yurik: oh :( and I am just so new here. I'll just stick to eclipse for now I guess :) [10:11:03] dshgna, i think you could apply for it - shouldn't take long [10:11:31] but yes, sadly i don't know any great php ide :( [10:11:43] i heard people use notepad... [10:11:51] * yurik is done trolling [10:13:07] yurik: :) [10:20:14] (03CR) 10Daniel Kinzler: "@aude: do you want to block this change on fixing Special:Import's error handling? I had a look and tried to find a good way to fix this, " [core] - 10https://gerrit.wikimedia.org/r/100563 (owner: 10Daniel Kinzler) [10:29:12] yurick: I'm just a bit confused on finding a bug to start work on. In the 'How to be a M/W Hacker' page it says "We used to accept patches attached to Bugzilla reports but such practice is currently discouraged.". But the stuff in openhatch and annoying little bugs both link to bugzilla. Am I missing something here? Really sorry :( [10:32:03] (03CR) 10Aude: "at least reword the message then." [core] - 10https://gerrit.wikimedia.org/r/100563 (owner: 10Daniel Kinzler) [10:37:59] (03CR) 10Phe: "The code is ok, but isn't doubleclick rather than simpleclick boring on some platform ? I'm thinking about mac." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101679 (owner: 10Tpt) [10:44:19] yurik: I'm just a bit confused on finding a bug to start work on. In the 'How to be a M/W Hacker' page it says "We used to accept patches attached to Bugzilla reports but such practice is currently discouraged.". But the stuff in openhatch and annoying little bugs both link to bugzilla. Am I missing something here? Really sorry :( [10:44:47] dshgna, you need to submit bugs to gerrit [10:44:54] i mean - patches [10:45:14] and in the comment of the patch, make sure it starts with (bug NNNN) ..... [10:45:31] this way, that bug will link back to bugzilla, which will automatically be updated by a bot [10:46:17] yurik: ah I get it now, thanks:) [11:02:18] (03PS3) 10Dan-nl: add-project-link [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 [11:03:15] (03CR) 10Dan-nl: "addressing siebrand’s inline comment in ps2" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 (owner: 10Dan-nl) [11:05:24] (03CR) 10Danny B.: [C: 031] "That's not a fix. Problems are still there." [core] - 10https://gerrit.wikimedia.org/r/101603 (owner: 10Danny B.) [11:05:51] (03CR) 10Danny B.: [C: 031] "That's not a fix. Problems are still there." [core] - 10https://gerrit.wikimedia.org/r/101604 (owner: 10Danny B.) [11:19:32] dshgna: if you find gerrit too complicated to get started with, you can use the patch uploader https://tools.wmflabs.org/gerrit-patch-uploader/ [11:20:13] for that you only need a developer account and the ability to create a diff file [11:21:53] wow, we should really update some of that developer documentation again. gerrit has changed a lot in the past year... [11:22:46] thedj: Hi :) [11:23:16] got a minute [11:23:18] ? [11:23:36] if the minute doesn't end up taking my entire lunchbrak, then yeah :D [11:24:33] thedj: :D I just want to hear that you agree with Graham and /me that we should have proper keyboard navigation support in MobileFrontend [11:24:49] cause the mobile team seemed a little unconvinced whether we really need that [11:25:29] depends... we definetly should have accessibility support, and that includes some keyhandlers for buttons etc. [11:25:55] thedj: Exactly... I just want it for the sections toggle thing [11:26:40] (03CR) 10Amire80: Better GENDER support in moderation.js (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 (owner: 10Amire80) [11:26:40] For me that case is simple. That thing should be navigable with voiceover for iOS. [11:27:03] (03PS8) 10Amire80: Better GENDER support in moderation.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 [11:27:28] if it isn't explaining to voiceover users that the section is collapsed and could be uncollapsed, then that should be fixed. [11:28:21] thedj: I have ZERO experience with mobile screen readers (and only a crappy old android), so I didn't test that (only did regression test of my patches so far on mobile platforms) [11:28:58] For now I just want it to work on desktop set ups properly, and that includes proper keyboard navigation, also for non-screen reader users IMO [11:31:19] thedj: I have to leave in 5 minutes... so I haz your support on adding a few keyhandlers to the section toggle stuff? [11:31:43] That's nothing more than maybe 10-15 loc and I have Qunit's for that [11:31:54] * Qunits [11:32:30] yup. and some more improvements can definetly be made there from a quick iOS voiceover test [11:32:59] I really should get myself into mobile screen readers someday [11:33:00] preferably, we do something more sustainable. [11:33:17] like a jquery extension to make these improvements a bit easier. [11:33:22] Sustainable would be to force devs. to test stuff in screen readers :P [11:33:24] mobile team is still changing stuff a lot. [11:33:42] That's why I wrote Qunits for all the aria stuff I yet added [11:33:42] if they need to refactor code and reapply this stuff every week, then that is not sustainble :D [11:34:13] hoo: yeah, they think it's burden. I say it should be worth it :D [11:34:13] heh [11:34:21] :) [11:34:43] Away for now ;) [11:34:51] Thanks, thedj :) [11:34:51] bye [11:38:25] (03CR) 10Shirayuki: "My suggestion adding comments for grep to *JavaScript* code has ever been rejected." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 (owner: 10Amire80) [11:56:01] (03CR) 10Bartosz Dziewoński: "I responded on the bug, where you didn't reply to me either." [core] - 10https://gerrit.wikimedia.org/r/101604 (owner: 10Danny B.) [11:56:08] (03CR) 10Bartosz Dziewoński: "I responded on the bug, where you didn't reply to me either." [core] - 10https://gerrit.wikimedia.org/r/101603 (owner: 10Danny B.) [11:58:28] (03CR) 10Bartosz Dziewoński: [C: 031] "(For the record, I don't like the original approach either.)" [core] - 10https://gerrit.wikimedia.org/r/101063 (owner: 10Legoktm) [12:14:38] (03CR) 10Bartosz Dziewoński: Add legend to Special:RecentChanges and Special:Watchlist (033 comments) [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [12:15:23] (03PS1) 10Bartosz Dziewoński: SpecialRecentChanges::makeLegend: Mention usage in Watchlist [core] - 10https://gerrit.wikimedia.org/r/101829 [12:17:02] (03Abandoned) 10Bartosz Dziewoński: Remove unused variable and deprecated parameters [core] - 10https://gerrit.wikimedia.org/r/100379 (owner: 10Gerrit Patch Uploader) [12:25:55] (03CR) 10Bartosz Dziewoński: [C: 032] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/100378 (owner: 10Gerrit Patch Uploader) [12:29:03] (03Merged) 10jenkins-bot: Remove unused variable and deprecated parameters [core] - 10https://gerrit.wikimedia.org/r/100378 (owner: 10Gerrit Patch Uploader) [12:32:16] (03CR) 10Bartosz Dziewoński: mw.loader.store: More fault tolerance (032 comments) [core] - 10https://gerrit.wikimedia.org/r/100930 (owner: 10Bartosz Dziewoński) [12:32:33] (03PS2) 10Bartosz Dziewoński: mw.loader.store: More fault tolerance [core] - 10https://gerrit.wikimedia.org/r/100930 [12:33:10] (03CR) 10jenkins-bot: [V: 04-1] mw.loader.store: More fault tolerance [core] - 10https://gerrit.wikimedia.org/r/100930 (owner: 10Bartosz Dziewoński) [12:33:51] (03CR) 10Bartosz Dziewoński: "Platonides, I think you forgot to finish that sentence :)" [core] - 10https://gerrit.wikimedia.org/r/53529 (owner: 10devunt) [12:52:57] (03PS1) 10Shirayuki: i18n: remove full-stop from checkbox label [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/101831 [12:54:17] (03PS3) 10PleaseStand: Removed deprecated functions and merged ProxyTools into IP file [core] - 10https://gerrit.wikimedia.org/r/101798 (owner: 10Aaron Schulz) [12:55:13] (03CR) 10Parent5446: [C: 031] Add BagOStuff::setMulti for batch insertions [core] - 10https://gerrit.wikimedia.org/r/101617 (owner: 10Legoktm) [12:56:02] (03CR) 10Parent5446: [C: 032] Add SpecialBlockModifyFormFields hook [core] - 10https://gerrit.wikimedia.org/r/101063 (owner: 10Legoktm) [12:58:19] (03CR) 10Bartosz Dziewoński: "I played with it, removed three lines of hacks from jqueryMsg tests and they pass now. Magic!" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [12:58:58] (03PS5) 10Bartosz Dziewoński: JSDuck-ify /resources/mediawiki.language/* [core] - 10https://gerrit.wikimedia.org/r/98380 [12:59:38] (03Merged) 10jenkins-bot: Add SpecialBlockModifyFormFields hook [core] - 10https://gerrit.wikimedia.org/r/101063 (owner: 10Legoktm) [13:01:37] (03CR) 10Bartosz Dziewoński: "Hmpf." [core] - 10https://gerrit.wikimedia.org/r/100930 (owner: 10Bartosz Dziewoński) [13:02:20] (03CR) 10PleaseStand: [C: 031] Removed deprecated functions and merged ProxyTools into GlobalFunctions [core] - 10https://gerrit.wikimedia.org/r/101798 (owner: 10Aaron Schulz) [13:02:35] (03PS1) 10Nemo bis: Typofix and dummy README [tools/grabbers] - 10https://gerrit.wikimedia.org/r/101832 [13:05:18] (03PS3) 10Bartosz Dziewoński: mw.loader.store: More fault tolerance [core] - 10https://gerrit.wikimedia.org/r/100930 [13:05:57] (03PS1) 10Dan-nl: translatewiki-issues [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101834 [13:14:09] (03CR) 10Nemo bis: [C: 031] "Thanks" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101834 (owner: 10Dan-nl) [13:18:12] (03CR) 10TMg: [C: 031] mw.loader.store: More fault tolerance [core] - 10https://gerrit.wikimedia.org/r/100930 (owner: 10Bartosz Dziewoński) [13:33:55] (03CR) 10Siebrand: [C: 032] translatewiki-issues [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101834 (owner: 10Dan-nl) [13:34:36] (03Merged) 10jenkins-bot: translatewiki-issues [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101834 (owner: 10Dan-nl) [13:36:35] (03CR) 10Siebrand: [C: 032 V: 032] i18n: remove full-stop from checkbox label [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/101831 (owner: 10Shirayuki) [13:37:00] (03CR) 10Siebrand: [C: 032 V: 032] i18n: consistency tweaks [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/101785 (owner: 10Shirayuki) [13:55:20] (03CR) 10Siebrand: [C: 04-1] Better GENDER support in moderation.js (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 (owner: 10Amire80) [13:55:41] (03PS1) 10Manybubbles: Do not queue empty other index jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101841 [14:01:38] (03CR) 10Siebrand: [C: 04-1] add-project-link (032 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 (owner: 10Dan-nl) [14:34:49] (03CR) 10Nikerabbit: [C: 04-1] "(Assuming) that this will delete many preferences which have been forgotten to be declared by extensions (and also all userjs-* keys?) by " [core] - 10https://gerrit.wikimedia.org/r/101233 (owner: 10Umherirrender) [14:35:05] (03CR) 10Siebrand: Initial implementation of the JSON configuration store. (031 comment) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [14:41:49] (03PS1) 10Dan-nl: some group and right messages are missing [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101861 [14:46:27] (03CR) 10Anomie: "> I don't see why you chose the overly complicated switch statement." (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98568 (owner: 10Anomie) [14:47:35] df [14:47:39] gah [14:52:45] (03CR) 10Amire80: Better GENDER support in moderation.js (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 (owner: 10Amire80) [14:53:42] (03PS9) 10Amire80: Better GENDER support in moderation.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 [14:59:11] (03PS2) 10Dan-nl: some group and right messages are missing [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101861 [14:59:46] (03CR) 10Dan-nl: "added i18n documentation for the new messages." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101861 (owner: 10Dan-nl) [15:14:43] (03CR) 10Gergő Tisza: [C: 04-1] "As discussed elsewhere, this should be improved so that the event handler does not rely on "global" variables." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/101029 (owner: 10Inchikutty) [15:18:03] (03CR) 10Hashar: [C: 031] "Good for me although i am not voting for the i18n messages themselves." (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101861 (owner: 10Dan-nl) [15:18:49] sorry hashar, don't know how i managed to add you to that commit [15:19:21] a few other people got automatically added as well … hmm [15:19:31] dan-nl: it is fine :-] [15:19:35] probably added myself to it anyway [15:28:52] (03Abandoned) 10Tpt: (bug 37764) Allow imageInfo API query to give XML DJVU metadata [core] - 10https://gerrit.wikimedia.org/r/24660 (owner: 10Tpt) [15:33:49] (03CR) 10Tpt: [C: 032] "Reviewed by Aarti" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101482 (owner: 10Tpt) [15:34:35] (03Merged) 10jenkins-bot: Remove dead code in zoom system [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101482 (owner: 10Tpt) [15:36:06] hey yurik [15:38:06] (03CR) 10Tpt: "It works fine with a MacBook trackpad with Mac OS 10.9 using latest Firefox, Chrome and Safari." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101679 (owner: 10Tpt) [15:44:25] (03CR) 10Bartosz Dziewoński: "I'm not sure if the renaming is worth breaking backwards-compatibility. I'd also prefer to do it in a separate patch (if at all), this has" [core] - 10https://gerrit.wikimedia.org/r/98589 (owner: 10Bartosz Dziewoński) [15:45:06] (03PS1) 10Hoo man: Add mw.html to Scribunto [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 [15:45:13] (03CR) 10Anomie: "Why not just merge this with I9329573d?" [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/101626 (owner: 10Legoktm) [15:45:37] (03CR) 10jenkins-bot: [V: 04-1] Add mw.html to Scribunto [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man) [15:45:49] (03PS1) 10BryanDavis: Update look and feel [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101875 [15:46:12] (03CR) 10jenkins-bot: [V: 04-1] Update look and feel [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101875 (owner: 10BryanDavis) [15:47:27] (03PS2) 10BryanDavis: Update look and feel [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101875 [15:48:42] (03PS3) 10BryanDavis: Update look and feel [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101875 [15:48:45] (03PS2) 10Hoo man: Add mw.html to Scribunto [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 [15:49:18] (03PS1) 10Jack Phoenix: Fix HTML parsing in the 'mp-welcome-needed-points' i18n msg in UserWelcome. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/101877 [15:49:50] (03CR) 10Jack Phoenix: [C: 032 V: 032] Fix HTML parsing in the 'mp-welcome-needed-points' i18n msg in UserWelcome. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/101877 (owner: 10Jack Phoenix) [15:50:11] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101861 (owner: 10Dan-nl) [15:51:03] (03PS1) 10BryanDavis: Wikimania 2014 content [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101878 [15:51:49] (03Abandoned) 10BryanDavis: Fix i18n template errors [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101442 (owner: 10BryanDavis) [15:52:41] (03PS1) 10BryanDavis: Allow empty values for Form::expectInArray [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101879 [15:57:29] (03CR) 10BryanDavis: [C: 032] some group and right messages are missing [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101861 (owner: 10Dan-nl) [15:57:39] (03Merged) 10jenkins-bot: some group and right messages are missing [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101861 (owner: 10Dan-nl) [16:06:33] (03CR) 10Anomie: "If the extension is enabled but $wgGlobalCssJsConfig isn't customized, what happens when it tries to load the global stuff from the "false" (034 comments) [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 (owner: 10Legoktm) [16:19:46] (03PS1) 10Jack Phoenix: Applying the Monaco-only fix to the clearfix CSS to the other three places (in addition to UserProfile/UserProfile.css) where said class is defined. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/101885 [16:21:13] (03CR) 10Jack Phoenix: [C: 032 V: 032] Applying the Monaco-only fix to the clearfix CSS to the other three places (in addition to UserProfile/UserProfile.css) where said class is [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/101885 (owner: 10Jack Phoenix) [16:24:56] A Google Code-in student about the MediaWiki logo: "Your current logo doesn't make any sense and its colors too bright which make it look less elegant.All logos that I like have a little simple look. The logo of Media Wiki has a flower which logo doesn't make any sense. " [16:25:08] Well, thanks, I guess? [16:26:17] lol [16:45:56] hi andre__ [16:46:03] hi mayankmadan [16:46:50] andre__: any new tasks? [16:49:14] mayankmadan, if I see it correctly there are currently 37 GCI tasks to choose from [16:49:35] i meant any quick documentation task [16:49:38] mayankmadan, and we're trying to get more developers providing more tasks, but you can also try to reach out :) [16:51:09] mayankmadan: https://bugzilla.wikimedia.org/showdependencytree.cgi?id=1&hide_resolved=1 and https://bugzilla.wikimedia.org/buglist.cgi?resolution=---&component=Documentation&product=MediaWiki list some open documentation tasks, but I cannot judge which of them are "quick" [16:53:24] (03CR) 10MaxSem: [C: 032] Remove useless $out parameter from SkinTemplate::prepareQuickTemplate() [core] - 10https://gerrit.wikimedia.org/r/101656 (owner: 10IAlex) [16:53:34] (03PS4) 10Dan-nl: add-project-link [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 [16:55:00] (03CR) 10Dan-nl: "addressed siebrand’s inline comments in ps 3" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 (owner: 10Dan-nl) [16:57:28] (03Merged) 10jenkins-bot: Remove useless $out parameter from SkinTemplate::prepareQuickTemplate() [core] - 10https://gerrit.wikimedia.org/r/101656 (owner: 10IAlex) [16:58:53] (03Abandoned) 10Aarcos: Just testing the workflow. [core] - 10https://gerrit.wikimedia.org/r/96194 (owner: 10Aarcos) [17:02:25] (03CR) 10Anomie: [C: 04-1] "If it's going to be in mw.html then it should probably not have to be required. And if it's going to have to be required (like bit32 or li" (0316 comments) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man) [17:03:03] (03CR) 10Chad: Change betafeatures text (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101500 (owner: 10Manybubbles) [17:06:54] (03CR) 10Chad: Do not queue empty other index jobs (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101841 (owner: 10Manybubbles) [17:06:58] (03CR) 10Manybubbles: [C: 04-1] "Mail sent to marketing folks. We'll delay merging this until we hear back from them." (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101500 (owner: 10Manybubbles) [17:09:24] (03CR) 10MaxSem: "Heh, I thought I used the existing convention - after all, you put Wikidiff2 class into wikidiff2.(h|cpp) ;)" [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/99541 (owner: 10MaxSem) [17:09:34] (03CR) 10Manybubbles: "One moment." (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101841 (owner: 10Manybubbles) [17:12:33] (03PS3) 10Tpt: Activate zoom on mouse wheel only when the user have double-clicked [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101679 [17:12:38] (03CR) 10jenkins-bot: [V: 04-1] Activate zoom on mouse wheel only when the user have double-clicked [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101679 (owner: 10Tpt) [17:12:59] (03PS2) 10Manybubbles: Do not queue empty other index jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101841 [17:13:28] (03CR) 10Tpt: "Use simple click" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101679 (owner: 10Tpt) [17:13:51] (03PS4) 10Tpt: Activate zoom on mouse wheel only when the user have clicked [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101679 [17:14:03] (03CR) 10Tpt: "Rebase" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101679 (owner: 10Tpt) [17:14:06] (03CR) 10Chad: [C: 032] Do not queue empty other index jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101841 (owner: 10Manybubbles) [17:14:11] (03Merged) 10jenkins-bot: Do not queue empty other index jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101841 (owner: 10Manybubbles) [17:15:22] hi [17:15:28] anybody familiar with editors for Mac OS X for directly interfacing with MediaWiki? [17:15:34] without having to paste and preview in a web browser constantly [17:16:02] I am using the TextMate MediaWiki bundle, but it still requires paste/preview [17:16:20] (03CR) 10Phe: [C: 031] Activate zoom on mouse wheel only when the user have clicked [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101679 (owner: 10Tpt) [17:19:19] (03PS1) 10Manybubbles: update cirrus to master [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/101891 [17:20:42] (03CR) 10Tpt: [C: 032] "Reviewed by Phe" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101679 (owner: 10Tpt) [17:20:53] (03Merged) 10jenkins-bot: Activate zoom on mouse wheel only when the user have clicked [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101679 (owner: 10Tpt) [17:21:38] (03PS1) 10Manybubbles: update cirrus to master [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/101892 [17:21:50] (03CR) 10Chad: [C: 032] update cirrus to master [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/101891 (owner: 10Manybubbles) [17:22:06] (03CR) 10Chad: [C: 032] update cirrus to master [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/101892 (owner: 10Manybubbles) [17:22:08] (03PS1) 10Katie Horn: Removing mw-config dir [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/101893 [17:22:35] thank you ^d [17:23:24] <^d> yw [17:24:02] (03CR) 10Chad: "Won't this create merge conflicts if you pull from master? Maybe easier to just deny access to it?" [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/101893 (owner: 10Katie Horn) [17:25:48] (03CR) 10Nuria: [C: 031] Log event when new editors reach edit milestone (031 comment) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/98079 (owner: 10Ori.livneh) [17:25:52] (03CR) 10Katie Horn: "Hmm... I'm not sure that merge conflicts would be an entirely bad thing. We never start over from scratch..." [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/101893 (owner: 10Katie Horn) [17:26:40] (03CR) 10Ori.livneh: Log event when new editors reach edit milestone (031 comment) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/98079 (owner: 10Ori.livneh) [17:26:41] (03CR) 10jenkins-bot: [V: 04-1] Removing mw-config dir [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/101893 (owner: 10Katie Horn) [17:26:50] (03Merged) 10jenkins-bot: update cirrus to master [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/101891 (owner: 10Manybubbles) [17:27:39] (03CR) 10Katie Horn: "What if I also add the whole directory to the gitignore for the fundraising branch?" [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/101893 (owner: 10Katie Horn) [17:27:46] (03CR) 10Chad: "Also it seems to not make jenkins happy at all :(" [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/101893 (owner: 10Katie Horn) [17:28:29] (03CR) 10Katie Horn: "Bah, okay. Forget it, then. ;)" [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/101893 (owner: 10Katie Horn) [17:28:33] (03Merged) 10jenkins-bot: update cirrus to master [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/101892 (owner: 10Manybubbles) [17:28:47] (03Abandoned) 10Katie Horn: Removing mw-config dir [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/101893 (owner: 10Katie Horn) [17:32:00] (03PS1) 10Aude: Add SkinTemplateAfterLanguages hook to add html after language links [core] - 10https://gerrit.wikimedia.org/r/101895 [17:34:06] (03PS1) 10UltrasonicNXT: Add chat-topic [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/101896 [17:35:43] (03PS2) 10Manybubbles: Change betafeatures text [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101500 [17:44:35] (03PS1) 10Njw: Remove table elements from cssreset so border acts as expected [skins/erudite] - 10https://gerrit.wikimedia.org/r/101897 [17:49:56] (03PS1) 10UltrasonicNXT: Add message docs [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/101898 [17:50:24] (03CR) 10Njw: [C: 032 V: 032] Remove table elements from cssreset so border acts as expected [skins/erudite] - 10https://gerrit.wikimedia.org/r/101897 (owner: 10Njw) [17:52:22] (03CR) 10Chad: [C: 032] Change betafeatures text [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101500 (owner: 10Manybubbles) [17:52:35] (03Merged) 10jenkins-bot: Change betafeatures text [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101500 (owner: 10Manybubbles) [17:54:16] (03PS2) 10UltrasonicNXT: Add chat-topic [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/101896 [17:55:14] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Add chat-topic [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/101896 (owner: 10UltrasonicNXT) [17:59:24] (03PS2) 10UltrasonicNXT: Add message docs [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/101898 [18:02:53] (03CR) 10Daniel Friesen: [C: 04-1] "- I do not like these 'html after' hooks, skins use different html structures, and I've been specifically trying to get rid of them." [core] - 10https://gerrit.wikimedia.org/r/101895 (owner: 10Aude) [18:03:53] (03PS1) 10Yurik: updated to latest zero extension [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/101901 [18:04:38] (03PS1) 10Yurik: updated to latest zero extension [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/101902 [18:04:51] (03PS1) 10Matthias Mullie: Refactor title JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101903 [18:05:43] (03CR) 10jenkins-bot: [V: 04-1] Refactor title JavaScript [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101903 (owner: 10Matthias Mullie) [18:12:50] hi jdlrobson [18:13:16] hello mayankmadan [18:13:29] (03CR) 10Parent5446: "Ah yeah Nikerabbit brings up an important point. This script really needs to use User::getOptionKinds() to determine what keys need to be " [core] - 10https://gerrit.wikimedia.org/r/101233 (owner: 10Umherirrender) [18:13:39] jdlrobson, more info on this task http://www.google-melange.com/gci/task/view/google/gci2013/5770916835360768 [18:13:39] Mobile: Support mobile editing in IE9 based phones [18:13:40] Status: Open [18:13:40] Mentor(s): Jon Robson [18:14:02] Didn't we get rid of the gcibot business? [18:14:12] sure thing mayankmadan - what problem are you hitting? [18:14:26] marktraceur: yeh that was weird my natural instinct with links is to click on them ;-) [18:14:41] (03CR) 10Parent5446: [C: 04-1] Expand cleanupPreferences.php script to handle unused preferences [core] - 10https://gerrit.wikimedia.org/r/101233 (owner: 10Umherirrender) [18:16:45] ^d, hey there, you around ? [18:17:05] <^d> mooeypoo: What's up? [18:17:26] ^d, I'm about to look into using fileRepos in VE and was told you may be able to help me out with combining searches local/commons on images? [18:17:30] (03CR) 10Matthias Mullie: "Jenkins' -1 is because of 'use strict' directive, and not all of the JS lints strict yet." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101903 (owner: 10Matthias Mullie) [18:17:33] (03CR) 10Yurik: [C: 032 V: 032] updated to latest zero extension [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/101902 (owner: 10Yurik) [18:17:35] jdlrobson, just for some info, on which devices ie9 mobile is installed [18:18:04] <^d> mooeypoo: Sooo, CirrusSearch handles combining searches natively. [18:18:05] (03CR) 10Yurik: [C: 032 V: 032] updated to latest zero extension [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/101901 (owner: 10Yurik) [18:18:35] ooh [18:18:56] <^d> mooeypoo: And we'll be supporting including commons search results on all Cirrus wikis once we've finished indexing commons [18:19:00] <^d> Which is happening as we speak :) [18:19:07] Interesting. [18:19:35] Okay, I'll take a look. The first step in VE will be to migrate from hard-coded repos to getting the fileRepos from the API [18:19:43] after that, it will be pretty good to have the search ability. [18:20:05] mayankmadan: mostly Windows Phone 7 [18:20:37] jdlrobson, so it doesnt have editing support which has to be implemented [18:20:40] right? [18:20:59] mayankmadan: correct - if i remember correctly there were some rendering issues with the editor [18:21:25] mayankmadan: also confusingly the editor is in the process of being rebooted so make sure you are testing with mobileaction=beta on the URL to get the new version of the editor [18:21:27] ^d, thanks, I'll take a look. Might bug you occasionally for questions. I need to first get into and understand some of the core stuff first. [18:21:31] jdlrobson, can you help me with this a bit? [18:21:35] where do i start? [18:21:47] <^d> mooeypoo: No problem. Feel free to ping me or manybubbles if we can help :) [18:21:49] mayankmadan: let's chat in #wikimedia-mobile [18:22:00] ^d, awesomesauce :) thanks! [18:23:43] (03PS6) 10Kaldari: Add 'mediawiki.ui.button' CSS module [core] - 10https://gerrit.wikimedia.org/r/98869 [18:25:03] (03CR) 10jenkins-bot: [V: 04-1] Add 'mediawiki.ui.button' CSS module [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari) [18:27:58] (03PS7) 10Kaldari: Add 'mediawiki.ui.button' CSS module [core] - 10https://gerrit.wikimedia.org/r/98869 [18:32:50] (03PS5) 10Umherirrender: Expand cleanupPreferences.php script to handle unused preferences [core] - 10https://gerrit.wikimedia.org/r/101233 [18:45:28] (03PS6) 10Umherirrender: Expand cleanupPreferences.php script to handle unused preferences [core] - 10https://gerrit.wikimedia.org/r/101233 [18:47:13] ori-l: are there any howtos for moving a current mw into the mw-vagrant layout? I'm looking at localsettings to start. Maybe just move it to settings.d? [18:47:45] or anyone else who has worked with Vagrant ^^ [18:48:25] hexmode: Is it MW-core with just LocalSettings.php config? [18:48:29] hexmode: Or local forks of the code? [18:48:50] James_F: some very minor forks of the code, but mostly extensions [18:49:00] I'll replace the bits with hooks [18:49:05] * James_F nods. [18:49:16] Theoretically you should build a puppet script for each extension, but… [18:49:32] * James_F has never needed to install an extension other than those that are already there. [18:49:38] heh [18:49:44] (03CR) 10Umherirrender: "I cannot call User::getOptionsKinds here, because I have no user object. I have add a manual check for userjs-. Thanks for the point." [core] - 10https://gerrit.wikimedia.org/r/101233 (owner: 10Umherirrender) [18:49:50] Not exactly sure how much you should trust my advice. :-) [18:49:56] (03CR) 10Krinkle: [C: 04-1] Update collapsible lists below edit form on live preview via mw.hook (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99714 (owner: 10Bartosz Dziewoński) [18:50:04] ok, so that is a longer-term thing. My immediate goal is just to get it working. [18:50:21] I was confused b/c I was treating it as a regular mw [18:50:32] * James_F nods. [18:50:39] but *now* I notice that the localsettings is in a different place [18:50:45] Yeah. [18:50:52] And is managed by Vagrant. [18:50:58] With individual additions. [18:51:50] ok, I think I see what I need. Thanks for the advice on making it all puppety [18:51:52] :) [18:53:38] (03CR) 10Krinkle: Update collapsible lists below edit form on live preview via mw.hook (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99714 (owner: 10Bartosz Dziewoński) [18:56:10] (03CR) 10Krinkle: "Whichever gets reviewed last will have to be rebased, naturally. Any actual code review?" [core] - 10https://gerrit.wikimedia.org/r/101470 (owner: 10Krinkle) [19:02:08] Hi qgil. I'm continuing the Design Document and waiting feedback from Heather. [19:06:35] monteirobrena, hi, yes, do not hesitate pinging her via email if she doesn't answer as soon as you expect, or if you are not sure that she is aware of your draft. [19:07:12] monteirobrena, CC me when you ping her, and CC her when you ping me. This way both mentors know when you are needing more/sooner feedback [19:08:14] monteirobrena, you are getting feedback at the Design list! This is good. No worry about the controversy. As you can see not even veteran contributors agree. :) [19:10:38] qchris_away: ! [remote rejected] HEAD -> refs/meta/config/dashboards/custom (failed to lock) --> wtf? I'm trying to update the dashboard config for VisualEditor, never seen this error before [19:10:53] ^d: ---^^ if you feel like dealing with Gerrit problems while qchris is _away [19:11:11] monteirobrena, I will follow the thread and reply later today, if still needed. In situations like this it is good (for you as well, and for you especially as opener of the thread) to sit and wait a bit to see if the conversation settles [19:12:11] ^d: I'm getting an error from Gerrit when doing a search with the "file:" operator, it suggested the operator from auto completion, but it seems the search backend has it disabled. ("secondary index must be enabled for file:"). Is that something we could enable? And I assume it is a bug that it shows up in autocomplete. [19:13:22] <^d> Krinkle's question is easier, him first. I'll turn that on for 2.8. It was highly highly experimental (and mostly broken) for 2.7-rc2, so I left it disabled. I'm testing 2.8, no ETA yet (maybe early Jan?) [19:13:37] Hah, I think file: in searches is a bug that I filed? [19:13:39] <^d> RoanKattouw: No clue. Lemme check log. [19:13:51] <^d> On your first question. [19:14:04] <^d> And file search bugs predate us ever using gerrit ;-) [19:14:09] qgil: ok. I'm seeing the review Heather did in Design Document ;) [19:14:26] ^d: Cool, thanks. Should I file a bug upstream for the operator being suggested whilst disabled? [19:14:27] (03PS1) 10Anomie: Provide access to Language::getFallbacksFor() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101910 [19:14:56] <^d> Meh, we'll upgrade soon enough. [19:15:02] <^d> And they'll take a year to fix the bug. [19:15:57] monteirobrena, also remember that we agreed that the default IRC channel for our project would be #mediawiki -- I'm saying this because maybe Heather idles there, but not here... I don't know [19:20:52] (03Restored) 10Krinkle: Jenkins validation test (do not submit).\. [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/43176 (owner: 10Hashar) [19:21:03] (03PS10) 10Krinkle: Jenkins validation test (do not submit).\. [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/43176 (owner: 10Hashar) [19:21:13] <^d> RoanKattouw: I've got nothing in logs. What repo was this? mw/e/VE? [19:21:14] (03PS11) 10Krinkle: Jenkins sample commit [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/43176 (owner: 10Hashar) [19:21:19] ^d: Yeah [19:21:42] $ git push origin HEAD:refs/meta/config/dashboards/custom [19:21:48] qgil: fine, I'll use the #mediawiki channel. thank you. [19:21:48] After committing something new [19:22:37] <^d> RoanKattouw: May (not) be useful: http://p.defau.lt/?tNrc8l8ZEFsj2Ce6Oxpelg [19:25:26] (03PS4) 10Anomie: Explicitly support user id in action=userrights [core] - 10https://gerrit.wikimedia.org/r/101502 (owner: 10Legoktm) [19:25:35] (03CR) 10Anomie: [C: 032] "Huh, this somehow fell off my radar." [core] - 10https://gerrit.wikimedia.org/r/101502 (owner: 10Legoktm) [19:25:38] (03PS1) 10Cmcmahon: locators for hide/delete/suppress changed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101911 [19:25:44] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Add message docs [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/101898 (owner: 10UltrasonicNXT) [19:26:59] ^d: Doesn't look like it should be related to pushes to refs/meta failing [19:27:13] Unless it's like magically lost the head of refs/meta [19:27:34] <^d> Yeah that'd be weird. [19:27:53] *the head of refs/meta/dashboards/custom [19:28:33] (03CR) 10Krinkle: JSDuck-ify /resources/mediawiki.language/* (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [19:29:15] James_F, ori-l (or other Vagrant peeps): so.... how do I regenerate the /vagrant/LocalSettings.php? I've tried "vagrant reload" and "vagrant provision" with no luck. [19:30:44] (03Merged) 10jenkins-bot: Explicitly support user id in action=userrights [core] - 10https://gerrit.wikimedia.org/r/101502 (owner: 10Legoktm) [19:32:15] (03CR) 10Jhall: [C: 031] locators for hide/delete/suppress changed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101911 (owner: 10Cmcmahon) [19:33:38] (03CR) 10TheDJ: "@Anomie. Do we have any idea about the penalty for pre loading libraries like that ? is it expensive ?" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man) [19:37:24] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101911 (owner: 10Cmcmahon) [19:44:03] (03CR) 10Anomie: "@TheDJ: In the absence of evidence that a preloaded library is using a lot of memory or takes a lot of time to clone for each #invoke on t" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/101874 (owner: 10Hoo man) [19:44:58] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/101924 (owner: 10L10n-bot) [19:45:10] (03CR) 10Bartosz Dziewoński: JSDuck-ify /resources/mediawiki.language/* (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [19:45:16] * hexmode gives himself a doh-slap since /vagrant/LocalSettings.php is from git [19:46:59] (03PS1) 10Amire80: GENDER and number i18n for flow-topic-meta-minimal [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101947 [19:47:43] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/101951 (owner: 10L10n-bot) [19:54:18] (03PS1) 10Chad: Index page templates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101992 [19:57:25] (03PS5) 10EBernhardson: Load usernames directly from wiki's in batches [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 [20:02:07] (03CR) 10Chad: Index page templates (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101992 (owner: 10Chad) [20:06:21] (03CR) 10Manybubbles: Index page templates (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101992 (owner: 10Chad) [20:06:31] (03PS2) 10Chad: Index page templates [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101992 [20:07:28] (03PS10) 10Amire80: Better GENDER support in moderation.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 [20:07:55] (03PS12) 10Krinkle: Jenkins sample commit [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/43176 (owner: 10Hashar) [20:07:57] ebernhardson: Hi. Do you mind taking a look at https://gerrit.wikimedia.org/r/#/c/98368/ ? [20:08:31] It's not too long, and I'd love the messages to be updated and translatable as early as possible. [20:08:34] (03CR) 10Chad: Index page templates (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101992 (owner: 10Chad) [20:12:01] (03CR) 10Manybubbles: Index page templates (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101992 (owner: 10Chad) [20:12:14] hello [20:16:21] aharoni: sure, sec [20:16:51] (03PS1) 10Bsitu: curl_setopt doesn't seem to url-encode the text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101994 [20:17:39] (03PS2) 10Bsitu: curl_setopt doesn't seem to url-encode the text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101994 [20:18:24] The new and improved JSON-based configuration storage needs some feedback https://www.mediawiki.org/wiki/Requests_for_comment/Json_Config_pages_in_wiki [20:18:37] I have mostly finished implementing it, seeking feedback [20:19:13] (03PS3) 10Bsitu: curl_setopt doesn't seem to url-encode the text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101994 [20:19:44] aharoni: unfortunatly, as is it looks like it does a network request per rendered post [20:20:07] huh? where? [20:20:13] aharoni: getCreatorGender [20:20:22] aharoni: it creates a user object to call ->getOption( 'gender' ) [20:20:46] which then uses User::loadOptions, which calls a full User::load [20:20:50] if i'm reading this right [20:20:54] Headdesk. [20:21:00] You are probably right. [20:21:19] its sometimes quite hard to not do N network requests in mw, i have to think about things a bit sometimes :) [20:21:58] aharoni: so if i read that right though, gender in i18n works off the users gender preference? [20:23:00] ebernhardson: it either needs an explicit 'male'/'female' string or a JS user object, but the latter is only available for the current user. [20:23:58] but... really? isn't there anything else that reads user options when rendering a page? [20:24:31] actually, wait. [20:24:36] will someone at the foundation please put the extension matrix bot on a foundation server as a cron job. [20:24:37] i can no longer host it. [20:24:37] https://www.mediawiki.org/wiki/Extension_Matrix [20:24:37] source code: https://www.mediawiki.org/wiki/User:Alterego/ExtensionMatrix/Source_code [20:24:44] ebernhardson: maybe it's not really needed here. [20:25:25] cortexman: You can get an account on labs, and labs will host it for you [20:26:03] RoanKattouw: refs/meta/config/dashboards/custom should be refs/meta/dashboards/custom [20:26:19] RoanKattouw: (no "config" part) [20:26:32] (03CR) 10Chad: Index page templates (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101992 (owner: 10Chad) [20:26:52] RoanKattouw: refs/meta/config is aleady a ref, so you cannot create a ref underneath it. [20:28:17] (03CR) 10MathiasLidal: [C: 032 V: 032] Fix implode() parameter [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/83096 (owner: 10Shirayuki) [20:28:25] ebernhardson: I can probably the loading of gender for now, although it may become needed in the future. Let me check. [20:29:29] aharoni: other way would be to check how i18n does gender when a simple string is passed, perhaps that code can be called directly to get the gender that would have been used (but with a quick grep i dont see where GENDER actually gets handled) [20:30:02] ebernhardson: I'll just remove it for now. [20:30:06] qchris: Aaaah OK thanks [20:37:11] (03PS2) 10Umherirrender: Raw option of parser functions should match complete word [core] - 10https://gerrit.wikimedia.org/r/100198 [20:37:43] (03PS11) 10Amire80: Better GENDER support in moderation.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 [20:37:57] ebernhardson: I amended https://gerrit.wikimedia.org/r/98368 . [20:38:10] Thanks for the comments earlier - I did a lot of silly things there :) [20:42:55] (03CR) 10jenkins-bot: [V: 04-1] Load usernames directly from wiki's in batches [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 (owner: 10EBernhardson) [21:06:48] (03PS5) 10MaxSem: Add new one-column diff mode [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/99541 [21:09:22] (03PS6) 10MaxSem: Add new one-column diff mode [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/99541 [21:14:30] (03Abandoned) 10Krinkle: Jenkins sample commit [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/43176 (owner: 10Hashar) [21:17:46] (03PS3) 10Nikerabbit: Raw option of parser functions should match complete word [core] - 10https://gerrit.wikimedia.org/r/100198 (owner: 10Umherirrender) [21:18:40] (03PS3) 10IAlex: Added more Setup.php profiling [core] - 10https://gerrit.wikimedia.org/r/101794 (owner: 10Aaron Schulz) [21:18:45] (03CR) 10IAlex: [C: 032] Added more Setup.php profiling [core] - 10https://gerrit.wikimedia.org/r/101794 (owner: 10Aaron Schulz) [21:21:02] Krinkle: still around ? [21:21:35] Krinkle: can you look at https://integration.wikimedia.org/zuul/ , I am going to +2 three changes at the sametime. [21:21:58] OK? [21:22:12] going to approve 3 changes for jjjb config [21:22:22] they will show up nicely in the gate-and-submit pipeline [21:22:29] (03Abandoned) 10MaxSem: Allow callers to specify timestamp formats outputted by API [core] - 10https://gerrit.wikimedia.org/r/93075 (owner: 10MaxSem) [21:22:30] approving them [21:22:34] https://gerrit.wikimedia.org/r/102001 #p1 [21:22:39] https://gerrit.wikimedia.org/r/102002 p1 [21:22:50] (check-voter0 [21:22:50] 3 of them shows up with nice dependencies :D [21:23:03] Moved to gate-and-submit , i their jjb queue [21:23:18] with dependency arrow! [21:23:19] yeah and the javascript shows them as linked [21:23:23] isn't that lovely? [21:23:33] so basically, I made gate-and-submit a dependent pipeline [21:23:39] i tried it out over the week end [21:23:51] and figured out that it would do no harm so I went crazy and enabled it [21:24:00] + I made a ton of job to be runnable in parralel [21:24:26] so if one +2 a bunch of changes that only do linting, they will all be tested in parallel and all jobs get merged in very fast [21:24:36] instead of waiting for the longest job to finish for each change [21:25:13] (03Merged) 10jenkins-bot: Added more Setup.php profiling [core] - 10https://gerrit.wikimedia.org/r/101794 (owner: 10Aaron Schulz) [21:28:53] hashar: So, I'd like to have one more confirmation that it is okay to use npm-install on nodes with hasNpm [21:29:02] See https://gerrit.wikimedia.org/r/#/c/101461/2/macro.yaml [21:29:14] specifically the comment I added to the existing npmtest macro [21:34:10] Krinkle: looking [21:34:32] (03CR) 10Legoktm: [C: 032] SpecialRecentChanges::makeLegend: Mention usage in Watchlist [core] - 10https://gerrit.wikimedia.org/r/101829 (owner: 10Bartosz Dziewoński) [21:34:33] Krinkle: iirc hasNpm is only on labs instance [21:35:11] OK [21:37:20] Krinkle: https://integration.wikimedia.org/ci/label/hasNpm/? [21:37:38] Yeah, verified as well through https://integration.wikimedia.org/ci/computer/integration-slave01/script [21:37:43] > println "cat /etc/wmflabs-instancename".execute().text [21:37:44] :) [21:38:06] Since the node name and IP don't 100% safely tell me it is labs [21:38:14] (03CR) 10Legoktm: [C: 031] Watch user page and user talk page by default [core] - 10https://gerrit.wikimedia.org/r/95742 (owner: 10Bartosz Dziewoński) [21:40:43] Krinkle: bah commented on the wrong putsches grbmbmb [21:41:18] (03Merged) 10jenkins-bot: SpecialRecentChanges::makeLegend: Mention usage in Watchlist [core] - 10https://gerrit.wikimedia.org/r/101829 (owner: 10Bartosz Dziewoński) [21:41:19] patchset [21:41:37] http://imgur.com/JTmBTX4, how can I get rid of this error? [21:41:52] Krinkle: so you get 'npm' macro and template that does 'npm install' [21:42:10] Krinkle: and we already have a '{name}-npmtest' job template [21:42:21] I'm not going to use the npmtest job template [21:42:28] was wondering why oojs would only has a job doing npm install, don you want to run npm test as well ? [21:42:31] ah [21:42:33] evil! [21:42:47] That is legacy as far as I'm concerned from now on. [21:43:00] so how you run the tests? [21:43:09] hashar: Are gerrit commits going else where for integration? [21:43:19] I'm not seeing anything from the past 20 minutes [21:43:31] It seems to be missing many things lately [21:43:49] zuul-config, jenkins-job-builder-config [21:44:08] in -dev [21:44:13] Krinkle: ah #wikimedia-qa [21:44:24] Krinkle: looks like a change I proposed for grrrit got merged in [21:44:54] Krinkle: yeah they got moved with https://gerrit.wikimedia.org/r/#/c/101019/ [21:44:58] Why? [21:45:08] Last I checked CI and QA are still mostly separate in practice [21:45:17] i did add you as a reviewer, should probable have -2 that change to make sure you cast your voice [21:45:38] in all of 21 minutes? [21:45:38] I don't feel like having a #wikimedia-ci on its own though [21:45:52] yeah hmm [21:46:03] blame legotkm :-) he has been a bit too quick possibly [21:46:15] Krinkle: 5x+1. This may be another one of those IRC things where you're out-voted. :-) [21:46:18] + point is that changes made to grrrit are merged/deployed very fast hehe [21:46:19] yeah, I don't feel like having most mediawiki- and wikimedia- channels, but people who prefer that, that's fine. The default is -dev though, has been for CI as well. we have. [21:46:39] sorry :( [21:46:51] so we got most ci / qa activities in #wikimedia-qa nowadays [21:46:52] I just deployed it because people +1'd it. I don't really have an opinion on the change itself. [21:47:06] legoktm: yeah thanks for that :-} [21:47:27] legoktm: was kind of expecting timo to give a final voice, should have blocked the change to reflect that. Nothing to blame on your side [21:47:36] Anyway, it's done now. [21:47:39] legoktm: and thank you for maintaining grrrrit \O/ [21:47:44] hashar: I'd propose to remove integration/* from -qa and keep that one -dev. The commit is somewhat dubious. It claims to remove duplication, but it does that + move integration/ [21:47:45] And it moves CI and QA closer together, so… :-) [21:48:07] I have ignored grrrit in this channel , too spammy [21:48:11] Krinkle: Or we could +2 Nemo's change that adds a second, full-fat feed in -feed so you can get all of them? [21:48:19] hehe [21:48:54] James_F: No, I don't use -feed, defeats the purpose of notification for me. I have a gerrit inbox for if I want to look though some definition of 'all of them'. [21:49:23] Krinkle: meanwhile, regarding using npm to run tests, you might have a look at the offlinecontentGenerator jobs https://integration.wikimedia.org/ci/label/hasNpm/ [21:49:26] Krinkle: But now you want everyone else to have to read -qa messages in here too? [21:49:36] Krinkle: I'm failing to spot the consistency. :-) [21:49:41] Krinkle: they are the only one using the '{name}-npm-test' template afaik [21:50:16] James_F: I don't care what QA is interested in, we can keep them there if they're interested in CI changes. in 9/10 cases (10/10 afaik) they're unrelated though. I mean, unrelated in that they're not managed by them, they can be intersted, just like non VE team members can be intersted in VE changes. [21:50:17] Krinkle: so feel free to get rid of the npm-test macro and convert that repository to a system similar to the one you are going to use for oo [21:50:26] Anyway, I rest my case, got other thigns to worry about. [21:51:21] by keep there, I mean, mirrored in -qa and -dev (like QA's changes were). for several months QA changes were going to both -dev and -qa and integration only in -dev. [21:51:39] Now QA is gone out of -dev, that's fine by me. But integration should imho say in -dev or both. [21:52:04] hashar: Yeah, I'm not going to touch wikidata though. They use a separate repo for nodejs, that's more than a jenkins configuration. [21:52:19] they presumably use that for other things as well so it should keep using that to stay consistent. [21:52:42] it can start using proper npm when they're ready to. I'll let them know about the possibility and let them decide. [21:57:38] Krinkle: feel free to get the integration notifications back in -dev [21:58:03] Krinkle: the main reason I proposed the change was to reduce the spam in here when I am doing mass changes during european mornigns [22:06:37] (03CR) 10Chad: [C: 032] Make review settings more flexible [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101255 (owner: 10BryanDavis) [22:06:45] (03Merged) 10jenkins-bot: Make review settings more flexible [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101255 (owner: 10BryanDavis) [22:08:47] (03CR) 10Aaron Schulz: "It will not reduce DB write load (though it will reduce some read load). Mostly it will reduce the number of parses needed (by at least ha" [core] - 10https://gerrit.wikimedia.org/r/101170 (owner: 10Aaron Schulz) [22:11:13] (03CR) 10Legoktm: [C: 04-1] Add ghetto batching to the BlacklistUpdate (032 comments) [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101620 (owner: 10Skizzerz) [22:16:25] RoanKattouw: I was wondering -- how much time do you not have today? aka -- I have two patches I'd really love to get reviewed [22:25:13] (03CR) 10Chad: [C: 032] Update look and feel [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101875 (owner: 10BryanDavis) [22:25:22] (03Merged) 10jenkins-bot: Update look and feel [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101875 (owner: 10BryanDavis) [22:25:35] (03CR) 10Chad: [C: 032] Wikimania 2014 content [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101878 (owner: 10BryanDavis) [22:25:43] (03Merged) 10jenkins-bot: Wikimania 2014 content [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101878 (owner: 10BryanDavis) [22:26:50] (03CR) 10Chad: [C: 032] Allow empty values for Form::expectInArray [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101879 (owner: 10BryanDavis) [22:26:54] (03Merged) 10jenkins-bot: Allow empty values for Form::expectInArray [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101879 (owner: 10BryanDavis) [22:31:12] (03CR) 10MathiasLidal: [C: 031] Added "search and replace within selection" functionality [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/87322 (owner: 10Netbrain) [22:37:50] mwalker: Well I'm doing code review for VE and it's almost midnight ... [22:37:57] mwalker: Are the patches small? [22:38:11] nah; couple hundred lines [22:38:16] I can bug someone else [22:38:32] * mwalker looks around for likely candidates [22:39:20] marktraceur: you have lots of not free time! want to review some patches for me? :D [22:44:28] (03PS1) 10Legoktm: Add $wgSFSEnableConfidenceVariable to enable AbuseFilter integration [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/102017 [22:44:29] (03PS1) 10Legoktm: Don't load confidence if we've already made 20,000 requests [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/102018 [22:48:14] (03PS1) 10MegaAlex: Change message 'rcshowhideliu' to match its actual functionality [core] - 10https://gerrit.wikimedia.org/r/102019 [22:50:47] hey ^d, I'm trying to make a git (gitolite) repository auto-update when one of its submodules receives a push. How did you do that for our extensions repo? [22:51:01] <^d> it's a gerrit feature. [22:51:57] werdna: you could do it via hooks, obviously :) [22:52:19] Ryan_Lane: yeah, but all I can think of to do is to actually make a temporary checkout of the parent repo [22:52:44] since the repos are all bare [22:54:19] (03PS1) 10BryanDavis: Update business logic and storage for 2014 [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102021 [22:55:48] (03PS1) 10Krinkle: Remove unused 'tools/gruntjs' submodule [integration/jenkins] - 10https://gerrit.wikimedia.org/r/102022 [22:57:00] werdna: use a git library [22:57:07] like dulwich or GitPython or pygit2 [22:57:27] then you can push changes directly into the bare repo [22:57:37] Ryan_Lane: aha [23:00:23] (03Draft1) 10Wikinaut: version 9.5.1 update from http://www.ratin.de/msupload.html [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/102023 [23:00:59] (03PS1) 10Manybubbles: Fix chunk size on in place reindex [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102024 [23:01:47] (03CR) 10Chad: [C: 032] Update business logic and storage for 2014 [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102021 (owner: 10BryanDavis) [23:01:50] (03Merged) 10jenkins-bot: Update business logic and storage for 2014 [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102021 (owner: 10BryanDavis) [23:02:08] ^d: \o/ [23:02:22] <^d> So, that's it? We think? [23:02:24] (03PS1) 10Legoktm: Use ApiBase::requireOnlyOneParameter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102025 [23:03:11] ^d: That's all I know for sure at the moment, but probably 1 small update coming to add an optional question back in according to my inbox. [23:03:57] ^d: I'm going to update the labs deploy and then see if I can find some folks to help test [23:03:57] <^d> Ok, I'm gonna i18nize grid, scores and search. [23:04:08] (03PS2) 10Werdna: Convert moderation success dialogs to inline boxes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100953 [23:04:15] Go for it [23:04:44] Feel free to make the key names make sense while you're in there too :) [23:05:08] (03CR) 10Werdna: "'close' is now capitalised." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100953 (owner: 10Werdna) [23:07:18] (03PS1) 10Legoktm: Don't dynamically define $container [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102027 [23:07:49] (03PS1) 10Legoktm: Fix typo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102028 [23:10:27] (03PS1) 10Legoktm: Cleanup ApiQueryFlow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102030 [23:10:52] (03PS2) 10Wikinaut: version 9.5.1 Extension:MsUpload [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/102023 [23:11:01] (03PS1) 10Krinkle: jpegmeta: Add links to source version and improve documentation [core] - 10https://gerrit.wikimedia.org/r/102031 [23:14:40] (03PS4) 10Krinkle: Add 'npm' macro and jobs for oojs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101461 [23:14:45] (03PS3) 10Krinkle: Clean up: Remove a few redundant 'scm' properties [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101462 [23:14:48] (03PS1) 10Chad: Localize most remaining review pages [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102032 [23:14:49] (03CR) 10Wikinaut: [C: 04-1] "many whitespace problems" [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/102023 (owner: 10Wikinaut) [23:15:13] (03CR) 10MaxSem: Initial implementation of the JSON configuration store. (0327 comments) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [23:15:20] :D [23:15:22] (03PS5) 10Krinkle: Add 'npm' macro and jobs for oojs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101461 [23:17:46] (03PS1) 10Ori.livneh: Add NavigationTiming role [vagrant] - 10https://gerrit.wikimedia.org/r/102033 [23:18:00] (03CR) 10Ori.livneh: [C: 032] Add NavigationTiming role [vagrant] - 10https://gerrit.wikimedia.org/r/102033 (owner: 10Ori.livneh) [23:18:01] (03CR) 10Krinkle: "Pushed oojs-core-npm and oojs-ui-npm to Jenkins." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101461 (owner: 10Krinkle) [23:18:13] (03Merged) 10jenkins-bot: Add NavigationTiming role [vagrant] - 10https://gerrit.wikimedia.org/r/102033 (owner: 10Ori.livneh) [23:20:26] (03CR) 10Krinkle: [C: 04-1] "Not yet enabled in Zuul, testing first https://integration.wikimedia.org/ci/job/oojs-core-npm/1/console." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/101461 (owner: 10Krinkle) [23:22:21] aude, ^d: Some poking at https://wikimania-scholarship.wmflabs.org/alpha/apply would be appreciated [23:26:03] <^d> bd808: This is looking fantastic. [23:26:30] I busted my ass to make it pretty over the weekend. [23:27:22] (03PS1) 10BryanDavis: Ignore .deploy in top directory [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102036 [23:27:40] (03CR) 10BryanDavis: [C: 032] Ignore .deploy in top directory [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102036 (owner: 10BryanDavis) [23:27:44] (03Merged) 10jenkins-bot: Ignore .deploy in top directory [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102036 (owner: 10BryanDavis) [23:28:21] (03PS1) 10Chad: Blank all non-en messages [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102037 [23:30:17] bd808: that is really really pretty [23:30:56] werdna: Thanks. I borrowed the graphics from https://wikimania2014.wikimedia.org/wiki/Main_Page [23:31:14] (03CR) 10Chad: [C: 032] Don't pass the Title object as third argument to CreditsSourceAction::getCredits() [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/101498 (owner: 10IAlex) [23:31:18] (03Merged) 10jenkins-bot: Don't pass the Title object as third argument to CreditsSourceAction::getCredits() [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/101498 (owner: 10IAlex) [23:31:27] The rest is Bootstrap with a slightly tweaked theme from the default [23:34:12] (03CR) 10Chad: [C: 032] Fix chunk size on in place reindex [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102024 (owner: 10Manybubbles) [23:34:17] (03Merged) 10jenkins-bot: Fix chunk size on in place reindex [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/102024 (owner: 10Manybubbles) [23:35:10] (03CR) 10Werdna: [C: 031] "Looks fine, but untested." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/102030 (owner: 10Legoktm) [23:37:06] (03PS1) 10Chad: Remove test wikis from wiki list [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102039 [23:38:17] (03CR) 10BryanDavis: [C: 031] Remove test wikis from wiki list (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102039 (owner: 10Chad) [23:43:32] (03CR) 10Chad: Remove test wikis from wiki list (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/102039 (owner: 10Chad)