[00:07:28] how can i revert merged changes? [00:07:39] file another gerrit change to do so [00:07:42] hit the revert button [00:07:58] * Jasper_Deng has seen gerrit changes that revert previous gerrit changes [00:17:43] there's a "revert change" button or something [00:19:37] (03PS4) 10Legoktm: Change blacklist caching mechanism [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101602 (owner: 10Skizzerz) [00:21:57] well, it has been merged and it is already live on wikis [00:24:12] which change? [00:25:37] (03PS5) 10Skizzerz: Change blacklist caching mechanism [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101602 [00:28:04] (03PS6) 10Skizzerz: Change blacklist caching mechanism [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101602 [00:28:11] https://gerrit.wikimedia.org/r/#/c/96584/ and subsequent https://gerrit.wikimedia.org/r/#/c/97388/ [00:29:15] rather than revert, why don't you discuss why you don't like it? [00:31:17] (03PS1) 10Danny B.: Revert "Add legend to Special:RecentChanges and Special:Watchlist" [core] - 10https://gerrit.wikimedia.org/r/101603 [00:31:55] (03CR) 10jenkins-bot: [V: 04-1] Revert "Add legend to Special:RecentChanges and Special:Watchlist" [core] - 10https://gerrit.wikimedia.org/r/101603 (owner: 10Danny B.) [00:32:12] (03PS1) 10Danny B.: Revert "SpecialRecentChanges: Use $wgRecentChangesFlags in makeLegend()" [core] - 10https://gerrit.wikimedia.org/r/101604 [00:32:34] what is rclegend? [00:32:49] just hide it with CSS if you don't like it. [00:33:43] legoktm: That's the message shown on top of Special:Recentchanges [00:34:02] "3) Poor design anyway - in narrow resolutions (i.e. 1024*768) it causes enormous shift of the content out of the viewport." that might be a valid point, though [00:34:06] hoo: nope, that recentchanges-summary [00:34:29] https://cs.wiktionary.org/wiki/Speci%C3%A1ln%C3%AD:Posledn%C3%AD_zm%C4%9Bny check this in 1024*768 [00:35:17] why don't we fix that then? [00:35:19] MatmaRex: ^ [00:35:34] Danny_B: you know you can hide it with CSS right? [00:35:51] of course, but that is _hiding_ [00:35:54] not removing [00:36:05] that's why rclegend was set [00:36:19] * Danny_B is trying to find that bug which introduced that [00:36:26] but bugzilla is slow [00:36:55] um [00:37:03] there's a patch pending that makes it collapsible [00:37:07] no one bothered to review it yet [00:37:33] what bug introduced what now? [00:38:11] at first there is absolutely no need to have it there, since all letters have the tooltip [00:38:32] Danny_B: sorry you have the legends now, the information about this is going i=out in next tech news (i missed the current issue) [00:38:40] 3) Poor design anyway - in narrow resolutions (i.e. 1024*768) it causes enormous shift of the content out of the viewport. [00:38:52] 3) Poor design anyway - in narrow resolutions (i.e. 1024*768) it causes enormous shift of the content out of the viewport. [00:38:54] damn [00:38:58] * hoo kills netbeans [00:39:05] $msg = $this->msg( 'rclegend' ); [00:39:26] forget it :P It's bad design and it's in SpecialRecentchange [00:39:28] two legends now* [00:39:55] $msg = $this->msg( 'rclegend' ); [00:39:55] if ( !$msg->isDisabled() ) { [00:39:55] $note .= '
' . $msg->parse() . "
\n"; [00:39:55] } [00:40:07] ah, if I cut it, it properly lands in my clipboard :P [00:40:23] MatmaRex: Killing rclegend sounds like a good option [00:41:33] what is rclegend, now? [00:41:50] ah, i see [00:42:04] hoo: there's a bug about redesigning and rewriting that area [00:42:15] i did some work on it, but none of this merged [00:42:23] (and most of it is unfit to be merged, tbh) [00:42:37] mh [00:42:45] my backlog is *this* huge [00:44:04] --> <-- like that huge? [00:44:46] :D [00:49:04] ok, it's late here. please bother me tomorrow, y'all. [00:49:05] night [00:51:09] no, killing rclegend is actually bad option [00:51:35] good option may be to fill rclegend with default content equal to the newly added legend [00:51:42] so it is customizable [00:51:47] and not hardcoded [00:54:18] mh [00:54:37] open a bug for that maybe... or go ahead and implement it [00:54:52] probably both is the best option, blank reverts wont solve any problems here [00:55:36] (03CR) 10Legoktm: [C: 032 V: 032] ":D" [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101602 (owner: 10Skizzerz) [01:13:36] oh, hoo, I had an abusefilter question. when I use the AbuseFilter-generateUserVars hook, is it safe to use external context like the current WebRequest object? I don't know if they get cached or not [01:14:37] legoktm: We don't ahve caching there, no... so you can use whatever you want on your side [01:14:57] awesome [01:21:23] hoo: blank revert solves the poor design at least at the moment. but i agree that optional approach which will allow wikis to have their own way how to format it (compare those two legends on link i posted - our takes much less space, thus does not move stuff down even on narrow displays) is the best [02:00:55] (03PS1) 10Legoktm: Don't try to submit if $wgSFSAPIKey is empty [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101608 [02:01:22] (03CR) 10Legoktm: [C: 032 V: 032] Don't try to submit if $wgSFSAPIKey is empty [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101608 (owner: 10Legoktm) [02:45:36] (03PS1) 10Skizzerz: Make blacklist accept CSV files + thresholds [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101610 [02:55:34] (03CR) 10MZMcBride: "Is this ready for review?" [core] - 10https://gerrit.wikimedia.org/r/95742 (owner: 10Bartosz Dziewoński) [03:20:33] (03CR) 10MZMcBride: "Is this related to a particular bug report?" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur) [03:31:54] (03CR) 10Legoktm: Make blacklist accept CSV files + thresholds (031 comment) [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101610 (owner: 10Skizzerz) [03:58:00] (03CR) 10MarkTraceur: "I doubt it, but let's check!" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur) [04:11:16] (03PS2) 10Skizzerz: Make blacklist accept CSV files + thresholds [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101610 [04:29:00] (03CR) 10Legoktm: [C: 032 V: 032] Make blacklist accept CSV files + thresholds [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101610 (owner: 10Skizzerz) [04:42:54] (03PS1) 10Legoktm: Indicate what action the user was attempting in debug log [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101614 [04:42:55] (03PS1) 10Legoktm: Move StopForumSpam::makeBlacklist into updateBlacklist.php [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101615 [04:43:49] (03CR) 10Legoktm: [C: 032 V: 032] Indicate what action the user was attempting in debug log [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101614 (owner: 10Legoktm) [04:56:37] (03PS2) 10Legoktm: Move StopForumSpam::makeBlacklist into updateBlacklist.php [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101615 [04:57:14] (03PS3) 10Legoktm: Move StopForumSpam::makeBlacklist into updateBlacklist.php [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101615 [05:19:35] (03PS4) 10Legoktm: Make updating the blacklist a DeferrableUpdate [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101615 [06:59:19] (03CR) 10Legoktm: [C: 032 V: 032] Make updating the blacklist a DeferrableUpdate [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101615 (owner: 10Legoktm) [07:10:01] (03PS1) 10Legoktm: Add BagOStuff::setMulti for batch insertions [core] - 10https://gerrit.wikimedia.org/r/101617 [07:21:32] (03PS1) 10Amire80: Clean some phpcs errors in Preferences.php [core] - 10https://gerrit.wikimedia.org/r/101618 [07:23:32] (03PS7) 10Theopolisme: Create jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/99021 [07:28:55] (03PS4) 10Amire80: i18n: Native digits on #wpLocalTime [core] - 10https://gerrit.wikimedia.org/r/101495 (owner: 10Ebrahim) [07:29:12] (03PS3) 10Amire80: i18n: Native digits on user id on preference [core] - 10https://gerrit.wikimedia.org/r/101221 (owner: 10Ebrahim) [07:41:44] (03PS1) 10Pastakhov: Add $end exception before return $bytecode; [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/101619 [07:42:37] (03CR) 10Pastakhov: [C: 032] Add $end exception before return $bytecode; [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/101619 (owner: 10Pastakhov) [07:42:44] (03Merged) 10jenkins-bot: Add $end exception before return $bytecode; [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/101619 (owner: 10Pastakhov) [07:46:36] (03PS1) 10Skizzerz: Add ghetto batching to the BlacklistUpdate [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101620 [07:52:30] (03PS2) 10Skizzerz: Add ghetto batching to the BlacklistUpdate [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101620 [08:32:40] (03PS1) 10Amire80: Discussion toggle icons for RTL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101622 [08:37:36] (03PS1) 10Legoktm: JS --> JavaScript [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/101624 [08:39:24] (03PS2) 10Dev-zero: Reformat the license warning only if available [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/98249 [08:42:47] (03PS1) 10Legoktm: Improve 'globalcssjs-desc' message [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/101625 [08:43:59] (03PS2) 10Legoktm: Improve 'globalcssjs-desc' message [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/101625 [08:44:20] (03CR) 10Calak: [C: 031] i18n: Native digits on user id on preference [core] - 10https://gerrit.wikimedia.org/r/101221 (owner: 10Ebrahim) [08:45:41] (03CR) 10Calak: [C: 031] i18n: Native digits on #wpLocalTime [core] - 10https://gerrit.wikimedia.org/r/101495 (owner: 10Ebrahim) [08:51:04] (03PS1) 10Legoktm: Remove user option [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/101626 [08:52:02] (03CR) 10Legoktm: "I removed the user option in If16941a60db780e12a3828ea9541b90739ed4966 (dependent upon this patch)." [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 (owner: 10Legoktm) [09:19:50] (03CR) 10Nemo bis: [C: 031] "No opinion on for/in/on all etc.; ok." [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/101625 (owner: 10Legoktm) [09:20:13] (03CR) 10Nemo bis: [C: 031] JS --> JavaScript [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/101624 (owner: 10Legoktm) [09:47:30] (03PS1) 10Foxtrott: Restructure classes; add components Structure, Html, Grid [skins/chameleon] - 10https://gerrit.wikimedia.org/r/101627 [09:48:42] (03CR) 10Foxtrott: [C: 032 V: 032] Restructure classes; add components Structure, Html, Grid [skins/chameleon] - 10https://gerrit.wikimedia.org/r/101627 (owner: 10Foxtrott) [09:50:18] (03PS1) 10Foxtrott: Bump version to 0.2 alpha [skins/chameleon] - 10https://gerrit.wikimedia.org/r/101628 [09:51:00] (03CR) 10Foxtrott: [C: 032 V: 032] Bump version to 0.2 alpha [skins/chameleon] - 10https://gerrit.wikimedia.org/r/101628 (owner: 10Foxtrott) [10:34:06] (03CR) 10Physikerwelt: [V: 032] "ok. Any concerns, to merge this change?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 (owner: 10Physikerwelt) [10:44:05] (03CR) 10Frédéric Wang: [C: 031] "Looks good to me too." [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 (owner: 10Physikerwelt) [10:48:47] (03PS7) 10Yurik: Ported some initial files from Zero extension [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 [10:55:39] (03PS2) 10Amire80: Discussion toggle icons for RTL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101622 [11:09:18] (03PS4) 10Apsdehal: Updated Special:GlobalUsers to show creation date of global user account [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 [11:11:08] (03CR) 10Physikerwelt: "Hi Frédéric," [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 (owner: 10Physikerwelt) [11:44:02] (03PS1) 10kroocsiogsi: Latest SoundManager2 updates and asynchronous script loading fixes [extensions/SoundManager2Button] - 10https://gerrit.wikimedia.org/r/101637 [11:45:41] (03CR) 10kroocsiogsi: [C: 032 V: 032] Latest SoundManager2 updates and asynchronous script loading fixes [extensions/SoundManager2Button] - 10https://gerrit.wikimedia.org/r/101637 (owner: 10kroocsiogsi) [12:08:06] (03PS2) 10IAlex: Set default for nickname preference [core] - 10https://gerrit.wikimedia.org/r/100938 (owner: 10MaxSem) [12:08:14] (03CR) 10IAlex: [C: 032] Set default for nickname preference [core] - 10https://gerrit.wikimedia.org/r/100938 (owner: 10MaxSem) [12:09:17] (03CR) 10Aude: [C: 032] Clean some phpcs errors in Preferences.php [core] - 10https://gerrit.wikimedia.org/r/101618 (owner: 10Amire80) [12:12:32] (03PS1) 10Amire80: Permalink RTL icon [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101638 [12:13:25] (03Merged) 10jenkins-bot: Set default for nickname preference [core] - 10https://gerrit.wikimedia.org/r/100938 (owner: 10MaxSem) [12:14:15] (03PS1) 10Amire80: RTL icon for search [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101639 [12:15:05] (03Merged) 10jenkins-bot: Clean some phpcs errors in Preferences.php [core] - 10https://gerrit.wikimedia.org/r/101618 (owner: 10Amire80) [12:15:59] (03CR) 10Amire80: "I couldn't find where is this icon actually used. I did flip it, because if it will be used somewhere, it will have to be flipped anyway. " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101639 (owner: 10Amire80) [12:38:20] (03CR) 10IAlex: [C: 04-1] "I don't like these "catch all" hooks, because first you can't simply know which special page it does affect, and second if a special page " [core] - 10https://gerrit.wikimedia.org/r/101063 (owner: 10Legoktm) [12:38:36] (03PS1) 10Aklapper: [4.4] Sync custom file with upstream 4.4 and reapply custom patch [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/101643 [12:39:47] (03PS2) 10IAlex: Add missing directories to findHooks.php [core] - 10https://gerrit.wikimedia.org/r/101070 (owner: 10Legoktm) [12:42:32] (03PS3) 10IAlex: Add missing directories to findHooks.php [core] - 10https://gerrit.wikimedia.org/r/101070 (owner: 10Legoktm) [12:43:04] (03CR) 10IAlex: [C: 032] Add missing directories to findHooks.php [core] - 10https://gerrit.wikimedia.org/r/101070 (owner: 10Legoktm) [12:47:29] (03Merged) 10jenkins-bot: Add missing directories to findHooks.php [core] - 10https://gerrit.wikimedia.org/r/101070 (owner: 10Legoktm) [12:50:48] (03PS1) 10IAlex: Add one more missing directory to findHooks.php [core] - 10https://gerrit.wikimedia.org/r/101644 [13:12:13] (03PS1) 10Shirayuki: i18n: capitalize "Bayesian" [extensions/BayesianFilter] - 10https://gerrit.wikimedia.org/r/101645 [13:56:26] (03PS1) 10IAlex: Use a better regular expression to find documented hooks in findHooks.php [core] - 10https://gerrit.wikimedia.org/r/101650 [14:00:57] (03PS1) 10IAlex: Don't pass $this by reference to SkinVectorStyleModules hook. [core] - 10https://gerrit.wikimedia.org/r/101651 [14:22:04] (03PS1) 10Shirayuki: i18n: replace "wiki" by "project" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/101652 [14:26:48] (03CR) 10Aklapper: [C: 04-1] Add support for Trello URLs to Bugzilla's 'See Also' field. [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/90565 (owner: 10Aklapper) [14:28:04] (03PS1) 10IAlex: Remove unused variable $user from SkinTemplate::outputPage() [core] - 10https://gerrit.wikimedia.org/r/101653 [14:32:28] (03CR) 10Aude: [C: 032] Remove unused variable $user from SkinTemplate::outputPage() [core] - 10https://gerrit.wikimedia.org/r/101653 (owner: 10IAlex) [14:35:06] (03PS3) 10Amire80: Add GENDER and localized number to flow-topic-comments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98769 [14:35:30] (03Merged) 10jenkins-bot: Remove unused variable $user from SkinTemplate::outputPage() [core] - 10https://gerrit.wikimedia.org/r/101653 (owner: 10IAlex) [14:36:10] (03PS1) 10Shirayuki: i18n: make "wiki" lowercase [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/101654 [15:08:06] (03PS1) 10Aklapper: Remove intro hook
from global footer [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/101655 [15:09:00] (03CR) 10Aklapper: [C: 031] Remove intro hook
from global footer [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/101655 (owner: 10Aklapper) [15:12:00] (03PS1) 10IAlex: Remove useless $out parameter from SkinTemplate::prepareQuickTemplate() [core] - 10https://gerrit.wikimedia.org/r/101656 [15:12:17] (03PS1) 10Shirayuki: i18n: make "potentially" lowercase [core] - 10https://gerrit.wikimedia.org/r/101658 [15:34:07] (03CR) 10Parent5446: [C: 04-1] "Inline comments. Also, MemcachedPeclBagOStuff deserves an implementation as well. It could also be implemented for MemcachedPhpBagOStuff, " (033 comments) [core] - 10https://gerrit.wikimedia.org/r/101617 (owner: 10Legoktm) [15:40:42] (03CR) 10Parent5446: [C: 031] Use a better regular expression to find documented hooks in findHooks.php [core] - 10https://gerrit.wikimedia.org/r/101650 (owner: 10IAlex) [15:46:29] (03PS1) 10Umherirrender: Break some lines in Preprocessors [core] - 10https://gerrit.wikimedia.org/r/101660 [15:47:38] (03CR) 10Parent5446: [C: 04-1] "Is this message used anywhere? Also, new messages need an entry in the 'qqq' section of the message file (see https://www.mediawiki.org/wi" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/101494 (owner: 10Apsdehal) [15:49:40] (03CR) 10Parent5446: [C: 04-1] "Inline comments. Also, new messages need an entry in the 'qqq' section of the message file (see https://www.mediawiki.org/wiki/Localisatio" (031 comment) [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/101499 (owner: 10Apsdehal) [15:57:44] (03CR) 10Parent5446: [C: 04-1] "Also, all messages need an entry in qqq." (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 (owner: 10Apsdehal) [16:02:09] (03PS2) 10Amire80: (bug 38474) Mixed directionality of AFT [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/62978 (owner: 10Matthias Mullie) [16:02:22] (03CR) 10Amire80: [C: 032] (bug 38474) Mixed directionality of AFT [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/62978 (owner: 10Matthias Mullie) [16:02:25] (03Merged) 10jenkins-bot: (bug 38474) Mixed directionality of AFT [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/62978 (owner: 10Matthias Mullie) [16:05:41] (03PS2) 10Amire80: (bug 36325) Direction (ltr/rtl) of feedback comments may be different from the direction of the interface language [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/62807 (owner: 10Matthias Mullie) [16:05:48] (03CR) 10Amire80: [C: 032] (bug 36325) Direction (ltr/rtl) of feedback comments may be different from the direction of the interface language [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/62807 (owner: 10Matthias Mullie) [16:05:50] (03Merged) 10jenkins-bot: (bug 36325) Direction (ltr/rtl) of feedback comments may be different from the direction of the interface language [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/62807 (owner: 10Matthias Mullie) [16:26:26] (03PS1) 10IAlex: Document SkinVectorStyleModules hook [core] - 10https://gerrit.wikimedia.org/r/101663 [16:41:39] (03CR) 10IAlex: [C: 04-1] Update comment for wfMsgExt() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100981 (owner: 10Siebrand) [16:53:16] Hello. [17:14:32] (03PS2) 10leucosticte: Add preferences checkbox to email text of watched deleted pages [core] - 10https://gerrit.wikimedia.org/r/101443 [17:15:09] (03CR) 10leucosticte: "Done." (036 comments) [core] - 10https://gerrit.wikimedia.org/r/101443 (owner: 10leucosticte) [17:16:30] (03CR) 10jenkins-bot: [V: 04-1] Add preferences checkbox to email text of watched deleted pages [core] - 10https://gerrit.wikimedia.org/r/101443 (owner: 10leucosticte) [17:32:18] (03PS3) 10leucosticte: Add preferences checkbox to email text of watched deleted pages [core] - 10https://gerrit.wikimedia.org/r/101443 [17:34:20] (03CR) 10jenkins-bot: [V: 04-1] Add preferences checkbox to email text of watched deleted pages [core] - 10https://gerrit.wikimedia.org/r/101443 (owner: 10leucosticte) [17:38:45] (03PS4) 10leucosticte: Add preferences checkbox to email text of watched deleted pages [core] - 10https://gerrit.wikimedia.org/r/101443 [17:43:16] (03PS8) 10Theopolisme: Create jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/99021 [18:28:26] (03PS2) 10IAlex: Add new_name_timestamp index when upgrading from 1.1 [core] - 10https://gerrit.wikimedia.org/r/100176 (owner: 10PleaseStand) [18:28:31] (03CR) 10IAlex: [C: 032] Add new_name_timestamp index when upgrading from 1.1 [core] - 10https://gerrit.wikimedia.org/r/100176 (owner: 10PleaseStand) [18:33:22] (03Merged) 10jenkins-bot: Add new_name_timestamp index when upgrading from 1.1 [core] - 10https://gerrit.wikimedia.org/r/100176 (owner: 10PleaseStand) [18:40:51] (03PS3) 10IAlex: Abstract out mysql_field_type() call from DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/100172 (owner: 10PleaseStand) [18:40:56] (03CR) 10IAlex: [C: 032] Abstract out mysql_field_type() call from DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/100172 (owner: 10PleaseStand) [18:45:47] (03Merged) 10jenkins-bot: Abstract out mysql_field_type() call from DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/100172 (owner: 10PleaseStand) [18:52:39] (03CR) 10Raimond Spekking: Updated Special:GlobalUsers to show creation date of global user account (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 (owner: 10Apsdehal) [18:59:25] (03PS1) 10Jack Phoenix: Default to HTML5 player instead of Flash Player. [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/101672 [19:08:14] (03PS2) 10IAlex: Improve redis connection error log [core] - 10https://gerrit.wikimedia.org/r/95579 (owner: 10Tim Starling) [19:08:36] (03CR) 10IAlex: [C: 032] Improve redis connection error log [core] - 10https://gerrit.wikimedia.org/r/95579 (owner: 10Tim Starling) [19:13:15] (03Merged) 10jenkins-bot: Improve redis connection error log [core] - 10https://gerrit.wikimedia.org/r/95579 (owner: 10Tim Starling) [19:16:18] (03PS4) 10IAlex: Attempt to fix problems noted in phpcs. [core] - 10https://gerrit.wikimedia.org/r/100559 (owner: 10MarkAHershberger) [19:17:01] (03Abandoned) 10Reedy: Pass $title parameter to getCredits() call [core] - 10https://gerrit.wikimedia.org/r/100619 (owner: 10Reedy) [19:18:22] (03CR) 10IAlex: [C: 032] Attempt to fix problems noted in phpcs. [core] - 10https://gerrit.wikimedia.org/r/100559 (owner: 10MarkAHershberger) [19:21:35] (03Merged) 10jenkins-bot: Attempt to fix problems noted in phpcs. [core] - 10https://gerrit.wikimedia.org/r/100559 (owner: 10MarkAHershberger) [19:23:17] (03PS2) 10IAlex: Attempt to fix problems noted in phpcs. [core] - 10https://gerrit.wikimedia.org/r/100561 (owner: 10MarkAHershberger) [19:25:18] (03CR) 10IAlex: [C: 032] Attempt to fix problems noted in phpcs. [core] - 10https://gerrit.wikimedia.org/r/100561 (owner: 10MarkAHershberger) [19:28:59] (03Merged) 10jenkins-bot: Attempt to fix problems noted in phpcs. [core] - 10https://gerrit.wikimedia.org/r/100561 (owner: 10MarkAHershberger) [19:36:49] (03PS1) 10Tpt: Adds a label for Page: pages content [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101678 [19:38:21] (03PS2) 10IAlex: Insert test page into DB not to violate constraint [core] - 10https://gerrit.wikimedia.org/r/100154 (owner: 10saper) [19:38:26] (03CR) 10IAlex: [C: 032] Insert test page into DB not to violate constraint [core] - 10https://gerrit.wikimedia.org/r/100154 (owner: 10saper) [19:38:53] (03CR) 10jenkins-bot: [V: 04-1] Insert test page into DB not to violate constraint [core] - 10https://gerrit.wikimedia.org/r/100154 (owner: 10saper) [19:41:51] (03PS1) 10Tpt: Activate zoom on mouse wheel only when the user have double-clicked [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101679 [19:41:55] (03Merged) 10jenkins-bot: Insert test page into DB not to violate constraint [core] - 10https://gerrit.wikimedia.org/r/100154 (owner: 10saper) [19:51:50] (03PS2) 10IAlex: SpecialUndelete: Use DifferenceEngine#addHeader instead of rolling our own [core] - 10https://gerrit.wikimedia.org/r/100218 (owner: 10Bartosz Dziewoński) [19:52:03] (03CR) 10IAlex: [C: 032] SpecialUndelete: Use DifferenceEngine#addHeader instead of rolling our own [core] - 10https://gerrit.wikimedia.org/r/100218 (owner: 10Bartosz Dziewoński) [19:52:56] (03PS2) 10Tpt: Activate zoom on mouse wheel only when the user have double-clicked [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101679 [19:53:14] (03CR) 10Tpt: "Fix error with unbind" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101679 (owner: 10Tpt) [19:56:45] (03Merged) 10jenkins-bot: SpecialUndelete: Use DifferenceEngine#addHeader instead of rolling our own [core] - 10https://gerrit.wikimedia.org/r/100218 (owner: 10Bartosz Dziewoński) [19:57:28] (03PS1) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/101680 [20:15:48] (03CR) 10Aude: [C: 04-1] "Special:Import still tells me "Q138 All revisions were previously imported." even though they were/are not and don't see them in my databa" [core] - 10https://gerrit.wikimedia.org/r/100563 (owner: 10Daniel Kinzler) [20:33:32] (03CR) 10Brian Wolff: [C: 032] Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/101680 (owner: 10Umherirrender) [20:46:16] (03PS3) 10IAlex: Move functions to better place in Special:Search [core] - 10https://gerrit.wikimedia.org/r/97310 (owner: 10Umherirrender) [20:46:22] (03CR) 10IAlex: [C: 032] Move functions to better place in Special:Search [core] - 10https://gerrit.wikimedia.org/r/97310 (owner: 10Umherirrender) [20:51:13] (03Merged) 10jenkins-bot: Move functions to better place in Special:Search [core] - 10https://gerrit.wikimedia.org/r/97310 (owner: 10Umherirrender) [21:07:30] (03PS3) 10IAlex: Fix HTML output arround HTMLForm's submit buttons when in vform [core] - 10https://gerrit.wikimedia.org/r/96704 [21:08:11] (03CR) 10IAlex: "Inverted nesting" [core] - 10https://gerrit.wikimedia.org/r/96704 (owner: 10IAlex) [21:12:52] (03PS9) 10IAlex: Update Special:ChangePassword to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/80411 [21:45:56] (03PS1) 10Shirayuki: i18n: consistency tweaks [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/101785 [22:16:11] (03PS1) 10Shirayuki: i18n: add full-stop [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/101786 [22:17:34] (03CR) 10Legoktm: "What would you recommend then? I could just add a hook to Special:Block, which is the special page that I want my extension to modify the " [core] - 10https://gerrit.wikimedia.org/r/101063 (owner: 10Legoktm) [22:22:35] (03CR) 10Bartosz Dziewoński: "Yes." [core] - 10https://gerrit.wikimedia.org/r/95742 (owner: 10Bartosz Dziewoński) [22:27:13] (03CR) 10Bartosz Dziewoński: [C: 031] Fix HTML output arround HTMLForm's submit buttons when in vform [core] - 10https://gerrit.wikimedia.org/r/96704 (owner: 10IAlex) [23:01:34] ori-l, around? [23:02:06] [23:02:26] Amgine, hold on, i have another line? [23:02:41] * yurik-road wonders what Amgine is snorting.... [23:02:52] No no no... just amused by silly puns. [23:04:03] yurik-road: briefly; what's up? [23:10:25] (03PS3) 10Aaron Schulz: [WIP] Removed cloudfiles dependency [core] - 10https://gerrit.wikimedia.org/r/101226 [23:11:50] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Removed cloudfiles dependency [core] - 10https://gerrit.wikimedia.org/r/101226 (owner: 10Aaron Schulz) [23:40:23] ori-l, sorry, this stupid IRC program does not notify properly :( I have made tons of great (IMHO!) updates to https://gerrit.wikimedia.org/r/#/c/98767/ -- lots of goodies there. You can start migrating your schema thing to it ;) [23:41:10] yurik-road: wee, cool. I'll look it over. [23:41:38] seriously though, badly need a review - I hope it to be a very capable extension, and allow others to have a single page and complex multi-page configs in many space/subspaces [23:42:08] Yeah, already added myself [23:42:15] as a reviewer, I mean [23:42:34] I have a toothache so I can't focus on anything :/ [23:42:52] but I look forward to seeing what you concoted [23:42:59] (03PS8) 10Yurik: Ported some initial files from Zero extension [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 [23:45:10] (03CR) 10Parent5446: [C: 04-1] Add preferences checkbox to email text of watched deleted pages (036 comments) [core] - 10https://gerrit.wikimedia.org/r/101443 (owner: 10leucosticte) [23:46:16] bummer, sorry ori-l, get that fixed (or pulled)! :) [23:46:37] ori-l, who else might be interested in reviewing? [23:47:18] (03CR) 10Parent5446: "Actually that might be the better option. The reason is because when you have an explicit hook in each individual special page, it becomes" [core] - 10https://gerrit.wikimedia.org/r/101063 (owner: 10Legoktm)