[00:08:44] (03CR) 10CSteipp: [C: 031] "This seems like a sane way to address the problem." [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 (owner: 10Legoktm) [00:28:50] (03PS12) 10saper: Respect CheckUser permissions when linking [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/11562 [00:29:08] (03CR) 10saper: [C: 031] "Rebased, again!" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/11562 (owner: 10saper) [00:47:10] (03CR) 10Krinkle: [C: 04-1] "You might want to look into the following plugins to avoid having to review and maintain this separately (both for developers, as well as " (036 comments) [extensions/ShortUrl] - 10https://gerrit.wikimedia.org/r/74649 (owner: 10Siddhartha Ghai) [00:55:41] greg-g: The mighty deploymight! :D [00:56:13] did I type that? [00:56:28] (03CR) 10Mattflaschen: ""Does it make sense to have a Jenkins job generating a page on doc.wikimedia.org once it gets merged to master?"" [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [00:56:58] Well kind of [00:57:08] Deploymight Highlights [00:58:15] oh man! [00:58:50] haha [00:59:01] And with that, I'm abandoning y'all for the holidays [00:59:34] (03Abandoned) 10Krinkle: Add 'mediawiki.ui' CSS module to all pages [core] - 10https://gerrit.wikimedia.org/r/87296 (owner: 10Mattflaschen) [00:59:47] RoanKattouw_away: latter! [01:00:35] (03PS4) 10Krinkle: JSDuck-ify /resources/mediawiki.language/* [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [01:04:01] (03CR) 10jenkins-bot: [V: 04-1] JSDuck-ify /resources/mediawiki.language/* [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [01:16:16] (03PS1) 10Brian Wolff: Use canonical casing for Xml::option (no code changes) [core] - 10https://gerrit.wikimedia.org/r/101464 [01:30:30] (03CR) 10TTO: "Qqq?" [core] - 10https://gerrit.wikimedia.org/r/101446 (owner: 10Bartosz Dziewoński) [01:32:52] (03PS2) 10Aaron Schulz: [WIP] Removed cloudfiles dependency [core] - 10https://gerrit.wikimedia.org/r/101226 [01:34:35] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Removed cloudfiles dependency [core] - 10https://gerrit.wikimedia.org/r/101226 (owner: 10Aaron Schulz) [01:36:40] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Bah, I knew I forgot about something." [core] - 10https://gerrit.wikimedia.org/r/101446 (owner: 10Bartosz Dziewoński) [01:40:08] (03PS2) 10Bartosz Dziewoński: Make legend on Special:RecentChanges and Special:Watchlist collapsible [core] - 10https://gerrit.wikimedia.org/r/101446 [02:24:04] (03CR) 10Krinkle: [C: 04-1] JSDuck-ify /resources/mediawiki.language/* (032 comments) [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [02:24:23] (03CR) 10Krinkle: "(and the tests, though I'm not sure what made them fail either, they pass in master)." [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [02:25:59] (03CR) 10Krinkle: "It might have to do with the local references no longer being there for getData, which means that an external method overriding one or mor" [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [02:30:46] (03CR) 10Leaves in Motion: "Oh, of course. I forgot to search for a bug. Good to know for the next time :)" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/101055 (owner: 10Leaves in Motion) [02:31:31] (03PS2) 10Mattflaschen: Document the wikipage.content hook [core] - 10https://gerrit.wikimedia.org/r/95330 [02:31:46] (03CR) 10Mattflaschen: "Replied inline." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/95330 (owner: 10Mattflaschen) [02:33:27] (03CR) 10Krinkle: [C: 031] Document the wikipage.content hook [core] - 10https://gerrit.wikimedia.org/r/95330 (owner: 10Mattflaschen) [02:33:36] (03CR) 10Krinkle: [C: 032] Document the wikipage.content hook [core] - 10https://gerrit.wikimedia.org/r/95330 (owner: 10Mattflaschen) [02:36:44] (03Merged) 10jenkins-bot: Document the wikipage.content hook [core] - 10https://gerrit.wikimedia.org/r/95330 (owner: 10Mattflaschen) [02:45:02] (03CR) 10Mattflaschen: [C: 04-1] "Can you add the new test, rather than replacing the old one?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95962 (owner: 10Bartosz Dziewoński) [02:58:40] (03PS1) 10Legoktm: rtrim doesn't work [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/101469 [03:00:57] (03PS1) 10Krinkle: mediawiki.action.edit.preview: Run hook on detached node [core] - 10https://gerrit.wikimedia.org/r/101470 [03:54:36] (03PS4) 10Brian Wolff: Begin indexing file text from pdf/djvu files [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 (owner: 10Chad) [04:00:57] (03PS4) 10Brian Wolff: Fix outdated comment in DefaultSettings [core] - 10https://gerrit.wikimedia.org/r/85420 (owner: 10TTO) [04:01:38] (03CR) 10Brian Wolff: [C: 032] "Sorry this took so long. First time I read it, I read to quickly and thought you were modifying the WMF config file." [core] - 10https://gerrit.wikimedia.org/r/85420 (owner: 10TTO) [04:02:07] (03CR) 10Mattflaschen: [C: 04-1] "Needs rebase." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/79917 (owner: 10MarkTraceur) [04:05:46] (03Merged) 10jenkins-bot: Fix outdated comment in DefaultSettings [core] - 10https://gerrit.wikimedia.org/r/85420 (owner: 10TTO) [04:17:09] (03PS1) 10Legoktm: Show log extract on Special:WikiSets [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101471 [04:20:09] (03CR) 10Legoktm: [C: 032 V: 032] rtrim doesn't work [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/101469 (owner: 10Legoktm) [04:23:44] (03PS4) 10Brian Wolff: Only show 'Show extended details' for file metadata having extra rows [core] - 10https://gerrit.wikimedia.org/r/99744 (owner: 10Umherirrender) [04:24:13] (03CR) 10Brian Wolff: [C: 032] "Tested. Works well and looks good." [core] - 10https://gerrit.wikimedia.org/r/99744 (owner: 10Umherirrender) [04:29:17] (03Merged) 10jenkins-bot: Only show 'Show extended details' for file metadata having extra rows [core] - 10https://gerrit.wikimedia.org/r/99744 (owner: 10Umherirrender) [04:41:08] (03CR) 10Legoktm: Updated Special:GlobalUsers to show creation date of global user account (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 (owner: 10Apsdehal) [04:42:12] (03CR) 10MarkTraceur: jquery audit of mw.DestinationChecker.js (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86804 (owner: 10MarkTraceur) [04:54:00] (03PS5) 10MarkTraceur: No need to use custom mw.log anymore [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/79917 [04:55:37] (03CR) 10Legoktm: Ignore testRunLegacyHooks in findHooks.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/101069 (owner: 10Legoktm) [04:56:59] (03PS2) 10Legoktm: Ignore testRunLegacyHooks in findHooks.php [core] - 10https://gerrit.wikimedia.org/r/101069 [05:17:05] (03CR) 10Brian Wolff: [C: 04-1] "This change is doing something different from what the bug is asking for. On the bug, the request appears to want broken redirects exclude" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/54120 (owner: 10devunt) [05:20:33] (03CR) 10Brian Wolff: [C: 04-1] "Given that the performance issues aren't critical, I would prefer a solution is found for adding to Special:Upload before the module is re" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/99597 (owner: 10Ori.livneh) [05:22:51] (03CR) 10Legoktm: "If it's just needed on Special:Upload, won't checking that $out->getTitle()->isSpecial( 'Upload' ) before adding the modules work?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/99597 (owner: 10Ori.livneh) [05:33:35] (03PS3) 10Brian Wolff: Make visibleMetadataField protected [core] - 10https://gerrit.wikimedia.org/r/99455 (owner: 10Siebrand) [05:35:23] hello yurik r u der? [05:35:27] (03CR) 10Brian Wolff: [C: 032] "I was originally opposed to this, as the MediaHandler class is one of the most public interfaces we have, and I don't think we should brea" [core] - 10https://gerrit.wikimedia.org/r/99455 (owner: 10Siebrand) [05:37:30] (03PS2) 10Brian Wolff: Make visibleMetadataField protected [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/99429 (owner: 10Siebrand) [05:37:39] (03CR) 10Brian Wolff: [C: 032] Make visibleMetadataField protected [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/99429 (owner: 10Siebrand) [05:37:57] (03Merged) 10jenkins-bot: Make visibleMetadataField protected [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/99429 (owner: 10Siebrand) [05:38:24] legoktm: that's not a bad idea [05:38:47] (03Merged) 10jenkins-bot: Make visibleMetadataField protected [core] - 10https://gerrit.wikimedia.org/r/99455 (owner: 10Siebrand) [05:39:14] :D [05:39:48] yeah, that sounds like a good solution to me too [05:42:24] yurik whenever you come ol pls ping me i want to show u d tutorials i have made on parsing [05:46:12] bawolff: ok, don't run anywhere, I'll update the patch [05:46:17] ori-l: Hmm, that change seems to break Special:Listfiles even though it shouldn't [05:46:54] yeah, it makes sense [05:47:00] special pages will require it [05:47:19] or rather, special pages won't be covered by the parser hook [05:47:51] are there others? [05:50:45] Special:MostLinkedFiles, Special:UncategorizedFiles, Special:UnusedFiles, Special:FileDuplicateSearch? [05:51:10] Special:newFiles [05:52:07] possibly special:Search [05:54:04] Special:MyFiles Special:AllMyFiles Special:MyUploads Special:AllMyUploads [05:54:52] Those all are redirects, you shouldn't need to include them [05:55:01] Not in core, but Special:GlobalUsage [05:57:05] There should really be a better interface where this is automatically taken into account [05:59:56] a "FIXME: There should really be a better interface" is far better than a "FIXME: We should stop loading this on EVERY page" [06:00:24] yes definitely [06:00:28] loading it only on special pages would still be an improvement [06:00:57] i thought about that, but that's being unfair to highly-trafficked special pages that aren't liable to have timed media, like recent changes [06:01:06] true [06:01:25] You must admit though that this is a pretty poor interface... [06:01:51] bawolff: i can go further and call it a kludge [06:02:11] i'm unabashedly single-minded [06:02:22] that said, i don't want to be a pig and just break things [06:03:05] This would still break an edge case with foreign files, but I think that's rare enough to just not care [06:03:12] (03PS1) 10Legoktm: Initial commit [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101473 [06:03:24] (03CR) 10Legoktm: [C: 032 V: 032] Initial commit [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101473 (owner: 10Legoktm) [06:03:27] bawolff: what's the case? [06:04:07] If you have a non-video file on commons, put embeds a video in its description, the video won't work properly when the description is viewed on wikipedia [06:04:55] I don't really see any good solution to that [06:05:35] s/put embeds/but embeds/ [06:09:01] Speaking of better interfaces, adding modules should maybe be handled by the MediaTransformOutput object, then SpecialPages would at least not have to be special cased (That's just an aside for future me to look into) [06:12:12] Hmm, kind of odd TMH is using an OuputHook when all its doing is adding modules, which can be accomplished more directly. Its probably copying off OggHandler [06:24:19] hello yurik [06:25:30] diwanship: You can tell how likely it is that yurik is online, by doing "/whois yurik yurik" which will give you how long he has been idle for (currently he's been away for 11 hours...) [06:26:14] bawolff, i'm here :) [06:26:25] just haven't written anything :) [06:26:27] oops...:P [06:26:33] hi diwanship [06:26:50] ah :) [06:26:56] had another window up, didn't see all the comotions :) [06:27:12] sorry :) [06:27:30] no problm...:) [06:28:44] just wanted to show u d tutorials of parsing 1) http://www.codecademy.com/courses/web-intermediate-en-BLea4/0/9 2)http://www.codecademy.com/courses/web-intermediate-en-BLea4/0/10 [06:28:47] (03CR) 10MZMcBride: Updated Special:GlobalUsers to show creation date of global user account (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 (owner: 10Apsdehal) [06:32:44] diwanship, you need to rework the text a bit - its not very clear what you are trying to explain and what the user should do [06:33:05] the code is ok, but this is instructions, we should probably improve it a bit [06:33:56] diwanship, also, you might want to put the result and the HTML visually into two boxes on the output - instead of simple text [06:34:26] i would suggest some
with a css style for api result and for the html result [06:36:34] ok ok [06:36:50] (03PS3) 10Ori.livneh: Only load mw.PopUpMediaTransform on pages that plausibly need it [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/99597 [06:36:53] (03CR) 10jenkins-bot: [V: 04-1] Only load mw.PopUpMediaTransform on pages that plausibly need it [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/99597 (owner: 10Ori.livneh) [06:37:27] so yes, the code is ok, but we need to actually present this as a learning material that explains what it is you are trying to achieve and how to get there [06:38:34] Yes so i should more concentrate on presenting the output and instructions [06:38:39] (03PS4) 10Ori.livneh: Only load mw.PopUpMediaTransform on pages that plausibly need it [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/99597 [06:44:10] (03CR) 10Brian Wolff: [C: 032] Removed excess title validity check [core] - 10https://gerrit.wikimedia.org/r/99598 (owner: 10Aaron Schulz) [06:50:39] ori-l: ugh, we forgot that normal image pages also wouldn't have the image necessarily in the parsed text. [06:52:46] Could make TimedMediaHandler hook into ImageOpenShowImageInlineBefore, in order for it to easily check if its a TMH handled file [06:59:13] (03CR) 10Brian Wolff: [C: 04-1] "Sorry I didn't see this earlier, but this will also break image pages that don't have a media file in the wikitext." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/99597 (owner: 10Ori.livneh) [07:01:45] (03CR) 10Brian Wolff: "addendum, if you used that function, you would also have to make sure the handler isn't false." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/99597 (owner: 10Ori.livneh) [07:02:09] bawolff: sorry, just saw your note [07:02:16] no problem, I'll update the patch, tho probably tomorrow [07:02:41] ok. sorry I didn't notice that earlier when I was testing the first time [07:02:45] nah, thanks for thinking this through [07:24:59] (03PS1) 10Legoktm: Allow the AbuseFilter to access the confidence level [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101475 [07:25:18] (03CR) 10Legoktm: [C: 032 V: 032] Allow the AbuseFilter to access the confidence level [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101475 (owner: 10Legoktm) [07:39:58] (03PS1) 10Legoktm: Use SpecialBlockModifyFormFields hook [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101476 [07:40:32] (03CR) 10Legoktm: [C: 032 V: 032] Use SpecialBlockModifyFormFields hook [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101476 (owner: 10Legoktm) [07:42:14] (03PS1) 10Legoktm: JavaScript cleanup [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101478 [07:43:07] (03PS2) 10Legoktm: JavaScript cleanup [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101478 [07:43:33] (03CR) 10Legoktm: [C: 032 V: 032] JavaScript cleanup [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101478 (owner: 10Legoktm) [07:54:23] (03PS1) 10Brian Wolff: Mark ParserOutput of MessageContent as varying by userlanguage [core] - 10https://gerrit.wikimedia.org/r/101479 [07:54:52] (03PS4) 10Inchikutty: Replacing 'show on map' button with a link [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/101029 [08:03:17] (03CR) 10Brian Wolff: Updated Special:GlobalUsers to show creation date of global user account (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 (owner: 10Apsdehal) [08:04:00] bawolff: you don't like lego??? [08:04:17] How can one not like Lego? [08:04:29] unless you have stepped on one of course… [08:05:17] You can never find the piece you need... [08:16:50] (03PS2) 10Aaron Schulz: Added a page_links_updated column for job de-duplication [core] - 10https://gerrit.wikimedia.org/r/101170 [08:21:27] hi, anybody can say what happens with html tables classes like class="wikitable" or class="TablePager" after MediaWiki 1.18 ? [08:23:07] (03PS1) 10Pastakhov: use array_merge for $bytecode instead of $bytecode[] [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/101480 [08:25:20] (03CR) 10Pastakhov: [C: 032] use array_merge for $bytecode instead of $bytecode[] [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/101480 (owner: 10Pastakhov) [08:25:27] (03Merged) 10jenkins-bot: use array_merge for $bytecode instead of $bytecode[] [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/101480 (owner: 10Pastakhov) [08:29:44] (03CR) 10Brian Wolff: [C: 04-1] "I'm not sure I see a need for a preference for this (unnecessary prefs are evil). If there really is a need, should probably have a corres" [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 (owner: 10Legoktm) [08:52:31] (03PS10) 10Legoktm: Load scripts and styles via ResourceLoader [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 [09:01:17] (03PS1) 10Tpt: Increase scan size on horizontal edit mode [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101481 [09:02:32] (03PS1) 10Tpt: Remove dead code in zoom system [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101482 [09:18:18] (03CR) 10Legoktm: "The usecase I was thinking of is if you have your global scripts run on all your wikis except for your main homewiki, where you have local" [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 (owner: 10Legoktm) [09:29:04] (03CR) 10Apsdehal: Updated Special:GlobalUsers to show creation date of global user account (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 (owner: 10Apsdehal) [10:03:14] Strange thing with table aligments for classes "wikitable" and "standard" as you can see at https://www.mediawiki.org/wiki/User_talk:Evgen2 is it bug? [10:11:34] (03CR) 10TTO: "Pleeeeease can you review/merge this?? :)" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/76460 (owner: 10TTO) [10:14:02] (03CR) 10Legoktm: [C: 031] "Since this is a breaking change, you should send an email to the mediawiki-api list (https://lists.wikimedia.org/mailman/listinfo/mediawik" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/76460 (owner: 10TTO) [11:09:31] (03CR) 10Umherirrender: [C: 031] Use canonical casing for Xml::option (no code changes) [core] - 10https://gerrit.wikimedia.org/r/101464 (owner: 10Brian Wolff) [11:18:22] (03CR) 10Hoo man: [C: 04-1] "To avoid a premature merge" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/87546 (owner: 10Stwalkerster) [11:18:42] Nemo_bis: ^ just adding more reviewers can't be the solution if waiting for the owner [11:20:02] hoo: thanks, but what do you mean? he said he had addressed the CR comments [11:20:29] Nemo_bis: Nah, the last one to comment was /me [11:20:52] W/o that question I would have already merged this [11:21:36] despite that it lacks tests... but that's pretty much standard :/ [11:22:29] but maybe he doesn't know the answer either :) if nobody has ideas, maybe we should open a bugzilla ticket to discuss more, dunno [11:23:33] Nemo_bis: Bah... that's to much work [11:23:38] I'll rather fix it myself then [11:23:55] I guess I can do this tonight [11:24:11] maybe I'll even write a few phpunits on top, if I'm in the mood, let's see [11:24:41] Nemo_bis: For gerrit: 100724 I am not sure that I can directly edit the qqq page for 'createaccount' on translatewiki.net [11:25:25] MegaAlex: have you followed https://translatewiki.net/wiki/Special:FirstSteps ? if not do it now and I'll authorise you immediately [11:25:53] thanks for taking care of those old bugs, they were quite confusing but you helped us close them :) [11:29:22] request sent, thanks :) [11:30:44] MegaAlex: done [11:33:15] hoo: ok; personally I hadn't understood that your question was a positive suggestion :) [11:34:28] Nemo_bis: heh :) I just don't like API responses to change, so that I want to have things right before the initial merge ;) [11:34:36] ... perfectionism :P [11:34:43] sure [11:44:09] Ok, I think that I have fixed the qqq text, should I revert the login button label back to 'login'? :) [11:46:27] (03PS5) 10Nemo bis: Link to existing login help page by default from helplogin-url [core] - 10https://gerrit.wikimedia.org/r/83220 [11:46:34] (03PS2) 10IAlex: Use canonical casing for Xml::option (no code changes) [core] - 10https://gerrit.wikimedia.org/r/101464 (owner: 10Brian Wolff) [11:46:39] (03CR) 10IAlex: [C: 032] Use canonical casing for Xml::option (no code changes) [core] - 10https://gerrit.wikimedia.org/r/101464 (owner: 10Brian Wolff) [11:47:06] (03CR) 10jenkins-bot: [V: 04-1] Link to existing login help page by default from helplogin-url [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [11:47:31] (03CR) 10Nemo bis: Link to existing login help page by default from helplogin-url (031 comment) [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [11:52:02] (03Merged) 10jenkins-bot: Use canonical casing for Xml::option (no code changes) [core] - 10https://gerrit.wikimedia.org/r/101464 (owner: 10Brian Wolff) [11:54:14] (03PS2) 10Umherirrender: Expand CleanupPreferences script to handle unused preferences [core] - 10https://gerrit.wikimedia.org/r/101233 [11:54:32] (03PS6) 10Nemo bis: Link to existing login help page by default from helplogin-url [core] - 10https://gerrit.wikimedia.org/r/83220 [11:57:17] thedj: thedj[work]: Anyone around? :D [12:00:53] (03PS3) 10IAlex: Replace deprecated notifyRC2UDP() with notifyRCFeeds(). [core] - 10https://gerrit.wikimedia.org/r/98971 (owner: 10Siebrand) [12:00:59] (03CR) 10IAlex: [C: 032] Replace deprecated notifyRC2UDP() with notifyRCFeeds(). [core] - 10https://gerrit.wikimedia.org/r/98971 (owner: 10Siebrand) [12:01:04] (03CR) 10Umherirrender: "Patch Set 2: Addressed comments" (038 comments) [core] - 10https://gerrit.wikimedia.org/r/101233 (owner: 10Umherirrender) [12:05:49] (03Merged) 10jenkins-bot: Replace deprecated notifyRC2UDP() with notifyRCFeeds(). [core] - 10https://gerrit.wikimedia.org/r/98971 (owner: 10Siebrand) [12:08:21] hey multichill, were you able to sort out the permissions on beta with hashar? [12:08:35] Nope, not yet [12:08:40] I haven't seen him online yet [12:10:10] dan-nl: Want to play around, but that's not possible now :-( [12:10:29] hmm … let's see if someone in #wikimedia-labs can help [12:12:01] multichill: what is your beta user name? [12:12:12] is it mutlichill? [12:12:17] of course [12:12:23] :) [12:13:49] so as an admin you can't add yourself to the group? [12:14:20] Nope [12:14:46] dan-nl: You can see who can assign what at http://commons.wikimedia.beta.wmflabs.org/wiki/Special:ListGroupRights [12:15:43] dan-nl: For the Rijksmuseum I figured out their identifiers. accession number":"BK-15258-C; RM0001.COLLECT.51009". First part (BK-15258-C) can be used to link to their website, the second part is stable identifier for handle.net [12:16:45] multichill: it looks like an admin can add a group to their own account. were you not able to? http://commons.wikimedia.beta.wmflabs.org/wiki/Special:UserRights [12:17:56] dan-nl: No, look at http://commons.wikimedia.beta.wmflabs.org/wiki/Special:ListGroupRights [12:17:56] Add groups: Rollbackers, Confirmed users, Patrollers, Autopatrollers, File movers, Image reviewers, IP block exemptions and Upload Wizard campaign editors [12:18:04] Remove groups: Rollbackers, Confirmed users, Patrollers, Autopatrollers, File movers, Image reviewers, IP block exemptions and Upload Wizard campaign editors [12:19:09] (03CR) 10Parent5446: ">.< Well if there is no LIMIT on the DELETE statement then it's going to be too slow because it's no longer in batches. In that case just " [core] - 10https://gerrit.wikimedia.org/r/101233 (owner: 10Umherirrender) [12:19:11] confusing list … guess this is only for translation admins … Add group to own account: Translation administrators [12:30:07] (03PS1) 10UltrasonicNXT: Escape smiley character codes [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/101486 [12:30:29] (03CR) 10Parent5446: "Two last minor thinks." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/101233 (owner: 10Umherirrender) [12:31:38] (03PS2) 10UltrasonicNXT: Escape smiley character codes [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/101486 [12:33:25] (03CR) 10Parent5446: [C: 031] Ignore testRunLegacyHooks in findHooks.php [core] - 10https://gerrit.wikimedia.org/r/101069 (owner: 10Legoktm) [12:33:27] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Escape smiley character codes [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/101486 (owner: 10UltrasonicNXT) [12:46:20] (03CR) 10Hoo man: "Or what about role="alert"?" [core] - 10https://gerrit.wikimedia.org/r/82122 (owner: 10Hoo man) [13:15:49] (03PS1) 10Dan-nl: add-project-link [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 [13:16:11] (03CR) 10Rtdwivedi: [C: 031] Remove dead code in zoom system [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/101482 (owner: 10Tpt) [13:29:04] multichill: just showing up for a few minutes :D [13:29:09] multichill: dan-nl : got a change that would potentially let sysop add/remove the gwtoolset group https://gerrit.wikimedia.org/r/#/c/101488/ [13:29:57] (03CR) 10Bartosz Dziewoński: "Re pt-login, I think it's better this way – both the link in personal menu and the button represent an action "to login", while the page t" [core] - 10https://gerrit.wikimedia.org/r/100724 (owner: 10MegaAlex) [13:35:10] (03CR) 10Bartosz Dziewoński: jquery.client: Component-wise version comparison in #test with strings (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95962 (owner: 10Bartosz Dziewoński) [13:36:11] (03CR) 10Bartosz Dziewoński: "Will merge-conflict with https://gerrit.wikimedia.org/r/#/c/99714/ :(" [core] - 10https://gerrit.wikimedia.org/r/101470 (owner: 10Krinkle) [13:37:29] thanks hashar … i couldn't +2 it [13:37:46] dan-nl: yeah the changes made on operations/mediawiki-config.git would impact production [13:37:55] so that is reserved to people having shell access on cluster [13:38:04] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Actually, I think this could be reimplemented on top of that, the logic will be less ugly." [core] - 10https://gerrit.wikimedia.org/r/101470 (owner: 10Krinkle) [13:38:11] i.e. ops / mwcore team (i.e. me, reedy, aaron..) + some folks from feature teams so they can deploy [13:38:26] unfortunately, volunteers / non shell users can't deploy such changes yet :( [13:39:09] cool, so should we add one of them to it or can you self +2 ? [13:44:14] i can +2 [13:44:16] and di [13:44:32] d [13:44:44] so sysops should be able to add remove gwtoolset group now [13:44:45] thanks [13:45:08] the only trouble I have is that we have too many different user rights management pages :D [13:45:13] (03CR) 10Nemo bis: "ok" [core] - 10https://gerrit.wikimedia.org/r/100724 (owner: 10MegaAlex) [13:47:16] i agree … find that list confusing [13:50:34] heading out :-D [13:50:51] dan-nl: I am off, might check my emails later tonight [13:51:02] cool, thanks for your help hashar [13:55:50] (03CR) 10Multichill: [C: 04-1] "As discussed on irc. I think it's a better idea to do this in i18n so that we can just override it on Commons." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 (owner: 10Dan-nl) [14:02:33] (03CR) 10Bartosz Dziewoński: [C: 031] Link to existing login help page by default from helplogin-url [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [14:03:37] MatmaRex: I finally stopped waiting ;) [14:04:19] heh [14:06:06] Nemo_bis: what are we going to do with wikimedia wikis which have actually created and customized that page? [14:06:22] (i don't remember if this was ever discussed) [14:08:00] they'll change the link if the bother; nobody had asked or was notified of its appearance either [14:09:39] i would imagine many wikis would have a help page for this already before the new login form existed [14:09:55] and i would imagine the translators would translate the link to something that already existed on their home wikis [14:10:47] Nemo_bis: https://www.wikidata.org/wiki/Q3511761 [14:16:39] MatmaRex: even more so then, those pages were not created on purpose for being linked from userlogin so there's nothing to worry about if they aren't [14:17:15] Nemo_bis: https://pl.wikipedia.org/wiki/Pomoc:Logowanie [14:17:40] the it.wiki page doesn't have any relationship with the link [14:18:32] yep, that page is pre-existing as you said, so no problem [14:19:11] (03PS2) 10Dan-nl: add-project-link [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 [14:20:31] (03CR) 10Dan-nl: "addressing multichill’s comments" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 (owner: 10Dan-nl) [14:26:28] Nemo_bis: unassigned the shorturl bug from myself, btw. Forgot it was assigned to me. Thanks for pointing it out [14:27:08] :) [14:30:38] (03CR) 10Multichill: [C: 031] "Looks good!" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101487 (owner: 10Dan-nl) [14:34:50] (03PS3) 10IAlex: (bug 40889) Follow-up 6f1d4db3: Fix the upload form when radio buttons are shown. [core] - 10https://gerrit.wikimedia.org/r/88443 (owner: 10VitaliyFilippov) [14:34:55] (03CR) 10IAlex: [C: 032] (bug 40889) Follow-up 6f1d4db3: Fix the upload form when radio buttons are shown. [core] - 10https://gerrit.wikimedia.org/r/88443 (owner: 10VitaliyFilippov) [14:39:48] (03Merged) 10jenkins-bot: (bug 40889) Follow-up 6f1d4db3: Fix the upload form when radio buttons are shown. [core] - 10https://gerrit.wikimedia.org/r/88443 (owner: 10VitaliyFilippov) [14:51:44] (03PS2) 10IAlex: UserArray: Avoid * and double keys in select [core] - 10https://gerrit.wikimedia.org/r/98254 (owner: 10Umherirrender) [14:51:51] (03CR) 10IAlex: [C: 032] UserArray: Avoid * and double keys in select [core] - 10https://gerrit.wikimedia.org/r/98254 (owner: 10Umherirrender) [14:56:41] (03Merged) 10jenkins-bot: UserArray: Avoid * and double keys in select [core] - 10https://gerrit.wikimedia.org/r/98254 (owner: 10Umherirrender) [15:24:36] (03PS1) 10Anomie: Use WikiPage::prepareContentForEdit in SpamBlacklistHooks::filterMergedContent [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/101490 [16:07:27] Who does beta shit besides hashar? [16:08:17] (03CR) 10MZMcBride: "Hashar: I added you as a reviewer here because this affects Beta Labs. If there's a better person to review this change, please let me kno" [core] - 10https://gerrit.wikimedia.org/r/95878 (owner: 10Alex Monk) [16:29:48] (03PS6) 10Amire80: Better GENDER support in moderation.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 [16:30:15] (03CR) 10Amire80: [C: 04-1] "Rebased. -1 per above comments. I'm trying to improve it." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 (owner: 10Amire80) [16:35:10] (03CR) 10Nikerabbit: [C: 04-1] "There is really no reason to show this number at all. So, if we are showing it, it might as well be formatted in whatever way we want." [core] - 10https://gerrit.wikimedia.org/r/101221 (owner: 10Ebrahim) [16:41:29] (03PS2) 10Ebrahim: i18n: Native digits on user id on preference [core] - 10https://gerrit.wikimedia.org/r/101221 [16:46:13] (03PS3) 10Apsdehal: Updated Special:GlobalUsers to show creation date of global user account [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 [16:54:26] (03CR) 10Nemo bis: "Does the formatted number then work where it's meant to be used, e.g. Special:Userrights?" [core] - 10https://gerrit.wikimedia.org/r/101221 (owner: 10Ebrahim) [17:21:21] (03CR) 10Brian Wolff: Only load mw.PopUpMediaTransform on pages that plausibly need it (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/99597 (owner: 10Ori.livneh) [17:48:40] (03PS1) 10Brian Wolff: Make SVG language selector use default lang better [core] - 10https://gerrit.wikimedia.org/r/101493 [18:09:10] (03PS2) 10Apsdehal: Added message for key 'abusefilter-edit-warn-view' to AbuseFilter.i18n.php [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/101494 [18:11:16] (03PS1) 10Ebrahim: i18n: Native digits on #wpLocalTime [core] - 10https://gerrit.wikimedia.org/r/101495 [18:12:19] (03CR) 10jenkins-bot: [V: 04-1] i18n: Native digits on #wpLocalTime [core] - 10https://gerrit.wikimedia.org/r/101495 (owner: 10Ebrahim) [18:19:41] (03CR) 10Ebrahim: "I can not see where user id (not user name) is used on Special:Userrights. Are you sure there is another usage for user id there?" [core] - 10https://gerrit.wikimedia.org/r/101221 (owner: 10Ebrahim) [18:26:47] (03PS2) 10Ebrahim: i18n: Native digits on #wpLocalTime [core] - 10https://gerrit.wikimedia.org/r/101495 [18:29:42] hello yurik [18:34:18] (03PS17) 10Physikerwelt: Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 [18:34:33] (03CR) 10jenkins-bot: [V: 04-1] Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 (owner: 10Physikerwelt) [18:34:36] (03PS52) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [18:37:27] (03PS3) 10Ebrahim: i18n: Native digits on #wpLocalTime [core] - 10https://gerrit.wikimedia.org/r/101495 [19:07:21] @notify dan-nl [19:07:21] I'll let you know when I see dan-nl around here [19:09:19] (03CR) 10Brian Wolff: "For reference original issue report at https://commons.wikimedia.org/w/index.php?title=Template_talk:Translate&oldid=111841370" [core] - 10https://gerrit.wikimedia.org/r/101493 (owner: 10Brian Wolff) [19:17:37] (03CR) 10Legoktm: [C: 04-1] Add an API module for querying the AntiSpoof results without having to attempt to create an account. (035 comments) [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/87546 (owner: 10Stwalkerster) [19:24:00] physikerwelt: i'm running the test sample now [19:26:41] (03PS3) 10Umherirrender: Expand CleanupPreferences script to handle unused preferences [core] - 10https://gerrit.wikimedia.org/r/101233 [19:27:21] (03CR) 10Umherirrender: "Patch Set 3: Addressed comments" (035 comments) [core] - 10https://gerrit.wikimedia.org/r/101233 (owner: 10Umherirrender) [19:33:50] (03CR) 10UltrasonicNXT: "Ah, just realised that would be pointless, there is makeLink() for that." [core] - 10https://gerrit.wikimedia.org/r/100816 (owner: 10UltrasonicNXT) [19:34:06] (03CR) 10Helder.wiki: Reformat the license warning only if available (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/98249 (owner: 10Dev-zero) [19:41:22] (03PS1) 10UltrasonicNXT: Add in a pair of missing braces [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/101497 [19:41:45] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Add in a pair of missing braces [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/101497 (owner: 10UltrasonicNXT) [19:42:12] (03CR) 10Calak: [C: 031] i18n: Native digits on #wpLocalTime [core] - 10https://gerrit.wikimedia.org/r/101495 (owner: 10Ebrahim) [19:48:23] (03PS1) 10IAlex: Don't pass the Title object as third argument to CreditsSourceAction::getCredits() [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/101498 [19:51:02] (03CR) 10IAlex: [C: 04-1] "Better fix in Ie10606be7f7ea706f398a6d748509a8da2a01f16" [core] - 10https://gerrit.wikimedia.org/r/100619 (owner: 10Reedy) [19:55:52] (03PS4) 10MZMcBride: Expand CleanupPreferences script to handle unused preferences [core] - 10https://gerrit.wikimedia.org/r/101233 (owner: 10Umherirrender) [19:57:14] (03CR) 10MZMcBride: "https://gerrit.wikimedia.org/r/101233 does the same." [core] - 10https://gerrit.wikimedia.org/r/100938 (owner: 10MaxSem) [19:57:34] (03CR) 10MZMcBride: "Cross-referencing ." [core] - 10https://gerrit.wikimedia.org/r/101233 (owner: 10Umherirrender) [20:12:02] (03PS1) 10Apsdehal: Added i18n functions and messages to PageSchemas [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/101499 [20:13:14] (03CR) 10MZMcBride: "I agree that a user preference should be unnecessary here. This opt-in feature targets power-users who can understand that global means gl" [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 (owner: 10Legoktm) [20:22:45] (03PS1) 10Manybubbles: Change betafeatures text [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101500 [20:26:09] (03CR) 10Nemo bis: "The user id (preceded by #) can be used as more reliable replacement of the username in some special pages which ask username as input. I " [core] - 10https://gerrit.wikimedia.org/r/101221 (owner: 10Ebrahim) [20:27:12] Nemo_bis: special:renameuser too iirc [20:28:26] legoktm: I tried but it didn't work [20:28:50] Hmmmmm. [20:29:02] maybe I'm misremembering then... [20:29:04] but I hadn't also provided a target username, maybe the error message was wrong [20:29:17] (03CR) 10MZMcBride: "I agree with Nike: I'm not sure why user ID is exposed." [core] - 10https://gerrit.wikimedia.org/r/101221 (owner: 10Ebrahim) [20:30:35] iirc in ancient times the only way to know user id was purodha's dbswithuser.php; or maybe that was for other users [20:31:45] The API has exposed it for a long time. [20:31:49] Because that's a programmatic interface. [20:31:59] But for index.php, I don't see much value. [20:32:15] Special:UserRights has the capability as a(n) historical quirk. [20:32:20] Because Unicode is hard. [20:36:47] Sure. I'm not defending that feature, just saying it exists. :) [20:37:04] :-) [20:37:08] I may file a bug about user ID. [20:37:29] "Investigate removing user IDs from the database" [20:37:37] It's probably not less useless than the editcount [20:38:27] legoktm: Eep, not the database! [20:38:30] Just the GUI. [20:38:35] https://bugzilla.wikimedia.org/show_bug.cgi?id=32493 [20:38:37] (03CR) 10Manybubbles: "Probably should also update the documentation of the job to show that it is being used by revision delete as well." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101447 (owner: 10Chad) [20:38:38] I marked that easy. [20:38:46] user id is exposed so users can compare their lengths [20:38:51] …of time spent of wikipedia. [20:39:25] heh [20:39:39] ApiUserRights just calls the special page internally [20:41:06] It's our soft-enforcing of the implicit gerontocracy of the wiki [20:42:56] https://bugzilla.wikimedia.org/show_bug.cgi?id=8816 [20:43:00] Marked as unconfirmed. [20:46:54] (03CR) 10TheDJ: [C: 031] "Looks alright to me. And this is probably gonna be easier to work with for now then reimplementing everything from scratch in php." [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 (owner: 10Physikerwelt) [20:47:28] (03PS1) 10Legoktm: Explicitly support user id in action=userrights [core] - 10https://gerrit.wikimedia.org/r/101502 [20:48:51] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/101512 (owner: 10L10n-bot) [20:48:54] (03PS2) 10Legoktm: Explicitly support user id in action=userrights [core] - 10https://gerrit.wikimedia.org/r/101502 [20:49:24] legoktm: STOP STEALING ALL THE BUGS. [20:49:39] I was tempted to mark the bug as RESOLVED WORKSFORME. [20:50:06] I'd actually written a reply to you... [20:50:56] heh :) [20:56:11] (03PS3) 10Legoktm: Explicitly support user id in action=userrights [core] - 10https://gerrit.wikimedia.org/r/101502 [21:07:35] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/101512 (owner: 10L10n-bot) [21:22:59] (03CR) 10Parent5446: [C: 031] "Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/101233 (owner: 10Umherirrender) [21:45:07] (03PS1) 10Legoktm: Send IP of logged in users too [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101599 [21:45:08] (03PS1) 10Legoktm: Actually load the i18n messages [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101600 [21:45:09] (03PS1) 10Legoktm: Block IP addresses listed on blacklists [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101601 [21:45:58] (03CR) 10Legoktm: [C: 032 V: 032] Send IP of logged in users too [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101599 (owner: 10Legoktm) [21:46:14] (03CR) 10Legoktm: [C: 032 V: 032] Actually load the i18n messages [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101600 (owner: 10Legoktm) [21:50:28] (03PS2) 10Legoktm: Block IP addresses listed on blacklists [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101601 [22:18:07] (03CR) 10Legoktm: [C: 032 V: 032] Block IP addresses listed on blacklists [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101601 (owner: 10Legoktm) [23:01:36] (03PS1) 10Skizzerz: Change blacklist caching mechanism, which should cut down on memory usage within the cache and when making the blacklist [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101602 [23:07:06] (03PS2) 10Skizzerz: Change blacklist caching mechanism [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101602 [23:24:12] (03PS7) 10Amire80: Better GENDER support in moderation.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 [23:33:33] (03CR) 10Legoktm: "Will test in a moment" (032 comments) [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101602 (owner: 10Skizzerz) [23:41:13] MatmaRex: http://www.bullshikipedia.com/index.php/Special:RecentChanges <-- that's the legend that was in 1.16 [23:41:26] I'm assuming that its standard [23:43:12] (03CR) 10Legoktm: [C: 04-1] "PHP Parse error: syntax error, unexpected '(' in /vagrant/mediawiki/extensions/StopForumSpam/StopForumSpam.body.php on line 14" [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101602 (owner: 10Skizzerz) [23:53:41] legoktm: huh. well, there's no such thing now. [23:55:19] yeah, I wonder where it went [23:57:11] (03PS3) 10Skizzerz: Change blacklist caching mechanism [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/101602 [23:58:24] is it still there in monobook? [23:58:38] nope