[00:00:24] TimStarling: anyway, considering how insanely expensive parsing is, I think storing a much of page_id,timestamp values on disk somewhere is reasonable [00:00:45] timestamps would be compared to rootJobTimestamp [00:01:22] (03CR) 10Catrope: [C: 032 V: 032] Update EducationProgram to wmf7 branch for cherry-picks [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/101141 (owner: 10Catrope) [00:01:34] I wonder if db0:keys counts everything [00:02:16] a timestamp should be a 32 bit value, is there really a need to store it on disk? [00:03:50] (03CR) 10BryanDavis: [C: 031] "JobQueueDB::doPop() and JobQueueRedis::doPop() will both discard the job if Title::makeTitleSafe() returns a falsy value." [core] - 10https://gerrit.wikimedia.org/r/99598 (owner: 10Aaron Schulz) [00:03:53] maybe it could go in memcached, provided it doesn't flood that slab with tens of millions of values [00:04:05] (03Merged) 10jenkins-bot: Updating Collection to deploy branch [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/101145 (owner: 10Mwalker) [00:04:26] not sure what kind of LRU churn we have there now [00:05:20] if each job has a start timestamp then at least for something like parsoid it would be relatively simple to conver the run method into a no-op with an If-Unmodified-Since header [00:05:43] right, since you have varnish persistently storing the objects/timestamps for you [00:05:52] or whatever medium it may be later [00:05:56] not sure if the same principle could be used based on page_touched or the like [00:06:07] (03Merged) 10jenkins-bot: Switching Collection to deploy branch [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/101143 (owner: 10Mwalker) [00:06:23] well not page_touched itself since I don't want jobs to bump that and cause cache misses on views [00:07:11] could add a field to the page table [00:07:33] for refreshLinks it seems that the rendering of templates could change [00:07:58] TimStarling: I mentioned page_links_touched...I was just afraid of a schema change ;) [00:08:05] but if that's OK it would be ideal [00:08:19] it would take up the least space [00:08:49] no need to duplicate the titles that way [00:09:04] right [00:10:30] (03PS1) 10EBernhardson: Put the submit button back inside the form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101149 [00:10:48] ok, add a field [00:11:20] the update rate will be lower than page_touched, and like you say, hardly significant compared to the cost of a parse [00:12:25] (03CR) 10Krinkle: "some post-merge feedback" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [00:12:26] maybe work out how many updates per second we can expect and run that figure by springle, to be on the safe side [00:12:26] can you give me a hint on why it is ok not to update page_touched on refreshLinks? [00:12:50] gwicke: because you didn't do anything that requires cache invalidation [00:13:08] page_touched would have already been updated by htmlCacheUpdate [00:13:13] all it should do is update the backlinks...it's htmlcacheupdate that is responsible for purging squids and bumping page_touched [00:13:35] ah, the htmlCacheUpdate is the bit I was missing [00:13:46] thanks [00:15:07] (03PS1) 10MarkTraceur: Backport MultimediaViewer event handler fix [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/101150 [00:16:10] (03PS1) 10MarkTraceur: Backport MultimediaViewer event handler fix [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/101151 [00:16:20] (03CR) 10MarkTraceur: [C: 032 V: 032] Backport MultimediaViewer event handler fix [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/101150 (owner: 10MarkTraceur) [00:16:26] (03CR) 10MarkTraceur: [C: 032 V: 032] Backport MultimediaViewer event handler fix [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/101151 (owner: 10MarkTraceur) [00:16:34] TimStarling: sure, I remember the reason for isQueueDeprioritized() originally goes back to slave lag and slower index scans (probably some long running trxs somewhere) [00:17:09] I guess we'd want to make sure we were not doing something to similarly bad, though this would involve far less data change and index updates that the DB job queue did at that time [00:17:31] * Aaron|home will talk to springle later [00:17:54] (03PS1) 10Chad: Support MediaWiki-style parameters to messages ($1, $2, etc) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101152 [00:17:55] (03PS1) 10Chad: Localize login form [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101153 [00:17:56] (03PS1) 10Chad: Localize error page [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101154 [00:17:57] (03PS1) 10Chad: Localize parts of base that weren't [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101155 [00:18:36] heh, in theory one could stage these kind of updates in a redis hash first and flush it randomly(to get batching optimizations) like a poor man's LSM [00:18:59] * Aaron|home would like to keep this super simple though [00:19:00] (03CR) 10Chad: Localize error page (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101154 (owner: 10Chad) [00:20:15] page_touched update queries from htmlCacheUpdate have not been a significant performance problem [00:20:39] well, the parses caused by the invalidation are a performance problem, but not the actual updates :) [00:20:52] so I wouldn't expect this to be a problem either [00:21:05] (03PS1) 10Chad: Localize 404 page [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101156 [00:21:35] right, though they are batched instead 1 at a time, though I suppose refreshLinks is self-throttled by parsing so it's probably on par for the course [00:22:01] (03CR) 10Parent5446: [C: 04-1] Ignore testRunLegacyHooks in findHooks.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/101069 (owner: 10Legoktm) [00:22:13] (03CR) 10Parent5446: [C: 031] Add missing directories to findHooks.php [core] - 10https://gerrit.wikimedia.org/r/101070 (owner: 10Legoktm) [00:22:47] (03CR) 10EBernhardson: [C: 032] Add callback when form & editor have completed loading [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100830 (owner: 10Matthias Mullie) [00:23:09] (03CR) 10Parent5446: [C: 031] Add hook for modifying FormSpecialPage fields [core] - 10https://gerrit.wikimedia.org/r/101063 (owner: 10Legoktm) [00:24:48] Is there a way to tell if the parser is parsing the main article text for an article or some ancillary stuff? [00:25:05] Semantic MediaWiki appears to assume that all text parsed with a given title is that article's main text [00:25:13] and uses a hook in ParserAfterTidy to run semantic data updates [00:25:50] meaning that any time a message is parsed on a page with semantic data, SMW extracts semantic data from the message text and replaces the page's semantic data with the message's semantic data [00:26:18] hook LinkUpdates [00:26:21] (03Merged) 10jenkins-bot: Add callback when form & editor have completed loading [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100830 (owner: 10Matthias Mullie) [00:27:06] LinksUpdate or LinksUpdateComplete [00:27:26] * Aaron|home always chuckles at thinks like <> [00:27:41] they are given a LinksUpdate object which has getParserOutput() [00:27:50] * werdna sighs. [00:27:50] \0\0\0\0\0\0\0\0\0\0\0\0\0\0 :) [00:27:55] I guess I should do this properly. [00:28:08] Was hoping for a one-line fix, but you're right, I should change it to use the correct hook. [00:28:10] you can use ParserOutput::setExtensionData() to send any data to LinksUpdate that you need to send [00:29:36] Oh, I didn't realise there was a function for that. I always just attached them as member variables [00:29:41] AaronSchulz: you should use varbinary(14) don't follow that example [00:29:47] $parserOutput->myExtensionData = 'Some data' [00:30:19] yeah, that's how it used to be done, now we have setExtensionData() for the same thing [00:30:39] * @since 1.21 [00:31:49] (03CR) 10Jdlrobson: [C: 032] mediawiki.mixins: Remove -o and -moz vendor prefixes for transition [core] - 10https://gerrit.wikimedia.org/r/99779 (owner: 10JGonera) [00:34:46] (03PS2) 10BryanDavis: Support MediaWiki-style parameters to messages ($1, $2, etc) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101152 (owner: 10Chad) [00:34:52] (03Merged) 10jenkins-bot: mediawiki.mixins: Remove -o and -moz vendor prefixes for transition [core] - 10https://gerrit.wikimedia.org/r/99779 (owner: 10JGonera) [00:35:56] TimStarling: for some reason they try to call "getDefaultSort()" on the parser, any idea where I could get that from? [00:36:57] public function setDefaultSort( $sort ) { [00:36:57] $this->mDefaultSort = $sort; [00:36:58] $this->mOutput->setProperty( 'defaultsort', $sort ); [00:36:58] } [00:36:58] looks like it's just set by ParserFunctions [00:37:07] aha [00:37:13] didn't notice the second line [00:37:21] yeah, you could use getProperty() [00:38:28] yep, got it :) [00:41:16] (03CR) 10BryanDavis: [C: 032] Support MediaWiki-style parameters to messages ($1, $2, etc) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101152 (owner: 10Chad) [00:41:19] (03Merged) 10jenkins-bot: Support MediaWiki-style parameters to messages ($1, $2, etc) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101152 (owner: 10Chad) [00:41:36] (03PS2) 10BryanDavis: Localize login form [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101153 (owner: 10Chad) [00:43:17] (03CR) 10BryanDavis: [C: 032] Localize login form [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101153 (owner: 10Chad) [00:44:09] (03Merged) 10jenkins-bot: Localize login form [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101153 (owner: 10Chad) [00:44:26] (03PS2) 10BryanDavis: Localize error page [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101154 (owner: 10Chad) [00:50:13] (03PS3) 10BryanDavis: Localize error page [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101154 (owner: 10Chad) [00:51:01] (03CR) 10BryanDavis: [C: 032] Localize error page [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101154 (owner: 10Chad) [00:51:04] (03Merged) 10jenkins-bot: Localize error page [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101154 (owner: 10Chad) [00:51:32] (03CR) 10EBernhardson: "Looks good, one bug though:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101001 (owner: 10Matthias Mullie) [00:51:36] (03PS2) 10BryanDavis: Localize parts of base that weren't [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101155 (owner: 10Chad) [00:52:02] (03PS1) 10Chad: Move all CirrusSearch hooks into one file [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101157 [00:52:21] (03PS2) 10Chad: Move all CirrusSearch hooks into one file [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101157 [00:54:12] (03CR) 10BryanDavis: [C: 032] Localize parts of base that weren't [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101155 (owner: 10Chad) [00:54:19] (03Merged) 10jenkins-bot: Localize parts of base that weren't [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101155 (owner: 10Chad) [00:54:25] (03PS2) 10BryanDavis: Localize 404 page [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101156 (owner: 10Chad) [00:55:26] (03CR) 10BryanDavis: [C: 032] Localize 404 page [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101156 (owner: 10Chad) [00:55:30] (03Merged) 10jenkins-bot: Localize 404 page [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101156 (owner: 10Chad) [00:56:22] (03PS2) 10Tim Starling: Plural rules: updates for UTS #35 Rev 33 [core] - 10https://gerrit.wikimedia.org/r/100931 [00:57:36] (03PS3) 10BryanDavis: Remove closed, private and fishbowl wikis [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101051 [01:01:46] (03CR) 10Chad: [C: 032] Remove closed, private and fishbowl wikis [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101051 (owner: 10BryanDavis) [01:01:51] (03Merged) 10jenkins-bot: Remove closed, private and fishbowl wikis [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101051 (owner: 10BryanDavis) [01:02:16] Look at all that lovely scholarship spam [01:02:27] *scholarships [01:05:01] (03CR) 10Tim Starling: "PS2: added handling for "other" rules which have an empty condition. Confirmed that the new plurals.xml can be compiled without exceptions" [core] - 10https://gerrit.wikimedia.org/r/100931 (owner: 10Tim Starling) [01:15:07] (03CR) 10EBernhardson: "seems to be the right direction, although it seems like we are duplicating the same code in the various templates with slightly different " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 (owner: 10Matthias Mullie) [01:15:43] (03PS1) 10Bsitu: No Reply button after clicking Be the first to comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101164 [01:16:13] (03PS2) 10Bsitu: No Reply button after clicking Be the first to comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101164 [01:24:33] (03CR) 10EBernhardson: "I like the idea, although i suppose to go farther need to see how much time we are willing to dedicate to it." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99004 (owner: 10Matthias Mullie) [01:27:22] Aaron|home: ping [01:29:03] (03PS1) 10Krinkle: Update oojs to v1.0.6 [core] - 10https://gerrit.wikimedia.org/r/101167 [01:29:55] (03CR) 10EBernhardson: "Also needs prevent the 'Last Week' group from containing the history items" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101059 (owner: 10Bsitu) [01:31:04] (03CR) 10Jforrester: [C: 032] Update oojs to v1.0.6 [core] - 10https://gerrit.wikimedia.org/r/101167 (owner: 10Krinkle) [01:32:19] gwicke_away: hm? [01:33:50] (03PS1) 10BryanDavis: Generate language list from Lang [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101169 [01:34:27] * Aaron|home wants to eat pizzzacat but doesn't want to choke on fur... [01:34:35] (03Merged) 10jenkins-bot: Update oojs to v1.0.6 [core] - 10https://gerrit.wikimedia.org/r/101167 (owner: 10Krinkle) [01:35:07] (03CR) 10BryanDavis: Generate language list from Lang (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101169 (owner: 10BryanDavis) [01:35:40] (03PS1) 10Aaron Schulz: Added a page_links_updated column for job de-duplication [core] - 10https://gerrit.wikimedia.org/r/101170 [01:37:49] gwicke_away: I didn't test though, not sure how [01:41:51] (03CR) 10Aaron Schulz: [C: 04-2] "Needs schema change" [core] - 10https://gerrit.wikimedia.org/r/101170 (owner: 10Aaron Schulz) [02:24:47] Hey how do I run an API request as a given user from a maintenance script [02:27:19] werdna: maintenance/editpage.php does that, I think. [02:27:38] Sorry, edit.php. [02:28:10] nup, it uses doEditContent [02:28:31] Hrmm. [02:31:18] https://github.com/wikimedia/mediawiki-extensions-MassMessage/blob/master/MassMessageJob.php is a bit more abstract. [02:31:50] Not sure it'll help. [02:32:34] looks out of date :/ [02:32:51] I'm futzing with RequestContexts at the moment [02:33:07] MassMessage was written in the past few months. It's not out of date. [02:34:36] (03CR) 10Scimonster: Add legend to Special:RecentChanges and Special:Watchlist (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [02:35:01] Gloria: well, it's broken then :p [02:35:13] werdna: It's deployed to Wikimedia wikis. [02:35:18] RequestContext::getMain()->setUser( $wgUser ); [02:35:19] RequestContext::getMain()->setRequest( $wgRequest ); [02:35:24] thaaat is terrifying [02:35:49] If you say so. :-) [02:35:57] well, it just changes the user that the request comes from [02:36:20] I don't *think* it's actually a security bug, because jobs are done at the end of a request (and not in a request at all on WMF), so it's proobably safe [02:36:52] * Gloria shrugs. [03:02:39] (03PS1) 10BryanDavis: Use session to remember language selection [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101175 [04:40:06] (03PS1) 10BryanDavis: Use select for language choice [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101176 [04:40:14] (03CR) 10jenkins-bot: [V: 04-1] Use select for language choice [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101176 (owner: 10BryanDavis) [04:42:55] (03PS2) 10BryanDavis: Use select for language choice [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101176 [04:52:42] So when doing profiling locally, how is it that 109.5% of the time is spent in Parser::internalParse (As in how is it > 100% ) [04:54:19] Multiple cores? [04:54:22] Bad math? [04:55:19] probably the second [04:55:27] (03CR) 10Tim Starling: "Please name the new files after the classes they contain." [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/99541 (owner: 10MaxSem) [04:57:05] hmm, especially since the profiling report says Parser::internalParse took 20 seconds, but firebug says it only took 18 seconds to load the page [04:58:46] and I'm pretty sure that php does not have multicore support at all [05:17:22] [05:35:22] hello yurik are u der? [06:00:07] diwanship, there :) [06:02:18] yes yurik i hav got a lil bit confused between text and title parameters [06:02:37] diwanship, figured it out or still confused? [06:03:54] i dont knw i am right or wrong the title is what a user give to a page and text can have a pagename or a text entered by user [06:04:14] and that text is converted to wikitext then?? [06:07:29] (03CR) 10Mattflaschen: "Thanks for the update. It looks really solid for the most part. See inline." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/98589 (owner: 10Bartosz Dziewoński) [06:07:38] (03CR) 10Mattflaschen: [C: 04-1] "See patch set 2." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98589 (owner: 10Bartosz Dziewoński) [06:09:14] (03PS1) 10BryanDavis: Stop referencing Config inside objects [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101177 [06:10:36] yurik for example please have a look at this http://www.codecademy.com/courses/web-intermediate-en-BLea4/0/9 have i made it right? [06:12:30] yurik one more question what difference it make if i use //simple.wikipedia.org/w/api.php or //en.wikipedia.org/w/api.php? [06:13:15] diwanship, it looks right, but getting HTML text in the api result like that is hard to read - i would recommend rendering it as HTML somewhere - i think in one of my original courseworks I had one of the slides show it as html [06:13:27] (03CR) 10Mattflaschen: "Actually, it would be good to rename the 'createacct-captcha' and 'createacct-imgcaptcha-ph' message keys as well." [core] - 10https://gerrit.wikimedia.org/r/98589 (owner: 10Bartosz Dziewoński) [06:13:57] simple has better data - its easier to read by those who are not very good in english [06:14:18] brr... i don't think that came out very "englishy" [06:14:34] yurik yes i'l do that just needed to know that its right or not.. [06:14:36] anyway, simple english wiki is an easier one to understand [06:15:05] sure. Btw, {{India}} itself is a bit confusing - people would think that "India" is the name of the article, but its not [06:15:59] might want to choose some template that has a telling name [06:17:24] yurik this is why i got confused in text and title i think title is what a user give to a page and text can have a pagename or a text entered by user m i right? [06:18:59] text is the wiki markup text [06:19:22] title is used just to understand which namespace it belongs to [06:19:41] so if title is missing, the text belongs to the page called "API" [06:20:32] imagine you started a new article - if you start it in the main namespace, it has some "context", that might be different than if you start it as a category or template page [06:20:39] usually the result is almost identical [06:20:47] but in some corner cases it might be different [06:23:24] yurik ok understood it thanks [06:27:12] (03PS1) 10Apsdehal: Updated Special:GlobalUsers to show creation date of global user account [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 [06:48:09] (03CR) 10Brian Wolff: [C: 04-1] "Generally looks good (however I haven't tested yet as I don't have the extension set up currently). Some minor issues with MediaWiki codin" (035 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 (owner: 10Apsdehal) [07:05:13] (03PS2) 10Inchikutty: Replacing 'show on map' button with a link [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/101029 [07:30:12] (03PS2) 10Apsdehal: Updated Special:GlobalUsers to show creation date of global user account [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/101178 [07:42:09] AaronSchulz: Is this one interesting? PHP Fatal error: Call to a member function isError() on a non-object in /www/translatewiki.net/w/includes/filerepo/file/File.php on line 907 [07:43:42] AaronSchulz: IIRC transform() can return false, in which case $thumb->isError() would cause this. [07:43:52] I'll report a bug. [07:44:19] In fact, it looks like transform would never return null, only false on failure [07:46:37] bawolff: I reported https://bugzilla.wikimedia.org/show_bug.cgi?id=58436 [07:46:59] bawolff: I think this was recently reworked. There may be similar incorrect assumptions. [07:48:22] git blame says hasn't changed since 2009 [07:55:42] (03CR) 10Legoktm: [C: 04-1] "Did a quick review with CSteipp today, discussed that this should follow $wgUseSiteCss and relatives." [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 (owner: 10Legoktm) [08:02:25] (03PS1) 10Brian Wolff: Fix error handling in File::createThumb. [core] - 10https://gerrit.wikimedia.org/r/101179 [08:02:35] siebrand: --^ [08:14:41] (03PS1) 10Brian Wolff: Fix getLongDesc if tif file is invalid or has invalid metadata [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/101180 [08:36:55] (03PS9) 10Legoktm: Load scripts and styles via ResourceLoader [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 [08:40:04] bawolff: *nod* looks good. I'll leave it for Aaron, because he may realise there is more that's not right. I haven't blamed the rev it came from. [08:40:26] Cool cool [09:13:26] (03PS1) 10Raimond Spekking: Add i18n file [extensions/PageTools] - 10https://gerrit.wikimedia.org/r/101183 [09:29:40] (03PS2) 10Raimond Spekking: Add message for 1.22 now that it is in Special:ExtensionDistributor [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/100803 [09:31:24] (03CR) 10Brian Wolff: "once this is deployed, someone should delete the mediawiki ns message I created earlier today" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/100803 (owner: 10Raimond Spekking) [10:50:10] (03CR) 10Nikerabbit: [C: 04-1] Added a page_links_updated column for job de-duplication (031 comment) [core] - 10https://gerrit.wikimedia.org/r/101170 (owner: 10Aaron Schulz) [10:50:22] (03PS4) 10MaxSem: Add new one-column diff mode [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/99541 [11:35:19] (03CR) 10Jack Phoenix: "Frankly this reminds me of $wgSysopUserBans (https://www.mediawiki.org/wiki/Manual:$wgSysopUserBans), which is one of those globals that s" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/100770 (owner: 10UltrasonicNXT) [11:57:34] (03PS6) 10Yurik: Ported some initial files from Zero extension [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 [11:59:18] (03CR) 10Jack Phoenix: [C: 04-1] "First, the usual coding style nitpicks:" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/100767 (owner: 10UltrasonicNXT) [12:04:34] interesting coincidence of the patch numbers ^ [12:14:22] (03CR) 10Foxtrott: [C: 032 V: 032] "Thanks!" [extensions/PageTools] - 10https://gerrit.wikimedia.org/r/101183 (owner: 10Raimond Spekking) [12:17:29] (03CR) 10Jack Phoenix: [C: 032 V: 032] "The code is essentially rather old (see https://www.mediawiki.org/wiki/Social_tools for some historical background and whatnot) and the or" [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/98353 (owner: 10saper) [12:58:45] hey siebrand, when you get a chance, can you take a look at https://gerrit.wikimedia.org/r/#/c/101008/ today? [13:39:29] (03CR) 10Daniel Kinzler: [C: 031] "Seems sensible, but needs manual testing, on PostGres and others DBs." [core] - 10https://gerrit.wikimedia.org/r/100183 (owner: 10saper) [13:48:57] (03CR) 10Bartosz Dziewoński: "Might have caused bug 58447 :(" [core] - 10https://gerrit.wikimedia.org/r/84991 (owner: 10Krinkle) [13:50:53] (03CR) 10Matthias Mullie: [C: 04-1] History in '4 hours ago' should not be included in 'Today' (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101059 (owner: 10Bsitu) [13:51:07] (03PS2) 10Matthias Mullie: History in '4 hours ago' should not be included in 'Today' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101059 (owner: 10Bsitu) [13:51:22] (03CR) 10Matthias Mullie: [C: 032] History in '4 hours ago' should not be included in 'Today' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101059 (owner: 10Bsitu) [13:51:48] (03Merged) 10jenkins-bot: History in '4 hours ago' should not be included in 'Today' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101059 (owner: 10Bsitu) [14:00:49] (03CR) 10Matthias Mullie: [C: 031] "Just added another suggestions, but I'm ok with the patch as-is too." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101120 (owner: 10EBernhardson) [14:19:24] (03PS3) 10Matthias Mullie: Crib some css from VE for empty external links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99520 (owner: 10EBernhardson) [14:19:38] (03CR) 10Matthias Mullie: "Submitted another patch to fix my remark" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99520 (owner: 10EBernhardson) [14:19:43] (03CR) 10Matthias Mullie: [C: 031] Crib some css from VE for empty external links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99520 (owner: 10EBernhardson) [14:26:30] (03PS1) 10Matthias Mullie: Fix tests; cache expects cachetime now [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101208 [14:27:11] (03CR) 10Matthias Mullie: [C: 032] Test case for redlink handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100405 (owner: 10EBernhardson) [14:27:20] (03Merged) 10jenkins-bot: Test case for redlink handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100405 (owner: 10EBernhardson) [14:32:16] (03CR) 10PiRSquared17: [C: 031] Add global groups to Special:CentralAuth/Username [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97851 (owner: 10Legoktm) [14:32:57] (03CR) 10PiRSquared17: [C: 031] Add local user group membership to Special:CentralAuth/Username [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97757 (owner: 10Gerrit Patch Uploader) [14:48:14] (03CR) 10Manybubbles: [C: 032] Rename $wgCirrusSearchContentReplicaCount to $wgCirrusSearchReplicaCount [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/100821 (owner: 10Chad) [14:48:20] (03Merged) 10jenkins-bot: Rename $wgCirrusSearchContentReplicaCount to $wgCirrusSearchReplicaCount [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/100821 (owner: 10Chad) [14:57:16] anybody knows where wikipedia zero people live? [14:57:34] I have tried #wikimedia-zero and #wikipedia-zero, but nobody is there :) [15:01:24] zeljkof: i think the people is basically yurik [15:01:40] plus mobilefrontend guys & gals [15:01:47] MatmaRex: thanks :) [15:01:58] will try in #wikimedia-mobile then [15:18:53] (03CR) 10Matthias Mullie: [C: 031] Filter the display of content via a hook (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100604 (owner: 10EBernhardson) [15:18:57] (03PS2) 10Matthias Mullie: Filter the display of content via a hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100604 (owner: 10EBernhardson) [15:19:09] (03CR) 10Matthias Mullie: [C: 032] Filter the display of content via a hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100604 (owner: 10EBernhardson) [15:19:20] (03Merged) 10jenkins-bot: Filter the display of content via a hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100604 (owner: 10EBernhardson) [15:25:13] (03CR) 10Manybubbles: [C: 032] "I _love_ it!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101157 (owner: 10Chad) [15:25:16] (03Merged) 10jenkins-bot: Move all CirrusSearch hooks into one file [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101157 (owner: 10Chad) [15:31:27] (03CR) 10Matthias Mullie: "Patch looks good." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [15:34:49] (03CR) 10Matthias Mullie: [C: 032] Disable external entity loading in libxml [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100904 (owner: 10EBernhardson) [15:34:59] (03Merged) 10jenkins-bot: Disable external entity loading in libxml [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100904 (owner: 10EBernhardson) [15:36:32] manybubbles: do you know if elastic search boxes on beta cluster have to access beta URL such as en.wikipedia.beta.wmflabs.org ? [15:36:49] manybubbles: cause that is not going to work unless we use some IP packets rewriting via iptables. [15:37:14] manybubbles: I know that lucene indexer was using the wiki URL to index pages, not sure about elastic [15:37:14] hashar: sorry, what isn't going to work? [15:37:21] ah sorry [15:37:42] so whenever you want to hit en.wikipedia.beta.wmflabs.org from an instance, the DNS server gives the public IP address [15:37:56] due to NAT, that public IP is not reachable from an instance [15:38:05] thus you can't access en.wikipedia.beta.wmflabs.org from inside [15:38:11] hashar: Elasticsearch doesn't hit MediaWiki at all. it goes the other way around. [15:38:14] (03CR) 10BryanDavis: [C: 032] "Let's get this tested on beta." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101008 (owner: 10Dan-nl) [15:38:21] manybubbles: excellent :-] [15:38:26] so you will befine [15:38:30] its been working for months too! [15:38:36] (03Merged) 10jenkins-bot: user-job-throttle [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/101008 (owner: 10Dan-nl) [15:38:36] ah, you mean it is changing [15:38:39] yeah, I won't notice [15:38:39] was wondering if I should apply the network rewriting hack on the elastic instances [15:38:50] ah and it has been working, yeah true [15:38:53] so it is safe :-] [15:39:05] you can contextSwitch( context->previous ) [15:40:56] hashar: thanks! [15:42:25] (03CR) 10Matthias Mullie: [C: 032] Put the submit button back inside the form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101149 (owner: 10EBernhardson) [15:42:52] (03Merged) 10jenkins-bot: Put the submit button back inside the form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101149 (owner: 10EBernhardson) [15:48:07] (03CR) 10BryanDavis: [C: 032] "The new ProcessCacheLRU cleans that up a lot." [core] - 10https://gerrit.wikimedia.org/r/98899 (owner: 10Aaron Schulz) [15:51:16] (03Merged) 10jenkins-bot: Made RepoGroup use ProcessCacheLRU [core] - 10https://gerrit.wikimedia.org/r/98899 (owner: 10Aaron Schulz) [16:04:49] (03CR) 10Matthias Mullie: Load usernames directly from wiki's in batches (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 (owner: 10EBernhardson) [16:18:32] (03Abandoned) 10UltrasonicNXT: Allow the disabling of comment blocks [extensions/Comments] - 10https://gerrit.wikimedia.org/r/100770 (owner: 10UltrasonicNXT) [16:27:30] out of here see you monday [16:28:45] (03CR) 10UltrasonicNXT: "Hmm, re the UI, when I did this, I was considering adding a more extensive UI, but apart from being much easier ( ;) ), the tooltip UI is " [extensions/Comments] - 10https://gerrit.wikimedia.org/r/100767 (owner: 10UltrasonicNXT) [16:37:33] (03PS2) 10UltrasonicNXT: Add ability to show who has voted for a comment [extensions/Comments] - 10https://gerrit.wikimedia.org/r/100767 [16:41:47] hello yurik [16:43:31] hey, I'm trying to add a user to the group for the extension I'm the administrator for on gerrit, but I'm not having any luck, can anyone give me a hand for this? Cheers [17:03:03] (03PS1) 10Ebrahim: i18n: Native digits on user id on preference [core] - 10https://gerrit.wikimedia.org/r/101221 [17:05:30] (03PS1) 10UltrasonicNXT: Show different messages to blocked users and anons [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/101222 [17:13:21] (03PS1) 10UltrasonicNXT: Add $wgChatWikiText [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/101223 [17:18:37] (03PS1) 10Anomie: Fix WikiPage::prepareContentForEdit's default format handling [core] - 10https://gerrit.wikimedia.org/r/101224 [17:21:58] (03CR) 10jenkins-bot: [V: 04-1] Fix WikiPage::prepareContentForEdit's default format handling [core] - 10https://gerrit.wikimedia.org/r/101224 (owner: 10Anomie) [17:30:32] (03CR) 10Chad: [C: 032] Generate language list from Lang [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101169 (owner: 10BryanDavis) [17:30:38] (03Merged) 10jenkins-bot: Generate language list from Lang [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101169 (owner: 10BryanDavis) [17:31:12] (03CR) 10Chad: [C: 032] Use session to remember language selection [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101175 (owner: 10BryanDavis) [17:31:16] (03Merged) 10jenkins-bot: Use session to remember language selection [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101175 (owner: 10BryanDavis) [17:31:42] (03CR) 10Chad: [C: 032] Use select for language choice [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101176 (owner: 10BryanDavis) [17:31:48] (03Merged) 10jenkins-bot: Use select for language choice [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101176 (owner: 10BryanDavis) [17:32:09] <^d> bd808: yay i18n :) [17:32:24] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Show different messages to blocked users and anons [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/101222 (owner: 10UltrasonicNXT) [17:33:54] (03PS1) 10Aaron Schulz: [WIP] Removed cloudfiles dependency [core] - 10https://gerrit.wikimedia.org/r/101226 [17:35:00] ^d: \o/ [17:35:34] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Removed cloudfiles dependency [core] - 10https://gerrit.wikimedia.org/r/101226 (owner: 10Aaron Schulz) [17:36:33] * bd808 waits patiently for jenkins to merge [17:36:50] (03CR) 10Amire80: "Some comments, before proper testing:" [core] - 10https://gerrit.wikimedia.org/r/101221 (owner: 10Ebrahim) [17:39:53] (03PS2) 10UltrasonicNXT: Add $wgChatRichMessages [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/101223 [17:41:05] merge all the stuffs! :) [17:42:17] (03PS1) 10Chad: Localize base_auth form [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101227 [17:44:56] (03PS1) 10Chad: Localize change password form [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101232 [17:45:05] <^d> localize all the forms! [17:45:46] :) [17:48:03] (03PS2) 10Chad: Localize change password form [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101232 [17:48:20] (03CR) 10Calak: [C: 031] i18n: Native digits on user id on preference [core] - 10https://gerrit.wikimedia.org/r/101221 (owner: 10Ebrahim) [17:49:49] <^d> Only forms that aren't localized are admin & review now, I think [17:53:17] (03PS1) 10Umherirrender: Expand CleanupPreferences script to handle unused preferences [core] - 10https://gerrit.wikimedia.org/r/101233 [17:58:30] (03CR) 10Umherirrender: "Feel free to work on this patch or to fork!" [core] - 10https://gerrit.wikimedia.org/r/101233 (owner: 10Umherirrender) [18:01:12] Aaron|home: let me test it locally then [18:05:09] (03PS1) 10Chad: Localize admin pages [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101234 [18:08:18] (03PS1) 10Chad: Localize part of login form that was missed [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101235 [18:08:52] <^d> bd808: Just finished reviewing all the forms. Everything's now localized other than the review forms. [18:08:55] <^d> :) [18:09:08] (03PS1) 10EBernhardson: Gracefully handle errors applying redlinks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101236 [18:09:50] ^d: Sweet. I'm hip deep in an email to Ellie + fixing the hard coded numbers in the Apply DAO [18:11:11] kill the hard coding! [18:11:48] (03CR) 10Chad: [C: 032] Stop referencing Config inside objects [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101177 (owner: 10BryanDavis) [18:11:49] (03CR) 10jenkins-bot: [V: 04-1] Stop referencing Config inside objects [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101177 (owner: 10BryanDavis) [18:12:44] ^d: I can fix that merge conflict in a bit [18:12:58] <^d> Yeah no rush :) [18:14:15] aude: When I'm done with the patch I'm working on things should be ready for a follow on patch that puts settings in the database and gives them an admin interface (hint, hint) [18:14:29] (03CR) 10Aaron Schulz: [C: 032] Fix error handling in File::createThumb. [core] - 10https://gerrit.wikimedia.org/r/101179 (owner: 10Brian Wolff) [18:14:46] :) [18:17:31] (03Merged) 10jenkins-bot: Fix error handling in File::createThumb. [core] - 10https://gerrit.wikimedia.org/r/101179 (owner: 10Brian Wolff) [18:18:21] (03PS2) 10EBernhardson: Gracefully handle errors applying redlinks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101236 [18:21:20] (03PS2) 10Anomie: Fix WikiPage::prepareContentForEdit's default format handling [core] - 10https://gerrit.wikimedia.org/r/101224 [18:21:21] (03PS1) 10Anomie: Fix TextContent::preSaveTransform() return type [core] - 10https://gerrit.wikimedia.org/r/101238 [18:21:27] mwalker: https://gerrit.wikimedia.org/r/101236 [18:24:47] (03PS1) 10Chad: Localize about half of the review forms [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101239 [18:26:16] (03PS3) 10UltrasonicNXT: Add $wgChatRichMessages [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/101223 [18:26:28] (03CR) 10UltrasonicNXT: [C: 032 V: 032] Add $wgChatRichMessages [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/101223 (owner: 10UltrasonicNXT) [18:27:07] ^d: https://www.mediawiki.org/wiki/Gerrit/Project_ownership#aarcos_.2B2_for_MultimediaViewer can has reviewer? :D [18:27:22] Also srsly, aude's +2. [18:31:38] <^d> marktraceur: I'm not sure there's consensus on aude ;-) [18:31:55] Yeah, there might be fifteen more people who want to +1 her [18:32:00] ^d: https://gerrit.wikimedia.org/r/#/c/99598/ easy commit :) [18:32:09] Hate to take away their opportunity to support [18:32:35] <^d> AaronSchulz: I thought I merged that before? [18:32:43] <^d> Or was that on refreshLinksJob2? [18:32:48] <^d> :) [18:34:56] <^d> marktraceur: Now we can deluge aude in things to review :p [18:36:57] Sweet [18:37:01] (03CR) 10Anomie: [C: 032] Clean up existing code and pass jshint [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/100709 (owner: 10Krinkle) [18:37:17] aude: Time to go mad with power [18:37:22] ^d: dibs! [18:38:45] (03Merged) 10jenkins-bot: Clean up existing code and pass jshint [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/100709 (owner: 10Krinkle) [18:40:30] (03CR) 10CSteipp: [C: 032] Add local user group membership to Special:CentralAuth/Username [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97757 (owner: 10Gerrit Patch Uploader) [18:40:35] (03Merged) 10jenkins-bot: Add local user group membership to Special:CentralAuth/Username [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97757 (owner: 10Gerrit Patch Uploader) [18:42:42] AaronSchulz: found one issue in https://gerrit.wikimedia.org/r/#/c/99033/ [18:44:05] (03CR) 10Parent5446: [C: 04-1] "Some inline code review comments." (038 comments) [core] - 10https://gerrit.wikimedia.org/r/101233 (owner: 10Umherirrender) [18:45:48] Is there a YouTube stream I can watch the meeting/tech-talk on? (RE: https://www.mediawiki.org/wiki/Meetings/2013-12-13 ) [18:46:05] (03CR) 10Calak: [C: 031] i18n: Localized user right labels [extensions/Echo] - 10https://gerrit.wikimedia.org/r/98863 (owner: 10Ebrahim) [18:46:07] (03PS3) 10Spage: Gracefully handle errors applying redlinks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101236 (owner: 10EBernhardson) [18:46:58] (03CR) 10Aaron Schulz: [C: 032] Use TempFSFile in UploadFromUrl [core] - 10https://gerrit.wikimedia.org/r/101132 (owner: 10BryanDavis) [18:47:37] gwicke: yeah, normally leaf jobs don't need 'table', I ammended it [18:47:40] danielrenfro, it says: request invitation to qgil at #wikimedia-dev [18:47:47] for https://www.mediawiki.org/wiki/Meetings/2013-12-13 [18:48:29] right, just thought I might have missed a link that rolled by somewhere. I'll do that, thanks [18:48:46] (03CR) 10CSteipp: [C: 032] "I feel like the extra complexity for the plural isn't worth it, but I won't hold up the patch for it." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97851 (owner: 10Legoktm) [18:48:53] (03Merged) 10jenkins-bot: Add global groups to Special:CentralAuth/Username [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97851 (owner: 10Legoktm) [18:50:03] (03Merged) 10jenkins-bot: Use TempFSFile in UploadFromUrl [core] - 10https://gerrit.wikimedia.org/r/101132 (owner: 10BryanDavis) [18:51:34] (03CR) 10CSteipp: [C: 032] "Hopefully the global js/css extension will be enabled soon. This is a dependency for that, so let's merge it now." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98751 (owner: 10Legoktm) [18:51:35] (03CR) 10jenkins-bot: [V: 04-1] Add hook handler for GlobalCssJs [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98751 (owner: 10Legoktm) [18:52:03] (03CR) 10MarkTraceur: [C: 032] "Huzzah" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100353 (owner: 10Legoktm) [18:52:11] (03Merged) 10jenkins-bot: Use RequestContext::getMain()->getSkin() instead of User::getSkin() [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100353 (owner: 10Legoktm) [18:52:16] (03PS4) 10EBernhardson: Gracefully handle errors applying redlinks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101236 [18:52:45] Tech Talk starting in <9 minutes. MediaWiki Upgrades and Extension Dependencies � Ideas for Improvement https://www.mediawiki.org/wiki/Meetings/2013-12-13 & https://plus.google.com/events/c6m2obdfitng094csuv61steclo [18:52:56] jdlrobson: Looking at that patch reminds me to ask whether you (wrote|would like to write) some tests for BetaFeatures that cover the dependency framework [18:53:14] e.g. testing whether a skin not supported by a feature will actually cause it to have the warning [18:53:15] qgil, I'm set [18:54:44] qgil: Will it be possible to participate via IRC? Is there a Youtube stream? [18:55:18] https://plus.google.com/events/c6m2obdfitng094csuv61steclo should show a video stream marktraceur [18:55:47] Oh, huh, I thought "On Air" went to Youtube. [18:56:07] Annoying, but meh. [18:57:42] hexmode, ping [18:58:21] qgil, can I get an invite to the hangout? [18:58:59] superm401, your email...? [18:59:25] mflaschen (at) wikimedia [18:59:32] let me get the hangout started and then I can invite more people ok? [19:00:46] qgil, sure [19:00:51] (03CR) 10Bartosz Dziewoński: [C: 032] "Appears trivial…" [core] - 10https://gerrit.wikimedia.org/r/101238 (owner: 10Anomie) [19:01:05] marktraceur, I thought that too. [19:01:32] marktraceur: it's new, yeah :( (re G+ link) [19:01:55] (03CR) 10Spage: [C: 032] "PS2 logged error, PS4 just works. [[Bad&Link]] redlinks," [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101236 (owner: 10EBernhardson) [19:02:02] (03Merged) 10jenkins-bot: Gracefully handle errors applying redlinks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101236 (owner: 10EBernhardson) [19:02:11] Beurk. [19:02:31] superm401, invitation sent [19:02:37] Thanks [19:02:46] (03PS2) 10UltrasonicNXT: Add 'text' data for Special page links [core] - 10https://gerrit.wikimedia.org/r/100816 [19:03:46] anybody else willing to participate in the tech taslk? [19:03:57] (03Merged) 10jenkins-bot: Fix TextContent::preSaveTransform() return type [core] - 10https://gerrit.wikimedia.org/r/101238 (owner: 10Anomie) [19:04:13] you can join the video conference (I need your email) or you can ask/comment via IRC [19:04:30] Are the slides available for download? [19:04:42] I will ask memethief [19:05:22] superm401, join the call, yay! [19:05:29] joinED [19:05:30] About to [19:06:27] Much appreciated, qgil. [19:07:01] Direct Youtube link: https://www.youtube.com/watch?v=yIlKX_IaY9I [19:07:56] thank you bd808 , I don't know why did I get a G+ URL this time... [19:08:21] it's Google's slow transformation to everything being within G+ [19:08:37] 'cuz no one would use it otherwise ;) [19:08:50] (03PS1) 10Cscott: Upgrade `request` dependency. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/101247 [19:08:58] because social [19:11:00] questions so far? [19:11:17] (03CR) 10Cscott: [C: 032] Upgrade `request` dependency. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/101247 (owner: 10Cscott) [19:11:39] (03CR) 10Cscott: [C: 032] Add font support for Malayalam script; also add a test case. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/100675 (owner: 10Cscott) [19:11:45] Agreed so far! [19:11:51] (03CR) 10Cscott: [C: 032] Add Taamey Frank CLM font for Hebrew. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/100676 (owner: 10Cscott) [19:12:00] Sounds very familiar :) [19:12:08] (03CR) 10Cscott: [C: 032] Replace Taamey Frank with Linux Libertine for Hebrew. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/100677 (owner: 10Cscott) [19:12:18] At our 1.20.2 upgrade I updated 30+ extensions....it was non-trivial [19:12:21] (03Merged) 10jenkins-bot: Add font support for Malayalam script; also add a test case. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/100675 (owner: 10Cscott) [19:12:28] qgil: Remember that there's a delay on the video; interruptions may come at bad times [19:12:49] marktraceur, I can be unpolite with lag as well :) [19:12:59] (03Merged) 10jenkins-bot: Add Taamey Frank CLM font for Hebrew. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/100676 (owner: 10Cscott) [19:13:36] (03Merged) 10jenkins-bot: Replace Taamey Frank with Linux Libertine for Hebrew. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/100677 (owner: 10Cscott) [19:13:42] (03PS2) 10BryanDavis: Stop referencing Config inside objects [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101177 [19:14:05] (03Merged) 10jenkins-bot: Upgrade `request` dependency. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/101247 (owner: 10Cscott) [19:14:26] (03CR) 10BryanDavis: [C: 031] "Patch set 2 was a manual rebase. Git merge is dumb." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101177 (owner: 10BryanDavis) [19:14:53] (03PS1) 10Cscott: Add links to related projects in the README. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/101248 [19:15:28] (03CR) 10Cscott: [C: 032] Add links to related projects in the README. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/101248 (owner: 10Cscott) [19:15:28] (03PS1) 10Spage: Gracefully handle errors applying redlinks (wmf7) [extensions/Flow] (bug58455_backport) - 10https://gerrit.wikimedia.org/r/101249 [19:16:02] (03PS1) 10Chad: Cleanup docs in CirrusSearch body class [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101250 [19:16:05] (03Merged) 10jenkins-bot: Add links to related projects in the README. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/101248 (owner: 10Cscott) [19:17:01] (03CR) 10Chad: [C: 032] Stop referencing Config inside objects [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101177 (owner: 10BryanDavis) [19:17:05] (03Merged) 10jenkins-bot: Stop referencing Config inside objects [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101177 (owner: 10BryanDavis) [19:18:31] (03PS1) 10Cscott: README: Rename mw-latexer => mw-ocg-latexer for build status badges. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/101251 [19:19:15] (03CR) 10Cscott: [C: 032] README: Rename mw-latexer => mw-ocg-latexer for build status badges. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/101251 (owner: 10Cscott) [19:19:51] (03Merged) 10jenkins-bot: README: Rename mw-latexer => mw-ocg-latexer for build status badges. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/101251 (owner: 10Cscott) [19:20:16] (03CR) 10Spage: [C: 032] "Still works on ee-flow, now to deploy it on production." [extensions/Flow] (bug58455_backport) - 10https://gerrit.wikimedia.org/r/101249 (owner: 10Spage) [19:20:26] (03Merged) 10jenkins-bot: Gracefully handle errors applying redlinks (wmf7) [extensions/Flow] (bug58455_backport) - 10https://gerrit.wikimedia.org/r/101249 (owner: 10Spage) [19:20:37] JeroenDeDauw, and hashar were just mentioned by mglaser when discussing Composer [19:25:28] Speaking of RFCs, I wrote this RFC for an extension-manager a while back: https://www.mediawiki.org/wiki/Requests_for_comment/Extension_manager [19:26:13] danielrenfro, do you want to talk about it at the hangout? Email address and you're in. [19:26:17] Hm, the slide about crowd certification has images that are hard to read [19:26:56] The next RFC discussion needs more things to discuss: https://www.mediawiki.org/wiki/Architecture_meetings/RFC_review_2013-12-18 [19:26:57] qgil: I would like to, but I'm on my computer at work with no webcam/microphone... [19:27:07] (03PS1) 10Chad: Begin indexing file text from pdf/djvu files [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 [19:27:19] qgil: I'd be okay with putting the link on the MW page and possibly emailing it to the current participants [19:27:22] marktraceur, you can find the real thing clicking any plugin at http://wordpress.org/plugins/ [19:27:26] marktraceur: you can see thos on the wordpress site, but markus will give his slides later [19:27:30] danielrenfro: you should reply to the wikitech-l message from Robla about the Composer RFC [19:27:52] greg-g: I will do that, thanks! [19:28:20] danielrenfro, see also https://www.mediawiki.org/wiki/Architecture_meetings [19:28:45] (03PS1) 10Spage: Update Flow with backported bug 58455 backport [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/101253 [19:28:49] danielrenfro: subject: [Wikitech-l] Making MediaWiki extensions installable via Composer [19:29:45] (03PS1) 10BryanDavis: Make review settings more flexible [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101255 [19:29:52] Sure! [19:30:06] (03CR) 10Manybubbles: Cleanup docs in CirrusSearch body class (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101250 (owner: 10Chad) [19:30:15] danielrenfro, mglaser :) [19:30:17] mglaser: Feel free to email me about extensions/distribution/installation/upgrades at bluecurio@gmail.com [19:32:06] (03CR) 10Chad: Cleanup docs in CirrusSearch body class (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101250 (owner: 10Chad) [19:32:51] (03CR) 10Manybubbles: Begin indexing file text from pdf/djvu files (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 (owner: 10Chad) [19:32:57] qgil: Remember to change the view for the stream [19:33:04] Ah, got it. [19:33:14] you should be seeing whoever is speaking [19:33:17] (03CR) 10Manybubbles: [C: 032] Cleanup docs in CirrusSearch body class [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101250 (owner: 10Chad) [19:33:20] (03Merged) 10jenkins-bot: Cleanup docs in CirrusSearch body class [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101250 (owner: 10Chad) [19:33:28] (03CR) 10Nemo bis: "I'm a bit confused here, the bug only asks about personal tools but you changed more and that may be ok or not." [core] - 10https://gerrit.wikimedia.org/r/100724 (owner: 10MegaAlex) [19:34:05] (let's collect all these ideas about video conferences for the future MediaWiki-on-air extension) ;) [19:36:20] qgil: No questions, just very interested! [19:36:40] ori-l, your name just popped at at the Tech Talk when discussing MediaWiki-vagrant [19:36:47] with Composer [19:39:26] Vagrant seems like a reasonable place to prototype composer integration. It would be pretty easy to clone on the widely-used-git-host-that-shall-not-be-named and try some different things out [19:40:06] someone pinged? [19:40:15] Yeah, MW-Vagrant already has a built-in mechanism through roles [19:40:19] * greg-g kicks YuviPanda  [19:40:25] But that's only useful if you actually use MW-Vagrant. [19:40:49] If Composer were used for the PHP-level dependencies, it would benefit other MW users too. [19:40:53] (03CR) 10Spage: [C: 032] "Serious bug, people complaining." [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/101253 (owner: 10Spage) [19:41:01] thank you very much! [19:41:04] TIL: Github hasn't registered the Github username on Freenode [19:41:07] (03PS2) 10Chad: Begin indexing file text from pdf/djvu files [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 [19:41:09] Thanks for the talk! [19:41:25] thanks for attending :) [19:41:47] qgil: Thanks again...I appreciate the recent endeavors into outreach [19:42:03] (03CR) 10Chad: Begin indexing file text from pdf/djvu files (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 (owner: 10Chad) [19:42:53] thank you danielrenfro , thank you for pushing your RFC [19:43:15] qgil: not so much of a push as a nudge :) [19:43:38] qgil: I went backwacks through the logs/mailing lists/extensions and tried to be comprehensive about the current state [19:43:45] (03Merged) 10jenkins-bot: Update Flow with backported bug 58455 backport [core] (wmf/1.23wmf7) - 10https://gerrit.wikimedia.org/r/101253 (owner: 10Spage) [19:49:30] mglaser: I forgot where you said you would post the talk slides. On the meeting page? [19:50:04] memethief: yes, just about to do so :) [19:51:16] terrific, thank you. [19:51:26] (03PS1) 10BryanDavis: Fix TempFSFile creation [core] - 10https://gerrit.wikimedia.org/r/101256 [19:51:54] AaronSchulz: ^^ Fix to my broken code [19:52:06] mglaser: good talk! I agree on all points and have thought about this problem for a long time (since 1.12 days) [19:52:42] mglaser: somehow I missed the work with Composer, I need to check that out [19:53:30] (03PS1) 10GWicke: Merge "Fix css decoding in the sanitizer" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101257 [19:53:30] danielrenfro: thanks! There will be a few links on the slides, in case you want to try it out [19:53:31] (03PS1) 10GWicke: Merge "Default initial MW page is Main Page (capitalized P)" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101258 [19:53:33] (03PS1) 10GWicke: Merge "(Bug 56733) Fixed bug serialization template args containing " : "" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101259 [19:53:34] (03PS1) 10GWicke: Merge "js/README.txt instructions to run node server" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101260 [19:53:35] (03PS1) 10GWicke: Merge "Fixed DSR errors introduced by DOM spec changes" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101261 [19:53:36] (03PS1) 10GWicke: Merge "(Bug 56983) Correctly serialize magic words added on client" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101262 [19:53:38] (03PS1) 10GWicke: Merge "Suppress harmless DSR inconsistency warnings" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101263 [19:53:39] (03PS1) 10GWicke: Merge "Remove some cruft from web service entry page" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101264 [19:53:40] (03PS1) 10GWicke: Merge "default php entry point" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101265 [19:53:41] (03PS1) 10GWicke: Merge "ISBN links now parse to mw:ExtLink instead of mw:WikiLink/ISBN" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101266 [19:53:42] (03PS1) 10GWicke: Merge "(Bug 57618) Bug fix in dom-fragment unpacking of transcluded extensions" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101267 [19:53:43] (03PS1) 10GWicke: Merge "Bug 56282: Enable gzip compression support, the sequel" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101268 [19:53:47] (03PS1) 10GWicke: Merge "Fixed buggy generation/application of changetrees to simulate edits" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101269 [19:53:48] (03PS1) 10GWicke: Merge "Created an AccumChain obj to use in AsyncTTM transformTokens loop." [services/parsoid] - 10https://gerrit.wikimedia.org/r/101270 [19:53:49] heh [19:53:49] (03PS1) 10GWicke: Merge "(Bug 57854) Handle linktrail/prefix nowiki escaping in selser mode" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101271 [19:53:51] (03PS1) 10GWicke: Merge "Fix empty-line matching regexp in makeSeparator" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101272 [19:53:52] (03PS1) 10GWicke: Merge "Specify the number workers from the command line" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101273 [19:53:53] (03PS1) 10GWicke: Merge "Fixed serializing of edited ISBN links" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101274 [19:53:54] (03PS1) 10GWicke: Merge "(Bug 51744) Add space around = chars in new headings" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101275 [19:53:58] (03PS1) 10GWicke: Merge "Improvements to DOMDiff" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101276 [19:53:59] (03PS1) 10GWicke: Merge "Bug 54438: First part of core change 97caae596: support time/data/mark elements" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101277 [19:54:03] (03PS1) 10GWicke: Merge "Bug 57251: Lowercase attributes before sanitization" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101278 [19:54:08] (03PS1) 10GWicke: Merge "Bug 57707: Hotfix, don't push undefined onto wikitext array" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101279 [19:54:14] (03PS1) 10GWicke: Merge "Titles can end with ? mark and should be serialized as wikilinks" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101280 [19:54:15] (03PS1) 10GWicke: Merge "More informative DoesNotExistError logging." [services/parsoid] - 10https://gerrit.wikimedia.org/r/101281 [19:54:16] (03PS1) 10GWicke: Merge "(Bug 57707) Clean up dead code (that was the source of exceptions)" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101282 [19:54:18] (03PS1) 10GWicke: Merge "Bugfix in DOMUtils.convertDOMtoTokens" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101283 [19:54:19] (03PS1) 10GWicke: Merge "Bug 58054: Implement URL link parenthesis heuristic" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101284 [19:54:23] (03PS1) 10GWicke: Merge "Tweaks to

and

  • sep constraints when surrounded by HTML nodes" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101285 [19:54:24] (03PS1) 10GWicke: Merge "Bug 50523: Hard-code Wikipedia rather than MW defaults" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101286 [19:54:27] (03PS1) 10GWicke: Merge "Bug 58212: Configure wiktionary by default as well" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101287 [19:54:31] (03PS1) 10GWicke: Merge "Disable proxy for ParsoidCacheRequest" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101288 [19:54:32] (03PS1) 10GWicke: Merge "Pre can end with a space" [services/parsoid] - 10https://gerrit.wikimedia.org/r/101289 [19:54:33] (03PS1) 10GWicke: Fix css decoding in the sanitizer [services/parsoid] - 10https://gerrit.wikimedia.org/r/101290 [19:54:37] (03PS1) 10GWicke: Default initial MW page is Main Page (capitalized P) [services/parsoid] - 10https://gerrit.wikimedia.org/r/101291 [19:54:38] (03PS1) 10GWicke: (Bug 56733) Fixed bug serialization template args containing " : " [services/parsoid] - 10https://gerrit.wikimedia.org/r/101292 [19:54:40] (03PS1) 10GWicke: Treat WikiLink/Category like PageProp/Category while serializing [services/parsoid] - 10https://gerrit.wikimedia.org/r/101293 [19:54:41] (03PS1) 10GWicke: Change round-trip test db page prefix to 24 chars [services/parsoid] - 10https://gerrit.wikimedia.org/r/101294 [19:54:43] (03PS1) 10GWicke: Remove 'wiki' from prefix to get the actual wikipedia URL [services/parsoid] - 10https://gerrit.wikimedia.org/r/101295 [19:54:44] (03PS1) 10GWicke: Better error handling in the ParserService [services/parsoid] - 10https://gerrit.wikimedia.org/r/101296 [19:54:44] (03PS1) 10GWicke: Some clean-up and fixes for the external API [services/parsoid] - 10https://gerrit.wikimedia.org/r/101297 [19:54:45] (03PS1) 10GWicke: (Bug 56983) Correctly serialize magic words added on client [services/parsoid] - 10https://gerrit.wikimedia.org/r/101298 [19:54:46] (03PS1) 10GWicke: Fixed DSR errors introduced by DOM spec changes [services/parsoid] - 10https://gerrit.wikimedia.org/r/101299 [19:54:47] (03PS1) 10GWicke: tagId was incorrectly used as tsr info in TreeBuilderFixups [services/parsoid] - 10https://gerrit.wikimedia.org/r/101300 [19:54:55] (03PS1) 10GWicke: Add commonswiki prefix by default [services/parsoid] - 10https://gerrit.wikimedia.org/r/101301 [19:54:56] (03PS1) 10GWicke: js/README.txt instructions to run node server [services/parsoid] - 10https://gerrit.wikimedia.org/r/101302 [19:54:57] (03PS1) 10GWicke: Suppress harmless DSR inconsistency warnings [services/parsoid] - 10https://gerrit.wikimedia.org/r/101303 [19:54:58] (03PS1) 10GWicke: Remove some cruft from web service entry page [services/parsoid] - 10https://gerrit.wikimedia.org/r/101304 [19:54:59] (03PS1) 10GWicke: Properly reset inPre state in the pre handler [services/parsoid] - 10https://gerrit.wikimedia.org/r/101305 [19:55:00] (03PS1) 10GWicke: Bug 56820: Don't fetch wikitext source if oldid is missing [services/parsoid] - 10https://gerrit.wikimedia.org/r/101306 [19:55:01] (03PS1) 10GWicke: Set default wgParsoidWikiPrefix [services/parsoid] - 10https://gerrit.wikimedia.org/r/101307 [19:55:02] (03PS1) 10GWicke: default php entry point [services/parsoid] - 10https://gerrit.wikimedia.org/r/101308 [19:55:03] (03PS1) 10GWicke: properly shutdown server on ^C [services/parsoid] - 10https://gerrit.wikimedia.org/r/101309 [19:55:04] (03PS1) 10GWicke: server: list number of worker about to be spawned [services/parsoid] - 10https://gerrit.wikimedia.org/r/101310 [19:55:05] (03PS1) 10GWicke: server: make master and worker exit(0) [services/parsoid] - 10https://gerrit.wikimedia.org/r/101311 [19:55:06] (03PS1) 10GWicke: ISBN links now parse to mw:ExtLink instead of mw:WikiLink/ISBN [services/parsoid] - 10https://gerrit.wikimedia.org/r/101312 [19:55:07] (03PS1) 10GWicke: (Bug 57618) Bug fix in dom-fragment unpacking of transcluded extensions [services/parsoid] - 10https://gerrit.wikimedia.org/r/101313 [19:55:08] (03PS1) 10GWicke: Fixed buggy generation/application of changetrees to simulate edits [services/parsoid] - 10https://gerrit.wikimedia.org/r/101314 [19:55:09] (03PS1) 10GWicke: Created an AccumChain obj to use in AsyncTTM transformTokens loop. [services/parsoid] - 10https://gerrit.wikimedia.org/r/101315 [19:55:10] (03PS1) 10GWicke: Bug 56282: Enable gzip compression support, the sequel [services/parsoid] - 10https://gerrit.wikimedia.org/r/101316 [19:55:11] (03PS1) 10GWicke: Process HTML 
    ...
    as a single, self-contained token [services/parsoid] - 10https://gerrit.wikimedia.org/r/101317 [19:55:12] (03PS1) 10GWicke: (Bug 51744) Add space around = chars in new headings [services/parsoid] - 10https://gerrit.wikimedia.org/r/101318 [19:55:13] (03PS1) 10GWicke: Prevent duplicate tests in round-trip testing [services/parsoid] - 10https://gerrit.wikimedia.org/r/101319 [19:55:14] (03PS1) 10GWicke: (Bug 57854) Handle linktrail/prefix nowiki escaping in selser mode [services/parsoid] - 10https://gerrit.wikimedia.org/r/101320 [19:55:15] (03PS1) 10GWicke: Bug 56691: Handle page names starting with a slash [services/parsoid] - 10https://gerrit.wikimedia.org/r/101321 [19:55:21] (03PS1) 10GWicke: Fix empty-line matching regexp in makeSeparator [services/parsoid] - 10https://gerrit.wikimedia.org/r/101322 [19:55:22] (03PS1) 10GWicke: Close unclosed HTML p-tags on encountering a block token [services/parsoid] - 10https://gerrit.wikimedia.org/r/101323 [19:55:23] (03PS1) 10GWicke: Fix for crashers in RT testing. [services/parsoid] - 10https://gerrit.wikimedia.org/r/101324 [19:55:24] (03PS1) 10GWicke: Fixed serializing of edited ISBN links [services/parsoid] - 10https://gerrit.wikimedia.org/r/101325 [19:55:25] (03PS1) 10GWicke: Specify the number workers from the command line [services/parsoid] - 10https://gerrit.wikimedia.org/r/101326 [19:55:26] (03PS1) 10GWicke: Bug 57416: Fix serialization of interwiki links with query string or fragment id [services/parsoid] - 10https://gerrit.wikimedia.org/r/101327 [19:55:28] (03PS1) 10GWicke: Improvements to DOMDiff [services/parsoid] - 10https://gerrit.wikimedia.org/r/101328 [19:55:29] (03PS1) 10GWicke: Bug 54438: First part of core change 97caae596: support time/data/mark elements [services/parsoid] - 10https://gerrit.wikimedia.org/r/101329 [19:55:30] (03PS1) 10GWicke: Bug 57251: Lowercase attributes before sanitization [services/parsoid] - 10https://gerrit.wikimedia.org/r/101330 [19:55:34] (03PS1) 10GWicke: Bug 57707: Hotfix, don't push undefined onto wikitext array [services/parsoid] - 10https://gerrit.wikimedia.org/r/101331 [19:55:38] (03PS1) 10GWicke: Titles can end with ? mark and should be serialized as wikilinks [services/parsoid] - 10https://gerrit.wikimedia.org/r/101332 [19:55:39] (03PS1) 10GWicke: Attributes, if present, should be preceded by a space [services/parsoid] - 10https://gerrit.wikimedia.org/r/101333 [19:55:44] (03PS1) 10GWicke: (Bug 57707) Clean up dead code (that was the source of exceptions) [services/parsoid] - 10https://gerrit.wikimedia.org/r/101334 [19:55:48] (03PS1) 10GWicke: Bugfix in DOMUtils.convertDOMtoTokens [services/parsoid] - 10https://gerrit.wikimedia.org/r/101335 [19:55:49] (03PS1) 10GWicke: More informative DoesNotExistError logging. [services/parsoid] - 10https://gerrit.wikimedia.org/r/101336 [19:55:53] (03PS1) 10GWicke: Bunch of 
     related fixes [services/parsoid] - 10https://gerrit.wikimedia.org/r/101337 
[19:55:55] 	 (03PS1) 10GWicke: parserTests selser-change gen fix: mw:Entity spans are uneditable [services/parsoid] - 10https://gerrit.wikimedia.org/r/101338 
[19:55:55] 	 ....
[19:55:55] 	 (03PS1) 10GWicke: Additional DOMDiff tweaks (continuation of 4170e8a9) [services/parsoid] - 10https://gerrit.wikimedia.org/r/101339 
[19:55:56] 	 (03PS1) 10GWicke: Tweaks to 
     and 
  •  sep constraints when surrounded by HTML nodes [services/parsoid] - 10https://gerrit.wikimedia.org/r/101340 
[19:55:58] 	 (03PS1) 10GWicke: Bug 58054: Implement URL link parenthesis heuristic [services/parsoid] - 10https://gerrit.wikimedia.org/r/101341 
[19:55:59] 	 (03PS1) 10GWicke: Add a new config option for an API proxy endpoint [services/parsoid] - 10https://gerrit.wikimedia.org/r/101342 
[19:56:00] 	 gwicke: WTF dude
[19:56:01] 	 (03PS1) 10GWicke: Minor cleanup: Only forward cookie if set [services/parsoid] - 10https://gerrit.wikimedia.org/r/101343 
[19:56:02] 	 (03PS1) 10GWicke: Some more DOMDiff tweaks (continuation of 4170e8a9) + fixes to WTS [services/parsoid] - 10https://gerrit.wikimedia.org/r/101344 
[19:56:03] 	 (03PS1) 10GWicke: Cleanup: Removed support for old-style templated attributes. [services/parsoid] - 10https://gerrit.wikimedia.org/r/101345 
[19:56:04] 	 (03PS1) 10GWicke: Dont suppress newlines around <*include*> in html2wt mode [services/parsoid] - 10https://gerrit.wikimedia.org/r/101346 
[19:56:05] 	 (03PS1) 10GWicke: Bug 50523: Hard-code Wikipedia rather than MW defaults [services/parsoid] - 10https://gerrit.wikimedia.org/r/101347 
[19:56:06] 	 (03PS1) 10GWicke: Bug 58212: Configure wiktionary by default as well [services/parsoid] - 10https://gerrit.wikimedia.org/r/101348 
[19:56:08] 	 (03PS1) 10GWicke: Disable proxy for ParsoidCacheRequest [services/parsoid] - 10https://gerrit.wikimedia.org/r/101349 
[19:56:09] 	 (03PS1) 10GWicke: parse-js, roundtrip-test.js: Set debugging flags with ParsoidConfig. [services/parsoid] - 10https://gerrit.wikimedia.org/r/101350 
[19:56:10] 	 (03PS1) 10GWicke: ParserTests: serialize DOM to HTML + reparse in wt2wt/selser modes [services/parsoid] - 10https://gerrit.wikimedia.org/r/101351 
[19:56:11] 	 (03PS1) 10GWicke: Fix broken HTML-pre serialization [services/parsoid] - 10https://gerrit.wikimedia.org/r/101352 
[19:56:12] 	 (03PS1) 10GWicke: urllink can parse as an array of tokens [services/parsoid] - 10https://gerrit.wikimedia.org/r/101353 
[19:56:13] 	 (03PS1) 10GWicke: Avoid indent-pre when line contains block tags [services/parsoid] - 10https://gerrit.wikimedia.org/r/101354 
[19:56:13] 	 marktraceur: it has flood protection, so won't get kicked for that
[19:56:14] 	 (03PS1) 10GWicke: Pre can end with a space [services/parsoid] - 10https://gerrit.wikimedia.org/r/101355 
[19:56:15] 	 (03PS1) 10GWicke: Bug 58355: Accept html pre with attribute and trailing space [services/parsoid] - 10https://gerrit.wikimedia.org/r/101356 
[19:56:19] 	 (03PS1) 10GWicke: Converted jobs to use BacklinkJobUtils [services/parsoid] - 10https://gerrit.wikimedia.org/r/101357 
[19:56:20] 	 (03PS1) 10GWicke: Merge ../mw/extensions/Parsoid [services/parsoid] - 10https://gerrit.wikimedia.org/r/101358 
[19:56:24] 	 That's not the point
[19:56:30] 	 marktraceur: I know
[19:56:32] 	 This looks like gwicke is doing the wrong thing
[19:56:36] 	 marktraceur: I think this was a 'rename'
[19:56:44] 	 Ahhhh.
[19:56:55] 	 where instead of direct pusing he is going to have to click 'submit' a *LOT* of times
[19:57:02] 	 Sigh.
[19:57:05] 	 (or write a script for it)
[19:57:14] 	 heh
[19:57:27] 	 git rebase -i & squash is your frieeeeend
[19:57:36] 	 brion: but then you lose history!
[19:57:45] 	 brion: the problem here is gerrit not making it easy to do a direct push
[19:57:50] 	 those who rebase history are doomed to repeat it
[19:59:59] 	 added the slides for the tech talk:
[20:00:00] 	 https://www.mediawiki.org/wiki/File:Improving_dependency_management_and_easing_upgrades.pdf
[20:00:10] 	 I need to go now.
[20:00:21] 	 Bye everybody!
[20:00:26] 	 (03CR) 10Dan-nl: [C: 031] "- tested it locally." [core] - 10https://gerrit.wikimedia.org/r/101256 (owner: 10BryanDavis)
[20:01:30] 	 I was transplanting history between two gerrit repos
[20:01:52] 	 git push gerrit HEAD:refs/heads/master finally did the trick
[20:02:07] 	 after tweaking the gerrit settings
[20:02:44] 	 sorry for the spam..
[20:02:57] 	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "They don't pass 'text' because it's not required, and in fact documented as such. From docs to BaseTemplate#makeLink: "The text of the lin" [core] - 10https://gerrit.wikimedia.org/r/100816 (owner: 10UltrasonicNXT)
[20:04:13] 	 (03CR) 10BryanDavis: [C: 032] "This being broken is blocking testing of GWToolset in beta so I'm self-merging to clear the problem." [core] - 10https://gerrit.wikimedia.org/r/101256 (owner: 10BryanDavis)
[20:08:23] 	 (03Merged) 10jenkins-bot: Fix TempFSFile creation [core] - 10https://gerrit.wikimedia.org/r/101256 (owner: 10BryanDavis)
[20:08:29] 	 (03CR) 10Ori.livneh: "Siebrand, ping." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/100534 (owner: 10Mattflaschen)
[20:10:05] 	 Nikerabbit: https://gerrit.wikimedia.org/r/101392 known issue?
[20:10:24] 	 (03PS3) 10Ori.livneh: Fix WikiPage::prepareContentForEdit's default format handling [core] - 10https://gerrit.wikimedia.org/r/101224 (owner: 10Anomie)
[20:10:38] 	 Looks like it's up to date
[20:10:47] 	 marktraceur: that seems to be happening more often lately
[20:10:48] 	 (03CR) 10Ori.livneh: [C: 032] Fix WikiPage::prepareContentForEdit's default format handling [core] - 10https://gerrit.wikimedia.org/r/101224 (owner: 10Anomie)
[20:11:00] 	 Rechecking
[20:13:59] 	 ...or I'm not, I dunno
[20:19:08] 	 (03CR) 10Jdlrobson: [C: 032] Blacklist Google Glass web browser from JS [core] - 10https://gerrit.wikimedia.org/r/100823 (owner: 10Brion VIBBER)
[20:19:31] 	 (03PS7) 10Jdlrobson: Migrate redirectToFragment() from wikibits.js to own module [core] - 10https://gerrit.wikimedia.org/r/94412 (owner: 10Umherirrender)
[20:19:36] 	 (03Merged) 10jenkins-bot: Fix WikiPage::prepareContentForEdit's default format handling [core] - 10https://gerrit.wikimedia.org/r/101224 (owner: 10Anomie)
[20:19:42] 	 (03CR) 10Jdlrobson: [C: 031] Migrate redirectToFragment() from wikibits.js to own module [core] - 10https://gerrit.wikimedia.org/r/94412 (owner: 10Umherirrender)
[20:20:12] 	 marktraceur: yes, known issue
[20:20:38] 	 MatmaRex: And the answer is to ignore jenkins-bot? :/
[20:20:40] 	 marktraceur: https://bugzilla.wikimedia.org/show_bug.cgi?id=57483
[20:20:57] 	 StevenW: I do so love my tables… https://www.mediawiki.org/wiki/User:Howief/WMF_Product_and_WikiData :-)
[20:21:12] 	 marktraceur: the answer is to fix that poor excuse of a code-review system that is gerrit
[20:21:19] 	 marktraceur: this happens about once a day
[20:21:23] 	 ...sigh
[20:21:33] 	 unfortunately no one cares so far
[20:21:38] 	 apart from me
[20:21:52] 	 (you're the fourth or fifth person that i am explaining this too)
[20:21:53] 	 to*
[20:21:58] 	 (03Abandoned) 10UltrasonicNXT: Add 'text' data for Special page links [core] - 10https://gerrit.wikimedia.org/r/100816 (owner: 10UltrasonicNXT)
[20:22:20] 	 MatmaRex: I think I've seen basically this bug before
[20:22:24] 	 Like, pulling code
[20:22:31] 	 From Gerrit onto labs in particular
[20:27:56] 	 (03CR) 10UltrasonicNXT: "Well I've abandoned this, but for reference, is there any way to use the toolbox without makeListItem? Ie. if I want to just access it as " [core] - 10https://gerrit.wikimedia.org/r/100816 (owner: 10UltrasonicNXT)
[20:32:41] 	 (03CR) 10Ragesoss: [C: 031] "I haven't been able to test this since I can't get uploadwizard to accept the offending PDF *at all* on my local vagrant setup, but it see" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/99178 (owner: 10MarkTraceur)
[20:33:37] 	 (03CR) 10BryanDavis: [C: 032] startup.js: log current time as global 'mediaWikiLoadStart' [core] - 10https://gerrit.wikimedia.org/r/95070 (owner: 10Ori.livneh)
[20:33:51] 	 (03CR) 10Bartosz Dziewoński: "Well, you can access it as an array, you just have to know how to handle missing keys. Or you can create a different tag, e.g. `$this->mak" [core] - 10https://gerrit.wikimedia.org/r/100816 (owner: 10UltrasonicNXT)
[20:42:57] 	 (03Merged) 10jenkins-bot: Blacklist Google Glass web browser from JS [core] - 10https://gerrit.wikimedia.org/r/100823 (owner: 10Brion VIBBER)
[20:43:04] 	 \o/
[20:43:33] 	 hah
[20:43:49] 	 native app will be way cooler ;)
[20:43:53] 	 the glass browser sucks
[20:45:34] 	 I wish it was just "blacklist google glass" ;)
[20:46:15] 	 the HUD is neat. the camera that you can't tell if it's on or off is creepy
[20:46:27] * greg-g  nods
[20:48:21] 	 playing with a Glass unit has made me almost want a smart watch though ;)
[20:48:34] 	 gives you the 'don't have to dig in your pocket' without the CYBORG
[20:48:40] 	 RoanKattouw: obnoxious nag re: https://gerrit.wikimedia.org/r/#/c/99547/ (ve.track -> mw.track)
[20:48:40] 	 why you blacklisting:)
[20:49:02] 	 mutante: ties to the communist party
[20:49:16] 	 ori-l: heh
[20:49:17] * brion  wonders if kim jong-un is at the center of this
[20:49:39] 	 so you got one in office now?
[20:49:52] 	 and 24/7 brion stream?
[20:50:09] 	 heh no live stream
[20:50:15] 	 :)
[20:50:22] 	 barely scratched the surface of it, i'll have to play with it some more this weekend
[20:50:32] 	 brion: i see what you did there
[20:50:32] 	 creepy yet interesting
[20:50:33] 	 native development kit is out now so you can write native android apps that integrate with the ui
[20:51:16] 	 (03Merged) 10jenkins-bot: startup.js: log current time as global 'mediaWikiLoadStart' [core] - 10https://gerrit.wikimedia.org/r/95070 (owner: 10Ori.livneh)
[20:51:21] 	 wee,, i see what you want
[20:51:40] 	 wp overlay when at historic places and monuments and stuff
[20:51:44] 	 using WLM app and glass
[20:51:46] 	 :))
[20:51:59] 	 also i want to somehow have Glass and Kinect get in a staring match
[20:52:05] 	 haha
[20:52:15] 	 ori-l: Will review at some point, have higher-prio things right now
[20:52:23] 	 reminds me, check if xbox one is back in stock...
[20:52:31] 	 RoanKattouw: OK, thanks, will stop nagging then
[20:52:50] 	 " In stock but may require an extra 1-2 days to process." hello
[20:52:54] 	 thank goodness it's payday
[20:53:18] 	 brion: hah, rob beat you to that, pre-order waiting list
[20:53:31] 	 yeah i had to cancel my pre-order cause it was right around my move
[20:53:38] 	 ugh, i see
[20:55:41] 	 ok re- ordered :D
[20:55:58] 	 arrives tuesday
[20:56:00] 	 tuesday! bah
[20:56:30] 	 brion: pay more for that one day earlier,they want you to give for 1 day,, tempting you :)
[20:56:40] 	 that's with the extra $8 ;)
[20:57:17] 	 i may or may not be in the office for meetings on tuesday, we'll see :D
[20:57:24] 	 hah, worth a lunch sandwich
[20:57:37] 	 totally
[20:57:37] 	 (03PS3) 10Nemo bis: Replacing 'show on map' button with a link [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/101029 (owner: 10Inchikutty)
[21:03:48] 	 (03CR) 10EBernhardson: [C: 04-1] "Havn't had a chance to look at the bugs you mentioned andrew, but a few other notes included." (0312 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99038 (owner: 10Werdna)
[21:05:17] 	 (03CR) 10EBernhardson: [C: 04-1] "db migration as it currently is done will not work for prod migration" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 (owner: 10EBernhardson)
[21:05:58] 	 (03CR) 10EBernhardson: [C: 032] Fix tests; cache expects cachetime now [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101208 (owner: 10Matthias Mullie)
[21:06:07] 	 (03Merged) 10jenkins-bot: Fix tests; cache expects cachetime now [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101208 (owner: 10Matthias Mullie)
[21:10:07] 	 (03CR) 10UltrasonicNXT: "An option to not generate that outer element would be useful, is that something I could think about adding?" [core] - 10https://gerrit.wikimedia.org/r/100816 (owner: 10UltrasonicNXT)
[21:14:40] 	 (03PS1) 10Cscott: Use ttf-malayalam-fonts instead of fonts-smc on older Ubuntu releases. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/101434 
[21:14:44] 	 (03CR) 10BryanDavis: [C: 032] Localize base_auth form [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101227 (owner: 10Chad)
[21:14:50] 	 (03Merged) 10jenkins-bot: Localize base_auth form [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101227 (owner: 10Chad)
[21:15:02] 	 (03PS3) 10BryanDavis: Localize change password form [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101232 (owner: 10Chad)
[21:15:20] 	 (03CR) 10Cscott: [C: 032] Use ttf-malayalam-fonts instead of fonts-smc on older Ubuntu releases. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/101434 (owner: 10Cscott)
[21:15:31] 	 (03CR) 10BryanDavis: [C: 032] Localize change password form [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101232 (owner: 10Chad)
[21:15:34] 	 (03Merged) 10jenkins-bot: Localize change password form [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101232 (owner: 10Chad)
[21:16:05] 	 (03Merged) 10jenkins-bot: Use ttf-malayalam-fonts instead of fonts-smc on older Ubuntu releases. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/101434 (owner: 10Cscott)
[21:16:18] 	 (03PS2) 10BryanDavis: Localize admin pages [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101234 (owner: 10Chad)
[21:17:13] 	 (03CR) 10BryanDavis: [C: 032] Localize admin pages [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101234 (owner: 10Chad)
[21:17:16] 	 (03Merged) 10jenkins-bot: Localize admin pages [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101234 (owner: 10Chad)
[21:17:26] 	 (03PS2) 10BryanDavis: Localize part of login form that was missed [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101235 (owner: 10Chad)
[21:17:44] 	 (03CR) 10BryanDavis: [C: 032] Localize part of login form that was missed [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101235 (owner: 10Chad)
[21:17:47] 	 (03Merged) 10jenkins-bot: Localize part of login form that was missed [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101235 (owner: 10Chad)
[21:17:51] 	 hey greg-g, i set-up two commits in order to prep gwtoolset for production, but would like someone on your team to review them to make sure i've covered everything. can you add them or let me know and i'll add them to https://gerrit.wikimedia.org/r/#/c/101058/ and https://gerrit.wikimedia.org/r/#/c/101061/
[21:18:08] 	 (03PS2) 10BryanDavis: Localize about half of the review forms [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101239 (owner: 10Chad)
[21:19:25] 	 (03CR) 10BryanDavis: [C: 032] Localize about half of the review forms [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101239 (owner: 10Chad)
[21:19:28] 	 (03Merged) 10jenkins-bot: Localize about half of the review forms [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101239 (owner: 10Chad)
[21:19:41] 	 (03PS2) 10BryanDavis: Make review settings more flexible [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101255 
[21:22:16] 	 (03PS1) 10EBernhardson: Only the text should prevent click-through [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101435 
[21:25:20] 	 dan-nl: added :)
[21:25:53] 	 thanks!
[21:26:04] 	 (03PS1) 10EBernhardson: Only require one click to expand moderated topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101441 
[21:27:20] 	 (03CR) 10Daniel Kinzler: "oops! good catch!" [core] - 10https://gerrit.wikimedia.org/r/101238 (owner: 10Anomie)
[21:27:31] 	 (03PS1) 10BryanDavis: Fix i18n template errors [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101442 
[21:28:51] 	 (03CR) 10Aaron Schulz: Added a page_links_updated column for job de-duplication (031 comment) [core] - 10https://gerrit.wikimedia.org/r/101170 (owner: 10Aaron Schulz)
[21:29:52] 	 (03Abandoned) 10Nemo bis: Quote the alleged "edit" message directly in livetranslate-dictionary-* [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/87562 (owner: 10Nemo bis)
[21:30:49] 	 (03CR) 10Anomie: "Looks generally ok to me, haven't tested." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/101170 (owner: 10Aaron Schulz)
[21:31:08] 	 (03PS7) 10Nemo bis: Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas)
[21:31:29] 	 (03PS3) 10Legoktm: Add hook handler for GlobalCssJs [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98751 
[21:31:53] 	 (03CR) 10Legoktm: "PS3: manual rebase" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98751 (owner: 10Legoktm)
[21:31:54] 	 (03CR) 10BryanDavis: [C: 04-1] Fix i18n template errors (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101442 (owner: 10BryanDavis)
[21:32:00] 	 csteipp: ^ rebased it
[21:32:04] 	 (03PS1) 10leucosticte: Add preferences checkbox to email text of watched deleted pages [core] - 10https://gerrit.wikimedia.org/r/101443 
[21:32:24] 	 (03PS2) 10BryanDavis: Fix i18n template errors [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101442 
[21:32:48] 	 (03CR) 10CSteipp: [C: 032] Add hook handler for GlobalCssJs [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98751 (owner: 10Legoktm)
[21:33:49] 	 (03CR) 10Aaron Schulz: Added a page_links_updated column for job de-duplication (031 comment) [core] - 10https://gerrit.wikimedia.org/r/101170 (owner: 10Aaron Schulz)
[21:34:08] 	 (03PS3) 10BryanDavis: Fix i18n template errors [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/101442 
[21:34:18] 	 (03PS1) 10Chad: Add picture for BetaFeature integration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101444 
[21:34:42] 	 (03PS2) 10Chad: Add picture for BetaFeature integration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101444 
[21:34:52] 	 (03Merged) 10jenkins-bot: Add hook handler for GlobalCssJs [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98751 (owner: 10Legoktm)
[21:35:02] 	 (03CR) 10Nemo bis: "Hello and welcome, your test worked! :) Now you can click the "abandon" button to make it clear that you're not interested in getting this" [extensions/examples] - 10https://gerrit.wikimedia.org/r/98992 (owner: 105xbe)
[21:35:24] 	 (03CR) 10Legoktm: Add picture for BetaFeature integration (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101444 (owner: 10Chad)
[21:36:26] 	 (03PS3) 10Chad: Add picture for BetaFeature integration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101444 
[21:36:36] <^d>	 legoktm: Fixed, thanks for spotting :)
[21:36:48] <^d>	 I had it in my copy+paste buffer. Don't know why I didn't paste.
[21:37:01] 	 :)
[21:37:17] 	 (03CR) 10Jforrester: [C: 031] Add picture for BetaFeature integration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101444 (owner: 10Chad)
[21:38:49] 	 (03CR) 10Legoktm: [C: 031] Add picture for BetaFeature integration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101444 (owner: 10Chad)
[21:38:59] 	 legoktm: 2x+1 == +2? :-)
[21:39:10] 	 lol
[21:39:11] 	 sure
[21:39:17] 	 (03CR) 10Legoktm: [C: 032] Add picture for BetaFeature integration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101444 (owner: 10Chad)
[21:39:33] * James_F  grins.
[21:40:01] 	 ^d: You beat me to adding the image myself. I was half-way through the git clone when your change came in. :-)
[21:40:14] <^d>	 :)
[21:40:16] <^d>	 +2 "has irc consensus"
[21:40:22] 	 Yup yup.
[21:40:30] 	 We can always fix it in post.
[21:40:31] 	 (03Merged) 10jenkins-bot: Add picture for BetaFeature integration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101444 (owner: 10Chad)
[21:40:37] <^d>	 I wanted to get it on beta.
[21:40:43] <^d>	 So we can all see it in the same place.
[21:40:44] 	 Well, {{done}}. :-)
[21:40:47] <^d>	 :)
[21:40:56] <^d>	 Oh wait.
[21:41:01] <^d>	 No beta wikis have it as secondary.
[21:41:07] <^d>	 Hmm
[21:41:14] 	 greg-g: that patch we had outstanding, https://gerrit.wikimedia.org/r/#/c/101008/, has been merged and i just finished running two test uploads which worked as expected. i think everything is ready for tuesday. let me know if there's anything else i need to double-check. http://commons.wikimedia.beta.wmflabs.org/w/index.php?title=Category:GWToolset_Batch_Upload
[21:41:52] 	 ^d: De-primary-ise it?
[21:41:58] 	 some of those source links are outdated, david gave me an old dataset, so no worries there
[21:42:00] 	 I just tested it on my own wiki
[21:42:03] 	 do you want me to screenshot it?
[21:42:11] 	 legoktm: That'd be great.
[21:42:42] <^d>	 James_F: Gonna do that on commonswiki in beta.
[21:42:46] 	 James_F: http://cl.ly/image/1U1J3U0n0L0Z
[21:43:00] <^d>	 Or that
[21:43:04] <^d>	 That's easier.
[21:43:05] 	 legoktm: Thanks.
[21:43:10] 	 (03PS2) 10Nemo bis: Use LEFT JOIN for SQLite compatibility [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/101055 (owner: 10Leaves in Motion)
[21:43:12] 	 ^d: Want to do the honours or should I?
[21:43:19] 	 Ha.
[21:43:28] 	 And now Nik has done a screenshot anyway.
[21:43:36] 	 Too many people to eagre to get this out. :-)
[21:45:07] 	 (03CR) 10Nemo bis: "Thanks for your patch! I've linked the existing bug report for the issue from the commit message." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/101055 (owner: 10Leaves in Motion)
[21:45:23] 	 ^d: I think the name of the beta feature should change to "kick ass search". "new " sounds boring but who wouldn't want "kick ass"?
[21:45:48] 	 bd808: Search Like A Boss
[21:45:48] 	 bd808: What about "Death To Old Search"?
[21:46:02] 	 I wonder if we could get Andy Samberg to give us a picture for the logo
[21:46:32] <^d>	 "Search so good you might even stop using Google"
[21:46:43] 	 ^d: Let's not go that far. ;-)
[21:47:17] <^d>	 s/might/might<\/em>/
[21:53:13] 	 can someone actually merge this? https://gerrit.wikimedia.org/r/#/c/62221/
[21:53:55] 	 (03PS1) 10Bartosz Dziewoński: Make legend on Special:RecentChanges and Special:Watchlist collapsible [core] - 10https://gerrit.wikimedia.org/r/101446 
[21:54:28] 	 Nemo_bis: lol
[21:54:45] 	 huh, i can't.
[21:54:49] 	 yeah, very funny
[21:54:52] 	 i click the button and nothing happens.
[21:55:12] 	 ^d: why is gerrit so shit? :( ^
[21:55:14] 	 maybe the change was actually merged by the next l10n-bot commit?
[21:55:23] 	 because that one allegedly needs this
[21:55:36] 	 yeah, so it seems
[21:55:52] <^d>	 Is it actually merged in the repo?
[21:55:59] <^d>	 Or does it just pretend to not be merged in the UI?
[21:56:08] 	 huh
[21:56:25] <^d>	 I know the UI says "Submitted, merge pending"
[21:56:27] <^d>	 Is it?
[21:56:33] <^d>	 Or does the repo contain the merge?
[21:56:52] 	 (03CR) 10Nemo bis: "/me suggests abandoning" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/63342 (owner: 10MarkAHershberger)
[21:58:17] <^d>	 AaronSchulz: Why does ArticleRevisionVisibilitySet suck? All it gives me is a Title.
[21:58:24] <^d>	 How can I get the rev that was deleted?
[21:58:29] <^d>	 rev_id, I mean.
[21:59:31] 	 ^d: it's clearly merged, merged patches depend on it
[21:59:54] <^d>	 Then the UI is just wrong.
[22:00:01] 	 clicking "Submit Patch Set 1" does nothing (apart from saying "Working ..." for a while)
[22:00:04] <^d>	 easily fixed.
[22:02:03] 	 (03PS7) 10Nemo bis: Allow hiding patrol entries from Special:log for all users [core] - 10https://gerrit.wikimedia.org/r/42279 (owner: 10Brian Wolff)
[22:02:06] <^d>	 MatmaRex: This has happened once or twice before. It's caused by a race condition and the database gets out of date.
[22:02:21] <^d>	 Fixed for 62221
[22:03:09] * AaronSchulz  can't remember what  ArticleRevisionVisibilitySet is
[22:03:45] <^d>	 It's in RevDel_RevisionList::doPostCommitUpdates()
[22:03:49] <^d>	 You use it in FlaggedRevs.
[22:08:35] <^d>	 AaronSchulz: Also, what happens when you revdel a page with only one revision?
[22:08:42] 	 (03CR) 10Spage: [C: 032] "Works on ee-flow. I have a general template comment." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101435 (owner: 10EBernhardson)
[22:08:53] 	 (03Merged) 10jenkins-bot: Only the text should prevent click-through [extensions/Flow] - 10https://gerrit.wikimedia.org/r/101435 (owner: 10EBernhardson)
[22:09:35] 	 (03PS2) 10Nemo bis: Fix #switch #default to match next (not last) named parameter. [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/87643 (owner: 10Lambdafu)
[22:09:54] 	 ^d: you can't delete the text of the current rev
[22:13:16] <^d>	 Gotcha.
[22:13:46] 	 (03CR) 10Legoktm: Add 'mediaWikiLoadComplete' measurement (031 comment) [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/100951 (owner: 10Ori.livneh)
[22:18:31] 	 (03PS4) 10Nemo bis: (bug 57106) Implement LanguageConverter for yue (Cantonese) [core] - 10https://gerrit.wikimedia.org/r/78504 (owner: 10Liangent)
[22:18:51] 	 (03CR) 10Bartosz Dziewoński: "Sounds reasonable to me." [core] - 10https://gerrit.wikimedia.org/r/100816 (owner: 10UltrasonicNXT)
[22:19:24] 	 (03CR) 10Brian Wolff: [C: 04-1] "As I said on the bug, I personally think this is better as an extension, but I'll leave that up to other people. Ignoring that, some comme" (036 comments) [core] - 10https://gerrit.wikimedia.org/r/101443 (owner: 10leucosticte)
[22:21:00] 	 (03CR) 10Brian Wolff: "Also, on the commit message, but the Bug: XXX line as second last, immediately above the Change-Id line. That way gerrit notification bot " [core] - 10https://gerrit.wikimedia.org/r/101443 (owner: 10leucosticte)
[22:21:39] 	 (03CR) 10BryanDavis: Add 'mediaWikiLoadComplete' measurement (032 comments) [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/100951 (owner: 10Ori.livneh)
[22:27:12] 	 (03PS2) 10Ori.livneh: Add 'mediaWikiLoadComplete' measurement [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/100951 
[22:28:21] 	 (03CR) 10Gergő Tisza: "That's better, but can still be improved quite a bit. The only thing you are doing with the la variables is setting them to 0/1 and compar" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/101029 (owner: 10Inchikutty)
[22:31:23] 	 (03PS3) 10BryanDavis: Add 'mediaWikiLoadComplete' measurement [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/100951 (owner: 10Ori.livneh)
[22:31:59] 	 (03CR) 10BryanDavis: [C: 032] Add 'mediaWikiLoadComplete' measurement [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/100951 (owner: 10Ori.livneh)
[22:32:04] 	 (03Merged) 10jenkins-bot: Add 'mediaWikiLoadComplete' measurement [extensions/NavigationTiming] - 10https://gerrit.wikimedia.org/r/100951 (owner: 10Ori.livneh)
[22:33:06] 	 (03PS1) 10Chad: Respect revision deletion in CirrusSearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101447 
[22:33:22] <^d>	 manybubbles: ^
[22:33:50] 	 ^d: got it.  will review
[22:34:23] 	 nice rant
[22:35:32] <^d>	 Make sense?
[22:36:07] <^d>	 Aaron was right. You can't rev_del the *current* revision, so in order to rev_del something you have to edit it to make sure it's not the current rev. We *should* update on that edit. But paranoid. :)
[22:38:02] 	 ^d: is that hook also called when a revision is undeleted? what if just the username or edit summary are deleted?
[22:38:29] <^d>	 Well we don't store the username or edit summary.
[22:38:35] <^d>	 So we only care about rev_del on text.
[22:38:38] 	 MatmaRex: BTW, https://www.mediawiki.org/wiki/User:Jdforrester_(WMF)/common.css now dies (swallows on the ')') - related to your url() changes?
[22:38:38] <^d>	 Which can't ever be (cur)
[22:39:10] 	 right, but the hook is still run so the job is queued even if its not text, which is what you care about
[22:39:12] 	 James_F: blarghfrg. yes.
[22:39:14] 	 (sort of)
[22:39:19] 	 MatmaRex: Boo. :-(
[22:39:20] 	 it's another bug my change makes more visible
[22:39:29] 	 MatmaRex: All my magic global CSS and JS failed.
[22:39:36] 	 it's low-severity, sorry :)
[22:39:48] 	 MatmaRex: I guess I could wait a week for legoktm's extension to get pushed live, but… :-)
[22:40:01] 	 i have more fascinating things to do on friday evenings that rewriting awful regexes
[22:40:05] 	 than*
[22:40:10] 	 MatmaRex: :-P
[22:40:13] 	 :D
[22:40:21] 	 const URL_REGEX = 'url\(\s*[\'"]?(?P[^\?\)\'"]*?)(?P\?[^\)\'"]*?|)[\'"]?\s*\)';
[22:40:21] <^d>	 legoktm: If you've got feedback, leave it on gerrit, I'm tired of trying to figure out rev_del :p
[22:40:30] 	 ^d: haha sure
[22:40:43] 	 James_F: i'd have to make it like twice as long to make it sorta kinda work with parentheses or quotes in the URL
[22:40:44] <^d>	 Also, I need to repeat this for FlaggedRevs.
[22:40:50] <^d>	 dewiki only wants to index stable pages.
[22:40:58] 	 James_F: and i'd have to kill it and implement a real parser to make it always work
[22:41:16] 	 James_F: you can url-escape the parentheses, you know.
[22:41:24] 	 :|
[22:41:31] 	 MatmaRex: Yes, but that @import is on 800 wikis.
[22:41:38] 	 MatmaRex: Changing them all is a bore.
[22:41:44] 	 User%3AJdforrester%20%28WMF%29
[22:41:45] 	 yeah
[22:42:07] 	 file a bug
[22:42:31] 	 "CSSMin's url() value processing doesn't allow parentheses or quotes in the URL"
[22:42:53] 	 ResourceLoader component?
[22:43:00] 	 probably
[22:43:06] 	 yeah, i think that's where the other bug were
[22:43:11] 	 bugs*
[22:43:53] * James_F  nods.
[22:44:18] 	 maybe i'll get around to it some time when i will feel too happy and will want to change that
[22:44:36] 	 (03CR) 10Legoktm: [C: 04-1] "If I understand how the hook works, this will be called even if a user just deletes the username or edit summary. There should be some che" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101447 (owner: 10Chad)
[22:54:26] 	 (03PS1) 10GWicke: Clean up repo for Parsoid service only [services/parsoid] - 10https://gerrit.wikimedia.org/r/101448 
[22:55:01] 	 (03CR) 10Manybubbles: [C: 032] "This is working for me." [core] - 10https://gerrit.wikimedia.org/r/99715 (owner: 10Brian Wolff)
[22:55:30] 	 (03CR) 10jenkins-bot: [V: 04-1] Add method to get entire text layer. This could be useful for search [core] - 10https://gerrit.wikimedia.org/r/99715 (owner: 10Brian Wolff)
[22:56:40] 	 (03CR) 10Subramanya Sastry: [C: 032] Clean up repo for Parsoid service only [services/parsoid] - 10https://gerrit.wikimedia.org/r/101448 (owner: 10GWicke)
[22:56:47] 	 (03PS3) 10Manybubbles: Begin indexing file text from pdf/djvu files [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 (owner: 10Chad)
[22:59:06] 	 manybubbles: Do you want me to rebase that change? or are you already doing that?
[22:59:07] 	 (03CR) 10Manybubbles: "Amended to add instructions for setting up the PdfHandler in the testing README and added a sample PDF. Also, if the PdfHandler isn't ins" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/101252 (owner: 10Chad)
[22:59:57] 	 bawolff: I can do it
[23:00:03] 	 ok
[23:01:30] 	 (03CR) 10Subramanya Sastry: [V: 032] "Force merging for now till we get jenkins configured on the new repo." [services/parsoid] - 10https://gerrit.wikimedia.org/r/101448 (owner: 10GWicke)
[23:02:36] 	 Anyone other than Chad and Yuvi (both away) able to get grrrit-wm to restart with new config?
[23:02:55] * aude  can :)
[23:03:12] 	 (03PS3) 10Manybubbles: Add method to get entire text layer. This could be useful for search [core] - 10https://gerrit.wikimedia.org/r/99715 (owner: 10Brian Wolff)
[23:03:30] 	 aude: Would be muchly obliged. :-)
[23:04:05] 	 bawolff: still look good?
[23:04:26] 	 legoktm: Thanks.
[23:04:27] 	 yep
[23:04:35] 	 np
[23:04:52] 	 oh, oops
[23:04:55] 	 sorry aude 
[23:05:06] 	 oko :)
[23:05:09] 	 ok
[23:05:39] 	 (03CR) 10Manybubbles: [C: 032] "Self merge after simple rebase." [core] - 10https://gerrit.wikimedia.org/r/99715 (owner: 10Brian Wolff)
[23:06:21] 	 aude: Thanks. ;-)
[23:06:51] 	 manybubbles: btw, if you notice that some djvu files have a bunch of literal '\n' (like an actual \ followed by an actual n, where there should be a newline) - its due to an issue I fixed in gerrit change 99710, but older files will still probably have that until next time someone purges them
[23:07:28] 	 bawolff: cool.  that would make them not work as well.  'cause the n would be stuck on the beginning of the next word
[23:07:42] 	 thanks legoktm 
[23:07:45] 	 but we're not sure what we're going to do with the text yet.  still poking ^d abou that
[23:08:00] 	 logging out now, though:)  good night everyone, or whatever time it is for you
[23:08:31] 	 manybubbles: If its a big deal, someone could run a maintinance script to purge file metadata for djvu, there's probably not a super large amount of them, so it probably wouldn't be a big deal
[23:08:34] 	 (03Merged) 10jenkins-bot: Add method to get entire text layer. This could be useful for search [core] - 10https://gerrit.wikimedia.org/r/99715 (owner: 10Brian Wolff)